[jira] [Comment Edited] (MNG-7049) Version range resolution downloads all poms, not just the highest version
[ https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285640#comment-17285640 ] Xiang Li edited comment on MNG-7049 at 2/17/21, 5:53 AM: - After some digging through the code, I found that it process every dependency of a certain version [[range|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L404],],] I wonder if it is intended while it can directly return the highest version. Appreciate any guidance. If not return whole verion set [here|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L682], it seems stop those pom downloads. [~michael-o] was (Author: xiangli1996): After some digging through the code, I found that it process every dependency of a certain version [[range|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L404],],] I wonder if it is intended while it can directly return the highest version. Appreciate any guidance. If not return whole verions [here|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L682], it seems reduce those pom downloads. [~michael-o] > Version range resolution downloads all poms, not just the highest version > - > > Key: MNG-7049 > URL: https://issues.apache.org/jira/browse/MNG-7049 > Project: Maven > Issue Type: Improvement > Components: core >Reporter: Moti Nisenson-Ken >Priority: Major > > When specifying a version range for a dependency, maven will download and try > to resolve all poms in that range which satisfy the range. The usage however > is only to use the highestVersion. This causes two issues: > # Performance - it's downloading numerous poms that aren't needed. > # Fragility - if the version range covers any "bad" poms, then the build > will fail. For example, consider that for a specific version, the parent of a > pom is not present in the repository. This is enough to fail any build with a > version range covering that specific version, as the range resolution stage > will not complete. This is particularly harmful when that version would not > be selected as the highest, anyway. > Recommend to have a system property to control the desired behavior - it > should be possible to short-circuit loading all the versions and to just to > load the highest version. > For another user report of this see: > [https://stackoverflow.com/questions/25047859/restrict-maven-to-not-download-all-poms] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MNG-7049) Version range resolution downloads all poms, not just the highest version
[ https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285640#comment-17285640 ] Xiang Li edited comment on MNG-7049 at 2/17/21, 5:50 AM: - After some digging through the code, I found that it process every dependency of a certain version [[range|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L404],],] I wonder if it is intended while it can directly return the highest version. Appreciate any guidance. If not return whole verions [here|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L682], it seems reduce those pom downloads. [~michael-o] was (Author: xiangli1996): After some digging through the code, I found that it process every dependency of a certain version [[range|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L404],|#L404],] I wonder if it is intended while it can directly return the highest version. Appreciate any guidance. [~michael-o] > Version range resolution downloads all poms, not just the highest version > - > > Key: MNG-7049 > URL: https://issues.apache.org/jira/browse/MNG-7049 > Project: Maven > Issue Type: Improvement > Components: core >Reporter: Moti Nisenson-Ken >Priority: Major > > When specifying a version range for a dependency, maven will download and try > to resolve all poms in that range which satisfy the range. The usage however > is only to use the highestVersion. This causes two issues: > # Performance - it's downloading numerous poms that aren't needed. > # Fragility - if the version range covers any "bad" poms, then the build > will fail. For example, consider that for a specific version, the parent of a > pom is not present in the repository. This is enough to fail any build with a > version range covering that specific version, as the range resolution stage > will not complete. This is particularly harmful when that version would not > be selected as the highest, anyway. > Recommend to have a system property to control the desired behavior - it > should be possible to short-circuit loading all the versions and to just to > load the highest version. > For another user report of this see: > [https://stackoverflow.com/questions/25047859/restrict-maven-to-not-download-all-poms] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MNG-7049) Version range resolution downloads all poms, not just the highest version
[ https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285640#comment-17285640 ] Xiang Li edited comment on MNG-7049 at 2/17/21, 5:43 AM: - After some digging through the code, I found that it process every dependency of a certain version [[range|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L404],|#L404],] I wonder if it is intended while it can directly return the highest version. Appreciate any guidance. [~michael-o] was (Author: xiangli1996): After some digging through the code, I found that it process every dependency of a certain version range[[https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L404],] I wonder if it is intended while it can directly return the highest version. Appreciate any guidance. [~michael-o] > Version range resolution downloads all poms, not just the highest version > - > > Key: MNG-7049 > URL: https://issues.apache.org/jira/browse/MNG-7049 > Project: Maven > Issue Type: Improvement > Components: core >Reporter: Moti Nisenson-Ken >Priority: Major > > When specifying a version range for a dependency, maven will download and try > to resolve all poms in that range which satisfy the range. The usage however > is only to use the highestVersion. This causes two issues: > # Performance - it's downloading numerous poms that aren't needed. > # Fragility - if the version range covers any "bad" poms, then the build > will fail. For example, consider that for a specific version, the parent of a > pom is not present in the repository. This is enough to fail any build with a > version range covering that specific version, as the range resolution stage > will not complete. This is particularly harmful when that version would not > be selected as the highest, anyway. > Recommend to have a system property to control the desired behavior - it > should be possible to short-circuit loading all the versions and to just to > load the highest version. > For another user report of this see: > [https://stackoverflow.com/questions/25047859/restrict-maven-to-not-download-all-poms] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7049) Version range resolution downloads all poms, not just the highest version
[ https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285640#comment-17285640 ] Xiang Li commented on MNG-7049: --- After some digging through the code, I found that it process every dependency of a certain version range[[https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L404],] I wonder if it is intended while it can directly return the highest version. Appreciate any guidance. [~michael-o] > Version range resolution downloads all poms, not just the highest version > - > > Key: MNG-7049 > URL: https://issues.apache.org/jira/browse/MNG-7049 > Project: Maven > Issue Type: Improvement > Components: core >Reporter: Moti Nisenson-Ken >Priority: Major > > When specifying a version range for a dependency, maven will download and try > to resolve all poms in that range which satisfy the range. The usage however > is only to use the highestVersion. This causes two issues: > # Performance - it's downloading numerous poms that aren't needed. > # Fragility - if the version range covers any "bad" poms, then the build > will fail. For example, consider that for a specific version, the parent of a > pom is not present in the repository. This is enough to fail any build with a > version range covering that specific version, as the range resolution stage > will not complete. This is particularly harmful when that version would not > be selected as the highest, anyway. > Recommend to have a system property to control the desired behavior - it > should be possible to short-circuit loading all the versions and to just to > load the highest version. > For another user report of this see: > [https://stackoverflow.com/questions/25047859/restrict-maven-to-not-download-all-poms] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-indexer] dependabot[bot] opened a new pull request #91: Bump version.spring from 5.3.2 to 5.3.4
dependabot[bot] opened a new pull request #91:
URL: https://github.com/apache/maven-indexer/pull/91
Bumps `version.spring` from 5.3.2 to 5.3.4.
Updates `spring-beans` from 5.3.2 to 5.3.4
Release notes
Sourced from https://github.com/spring-projects/spring-framework/releases;>spring-beans's
releases.
v5.3.4
:star: New Features
Enforce standard Java types in YamlProcessor https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26530;>#26530
Fall back on awaitToBodylessEntity when awaitBody is used with Unit https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/26504;>#26504
Expose HttpHandler Decoration as a bean https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/26502;>#26502
Inefficient reflection operations for destroy method determination https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26498;>#26498
Missing CORS Headers for Static Resources in WebFlux https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26495;>#26495
Ignore null Locale in MockHttpServletResponse https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26493;>#26493
Ignore null header value in MockHttpServletResponse https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26488;>#26488
Add application/vnd.google.protobuf to ProtobufCodecSupport https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/26487;>#26487
Expose ChannelId in ReactorNettyWebsocketSession https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26485;>#26485
Exclude User Destination Messages in Broker Message Handler https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26474;>#26474
UriComponentsBuilder '{' '}' may not be encoded although invalid
characters https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26466;>#26466
Support BASE64 file name encoding in ContentDisposition https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/26463;>#26463
Allow AbstractEnvironment subclasses to use custom
ConfigurablePropertyResolver and MutablePropertySources https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26462;>#26462
Allow AbstractEnvironment to bypass active/default properties https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26461;>#26461
No way to affect response when unhandled exceptions thrown from
ForwardedHeaderTransformer https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26459;>#26459
Support for servletPath prefix with PathPatternParser in Spring MVC https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26445;>#26445
Add unique number to WebFlux log prefix for Undertow server https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26430;>#26430
Provide a way to modify RequestMappingInfo conditions https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26428;>#26428
Provide better lifecyle for WebMvcConfigurer.configurePathMatch https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26427;>#26427
Fail early FactoryBean instantiation for LinkageError https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/26425;>#26425
Unwrap DataSource hidden behind InfrastructureProxy in
SqlScriptsTestExecutionListener https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26422;>#26422
Close mapping streams after the ValidatorFactory has been built in
LocalValidatorFactoryBean https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/26418;>#26418
Introduce public defineClass variant for SmartClassLoader
implementations https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26403;>#26403
Return 415 for form data via @RequestBody in WebFlux https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26386;>#26386
Make set operator for MapSqlParameterSource accept nullable value https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/26288;>#26288
Provide API to Expose the Handling of PreFlight Requests in WebFlux https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26257;>#26257
Configure the ObjectMappers to Use for a Class by MediaType https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26212;>#26212
Jetty 10 Support https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/26123;>#26123
Introduce a NativeDetector utility class https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25795;>#25795
Add overload for MockRestServiceServer.verify with a timeout
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #336: Add more documentation and verification for failOnFlakeCount
Tibor17 commented on a change in pull request #336: URL: https://github.com/apache/maven-surefire/pull/336#discussion_r57727 ## File path: maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java ## @@ -257,6 +257,8 @@ /** * Set this to a value greater than 0 to fail the whole test set if the cumulative number of flakes reaches * this threshold. Set to 0 to allow an unlimited number of flakes. + * + * @since 3.0-M6 Review comment: pls rename it to `3.0.0-M6`, thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MASSEMBLY-950) assemblies without identifier
[ https://issues.apache.org/jira/browse/MASSEMBLY-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MASSEMBLY-950. Resolution: Not A Problem http://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html#appendAssemblyId > assemblies without identifier > - > > Key: MASSEMBLY-950 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-950 > Project: Maven Assembly Plugin > Issue Type: Improvement > Components: component descriptor >Affects Versions: 3.3.0 >Reporter: Ernst Reissner >Priority: Major > > I have an application where I use the assembly plugin to create a package > file for computation software called octave. > It is just a file artifactId-version.tar.gz with a predefined folder > structure. > The problem is that the assembly plugin doesnt do without an assembly > identifier. > Then the result is something like artifactId-version-assId.tar.gz. > Strictly speaking, octave needs the first kind of name without assId. > My workaround is to copy xxx-assId.tar.gz to xxx.tar.gz > but then the install plugin fails expecting still xxx-assId.tar.gz. > My question is now whether it is possible to allow empty assid > in case there is a single assembly only. > This would solve my problem. > The other way to solve is, maybe to understand how the install plugin finds > out what to install. > Does the assembly plugin pass any kind of information?? > I cannot imagine. > Help, in any way, very much appreciated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] michael-o commented on a change in pull request #446: [MNG-6511] - Optional project selection
michael-o commented on a change in pull request #446:
URL: https://github.com/apache/maven/pull/446#discussion_r577151442
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumptionDataRepository
buildResumptionDataRep
{
List result = projects;
-if ( !request.getExcludedProjects().isEmpty() )
+ProjectActivation projectActivation = request.getProjectActivation();
+Set requiredSelectors =
projectActivation.getRequiredInactiveProjectSelectors();
+Set optionalSelectors =
projectActivation.getOptionalInactiveProjectSelectors();
+if ( !requiredSelectors.isEmpty() || !optionalSelectors.isEmpty() )
{
-File reactorDirectory = getReactorDirectory( request );
+Set excludedProjects = new HashSet<>(
requiredSelectors.size() + optionalSelectors.size() );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, requiredSelectors, true ) );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, optionalSelectors, false ) );
Review comment:
Fixed the symptom. That's what I understand and it should carry a
comment about that. One should explore the "No goal..." issue later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on a change in pull request #446: [MNG-6511] - Optional project selection
MartinKanters commented on a change in pull request #446:
URL: https://github.com/apache/maven/pull/446#discussion_r577123679
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumptionDataRepository
buildResumptionDataRep
{
List result = projects;
-if ( !request.getExcludedProjects().isEmpty() )
+ProjectActivation projectActivation = request.getProjectActivation();
+Set requiredSelectors =
projectActivation.getRequiredInactiveProjectSelectors();
+Set optionalSelectors =
projectActivation.getOptionalInactiveProjectSelectors();
+if ( !requiredSelectors.isEmpty() || !optionalSelectors.isEmpty() )
{
-File reactorDirectory = getReactorDirectory( request );
+Set excludedProjects = new HashSet<>(
requiredSelectors.size() + optionalSelectors.size() );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, requiredSelectors, true ) );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, optionalSelectors, false ) );
Review comment:
True, but that's now fixed with this last commit I did, right? You will
now get the following:
```
> mvn -pl !core-it-suite,:core-it-suite validate
[INFO] Scanning for projects...
[ERROR] The project exclusion settings resulted in an empty project list,
please correct the usage of --projects/-pl ! or -
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MASSEMBLY-950) assemblies without identifier
Ernst Reissner created MASSEMBLY-950: Summary: assemblies without identifier Key: MASSEMBLY-950 URL: https://issues.apache.org/jira/browse/MASSEMBLY-950 Project: Maven Assembly Plugin Issue Type: Improvement Components: component descriptor Affects Versions: 3.3.0 Reporter: Ernst Reissner I have an application where I use the assembly plugin to create a package file for computation software called octave. It is just a file artifactId-version.tar.gz with a predefined folder structure. The problem is that the assembly plugin doesnt do without an assembly identifier. Then the result is something like artifactId-version-assId.tar.gz. Strictly speaking, octave needs the first kind of name without assId. My workaround is to copy xxx-assId.tar.gz to xxx.tar.gz but then the install plugin fails expecting still xxx-assId.tar.gz. My question is now whether it is possible to allow empty assid in case there is a single assembly only. This would solve my problem. The other way to solve is, maybe to understand how the install plugin finds out what to install. Does the assembly plugin pass any kind of information?? I cannot imagine. Help, in any way, very much appreciated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] michael-o commented on a change in pull request #446: [MNG-6511] - Optional project selection
michael-o commented on a change in pull request #446:
URL: https://github.com/apache/maven/pull/446#discussion_r577076081
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumptionDataRepository
buildResumptionDataRep
{
List result = projects;
-if ( !request.getExcludedProjects().isEmpty() )
+ProjectActivation projectActivation = request.getProjectActivation();
+Set requiredSelectors =
projectActivation.getRequiredInactiveProjectSelectors();
+Set optionalSelectors =
projectActivation.getOptionalInactiveProjectSelectors();
+if ( !requiredSelectors.isEmpty() || !optionalSelectors.isEmpty() )
{
-File reactorDirectory = getReactorDirectory( request );
+Set excludedProjects = new HashSet<>(
requiredSelectors.size() + optionalSelectors.size() );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, requiredSelectors, true ) );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, optionalSelectors, false ) );
Review comment:
I can't tell what the correct behavior would be, but not saying no goals
given. I guess this is a separate discussion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on a change in pull request #446: [MNG-6511] - Optional project selection
MartinKanters commented on a change in pull request #446:
URL: https://github.com/apache/maven/pull/446#discussion_r577045936
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumptionDataRepository
buildResumptionDataRep
{
List result = projects;
-if ( !request.getExcludedProjects().isEmpty() )
+ProjectActivation projectActivation = request.getProjectActivation();
+Set requiredSelectors =
projectActivation.getRequiredInactiveProjectSelectors();
+Set optionalSelectors =
projectActivation.getOptionalInactiveProjectSelectors();
+if ( !requiredSelectors.isEmpty() || !optionalSelectors.isEmpty() )
{
-File reactorDirectory = getReactorDirectory( request );
+Set excludedProjects = new HashSet<>(
requiredSelectors.size() + optionalSelectors.size() );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, requiredSelectors, true ) );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, optionalSelectors, false ) );
Review comment:
I agree, but I don't think I understand how it would ideally work. Would
you want to let `-a,+:a` work the same way as `-a,+a` instead of have the
exception thrown? (last one wins)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINSTALL-170) more control over what artifacts to be installed.
Ernst Reissner created MINSTALL-170: --- Summary: more control over what artifacts to be installed. Key: MINSTALL-170 URL: https://issues.apache.org/jira/browse/MINSTALL-170 Project: Maven Install Plugin Issue Type: Improvement Components: install:install Affects Versions: 3.0.0-M1 Reporter: Ernst Reissner Maybe it is the wrong way to file a feature request but maybe this is the best way to come into contact with the development team. My problem is that I want to deploy both a jar and a tar.gz file. The latter I create with an assembly plugin. Unfortunately, the assembly plugin forces the name `artifact-version-assId.tar.gz` and offers no way to have empty assId. The tar.gz is used in another software which strictly speaking requires `artifact-version.tar.gz`. So I had the simple idea to just move `artifact-version-assId.tar.gz` to `artifact-version.tar.gz` using exec plugin in a phase before install. Well of course i want the install plugin to install now `artifact-version.tar.gz` instead of `artifact-version-assId.tar.gz`. But the install plugin still wants to use the original artifact. My somehow academical question would be how install plugin determines the artifact to be installed and to modify that info appropriately. It seems to have nothing to do with the packaging as the original tar.gz is installed also. If I need to define another kind of packaging installing other kinds of artifacts, may I reuse the install plugin Help very much appreciated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on pull request #335: [SUREFIRE-1886] Upgrade plexus-java to Version 1.0.6
Tibor17 commented on pull request #335: URL: https://github.com/apache/maven-surefire/pull/335#issuecomment-779961834 @pzygielo yes, i changed the settings yesterday, pls see https://github.com/apache/maven-surefire/commit/418aa89724442f5f03b00e0616ec6f1b31fa0bfa This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] bguerin commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r576812607
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
@slachiewicz Yes, EXACTLY !!! The test case added in my previous PR is
WRONG, and HERE, in THIS PR, I want to fix it ...
Please please, tell me what to do to get this merged and released, my team
just NEED this ...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] oehme opened a new pull request #336: Add more documentation and verification for failOnFlakeCount
oehme opened a new pull request #336: URL: https://github.com/apache/maven-surefire/pull/336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
