[GitHub] [maven-site] dependabot[bot] opened a new pull request, #305: Bump maven-enforcer-plugin from 3.0.0 to 3.1.0
dependabot[bot] opened a new pull request, #305: URL: https://github.com/apache/maven-site/pull/305 Bumps [maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.0.0 to 3.1.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases";>maven-enforcer-plugin's releases. 3.1.0 🚀 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-420";>[MENFORCER-420] - cache dependencies across rules (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/152";>#152) https://github.com/josephw";>@josephw https://issues.apache.org/jira/browse/MENFORCER-409";>[MENFORCER-409] - Log at ERROR level when is set (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/133";>#133) https://github.com/electrum";>@electrum 🐛 Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-389";>[MENFORCER-389] - Allow filtering of parent in requireReleaseDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/157";>#157) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-421";>[MENFORCER-421] - Use currently build artifacts in IT tests (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/159";>#159) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-402";>[MENFORCER-402] - fix provided dependencies in RequireUpperBoundDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/140";>#140) https://github.com/subes";>@subes 📦 Dependency updates Bump mockito.version from 4.6.0 to 4.6.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/161";>#161) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.23.0 to 3.23.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/160";>#160) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.22.0 to 3.23.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.5.1 to 4.6.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/156";>#156) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MENFORCER-419";>[MENFORCER-419] - Upgrade Maven to 3.2.5 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/154";>#154) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-418";>[MENFORCER-418] - Upgrade Parent to 36 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/153";>#153) https://github.com/slawekjaranowski";>@slawekjaranowski Bump plexus-utils from 3.4.1 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/151";>#151) https://github.com/dependabot";>@dependabot Bump maven-dependency-tree from 3.1.0 to 3.1.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/150";>#150) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.3.1 to 3.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/147";>#147) https://github.com/dependabot";>@dependabot Bump maven-surefire-plugin from 3.0.0-M5 to 3.0.0-M6 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/148";>#148) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.2.2 to 3.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/149";>#149) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.4.0 to 4.5.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/146";>#146) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.21.0 to 3.22.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/134";>#134) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.2.0 to 4.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/142";>#142) https://github.com/dependabot";>@dependabot Bump maven-jxr-plugin from 3.1.1 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/143";>#143) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/144";>#144) https://github.com/dependabot";>@dependabot Bump mrm-maven-plugin from 1.2.0 to 1.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/129";>#129) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.1.0 to 4.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/132";>#132) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.2.0 to 3.3.1 (https://github-redirect.d
[GitHub] [maven] dependabot[bot] closed pull request #751: Bump jetty from 6.1.4 to 6.1.17 in /maven-core/src/test/resources-project-builder/foo/sub
dependabot[bot] closed pull request #751: Bump jetty from 6.1.4 to 6.1.17 in /maven-core/src/test/resources-project-builder/foo/sub URL: https://github.com/apache/maven/pull/751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] dependabot[bot] commented on pull request #751: Bump jetty from 6.1.4 to 6.1.17 in /maven-core/src/test/resources-project-builder/foo/sub
dependabot[bot] commented on PR #751: URL: https://github.com/apache/maven/pull/751#issuecomment-1152784588 Superseded by #753. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] dependabot[bot] opened a new pull request, #753: Bump jetty from 6.1.4 to 6.1.23 in /maven-core/src/test/resources-project-builder/foo/sub
dependabot[bot] opened a new pull request, #753: URL: https://github.com/apache/maven/pull/753 Bumps jetty from 6.1.4 to 6.1.23. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] dependabot[bot] closed pull request #183: Bump plexus-archiver from 4.2.2 to 4.2.7
dependabot[bot] closed pull request #183: Bump plexus-archiver from 4.2.2 to 4.2.7 URL: https://github.com/apache/maven-dependency-plugin/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] dependabot[bot] commented on pull request #183: Bump plexus-archiver from 4.2.2 to 4.2.7
dependabot[bot] commented on PR #183: URL: https://github.com/apache/maven-dependency-plugin/pull/183#issuecomment-1152767409 Superseded by #222. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #222: Bump plexus-archiver from 4.2.2 to 4.3.0
dependabot[bot] opened a new pull request, #222: URL: https://github.com/apache/maven-dependency-plugin/pull/222 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.2.2 to 4.3.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/releases";>plexus-archiver's releases. Plexus Archiver 4.2.7 🚀 New features and improvements Respect order of META-INF/ and META-INF/MANIFEST.MF entries in a JAR file (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/189";>#189) https://github.com/michael-o";>@michael-o Plexus Archiver 4.2.6 This release updates commons-compress to 1.21 which contains security fixed for https://github.com/advisories/GHSA-xqfj-vm6h-2x34";>CVE-2021-35517 https://github.com/advisories/GHSA-crv7-7245-f45f";>CVE-2021-35516 https://github.com/advisories/GHSA-7hfm-57qf-j43q";>CVE-2021-35515 https://github.com/advisories/GHSA-mc84-pj99-q6hh";>CVE-2021-36090 This version requires Java 8 as minimum (commons-compress 1.21 requires Java 8). 🚀 New features and improvements FileInputStream, FileOutputStream, FileReader and FileWriter are no longer used (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/183";>#183) https://github.com/jorsol";>@jorsol Code cleanup (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/172";>#172) https://github.com/olamy";>@olamy 📦 Dependency updates Bump plexus from 7 to 8 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/179";>#179) https://github.com/dependabot";>@dependabot Bump plexus-utils from 3.3.0 to 3.4.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/181";>#181) https://github.com/dependabot";>@dependabot Bump commons-compress from 1.20 to 1.21 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/177";>#177) https://github.com/dependabot";>@dependabot Plexus Archiver 4.2.5 🚀 New features and improvements Speed improvements (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/157";>#157) https://github.com/gnodet";>@gnodet 🐛 Bug Fixes Fix use of a mismatching Unicode path extra field in zip unarchiving (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/167";>#167) https://github.com/cwalther";>@cwalther In some cases zip archiver may update the file path but not the Unicode path extra field. This would result in Plexus Archiver extracting the file using wrong (obsolete) path. Now Plexus Archiver follows the specification and in this case will ignore the extra filed and extract the file in the correct location. 📦 Dependency updates Bump plexus from 6.5 to 7 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump xz from 1.8 to 1.9 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/165";>#165) https://github.com/dependabot";>@dependabot Plexus Archiver 4.2.4 🐛 Bug Fixes Fix unjustified warning about casing for directory entries (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/155";>#155) https://github.com/mthmulders";>@mthmulders Commits https://github.com/codehaus-plexus/plexus-archiver/commit/88d132ad0cb904d1786c9a4ec4b8318ac66f3864";>88d132a [maven-release-plugin] prepare release plexus-archiver-4.3.0 https://github.com/codehaus-plexus/plexus-archiver/commit/e135a2b6671fa098b429bc28eb178af256326b79";>e135a2b Bump plexus from 8 to 10 https://github.com/codehaus-plexus/plexus-archiver/commit/e8eecf29c068c20dca8a126a7c7d28a184e8e318";>e8eecf2 switch build badge from Travis to GH https://github.com/codehaus-plexus/plexus-archiver/commit/d715d6437afbb75c913d0e8d76ef2e00b8a0e322";>d715d64 Bump release-drafter/release-drafter from 5.19.0 to 5.20.0 https://github.com/codehaus-plexus/plexus-archiver/commit/50c5fc07ae7e84e7d9a33fe22e2e409ec6aa8a08";>50c5fc0 Rename setTime method to setZipEntryTime https://github.com/codehaus-plexus/plexus-archiver/commit/ee2f99da1d8fc90b5a9c9722176c0c8b88ea";>ee2f99d Bump plexus-io from 3.2.0 to 3.3.1 https://github.com/codehaus-plexus/plexus-archiver/commit/c2a06d64b76458d12cc4e7fab9b9b82cbd686cf5";>c2a06d6 Bump plexus-utils from 3.4.1 to 3.4.2 https://github.com/codehaus-plexus/plexus-archiver/commit/6d0cb3607a7c35e12ddaa9a133885caa777b177d";>6d0cb36 remove old release tag value https://github.com/codehaus-plexus/plexus-archiver/commit/581e306276b780092b43cd5b9a230f9960fa27c2";>581e306 Convert InputStreamSupplier to lambdas https://github.com/codehaus-plexus/plexus-archiver/commit/7eb5a660a9ccb2968ce4f172baaa949c72e87f87";>7eb5a66 Delete codeql-analysis.yml Additional commits viewabl
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #34: Mskins 191 dynamic library retrieval
stevecrox commented on PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#issuecomment-1152765601 Making progress, the breadcrumb section has been pulled into the nav along with a few other bits since we want it embedded along with it. This has lead to some movement around the template. I'm also using the elements to generate the effect I want, for example all buttons/menus are within the navbar-collpase so they should shrink behind a hamburger menu cleanly. The submenu behavoir has broken (it looks fine, will investigate soon). mskins-24_topbar is my current focus because something really odd is happening in the construction and I need to understand that. There have been a few CSS class updates. I've been moving between mskins-10 and topbar, I'm pretty happy with topbar atm. mskins-10 sidebar is the next challenge. The use of Nav-items in it and the topbar causes a conflict in padding/margins. I need to figure out an approach which works with the recommended bootstrap styles. I have been using Bootstrap 3.3 and Bootstrap 5 examples, there is a clear evolution from 3 -> 5 and the structure of 3 seems to be compatible with 5 (and vice verse) so I figure from a technical debt perspective the closer I can get the easier for long term upgrades - https://getbootstrap.com/docs/3.3/examples/navbar-fixed-top/ - https://getbootstrap.com/docs/5.0/examples/navbar-fixed/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MPOM-323) Upgrade fluido skin to 1.11.0
[ https://issues.apache.org/jira/browse/MPOM-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-323: - Fix Version/s: ASF-27 MAVEN-37 > Upgrade fluido skin to 1.11.0 > - > > Key: MPOM-323 > URL: https://issues.apache.org/jira/browse/MPOM-323 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf, maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-27, MAVEN-37 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (MPOM-323) Upgrade fluido skin to 1.11.0
[ https://issues.apache.org/jira/browse/MPOM-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MPOM-323: Assignee: Slawomir Jaranowski > Upgrade fluido skin to 1.11.0 > - > > Key: MPOM-323 > URL: https://issues.apache.org/jira/browse/MPOM-323 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf, maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MPOM-323) Upgrade fluido skin to 1.11.0
Slawomir Jaranowski created MPOM-323: Summary: Upgrade fluido skin to 1.11.0 Key: MPOM-323 URL: https://issues.apache.org/jira/browse/MPOM-323 Project: Maven POMs Issue Type: Dependency upgrade Components: asf, maven Reporter: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MPOM-322) Add link to ASF privacy policy
[ https://issues.apache.org/jira/browse/MPOM-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-322: - Fix Version/s: MAVEN-37 > Add link to ASF privacy policy > -- > > Key: MPOM-322 > URL: https://issues.apache.org/jira/browse/MPOM-322 > Project: Maven POMs > Issue Type: New Feature > Components: asf, maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-27, MAVEN-37 > > > Maven sites should have link to > [https://privacy.apache.org/policies/privacy-policy-public.html] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MPOM-322) Add link to ASF privacy policy
[ https://issues.apache.org/jira/browse/MPOM-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-322: - Fix Version/s: ASF-27 > Add link to ASF privacy policy > -- > > Key: MPOM-322 > URL: https://issues.apache.org/jira/browse/MPOM-322 > Project: Maven POMs > Issue Type: New Feature > Components: asf, maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-27 > > > Maven sites should have link to > [https://privacy.apache.org/policies/privacy-policy-public.html] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (MPOM-322) Add link to ASF privacy policy
[ https://issues.apache.org/jira/browse/MPOM-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MPOM-322: Assignee: Slawomir Jaranowski > Add link to ASF privacy policy > -- > > Key: MPOM-322 > URL: https://issues.apache.org/jira/browse/MPOM-322 > Project: Maven POMs > Issue Type: New Feature > Components: maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > > Maven sites should have link to > [https://privacy.apache.org/policies/privacy-policy-public.html] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MPOM-322) Add link to ASF privacy policy
[ https://issues.apache.org/jira/browse/MPOM-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-322: - Component/s: asf > Add link to ASF privacy policy > -- > > Key: MPOM-322 > URL: https://issues.apache.org/jira/browse/MPOM-322 > Project: Maven POMs > Issue Type: New Feature > Components: asf, maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > > Maven sites should have link to > [https://privacy.apache.org/policies/privacy-policy-public.html] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-filtering] cstamas commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
cstamas commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894851956
##
pom.xml:
##
@@ -141,21 +136,39 @@
2.2
test
+
+ org.slf4j
+ slf4j-simple
+ ${slf4jVersion}
+ test
+
+
+ org.sonatype.plexus
+ plexus-build-api
+ ${plexusBuildApiVersion}
+ test
+ tests
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.plexus
+ 0.3.0.M1
+ test
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.inject
+ 0.3.0.M1
Review Comment:
Just figured: after this there is NO NEED to keep it sync with maven (all is
test scope), hence, I removed the property alltogether, using current version
from parent POM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEPLOY-293) Maven deploy fails with 401 Unauthorized when using £ in password
[
https://issues.apache.org/jira/browse/MDEPLOY-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552942#comment-17552942
]
Nélson Cunha commented on MDEPLOY-293:
--
Here you go:
{noformat}
PS C:\Users\ncunha\Documents\XXX>
$env:MAVEN_OPTS='-Dorg.slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient=debug'
PS C:\Users\ncunha\Documents\XXX> mvn deploy
[INFO] Scanning for projects...
[INFO]
[INFO] Reactor Build Order:
[INFO]
[INFO] XXX [pom]
[INFO] XXX [jar]
[INFO] XXX [jar]
[INFO] XXX [jar]
[INFO] XXX [jar]
[INFO] XXX [jar]
[INFO]
[INFO] -< xxx.xxx.xxx:xxx-xxx-xxx >-
[INFO] Building XXX 4.0.0-SNAPSHOT [1/6]
[INFO] [ pom ]-
[INFO]
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ xxx-xxx-xxx
---
[INFO] Installing C:\Users\ncunha\Documents\XXX\pom.xml to
C:\Users\ncunha\.m2\repository\xxx\xxx\xxx\4.0.0-SNAPSHOT\xxx-xxx-xxx-4.0.0-SNAPSHOT.pom
[INFO]
[INFO] --- maven-deploy-plugin:3.0.0-M2:deploy (default-deploy) @ xxx-xxx-xxx
---
Downloading from nexus-snapshots:
http://xxx.xxx.com/repository/maven-snapshots/xxx/xxx/xxx/4.0.0-SNAPSHOT/maven-metadata.xml
[DEBUG] CookieSpec selected: compatibility
[DEBUG] Connection request: [route: {}->http://xxx.xxx.com:80][total available:
0; route allocated: 0 of 20; total allocated: 0 of 40]
[DEBUG] Connection leased: [id: 0][route: {}->http://xxx.xxx.com:80][total
available: 0; route allocated: 1 of 20; total allocated: 1 of 40]
[DEBUG] Opening connection {}->http://xxx.xxx.com:80
[DEBUG] Connecting to xxx.xxx.com/172.21.2.99:80
[DEBUG] Connection established 10.69.72.147:63776<->172.21.2.99:80
[DEBUG] http-outgoing-0: set socket timeout to 180
[DEBUG] Executing request GET
/repository/maven-snapshots/xxx/xxx/xxx/4.0.0-SNAPSHOT/maven-metadata.xml
HTTP/1.1
[DEBUG] Target auth state: UNCHALLENGED
[DEBUG] Proxy auth state: UNCHALLENGED
[DEBUG] http-outgoing-0 >> GET
/repository/maven-snapshots/xxx/xxx/xxx/4.0.0-SNAPSHOT/maven-metadata.xml
HTTP/1.1
[DEBUG] http-outgoing-0 >> Cache-control: no-cache
[DEBUG] http-outgoing-0 >> Pragma: no-cache
[DEBUG] http-outgoing-0 >> User-Agent: Apache-Maven/3.8.5 (Java 1.8.0_321;
Windows 10 10.0)
[DEBUG] http-outgoing-0 >> Host: xxx.xxx.com
[DEBUG] http-outgoing-0 >> Connection: Keep-Alive
[DEBUG] http-outgoing-0 >> Accept-Encoding: gzip,deflate
[DEBUG] http-outgoing-0 << HTTP/1.1 401 Unauthorized
[DEBUG] http-outgoing-0 << Date: Fri, 10 Jun 2022 19:21:21 GMT
[DEBUG] http-outgoing-0 << Server: Nexus/3.16.2-01 (OSS)
[DEBUG] http-outgoing-0 << X-Content-Type-Options: nosniff
[DEBUG] http-outgoing-0 << Content-Security-Policy: sandbox allow-forms
allow-modals allow-popups allow-presentation allow-scripts allow-top-navigation
[DEBUG] http-outgoing-0 << X-XSS-Protection: 1; mode=block
[DEBUG] http-outgoing-0 << WWW-Authenticate: BASIC realm="Sonatype Nexus
Repository Manager"
[DEBUG] http-outgoing-0 << Content-Length: 0
[DEBUG] Connection can be kept alive indefinitely
[DEBUG] Authentication required
[DEBUG] xxx.xxx.com:80 requested authentication
[DEBUG] Authentication schemes in the order of preference: [Negotiate,
Kerberos, NTLM, CredSSP, Digest, Basic]
[DEBUG] Challenge for Negotiate authentication scheme not available
[DEBUG] Challenge for Kerberos authentication scheme not available
[DEBUG] Challenge for NTLM authentication scheme not available
[DEBUG] Challenge for CredSSP authentication scheme not available
[DEBUG] Challenge for Digest authentication scheme not available
[DEBUG] Selected authentication options: [BASIC [complete=true]]
[DEBUG] http-outgoing-0: set socket timeout to 180
[DEBUG] Executing request GET
/repository/maven-snapshots/xxx/xxx/xxx/4.0.0-SNAPSHOT/maven-metadata.xml
HTTP/1.1
[DEBUG] Target auth state: CHALLENGED
[DEBUG] Generating response to an authentication challenge using basic scheme
[DEBUG] Proxy auth state: UNCHALLENGED
[DEBUG] http-outgoing-0 >> GET
/repository/maven-snapshots/xxx/xxx/xxx/4.0.0-SNAPSHOT/maven-metadata.xml
HTTP/1.1
[DEBUG] http-outgoing-0 >> Cache-control: no-cache
[DEBUG] http-outgoing-0 >> Pragma: no-cache
[DEBUG] http-outgoing-0 >> User-Agent: Apache-Maven/3.8.5 (Java 1.8.0_321;
Windows 10 10.0)
[DEBUG] http-outgoing-0 >> Host: xxx.xxx.com
[DEBUG] http-outgoing-0 >> Connection: Keep-Alive
[DEBUG] http-outgoing-0 >> Accept-Encoding: gzip,deflate
[DEBUG] http-outgoing-0 >> Authorization: Basic bmN1bmhhOsKjUGFzc3dvcmQx
[DEBUG] http-outgoing-0 << HTTP/1.1 404
xxx/xxx/xxx/4.0.0-SNAPSHOT/maven-metadata.xml
[DEBUG] http-outgoing-0 << Date: Fri, 1
[jira] [Created] (MSKINS-192) Load Twitter plugin after user request
Slawomir Jaranowski created MSKINS-192:
--
Summary: Load Twitter plugin after user request
Key: MSKINS-192
URL: https://issues.apache.org/jira/browse/MSKINS-192
Project: Maven Skins
Issue Type: New Feature
Components: Fluido Skin
Reporter: Slawomir Jaranowski
According to ASF Data Privacy we a need special integration for {{Twitter
follow button}} - called two-click method - only load them when users actively
want them to load.
https://privacy.apache.org/policies/privacy-policy-public.html - 5. Social
Media Plug-ins
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-integration-testing] jglick commented on pull request #25: Importing a BOM works even when it has the same components in dep mgmt
jglick commented on PR #25: URL: https://github.com/apache/maven-integration-testing/pull/25#issuecomment-1152614868 @gnodet @cstamas et al., is there someone to review this sort of thing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MENFORCER-412) unable to parse rule configuration
[
https://issues.apache.org/jira/browse/MENFORCER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MENFORCER-412.
-
Resolution: Not A Bug
Probably incobability with mojohaus/extra-enforcer-rules
Ii is ok with the latest version of 3.8.x
> unable to parse rule configuration
> --
>
> Key: MENFORCER-412
> URL: https://issues.apache.org/jira/browse/MENFORCER-412
> Project: Maven Enforcer Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Delany
>Priority: Major
>
> Steps to reproduce:
> # clone g...@github.com:delanym/maven.git
> # git switch maven-3.8.x
> # configure any jdk 8, 11 or 16
> # build with ./mvnw validate -e
> This builds on 3.0.0-M3 but fails on 3.0.0 with the below.
> Strangely, there isn't even a bytecode version rule in the configuration. At
> least on the project where I discovered this it was failing "correctly" on
> the banLatest rule (same error).
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce
> (enforce-bytecode-version) on project maven: Unable to parse configuration of
> mojo org.apache.mave
> n.plugins:maven-enforcer-plugin:3.0.0:enforce for parameter
> enforceBytecodeVersion: Cannot create instance of class
> org.apache.maven.plugins.enforcer.EnforceBytecodeVersion: org/apache/maven
> /shared/dependency/tree/DependencyTreeBuilderException:
> org.apache.maven.shared.dependency.tree.DependencyTreeBuilderException ->
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce
> (enforce-bytecode-version) on project maven: Unabl
> e to parse configuration of mojo
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce for parameter
> enforceBytecodeVersion: Cannot create instance of class
> org.apache.maven.plugins.e
> nforcer.EnforceBytecodeVersion
>
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
>
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
>
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
>
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>
>
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>
>
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>
>
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
>
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>
>
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
>
> at sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.lau
[GitHub] [maven-fluido-skin] hboutemy merged pull request #33: rework ITs to better integrate into skin documentation
hboutemy merged PR #33: URL: https://github.com/apache/maven-fluido-skin/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] hboutemy commented on pull request #33: rework ITs to better integrate into skin documentation
hboutemy commented on PR #33: URL: https://github.com/apache/maven-fluido-skin/pull/33#issuecomment-1152571666 thank you @slawekjaranowski -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-394) DependencyConvergence in 3.0.0 fails on provided scoped dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552860#comment-17552860
]
Slawomir Jaranowski commented on MENFORCER-394:
---
Exactly I saw the same ... if we have dependency in runtime scope, transitive
dependencies in provided are changed to runtime.
Now I don't known where is the bug in enforcer or dependency-tree component.
So we need new issues to truck it.
> DependencyConvergence in 3.0.0 fails on provided scoped dependencies
>
>
> Key: MENFORCER-394
> URL: https://issues.apache.org/jira/browse/MENFORCER-394
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0
>Reporter: Joe Barnett
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.1.0
>
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.0.0 starts to show
> convergence errors where provided scope dependencies have different versions
> than compile scope dependencies, for example:
> {code:java}
> [WARNING]
> Dependency convergence error for
> org.javassist:javassist:jar:3.28.0-GA:compile paths to dependency are:
> +-com.trib3:testing:jar:1.25-dependabot-maven-org.apache.maven.plugins-maven-enforcer-plugin-3.0.0-SNAPSHOT
> +-io.dropwizard:dropwizard-auth:jar:2.0.23:compile
> +-io.dropwizard:dropwizard-jersey:jar:2.0.23:compile
> +-org.javassist:javassist:jar:3.28.0-GA:compile
> and
> +-com.trib3:testing:jar:1.25-dependabot-maven-org.apache.maven.plugins-maven-enforcer-plugin-3.0.0-SNAPSHOT
> +-io.dropwizard:dropwizard-testing:jar:2.0.23:compile
> +-org.hibernate:hibernate-core:jar:5.5.2.Final:provided
> +-org.javassist:javassist:jar:3.27.0-GA:provided
> {code}
> Is this an intended breaking change? I don't see anything in the release
> announcement that points obviously to a change here. Seems like the provided
> version shouldn't matter as it doesn't get shipped with the artifact?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MENFORCER-394) DependencyConvergence in 3.0.0 fails on provided scoped dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552854#comment-17552854
]
Matt Nelson commented on MENFORCER-394:
---
{quote}
in this issue and corresponding PR we add filtering for exclude provided scope
and optional artifacts.
{quote}
Does that include the scopes of transitives? or is it only the scope of
directly declared dependencies?
In the reproduction, the declared dependency is runtime scope, then all of its
provided transitives are being elevated to runtime scope for the context of the
convergence analysis.
{noformat}
Dependency convergence error for
org.robolectric:android-all:jar:12-robolectric-7732740:runtime paths to
dependency are:
+-io.mattnelson:menforcer394:pom:1.0-SNAPSHOT
+-dnsjava:dnsjava:jar:3.5.1:runtime
+-org.robolectric:android-all:jar:12-robolectric-7732740:runtime (scope is
being changed from provided to runtime)
and
+-io.mattnelson:menforcer394:pom:1.0-SNAPSHOT
+-io.fabric8:kubernetes-client:jar:5.12.2:runtime
+-com.squareup.okhttp3:okhttp:jar:3.12.12:runtime
+-org.robolectric:android-all:jar:10-robolectric-5803371:runtime (scope
is being changed from provided to runtime)
{noformat}
> DependencyConvergence in 3.0.0 fails on provided scoped dependencies
>
>
> Key: MENFORCER-394
> URL: https://issues.apache.org/jira/browse/MENFORCER-394
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0
>Reporter: Joe Barnett
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.1.0
>
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.0.0 starts to show
> convergence errors where provided scope dependencies have different versions
> than compile scope dependencies, for example:
> {code:java}
> [WARNING]
> Dependency convergence error for
> org.javassist:javassist:jar:3.28.0-GA:compile paths to dependency are:
> +-com.trib3:testing:jar:1.25-dependabot-maven-org.apache.maven.plugins-maven-enforcer-plugin-3.0.0-SNAPSHOT
> +-io.dropwizard:dropwizard-auth:jar:2.0.23:compile
> +-io.dropwizard:dropwizard-jersey:jar:2.0.23:compile
> +-org.javassist:javassist:jar:3.28.0-GA:compile
> and
> +-com.trib3:testing:jar:1.25-dependabot-maven-org.apache.maven.plugins-maven-enforcer-plugin-3.0.0-SNAPSHOT
> +-io.dropwizard:dropwizard-testing:jar:2.0.23:compile
> +-org.hibernate:hibernate-core:jar:5.5.2.Final:provided
> +-org.javassist:javassist:jar:3.27.0-GA:provided
> {code}
> Is this an intended breaking change? I don't see anything in the release
> announcement that points obviously to a change here. Seems like the provided
> version shouldn't matter as it doesn't get shipped with the artifact?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (SUREFIRE-2058) Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging
[
https://issues.apache.org/jira/browse/SUREFIRE-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552812#comment-17552812
]
Richard Harris edited comment on SUREFIRE-2058 at 6/10/22 4:10 PM:
---
The consequence of this is quite significant - we have just upgraded to
3.0.0-M6 from 3.0.0-M3 and have found that some test goals (with JUnit4 tests)
have been marked as passing even though there are test failures, in each
problematic case this warning was produced, but it doesn't cause a failure and
means the actual results are hidden.
was (Author: JIRAUSER290819):
The consequence of this is quite significant - we have just upgraded to
3.0.0-M6 from 3.0.0-M3 and have found that test goals have been marked as
passing even though there are test failures, in each case this warning was
produced, but it doesn't cause a failure and means the actual results are
hidden.
> Corrupted STDOUT by directly writing to native stream in forked JVM 1 with
> UTF-8 console logging
>
>
> Key: SUREFIRE-2058
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2058
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Zoltan Meze
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> With 3.0.0-M6 surefire and slf4j + logback, most test runs end up with:
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1. {code}
> This only affects *3.0.0-M6* (3.0.0-M5 version is working fine in test
> project).
>
> After some digging, there are two different scenarios (most likely caused by
> the same issue):
> * 2-byte character at position 1023 (or N * 1024 - 1) in log message is
> causing the following warning
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1.
> {code}
> To reproduce this issue logback (with slf4j) should be used.
> Not able to reproduce with System.out.println.
> * 4-byte character at position 1023 (or N * 1024 - 1) in log message.
> Can be reproduced with System.out.println (logback not required in this case).
> This blocks surefire entirely at (from jstack):
> {code:java}
> "fork-1-event-thread" #30 daemon prio=5 os_prio=0 cpu=32350.09ms
> elapsed=32.94s tid=0x7ff8292d7800 nid=0x3caef runnable
> [0x7ff7876f6000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.decodeString(AbstractStreamDecoder.java:350)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:322)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:196)
> at
> org.apache.maven.surefire.stream.EventDecoder.decode(EventDecoder.java:176)
> at
> org.apache.maven.plugin.surefire.extensions.EventConsumerThread.run(EventConsumerThread.java:73)
> {code}
>
> Project with reproducible tests (for both scenarios, more in README):
> [https://github.com/zoltanmeze/surefire-corrupted-channel]
>
> One workaround on M6 for now is to use different charset (instead of default
> UTF-8) or limit message size.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MENFORCER-394) DependencyConvergence in 3.0.0 fails on provided scoped dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552818#comment-17552818
]
Slawomir Jaranowski commented on MENFORCER-394:
---
[~MattNelson] in this issue and corresponding PR we add filtering for exclude
provided scope and optional artifacts.
https://github.com/apache/maven-enforcer/pull/102/files#diff-830acc044bf81179966c7a9bb6cb4750603d7f5df74c6fc9ad6d76d770c9b8e1R86-R88
Your case is a little different - you have conflict on artifacts with runtime
scope.
Please create new issue for runtime scope problem - it needs more investigate.
> DependencyConvergence in 3.0.0 fails on provided scoped dependencies
>
>
> Key: MENFORCER-394
> URL: https://issues.apache.org/jira/browse/MENFORCER-394
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0
>Reporter: Joe Barnett
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.1.0
>
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.0.0 starts to show
> convergence errors where provided scope dependencies have different versions
> than compile scope dependencies, for example:
> {code:java}
> [WARNING]
> Dependency convergence error for
> org.javassist:javassist:jar:3.28.0-GA:compile paths to dependency are:
> +-com.trib3:testing:jar:1.25-dependabot-maven-org.apache.maven.plugins-maven-enforcer-plugin-3.0.0-SNAPSHOT
> +-io.dropwizard:dropwizard-auth:jar:2.0.23:compile
> +-io.dropwizard:dropwizard-jersey:jar:2.0.23:compile
> +-org.javassist:javassist:jar:3.28.0-GA:compile
> and
> +-com.trib3:testing:jar:1.25-dependabot-maven-org.apache.maven.plugins-maven-enforcer-plugin-3.0.0-SNAPSHOT
> +-io.dropwizard:dropwizard-testing:jar:2.0.23:compile
> +-org.hibernate:hibernate-core:jar:5.5.2.Final:provided
> +-org.javassist:javassist:jar:3.27.0-GA:provided
> {code}
> Is this an intended breaking change? I don't see anything in the release
> announcement that points obviously to a change here. Seems like the provided
> version shouldn't matter as it doesn't get shipped with the artifact?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (SUREFIRE-2058) Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging
[
https://issues.apache.org/jira/browse/SUREFIRE-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552812#comment-17552812
]
Richard Harris edited comment on SUREFIRE-2058 at 6/10/22 3:33 PM:
---
The consequence of this is quite significant - we have just upgraded to
3.0.0-M6 from 3.0.0-M53and have found that test goals have been marked as
passing even though there are test failures, in each case this warning was
produced, but it doesn't cause a failure and means the actual results are
hidden.
was (Author: JIRAUSER290819):
The consequence of this is quite significant - we have just upgraded to
3.0.0-M6 from 3.0.0-M5 and have found that test goals have been marked as
passing even though there are test failures, in each case this warning was
produced, but it doesn't cause a failure and means the actual results are
hidden.
> Corrupted STDOUT by directly writing to native stream in forked JVM 1 with
> UTF-8 console logging
>
>
> Key: SUREFIRE-2058
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2058
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Zoltan Meze
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> With 3.0.0-M6 surefire and slf4j + logback, most test runs end up with:
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1. {code}
> This only affects *3.0.0-M6* (3.0.0-M5 version is working fine in test
> project).
>
> After some digging, there are two different scenarios (most likely caused by
> the same issue):
> * 2-byte character at position 1023 (or N * 1024 - 1) in log message is
> causing the following warning
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1.
> {code}
> To reproduce this issue logback (with slf4j) should be used.
> Not able to reproduce with System.out.println.
> * 4-byte character at position 1023 (or N * 1024 - 1) in log message.
> Can be reproduced with System.out.println (logback not required in this case).
> This blocks surefire entirely at (from jstack):
> {code:java}
> "fork-1-event-thread" #30 daemon prio=5 os_prio=0 cpu=32350.09ms
> elapsed=32.94s tid=0x7ff8292d7800 nid=0x3caef runnable
> [0x7ff7876f6000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.decodeString(AbstractStreamDecoder.java:350)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:322)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:196)
> at
> org.apache.maven.surefire.stream.EventDecoder.decode(EventDecoder.java:176)
> at
> org.apache.maven.plugin.surefire.extensions.EventConsumerThread.run(EventConsumerThread.java:73)
> {code}
>
> Project with reproducible tests (for both scenarios, more in README):
> [https://github.com/zoltanmeze/surefire-corrupted-channel]
>
> One workaround on M6 for now is to use different charset (instead of default
> UTF-8) or limit message size.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (SUREFIRE-2058) Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging
[
https://issues.apache.org/jira/browse/SUREFIRE-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552812#comment-17552812
]
Richard Harris edited comment on SUREFIRE-2058 at 6/10/22 3:33 PM:
---
The consequence of this is quite significant - we have just upgraded to
3.0.0-M6 from 3.0.0-M3 and have found that test goals have been marked as
passing even though there are test failures, in each case this warning was
produced, but it doesn't cause a failure and means the actual results are
hidden.
was (Author: JIRAUSER290819):
The consequence of this is quite significant - we have just upgraded to
3.0.0-M6 from 3.0.0-M53and have found that test goals have been marked as
passing even though there are test failures, in each case this warning was
produced, but it doesn't cause a failure and means the actual results are
hidden.
> Corrupted STDOUT by directly writing to native stream in forked JVM 1 with
> UTF-8 console logging
>
>
> Key: SUREFIRE-2058
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2058
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Zoltan Meze
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> With 3.0.0-M6 surefire and slf4j + logback, most test runs end up with:
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1. {code}
> This only affects *3.0.0-M6* (3.0.0-M5 version is working fine in test
> project).
>
> After some digging, there are two different scenarios (most likely caused by
> the same issue):
> * 2-byte character at position 1023 (or N * 1024 - 1) in log message is
> causing the following warning
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1.
> {code}
> To reproduce this issue logback (with slf4j) should be used.
> Not able to reproduce with System.out.println.
> * 4-byte character at position 1023 (or N * 1024 - 1) in log message.
> Can be reproduced with System.out.println (logback not required in this case).
> This blocks surefire entirely at (from jstack):
> {code:java}
> "fork-1-event-thread" #30 daemon prio=5 os_prio=0 cpu=32350.09ms
> elapsed=32.94s tid=0x7ff8292d7800 nid=0x3caef runnable
> [0x7ff7876f6000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.decodeString(AbstractStreamDecoder.java:350)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:322)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:196)
> at
> org.apache.maven.surefire.stream.EventDecoder.decode(EventDecoder.java:176)
> at
> org.apache.maven.plugin.surefire.extensions.EventConsumerThread.run(EventConsumerThread.java:73)
> {code}
>
> Project with reproducible tests (for both scenarios, more in README):
> [https://github.com/zoltanmeze/surefire-corrupted-channel]
>
> One workaround on M6 for now is to use different charset (instead of default
> UTF-8) or limit message size.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SUREFIRE-2058) Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging
[
https://issues.apache.org/jira/browse/SUREFIRE-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552812#comment-17552812
]
Richard Harris commented on SUREFIRE-2058:
--
The consequence of this is quite significant - we have just upgraded to
3.0.0-M6 from 3.0.0-M5 and have found that test goals have been marked as
passing even though there are test failures, in each case this warning was
produced, but it doesn't cause a failure and means the actual results are
hidden.
> Corrupted STDOUT by directly writing to native stream in forked JVM 1 with
> UTF-8 console logging
>
>
> Key: SUREFIRE-2058
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2058
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Zoltan Meze
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> With 3.0.0-M6 surefire and slf4j + logback, most test runs end up with:
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1. {code}
> This only affects *3.0.0-M6* (3.0.0-M5 version is working fine in test
> project).
>
> After some digging, there are two different scenarios (most likely caused by
> the same issue):
> * 2-byte character at position 1023 (or N * 1024 - 1) in log message is
> causing the following warning
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1.
> {code}
> To reproduce this issue logback (with slf4j) should be used.
> Not able to reproduce with System.out.println.
> * 4-byte character at position 1023 (or N * 1024 - 1) in log message.
> Can be reproduced with System.out.println (logback not required in this case).
> This blocks surefire entirely at (from jstack):
> {code:java}
> "fork-1-event-thread" #30 daemon prio=5 os_prio=0 cpu=32350.09ms
> elapsed=32.94s tid=0x7ff8292d7800 nid=0x3caef runnable
> [0x7ff7876f6000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.decodeString(AbstractStreamDecoder.java:350)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:322)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:196)
> at
> org.apache.maven.surefire.stream.EventDecoder.decode(EventDecoder.java:176)
> at
> org.apache.maven.plugin.surefire.extensions.EventConsumerThread.run(EventConsumerThread.java:73)
> {code}
>
> Project with reproducible tests (for both scenarios, more in README):
> [https://github.com/zoltanmeze/surefire-corrupted-channel]
>
> One workaround on M6 for now is to use different charset (instead of default
> UTF-8) or limit message size.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MDEPLOY-293) Maven deploy fails with 401 Unauthorized when using £ in password
[
https://issues.apache.org/jira/browse/MDEPLOY-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552808#comment-17552808
]
Slawomir Jaranowski commented on MDEPLOY-293:
-
command line should be - linux / bash:
{code}
MAVEN_OPTS=-Dorg.slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient=debug
mvn deploy
{code}
for windows probably, two commands - one for set environment variable and one
for execute
{code}
set
"MAVEN_OPTS=-Dorg.slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient=debug"
mvn deploy
{code}
> Maven deploy fails with 401 Unauthorized when using £ in password
> -
>
> Key: MDEPLOY-293
> URL: https://issues.apache.org/jira/browse/MDEPLOY-293
> Project: Maven Deploy Plugin
> Issue Type: Bug
>Reporter: Nélson Cunha
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
> Attachments: image-2022-06-08-20-06-39-388.png,
> image-2022-06-08-20-09-57-536.png, image-2022-06-09-16-52-04-876.png,
> image-2022-06-09-16-52-19-905.png, image-2022-06-09-17-01-18-568.png
>
>
> Hello.
> I'm using Apache Maven 3.6.3 and maven-deploy-plugin 2.8.2 on Oracle's Java
> version 1.8.0_321 and I'm currently receiving the 401 Unauthorized error
> when deploying an artifact to Sonatype Nexus:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on
> project XXX: Failed to deploy artifacts: Could not transfer artifact
> XXX:XXX:pom:4.0.0-20220608.184337-1 from/to nexus-snapshots
> (http://.../repository/maven-snapshots/): Transfer failed for
> http://...-4.0.0-20220608.184337-1.pom 401 Unauthorized -> [Help 1]{noformat}
>
> This error showed up after I changed my password with a leading {{£}}
> character.
>
> Using Wireshark to capture the HTTP packages exchanged between the maven
> client and the nexus repository, I see 3 interactions:
> # unauthenticated GET request for a maven-metadata.xml file, followed by a
> 401 response
> # authenticated GET request for the same maven-metadata.xml file, followed
> by a 404 response
> # authenticated PUT request for the pom file, followed by a 401 response
>
> Now, analyzing the headers for the second and third request I noticed the
> base64 on the Authentication header is not the same.
> * 2nd request: GET metadata
> !image-2022-06-08-20-06-39-388.png!
>
> * 3rd request PUT pom
> !image-2022-06-08-20-09-57-536.png!
>
> The decoded base64 with the username:password, shows that, as expected, the
> request that received a 404 holds the right password, but on the other hand,
> the PUT request that got a 401 has a password with a {{?}} for the {{{}£{}}}.
>
> All the servers on my {{settings.xml}} hold the same user/password and I have
> tried with the passwords encoded and in plain text.
>
>
> Further tests with base64 encoding and decoding showed that the "wrong"
> password is the actual password but encoded from an ANSI code page where the
> password accepted by Nexus is encoded from utf8.
>
> I noticed the 401 responses don't specify the encoding on the
> {{WWW-Authenticate}} header, which should clear up which encoding to use, but
> still for some reason the two requests are apparently using different
> encodings.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNGSITE-485) Expired signature in provided KEYS file on the download page
[
https://issues.apache.org/jira/browse/MNGSITE-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552807#comment-17552807
]
Michael Osipov commented on MNGSITE-485:
I have imported the keys, as-is. No issue with my key, then verfired:
{noformat}
mosipov@mikaw10 MINGW64
/d/Entwicklung/Projekte/maven/target/checkout/apache-maven/target
((maven-3.8.6))
$ gpg --verify apache-maven-3.8.6-bin.zip.asc apache-maven-3.8.6-bin.zip
gpg: Signature made Mo, 6. Jun 2022 18:39:25
gpg:using RSA key 6A814B1F869C2BBEAB7CB7271A2A1C94BDE89688
gpg: Good signature from "Michael Osipov (Java developer) <1983-01...@gmx.net>"
[unknown]
gpg: aka "Michael Osipov " [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: 6A81 4B1F 869C 2BBE AB7C B727 1A2A 1C94 BDE8 9688
{noformat}
So the file was verfied to be done by me, no? What do you expect to see?
> Expired signature in provided KEYS file on the download page
>
>
> Key: MNGSITE-485
> URL: https://issues.apache.org/jira/browse/MNGSITE-485
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Baiyang Li
>Assignee: Michael Osipov
>Priority: Major
>
> Hey,
> I met the same expired signature issue described in this close
> [issue|https://issues.apache.org/jira/browse/MNGSITE-458?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17410236#comment-17410236].
> When i follow the procedure to verify the signature using the KEYS file, both
> provided on the maven's download page::
> * KEYS file import: gpg --import KEYS
> * signature verification; gpg --verify .\apache-maven-3.8.2-bin.tar.gz.asc
> .\apache-maven-3.8.2-bin.tar.gz
> I've got the following message at the second step:
> gpg: Good signature from "Michael Osipov (Java developer)
> <1983-01...@gmx.net>" [expired]
> gpg: aka "Michael Osipov " [expired]
> gpg: Note: This key has expired!
> According to the same procedure: "A signature is valid, if gpg verifies the
> .asc as a good signature, and doesn't complain about expired or revoked
> keys", so, technically, the signature is not valid.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-common-artifact-filters] cstamas commented on pull request #26: [MSHARED-1077] Bugfix for classifier in pattern
cstamas commented on PR #26: URL: https://github.com/apache/maven-common-artifact-filters/pull/26#issuecomment-1152470743 Um. The GN file is copied from master unmodified. No need to review it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (MNGSITE-485) Expired signature in provided KEYS file on the download page
[ https://issues.apache.org/jira/browse/MNGSITE-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MNGSITE-485: > Expired signature in provided KEYS file on the download page > > > Key: MNGSITE-485 > URL: https://issues.apache.org/jira/browse/MNGSITE-485 > Project: Maven Project Web Site > Issue Type: Bug >Reporter: Baiyang Li >Assignee: Michael Osipov >Priority: Major > > Hey, > I met the same expired signature issue described in this close > [issue|https://issues.apache.org/jira/browse/MNGSITE-458?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17410236#comment-17410236]. > When i follow the procedure to verify the signature using the KEYS file, both > provided on the maven's download page:: > * KEYS file import: gpg --import KEYS > * signature verification; gpg --verify .\apache-maven-3.8.2-bin.tar.gz.asc > .\apache-maven-3.8.2-bin.tar.gz > I've got the following message at the second step: > gpg: Good signature from "Michael Osipov (Java developer) > <1983-01...@gmx.net>" [expired] > gpg: aka "Michael Osipov " [expired] > gpg: Note: This key has expired! > According to the same procedure: "A signature is valid, if gpg verifies the > .asc as a good signature, and doesn't complain about expired or revoked > keys", so, technically, the signature is not valid. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Moved] (ARCHETYPE-630) adding a message for debug
[ https://issues.apache.org/jira/browse/ARCHETYPE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MNG-7494 to ARCHETYPE-630: --- Key: ARCHETYPE-630 (was: MNG-7494) Project: Maven Archetype (was: Maven) > adding a message for debug > -- > > Key: ARCHETYPE-630 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-630 > Project: Maven Archetype > Issue Type: Improvement >Reporter: Andra Puscas >Priority: Minor > > As I have some problems downloading the archetype catalog I needed to do some > debugging and I added a message, to make it more clear. > This is the PR: [https://github.com/apache/maven-archetype/pull/109] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MDEPLOY-293) Maven deploy fails with 401 Unauthorized when using £ in password
[
https://issues.apache.org/jira/browse/MDEPLOY-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552791#comment-17552791
]
Nélson Cunha commented on MDEPLOY-293:
--
Hello.
Running with maven-deploy-plugin version {{3.0.0-M2}} produced the same result.
Running {{mvn deploy
-Dorg.slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient=debug}}
produces
{noformat}
[ERROR] Unknown lifecycle phase
".slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient=debug".
You must specify a valid lifecycle phase or a goal in the format
: or
:[:]:. Available
lifecycle phases are: validate, initialize, generate-sources, process-sources,
generate-resources, process-resources, compile, process-classes,
generate-test-sources, process-test-sources, generate-test-resources,
process-test-resources, test-compile, process-test-classes, test,
prepare-package, package, pre-integration-test, integration-test,
post-integration-test, verify, install, deploy, pre-clean, clean, post-clean,
pre-site, site, post-site, site-deploy. -> [Help 1]{noformat}
> Maven deploy fails with 401 Unauthorized when using £ in password
> -
>
> Key: MDEPLOY-293
> URL: https://issues.apache.org/jira/browse/MDEPLOY-293
> Project: Maven Deploy Plugin
> Issue Type: Bug
>Reporter: Nélson Cunha
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
> Attachments: image-2022-06-08-20-06-39-388.png,
> image-2022-06-08-20-09-57-536.png, image-2022-06-09-16-52-04-876.png,
> image-2022-06-09-16-52-19-905.png, image-2022-06-09-17-01-18-568.png
>
>
> Hello.
> I'm using Apache Maven 3.6.3 and maven-deploy-plugin 2.8.2 on Oracle's Java
> version 1.8.0_321 and I'm currently receiving the 401 Unauthorized error
> when deploying an artifact to Sonatype Nexus:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on
> project XXX: Failed to deploy artifacts: Could not transfer artifact
> XXX:XXX:pom:4.0.0-20220608.184337-1 from/to nexus-snapshots
> (http://.../repository/maven-snapshots/): Transfer failed for
> http://...-4.0.0-20220608.184337-1.pom 401 Unauthorized -> [Help 1]{noformat}
>
> This error showed up after I changed my password with a leading {{£}}
> character.
>
> Using Wireshark to capture the HTTP packages exchanged between the maven
> client and the nexus repository, I see 3 interactions:
> # unauthenticated GET request for a maven-metadata.xml file, followed by a
> 401 response
> # authenticated GET request for the same maven-metadata.xml file, followed
> by a 404 response
> # authenticated PUT request for the pom file, followed by a 401 response
>
> Now, analyzing the headers for the second and third request I noticed the
> base64 on the Authentication header is not the same.
> * 2nd request: GET metadata
> !image-2022-06-08-20-06-39-388.png!
>
> * 3rd request PUT pom
> !image-2022-06-08-20-09-57-536.png!
>
> The decoded base64 with the username:password, shows that, as expected, the
> request that received a 404 holds the right password, but on the other hand,
> the PUT request that got a 401 has a password with a {{?}} for the {{{}£{}}}.
>
> All the servers on my {{settings.xml}} hold the same user/password and I have
> tried with the passwords encoded and in plain text.
>
>
> Further tests with base64 encoding and decoding showed that the "wrong"
> password is the actual password but encoded from an ANSI code page where the
> password accepted by Nexus is encoded from utf8.
>
> I noticed the 401 responses don't specify the encoding on the
> {{WWW-Authenticate}} header, which should clear up which encoding to use, but
> still for some reason the two requests are apparently using different
> encodings.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-filtering] michael-o commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
michael-o commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894619541
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -90,23 +87,25 @@ public boolean filteredFileExtension( String fileName,
List userNonFilte
{
nonFilteredFileExtensions.addAll( userNonFilteredFileExtensions );
}
-String extension = StringUtils.lowerCase( FilenameUtils.getExtension(
fileName ) );
+String extension = getExtension( fileName );
boolean filteredFileExtension = !nonFilteredFileExtensions.contains(
extension );
-if ( getLogger().isDebugEnabled() )
+if ( LOGGER.isDebugEnabled() )
{
-getLogger().debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+LOGGER.debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+ "filtered file extension" );
}
return filteredFileExtension;
}
+private static String getExtension( String fileName )
+{
+String rawExt = FilenameUtils.getExtension( fileName );
+return rawExt == null ? null : rawExt.toLowerCase( Locale.ROOT );
+}
+
@Override
public List getDefaultNonFilteredFileExtensions()
{
-if ( this.defaultNonFilteredFileExtensions == null )
-{
-this.defaultNonFilteredFileExtensions = new ArrayList<>();
-}
return this.defaultNonFilteredFileExtensions;
Review Comment:
Dammit, not noticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-filtering] michael-o commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
michael-o commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894617986
##
pom.xml:
##
@@ -141,21 +136,39 @@
2.2
test
+
+ org.slf4j
+ slf4j-simple
+ ${slf4jVersion}
+ test
+
+
+ org.sonatype.plexus
+ plexus-build-api
+ ${plexusBuildApiVersion}
+ test
+ tests
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.plexus
+ 0.3.0.M1
+ test
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.inject
+ 0.3.0.M1
+ test
+
-org.codehaus.plexus
-plexus-component-metadata
-
-
-
- generate-metadata
-
-
-
+org.eclipse.sisu
+sisu-maven-plugin
Review Comment:
Makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] michael-o commented on a diff in pull request #26: [MSHARED-1077] Bugfix for classifier in pattern
michael-o commented on code in PR #26:
URL:
https://github.com/apache/maven-common-artifact-filters/pull/26#discussion_r894614846
##
src/test/java/org/apache/maven/shared/artifact/filter/GNPatternIncludesArtifactFilter.java:
##
@@ -0,0 +1,917 @@
+package org.apache.maven.shared.artifact.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
+import org.apache.maven.artifact.versioning.DefaultArtifactVersion;
+import
org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
+import org.apache.maven.artifact.versioning.VersionRange;
+import org.slf4j.Logger;
+
+/**
+ * TODO: include in maven-artifact in future
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ * @see StrictPatternIncludesArtifactFilter
+ */
+public class GNPatternIncludesArtifactFilter
+implements ArtifactFilter, StatisticsReportingArtifactFilter
+{
+/** Holds the set of compiled patterns */
+private final Set patterns;
+
+/** Whether the dependency trail should be checked */
+private final boolean actTransitively;
+
+/** Set of patterns that have been triggered */
+private final Set patternsTriggered = new HashSet<>();
+
+/** Set of artifacts that have been filtered out */
+private final List filteredArtifact = new ArrayList<>();
+
+/**
+ * Constructor for PatternIncludesArtifactFilter.
+ *
+ * @param patterns The pattern to be used.
+ */
+public GNPatternIncludesArtifactFilter( final Collection patterns )
+{
+this( patterns, false );
+}
+
+/**
+ * Constructor for PatternIncludesArtifactFilter.
+ *
+ * @param patterns The pattern to be used.
+ * @param actTransitively transitive yes/no.
+ */
+public GNPatternIncludesArtifactFilter( final Collection patterns,
final boolean actTransitively )
+{
+this.actTransitively = actTransitively;
+final Set pat = new LinkedHashSet<>();
+if ( patterns != null && !patterns.isEmpty() )
+{
+for ( String pattern : patterns )
+{
+
+Pattern p = compile( pattern );
+pat.add( p );
+}
+}
+this.patterns = pat;
+}
+
+/** {@inheritDoc} */
+public boolean include( final Artifact artifact )
+{
+final boolean shouldInclude = patternMatches( artifact );
+
+if ( !shouldInclude )
+{
+addFilteredArtifact( artifact );
+}
+
+return shouldInclude;
+}
+
+/**
+ * patternMatches.
+ *
+ * @param artifact to check for.
+ * @return true if the match is true false otherwise.
+ */
+protected boolean patternMatches( final Artifact artifact )
+{
+// Check if the main artifact matches
+char[][] artifactGatvCharArray = new char[][] {
+emptyOrChars( artifact.getGroupId() ),
+emptyOrChars( artifact.getArtifactId() ),
+emptyOrChars( artifact.getType() ),
+emptyOrChars( artifact.getClassifier() ),
+emptyOrChars( artifact.getBaseVersion() )
+};
+Boolean match = match( artifactGatvCharArray );
+if ( match != null )
+{
+return match;
+}
+
+if ( actTransitively )
+{
+final List depTrail = artifact.getDependencyTrail();
+
+if ( depTrail != null && depTrail.size() > 1 )
+{
+for ( String trailItem : depTrail )
+{
+char[][] depGatvCharArray = tokenizeAndSplit( trailItem );
+match = match( depGatvCharArray );
+if ( match != null )
+{
+return match;
+}
+}
+
[jira] [Created] (MNG-7494) adding a message for debug
Andra Puscas created MNG-7494: - Summary: adding a message for debug Key: MNG-7494 URL: https://issues.apache.org/jira/browse/MNG-7494 Project: Maven Issue Type: Improvement Reporter: Andra Puscas As I have some problems downloading the archetype catalog I needed to do some debugging and I added a message, to make it more clear. This is the PR: [https://github.com/apache/maven-archetype/pull/109] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-filtering] cstamas commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
cstamas commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894614092
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -90,23 +87,25 @@ public boolean filteredFileExtension( String fileName,
List userNonFilte
{
nonFilteredFileExtensions.addAll( userNonFilteredFileExtensions );
}
-String extension = StringUtils.lowerCase( FilenameUtils.getExtension(
fileName ) );
+String extension = getExtension( fileName );
boolean filteredFileExtension = !nonFilteredFileExtensions.contains(
extension );
-if ( getLogger().isDebugEnabled() )
+if ( LOGGER.isDebugEnabled() )
{
-getLogger().debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+LOGGER.debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+ "filtered file extension" );
}
return filteredFileExtension;
}
+private static String getExtension( String fileName )
+{
+String rawExt = FilenameUtils.getExtension( fileName );
+return rawExt == null ? null : rawExt.toLowerCase( Locale.ROOT );
+}
+
@Override
public List getDefaultNonFilteredFileExtensions()
{
-if ( this.defaultNonFilteredFileExtensions == null )
-{
-this.defaultNonFilteredFileExtensions = new ArrayList<>();
-}
return this.defaultNonFilteredFileExtensions;
Review Comment:
Nope, member made final, inited in ctor , no more "lazy init"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-filtering] cstamas commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
cstamas commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894614092
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -90,23 +87,25 @@ public boolean filteredFileExtension( String fileName,
List userNonFilte
{
nonFilteredFileExtensions.addAll( userNonFilteredFileExtensions );
}
-String extension = StringUtils.lowerCase( FilenameUtils.getExtension(
fileName ) );
+String extension = getExtension( fileName );
boolean filteredFileExtension = !nonFilteredFileExtensions.contains(
extension );
-if ( getLogger().isDebugEnabled() )
+if ( LOGGER.isDebugEnabled() )
{
-getLogger().debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+LOGGER.debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+ "filtered file extension" );
}
return filteredFileExtension;
}
+private static String getExtension( String fileName )
+{
+String rawExt = FilenameUtils.getExtension( fileName );
+return rawExt == null ? null : rawExt.toLowerCase( Locale.ROOT );
+}
+
@Override
public List getDefaultNonFilteredFileExtensions()
{
-if ( this.defaultNonFilteredFileExtensions == null )
-{
-this.defaultNonFilteredFileExtensions = new ArrayList<>();
-}
return this.defaultNonFilteredFileExtensions;
Review Comment:
Nope, member made final, no more "lazy init"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-filtering] cstamas commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
cstamas commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894613310
##
pom.xml:
##
@@ -141,21 +136,39 @@
2.2
test
+
+ org.slf4j
+ slf4j-simple
+ ${slf4jVersion}
+ test
+
+
+ org.sonatype.plexus
+ plexus-build-api
+ ${plexusBuildApiVersion}
+ test
+ tests
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.plexus
+ 0.3.0.M1
+ test
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.inject
+ 0.3.0.M1
+ test
+
-org.codehaus.plexus
-plexus-component-metadata
-
-
-
- generate-metadata
-
-
-
+org.eclipse.sisu
+sisu-maven-plugin
Review Comment:
Is, in build/pluginMgmt, but i want it to execute
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java:
##
@@ -19,32 +19,36 @@
* under the License.
*/
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
import java.io.File;
import java.io.IOException;
import java.util.List;
import org.apache.maven.execution.MavenSession;
import org.apache.maven.project.MavenProject;
-import org.apache.maven.shared.utils.io.FileUtils;
-import org.apache.maven.shared.utils.io.FileUtils.FilterWrapper;
-import org.codehaus.plexus.component.annotations.Component;
-import org.codehaus.plexus.component.annotations.Requirement;
import org.sonatype.plexus.build.incremental.BuildContext;
+import static java.util.Objects.requireNonNull;
+
/**
* @author Olivier Lamy
*/
-@Component( role = org.apache.maven.shared.filtering.MavenFileFilter.class,
hint = "default" )
+@Singleton
+@Named
public class DefaultMavenFileFilter
extends BaseFilter
implements MavenFileFilter
{
+private final BuildContext buildContext;
-@Requirement
-private MavenReaderFilter readerFilter;
Review Comment:
Yup. Was unused member
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-archetype] ampuscas opened a new pull request, #109: adding a debug message for getRemoteCatalog
ampuscas opened a new pull request, #109: URL: https://github.com/apache/maven-archetype/pull/109 I had some issues getting the catalog so I added a debug message when the catalog cannot be downloaded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] michael-o commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
michael-o commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894589012
##
pom.xml:
##
@@ -55,7 +56,9 @@
3.2.5
-7
+1.7.36
+0.0.7
+8
Review Comment:
Please retain the position of `javaVersion`, makes easier to diff.
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java:
##
@@ -19,32 +19,36 @@
* under the License.
*/
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
import java.io.File;
import java.io.IOException;
import java.util.List;
import org.apache.maven.execution.MavenSession;
import org.apache.maven.project.MavenProject;
-import org.apache.maven.shared.utils.io.FileUtils;
-import org.apache.maven.shared.utils.io.FileUtils.FilterWrapper;
-import org.codehaus.plexus.component.annotations.Component;
-import org.codehaus.plexus.component.annotations.Requirement;
import org.sonatype.plexus.build.incremental.BuildContext;
+import static java.util.Objects.requireNonNull;
+
/**
* @author Olivier Lamy
*/
-@Component( role = org.apache.maven.shared.filtering.MavenFileFilter.class,
hint = "default" )
+@Singleton
+@Named
public class DefaultMavenFileFilter
extends BaseFilter
implements MavenFileFilter
{
+private final BuildContext buildContext;
-@Requirement
-private MavenReaderFilter readerFilter;
Review Comment:
Is this one not used anymore?
##
pom.xml:
##
@@ -141,21 +136,39 @@
2.2
test
+
+ org.slf4j
+ slf4j-simple
+ ${slf4jVersion}
+ test
+
+
+ org.sonatype.plexus
+ plexus-build-api
+ ${plexusBuildApiVersion}
+ test
+ tests
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.plexus
+ 0.3.0.M1
+ test
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.inject
+ 0.3.0.M1
+ test
+
-org.codehaus.plexus
-plexus-component-metadata
-
-
-
- generate-metadata
-
-
-
+org.eclipse.sisu
+sisu-maven-plugin
Review Comment:
Are you certain that this isn't in the parent already?
##
pom.xml:
##
@@ -141,21 +136,39 @@
2.2
test
+
+ org.slf4j
+ slf4j-simple
+ ${slf4jVersion}
+ test
+
+
+ org.sonatype.plexus
+ plexus-build-api
+ ${plexusBuildApiVersion}
+ test
+ tests
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.plexus
+ 0.3.0.M1
+ test
+
+
+ org.eclipse.sisu
+ org.eclipse.sisu.inject
+ 0.3.0.M1
Review Comment:
Move this to a property please.
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -90,23 +87,25 @@ public boolean filteredFileExtension( String fileName,
List userNonFilte
{
nonFilteredFileExtensions.addAll( userNonFilteredFileExtensions );
}
-String extension = StringUtils.lowerCase( FilenameUtils.getExtension(
fileName ) );
+String extension = getExtension( fileName );
boolean filteredFileExtension = !nonFilteredFileExtensions.contains(
extension );
-if ( getLogger().isDebugEnabled() )
+if ( LOGGER.isDebugEnabled() )
{
-getLogger().debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+LOGGER.debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+ "filtered file extension" );
}
return filteredFileExtension;
}
+private static String getExtension( String fileName )
+{
+String rawExt = FilenameUtils.getExtension( fileName );
+return rawExt == null ? null : rawExt.toLowerCase( Locale.ROOT );
+}
+
@Override
public List getDefaultNonFilteredFileExtensions()
{
-if ( this.defaultNonFilteredFileExtensions == null )
-{
-this.defaultNonFilteredFileExtensions = new ArrayList<>();
-}
return this.defaultNonFilteredFileExtensions;
Review Comment:
This changes semantics, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MSHARED-1080) Upgrade Parent POM to 36, to Java 8, dependencies; drop Plexus
[ https://issues.apache.org/jira/browse/MSHARED-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MSHARED-1080: Assignee: Tamás Cservenák > Upgrade Parent POM to 36, to Java 8, dependencies; drop Plexus > -- > > Key: MSHARED-1080 > URL: https://issues.apache.org/jira/browse/MSHARED-1080 > Project: Maven Shared Components > Issue Type: Task > Components: maven-filtering >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: maven-filtering-3.3.0 > > > Update parent POM to 36, up to Java8, and update all locked dependencies due > Java8, drop maven-shared-utils -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSHARED-1080) Upgrade Parent POM to 36, to Java 8, dependencies; drop Plexus
[ https://issues.apache.org/jira/browse/MSHARED-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1080: Summary: Upgrade Parent POM to 36, to Java 8, dependencies; drop Plexus (was: Update parent POM to 36, Java8, dependencies, drop plexus) > Upgrade Parent POM to 36, to Java 8, dependencies; drop Plexus > -- > > Key: MSHARED-1080 > URL: https://issues.apache.org/jira/browse/MSHARED-1080 > Project: Maven Shared Components > Issue Type: Task > Components: maven-filtering >Reporter: Tamás Cservenák >Priority: Major > Fix For: maven-filtering-3.3.0 > > > Update parent POM to 36, up to Java8, and update all locked dependencies due > Java8, drop maven-shared-utils -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SUREFIRE-1631) Forked VM terminated without properly saying goodbye with AciveMQ on Windows10 and MinTTY(Cygwin) console
[ https://issues.apache.org/jira/browse/SUREFIRE-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552774#comment-17552774 ] Delany commented on SUREFIRE-1631: -- What's the upshot of this thread. Does the issue persist in Surefire 3.0.0-M7? After reading this and these pages * [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#enableProcessChecker] * [https://maven.apache.org/surefire/maven-surefire-plugin/faq.html#kill-jvm] Im no wiser whether to use enableProcessChecker. > Forked VM terminated without properly saying goodbye with AciveMQ on > Windows10 and MinTTY(Cygwin) console > - > > Key: SUREFIRE-1631 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1631 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20.1, 2.22.0, 3.0.0-M2, 3.0.0-M1 >Reporter: Aaron Digulla >Assignee: Tibor Digana >Priority: Major > Attachments: cmd.PNG, cmd2.PNG, shurefire-shutdownhook-bug-0.0.1.zip > > > I'm seeing spurious "The forked VM terminated without properly saying > goodbye. VM crash or System.exit called?" messages when running unit tests in > a big multi-module project. > OS: Windows 10, running Maven 3.5.0 to 3.6.0 and different versions of > Surefire (2.20.1 to 3.0.0.-M2), Java 8u171 to 8u191. > I'm running Maven from the command line using MinTTY (Cygwin). > Things I tried which have no effect: > * Reboot / Cold boot (happens first thing on Monday morning when I come into > the office and turn on my PC). > * More free memory (happens when I only have a single window open). I have > 16GB of RAM. > * Different terminal. I tried CMD prompt and urxvt (Cygwin/X). > * Different versions of the Surefire plugin or Maven > * Different JDK 8 builds > Things that affect the bug: > * Redirecting Maven's stdout to a file: mvn ... | tee mvn.log > * Redirecting all log output to a file using logback-test.xml > * Running Surefire with forkCount=0 > * Running a subset of the tests (-Dtest=...) > * Pending Windows updates (I think, not sure about this one). > Counts: I've never seen it with forkCount=0 (~ 20 test builds). I've never > seen it with redirecting log output (~ 10 builds). Redirecting sometimes > helps but not always. > One thing which I notice is that one of the tests creates an ActiveMQ broker > and uses a shutdown hook to stop it. So I created a small test project which > demonstrates that Surefire will sometimes cut off stdout. I think that > happens because the main process kills the child after a timeout (correct?). > So my guess would be that shutdown hooks can mess with the pipeline between > the surefire child VM and main Maven process. ActiveMQ might be worse since > it stops threads and execution pools (so the output comes slowly with a > couple of exceptions sprinkled in when one component loses connection because > another is shutting down). > But now, it gets weird. When the build succeeds, it takes about ~5 minutes to > run 1028 tests. The log is 25 MB. > When it fails, it takes ~8 minutes to run ~700-800 tests (this number varies) > and the log stops in the middle of a test but is also 25 MB. > Some of the time discrepancy is probably because writing to a file is faster > than printing on a terminal. The strange part is that the log file is about > the same size but 30% of the tests haven't run. Most tests log a lot, do I > would expect to see a difference of at least a few MB. The Maven part (which > contains escape sequences, etc). is just 60 KB. > Maybe the parent takes some part of the log output as "child terminated". > I'm running out of ideas what to try next. I think a way to log the > communication between parent and child would help. Also the parent should > terminate the child and then read stdout until EOF to we can see anything > that happens afterwards. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven] cstamas closed pull request #752: [EXPERIMENT] Add ZIP ArtifactHandler
cstamas closed pull request #752: [EXPERIMENT] Add ZIP ArtifactHandler URL: https://github.com/apache/maven/pull/752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #752: [EXPERIMENT] Add ZIP ArtifactHandler
michael-o commented on code in PR #752:
URL: https://github.com/apache/maven/pull/752#discussion_r89447
##
maven-core/src/main/java/org/apache/maven/artifact/handler/providers/ZipArtifactHandlerProvider.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.artifact.handler.providers;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+import javax.inject.Singleton;
+
+import org.apache.maven.artifact.handler.ArtifactHandler;
+import org.apache.maven.artifact.handler.DefaultArtifactHandler;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * {@code zip} artifact handler provider.
+ */
+@Named( "zip" )
+@Singleton
+public class ZipArtifactHandlerProvider
+implements Provider
+{
+private static final boolean ADDED_TO_CLASSPATH = Boolean.parseBoolean(
System.getProperty(
+"maven.artifactHandler.zip.addedToClasspath",
Boolean.TRUE.toString() ) );
+private final ArtifactHandler artifactHandler;
+
+@Inject
+public ZipArtifactHandlerProvider()
+{
+this.artifactHandler = new DefaultArtifactHandler(
+"zip",
+null,
+null,
+null,
+null,
+false,
+"java",
+ADDED_TO_CLASSPATH
Review Comment:
Broken indent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] cstamas opened a new pull request, #752: [EXPERIMENT] Add ZIP ArtifactHandler
cstamas opened a new pull request, #752: URL: https://github.com/apache/maven/pull/752 And make it possible to control are they added to CP or not. W.o param default is `true` as master (behaves same as master). To make ZIPs not end up on classpath, use: `-Dmaven.artifactHandler.zip.addedToClasspath=false` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-1080) Update parent POM to 36, Java8, dependencies, drop plexus
[ https://issues.apache.org/jira/browse/MSHARED-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MSHARED-1080: - Description: Update parent POM to 36, up to Java8, and update all locked dependencies due Java8, drop maven-shared-utils (was: Update parent POM to 36, up to Java8, and update all locked dependencies due Java8, drop maven-shared-utils, drop plexus APIs) > Update parent POM to 36, Java8, dependencies, drop plexus > - > > Key: MSHARED-1080 > URL: https://issues.apache.org/jira/browse/MSHARED-1080 > Project: Maven Shared Components > Issue Type: Task > Components: maven-filtering >Reporter: Tamás Cservenák >Priority: Major > Fix For: maven-filtering-3.3.0 > > > Update parent POM to 36, up to Java8, and update all locked dependencies due > Java8, drop maven-shared-utils -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-filtering] cstamas commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
cstamas commented on code in PR #38: URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894246793 ## src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java: ## @@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean filtering, List
[GitHub] [maven-filtering] cstamas commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
cstamas commented on code in PR #38: URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894240918 ## src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java: ## @@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean filtering, List frankly looking at commit history m2e has more maintenance than https://github.com/takari/io.takari.incrementalbuild (last commit almost 2 yo ago). And who said this then? Anyway, lets bury the boomerang, sisu build api is raised from the dead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] olamy commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
olamy commented on code in PR #38: URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894235164 ## src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java: ## @@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean filtering, List If I get it correctly, what you say is "buildcontext prevails over takari/incrementalbuild as m2e has more commits"? 🦘 LOL, well, I am about to stop here 😆 no sorry but you do not read correctly, the most important is the number of users impacted. and here in m2e is a lot! what is better it's not the question here. again I'm just saying the impacted users number is really huge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on pull request #26: [MSHARED-1077] Bugfix for classifier in pattern
cstamas commented on PR #26: URL: https://github.com/apache/maven-common-artifact-filters/pull/26#issuecomment-1152048957 Aside of build passing above, @gnodet made a nice perf test as well (to prove that his rewrite was better than "old" one). So, this PR continues along (hence, copies the existing code from master as GN prefixed) and now perf tests had 3 classes testing. You can run perf test locally as well to ensure, but locally my results are: https://gist.github.com/cstamas/844fbe97bf861ffab045c43e9f734c4a Legend: "old" - in src/test the "old" pattern filter code "gn" - this PR moves current master from src/main to src/test the code it replaces "new" - the src/main "newest" pattern filter code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] cstamas commented on a diff in pull request #38: [MSHARED-1080] Parent POM 36, Java8, drop legacy.
cstamas commented on code in PR #38: URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894218354 ## src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java: ## @@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean filtering, List
[jira] [Commented] (MASSEMBLY-959) Update to Java8, drop unused dependencies
[ https://issues.apache.org/jira/browse/MASSEMBLY-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552592#comment-17552592 ] Hudson commented on MASSEMBLY-959: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-assembly-plugin » master #10 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-assembly-plugin/job/master/10/ > Update to Java8, drop unused dependencies > - > > Key: MASSEMBLY-959 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-959 > Project: Maven Assembly Plugin > Issue Type: Task >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-resolver] asfgit merged pull request #180: Prepare 1.8.1 release
asfgit merged PR #180: URL: https://github.com/apache/maven-resolver/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
