Re: install-file bug
On 23/11/2022 13:32, Romain Bioteau wrote: Hi ! I've found an issue in the latest maven-install-plugin version (3.1.0) and liked to be able to create a JIRA ticket to properly submit my fix. I don't know if it is the proper place to ask that, but the Guide is not very precise about the steps to follow. Thanks for your help ! Romain Hi Romain, Apologies for the delay. I think the best way would be to raise an issue in JIRA. It would be great if you could attach a small project that reproduces or illustrates the perceived bug. That makes it easier to assess if it is indeed a bug, and it also eases the path to determine if the bug indeed got fixed. Thanks, Maarten
[GitHub] [maven-javadoc-plugin] sman-81 commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
sman-81 commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1327111450 I submitted this PR as I wanted to contribute (as I have before). I find this change quite valuable, as small as it is. Project teams and organisations will always want library versions flagged in context of a CVE to be upgraded asap. Whether the library is in fact affected or not, they do not care. The experience on this PR, the wait times, the nitpicking and mocking of outside contributors feels very discouraging. @Neutius Hope you will have a new version soon with this issue fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] sman-81 commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
sman-81 commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1327106370 > Please rename the PR to something like "Bump commons-text version to 1.10.0" and let the show go on. @cstamas Shouldn't you have given me time to react to your comment rather than merging my change under your own pr and your own name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-sitetools] hboutemy commented on a diff in pull request #67: [DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instead of Locale#ENGLISH default and use full locale)
hboutemy commented on code in PR #67: URL: https://github.com/apache/maven-doxia-sitetools/pull/67#discussion_r1032066848 ## doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/SiteTool.java: ## @@ -63,8 +64,9 @@ Artifact getSkinArtifactFromRepository( ArtifactRepository localRepository, * Get a site descriptor from the project's site directory. * * @param siteDirectory the site directory, not null - * @param locale the locale wanted for the site descriptor. If not null, searching for - * site_localeLanguage.xml, otherwise searching for site.xml. + * @param locale the locale wanted for the site descriptor, not null. Telescoping lookup for Review Comment: s/Telescoping/merging/ ## doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/SiteTool.java: ## @@ -63,8 +64,9 @@ Artifact getSkinArtifactFromRepository( ArtifactRepository localRepository, * Get a site descriptor from the project's site directory. * * @param siteDirectory the site directory, not null - * @param locale the locale wanted for the site descriptor. If not null, searching for - * site_localeLanguage.xml, otherwise searching for site.xml. + * @param locale the locale wanted for the site descriptor, not null. Telescoping lookup for + * site_language_country_variant.xml, site_language_country.xml, Review Comment: add "if provided locale defines a variant and/or a country and/or a language" ## doxia-integration-tools/src/test/resources/unit/site-tool-locales-test/full/src/site/site_de_DE_BY.xml: ## @@ -0,0 +1,45 @@ + + + + + + +Maven Site +http://maven.apache.org/images/apache-maven-project.png +http://maven.apache.org/ + + +http://maven.apache.org/images/maven-small.gif + + +org.apache.maven.skins +maven-stylus-skin + + + Review Comment: why override this link if it is not really changed? ## doxia-integration-tools/src/test/resources/unit/site-tool-locales-test/language/src/site/site.xml: ## @@ -0,0 +1,45 @@ + + + + + + +Maven Site +http://maven.apache.org/images/apache-maven-project.png +http://maven.apache.org/ + + +http://maven.apache.org/images/maven-small.gif + + +org.apache.maven.skins +maven-stylus-skin + + + + http://maven.apache.org/maven2/"/> + + + Review Comment: for clarity, having "Overview from site.xml" would be useful ## doxia-integration-tools/src/test/resources/unit/site-tool-locales-test/language/src/site/site_de.xml: ## @@ -0,0 +1,45 @@ + + + + + + +Maven Site +http://maven.apache.org/images/apache-maven-project.png +http://maven.apache.org/ + + +http://maven.apache.org/images/maven-small.gif + + +org.apache.maven.skins +maven-stylus-skin + + + + http://maven.apache.org/maven2/"/> + + + Review Comment: for clarity, having "Overview from site_de.xml" would be useful ## doxia-integration-tools/src/test/resources/unit/site-tool-locales-test/full/src/site/site.xml: ## @@ -0,0 +1,45 @@ + + + + + + +Maven Site +http://maven.apache.org/images/apache-maven-project.png +http://maven.apache.org/ + + +http://maven.apache.org/images/maven-small.gif + + +org.apache.maven.skins +maven-stylus-skin + + + + http://maven.apache.org/maven2/"/> + + + Review Comment: for clarity, having "Overview from site.xml" would be useful ## doxia-integration-tools/src/test/resources/unit/site-tool-locales-test/full/src/site/site_de_DE_BY.xml: ## @@ -0,0 +1,45 @@ + + + + + + +Maven Site +http://maven.apache.org/images/apache-maven-project.png +http://maven.apache.org/ + + +http://maven.apache.org/images/maven-small.gif + + +org.apache.maven.skins +maven-stylus-skin + + + + http://maven.apache.org/maven2/"/> + + + Review Comment: for clarity, having "Overview from site_de_DE_BY.xml" would be useful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] sman-81 commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
sman-81 commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1327097011 > still a Jira issue to create :P especially as the user ticked everything rofl From checklist: "Trivial changes do not require a JIRA issue" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] closed pull request #272: Bump version.spring from 5.3.23 to 6.0.1
dependabot[bot] closed pull request #272: Bump version.spring from 5.3.23 to 6.0.1 URL: https://github.com/apache/maven-indexer/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #272: Bump version.spring from 5.3.23 to 6.0.1
dependabot[bot] commented on PR #272: URL: https://github.com/apache/maven-indexer/pull/272#issuecomment-1326999230 Superseded by #276. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #276: Bump version.spring from 5.3.23 to 6.0.2
dependabot[bot] opened a new pull request, #276: URL: https://github.com/apache/maven-indexer/pull/276 Bumps `version.spring` from 5.3.23 to 6.0.2. Updates `spring-beans` from 5.3.23 to 6.0.2 Release notes Sourced from https://github.com/spring-projects/spring-framework/releases;>spring-beans's releases. v6.0.2 :star: New Features Rely on standard parameter name resolution in Bean Validation 3.0 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29566;>#29566 :lady_beetle: Bug Fixes ResponseStatusException does not use the reason to set the detail field https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29567;>#29567 LocalVariableTableParameterNameDiscoverer logs many warnings with Hibernate validation https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29563;>#29563 :notebook_with_decorative_cover: Documentation org.springframework.web.multipart.commons not found https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29562;>#29562 v6.0.1 :star: New Features Make SourceHttpMessageConverter optional https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29535;>#29535 Deprecate LocalVariableTableParameterNameDiscoverer completely (avoiding its exposure in native images) https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29531;>#29531 Make GeneratorStrategy.generate unreachable on native https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29521;>#29521 Update LogAdapter to allow build-time code removal https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29506;>#29506 :lady_beetle: Bug Fixes Unhandled exceptions should mark Servlet observation outcome as error https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29512;>#29512 :notebook_with_decorative_cover: Documentation Broken link in documentation section 6.10 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29554;>#29554 Fix Javadoc link text in BindingResult https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29551;>#29551 Fix some typos in Kotlin WebClient example code https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29538;>#29538 Fix link to Bean Utils Light Library in BeanUtils Javadoc https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29534;>#29534 Fix link to WebFlux section in reference manual https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29525;>#29525 Document RuntimeHints testing strategies https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29523;>#29523 Reorganize and modularize the Testing chapter in the reference manual https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29522;>#29522 Document switch to SQLExceptionSubclassTranslator in the upgrade guide https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29518;>#29518 Update documentation to mention Java 17+ baseline https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29514;>#29514 Link to Spring WebFlux section is broken https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29513;>#29513 Update javadoc of Jackson-based decoders to reflect 2.14 baseline https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29508;>#29508 Code example has callout from a different code example https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29505;>#29505 Code listing callouts are displayed incorrectly in core-beans.adoc https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29457;>#29457 Fix a syntax error in an XML listing in core-validation.adoc https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29456;>#29456 :hammer: Dependency Upgrades Upgrade to Jackson 2.14.1 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29539;>#29539 Upgrade to Kotlin 1.7.21 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29543;>#29543 :heart: Contributors ... (truncated) Commits https://github.com/spring-projects/spring-framework/commit/3a04435cd0f3fed975fb189063ceee2808467427;>3a04435 Release v6.0.2 https://github.com/spring-projects/spring-framework/commit/b7e99fbe3039a5e10667922502388de3a9705335;>b7e99fb Additional documentation notes on Java/Kotlin parameter name retention https://github.com/spring-projects/spring-framework/commit/a27f2e994b632a63ca1bbd6f3de5d9b60246ccaa;>a27f2e9 ResponseStatusException sets detail from reason again
[GitHub] [maven-parent] dependabot[bot] closed pull request #92: Bump spotless-maven-plugin from 2.27.1 to 2.27.2
dependabot[bot] closed pull request #92: Bump spotless-maven-plugin from 2.27.1 to 2.27.2 URL: https://github.com/apache/maven-parent/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] dependabot[bot] commented on pull request #92: Bump spotless-maven-plugin from 2.27.1 to 2.27.2
dependabot[bot] commented on PR #92: URL: https://github.com/apache/maven-parent/pull/92#issuecomment-1326999088 Superseded by #93. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] dependabot[bot] opened a new pull request, #93: Bump spotless-maven-plugin from 2.27.1 to 2.28.0
dependabot[bot] opened a new pull request, #93: URL: https://github.com/apache/maven-parent/pull/93 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.27.1 to 2.28.0. Changelog Sourced from https://github.com/diffplug/spotless/blob/main/CHANGES.md;>spotless-maven-plugin's changelog. [2.28.0] - 2022-07-28 Added Clang and Black no longer break the build when the binary is unavailable, if they will not be run during that build (https://github-redirect.dependabot.com/diffplug/spotless/pull/1257;>#1257). License header support for Kotlin files without package or @file but do at least have import (https://github-redirect.dependabot.com/diffplug/spotless/pull/1263;>#1263). [2.27.0] - 2022-06-30 Added Support for MAC_CLASSIC (\r) line ending (https://github-redirect.dependabot.com/diffplug/spotless/pull/1243;>#1243 fixes https://github-redirect.dependabot.com/diffplug/spotless/issues/1196;>#1196) Changes Bump default ktlint version to latest 0.45.2 - 0.46.1 (https://github-redirect.dependabot.com/diffplug/spotless/issues/1239;>#1239) Minimum supported version also bumped to 0.46.0 (we have abandoned strong backward compatibility for ktlint, from here on out Spotless will only support the most-recent breaking change). Bump default diktat version to latest 1.1.0 - 1.2.1 (https://github-redirect.dependabot.com/diffplug/spotless/pull/1246;>#1246) Minimum supported version also bumped to 1.2.1 (diktat is based on ktlint and has the same backward compatibility issues). Bump default ktfmt version to latest 0.37 - 0.39 (https://github-redirect.dependabot.com/diffplug/spotless/pull/1240;>#1240) [2.26.2] - 2022-06-11 Fixed PalantirJavaFormatStep no longer needs the --add-exports calls in the org.gradle.jvmargs property in gradle.properties. (https://github-redirect.dependabot.com/diffplug/spotless/pull/1233;>#1233) [2.26.1] - 2022-06-10 Fixed (Second try) googleJavaFormat and removeUnusedImports works on JDK16+ without jvm args workaround. (https://github-redirect.dependabot.com/diffplug/spotless/pull/1228;>#1228) [2.26.0] - 2022-06-05 Added Support for editorConfigOverride in ktlint. (https://github-redirect.dependabot.com/diffplug/spotless/pull/1218;>#1218 fixes https://github-redirect.dependabot.com/diffplug/spotless/issues/1193;>#1193) Fixed google-java-format and RemoveUnusedImportsStep works on JDK16+ without jvm args workaround. (https://github-redirect.dependabot.com/diffplug/spotless/pull/1224;>#1224 fixes https://github-redirect.dependabot.com/diffplug/spotless/issues/834;>#834) [2.25.3] - 2022-05-10 Fixed Update the black version regex to fix 19.10b0 and earlier. (fixes https://github-redirect.dependabot.com/diffplug/spotless/issues/1195;>#1195, regression introduced in 2.25.0) GitAttributesLineEndings$RelocatablePolicy and FormatterStepImpl now null-out their initialization lambdas after their state has been calculated, which allows GC to collect variables which were incidentally captured but not needed in the calculated state. (https://github-redirect.dependabot.com/diffplug/spotless/pull/1198;>#1198) Changes Bump default ktfmt version to latest 0.36 - 0.37. (https://github-redirect.dependabot.com/diffplug/spotless/pull/1200;>#1200) [2.25.2] - 2022-05-03 Changes Bump default diktat version to latest 1.0.1 - 1.1.0. (https://github-redirect.dependabot.com/diffplug/spotless/pull/1190;>#1190) Converted diktat integration to use a compile-only source set. (fixes https://github-redirect.dependabot.com/diffplug/spotless/issues/524;>#524) Use the full path to a file in diktat integration. (fixes https://github-redirect.dependabot.com/diffplug/spotless/issues/1189;>#1189) [2.25.1] - 2022-04-27 Changes Bump default ktfmt version to latest 0.35 - 0.36. (https://github-redirect.dependabot.com/diffplug/spotless/issues/1183;>#1183) Bump default google-java-format version to latest 1.13.0 - 1.15.0. This means it is no longer necessary to use the --add-exports workaround (fixes https://github-redirect.dependabot.com/diffplug/spotless/issues/834;>#834). --add-exports workaround is still needed. [2.25.0] - 2022-04-22 Added ... (truncated) Commits https://github.com/diffplug/spotless/commit/a474435ae70036140d446644d641a682ae20672d;>a474435 Published lib/2.28.0 https://github.com/diffplug/spotless/commit/d6e767a2dfa91a0c24464a093d2827d7d1dd9ec0;>d6e767a Adapt gradle plugin publishing for the new 1.0 plugin-publish plugin. https://github.com/diffplug/spotless/commit/c229c19e48c2d30f0ffed3fe6ba061e6519899d9;>c229c19 Support adding license header for kotlin files without package name (https://github-redirect.dependabot.com/diffplug/spotless/issues/1263;>#1263)
[jira] [Commented] (MNG-5896) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638466#comment-17638466 ] wei cai commented on MNG-5896: -- [~jhaber] Tried to build a maven 3.9.0 snapshot myself, and did not see issues regarding with DF. Have you already found the cause? > Download dependency POMs in parallel > > > Key: MNG-5896 > URL: https://issues.apache.org/jira/browse/MNG-5896 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.3.3 >Reporter: Harald Wellmann >Priority: Major > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.3 first downloads the dependency POMs > _sequentially_ and then proceeds downloading the dependency JARs with up to 5 > threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] zhaoyunxing92 opened a new issue, #745: Is it possible to print the version of the plugin
zhaoyunxing92 opened a new issue, #745: URL: https://github.com/apache/maven-mvnd/issues/745 I especially like this project, I want to know the plugin version at compile time ```log ➜ mvnd clean package -Dmaven.test.skip=true -Dmvnd.debug=true Building java-agent daemon: aa845462 threads used/hidden/max: 6/0/11 progress: 194/200 97% time: 12:19 :apm-spring-cloud-gateway-3.x-plugin maven-shade-plugin:shade @ default :apm-spring-cloud-gateway-2.1.x-plugin maven-shade-plugin:shade @ default :apm-spring-cloud-gateway-2.0.x-plugin maven-shade-plugin:shade @ default :apm-shenyu-2.4.x-plugin maven-shade-plugin:shade @ default :apm-resttemplate-4.3.x-pluginmaven-shade-plugin:shade @ default ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638422#comment-17638422
]
Chesnay Schepler edited comment on MSHADE-434 at 11/25/22 1:33 AM:
---
??Why you check licenses by RAT at the one of last phase - verify.??
I don't quite remember why we run it in the verify phase.
??Change phase of RAT to standard validate will help you.??
We can certainly work around this particular issue; that's not really the
problem at hand.
What I worry about is that this may also affect other plugins in some way that
isn't as obvious.
was (Author: zentol):
??Why you check licenses by RAT at the one of last phase - verify.??
I don't quite remember why we run it in the verify phase.
??Change phase of RAT to standard validate will help you.??
We can certainly work around this particular issue; that's not really the
problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-compiler-plugin] olamy commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
olamy commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1326913635 maybe we should simply change `showWarnings` to `true` per default as described in MCOMPILER-457? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638425#comment-17638425
]
Chesnay Schepler commented on MSHADE-434:
-
??Looks like new reduced pom is now used as project pom ... ??
Why would this affect the execution of another plugin though? AFAICT the
content of the reduced pom still contains original rat-plugin configuration
without any changes.
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638425#comment-17638425
]
Chesnay Schepler edited comment on MSHADE-434 at 11/24/22 10:29 PM:
??Looks like new reduced pom is now used as project pom ...??
Why would this affect the execution of another plugin though? AFAICT the
content of the reduced pom still contains original rat-plugin configuration
without any changes.
was (Author: zentol):
??Looks like new reduced pom is now used as project pom ... ??
Why would this affect the execution of another plugin though? AFAICT the
content of the reduced pom still contains original rat-plugin configuration
without any changes.
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-738) Upgrade commons-text to 1.10.0
[ https://issues.apache.org/jira/browse/MJAVADOC-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638424#comment-17638424 ] Hudson commented on MJAVADOC-738: - Build failed in Jenkins: Maven » Maven TLP » maven-javadoc-plugin » master #51 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-javadoc-plugin/job/master/51/ > Upgrade commons-text to 1.10.0 > -- > > Key: MJAVADOC-738 > URL: https://issues.apache.org/jira/browse/MJAVADOC-738 > Project: Maven Javadoc Plugin > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.4.2 > > > Bump commons-text from 1.9 to 1.10.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638422#comment-17638422
]
Chesnay Schepler edited comment on MSHADE-434 at 11/24/22 10:25 PM:
??Why you check licenses by RAT at the one of last phase - verify.??
I don't quite remember why we run it in the verify phase.
??Change phase of RAT to standard validate will help you.??
We can certainly work around this particular issue; that's not really the
problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
was (Author: zentol):
??Why you check licenses by RAT at the one of last phase - verify.
Change phase of RAT to standard validate will help you.??
I don't quite remember why we run it in the verify phase. We can certainly work
around this particular issue; that's not really the problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638422#comment-17638422
]
Chesnay Schepler edited comment on MSHADE-434 at 11/24/22 10:24 PM:
??Why you check licenses by RAT at the one of last phase - verify.
Change phase of RAT to standard validate will help you.??
I don't quite remember why we run it in the verify phase. We can certainly work
around this particular issue; that's not really the problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
was (Author: zentol):
??Why you check licenses by RAT at the one of last phase - verify.
Change phase of RAT to standard validate will help you.??
I don't quite remember why we run it in the verify phase. We can certainly work
around this particular issue; that's not really the problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638422#comment-17638422
]
Chesnay Schepler edited comment on MSHADE-434 at 11/24/22 10:24 PM:
??Why you check licenses by RAT at the one of last phase - verify.
Change phase of RAT to standard validate will help you.??
I don't quite remember why we run it in the verify phase. We can certainly work
around this particular issue; that's not really the problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
was (Author: zentol):
> Why you check licenses by RAT at the one of last phase - verify.
Change phase of RAT to standard validate will help you.
I don't quite remember why we run it in the verify phase. We can certainly work
around this particular issue; that's not really the problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638422#comment-17638422
]
Chesnay Schepler commented on MSHADE-434:
-
> Why you check licenses by RAT at the one of last phase - verify.
Change phase of RAT to standard validate will help you.
I don't quite remember why we run it in the verify phase. We can certainly work
around this particular issue; that's not really the problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJAVADOC-738) Upgrade commons-text to 1.10.0
[ https://issues.apache.org/jira/browse/MJAVADOC-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MJAVADOC-738. Resolution: Fixed > Upgrade commons-text to 1.10.0 > -- > > Key: MJAVADOC-738 > URL: https://issues.apache.org/jira/browse/MJAVADOC-738 > Project: Maven Javadoc Plugin > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.4.2 > > > Bump commons-text from 1.9 to 1.10.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] cstamas merged pull request #174: [MJAVADOC-738] Upgrade commons-text to 1.10.0
cstamas merged PR #174: URL: https://github.com/apache/maven-javadoc-plugin/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MJAVADOC-738) Upgrade commons-text to 1.10.0
[ https://issues.apache.org/jira/browse/MJAVADOC-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MJAVADOC-738: Assignee: Tamas Cservenak > Upgrade commons-text to 1.10.0 > -- > > Key: MJAVADOC-738 > URL: https://issues.apache.org/jira/browse/MJAVADOC-738 > Project: Maven Javadoc Plugin > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.4.2 > > > Bump commons-text from 1.9 to 1.10.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] cstamas closed pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
cstamas closed pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889 URL: https://github.com/apache/maven-javadoc-plugin/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] cstamas commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
cstamas commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1326842073 Superseded by https://github.com/apache/maven-javadoc-plugin/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] cstamas opened a new pull request, #174: [MJAVADOC-738] Upgrade commons-text to 1.10.0
cstamas opened a new pull request, #174: URL: https://github.com/apache/maven-javadoc-plugin/pull/174 Dependency upgrade to common-text 1.10.0 --- https://issues.apache.org/jira/browse/MJAVADOC-738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
olamy commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1326835523 > Please rename the PR to something like "Bump commons-text version to 1.10.0" and let the show go on. still a Jira issue to create :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MJAVADOC-738) Upgrade commons-text to 1.10.0
Tamas Cservenak created MJAVADOC-738: Summary: Upgrade commons-text to 1.10.0 Key: MJAVADOC-738 URL: https://issues.apache.org/jira/browse/MJAVADOC-738 Project: Maven Javadoc Plugin Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 3.4.2 Bump commons-text from 1.9 to 1.10.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
olamy commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1326831424 > > @Neutius Please show us how the plugin here is affected by the commons-text CVE. Thanks > > Why do you keep on going on about this @olamy? I've offered to rename this PR to a title of your liking. You have not responded to the offer. Let me know how the title should be rephrased and I will happily do so. > > > I fully agree with @olamy, we are not affected here. The CVE does not apply: [..] > > @michael-o and as a conclusion the plugin won't be upgraded? read my comment here https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1295751406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on a diff in pull request #273: [MINDEXER-176] Clean up silos
cstamas commented on code in PR #273:
URL: https://github.com/apache/maven-indexer/pull/273#discussion_r1031827911
##
indexer-core/src/main/java/org/apache/maven/index/updater/IndexDataReader.java:
##
@@ -245,10 +249,18 @@ private IndexDataReadResult readIndexMT( IndexWriter w,
IndexingContext context
}
LOGGER.debug( "Merging silos..." );
-for ( IndexWriter silo : silos )
+for ( IndexWriter siloWriter : siloWriters )
{
-IndexUtils.close( silo );
-w.addIndexes( silo.getDirectory() );
+siloWriter.commit();
+siloWriter.close();
+}
+LOGGER.debug( "Cleanup of silos..." );
Review Comment:
Adjust log msg: this is not cleanup but merge + cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on a diff in pull request #273: [MINDEXER-176] Clean up silos
cstamas commented on code in PR #273: URL: https://github.com/apache/maven-indexer/pull/273#discussion_r1031827837 ## indexer-core/src/main/java/org/apache/maven/index/updater/IndexDataReader.java: ## @@ -245,10 +249,18 @@ private IndexDataReadResult readIndexMT( IndexWriter w, IndexingContext context } LOGGER.debug( "Merging silos..." ); Review Comment: Adjust log msg (this is not merging, just commit+close) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSHARED-1162) Upgrade Plexus Utils to 3.5.0
[ https://issues.apache.org/jira/browse/MSHARED-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-1162. --- Resolution: Fixed Fixed with [159df35aa6803fbe977296faeeeb524d7dd47dca|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=159df35aa6803fbe977296faeeeb524d7dd47dca]. > Upgrade Plexus Utils to 3.5.0 > - > > Key: MSHARED-1162 > URL: https://issues.apache.org/jira/browse/MSHARED-1162 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-impl-4.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1162) Upgrade Plexus Utils to 3.5.0
[ https://issues.apache.org/jira/browse/MSHARED-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638411#comment-17638411 ] Hudson commented on MSHARED-1162: - Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-impl » master #34 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-impl/job/master/34/ > Upgrade Plexus Utils to 3.5.0 > - > > Key: MSHARED-1162 > URL: https://issues.apache.org/jira/browse/MSHARED-1162 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-impl-4.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1165) Upgrade plugins and components in ITs
Michael Osipov created MSHARED-1165: --- Summary: Upgrade plugins and components in ITs Key: MSHARED-1165 URL: https://issues.apache.org/jira/browse/MSHARED-1165 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-reporting-impl Reporter: Michael Osipov Assignee: Michael Osipov Fix For: maven-reporting-impl-4.0.0-M3 * Upgrade Maven Install Plugin to 3.1.0 * Upgrade Maven Site Plugin to 4.0.0-M4 * Upgrade Maven Project Info Reports Plugin to 3.4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1163) Upgrade Maven Reporting API to 4.0.0-M3
Michael Osipov created MSHARED-1163: --- Summary: Upgrade Maven Reporting API to 4.0.0-M3 Key: MSHARED-1163 URL: https://issues.apache.org/jira/browse/MSHARED-1163 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-reporting-impl Reporter: Michael Osipov Assignee: Michael Osipov Fix For: maven-reporting-impl-4.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1164) Upgrade to Doxia/Doxia Sitetools to 2.0.0-M4
Michael Osipov created MSHARED-1164: --- Summary: Upgrade to Doxia/Doxia Sitetools to 2.0.0-M4 Key: MSHARED-1164 URL: https://issues.apache.org/jira/browse/MSHARED-1164 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-reporting-impl Reporter: Michael Osipov Assignee: Michael Osipov Fix For: maven-reporting-impl-4.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1162) Upgrade Plexus Utils to 3.5.0
Michael Osipov created MSHARED-1162: --- Summary: Upgrade Plexus Utils to 3.5.0 Key: MSHARED-1162 URL: https://issues.apache.org/jira/browse/MSHARED-1162 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-reporting-impl Reporter: Michael Osipov Assignee: Michael Osipov Fix For: maven-reporting-impl-4.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MSHARED-831: Reopening for the moment since I found a non-too-intrusive way to solve this problem. Will share a possible solution next after Doxia Sitetools 2.0.0-M4 release. > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638396#comment-17638396
]
Slawomir Jaranowski commented on MSHADE-434:
After some of tests:
Old version 3.1.1
{code}
[DEBUG] Configuring mojo 'org.apache.rat:apache-rat-plugin:0.13:check' with
basic configurator -->
...
[DEBUG] (f) basedir = /Users/slawomir.jaranowski/repos/temp/flink
[DEBUG] (f) project = MavenProject:
org.apache.flink:flink-parent:1.17-SNAPSHOT @
/Users/slawomir.jaranowski/repos/temp/flink/pom.xml
...
{code}
New version:
{code}
DEBUG] Configuring mojo 'org.apache.rat:apache-rat-plugin:0.13:check' with
basic configurator -->
...
[DEBUG] (f) basedir = /Users/slawomir.jaranowski/repos/temp/flink/target
[DEBUG] (f) project = MavenProject:
org.apache.flink:flink-parent:1.17-SNAPSHOT @
/Users/slawomir.jaranowski/repos/temp/flink/target/dependency-reduced-pom.xml
...
{code}
Looks like new reduced pom is now used as project pom ...
Flink build looks a little complicated.
Why you check licenses by RAT at the one of last phase - {{verify}}.
Change phase of RAT to standard {{validate}} will help you.
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] damian-burda commented on pull request #122: Bump commons-text from 1.9 to 1.10.0
damian-burda commented on PR #122: URL: https://github.com/apache/maven-doxia/pull/122#issuecomment-1326760225 Because of https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42889 , could this be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHADE-434) Strange side-effect on rat-plugin
Chesnay Schepler created MSHADE-434:
---
Summary: Strange side-effect on rat-plugin
Key: MSHADE-434
URL: https://issues.apache.org/jira/browse/MSHADE-434
Project: Maven Shade Plugin
Issue Type: Bug
Affects Versions: 3.3.0
Reporter: Chesnay Schepler
When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing anything
else, the Apache Flink builds are getting failed by the rat-plugin, complaining
about a number of files in the root target/ directory.
These files do exist, but are usually excluded by the plugin.
For some reason upgrading the shade-plugin is changing this behavior.
{code:java}
[WARNING] Files with unapproved licenses:
/home/chesnay/dev/repos/flink/flink/target/rat.txt
/home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
/home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
{code}
This is rally strange, and were wondering if you guys have any ideas for
what could going on here.
Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
results in them being excluded again.
This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSHADE-433) Support .kt files when isShadeSourcesContent is enabled
[ https://issues.apache.org/jira/browse/MSHADE-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Grossetie updated MSHADE-433: --- Description: The shadeSourcesContent is really useful but currently it only supports Java files. I think it would be great to support Kotlin files. I'm willing to work on this feature/improvement. was: The `shadeSourcesContent` is really useful but currently it only supports Java files. I think it would be great to support Kotlin files. I'm willing to work on this feature/improvement. > Support .kt files when isShadeSourcesContent is enabled > --- > > Key: MSHADE-433 > URL: https://issues.apache.org/jira/browse/MSHADE-433 > Project: Maven Shade Plugin > Issue Type: Improvement >Affects Versions: 3.4.1 >Reporter: Guillaume Grossetie >Priority: Minor > > The shadeSourcesContent is really useful but currently it only supports Java > files. I think it would be great to support Kotlin files. > > I'm willing to work on this feature/improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHADE-433) Support .kt files when isShadeSourcesContent is enabled
[
https://issues.apache.org/jira/browse/MSHADE-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Grossetie updated MSHADE-433:
---
Description:
{{The shadeSourcesContent is really useful but currently it only supports Java
files. I think it would be great to support Kotlin files.}}
I'm willing to work on this feature/improvement.
was:
The shadeSourcesContent is really useful but currently it only supports Java
files. I think it would be great to support Kotlin files.
I'm willing to work on this feature/improvement.
> Support .kt files when isShadeSourcesContent is enabled
> ---
>
> Key: MSHADE-433
> URL: https://issues.apache.org/jira/browse/MSHADE-433
> Project: Maven Shade Plugin
> Issue Type: Improvement
>Affects Versions: 3.4.1
>Reporter: Guillaume Grossetie
>Priority: Minor
>
> {{The shadeSourcesContent is really useful but currently it only supports
> Java files. I think it would be great to support Kotlin files.}}
>
> I'm willing to work on this feature/improvement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MSHADE-433) Support .kt files when isShadeSourcesContent is enabled
Guillaume Grossetie created MSHADE-433: -- Summary: Support .kt files when isShadeSourcesContent is enabled Key: MSHADE-433 URL: https://issues.apache.org/jira/browse/MSHADE-433 Project: Maven Shade Plugin Issue Type: Improvement Affects Versions: 3.4.1 Reporter: Guillaume Grossetie The `shadeSourcesContent` is really useful but currently it only supports Java files. I think it would be great to support Kotlin files. I'm willing to work on this feature/improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-335) Aggregate mode doesn't use additional repositories
[
https://issues.apache.org/jira/browse/MPMD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638296#comment-17638296
]
Hudson commented on MPMD-335:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-pmd-plugin » master #69
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-pmd-plugin/job/master/69/
> Aggregate mode doesn't use additional repositories
> --
>
> Key: MPMD-335
> URL: https://issues.apache.org/jira/browse/MPMD-335
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.15.0, 3.16.0, 3.17.0, 3.18.0, 3.19.0
>Reporter: Andre Kalamandeen
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.20.0
>
> Attachments: MPMD-335-aggregate-private-repo.zip
>
>
> I've tried to upgrade PMD to 3.16.0 and noticed that when building it tries
> to get artifacts from the default maven repository instead of the repository
> configured in the project.
> This causes issues with the build as certain artifacts are only available in
> the custom repository.
>
> The build error:
> {code:java}
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.16.0:pmd
> failed: org.apache.maven.reporting.MavenReportException:
> org.eclipse.aether.resolution.DependencyResolutionException: The following
> artifacts could not be resolved: [REMOVED]: Failure to find [REMOVED] in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MPMD-335) Aggregate mode doesn't use additional repositories
[
https://issues.apache.org/jira/browse/MPMD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Dangel resolved MPMD-335.
-
Resolution: Fixed
> Aggregate mode doesn't use additional repositories
> --
>
> Key: MPMD-335
> URL: https://issues.apache.org/jira/browse/MPMD-335
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.15.0, 3.16.0, 3.17.0, 3.18.0, 3.19.0
>Reporter: Andre Kalamandeen
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.20.0
>
> Attachments: MPMD-335-aggregate-private-repo.zip
>
>
> I've tried to upgrade PMD to 3.16.0 and noticed that when building it tries
> to get artifacts from the default maven repository instead of the repository
> configured in the project.
> This causes issues with the build as certain artifacts are only available in
> the custom repository.
>
> The build error:
> {code:java}
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.16.0:pmd
> failed: org.apache.maven.reporting.MavenReportException:
> org.eclipse.aether.resolution.DependencyResolutionException: The following
> artifacts could not be resolved: [REMOVED]: Failure to find [REMOVED] in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MPMD-335) Aggregate mode doesn't use additional repositories
[
https://issues.apache.org/jira/browse/MPMD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Dangel closed MPMD-335.
---
> Aggregate mode doesn't use additional repositories
> --
>
> Key: MPMD-335
> URL: https://issues.apache.org/jira/browse/MPMD-335
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.15.0, 3.16.0, 3.17.0, 3.18.0, 3.19.0
>Reporter: Andre Kalamandeen
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.20.0
>
> Attachments: MPMD-335-aggregate-private-repo.zip
>
>
> I've tried to upgrade PMD to 3.16.0 and noticed that when building it tries
> to get artifacts from the default maven repository instead of the repository
> configured in the project.
> This causes issues with the build as certain artifacts are only available in
> the custom repository.
>
> The build error:
> {code:java}
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.16.0:pmd
> failed: org.apache.maven.reporting.MavenReportException:
> org.eclipse.aether.resolution.DependencyResolutionException: The following
> artifacts could not be resolved: [REMOVED]: Failure to find [REMOVED] in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-pmd-plugin] adangel merged pull request #101: [MPMD-335] - Aggregate mode doesn't use additional repositories
adangel merged PR #101: URL: https://github.com/apache/maven-pmd-plugin/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MPDF-81) Override the copyright footer
[ https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638281#comment-17638281 ] Alex O'Ree edited comment on MPDF-81 at 11/24/22 1:23 PM: -- > Given your experience on new configuration that would be required to enhance > pdf results, do you have proposals on model evolution? i can get you a listing of the things i've added some what recently... exsum, as in executive summary, the title of document in the pdf site descriptor that is rendered before the TOC, optional overrideable header/footers for the title page overrideable header/footers for all other pages foStylesOverride - path to a xslt to override the styling of the document tocMaxDeapth number for the maximum depth of the toc title page date, renders a date on the title page, below the title distributionStatement, shown at the bottom of the title page, above the footers was (Author: spyhunter99): > Given your experience on new configuration that would be required to enhance > pdf results, do you have proposals on model evolution? i can get you a listing of the things i've added some what recently... > Override the copyright footer > - > > Key: MPDF-81 > URL: https://issues.apache.org/jira/browse/MPDF-81 > Project: Maven PDF Plugin > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Alex O'Ree >Priority: Major > Labels: intern > Attachments: maven-pdf-plugin2.pdf > > > As of right now, it doesn't look possible to override the content of the > footer which is on all non-title page pages. It currently reads (c) year - > organization All rights reserved. > I don't see anywhere in the code where this is defined or in any of the > resource files. It is in the generated fo files but it's not obvious where > the xslt is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPDF-106) Watermark support
[ https://issues.apache.org/jira/browse/MPDF-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638283#comment-17638283 ] Michael Osipov commented on MPDF-106: - I would rather recommend looking at qpdf: https://qpdf.readthedocs.io/en/stable/cli.html#overlay-and-underlay It is extremely unlike that anyone of us will look into how to do this with FOP. > Watermark support > - > > Key: MPDF-106 > URL: https://issues.apache.org/jira/browse/MPDF-106 > Project: Maven PDF Plugin > Issue Type: New Feature >Reporter: Alex O'Ree >Priority: Major > > In word, you can specify a water mark that is rendered on each page, > typically in the background. It's usually something like draft or > confidential or something like that. Would it be possible to add something > like this to the pdf plugin? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPDF-81) Override the copyright footer
[ https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638281#comment-17638281 ] Alex O'Ree commented on MPDF-81: > Given your experience on new configuration that would be required to enhance > pdf results, do you have proposals on model evolution? i can get you a listing of the things i've added some what recently... > Override the copyright footer > - > > Key: MPDF-81 > URL: https://issues.apache.org/jira/browse/MPDF-81 > Project: Maven PDF Plugin > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Alex O'Ree >Priority: Major > Labels: intern > Attachments: maven-pdf-plugin2.pdf > > > As of right now, it doesn't look possible to override the content of the > footer which is on all non-title page pages. It currently reads (c) year - > organization All rights reserved. > I don't see anywhere in the code where this is defined or in any of the > resource files. It is in the generated fo files but it's not obvious where > the xslt is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPDF-81) Override the copyright footer
[ https://issues.apache.org/jira/browse/MPDF-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638279#comment-17638279 ] Alex O'Ree commented on MPDF-81: is it possible to override the footer text by specifying a property file? doxia-fo.properties in the default package. Although i'm not clear where to put it, it might be an option > Override the copyright footer > - > > Key: MPDF-81 > URL: https://issues.apache.org/jira/browse/MPDF-81 > Project: Maven PDF Plugin > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Alex O'Ree >Priority: Major > Labels: intern > Attachments: maven-pdf-plugin2.pdf > > > As of right now, it doesn't look possible to override the content of the > footer which is on all non-title page pages. It currently reads (c) year - > organization All rights reserved. > I don't see anywhere in the code where this is defined or in any of the > resource files. It is in the generated fo files but it's not obvious where > the xslt is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-pmd-plugin] adangel commented on a diff in pull request #101: [MPMD-335] - Aggregate mode doesn't use additional repositories
adangel commented on code in PR #101: URL: https://github.com/apache/maven-pmd-plugin/pull/101#discussion_r1031494338 ## src/it/MPMD-335-aggregate-classpath-repositories/verify.groovy: ## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +File buildLog = new File( basedir, 'build.log' ) +assert buildLog.exists() +assert !buildLog.text.contains( 'The POM for org.apache.maven.plugins.pmd.it:mpmd335-dependency1:jar:1.0.0-SNAPSHOT is missing, no dependency information available' ) +assert !buildLog.text.contains( 'org.eclipse.aether.resolution.DependencyResolutionException: Could not find artifact org.apache.maven.plugins.pmd.it:mpmd335-dependency1:jar:1.0.0-SNAPSHOT' ) Review Comment: This verifies actually a wrong log message. the test dependency is now package pom and not jar anymore... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPDF-107) Line numbers
Alex O'Ree created MPDF-107: --- Summary: Line numbers Key: MPDF-107 URL: https://issues.apache.org/jira/browse/MPDF-107 Project: Maven PDF Plugin Issue Type: New Feature Reporter: Alex O'Ree Not sure how feasible this is, but it would be great to have the ability to add line numbers on the output. It's typically used for document reviews and whatnot (on page 3 line 301, etc) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPDF-106) Watermark support
Alex O'Ree created MPDF-106: --- Summary: Watermark support Key: MPDF-106 URL: https://issues.apache.org/jira/browse/MPDF-106 Project: Maven PDF Plugin Issue Type: New Feature Reporter: Alex O'Ree In word, you can specify a water mark that is rendered on each page, typically in the background. It's usually something like draft or confidential or something like that. Would it be possible to add something like this to the pdf plugin? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] michael-o commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
michael-o commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1326405758 > > I fully agree with @olamy, we are not affected here. The CVE does not apply: [..] > > @michael-o and as a conclusion the plugin won't be upgraded? No, I did not say that. I approve the PR because I don't see a reason not to merge it, but the abstract provided by the PR does not apply here. So any other committer is free to merge. Those who absolutely need this to happen also this is a non-issue are free to get in touch privately with a committer to sponsor a release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MJAVADOC-685) Deprecate parameter "stylesheet"
[
https://issues.apache.org/jira/browse/MJAVADOC-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MJAVADOC-685.
---
> Deprecate parameter "stylesheet"
>
>
> Key: MJAVADOC-685
> URL: https://issues.apache.org/jira/browse/MJAVADOC-685
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
> Attachments: Screenshot 2021-07-25 at 10.55.44.png
>
>
> When configuring m-javadoc-p 3.3.0 with stylesheet {{maven}} (according to
> https://maven.apache.org/plugins/maven-javadoc-plugin/examples/stylesheet-configuration.html)
> it only loads the simple CSS from
> https://github.com/apache/maven-javadoc-plugin/blob/master/src/main/resources/org/apache/maven/plugins/javadoc/css/stylesheet.css
> which has only very few styling options and is not suited for styling the
> markup emitted by javadoc correctly. This affects both JDK8 and JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJAVADOC-729) Link to Javadoc references from JDK 17
[ https://issues.apache.org/jira/browse/MJAVADOC-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MJAVADOC-729. --- > Link to Javadoc references from JDK 17 > -- > > Key: MJAVADOC-729 > URL: https://issues.apache.org/jira/browse/MJAVADOC-729 > Project: Maven Javadoc Plugin > Issue Type: Improvement > Components: javadoc >Affects Versions: 3.4.1 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.4.2 > > > Currently the external links explaining javadoc features or options from the > site at https://github.com/apache/maven-javadoc-plugin still [point to > https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html|https://github.com/apache/maven-javadoc-plugin/search?q=https%3A%2F%2Fdocs.oracle.com%2Fjavase%2F7%2Fdocs%2Ftechnotes%2Ftools%2Fwindows%2Fjavadoc.html]. > Instead one should leverage the new documentation at > # > https://docs.oracle.com/en/java/javase/17/docs/specs/javadoc/doc-comment-spec.html > (for the standard doclet) and > # https://docs.oracle.com/en/java/javase/17/javadoc/javadoc.html (for the > options of the javadoc tool) > The new documentation provides a better overview of javadoc and also > describes the additions added since Java 7. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] sman-81 commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
sman-81 commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1326399780 > @Neutius Please show us how the plugin here is affected by the commons-text CVE. Thanks Why do you keep on going on about this @olamy? I've offered to rename this PR to a title of your liking. You have not responded to the offer. Let me know how the title should be rephrased and I will happily do so. > I fully agree with @olamy, we are not affected here. The CVE does not apply: [..] @michael-o and as a conclusion the plugin won't be upgraded? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
olamy commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1326378547 @Neutius Please show us how the plugin here is affected by the commons-text CVE. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1326375665 Is there any change requested here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] Neutius commented on pull request #170: Bump commons-text version to 1.10.0 to address CVE-2022-42889
Neutius commented on PR #170: URL: https://github.com/apache/maven-javadoc-plugin/pull/170#issuecomment-1326326494 It seems like this PR still isn't merged. @michael-o Could you please approve this PR? I've now got a solutions architect breathing down my neck, so thanks in advance :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas opened a new pull request, #275: [MINDEXER-179] Update install/deploy
cstamas opened a new pull request, #275: URL: https://github.com/apache/maven-indexer/pull/275 Still 2.x were used. --- https://issues.apache.org/jira/browse/MINDEXER-179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINDEXER-179) Update install/deploy plugins to latest
Tamas Cservenak created MINDEXER-179: Summary: Update install/deploy plugins to latest Key: MINDEXER-179 URL: https://issues.apache.org/jira/browse/MINDEXER-179 Project: Maven Indexer Issue Type: Task Reporter: Tamas Cservenak Assignee: Tamas Cservenak Fix For: 7.0.1 Changes: * m-install-p 3.1.0 * m-deploy-p 3.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-175) Examples does not need to be deployed
[ https://issues.apache.org/jira/browse/MINDEXER-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-175: Assignee: Tamas Cservenak > Examples does not need to be deployed > - > > Key: MINDEXER-175 > URL: https://issues.apache.org/jira/browse/MINDEXER-175 > Project: Maven Indexer > Issue Type: Task >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.0.1 > > > They are really just showcase and deploying them is a waste of bytes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-indexer] cstamas opened a new pull request, #274: [MINDEXER-175] Do not deploy examples
cstamas opened a new pull request, #274: URL: https://github.com/apache/maven-indexer/pull/274 They are really just source examples, are waste of bytes to deploy them to MC. --- https://issues.apache.org/jira/browse/MINDEXER-175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINDEXER-175) Examples does not need to be deployed
[ https://issues.apache.org/jira/browse/MINDEXER-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MINDEXER-175: - Fix Version/s: 7.0.1 > Examples does not need to be deployed > - > > Key: MINDEXER-175 > URL: https://issues.apache.org/jira/browse/MINDEXER-175 > Project: Maven Indexer > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > Fix For: 7.0.1 > > > They are really just showcase and deploying them is a waste of bytes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-indexer] cstamas commented on pull request #273: [MINDEXER-176] Clean up silos
cstamas commented on PR #273: URL: https://github.com/apache/maven-indexer/pull/273#issuecomment-1326088575 @mbien pls take a peek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINDEXER-176) Core's IndexDataReader does not clean up after itself
[ https://issues.apache.org/jira/browse/MINDEXER-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-176: Assignee: Tamas Cservenak > Core's IndexDataReader does not clean up after itself > - > > Key: MINDEXER-176 > URL: https://issues.apache.org/jira/browse/MINDEXER-176 > Project: Maven Indexer > Issue Type: Bug >Affects Versions: 7.0.0 >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.0.1 > > > As MT index update was implemented that uses split "silos", it seems that > silos are not cleaned up. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-indexer] cstamas opened a new pull request, #273: [MINDEXER-176] Clean up silos
cstamas opened a new pull request, #273: URL: https://github.com/apache/maven-indexer/pull/273 The MT updater did not clean up silos after done. --- https://issues.apache.org/jira/browse/MINDEXER-176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
