[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown
[
https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645956#comment-17645956
]
ASF GitHub Bot commented on DOXIA-569:
--
hboutemy commented on code in PR #128:
URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1045495865
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java:
##
@@ -0,0 +1,147 @@
+package org.apache.maven.doxia.module.markdown;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.doxia.markup.TextMarkup;
+import org.codehaus.plexus.util.StringUtils;
+
+/**
+ * This interface defines all markups and syntaxes used by the Markdown
format.
+ */
+@SuppressWarnings( "checkstyle:interfaceistype" )
+public interface MarkdownMarkup
+extends TextMarkup
+{
+// --
+// Markup separators
+// --
+
+/** APT backslash markup char: '\\' */
Review Comment:
as you can see, I created the sink by copy/pasting APT sink and updating
content: yes, I did not change each and every comment
> Add Markdown Sink to be able to convert anything to Markdown
>
>
> Key: DOXIA-569
> URL: https://issues.apache.org/jira/browse/DOXIA-569
> Project: Maven Doxia
> Issue Type: New Feature
> Components: Module - Markdown
>Affects Versions: 1.8
>Reporter: Herve Boutemy
>Priority: Major
> Labels: intern
>
> Markdown is well known: having Markdown Sink would help people transform
> existing content to Markdown
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)
hboutemy commented on code in PR #128:
URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1045495865
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java:
##
@@ -0,0 +1,147 @@
+package org.apache.maven.doxia.module.markdown;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.doxia.markup.TextMarkup;
+import org.codehaus.plexus.util.StringUtils;
+
+/**
+ * This interface defines all markups and syntaxes used by the Markdown
format.
+ */
+@SuppressWarnings( "checkstyle:interfaceistype" )
+public interface MarkdownMarkup
+extends TextMarkup
+{
+// --
+// Markup separators
+// --
+
+/** APT backslash markup char: '\\' */
Review Comment:
as you can see, I created the sink by copy/pasting APT sink and updating
content: yes, I did not change each and every comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-307) Support listing of workspace artifacts
[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645953#comment-17645953
]
ASF GitHub Bot commented on MRESOLVER-307:
--
laeubi commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1346011941
> implement any newly added methods in support class, to retain source
compatibility
I still don'T get why this is considdered more "source compatible" than a
default interface method because both seem only source compatible?!?
But anyways so I would
1. add `noimplement` / `noextend`
2. add an `AbstractWorkspaceReaderClass` (?)
3. Wait for 2.0 ...
> Support listing of workspace artifacts
> --
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] laeubi commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts
laeubi commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1346011941 > implement any newly added methods in support class, to retain source compatibility I still don'T get why this is considdered more "source compatible" than a default interface method because both seem only source compatible?!? But anyways so I would 1. add `noimplement` / `noextend` 2. add an `AbstractWorkspaceReaderClass` (?) 3. Wait for 2.0 ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #115: Bump jettyVersion from 9.4.49.v20220914 to 11.0.13
dependabot[bot] commented on PR #115: URL: https://github.com/apache/maven-site-plugin/pull/115#issuecomment-1346010220 OK, I won't notify you about version 11.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] slachiewicz commented on pull request #115: Bump jettyVersion from 9.4.49.v20220914 to 11.0.13
slachiewicz commented on PR #115: URL: https://github.com/apache/maven-site-plugin/pull/115#issuecomment-1346010184 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-307) Support listing of workspace artifacts
[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645945#comment-17645945
]
ASF GitHub Bot commented on MRESOLVER-307:
--
cstamas commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1346002536
It is a bit japicm as well, see here
https://github.com/siom79/japicmp/issues/201
But presence of "indirection" in form of support class allows us:
* to move iface from source to binary only compat change (then build would
not fail)
* implement any newly added methods in support class, to retain source
compatibility
I bet there are cases like in Maven as well, but somewhere we have to start
:smile:
> Support listing of workspace artifacts
> --
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] cstamas commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts
cstamas commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1346002536 It is a bit japicm as well, see here https://github.com/siom79/japicmp/issues/201 But presence of "indirection" in form of support class allows us: * to move iface from source to binary only compat change (then build would not fail) * implement any newly added methods in support class, to retain source compatibility I bet there are cases like in Maven as well, but somewhere we have to start :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #115: Bump jettyVersion from 9.4.49.v20220914 to 11.0.13
dependabot[bot] commented on PR #115: URL: https://github.com/apache/maven-site-plugin/pull/115#issuecomment-1345999316 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] michael-o closed pull request #115: Bump jettyVersion from 9.4.49.v20220914 to 11.0.13
michael-o closed pull request #115: Bump jettyVersion from 9.4.49.v20220914 to 11.0.13 URL: https://github.com/apache/maven-site-plugin/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-307) Support listing of workspace artifacts
[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645941#comment-17645941
]
ASF GitHub Bot commented on MRESOLVER-307:
--
laeubi commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345995022
> allows us to introduce methods that would be otherwise breaking, and
provide some default logic.
I'm not really understand the difference to a default implemented interface
method?!?
> FORBIDS direct implementation
At laest maven extends AND implements this interface, I think this will
still be possible but "discouraged"?
> Support listing of workspace artifacts
> --
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] laeubi commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts
laeubi commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345995022 > allows us to introduce methods that would be otherwise breaking, and provide some default logic. I'm not really understand the difference to a default implemented interface method?!? > FORBIDS direct implementation At laest maven extends AND implements this interface, I think this will still be possible but "discouraged"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-307) Support listing of workspace artifacts
[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645939#comment-17645939
]
ASF GitHub Bot commented on MRESOLVER-307:
--
cstamas commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345989051
In short: japicmp fails with a reason, this is a breakage.
Longer story: We have a page
https://maven.apache.org/resolver/api-compatibility.html that explains how we
"expect" clients to behave, and what we promise. In this case, this PR breaks
our promise. This is why common (but not applied to all) approach is visible on
this example:
Listener interface
https://github.com/apache/maven-resolver/blob/ce54f7f371eaf37657413d7b7135171aa88cba40/maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferListener.java
FORBIDS direct implementation, instead, it directs you to
https://github.com/apache/maven-resolver/blob/ce54f7f371eaf37657413d7b7135171aa88cba40/maven-resolver-api/src/main/java/org/eclipse/aether/transfer/AbstractTransferListener.java
support class. Now, we cannot "enforce" this in any way (so "bad" clients
still can directly implement interface), but according to that page, then they
are "on their own". The presence of support class in chain `iface -> support
class -> impl` allows us to introduce methods that would be otherwise breaking.
Problem is, WorkspaceReader is NOT introduced in that set (see japicmp
config). We may change that of course
> Support listing of workspace artifacts
> --
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] cstamas commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts
cstamas commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345989051 In short: japicmp fails with a reason, this is a breakage. Longer story: We have a page https://maven.apache.org/resolver/api-compatibility.html that explains how we "expect" clients to behave, and what we promise. In this case, this PR breaks our promise. This is why common (but not applied to all) approach is visible on this example: Listener interface https://github.com/apache/maven-resolver/blob/ce54f7f371eaf37657413d7b7135171aa88cba40/maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferListener.java FORBIDS direct implementation, instead, it directs you to https://github.com/apache/maven-resolver/blob/ce54f7f371eaf37657413d7b7135171aa88cba40/maven-resolver-api/src/main/java/org/eclipse/aether/transfer/AbstractTransferListener.java support class. Now, we cannot "enforce" this in any way (so "bad" clients still can directly implement interface), but according to that page, then they are "on their own". The presence of support class in chain `iface -> support class -> impl` allows us to introduce methods that would be otherwise breaking. Problem is, WorkspaceReader is NOT introduced in that set (see japicmp config). We may change that of course -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-307) Support listing of workspace artifacts
[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645919#comment-17645919
]
ASF GitHub Bot commented on MRESOLVER-307:
--
laeubi commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345910655
> implements this class, but also Tycho, m2e
Tycho/m2e is actually the reason I'd like to have such method :-)
> so a LOT of breakage here...
That's the question, do we really "break" anything? As it is a default
implemented method, everything will compile as before and no one will really
notice even though it is not 100% binary compatible.
> Ideally, I'd make this in 2.0 of resolver,
Is there actually any plan for 2.0 release anywhere soon or is it more
"sometimes in the future"? Should I target another branch? If 2.x is the way to
go I'll update this to not use a default method then, beside this do you think
this can be done that way or are there any other concerns?
> and would introduce "safety measures" like for the rest: iface directly
should not be implemented, but provide a "support class"?
What do you mean by "support class"? And how is it more safe than in
interface? I think interfaces are more appropriate for this and are as safe as
an (abstract) class?
> Support listing of workspace artifacts
> --
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] laeubi commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts
laeubi commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345910655 > implements this class, but also Tycho, m2e Tycho/m2e is actually the reason I'd like to have such method :-) > so a LOT of breakage here... That's the question, do we really "break" anything? As it is a default implemented method, everything will compile as before and no one will really notice even though it is not 100% binary compatible. > Ideally, I'd make this in 2.0 of resolver, Is there actually any plan for 2.0 release anywhere soon or is it more "sometimes in the future"? Should I target another branch? If 2.x is the way to go I'll update this to not use a default method then, beside this do you think this can be done that way or are there any other concerns? > and would introduce "safety measures" like for the rest: iface directly should not be implemented, but provide a "support class"? What do you mean by "support class"? And how is it more safe than in interface? I think interfaces are more appropriate for this and are as safe as an (abstract) class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] closed pull request #245: Bump jetty-webapp from 9.4.45.v20220203 to 11.0.12
dependabot[bot] closed pull request #245: Bump jetty-webapp from 9.4.45.v20220203 to 11.0.12 URL: https://github.com/apache/maven-indexer/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request, #115: Bump jettyVersion from 9.4.49.v20220914 to 11.0.13
dependabot[bot] opened a new pull request, #115: URL: https://github.com/apache/maven-site-plugin/pull/115 Bumps `jettyVersion` from 9.4.49.v20220914 to 11.0.13. Updates `jetty-server` from 9.4.49.v20220914 to 11.0.13 Release notes Sourced from https://github.com/eclipse/jetty.project/releases;>jetty-server's releases. 11.0.13 Special Thanks to the following Eclipse Jetty community members https://github.com/janvojt;>@janvojt (Jan Vojt) https://github.com/joschi;>@joschi (Jochen Schalanda) https://github.com/leonchen83;>@leonchen83 (Baoyi Chen) https://github.com/cowwoc;>@cowwoc (Gili Tzabari) https://github.com/Vlatombe;>@Vlatombe (Vincent Latombe) Changelog https://github-redirect.dependabot.com/eclipse/jetty.project/issues/9006;>#9006 - WebSocket Message InputStream read() returns signed byte https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8913;>#8913 - Review Jetty XML syntax to allow calling JDK methods https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8905;>#8905 - GzipHandler fails to set Vary header on 304 responses https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8900;>#8900 - Improved documentation about virtual threads. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8897;>#8897 - Update Conditional request handling for RFC7232 https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8895;>#8895 - Generate downloadable version of javadocs documentation in website deploy script https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8863;>#8863 - Provide a possibility to name virtual threads https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8810;>#8810 - ArrayRetainableByteBufferPool inefficiently calculates bucket indices https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8786;>#8786 - KeyStoreScanner is not able to monitor a symlink file and always resolves to the target. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8779;>#8779 - CompactPathRule drops query section on use https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8770;>#8770 - Review whether to send request body in redirects https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8753;>#8753 - Starting HttpClient with destinationIdleTimeout set throws NPE. (https://github.com/janvojt;>@janvojt) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8750;>#8750 - AbstractProxyServlet.onServerResponseHeaders does not support headers with empty values https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8743;>#8743 - Add log.isDebugEnabled() to reduce string allocation (https://github.com/leonchen83;>@leonchen83) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8721;>#8721 - jetty:effective-web-xml doesn't generate quickstart information for web fragment jars that contain META-INF/resources https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8716;>#8716 - Multiple Host header values handled poorly https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8712;>#8712 - ELContextCleaner no longer needed. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8688;>#8688 - Fix traversal bug on extraction of bad jar/zip files during jetty-start https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8682;>#8682 - expand jetty properties when generating dry-run command line https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8678;>#8678 - Jetty client is not responding to GO_AWAY packet received from (Jetty) Server and continue to send traffic on same connection https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8628;>#8628 - Pseudo restore PathMappings.getMatch(String) for backwards compat reasons https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8623;>#8623 - Use AutoLock in InputStreamResponseListener https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8600;>#8600 - Allow to pass instances of ClientConfig and Config to Hazelcast data store factory (https://github.com/Vlatombe;>@Vlatombe) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8591;>#8591 - Indicate units of HttpClient properties (https://github.com/cowwoc;>@cowwoc) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8558;>#8558 - Idle timeout occured sometimes on HTTP/2 client with InputStreamResponseListener https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8536;>#8536 - HotSwapHandler race condition https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8473;>#8473 - add getter for the WebSocketUpgradeHandler configuration
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #245: Bump jetty-webapp from 9.4.45.v20220203 to 11.0.12
dependabot[bot] commented on PR #245: URL: https://github.com/apache/maven-indexer/pull/245#issuecomment-1345834157 Superseded by #281. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #281: Bump jetty-webapp from 9.4.49.v20220914 to 11.0.13
dependabot[bot] opened a new pull request, #281: URL: https://github.com/apache/maven-indexer/pull/281 Bumps [jetty-webapp](https://github.com/eclipse/jetty.project) from 9.4.49.v20220914 to 11.0.13. Release notes Sourced from https://github.com/eclipse/jetty.project/releases;>jetty-webapp's releases. 11.0.13 Special Thanks to the following Eclipse Jetty community members https://github.com/janvojt;>@janvojt (Jan Vojt) https://github.com/joschi;>@joschi (Jochen Schalanda) https://github.com/leonchen83;>@leonchen83 (Baoyi Chen) https://github.com/cowwoc;>@cowwoc (Gili Tzabari) https://github.com/Vlatombe;>@Vlatombe (Vincent Latombe) Changelog https://github-redirect.dependabot.com/eclipse/jetty.project/issues/9006;>#9006 - WebSocket Message InputStream read() returns signed byte https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8913;>#8913 - Review Jetty XML syntax to allow calling JDK methods https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8905;>#8905 - GzipHandler fails to set Vary header on 304 responses https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8900;>#8900 - Improved documentation about virtual threads. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8897;>#8897 - Update Conditional request handling for RFC7232 https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8895;>#8895 - Generate downloadable version of javadocs documentation in website deploy script https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8863;>#8863 - Provide a possibility to name virtual threads https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8810;>#8810 - ArrayRetainableByteBufferPool inefficiently calculates bucket indices https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8786;>#8786 - KeyStoreScanner is not able to monitor a symlink file and always resolves to the target. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8779;>#8779 - CompactPathRule drops query section on use https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8770;>#8770 - Review whether to send request body in redirects https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8753;>#8753 - Starting HttpClient with destinationIdleTimeout set throws NPE. (https://github.com/janvojt;>@janvojt) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8750;>#8750 - AbstractProxyServlet.onServerResponseHeaders does not support headers with empty values https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8743;>#8743 - Add log.isDebugEnabled() to reduce string allocation (https://github.com/leonchen83;>@leonchen83) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8721;>#8721 - jetty:effective-web-xml doesn't generate quickstart information for web fragment jars that contain META-INF/resources https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8716;>#8716 - Multiple Host header values handled poorly https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8712;>#8712 - ELContextCleaner no longer needed. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8688;>#8688 - Fix traversal bug on extraction of bad jar/zip files during jetty-start https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8682;>#8682 - expand jetty properties when generating dry-run command line https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8678;>#8678 - Jetty client is not responding to GO_AWAY packet received from (Jetty) Server and continue to send traffic on same connection https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8628;>#8628 - Pseudo restore PathMappings.getMatch(String) for backwards compat reasons https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8623;>#8623 - Use AutoLock in InputStreamResponseListener https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8600;>#8600 - Allow to pass instances of ClientConfig and Config to Hazelcast data store factory (https://github.com/Vlatombe;>@Vlatombe) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8591;>#8591 - Indicate units of HttpClient properties (https://github.com/cowwoc;>@cowwoc) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8558;>#8558 - Idle timeout occured sometimes on HTTP/2 client with InputStreamResponseListener https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8536;>#8536 - HotSwapHandler race condition https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8473;>#8473 - add getter for the WebSocketUpgradeHandler configuration
[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #136: Bump maven-reporting-impl from 3.1.0 to 3.2.0
dependabot[bot] commented on PR #136: URL: https://github.com/apache/maven-invoker-plugin/pull/136#issuecomment-1345676937 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o closed pull request #136: Bump maven-reporting-impl from 3.1.0 to 3.2.0
michael-o closed pull request #136: Bump maven-reporting-impl from 3.1.0 to 3.2.0 URL: https://github.com/apache/maven-invoker-plugin/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o commented on pull request #136: Bump maven-reporting-impl from 3.1.0 to 3.2.0
michael-o commented on PR #136: URL: https://github.com/apache/maven-invoker-plugin/pull/136#issuecomment-1345676927 Superseded by #155. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o opened a new pull request, #155: [MINVOKER-315] Upgrade Maven Reporting API to 3.1.1/Maven Reporting I…
michael-o opened a new pull request, #155: URL: https://github.com/apache/maven-invoker-plugin/pull/155 …mpl to 3.2.0 This closes #155 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MINVOKER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MINVOKER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MINVOKER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINVOKER-315) Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0
Michael Osipov created MINVOKER-315: --- Summary: Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0 Key: MINVOKER-315 URL: https://issues.apache.org/jira/browse/MINVOKER-315 Project: Maven Invoker Plugin Issue Type: Dependency upgrade Affects Versions: 3.3.0 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645857#comment-17645857 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345666091 Um, unsure what this is: ``` Error: Errors: Error:MavenITmng4162ReportingMigrationTest.testit:66 NullPointer Warning: Tmng6189SiteReportPluginsWarningTest.testit:54 » Verification Text not found in log: [WARNING] Reporting configuration should be done in section ``` > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345666091 Um, unsure what this is: ``` Error: Errors: Error:MavenITmng4162ReportingMigrationTest.testit:66 NullPointer Warning: Tmng6189SiteReportPluginsWarningTest.testit:54 » Verification Text not found in log: [WARNING] Reporting configuration should be done in section ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINVOKER-125) Global variable about the target directory into the groovy scripts
[
https://issues.apache.org/jira/browse/MINVOKER-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MINVOKER-125:
Summary: Global variable about the target directory into the groovy scripts
(was: Global variable about the target folder into the groovy scripts.)
> Global variable about the target directory into the groovy scripts
> --
>
> Key: MINVOKER-125
> URL: https://issues.apache.org/jira/browse/MINVOKER-125
> Project: Maven Invoker Plugin
> Issue Type: New Feature
>Affects Versions: 1.5
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Often (may be everytime) groovy scripts (post-build) which are doing work in
> relationship with integration-tests must access the *target* folder to check
> results etc. But currently i have to hard code the folder "target" by
> contrast in the pom.xml there already exists a good replacement for that
> $\{project.build.directory} so it would be very helpful to have an context
> information like "target" which represents the target folder.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINVOKER-125) Global variable about the target directory into the groovy scripts
[
https://issues.apache.org/jira/browse/MINVOKER-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MINVOKER-125:
Description: Often (may be everytime) groovy scripts (post-build) which are
doing work in relationship with integration-tests must access the *target*
directory to check results etc. But currently i have to hard code the directory
"target" by contrast in the pom.xml there already exists a good replacement for
that $\{project.build.directory} so it would be very helpful to have an context
information like "target" which represents the target directory. (was: Often
(may be everytime) groovy scripts (post-build) which are doing work in
relationship with integration-tests must access the *target* folder to check
results etc. But currently i have to hard code the folder "target" by contrast
in the pom.xml there already exists a good replacement for that
$\{project.build.directory} so it would be very helpful to have an context
information like "target" which represents the target folder.)
> Global variable about the target directory into the groovy scripts
> --
>
> Key: MINVOKER-125
> URL: https://issues.apache.org/jira/browse/MINVOKER-125
> Project: Maven Invoker Plugin
> Issue Type: New Feature
>Affects Versions: 1.5
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Often (may be everytime) groovy scripts (post-build) which are doing work in
> relationship with integration-tests must access the *target* directory to
> check results etc. But currently i have to hard code the directory "target"
> by contrast in the pom.xml there already exists a good replacement for that
> $\{project.build.directory} so it would be very helpful to have an context
> information like "target" which represents the target directory.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MNGSITE-503) add .well-known/security.txt
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MNGSITE-503. -- Resolution: Fixed > add .well-known/security.txt > > > Key: MNGSITE-503 > URL: https://issues.apache.org/jira/browse/MNGSITE-503 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: security > > As per consensus on the mailing list (+1 from [~rmannibucau] and me), we > should add a file `.well-known/security.txt`. > I will prepare a PR. > References: > * [.well-known/security.txt at maven.apache.org > (mail-archive.com)|https://www.mail-archive.com/dev@maven.apache.org/msg128366.html] > * [.well-known/security.txt at maven.apache.org-Apache Mail > Archives|https://lists.apache.org/thread/tvfg1lx9nd72c9t4t4s3zlx6l0tpnmwy] > * [RFC 9116|https://datatracker.ietf.org/doc/html/rfc9116] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNGSITE-503) add .well-known/security.txt
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645856#comment-17645856 ] Hudson commented on MNGSITE-503: Build succeeded in Jenkins: Maven » Maven TLP » maven-site » master #194 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site/job/master/194/ > add .well-known/security.txt > > > Key: MNGSITE-503 > URL: https://issues.apache.org/jira/browse/MNGSITE-503 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: security > > As per consensus on the mailing list (+1 from [~rmannibucau] and me), we > should add a file `.well-known/security.txt`. > I will prepare a PR. > References: > * [.well-known/security.txt at maven.apache.org > (mail-archive.com)|https://www.mail-archive.com/dev@maven.apache.org/msg128366.html] > * [.well-known/security.txt at maven.apache.org-Apache Mail > Archives|https://lists.apache.org/thread/tvfg1lx9nd72c9t4t4s3zlx6l0tpnmwy] > * [RFC 9116|https://datatracker.ietf.org/doc/html/rfc9116] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNGSITE-503) add .well-known/security.txt
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645855#comment-17645855 ] ASF GitHub Bot commented on MNGSITE-503: bmarwell merged PR #354: URL: https://github.com/apache/maven-site/pull/354 > add .well-known/security.txt > > > Key: MNGSITE-503 > URL: https://issues.apache.org/jira/browse/MNGSITE-503 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: security > > As per consensus on the mailing list (+1 from [~rmannibucau] and me), we > should add a file `.well-known/security.txt`. > I will prepare a PR. > References: > * [.well-known/security.txt at maven.apache.org > (mail-archive.com)|https://www.mail-archive.com/dev@maven.apache.org/msg128366.html] > * [.well-known/security.txt at maven.apache.org-Apache Mail > Archives|https://lists.apache.org/thread/tvfg1lx9nd72c9t4t4s3zlx6l0tpnmwy] > * [RFC 9116|https://datatracker.ietf.org/doc/html/rfc9116] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-site] bmarwell merged pull request #354: [MNGSITE-503] add .well-known/security.txt
bmarwell merged PR #354: URL: https://github.com/apache/maven-site/pull/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645854#comment-17645854
]
ASF GitHub Bot commented on MNG-7622:
-
michael-o commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045299177
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -144,4 +152,17 @@ private static BiConsumer
transformer(RepositorySystemSession sessio
};
}
}
+
+/**
+ * The actual transformation: visible for testing.
+ */
+static InputStream transform(Path pomFile, TransformerContext context)
throws IOException, XmlPullParserException {
+XmlStreamReader reader =
ReaderFactory.newXmlReader(Files.newInputStream(pomFile));
+XmlPullParser parser = new MXParser(
EntityReplacementMap.defaultEntityReplacementMap);
Review Comment:
whitespace
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
michael-o commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045299177
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -144,4 +152,17 @@ private static BiConsumer
transformer(RepositorySystemSession sessio
};
}
}
+
+/**
+ * The actual transformation: visible for testing.
+ */
+static InputStream transform(Path pomFile, TransformerContext context)
throws IOException, XmlPullParserException {
+XmlStreamReader reader =
ReaderFactory.newXmlReader(Files.newInputStream(pomFile));
+XmlPullParser parser = new MXParser(
EntityReplacementMap.defaultEntityReplacementMap);
Review Comment:
whitespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645853#comment-17645853 ] ASF GitHub Bot commented on MNG-7622: - michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345658760 > @michael-o so ultimately, what changes did you request on this PR? The only the comment. > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345658760 > @michael-o so ultimately, what changes did you request on this PR? The only the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645852#comment-17645852 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345658118 @michael-o so ultimately, what changes did you request on this PR? > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345658118 @michael-o so ultimately, what changes did you request on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-503) add .well-known/security.txt
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645850#comment-17645850 ] Hudson commented on MNGSITE-503: Build failed in Jenkins: Maven » Maven TLP » maven-site » PR-354 #10 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site/job/PR-354/10/ > add .well-known/security.txt > > > Key: MNGSITE-503 > URL: https://issues.apache.org/jira/browse/MNGSITE-503 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: security > > As per consensus on the mailing list (+1 from [~rmannibucau] and me), we > should add a file `.well-known/security.txt`. > I will prepare a PR. > References: > * [.well-known/security.txt at maven.apache.org > (mail-archive.com)|https://www.mail-archive.com/dev@maven.apache.org/msg128366.html] > * [.well-known/security.txt at maven.apache.org-Apache Mail > Archives|https://lists.apache.org/thread/tvfg1lx9nd72c9t4t4s3zlx6l0tpnmwy] > * [RFC 9116|https://datatracker.ietf.org/doc/html/rfc9116] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNGSITE-503) add .well-known/security.txt
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645849#comment-17645849 ] ASF GitHub Bot commented on MNGSITE-503: bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345653699 > This is not what I understand. The specification is not concrete enough for me. That's a legit statement. However, it could take some considerable amount of time until the issue you opened has been resolved (i.e. clarification and fix of the example). As @bdemers, @hboutemy and @slawekjaranowski are okay with the state as-is, let’s merge it and come back later if it needs attention. > add .well-known/security.txt > > > Key: MNGSITE-503 > URL: https://issues.apache.org/jira/browse/MNGSITE-503 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: security > > As per consensus on the mailing list (+1 from [~rmannibucau] and me), we > should add a file `.well-known/security.txt`. > I will prepare a PR. > References: > * [.well-known/security.txt at maven.apache.org > (mail-archive.com)|https://www.mail-archive.com/dev@maven.apache.org/msg128366.html] > * [.well-known/security.txt at maven.apache.org-Apache Mail > Archives|https://lists.apache.org/thread/tvfg1lx9nd72c9t4t4s3zlx6l0tpnmwy] > * [RFC 9116|https://datatracker.ietf.org/doc/html/rfc9116] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345653699 > This is not what I understand. The specification is not concrete enough for me. That's a legit statement. However, it could take some considerable amount of time until the issue you opened has been resolved (i.e. clarification and fix of the example). As @bdemers, @hboutemy and @slawekjaranowski are okay with the state as-is, let’s merge it and come back later if it needs attention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-385) Upgrade Parent to 29
[ https://issues.apache.org/jira/browse/MPOM-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-385. Resolution: Fixed > Upgrade Parent to 29 > > > Key: MPOM-385 > URL: https://issues.apache.org/jira/browse/MPOM-385 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-39 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPOM-385) Upgrade Parent to 29
[ https://issues.apache.org/jira/browse/MPOM-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645847#comment-17645847 ] Slawomir Jaranowski commented on MPOM-385: -- Done in https://github.com/apache/maven-parent/commit/eac4aa989a9035002943c9fc8f8140a7a2dcff76 > Upgrade Parent to 29 > > > Key: MPOM-385 > URL: https://issues.apache.org/jira/browse/MPOM-385 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-39 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPOM-385) Upgrade Parent to 29
Slawomir Jaranowski created MPOM-385: Summary: Upgrade Parent to 29 Key: MPOM-385 URL: https://issues.apache.org/jira/browse/MPOM-385 Project: Maven POMs Issue Type: Dependency upgrade Components: maven Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: MAVEN-39 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-surefire] michael-o opened a new pull request, #582: [SUREFIRE-2133] Make anchors start *before* the headings
michael-o opened a new pull request, #582: URL: https://github.com/apache/maven-surefire/pull/582 This closes #582 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2133) Make anchors start *before* the headings
[ https://issues.apache.org/jira/browse/SUREFIRE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-2133: - Description: Right now anchors start after the actual heading which means that if a user opens up the anchor the browser will scroll below the heading outside of the viewport. Ideally, the user shall see the heading and the following content. (was: In the last improvement of FML elements were wrapped in anchors. While this seems to be a good idea it causes trouble with HTML output since CSS rules then completely change the style of the anchor body. It is then a CSS trickery to differential between anchors and links. Since anchors itself are deprecated (anchors without href) and the nearest element should have the id we will pull up the anchor above the target element.) > Make anchors start *before* the headings > > > Key: SUREFIRE-2133 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2133 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Surefire Report Plugin >Affects Versions: 3.0.0-M7 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M8 > > > Right now anchors start after the actual heading which means that if a user > opens up the anchor the browser will scroll below the heading outside of the > viewport. Ideally, the user shall see the heading and the following content. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2133) Make anchors start *before* the headings
[ https://issues.apache.org/jira/browse/SUREFIRE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-2133: - Summary: Make anchors start *before* the headings (was: Don't wrap elements in anchors) > Make anchors start *before* the headings > > > Key: SUREFIRE-2133 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2133 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Surefire Report Plugin >Affects Versions: 3.0.0-M7 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M8 > > > In the last improvement of FML elements were wrapped in anchors. While this > seems to be a good idea it causes trouble with HTML output since CSS rules > then completely change the style of the anchor body. It is then a CSS > trickery to differential between anchors and links. Since anchors itself are > deprecated (anchors without href) and the nearest element should have the id > we will pull up the anchor above the target element. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2133) Don't wrap elements in anchors
[ https://issues.apache.org/jira/browse/SUREFIRE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-2133: - Issue Type: Improvement (was: Task) > Don't wrap elements in anchors > -- > > Key: SUREFIRE-2133 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2133 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Surefire Report Plugin >Affects Versions: 3.0.0-M7 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M8 > > > In the last improvement of FML elements were wrapped in anchors. While this > seems to be a good idea it causes trouble with HTML output since CSS rules > then completely change the style of the anchor body. It is then a CSS > trickery to differential between anchors and links. Since anchors itself are > deprecated (anchors without href) and the nearest element should have the id > we will pull up the anchor above the target element. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1174) Don't wrap elements in anchors
[
https://issues.apache.org/jira/browse/MSHARED-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSHARED-1174:
Issue Type: Improvement (was: Task)
> Don't wrap elements in anchors
> --
>
> Key: MSHARED-1174
> URL: https://issues.apache.org/jira/browse/MSHARED-1174
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl-4.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M4
>
>
> In the last improvement of the {{AbstractMavenReportRenderer}} elements were
> wrapped in anchors. While this seems to be a good idea it causes trouble with
> HTML output since CSS rules then completely change the style of the anchor
> body. It is then a CSS trickery to differential between anchors and links.
> Since anchors itself are deprecated (anchors without href) and the nearest
> element should have the id we will pull up the anchor above the target
> element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Moved] (SUREFIRE-2133) Don't wrap elements in anchors
[ https://issues.apache.org/jira/browse/SUREFIRE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved DOXIA-683 to SUREFIRE-2133: Component/s: Maven Surefire Report Plugin (was: Module - Fml) Fix Version/s: 3.0.0-M8 (was: 2.0.0-M5) Key: SUREFIRE-2133 (was: DOXIA-683) Affects Version/s: 3.0.0-M7 (was: 2.0.0-M4) Project: Maven Surefire (was: Maven Doxia) > Don't wrap elements in anchors > -- > > Key: SUREFIRE-2133 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2133 > Project: Maven Surefire > Issue Type: Task > Components: Maven Surefire Report Plugin >Affects Versions: 3.0.0-M7 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M8 > > > In the last improvement of FML elements were wrapped in anchors. While this > seems to be a good idea it causes trouble with HTML output since CSS rules > then completely change the style of the anchor body. It is then a CSS > trickery to differential between anchors and links. Since anchors itself are > deprecated (anchors without href) and the nearest element should have the id > we will pull up the anchor above the target element. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIA-680) Don't wrap elements in anchors
[ https://issues.apache.org/jira/browse/DOXIA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-680: - Issue Type: Improvement (was: Task) > Don't wrap elements in anchors > -- > > Key: DOXIA-680 > URL: https://issues.apache.org/jira/browse/DOXIA-680 > Project: Maven Doxia > Issue Type: Improvement > Components: Module - Fml >Affects Versions: 2.0.0-M4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M5 > > > In the last improvement of FML elements were wrapped in anchors. While this > seems to be a good idea it causes trouble with HTML output since CSS rules > then completely change the style of the anchor body. It is then a CSS > trickery to differential between anchors and links. Since anchors itself are > deprecated (anchors without href) and the nearest element should have the id > we will pull up the anchor above the target element. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (DOXIA-683) Don't wrap elements in anchors
Michael Osipov created DOXIA-683: Summary: Don't wrap elements in anchors Key: DOXIA-683 URL: https://issues.apache.org/jira/browse/DOXIA-683 Project: Maven Doxia Issue Type: Task Components: Module - Fml Affects Versions: 2.0.0-M4 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 2.0.0-M5 In the last improvement of FML elements were wrapped in anchors. While this seems to be a good idea it causes trouble with HTML output since CSS rules then completely change the style of the anchor body. It is then a CSS trickery to differential between anchors and links. Since anchors itself are deprecated (anchors without href) and the nearest element should have the id we will pull up the anchor above the target element. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-assembly-plugin] michael-o commented on pull request #102: [MASSEMBLY-973] Support zstd format
michael-o commented on PR #102: URL: https://github.com/apache/maven-assembly-plugin/pull/102#issuecomment-1345646184 > @michael-o Do you want more changes? Should i squash these commits? Haven't found the time yet. Will try to complete this month. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] pleeplop commented on pull request #102: [MASSEMBLY-973] Support zstd format
pleeplop commented on PR #102: URL: https://github.com/apache/maven-assembly-plugin/pull/102#issuecomment-1345643678 @michael-o Do you want more changes? Should i squash these commits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-307) Support listing of workspace artifacts
[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645846#comment-17645846
]
ASF GitHub Bot commented on MRESOLVER-307:
--
cstamas commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345642240
This is for sure incompatible change (hence the build failure), so I'd be
careful here: Maven implements this class, but also Tycho, m2e etc... so a LOT
of breakage here...
Ideally, I'd make this in 2.0 of resolver, and would introduce "safety
measures" like for the rest: iface directly should not be implemented, but
provide a "support class"?
> Support listing of workspace artifacts
> --
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] cstamas commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts
cstamas commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345642240 This is for sure incompatible change (hence the build failure), so I'd be careful here: Maven implements this class, but also Tycho, m2e etc... so a LOT of breakage here... Ideally, I'd make this in 2.0 of resolver, and would introduce "safety measures" like for the rest: iface directly should not be implemented, but provide a "support class"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas closed pull request #904: Alternate transform API
cstamas closed pull request #904: Alternate transform API URL: https://github.com/apache/maven/pull/904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-384) Allow to override streamLogsOnFailures parameter for m-invoker-p
[
https://issues.apache.org/jira/browse/MPOM-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645845#comment-17645845
]
Hudson commented on MPOM-384:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-parent » master #83
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/83/
> Allow to override streamLogsOnFailures parameter for m-invoker-p
>
>
> Key: MPOM-384
> URL: https://issues.apache.org/jira/browse/MPOM-384
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-39
>
>
> When configuration is used, we can not override value by property.
> During local development I want to override {{streamLogsOnFailures}}
> parameter and simply read logs in IDE.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MPOM-384) Allow to override streamLogsOnFailures parameter for m-invoker-p
[
https://issues.apache.org/jira/browse/MPOM-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MPOM-384.
Fix Version/s: MAVEN-39
Assignee: Slawomir Jaranowski
Resolution: Fixed
> Allow to override streamLogsOnFailures parameter for m-invoker-p
>
>
> Key: MPOM-384
> URL: https://issues.apache.org/jira/browse/MPOM-384
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-39
>
>
> When configuration is used, we can not override value by property.
> During local development I want to override {{streamLogsOnFailures}}
> parameter and simply read logs in IDE.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-parent] slawekjaranowski merged pull request #99: [MPOM-384] Allow to override streamLogsOnFailures parameter for m-invoker-p
slawekjaranowski merged PR #99: URL: https://github.com/apache/maven-parent/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645843#comment-17645843 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345636848 This was more to address @rfscholte concerns... > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345636848 This was more to address @rfscholte concerns... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645842#comment-17645842 ] ASF GitHub Bot commented on MNG-7622: - michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345635241 > And one more thing: > > * while artifact is added early, the content is NOT, content is added on very first consumerPom.getFile() call > > * it is being written to randomized file, so hard to "catch" and possibly rewrite > > * while it is not being deleted, we could do that as well if needed I don't expect any ephemeral files to be retained after completion. WDYT? > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345635241 > And one more thing: > > * while artifact is added early, the content is NOT, content is added on very first consumerPom.getFile() call > > * it is being written to randomized file, so hard to "catch" and possibly rewrite > > * while it is not being deleted, we could do that as well if needed I don't expect any ephemeral files to be retained after completion. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645841#comment-17645841 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345634598 And one more thing: * while artifact is added early, the content is NOT, content is added on very first consumerPom.getFile() call * it is being written to randomized file, so hard to "catch" and possibly rewrite * while it is not being deleted, we could do that as well if needed > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345634598 And one more thing: * while artifact is added early, the content is NOT, content is added on very first consumerPom.getFile() call * it is being written to randomized file, so hard to "catch" and possibly rewrite * while it is not being deleted, we could do that as well if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645833#comment-17645833 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345629202 > Then it would also replace `.pompom` which is not what you want, no? I guess you want either exact `.pom` or starts with `.pom.`, on? Yes, I bet there are some rough edges we need to clear up (like inlined sha1, the CLASSIFIER/EXTENSION), but in general, it places consumer pom under CLASSIFIER, so IMHO > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345629202 > Then it would also replace `.pompom` which is not what you want, no? I guess you want either exact `.pom` or starts with `.pom.`, on? Yes, I bet there are some rough edges we need to clear up (like inlined sha1, the CLASSIFIER/EXTENSION), but in general, it places consumer pom under CLASSIFIER, so IMHO -- unsure, just tinkering -- what it should do is: * remove all artifacts that has no classifier and extension "pom" (or starts with, like "pom.asc") * "relocated" all artifact with CLASSIFIER into "no classifier" (so if there is "pompom" under CLASSIFIER, that too). Is like moving a "group", whatever artifact has classifier CLASSIFIER should have CLASSIFIER removed, that's all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645831#comment-17645831 ] ASF GitHub Bot commented on MNG-7622: - michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345628665 > One addendum: "at the end it will replace the actual POM with the consumer POM quite same as maven-shade-plugin"... a bit more: it intentionally use `startsWith` for extension, as it not replaces _only the POM_ but all the "whistle and bells" (signature, checksum, whatever) it may have more and that _is the key_ thing here, and that enables today's m-gpg-p to function. Then it would also replace `.pompom` which is not what you want, no? I guess you want either exact `.pom` or starts with `.pom.`, on? > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345628665 > One addendum: "at the end it will replace the actual POM with the consumer POM quite same as maven-shade-plugin"... a bit more: it intentionally use `startsWith` for extension, as it not replaces _only the POM_ but all the "whistle and bells" (signature, checksum, whatever) it may have more and that _is the key_ thing here, and that enables today's m-gpg-p to function. Then it would also replace `.pompom` which is not what you want, no? I guess you want either exact `.pom` or starts with `.pom.`, on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645829#comment-17645829 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345627596 One addendum: "at the end it will replace the actual POM wioth the consumer POM quite same as maven-shade-plugin"... a bit more: it intentionally use `startsWith` for extension, as it not replaces _only the POM_ but all the "whistle and bells" (signature, checksum, whatever) it may have more > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345627596 One addendum: "at the end it will replace the actual POM wioth the consumer POM quite same as maven-shade-plugin"... a bit more: it intentionally use `startsWith` for extension, as it not replaces _only the POM_ but all the "whistle and bells" (signature, checksum, whatever) it may have more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645828#comment-17645828
]
ASF GitHub Bot commented on MNG-7622:
-
michael-o commented on PR #907:
URL: https://github.com/apache/maven/pull/907#issuecomment-1345626511
> Several "global" remarks:
>
> * re empty line: you are arguing with our new code formatter, not me
Darn!
> * re EXTENSION/"pom" - I did it intentionally like this to make clear
that we attach CLASSIFIER/EXTENSION transformed artifact (CLASSIFIER and
EXTENSION could be really ANYTHING), while we REPLACE always the POM (so
classifier "" and extension "pom"). So I consider your remark as wrong, as
EXTENSION currently "just happens" to be same as "pom", we could make it
"consumer-super-duper-pom" as well if needed.
I accept this, then the code requires a single line comment to make the
intent clear.
> * re null vs non existent file: as we need and do same as "source"
artifact do, we really mimic what it does return, and non-null file but not
existing backing file on disk is one of the cases we need to cover.
Hmm, but returning `""` will give `new File("")` which is valid, no?
> * re sha1: yes, I just inlined it in here but it can be really
anything (or just some guava util, but I did not want to use guava, while i did
not find anything suitable for this case...)
Yeah, just wanted to express that we did it again.
> * "it now works" yes, ITs pass _unmodified_, so this PR achieves
same functionality as existing code on master, but it does not use
FileTransformer API. OTOH, it "works" with m-gpg-p for reason that "consumer
POM" _is present_ as attached artifact from earliest moment, and gpg just finds
it and signs it (same for checksum-m-p or whatever other use case). At the end,
we "remap" the consumer POM as "main" POM
Ah ok, at the end it will replace the actual POM wioth the consumer POM
quite same as maven-shade-plugin can do with the main artifact?
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
michael-o commented on PR #907:
URL: https://github.com/apache/maven/pull/907#issuecomment-1345626511
> Several "global" remarks:
>
> * re empty line: you are arguing with our new code formatter, not me
Darn!
> * re EXTENSION/"pom" - I did it intentionally like this to make clear
that we attach CLASSIFIER/EXTENSION transformed artifact (CLASSIFIER and
EXTENSION could be really ANYTHING), while we REPLACE always the POM (so
classifier "" and extension "pom"). So I consider your remark as wrong, as
EXTENSION currently "just happens" to be same as "pom", we could make it
"consumer-super-duper-pom" as well if needed.
I accept this, then the code requires a single line comment to make the
intent clear.
> * re null vs non existent file: as we need and do same as "source"
artifact do, we really mimic what it does return, and non-null file but not
existing backing file on disk is one of the cases we need to cover.
Hmm, but returning `""` will give `new File("")` which is valid, no?
> * re sha1: yes, I just inlined it in here but it can be really
anything (or just some guava util, but I did not want to use guava, while i did
not find anything suitable for this case...)
Yeah, just wanted to express that we did it again.
> * "it now works" yes, ITs pass _unmodified_, so this PR achieves
same functionality as existing code on master, but it does not use
FileTransformer API. OTOH, it "works" with m-gpg-p for reason that "consumer
POM" _is present_ as attached artifact from earliest moment, and gpg just finds
it and signs it (same for checksum-m-p or whatever other use case). At the end,
we "remap" the consumer POM as "main" POM
Ah ok, at the end it will replace the actual POM wioth the consumer POM
quite same as maven-shade-plugin can do with the main artifact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-reporting-impl] michael-o opened a new pull request, #16: [MSHARED-1174] Don't wrap elements in anchors
michael-o opened a new pull request, #16: URL: https://github.com/apache/maven-reporting-impl/pull/16 This closes #16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645825#comment-17645825 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345625479 Several "global" remarks: * re empty line: you are arguing with our new code formatter, not me :smile: * re EXTENSION/"pom" - I did it intentionally like this to make clear that we attach CLASSIFIER/EXTENSION transformed artifact (CLASSIFIER and EXTENSION could be really ANYTHING), while we REPLACE always the POM (so classifier "" and extension "pom"). So I consider your remark as wrong, as EXTENSION currently "just happens" to be same as "pom", we could make it "consumer-super-duper-pom" as well if needed. * re null vs non existent file: as we need and do same as "source" artifact do, we really mimic what it does return, and non-null file but not existing backing file on disk is one of the cases we need to cover. * re sha1: yes, I just inlined it in here but it can be really anything (or just some guava util, but I did not want to use guava, while i did not find anything suitable for this case...) * "it now works" yes, ITs pass _unmodified_, so this PR achieves same functionality as existing code on master, but it does not use FileTransformer API. OTOH, it "works" with m-gpg-p for reason that "consumer POM" _is present_ as attached artifact from earliest moment, and gpg just finds it and signs it (same for checksum-m-p or whatever other use case). At the end, we "remap" the consumer POM as "main" POM > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1345625479 Several "global" remarks: * re empty line: you are arguing with our new code formatter, not me :smile: * re EXTENSION/"pom" - I did it intentionally like this to make clear that we attach CLASSIFIER/EXTENSION transformed artifact (CLASSIFIER and EXTENSION could be really ANYTHING), while we REPLACE always the POM (so classifier "" and extension "pom"). So I consider your remark as wrong, as EXTENSION currently "just happens" to be same as "pom", we could make it "consumer-super-duper-pom" as well if needed. * re null vs non existent file: as we need and do same as "source" artifact do, we really mimic what it does return, and non-null file but not existing backing file on disk is one of the cases we need to cover. * re sha1: yes, I just inlined it in here but it can be really anything (or just some guava util, but I did not want to use guava, while i did not find anything suitable for this case...) * "it now works" yes, ITs pass _unmodified_, so this PR achieves same functionality as existing code on master, but it does not use FileTransformer API. OTOH, it "works" with m-gpg-p for reason that "consumer POM" _is present_ as attached artifact from earliest moment, and gpg just finds it and signs it (same for checksum-m-p or whatever other use case). At the end, we "remap" the consumer POM as "main" POM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Moved] (MSHARED-1174) Don't wrap elements in anchors
[ https://issues.apache.org/jira/browse/MSHARED-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved DOXIA-682 to MSHARED-1174: --- Component/s: maven-reporting-impl (was: Module - Fml) Fix Version/s: maven-reporting-impl-4.0.0-M4 (was: 2.0.0-M5) Key: MSHARED-1174 (was: DOXIA-682) Affects Version/s: maven-reporting-impl-4.0.0-M3 (was: 2.0.0-M4) Project: Maven Shared Components (was: Maven Doxia) > Don't wrap elements in anchors > -- > > Key: MSHARED-1174 > URL: https://issues.apache.org/jira/browse/MSHARED-1174 > Project: Maven Shared Components > Issue Type: Task > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl-4.0.0-M3 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-impl-4.0.0-M4 > > > In the last improvement of FML elements were wrapped in anchors. While this > seems to be a good idea it causes trouble with HTML output since CSS rules > then completely change the style of the anchor body. It is then a CSS > trickery to differential between anchors and links. Since anchors itself are > deprecated (anchors without href) and the nearest element should have the id > we will pull up the anchor above the target element. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1174) Don't wrap elements in anchors
[
https://issues.apache.org/jira/browse/MSHARED-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSHARED-1174:
Description: In the last improvement of the {{AbstractMavenReportRenderer}}
elements were wrapped in anchors. While this seems to be a good idea it causes
trouble with HTML output since CSS rules then completely change the style of
the anchor body. It is then a CSS trickery to differential between anchors and
links. Since anchors itself are deprecated (anchors without href) and the
nearest element should have the id we will pull up the anchor above the target
element. (was: In the last improvement of FML elements were wrapped in
anchors. While this seems to be a good idea it causes trouble with HTML output
since CSS rules then completely change the style of the anchor body. It is then
a CSS trickery to differential between anchors and links. Since anchors itself
are deprecated (anchors without href) and the nearest element should have the
id we will pull up the anchor above the target element.)
> Don't wrap elements in anchors
> --
>
> Key: MSHARED-1174
> URL: https://issues.apache.org/jira/browse/MSHARED-1174
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl-4.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M4
>
>
> In the last improvement of the {{AbstractMavenReportRenderer}} elements were
> wrapped in anchors. While this seems to be a good idea it causes trouble with
> HTML output since CSS rules then completely change the style of the anchor
> body. It is then a CSS trickery to differential between anchors and links.
> Since anchors itself are deprecated (anchors without href) and the nearest
> element should have the id we will pull up the anchor above the target
> element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DOXIA-682) Don't wrap elements in anchors
Michael Osipov created DOXIA-682: Summary: Don't wrap elements in anchors Key: DOXIA-682 URL: https://issues.apache.org/jira/browse/DOXIA-682 Project: Maven Doxia Issue Type: Task Components: Module - Fml Affects Versions: 2.0.0-M4 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 2.0.0-M5 In the last improvement of FML elements were wrapped in anchors. While this seems to be a good idea it causes trouble with HTML output since CSS rules then completely change the style of the anchor body. It is then a CSS trickery to differential between anchors and links. Since anchors itself are deprecated (anchors without href) and the nearest element should have the id we will pull up the anchor above the target element. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645821#comment-17645821
]
ASF GitHub Bot commented on MNG-7622:
-
michael-o commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045275559
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.function.BiConsumer;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import org.apache.maven.feature.Features;
+import org.apache.maven.model.building.TransformerContext;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.project.artifact.ProjectArtifact;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.artifact.DefaultArtifact;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Consumer POM transformer.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named("consumer-pom")
+public final class ConsumerPomArtifactTransformer implements
ArtifactTransformer {
+private static final String CLASSIFIER = "maven-consumer-pom";
Review Comment:
here as well
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.function.BiConsumer;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import org.apache.maven.feature.Features;
+import org.apache.maven.model.building.TransformerContext;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.project.artifact.ProjectArtifact;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.artifact.DefaultArtifact;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Consumer POM transformer.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named("consumer-pom")
+public final class ConsumerPomArtifactTransformer implements
ArtifactTransformer {
+private static final String CLASSIFIER = "maven-consumer-pom";
+
+private static final String EXTENSION = "pom";
+
+@Override
+public void injectTransformedArtifacts(MavenProject project,
RepositorySystemSession session) throws IOException {
+if (isActive(session)) {
+Path generatedFile;
+String buildDirectory =
+
[GitHub] [maven] michael-o commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
michael-o commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045275559
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.function.BiConsumer;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import org.apache.maven.feature.Features;
+import org.apache.maven.model.building.TransformerContext;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.project.artifact.ProjectArtifact;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.artifact.DefaultArtifact;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Consumer POM transformer.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named("consumer-pom")
+public final class ConsumerPomArtifactTransformer implements
ArtifactTransformer {
+private static final String CLASSIFIER = "maven-consumer-pom";
Review Comment:
here as well
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.function.BiConsumer;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import org.apache.maven.feature.Features;
+import org.apache.maven.model.building.TransformerContext;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.project.artifact.ProjectArtifact;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.artifact.DefaultArtifact;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Consumer POM transformer.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named("consumer-pom")
+public final class ConsumerPomArtifactTransformer implements
ArtifactTransformer {
+private static final String CLASSIFIER = "maven-consumer-pom";
+
+private static final String EXTENSION = "pom";
+
+@Override
+public void injectTransformedArtifacts(MavenProject project,
RepositorySystemSession session) throws IOException {
+if (isActive(session)) {
+Path generatedFile;
+String buildDirectory =
+project.getBuild() != null ?
project.getBuild().getDirectory() : null;
+if (buildDirectory == null) {
+generatedFile = Files.createTempFile(CLASSIFIER, EXTENSION);
+} else {
+
[GitHub] [maven-doxia] dependabot[bot] opened a new pull request, #131: Bump commons-text from 1.9 to 1.10.0 in /doxia-core
dependabot[bot] opened a new pull request, #131: URL: https://github.com/apache/maven-doxia/pull/131 Bumps commons-text from 1.9 to 1.10.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-doxia/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (DOXIA-681) Upgrade Plexus Utils to 3.5.0
[ https://issues.apache.org/jira/browse/DOXIA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-681. Resolution: Fixed Fixed with [3734db142b44aa401072f378948d2dc6a8b963ce|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=3734db142b44aa401072f378948d2dc6a8b963ce]. > Upgrade Plexus Utils to 3.5.0 > - > > Key: DOXIA-681 > URL: https://issues.apache.org/jira/browse/DOXIA-681 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-doxia] dependabot[bot] commented on pull request #125: Bump plexus-utils from 3.4.2 to 3.5.0
dependabot[bot] commented on PR #125: URL: https://github.com/apache/maven-doxia/pull/125#issuecomment-1345619570 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] michael-o closed pull request #125: Bump plexus-utils from 3.4.2 to 3.5.0
michael-o closed pull request #125: Bump plexus-utils from 3.4.2 to 3.5.0 URL: https://github.com/apache/maven-doxia/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] michael-o commented on pull request #125: Bump plexus-utils from 3.4.2 to 3.5.0
michael-o commented on PR #125: URL: https://github.com/apache/maven-doxia/pull/125#issuecomment-1345619558 Superseded by 3734db142b44aa401072f378948d2dc6a8b963ce. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DOXIA-681) Upgrade Plexus Utils to 3.5.0
Michael Osipov created DOXIA-681: Summary: Upgrade Plexus Utils to 3.5.0 Key: DOXIA-681 URL: https://issues.apache.org/jira/browse/DOXIA-681 Project: Maven Doxia Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 2.0.0-M5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7622) Reimplement Consumer POM feature
Tamas Cservenak created MNG-7622: Summary: Reimplement Consumer POM feature Key: MNG-7622 URL: https://issues.apache.org/jira/browse/MNG-7622 Project: Maven Issue Type: Task Components: build/consumer Reporter: Tamas Cservenak Fix For: 4.0.x-candidate Current implementation relies on deprecated resolver API (is deprecated as it is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p broken. Reimplement consumer POM feature that: * does not use FileTransformer API * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645818#comment-17645818
]
Andrzej Jarmoniuk edited comment on MENFORCER-435 at 12/11/22 6:00 PM:
---
Oh I didn't know you were working on it. Anyway, since the required maven
version is 3.2.5, it's safe to assume that we can use the new Resolver API and
thus remove maven-compat cruft altogether. Here's my attempt from today (very
much a WIP):
https://github.com/apache/maven-enforcer/compare/master...ajarmoniuk:maven-enforcer:MENFORCER-435?expand=1
If you don't mind, I'll gladly continue your job.
was (Author: ajarmoniuk):
Oh I didn't know you were working on it. Anyway, since the required maven
version is 3.2.5, it's safe to assume that we can use the new Resolver API and
thus remove maven-compat cruft altogether. Here's my attempt from today:
https://github.com/apache/maven-enforcer/compare/master...ajarmoniuk:maven-enforcer:MENFORCER-435?expand=1
If you don't mind, I'll gladly continue your job.
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7505) Remove ReportingConverter
[
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-7505.
Fix Version/s: 4.0.0-alpha-3
(was: 4.0.x-candidate)
Assignee: Guillaume Nodet (was: Slawomir Jaranowski)
Resolution: Fixed
> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed -
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p
> is not needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7505) Remove ReportingConverter
[
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645817#comment-17645817
]
ASF GitHub Bot commented on MNG-7505:
-
gnodet merged PR #906:
URL: https://github.com/apache/maven/pull/906
> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed -
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p
> is not needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645818#comment-17645818
]
Andrzej Jarmoniuk commented on MENFORCER-435:
-
Oh I didn't know you were working on it. Anyway, since the required maven
version is 3.2.5, it's safe to assume that we can use the new Resolver API and
thus remove maven-compat cruft altogether. Here's my attempt from today:
https://github.com/apache/maven-enforcer/compare/master...ajarmoniuk:maven-enforcer:MENFORCER-435?expand=1
If you don't mind, I'll gladly continue your job.
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7505) Remove ReportingConverter
[
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645819#comment-17645819
]
Hudson commented on MNG-7505:
-
Build failed in Jenkins: Maven » Maven TLP » maven » master #155
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/155/
> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed -
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p
> is not needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet merged pull request #906: [MNG-7505] Disable reportPlugins processing if m-site-p >= 3.7.0 is used
gnodet merged PR #906: URL: https://github.com/apache/maven/pull/906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-680) Don't wrap elements in anchors
[ https://issues.apache.org/jira/browse/DOXIA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645816#comment-17645816 ] ASF GitHub Bot commented on DOXIA-680: -- michael-o opened a new pull request, #130: URL: https://github.com/apache/maven-doxia/pull/130 This closes #130 > Don't wrap elements in anchors > -- > > Key: DOXIA-680 > URL: https://issues.apache.org/jira/browse/DOXIA-680 > Project: Maven Doxia > Issue Type: Task > Components: Module - Fml >Affects Versions: 2.0.0-M4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M5 > > > In the last improvement of FML elements were wrapped in anchors. While this > seems to be a good idea it causes trouble with HTML output since CSS rules > then completely change the style of the anchor body. It is then a CSS > trickery to differential between anchors and links. Since anchors itself are > deprecated (anchors without href) and the nearest element should have the id > we will pull up the anchor above the target element. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-doxia] michael-o opened a new pull request, #130: [DOXIA-680] Don't wrap elements in anchors
michael-o opened a new pull request, #130: URL: https://github.com/apache/maven-doxia/pull/130 This closes #130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] michael-o commented on pull request #351: Using an SPDX identifier as the license name in example
michael-o commented on PR #351: URL: https://github.com/apache/maven-site/pull/351#issuecomment-1345616098 > > Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong. > > We have text: > > > Using an [https://spdx.org/licenses/}SPDX](https://spdx.org/licenses/%7DSPDX) identifier as the license `name` is recommended. > > So how should be ... > > I merged similar in ASF parent pom I know that we have it and only because we don't have an id element. For me, it feels wrong, honestly, but I won't object to merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on pull request #351: Using an SPDX identifier as the license name in example
slawekjaranowski commented on PR #351: URL: https://github.com/apache/maven-site/pull/351#issuecomment-1345614717 > Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong. We have text: > Using an https://spdx.org/licenses/}SPDX identifier as the license `name` is recommended. So how should be ... I merged similar in ASF parent pom -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
