[jira] [Comment Edited] (MJAVADOC-745) Taglet auto-detection doesn't support transitive dependencies

[Stefano Chizzolini (Jira)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693825#comment-17693825
 ] 

Stefano Chizzolini edited comment on MJAVADOC-745 at 2/27/23 7:43 AM:
--

For the purpose, I prepared a fix proposal (see 
[fix-taglet-autodetect|https://github.com/stechio/maven-javadoc-plugin/tree/fix-taglet-autodetect]
 branch — because of a regression affecting dependency resolution on current 
master HEAD (see MJAVADOC-742), I had to temporarily create my branch from the 
last functioning version (3.4.1); when that regression is solved, I will move 
my changes to a proper PR branch from master).

My proposal overcomes the severe limitation on topic, replacing the old taglet 
auto-detection algorithm with an invocation to a robust classpath scanner 
([classgraph|https://github.com/classgraph/classgraph]) — I'm not aware if 
Apache already has its own preferred classpath scanner, neither am I aware 
which Apache policies apply to the addition of new dependencies (I'm looking 
forward to your feedback, thanks).

My branch includes a new unit test ({{{}tagletArtifacts-jdk9-test{}}}) and has 
been successfully verified before commit ({{{}mvn -P run-its verify{}}}).


was (Author: JIRAUSER299015):
For the purpose, I prepared a fix proposal (see 
[fix-taglet-autodetect|https://github.com/stechio/maven-javadoc-plugin/tree/fix-taglet-autodetect]
 branch — because of a regression affecting dependency resolution on current 
master HEAD (see MJAVADOC-742), I had to temporarily create my branch from the 
last functioning version (3.4.1); when that regression is solved, I will move 
my changes to a proper PR branch from master).

My proposal overcomes the severe limitation on topic, adding a dependency to a 
robust classpath scanner 
([classgraph|https://github.com/classgraph/classgraph]) — I'm not aware if 
Apache already has its own preferred classpath scanner, neither am I aware 
which Apache policies apply to the addition of new dependencies (I'm looking 
forward to your feedback, thanks).

My branch includes a new unit test ({{{}tagletArtifacts-jdk9-test{}}}) and has 
been successfully verified before commit ({{{}mvn -P run-its verify{}}}).

> Taglet auto-detection doesn't support transitive dependencies
> -
>
> Key: MJAVADOC-745
> URL: https://issues.apache.org/jira/browse/MJAVADOC-745
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 3.4.1
>Reporter: Stefano Chizzolini
>Priority: Major
>
> The current implementation of the taglet auto-detection algorithm (initial 
> feature request: MJAVADOC-204) doesn't honor the transitive dependency 
> resolution of the configured taglet artifacts (see 
> [|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#tagletArtifacts]):
>  _each artifact on the taglet classpath is scanned separately_ (see 
> [AbstractJavadocMojo.addTagletsFromTagletArtifacts(..)|https://github.com/apache/maven-javadoc-plugin/blob/a5db96e7e16cc432d8fdea05f460f6c3fa258ba9/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L5901]
>  and 
> [JavadocUtil.getTagletClassNames(..)|https://github.com/apache/maven-javadoc-plugin/blob/a5db96e7e16cc432d8fdea05f460f6c3fa258ba9/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java#L721]),
>  _causing taglet class loading to fail in case its hierarchy is spread across 
> multiple artifacts_ (its class loader has visibility only on a single 
> artifact at a time, in the wrong assumption that no intermediate artifact 
> lies between the Taglet interface and its implementations).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MASSEMBLY-975) Regression: 3.5.0 no longer uses default fileMode and directoryMode

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693829#comment-17693829
 ] 

Michael Osipov commented on MASSEMBLY-975:
--

[~hboutemy]

> Regression: 3.5.0 no longer uses default fileMode and directoryMode
> ---
>
> Key: MASSEMBLY-975
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-975
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Niels Basjes
>Priority: Critical
>
> If the fileMode and directoryMode have not been specified with the 3.5.0 
> version then the umask of the system at hand will determine the permissions 
> of the files in the jar generated by the assembly plugin.
> This is a bug because it has been documented that it should use the 
> documented defaults in this case.
> If I change the version of the plugin from 3.5.0 to 3.4.2 then it works as 
> expected.
> I made a simple reproduction project:
> https://github.com/nielsbasjes/BugreportMavenAssemblyUMask
> This builds the same trivial project (with 3 different umask settings) and 
> assembles a jar with the default and explicitly set the same as the 
> documented defaults.
> The base files are all the same (md5sum output)
> {code}
> ec364137a2c7678ef0c8f495652efe36  target-0002/assemblyumask-1.0-SNAPSHOT.jar
> ec364137a2c7678ef0c8f495652efe36  target-0022/assemblyumask-1.0-SNAPSHOT.jar
> ec364137a2c7678ef0c8f495652efe36  target-0055/assemblyumask-1.0-SNAPSHOT.jar
> {code}
> The maven-assembly-plugin created files WITH fileMode and directoryMode are 
> all the same
> {code}
> ba12113ad2b95a4fc75d99aa5bfd4e4f  
> target-0002/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> ba12113ad2b95a4fc75d99aa5bfd4e4f  
> target-0022/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> ba12113ad2b95a4fc75d99aa5bfd4e4f  
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> {code}
> The maven-assembly-plugin created files WITHOUT fileMode and directoryMode 
> are all different
> {code}
> 316e5d6b2e85b7d829e938a5797370d7  
> target-0022/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> 3375500189ef3087f8943d518209a5e6  
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> c341cbbc9f21bb64b817b8bbdaae8608  
> target-0002/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> {code}
> The permissions IN the files are the difference:
> {code}
> $ diffoscope target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar 
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> --- target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> +++ target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> │┄ Archive contents identical but files differ, possibly due to different 
> compression levels. Falling back to binary comparison.
> ├── zipinfo {}
> │ @@ -1,13 +1,13 @@
> │  Zip file size: 2152173 bytes, number of entries: 1515
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/
> │  -rw-r--r--  2.0 unx   79 b- defN 03-Mar-03 03:03 META-INF/MANIFEST.MF
> │ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/
> │ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/
> │ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/bugreports/
> │ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/
> │ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/
> │ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/bugreports/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/org/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/org/apache/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/log4j/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/log4j/core/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/log4j/core/config/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/log4j/core/config/plugins/
> │ @@ -1508,10 +1508,10 @@
> │  -rw-r--r--  2.0 unx  223 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/Unbox$1.class
> │  -rw-r--r--  2.0 unx 1135 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/Unbox$State.class
> │  -rw-r--r--  2.0 unx 1779 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/Unbox$WebSafeState.class
> │  -rw-r--r--  2.0 unx 4595 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/Unbox.class
> │  -rw-r--r--  2.0 unx  135 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/package-info.class
> │  -rw-r--r--  2.0 unx 6283 b- defN 03-Mar-03 03:03 
> META-INF/maven/org.apache.logging.log4j/log4j-api/pom.xml
> │  -rw-r--r--  2.0 unx   69 b- defN 03-Mar-03 03:03 
> 

[jira] [Commented] (MJAVADOC-745) Taglet auto-detection doesn't support transitive dependencies

[Stefano Chizzolini (Jira)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693825#comment-17693825
 ] 

Stefano Chizzolini commented on MJAVADOC-745:
-

For the purpose, I prepared a fix proposal (see 
[fix-taglet-autodetect|https://github.com/stechio/maven-javadoc-plugin/tree/fix-taglet-autodetect]
 branch — because of a regression affecting dependency resolution on current 
master HEAD (see MJAVADOC-742), I had to temporarily create my branch from the 
last functioning version (3.4.1); when that regression is solved, I will move 
my changes to a proper PR branch from master).

My proposal overcomes the severe limitation on topic, adding a dependency to a 
robust classpath scanner 
([classgraph|https://github.com/classgraph/classgraph]) — I'm not aware if 
Apache already has its own preferred classpath scanner, neither am I aware 
which Apache policies apply to the addition of new dependencies (I'm looking 
forward to your feedback, thanks).

My branch includes a new unit test ({{{}tagletArtifacts-jdk9-test{}}}) and has 
been successfully verified before commit ({{{}mvn -P run-its verify{}}}).

> Taglet auto-detection doesn't support transitive dependencies
> -
>
> Key: MJAVADOC-745
> URL: https://issues.apache.org/jira/browse/MJAVADOC-745
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 3.4.1
>Reporter: Stefano Chizzolini
>Priority: Major
>
> The current implementation of the taglet auto-detection algorithm (initial 
> feature request: MJAVADOC-204) doesn't honor the transitive dependency 
> resolution of the configured taglet artifacts (see 
> [|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#tagletArtifacts]):
>  _each artifact on the taglet classpath is scanned separately_ (see 
> [AbstractJavadocMojo.addTagletsFromTagletArtifacts(..)|https://github.com/apache/maven-javadoc-plugin/blob/a5db96e7e16cc432d8fdea05f460f6c3fa258ba9/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L5901]
>  and 
> [JavadocUtil.getTagletClassNames(..)|https://github.com/apache/maven-javadoc-plugin/blob/a5db96e7e16cc432d8fdea05f460f6c3fa258ba9/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java#L721]),
>  _causing taglet class loading to fail in case its hierarchy is spread across 
> multiple artifacts_ (its class loader has visibility only on a single 
> artifact at a time, in the wrong assumption that no intermediate artifact 
> lies between the Taglet interface and its implementations).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MJAVADOC-745) Taglet auto-detection doesn't support transitive dependencies

[Stefano Chizzolini (Jira)]

Stefano Chizzolini created MJAVADOC-745:
---

 Summary: Taglet auto-detection doesn't support transitive 
dependencies
 Key: MJAVADOC-745
 URL: https://issues.apache.org/jira/browse/MJAVADOC-745
 Project: Maven Javadoc Plugin
  Issue Type: Bug
  Components: javadoc
Affects Versions: 3.4.1
Reporter: Stefano Chizzolini


The current implementation of the taglet auto-detection algorithm (initial 
feature request: MJAVADOC-204) doesn't honor the transitive dependency 
resolution of the configured taglet artifacts (see 
[|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#tagletArtifacts]):
 _each artifact on the taglet classpath is scanned separately_ (see 
[AbstractJavadocMojo.addTagletsFromTagletArtifacts(..)|https://github.com/apache/maven-javadoc-plugin/blob/a5db96e7e16cc432d8fdea05f460f6c3fa258ba9/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L5901]
 and 
[JavadocUtil.getTagletClassNames(..)|https://github.com/apache/maven-javadoc-plugin/blob/a5db96e7e16cc432d8fdea05f460f6c3fa258ba9/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java#L721]),
 _causing taglet class loading to fail in case its hierarchy is spread across 
multiple artifacts_ (its class loader has visibility only on a single artifact 
at a time, in the wrong assumption that no intermediate artifact lies between 
the Taglet interface and its implementations).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-757) bug with "non-test scoped test only dependencies found"

[Richard Eckart de Castilho (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693814#comment-17693814
 ] 

Richard Eckart de Castilho commented on MDEP-757:
-

I still think this is a bug because the analyzer should be able to find a path 
from classes included in `A` to classes included in `B` and thereby deduce that 
`B` is needed in the same scope as `A`, no?

> bug with "non-test scoped test only dependencies found"
> ---
>
> Key: MDEP-757
> URL: https://issues.apache.org/jira/browse/MDEP-757
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: analyze
>Affects Versions: 3.2.0
> Environment: mvn --version
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /usr/local/Cellar/maven/3.8.1/libexec
> Java version: 11.0.11, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac"
>Reporter: Henning Schmiedehausen
>Assignee: Henning Schmiedehausen
>Priority: Major
>
> Starting with 3.2.0, I see this problem in one of my project modules:
> {noformat}
> [INFO] --- maven-dependency-plugin:3.2.0:analyze-only (basepom.default) @ 
> foundation ---
> [WARNING] Non-test scoped test only dependencies found:
> [WARNING] com.fasterxml.jackson.core:jackson-databind:jar:2.12.2:compile
> {noformat}
> This is not correct:
> {noformat}
> % cd lib/foundation
> % grep -r databind src/main
> src/main/java/dev/data/DataSet.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/DataSet.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/WriteableLocator.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectMetadata.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectMetadata.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/DataDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectAttribute.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectAttribute.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ImmutableDataObject.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> {noformat}
> So this dependency is used all over the place in the main sources (which is 
> why it can not be in test scope). However, the plugin no longer (it did in 
> 3.1.2) recognize it (all the uses are just annotations, so I guess that is 
> the problem) and raises this error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-757) bug with "non-test scoped test only dependencies found"

[Richard Eckart de Castilho (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693812#comment-17693812
 ] 

Richard Eckart de Castilho commented on MDEP-757:
-

Is there any reason why `ignoreAllNonTestScoped` is not `true` by default?

> bug with "non-test scoped test only dependencies found"
> ---
>
> Key: MDEP-757
> URL: https://issues.apache.org/jira/browse/MDEP-757
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: analyze
>Affects Versions: 3.2.0
> Environment: mvn --version
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /usr/local/Cellar/maven/3.8.1/libexec
> Java version: 11.0.11, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac"
>Reporter: Henning Schmiedehausen
>Assignee: Henning Schmiedehausen
>Priority: Major
>
> Starting with 3.2.0, I see this problem in one of my project modules:
> {noformat}
> [INFO] --- maven-dependency-plugin:3.2.0:analyze-only (basepom.default) @ 
> foundation ---
> [WARNING] Non-test scoped test only dependencies found:
> [WARNING] com.fasterxml.jackson.core:jackson-databind:jar:2.12.2:compile
> {noformat}
> This is not correct:
> {noformat}
> % cd lib/foundation
> % grep -r databind src/main
> src/main/java/dev/data/DataSet.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/DataSet.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/WriteableLocator.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectMetadata.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectMetadata.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/DataDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectAttribute.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectAttribute.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ImmutableDataObject.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> {noformat}
> So this dependency is used all over the place in the main sources (which is 
> why it can not be in test scope). However, the plugin no longer (it did in 
> 3.1.2) recognize it (all the uses are just annotations, so I guess that is 
> the problem) and raises this error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-verifier] dependabot[bot] opened a new pull request, #72: Bump apache/maven-gh-actions-shared from 2 to 3

[via GitHub]

dependabot[bot] opened a new pull request, #72:
URL: https://github.com/apache/maven-verifier/pull/72

   Bumps 
[apache/maven-gh-actions-shared](https://github.com/apache/maven-gh-actions-shared)
 from 2 to 3.
   
   Commits
   
   See full diff in https://github.com/apache/maven-gh-actions-shared/commits/v3;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=apache/maven-gh-actions-shared=github_actions=2=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MDEP-757) bug with "non-test scoped test only dependencies found"

[Henning Schmiedehausen (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693803#comment-17693803
 ] 

Henning Schmiedehausen commented on MDEP-757:
-

{{use true}}

 

> bug with "non-test scoped test only dependencies found"
> ---
>
> Key: MDEP-757
> URL: https://issues.apache.org/jira/browse/MDEP-757
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: analyze
>Affects Versions: 3.2.0
> Environment: mvn --version
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /usr/local/Cellar/maven/3.8.1/libexec
> Java version: 11.0.11, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac"
>Reporter: Henning Schmiedehausen
>Assignee: Henning Schmiedehausen
>Priority: Major
>
> Starting with 3.2.0, I see this problem in one of my project modules:
> {noformat}
> [INFO] --- maven-dependency-plugin:3.2.0:analyze-only (basepom.default) @ 
> foundation ---
> [WARNING] Non-test scoped test only dependencies found:
> [WARNING] com.fasterxml.jackson.core:jackson-databind:jar:2.12.2:compile
> {noformat}
> This is not correct:
> {noformat}
> % cd lib/foundation
> % grep -r databind src/main
> src/main/java/dev/data/DataSet.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/DataSet.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/WriteableLocator.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectMetadata.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectMetadata.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/DataDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectAttribute.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectAttribute.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ImmutableDataObject.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> {noformat}
> So this dependency is used all over the place in the main sources (which is 
> why it can not be in test scope). However, the plugin no longer (it did in 
> 3.1.2) recognize it (all the uses are just annotations, so I guess that is 
> the problem) and raises this error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (MDEP-757) bug with "non-test scoped test only dependencies found"

[Henning Schmiedehausen (Jira)]

 [ 
https://issues.apache.org/jira/browse/MDEP-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henning Schmiedehausen reassigned MDEP-757:
---

Assignee: Henning Schmiedehausen

> bug with "non-test scoped test only dependencies found"
> ---
>
> Key: MDEP-757
> URL: https://issues.apache.org/jira/browse/MDEP-757
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: analyze
>Affects Versions: 3.2.0
> Environment: mvn --version
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /usr/local/Cellar/maven/3.8.1/libexec
> Java version: 11.0.11, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac"
>Reporter: Henning Schmiedehausen
>Assignee: Henning Schmiedehausen
>Priority: Major
>
> Starting with 3.2.0, I see this problem in one of my project modules:
> {noformat}
> [INFO] --- maven-dependency-plugin:3.2.0:analyze-only (basepom.default) @ 
> foundation ---
> [WARNING] Non-test scoped test only dependencies found:
> [WARNING] com.fasterxml.jackson.core:jackson-databind:jar:2.12.2:compile
> {noformat}
> This is not correct:
> {noformat}
> % cd lib/foundation
> % grep -r databind src/main
> src/main/java/dev/data/DataSet.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/DataSet.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/WriteableLocator.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectMetadata.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectMetadata.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/DataDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectAttribute.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectAttribute.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ObjectDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> src/main/java/dev/data/ObjectDefinition.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> src/main/java/dev/data/ImmutableDataObject.java:import 
> com.fasterxml.jackson.databind.annotation.JsonSerialize;
> {noformat}
> So this dependency is used all over the place in the main sources (which is 
> why it can not be in test scope). However, the plugin no longer (it did in 
> 3.1.2) recognize it (all the uses are just annotations, so I guess that is 
> the problem) and raises this error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MRESOLVER-324) Make the BF algorithm as the default option to speed up maven dependency resolution and downloading

[wei cai (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693794#comment-17693794
 ] 

wei cai commented on MRESOLVER-324:
---

[~.wojtek] 

You can put to MAVEN_OPTS or MAVEN_ARGS environment variable

[https://maven.apache.org/configure.html]

 

> Make the BF algorithm as the default option to speed up maven dependency 
> resolution and downloading
> ---
>
> Key: MRESOLVER-324
> URL: https://issues.apache.org/jira/browse/MRESOLVER-324
> Project: Maven Resolver
>  Issue Type: Wish
>  Components: Resolver
>Affects Versions: 1.10.0
>Reporter: wei cai
>Priority: Major
> Fix For: 1.10.0
>
>
> This is a WISH type Jira :D. So far, Maven 3.9.0 has released a BF algorithm 
> which includes changes from below JIRAs along with the DF option (default).
>  * MRESOLVER-228
>  * MRESOLVER-247
>  * MRESOLVER-7
> The BF algorithm solves:
>  * Cache missing issue when comes to resolve heavy dependencies with 
> different exclusions, it can help speed up dependency resolution especially 
> for large scale enterprise level projects.
>  * Improve download speed by:
>  ** Skip downloading poms for conflict losers.
>  ** Download poms in parallel.
> Below is the introduction in 
> [https://maven.apache.org/docs/3.9.0/release-notes.html:]
> {noformat}
> Choice of resolver collectors: a new BF collector (with parallel POM 
> downloads) has been added along the existing DF one.{noformat}
> The solution is already widely adopted at eBay. You can simply enable it by 
> putting below config item into file: ${maven.projectBasedir}/.mvn/maven.config
> {code:java}
> aether.dependencyCollector.impl=bf {code}
> More introduction about this option: 
> [https://maven.apache.org/resolver/configuration.html]
> Please try and tells us how much it helps by running:
> {code:java}
> 1. mvn clean install -DskipTests -Dmaven.repo.local=bf 
> -Daether.dependencyCollector.impl=bf 
> 2. mvn clean install -DskipTests -Dmaven.repo.local=df{code}
> With more feedback collected, we would be able to propose the changes to 
> Maven team to make BF as the default.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-script-interpreter] dependabot[bot] opened a new pull request, #93: Bump apache/maven-gh-actions-shared from 2 to 3

[via GitHub]

dependabot[bot] opened a new pull request, #93:
URL: https://github.com/apache/maven-script-interpreter/pull/93

   Bumps 
[apache/maven-gh-actions-shared](https://github.com/apache/maven-gh-actions-shared)
 from 2 to 3.
   
   Commits
   
   See full diff in https://github.com/apache/maven-gh-actions-shared/commits/v3;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=apache/maven-gh-actions-shared=github_actions=2=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #191: Bump doxia-sink-api from 1.11.1 to 1.12.0

[via GitHub]

dependabot[bot] commented on PR #191:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/191#issuecomment-1445664068

   Sorry, only users with push access can use that command.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #193: Bump maven-common-artifact-filters from 3.2.0 to 3.3.2

[via GitHub]

dependabot[bot] opened a new pull request, #193:
URL: https://github.com/apache/maven-javadoc-plugin/pull/193

   Bumps 
[maven-common-artifact-filters](https://github.com/apache/maven-common-artifact-filters)
 from 3.2.0 to 3.3.2.
   
   Commits
   
   https://github.com/apache/maven-common-artifact-filters/commit/31e20e5c0a2226285dc6b90fc5b3eaaf5f642d8a;>31e20e5
 [maven-release-plugin] prepare release maven-common-artifact-filters-3.3.2
   https://github.com/apache/maven-common-artifact-filters/commit/7660d9bc1429ffbe4c86cdaf7af5776d118883cf;>7660d9b
 [MSHARED-1131] Upgrade Parent to 37 and cleanup
   https://github.com/apache/maven-common-artifact-filters/commit/bde012cf6f793adf6d135e0356694dc1fef2c7f9;>bde012c
 (doc) small code cleanup from ide suggestions
   https://github.com/apache/maven-common-artifact-filters/commit/500569dad88b8f91e77116a2743a4685c920bed5;>500569d
 [MSHARED-1130] Sanitised value nullability in match(Pattern, boolean, 
String)
   https://github.com/apache/maven-common-artifact-filters/commit/299cf441a2e6eede21b0f1657c86f292ab4885b0;>299cf44
 Use GH shared v3
   https://github.com/apache/maven-common-artifact-filters/commit/37ea472bf2950d12a9176c91a9a79543f748846b;>37ea472
 [maven-release-plugin] prepare for next development iteration
   https://github.com/apache/maven-common-artifact-filters/commit/b244fd9e0e7e84ee0e2e3ba3402f5ba654b5becd;>b244fd9
 [maven-release-plugin] prepare release maven-common-artifact-filters-3.3.1
   https://github.com/apache/maven-common-artifact-filters/commit/611baf61bc8ff8a26bf4af48dcf8ecb53e5c74dc;>611baf6
 [MSHARED-1104] Four element pattern may be GATV or GATC (https://github-redirect.dependabot.com/apache/maven-common-artifact-filters/issues/29;>#29)
   https://github.com/apache/maven-common-artifact-filters/commit/0985a227dcc4de82759797b40b939c4ebb5f6ff5;>0985a22
 Fix jenkins url
   https://github.com/apache/maven-common-artifact-filters/commit/94088c760d6e9b80cf166a5028b2a87b5af43cfa;>94088c7
 [maven-release-plugin] prepare for next development iteration
   Additional commits viewable in https://github.com/apache/maven-common-artifact-filters/compare/maven-common-artifact-filters-3.2.0...maven-common-artifact-filters-3.3.2;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.shared:maven-common-artifact-filters=maven=3.2.0=3.3.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #192: Bump jetty.version from 9.4.50.v20221201 to 10.0.13

[via GitHub]

dependabot[bot] opened a new pull request, #192:
URL: https://github.com/apache/maven-javadoc-plugin/pull/192

   Bumps `jetty.version` from 9.4.50.v20221201 to 10.0.13.
   Updates `jetty-server` from 9.4.50.v20221201 to 10.0.13
   
   Release notes
   Sourced from https://github.com/eclipse/jetty.project/releases;>jetty-server's 
releases.
   
   10.0.13
   Special Thanks to the following Eclipse Jetty community members
   
   https://github.com/janvojt;>@​janvojt (Jan 
Vojt)
   https://github.com/joschi;>@​joschi (Jochen 
Schalanda)
   https://github.com/leonchen83;>@​leonchen83 
(Baoyi Chen)
   https://github.com/cowwoc;>@​cowwoc (Gili 
Tzabari)
   https://github.com/Vlatombe;>@​Vlatombe 
(Vincent Latombe)
   
   Changelog
   
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/9006;>#9006
 - WebSocket Message InputStream read() returns signed byte
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8913;>#8913
 - Review Jetty XML syntax to allow calling JDK methods
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8905;>#8905
 - GzipHandler fails to set Vary header on 304 responses
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8900;>#8900
 - Improved documentation about virtual threads.
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8897;>#8897
 - Update Conditional request handling for RFC7232
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8895;>#8895
 - Generate downloadable version of javadocs documentation in website deploy 
script
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8863;>#8863
 - Provide a possibility to name virtual threads
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8810;>#8810
 - ArrayRetainableByteBufferPool inefficiently calculates bucket 
indices
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8786;>#8786
 - KeyStoreScanner is not able to monitor a symlink file and always resolves to 
the target.
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8779;>#8779
 - CompactPathRule drops query section on use
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8770;>#8770
 - Review whether to send request body in redirects
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8753;>#8753
 - Starting HttpClient with destinationIdleTimeout set throws NPE. (https://github.com/janvojt;>@​janvojt)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8750;>#8750
 - AbstractProxyServlet.onServerResponseHeaders does not support headers with 
empty values
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8743;>#8743
 - Add log.isDebugEnabled() to reduce string allocation (https://github.com/leonchen83;>@​leonchen83)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8721;>#8721
 - jetty:effective-web-xml doesn't generate quickstart information for web 
fragment jars that contain META-INF/resources
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8716;>#8716
 - Multiple Host header values handled poorly
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8712;>#8712
 - ELContextCleaner no longer needed.
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8688;>#8688
 - Fix traversal bug on extraction of bad jar/zip files during jetty-start
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8682;>#8682
 - expand jetty properties when generating dry-run command line
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8678;>#8678
 - Jetty client is not responding to GO_AWAY packet received from (Jetty) 
Server and continue to send traffic on same connection
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8628;>#8628
 - Pseudo restore PathMappings.getMatch(String) for backwards 
compat reasons
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8623;>#8623
 - Use AutoLock in InputStreamResponseListener
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8600;>#8600
 - Allow to pass instances of ClientConfig and Config to Hazelcast data store 
factory (https://github.com/Vlatombe;>@​Vlatombe)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8591;>#8591
 - Indicate units of HttpClient properties (https://github.com/cowwoc;>@​cowwoc)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8558;>#8558
 - Idle timeout occured sometimes on HTTP/2 client with 
InputStreamResponseListener
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8536;>#8536
 - HotSwapHandler race condition
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8473;>#8473
 - add getter for the WebSocketUpgradeHandler configuration
   

[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #191: Bump doxia-sink-api from 1.11.1 to 1.12.0

[via GitHub]

dependabot[bot] opened a new pull request, #191:
URL: https://github.com/apache/maven-javadoc-plugin/pull/191

   Bumps [doxia-sink-api](https://github.com/apache/maven-doxia) from 1.11.1 to 
1.12.0.
   
   Commits
   
   https://github.com/apache/maven-doxia/commit/281dc2c380cc14ba758d693c5b463186c53c2fb5;>281dc2c
 [maven-release-plugin] prepare release doxia-1.12.0
   https://github.com/apache/maven-doxia/commit/7b34b7d16e486d9217400a70481180e4ee753f96;>7b34b7d
 [DOXIA-569] fix javadoc
   https://github.com/apache/maven-doxia/commit/062ba3d7d7d7914cc6f0b1a7f14574fed73f727e;>062ba3d
 [MNGSITE-505] use dlcdn.apache.org (no mirrors) + downloads.apache.org
   https://github.com/apache/maven-doxia/commit/5d364e097968b01e30ddb74f2ad9259204be7a26;>5d364e0
 [DOXIA-617] support yaml metadata
   https://github.com/apache/maven-doxia/commit/a1ad9b5bf11944e1a723b4a44298d2439f7201c0;>a1ad9b5
 [DOXIA-569] add Markdown sink implementation
   https://github.com/apache/maven-doxia/commit/24f0066c4b0f6a1c0ae4b38204f5df716a3d310b;>24f0066
 [DOXIA-662] Non unique IDs generated by IndexingSink
   https://github.com/apache/maven-doxia/commit/51922943b765a36887461b9290306f9708188b13;>5192294
 [DOXIA-671] Double quotes contained in markdown page are removed in HTML 
output
   https://github.com/apache/maven-doxia/commit/ceb77298f6eb362eee86c76f678cc7d60a710055;>ceb7729
 [DOXIA-650] Make MarkdownParser to be a text parser with text markup
   https://github.com/apache/maven-doxia/commit/47a1bb25542dc4ce0af63d953cd7c579e0fa77b6;>47a1bb2
 [DOXIA-641] AprParser throws exception if title is not present
   https://github.com/apache/maven-doxia/commit/539428bd17e649c506e4a7a549b8f8b5d1cc3c18;>539428b
 [DOXIA-684] avoid flexmark-all: declare used extensions only
   Additional commits viewable in https://github.com/apache/maven-doxia/compare/doxia-1.11.1...doxia-1.12.0;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.doxia:doxia-sink-api=maven=1.11.1=1.12.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #190: Bump mockito-core from 4.4.0 to 5.1.1

[via GitHub]

dependabot[bot] opened a new pull request, #190:
URL: https://github.com/apache/maven-javadoc-plugin/pull/190

   Bumps [mockito-core](https://github.com/mockito/mockito) from 4.4.0 to 5.1.1.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-core's 
releases.
   
   v5.1.1
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   5.1.1
   
   2023-01-30 - https://github.com/mockito/mockito/compare/v5.1.0...v5.1.1;>1 
commit(s) by Andriy Redko
   StackWalker.Option not found on Mockito 5.1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2891;>#2891)](https://github-redirect.dependabot.com/mockito/mockito/pull/2891;>mockito/mockito#2891)
   StackWalker.Option not found on Mockito 5.1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2890;>#2890)](https://github-redirect.dependabot.com/mockito/mockito/issues/2890;>mockito/mockito#2890)
   
   v5.1.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   5.1.0
   
   2023-01-29 - https://github.com/mockito/mockito/compare/v5.0.0...v5.1.0;>12 
commit(s) by Andriy Redko, Ashley, Róbert Papp, Stephan Schroevers, Tim te 
Beek, dependabot[bot]
   Fixes some mistakes and missing details in documentation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2889;>#2889)](https://github-redirect.dependabot.com/mockito/mockito/pull/2889;>mockito/mockito#2889)
   Bump com.diffplug.spotless from 6.13.0 to 6.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2888;>#2888)](https://github-redirect.dependabot.com/mockito/mockito/pull/2888;>mockito/mockito#2888)
   Clean up JDK-8 related code [(https://github-redirect.dependabot.com/mockito/mockito/issues/2883;>#2883)](https://github-redirect.dependabot.com/mockito/mockito/pull/2883;>mockito/mockito#2883)
   Feat: reified mock overloads [(https://github-redirect.dependabot.com/mockito/mockito/issues/2882;>#2882)](https://github-redirect.dependabot.com/mockito/mockito/pull/2882;>mockito/mockito#2882)
   Clean up JDK-8 related code [(https://github-redirect.dependabot.com/mockito/mockito/issues/2879;>#2879)](https://github-redirect.dependabot.com/mockito/mockito/issues/2879;>mockito/mockito#2879)
   Bump assertj-core from 3.24.1 to 3.24.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2875;>#2875)](https://github-redirect.dependabot.com/mockito/mockito/pull/2875;>mockito/mockito#2875)
   Make sure the tests use mock maker with intended member accessor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2872;>#2872)](https://github-redirect.dependabot.com/mockito/mockito/pull/2872;>mockito/mockito#2872)
   Bump com.diffplug.spotless from 6.12.1 to 6.13.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2871;>#2871)](https://github-redirect.dependabot.com/mockito/mockito/pull/2871;>mockito/mockito#2871)
   Remove broken link from CONTRIBUTING.md [(https://github-redirect.dependabot.com/mockito/mockito/issues/2870;>#2870)](https://github-redirect.dependabot.com/mockito/mockito/pull/2870;>mockito/mockito#2870)
   Update outdated badge 3.x to 5.x [(https://github-redirect.dependabot.com/mockito/mockito/issues/2869;>#2869)](https://github-redirect.dependabot.com/mockito/mockito/pull/2869;>mockito/mockito#2869)
   Broken link in CONTRIBUTING.md [(https://github-redirect.dependabot.com/mockito/mockito/issues/2868;>#2868)](https://github-redirect.dependabot.com/mockito/mockito/issues/2868;>mockito/mockito#2868)
   Set current version to 5.x in README and highlight changes [(https://github-redirect.dependabot.com/mockito/mockito/issues/2867;>#2867)](https://github-redirect.dependabot.com/mockito/mockito/pull/2867;>mockito/mockito#2867)
   Annotate Mockito#{mock,spy}(T... reified) with 
@SafeVarargs [(https://github-redirect.dependabot.com/mockito/mockito/issues/2866;>#2866)](https://github-redirect.dependabot.com/mockito/mockito/pull/2866;>mockito/mockito#2866)
   Make sure the tests use mock maker with intended member accessor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2855;>#2855)](https://github-redirect.dependabot.com/mockito/mockito/issues/2855;>mockito/mockito#2855)
   Improve examples for InOrder [(https://github-redirect.dependabot.com/mockito/mockito/issues/2843;>#2843)](https://github-redirect.dependabot.com/mockito/mockito/pull/2843;>mockito/mockito#2843)
   
   v5.0.0
   Mockito 5: prepare for future JDK versions
   For a while now, we have seen an increase in problems/incompatibilities 
with recent versions of the JDK due to our usage of JVM-internal API.
   Most notably, JDK 17 made some changes which are incompatible with the 
current subclass mockmaker.
   Therefore, to prepare for the future of JDK, we are making some core changes 
to ensure Mockito keeps on working.
   Switch the default mockmaker to mockito-inline
   Back in Mockito 2.7.6, we 

[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #189: Bump wagonVersion from 2.4 to 3.5.3

[via GitHub]

dependabot[bot] opened a new pull request, #189:
URL: https://github.com/apache/maven-javadoc-plugin/pull/189

   Bumps `wagonVersion` from 2.4 to 3.5.3.
   Updates `wagon-provider-api` from 2.4 to 3.5.3
   
   Commits
   
   https://github.com/apache/maven-wagon/commit/20b847446bb60f49af0428d592eadee774b5bff2;>20b8474
 [maven-release-plugin] prepare release wagon-3.5.3
   https://github.com/apache/maven-wagon/commit/baac9242909c26057797d040b2d5bdfa6db426ef;>baac924
 [WAGON-631] Upgrade and clean up dependencies
   https://github.com/apache/maven-wagon/commit/e9a7f952969918ec72b79517c25f2fde4206a261;>e9a7f95
 update Reproducible Builds badge link
   https://github.com/apache/maven-wagon/commit/f840c59358f15c13d65c532e085b63be3ed876e5;>f840c59
 Fix Jenkins url
   https://github.com/apache/maven-wagon/commit/f654cd59c33a3efe3149dd1a2b418de49813f83e;>f654cd5
 [maven-release-plugin] prepare for next development iteration
   https://github.com/apache/maven-wagon/commit/8331ee26ffb3b5770c4e01ac3ed38d321c9158b1;>8331ee2
 [maven-release-plugin] prepare release wagon-3.5.2
   https://github.com/apache/maven-wagon/commit/88e8574c69d83e6a658fcd2ad10f3f80926b8840;>88e8574
 [WAGON-629] Properly handle authentication scenarios with MKCOL
   https://github.com/apache/maven-wagon/commit/17529c6232a02ee836107bae11a9b5eb6778afb1;>17529c6
 [WAGON-628] Default connect timeout not set when no HttpMethodConfiguration 
i...
   https://github.com/apache/maven-wagon/commit/d7f336745a6fec7c3697e47b17f46b9ae996d305;>d7f3367
 [WAGON-627] Maven deploy fails with 401 Unauthorized when using £ in 
password
   https://github.com/apache/maven-wagon/commit/8e5a4b698b77b5272405a1678ef87e24aba2f4a2;>8e5a4b6
 Drop findbugs from site reporting
   Additional commits viewable in https://github.com/apache/maven-wagon/compare/wagon-2.4...wagon-3.5.3;>compare
 view
   
   
   
   
   Updates `wagon-http` from 2.4 to 3.5.3
   
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-remote-resources-plugin] dependabot[bot] opened a new pull request, #25: Bump apache/maven-gh-actions-shared from 2 to 3

[via GitHub]

dependabot[bot] opened a new pull request, #25:
URL: https://github.com/apache/maven-remote-resources-plugin/pull/25

   Bumps 
[apache/maven-gh-actions-shared](https://github.com/apache/maven-gh-actions-shared)
 from 2 to 3.
   
   Commits
   
   See full diff in https://github.com/apache/maven-gh-actions-shared/commits/v3;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=apache/maven-gh-actions-shared=github_actions=2=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-jar-plugin] dependabot[bot] opened a new pull request, #60: Bump apache/maven-gh-actions-shared from 2 to 3

[via GitHub]

dependabot[bot] opened a new pull request, #60:
URL: https://github.com/apache/maven-jar-plugin/pull/60

   Bumps 
[apache/maven-gh-actions-shared](https://github.com/apache/maven-gh-actions-shared)
 from 2 to 3.
   
   Commits
   
   See full diff in https://github.com/apache/maven-gh-actions-shared/commits/v3;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=apache/maven-gh-actions-shared=github_actions=2=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] olamy merged pull request #614: [SUREFIRE-2150] upgrade to parent pom 39

[via GitHub]

olamy merged PR #614:
URL: https://github.com/apache/maven-surefire/pull/614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (SUREFIRE-2150) Upgrade Maven parent 39

[Olivier Lamy (Jira)]

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy closed SUREFIRE-2150.
--
Resolution: Fixed

done

> Upgrade Maven parent 39
> ---
>
> Key: SUREFIRE-2150
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2150
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.0.0-M10
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SUREFIRE-2155) system property java.io.tmpdir set too late

[Olivier Lamy (Jira)]

Olivier Lamy created SUREFIRE-2155:
--

 Summary: system property java.io.tmpdir set too late
 Key: SUREFIRE-2155
 URL: https://issues.apache.org/jira/browse/SUREFIRE-2155
 Project: Maven Surefire
  Issue Type: Bug
Affects Versions: 3.0.0-M9
Reporter: Olivier Lamy
Assignee: Olivier Lamy
 Fix For: 3.0.0-M10


Using such configuration
{code}

  ${project.build.directory}

{code}
This code doesn't create the tmp directory on ${project.build.directory}
{code}
Files.createTempDirectory​("foo")
{code} 

property such java.io.tmpdir (and probably all) should be configured with using 
-D of the forked jvm




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MASSEMBLY-975) Regression: 3.5.0 no longer uses default fileMode and directoryMode

[Niels Basjes (Jira)]

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693726#comment-17693726
 ] 

Niels Basjes commented on MASSEMBLY-975:


FYI: I ran into this because my project was suddenly no longer reproducible.

I fear a lot of projects on 
[https://github.com/jvm-repo-rebuild/reproducible-central] will fail because of 
this. 

> Regression: 3.5.0 no longer uses default fileMode and directoryMode
> ---
>
> Key: MASSEMBLY-975
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-975
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Niels Basjes
>Priority: Critical
>
> If the fileMode and directoryMode have not been specified with the 3.5.0 
> version then the umask of the system at hand will determine the permissions 
> of the files in the jar generated by the assembly plugin.
> This is a bug because it has been documented that it should use the 
> documented defaults in this case.
> If I change the version of the plugin from 3.5.0 to 3.4.2 then it works as 
> expected.
> I made a simple reproduction project:
> https://github.com/nielsbasjes/BugreportMavenAssemblyUMask
> This builds the same trivial project (with 3 different umask settings) and 
> assembles a jar with the default and explicitly set the same as the 
> documented defaults.
> The base files are all the same (md5sum output)
> {code}
> ec364137a2c7678ef0c8f495652efe36  target-0002/assemblyumask-1.0-SNAPSHOT.jar
> ec364137a2c7678ef0c8f495652efe36  target-0022/assemblyumask-1.0-SNAPSHOT.jar
> ec364137a2c7678ef0c8f495652efe36  target-0055/assemblyumask-1.0-SNAPSHOT.jar
> {code}
> The maven-assembly-plugin created files WITH fileMode and directoryMode are 
> all the same
> {code}
> ba12113ad2b95a4fc75d99aa5bfd4e4f  
> target-0002/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> ba12113ad2b95a4fc75d99aa5bfd4e4f  
> target-0022/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> ba12113ad2b95a4fc75d99aa5bfd4e4f  
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> {code}
> The maven-assembly-plugin created files WITHOUT fileMode and directoryMode 
> are all different
> {code}
> 316e5d6b2e85b7d829e938a5797370d7  
> target-0022/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> 3375500189ef3087f8943d518209a5e6  
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> c341cbbc9f21bb64b817b8bbdaae8608  
> target-0002/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> {code}
> The permissions IN the files are the difference:
> {code}
> $ diffoscope target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar 
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> --- target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> +++ target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> │┄ Archive contents identical but files differ, possibly due to different 
> compression levels. Falling back to binary comparison.
> ├── zipinfo {}
> │ @@ -1,13 +1,13 @@
> │  Zip file size: 2152173 bytes, number of entries: 1515
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/
> │  -rw-r--r--  2.0 unx   79 b- defN 03-Mar-03 03:03 META-INF/MANIFEST.MF
> │ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/
> │ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/
> │ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/bugreports/
> │ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/
> │ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/
> │ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/bugreports/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/org/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/org/apache/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/log4j/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/log4j/core/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/log4j/core/config/
> │  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
> META-INF/org/apache/logging/log4j/core/config/plugins/
> │ @@ -1508,10 +1508,10 @@
> │  -rw-r--r--  2.0 unx  223 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/Unbox$1.class
> │  -rw-r--r--  2.0 unx 1135 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/Unbox$State.class
> │  -rw-r--r--  2.0 unx 1779 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/Unbox$WebSafeState.class
> │  -rw-r--r--  2.0 unx 4595 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/Unbox.class
> │  -rw-r--r--  2.0 unx  135 b- defN 03-Mar-03 03:03 
> org/apache/logging/log4j/util/package-info.class
> │  -rw-r--r--  2.0 

[jira] [Created] (MASSEMBLY-975) Regression: 3.5.0 no longer uses default fileMode and directoryMode

[Niels Basjes (Jira)]

Niels Basjes created MASSEMBLY-975:
--

 Summary: Regression: 3.5.0 no longer uses default fileMode and 
directoryMode
 Key: MASSEMBLY-975
 URL: https://issues.apache.org/jira/browse/MASSEMBLY-975
 Project: Maven Assembly Plugin
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: Niels Basjes


If the fileMode and directoryMode have not been specified with the 3.5.0 
version then the umask of the system at hand will determine the permissions of 
the files in the jar generated by the assembly plugin.
This is a bug because it has been documented that it should use the documented 
defaults in this case.

If I change the version of the plugin from 3.5.0 to 3.4.2 then it works as 
expected.

I made a simple reproduction project:
https://github.com/nielsbasjes/BugreportMavenAssemblyUMask

This builds the same trivial project (with 3 different umask settings) and 
assembles a jar with the default and explicitly set the same as the documented 
defaults.

The base files are all the same (md5sum output)
{code}
ec364137a2c7678ef0c8f495652efe36  target-0002/assemblyumask-1.0-SNAPSHOT.jar
ec364137a2c7678ef0c8f495652efe36  target-0022/assemblyumask-1.0-SNAPSHOT.jar
ec364137a2c7678ef0c8f495652efe36  target-0055/assemblyumask-1.0-SNAPSHOT.jar
{code}

The maven-assembly-plugin created files WITH fileMode and directoryMode are all 
the same

{code}
ba12113ad2b95a4fc75d99aa5bfd4e4f  
target-0002/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
ba12113ad2b95a4fc75d99aa5bfd4e4f  
target-0022/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
ba12113ad2b95a4fc75d99aa5bfd4e4f  
target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
{code}

The maven-assembly-plugin created files WITHOUT fileMode and directoryMode are 
all different
{code}
316e5d6b2e85b7d829e938a5797370d7  
target-0022/assemblyumask-1.0-SNAPSHOT-udf-default.jar
3375500189ef3087f8943d518209a5e6  
target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
c341cbbc9f21bb64b817b8bbdaae8608  
target-0002/assemblyumask-1.0-SNAPSHOT-udf-default.jar
{code}

The permissions IN the files are the difference:

{code}
$ diffoscope target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar 
target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
--- target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
+++ target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
│┄ Archive contents identical but files differ, possibly due to different 
compression levels. Falling back to binary comparison.
├── zipinfo {}
│ @@ -1,13 +1,13 @@
│  Zip file size: 2152173 bytes, number of entries: 1515
│  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/
│  -rw-r--r--  2.0 unx   79 b- defN 03-Mar-03 03:03 META-INF/MANIFEST.MF
│ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/
│ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/
│ -drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/bugreports/
│ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/
│ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/
│ +drwx-w--w-  2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/bugreports/
│  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/org/
│  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/org/apache/
│  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
META-INF/org/apache/logging/
│  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
META-INF/org/apache/logging/log4j/
│  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
META-INF/org/apache/logging/log4j/core/
│  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
META-INF/org/apache/logging/log4j/core/config/
│  drwxr-xr-x  2.0 unx0 b- stor 03-Mar-03 03:03 
META-INF/org/apache/logging/log4j/core/config/plugins/
│ @@ -1508,10 +1508,10 @@
│  -rw-r--r--  2.0 unx  223 b- defN 03-Mar-03 03:03 
org/apache/logging/log4j/util/Unbox$1.class
│  -rw-r--r--  2.0 unx 1135 b- defN 03-Mar-03 03:03 
org/apache/logging/log4j/util/Unbox$State.class
│  -rw-r--r--  2.0 unx 1779 b- defN 03-Mar-03 03:03 
org/apache/logging/log4j/util/Unbox$WebSafeState.class
│  -rw-r--r--  2.0 unx 4595 b- defN 03-Mar-03 03:03 
org/apache/logging/log4j/util/Unbox.class
│  -rw-r--r--  2.0 unx  135 b- defN 03-Mar-03 03:03 
org/apache/logging/log4j/util/package-info.class
│  -rw-r--r--  2.0 unx 6283 b- defN 03-Mar-03 03:03 
META-INF/maven/org.apache.logging.log4j/log4j-api/pom.xml
│  -rw-r--r--  2.0 unx   69 b- defN 03-Mar-03 03:03 
META-INF/maven/org.apache.logging.log4j/log4j-api/pom.properties
│ --rw-r--r--  2.0 unx  494 b- defN 03-Mar-03 03:03 log4j2.xml
│ --rw-r--r--  2.0 unx  605 b- defN 03-Mar-03 03:03 
nl/basjes/bugreports/App.class
│ +-rw-rw-r--  2.0 unx  494 b- defN 03-Mar-03 03:03 log4j2.xml
│ +-rw--w--w-  2.0 unx  605 b- defN 03-Mar-03 03:03 
nl/basjes/bugreports/App.class
│  1515 files, 4853233 bytes uncompressed, 1839331 bytes compressed:  62.1%

[GitHub] [maven] elharo commented on pull request #1005: Replace some old, pre-Java 7 Plexus code

[via GitHub]

elharo commented on PR #1005:
URL: https://github.com/apache/maven/pull/1005#issuecomment-1445502457

   Usually it's OK to close a stream more than once. If this method is expected 
to completely consume the stream, it doesn't feel wrong to me to close it here. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (MSHADE-345) Package relocation appears not to work with Scala

[Javier Neira Sanchez (Jira)]

[ 
https://issues.apache.org/jira/browse/MSHADE-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693720#comment-17693720
 ] 

Javier Neira Sanchez edited comment on MSHADE-345 at 2/26/23 10:19 PM:
---

[~icshuo] hey, thanks for the hint to try to reroduce the issue. I followed it, 
you can check that version at 
[https://github.com/jneira/maven-shade-plugin/tree/SHADE-345_scala-package-relocation/src/it/projects/MSHADE-345_scala-package-relocation/src/main/scala]

The scala app looks like:
{code:java}
import org.apache.logging.log4j.scala.Logger;
import org.apache.logging.log4j.scala.Logging;
object MyApp extends App with Logging {  
  println("Logger FQCN: " + Logger.FQCN)
  logger.info("Test Logging")
} 
{code}
Executing the app shows
{code:java}
Logger FQCN: relocated.scala.Logger${code}{code}
Which still seems to be correct And, well, the bytecode generated for relocated 
classes also looks good, for example:  
{code:java}
{code:java}
public void delayedInit(relocated.scala.Function0https://github.com/jneira/maven-shade-plugin/tree/SHADE-345_scala-package-relocation/src/it/projects/MSHADE-345_scala-package-relocation/src/main/scala]

The scala app looks like:
{code:java}
import org.apache.logging.log4j.scala.Logger;
import org.apache.logging.log4j.scala.Logging;
object MyApp extends App with Logging {  
  println("Logger FQCN: " + Logger.FQCN)
  logger.info("Test Logging")
} 
{code}
Executing the app shows
 
{code:java}
Logger FQCN: relocated.scala.Logger${code}
 
Which still seems to be correct
And, well, the bytecode generated for relocated classes also looks good, for 
example:
 
{code:java}
public void delayedInit(relocated.scala.Function0 Package relocation appears not to work with Scala
> -
>
> Key: MSHADE-345
> URL: https://issues.apache.org/jira/browse/MSHADE-345
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Reporter: Graham Pople
>Priority: Major
> Attachments: image (4).png
>
>
> (Apologies if this is a known issue, I searched but couldn't find it.)
> I have a small pom.xml that's simply pulling in two dependent libraries from 
> Maven, and shading them:
> {code:java}
> 
> http://maven.apache.org/POM/4.0.0;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/maven-v4_0_0.xsd;>
> 4.0.0
> com.couchbase.client
> scala-deps
> 1.1.1-SNAPSHOT
> jar
> Couchbase Scala Dependencies
> Shadowing dependencies for Scala prokect
> 
> 
> com.github.plokhotnyuk.jsoniter-scala
> jsoniter-scala-core_2.12
> 1.0.0
> 
> 
> com.github.plokhotnyuk.jsoniter-scala
> jsoniter-scala-macros_2.12
> 1.0.0
> 
> 
> 
> 
> 
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.1
> 
> 
> 
> com.github.plokhotnyuk
> 
> com.couchbase.client.scala.deps.plokhotnyuk
> 
> 
> true
> true
> true
> 
> 
> 
> package
> 
> shade
> 
> 
> 
> 
> 
> 
>  {code}
> From this I expect to get an uber-jar containing those dependencies, with 
> classfiles inside 
> com/couchbase/client/scala/deps/plokhotnyuk/jsoniter_scala/..., and with 
> those files starting "package com.couchbase.client.scala.deps.plokhotnyuk...".
> However, while the files are moved to the correct file structure, the package 
> names aren't adjusted.  Here's a screenshot from the sources jar:
> !image (4).png!
>  
> And my experiments with the binary jar itself seem to indicate that the same 
> issue exists at the bytecode level in the regular jar too, e.g. the 
> classfiles are in the right place but the package hasn't been changed.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (MSHADE-345) Package relocation appears not to work with Scala

[Javier Neira Sanchez (Jira)]

[ 
https://issues.apache.org/jira/browse/MSHADE-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693720#comment-17693720
 ] 

Javier Neira Sanchez edited comment on MSHADE-345 at 2/26/23 10:16 PM:
---

[~icshuo] hey, thanks for the hint to try to reroduce the issue. I followed it, 
you can check that version at 
[https://github.com/jneira/maven-shade-plugin/tree/SHADE-345_scala-package-relocation/src/it/projects/MSHADE-345_scala-package-relocation/src/main/scala]

The scala app looks like:
{code:java}
import org.apache.logging.log4j.scala.Logger;
import org.apache.logging.log4j.scala.Logging;
object MyApp extends App with Logging {  
  println("Logger FQCN: " + Logger.FQCN)
  logger.info("Test Logging")
} 
{code}
Executing the app shows
 
{code:java}
Logger FQCN: relocated.scala.Logger${code}
 
Which still seems to be correct
And, well, the bytecode generated for relocated classes also looks good, for 
example:
 
{code:java}
public void delayedInit(relocated.scala.Function0https://github.com/jneira/maven-shade-plugin/tree/SHADE-345_scala-package-relocation/src/it/projects/MSHADE-345_scala-package-relocation/src/main/scala]

The scala app looks like:

```
import org.apache.logging.log4j.scala.Logger;
import org.apache.logging.log4j.scala.Logging;

object MyApp extends App with Logging {
  println("Logger FQCN: " + Logger.FQCN)
  logger.info("Test Logging")
}
```
 
Executing the app shows
 
```
Logger FQCN: relocated.scala.Logger$
```
 
Which still seems to be correct
And, well, the bytecode generated for relocated classes also looks good, for 
example:
 
```
public void delayedInit(relocated.scala.Function0 Package relocation appears not to work with Scala
> -
>
> Key: MSHADE-345
> URL: https://issues.apache.org/jira/browse/MSHADE-345
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Reporter: Graham Pople
>Priority: Major
> Attachments: image (4).png
>
>
> (Apologies if this is a known issue, I searched but couldn't find it.)
> I have a small pom.xml that's simply pulling in two dependent libraries from 
> Maven, and shading them:
> {code:java}
> 
> http://maven.apache.org/POM/4.0.0;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/maven-v4_0_0.xsd;>
> 4.0.0
> com.couchbase.client
> scala-deps
> 1.1.1-SNAPSHOT
> jar
> Couchbase Scala Dependencies
> Shadowing dependencies for Scala prokect
> 
> 
> com.github.plokhotnyuk.jsoniter-scala
> jsoniter-scala-core_2.12
> 1.0.0
> 
> 
> com.github.plokhotnyuk.jsoniter-scala
> jsoniter-scala-macros_2.12
> 1.0.0
> 
> 
> 
> 
> 
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.1
> 
> 
> 
> com.github.plokhotnyuk
> 
> com.couchbase.client.scala.deps.plokhotnyuk
> 
> 
> true
> true
> true
> 
> 
> 
> package
> 
> shade
> 
> 
> 
> 
> 
> 
>  {code}
> From this I expect to get an uber-jar containing those dependencies, with 
> classfiles inside 
> com/couchbase/client/scala/deps/plokhotnyuk/jsoniter_scala/..., and with 
> those files starting "package com.couchbase.client.scala.deps.plokhotnyuk...".
> However, while the files are moved to the correct file structure, the package 
> names aren't adjusted.  Here's a screenshot from the sources jar:
> !image (4).png!
>  
> And my experiments with the binary jar itself seem to indicate that the same 
> issue exists at the bytecode level in the regular jar too, e.g. the 
> classfiles are in the right place but the package hasn't been changed.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MSHADE-345) Package relocation appears not to work with Scala

[Javier Neira Sanchez (Jira)]

[ 
https://issues.apache.org/jira/browse/MSHADE-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693720#comment-17693720
 ] 

Javier Neira Sanchez commented on MSHADE-345:
-

[~icshuo] hey, thanks for the hint to try to reroduce the issue. I followed it, 
you can check that version at 
[https://github.com/jneira/maven-shade-plugin/tree/SHADE-345_scala-package-relocation/src/it/projects/MSHADE-345_scala-package-relocation/src/main/scala]

The scala app looks like:

```
import org.apache.logging.log4j.scala.Logger;
import org.apache.logging.log4j.scala.Logging;

object MyApp extends App with Logging {
  println("Logger FQCN: " + Logger.FQCN)
  logger.info("Test Logging")
}
```
 
Executing the app shows
 
```
Logger FQCN: relocated.scala.Logger$
```
 
Which still seems to be correct
And, well, the bytecode generated for relocated classes also looks good, for 
example:
 
```
public void delayedInit(relocated.scala.Function0 Package relocation appears not to work with Scala
> -
>
> Key: MSHADE-345
> URL: https://issues.apache.org/jira/browse/MSHADE-345
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Reporter: Graham Pople
>Priority: Major
> Attachments: image (4).png
>
>
> (Apologies if this is a known issue, I searched but couldn't find it.)
> I have a small pom.xml that's simply pulling in two dependent libraries from 
> Maven, and shading them:
> {code:java}
> 
> http://maven.apache.org/POM/4.0.0;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/maven-v4_0_0.xsd;>
> 4.0.0
> com.couchbase.client
> scala-deps
> 1.1.1-SNAPSHOT
> jar
> Couchbase Scala Dependencies
> Shadowing dependencies for Scala prokect
> 
> 
> com.github.plokhotnyuk.jsoniter-scala
> jsoniter-scala-core_2.12
> 1.0.0
> 
> 
> com.github.plokhotnyuk.jsoniter-scala
> jsoniter-scala-macros_2.12
> 1.0.0
> 
> 
> 
> 
> 
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.1
> 
> 
> 
> com.github.plokhotnyuk
> 
> com.couchbase.client.scala.deps.plokhotnyuk
> 
> 
> true
> true
> true
> 
> 
> 
> package
> 
> shade
> 
> 
> 
> 
> 
> 
>  {code}
> From this I expect to get an uber-jar containing those dependencies, with 
> classfiles inside 
> com/couchbase/client/scala/deps/plokhotnyuk/jsoniter_scala/..., and with 
> those files starting "package com.couchbase.client.scala.deps.plokhotnyuk...".
> However, while the files are moved to the correct file structure, the package 
> names aren't adjusted.  Here's a screenshot from the sources jar:
> !image (4).png!
>  
> And my experiments with the binary jar itself seem to indicate that the same 
> issue exists at the bytecode level in the regular jar too, e.g. the 
> classfiles are in the right place but the package hasn't been changed.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] michael-o commented on pull request #1005: Replace some old, pre-Java 7 Plexus code

[via GitHub]

michael-o commented on PR #1005:
URL: https://github.com/apache/maven/pull/1005#issuecomment-1445481253

   @gnodet Can we finally change the semantics here? The caller opens the 
stream then he must close it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] elharo commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

[via GitHub]

elharo commented on code in PR #1015:
URL: https://github.com/apache/maven/pull/1015#discussion_r1118159158


##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##
@@ -364,4 +364,12 @@ public void testMng7644() {
 checkVersionsEqual("2.0." + x, "2.0.0." + x); // previously 
ordered, now equals
 }
 }
+
+@Test
+public void testMNG7701() {
+ComparableVersion c1 = new ComparableVersion("1.x");
+ComparableVersion c2 = new ComparableVersion("1_x");
+
+assertTrue(c1.compareTo(c2) < 0);
+}

Review Comment:
   snuck in from another PR. Branch management is hard. :-)  removed



##
maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java:
##
@@ -60,7 +59,7 @@ public void validate(Settings settings, 
SettingsProblemCollector problems) {
 for (int i = 0; i < pluginGroups.size(); i++) {
 String pluginGroup = pluginGroups.get(i).trim();
 
-if (StringUtils.isBlank(pluginGroup)) {
+if (pluginGroup.trim().isEmpty()) {

Review Comment:
   good point, and no it can't be null here since trim() doesn't return null. 
Fixed. 



##
maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java:
##
@@ -60,7 +59,7 @@ public void validate(Settings settings, 
SettingsProblemCollector problems) {
 for (int i = 0; i < pluginGroups.size(); i++) {
 String pluginGroup = pluginGroups.get(i).trim();
 
-if (StringUtils.isBlank(pluginGroup)) {
+if (pluginGroup.trim().isEmpty()) {
 addViolation(
 problems, Severity.ERROR, 
"pluginGroups.pluginGroup[" + i + "]", null, "must not be empty");
 } else if (!ID_REGEX.matcher(pluginGroup).matches()) {

Review Comment:
   I'm not sure I see how, but in any case that would be a pre-existing, 
unrelated issue. Please file a JIRA on this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7683) Plugin configuration is merged incorrectly

[Alexey Venderov (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693719#comment-17693719
 ] 

Alexey Venderov commented on MNG-7683:
--

[~cstamas] No. The issue exists only in the {{4.x}} line, starting from version 
{{4.0.0-alpha3}}

> Plugin configuration is merged incorrectly
> --
>
> Key: MNG-7683
> URL: https://issues.apache.org/jira/browse/MNG-7683
> Project: Maven
>  Issue Type: Bug
>  Components: Inheritance and Interpolation
>Affects Versions: 4.0.0-alpha-3, 4.0.x-candidate
>Reporter: Alexey Venderov
>Priority: Major
>
> Hi,
> As was mentioned by my colleague 
> [here|https://github.com/apache/maven/pull/866#discussion_r1058637665] there 
> is a regression in the plugin configuration merging logic introduced in 
> version {{4.0.0-alpha-3}}. The original assumption was that the issue is 
> caused by 
> [this|https://github.com/codehaus-plexus/plexus-utils/commit/67ac243dbc6434c03a9b1582d94aef6bf2b5cf95]
>  change in the {{plexus-utils}} library. I wrote a small reproducer test: 
> [https://github.com/c00ler/plexus-utils-merge-xml-reproducer/blob/main/src/test/java/com/github/avenderov/ReproducerTest.java]
>  and run it with the {{plexus-utils}} versions before and after the change. 
> Test passes with both versions. So it's not the change in the 
> {{plexus-utils}}.
> After that, I checked Maven sources and found out that {{Maven 4}} doesn't 
> use {{Xpp3Dom}} and associated utilities from the {{plexus-utils}} anymore, 
> and has its own merging logic implemented 
> [here|https://github.com/apache/maven/blob/master/maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeImpl.java#L207].
>  The behavior of the configuration merging logic was correct (same as in 
> maven 3.x) up until version {{4.0.0-alpha-2}} and then was changed in version 
> {{4.0.0-alpha-3}}.
> h3. Problem description.
> We have the following {{foo-bar-plugin}} configuration in the parent pom:
> {code:xml}
> 
>   
> 
>   foo.bar
>   foo-bar-plugin
>   
> 
>   
> org.apache.maven.plugins
> maven-compiler-plugin
> 
>   foo
> 
>   
>   
> org.apache.maven.plugins
> maven-surefire-plugin
> 
>   
> 
>   prop1
>   value1
> 
>   
> 
>   
> 
>   
> 
>   
> 
> {code}
> In the child pom, we want to make changes to the {{foo-bar-plugin}} 
> configuration:
> {code:xml}
> 
> 
>   
> foo.bar
> foo-bar-plugin
> 
>   
> 
>   org.apache.maven.plugins
>   maven-compiler-plugin
> 
> 
>   org.apache.maven.plugins
>   maven-surefire-plugin
>   
> 
>   
> prop2
> value2
>   
> 
>   
> 
>   
> 
>   
> 
> 
> {code}
> The expected effective pom after merging ({{maven-compiler-plugin}} 
> configuration is persisted, {{maven-surefire-plugin}} configuration is 
> merged):
> {code:xml}
> 
> 
>   
> foo.bar
> foo-bar-plugin
> 
>   
> 
>   org.apache.maven.plugins
>   maven-compiler-plugin
>   
> foo
>   
> 
> 
>   org.apache.maven.plugins
>   maven-surefire-plugin
>   
> 
>   
> prop1
> value1
>   
>   
> prop2
> value2
>   
> 
>   
> 
>   
> 
>   
> 
> 
> {code}
> Instead {{Maven 4.0.0-alpha-3}} produces the following result:
> {code:xml}
> 
> 
>   
> foo.bar
> foo-bar-plugin
> 
>   
> 
>   org.apache.maven.plugins
>   maven-compiler-plugin
>   
> 
>   
> prop1
> value1
>   
> 
>   
> 
> 
>   org.apache.maven.plugins
>   maven-surefire-plugin
>   
> 
>   
> prop2
> value2
>   
> 
>   
> 
>   
> 
>   
> 
> 
> {code}
> h3. Steps to reproduce.
> We have a repository with the reproducer: 
> [https://github.com/c00ler/maven-merge-xml-reproducer]:
>  * the [main|https://github.com/c00ler/maven-merge-xml-reproducer] branch 
> produces a diff between {{maven 3.8.7}} and {{maven 4.0.0-alpha-3}}. It shows 
> the described example;
>  * the 
> [alpha2-alpha3|https://github.com/c00ler/maven-merge-xml-reproducer/tree/alpha2-alpha3]
>  branch produces a 

[jira] [Commented] (DOXIATOOLS-80) Update to Doxia 2.x

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DOXIATOOLS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693718#comment-17693718
 ] 

ASF GitHub Bot commented on DOXIATOOLS-80:
--

kwin commented on PR #41:
URL: 
https://github.com/apache/maven-doxia-converter/pull/41#issuecomment-1445474399

   The generated XHTML is valid (look at the generated file) still the parser 
stumbles.




> Update to Doxia 2.x
> ---
>
> Key: DOXIATOOLS-80
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-80
> Project: Maven Doxia Tools
>  Issue Type: Improvement
>  Components: Doxia Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: doxia-converter-1.4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-doxia-converter] kwin commented on pull request #41: [DOXIATOOLS-80] Update to Doxia 2.0.0-M5

[via GitHub]

kwin commented on PR #41:
URL: 
https://github.com/apache/maven-doxia-converter/pull/41#issuecomment-1445474399

   The generated XHTML is valid (look at the generated file) still the parser 
stumbles.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (MNG-7699) Remove all Maven 3.9.0+ ITs from maven-3.8.x branch

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MNG-7699.
---
Resolution: Done

Done with 
[d9ee1f8d0f8cd139181bb8e12b7b78cdc423bc58|https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=d9ee1f8d0f8cd139181bb8e12b7b78cdc423bc58].

> Remove all Maven 3.9.0+ ITs from maven-3.8.x branch
> ---
>
> Key: MNG-7699
> URL: https://issues.apache.org/jira/browse/MNG-7699
> Project: Maven
>  Issue Type: Task
>  Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> These are skipped and cannot be executed on {{maven-3.8.x}} branch anyway:
> {noformat}
> $ grep SKIPPED skipped  | grep -e 3.9.0 -e 4.0
> mng7474 SessionScope.SessionScope().. SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7443 
> ConsistencyOfOptionalProjectsAndProfiles.ConsistentLoggingOfOptionalProfilesAndProjects()
>  SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng7504 NotWarnUnsupportedReportPlugins.WarnNotPresent(). SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,3.9.0]
> mng7468 UnsupportedPluginsParameters.ValidParameterAlias()... SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.InPluginManagement() SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.InBuildMixed().. SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.InBuildExecution().. SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.ValidParameter() SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.WithForkedGoalExecution() SKIPPED - 
> Maven version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.NoConfiguration()... SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.InPluginManagementParent() SKIPPED - 
> Maven version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.ValidParameterForOtherGoal() SKIPPED - 
> Maven version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7468 UnsupportedPluginsParameters.InBuildPlugin(). SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7470 ResolverTransport.ResolverTransportDefault(). SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7470 ResolverTransport.ResolverTransportNative().. SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7470 ResolverTransport.ResolverTransportWagon()... SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7464 ReadOnlyMojoParametersWarning.ReadOnlyProperty(). SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7464 ReadOnlyMojoParametersWarning.ReadOnlyConfig()... SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7464 ReadOnlyMojoParametersWarning.EmptyConfiguration()... SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7404 IgnorePrefixlessExpressions.IgnorePrefixlessExpressions() SKIPPED - 
> Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng5222 MojoDeprecated.DeprecatedProperty().. SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng5222 MojoDeprecated.DeprecatedConfig() SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng5222 MojoDeprecated.EmptyConfiguration().. SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [3.9.0,)
> mng7390 SelectModuleOutsideCwd.SelectModuleByRelativePath().. SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng7390 SelectModuleOutsideCwd.SelectMultipleModulesByCoordinate() SKIPPED - 
> Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng7390 
> SelectModuleOutsideCwd.SelectModulesOutsideCwdDoesNotWorkWhenDotMvnIsNotPresent()
>  SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng7390 SelectModuleOutsideCwd.SelectModulesByRelativePath(). SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng7390 SelectModuleOutsideCwd.SelectModuleByCoordinate() SKIPPED - Maven 
> version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng7244 IgnorePomPrefixInExpressions.IgnorePomPrefixInExpressions() SKIPPED - 
> Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng4463 DependencyManagementImportVersionRanges.FailureWithoutUpperBound() 
> SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
> mng4463 
> 

[GitHub] [maven-integration-testing] asfgit merged pull request #243: [MNG-7699] Remove all Maven 3.9.0+ ITs from maven-3.8.x branch

[via GitHub]

asfgit merged PR #243:
URL: https://github.com/apache/maven-integration-testing/pull/243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (DOXIATOOLS-80) Update to Doxia 2.x

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DOXIATOOLS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693715#comment-17693715
 ] 

ASF GitHub Bot commented on DOXIATOOLS-80:
--

michael-o commented on PR #41:
URL: 
https://github.com/apache/maven-doxia-converter/pull/41#issuecomment-1445471147

   > @michael-o Any idea why one XHTML5 test fails with a parsing exception in 
Doxia 2?
   
   I guess it misses the `` element. Look at what Doxia 2 now produces, 
this must match.




> Update to Doxia 2.x
> ---
>
> Key: DOXIATOOLS-80
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-80
> Project: Maven Doxia Tools
>  Issue Type: Improvement
>  Components: Doxia Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: doxia-converter-1.4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-doxia-converter] michael-o commented on pull request #41: [DOXIATOOLS-80] Update to Doxia 2.0.0-M5

[via GitHub]

michael-o commented on PR #41:
URL: 
https://github.com/apache/maven-doxia-converter/pull/41#issuecomment-1445471147

   > @michael-o Any idea why one XHTML5 test fails with a parsing exception in 
Doxia 2?
   
   I guess it misses the `` element. Look at what Doxia 2 now produces, 
this must match.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (DOXIATOOLS-80) Update to Doxia 2.x

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DOXIATOOLS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693713#comment-17693713
 ] 

ASF GitHub Bot commented on DOXIATOOLS-80:
--

michael-o commented on code in PR #41:
URL: 
https://github.com/apache/maven-doxia-converter/pull/41#discussion_r1118153892


##
pom.xml:
##
@@ -173,17 +123,35 @@ under the License.
   icu4j
   72.1
 
-
+
+  org.slf4j
+  slf4j-api
+  1.7.36
+
+
+  ch.qos.logback
+  logback-classic
+  1.2.11
+

Review Comment:
   Why not SLF4J simple with runtime scope?



##
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##
@@ -370,23 +335,21 @@ private void parse(
 File outputDirectoryOrFile = relativeOutputDirectory != null
 ? new File(output.getFile(), relativeOutputDirectory.getPath())
 : output.getFile();
-if (getLog().isDebugEnabled()) {
-getLog().debug("Parsing file from '" + inputFile.getAbsolutePath() 
+ "' with the encoding '"
-+ inputEncoding + "' to '" + 
outputDirectoryOrFile.getAbsolutePath()
-+ "' with the encoding '" + output.getEncoding() + "'");
-}
+LOGGER.debug(
+"Parsing file from '{}' with the encoding '{}'" + " to '{}' 
with the encoding '{}'",

Review Comment:
   Why not make it one string now?



##
src/main/java/org/apache/maven/doxia/cli/ConverterCli.java:
##
@@ -100,11 +98,9 @@ private static int doMain(String[] args) {
 }
 
 Converter converter = new DefaultConverter();
-Log log = new SystemStreamLog();
 if (debug) {
-log.setLogLevel(Log.LEVEL_DEBUG);
+// TODO: programmatically adjust log level
 }

Review Comment:
   Why then not drop the empty `if` clause?





> Update to Doxia 2.x
> ---
>
> Key: DOXIATOOLS-80
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-80
> Project: Maven Doxia Tools
>  Issue Type: Improvement
>  Components: Doxia Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: doxia-converter-1.4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-doxia-converter] michael-o commented on a diff in pull request #41: [DOXIATOOLS-80] Update to Doxia 2.0.0-M5

[via GitHub]

michael-o commented on code in PR #41:
URL: 
https://github.com/apache/maven-doxia-converter/pull/41#discussion_r1118153892


##
pom.xml:
##
@@ -173,17 +123,35 @@ under the License.
   icu4j
   72.1
 
-
+
+  org.slf4j
+  slf4j-api
+  1.7.36
+
+
+  ch.qos.logback
+  logback-classic
+  1.2.11
+

Review Comment:
   Why not SLF4J simple with runtime scope?



##
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##
@@ -370,23 +335,21 @@ private void parse(
 File outputDirectoryOrFile = relativeOutputDirectory != null
 ? new File(output.getFile(), relativeOutputDirectory.getPath())
 : output.getFile();
-if (getLog().isDebugEnabled()) {
-getLog().debug("Parsing file from '" + inputFile.getAbsolutePath() 
+ "' with the encoding '"
-+ inputEncoding + "' to '" + 
outputDirectoryOrFile.getAbsolutePath()
-+ "' with the encoding '" + output.getEncoding() + "'");
-}
+LOGGER.debug(
+"Parsing file from '{}' with the encoding '{}'" + " to '{}' 
with the encoding '{}'",

Review Comment:
   Why not make it one string now?



##
src/main/java/org/apache/maven/doxia/cli/ConverterCli.java:
##
@@ -100,11 +98,9 @@ private static int doMain(String[] args) {
 }
 
 Converter converter = new DefaultConverter();
-Log log = new SystemStreamLog();
 if (debug) {
-log.setLogLevel(Log.LEVEL_DEBUG);
+// TODO: programmatically adjust log level
 }

Review Comment:
   Why then not drop the empty `if` clause?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-jar-plugin] jorsol closed pull request #58: Small improvements to the code

[via GitHub]

jorsol closed pull request #58: Small improvements to the code
URL: https://github.com/apache/maven-jar-plugin/pull/58


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

[via GitHub]

michael-o commented on code in PR #1015:
URL: https://github.com/apache/maven/pull/1015#discussion_r1118151608


##
maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java:
##
@@ -60,7 +59,7 @@ public void validate(Settings settings, 
SettingsProblemCollector problems) {
 for (int i = 0; i < pluginGroups.size(); i++) {
 String pluginGroup = pluginGroups.get(i).trim();
 
-if (StringUtils.isBlank(pluginGroup)) {
+if (pluginGroup.trim().isEmpty()) {
 addViolation(
 problems, Severity.ERROR, 
"pluginGroups.pluginGroup[" + i + "]", null, "must not be empty");
 } else if (!ID_REGEX.matcher(pluginGroup).matches()) {

Review Comment:
   This error message is misleading...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

[via GitHub]

michael-o commented on code in PR #1015:
URL: https://github.com/apache/maven/pull/1015#discussion_r1118151563


##
maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java:
##
@@ -60,7 +59,7 @@ public void validate(Settings settings, 
SettingsProblemCollector problems) {
 for (int i = 0; i < pluginGroups.size(); i++) {
 String pluginGroup = pluginGroups.get(i).trim();
 
-if (StringUtils.isBlank(pluginGroup)) {
+if (pluginGroup.trim().isEmpty()) {

Review Comment:
   This is nonsense now since it is trimmed above in 60. Can it be `null`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MNG-7701) Incompatible version sorting changes

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7701:

Fix Version/s: (was: waiting-for-feedback)
   (was: 3.8.x-candidate)
   (was: 3.9.1-candidate)

> Incompatible version sorting changes
> 
>
> Key: MNG-7701
> URL: https://issues.apache.org/jira/browse/MNG-7701
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> Between 3.8.6 and 3.8.7, the sorting of a variety of version strings has 
> changed. This table captures the observed relations:
> ||Input 1||3.8.6||3.8.7||Input 2||
> |{{0.x}}|{{>}}|{{==}}|{{0-x}}|
> |{{1.x}}|{{<}}|{{==}}|{{1-x}}|
> |{{1.x}}|{{<}}|{{>}}|{{1_y}}|
> |{{1.y}}|{{<}}|{{>}}|{{1_x}}|
> |{{1-alpha}}|{{>}}|{{==}}|{{1.alpha}}|



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] michael-o commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

[via GitHub]

michael-o commented on code in PR #1015:
URL: https://github.com/apache/maven/pull/1015#discussion_r1118151341


##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##
@@ -364,4 +364,12 @@ public void testMng7644() {
 checkVersionsEqual("2.0." + x, "2.0.0." + x); // previously 
ordered, now equals
 }
 }
+
+@Test
+public void testMNG7701() {
+ComparableVersion c1 = new ComparableVersion("1.x");
+ComparableVersion c2 = new ComparableVersion("1_x");
+
+assertTrue(c1.compareTo(c2) < 0);
+}

Review Comment:
   This seems to be wrong here



##
maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java:
##
@@ -60,7 +59,7 @@ public void validate(Settings settings, 
SettingsProblemCollector problems) {
 for (int i = 0; i < pluginGroups.size(); i++) {
 String pluginGroup = pluginGroups.get(i).trim();
 
-if (StringUtils.isBlank(pluginGroup)) {
+if (pluginGroup.trim().isEmpty()) {
 addViolation(
 problems, Severity.ERROR, 
"pluginGroups.pluginGroup[" + i + "]", null, "must not be empty");
 } else if (!ID_REGEX.matcher(pluginGroup).matches()) {

Review Comment:
   This, the error message is misleading...



##
maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java:
##
@@ -60,7 +59,7 @@ public void validate(Settings settings, 
SettingsProblemCollector problems) {
 for (int i = 0; i < pluginGroups.size(); i++) {
 String pluginGroup = pluginGroups.get(i).trim();
 
-if (StringUtils.isBlank(pluginGroup)) {
+if (pluginGroup.trim().isEmpty()) {

Review Comment:
   This is nonsense now since it is trimmens above in 60. Can it be `null`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRESOLVER-325.

  Assignee: Michael Osipov
Resolution: Fixed

This issue has been addressed under the conditions described in MRESOLVER-331. 
A true solution can only come from the OpenJDK team.

> [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
> 
>
> Key: MRESOLVER-325
> URL: https://issues.apache.org/jira/browse/MRESOLVER-325
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Christoph Läubrich
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> If one runs a build that otherwise works fine on 3.8.x with 3.9 we now get 
> the following exception (full output can be found here 
> https://github.com/eclipse-platform/eclipse.platform/actions/runs/4211467991/jobs/7309831666):
> {code:java}
> Error: 5.889 [ERROR] Internal error: java.io.UncheckedIOException: 
> java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
>  -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update 
> (DefaultTrackingFileManager.java:121)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo 
> (EnhancedLocalRepositoryManager.java:274)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact 
> (EnhancedLocalRepositoryManager.java:252)
> at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.add 
> (EnhancedLocalRepositoryManager.java:225)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads 
> (DefaultArtifactResolver.java:680)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads 
> (DefaultArtifactResolver.java:592)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:478)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts 
> (DefaultArtifactResolver.java:278)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
> (DefaultArtifactResolver.java:255)
> at 
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
> (DefaultRepositorySystem.java:296)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:197)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:413)
> at org.apache.maven.repository.legacy.LegacyRepositorySystem.resolve 
> (LegacyRepositorySystem.java:332)
> at 
> org.eclipse.tycho.osgi.configuration.MavenDependenciesResolverConfigurer.resolve
>  (MavenDependenciesResolverConfigurer.java:104)
> at org.eclipse.tycho.core.shared.MavenDependenciesResolver.resolve 
> (MavenDependenciesResolver.java:60)
> at 

[jira] [Commented] (MRESOLVER-331) Make DefaultTrackingFileManager write directly to tracking files

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693710#comment-17693710
 ] 

ASF GitHub Bot commented on MRESOLVER-331:
--

asfgit closed pull request #259: [MRESOLVER-331] Make 
DefaultTrackingFileManager write directly to tracking files
URL: https://github.com/apache/maven-resolver/pull/259




> Make DefaultTrackingFileManager write directly to tracking files
> 
>
> Key: MRESOLVER-331
> URL: https://issues.apache.org/jira/browse/MRESOLVER-331
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Affects Versions: 1.9.5
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> Resolver recently introduced file collocation that is write to an adjecent 
> temp file and then atomically move to the target file. It turned out that on 
> Windows, when the target file is written with a high frequency the system 
> fails to move in time and it causes an {{AccessDeniedException}}, there is no 
> known workaround with current Java code.
> Since tracking files are written very often for the same artifact this 
> creates a bottleneck. We need to resort to write to the file directly for 
> now, although it just affects Windows.
> Pending: Report to the OpenJDK team



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-resolver] asfgit closed pull request #259: [MRESOLVER-331] Make DefaultTrackingFileManager write directly to tracking files

[via GitHub]

asfgit closed pull request #259: [MRESOLVER-331] Make 
DefaultTrackingFileManager write directly to tracking files
URL: https://github.com/apache/maven-resolver/pull/259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (MRESOLVER-331) Make DefaultTrackingFileManager write directly to tracking files

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRESOLVER-331.

Resolution: Fixed

Fixed with 
[23cd526fe754499e1ec54ea8e618557e731fd091|https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=802b50df5d9b7e3936f98b71496ece88da62f223].

> Make DefaultTrackingFileManager write directly to tracking files
> 
>
> Key: MRESOLVER-331
> URL: https://issues.apache.org/jira/browse/MRESOLVER-331
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Affects Versions: 1.9.5
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> Resolver recently introduced file collocation that is write to an adjecent 
> temp file and then atomically move to the target file. It turned out that on 
> Windows, when the target file is written with a high frequency the system 
> fails to move in time and it causes an {{AccessDeniedException}}, there is no 
> known workaround with current Java code.
> Since tracking files are written very often for the same artifact this 
> creates a bottleneck. We need to resort to write to the file directly for 
> now, although it just affects Windows.
> Pending: Report to the OpenJDK team



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MNG-7705) Sporadic failures on multiple builds sharing the same local repo when writing the .lastUpdated file

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7705:

Attachment: apache-maven-3.9.1-SNAPSHOT-bin.tar.gz

> Sporadic failures on multiple builds sharing the same local repo when writing 
> the .lastUpdated file
> ---
>
> Key: MNG-7705
> URL: https://issues.apache.org/jira/browse/MNG-7705
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.9.0
> Environment: Apache Maven 3.9.0 
> (9b58d2bad23a66be161c4664ef21ce219c2c8584)
> Maven home: /data00/bamboo/maven/maven-next
> Java version: 1.8.0_362, vendor: Red Hat, Inc., runtime: 
> /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b09-2.el8_7.x86_64/jre
> Default locale: en_CA, platform encoding: ISO-8859-1
> OS name: "linux", version: "4.18.0-193.el8.x86_64", arch: "amd64", family: 
> "unix"
>Reporter: Jim Sellers
>Priority: Minor
> Fix For: 3.9.2
>
> Attachments: MNG-7705.zip, apache-maven-3.9.1-SNAPSHOT-bin.tar.gz, 
> maven-resolver-util-1.9.6-SNAPSHOT.jar
>
>
> On a CI server, we have multiple builds running on the same host and sharing 
> the same repo.
> While testing 3.9.0, I started to see a NIO exception for the 
> {{.lastUpdated}} file. This has worked fine for years, all the way up to 
> 3.8.7.
> If you re-run the build, it will work. I think that it's just a collision 
> between the different processes.
> {code:title=example command}
> mvn --batch-mode dependency:sources dependency:resolve -Dclassifier=javadoc
> # this uses dependency:3.5.0:sources
> {code}
> {code:title=stracktrace}
> [WARNING] Failed to write tracking file 
> '/home/bamboo/.m2/repository/io/smallrye/config/smallrye-config/2.3.0/smallrye-config-2.3.0-javadoc.jar.lastUpdated'
>     java.nio.file.NoSuchFileException: 
> /home/bamboo/.m2/repository/io/smallrye/config/smallrye-config/2.3.0/smallrye-config-2.3.0-javadoc.jar.lastUpdated
>         at sun.nio.fs.UnixException.translateToIOException 
> (UnixException.java:86)
>         at sun.nio.fs.UnixException.rethrowAsIOException 
> (UnixException.java:102)
>         at sun.nio.fs.UnixException.rethrowAsIOException 
> (UnixException.java:107)
>         at sun.nio.fs.UnixFileSystemProvider.newByteChannel 
> (UnixFileSystemProvider.java:214)
>         at java.nio.file.Files.newByteChannel (Files.java:361)
>         at java.nio.file.Files.newByteChannel (Files.java:407)
>         at java.nio.file.spi.FileSystemProvider.newInputStream 
> (FileSystemProvider.java:384)
>         at java.nio.file.Files.newInputStream (Files.java:152)
>         at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update 
> (DefaultTrackingFileManager.java:90)
>         at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.write 
> (DefaultUpdateCheckManager.java:604)
>         at 
> org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.touchArtifact 
> (DefaultUpdateCheckManager.java:539)
>         at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads 
> (DefaultArtifactResolver.java:701)
>         at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads 
> (DefaultArtifactResolver.java:592)
>         at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:478)
>         at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts 
> (DefaultArtifactResolver.java:278)
>         at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
> (DefaultArtifactResolver.java:255)
>         at 
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
> (DefaultRepositorySystem.java:296)
>         at 
> org.apache.maven.shared.transfer.artifact.resolve.internal.Maven31ArtifactResolver.resolveArtifact
>  (Maven31ArtifactResolver.java:97)
>         at 
> org.apache.maven.shared.transfer.artifact.resolve.internal.Maven31ArtifactResolver.resolveArtifact
>  (Maven31ArtifactResolver.java:78)
>         at 
> org.apache.maven.shared.transfer.artifact.resolve.internal.DefaultArtifactResolver.resolveArtifact
>  (DefaultArtifactResolver.java:70)
>         at 
> org.apache.maven.plugins.dependency.fromDependencies.AbstractDependencyFilterMojo.resolve
>  (AbstractDependencyFilterMojo.java:464)
>         at 
> org.apache.maven.plugins.dependency.fromDependencies.AbstractDependencyFilterMojo.getClassifierTranslatedDependencies
>  (AbstractDependencyFilterMojo.java:408)
>         at 
> org.apache.maven.plugins.dependency.fromDependencies.AbstractDependencyFilterMojo.getDependencySets
>  (AbstractDependencyFilterMojo.java:340)
>         at 
> org.apache.maven.plugins.dependency.resolvers.ResolveDependenciesMojo.doExecute
>  (ResolveDependenciesMojo.java:103)
>         at 
> 

[jira] [Commented] (MNG-7705) Sporadic failures on multiple builds sharing the same local repo when writing the .lastUpdated file

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693708#comment-17693708
 ] 

Michael Osipov commented on MNG-7705:
-

[~sellersj], uploaded a patched version of Maven. Can you give it a try again?

> Sporadic failures on multiple builds sharing the same local repo when writing 
> the .lastUpdated file
> ---
>
> Key: MNG-7705
> URL: https://issues.apache.org/jira/browse/MNG-7705
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.9.0
> Environment: Apache Maven 3.9.0 
> (9b58d2bad23a66be161c4664ef21ce219c2c8584)
> Maven home: /data00/bamboo/maven/maven-next
> Java version: 1.8.0_362, vendor: Red Hat, Inc., runtime: 
> /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b09-2.el8_7.x86_64/jre
> Default locale: en_CA, platform encoding: ISO-8859-1
> OS name: "linux", version: "4.18.0-193.el8.x86_64", arch: "amd64", family: 
> "unix"
>Reporter: Jim Sellers
>Priority: Minor
> Fix For: 3.9.2
>
> Attachments: MNG-7705.zip, apache-maven-3.9.1-SNAPSHOT-bin.tar.gz, 
> maven-resolver-util-1.9.6-SNAPSHOT.jar
>
>
> On a CI server, we have multiple builds running on the same host and sharing 
> the same repo.
> While testing 3.9.0, I started to see a NIO exception for the 
> {{.lastUpdated}} file. This has worked fine for years, all the way up to 
> 3.8.7.
> If you re-run the build, it will work. I think that it's just a collision 
> between the different processes.
> {code:title=example command}
> mvn --batch-mode dependency:sources dependency:resolve -Dclassifier=javadoc
> # this uses dependency:3.5.0:sources
> {code}
> {code:title=stracktrace}
> [WARNING] Failed to write tracking file 
> '/home/bamboo/.m2/repository/io/smallrye/config/smallrye-config/2.3.0/smallrye-config-2.3.0-javadoc.jar.lastUpdated'
>     java.nio.file.NoSuchFileException: 
> /home/bamboo/.m2/repository/io/smallrye/config/smallrye-config/2.3.0/smallrye-config-2.3.0-javadoc.jar.lastUpdated
>         at sun.nio.fs.UnixException.translateToIOException 
> (UnixException.java:86)
>         at sun.nio.fs.UnixException.rethrowAsIOException 
> (UnixException.java:102)
>         at sun.nio.fs.UnixException.rethrowAsIOException 
> (UnixException.java:107)
>         at sun.nio.fs.UnixFileSystemProvider.newByteChannel 
> (UnixFileSystemProvider.java:214)
>         at java.nio.file.Files.newByteChannel (Files.java:361)
>         at java.nio.file.Files.newByteChannel (Files.java:407)
>         at java.nio.file.spi.FileSystemProvider.newInputStream 
> (FileSystemProvider.java:384)
>         at java.nio.file.Files.newInputStream (Files.java:152)
>         at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update 
> (DefaultTrackingFileManager.java:90)
>         at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.write 
> (DefaultUpdateCheckManager.java:604)
>         at 
> org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.touchArtifact 
> (DefaultUpdateCheckManager.java:539)
>         at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads 
> (DefaultArtifactResolver.java:701)
>         at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads 
> (DefaultArtifactResolver.java:592)
>         at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:478)
>         at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts 
> (DefaultArtifactResolver.java:278)
>         at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
> (DefaultArtifactResolver.java:255)
>         at 
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
> (DefaultRepositorySystem.java:296)
>         at 
> org.apache.maven.shared.transfer.artifact.resolve.internal.Maven31ArtifactResolver.resolveArtifact
>  (Maven31ArtifactResolver.java:97)
>         at 
> org.apache.maven.shared.transfer.artifact.resolve.internal.Maven31ArtifactResolver.resolveArtifact
>  (Maven31ArtifactResolver.java:78)
>         at 
> org.apache.maven.shared.transfer.artifact.resolve.internal.DefaultArtifactResolver.resolveArtifact
>  (DefaultArtifactResolver.java:70)
>         at 
> org.apache.maven.plugins.dependency.fromDependencies.AbstractDependencyFilterMojo.resolve
>  (AbstractDependencyFilterMojo.java:464)
>         at 
> org.apache.maven.plugins.dependency.fromDependencies.AbstractDependencyFilterMojo.getClassifierTranslatedDependencies
>  (AbstractDependencyFilterMojo.java:408)
>         at 
> org.apache.maven.plugins.dependency.fromDependencies.AbstractDependencyFilterMojo.getDependencySets
>  (AbstractDependencyFilterMojo.java:340)
>         at 
> 

[jira] [Commented] (MRESOLVER-329) Make IO in DefaultTrackingFileManager more robust

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693707#comment-17693707
 ] 

Michael Osipov commented on MRESOLVER-329:
--

I'd like to supersede this with MRESOLVER-331.

> Make IO in DefaultTrackingFileManager more robust
> -
>
> Key: MRESOLVER-329
> URL: https://issues.apache.org/jira/browse/MRESOLVER-329
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.6
>
>
> There are couple of spots where implementation naively assumes is alone 
> running process on this world. Several user reports suggests this is not the 
> case, like MRESOLVER-325 or MNG-7705. Fix these spots.
> Still, something is fishy, as it seems these files (all that are handled by 
> DefaultTrackingFileManager) are not subject to locking? This needs 
> investigation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693706#comment-17693706
 ] 

Michael Osipov commented on MRESOLVER-325:
--

Reported: https://mail.openjdk.org/pipermail/nio-dev/2023-February/013252.html

> [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
> 
>
> Key: MRESOLVER-325
> URL: https://issues.apache.org/jira/browse/MRESOLVER-325
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Christoph Läubrich
>Priority: Major
> Fix For: 1.9.6
>
>
> If one runs a build that otherwise works fine on 3.8.x with 3.9 we now get 
> the following exception (full output can be found here 
> https://github.com/eclipse-platform/eclipse.platform/actions/runs/4211467991/jobs/7309831666):
> {code:java}
> Error: 5.889 [ERROR] Internal error: java.io.UncheckedIOException: 
> java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
>  -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update 
> (DefaultTrackingFileManager.java:121)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo 
> (EnhancedLocalRepositoryManager.java:274)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact 
> (EnhancedLocalRepositoryManager.java:252)
> at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.add 
> (EnhancedLocalRepositoryManager.java:225)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads 
> (DefaultArtifactResolver.java:680)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads 
> (DefaultArtifactResolver.java:592)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:478)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts 
> (DefaultArtifactResolver.java:278)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
> (DefaultArtifactResolver.java:255)
> at 
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
> (DefaultRepositorySystem.java:296)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:197)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:413)
> at org.apache.maven.repository.legacy.LegacyRepositorySystem.resolve 
> (LegacyRepositorySystem.java:332)
> at 
> org.eclipse.tycho.osgi.configuration.MavenDependenciesResolverConfigurer.resolve
>  (MavenDependenciesResolverConfigurer.java:104)
> at org.eclipse.tycho.core.shared.MavenDependenciesResolver.resolve 
> (MavenDependenciesResolver.java:60)
> at org.eclipse.tycho.core.resolver.MavenTargetDefinitionContent. 
> (MavenTargetDefinitionContent.java:262)
> at 
> 

[jira] [Commented] (MJAR-62) Build-Jdk in Manifest.mf does not reflect which compiler version actually compiled the classes in the jar

[Jira]

[ 
https://issues.apache.org/jira/browse/MJAR-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693701#comment-17693701
 ] 

Jorge Solórzano commented on MJAR-62:
-

[~michael-o] That could work, but again, that will only refer to the baseline 
code in an MRJAR, and ideally, it makes sense to use something like 
Target-Bytecode and use the bytecode version instead.

> Build-Jdk in Manifest.mf does not reflect which compiler version actually 
> compiled the classes in the jar
> -
>
> Key: MJAR-62
> URL: https://issues.apache.org/jira/browse/MJAR-62
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Reporter: Stefan Magnus Landrø
>Priority: Major
> Attachments: example-app.zip
>
>
> Manifest.mf does not reflect the version of the compiler that built the jar, 
> but defaults to the version that maven runs under:  Build-Jdk: 
> ${java.version}.
> I believe this makes users uncertain of which compiler was actually used to 
> build the classes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693698#comment-17693698
 ] 

Michael Osipov commented on MRESOLVER-325:
--

Here it is: https://github.com/apache/maven-resolver/pull/259

I'll try to report this issue next week to the OpenJDK nio team.

> [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
> 
>
> Key: MRESOLVER-325
> URL: https://issues.apache.org/jira/browse/MRESOLVER-325
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Christoph Läubrich
>Priority: Major
> Fix For: 1.9.6
>
>
> If one runs a build that otherwise works fine on 3.8.x with 3.9 we now get 
> the following exception (full output can be found here 
> https://github.com/eclipse-platform/eclipse.platform/actions/runs/4211467991/jobs/7309831666):
> {code:java}
> Error: 5.889 [ERROR] Internal error: java.io.UncheckedIOException: 
> java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
>  -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update 
> (DefaultTrackingFileManager.java:121)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo 
> (EnhancedLocalRepositoryManager.java:274)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact 
> (EnhancedLocalRepositoryManager.java:252)
> at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.add 
> (EnhancedLocalRepositoryManager.java:225)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads 
> (DefaultArtifactResolver.java:680)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads 
> (DefaultArtifactResolver.java:592)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:478)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts 
> (DefaultArtifactResolver.java:278)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
> (DefaultArtifactResolver.java:255)
> at 
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
> (DefaultRepositorySystem.java:296)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:197)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:413)
> at org.apache.maven.repository.legacy.LegacyRepositorySystem.resolve 
> (LegacyRepositorySystem.java:332)
> at 
> org.eclipse.tycho.osgi.configuration.MavenDependenciesResolverConfigurer.resolve
>  (MavenDependenciesResolverConfigurer.java:104)
> at org.eclipse.tycho.core.shared.MavenDependenciesResolver.resolve 
> (MavenDependenciesResolver.java:60)
> at org.eclipse.tycho.core.resolver.MavenTargetDefinitionContent. 
> 

[jira] [Created] (MRESOLVER-331) Make DefaultTrackingFileManager write directly to tracking files

[Michael Osipov (Jira)]

Michael Osipov created MRESOLVER-331:


 Summary: Make DefaultTrackingFileManager write directly to 
tracking files
 Key: MRESOLVER-331
 URL: https://issues.apache.org/jira/browse/MRESOLVER-331
 Project: Maven Resolver
  Issue Type: Task
  Components: Resolver
Affects Versions: 1.9.5
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 1.9.6


Resolver recently introduced file collocation that is write to an adjecent temp 
file and then atomically move to the target file. It turned out that on 
Windows, when the target file is written with a high frequency the system fails 
to move in time and it causes an {{AccessDeniedException}}, there is no known 
workaround with current Java code.
Since tracking files are written very often for the same artifact this creates 
a bottleneck. We need to resort to write to the file directly for now, although 
it just affects Windows.

Pending: Report to the OpenJDK team



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693631#comment-17693631
 ] 

Michael Osipov edited comment on MRESOLVER-325 at 2/26/23 7:39 PM:
---

Another Windows test:
{code:java}
import java.io.BufferedReader;
import java.io.IOException;
import java.io.Writer;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.nio.file.StandardCopyOption;

import com.sun.jna.platform.win32.Kernel32;
import com.sun.jna.platform.win32.WinBase;
import com.sun.jna.platform.win32.WinDef.DWORD;

public class AtomicMove {

public static void main(String[] args) throws IOException, 
InterruptedException {

Path target = Paths.get("mumu");

for (int i = 0; i < 100; i++) {
Path temp = Paths.get("mumu." + i);
try (Writer w = Files.newBufferedWriter(temp)) {
w.write(i + ": I was made for crashing you, 
baby!");
}
//Files.move(temp, target, 
StandardCopyOption.ATOMIC_MOVE);
Kernel32.INSTANCE.MoveFileEx( 
temp.toAbsolutePath().toString(), target.toAbsolutePath().toString(),
new DWORD( 
WinBase.MOVEFILE_REPLACE_EXISTING | WinBase.MOVEFILE_WRITE_THROUGH ) );
try (BufferedReader r = 
Files.newBufferedReader(target)) {
System.out.println(r.readLine());
}
}
}

}
{code}

Output:
{noformat}
0: I was made for crashing you, baby!
1: I was made for crashing you, baby!
2: I was made for crashing you, baby!
3: I was made for crashing you, baby!
4: I was made for crashing you, baby!
5: I was made for crashing you, baby!
6: I was made for crashing you, baby!
7: I was made for crashing you, baby!
8: I was made for crashing you, baby!
9: I was made for crashing you, baby!
10: I was made for crashing you, baby!
11: I was made for crashing you, baby!
12: I was made for crashing you, baby!
13: I was made for crashing you, baby!
14: I was made for crashing you, baby!
15: I was made for crashing you, baby!
16: I was made for crashing you, baby!
17: I was made for crashing you, baby!
18: I was made for crashing you, baby!
19: I was made for crashing you, baby!
20: I was made for crashing you, baby!
21: I was made for crashing you, baby!
22: I was made for crashing you, baby!
23: I was made for crashing you, baby!
24: I was made for crashing you, baby!
25: I was made for crashing you, baby!
26: I was made for crashing you, baby!
27: I was made for crashing you, baby!
28: I was made for crashing you, baby!
29: I was made for crashing you, baby!
30: I was made for crashing you, baby!
31: I was made for crashing you, baby!
32: I was made for crashing you, baby!
33: I was made for crashing you, baby!
34: I was made for crashing you, baby!
35: I was made for crashing you, baby!
36: I was made for crashing you, baby!
37: I was made for crashing you, baby!
38: I was made for crashing you, baby!
39: I was made for crashing you, baby!
40: I was made for crashing you, baby!
41: I was made for crashing you, baby!
42: I was made for crashing you, baby!
43: I was made for crashing you, baby!
44: I was made for crashing you, baby!
45: I was made for crashing you, baby!
46: I was made for crashing you, baby!
47: I was made for crashing you, baby!
48: I was made for crashing you, baby!
49: I was made for crashing you, baby!
50: I was made for crashing you, baby!
51: I was made for crashing you, baby!
52: I was made for crashing you, baby!
53: I was made for crashing you, baby!
54: I was made for crashing you, baby!
55: I was made for crashing you, baby!
56: I was made for crashing you, baby!
57: I was made for crashing you, baby!
58: I was made for crashing you, baby!
59: I was made for crashing you, baby!
60: I was made for crashing you, baby!
61: I was made for crashing you, baby!
62: I was made for crashing you, baby!
63: I was made for crashing you, baby!
64: I was made for crashing you, baby!
65: I was made for crashing you, baby!
66: I was made for crashing you, baby!
67: I was made for crashing you, baby!
68: I was made for crashing you, baby!
69: I was made for crashing you, baby!
70: I was made for crashing you, baby!
71: I was made for crashing you, baby!
72: I was made for crashing you, baby!
73: I was made for crashing you, baby!
74: I was made for crashing you, baby!
75: I was made for crashing you, baby!
75: I was made for crashing you, baby!
77: I was made for crashing you, baby!
78: I was made for crashing you, baby!
79: I was made for crashing you, baby!
80: I was made for crashing you, baby!
81: I was made for crashing you, baby!
82: I was made for crashing you, baby!
83: I was made for crashing you, baby!
84: I was made for crashing 

[GitHub] [maven] gnodet commented on pull request #1016: remove unused code

[via GitHub]

gnodet commented on PR #1016:
URL: https://github.com/apache/maven/pull/1016#issuecomment-1445444959

   > Yes, I've been looking at that. There are several somewhat parallel tracks 
here. The work you're doing on XML is the biggest part of it. I'd also like to 
get rid of a lot of the duplicate utility code that's been copied and pasted 
into Plexus utils, maven-shared-utils, apache commons, and other places over 
the years. These days a lot of it can ve found in the JDK. Ideally I'd like tp 
reach a point where org.codehaus is nowhere to be found in our code. One can 
dream. :-)
   
   I would begin by removing any dependency on `maven-shared-utils` because I 
think not many projects have migrated from plexus-utils.  So the path will be 
much easier in this way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MJAR-62) Build-Jdk in Manifest.mf does not reflect which compiler version actually compiled the classes in the jar

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MJAR-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693685#comment-17693685
 ] 

Michael Osipov commented on MJAR-62:


[~jorsol], so one would require a {{Target-Jdk}} manifest entry.

> Build-Jdk in Manifest.mf does not reflect which compiler version actually 
> compiled the classes in the jar
> -
>
> Key: MJAR-62
> URL: https://issues.apache.org/jira/browse/MJAR-62
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Reporter: Stefan Magnus Landrø
>Priority: Major
> Attachments: example-app.zip
>
>
> Manifest.mf does not reflect the version of the compiler that built the jar, 
> but defaults to the version that maven runs under:  Build-Jdk: 
> ${java.version}.
> I believe this makes users uncertain of which compiler was actually used to 
> build the classes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-jar-plugin] jorsol opened a new pull request, #59: [MJAR-293] Update Parent to 39

[via GitHub]

jorsol opened a new pull request, #59:
URL: https://github.com/apache/maven-jar-plugin/pull/59

   Also increased the version of maven-jar-plugin following other plugins that 
bump the parent to 39 due to the style change. 
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MJAR) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MJAR-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MJAR-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [X] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] elharo merged pull request #1016: remove unused code

[via GitHub]

elharo merged PR #1016:
URL: https://github.com/apache/maven/pull/1016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] elharo commented on pull request #1016: remove unused code

[via GitHub]

elharo commented on PR #1016:
URL: https://github.com/apache/maven/pull/1016#issuecomment-1445428500

   Yes, I've been looking at that. There are several somewhat parallel tracks 
here. The work you're doing on XML is the biggest part of it. I'd also like to 
get rid of a lot of the duplicate utility code that's been copied and pasted 
into Plexus utils, maven-shared-utils, apache commons, and other places over 
the years. These days a lot of it can ve found in the JDK. Ideally I'd like tp 
reach a point where org.codehaus is nowhere to be found in our code. One can 
dream. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MJAR-293) Update Parent to 39

[Jira]

Jorge Solórzano created MJAR-293:


 Summary: Update Parent to 39
 Key: MJAR-293
 URL: https://issues.apache.org/jira/browse/MJAR-293
 Project: Maven JAR Plugin
  Issue Type: Dependency upgrade
Affects Versions: 3.3.0
Reporter: Jorge Solórzano






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-mvnd] oehme opened a new pull request, #797: Add property to disable model caching

[via GitHub]

oehme opened a new pull request, #797:
URL: https://github.com/apache/maven-mvnd/pull/797

   This is mostly for the integration tests of the Gradle Enterprise Maven 
extension, which heavily test dependency resolution and reuse the same GAVs in 
many test, e.g. a:b:1.0. It would be a lot of effort to rewrite all those tests 
and a shame to restart the daemon every time. So I wanted to ask if you'd 
consider this flag to disable the caching altogether.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MJAR-62) Build-Jdk in Manifest.mf does not reflect which compiler version actually compiled the classes in the jar

[Jira]

[ 
https://issues.apache.org/jira/browse/MJAR-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693678#comment-17693678
 ] 

Jorge Solórzano commented on MJAR-62:
-

This issue as it stands out today is irrelevant, and it actually does the 
correct thing, let me explain:

The {{MANIFEST.MF}} does not reflect the version of the compiler that built the 
jar because you can compile a class using a higher JDK version that targets a 
lower Java bytecode, so assume that you build a JAR that compiles the classes 
with JDK 17 but targets (–release) Java 11, which version do you use as 
*Build-Jdk* option? you are using Java 17 so it makes sense to set the version 
to {+}17{+}, but at the same time, you are compiling to Java 11 so you could 
argue that it must use {+}11{+}, but that is not true, and even the bytecode 
produced could be different.

But even if we try to use the "same" version in the *Build-Jdk* property that 
compiles the classes, the most important point that this is irrelevant now, is 
that we now have Multi-Release JARs ("MRJAR"), that contain bytecode generated 
for different Java versions in a versioned area of the JAR, so, if you build a 
JAR which compiles the base classes as Java 8, and have versioned classes for 
Java 9, Java 11, and Java 17, which version do you set in the *Build-Jdk* 
property? If you use the lower one (Java 8) that is not correct since it 
contains classes with different bytecode, and if you use the higher one (Java 
17) that could not be entirely true as you might probably build the JAR using 
JDK 19.

In the end, the *Build-Jdk* should be used more as a property to signal which 
JDK was used to build (or a better term "assemble") the JAR rather than to know 
the compiled bytecode contained, when I mean that it actually does the correct 
thing is because if the JDK used to assemble the JAR is the one that Maven 
uses, then that's the JDK to be used in the property.

NOTE: This has no relation with the issue MJAR-289 since Toolchains handling is 
a different topic and this issue does not duplicate that, and while I agree 
that toolchain support could be improved, the same premise should be done, if 
maven-jar-plugin is aware of the toolchain, and the toolchain of 
maven-compiler-plugin is different from the toolchain used in maven-jar-plugin, 
which version should be used in the property? of course the one that uses 
maven-jar-plugin, yet doesn't need any special treatment since it will use the 
"java.version" property which again is the correct thing to do.

> Build-Jdk in Manifest.mf does not reflect which compiler version actually 
> compiled the classes in the jar
> -
>
> Key: MJAR-62
> URL: https://issues.apache.org/jira/browse/MJAR-62
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Reporter: Stefan Magnus Landrø
>Priority: Major
> Attachments: example-app.zip
>
>
> Manifest.mf does not reflect the version of the compiler that built the jar, 
> but defaults to the version that maven runs under:  Build-Jdk: 
> ${java.version}.
> I believe this makes users uncertain of which compiler was actually used to 
> build the classes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693671#comment-17693671
 ] 

Michael Osipov commented on MRESOLVER-325:
--

Played with the size, went upto 10 MB, no change. So it is not the size, but I 
guess rather the frequency.

> [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
> 
>
> Key: MRESOLVER-325
> URL: https://issues.apache.org/jira/browse/MRESOLVER-325
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Christoph Läubrich
>Priority: Major
> Fix For: 1.9.6
>
>
> If one runs a build that otherwise works fine on 3.8.x with 3.9 we now get 
> the following exception (full output can be found here 
> https://github.com/eclipse-platform/eclipse.platform/actions/runs/4211467991/jobs/7309831666):
> {code:java}
> Error: 5.889 [ERROR] Internal error: java.io.UncheckedIOException: 
> java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
>  -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update 
> (DefaultTrackingFileManager.java:121)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo 
> (EnhancedLocalRepositoryManager.java:274)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact 
> (EnhancedLocalRepositoryManager.java:252)
> at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.add 
> (EnhancedLocalRepositoryManager.java:225)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads 
> (DefaultArtifactResolver.java:680)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads 
> (DefaultArtifactResolver.java:592)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:478)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts 
> (DefaultArtifactResolver.java:278)
> at 
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
> (DefaultArtifactResolver.java:255)
> at 
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
> (DefaultRepositorySystem.java:296)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:197)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve 
> (DefaultArtifactResolver.java:413)
> at org.apache.maven.repository.legacy.LegacyRepositorySystem.resolve 
> (LegacyRepositorySystem.java:332)
> at 
> org.eclipse.tycho.osgi.configuration.MavenDependenciesResolverConfigurer.resolve
>  (MavenDependenciesResolverConfigurer.java:104)
> at org.eclipse.tycho.core.shared.MavenDependenciesResolver.resolve 
> (MavenDependenciesResolver.java:60)
> at org.eclipse.tycho.core.resolver.MavenTargetDefinitionContent. 
> 

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #146: Bump spring-security-core from 2.0.4 to 5.5.7 in /src/it/projects/MJAVADOC-526_aggr-managedDeps/javadoc-child

[via GitHub]

dependabot[bot] commented on PR #146:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/146#issuecomment-1445392056

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #184: Bump apache/maven-gh-actions-shared from 2 to 3

[via GitHub]

dependabot[bot] commented on PR #184:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/184#issuecomment-1445392054

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz closed pull request #146: Bump spring-security-core from 2.0.4 to 5.5.7 in /src/it/projects/MJAVADOC-526_aggr-managedDeps/javadoc-child

[via GitHub]

slachiewicz closed pull request #146: Bump spring-security-core from 2.0.4 to 
5.5.7 in /src/it/projects/MJAVADOC-526_aggr-managedDeps/javadoc-child
URL: https://github.com/apache/maven-javadoc-plugin/pull/146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz closed pull request #188: ci fix: adopt-openj9 does not support the footer param

[via GitHub]

slachiewicz closed pull request #188: ci fix: adopt-openj9 does not support the 
footer param
URL: https://github.com/apache/maven-javadoc-plugin/pull/188


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz closed pull request #184: Bump apache/maven-gh-actions-shared from 2 to 3

[via GitHub]

slachiewicz closed pull request #184: Bump apache/maven-gh-actions-shared from 
2 to 3
URL: https://github.com/apache/maven-javadoc-plugin/pull/184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-shared-utils] elharo opened a new pull request, #131: Deprecate newXmlWriter

[via GitHub]

elharo opened a new pull request, #131:
URL: https://github.com/apache/maven-shared-utils/pull/131

   XmlStreamWriter is deprecated so the factory mwthods that create one should 
be too.  @hboutemy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #141: Bump gson from 2.5 to 2.8.9 in /src/it/projects/MJAVADOC-528

[via GitHub]

dependabot[bot] commented on PR #141:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/141#issuecomment-1445387416

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz closed pull request #178: Bump mrm-maven-plugin from 1.2.0 to 1.5.0

[via GitHub]

slachiewicz closed pull request #178: Bump mrm-maven-plugin from 1.2.0 to 1.5.0
URL: https://github.com/apache/maven-javadoc-plugin/pull/178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz closed pull request #141: Bump gson from 2.5 to 2.8.9 in /src/it/projects/MJAVADOC-528

[via GitHub]

slachiewicz closed pull request #141: Bump gson from 2.5 to 2.8.9 in 
/src/it/projects/MJAVADOC-528
URL: https://github.com/apache/maven-javadoc-plugin/pull/141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #178: Bump mrm-maven-plugin from 1.2.0 to 1.5.0

[via GitHub]

dependabot[bot] commented on PR #178:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/178#issuecomment-1445387311

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #177: Bump maven-plugins from 37 to 39

[via GitHub]

dependabot[bot] commented on PR #177:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/177#issuecomment-1445387207

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz closed pull request #177: Bump maven-plugins from 37 to 39

[via GitHub]

slachiewicz closed pull request #177: Bump maven-plugins from 37 to 39
URL: https://github.com/apache/maven-javadoc-plugin/pull/177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #169: Bump qdox from 2.0.1 to 2.0.3

[via GitHub]

dependabot[bot] commented on PR #169:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/169#issuecomment-1445387159

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz closed pull request #169: Bump qdox from 2.0.1 to 2.0.3

[via GitHub]

slachiewicz closed pull request #169: Bump qdox from 2.0.1 to 2.0.3
URL: https://github.com/apache/maven-javadoc-plugin/pull/169


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (DOXIATOOLS-80) Update to Doxia 2.x

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DOXIATOOLS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693652#comment-17693652
 ] 

ASF GitHub Bot commented on DOXIATOOLS-80:
--

kwin commented on PR #41:
URL: 
https://github.com/apache/maven-doxia-converter/pull/41#issuecomment-1445373060

   @michael-o Any idea why one XHTML5 test fails with a parsing exception in 
Doxia 2?




> Update to Doxia 2.x
> ---
>
> Key: DOXIATOOLS-80
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-80
> Project: Maven Doxia Tools
>  Issue Type: Improvement
>  Components: Doxia Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: doxia-converter-1.4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-doxia-converter] kwin commented on pull request #41: [DOXIATOOLS-80] Update to Doxia 2.0.0-M5

[via GitHub]

kwin commented on PR #41:
URL: 
https://github.com/apache/maven-doxia-converter/pull/41#issuecomment-1445373060

   @michael-o Any idea why one XHTML5 test fails with a parsing exception in 
Doxia 2?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] elharo opened a new pull request, #1016: remove unused code

[via GitHub]

elharo opened a new pull request, #1016:
URL: https://github.com/apache/maven/pull/1016

   and we remove reference to class we want to delete


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-doxia] kwin commented on a diff in pull request #146: Bugfix/newlines

[via GitHub]

kwin commented on code in PR #146:
URL: https://github.com/apache/maven-doxia/pull/146#discussion_r1118085653


##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/SinkEventElement.java:
##
@@ -80,4 +80,22 @@ public String toString() {
 builder.append(']');
 return builder.toString();
 }
+
+@Override
+public int hashCode() {

Review Comment:
   Those is a test class only! I don't think adding test for testing utilities 
is very useful. Tests will fail if those don't work!



##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/SinkEventElement.java:
##
@@ -80,4 +80,22 @@ public String toString() {
 builder.append(']');
 return builder.toString();
 }
+
+@Override
+public int hashCode() {

Review Comment:
   This is a test class only! I don't think adding test for testing utilities 
is very useful. Tests will fail if those don't work!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-doxia] kwin commented on a diff in pull request #146: Bugfix/newlines

[via GitHub]

kwin commented on code in PR #146:
URL: https://github.com/apache/maven-doxia/pull/146#discussion_r1118085895


##
doxia-modules/doxia-module-markdown/src/test/java/org/apache/maven/doxia/module/markdown/MarkdownSinkTest.java:
##
@@ -212,24 +214,23 @@ protected String getDivisionBlock(String text) {
 
 /** {@inheritDoc} */
 protected String getVerbatimSourceBlock(String text) {
-return EOL
-+ EOL
-+ MarkdownMarkup.VERBATIM_START_MARKUP
+return MarkdownMarkup.VERBATIM_START_MARKUP
 + EOL
 + text
 + EOL
 + MarkdownMarkup.VERBATIM_START_MARKUP
++ EOL
 + EOL;
 }
 
 /** {@inheritDoc} */
 protected String getHorizontalRuleBlock() {
-return EOL + MarkdownMarkup.HORIZONTAL_RULE_MARKUP + EOL;
+return MarkdownMarkup.HORIZONTAL_RULE_MARKUP + EOL + EOL;
 }
 
 /** {@inheritDoc} */
 protected String getPageBreakBlock() {
-return EOL + MarkdownMarkup.PAGE_BREAK_MARKUP + EOL;
+return "";

Review Comment:
   I agree with @elharo. Using a constant for this seems like overkill.



##
doxia-modules/doxia-module-markdown/src/test/java/org/apache/maven/doxia/module/markdown/MarkdownSinkTest.java:
##
@@ -144,21 +149,18 @@ protected String getFooterBlock() {
 
 /** {@inheritDoc} */
 protected String getListBlock(String item) {
-return EOL + EOL + Markup.SPACE + "" + 
MarkdownMarkup.LIST_UNORDERED_ITEM_START_MARKUP + "" + Markup.SPACE
-+ getEscapedText(item) + EOL + EOL;
+return MarkdownMarkup.LIST_UNORDERED_ITEM_START_MARKUP + "" + 
Markup.SPACE + getEscapedText(item) + EOL + EOL;
 }
 
 /** {@inheritDoc} */
 protected String getNumberedListBlock(String item) {
-return EOL + EOL + Markup.SPACE + ""
-+ MarkdownMarkup.LIST_ORDERED_ITEM_START_MARKUP + ""
-+ Markup.SPACE + getEscapedText(item) + EOL + EOL;
+return MarkdownMarkup.LIST_ORDERED_ITEM_START_MARKUP + "" + 
Markup.SPACE + getEscapedText(item) + EOL + EOL;
 }
 
 /** {@inheritDoc} */
 protected String getDefinitionListBlock(String definum, String definition) 
{
-return EOL + EOL + Markup.SPACE + "" + Markup.LEFT_SQUARE_BRACKET + 
definum + Markup.RIGHT_SQUARE_BRACKET + ""
-+ Markup.SPACE + definition + EOL + EOL;
+return "" + EOL + "" + getEscapedText(definum) + "" + EOL 
+ "" + getEscapedText(definition)

Review Comment:
   Done in 
https://github.com/apache/maven-doxia/pull/146/commits/c49775264627b41daa3b17e90f9d72a0b0d9c218.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-doxia] kwin commented on a diff in pull request #146: Bugfix/newlines

[via GitHub]

kwin commented on code in PR #146:
URL: https://github.com/apache/maven-doxia/pull/146#discussion_r1118085847


##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java:
##
@@ -92,10 +91,7 @@ public interface MarkdownMarkup extends TextMarkup {
 String VERBATIM_START_MARKUP = "```";
 
 /** Syntax for the non breaking space: "\ " */
-String NON_BREAKING_SPACE_MARKUP = String.valueOf(BACKSLASH) + SPACE;
-
-/** Syntax for the page break: "\f" */
-String PAGE_BREAK_MARKUP = String.valueOf(PAGE_BREAK);
+String NON_BREAKING_SPACE_MARKUP = "";

Review Comment:
   Fixed in 
https://github.com/apache/maven-doxia/pull/146/commits/c49775264627b41daa3b17e90f9d72a0b0d9c218.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-doxia] kwin commented on a diff in pull request #146: Bugfix/newlines

[via GitHub]

kwin commented on code in PR #146:
URL: https://github.com/apache/maven-doxia/pull/146#discussion_r1118085807


##
doxia-modules/doxia-module-markdown/src/test/java/org/apache/maven/doxia/module/markdown/MarkdownSinkTest.java:
##
@@ -349,11 +350,34 @@ public void testMultipleAuthors() {
 + "author: " + EOL
 + "  - first author" + EOL
 + "  - second author" + EOL
-+ MarkdownMarkup.METADATA_MARKUP + EOL;
++ MarkdownMarkup.METADATA_MARKUP + EOL + EOL;
 
 assertEquals(expected, getSinkContent(), "Wrong metadata section");
 }
 
+@Test
+public void testRoundtrip() throws IOException, ParseException {
+parseFile(parser, "test", getSink());
+
+final SinkEventTestingSink regeneratedSink = new 
SinkEventTestingSink();
+try (Reader reader = new StringReader(getSinkContent())) {
+parser.parse(reader, regeneratedSink);
+}
+
+System.out.println(getSinkContent());

Review Comment:
   Done in 
https://github.com/apache/maven-doxia/pull/146/commits/c49775264627b41daa3b17e90f9d72a0b0d9c218.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-doxia] kwin commented on a diff in pull request #146: Bugfix/newlines

[via GitHub]

kwin commented on code in PR #146:
URL: https://github.com/apache/maven-doxia/pull/146#discussion_r1118085653


##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/SinkEventElement.java:
##
@@ -80,4 +80,22 @@ public String toString() {
 builder.append(']');
 return builder.toString();
 }
+
+@Override
+public int hashCode() {

Review Comment:
   Those are test classes only! I don't think adding test for tester utilities 
is very useful. Tests will fail if those don't work!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] elharo opened a new pull request, #1015: Prefer Java standard library to Plexus util

[via GitHub]

elharo opened a new pull request, #1015:
URL: https://github.com/apache/maven/pull/1015

   Begin slog of removing plexus util dependencies we shouldn't have to 
maintain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MNG-7670) Upgrade misc dependencies

[Sylwester Lachiewicz (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MNG-7670:
--
Fix Version/s: 3.9.2
   (was: 3.9.1-candidate)

> Upgrade misc dependencies
> -
>
> Key: MNG-7670
> URL: https://issues.apache.org/jira/browse/MNG-7670
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.9.2
>
>
> [INFO] The following dependencies in Dependency Management have newer 
> versions:
> [INFO]   com.google.guava:guava .. 30.1-jre -> 
> 31.1-jre
> [INFO]   org.apache.commons:commons-lang3 . 3.8.1 -> 
> 3.12.0
> [INFO]   org.codehaus.plexus:plexus-classworlds  2.6.0 -> 
> 2.7.0
> [INFO]   org.codehaus.plexus:plexus-component-annotations .. 2.1.0 -> 
> 2.1.1
> [INFO]   org.codehaus.plexus:plexus-utils .. 3.4.2 -> 
> 3.5.0
> [INFO]   org.hamcrest:hamcrest-core  1.3 -> 
> 2.2
> [INFO]   org.hamcrest:hamcrest-library . 1.3 -> 
> 2.2
> [INFO]   org.mockito:mockito-core  2.21.0 -> 
> 4.11.0
> [INFO]   org.powermock:powermock-reflect ... 1.7.4 -> 
> 2.0.9
> [INFO]   org.xmlunit:xmlunit-core .. 2.2.1 -> 
> 2.9.1
> [INFO]   org.xmlunit:xmlunit-matchers .. 2.2.1 -> 
> 2.9.1
> Logback 1.3.x depends on SLF4J 2.x, Logback 1.4.x requires Java 11



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7700) Improper canonicalization of versions

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693640#comment-17693640
 ] 

ASF GitHub Bot commented on MNG-7700:
-

elharo commented on code in PR #1014:
URL: https://github.com/apache/maven/pull/1014#discussion_r1118082057


##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##
@@ -209,6 +208,26 @@ public void testVersionComparing() {
 checkVersionsOrder("2.0.1-xyz", "2.0.1-123");
 }
 
+@Test
+public void testLeadingZeroes() {
+checkVersionsOrder("0.7", "2");
+checkVersionsOrder("0.2", "1.0.7");
+}
+
+@Test
+public void testGetCanonical() {
+// MNG-7700
+newComparable("0.x");
+newComparable("0-x");
+newComparable("0.rc");
+newComparable("0-1");
+
+ComparableVersion version = new ComparableVersion("0.x");
+assertEquals("x", version.getCanonical());

Review Comment:
   I'm testing that the input produces the output. That is useful. There's a 
case to be made that the current behavior is wrong, which can be discussed on 
the bug. If we decide it is and change it, then having this test here will make 
it clear what changed when.
   
   The test you suggest is also good. However, it's (not so obviously) 
performed in line 220 by `newComparable("0.x")` which includes an assert to 
check that.





> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: 3.8.x-candidate, 3.9.1-candidate, waiting-for-feedback
>
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> |{{0.rc}}|{{0.rc}}|yes|{{rc}}|no|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] elharo commented on a diff in pull request #1014: [MNG-7700] test some edge cases with leading zeroes

[via GitHub]

elharo commented on code in PR #1014:
URL: https://github.com/apache/maven/pull/1014#discussion_r1118082057


##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##
@@ -209,6 +208,26 @@ public void testVersionComparing() {
 checkVersionsOrder("2.0.1-xyz", "2.0.1-123");
 }
 
+@Test
+public void testLeadingZeroes() {
+checkVersionsOrder("0.7", "2");
+checkVersionsOrder("0.2", "1.0.7");
+}
+
+@Test
+public void testGetCanonical() {
+// MNG-7700
+newComparable("0.x");
+newComparable("0-x");
+newComparable("0.rc");
+newComparable("0-1");
+
+ComparableVersion version = new ComparableVersion("0.x");
+assertEquals("x", version.getCanonical());

Review Comment:
   I'm testing that the input produces the output. That is useful. There's a 
case to be made that the current behavior is wrong, which can be discussed on 
the bug. If we decide it is and change it, then having this test here will make 
it clear what changed when.
   
   The test you suggest is also good. However, it's (not so obviously) 
performed in line 220 by `newComparable("0.x")` which includes an assert to 
check that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz commented on pull request #146: Bump spring-security-core from 2.0.4 to 5.5.7 in /src/it/projects/MJAVADOC-526_aggr-managedDeps/javadoc-child

[via GitHub]

slachiewicz commented on PR #146:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/146#issuecomment-1445352476

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693631#comment-17693631
 ] 

Michael Osipov commented on MRESOLVER-325:
--

Another Windows test:
{code:java}
import java.io.BufferedReader;
import java.io.IOException;
import java.io.Writer;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.nio.file.StandardCopyOption;

import com.sun.jna.platform.win32.Kernel32;
import com.sun.jna.platform.win32.WinBase;
import com.sun.jna.platform.win32.WinDef.DWORD;

public class AtomicMove {

public static void main(String[] args) throws IOException, 
InterruptedException {

Path target = Paths.get("mumu");

for (int i = 0; i < 100; i++) {
Path temp = Paths.get("mumu." + i);
try (Writer w = Files.newBufferedWriter(temp)) {
w.write(i + ": I was made for crashing your, 
baby!");
}
//Files.move(temp, target, 
StandardCopyOption.ATOMIC_MOVE);
Kernel32.INSTANCE.MoveFileEx( 
temp.toAbsolutePath().toString(), target.toAbsolutePath().toString(),
new DWORD( 
WinBase.MOVEFILE_REPLACE_EXISTING | WinBase.MOVEFILE_WRITE_THROUGH ) );
try (BufferedReader r = 
Files.newBufferedReader(target)) {
System.out.println(r.readLine());
}
}
}

}
{code}

Output:
{noformat}
0: I was made for crashing your, baby!
1: I was made for crashing your, baby!
2: I was made for crashing your, baby!
3: I was made for crashing your, baby!
4: I was made for crashing your, baby!
5: I was made for crashing your, baby!
6: I was made for crashing your, baby!
7: I was made for crashing your, baby!
8: I was made for crashing your, baby!
9: I was made for crashing your, baby!
10: I was made for crashing your, baby!
11: I was made for crashing your, baby!
12: I was made for crashing your, baby!
13: I was made for crashing your, baby!
14: I was made for crashing your, baby!
15: I was made for crashing your, baby!
16: I was made for crashing your, baby!
17: I was made for crashing your, baby!
18: I was made for crashing your, baby!
19: I was made for crashing your, baby!
20: I was made for crashing your, baby!
21: I was made for crashing your, baby!
22: I was made for crashing your, baby!
23: I was made for crashing your, baby!
24: I was made for crashing your, baby!
25: I was made for crashing your, baby!
26: I was made for crashing your, baby!
27: I was made for crashing your, baby!
28: I was made for crashing your, baby!
29: I was made for crashing your, baby!
30: I was made for crashing your, baby!
31: I was made for crashing your, baby!
32: I was made for crashing your, baby!
33: I was made for crashing your, baby!
34: I was made for crashing your, baby!
35: I was made for crashing your, baby!
36: I was made for crashing your, baby!
37: I was made for crashing your, baby!
38: I was made for crashing your, baby!
39: I was made for crashing your, baby!
40: I was made for crashing your, baby!
41: I was made for crashing your, baby!
42: I was made for crashing your, baby!
43: I was made for crashing your, baby!
44: I was made for crashing your, baby!
45: I was made for crashing your, baby!
46: I was made for crashing your, baby!
47: I was made for crashing your, baby!
48: I was made for crashing your, baby!
49: I was made for crashing your, baby!
50: I was made for crashing your, baby!
51: I was made for crashing your, baby!
52: I was made for crashing your, baby!
53: I was made for crashing your, baby!
54: I was made for crashing your, baby!
55: I was made for crashing your, baby!
56: I was made for crashing your, baby!
57: I was made for crashing your, baby!
58: I was made for crashing your, baby!
59: I was made for crashing your, baby!
60: I was made for crashing your, baby!
61: I was made for crashing your, baby!
62: I was made for crashing your, baby!
63: I was made for crashing your, baby!
64: I was made for crashing your, baby!
65: I was made for crashing your, baby!
66: I was made for crashing your, baby!
67: I was made for crashing your, baby!
68: I was made for crashing your, baby!
69: I was made for crashing your, baby!
70: I was made for crashing your, baby!
71: I was made for crashing your, baby!
72: I was made for crashing your, baby!
73: I was made for crashing your, baby!
74: I was made for crashing your, baby!
75: I was made for crashing your, baby!
75: I was made for crashing your, baby!
77: I was made for crashing your, baby!
78: I was made for crashing your, baby!
79: I was made for crashing your, baby!
80: I was made for crashing your, baby!
81: I was made for crashing your, baby!
82: I was made for crashing your, baby!
83: I was made for crashing 

[jira] [Commented] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693625#comment-17693625
 ] 

Michael Osipov commented on MRESOLVER-325:
--

[~laeubi], interesting:
{code:java}
import java.io.IOException;
import java.io.Writer;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.nio.file.StandardCopyOption;

public class AtomicMove {

public static void main(String[] args) throws IOException, 
InterruptedException {

Path target = Paths.get("mumu");

for (int i = 0; i < 100; i++) {
Path temp = Paths.get("mumu." + i);
try (Writer w = Files.newBufferedWriter(temp)) {
w.write("I was made for crashing your, baby!");
}
Files.move(temp, target, 
StandardCopyOption.ATOMIC_MOVE);
}
}

}
{code}
with
{noformat}
Exception in thread "main" java.nio.file.AccessDeniedException: mumu.41 -> mumu
at 
sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:83)
at 
sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:301)
at 
sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:287)
at java.nio.file.Files.move(Files.java:1395)
at com.siemens.sb.sso.example.AtomicMove.main(AtomicMove.java:21)
{noformat}

On
{noformat}
$ uname -a
FreeBSD deblndw011x.ad001.siemens.net 12.4-STABLE FreeBSD 12.4-STABLE 1279c260c 
GENERIC  amd64
{noformat}

[~cstamas], please try on Fedora, it won't be diferent.

What am I supposed to say for Windows?

> [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
> 
>
> Key: MRESOLVER-325
> URL: https://issues.apache.org/jira/browse/MRESOLVER-325
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Christoph Läubrich
>Priority: Major
> Fix For: 1.9.6
>
>
> If one runs a build that otherwise works fine on 3.8.x with 3.9 we now get 
> the following exception (full output can be found here 
> https://github.com/eclipse-platform/eclipse.platform/actions/runs/4211467991/jobs/7309831666):
> {code:java}
> Error: 5.889 [ERROR] Internal error: java.io.UncheckedIOException: 
> java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
>  -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException: 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
>  -> 
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update 
> (DefaultTrackingFileManager.java:121)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo 
> (EnhancedLocalRepositoryManager.java:274)
> at 
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact 
> (EnhancedLocalRepositoryManager.java:252)
> at 

[GitHub] [maven-javadoc-plugin] dependabot[bot] closed pull request #182: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0

[via GitHub]

dependabot[bot] closed pull request #182: Bump aetherVersion from 
1.0.0.v20140518 to 1.1.0
URL: https://github.com/apache/maven-javadoc-plugin/pull/182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #182: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0

[via GitHub]

dependabot[bot] commented on PR #182:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/182#issuecomment-1445338007

   OK, I won't notify you about version 1.x.x again, unless you re-open this 
PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz commented on pull request #182: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0

[via GitHub]

slachiewicz commented on PR #182:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/182#issuecomment-1445338002

   @dependabot ignore this major version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] slachiewicz commented on pull request #181: Bump jetty.version from 9.4.43.v20210629 to 11.0.13

[via GitHub]

slachiewicz commented on PR #181:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/181#issuecomment-1445337903

   @dependabot ignore this major version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #181: Bump jetty.version from 9.4.43.v20210629 to 11.0.13

[via GitHub]

dependabot[bot] commented on PR #181:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/181#issuecomment-1445337916

   OK, I won't notify you about version 11.x.x again, unless you re-open this 
PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-javadoc-plugin] dependabot[bot] closed pull request #181: Bump jetty.version from 9.4.43.v20210629 to 11.0.13

[via GitHub]

dependabot[bot] closed pull request #181: Bump jetty.version from 
9.4.43.v20210629 to 11.0.13
URL: https://github.com/apache/maven-javadoc-plugin/pull/181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org