[jira] [Commented] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696072#comment-17696072
]
ASF GitHub Bot commented on MNG-7717:
-
cstamas merged PR #1030:
URL: https://github.com/apache/maven/pull/1030
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-7717.
Resolution: Fixed
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-7717:
Assignee: Tamas Cservenak
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas merged pull request #1030: [MNG-7717] Maven warns wrongly about deprecated parameter
cstamas merged PR #1030: URL: https://github.com/apache/maven/pull/1030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696071#comment-17696071
]
ASF GitHub Bot commented on MNG-7717:
-
cstamas merged PR #1031:
URL: https://github.com/apache/maven/pull/1031
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas merged pull request #1031: [MNG-7717] Maven warns wrongly about deprecated parameter
cstamas merged PR #1031: URL: https://github.com/apache/maven/pull/1031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-7717:
-
Fix Version/s: 4.0.0
4.0.0-alpha-5
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696053#comment-17696053
]
ASF GitHub Bot commented on MNG-7717:
-
cstamas opened a new pull request, #1031:
URL: https://github.com/apache/maven/pull/1031
The implementation for MNG-7706 is wrong: it changes parameter NAME, where
it should check type and defaultValue instead.
---
https://issues.apache.org/jira/browse/MNG-7717
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas opened a new pull request, #1031: [MNG-7717] Maven warns wrongly about deprecated parameter
cstamas opened a new pull request, #1031: URL: https://github.com/apache/maven/pull/1031 The implementation for MNG-7706 is wrong: it changes parameter NAME, where it should check type and defaultValue instead. --- https://issues.apache.org/jira/browse/MNG-7717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHADE-352) shaded jars are not reproducible when using transformer
[ https://issues.apache.org/jira/browse/MSHADE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MSHADE-352: - Description: some shaded jars are not reproducible some files still use the current time iso the project.build.outputTimestamp time * META-INF/MANIFEST.MF * files in META-INF/services/ was: shaded jars are not reproducible some files still use the current time iso the project.build.outputTimestamp time * META-INF/MANIFEST.MF * files in META-INF/services/ > shaded jars are not reproducible when using transformer > --- > > Key: MSHADE-352 > URL: https://issues.apache.org/jira/browse/MSHADE-352 > Project: Maven Shade Plugin > Issue Type: Bug >Affects Versions: 3.2.2 >Reporter: Michael Brackx >Assignee: Herve Boutemy >Priority: Major > Fix For: 3.2.3 > > Attachments: pom.xml > > > some shaded jars are not reproducible > some files still use the current time iso the project.build.outputTimestamp > time > * META-INF/MANIFEST.MF > * files in META-INF/services/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MSHADE-420) Reproducible Builds timestamp issue in some cases
[
https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696035#comment-17696035
]
Herve Boutemy edited comment on MSHADE-420 at 3/3/23 7:09 AM:
--
for most of the entries, this plugin has shown to not suffer from timezone
issues: it is taken into account in MSHADE-347
but clearly there is an edge case in undefined conditions where "something
happens", I don't know what (linked to timezone or not, I don't know: last edge
case found was MSHADE-352)
happy to get help debugging...
was (Author: hboutemy):
for most of the entries, this plugin has shown to not suffer from timezone
issues: it is taken into account
but clearly there is an edge case in undefined conditions where "something
happens", I don't know what (linked to timezone or not, i don't know)
happy to get help debugging...
> Reproducible Builds timestamp issue in some cases
> -
>
> Key: MSHADE-420
> URL: https://issues.apache.org/jira/browse/MSHADE-420
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.2.4
>Reporter: Herve Boutemy
>Priority: Major
>
> seen in Tika
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/tika/tika-2.4.0.diffoscope
> maven-shade-plugin 3.2.4 has an issue with timestamps in unexplained
> circumstances:
> why does 21-Nov-20 20:25 from reference become 21-Nov-21 01:25 in rebuild?
> why does 20-May-14 07:15 from reference become 20-May-14 11:15 in rebuild?
> could be related to the timezone of the rebuilder?
> {noformat}
> 21 / 44 target/reference/tika-parser-nlp-package-2.4.0.jar
> tika-parsers/tika-parsers-ml/tika-parser-nlp-package/target/tika-parser-nlp-package-2.4.0.jar
> --- target/reference/tika-parser-nlp-package-2.4.0.jar
> +++
> tika-parsers/tika-parsers-ml/tika-parser-nlp-package/target/tika-parser-nlp-package-2.4.0.jar
> ├── zipinfo {}
> │ @@ -9868,1231 +9868,1231 @@
> │ -rw 2.0 fat 2653 bl defN 22-Apr-08 17:41
> schemas/wsdl/ws-addr-wsdl.xsd
> │ -rw 2.0 fat 5591 bl defN 22-Apr-08 17:41
> schemas/wsdl/ws-addr.xsd
> │ -rw 2.0 fat 1606 bl defN 22-Apr-08 17:41 schemas/wsdl/wsdl.xjb
> │ -rw 2.0 fat12126 bl defN 22-Apr-08 17:41 schemas/wsdl/wsdl.xsd
> │ -rw 2.0 fat 8198 bl defN 22-Apr-08 17:41 schemas/wsdl/wsrm.xsd
> │ -rw 2.0 fat 932 bl defN 22-Apr-08 17:41 schemas/wsdl/xmime.xsd
> │ -rw 2.0 fat 5840 bl defN 22-Apr-08 17:41 schemas/wsdl/xml.xsd
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/
> │ --rw 2.0 fat 70 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.properties
> │ --rw 2.0 fat15917 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.xml
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/wstx/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/wstx/api/
> ...
> │ --rw 2.0 fat 722 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidationSchema.class
> │ --rw 2.0 fat 7795 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidationSchemaFactory.class
> │ --rw 2.0 fat 1801 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidator.class
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/
> │ +-rw 2.0 fat 70 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.properties
> │ +-rw 2.0 fat15917 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.xml
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/wstx/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/wstx/api/
> ...
> │ +-rw 2.0 fat 722 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidationSchema.class
> │ +-rw 2.0 fat 7795 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidationSchemaFactory.class
> │ +-rw 2.0 fat 1801 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidator.class
> │ -rw 2.0 fat0 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/
> │ -rw 2.0 fat0 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/
> │
[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases
[
https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696035#comment-17696035
]
Herve Boutemy commented on MSHADE-420:
--
for most of the entries, this plugin has shown to not suffer from timezone
issues: it is taken into account
but clearly there is an edge case in undefined conditions where "something
happens", I don't know what (linked to timezone or not, i don't know)
happy to get help debugging...
> Reproducible Builds timestamp issue in some cases
> -
>
> Key: MSHADE-420
> URL: https://issues.apache.org/jira/browse/MSHADE-420
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.2.4
>Reporter: Herve Boutemy
>Priority: Major
>
> seen in Tika
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/tika/tika-2.4.0.diffoscope
> maven-shade-plugin 3.2.4 has an issue with timestamps in unexplained
> circumstances:
> why does 21-Nov-20 20:25 from reference become 21-Nov-21 01:25 in rebuild?
> why does 20-May-14 07:15 from reference become 20-May-14 11:15 in rebuild?
> could be related to the timezone of the rebuilder?
> {noformat}
> 21 / 44 target/reference/tika-parser-nlp-package-2.4.0.jar
> tika-parsers/tika-parsers-ml/tika-parser-nlp-package/target/tika-parser-nlp-package-2.4.0.jar
> --- target/reference/tika-parser-nlp-package-2.4.0.jar
> +++
> tika-parsers/tika-parsers-ml/tika-parser-nlp-package/target/tika-parser-nlp-package-2.4.0.jar
> ├── zipinfo {}
> │ @@ -9868,1231 +9868,1231 @@
> │ -rw 2.0 fat 2653 bl defN 22-Apr-08 17:41
> schemas/wsdl/ws-addr-wsdl.xsd
> │ -rw 2.0 fat 5591 bl defN 22-Apr-08 17:41
> schemas/wsdl/ws-addr.xsd
> │ -rw 2.0 fat 1606 bl defN 22-Apr-08 17:41 schemas/wsdl/wsdl.xjb
> │ -rw 2.0 fat12126 bl defN 22-Apr-08 17:41 schemas/wsdl/wsdl.xsd
> │ -rw 2.0 fat 8198 bl defN 22-Apr-08 17:41 schemas/wsdl/wsrm.xsd
> │ -rw 2.0 fat 932 bl defN 22-Apr-08 17:41 schemas/wsdl/xmime.xsd
> │ -rw 2.0 fat 5840 bl defN 22-Apr-08 17:41 schemas/wsdl/xml.xsd
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/
> │ --rw 2.0 fat 70 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.properties
> │ --rw 2.0 fat15917 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.xml
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/wstx/
> │ --rw 2.0 fat0 bl defN 21-Nov-20 20:25 com/ctc/wstx/api/
> ...
> │ --rw 2.0 fat 722 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidationSchema.class
> │ --rw 2.0 fat 7795 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidationSchemaFactory.class
> │ --rw 2.0 fat 1801 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidator.class
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/
> │ +-rw 2.0 fat 70 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.properties
> │ +-rw 2.0 fat15917 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.xml
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/wstx/
> │ +-rw 2.0 fat0 bl defN 21-Nov-21 01:25 com/ctc/wstx/api/
> ...
> │ +-rw 2.0 fat 722 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidationSchema.class
> │ +-rw 2.0 fat 7795 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidationSchemaFactory.class
> │ +-rw 2.0 fat 1801 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidator.class
> │ -rw 2.0 fat0 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/
> │ -rw 2.0 fat0 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/
> │ -rw 2.0 fat 146 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/pom.properties
> │ -rw 2.0 fat 6857 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/pom.xml
> │ -rw 2.0 fat0 bl defN 21-Sep-14 14:41 org/apache/ws/
> │ -rw 2.0 fat0 bl defN 21-Sep-14 14:41 org/apache/ws/commons/
> │ -rw
[jira] [Commented] (MASSEMBLY-975) Regression: 3.5.0 no longer uses default fileMode and directoryMode
[
https://issues.apache.org/jira/browse/MASSEMBLY-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696024#comment-17696024
]
Herve Boutemy commented on MASSEMBLY-975:
-
this issue start to be hijacked with topics going far beyond
maven-assembly-plugin: reproducible central seems to be a better place (or any
other if you find one: I tried reproducible-builds.org but my topics were too
Java oriented)
bq. Also: A tool is really needed for developers to verify their project
without the need to actually deploy it to maven central.
it already exists = one paragraph in the doc
https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-to-test-my-maven-build-reproducibility
I love every idea you write, because I went on similar route in past 3 years: I
have some answers for some, experienced some issues, found some solutions
sometimes like
https://maven.apache.org/plugins/maven-artifact-plugin/plugin-issues.html
we definitively need to have a live discussion :)
> Regression: 3.5.0 no longer uses default fileMode and directoryMode
> ---
>
> Key: MASSEMBLY-975
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-975
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Niels Basjes
>Priority: Critical
>
> If the fileMode and directoryMode have not been specified with the 3.5.0
> version then the umask of the system at hand will determine the permissions
> of the files in the jar generated by the assembly plugin.
> This is a bug because it has been documented that it should use the
> documented defaults in this case.
> If I change the version of the plugin from 3.5.0 to 3.4.2 then it works as
> expected.
> I made a simple reproduction project:
> https://github.com/nielsbasjes/BugreportMavenAssemblyUMask
> This builds the same trivial project (with 3 different umask settings) and
> assembles a jar with the default and explicitly set the same as the
> documented defaults.
> The base files are all the same (md5sum output)
> {code}
> ec364137a2c7678ef0c8f495652efe36 target-0002/assemblyumask-1.0-SNAPSHOT.jar
> ec364137a2c7678ef0c8f495652efe36 target-0022/assemblyumask-1.0-SNAPSHOT.jar
> ec364137a2c7678ef0c8f495652efe36 target-0055/assemblyumask-1.0-SNAPSHOT.jar
> {code}
> The maven-assembly-plugin created files WITH fileMode and directoryMode are
> all the same
> {code}
> ba12113ad2b95a4fc75d99aa5bfd4e4f
> target-0002/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> ba12113ad2b95a4fc75d99aa5bfd4e4f
> target-0022/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> ba12113ad2b95a4fc75d99aa5bfd4e4f
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> {code}
> The maven-assembly-plugin created files WITHOUT fileMode and directoryMode
> are all different
> {code}
> 316e5d6b2e85b7d829e938a5797370d7
> target-0022/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> 3375500189ef3087f8943d518209a5e6
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> c341cbbc9f21bb64b817b8bbdaae8608
> target-0002/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> {code}
> The permissions IN the files are the difference:
> {code}
> $ diffoscope target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> --- target-0055/assemblyumask-1.0-SNAPSHOT-udf-mode.jar
> +++ target-0055/assemblyumask-1.0-SNAPSHOT-udf-default.jar
> │┄ Archive contents identical but files differ, possibly due to different
> compression levels. Falling back to binary comparison.
> ├── zipinfo {}
> │ @@ -1,13 +1,13 @@
> │ Zip file size: 2152173 bytes, number of entries: 1515
> │ drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/
> │ -rw-r--r-- 2.0 unx 79 b- defN 03-Mar-03 03:03 META-INF/MANIFEST.MF
> │ -drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03 nl/
> │ -drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/
> │ -drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/bugreports/
> │ +drwx-w--w- 2.0 unx0 b- stor 03-Mar-03 03:03 nl/
> │ +drwx-w--w- 2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/
> │ +drwx-w--w- 2.0 unx0 b- stor 03-Mar-03 03:03 nl/basjes/bugreports/
> │ drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/org/
> │ drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03 META-INF/org/apache/
> │ drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03
> META-INF/org/apache/logging/
> │ drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03
> META-INF/org/apache/logging/log4j/
> │ drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03
> META-INF/org/apache/logging/log4j/core/
> │ drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03
> META-INF/org/apache/logging/log4j/core/config/
> │ drwxr-xr-x 2.0 unx0 b- stor 03-Mar-03 03:03
>
[GitHub] [maven-indexer] dependabot[bot] closed pull request #294: Bump version.spring from 5.3.23 to 6.0.5
dependabot[bot] closed pull request #294: Bump version.spring from 5.3.23 to 6.0.5 URL: https://github.com/apache/maven-indexer/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #294: Bump version.spring from 5.3.23 to 6.0.5
dependabot[bot] commented on PR #294: URL: https://github.com/apache/maven-indexer/pull/294#issuecomment-1452973016 Superseded by #298. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #298: Bump version.spring from 5.3.25 to 6.0.6
dependabot[bot] opened a new pull request, #298: URL: https://github.com/apache/maven-indexer/pull/298 Bumps `version.spring` from 5.3.25 to 6.0.6. Updates `spring-beans` from 5.3.25 to 6.0.6 Release notes Sourced from https://github.com/spring-projects/spring-framework/releases;>spring-beans's releases. v6.0.6 :star: New Features Prefer request hostName and hostPort in ReactorServerHttpRequest https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/30062;>#30062 Use readNBytes in ByteArrayHttpMessageConverter when contentLength is available https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/30010;>#30010 Add missing @Nullable annotations to LogMessage.format methods https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30006;>#30006 Refine CoroutinesUtils#invokeSuspendingFunction contract https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30005;>#30005 @SubscribeMapping method not called when built as native image https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30002;>#30002 Provide method with ContextView instead of Context in ServerWebExchangeContextFilter https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29691;>#29691 Support @Value for record injection https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/28774;>#28774 :lady_beetle: Bug Fixes WebClient now requires scheme https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30053;>#30053 Move HttpServiceProxyFactoryExtensions.kt to spring-web module https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30042;>#30042 AutowireCapableBeanFactory.createBean does not prefer default constructor anymore https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30041;>#30041 Server request URL with spring-webflux 6.0.5 is in resolved IP6 format https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30033;>#30033 PathMatchingResourcePatternResolver can no longer handle paths containing spaces and special characters https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30031;>#30031 Catch defensively exception thrown by validation contraints AOT processing of Kotlin extensions https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30037;>#30037 Fix proxy hint Kotlin extensions https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30025;>#30025 WebFlux fails with WebDAV HTTP methods https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29981;>#29981 NullPointerException if passing an anonymous class to ReflectionsHint#registerType https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29774;>#29774 Native hints for package private methods on custom @Repository class https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29764;>#29764 Native version of webflux/r2dbc failed https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29582;>#29582 Protect JMS connection creation against prepareConnection errors https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29116;>#29116 SingleConnectionFactory - reconnection problem (AMQ Broker) https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29115;>#29115 :notebook_with_decorative_cover: Documentation Fix Configuring a Global Date and Time Format example https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/30034;>#30034 @AspectJ argument name resolution algorithm is outdated in reference manual https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30026;>#30026 Update comment in Javadoc of ServletRequestPathFilter DispatcherServlet relating to DispatcherServlet https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/30014;>#30014 Revise AspectJ examples in the reference manual https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30003;>#30003 Revise chomp and fold settings in reference documentation https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30001;>#30001 :hammer: Dependency Upgrades Upgrade to Reactor 2022.0.4 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/30063;>#30063 :heart: Contributors Thank you to all the contributors who worked on this release: https://github.com/1004789224;>@1004789224, https://github.com/1993heqiang;>@1993heqiang, https://github.com/AlexElin;>@AlexElin, https://github.com/diguage;>@diguage, https://github.com/divcon;>@divcon, https://github.com/izeye;>@izeye,
[jira] [Comment Edited] (MNG-7697) Cannot parse POM that contains an emoji in a comment
[
https://issues.apache.org/jira/browse/MNG-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695967#comment-17695967
]
Larry West edited comment on MNG-7697 at 3/3/23 2:59 AM:
-
_Update: I missed Michael Osipov's "Confirmed" comment until after submitting._
_And now I see that
[plexus-utils-3.5.1|https://github.com/codehaus-plexus/plexus-utils/releases/tag/plexus-utils-3.5.1]
appears to have a fix (MNG-7710) — thanks [~gnodet]!_
Here's another example with {{f0 9f a4 94}} (U+1F914: "thinking face") in the
comment: [^pom.xml].
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
G
A
1
{code}
I can't find an XML tool that says this is *not* well-formed. Nor {{xmllint}}
on MacOS.
h3. Maven 3.9.0
As noted in the description, Maven 3.9.0 incorrectly complains about the UTF-8
character:
{noformat}
$ mvn390 -version
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
⋮
$ mvn390 dependency:tree
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /Users/lwest/test/MNG-7696/pom.xml: Illegal character
0xd83e found in comment (position: END_TAG seen ...\n
G
A
1
{code}
I can't find an XML tool that says this is *not* well-formed. Nor {{xmllint}}
on MacOS.
h3. Maven 3.9.0
As noted in the description, Maven 3.9.0 incorrectly complains about the UTF-8
character:
{noformat}
$ mvn390 -version
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
⋮
$ mvn390 dependency:tree
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /Users/lwest/test/MNG-7696/pom.xml: Illegal character
0xd83e found in comment (position: END_TAG seen ...\n
> Key: MNG-7697
> URL: https://issues.apache.org/jira/browse/MNG-7697
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.9.0
> Environment: MacOS 13.2.1
> OpenJDK Runtime Environment Temurin-17.0.4+8
>Reporter: Andrew Rosenberg
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: pom-1.xml, pom.xml
>
>
> {noformat}
> mvn -e clean install
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-parseable POM
> /Users/andrew.rosenberg/.m2/repository/com/verygood/security/base-pom-17/0.2.47/base-pom-17-0.2.47.pom:
> Illegal character 0xd83d found in comment (position: START_TAG seen
> ...\n
[jira] [Comment Edited] (MNG-7697) Cannot parse POM that contains an emoji in a comment
[
https://issues.apache.org/jira/browse/MNG-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695967#comment-17695967
]
Larry West edited comment on MNG-7697 at 3/3/23 2:53 AM:
-
_Update: I missed Michael Osipov's "Confirmed" comment until after submitting._
_And now I see that
[plexus-utils-3.5.1|https://github.com/codehaus-plexus/plexus-utils/releases/tag/plexus-utils-3.5.1]
appears to have a fix._
Here's another example with {{f0 9f a4 94}} (U+1F914: "thinking face") in the
comment: [^pom.xml].
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
G
A
1
{code}
I can't find an XML tool that says this is *not* well-formed. Nor {{xmllint}}
on MacOS.
h3. Maven 3.9.0
As noted in the description, Maven 3.9.0 incorrectly complains about the UTF-8
character:
{noformat}
$ mvn390 -version
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
⋮
$ mvn390 dependency:tree
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /Users/lwest/test/MNG-7696/pom.xml: Illegal character
0xd83e found in comment (position: END_TAG seen ...\n
G
A
1
{code}
I can't find an XML tool that says this is *not* well-formed. Nor {{xmllint}}
on MacOS.
h3. Maven 3.9.0
As noted in the description, Maven 3.9.0 incorrectly complains about the UTF-8
character:
{noformat}
$ mvn390 -version
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
⋮
$ mvn390 dependency:tree
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /Users/lwest/test/MNG-7696/pom.xml: Illegal character
0xd83e found in comment (position: END_TAG seen ...\n
> Key: MNG-7697
> URL: https://issues.apache.org/jira/browse/MNG-7697
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.9.0
> Environment: MacOS 13.2.1
> OpenJDK Runtime Environment Temurin-17.0.4+8
>Reporter: Andrew Rosenberg
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: pom-1.xml, pom.xml
>
>
> {noformat}
> mvn -e clean install
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-parseable POM
> /Users/andrew.rosenberg/.m2/repository/com/verygood/security/base-pom-17/0.2.47/base-pom-17-0.2.47.pom:
> Illegal character 0xd83d found in comment (position: START_TAG seen
> ...\n
[jira] [Comment Edited] (MNG-7697) Cannot parse POM that contains an emoji in a comment
[
https://issues.apache.org/jira/browse/MNG-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695967#comment-17695967
]
Larry West edited comment on MNG-7697 at 3/3/23 2:44 AM:
-
_Update: I missed Michael Osipov's "Confirmed" comment until after submitting._
Here's another example with {{f0 9f a4 94}} (U+1F914: "thinking face") in the
comment: [^pom.xml].
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
G
A
1
{code}
I can't find an XML tool that says this is *not* well-formed. Nor {{xmllint}}
on MacOS.
h3. Maven 3.9.0
As noted in the description, Maven 3.9.0 incorrectly complains about the UTF-8
character:
{noformat}
$ mvn390 -version
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
⋮
$ mvn390 dependency:tree
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /Users/lwest/test/MNG-7696/pom.xml: Illegal character
0xd83e found in comment (position: END_TAG seen ...\n
G
A
1
{code}
I can't find an XML tool that says this is *not* well-formed. Nor {{xmllint}}
on MacOS.
h3. Maven 3.9.0
As noted in the description, Maven 3.9.0 incorrectly complains about the UTF-8
character:
{noformat}
$ mvn390 -version
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
⋮
$ mvn390 dependency:tree
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /Users/lwest/test/MNG-7696/pom.xml: Illegal character
0xd83e found in comment (position: END_TAG seen ...\n
> Key: MNG-7697
> URL: https://issues.apache.org/jira/browse/MNG-7697
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.9.0
> Environment: MacOS 13.2.1
> OpenJDK Runtime Environment Temurin-17.0.4+8
>Reporter: Andrew Rosenberg
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: pom-1.xml, pom.xml
>
>
> {noformat}
> mvn -e clean install
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-parseable POM
> /Users/andrew.rosenberg/.m2/repository/com/verygood/security/base-pom-17/0.2.47/base-pom-17-0.2.47.pom:
> Illegal character 0xd83d found in comment (position: START_TAG seen
> ...\n
[jira] [Commented] (MNG-7697) Cannot parse POM that contains an emoji in a comment
[
https://issues.apache.org/jira/browse/MNG-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695967#comment-17695967
]
Larry West commented on MNG-7697:
-
Here's another example with {{f0 9f a4 94}} (U+1F914: "thinking face") in the
comment: [^pom.xml].
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
G
A
1
{code}
I can't find an XML tool that says this is *not* well-formed. Nor {{xmllint}}
on MacOS.
h3. Maven 3.9.0
As noted in the description, Maven 3.9.0 incorrectly complains about the UTF-8
character:
{noformat}
$ mvn390 -version
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
⋮
$ mvn390 dependency:tree
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /Users/lwest/test/MNG-7696/pom.xml: Illegal character
0xd83e found in comment (position: END_TAG seen ...\n
> Key: MNG-7697
> URL: https://issues.apache.org/jira/browse/MNG-7697
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.9.0
> Environment: MacOS 13.2.1
> OpenJDK Runtime Environment Temurin-17.0.4+8
>Reporter: Andrew Rosenberg
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: pom-1.xml, pom.xml
>
>
> {noformat}
> mvn -e clean install
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-parseable POM
> /Users/andrew.rosenberg/.m2/repository/com/verygood/security/base-pom-17/0.2.47/base-pom-17-0.2.47.pom:
> Illegal character 0xd83d found in comment (position: START_TAG seen
> ...\n
[jira] [Updated] (MNG-7697) Cannot parse POM that contains an emoji in a comment
[
https://issues.apache.org/jira/browse/MNG-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Larry West updated MNG-7697:
Attachment: pom-1.xml
> Cannot parse POM that contains an emoji in a comment
>
>
> Key: MNG-7697
> URL: https://issues.apache.org/jira/browse/MNG-7697
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.9.0
> Environment: MacOS 13.2.1
> OpenJDK Runtime Environment Temurin-17.0.4+8
>Reporter: Andrew Rosenberg
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: pom-1.xml, pom.xml
>
>
> {noformat}
> mvn -e clean install
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-parseable POM
> /Users/andrew.rosenberg/.m2/repository/com/verygood/security/base-pom-17/0.2.47/base-pom-17-0.2.47.pom:
> Illegal character 0xd83d found in comment (position: START_TAG seen
> ...\n
[GitHub] [maven-site] dependabot[bot] opened a new pull request, #388: Bump plantuml from 1.2023.1 to 1.2023.2
dependabot[bot] opened a new pull request, #388: URL: https://github.com/apache/maven-site/pull/388 Bumps plantuml from 1.2023.1 to 1.2023.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNGSITE-512) POM Reference: Repositories section confusing
Philippe Cloutier created MNGSITE-512: - Summary: POM Reference: Repositories section confusing Key: MNGSITE-512 URL: https://issues.apache.org/jira/browse/MNGSITE-512 Project: Maven Project Web Site Issue Type: Improvement Reporter: Philippe Cloutier [The Repositories section of the POM Reference page|https://maven.apache.org/pom.html#Repositories] is confusing. It covers one type of repositories (repositories of Maven artifacts), but not a much more common type of repositories (repositories of source code). It would be less confusing to either: * rename the section with a more specific title (such as "Artifact repositories") * or also cover source code repositories, if that is supported By the way, reviewing the section's current contents (e.g. discussing purpose before implementation) could also help. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] ppalaga merged pull request #797: Add property to disable model caching
ppalaga merged PR #797: URL: https://github.com/apache/maven-mvnd/pull/797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-7717:
-
Description:
With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
represented by {{ArtifactRepository}} legacy type. But the code is too eager,
it warns about {{settings.localRepository}} expression as well, while it does
NOT use this legacy type.
In short: it checks for parameter {*}name{*}, where instead it should check for
*type* and *defaultValue* expression.
was:With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it
is represented by {{ArtifactRepository}} legacy type. But the code is too
eager, it warns about {{settings.localRepository}} expression as well, while it
does NOT use this legacy type.
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7717) Maven warns about ${settings.localRepository} expression as deprecated
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695889#comment-17695889
]
ASF GitHub Bot commented on MNG-7717:
-
cstamas opened a new pull request, #1030:
URL: https://github.com/apache/maven/pull/1030
The implementation for MNG-7706 is wrong: it changes parameter NAME, where
it should check type and defaultValue instead.
---
https://issues.apache.org/jira/browse/MNG-7717
> Maven warns about ${settings.localRepository} expression as deprecated
> --
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-7717:
-
Summary: Maven warns wrongly about ${localRepository} expression (was:
Maven warns about ${settings.localRepository} expression as deprecated)
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas opened a new pull request, #1030: [MNG-7717] Maven warns wrongly about deprecated parameter
cstamas opened a new pull request, #1030: URL: https://github.com/apache/maven/pull/1030 The implementation for MNG-7706 is wrong: it changes parameter NAME, where it should check type and defaultValue instead. --- https://issues.apache.org/jira/browse/MNG-7717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] dependabot[bot] opened a new pull request, #132: Bump plexus-utils from 3.5.0 to 3.5.1
dependabot[bot] opened a new pull request, #132: URL: https://github.com/apache/maven-shared-utils/pull/132 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases;>plexus-utils's releases. 3.5.1 New features and improvements Reading and writing files using Java NIO (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/232;>#232) https://github.com/mkarg;>@mkarg Bug Fixes Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/241;>#241) https://github.com/gnodet;>@gnodet Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/240;>#240) https://github.com/gnodet;>@gnodet Dependency updates Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/237;>#237) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/231;>#231) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.1.0 to 3.2.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/227;>#227) https://github.com/dependabot;>@dependabot Bump jmh-generator-annprocess from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/222;>#222) https://github.com/dependabot;>@dependabot Bump jmh-core from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/223;>#223) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.0.2 to 3.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/220;>#220) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/8488ff2200964f47114b9dee5604dc3314a2fe8a;>8488ff2 [maven-release-plugin] prepare release plexus-utils-3.5.1 https://github.com/codehaus-plexus/plexus-utils/commit/bf198ff5d8f3bd5eb90d09826006c4d419884660;>bf198ff Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/241;>#241) https://github.com/codehaus-plexus/plexus-utils/commit/32b72a6e8ff51e7b53510ecfc47ca46eaa4695ba;>32b72a6 Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/240;>#240) https://github.com/codehaus-plexus/plexus-utils/commit/d3d137cdf51aff2fc854eb60c300a9953c0e093d;>d3d137c Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 https://github.com/codehaus-plexus/plexus-utils/commit/4f333f2691873e5ba024991a03390a4e773511e9;>4f333f2 Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/231;>#231) https://github.com/codehaus-plexus/plexus-utils/commit/9db3ea7f918d3c5612703c6f95f1c2a87337ab05;>9db3ea7 Using Files#write() to implement Files#append() https://github.com/codehaus-plexus/plexus-utils/commit/6aa1b6fa11f16340757842939ff27a79c937a87f;>6aa1b6f Using Files#readString()/#writeString() on Java 11+ https://github.com/codehaus-plexus/plexus-utils/commit/c41544820537cc0ab39791f65baa1cb518a33879;>c415448 Using Files.write instead of OutputStream.write https://github.com/codehaus-plexus/plexus-utils/commit/b8696fb4b0ee29d866c5e09c08b6617dbc1fbfc2;>b8696fb Using Files.readAllBytes instead of custom loop https://github.com/codehaus-plexus/plexus-utils/commit/6288353e08b999ff16b7cf8ab09625f4e17b1b98;>6288353 Bump actions/checkout from 3.1.0 to 3.2.0 Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.5.0...plexus-utils-3.5.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will
[jira] [Commented] (MNG-7717) Maven warns about ${settings.localRepository} expression as deprecated
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695887#comment-17695887
]
Tamas Cservenak commented on MNG-7717:
--
Nope, MNG-7706 was not backported to 3.8.8 as it is not a regression.
> Maven warns about ${settings.localRepository} expression as deprecated
> --
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7717) Maven warns about ${settings.localRepository} expression as deprecated
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695877#comment-17695877
]
Michael Osipov commented on MNG-7717:
-
Maybe in 3.8.8 as well?
> Maven warns about ${settings.localRepository} expression as deprecated
> --
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7717) Maven warns about ${settings.localRepository} expression as deprecated
Tamas Cservenak created MNG-7717:
Summary: Maven warns about ${settings.localRepository} expression
as deprecated
Key: MNG-7717
URL: https://issues.apache.org/jira/browse/MNG-7717
Project: Maven
Issue Type: Bug
Components: Core
Reporter: Tamas Cservenak
Fix For: 3.9.1
With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
represented by {{ArtifactRepository}} legacy type. But the code is too eager,
it warns about {{settings.localRepository}} expression as well, while it does
NOT use this legacy type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #250: Add integrationtest for MNG-7716
michael-o commented on code in PR #250:
URL:
https://github.com/apache/maven-integration-testing/pull/250#discussion_r1123573840
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7716BuildDeadlock.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for
+ * https://issues.apache.org/jira/browse/MNG-7716;>MNG-7716.
+ * Executing the project should not deadlock
+ *
+ */
+class MavenITmng7716BuildDeadlock
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7716BuildDeadlock()
+{
+super( "[3.8.8,)[3.9.1,)[4.0.0-alpha-5,)" );
Review Comment:
But `[3.8.8,)` will match 3.9.0 as well which is not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] laeubi commented on a diff in pull request #250: Add integrationtest for MNG-7716
laeubi commented on code in PR #250:
URL:
https://github.com/apache/maven-integration-testing/pull/250#discussion_r1123570218
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7716BuildDeadlock.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for
+ * https://issues.apache.org/jira/browse/MNG-7716;>MNG-7716.
+ * Executing the project should not deadlock
+ *
+ */
+class MavenITmng7716BuildDeadlock
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7716BuildDeadlock()
+{
+super( "[3.8.8,)[3.9.1,)[4.0.0-alpha-5,)" );
Review Comment:
3.9.1 is the first included version...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #250: Add integrationtest for MNG-7716
michael-o commented on code in PR #250:
URL:
https://github.com/apache/maven-integration-testing/pull/250#discussion_r1123559258
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7716BuildDeadlock.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for
+ * https://issues.apache.org/jira/browse/MNG-7716;>MNG-7716.
+ * Executing the project should not deadlock
+ *
+ */
+class MavenITmng7716BuildDeadlock
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7716BuildDeadlock()
+{
+super( "[3.8.8,)[3.9.1,)[4.0.0-alpha-5,)" );
Review Comment:
I don't this that this is correct because this test does not apply to 3.9.0:
https://github.com/apache/maven-integration-testing/commit/5dd08b8931e3ceecc6fb2621c4d8214683b12920#diff-f7e71461bbf4f4479ee33d4aab9581ade83aa096bd93907acba4d337e3b760d6R40
@cstamas WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #250: Add integrationtest for MNG-7716
michael-o commented on code in PR #250:
URL:
https://github.com/apache/maven-integration-testing/pull/250#discussion_r1123557709
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7716BuildDeadlock.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for
+ * https://issues.apache.org/jira/browse/MNG-7716;>MNG-7716.
+ * Executing the project should not deadlock
+ *
+ */
+class MavenITmng7716BuildDeadlock
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7716BuildDeadlock()
+{
+super( "[3.8.0,)" );
+}
+
+/**
+ * Verify that maven invocation works (no NPE/error happens).
+ *
+ * @throws Exception in case of failure
+ */
+@Test
+void testSingleMojoNoPom()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(),
"/mng-7716" );
+
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+verifier.addCliArgument( "install" );
+verifier.addCliArgument( "-f" );
+verifier.addCliArgument( "settings" );
+verifier.execute();
+verifier.verifyErrorFreeLog();
+Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+verifier2.addCliArgument( "-T1C" );
+verifier2.addCliArgument( "versions:set" );
Review Comment:
Add it to the POM and here:
https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/resources-filtered/bootstrap.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] laeubi commented on a diff in pull request #250: Add integrationtest for MNG-7716
laeubi commented on code in PR #250:
URL:
https://github.com/apache/maven-integration-testing/pull/250#discussion_r1123548335
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7716BuildDeadlock.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for
+ * https://issues.apache.org/jira/browse/MNG-7716;>MNG-7716.
+ * Executing the project should not deadlock
+ *
+ */
+class MavenITmng7716BuildDeadlock
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7716BuildDeadlock()
+{
+super( "[3.8.0,)" );
Review Comment:
done
##
core-it-suite/src/test/resources/mng-7716/pom.xml:
##
@@ -0,0 +1,19 @@
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+ mng
+ base
+ 1.2.3
+ pom
+
+
+
+
+ settings
+
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] laeubi commented on a diff in pull request #250: Add integrationtest for MNG-7716
laeubi commented on code in PR #250:
URL:
https://github.com/apache/maven-integration-testing/pull/250#discussion_r1123543866
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7716BuildDeadlock.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for
+ * https://issues.apache.org/jira/browse/MNG-7716;>MNG-7716.
+ * Executing the project should not deadlock
+ *
+ */
+class MavenITmng7716BuildDeadlock
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7716BuildDeadlock()
+{
+super( "[3.8.0,)" );
+}
+
+/**
+ * Verify that maven invocation works (no NPE/error happens).
+ *
+ * @throws Exception in case of failure
+ */
+@Test
+void testSingleMojoNoPom()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(),
"/mng-7716" );
+
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+verifier.addCliArgument( "install" );
+verifier.addCliArgument( "-f" );
+verifier.addCliArgument( "settings" );
+verifier.execute();
+verifier.verifyErrorFreeLog();
+Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+verifier2.addCliArgument( "-T1C" );
+verifier2.addCliArgument( "versions:set" );
Review Comment:
How do I do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #250: Add integrationtest for MNG-7716
michael-o commented on code in PR #250:
URL:
https://github.com/apache/maven-integration-testing/pull/250#discussion_r1123542626
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7716BuildDeadlock.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for
+ * https://issues.apache.org/jira/browse/MNG-7716;>MNG-7716.
+ * Executing the project should not deadlock
+ *
+ */
+class MavenITmng7716BuildDeadlock
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7716BuildDeadlock()
+{
+super( "[3.8.0,)" );
+}
+
+/**
+ * Verify that maven invocation works (no NPE/error happens).
+ *
+ * @throws Exception in case of failure
+ */
+@Test
+void testSingleMojoNoPom()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(),
"/mng-7716" );
+
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+verifier.addCliArgument( "install" );
+verifier.addCliArgument( "-f" );
+verifier.addCliArgument( "settings" );
+verifier.execute();
+verifier.verifyErrorFreeLog();
+Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+verifier2.addCliArgument( "-T1C" );
+verifier2.addCliArgument( "versions:set" );
Review Comment:
Versions Maven Plugin must be declared and int boostrap to be availabe
offline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #250: Add integrationtest for MNG-7716
michael-o commented on code in PR #250:
URL:
https://github.com/apache/maven-integration-testing/pull/250#discussion_r1123540370
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7716BuildDeadlock.java:
##
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for
+ * https://issues.apache.org/jira/browse/MNG-7716;>MNG-7716.
+ * Executing the project should not deadlock
+ *
+ */
+class MavenITmng7716BuildDeadlock
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7716BuildDeadlock()
+{
+super( "[3.8.0,)" );
Review Comment:
This looks wrong, no? should be 3.8.8+, 3.9.1+, 4.0.0-alpha-5+
@cstamas Added an IT recently which contains the exact value you need
##
core-it-suite/src/test/resources/mng-7716/pom.xml:
##
@@ -0,0 +1,19 @@
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+ mng
+ base
+ 1.2.3
+ pom
+
+
+
+
+ settings
+
+
Review Comment:
XML with two space-indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MRESOLVER-335) Better resolver errors for Artifact Not Found
[
https://issues.apache.org/jira/browse/MRESOLVER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MRESOLVER-335:
--
Component/s: Resolver
> Better resolver errors for Artifact Not Found
> -
>
> Key: MRESOLVER-335
> URL: https://issues.apache.org/jira/browse/MRESOLVER-335
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: 1.10.0
>
>
> When we have many remote repositories only first
> {{ArtifactNotFoundException}} is returned, all checks for other repositories
> are hidden.
> When we have errors for many artifacts in one request - list of problematic
> artifacts is present in message and only first exception for one artifact.
> Next case is with remote repository filtering, checks for remote repository
> according to filtering also produce {{ArtifactNotFoundException}}, this is
> done at the beginning so exception is first on list.
> In logs and exception we have:
> {code}
> Downloading from my-mirror:
> https://artifactory.../artifactory/remote-repos/org/apache/commons/commons-lang3/4.4.4/commons-lang3-4.4.4.pom
> [WARNING] The POM for org.apache.commons:commons-lang3:jar:4.4.4 is missing,
> no dependency information available
> Downloading from my-mirror:
> https://artifactory.../artifactory/remote-repos/org/apache/commons/commons-lang3/4.4.4/commons-lang3-4.4.4.jar
> [ERROR] Failed to execute goal on project maven-3.9: Could not resolve
> dependencies for project org.test:maven-3.9:jar:1.0.0-SNAPSHOT: Prefix org
> NOT allowed from mayrepo (https://artifactory.../artifactory/myrepo/,
> default, releases+snapshots)
> {code}
> As we see artefact was not found in {{my-mirror}}, but in error report we
> have information about not allowed prefixes - it can be confusing
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] ppalaga commented on a diff in pull request #797: Add property to disable model caching
ppalaga commented on code in PR #797:
URL: https://github.com/apache/maven-mvnd/pull/797#discussion_r1123526900
##
common/src/main/java/org/mvndaemon/mvnd/common/Environment.java:
##
@@ -163,6 +163,12 @@ public enum Environment {
* non-native clients and is useful mostly for debugging.
*/
MVND_NO_DAEMON("mvnd.noDaemon", "MVND_NO_DAEMON", Boolean.FALSE,
OptionType.BOOLEAN, Flags.DISCRIMINATING),
+
+/**
+ * If true, the daemon will not use its in-memory metadata
cache and instead re-read the
+ * metadata from the pom.xml files in the local repository. This is mostly
useful for testing purposes.
+ */
+MVND_NO_MODEL_CACHE("mvnd.noModelCache", null, Boolean.FALSE,
OptionType.BOOLEAN, Flags.NONE),
Review Comment:
Looking at the CI failures, we may need `Flags.OPTIONAL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on a diff in pull request #797: Add property to disable model caching
ppalaga commented on code in PR #797:
URL: https://github.com/apache/maven-mvnd/pull/797#discussion_r1123521781
##
common/src/main/java/org/mvndaemon/mvnd/common/Environment.java:
##
@@ -163,6 +163,12 @@ public enum Environment {
* non-native clients and is useful mostly for debugging.
*/
MVND_NO_DAEMON("mvnd.noDaemon", "MVND_NO_DAEMON", Boolean.FALSE,
OptionType.BOOLEAN, Flags.DISCRIMINATING),
+
+/**
+ * If true, the daemon will not use its in-memory metadata
cache and instead re-read the
+ * metadata from the pom.xml files in the local repository. This is mostly
useful for testing purposes.
+ */
+MVND_NO_MODEL_CACHE("mvnd.noModelCache", null, Boolean.FALSE,
OptionType.BOOLEAN, Flags.NONE),
Review Comment:
If it is called every build, then no need to change anything. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-filtering] dependabot[bot] closed pull request #53: Bump plexus-utils from 3.4.2 to 3.5.0
dependabot[bot] closed pull request #53: Bump plexus-utils from 3.4.2 to 3.5.0 URL: https://github.com/apache/maven-filtering/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] dependabot[bot] commented on pull request #53: Bump plexus-utils from 3.4.2 to 3.5.0
dependabot[bot] commented on PR #53: URL: https://github.com/apache/maven-filtering/pull/53#issuecomment-145229 Superseded by #69. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] dependabot[bot] opened a new pull request, #69: Bump plexus-utils from 3.4.2 to 3.5.1
dependabot[bot] opened a new pull request, #69: URL: https://github.com/apache/maven-filtering/pull/69 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases;>plexus-utils's releases. 3.5.1 New features and improvements Reading and writing files using Java NIO (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/232;>#232) https://github.com/mkarg;>@mkarg Bug Fixes Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/241;>#241) https://github.com/gnodet;>@gnodet Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/240;>#240) https://github.com/gnodet;>@gnodet Dependency updates Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/237;>#237) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/231;>#231) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.1.0 to 3.2.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/227;>#227) https://github.com/dependabot;>@dependabot Bump jmh-generator-annprocess from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/222;>#222) https://github.com/dependabot;>@dependabot Bump jmh-core from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/223;>#223) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.0.2 to 3.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/220;>#220) https://github.com/dependabot;>@dependabot 3.5.0 Don't throw IOException when none is required (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/206;>#206) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/221;>#221) https://github.com/michael-o;>@michael-o Always preserve dominant node value (even if empty) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/217;>#217) https://github.com/kwin;>@kwin Don't overwrite blank (but non-empty) dominant values during mergeXpp3Dom (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/213;>#213) https://github.com/kwin;>@kwin Deprecate isEmpty(String) and isNotEmpty(String) in favour of same named (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/218;>#218) https://github.com/kwin;>@kwin isEmpty(String) must not return false for whitespace-only values (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/219;>#219) https://github.com/kwin;>@kwin Get rid maven-plugin-testing-harness from dependency (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/208;>#208) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates Bump plexus from 8 to 10 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/207;>#207) https://github.com/dependabot;>@dependabot Bump release-drafter/release-drafter from 5.19.0 to 5.20.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/205;>#205) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/8488ff2200964f47114b9dee5604dc3314a2fe8a;>8488ff2 [maven-release-plugin] prepare release plexus-utils-3.5.1 https://github.com/codehaus-plexus/plexus-utils/commit/bf198ff5d8f3bd5eb90d09826006c4d419884660;>bf198ff Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/241;>#241) https://github.com/codehaus-plexus/plexus-utils/commit/32b72a6e8ff51e7b53510ecfc47ca46eaa4695ba;>32b72a6 Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/240;>#240) https://github.com/codehaus-plexus/plexus-utils/commit/d3d137cdf51aff2fc854eb60c300a9953c0e093d;>d3d137c Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 https://github.com/codehaus-plexus/plexus-utils/commit/4f333f2691873e5ba024991a03390a4e773511e9;>4f333f2 Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/231;>#231)
[jira] [Created] (MRESOLVER-338) Drop FileTransform API
Tamas Cservenak created MRESOLVER-338: - Summary: Drop FileTransform API Key: MRESOLVER-338 URL: https://issues.apache.org/jira/browse/MRESOLVER-338 Project: Maven Resolver Issue Type: Dependency upgrade Components: Resolver Reporter: Tamas Cservenak Fix For: 1.10.0 As this will streamline things from impl through connector and transport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] oehme commented on a diff in pull request #797: Add property to disable model caching
oehme commented on code in PR #797:
URL: https://github.com/apache/maven-mvnd/pull/797#discussion_r1123498117
##
common/src/main/java/org/mvndaemon/mvnd/common/Environment.java:
##
@@ -163,6 +163,12 @@ public enum Environment {
* non-native clients and is useful mostly for debugging.
*/
MVND_NO_DAEMON("mvnd.noDaemon", "MVND_NO_DAEMON", Boolean.FALSE,
OptionType.BOOLEAN, Flags.DISCRIMINATING),
+
+/**
+ * If true, the daemon will not use its in-memory metadata
cache and instead re-read the
+ * metadata from the pom.xml files in the local repository. This is mostly
useful for testing purposes.
+ */
+MVND_NO_MODEL_CACHE("mvnd.noModelCache", null, Boolean.FALSE,
OptionType.BOOLEAN, Flags.NONE),
Review Comment:
The `createCache` method is called every build, so it doesn't have to be
discriminating. It doesn't hurt either, I don't mind :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7716) ConcurrencyDependencyGraph deadlock if no root can be selected
[
https://issues.apache.org/jira/browse/MNG-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695813#comment-17695813
]
Michael Osipov commented on MNG-7716:
-
Any change to have an IT here?
> ConcurrencyDependencyGraph deadlock if no root can be selected
> --
>
> Key: MNG-7716
> URL: https://issues.apache.org/jira/browse/MNG-7716
> Project: Maven
> Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Major
>
> At Tycho we got a bug-report that results in a deadlock when calling the
> tycho-version-plugin:
> https://github.com/eclipse-tycho/tycho/issues/2169
> I debugged the problem and it seems that ConcurrencyDependencyGraph is
> actually the culprit here because it can return an empty list of projects to
> initially build. As no builds are scheduled then the code in the
> MultiThreadedBuilder waits forever for the result, this is what happening
> here:
> * There is one segment {code}org.faktorips:base:pom:23.6.0-SNAPSHOT ->
> [org.eclipse.tycho:tycho-versions-plugin:3.0.4-SNAPSHOT:set-version]{code}
> * This segment has a transitive reactor dependency to {code}MavenProject:
> org.faktorips:codequality-config:23.6.0-SNAPSHOT @
> faktorips.base/codequality-config/pom.xml{code} (this is not a problem
> because we only execute a reactor=true mojo!)
> * So now the loop finds that there is no "independent" project and returns an
> empty list
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7716) ConcurrencyDependencyGraph deadlock if no root can be selected
[
https://issues.apache.org/jira/browse/MNG-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695806#comment-17695806
]
ASF GitHub Bot commented on MNG-7716:
-
laeubi commented on PR #1029:
URL: https://github.com/apache/maven/pull/1029#issuecomment-1452138653
Backport 3.9.x:
-https://github.com/apache/maven/pull/1028
Backport 3.8.x:
- https://github.com/apache/maven/pull/1027
> ConcurrencyDependencyGraph deadlock if no root can be selected
> --
>
> Key: MNG-7716
> URL: https://issues.apache.org/jira/browse/MNG-7716
> Project: Maven
> Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Major
>
> At Tycho we got a bug-report that results in a deadlock when calling the
> tycho-version-plugin:
> https://github.com/eclipse-tycho/tycho/issues/2169
> I debugged the problem and it seems that ConcurrencyDependencyGraph is
> actually the culprit here because it can return an empty list of projects to
> initially build. As no builds are scheduled then the code in the
> MultiThreadedBuilder waits forever for the result, this is what happening
> here:
> * There is one segment {code}org.faktorips:base:pom:23.6.0-SNAPSHOT ->
> [org.eclipse.tycho:tycho-versions-plugin:3.0.4-SNAPSHOT:set-version]{code}
> * This segment has a transitive reactor dependency to {code}MavenProject:
> org.faktorips:codequality-config:23.6.0-SNAPSHOT @
> faktorips.base/codequality-config/pom.xml{code} (this is not a problem
> because we only execute a reactor=true mojo!)
> * So now the loop finds that there is no "independent" project and returns an
> empty list
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] laeubi commented on pull request #1029: [MNG-7716] ConcurrencyDependencyGraph deadlock if no root is selected
laeubi commented on PR #1029: URL: https://github.com/apache/maven/pull/1029#issuecomment-1452138653 Backport 3.9.x: -https://github.com/apache/maven/pull/1028 Backport 3.8.x: - https://github.com/apache/maven/pull/1027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7716) ConcurrencyDependencyGraph deadlock if no root can be selected
[
https://issues.apache.org/jira/browse/MNG-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695804#comment-17695804
]
ASF GitHub Bot commented on MNG-7716:
-
laeubi opened a new pull request, #1029:
URL: https://github.com/apache/maven/pull/1029
If ConcurrencyDependencyGraph#getRootSchedulableBuilds returns an empty list
then MultiThreadedBuilder is locked forever as it never gets a build result
(because nothing is scheduled).
This changes the method, that in such case just the first project is
returned, this might not give the best performance, but ensures that there is
at least one build scheduled and the build-loop can proceed.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> ConcurrencyDependencyGraph deadlock if no root can be selected
> --
>
> Key: MNG-7716
> URL: https://issues.apache.org/jira/browse/MNG-7716
> Project: Maven
> Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Major
>
> At Tycho we got a bug-report that results in a deadlock when calling the
> tycho-version-plugin:
> https://github.com/eclipse-tycho/tycho/issues/2169
> I debugged the problem and it seems that ConcurrencyDependencyGraph is
> actually the culprit here because it can return an empty list of projects to
> initially build. As no builds are scheduled then the code in the
> MultiThreadedBuilder waits forever for the result, this is what happening
> here:
> * There is one segment {code}org.faktorips:base:pom:23.6.0-SNAPSHOT ->
> [org.eclipse.tycho:tycho-versions-plugin:3.0.4-SNAPSHOT:set-version]{code}
> * This segment has a transitive reactor dependency to {code}MavenProject:
> org.faktorips:codequality-config:23.6.0-SNAPSHOT @
> faktorips.base/codequality-config/pom.xml{code} (this is not a problem
> because we only execute a reactor=true mojo!)
> * So now the loop finds that there is no "independent" project and returns an
> empty list
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] laeubi opened a new pull request, #1029: [MNG-7716] ConcurrencyDependencyGraph deadlock if no root is selected
laeubi opened a new pull request, #1029: URL: https://github.com/apache/maven/pull/1029 If ConcurrencyDependencyGraph#getRootSchedulableBuilds returns an empty list then MultiThreadedBuilder is locked forever as it never gets a build result (because nothing is scheduled). This changes the method, that in such case just the first project is returned, this might not give the best performance, but ensures that there is at least one build scheduled and the build-loop can proceed. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695800#comment-17695800
]
Elliotte Rusty Harold commented on MNG-6825:
Feel free to throw any reviews my way. I do prefer smaller reviews. They tend
not to be drop in replacements since null checking particular can vary from one
line of code to the next. E.g. sometimes a StringUtils.isEmpty replacement
needs to include a null check and sometime it doesn't if the string has already
been dereferenced previously. We don't really have tooling to perform a lot of
these modifications at scale, so if you do what you can when you can,
eventually we'll get it done.
https://google.github.io/eng-practices/review/developer/small-cls.html
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #252: Bump plexus-utils from 3.5.0 to 3.5.1
dependabot[bot] opened a new pull request, #252: URL: https://github.com/apache/maven-enforcer/pull/252 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases;>plexus-utils's releases. 3.5.1 New features and improvements Reading and writing files using Java NIO (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/232;>#232) https://github.com/mkarg;>@mkarg Bug Fixes Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/241;>#241) https://github.com/gnodet;>@gnodet Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/240;>#240) https://github.com/gnodet;>@gnodet Dependency updates Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/237;>#237) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/231;>#231) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.1.0 to 3.2.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/227;>#227) https://github.com/dependabot;>@dependabot Bump jmh-generator-annprocess from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/222;>#222) https://github.com/dependabot;>@dependabot Bump jmh-core from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/223;>#223) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.0.2 to 3.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/220;>#220) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/8488ff2200964f47114b9dee5604dc3314a2fe8a;>8488ff2 [maven-release-plugin] prepare release plexus-utils-3.5.1 https://github.com/codehaus-plexus/plexus-utils/commit/bf198ff5d8f3bd5eb90d09826006c4d419884660;>bf198ff Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/241;>#241) https://github.com/codehaus-plexus/plexus-utils/commit/32b72a6e8ff51e7b53510ecfc47ca46eaa4695ba;>32b72a6 Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/240;>#240) https://github.com/codehaus-plexus/plexus-utils/commit/d3d137cdf51aff2fc854eb60c300a9953c0e093d;>d3d137c Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 https://github.com/codehaus-plexus/plexus-utils/commit/4f333f2691873e5ba024991a03390a4e773511e9;>4f333f2 Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/231;>#231) https://github.com/codehaus-plexus/plexus-utils/commit/9db3ea7f918d3c5612703c6f95f1c2a87337ab05;>9db3ea7 Using Files#write() to implement Files#append() https://github.com/codehaus-plexus/plexus-utils/commit/6aa1b6fa11f16340757842939ff27a79c937a87f;>6aa1b6f Using Files#readString()/#writeString() on Java 11+ https://github.com/codehaus-plexus/plexus-utils/commit/c41544820537cc0ab39791f65baa1cb518a33879;>c415448 Using Files.write instead of OutputStream.write https://github.com/codehaus-plexus/plexus-utils/commit/b8696fb4b0ee29d866c5e09c08b6617dbc1fbfc2;>b8696fb Using Files.readAllBytes instead of custom loop https://github.com/codehaus-plexus/plexus-utils/commit/6288353e08b999ff16b7cf8ab09625f4e17b1b98;>6288353 Bump actions/checkout from 3.1.0 to 3.2.0 Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.5.0...plexus-utils-3.5.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will
[jira] [Comment Edited] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695791#comment-17695791
]
Michael Osipov edited comment on MNG-6825 at 3/2/23 3:50 PM:
-
[~timtebeek], I'd say core, then plugins, later the rest.
was (Author: michael-o):
[~timtebeek], I'd say core, then plugins.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695791#comment-17695791
]
Michael Osipov commented on MNG-6825:
-
[~timtebeek], I'd say core, then plugins.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7716) ConcurrencyDependencyGraph deadlock if no root can be selected
[
https://issues.apache.org/jira/browse/MNG-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695765#comment-17695765
]
ASF GitHub Bot commented on MNG-7716:
-
laeubi opened a new pull request, #1028:
URL: https://github.com/apache/maven/pull/1028
If ConcurrencyDependencyGraph#getRootSchedulableBuilds returns an empty list
then MultiThreadedBuilder is locked forever as it never gets a build result
(because nothing is scheduled).
This changes the method, that in such case just the first project is
returned, this might not give the best performance, but ensures that there is
at least one build scheduled and the build-loop can proceed.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> ConcurrencyDependencyGraph deadlock if no root can be selected
> --
>
> Key: MNG-7716
> URL: https://issues.apache.org/jira/browse/MNG-7716
> Project: Maven
> Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Major
>
> At Tycho we got a bug-report that results in a deadlock when calling the
> tycho-version-plugin:
> https://github.com/eclipse-tycho/tycho/issues/2169
> I debugged the problem and it seems that ConcurrencyDependencyGraph is
> actually the culprit here because it can return an empty list of projects to
> initially build. As no builds are scheduled then the code in the
> MultiThreadedBuilder waits forever for the result, this is what happening
> here:
> * There is one segment {code}org.faktorips:base:pom:23.6.0-SNAPSHOT ->
> [org.eclipse.tycho:tycho-versions-plugin:3.0.4-SNAPSHOT:set-version]{code}
> * This segment has a transitive reactor dependency to {code}MavenProject:
> org.faktorips:codequality-config:23.6.0-SNAPSHOT @
> faktorips.base/codequality-config/pom.xml{code} (this is not a problem
> because we only execute a reactor=true mojo!)
> * So now the loop finds that there is no "independent" project and returns an
> empty list
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] laeubi opened a new pull request, #1028: [MNG-7716] ConcurrencyDependencyGraph deadlock if no root is selected
laeubi opened a new pull request, #1028: URL: https://github.com/apache/maven/pull/1028 If ConcurrencyDependencyGraph#getRootSchedulableBuilds returns an empty list then MultiThreadedBuilder is locked forever as it never gets a build result (because nothing is scheduled). This changes the method, that in such case just the first project is returned, this might not give the best performance, but ensures that there is at least one build scheduled and the build-loop can proceed. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695760#comment-17695760
]
Michael Osipov commented on MNG-6825:
-
Same opinion here.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695759#comment-17695759
]
Tim te Beek commented on MNG-6825:
--
Thank you both for weighing in here; helps to have the goal so clearly stated.
As said this could be fun to dive into for me, but I don't want to burden
anyone with review work, especially when these changes are applied at scale. So
my proposal would be that I start small, but ideally do apply multiple changes
per pull request, rather than have lots of small pull requests per repository.
My takeaways from above are:
* remove org.codehaus.plexus.util.StringUtils
* remove maven-shared-utils
* prefer JDK methods where possible
* fall back onto commons-* where there's no equivalent in JDK
Are those takeaways correct?
And could you indicate for which of these repositories you'd like me to create
a first few pull requests?
apache/maven-acr-plugin @ master
apache/maven-antrun-plugin @ master
apache/maven-archetype @ master
apache/maven-archetypes @ master
apache/maven-archiver @ master
apache/maven-artifact-plugin @ master
apache/maven-artifact-resolver @ master
apache/maven-artifact-transfer @ master
apache/maven-assembly-plugin @ master
apache/maven-build-cache-extension @ master
apache/maven-changelog-plugin @ master
apache/maven-changes-plugin @ master
apache/maven-checkstyle-plugin @ master
apache/maven-clean-plugin @ master
apache/maven-common-artifact-filters @ master
apache/maven-compiler-plugin @ master
apache/maven-dependency-analyzer @ master
apache/maven-dependency-plugin @ master
apache/maven-dependency-tree @ master
apache/maven-deploy-plugin @ master
apache/maven-doap-plugin @ master
apache/maven-docck-plugin @ master
apache/maven-doxia-book-maven-plugin @ master
apache/maven-doxia-book-renderer @ master
apache/maven-doxia-converter @ master
apache/maven-doxia-sitetools @ master
apache/maven-doxia @ master
apache/maven-ear-plugin @ master
apache/maven-ejb-plugin @ master
apache/maven-enforcer @ master
apache/maven-file-management @ master
apache/maven-filtering @ master
apache/maven-gpg-plugin @ master
apache/maven-help-plugin @ master
apache/maven-indexer @ master
apache/maven-install-plugin @ master
apache/maven-integration-testing @ master
apache/maven-invoker-plugin @ master
apache/maven-invoker @ master
apache/maven-jar-plugin @ master
apache/maven-jarsigner-plugin @ master
apache/maven-jarsigner @ master
apache/maven-javadoc-plugin @ master
apache/maven-jdeprscan-plugin @ master
apache/maven-jdeps-plugin @ master
apache/maven-jlink-plugin @ master
apache/maven-jmod-plugin @ master
apache/maven-mapping @ master
apache/maven-patch-plugin @ master
apache/maven-pdf-plugin @ master
apache/maven-plugin-testing @ master
apache/maven-plugin-tools @ master
apache/maven-pmd-plugin @ master
apache/maven-project-info-reports-plugin @ master
apache/maven-project-utils @ master
apache/maven-rar-plugin @ master
apache/maven-release @ master
apache/maven-remote-resources-plugin @ master
apache/maven-reporting-api @ master
apache/maven-reporting-exec @ master
apache/maven-reporting-impl @ master
apache/maven-resolver-ant-tasks @ master
apache/maven-resolver @ master
apache/maven-resources-plugin @ master
apache/maven-runtime @ master
apache/maven-scm-publish-plugin @ master
apache/maven-scm @ master
apache/maven-script-interpreter @ master
apache/maven-scripting-plugin @ master
apache/maven-shade-plugin @ master
apache/maven-shared-incremental @ master
apache/maven-shared-io @ master
apache/maven-shared-jar @ master
apache/maven-shared-utils @ master
apache/maven-site-plugin @ master
apache/maven-source-plugin @ master
apache/maven-stage-plugin @ master
apache/maven-surefire @ master
apache/maven-toolchains-plugin @ master
apache/maven-verifier-plugin @ master
apache/maven-verifier @ master
apache/maven-wagon @ master
apache/maven-war-plugin @ master
apache/maven-wrapper @ master
apache/maven @ master
I'd thought to document any work I do here, and build up a repeatable set of
recipes that can then later be applied to all repositories if so desired.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from
[jira] [Comment Edited] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695748#comment-17695748
]
Tamas Cservenak edited comment on MNG-6825 at 3/2/23 3:01 PM:
--
I agree here with Elliotte, those projects (commons, plexus-utils,
maven-shared-utils) share common roots, have code copy pasted from each to
other... IMHO, maven-shared-utils
[https://github.com/apache/maven-shared-utils] should simply die off,
plexus-utils should deprecate all methods that are present in other commons
project, and at one point just drop them. This last step was on-hold almost
forever, as maven was injecting "currently used" plexus-utils into plugins,
which is not the case anymore, since 3.9 all plugins MUST declare and use their
own explicit plexus-utils version, so the danger of incompatibility is gone.
was (Author: cstamas):
I agree here with Elliotte, those projects (commons, plexus-utils,
maven-shared-utils) share common roots, have code copy pasted from each to
other... IMHO, maven-shared-utils
[https://github.com/apache/maven-shared-utils] should simply die off,
plexus-utils should deprecate all methods that are present in other commons
project, and at one point just drop them.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] ppalaga commented on a diff in pull request #797: Add property to disable model caching
ppalaga commented on code in PR #797:
URL: https://github.com/apache/maven-mvnd/pull/797#discussion_r1123228141
##
common/src/main/java/org/mvndaemon/mvnd/common/Environment.java:
##
@@ -163,6 +163,12 @@ public enum Environment {
* non-native clients and is useful mostly for debugging.
*/
MVND_NO_DAEMON("mvnd.noDaemon", "MVND_NO_DAEMON", Boolean.FALSE,
OptionType.BOOLEAN, Flags.DISCRIMINATING),
+
+/**
+ * If true, the daemon will not use its in-memory metadata
cache and instead re-read the
+ * metadata from the pom.xml files in the local repository. This is mostly
useful for testing purposes.
+ */
+MVND_NO_MODEL_CACHE("mvnd.noModelCache", null, Boolean.FALSE,
OptionType.BOOLEAN, Flags.NONE),
Review Comment:
I wonder whether we should use `Flags.DISCRIMINATING`? Is the
`createCache()` method called once for a given daemon instance or once per
Maven build?
If it's once for daemon, I'd say it should be `Flags.DISCRIMINATING`.
Otherwise it could happen that the user starts the daemon with `mvnd
-Dmvnd.noModelCache` and all subsequent `mvnd` invocations with *or without*
`-Dmvnd.noModelCache` will be served by the same daemon instance that has model
cache off. That would not be correct, would it?
`Flags.DISCRIMINATING` will make all calls with `-Dmvnd.noModelCache` be
served by a cacheless instance while all calls without `-Dmvnd.noModelCache`
will be served by some other daemon instance that has the cache enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7716) ConcurrencyDependencyGraph deadlock if no root can be selected
[
https://issues.apache.org/jira/browse/MNG-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695747#comment-17695747
]
ASF GitHub Bot commented on MNG-7716:
-
laeubi opened a new pull request, #1027:
URL: https://github.com/apache/maven/pull/1027
If ConcurrencyDependencyGraph#getRootSchedulableBuilds returns an empty list
then MultiThreadedBuilder is locked forever as it never gets a build result
(because nothing is scheduled).
This changes the method, that in such case just the first project is
returned, this might not give the best performance, but ensures that there is
at least one build scheduled and the build-loop can proceed.
If this is merged I can contribute a fix for 3.9.x as well!
This relates to:
- https://github.com/eclipse-tycho/tycho/issues/2169
The fix for this issue was gently sponsored by [Faktor Zehn
GmbH](https://www.faktorzehn.com).
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG-7716) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> ConcurrencyDependencyGraph deadlock if no root can be selected
> --
>
> Key: MNG-7716
> URL: https://issues.apache.org/jira/browse/MNG-7716
> Project: Maven
> Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Major
>
> At Tycho we got a bug-report that results in a deadlock when calling the
> tycho-version-plugin:
> https://github.com/eclipse-tycho/tycho/issues/2169
> I debugged the problem and it seems that ConcurrencyDependencyGraph is
> actually the culprit here because it can return an empty list of projects to
> initially build. As no builds are scheduled then the code in the
> MultiThreadedBuilder waits forever for the result, this is what happening
> here:
> * There is one segment {code}org.faktorips:base:pom:23.6.0-SNAPSHOT ->
> [org.eclipse.tycho:tycho-versions-plugin:3.0.4-SNAPSHOT:set-version]{code}
> * This segment has a transitive reactor dependency to {code}MavenProject:
> org.faktorips:codequality-config:23.6.0-SNAPSHOT @
> faktorips.base/codequality-config/pom.xml{code} (this is not a problem
> because we only execute a reactor=true mojo!)
> * So now the loop finds that there is no "independent" project and returns an
> empty list
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695748#comment-17695748
]
Tamas Cservenak commented on MNG-6825:
--
I agree here with Elliotte, those projects (commons, plexus-utils,
maven-shared-utils) share common roots, have code copy pasted from each to
other... IMHO, maven-shared-utils
[https://github.com/apache/maven-shared-utils] should simply die off,
plexus-utils should deprecate all methods that are present in other commons
project, and at one point just drop them.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] laeubi opened a new pull request, #1027: [3.8.x][MNG-7716] ConcurrencyDependencyGraph deadlock if no root is selected
laeubi opened a new pull request, #1027: URL: https://github.com/apache/maven/pull/1027 If ConcurrencyDependencyGraph#getRootSchedulableBuilds returns an empty list then MultiThreadedBuilder is locked forever as it never gets a build result (because nothing is scheduled). This changes the method, that in such case just the first project is returned, this might not give the best performance, but ensures that there is at least one build scheduled and the build-loop can proceed. If this is merged I can contribute a fix for 3.9.x as well! This relates to: - https://github.com/eclipse-tycho/tycho/issues/2169 The fix for this issue was gently sponsored by [Faktor Zehn GmbH](https://www.faktorzehn.com). Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG-7716) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695739#comment-17695739
]
Elliotte Rusty Harold commented on MNG-6825:
Both org.codehaus.plexus.util.StringUtils and maven-shared-utils should go
away. In many cases we can simply use the JDK. Otherwise the better choice is
org.apache.commons.lang3.StringUtils as it's actively supported, which is more
than we can say for plexus utils and maven-shared-utils. Generally we need to
get away from the idea that generic utilities should be implemented in maven
itself. They are better handled by Apache Commons, which focuses on those
things and is used and tested far beyond Maven.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7716) ConcurrencyDependencyGraph deadlock if no root can be selected
Christoph Läubrich created MNG-7716:
---
Summary: ConcurrencyDependencyGraph deadlock if no root can be
selected
Key: MNG-7716
URL: https://issues.apache.org/jira/browse/MNG-7716
Project: Maven
Issue Type: Bug
Reporter: Christoph Läubrich
At Tycho we got a bug-report that results in a deadlock when calling the
tycho-version-plugin:
https://github.com/eclipse-tycho/tycho/issues/2169
I debugged the problem and it seems that ConcurrencyDependencyGraph is actually
the culprit here because it can return an empty list of projects to initially
build. As no builds are scheduled then the code in the MultiThreadedBuilder
waits forever for the result, this is what happening here:
* There is one segment {code}org.faktorips:base:pom:23.6.0-SNAPSHOT ->
[org.eclipse.tycho:tycho-versions-plugin:3.0.4-SNAPSHOT:set-version]{code}
* This segment has a transitive reactor dependency to {code}MavenProject:
org.faktorips:codequality-config:23.6.0-SNAPSHOT @
faktorips.base/codequality-config/pom.xml{code} (this is not a problem because
we only execute a reactor=true mojo!)
* So now the loop finds that there is no "independent" project and returns an
empty list
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-antrun-plugin] dependabot[bot] closed pull request #69: Bump plexus-utils from 3.4.2 to 3.5.0
dependabot[bot] closed pull request #69: Bump plexus-utils from 3.4.2 to 3.5.0 URL: https://github.com/apache/maven-antrun-plugin/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] dependabot[bot] commented on pull request #69: Bump plexus-utils from 3.4.2 to 3.5.0
dependabot[bot] commented on PR #69: URL: https://github.com/apache/maven-antrun-plugin/pull/69#issuecomment-1451906306 Superseded by #78. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #78: Bump plexus-utils from 3.4.2 to 3.5.1
dependabot[bot] opened a new pull request, #78: URL: https://github.com/apache/maven-antrun-plugin/pull/78 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases;>plexus-utils's releases. 3.5.1 New features and improvements Reading and writing files using Java NIO (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/232;>#232) https://github.com/mkarg;>@mkarg Bug Fixes Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/241;>#241) https://github.com/gnodet;>@gnodet Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/240;>#240) https://github.com/gnodet;>@gnodet Dependency updates Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/237;>#237) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/231;>#231) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.1.0 to 3.2.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/227;>#227) https://github.com/dependabot;>@dependabot Bump jmh-generator-annprocess from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/222;>#222) https://github.com/dependabot;>@dependabot Bump jmh-core from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/223;>#223) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.0.2 to 3.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/220;>#220) https://github.com/dependabot;>@dependabot 3.5.0 Don't throw IOException when none is required (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/206;>#206) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/221;>#221) https://github.com/michael-o;>@michael-o Always preserve dominant node value (even if empty) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/217;>#217) https://github.com/kwin;>@kwin Don't overwrite blank (but non-empty) dominant values during mergeXpp3Dom (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/213;>#213) https://github.com/kwin;>@kwin Deprecate isEmpty(String) and isNotEmpty(String) in favour of same named (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/218;>#218) https://github.com/kwin;>@kwin isEmpty(String) must not return false for whitespace-only values (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/219;>#219) https://github.com/kwin;>@kwin Get rid maven-plugin-testing-harness from dependency (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/208;>#208) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates Bump plexus from 8 to 10 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/207;>#207) https://github.com/dependabot;>@dependabot Bump release-drafter/release-drafter from 5.19.0 to 5.20.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/205;>#205) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/8488ff2200964f47114b9dee5604dc3314a2fe8a;>8488ff2 [maven-release-plugin] prepare release plexus-utils-3.5.1 https://github.com/codehaus-plexus/plexus-utils/commit/bf198ff5d8f3bd5eb90d09826006c4d419884660;>bf198ff Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/241;>#241) https://github.com/codehaus-plexus/plexus-utils/commit/32b72a6e8ff51e7b53510ecfc47ca46eaa4695ba;>32b72a6 Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/240;>#240) https://github.com/codehaus-plexus/plexus-utils/commit/d3d137cdf51aff2fc854eb60c300a9953c0e093d;>d3d137c Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 https://github.com/codehaus-plexus/plexus-utils/commit/4f333f2691873e5ba024991a03390a4e773511e9;>4f333f2 Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/231;>#231)
[jira] [Assigned] (MNG-7715) Upgrade to Maven Resolver 1.9.6
[ https://issues.apache.org/jira/browse/MNG-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-7715: Assignee: Tamas Cservenak > Upgrade to Maven Resolver 1.9.6 > --- > > Key: MNG-7715 > URL: https://issues.apache.org/jira/browse/MNG-7715 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1 > > > Update resolver to 1.9.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-7708) Resolver in Maven 3.9+ no longer retries on a conection failure
[ https://issues.apache.org/jira/browse/MNG-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-7708: Assignee: Tamas Cservenak > Resolver in Maven 3.9+ no longer retries on a conection failure > --- > > Key: MNG-7708 > URL: https://issues.apache.org/jira/browse/MNG-7708 > Project: Maven > Issue Type: Bug >Affects Versions: 3.9.0 >Reporter: Jaromir Hamala >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 3.9.1 > > > It looks resolver in Maven 3.9+ no longer retries on a connection failure. > > The Wagon transport configures the internal HTTP client for retries: > [https://github.com/apache/maven-wagon/blob/88e8574c69d83e6a658fcd2ad10f3f80926b8840/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L560] > > The Native transport does not do that: > [https://github.com/apache/maven-resolver/blob/97dfd1c2b9deb15734d5e401807e55cd0498332a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java#L190-L200] > > In environments where idle connection connections are killed, Maven 3.9+ > often fails to resolve/download artefacts. A typical example is Azure > Pipelines. > > Consider exposing configuration options to re-enable retries, perhaps even > retry by default as it was the case with Wagon. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-7685) Unable to ignore certificate errors with v3.9.0
[ https://issues.apache.org/jira/browse/MNG-7685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-7685: Assignee: Tamas Cservenak > Unable to ignore certificate errors with v3.9.0 > --- > > Key: MNG-7685 > URL: https://issues.apache.org/jira/browse/MNG-7685 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.0 > Environment: Linux and Mac >Reporter: John Patrick >Assignee: Tamas Cservenak >Priority: Major > Labels: Regression > Fix For: waiting-for-feedback, 3.9.1 > > > Setting `-Dmaven.wagon.http.ssl.insecure=true` via `.mvn/jvm.config` does not > work with v3.9.0, but works with v3.8.7. i.e. when executing `./mvnw > org.apache.maven.plugins:maven-dependency-plugin:3.5.0:go-offline`. > I've got a minishift instance running jenkins, with agents created on demand. > I've got a nexus with a self signed certificate and for simpler out of the > box Jenkins agents I'm happy for it to ignore the nexus certificate error. So > Jenkins uses config-file-provider plugin to provide `jvm.config` and for > builds to ignore certificate issues. > Not sure if maven has; > # stopped reading `.mvn/jvm.config` > # stoped allowing multiple line `.mvn/jvm.config` > # not setting System properties as defined in `.mvn/jvm.config` > # wagon upgrade has introduced bug or new config -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7685) Unable to ignore certificate errors with v3.9.0
[ https://issues.apache.org/jira/browse/MNG-7685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7685: - Fix Version/s: 3.9.1 > Unable to ignore certificate errors with v3.9.0 > --- > > Key: MNG-7685 > URL: https://issues.apache.org/jira/browse/MNG-7685 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.0 > Environment: Linux and Mac >Reporter: John Patrick >Priority: Major > Labels: Regression > Fix For: waiting-for-feedback, 3.9.1 > > > Setting `-Dmaven.wagon.http.ssl.insecure=true` via `.mvn/jvm.config` does not > work with v3.9.0, but works with v3.8.7. i.e. when executing `./mvnw > org.apache.maven.plugins:maven-dependency-plugin:3.5.0:go-offline`. > I've got a minishift instance running jenkins, with agents created on demand. > I've got a nexus with a self signed certificate and for simpler out of the > box Jenkins agents I'm happy for it to ignore the nexus certificate error. So > Jenkins uses config-file-provider plugin to provide `jvm.config` and for > builds to ignore certificate issues. > Not sure if maven has; > # stopped reading `.mvn/jvm.config` > # stoped allowing multiple line `.mvn/jvm.config` > # not setting System properties as defined in `.mvn/jvm.config` > # wagon upgrade has introduced bug or new config -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7708) Resolver in Maven 3.9+ no longer retries on a conection failure
[ https://issues.apache.org/jira/browse/MNG-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7708: - Fix Version/s: 3.9.1 (was: 3.9.2) > Resolver in Maven 3.9+ no longer retries on a conection failure > --- > > Key: MNG-7708 > URL: https://issues.apache.org/jira/browse/MNG-7708 > Project: Maven > Issue Type: Bug >Affects Versions: 3.9.0 >Reporter: Jaromir Hamala >Priority: Minor > Fix For: 3.9.1 > > > It looks resolver in Maven 3.9+ no longer retries on a connection failure. > > The Wagon transport configures the internal HTTP client for retries: > [https://github.com/apache/maven-wagon/blob/88e8574c69d83e6a658fcd2ad10f3f80926b8840/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L560] > > The Native transport does not do that: > [https://github.com/apache/maven-resolver/blob/97dfd1c2b9deb15734d5e401807e55cd0498332a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java#L190-L200] > > In environments where idle connection connections are killed, Maven 3.9+ > often fails to resolve/download artefacts. A typical example is Azure > Pipelines. > > Consider exposing configuration options to re-enable retries, perhaps even > retry by default as it was the case with Wagon. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
[
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695723#comment-17695723
]
Robert Muir commented on MRESOLVER-325:
---
Another trap to look out for with java, if you are going to write/fsync/close,
make sure the write() really happens first. You may have to call
BufferedWriter.flush or similar methods.
In lucene we write files with open/write/close. data is then in "uncommitted
state" (we have some features "NRT search" that still allow you to search it in
this state, kinda like read-uncommitted with a database).
When you call commit(), then we do open+fsync+close on all the data files (see
that IOUtils helper, that's what it does). Then we rename() the commit marker
and open+fsync+close the containing directory (again via IOUtils helper).
Sorry, i know its confusing as hell. synchronizing data to disk should be easy.
But java makes it pretty hard. Write once, test everywhere.
> [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
>
>
> Key: MRESOLVER-325
> URL: https://issues.apache.org/jira/browse/MRESOLVER-325
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Christoph Läubrich
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> If one runs a build that otherwise works fine on 3.8.x with 3.9 we now get
> the following exception (full output can be found here
> https://github.com/eclipse-platform/eclipse.platform/actions/runs/4211467991/jobs/7309831666):
> {code:java}
> Error: 5.889 [ERROR] Internal error: java.io.UncheckedIOException:
> java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.io.UncheckedIOException: java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update
> (DefaultTrackingFileManager.java:121)
> at
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo
> (EnhancedLocalRepositoryManager.java:274)
> at
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact
> (EnhancedLocalRepositoryManager.java:252)
> at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.add
> (EnhancedLocalRepositoryManager.java:225)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads
> (DefaultArtifactResolver.java:680)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads
> (DefaultArtifactResolver.java:592)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve
> (DefaultArtifactResolver.java:478)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
> (DefaultArtifactResolver.java:278)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact
> (DefaultArtifactResolver.java:255)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact
>
[GitHub] [maven-integration-testing] cstamas merged pull request #249: [MNG-5181] Improve "missing dependency" message
cstamas merged PR #249: URL: https://github.com/apache/maven-integration-testing/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
[
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695714#comment-17695714
]
Robert Muir commented on MRESOLVER-325:
---
additionally we fsync the file's containing directory after the rename to
ensure rename is really visible. But this isn't related to your windows
problem, just something you should do on *nix if you really care about the
data. If you want to do that too, you may want to see lucene's helper method,
since jdk does not support fsyncing directories on windows (maybe windows has
synchronous metadata or something and it makes no sense to do this, i can't
remember)
https://github.com/apache/lucene/blob/70c152bf321f20c589f1e002fa01ccbfc74aa398/lucene/core/src/java/org/apache/lucene/util/IOUtils.java#L408-L444
> [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
>
>
> Key: MRESOLVER-325
> URL: https://issues.apache.org/jira/browse/MRESOLVER-325
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Christoph Läubrich
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> If one runs a build that otherwise works fine on 3.8.x with 3.9 we now get
> the following exception (full output can be found here
> https://github.com/eclipse-platform/eclipse.platform/actions/runs/4211467991/jobs/7309831666):
> {code:java}
> Error: 5.889 [ERROR] Internal error: java.io.UncheckedIOException:
> java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.io.UncheckedIOException: java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update
> (DefaultTrackingFileManager.java:121)
> at
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo
> (EnhancedLocalRepositoryManager.java:274)
> at
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact
> (EnhancedLocalRepositoryManager.java:252)
> at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.add
> (EnhancedLocalRepositoryManager.java:225)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads
> (DefaultArtifactResolver.java:680)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads
> (DefaultArtifactResolver.java:592)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve
> (DefaultArtifactResolver.java:478)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
> (DefaultArtifactResolver.java:278)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact
> (DefaultArtifactResolver.java:255)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact
> (DefaultRepositorySystem.java:296)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve
> (DefaultArtifactResolver.java:197)
> at
[jira] [Updated] (MRESOLVER-337) Real cause when artifact not found with repository filtering
[ https://issues.apache.org/jira/browse/MRESOLVER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-337: -- Component/s: Resolver > Real cause when artifact not found with repository filtering > > > Key: MRESOLVER-337 > URL: https://issues.apache.org/jira/browse/MRESOLVER-337 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 1.9.6 > > > One case from MRESOLVER-335. > When we use remote repository filtering real cause for artifact not found may > be hidden. > We can return first ArtifactNotFoundException which is not caused by > filtering. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] timtebeek closed pull request #183: [MNG-6825] Replace org.apache.maven.shared.utils.StringUtils
timtebeek closed pull request #183: [MNG-6825] Replace org.apache.maven.shared.utils.StringUtils URL: https://github.com/apache/maven-javadoc-plugin/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jmod-plugin] timtebeek closed pull request #6: [MNG-6825] Replace org.apache.maven.shared.utils.StringUtils
timtebeek closed pull request #6: [MNG-6825] Replace org.apache.maven.shared.utils.StringUtils URL: https://github.com/apache/maven-jmod-plugin/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7714) sp < final
[
https://issues.apache.org/jira/browse/MNG-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695704#comment-17695704
]
Elliotte Rusty Harold commented on MNG-7714:
somehow in the failing cases we end up comparing redhat on the left to sp on
the right, like the iteration is off. (Assuming I'm reading the debugger
correctly)
> sp < final
> --
>
> Key: MNG-7714
> URL: https://issues.apache.org/jira/browse/MNG-7714
> Project: Maven
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> Ported from a comment on https://issues.apache.org/jira/browse/MNG-7701
> The claim is that sp < final, which if true is incorrect according to spec.
> It is easy to demonstrate that this is not fixed and also not in line with
> the spec, with just this one important example (yes this does break for us):
> $ jbang org.apache.maven:maven-artifact:3.8.6 1.0.final-redhat-0001
> 1.0.sp1-redhat-0001
> Display parameters as parsed by Maven (in canonical form and as a list of
> tokens) and comparison result:
> 1. 1.0.final-redhat-0001 -> 1-redhat-1; tokens: [1, [redhat, [1]]]
>1.0.final-redhat-0001 < 1.0.sp1-redhat-0001
> 2. 1.0.sp1-redhat-0001 -> 1.0.sp-1-redhat-1; tokens: [1, 0, sp, [1, [redhat,
> [1
> versus
> $ jbang org.apache.maven:maven-artifact:3.8.7 1.0.final-redhat-0001
> 1.0.sp1-redhat-0001
> Display parameters as parsed by Maven (in canonical form and as a list of
> tokens) and comparison result:
> 1. 1.0.final-redhat-0001 -> 1-redhat-1; tokens: [1, [redhat, [1]]]
>1.0.final-redhat-0001 > 1.0.sp1-redhat-0001
> 2. 1.0.sp1-redhat-0001 -> 1-sp-1-redhat-1; tokens: [1, [sp, [1, [redhat,
> [1]
> As you can see, our `sp` release is now ordered after our `final` release
> despite this clear text in the "spec":
> Non-numeric tokens ("qualifiers") have the alphabetical order, except for
> the following tokens which come first in this order: "alpha" < "beta" <
> "milestone" < "rc" = "cr" < "snapshot" < "" = "final" = "ga" < "sp"
> It's clear that this tokenization isn't really correct by any reasonable
> measurement, and breaking large amounts of (our) existing artifacts in the
> wild is definitely not OK.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-pdf-plugin] dependabot[bot] opened a new pull request, #38: Bump plexus-utils from 3.5.0 to 3.5.1
dependabot[bot] opened a new pull request, #38: URL: https://github.com/apache/maven-pdf-plugin/pull/38 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases;>plexus-utils's releases. 3.5.1 New features and improvements Reading and writing files using Java NIO (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/232;>#232) https://github.com/mkarg;>@mkarg Bug Fixes Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/241;>#241) https://github.com/gnodet;>@gnodet Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/240;>#240) https://github.com/gnodet;>@gnodet Dependency updates Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/237;>#237) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/231;>#231) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.1.0 to 3.2.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/227;>#227) https://github.com/dependabot;>@dependabot Bump jmh-generator-annprocess from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/222;>#222) https://github.com/dependabot;>@dependabot Bump jmh-core from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/223;>#223) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.0.2 to 3.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/220;>#220) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/8488ff2200964f47114b9dee5604dc3314a2fe8a;>8488ff2 [maven-release-plugin] prepare release plexus-utils-3.5.1 https://github.com/codehaus-plexus/plexus-utils/commit/bf198ff5d8f3bd5eb90d09826006c4d419884660;>bf198ff Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/241;>#241) https://github.com/codehaus-plexus/plexus-utils/commit/32b72a6e8ff51e7b53510ecfc47ca46eaa4695ba;>32b72a6 Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/240;>#240) https://github.com/codehaus-plexus/plexus-utils/commit/d3d137cdf51aff2fc854eb60c300a9953c0e093d;>d3d137c Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 https://github.com/codehaus-plexus/plexus-utils/commit/4f333f2691873e5ba024991a03390a4e773511e9;>4f333f2 Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/231;>#231) https://github.com/codehaus-plexus/plexus-utils/commit/9db3ea7f918d3c5612703c6f95f1c2a87337ab05;>9db3ea7 Using Files#write() to implement Files#append() https://github.com/codehaus-plexus/plexus-utils/commit/6aa1b6fa11f16340757842939ff27a79c937a87f;>6aa1b6f Using Files#readString()/#writeString() on Java 11+ https://github.com/codehaus-plexus/plexus-utils/commit/c41544820537cc0ab39791f65baa1cb518a33879;>c415448 Using Files.write instead of OutputStream.write https://github.com/codehaus-plexus/plexus-utils/commit/b8696fb4b0ee29d866c5e09c08b6617dbc1fbfc2;>b8696fb Using Files.readAllBytes instead of custom loop https://github.com/codehaus-plexus/plexus-utils/commit/6288353e08b999ff16b7cf8ab09625f4e17b1b98;>6288353 Bump actions/checkout from 3.1.0 to 3.2.0 Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.5.0...plexus-utils-3.5.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will
[GitHub] [maven-doxia] dependabot[bot] opened a new pull request, #154: Bump plexus-utils from 3.5.0 to 3.5.1
dependabot[bot] opened a new pull request, #154: URL: https://github.com/apache/maven-doxia/pull/154 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases;>plexus-utils's releases. 3.5.1 New features and improvements Reading and writing files using Java NIO (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/232;>#232) https://github.com/mkarg;>@mkarg Bug Fixes Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/241;>#241) https://github.com/gnodet;>@gnodet Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/240;>#240) https://github.com/gnodet;>@gnodet Dependency updates Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/237;>#237) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/231;>#231) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.1.0 to 3.2.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/227;>#227) https://github.com/dependabot;>@dependabot Bump jmh-generator-annprocess from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/222;>#222) https://github.com/dependabot;>@dependabot Bump jmh-core from 1.35 to 1.36 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/223;>#223) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3.0.2 to 3.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/pull/220;>#220) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/8488ff2200964f47114b9dee5604dc3314a2fe8a;>8488ff2 [maven-release-plugin] prepare release plexus-utils-3.5.1 https://github.com/codehaus-plexus/plexus-utils/commit/bf198ff5d8f3bd5eb90d09826006c4d419884660;>bf198ff Partial revert of Support combine.self='remove' to fix MNG-7709 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/241;>#241) https://github.com/codehaus-plexus/plexus-utils/commit/32b72a6e8ff51e7b53510ecfc47ca46eaa4695ba;>32b72a6 Fix reading comments with UTF chars (fixes https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/240;>#240) https://github.com/codehaus-plexus/plexus-utils/commit/d3d137cdf51aff2fc854eb60c300a9953c0e093d;>d3d137c Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 https://github.com/codehaus-plexus/plexus-utils/commit/4f333f2691873e5ba024991a03390a4e773511e9;>4f333f2 Bump actions/checkout from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/231;>#231) https://github.com/codehaus-plexus/plexus-utils/commit/9db3ea7f918d3c5612703c6f95f1c2a87337ab05;>9db3ea7 Using Files#write() to implement Files#append() https://github.com/codehaus-plexus/plexus-utils/commit/6aa1b6fa11f16340757842939ff27a79c937a87f;>6aa1b6f Using Files#readString()/#writeString() on Java 11+ https://github.com/codehaus-plexus/plexus-utils/commit/c41544820537cc0ab39791f65baa1cb518a33879;>c415448 Using Files.write instead of OutputStream.write https://github.com/codehaus-plexus/plexus-utils/commit/b8696fb4b0ee29d866c5e09c08b6617dbc1fbfc2;>b8696fb Using Files.readAllBytes instead of custom loop https://github.com/codehaus-plexus/plexus-utils/commit/6288353e08b999ff16b7cf8ab09625f4e17b1b98;>6288353 Bump actions/checkout from 3.1.0 to 3.2.0 Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.5.0...plexus-utils-3.5.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate
[GitHub] [maven-doxia] dependabot[bot] closed pull request #139: Bump annotations from 15.0 to 24.0.0
dependabot[bot] closed pull request #139: Bump annotations from 15.0 to 24.0.0 URL: https://github.com/apache/maven-doxia/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] dependabot[bot] opened a new pull request, #153: Bump annotations from 15.0 to 24.0.1
dependabot[bot] opened a new pull request, #153: URL: https://github.com/apache/maven-doxia/pull/153 Bumps [annotations](https://github.com/JetBrains/java-annotations) from 15.0 to 24.0.1. Release notes Sourced from https://github.com/JetBrains/java-annotations/releases;>annotations's releases. 24.0.0 Added new annotation: @CheckReturnValue 23.1.0 Added new annotation: @ApiStatus.Obsolete 23.0.0 Added new annotations: @BlockingExecutor and @NonBlockingExecutor. 22.0.0 Added new annotations: @Blocking and @NonBlocking. 21.0.1 Multi-Release Jar: Manifest fixed 21.0.0 Added new annotation: @UnknownNullability. Proper JPMS module. 20.1.0 Added TYPE_USE target for PropertyKey annotation. 20.0.0 Added new annotation: @MustBeInvokedByOverriders. Added new annotation: @VisibleForTesting. Added TYPE_USE target for NonNls annotation. String attributes of annotations are marked as @NonNls where applicable. Documentation for @Nls and @NonNls updated: now they could be used as meta-annotations. Documentation added for @Subst annotation. 19.0.0 Added new annotations: @Unmodifiable and @UnmodifiableView. Added TYPE_USE target for Nls annotation. Improved the documentation for @Language, @Pattern, @RegExp, and @ApiStatus.Internal annotations. Fixed Automatic-Module-Name for Java 5. 18.0.0 Added new annotation family @ApiStatus.* Added new annotation @Debug.Renderer 17.0.0 Added new annotation: @Range 16.0.3 Added Automatic-Module-Name to MANIFEST.MF 16.0.2 Improved the documentation for the @Contract annotation. 16.0.1 ... (truncated) Changelog Sourced from https://github.com/JetBrains/java-annotations/blob/master/CHANGELOG.md;>annotations's changelog. Version 24.0.1 Added @Documented annotation where it would be useful. Version 24.0.0 Added new annotation: @CheckReturnValue. Version 23.1.0 Added new annotation: @ApiStatus.Obsolete. Version 23.0.0 Added new annotations: @BlockingExecutor and @NonBlockingExecutor. Version 22.0.0 Added new annotations: @Blocking and @NonBlocking. Version 21.0.1 Multi-Release Jar: Manifest fixed Version 21.0.0 Added new annotation: @UnknownNullability. Proper JPMS module. JdkConstants deprecated. Version 20.1.0 Added TYPE_USE target for PropertyKey annotation. Version 20.0.0 Added new annotation: @MustBeInvokedByOverriders. Added new annotation: @VisibleForTesting. Added TYPE_USE target for NonNls annotation. String attributes of annotations are marked as @NonNls where applicable. Documentation for @Nls and @NonNls updated: now they could be used as meta-annotations. Documentation added for @Subst annotation. Version 19.0.0 Added new annotations: @Unmodifiable and @UnmodifiableView. Added TYPE_USE target for Nls annotation. Improved the documentation for @Language, @Pattern, @RegExp, and @ApiStatus.Internal annotations. Fixed Automatic-Module-Name for Java 5. ... (truncated) Commits See full diff in https://github.com/JetBrains/java-annotations/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating
[GitHub] [maven-doxia] dependabot[bot] commented on pull request #139: Bump annotations from 15.0 to 24.0.0
dependabot[bot] commented on PR #139: URL: https://github.com/apache/maven-doxia/pull/139#issuecomment-1451826876 Superseded by #153. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] cstamas opened a new pull request, #249: [MNG-5181] Improve "missing dependency" message
cstamas opened a new pull request, #249: URL: https://github.com/apache/maven-integration-testing/pull/249 Related IT change, as the change for this issue made MNG-7128 IT to fail, as it was too eagerly match whole error message string that has now due MNG-5181 changed. To fix it, match only the key parts of the expected error message, that project failed, due transfer failure, as insecure mirror was blocked. This makes IT assert same thing, but is more flexible regarding error text change in MNG-5181. --- https://issues.apache.org/jira/browse/MNG-5185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7714) sp < final
[
https://issues.apache.org/jira/browse/MNG-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695697#comment-17695697
]
Elliotte Rusty Harold commented on MNG-7714:
"1.0.final" < "1.0.sp1"
However
1.0.final-redhat > "1.0.sp1-redhat" // incorrect
> sp < final
> --
>
> Key: MNG-7714
> URL: https://issues.apache.org/jira/browse/MNG-7714
> Project: Maven
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> Ported from a comment on https://issues.apache.org/jira/browse/MNG-7701
> The claim is that sp < final, which if true is incorrect according to spec.
> It is easy to demonstrate that this is not fixed and also not in line with
> the spec, with just this one important example (yes this does break for us):
> $ jbang org.apache.maven:maven-artifact:3.8.6 1.0.final-redhat-0001
> 1.0.sp1-redhat-0001
> Display parameters as parsed by Maven (in canonical form and as a list of
> tokens) and comparison result:
> 1. 1.0.final-redhat-0001 -> 1-redhat-1; tokens: [1, [redhat, [1]]]
>1.0.final-redhat-0001 < 1.0.sp1-redhat-0001
> 2. 1.0.sp1-redhat-0001 -> 1.0.sp-1-redhat-1; tokens: [1, 0, sp, [1, [redhat,
> [1
> versus
> $ jbang org.apache.maven:maven-artifact:3.8.7 1.0.final-redhat-0001
> 1.0.sp1-redhat-0001
> Display parameters as parsed by Maven (in canonical form and as a list of
> tokens) and comparison result:
> 1. 1.0.final-redhat-0001 -> 1-redhat-1; tokens: [1, [redhat, [1]]]
>1.0.final-redhat-0001 > 1.0.sp1-redhat-0001
> 2. 1.0.sp1-redhat-0001 -> 1-sp-1-redhat-1; tokens: [1, [sp, [1, [redhat,
> [1]
> As you can see, our `sp` release is now ordered after our `final` release
> despite this clear text in the "spec":
> Non-numeric tokens ("qualifiers") have the alphabetical order, except for
> the following tokens which come first in this order: "alpha" < "beta" <
> "milestone" < "rc" = "cr" < "snapshot" < "" = "final" = "ga" < "sp"
> It's clear that this tokenization isn't really correct by any reasonable
> measurement, and breaking large amounts of (our) existing artifacts in the
> wild is definitely not OK.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7714) sp < final
[
https://issues.apache.org/jira/browse/MNG-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695690#comment-17695690
]
Elliotte Rusty Harold commented on MNG-7714:
also correctly handled:
"1.0.final-redhat-0001" < "1.0.sp.1-redhat-0001"
"1.0.final-redhat-0001" < "1.0.sp-1-redhat-0001"
so it might be something in the splitting that screws this up. E.g. maybe sp1
is getting parsed as "sp1" instead of "sp-1"
> sp < final
> --
>
> Key: MNG-7714
> URL: https://issues.apache.org/jira/browse/MNG-7714
> Project: Maven
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> Ported from a comment on https://issues.apache.org/jira/browse/MNG-7701
> The claim is that sp < final, which if true is incorrect according to spec.
> It is easy to demonstrate that this is not fixed and also not in line with
> the spec, with just this one important example (yes this does break for us):
> $ jbang org.apache.maven:maven-artifact:3.8.6 1.0.final-redhat-0001
> 1.0.sp1-redhat-0001
> Display parameters as parsed by Maven (in canonical form and as a list of
> tokens) and comparison result:
> 1. 1.0.final-redhat-0001 -> 1-redhat-1; tokens: [1, [redhat, [1]]]
>1.0.final-redhat-0001 < 1.0.sp1-redhat-0001
> 2. 1.0.sp1-redhat-0001 -> 1.0.sp-1-redhat-1; tokens: [1, 0, sp, [1, [redhat,
> [1
> versus
> $ jbang org.apache.maven:maven-artifact:3.8.7 1.0.final-redhat-0001
> 1.0.sp1-redhat-0001
> Display parameters as parsed by Maven (in canonical form and as a list of
> tokens) and comparison result:
> 1. 1.0.final-redhat-0001 -> 1-redhat-1; tokens: [1, [redhat, [1]]]
>1.0.final-redhat-0001 > 1.0.sp1-redhat-0001
> 2. 1.0.sp1-redhat-0001 -> 1-sp-1-redhat-1; tokens: [1, [sp, [1, [redhat,
> [1]
> As you can see, our `sp` release is now ordered after our `final` release
> despite this clear text in the "spec":
> Non-numeric tokens ("qualifiers") have the alphabetical order, except for
> the following tokens which come first in this order: "alpha" < "beta" <
> "milestone" < "rc" = "cr" < "snapshot" < "" = "final" = "ga" < "sp"
> It's clear that this tokenization isn't really correct by any reasonable
> measurement, and breaking large amounts of (our) existing artifacts in the
> wild is definitely not OK.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7714) sp < final
[
https://issues.apache.org/jira/browse/MNG-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695687#comment-17695687
]
Elliotte Rusty Harold commented on MNG-7714:
I can reproduce this. Specifically,
"final" < "sp" // correct
"final" < "sp1" // correct
"1.0.final-redhat-0001" < "1.0.sp-redhat-0001" // correct
"1.0.final-redhat-0001" > "1.0.sp1-redhat-0001" // likely incorrect,
investigating
> sp < final
> --
>
> Key: MNG-7714
> URL: https://issues.apache.org/jira/browse/MNG-7714
> Project: Maven
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> Ported from a comment on https://issues.apache.org/jira/browse/MNG-7701
> The claim is that sp < final, which if true is incorrect according to spec.
> It is easy to demonstrate that this is not fixed and also not in line with
> the spec, with just this one important example (yes this does break for us):
> $ jbang org.apache.maven:maven-artifact:3.8.6 1.0.final-redhat-0001
> 1.0.sp1-redhat-0001
> Display parameters as parsed by Maven (in canonical form and as a list of
> tokens) and comparison result:
> 1. 1.0.final-redhat-0001 -> 1-redhat-1; tokens: [1, [redhat, [1]]]
>1.0.final-redhat-0001 < 1.0.sp1-redhat-0001
> 2. 1.0.sp1-redhat-0001 -> 1.0.sp-1-redhat-1; tokens: [1, 0, sp, [1, [redhat,
> [1
> versus
> $ jbang org.apache.maven:maven-artifact:3.8.7 1.0.final-redhat-0001
> 1.0.sp1-redhat-0001
> Display parameters as parsed by Maven (in canonical form and as a list of
> tokens) and comparison result:
> 1. 1.0.final-redhat-0001 -> 1-redhat-1; tokens: [1, [redhat, [1]]]
>1.0.final-redhat-0001 > 1.0.sp1-redhat-0001
> 2. 1.0.sp1-redhat-0001 -> 1-sp-1-redhat-1; tokens: [1, [sp, [1, [redhat,
> [1]
> As you can see, our `sp` release is now ordered after our `final` release
> despite this clear text in the "spec":
> Non-numeric tokens ("qualifiers") have the alphabetical order, except for
> the following tokens which come first in this order: "alpha" < "beta" <
> "milestone" < "rc" = "cr" < "snapshot" < "" = "final" = "ga" < "sp"
> It's clear that this tokenization isn't really correct by any reasonable
> measurement, and breaking large amounts of (our) existing artifacts in the
> wild is definitely not OK.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOLVER-325) [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
[
https://issues.apache.org/jira/browse/MRESOLVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695641#comment-17695641
]
Michael Osipov commented on MRESOLVER-325:
--
[~rcmuir], [~uschindler], the approach would be open/write/fsync/close/rename?
> [REGRESSION] Suddenly seeing I/O errors under windows aborting the build
>
>
> Key: MRESOLVER-325
> URL: https://issues.apache.org/jira/browse/MRESOLVER-325
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Christoph Läubrich
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> If one runs a build that otherwise works fine on 3.8.x with 3.9 we now get
> the following exception (full output can be found here
> https://github.com/eclipse-platform/eclipse.platform/actions/runs/4211467991/jobs/7309831666):
> {code:java}
> Error: 5.889 [ERROR] Internal error: java.io.UncheckedIOException:
> java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.io.UncheckedIOException: java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException:
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories.15650462061630955031.tmp
> ->
> C:\Users\runneradmin\.m2\repository\com\google\code\gson\gson\2.10.1\_remote.repositories
> at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update
> (DefaultTrackingFileManager.java:121)
> at
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo
> (EnhancedLocalRepositoryManager.java:274)
> at
> org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact
> (EnhancedLocalRepositoryManager.java:252)
> at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.add
> (EnhancedLocalRepositoryManager.java:225)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads
> (DefaultArtifactResolver.java:680)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads
> (DefaultArtifactResolver.java:592)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve
> (DefaultArtifactResolver.java:478)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
> (DefaultArtifactResolver.java:278)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact
> (DefaultArtifactResolver.java:255)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact
> (DefaultRepositorySystem.java:296)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve
> (DefaultArtifactResolver.java:197)
> at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve
> (DefaultArtifactResolver.java:413)
> at org.apache.maven.repository.legacy.LegacyRepositorySystem.resolve
> (LegacyRepositorySystem.java:332)
> at
> org.eclipse.tycho.osgi.configuration.MavenDependenciesResolverConfigurer.resolve
> (MavenDependenciesResolverConfigurer.java:104)
> at org.eclipse.tycho.core.shared.MavenDependenciesResolver.resolve
> (MavenDependenciesResolver.java:60)
> at org.eclipse.tycho.core.resolver.MavenTargetDefinitionContent.
>
[jira] [Commented] (MRESOLVER-332) Could not acquire write lock
[
https://issues.apache.org/jira/browse/MRESOLVER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695639#comment-17695639
]
Michael Osipov commented on MRESOLVER-332:
--
Darn, I really need to update the document, there have been a lot of changes.
For the vars, please https://maven.apache.org/resolver/configuration.html and
https://maven.apache.org/resolver/maven-resolver-named-locks/index.html
> Could not acquire write lock
>
>
> Key: MRESOLVER-332
> URL: https://issues.apache.org/jira/browse/MRESOLVER-332
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.9.4
>Reporter: Delany
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> *
> {noformat}
> 07:59:36 [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.2.1:enforce (fail) on
> project distribution-noidentityjars: Execution fail of goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.2.1:enforce failed: Could
> not acquire write lock for 'artifact:org.junit.jupiter:junit-jupiter:5.9.0'
> -> [Help 1]
> 07:59:36 org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.2.1:enforce
> (fail) on project distribution-noidentityjars: Execution fail of goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.2.1:enforce failed: Could
> not acquire write lock for
> 'artifact:org.junit.jupiter:junit-jupiter:5.9.0'07:59:36 Caused by:
> java.lang.IllegalStateException: Could not acquire write lock for
> 'artifact:org.junit.jupiter:junit-jupiter:5.9.0'
> 07:59:36 at
> org.eclipse.aether.internal.impl.synccontext.named.NamedLockFactoryAdapter$AdaptedLockSyncContext.acquire
> (NamedLockFactoryAdapter.java:184)
> 07:59:36 at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
> (DefaultArtifactResolver.java:276)
> 07:59:36 at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact
> (DefaultArtifactResolver.java:255)
> 07:59:36 at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact
> (DefaultRepositorySystem.java:296)
> 07:59:36 at
> org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve
> (DefaultArtifactResolver.java:197)
> 07:59:36 at
> org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve
> (DefaultArtifactResolver.java:413)
> 07:59:36 at
> org.apache.maven.repository.legacy.LegacyRepositorySystem.resolve
> (LegacyRepositorySystem.java:332)
> 07:59:36 at
> org.apache.maven.plugins.enforcer.AbstractResolveDependencies.resolveArtifact
> (AbstractResolveDependencies.java:152)
> 07:59:36 at
> org.apache.maven.plugins.enforcer.AbstractResolveDependencies.getAllDescendants
> (AbstractResolveDependencies.java:124)
> 07:59:36 at
> org.apache.maven.plugins.enforcer.AbstractResolveDependencies.getDependenciesToCheck
> (AbstractResolveDependencies.java:95)
> 07:59:36 at
> org.apache.maven.plugins.enforcer.AbstractResolveDependencies.execute
> (AbstractResolveDependencies.java:76)
> 07:59:36 at org.apache.maven.plugins.enforcer.EnforceMojo.executeRuleOld
> (EnforceMojo.java:342)
> 07:59:36 at org.apache.maven.plugins.enforcer.EnforceMojo.executeRule
> (EnforceMojo.java:323)
> 07:59:36 at org.apache.maven.plugins.enforcer.EnforceMojo.execute
> (EnforceMojo.java:248)
> 07:59:36 at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126)
> 07:59:36 at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:342)
> 07:59:36 at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:330)
> 07:59:36 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:213)
> 07:59:36 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:175)
> 07:59:36 at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:76)
> 07:59:36 at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:163)
> 07:59:36 at
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> 07:59:36 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> 07:59:36 at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> 07:59:36 at
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
> (MultiThreadedBuilder.java:193)
> 07:59:36 at
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
>
[jira] [Closed] (MNG-6889) Mark command line option --legacy-local-repository as deprecated
[ https://issues.apache.org/jira/browse/MNG-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-6889. Resolution: Fixed > Mark command line option --legacy-local-repository as deprecated > > > Key: MNG-6889 > URL: https://issues.apache.org/jira/browse/MNG-6889 > Project: Maven > Issue Type: Task > Components: Command Line >Affects Versions: 3.6.3 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.8.8 > > > We should at least mark this option as deprecated or even better remove this > option but this would be inconsistent to remove something which has not been > marked deprecated before. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6889) Mark command line option --legacy-local-repository as deprecated
[ https://issues.apache.org/jira/browse/MNG-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695634#comment-17695634 ] ASF GitHub Bot commented on MNG-6889: - cstamas merged PR #1026: URL: https://github.com/apache/maven/pull/1026 > Mark command line option --legacy-local-repository as deprecated > > > Key: MNG-6889 > URL: https://issues.apache.org/jira/browse/MNG-6889 > Project: Maven > Issue Type: Task > Components: Command Line >Affects Versions: 3.6.3 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.8.8 > > > We should at least mark this option as deprecated or even better remove this > option but this would be inconsistent to remove something which has not been > marked deprecated before. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas merged pull request #1026: [3.8.x] [MNG-6889] Deprecate llr option
cstamas merged PR #1026: URL: https://github.com/apache/maven/pull/1026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-337) Real cause when artifact not found with repository filtering
[ https://issues.apache.org/jira/browse/MRESOLVER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MRESOLVER-337. - Resolution: Fixed > Real cause when artifact not found with repository filtering > > > Key: MRESOLVER-337 > URL: https://issues.apache.org/jira/browse/MRESOLVER-337 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 1.9.6 > > > One case from MRESOLVER-335. > When we use remote repository filtering real cause for artifact not found may > be hidden. > We can return first ArtifactNotFoundException which is not caused by > filtering. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-337) Real cause when artifact not found with repository filtering
[ https://issues.apache.org/jira/browse/MRESOLVER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695630#comment-17695630 ] ASF GitHub Bot commented on MRESOLVER-337: -- slawekjaranowski merged PR #262: URL: https://github.com/apache/maven-resolver/pull/262 > Real cause when artifact not found with repository filtering > > > Key: MRESOLVER-337 > URL: https://issues.apache.org/jira/browse/MRESOLVER-337 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 1.9.6 > > > One case from MRESOLVER-335. > When we use remote repository filtering real cause for artifact not found may > be hidden. > We can return first ArtifactNotFoundException which is not caused by > filtering. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-resolver] slawekjaranowski merged pull request #262: [MRESOLVER-337] Real cause when artifact not found with repository filtering
slawekjaranowski merged PR #262: URL: https://github.com/apache/maven-resolver/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
