[jira] [Created] (MBUILDCACHE-57) Configure remote url with command line property
Olivier Lamy created MBUILDCACHE-57: --- Summary: Configure remote url with command line property Key: MBUILDCACHE-57 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-57 Project: Maven Build Cache Extension Issue Type: New Feature Reporter: Olivier Lamy Assignee: Olivier Lamy Fix For: 1.0.1 being able to use -Dmaven.build.cache.remote.url= to override remote cache url -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MBUILDCACHE-44) Running duplicate maven phase leads to IllegalStateException and cache miss
[
https://issues.apache.org/jira/browse/MBUILDCACHE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MBUILDCACHE-44.
---
Resolution: Fixed
> Running duplicate maven phase leads to IllegalStateException and cache miss
> ---
>
> Key: MBUILDCACHE-44
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-44
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Miguel Ortega
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.0.1
>
> Attachments: maven-cache.zip
>
>
> When running maven with a duplicate maven goal like below (i'm aware that
> compile phase here is not necessary)
> {code:java}
> mvn compile test
> {code}
> the plugin seems to create a cache key that cause an error if i call.
> {code:java}
> mvn test
> {code}
> This will cause the following error:
> {code:java}
> [ERROR] Failed to restore project
> java.lang.IllegalStateException: Duplicate key
> default-resources:resources:process-resources:maven-resources-plugin:org.apache.maven.plugins
> (attempted merging values
> org.apache.maven.buildcache.xml.build.CompletedExecution@1e1b061 and
> org.apache.maven.buildcache.xml.build.CompletedExecution@38f77cd9)
> at java.util.stream.Collectors.duplicateKeyException (Collectors.java:135)
> at java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1
> (Collectors.java:182)
> at java.util.stream.ReduceOps$3ReducingSink.accept (ReduceOps.java:169)
> at java.util.ArrayList$ArrayListSpliterator.forEachRemaining
> (ArrayList.java:1625)
> at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509)
> at java.util.stream.AbstractPipeline.wrapAndCopyInto
> (AbstractPipeline.java:499)
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential
> (ReduceOps.java:921)
> at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682)
> at org.apache.maven.buildcache.xml.Build.getExecutionMap (Build.java:198)
> at org.apache.maven.buildcache.xml.Build.hasCompletedExecution
> (Build.java:116)
> at org.apache.maven.buildcache.xml.Build.lambda$getMissingExecutions$0
> (Build.java:110)
> at java.util.stream.ReferencePipeline$2$1.accept
> (ReferencePipeline.java:178)
> at java.util.ArrayList$ArrayListSpliterator.forEachRemaining
> (ArrayList.java:1625)
> at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509)
> at java.util.stream.AbstractPipeline.wrapAndCopyInto
> (AbstractPipeline.java:499)
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential
> (ReduceOps.java:921)
> at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682)
> at org.apache.maven.buildcache.xml.Build.getMissingExecutions
> (Build.java:111)
> at org.apache.maven.buildcache.CacheControllerImpl.analyzeResult
> (CacheControllerImpl.java:267)
> at org.apache.maven.buildcache.CacheControllerImpl.findLocalBuild
> (CacheControllerImpl.java:234)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:185)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:114)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launc
[jira] [Updated] (MBUILDCACHE-44) Running duplicate maven phase leads to IllegalStateException and cache miss
[
https://issues.apache.org/jira/browse/MBUILDCACHE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy updated MBUILDCACHE-44:
Fix Version/s: 1.0.1
> Running duplicate maven phase leads to IllegalStateException and cache miss
> ---
>
> Key: MBUILDCACHE-44
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-44
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Miguel Ortega
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.0.1
>
> Attachments: maven-cache.zip
>
>
> When running maven with a duplicate maven goal like below (i'm aware that
> compile phase here is not necessary)
> {code:java}
> mvn compile test
> {code}
> the plugin seems to create a cache key that cause an error if i call.
> {code:java}
> mvn test
> {code}
> This will cause the following error:
> {code:java}
> [ERROR] Failed to restore project
> java.lang.IllegalStateException: Duplicate key
> default-resources:resources:process-resources:maven-resources-plugin:org.apache.maven.plugins
> (attempted merging values
> org.apache.maven.buildcache.xml.build.CompletedExecution@1e1b061 and
> org.apache.maven.buildcache.xml.build.CompletedExecution@38f77cd9)
> at java.util.stream.Collectors.duplicateKeyException (Collectors.java:135)
> at java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1
> (Collectors.java:182)
> at java.util.stream.ReduceOps$3ReducingSink.accept (ReduceOps.java:169)
> at java.util.ArrayList$ArrayListSpliterator.forEachRemaining
> (ArrayList.java:1625)
> at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509)
> at java.util.stream.AbstractPipeline.wrapAndCopyInto
> (AbstractPipeline.java:499)
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential
> (ReduceOps.java:921)
> at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682)
> at org.apache.maven.buildcache.xml.Build.getExecutionMap (Build.java:198)
> at org.apache.maven.buildcache.xml.Build.hasCompletedExecution
> (Build.java:116)
> at org.apache.maven.buildcache.xml.Build.lambda$getMissingExecutions$0
> (Build.java:110)
> at java.util.stream.ReferencePipeline$2$1.accept
> (ReferencePipeline.java:178)
> at java.util.ArrayList$ArrayListSpliterator.forEachRemaining
> (ArrayList.java:1625)
> at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509)
> at java.util.stream.AbstractPipeline.wrapAndCopyInto
> (AbstractPipeline.java:499)
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential
> (ReduceOps.java:921)
> at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682)
> at org.apache.maven.buildcache.xml.Build.getMissingExecutions
> (Build.java:111)
> at org.apache.maven.buildcache.CacheControllerImpl.analyzeResult
> (CacheControllerImpl.java:267)
> at org.apache.maven.buildcache.CacheControllerImpl.findLocalBuild
> (CacheControllerImpl.java:234)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:185)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:114)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.
[jira] [Closed] (MBUILDCACHE-52) Use current latest release in Getting Started snippet
[ https://issues.apache.org/jira/browse/MBUILDCACHE-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MBUILDCACHE-52. --- Resolution: Fixed fixed with https://github.com/apache/maven-build-cache-extension/pull/70 > Use current latest release in Getting Started snippet > - > > Key: MBUILDCACHE-52 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-52 > Project: Maven Build Cache Extension > Issue Type: Improvement >Affects Versions: 1.0.0 >Reporter: Nils Breunese >Assignee: Olivier Lamy >Priority: Minor > Fix For: 1.0.1 > > > [https://maven.apache.org/extensions/maven-build-cache-extension/getting-started.html#declaring-build-cache-extension] > shows an XML snippet for version 1.0.0-SNAPSHOT, while 1.0.0 is currently > the latest release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-52) Use current latest release in Getting Started snippet
[ https://issues.apache.org/jira/browse/MBUILDCACHE-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MBUILDCACHE-52: Fix Version/s: 1.0.1 > Use current latest release in Getting Started snippet > - > > Key: MBUILDCACHE-52 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-52 > Project: Maven Build Cache Extension > Issue Type: Improvement >Affects Versions: 1.0.0 >Reporter: Nils Breunese >Priority: Minor > Fix For: 1.0.1 > > > [https://maven.apache.org/extensions/maven-build-cache-extension/getting-started.html#declaring-build-cache-extension] > shows an XML snippet for version 1.0.0-SNAPSHOT, while 1.0.0 is currently > the latest release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MBUILDCACHE-52) Use current latest release in Getting Started snippet
[ https://issues.apache.org/jira/browse/MBUILDCACHE-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MBUILDCACHE-52: --- Assignee: Olivier Lamy > Use current latest release in Getting Started snippet > - > > Key: MBUILDCACHE-52 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-52 > Project: Maven Build Cache Extension > Issue Type: Improvement >Affects Versions: 1.0.0 >Reporter: Nils Breunese >Assignee: Olivier Lamy >Priority: Minor > Fix For: 1.0.1 > > > [https://maven.apache.org/extensions/maven-build-cache-extension/getting-started.html#declaring-build-cache-extension] > shows an XML snippet for version 1.0.0-SNAPSHOT, while 1.0.0 is currently > the latest release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-38) IAE while execution plugin goal
[
https://issues.apache.org/jira/browse/MBUILDCACHE-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715597#comment-17715597
]
Olivier Lamy commented on MBUILDCACHE-38:
-
sounds like a duplicate of MBUILDCACHE-50 ?
> IAE while execution plugin goal
> ---
>
> Key: MBUILDCACHE-38
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-38
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Critical
>
> Reproducing project:
> [https://github.com/athkalia/maven-build-cache-forked-executions]
> Description:
> ```
> h2.
> [README.md|https://github.com/apache/maven-build-cache-extension/pull/30#readme]
> To replicate issue:
> * Run {{./mvnw clean install}}
> * Run {{./mvnw clean com.athkalia:module-1:level0 -e}}
> Error appears:
> {code}
> [ERROR] Unsupported phase: null
> java.lang.IllegalArgumentException: Unsupported phase: null
> at org.apache.maven.buildcache.LifecyclePhasesHelper.isLaterPhase
> (LifecyclePhasesHelper.java:131)
> at org.apache.maven.buildcache.LifecyclePhasesHelper.isLaterPhaseThanClean
> (LifecyclePhasesHelper.java:115)
> at org.apache.maven.buildcache.LifecyclePhasesHelper.getCleanSegment
> (LifecyclePhasesHelper.java:151)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:106)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:157)
> at org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions
> (MojoExecutor.java:454)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:317)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:172)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:160)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:132)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:157)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:106)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:74)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:58)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:130)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:304)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:226)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:151)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:854)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:281)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:197)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.apache.maven.wrapper.BootstrapMainStarter.start
> (BootstrapMainStarter.java:53)
> at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:152)
> at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:76)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-50) Unsupported phase: null with dependency:analyze in multimodule project
[
https://issues.apache.org/jira/browse/MBUILDCACHE-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy updated MBUILDCACHE-50:
Fix Version/s: 1.0.1
> Unsupported phase: null with dependency:analyze in multimodule project
> --
>
> Key: MBUILDCACHE-50
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-50
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
> Environment: Windows 10 x64
> Maven 3.9.1
> Java 20 (Eclipse Adoptium)
>Reporter: Thorsten Heit
>Priority: Major
> Fix For: 1.0.1
>
> Attachments: pomtest.tar.bz2
>
>
> Executing {{"mvn dependency:analyze"}} results in an error message
> "Unsupported phase: null" when the first submodule of a multimodule project
> is being analyzed.
> I've attached a very simple project that can be used to demonstrate the
> behaviour: As long as the {{.mvn}} folder exists and the build cache
> extension is active, executing {{"mvn dependency:analyze"}} or {{"mvn
> dependency:3.5.0:analyze"}} don't work. Rename the folder => works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7772) Allow to register maven core extension in .m2 folder instead of MAVEN_HOME
[
https://issues.apache.org/jira/browse/MNG-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715596#comment-17715596
]
Roy Teeuwen commented on MNG-7772:
--
I'd want to see if I could contribute this, unless there is a good reason to
not allow this?
> Allow to register maven core extension in .m2 folder instead of MAVEN_HOME
> ---
>
> Key: MNG-7772
> URL: https://issues.apache.org/jira/browse/MNG-7772
> Project: Maven
> Issue Type: Improvement
>Reporter: Roy Teeuwen
>Priority: Major
>
> Currently the way to register a maven core extension is described here:
> [https://maven.apache.org/guides/mini/guide-using-extensions.html]
> Namely the following ways are supported:
> * Registered via extension jar in {{${maven.home}/lib/ext}}
> * Registered via CLI argument {{mvn -Dmaven.ext.class.path=extension.jar}}
> * Registered via [{{.mvn/extensions.xml}}
> file|https://maven.apache.org/configure.html#mvn-extensions-xml-file]
> The downside of this is that the ${maven.home} directory is not something
> that you should touch, seeing as with every update of maven (through for
> example homebrew), it will replace the directory with the new version, making
> it required to manually re-register the core extension by dragging the jar in
> /lib/ext.
> My proposal is to also make it possible to register the extension through the
> ${user.home}/.m2 folder. This could for example be by also allowing the
> extensions.xml in the .m2 folder or by creating an ext folder in the .m2
> folder.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7772) Allow to register maven core extension in .m2 folder instead of MAVEN_HOME
Roy Teeuwen created MNG-7772:
Summary: Allow to register maven core extension in .m2 folder
instead of MAVEN_HOME
Key: MNG-7772
URL: https://issues.apache.org/jira/browse/MNG-7772
Project: Maven
Issue Type: Improvement
Reporter: Roy Teeuwen
Currently the way to register a maven core extension is described here:
[https://maven.apache.org/guides/mini/guide-using-extensions.html]
Namely the following ways are supported:
* Registered via extension jar in {{${maven.home}/lib/ext}}
* Registered via CLI argument {{mvn -Dmaven.ext.class.path=extension.jar}}
* Registered via [{{.mvn/extensions.xml}}
file|https://maven.apache.org/configure.html#mvn-extensions-xml-file]
The downside of this is that the ${maven.home} directory is not something that
you should touch, seeing as with every update of maven (through for example
homebrew), it will replace the directory with the new version, making it
required to manually re-register the core extension by dragging the jar in
/lib/ext.
My proposal is to also make it possible to register the extension through the
${user.home}/.m2 folder. This could for example be by also allowing the
extensions.xml in the .m2 folder or by creating an ext folder in the .m2 folder.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-build-cache-extension] dependabot[bot] commented on pull request #68: Bump jcl-over-slf4j from 1.7.35 to 2.0.7
dependabot[bot] commented on PR #68: URL: https://github.com/apache/maven-build-cache-extension/pull/68#issuecomment-1519458199 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] olamy closed pull request #68: Bump jcl-over-slf4j from 1.7.35 to 2.0.7
olamy closed pull request #68: Bump jcl-over-slf4j from 1.7.35 to 2.0.7 URL: https://github.com/apache/maven-build-cache-extension/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] dependabot[bot] merged pull request #71: Bump logback-classic from 1.3.6 to 1.3.7
dependabot[bot] merged PR #71: URL: https://github.com/apache/maven-build-cache-extension/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] dependabot[bot] opened a new pull request, #135: Bump zstd-jni from 1.5.5-1 to 1.5.5-2
dependabot[bot] opened a new pull request, #135: URL: https://github.com/apache/maven-assembly-plugin/pull/135 Bumps [zstd-jni](https://github.com/luben/zstd-jni) from 1.5.5-1 to 1.5.5-2. Commits https://github.com/luben/zstd-jni/commit/4793b0b957e8833ef9680c83f08d29be2f88b66f";>4793b0b Bump version to 1.5.5-2 https://github.com/luben/zstd-jni/commit/e845db143760813a2af785dd1360688959eb304b";>e845db1 Added support for initialising a dict from a direct ByteBuffer. This avoid th... See full diff in https://github.com/luben/zstd-jni/compare/v1.5.5-1...v1.5.5-2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-site] dependabot[bot] commented on pull request #21: Bump maven-pdf-plugin from 1.5.1 to 1.6.1
dependabot[bot] commented on PR #21: URL: https://github.com/apache/maven-doxia-site/pull/21#issuecomment-1519182102 OK, I won't notify you about org.apache.maven.plugins:maven-pdf-plugin again, unless you re-open this PR. 😢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-site] slachiewicz commented on pull request #21: Bump maven-pdf-plugin from 1.5.1 to 1.6.1
slachiewicz commented on PR #21: URL: https://github.com/apache/maven-doxia-site/pull/21#issuecomment-1519182095 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-site] dependabot[bot] closed pull request #21: Bump maven-pdf-plugin from 1.5.1 to 1.6.1
dependabot[bot] closed pull request #21: Bump maven-pdf-plugin from 1.5.1 to 1.6.1 URL: https://github.com/apache/maven-doxia-site/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] slawekjaranowski commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
slawekjaranowski commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174634942
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+private void configureJarArchiver(
+JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+}
+
+archiver.setMinimalDefaultManifest(true);
Review Comment:
The same is in Maven Archiver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-assembly-plugin] slawekjaranowski commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
slawekjaranowski commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174634834
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+private void configureJarArchiver(
+JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+}
+
+archiver.setMinimalDefaultManifest(true);
+
+if (configuration != null) {
+archiver.setCompress(configuration.isCompress());
+archiver.setForced(configuration.isForced());
+archiver.setIndex(configuration.isIndex());
Review Comment:
Ok, I did it by the way - can be in separate issue 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7758:
Description:
Consider you have three repos defined in your build (could be POM or settings),
evaluated in following order:
1. repo A: serves custom artifacts with group id {{com.example}}, due to repo
partitioning in Nexus rejects requests to all other group ids with 403
1. repo B: serves third party artifacts without any restriction from a Nexus
repo
1. repo C: serves Central mirror, last one quried, no restrictions
Note that order is important! Now add a non-existing dependency to your POM
and receive the following behavior:
{{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three
exceptions:
- {{TransferException}} with nested {{AuthorizationException}},
- {{ArtifactNotFoundException}},
- {{ArtifactNotFoundException}}.
{{ArtifactResolutionException#getCause()}} will be populated with the
{{TransferException}} so will
{{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first
exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will do
{{if (e.getCause() instanceof ArtifactNotFoundException)}} which is deceiving.
Here is a sample for a non-existing artifact:
{noformat}
[INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @ mskins-222
---
[INFO] Configuring report plugin
org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
[WARNING] index report is declared twice in default reportSet
[INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2:
index, summary, dependency-info, modules, team, scm, issue-management,
mailing-lists, dependency-management, dependencies, dependency-convergence,
ci-management, plugin-management, plugins, distribution-management
[INFO] Rendering site for default locale
Downloading from lda-public:
https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3.214 s
[INFO] Finished at: 2023-04-02T12:51:02+02:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site
(default-site) on project mskins-222: SiteToolException: The site descriptor
cannot be resolved from the repository: Unable to locate site descriptor: Could
not transfer artifact org.apache:apache:xml:site:29 from/to lda-public
(https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/):
authorization failed for
https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
status: 403 Forbidden -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{noformat}
for a dependency:
{noformat}
[INFO] org.apache.maven.cli.event.ExecutionEventLogger -
[ERROR] org.apache.maven.cli.MavenCli - Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site
(default-site) on project mskins-222: Failed to get report for
org.apache.maven.plugins:maven-project-plugin: Plugin
org.apache.maven.plugins:maven-project-plugin:3.4.2 or one of its dependencies
could not be resolved: Failed to read artifact descriptor for
org.apache.maven.plugins:maven-project-plugin:jar:3.4.2: Could not transfer
artifact org.apache.maven.plugins:maven-project-plugin:pom:3.4.2 from/to
lda-public
(https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/):
authorization failed for
https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/maven/plugins/maven-project-plugin/3.4.2/maven-project-plugin-3.4.2.pom,
status: 403 Forbidden -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site
(default-site) on project mskins-222: Failed to get report for
org.apache.maven.plugins:maven-project-plugin
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:375)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:351)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder
[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715493#comment-17715493
]
ASF GitHub Bot commented on MNG-7758:
-
michael-o commented on PR #1095:
URL: https://github.com/apache/maven/pull/1095#issuecomment-1519114900
Here is a non-sense exception message since it uses only the the first
result and the first exception:
```
[ERROR] Failed to execute goal on project service-controller: Could not
resolve dependencies for project
com.siemens.lda.cafe:service-controller:jar:2.5-SNAPSHOT: The following
artifacts could not be resolved: org.awaitility1:awaitility1:jar:3.1.6
(absent), com.siemens.lda.cafe:lda-cafe-module-dd-schema1:jar:1.0.0 (absent):
Could not transfer artifact org.awaitility1:awaitility1:jar:3.1.6 from/to
lda-public
(https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/):
status code: 403, reason phrase: Forbidden (403) -> [Help 1]
```
`awaitility1` cannot be searched in `lda-public`, but for
`da-cafe-module-dd-schema1` nothing is said because in all repos it gives 404.
The message is simply misleading.
> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your POM
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three
> exceptions:
> - {{TransferException}} with nested {{AuthorizationException}},
> - {{ArtifactNotFoundException}},
> - {{ArtifactNotFoundException}}.
> {{ArtifactResolutionException#getCause()}} will be populated with the
> {{TransferException}} so will
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @
> mskins-222 ---
> [INFO] Configuring report plugin
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2:
> index, summary, dependency-info, modules, team, scm, issue-management,
> mailing-lists, dependency-management, dependencies, dependency-convergence,
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public:
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site
> (default-site) on project mskins-222: SiteToolException: The site descriptor
> cannot be resolved from the repository: Unable to locate site descriptor:
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/):
> authorization failed for
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
> status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible
[GitHub] [maven] michael-o commented on pull request #1095: MNG-7758 workaround
michael-o commented on PR #1095: URL: https://github.com/apache/maven/pull/1095#issuecomment-1519114900 Here is a non-sense exception message since it uses only the the first result and the first exception: ``` [ERROR] Failed to execute goal on project service-controller: Could not resolve dependencies for project com.siemens.lda.cafe:service-controller:jar:2.5-SNAPSHOT: The following artifacts could not be resolved: org.awaitility1:awaitility1:jar:3.1.6 (absent), com.siemens.lda.cafe:lda-cafe-module-dd-schema1:jar:1.0.0 (absent): Could not transfer artifact org.awaitility1:awaitility1:jar:3.1.6 from/to lda-public (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): status code: 403, reason phrase: Forbidden (403) -> [Help 1] ``` `awaitility1` cannot be searched in `lda-public`, but for `da-cafe-module-dd-schema1` nothing is said because in all repos it gives 404. The message is simply misleading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-534) Broken command line generated on Java 8 when maven.compiler.release is set
[
https://issues.apache.org/jira/browse/MCOMPILER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715488#comment-17715488
]
Michael Osipov commented on MCOMPILER-534:
--
[~ggregory], you can introduce a {{javaVersion}} property just like we do with
Maven parent and use that value everywhere. For release, in the profile only of
course. No need to fiddle with the plugin, it should pick it up automatically.
Give it a try.
> Broken command line generated on Java 8 when maven.compiler.release is set
> --
>
> Key: MCOMPILER-534
> URL: https://issues.apache.org/jira/browse/MCOMPILER-534
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Apache Maven 3.9.1
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: /usr/local/Cellar/maven/3.9.1/libexec
> Java version: 1.8.0_362, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@8/1.8.0+362/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.3.1", arch: "x86_64", family: "mac"
> Darwin 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST
> 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
>Reporter: Gary D. Gregory
>Priority: Major
>
> Apache Commons Parent 57 RC1
> (https://lists.apache.org/thread/rwgf9c7dgl2bymq3jg6ckxs6gk9pz4mg) attempts
> to use the javac release flag only on Java 9 and above with
> {code:xml}
> 8
> {code}
> and
> {code:xml}
>
> jdk9-compiler
>
> [9
>
>
>
>
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> ${maven.compiler.release}
>
>
>
>
>
>
> {code}
> This fails miserably:
> {noformat}
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 5.402 s
> [INFO] Finished at: 2023-04-23T09:23:21-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile
> (default-compile) on project commons-lang3: Fatal error compiling: invalid
> flag: --release -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> IMO, setting a property "maven.compiler.release" should not be used on
> compilers that do not support the flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MCOMPILER-534) Broken command line generated on Java 8 when maven.compiler.release is set
[
https://issues.apache.org/jira/browse/MCOMPILER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715479#comment-17715479
]
Michael Osipov edited comment on MCOMPILER-534 at 4/23/23 4:08 PM:
---
We know the supplied configuration is incorrect for conditional setting of the
property. The property is for targeting Java 8 when building with a later JDK.
But you do not have to set the property if you are building with JDK 8. If you
do then you receive the described error.
Perhaps the conditional inclusion of the property (for JDK 9+) can be added to
the example on the maven-compiler-plugin documentation:
[Setting the --release of the Java
Compiler|https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html]
was (Author: alexherbert):
We know the supplied configuration is incorrect for conditional setting of the
property. The property is for targeting Java 8 when building with a later JDK.
But you do not have to set the property if you are building with JDK 8. If you
do then you receive the described error.
Perhaps the conditional inclusion of the property (for JDK 9+) can be added to
the example on the maven-compiler-plugin documentation:
[Setting the --release of the Java
Compiler|https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html]
> Broken command line generated on Java 8 when maven.compiler.release is set
> --
>
> Key: MCOMPILER-534
> URL: https://issues.apache.org/jira/browse/MCOMPILER-534
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Apache Maven 3.9.1
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: /usr/local/Cellar/maven/3.9.1/libexec
> Java version: 1.8.0_362, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@8/1.8.0+362/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.3.1", arch: "x86_64", family: "mac"
> Darwin 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST
> 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
>Reporter: Gary D. Gregory
>Priority: Major
>
> Apache Commons Parent 57 RC1
> (https://lists.apache.org/thread/rwgf9c7dgl2bymq3jg6ckxs6gk9pz4mg) attempts
> to use the javac release flag only on Java 9 and above with
> {code:xml}
> 8
> {code}
> and
> {code:xml}
>
> jdk9-compiler
>
> [9
>
>
>
>
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> ${maven.compiler.release}
>
>
>
>
>
>
> {code}
> This fails miserably:
> {noformat}
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 5.402 s
> [INFO] Finished at: 2023-04-23T09:23:21-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile
> (default-compile) on project commons-lang3: Fatal error compiling: invalid
> flag: --release -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> IMO, setting a property "maven.compiler.release" should not be used on
> compilers that do not support the flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715485#comment-17715485
]
ASF GitHub Bot commented on MNG-7758:
-
michael-o commented on PR #1095:
URL: https://github.com/apache/maven/pull/1095#issuecomment-1519098927
Something isn't right:
before:
```
$ mvn clean validate -U
[INFO] Scanning for projects...
[INFO]
[INFO] --< com.siemens.lda.cafe:service-controller
>---
[INFO] Building service-controller 2.5-SNAPSHOT
[INFO] from pom.xml
[INFO] [ jar
]-
Downloading from lda-public:
https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom
Downloading from dynamowerk-public:
https://deblndw011x.ad001.siemens.net/nexus/content/groups/dynamowerk-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom
Downloading from central-mirror:
https://deblndw011x.ad001.siemens.net/nexus/content/repositories/central/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 2.480 s
[INFO] Finished at: 2023-04-23T17:56:46+02:00
[INFO]
[ERROR] Failed to execute goal on project service-controller: Could not
resolve dependencies for project
com.siemens.lda.cafe:service-controller:jar:2.5-SNAPSHOT: Failed to collect
dependencies at org.awaitility1:awaitility1:jar:3.1.6: Failed to read artifact
descriptor for org.awaitility1:awaitility1:jar:3.1.6: Could not transfer
artifact org.awaitility1:awaitility1:pom:3.1.6 from/to lda-public
(https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/):
authorization failed for
https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom,
status: 403 Forbidden -> [Help 1]
```
after:
```
$ /tmp/apache-maven-4.0.0-alpha-6-SNAPSHOT/bin/mvn clean validate -U
[INFO] Scanning for projects...
[INFO]
[INFO] ---<
com.siemens.lda.cafe:service-controller
>
[INFO] Building service-controller 2.5-SNAPSHOT
[INFO] from pom.xml
[INFO] -[ jar
]--
Downloading from lda-public:
https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom
Downloading from dynamowerk-public:
https://deblndw011x.ad001.siemens.net/nexus/content/groups/dynamowerk-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom
Downloading from central-mirror:
https://deblndw011x.ad001.siemens.net/nexus/content/repositories/central/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom
[WARNING] The POM for org.awaitility1:awaitility1:jar:3.1.6 is missing, no
dependency information available
[INFO]
[INFO] -
> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your POM
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three
> exceptions:
> - {{TransferException}} with nested {{AuthorizationException}},
> - {{ArtifactNotFoundException}},
> - {{ArtifactNotFoundException}}.
> {{ArtifactResolutionException#getCause()}} will be populated with the
> {{TransferException}} so will
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first
> exception only into
[GitHub] [maven] michael-o commented on pull request #1095: MNG-7758 workaround
michael-o commented on PR #1095: URL: https://github.com/apache/maven/pull/1095#issuecomment-1519098927 Something isn't right: before: ``` $ mvn clean validate -U [INFO] Scanning for projects... [INFO] [INFO] --< com.siemens.lda.cafe:service-controller >--- [INFO] Building service-controller 2.5-SNAPSHOT [INFO] from pom.xml [INFO] [ jar ]- Downloading from lda-public: https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom Downloading from dynamowerk-public: https://deblndw011x.ad001.siemens.net/nexus/content/groups/dynamowerk-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom Downloading from central-mirror: https://deblndw011x.ad001.siemens.net/nexus/content/repositories/central/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 2.480 s [INFO] Finished at: 2023-04-23T17:56:46+02:00 [INFO] [ERROR] Failed to execute goal on project service-controller: Could not resolve dependencies for project com.siemens.lda.cafe:service-controller:jar:2.5-SNAPSHOT: Failed to collect dependencies at org.awaitility1:awaitility1:jar:3.1.6: Failed to read artifact descriptor for org.awaitility1:awaitility1:jar:3.1.6: Could not transfer artifact org.awaitility1:awaitility1:pom:3.1.6 from/to lda-public (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): authorization failed for https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom, status: 403 Forbidden -> [Help 1] ``` after: ``` $ /tmp/apache-maven-4.0.0-alpha-6-SNAPSHOT/bin/mvn clean validate -U [INFO] Scanning for projects... [INFO] [INFO] ---< com.siemens.lda.cafe:service-controller > [INFO] Building service-controller 2.5-SNAPSHOT [INFO] from pom.xml [INFO] -[ jar ]-- Downloading from lda-public: https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom Downloading from dynamowerk-public: https://deblndw011x.ad001.siemens.net/nexus/content/groups/dynamowerk-public/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom Downloading from central-mirror: https://deblndw011x.ad001.siemens.net/nexus/content/repositories/central/org/awaitility1/awaitility1/3.1.6/awaitility1-3.1.6.pom [WARNING] The POM for org.awaitility1:awaitility1:jar:3.1.6 is missing, no dependency information available [INFO] [INFO] --- clean:3.2.0:clean (default-clean) @ service-controller --- [INFO] Deleting /var/osipovmi/Projekte/lda-cafe/backend-services/service-controller/target [INFO] [INFO] --- enforcer:3.1.0:enforce (enforce-maven) @ service-controller --- [INFO] -- [INFO] BUILD SUCCESS [INFO] -- [INFO] Total time: 3.664 s [INFO] Finished at: 2023-04-23T17:57:03+02:00 [INFO] -- ``` Will debug... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-534) Broken command line generated on Java 8 when maven.compiler.release is set
[
https://issues.apache.org/jira/browse/MCOMPILER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715481#comment-17715481
]
Michael Osipov commented on MCOMPILER-534:
--
PR for doc improvements welcome!
> Broken command line generated on Java 8 when maven.compiler.release is set
> --
>
> Key: MCOMPILER-534
> URL: https://issues.apache.org/jira/browse/MCOMPILER-534
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Apache Maven 3.9.1
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: /usr/local/Cellar/maven/3.9.1/libexec
> Java version: 1.8.0_362, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@8/1.8.0+362/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.3.1", arch: "x86_64", family: "mac"
> Darwin 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST
> 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
>Reporter: Gary D. Gregory
>Priority: Major
>
> Apache Commons Parent 57 RC1
> (https://lists.apache.org/thread/rwgf9c7dgl2bymq3jg6ckxs6gk9pz4mg) attempts
> to use the javac release flag only on Java 9 and above with
> {code:xml}
> 8
> {code}
> and
> {code:xml}
>
> jdk9-compiler
>
> [9
>
>
>
>
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> ${maven.compiler.release}
>
>
>
>
>
>
> {code}
> This fails miserably:
> {noformat}
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 5.402 s
> [INFO] Finished at: 2023-04-23T09:23:21-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile
> (default-compile) on project commons-lang3: Fatal error compiling: invalid
> flag: --release -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> IMO, setting a property "maven.compiler.release" should not be used on
> compilers that do not support the flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-534) Broken command line generated on Java 8 when maven.compiler.release is set
[
https://issues.apache.org/jira/browse/MCOMPILER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715479#comment-17715479
]
Alex Herbert commented on MCOMPILER-534:
We know the supplied configuration is incorrect for conditional setting of the
property. The property is for targeting Java 8 when building with a later JDK.
But you do not have to set the property if you are building with JDK 8. If you
do then you receive the described error.
Perhaps the conditional inclusion of the property (for JDK 9+) can be added to
the example on the maven-compiler-plugin documentation:
[Setting the --release of the Java
Compiler|https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html]
> Broken command line generated on Java 8 when maven.compiler.release is set
> --
>
> Key: MCOMPILER-534
> URL: https://issues.apache.org/jira/browse/MCOMPILER-534
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Apache Maven 3.9.1
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: /usr/local/Cellar/maven/3.9.1/libexec
> Java version: 1.8.0_362, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@8/1.8.0+362/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.3.1", arch: "x86_64", family: "mac"
> Darwin 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST
> 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
>Reporter: Gary D. Gregory
>Priority: Major
>
> Apache Commons Parent 57 RC1
> (https://lists.apache.org/thread/rwgf9c7dgl2bymq3jg6ckxs6gk9pz4mg) attempts
> to use the javac release flag only on Java 9 and above with
> {code:xml}
> 8
> {code}
> and
> {code:xml}
>
> jdk9-compiler
>
> [9
>
>
>
>
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> ${maven.compiler.release}
>
>
>
>
>
>
> {code}
> This fails miserably:
> {noformat}
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 5.402 s
> [INFO] Finished at: 2023-04-23T09:23:21-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile
> (default-compile) on project commons-lang3: Fatal error compiling: invalid
> flag: --release -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> IMO, setting a property "maven.compiler.release" should not be used on
> compilers that do not support the flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MCOMPILER-534) Broken command line generated on Java 8 when maven.compiler.release is set
[
https://issues.apache.org/jira/browse/MCOMPILER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715478#comment-17715478
]
Michael Osipov edited comment on MCOMPILER-534 at 4/23/23 3:27 PM:
---
You can't do this. You profile is moot since you have set the property already
globally. It is passed directly to the plugin. Either set the property within
the profile or set a literal value.
was (Author: michael-o):
You can't do this. You provide is moot since you have set the property already
globally. It is passed directly to the plugin. Either set the property within
the profile or set a literal value.
> Broken command line generated on Java 8 when maven.compiler.release is set
> --
>
> Key: MCOMPILER-534
> URL: https://issues.apache.org/jira/browse/MCOMPILER-534
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Apache Maven 3.9.1
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: /usr/local/Cellar/maven/3.9.1/libexec
> Java version: 1.8.0_362, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@8/1.8.0+362/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.3.1", arch: "x86_64", family: "mac"
> Darwin 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST
> 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
>Reporter: Gary D. Gregory
>Priority: Major
>
> Apache Commons Parent 57 RC1
> (https://lists.apache.org/thread/rwgf9c7dgl2bymq3jg6ckxs6gk9pz4mg) attempts
> to use the javac release flag only on Java 9 and above with
> {code:xml}
> 8
> {code}
> and
> {code:xml}
>
> jdk9-compiler
>
> [9
>
>
>
>
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> ${maven.compiler.release}
>
>
>
>
>
>
> {code}
> This fails miserably:
> {noformat}
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 5.402 s
> [INFO] Finished at: 2023-04-23T09:23:21-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile
> (default-compile) on project commons-lang3: Fatal error compiling: invalid
> flag: --release -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> IMO, setting a property "maven.compiler.release" should not be used on
> compilers that do not support the flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-534) Broken command line generated on Java 8 when maven.compiler.release is set
[
https://issues.apache.org/jira/browse/MCOMPILER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715478#comment-17715478
]
Michael Osipov commented on MCOMPILER-534:
--
You can't do this. You provide is moot since you have set the property already
globally. It is passed directly to the plugin. Either set the property within
the profile or set a literal value.
> Broken command line generated on Java 8 when maven.compiler.release is set
> --
>
> Key: MCOMPILER-534
> URL: https://issues.apache.org/jira/browse/MCOMPILER-534
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Apache Maven 3.9.1
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: /usr/local/Cellar/maven/3.9.1/libexec
> Java version: 1.8.0_362, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@8/1.8.0+362/libexec/openjdk.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.3.1", arch: "x86_64", family: "mac"
> Darwin 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST
> 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
>Reporter: Gary D. Gregory
>Priority: Major
>
> Apache Commons Parent 57 RC1
> (https://lists.apache.org/thread/rwgf9c7dgl2bymq3jg6ckxs6gk9pz4mg) attempts
> to use the javac release flag only on Java 9 and above with
> {code:xml}
> 8
> {code}
> and
> {code:xml}
>
> jdk9-compiler
>
> [9
>
>
>
>
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> ${maven.compiler.release}
>
>
>
>
>
>
> {code}
> This fails miserably:
> {noformat}
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 5.402 s
> [INFO] Finished at: 2023-04-23T09:23:21-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile
> (default-compile) on project commons-lang3: Fatal error compiling: invalid
> flag: --release -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> IMO, setting a property "maven.compiler.release" should not be used on
> compilers that do not support the flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSITE-960) CI is broken
[ https://issues.apache.org/jira/browse/MSITE-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715477#comment-17715477 ] Michael Osipov commented on MSITE-960: -- Well, this is because someone has upgrade stuff w/o even testing it. I would recommend to downgrade MSITE to 3.12.1 and Fluido Skin to 1.11.2. > CI is broken > > > Key: MSITE-960 > URL: https://issues.apache.org/jira/browse/MSITE-960 > Project: Maven Site Plugin > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Priority: Blocker > > Error: Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on > project maven-site-plugin: RendererException while preparing context for > skin: Cannot use skin: has 2.0.0-M5 Doxia Sitetools prerequisite, but current > is 1.11.1 -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6732) DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException
[
https://issues.apache.org/jira/browse/MNG-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715476#comment-17715476
]
Michael Osipov commented on MNG-6732:
-
[~sjaranowski], this is related to the issue where the
{{ArtifactNotFoundException}} is deceiving.
> DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon
> ArtifactTransferException
> -
>
> Key: MNG-6732
> URL: https://issues.apache.org/jira/browse/MNG-6732
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.6.1
>Reporter: Tomo Suzuki
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Attachments: 62884438-89260580-bd04-11e9-8c4a-897d4b736dc7.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> h1. Problem
> Sometimes [Linkage Checker enforcer
> rule|https://github.com/GoogleCloudPlatform/cloud-opensource-java/tree/master/enforcer-rules]
> does not receive resolved artifact list because of a missing artifact even
> when the missing artifact is unused after Maven's dependency mediation.
> h1. Background
> The enforcer rule fails to retrieve artifact list through
> {{DefaultProjectDependenciesResolver.resolve}} when applied to
> [grpc-java-by-example/chat-example/chat-vaadin-client|https://github.com/saturnism/grpc-java-by-example/tree/master/chat-example/chat-vaadin-client]
> because of the missing {{xerces:xerces-impl:2.6.2}}, even though the
> artifact does not appear in the final dependency graph. The artifact does not
> appear in the graph because of Maven's dependency mediation.
> Artifact xerces:xerces-impl:2.6.2 is not published in Maven Central.
> In contrast, the enforcer rule can retrieve artifact list when applied to
> [https://github.com/suztomo/spring-cloud-gcp/tree/v1.1.2-linkage-checker]
> project even though it outputs "[WARNING] The POM for
> xerces:xerces-impl:jar:2.6.2 is missing, no dependency information
> available". The missing artifact does not appear in final dependency graph.
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/834]
> h1. Diagnosis
> Currently {{DefaultArtifactDescriptorReader.loadPom}} method checks
> "ArtifactDescriptorPolicy.IGNORE_MISSING" policy upon
> ArtifactNotFoundException. This allows
> {{DefaultProjectDependenciesResolver.resolve}} calls
> {{repoSystem.resolveDependencies}} to obtain partially resolved artifact
> list, rather than failing entirely, when there is a missing artifact (such as
> {{xerces:xerces-impl:2.6.2}})
> However, when a retired Maven repository is involved (such as
> [http://repository.codehaus.org/] ),
> {{DefaultArtifactDescriptorReader.loadPom}} gets an ArtifactTransferException
> and throws ArtifactDescriptorException without checking
> "ArtifactDescriptorPolicy.IGNORE_MISSING" policy (excerpt below), and thus
> {{DefaultProjectDependenciesResolver.resolve}} does not return partially
> resolved artifact list.
> {code:java}
> catch ( ArtifactResolutionException e )
> {
> if ( e.getCause() instanceof ArtifactNotFoundException )
> {
> missingDescriptor( session, trace, a, (Exception)
> e.getCause() );
> if ( ( getPolicy( session, a, request ) &
> ArtifactDescriptorPolicy.IGNORE_MISSING ) != 0 )
> {
> return null;
> }
> }
> result.addException( e );
> throw new ArtifactDescriptorException( result );
> }
> {code}
> from
> [DefaultArtifactDescriptorReader.java|https://github.com/apache/maven/blob/d3ace78/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java#L255]
> ArtifactNotFoundException is a special case of
> [ArtifactTransferException|https://maven.apache.org/resolver/apidocs/org/eclipse/aether/transfer/ArtifactTransferException.html].
> h1. Example Project
> Example project to demonstrate the diagnosis:
> [https://github.com/suztomo/maven-missing-artifact] . In this example, even
> though module-b and module-c have the same dependency section, module-c fails
> to run Maven because of a repository section containing a retired repository
> URL.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-assembly-plugin] michael-o commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
michael-o commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174598030
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+private void configureJarArchiver(
+JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+}
+
+archiver.setMinimalDefaultManifest(true);
+
+if (configuration != null) {
+archiver.setCompress(configuration.isCompress());
+archiver.setForced(configuration.isForced());
+archiver.setIndex(configuration.isIndex());
Review Comment:
But these aren't related to this change, no? I am still searching for the
connection between the issue title and this hunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-assembly-plugin] slawekjaranowski commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
slawekjaranowski commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174597747
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -293,10 +294,7 @@ protected Archiver createArchiver(
final List extraSelectors = new ArrayList<>();
final List extraFinalizers = new ArrayList<>();
if (archiver instanceof JarArchiver) {
-if (mergeManifestMode != null) {
-((JarArchiver) archiver)
-
.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
-}
+configureJarArchiver((JarArchiver) archiver, mergeManifestMode,
configSource.getJarArchiveConfiguration());
Review Comment:
yes - currently ear, rar, war
https://codehaus-plexus.github.io/plexus-archiver/apidocs/org/codehaus/plexus/archiver/jar/JarArchiver.html
I would like to extends another types, eg for car we only have a UnArchiver
https://codehaus-plexus.github.io/plexus-archiver/apidocs/org/codehaus/plexus/archiver/car/package-summary.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-assembly-plugin] slawekjaranowski commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
slawekjaranowski commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174596978
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+private void configureJarArchiver(
+JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+}
+
+archiver.setMinimalDefaultManifest(true);
+
+if (configuration != null) {
+archiver.setCompress(configuration.isCompress());
+archiver.setForced(configuration.isForced());
+archiver.setIndex(configuration.isIndex());
Review Comment:
It comes from
https://github.com/apache/maven-archiver/blob/master/src/main/java/org/apache/maven/archiver/MavenArchiver.java#L576-L593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
michael-o commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174596894
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+private void configureJarArchiver(
+JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+}
+
+archiver.setMinimalDefaultManifest(true);
Review Comment:
So this leaves the user no option to include it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-assembly-plugin] slawekjaranowski commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
slawekjaranowski commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174596627
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+private void configureJarArchiver(
+JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+}
+
+archiver.setMinimalDefaultManifest(true);
Review Comment:
yes - exactly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
michael-o commented on PR #134: URL: https://github.com/apache/maven-assembly-plugin/pull/134#issuecomment-1519086649 I am still not fully conviced here. For me the gain is questionable or I don't understand it completely. I'd like to hear @hboutemy's opinion on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
michael-o commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174595764
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+private void configureJarArchiver(
+JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+}
+
+archiver.setMinimalDefaultManifest(true);
Review Comment:
This will set it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
michael-o commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174595729
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+private void configureJarArchiver(
+JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+}
+
+archiver.setMinimalDefaultManifest(true);
+
+if (configuration != null) {
+archiver.setCompress(configuration.isCompress());
+archiver.setForced(configuration.isForced());
+archiver.setIndex(configuration.isIndex());
Review Comment:
I am confused, where do these come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
michael-o commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174595582
##
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##
@@ -293,10 +294,7 @@ protected Archiver createArchiver(
final List extraSelectors = new ArrayList<>();
final List extraFinalizers = new ArrayList<>();
if (archiver instanceof JarArchiver) {
-if (mergeManifestMode != null) {
-((JarArchiver) archiver)
-
.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
-}
+configureJarArchiver((JarArchiver) archiver, mergeManifestMode,
configSource.getJarArchiveConfiguration());
Review Comment:
I would expect that this applies to all JAR derived formats? WAR, EAR, CAR,
etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-wagon] michael-o commented on pull request #89: [WAGON-632] Java 8
michael-o commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1519085528 For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WAGON-625) Upgrade To commons-io 2.11.0
[ https://issues.apache.org/jira/browse/WAGON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715472#comment-17715472 ] Michael Osipov commented on WAGON-625: -- this issue is basically academic: !screenshot-1.png! The FTP Wagon will be removed in the next major version. Don't waste your time for this. > Upgrade To commons-io 2.11.0 > > > Key: WAGON-625 > URL: https://issues.apache.org/jira/browse/WAGON-625 > Project: Maven Wagon > Issue Type: Dependency upgrade >Affects Versions: 3.5.1 >Reporter: Ryan Baxter >Priority: Major > Attachments: screenshot-1.png > > > commons-io 2.6 is effected by CVE-2021-29425 which is addressed in 2.7 > https://nvd.nist.gov/vuln/detail/CVE-2021-29425 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (WAGON-625) Upgrade To commons-io 2.11.0
[ https://issues.apache.org/jira/browse/WAGON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated WAGON-625: - Attachment: screenshot-1.png > Upgrade To commons-io 2.11.0 > > > Key: WAGON-625 > URL: https://issues.apache.org/jira/browse/WAGON-625 > Project: Maven Wagon > Issue Type: Dependency upgrade >Affects Versions: 3.5.1 >Reporter: Ryan Baxter >Priority: Major > Attachments: screenshot-1.png > > > commons-io 2.6 is effected by CVE-2021-29425 which is addressed in 2.7 > https://nvd.nist.gov/vuln/detail/CVE-2021-29425 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WAGON-625) Upgrade To commons-io 2.11.0
[ https://issues.apache.org/jira/browse/WAGON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715471#comment-17715471 ] Michael Osipov commented on WAGON-625: -- Because only 4 will move to Java 8. > Upgrade To commons-io 2.11.0 > > > Key: WAGON-625 > URL: https://issues.apache.org/jira/browse/WAGON-625 > Project: Maven Wagon > Issue Type: Dependency upgrade >Affects Versions: 3.5.1 >Reporter: Ryan Baxter >Priority: Major > > commons-io 2.6 is effected by CVE-2021-29425 which is addressed in 2.7 > https://nvd.nist.gov/vuln/detail/CVE-2021-29425 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x
[
https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715470#comment-17715470
]
ASF GitHub Bot commented on MNGSITE-393:
michael-o commented on code in PR #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r1174593983
##
content/apt/guides/mini/guide-http-settings.apt:
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
Review Comment:
This entire guide needs a review :-(
> Remove references to Maven 2.x
> --
>
> Key: MNGSITE-393
> URL: https://issues.apache.org/jira/browse/MNGSITE-393
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Maven 3.x is over a decade old now and we're talking about Maven 4. It's time
> to clean out all the random discussion here and there about how Maven 2.x did
> things, differences between Maven 2 and 3, what works in Maven 3 but not 2,
> etc.
> Assume Maven 3.0 as the minimum, probably Maven 3.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] michael-o commented on a diff in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info
michael-o commented on code in PR #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r1174593983
##
content/apt/guides/mini/guide-http-settings.apt:
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
Review Comment:
This entire guide needs a review :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] michael-o commented on a diff in pull request #191: docs: system dependencies are not always available
michael-o commented on code in PR #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r1174593816 ## content/apt/guides/introduction/introduction-to-dependency-mechanism.apt: ## @@ -826,12 +826,14 @@ Introduction to the Dependency Mechanism <<>> - Dependencies with the scope are always available and are not looked - up in repository. They are usually used to tell Maven about dependencies which - are provided by the JDK or the VM. Thus, system dependencies are especially - useful for resolving dependencies on artifacts which are now provided by the - JDK, but were available as separate downloads earlier. Typical examples are - the JDBC standard extensions or the Java Authentication and Authorization + Dependencies with the scope are not looked up in the Maven repository system. + Instead the `dependency` element contains a `systemPath` pointing to a jar on the local + file system. + + The system scope is commonly used to tell Maven about dependencies provided by the JDK or the VM. + System dependencies are especially useful for resolving dependencies on artifacts which + are now provided by the JDK, but were available as separate downloads earlier. Typical + examples are the JDBC standard extensions or the Java Authentication and Authorization Review Comment: My example was just have a custom JAR which you distribute across your company. That's it. My proposal is to simply remove all examples regarding `system` and provide an abstract description/definition of this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (WAGON-625) Upgrade To commons-io 2.11.0
[ https://issues.apache.org/jira/browse/WAGON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated WAGON-625: Summary: Upgrade To commons-io 2.11.0 (was: Upgrade To commons-io 2.7) > Upgrade To commons-io 2.11.0 > > > Key: WAGON-625 > URL: https://issues.apache.org/jira/browse/WAGON-625 > Project: Maven Wagon > Issue Type: Dependency upgrade >Affects Versions: 3.5.1 >Reporter: Ryan Baxter >Priority: Major > > commons-io 2.6 is effected by CVE-2021-29425 which is addressed in 2.7 > https://nvd.nist.gov/vuln/detail/CVE-2021-29425 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WAGON-625) Upgrade To commons-io 2.7
[ https://issues.apache.org/jira/browse/WAGON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715462#comment-17715462 ] Elliotte Rusty Harold commented on WAGON-625: - Why will Wagon 3.x remain on Java 7? Everything else is moving to Java 8. > Upgrade To commons-io 2.7 > - > > Key: WAGON-625 > URL: https://issues.apache.org/jira/browse/WAGON-625 > Project: Maven Wagon > Issue Type: Dependency upgrade >Affects Versions: 3.5.1 >Reporter: Ryan Baxter >Priority: Major > > commons-io 2.6 is effected by CVE-2021-29425 which is addressed in 2.7 > https://nvd.nist.gov/vuln/detail/CVE-2021-29425 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (WAGON-632) Java 8 minimum
Elliotte Rusty Harold created WAGON-632: --- Summary: Java 8 minimum Key: WAGON-632 URL: https://issues.apache.org/jira/browse/WAGON-632 Project: Maven Wagon Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold Mostly so we can get a recent version of commons IO to replace bugs in Plexus utils -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-doxia-site] elharo commented on pull request #28: Try to unbreak CI
elharo commented on PR #28:
URL: https://github.com/apache/maven-doxia-site/pull/28#issuecomment-1519071232
This is the PLexus code so I'm betting it's dying on a symlink:
```
if ( file.isFile() )
{
destination = destination.getParentFile();
if ( onlyModifiedFiles )
{
copyFileToDirectoryIfModified( file, destination );
}
else
{
copyFileToDirectory( file, destination );
}
}
else if ( file.isDirectory() )
{
if ( !destination.exists() && !destination.mkdirs() )
{
throw new IOException( "Could not create destination
directory '" + destination.getAbsolutePath()
+ "'." );
}
copyDirectoryStructure( file, destination,
rootDestinationDirectory, onlyModifiedFiles );
}
else
{
throw new IOException( "Unknown file type: " +
file.getAbsolutePath() );
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-doxia-site] elharo commented on pull request #28: Try to unbreak CI
elharo commented on PR #28: URL: https://github.com/apache/maven-doxia-site/pull/28#issuecomment-1519070910 Caused by: java.io.IOException: Unknown file type: /home/runner/work/maven-doxia-site/maven-doxia-site/target/site/doxia at org.codehaus.plexus.util.FileUtils.copyDirectoryStructure (FileUtils.java:2088) at org.codehaus.plexus.util.FileUtils.copyDirectoryStructure (FileUtils.java:1999) at org.apache.maven.wagon.providers.file.FileWagon.putDirectory (FileWagon.java:193) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-site] elharo commented on pull request #28: Try to unbreak CI
elharo commented on PR #28:
URL: https://github.com/apache/maven-doxia-site/pull/28#issuecomment-1519070762
problem could be here in FileWagon:
try
{
FileUtils.copyDirectoryStructure( sourceDirectory, path );
}
catch ( IOException e )
{
throw new TransferFailedException( "Error copying directory
structure", e );
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MCOMPILER-534) Broken command line generated on Java 8 when maven.compiler.release is set
Gary D. Gregory created MCOMPILER-534:
-
Summary: Broken command line generated on Java 8 when
maven.compiler.release is set
Key: MCOMPILER-534
URL: https://issues.apache.org/jira/browse/MCOMPILER-534
Project: Maven Compiler Plugin
Issue Type: Bug
Affects Versions: 3.11.0
Environment: Apache Maven 3.9.1
(2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
Maven home: /usr/local/Cellar/maven/3.9.1/libexec
Java version: 1.8.0_362, vendor: Homebrew, runtime:
/usr/local/Cellar/openjdk@8/1.8.0+362/libexec/openjdk.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "13.3.1", arch: "x86_64", family: "mac"
Darwin 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST 2023;
root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
Reporter: Gary D. Gregory
Apache Commons Parent 57 RC1
(https://lists.apache.org/thread/rwgf9c7dgl2bymq3jg6ckxs6gk9pz4mg) attempts to
use the javac release flag only on Java 9 and above with
{code:xml}
8
{code}
and
{code:xml}
jdk9-compiler
[9
org.apache.maven.plugins
maven-compiler-plugin
${maven.compiler.release}
{code}
This fails miserably:
{noformat}
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 5.402 s
[INFO] Finished at: 2023-04-23T09:23:21-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile)
on project commons-lang3: Fatal error compiling: invalid flag: --release ->
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{noformat}
IMO, setting a property "maven.compiler.release" should not be used on
compilers that do not support the flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MSITE-960) CI is broken
Elliotte Rusty Harold created MSITE-960: --- Summary: CI is broken Key: MSITE-960 URL: https://issues.apache.org/jira/browse/MSITE-960 Project: Maven Site Plugin Issue Type: Bug Reporter: Elliotte Rusty Harold Error: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project maven-site-plugin: RendererException while preparing context for skin: Cannot use skin: has 2.0.0-M5 Doxia Sitetools prerequisite, but current is 1.11.1 -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-doxia-site] elharo commented on pull request #28: Try to unbreak CI
elharo commented on PR #28: URL: https://github.com/apache/maven-doxia-site/pull/28#issuecomment-1519063541 Possible this is an issue with symlink handling in the site plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site-plugin] elharo opened a new pull request, #145: Remove old URLs and Maven versions
elharo opened a new pull request, #145: URL: https://github.com/apache/maven-site-plugin/pull/145 and omit needless words -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #412: spotless fix
elharo commented on code in PR #412: URL: https://github.com/apache/maven-site/pull/412#discussion_r1174569591 ## pom.xml: ## @@ -55,7 +55,8 @@ maven-site -x +x + Review Comment: I'm not sure what you mean. In any case, this is exactly how spotless changed the existing file, nothing else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] elharo merged pull request #412: spotless fix
elharo merged PR #412: URL: https://github.com/apache/maven-site/pull/412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715452#comment-17715452
]
ASF GitHub Bot commented on MBUILDCACHE-56:
---
olamy opened a new pull request, #73:
URL: https://github.com/apache/maven-build-cache-extension/pull/73
Signed-off-by: Olivier Lamy
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [MBUILDCACHE JIRA
issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMeth
[jira] [Updated] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated MBUILDCACHE-56:
--
Labels: pull-request-available (was: )
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-build-cache-extension] olamy opened a new pull request, #73: [MBUILDCACHE-56] fix NPE when mojo does not a have field with same name as parameter
olamy opened a new pull request, #73: URL: https://github.com/apache/maven-build-cache-extension/pull/73 Signed-off-by: Olivier Lamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [MBUILDCACHE JIRA issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-site] elharo commented on pull request #28: Try to unbreak CI
elharo commented on PR #28: URL: https://github.com/apache/maven-doxia-site/pull/28#issuecomment-1519046281 and the next one: ``` Error: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:stage (default-cli) on project doxia-site: Error uploading site: Error copying directory structure: Unknown file type: /home/runner/work/maven-doxia-site/maven-doxia-site/target/site/doxia-tools/doxia-linkcheck -> [Help 1] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-site] elharo commented on pull request #28: Try to unbreak CI
elharo commented on PR #28: URL: https://github.com/apache/maven-doxia-site/pull/28#issuecomment-1519043799 Progress! This moves us to the next error: ``` Error: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:stage (default-cli) on project doxia-site: Error uploading site: Error copying directory structure: Unknown file type: /home/runner/work/maven-doxia-site/maven-doxia-site/target/site/doxia-tools/doxia-book-renderer -> [Help 1] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DOXIA-703) doxia-site CI is broken
Elliotte Rusty Harold created DOXIA-703: --- Summary: doxia-site CI is broken Key: DOXIA-703 URL: https://issues.apache.org/jira/browse/DOXIA-703 Project: Maven Doxia Issue Type: Bug Reporter: Elliotte Rusty Harold [INFO] Using this base directory for staging: /home/runner/work/maven-doxia-site/maven-doxia-site/target/staging [INFO] Pushing /home/runner/work/maven-doxia-site/maven-doxia-site/target/site [INFO]>>> to file:///home/runner/work/maven-doxia-site/maven-doxia-site/target/staging/../../../doxia/website/content [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 46.400 s [INFO] Finished at: 2023-04-23T11:21:08Z [INFO] Error: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:stage (default-cli) on project doxia-site: Error uploading site: Error copying directory structure: Unknown file type: /home/runner/work/maven-doxia-site/maven-doxia-site/target/site/doxia-ide -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (ARCHETYPE-584) Resulting root pom.xml from archetype generation has additional newlines with JDK11
[
https://issues.apache.org/jira/browse/ARCHETYPE-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715445#comment-17715445
]
Elliotte Rusty Harold edited comment on ARCHETYPE-584 at 4/23/23 11:14 AM:
---
The Stack Overflow threads are interesting. That smells like a JDK bug to me,
though I do think it's one worth working around. I'm still open to a PR here,
though as with any other PR it needs to have tests and not break the CI. So far
no one, me included, has managed to do all of this. It's like we're chasing a
bubble under a rug and wherever we push it down, it pops back up again in
another part of the carpet. :-(
was (Author: elharo):
The Stack Overflow threads are interesting. That smells like a JDK bug to me,
though I do think it's one worth working around. I'm still open to a PR here,
though as with any other PR though as with any other PR it needs to have tests
and not break the CI. So far no one, me included, has managed to do all of
this. It's like we're chasing a bubble under a rug and wherever we push it
down, it pops back up again in another part of the carpet. :-(
> Resulting root pom.xml from archetype generation has additional newlines with
> JDK11
> ---
>
> Key: ARCHETYPE-584
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-584
> Project: Maven Archetype
> Issue Type: Bug
> Components: Archetypes
>Affects Versions: 3.1.1, 3.1.2
>Reporter: bugflux
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This issue does not apply to version 3.1.0, it was introduced in version
> 3.1.1.
>
> In our project, we have the default configuration of the root pom.xml that
> contains lines such as this:
> {code:java}
>
> 11
> Greenwich.RELEASE
>
> {code}
> These lines are still in good shape when added to the jar artifact. However,
> upon generating the project from the archetype, we get the following (note
> also the whitespace on the blank lines hinting at some indentation attempts,
> not just the unexpected line breaks)
> {code:java}
>
>
>
> 11
>
>
> Greenwich.RELEASE
>
>
>
> {code}
> This issue does *not* occur in in child module pom.xml files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-584) Resulting root pom.xml from archetype generation has additional newlines with JDK11
[
https://issues.apache.org/jira/browse/ARCHETYPE-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715445#comment-17715445
]
Elliotte Rusty Harold commented on ARCHETYPE-584:
-
The Stack Overflow threads are interesting. That smells like a JDK bug to me,
though I do think it's one worth working around. I'm still open to a PR here,
though as with any other PR though as with any other PR it needs to have tests
and not break the CI. So far no one, me included, has managed to do all of
this. It's like we're chasing a bubble under a rug and wherever we push it
down, it pops back up again in another part of the carpet. :-(
> Resulting root pom.xml from archetype generation has additional newlines with
> JDK11
> ---
>
> Key: ARCHETYPE-584
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-584
> Project: Maven Archetype
> Issue Type: Bug
> Components: Archetypes
>Affects Versions: 3.1.1, 3.1.2
>Reporter: bugflux
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This issue does not apply to version 3.1.0, it was introduced in version
> 3.1.1.
>
> In our project, we have the default configuration of the root pom.xml that
> contains lines such as this:
> {code:java}
>
> 11
> Greenwich.RELEASE
>
> {code}
> These lines are still in good shape when added to the jar artifact. However,
> upon generating the project from the archetype, we get the following (note
> also the whitespace on the blank lines hinting at some indentation attempts,
> not just the unexpected line breaks)
> {code:java}
>
>
>
> 11
>
>
> Greenwich.RELEASE
>
>
>
> {code}
> This issue does *not* occur in in child module pom.xml files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715444#comment-17715444
]
Olivier Lamy commented on MBUILDCACHE-56:
-
why people simply not use standard field pattern naming and use some
completely/complicated name differences.
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715444#comment-17715444
]
Olivier Lamy edited comment on MBUILDCACHE-56 at 4/23/23 11:12 AM:
---
why people simply not use standard field pattern naming and use some
completely/complicated name differences.
at least this will not break but hash might be the same in case of different
values...
was (Author: olamy):
why people simply not use standard field pattern naming and use some
completely/complicated name differences.
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715443#comment-17715443
]
Olivier Lamy commented on MBUILDCACHE-56:
-
another case is
https://github.com/apache/maven-enforcer/commit/495818f95eb773a677672b21a2bf5969ebdc2411#diff-376d0eba74cd031bde69018690488d25360994a47cb7b5cf962388fc119a551eR150
where field name and parameter name are very different
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #412: spotless fix
slawekjaranowski commented on code in PR #412: URL: https://github.com/apache/maven-site/pull/412#discussion_r1174558948 ## pom.xml: ## @@ -55,7 +55,8 @@ maven-site -x +x + Review Comment: should be one line upper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715442#comment-17715442
]
Slawomir Jaranowski commented on MBUILDCACHE-56:
Next case when we read parameter which we have in mentioned example is that
field always has a null value, because magic is done in set method and filed is
not used at all.
Try to use dependency:copy in cache with artifact parameter.
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] elharo opened a new pull request, #412: spotless fix
elharo opened a new pull request, #412: URL: https://github.com/apache/maven-site/pull/412 somebody must have updated without running `mvn test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x
[
https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715441#comment-17715441
]
ASF GitHub Bot commented on MNGSITE-393:
elharo commented on code in PR #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r1174557971
##
content/apt/guides/mini/guide-http-settings.apt:
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
Review Comment:
Please file a JIRA
> Remove references to Maven 2.x
> --
>
> Key: MNGSITE-393
> URL: https://issues.apache.org/jira/browse/MNGSITE-393
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Maven 3.x is over a decade old now and we're talking about Maven 4. It's time
> to clean out all the random discussion here and there about how Maven 2.x did
> things, differences between Maven 2 and 3, what works in Maven 3 but not 2,
> etc.
> Assume Maven 3.0 as the minimum, probably Maven 3.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] elharo commented on a diff in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info
elharo commented on code in PR #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r1174557971
##
content/apt/guides/mini/guide-http-settings.apt:
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
Review Comment:
Please file a JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x
[
https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715440#comment-17715440
]
ASF GitHub Bot commented on MNGSITE-393:
elharo commented on code in PR #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r1174557289
##
content/apt/guides/mini/guide-http-settings.apt:
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
- * readTimeout: default to 180ms (~30 minutes) (see section <<>> below)
+ * readTimeout: default to 1,800,000ms (~30 minutes) (see section <<>> below)
Review Comment:
reverted 180 since it's a Java property and this is the Java default
value
> Remove references to Maven 2.x
> --
>
> Key: MNGSITE-393
> URL: https://issues.apache.org/jira/browse/MNGSITE-393
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Maven 3.x is over a decade old now and we're talking about Maven 4. It's time
> to clean out all the random discussion here and there about how Maven 2.x did
> things, differences between Maven 2 and 3, what works in Maven 3 but not 2,
> etc.
> Assume Maven 3.0 as the minimum, probably Maven 3.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] elharo commented on a diff in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info
elharo commented on code in PR #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r1174557289
##
content/apt/guides/mini/guide-http-settings.apt:
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
- * readTimeout: default to 180ms (~30 minutes) (see section <<>> below)
+ * readTimeout: default to 1,800,000ms (~30 minutes) (see section <<>> below)
Review Comment:
reverted 180 since it's a Java property and this is the Java default
value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715438#comment-17715438
]
Olivier Lamy commented on MBUILDCACHE-56:
-
I will push a PR which will warn to ignore those mojo parameters as there is no
way to get them. (except if there is a getXXX but in this case nope).
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-stage-plugin] elharo closed pull request #6: [MSTAGE-25] fixup and modernize IO
elharo closed pull request #6: [MSTAGE-25] fixup and modernize IO URL: https://github.com/apache/maven-stage-plugin/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715435#comment-17715435
]
Olivier Lamy edited comment on MBUILDCACHE-56 at 4/23/23 10:48 AM:
---
[~sjaranowski] I know BUT this is not the problem :)
here we try to read a value (Mojo parameter) and not to set value.
So when there is a field it works fine but it's broken when there is no field
because it is using this method which is expecting a field see
https://github.com/codehaus-plexus/plexus-utils/blob/21bf1654318ac4814c9f9c97418a0be69cd8d215/src/main/java/org/codehaus/plexus/util/ReflectionUtils.java#L175
was (Author: olamy):
[~sjaranowski] I know BUT this is not the problem :)
here we try to read values and not to set value.
So when there is a field it works fine but it's broken when there is no field
because it is using this method which is expecting a field see
https://github.com/codehaus-plexus/plexus-utils/blob/21bf1654318ac4814c9f9c97418a0be69cd8d215/src/main/java/org/codehaus/plexus/util/ReflectionUtils.java#L175
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715435#comment-17715435
]
Olivier Lamy commented on MBUILDCACHE-56:
-
[~sjaranowski] I know BUT this is not the problem :)
here we try to read values and not to set value.
So when there is a field it works fine but it's broken when there is no field
because it is using this method which is expecting a field see
https://github.com/codehaus-plexus/plexus-utils/blob/21bf1654318ac4814c9f9c97418a0be69cd8d215/src/main/java/org/codehaus/plexus/util/ReflectionUtils.java#L175
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] elharo commented on a diff in pull request #191: docs: system dependencies are not always available
elharo commented on code in PR #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r1174555356 ## content/apt/guides/introduction/introduction-to-dependency-mechanism.apt: ## @@ -826,12 +826,14 @@ Introduction to the Dependency Mechanism <<>> - Dependencies with the scope are always available and are not looked - up in repository. They are usually used to tell Maven about dependencies which - are provided by the JDK or the VM. Thus, system dependencies are especially - useful for resolving dependencies on artifacts which are now provided by the - JDK, but were available as separate downloads earlier. Typical examples are - the JDBC standard extensions or the Java Authentication and Authorization + Dependencies with the scope are not looked up in the Maven repository system. + Instead the `dependency` element contains a `systemPath` pointing to a jar on the local + file system. + + The system scope is commonly used to tell Maven about dependencies provided by the JDK or the VM. + System dependencies are especially useful for resolving dependencies on artifacts which + are now provided by the JDK, but were available as separate downloads earlier. Typical + examples are the JDBC standard extensions or the Java Authentication and Authorization Review Comment: I'm not quite sure what you mean. Do you mean some sort of fat jar? Or perhaps a custom version of Maven? Either way this seems much more complex than a system dependency that points to tools.jar. To move this PR forward, what specific change in the current text do you propose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] slawekjaranowski opened a new pull request, #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver
slawekjaranowski opened a new pull request, #134: URL: https://github.com/apache/maven-assembly-plugin/pull/134 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715405#comment-17715405
]
Slawomir Jaranowski commented on MBUILDCACHE-56:
Even when we have @Parameter on the field - plugin configurator will use setter
method at first, so setting only a filed can break something.
Like in
https://github.com/apache/maven-dependency-plugin/blob/master/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/CopyMojo.java#L73
{code:java}
@SuppressWarnings("unused") // marker-field, setArtifact(String) does the
magic
@Parameter(property = "artifact")
private String artifact;
{code}
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MASSEMBLY-987) Bump plexus-archiver from 4.6.0 to 4.6.3
Slawomir Jaranowski created MASSEMBLY-987: - Summary: Bump plexus-archiver from 4.6.0 to 4.6.3 Key: MASSEMBLY-987 URL: https://issues.apache.org/jira/browse/MASSEMBLY-987 Project: Maven Assembly Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.5.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-986) Minimal default Manifest should be used by jar archiver
[
https://issues.apache.org/jira/browse/MASSEMBLY-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715400#comment-17715400
]
Slawomir Jaranowski commented on MASSEMBLY-986:
---
{{Maven Assembly Plugin}} is not used for creating archive, it is only used for
manage Manifest.
I updated description
> Minimal default Manifest should be used by jar archiver
> ---
>
> Key: MASSEMBLY-986
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-986
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.5.1
>
>
> When we configure plugin with:
> {code}
>
>
> false
>
>
> {code}
> We expect that minimal Manifest will be created with content:
> {code}
> Manifest-Version: 1.0
> {code}
> but we have:
> {code}
> Manifest-Version: 1.0
> Created-By: Plexus Archiver 4.6.0
> {code}
> Manifest content depends on version of Plexus Archiver and in such case can
> break reproducible build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MASSEMBLY-986) Minimal default Manifest should be used by jar archiver
[
https://issues.apache.org/jira/browse/MASSEMBLY-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MASSEMBLY-986:
--
Description:
When we configure plugin with:
{code}
false
{code}
We expect that minimal Manifest will be created with content:
{code}
Manifest-Version: 1.0
{code}
but we have:
{code}
Manifest-Version: 1.0
Created-By: Plexus Archiver 4.6.0
{code}
Manifest content depends on version of Plexus Archiver and in such case can
break reproducible build.
was:
When we configure plugin with:
{code}
false
{code}
We expect that empty Manifest will be used - but we have:
{code}
Manifest-Version: 1.0
Created-By: Plexus Archiver 4.6.0
{code}
Manifest content depends on version of Plexus Archiver and in such case can
break reproducible build.
> Minimal default Manifest should be used by jar archiver
> ---
>
> Key: MASSEMBLY-986
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-986
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.5.1
>
>
> When we configure plugin with:
> {code}
>
>
> false
>
>
> {code}
> We expect that minimal Manifest will be created with content:
> {code}
> Manifest-Version: 1.0
> {code}
> but we have:
> {code}
> Manifest-Version: 1.0
> Created-By: Plexus Archiver 4.6.0
> {code}
> Manifest content depends on version of Plexus Archiver and in such case can
> break reproducible build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
