[GitHub] [maven-verifier] dependabot[bot] opened a new pull request, #78: Bump maven-shared-utils from 3.3.4 to 3.4.1
dependabot[bot] opened a new pull request, #78: URL: https://github.com/apache/maven-verifier/pull/78 Bumps [maven-shared-utils](https://github.com/apache/maven-shared-utils) from 3.3.4 to 3.4.1. Release notes Sourced from https://github.com/apache/maven-shared-utils/releases;>maven-shared-utils's releases. 3.4.1 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922version=12353186;>Release Notes New features and improvements https://issues.apache.org/jira/browse/MNG-7729;>[MNG-7729] - deprecate questionable IsEmpty/IsNotEmpty methods (https://redirect.github.com/apache/maven-shared-utils/pull/136;>#136) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1014;>[MSHARED-1014] - Make Commandline.addSystemEnvironment public and deprecated (https://redirect.github.com/apache/maven-shared-utils/pull/138;>#138) https://github.com/slawekjaranowski;>@slawekjaranowski Deprecate newXmlWriter (https://redirect.github.com/apache/maven-shared-utils/pull/131;>#131) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1172;>[MSHARED-1172] - Deprecate redundant isEmptyString method (https://redirect.github.com/apache/maven-shared-utils/pull/123;>#123) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1169;>[MSHARED-1169] - deprecate join methods now available in Java 8 String class (https://redirect.github.com/apache/maven-shared-utils/pull/127;>#127) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1122;>[MSHARED-1122] - FileUtils: avoid getCanonicalPath() (https://redirect.github.com/apache/maven-shared-utils/pull/114;>#114) https://github.com/jukzi;>@jukzi https://issues.apache.org/jira/browse/MSHARED-1079;>[MSHARED-1079] - add build() method and document toString() method (https://redirect.github.com/apache/maven-shared-utils/pull/96;>#96) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-1014;>[MSHARED-1014] - Optionally inherit system environment variables by Commandline (https://redirect.github.com/apache/maven-shared-utils/pull/94;>#94) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-983;>[MSHARED-983] - Drop plexus container default (https://redirect.github.com/apache/maven-shared-utils/pull/87;>#87) https://github.com/cstamas;>@cstamas Bug Fixes https://issues.apache.org/jira/browse/MSHARED-953;>[MSHARED-953] - don't trim (https://redirect.github.com/apache/maven-shared-utils/pull/124;>#124) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1072;>[MSHARED-1072] - fix blocking in StreamFeeder (https://redirect.github.com/apache/maven-shared-utils/pull/113;>#113) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1109;>[MSHARED-1109] - Ignore MessageUtilsTest methods on unsupported platforms (https://redirect.github.com/apache/maven-shared-utils/pull/106;>#106) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-1107;>[MSHARED-1107] - Make copyFile succeed with source file having (https://redirect.github.com/apache/maven-shared-utils/pull/105;>#105) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-985;>[MSHARED-985] - XmlWriterUtil platform independent and consistent (https://redirect.github.com/apache/maven-shared-utils/pull/91;>#91) https://github.com/elharo;>@elharo Dependency updates Bump maven-resources-plugin from 3.1.0 to 3.3.1 (https://redirect.github.com/apache/maven-shared-utils/pull/137;>#137) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MSHARED-1196;>[MSHARED-1196] - Bump maven-shared-components from 37 to 39 (https://redirect.github.com/apache/maven-shared-utils/pull/134;>#134) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1197;>[MSHARED-1197] - Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/apache/maven-shared-utils/pull/132;>#132) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 2 to 3 (https://redirect.github.com/apache/maven-shared-utils/pull/130;>#130) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/apache/maven-shared-utils/pull/120;>#120) https://github.com/dependabot;>@dependabot Bump commons-text from 1.3 to 1.10.0 (https://redirect.github.com/apache/maven-shared-utils/pull/119;>#119) https://github.com/dependabot;>@dependabot Bump maven-shared-components from 36 to 37 (https://redirect.github.com/apache/maven-shared-utils/pull/108;>#108) https://github.com/dependabot;>@dependabot Maintenance suggest java.nio.Files.walkFileTree as replacement for
[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)
[
https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719640#comment-17719640
]
ASF GitHub Bot commented on MBUILDCACHE-56:
---
olamy merged PR #73:
URL: https://github.com/apache/maven-build-cache-extension/pull/73
> NPE with mojo parameters not declared as fields (prevent any saving of cache)
> -
>
> Key: MBUILDCACHE-56
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-56
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.0.1
>
>
> such field from m-enforcer-p
> https://github.com/apache/maven-enforcer/blame/master/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L192
> is creating an NPE when trying saving the cache content because there is no
> field but a method!
> This makes the cache extension totally not usable.
> {code}
> java.lang.NullPointerException: Cannot invoke
> "java.lang.reflect.Field.setAccessible(boolean)" because "field" is null
> at org.codehaus.plexus.util.ReflectionUtils.getValueIncludingSuperclasses
> (ReflectionUtils.java:177)
> at org.apache.maven.buildcache.CacheControllerImpl.recordMojoProperties
> (CacheControllerImpl.java:612)
> at org.apache.maven.buildcache.CacheControllerImpl.buildExecutionInfo
> (CacheControllerImpl.java:579)
> at org.apache.maven.buildcache.CacheControllerImpl.save
> (CacheControllerImpl.java:440)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> {code}
> Ideally we should check if there is a field and throw IAE in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-build-cache-extension] olamy merged pull request #73: [MBUILDCACHE-56] fix NPE when mojo does not a have field with same name as parameter
olamy merged PR #73: URL: https://github.com/apache/maven-build-cache-extension/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-remote-resources-plugin] dependabot[bot] opened a new pull request, #35: Bump aether.version from 1.0.0.v20140518 to 1.1.0
dependabot[bot] opened a new pull request, #35: URL: https://github.com/apache/maven-remote-resources-plugin/pull/35 Bumps `aether.version` from 1.0.0.v20140518 to 1.1.0. Updates `aether-api` from 1.0.0.v20140518 to 1.1.0 Updates `aether-util` from 1.0.0.v20140518 to 1.1.0 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] dependabot[bot] opened a new pull request, #47: Bump maven-shared-utils from 3.3.4 to 3.4.1
dependabot[bot] opened a new pull request, #47: URL: https://github.com/apache/maven-war-plugin/pull/47 Bumps [maven-shared-utils](https://github.com/apache/maven-shared-utils) from 3.3.4 to 3.4.1. Release notes Sourced from https://github.com/apache/maven-shared-utils/releases;>maven-shared-utils's releases. 3.4.1 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922version=12353186;>Release Notes New features and improvements https://issues.apache.org/jira/browse/MNG-7729;>[MNG-7729] - deprecate questionable IsEmpty/IsNotEmpty methods (https://redirect.github.com/apache/maven-shared-utils/pull/136;>#136) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1014;>[MSHARED-1014] - Make Commandline.addSystemEnvironment public and deprecated (https://redirect.github.com/apache/maven-shared-utils/pull/138;>#138) https://github.com/slawekjaranowski;>@slawekjaranowski Deprecate newXmlWriter (https://redirect.github.com/apache/maven-shared-utils/pull/131;>#131) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1172;>[MSHARED-1172] - Deprecate redundant isEmptyString method (https://redirect.github.com/apache/maven-shared-utils/pull/123;>#123) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1169;>[MSHARED-1169] - deprecate join methods now available in Java 8 String class (https://redirect.github.com/apache/maven-shared-utils/pull/127;>#127) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1122;>[MSHARED-1122] - FileUtils: avoid getCanonicalPath() (https://redirect.github.com/apache/maven-shared-utils/pull/114;>#114) https://github.com/jukzi;>@jukzi https://issues.apache.org/jira/browse/MSHARED-1079;>[MSHARED-1079] - add build() method and document toString() method (https://redirect.github.com/apache/maven-shared-utils/pull/96;>#96) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-1014;>[MSHARED-1014] - Optionally inherit system environment variables by Commandline (https://redirect.github.com/apache/maven-shared-utils/pull/94;>#94) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-983;>[MSHARED-983] - Drop plexus container default (https://redirect.github.com/apache/maven-shared-utils/pull/87;>#87) https://github.com/cstamas;>@cstamas Bug Fixes https://issues.apache.org/jira/browse/MSHARED-953;>[MSHARED-953] - don't trim (https://redirect.github.com/apache/maven-shared-utils/pull/124;>#124) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1072;>[MSHARED-1072] - fix blocking in StreamFeeder (https://redirect.github.com/apache/maven-shared-utils/pull/113;>#113) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1109;>[MSHARED-1109] - Ignore MessageUtilsTest methods on unsupported platforms (https://redirect.github.com/apache/maven-shared-utils/pull/106;>#106) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-1107;>[MSHARED-1107] - Make copyFile succeed with source file having (https://redirect.github.com/apache/maven-shared-utils/pull/105;>#105) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-985;>[MSHARED-985] - XmlWriterUtil platform independent and consistent (https://redirect.github.com/apache/maven-shared-utils/pull/91;>#91) https://github.com/elharo;>@elharo Dependency updates Bump maven-resources-plugin from 3.1.0 to 3.3.1 (https://redirect.github.com/apache/maven-shared-utils/pull/137;>#137) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MSHARED-1196;>[MSHARED-1196] - Bump maven-shared-components from 37 to 39 (https://redirect.github.com/apache/maven-shared-utils/pull/134;>#134) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1197;>[MSHARED-1197] - Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/apache/maven-shared-utils/pull/132;>#132) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 2 to 3 (https://redirect.github.com/apache/maven-shared-utils/pull/130;>#130) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/apache/maven-shared-utils/pull/120;>#120) https://github.com/dependabot;>@dependabot Bump commons-text from 1.3 to 1.10.0 (https://redirect.github.com/apache/maven-shared-utils/pull/119;>#119) https://github.com/dependabot;>@dependabot Bump maven-shared-components from 36 to 37 (https://redirect.github.com/apache/maven-shared-utils/pull/108;>#108) https://github.com/dependabot;>@dependabot Maintenance suggest java.nio.Files.walkFileTree as replacement for
[GitHub] [maven-site] dependabot[bot] opened a new pull request, #415: Bump maven-site-plugin from 4.0.0-M7 to 4.0.0-M8
dependabot[bot] opened a new pull request, #415: URL: https://github.com/apache/maven-site/pull/415 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 4.0.0-M7 to 4.0.0-M8. Commits https://github.com/apache/maven-site-plugin/commit/ab0524fc52efe09c1c1d95d1bbe089351cf19936;>ab0524f [maven-release-plugin] prepare release maven-site-plugin-4.0.0-M8 https://github.com/apache/maven-site-plugin/commit/ace21d1787236a9ea7775e364e5685e2b171c23c;>ace21d1 [MSITE-873] Mark SiteMojo and SiteJarMojo thread-safe https://github.com/apache/maven-site-plugin/commit/0e9a300c8a538b78f79161eab06c2d6a2d57f298;>0e9a300 [MSITE-962] Upgrade to Doxia Sitetools to 2.0.0-M10, Maven Reporting Impl/Exe... https://github.com/apache/maven-site-plugin/commit/48f4155af2069e61c15399a475a26d2467749347;>48f4155 [MSITE-964] Fix failure of 'site-jar' IT on Java 17 https://github.com/apache/maven-site-plugin/commit/d452e4befc21c79b12c1277beab975418bca6bc8;>d452e4b [MSITE-963] Delete broken site descriptor files from local repository https://github.com/apache/maven-site-plugin/commit/ab07cd2ce6f22a40350f7b964c2fc0466591;>ab0 [MSITE-961] Separate Fluido Skin version between site generation and testing/... https://github.com/apache/maven-site-plugin/commit/0c556eafa3ef639bfee6e18a6c9444dc2b2a0501;>0c556ea Remove old URLs and Maven versions https://github.com/apache/maven-site-plugin/commit/aee2c9727262bbc52206bf208d5c429cffc14bcf;>aee2c97 [MSITE-959] Incorrect assumption of default locale https://github.com/apache/maven-site-plugin/commit/39d5e3635329932ed113c99adfe90d3b2c5940f1;>39d5e36 [MSITE-958] Rewrite sitemap generator to a rendender https://github.com/apache/maven-site-plugin/commit/ca04195938a3632d041ebb5a8d50868790a4fecd;>ca04195 [MSITE-957] Print generation log message in CategorySummaryDocumentRenderer l... Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-4.0.0-M7...maven-site-plugin-4.0.0-M8;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] guylabs commented on pull request #810: Add configuration to send build scans to https://ge.apache.org
guylabs commented on PR #810: URL: https://github.com/apache/maven-mvnd/pull/810#issuecomment-1535416527 Hi @ppalaga, gentle ping :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-650) Fire ExecutionEvent from DefaultMavenReportExecutor
[
https://issues.apache.org/jira/browse/MSHARED-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719521#comment-17719521
]
Michael Osipov commented on MSHARED-650:
[~cstamas], can you tell us your opinion on this?
> Fire ExecutionEvent from DefaultMavenReportExecutor
> ---
>
> Key: MSHARED-650
> URL: https://issues.apache.org/jira/browse/MSHARED-650
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-reporting-exec
>Reporter: Matt Nelson
>Priority: Major
>
> The event spy features added currently only support plugin mojos. When
> building site all the report mojos are grouped together under the site plugin
> and do not enable the ability to profile the site and find slow mojos. I dug
> through the code and it appears that the {{DefaultMavenReportExecutor}}[1]
> could be instrumented with the Catapult to fire events for each report mojo
> that the {{EventSpy}}[2] can handle.
> [1]
> https://github.com/apache/maven-shared/blob/maven-reporting-exec-1.3/src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java
> [2]
> https://github.com/apache/maven/blob/maven-3.5.0/maven-core/src/main/java/org/apache/maven/eventspy/EventSpy.java
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSITE-948) Site stage/deploy should respect 'child.site.url.inherit.append.path="false"' and not use relativePath related to that parent
[ https://issues.apache.org/jira/browse/MSITE-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-948: - Labels: doxia-2.0.0-stack (was: ) > Site stage/deploy should respect 'child.site.url.inherit.append.path="false"' > and not use relativePath related to that parent > - > > Key: MSITE-948 > URL: https://issues.apache.org/jira/browse/MSITE-948 > Project: Maven Site Plugin > Issue Type: Bug > Components: site:stage(-deploy) >Affects Versions: 3.12.1, 4.0.0-M7 >Reporter: Jeremy Landis >Priority: Major > Labels: doxia-2.0.0-stack > > All versions of maven have long been affected by this and there are many > tickets opened / closed claiming to have resolved or seem to be outstanding > for years with no resolution. I believe they are mostly related. > The 'child.site.url.inherit.append.path="false"' was added back in maven > 3.6.0 with claim to stop this behaviour but its never worked outside of > effective pom looks right IMO. At least most platforms support that now > (artifactory was late in that game). > Currently regardless of that setting, the maven site plugin doesn't respect > it or even look at it from what I can tell. Its there in the debug tree but > the code doesn't appear to look at that to determine what it will do with > relativePath. > So, if I have project example [https://github.com/hazendaz/base-parent] and I > happen to have those set (such as > [https://github.com/hazendaz/base-parent/commit/58e9f8a7749a80e74e8197d5b90b17458cadb161]), > then anything downstream using that parent which is unrelated I would expect > to adhere to the request and not attempt to use the super pom for its > calculations at all. But it does not do so. > I suspect areas of code problematic are getTopLevelProject(MavenProject) or > 'getDeployModuleDirectory'. The later being where it matters with > 'relativePath' determined. > The main issue is with multi module downstream projects. Fixing this issue I > suspect would have immediate impact on being able to use the site plugin > directly and not need scm publish. Scm publish tends to work for single > module but it still suffers from fact that the site plugin messes up the data > before it ever gets there. > For example, if my project is 'somerepo.git', I would expect site:stage to > put the data in 'target/staging' as the documentation states it will do so. > It however does not, regardless of the above noted setting. What it does > instead is determine that it needs the relative path to be '../somerepo.git' > just because it has a parent pom from some other project from same hosted > platform (gh-pages on github). So the staging then puts that in > 'target/somerepo.git' instead. So maven scm publish cannot even see that. > The site deploy fails to do it correctly as it completely changes out the > repo to deploy to and tries to go to the parent which in most cases like this > isn't related at all. My base super pom for example is used by quite a > number of repos and they all have issues with site distributions as a result. > So how can we make the site plugin actually respect > 'child.site.url.inherit.append.path="false"'? Or any way to actually make > that easier like configure it to just stop doing that logic as unnecessary. > The pom settings IMO are over bearing as it is so a config option would be > far better and easier to implement. > I've debugged this far enough to just keep changing the site plugins > determination on the relativePath to be './' which fixes the issue. Note: > The rest of relative path for multi module is needed but starting part was > wrong '../' vs './'. > IMO I don't think maven should even be touching items like this, its so hard > to understand the math as a result. Thus why so many tickets get opened for > same thing in various different ways. Over the years we have tried just > about everything to make this work and honestly the only thing that really > does currently is to drop maven from doing the site distribution entirely and > use gh-actions to do the same or other solutions on different platforms. It > would be better IMO to use maven site plugin directly and/or with scm publish > if it consistently worked as documented. Maybe a flag isn't even need, maybe > just fixing maven site plugin to stop going outside of the staging folder > would be a good step 1 as scm publish should be ok then. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSITE-833) Remove dependency to maven-compat
[ https://issues.apache.org/jira/browse/MSITE-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-833: - Labels: doxia-2.0.0-stack (was: ) > Remove dependency to maven-compat > - > > Key: MSITE-833 > URL: https://issues.apache.org/jira/browse/MSITE-833 > Project: Maven Site Plugin > Issue Type: Improvement > Components: Maven 3 >Reporter: Sylwester Lachiewicz >Priority: Major > Labels: doxia-2.0.0-stack > > # Remove usages of the maven-compat classes: > ## org.apache.maven.artifact.manager.WagonManager > ## org.apache.maven.artifact.repository.ArtifactRepositoryFactory > # Move maven-compat scope to test > [https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-193: --- Labels: doxia-2.0.0-stack (was: ) > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > org.apache.maven.reporting.MavenReportRenderer.render() does not throw > MavenReportingException. Thus, even though the execute method for a report > throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1032) API change: let canGenerateReport() throw an Exception
[
https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSHARED-1032:
Labels: doxia-2.0.0-stack (was: )
> API change: let canGenerateReport() throw an Exception
> --
>
> Key: MSHARED-1032
> URL: https://issues.apache.org/jira/browse/MSHARED-1032
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-api
>Affects Versions: maven-reporting-api-3.0
>Reporter: Benjamin Marwell
>Priority: Major
> Labels: doxia-2.0.0-stack
>
> Hi everyone,
> the [{{AbstractReportMojo}} in
> reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html]
> implements a method [{{canGenerateReport()}} from
> reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html].
> However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}}
> or {{MavenReportEx}}, which is most unfortunate.
> It is being used twice:
> Once in {{execute() throws MojoExEx}}
> and in
> {{generate() throws MavenReportEx}} (and is called by execute()).
> This way, there is no way for reporting plugins to scan for files, because
> {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot
> be wrapped. However, the {{IOException}} from that method is useless anyway,
> because it is never declared in any methods it calls.
> Therefore please consider:
> * Declaring any Exception on {{canGenerateReports()}}
> * Removing the declared {{IOException}} in PlexusUtils ([PR
> exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and
> Maven-Utils (issue: tbd).
> Thanks!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIASITETOOLS-253) Clarify "border", "width" and "height" for Banner and LinkItem
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIASITETOOLS-253: -- Labels: doxia-2.0.0-stack (was: ) > Clarify "border", "width" and "height" for Banner and LinkItem > -- > > Key: DOXIASITETOOLS-253 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-253 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Decoration model >Reporter: Konrad Windszus >Priority: Major > Labels: doxia-2.0.0-stack > > The elements "border", "width" and "height" in > # > https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft > # > https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerRight > # > https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_item > have a very vague description. It should be clarified with regards to whether > this is the format of the same named CSS properties > (https://www.w3.org/TR/CSS2/box.html#border-properties, > https://www.w3.org/TR/CSS2/visudet.html#the-width-property and > https://www.w3.org/TR/CSS2/visudet.html#the-height-property) or the HTML4 > attributes (https://www.w3.org/TR/html401/struct/objects.html#h-13.7.1 and > https://www.w3.org/TR/html401/struct/objects.html#h-13.7.3) or another custom > format. > Currently the skins use the values as is for either CSS property or HTML > attribute, but although the are named the same the supported values differ a > lot. > This came up in the context of > https://github.com/apache/maven-fluido-skin/pull/23#discussion_r866169720. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIASITETOOLS-174) rename site.xml root tag from "project" to "site"
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIASITETOOLS-174:
--
Labels: doxia-2.0.0-stack (was: )
> rename site.xml root tag from "project" to "site"
> -
>
> Key: DOXIASITETOOLS-174
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-174
> Project: Maven Doxia Sitetools
> Issue Type: Wish
> Components: Decoration model
>Affects Versions: 1.7.4
>Reporter: Herve Boutemy
>Priority: Major
> Labels: doxia-2.0.0-stack
> Fix For: version-next
>
>
> when looking at [decoration model
> descriptor|http://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-1.7/doxia-decoration-model/decoration.html],
> naming the root element as {{project}} (like for {{pom.xml}}) is misleading
> if the root element could be renamed as {{doxia-decoration}}, the obvious
> (this descriptor is about site decoration, done with Doxia) could perhaps
> become obvious
> (in IT, calling everything a "project" is an issue...)
> I know that this change of xsd schema will break compatibility, but I think
> it can really make a big difference in usability (and I should have had this
> idea for Doxia Sitetools 1.7, when we already made some breaking changes...)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIASITETOOLS-254) Clarify inconsistencies in site decoration model
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIASITETOOLS-254:
--
Labels: doxia-2.0.0-stack (was: )
> Clarify inconsistencies in site decoration model
>
>
> Key: DOXIASITETOOLS-254
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-254
> Project: Maven Doxia Sitetools
> Issue Type: Task
> Components: Decoration model
>Affects Versions: 1.11.1
>Reporter: Michael Osipov
>Priority: Major
> Labels: doxia-2.0.0-stack
>
> [https://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-1.11.1/doxia-decoration-model/decoration.html]
> bannerLeft/bannerRight:
> * Are {{name}} and {{src}} (image) mutually exclusive? If yes, in what order
> should they appear? Why is no {{position}} like with other similar elements
> (logo, item)?
> * Does {{href}} truly only apply to the image?
> * Why is there no {{target}}?
> * Must {{title}}/{{alt}} only be used on the image?
> * Why not apply here the same logic as with the other imaged elements?
> * Why {{src}} instead of {{img}} like the rest?
> logo/link item/menu/menu item:
> * Does {{href}} truly only apply to the text? (different to banner)
> * Must {{title}}/{{alt}} only be used on the image?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-540) Update/remove ancient information on Doxia site
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-540: - Labels: doxia-2.0.0-stack up-for-grabs (was: up-for-grabs) > Update/remove ancient information on Doxia site > --- > > Key: DOXIA-540 > URL: https://issues.apache.org/jira/browse/DOXIA-540 > Project: Maven Doxia > Issue Type: Task > Components: Documentation >Reporter: Michael Osipov >Priority: Major > Labels: doxia-2.0.0-stack, up-for-grabs > Time Spent: 10m > Remaining Estimate: 0h > > Tasks to perform: > * Remove [Developer Docs|http://maven.apache.org/doxia/] for ancient versions. > * Remove Doxia IDE intergration is there is none working > * Remove [Upgrading|http://maven.apache.org/doxia/upgrading.html], it is > overhauled. > * Check [FAQ|http://maven.apache.org/doxia/faq.html] for validity. > * Merge [Apt > Enhancements|http://maven.apache.org/doxia/references/doxia-apt.html] into > [main site|http://maven.apache.org/doxia/references/apt-format.html]. > * Check [Issues|http://maven.apache.org/doxia/issues/index.html] for > validity. > * Update [External Resources|http://maven.apache.org/doxia/resources.html]. > * Remove ancient information from [Sink > API|http://maven.apache.org/doxia/doxia/doxia-sink-api/index.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-989) in RB mode, apply 022 umask to ignore environment group write umask
[ https://issues.apache.org/jira/browse/MASSEMBLY-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719445#comment-17719445 ] ASF GitHub Bot commented on MASSEMBLY-989: -- hboutemy opened a new pull request, #141: URL: https://github.com/apache/maven-assembly-plugin/pull/141 uses https://github.com/codehaus-plexus/plexus-archiver/pull/271 > in RB mode, apply 022 umask to ignore environment group write umask > --- > > Key: MASSEMBLY-989 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-989 > Project: Maven Assembly Plugin > Issue Type: Improvement >Affects Versions: 3.5.0 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 3.6.0 > > > after MASSEMBLY-941, as expected, environment umask give different output: > some use 002 (group write by default), some use 022 (group read only by > default) > applying 022 umask in reproducible mode will give the same archive for each > environment: group will be read only -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-assembly-plugin] hboutemy opened a new pull request, #141: [MASSEMBLY-989] apply 022 umask in RM mode
hboutemy opened a new pull request, #141: URL: https://github.com/apache/maven-assembly-plugin/pull/141 uses https://github.com/codehaus-plexus/plexus-archiver/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MASSEMBLY-989) in RB mode, apply 022 umask to ignore environment group write umask
Herve Boutemy created MASSEMBLY-989: --- Summary: in RB mode, apply 022 umask to ignore environment group write umask Key: MASSEMBLY-989 URL: https://issues.apache.org/jira/browse/MASSEMBLY-989 Project: Maven Assembly Plugin Issue Type: Improvement Affects Versions: 3.5.0 Reporter: Herve Boutemy Assignee: Herve Boutemy Fix For: 3.6.0 after MASSEMBLY-941, as expected, environment umask give different output: some use 002 (group write by default), some use 022 (group read only by default) applying 022 umask in reproducible mode will give the same archive for each environment: group will be read only -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRRESOURCES-129) Unable to process POMs of dependencies using profiles activated by Java versions
[
https://issues.apache.org/jira/browse/MRRESOURCES-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MRRESOURCES-129:
---
Assignee: Slawomir Jaranowski
> Unable to process POMs of dependencies using profiles activated by Java
> versions
>
>
> Key: MRRESOURCES-129
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-129
> Project: Maven Remote Resources Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Richard Eckart de Castilho
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.1.0
>
>
> The 1.7.0 version of the maven-remote-resources-plugin as no trouble
> processing POMs of dependencies such as the various Apache Commons libraries
> which contain a profile activated by the Java version in their respective
> parent POMs (cf.
> https://search.maven.org/artifact/org.apache.commons/commons-parent/52/pom -
> profile "japicmp").
> Trying the same with version 3.0.0 generates errors such as:
> {noformat}
> [WARNING] Failed to build parent project for
> org.apache.commons:commons-csv:jar:1.10.0
> org.apache.maven.project.ProjectBuildingException: Some problems were
> encountered while processing the POMs:
> [ERROR] Failed to determine Java version for profile japicmp @ line 1505,
> column 14
> [ERROR] Failed to determine Java version for profile jdk7-plugin-fix-version
> @ line 1922, column 14
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:207)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:342)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:299)
> at org.apache.maven.project.DefaultProjectBuilder.initParent
> (DefaultProjectBuilder.java:960)
> at org.apache.maven.project.DefaultProjectBuilder.initProject
> (DefaultProjectBuilder.java:680)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:188)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:342)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:299)
> at
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.getProjects
> (ProcessRemoteResourcesMojo.java:665)
> at
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo$1.internalGet
> (ProcessRemoteResourcesMojo.java:1044)
> at org.apache.velocity.context.AbstractContext.get
> (AbstractContext.java:193)
> at org.apache.velocity.context.InternalContextAdapterImpl.get
> (InternalContextAdapterImpl.java:267)
> at org.apache.velocity.runtime.parser.node.ASTReference.getVariableValue
> (ASTReference.java:991)
> at org.apache.velocity.runtime.parser.node.ASTReference.execute
> (ASTReference.java:240)
> at org.apache.velocity.runtime.parser.node.ASTReference.value
> (ASTReference.java:567)
> at org.apache.velocity.runtime.directive.Foreach.render (Foreach.java:318)
> at org.apache.velocity.runtime.parser.node.ASTDirective.render
> (ASTDirective.java:207)
> at org.apache.velocity.runtime.parser.node.SimpleNode.render
> (SimpleNode.java:342)
> at org.apache.velocity.Template.merge (Template.java:356)
> at org.apache.velocity.Template.merge (Template.java:260)
> at org.apache.velocity.app.VelocityEngine.mergeTemplate
> (VelocityEngine.java:354)
> at
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles
> (ProcessRemoteResourcesMojo.java:1255)
> at
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute
> (ProcessRemoteResourcesMojo.java:531)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7774) Maven config and command line interpolation
[
https://issues.apache.org/jira/browse/MNG-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719400#comment-17719400
]
ASF GitHub Bot commented on MNG-7774:
-
CrazyHZM commented on PR #1098:
URL: https://github.com/apache/maven/pull/1098#issuecomment-1534997859
> > @cstamas I think the description of adding this command in `mvn -help`
is still missing.
>
> Which command? No command was added or modified in Maven CLI
My mistake was that I didn't see it clearly. There was nothing wrong with
3.9.x. There are too many maven versions for my local development.
@cstamas
> Maven config and command line interpolation
> ---
>
> Key: MNG-7774
> URL: https://issues.apache.org/jira/browse/MNG-7774
> Project: Maven
> Issue Type: Task
> Components: Command Line
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.2
>
>
> Note: this issue "mildly follows" functionality done in Maven 4 as part of
> MNG-7038 and MNG-6303, with partial implementation only (is not full
> back-port), hence "mild introduction".
> Rationale: many new resolver features are akin to be able to store their
> configuration and input along SCM tracked Maven project sources. Sadly,
> currently this is not possible. The two issues targeting Maven4 (MNG-7038 and
> MNG-6303) with introduction of session and project "topDirectory" and
> "rootDirectory" properties solve this. Still, Maven 3.9.x does not need all
> of this.
> So, idea is following:
> * extend MavenCli to interpolate Maven arguments
> * introduce two special properties {{session.rootDirectory}} and
> {{session.topDirectory}} in interpolation. They are special, as they may not
> be defined, and IF they are not defined, their use in Maven argument
> interpolation causes error (Maven will not boot).
> * limit the use of the two new properties to Maven CLI interpolation only.
> This makes projects relying on Maven CLI interpolation "permeable" between
> Maven 3.9.x and Maven 4, while all the whistle and bells (exposing this via
> session or project) will be available in Maven 4 only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] CrazyHZM commented on pull request #1098: [MNG-7774] Maven config and command line interpolation
CrazyHZM commented on PR #1098: URL: https://github.com/apache/maven/pull/1098#issuecomment-1534997859 > > @cstamas I think the description of adding this command in `mvn -help` is still missing. > > Which command? No command was added or modified in Maven CLI My mistake was that I didn't see it clearly. There was nothing wrong with 3.9.x. There are too many maven versions for my local development. @cstamas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7774) Maven config and command line interpolation
[
https://issues.apache.org/jira/browse/MNG-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719392#comment-17719392
]
ASF GitHub Bot commented on MNG-7774:
-
cstamas commented on PR #1098:
URL: https://github.com/apache/maven/pull/1098#issuecomment-1534979166
> @cstamas I think the description of adding this command in `mvn -help` is
still missing.
Which command? No command was added or modified in Maven CLI
> Maven config and command line interpolation
> ---
>
> Key: MNG-7774
> URL: https://issues.apache.org/jira/browse/MNG-7774
> Project: Maven
> Issue Type: Task
> Components: Command Line
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.2
>
>
> Note: this issue "mildly follows" functionality done in Maven 4 as part of
> MNG-7038 and MNG-6303, with partial implementation only (is not full
> back-port), hence "mild introduction".
> Rationale: many new resolver features are akin to be able to store their
> configuration and input along SCM tracked Maven project sources. Sadly,
> currently this is not possible. The two issues targeting Maven4 (MNG-7038 and
> MNG-6303) with introduction of session and project "topDirectory" and
> "rootDirectory" properties solve this. Still, Maven 3.9.x does not need all
> of this.
> So, idea is following:
> * extend MavenCli to interpolate Maven arguments
> * introduce two special properties {{session.rootDirectory}} and
> {{session.topDirectory}} in interpolation. They are special, as they may not
> be defined, and IF they are not defined, their use in Maven argument
> interpolation causes error (Maven will not boot).
> * limit the use of the two new properties to Maven CLI interpolation only.
> This makes projects relying on Maven CLI interpolation "permeable" between
> Maven 3.9.x and Maven 4, while all the whistle and bells (exposing this via
> session or project) will be available in Maven 4 only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #1098: [MNG-7774] Maven config and command line interpolation
cstamas commented on PR #1098: URL: https://github.com/apache/maven/pull/1098#issuecomment-1534979166 > @cstamas I think the description of adding this command in `mvn -help` is still missing. Which command? No command was added or modified in Maven CLI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7774) Maven config and command line interpolation
[
https://issues.apache.org/jira/browse/MNG-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719390#comment-17719390
]
ASF GitHub Bot commented on MNG-7774:
-
CrazyHZM commented on PR #1098:
URL: https://github.com/apache/maven/pull/1098#issuecomment-1534973768
@cstamas I think the description of adding this command in `mvn -help` is
still missing.
> Maven config and command line interpolation
> ---
>
> Key: MNG-7774
> URL: https://issues.apache.org/jira/browse/MNG-7774
> Project: Maven
> Issue Type: Task
> Components: Command Line
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.2
>
>
> Note: this issue "mildly follows" functionality done in Maven 4 as part of
> MNG-7038 and MNG-6303, with partial implementation only (is not full
> back-port), hence "mild introduction".
> Rationale: many new resolver features are akin to be able to store their
> configuration and input along SCM tracked Maven project sources. Sadly,
> currently this is not possible. The two issues targeting Maven4 (MNG-7038 and
> MNG-6303) with introduction of session and project "topDirectory" and
> "rootDirectory" properties solve this. Still, Maven 3.9.x does not need all
> of this.
> So, idea is following:
> * extend MavenCli to interpolate Maven arguments
> * introduce two special properties {{session.rootDirectory}} and
> {{session.topDirectory}} in interpolation. They are special, as they may not
> be defined, and IF they are not defined, their use in Maven argument
> interpolation causes error (Maven will not boot).
> * limit the use of the two new properties to Maven CLI interpolation only.
> This makes projects relying on Maven CLI interpolation "permeable" between
> Maven 3.9.x and Maven 4, while all the whistle and bells (exposing this via
> session or project) will be available in Maven 4 only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] CrazyHZM commented on pull request #1098: [MNG-7774] Maven config and command line interpolation
CrazyHZM commented on PR #1098: URL: https://github.com/apache/maven/pull/1098#issuecomment-1534973768 @cstamas I think the description of adding this command in `mvn -help` is still missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-7670) Upgrade misc dependencies
[ https://issues.apache.org/jira/browse/MNG-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-7670: Assignee: Tamas Cservenak > Upgrade misc dependencies > - > > Key: MNG-7670 > URL: https://issues.apache.org/jira/browse/MNG-7670 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 3.9.2 > > > [INFO] The following dependencies in Dependency Management have newer > versions: > [INFO] com.google.guava:guava .. 30.1-jre -> 31.1-jre > [INFO] org.apache.commons:commons-lang3 . 3.8.1 -> 3.12.0 > [INFO] org.codehaus.plexus:plexus-classworlds 2.6.0 -> 2.7.0 > -[INFO] org.codehaus.plexus:plexus-component-annotations .. 2.1.0 -> > 2.1.1- > -[INFO] org.codehaus.plexus:plexus-utils .. 3.4.2 -> > 3.5.1- > [INFO] org.hamcrest:hamcrest-core 1.3 -> 2.2 > [INFO] org.hamcrest:hamcrest-library . 1.3 -> 2.2 > [INFO] org.mockito:mockito-core 2.21.0 -> 4.11.0 > [INFO] org.powermock:powermock-reflect ... 1.7.4 -> 2.0.9 > [INFO] org.xmlunit:xmlunit-core .. 2.2.1 -> 2.9.1 > [INFO] org.xmlunit:xmlunit-matchers .. 2.2.1 -> 2.9.1 > Logback 1.3.x depends on SLF4J 2.x, Logback 1.4.x requires Java 11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7774) Maven config and command line interpolation
[
https://issues.apache.org/jira/browse/MNG-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719380#comment-17719380
]
ASF GitHub Bot commented on MNG-7774:
-
cstamas commented on PR #1098:
URL: https://github.com/apache/maven/pull/1098#issuecomment-1534947001
Anyone else?
> Maven config and command line interpolation
> ---
>
> Key: MNG-7774
> URL: https://issues.apache.org/jira/browse/MNG-7774
> Project: Maven
> Issue Type: Task
> Components: Command Line
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.2
>
>
> Note: this issue "mildly follows" functionality done in Maven 4 as part of
> MNG-7038 and MNG-6303, with partial implementation only (is not full
> back-port), hence "mild introduction".
> Rationale: many new resolver features are akin to be able to store their
> configuration and input along SCM tracked Maven project sources. Sadly,
> currently this is not possible. The two issues targeting Maven4 (MNG-7038 and
> MNG-6303) with introduction of session and project "topDirectory" and
> "rootDirectory" properties solve this. Still, Maven 3.9.x does not need all
> of this.
> So, idea is following:
> * extend MavenCli to interpolate Maven arguments
> * introduce two special properties {{session.rootDirectory}} and
> {{session.topDirectory}} in interpolation. They are special, as they may not
> be defined, and IF they are not defined, their use in Maven argument
> interpolation causes error (Maven will not boot).
> * limit the use of the two new properties to Maven CLI interpolation only.
> This makes projects relying on Maven CLI interpolation "permeable" between
> Maven 3.9.x and Maven 4, while all the whistle and bells (exposing this via
> session or project) will be available in Maven 4 only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #1098: [MNG-7774] Maven config and command line interpolation
cstamas commented on PR #1098: URL: https://github.com/apache/maven/pull/1098#issuecomment-1534947001 Anyone else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pdf-plugin] dependabot[bot] opened a new pull request, #40: Bump maven-shared-utils from 3.3.4 to 3.4.1
dependabot[bot] opened a new pull request, #40: URL: https://github.com/apache/maven-pdf-plugin/pull/40 Bumps [maven-shared-utils](https://github.com/apache/maven-shared-utils) from 3.3.4 to 3.4.1. Release notes Sourced from https://github.com/apache/maven-shared-utils/releases;>maven-shared-utils's releases. 3.4.1 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922version=12353186;>Release Notes New features and improvements https://issues.apache.org/jira/browse/MNG-7729;>[MNG-7729] - deprecate questionable IsEmpty/IsNotEmpty methods (https://redirect.github.com/apache/maven-shared-utils/pull/136;>#136) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1014;>[MSHARED-1014] - Make Commandline.addSystemEnvironment public and deprecated (https://redirect.github.com/apache/maven-shared-utils/pull/138;>#138) https://github.com/slawekjaranowski;>@slawekjaranowski Deprecate newXmlWriter (https://redirect.github.com/apache/maven-shared-utils/pull/131;>#131) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1172;>[MSHARED-1172] - Deprecate redundant isEmptyString method (https://redirect.github.com/apache/maven-shared-utils/pull/123;>#123) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1169;>[MSHARED-1169] - deprecate join methods now available in Java 8 String class (https://redirect.github.com/apache/maven-shared-utils/pull/127;>#127) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1122;>[MSHARED-1122] - FileUtils: avoid getCanonicalPath() (https://redirect.github.com/apache/maven-shared-utils/pull/114;>#114) https://github.com/jukzi;>@jukzi https://issues.apache.org/jira/browse/MSHARED-1079;>[MSHARED-1079] - add build() method and document toString() method (https://redirect.github.com/apache/maven-shared-utils/pull/96;>#96) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-1014;>[MSHARED-1014] - Optionally inherit system environment variables by Commandline (https://redirect.github.com/apache/maven-shared-utils/pull/94;>#94) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-983;>[MSHARED-983] - Drop plexus container default (https://redirect.github.com/apache/maven-shared-utils/pull/87;>#87) https://github.com/cstamas;>@cstamas Bug Fixes https://issues.apache.org/jira/browse/MSHARED-953;>[MSHARED-953] - don't trim (https://redirect.github.com/apache/maven-shared-utils/pull/124;>#124) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1072;>[MSHARED-1072] - fix blocking in StreamFeeder (https://redirect.github.com/apache/maven-shared-utils/pull/113;>#113) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1109;>[MSHARED-1109] - Ignore MessageUtilsTest methods on unsupported platforms (https://redirect.github.com/apache/maven-shared-utils/pull/106;>#106) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-1107;>[MSHARED-1107] - Make copyFile succeed with source file having (https://redirect.github.com/apache/maven-shared-utils/pull/105;>#105) https://github.com/kwin;>@kwin https://issues.apache.org/jira/browse/MSHARED-985;>[MSHARED-985] - XmlWriterUtil platform independent and consistent (https://redirect.github.com/apache/maven-shared-utils/pull/91;>#91) https://github.com/elharo;>@elharo Dependency updates Bump maven-resources-plugin from 3.1.0 to 3.3.1 (https://redirect.github.com/apache/maven-shared-utils/pull/137;>#137) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MSHARED-1196;>[MSHARED-1196] - Bump maven-shared-components from 37 to 39 (https://redirect.github.com/apache/maven-shared-utils/pull/134;>#134) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1197;>[MSHARED-1197] - Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/apache/maven-shared-utils/pull/132;>#132) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 2 to 3 (https://redirect.github.com/apache/maven-shared-utils/pull/130;>#130) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/apache/maven-shared-utils/pull/120;>#120) https://github.com/dependabot;>@dependabot Bump commons-text from 1.3 to 1.10.0 (https://redirect.github.com/apache/maven-shared-utils/pull/119;>#119) https://github.com/dependabot;>@dependabot Bump maven-shared-components from 36 to 37 (https://redirect.github.com/apache/maven-shared-utils/pull/108;>#108) https://github.com/dependabot;>@dependabot Maintenance suggest java.nio.Files.walkFileTree as replacement for
[jira] [Commented] (MRELEASE-1102) prepare-with-pom : NullPointerException when plugin's group-id is a property
[
https://issues.apache.org/jira/browse/MRELEASE-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719310#comment-17719310
]
Michael Osipov commented on MRELEASE-1102:
--
This does not explain why the plugin id can change here. Please explain.
> prepare-with-pom : NullPointerException when plugin's group-id is a property
>
>
> Key: MRELEASE-1102
> URL: https://issues.apache.org/jira/browse/MRELEASE-1102
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare-with-pom
>Affects Versions: 3.0.0-M1, 3.0.0-M4, 3.0.0-M5, 3.0.0-M6
>Reporter: Mahdi Konzali
>Priority: Major
>
> we had in our initial pom
>
>
> ${quarkus.platform.group-id}
> quarkus-maven-plugin
> ${quarkus.platform.version}
> ...
>
> when creating release pom from this original pom we had the error log below :
> Caused by: java.lang.NullPointerException at
> org.apache.maven.artifact.ArtifactUtils.versionlessKey
> (ArtifactUtils.java:77) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.getReleaseVersion
> (GenerateReleasePomsPhase.java:528) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleasePlugins
> (GenerateReleasePomsPhase.java:580) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseModel
> (GenerateReleasePomsPhase.java:297) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePom
> (GenerateReleasePomsPhase.java:164) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePoms
> (GenerateReleasePomsPhase.java:151) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.execute
> (GenerateReleasePomsPhase.java:129) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.simulate
> (GenerateReleasePomsPhase.java:426) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:220) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:122) at
> org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease
> (PrepareReleaseMojo.java:416) at
> org.apache.maven.plugins.release.PrepareWithPomReleaseMojo.execute
> (PrepareWithPomReleaseMojo.java:48) at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> replacing the property by its value resolves the problem by our side.
> But if this passes the build and package goals it should pass the
> prepare-with-pom goal
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1102) prepare-with-pom : NullPointerException when plugin's group-id is a property
[
https://issues.apache.org/jira/browse/MRELEASE-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719301#comment-17719301
]
Mahdi Konzali commented on MRELEASE-1102:
-
because we might have parameters in groupId, it works with maven core goals, so
should be working with release plugin also.
otherwise we can put the value directly to workaround. still I think it's a
nice to have feature
> prepare-with-pom : NullPointerException when plugin's group-id is a property
>
>
> Key: MRELEASE-1102
> URL: https://issues.apache.org/jira/browse/MRELEASE-1102
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare-with-pom
>Affects Versions: 3.0.0-M1, 3.0.0-M4, 3.0.0-M5, 3.0.0-M6
>Reporter: Mahdi Konzali
>Priority: Major
>
> we had in our initial pom
>
>
> ${quarkus.platform.group-id}
> quarkus-maven-plugin
> ${quarkus.platform.version}
> ...
>
> when creating release pom from this original pom we had the error log below :
> Caused by: java.lang.NullPointerException at
> org.apache.maven.artifact.ArtifactUtils.versionlessKey
> (ArtifactUtils.java:77) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.getReleaseVersion
> (GenerateReleasePomsPhase.java:528) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleasePlugins
> (GenerateReleasePomsPhase.java:580) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseModel
> (GenerateReleasePomsPhase.java:297) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePom
> (GenerateReleasePomsPhase.java:164) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePoms
> (GenerateReleasePomsPhase.java:151) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.execute
> (GenerateReleasePomsPhase.java:129) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.simulate
> (GenerateReleasePomsPhase.java:426) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:220) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:122) at
> org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease
> (PrepareReleaseMojo.java:416) at
> org.apache.maven.plugins.release.PrepareWithPomReleaseMojo.execute
> (PrepareWithPomReleaseMojo.java:48) at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> replacing the property by its value resolves the problem by our side.
> But if this passes the build and package goals it should pass the
> prepare-with-pom goal
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1102) prepare-with-pom : NullPointerException when plugin's group-id is a property
[
https://issues.apache.org/jira/browse/MRELEASE-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719252#comment-17719252
]
Michael Osipov commented on MRELEASE-1102:
--
Why do you need to interpolate the group id?
> prepare-with-pom : NullPointerException when plugin's group-id is a property
>
>
> Key: MRELEASE-1102
> URL: https://issues.apache.org/jira/browse/MRELEASE-1102
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare-with-pom
>Affects Versions: 3.0.0-M1, 3.0.0-M4, 3.0.0-M5, 3.0.0-M6
>Reporter: Mahdi Konzali
>Priority: Major
>
> we had in our initial pom
>
>
> ${quarkus.platform.group-id}
> quarkus-maven-plugin
> ${quarkus.platform.version}
> ...
>
> when creating release pom from this original pom we had the error log below :
> Caused by: java.lang.NullPointerException at
> org.apache.maven.artifact.ArtifactUtils.versionlessKey
> (ArtifactUtils.java:77) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.getReleaseVersion
> (GenerateReleasePomsPhase.java:528) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleasePlugins
> (GenerateReleasePomsPhase.java:580) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseModel
> (GenerateReleasePomsPhase.java:297) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePom
> (GenerateReleasePomsPhase.java:164) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePoms
> (GenerateReleasePomsPhase.java:151) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.execute
> (GenerateReleasePomsPhase.java:129) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.simulate
> (GenerateReleasePomsPhase.java:426) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:220) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:122) at
> org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease
> (PrepareReleaseMojo.java:416) at
> org.apache.maven.plugins.release.PrepareWithPomReleaseMojo.execute
> (PrepareWithPomReleaseMojo.java:48) at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> replacing the property by its value resolves the problem by our side.
> But if this passes the build and package goals it should pass the
> prepare-with-pom goal
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1102) prepare-with-pom : NullPointerException when plugin's group-id is a property
[
https://issues.apache.org/jira/browse/MRELEASE-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719251#comment-17719251
]
Michael Osipov commented on MRELEASE-1102:
--
Can you raise a PR with an IT?
> prepare-with-pom : NullPointerException when plugin's group-id is a property
>
>
> Key: MRELEASE-1102
> URL: https://issues.apache.org/jira/browse/MRELEASE-1102
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare-with-pom
>Affects Versions: 3.0.0-M1, 3.0.0-M4, 3.0.0-M5, 3.0.0-M6
>Reporter: Mahdi Konzali
>Priority: Major
>
> we had in our initial pom
>
>
> ${quarkus.platform.group-id}
> quarkus-maven-plugin
> ${quarkus.platform.version}
> ...
>
> when creating release pom from this original pom we had the error log below :
> Caused by: java.lang.NullPointerException at
> org.apache.maven.artifact.ArtifactUtils.versionlessKey
> (ArtifactUtils.java:77) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.getReleaseVersion
> (GenerateReleasePomsPhase.java:528) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleasePlugins
> (GenerateReleasePomsPhase.java:580) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseModel
> (GenerateReleasePomsPhase.java:297) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePom
> (GenerateReleasePomsPhase.java:164) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePoms
> (GenerateReleasePomsPhase.java:151) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.execute
> (GenerateReleasePomsPhase.java:129) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.simulate
> (GenerateReleasePomsPhase.java:426) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:220) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:122) at
> org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease
> (PrepareReleaseMojo.java:416) at
> org.apache.maven.plugins.release.PrepareWithPomReleaseMojo.execute
> (PrepareWithPomReleaseMojo.java:48) at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> replacing the property by its value resolves the problem by our side.
> But if this passes the build and package goals it should pass the
> prepare-with-pom goal
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1114) Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6
[
https://issues.apache.org/jira/browse/MRELEASE-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MRELEASE-1114:
Description:
Before [https://github.com/apache/maven-release/pull/125], when gpg-plugin
runs, it triggered the cert password prompt window of Kleopatra but now it
fails right away with {{{}no pinentry{}}}.
{noformat}
[INFO] [INFO] --- gpg:3.0.1:sign (sign-release-artifacts) @ mrelease-1114 ---
[INFO] gpg: signing failed: No pinentry
[INFO] gpg: signing failed: No pinentry
[INFO] [INFO]
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO]
[INFO] [INFO] Total time: 1.130 s
[INFO] [INFO] Finished at: 2023-05-03T02:47:31+02:00
[INFO] [INFO]
[INFO] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-gpg-plugin:3.0.1:sign (sign-release-artifacts)
on project mrelease-1114: Exit code: 2 -> [Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and possible solutions,
please read the following articles:
[INFO] [ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3.622 s
[INFO] Finished at: 2023-05-03T02:54:16+02:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:3.0.0:perform (default-cli) on
project mrelease-1114: Maven execution failed, exit code: 1 -> [Help 1]
{noformat}
See also
[https://github.com/apache/maven-release/pull/125#issuecomment-1160398620] and
the following comments.
h2. WORKAROUND
init the GPG agent:
- with Maven: {{mvn gpg:sign}}
- or more basically in pure shell: {{echo "test" | gpg --clearsign}}
then you can run {{mvn release:perform}} again and it will be successful (it's
perfectly supported by maven-release-plugin to retry the perform step)
was:
Before [https://github.com/apache/maven-release/pull/125], when gpg-plugin
runs, it triggered the cert password prompt window of Kleopatra but now it
fails right away with {{{}no pinentry{}}}.
{noformat}
[INFO] [INFO] --- gpg:3.0.1:sign (sign-release-artifacts) @ mrelease-1114 ---
[INFO] gpg: signing failed: No pinentry
[INFO] gpg: signing failed: No pinentry
[INFO] [INFO]
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO]
[INFO] [INFO] Total time: 1.130 s
[INFO] [INFO] Finished at: 2023-05-03T02:47:31+02:00
[INFO] [INFO]
[INFO] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-gpg-plugin:3.0.1:sign (sign-release-artifacts)
on project mrelease-1114: Exit code: 2 -> [Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and possible solutions,
please read the following articles:
[INFO] [ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3.622 s
[INFO] Finished at: 2023-05-03T02:54:16+02:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:3.0.0:perform (default-cli) on
project mrelease-1114: Maven execution failed, exit code: 1 -> [Help 1]
{noformat}
See also
[https://github.com/apache/maven-release/pull/125#issuecomment-1160398620] and
the following comments.
h2. WORKAROUND
run {{mvn gpg:sign}} to init the GPG agent
or more basically {{echo "test" | gpg --clearsign}} in pure shell
then you can run {{mvn release:perform}} again and it will be successful (it's
perfectly supported by maven-release-plugin to retry the perform step)
> Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6
>
>
> Key: MRELEASE-1114
> URL:
[jira] [Updated] (MRELEASE-1114) Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6
[
https://issues.apache.org/jira/browse/MRELEASE-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MRELEASE-1114:
Description:
Before [https://github.com/apache/maven-release/pull/125], when gpg-plugin
runs, it triggered the cert password prompt window of Kleopatra but now it
fails right away with {{{}no pinentry{}}}.
{noformat}
[INFO] [INFO] --- gpg:3.0.1:sign (sign-release-artifacts) @ mrelease-1114 ---
[INFO] gpg: signing failed: No pinentry
[INFO] gpg: signing failed: No pinentry
[INFO] [INFO]
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO]
[INFO] [INFO] Total time: 1.130 s
[INFO] [INFO] Finished at: 2023-05-03T02:47:31+02:00
[INFO] [INFO]
[INFO] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-gpg-plugin:3.0.1:sign (sign-release-artifacts)
on project mrelease-1114: Exit code: 2 -> [Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and possible solutions,
please read the following articles:
[INFO] [ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3.622 s
[INFO] Finished at: 2023-05-03T02:54:16+02:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:3.0.0:perform (default-cli) on
project mrelease-1114: Maven execution failed, exit code: 1 -> [Help 1]
{noformat}
See also
[https://github.com/apache/maven-release/pull/125#issuecomment-1160398620] and
the following comments.
h2. WORKAROUND
run {{mvn gpg:sign}} to init the GPG agent
or more basically {{echo "test" | gpg --clearsign}} in pure shell
then you can run {{mvn release:perform}} again and it will be successful (it's
perfectly supported by maven-release-plugin to retry the perform step)
was:
Before https://github.com/apache/maven-release/pull/125, when gpg-plugin runs,
it triggered the cert password prompt window of Kleopatra but now it fails
right away with {{no pinentry}}.
{noformat}
[INFO] [INFO] --- gpg:3.0.1:sign (sign-release-artifacts) @ mrelease-1114 ---
[INFO] gpg: signing failed: No pinentry
[INFO] gpg: signing failed: No pinentry
[INFO] [INFO]
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO]
[INFO] [INFO] Total time: 1.130 s
[INFO] [INFO] Finished at: 2023-05-03T02:47:31+02:00
[INFO] [INFO]
[INFO] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-gpg-plugin:3.0.1:sign (sign-release-artifacts)
on project mrelease-1114: Exit code: 2 -> [Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and possible solutions,
please read the following articles:
[INFO] [ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3.622 s
[INFO] Finished at: 2023-05-03T02:54:16+02:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:3.0.0:perform (default-cli) on
project mrelease-1114: Maven execution failed, exit code: 1 -> [Help 1]
{noformat}
See also
https://github.com/apache/maven-release/pull/125#issuecomment-1160398620 and
the following comments.
h2. WORKAROUND
run {{mvn gpg:sign}} to init the GPG agent (or more basically {{echo "test" |
gpg --clearsign}} in pure shell)
then you can run {{mvn release:perform}} again and it will be successful (it's
perfectly supported by maven-release-plugin to retry the perform step)
> Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6
>
>
> Key: MRELEASE-1114
> URL: https://issues.apache.org/jira/browse/MRELEASE-1114
>
[jira] [Created] (MGPG-98) non-reproducible pom.xml
Herve Boutemy created MGPG-98:
-
Summary: non-reproducible pom.xml
Key: MGPG-98
URL: https://issues.apache.org/jira/browse/MGPG-98
Project: Maven GPG Plugin
Issue Type: Bug
Affects Versions: 3.0.1, 3.1.0
Reporter: Herve Boutemy
generated {{dependency-reduced-pom.xml}} contains environment's specific data
(build directory, path to Maven ...)
see
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/maven/plugins/maven-gpg-plugin/README.md
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1102) prepare-with-pom : NullPointerException when plugin's group-id is a property
[
https://issues.apache.org/jira/browse/MRELEASE-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719241#comment-17719241
]
Mahdi Konzali commented on MRELEASE-1102:
-
In fact no, because if it's so we must not have nullPointerException.
I've been through the source code and I figured out that in the map
construction you did the interpolation so we have like map= [quarkus.io :
\{Artifact}]
and later when you create release pom you don't do interpolation so you try to
do map.get(${quarkus.platform.group-id}) which returns null .
It's globally that, you can start from line ArtifactUtils.java:77 to figure
this out.
may be the solution is to add interpolation for groupIds in the release pom
creation.
Thanks and regards.
> prepare-with-pom : NullPointerException when plugin's group-id is a property
>
>
> Key: MRELEASE-1102
> URL: https://issues.apache.org/jira/browse/MRELEASE-1102
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare-with-pom
>Affects Versions: 3.0.0-M1, 3.0.0-M4, 3.0.0-M5, 3.0.0-M6
>Reporter: Mahdi Konzali
>Priority: Major
>
> we had in our initial pom
>
>
> ${quarkus.platform.group-id}
> quarkus-maven-plugin
> ${quarkus.platform.version}
> ...
>
> when creating release pom from this original pom we had the error log below :
> Caused by: java.lang.NullPointerException at
> org.apache.maven.artifact.ArtifactUtils.versionlessKey
> (ArtifactUtils.java:77) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.getReleaseVersion
> (GenerateReleasePomsPhase.java:528) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleasePlugins
> (GenerateReleasePomsPhase.java:580) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseModel
> (GenerateReleasePomsPhase.java:297) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePom
> (GenerateReleasePomsPhase.java:164) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePoms
> (GenerateReleasePomsPhase.java:151) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.execute
> (GenerateReleasePomsPhase.java:129) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.simulate
> (GenerateReleasePomsPhase.java:426) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:220) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:122) at
> org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease
> (PrepareReleaseMojo.java:416) at
> org.apache.maven.plugins.release.PrepareWithPomReleaseMojo.execute
> (PrepareWithPomReleaseMojo.java:48) at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> replacing the property by its value resolves the problem by our side.
> But if this passes the build and package goals it should pass the
> prepare-with-pom goal
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MRELEASE-1102) prepare-with-pom : NullPointerException when plugin's group-id is a property
[
https://issues.apache.org/jira/browse/MRELEASE-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719241#comment-17719241
]
Mahdi Konzali edited comment on MRELEASE-1102 at 5/4/23 9:47 AM:
-
In fact no, because if it's so we must not have nullPointerException.
I've been through the source code and I figured out that in the map
construction you did the interpolation so we have like map= [quarkus.io :
\{Artifact}]
and later when you create release pom you don't do interpolation so you try to
do map.get(${quarkus.platform.group-id}) which returns null .
It's globally that, you can start from line ArtifactUtils.java:77 to figure
this out.
may be the solution is to add interpolation for groupIds in the release pom
creation.
Thanks and regards.
was (Author: JIRAUSER293500):
In fact no, because if it's so we must not have nullPointerException.
I've been through the source code and I figured out that in the map
construction you did the interpolation so we have like map= [quarkus.io :
\{Artifact}]
and later when you create release pom you don't do interpolation so you try to
do map.get(${quarkus.platform.group-id}) which returns null .
It's globally that, you can start from line ArtifactUtils.java:77 to figure
this out.
may be the solution is to add interpolation for groupIds in the release pom
creation.
Thanks and regards.
> prepare-with-pom : NullPointerException when plugin's group-id is a property
>
>
> Key: MRELEASE-1102
> URL: https://issues.apache.org/jira/browse/MRELEASE-1102
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare-with-pom
>Affects Versions: 3.0.0-M1, 3.0.0-M4, 3.0.0-M5, 3.0.0-M6
>Reporter: Mahdi Konzali
>Priority: Major
>
> we had in our initial pom
>
>
> ${quarkus.platform.group-id}
> quarkus-maven-plugin
> ${quarkus.platform.version}
> ...
>
> when creating release pom from this original pom we had the error log below :
> Caused by: java.lang.NullPointerException at
> org.apache.maven.artifact.ArtifactUtils.versionlessKey
> (ArtifactUtils.java:77) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.getReleaseVersion
> (GenerateReleasePomsPhase.java:528) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleasePlugins
> (GenerateReleasePomsPhase.java:580) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseModel
> (GenerateReleasePomsPhase.java:297) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePom
> (GenerateReleasePomsPhase.java:164) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.generateReleasePoms
> (GenerateReleasePomsPhase.java:151) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.execute
> (GenerateReleasePomsPhase.java:129) at
> org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.simulate
> (GenerateReleasePomsPhase.java:426) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:220) at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare
> (DefaultReleaseManager.java:122) at
> org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease
> (PrepareReleaseMojo.java:416) at
> org.apache.maven.plugins.release.PrepareWithPomReleaseMojo.execute
> (PrepareWithPomReleaseMojo.java:48) at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> replacing the property by its value resolves the problem by our side.
> But if this passes the build and package goals it should pass the
> prepare-with-pom goal
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7774) Maven config and command line interpolation
[
https://issues.apache.org/jira/browse/MNG-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719222#comment-17719222
]
ASF GitHub Bot commented on MNG-7774:
-
cstamas commented on PR #1098:
URL: https://github.com/apache/maven/pull/1098#issuecomment-1534339709
> Does this actually supersede #1062?
No, that one is for master and builds on top of already present new mvn4
features not present in 3.9.x. This PR is for 3.9.x and "mildly follows" the
one you refer to, with reduced functionalities. For example, that one uses
`RootLocator` (already on master) while we have no such thing. Master also uses
two strategies to identify "root", but it requires consumer POM feature, again
not available here, etc. This PR provides "minimum viable change" to provide in
3.9.x:
* config and command line interpolation
* two new properties (but for interpolation ONLY), unlike on master, where
these two bubble up to session and project
* the UT is intentionally 1:1 (so it IS copy pasted from referenced PR)
> Maven config and command line interpolation
> ---
>
> Key: MNG-7774
> URL: https://issues.apache.org/jira/browse/MNG-7774
> Project: Maven
> Issue Type: Task
> Components: Command Line
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.2
>
>
> Note: this issue "mildly follows" functionality done in Maven 4 as part of
> MNG-7038 and MNG-6303, with partial implementation only (is not full
> back-port), hence "mild introduction".
> Rationale: many new resolver features are akin to be able to store their
> configuration and input along SCM tracked Maven project sources. Sadly,
> currently this is not possible. The two issues targeting Maven4 (MNG-7038 and
> MNG-6303) with introduction of session and project "topDirectory" and
> "rootDirectory" properties solve this. Still, Maven 3.9.x does not need all
> of this.
> So, idea is following:
> * extend MavenCli to interpolate Maven arguments
> * introduce two special properties {{session.rootDirectory}} and
> {{session.topDirectory}} in interpolation. They are special, as they may not
> be defined, and IF they are not defined, their use in Maven argument
> interpolation causes error (Maven will not boot).
> * limit the use of the two new properties to Maven CLI interpolation only.
> This makes projects relying on Maven CLI interpolation "permeable" between
> Maven 3.9.x and Maven 4, while all the whistle and bells (exposing this via
> session or project) will be available in Maven 4 only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #1098: [MNG-7774] Maven config and command line interpolation
cstamas commented on PR #1098: URL: https://github.com/apache/maven/pull/1098#issuecomment-1534339709 > Does this actually supersede #1062? No, that one is for master and builds on top of already present new mvn4 features not present in 3.9.x. This PR is for 3.9.x and "mildly follows" the one you refer to, with reduced functionalities. For example, that one uses `RootLocator` (already on master) while we have no such thing. Master also uses two strategies to identify "root", but it requires consumer POM feature, again not available here, etc. This PR provides "minimum viable change" to provide in 3.9.x: * config and command line interpolation * two new properties (but for interpolation ONLY), unlike on master, where these two bubble up to session and project * the UT is intentionally 1:1 (so it IS copy pasted from referenced PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7774) Maven config and command line interpolation
[
https://issues.apache.org/jira/browse/MNG-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719214#comment-17719214
]
ASF GitHub Bot commented on MNG-7774:
-
michael-o commented on PR #1098:
URL: https://github.com/apache/maven/pull/1098#issuecomment-1534325920
Does this actually supersede https://github.com/apache/maven/pull/1062?
> Maven config and command line interpolation
> ---
>
> Key: MNG-7774
> URL: https://issues.apache.org/jira/browse/MNG-7774
> Project: Maven
> Issue Type: Task
> Components: Command Line
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.2
>
>
> Note: this issue "mildly follows" functionality done in Maven 4 as part of
> MNG-7038 and MNG-6303, with partial implementation only (is not full
> back-port), hence "mild introduction".
> Rationale: many new resolver features are akin to be able to store their
> configuration and input along SCM tracked Maven project sources. Sadly,
> currently this is not possible. The two issues targeting Maven4 (MNG-7038 and
> MNG-6303) with introduction of session and project "topDirectory" and
> "rootDirectory" properties solve this. Still, Maven 3.9.x does not need all
> of this.
> So, idea is following:
> * extend MavenCli to interpolate Maven arguments
> * introduce two special properties {{session.rootDirectory}} and
> {{session.topDirectory}} in interpolation. They are special, as they may not
> be defined, and IF they are not defined, their use in Maven argument
> interpolation causes error (Maven will not boot).
> * limit the use of the two new properties to Maven CLI interpolation only.
> This makes projects relying on Maven CLI interpolation "permeable" between
> Maven 3.9.x and Maven 4, while all the whistle and bells (exposing this via
> session or project) will be available in Maven 4 only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #1098: [MNG-7774] Maven config and command line interpolation
michael-o commented on PR #1098: URL: https://github.com/apache/maven/pull/1098#issuecomment-1534325920 Does this actually supersede https://github.com/apache/maven/pull/1062? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRRESOURCES-130) Refresh download page
[ https://issues.apache.org/jira/browse/MRRESOURCES-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MRRESOURCES-130. --- Resolution: Fixed > Refresh download page > - > > Key: MRRESOURCES-130 > URL: https://issues.apache.org/jira/browse/MRRESOURCES-130 > Project: Maven Remote Resources Plugin > Issue Type: Task >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-remote-resources-plugin] slawekjaranowski merged pull request #31: [MRRESOURCES-130] Refresh download page
slawekjaranowski merged PR #31: URL: https://github.com/apache/maven-remote-resources-plugin/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRRESOURCES-130) Refresh download page
[ https://issues.apache.org/jira/browse/MRRESOURCES-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719205#comment-17719205 ] ASF GitHub Bot commented on MRRESOURCES-130: slawekjaranowski merged PR #31: URL: https://github.com/apache/maven-remote-resources-plugin/pull/31 > Refresh download page > - > > Key: MRRESOURCES-130 > URL: https://issues.apache.org/jira/browse/MRRESOURCES-130 > Project: Maven Remote Resources Plugin > Issue Type: Task >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SUREFIRE-1986) New element "rerunSkipped" in XSD of XML Test Report
[ https://issues.apache.org/jira/browse/SUREFIRE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-1986: - Fix Version/s: (was: 3.1.0) > New element "rerunSkipped" in XSD of XML Test Report > > > Key: SUREFIRE-1986 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1986 > Project: Maven Surefire > Issue Type: New Feature > Components: Maven Failsafe Plugin, Maven Surefire Plugin, xml > generation >Reporter: Tibor Digana >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRRESOURCES-132) Dependency improvements
[
https://issues.apache.org/jira/browse/MRRESOURCES-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719201#comment-17719201
]
ASF GitHub Bot commented on MRRESOURCES-132:
slawekjaranowski merged PR #33:
URL: https://github.com/apache/maven-remote-resources-plugin/pull/33
> Dependency improvements
> ---
>
> Key: MRRESOURCES-132
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-132
> Project: Maven Remote Resources Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.1.0
>
>
> {noformat}
> [INFO] --- dependency:3.4.0:analyze (default-cli) @
> maven-remote-resources-plugin ---
> [WARNING] Used undeclared dependencies found:
> [WARNING] org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.5:provided
> [WARNING] org.apache.maven:maven-model-builder:jar:3.2.5:provided
> [WARNING] org.eclipse.aether:aether-impl:jar:1.0.0.v20140518:provided
> [WARNING] org.apache.maven:maven-aether-provider:jar:3.2.5:provided
> [WARNING] org.eclipse.aether:aether-util:jar:1.0.0.v20140518:provided
> [WARNING] org.eclipse.aether:aether-api:jar:1.0.0.v20140518:provided
> [WARNING] org.codehaus.plexus:plexus-utils:jar:3.5.1:compile
> [WARNING] Unused declared dependencies found:
> [WARNING] org.apache.maven:maven-settings:jar:3.2.5:provided
> [WARNING] org.apache.maven:maven-compat:jar:3.2.5:test
> [WARNING] org.slf4j:slf4j-simple:jar:1.7.36:test
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MRRESOURCES-132) Dependency improvements
[
https://issues.apache.org/jira/browse/MRRESOURCES-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MRRESOURCES-132.
---
Resolution: Fixed
> Dependency improvements
> ---
>
> Key: MRRESOURCES-132
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-132
> Project: Maven Remote Resources Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.1.0
>
>
> {noformat}
> [INFO] --- dependency:3.4.0:analyze (default-cli) @
> maven-remote-resources-plugin ---
> [WARNING] Used undeclared dependencies found:
> [WARNING] org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.5:provided
> [WARNING] org.apache.maven:maven-model-builder:jar:3.2.5:provided
> [WARNING] org.eclipse.aether:aether-impl:jar:1.0.0.v20140518:provided
> [WARNING] org.apache.maven:maven-aether-provider:jar:3.2.5:provided
> [WARNING] org.eclipse.aether:aether-util:jar:1.0.0.v20140518:provided
> [WARNING] org.eclipse.aether:aether-api:jar:1.0.0.v20140518:provided
> [WARNING] org.codehaus.plexus:plexus-utils:jar:3.5.1:compile
> [WARNING] Unused declared dependencies found:
> [WARNING] org.apache.maven:maven-settings:jar:3.2.5:provided
> [WARNING] org.apache.maven:maven-compat:jar:3.2.5:test
> [WARNING] org.slf4j:slf4j-simple:jar:1.7.36:test
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-remote-resources-plugin] slawekjaranowski merged pull request #33: [MRRESOURCES-132] Dependency improvements
slawekjaranowski merged PR #33: URL: https://github.com/apache/maven-remote-resources-plugin/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2162) Document upcoming mojo and file names change
[ https://issues.apache.org/jira/browse/SUREFIRE-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719198#comment-17719198 ] ASF GitHub Bot commented on SUREFIRE-2162: -- michael-o opened a new pull request, #628: URL: https://github.com/apache/maven-surefire/pull/628 This closes #628 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Document upcoming mojo and file names change > > > Key: SUREFIRE-2162 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2162 > Project: Maven Surefire > Issue Type: Sub-task > Components: Maven Surefire Report Plugin >Affects Versions: 3.0.0 >Reporter: Michael Osipov >Priority: Major > Fix For: 3.1.0 > > > Since we are going to break stuff, let's announce it on the front page first. > https://maven.apache.org/surefire/maven-surefire-report-plugin/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-surefire] michael-o opened a new pull request, #628: [SUREFIRE-2162] Document upcoming mojo and file names change
michael-o opened a new pull request, #628: URL: https://github.com/apache/maven-surefire/pull/628 This closes #628 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7774) Maven config and command line interpolation
[
https://issues.apache.org/jira/browse/MNG-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719191#comment-17719191
]
ASF GitHub Bot commented on MNG-7774:
-
cstamas commented on code in PR #1098:
URL: https://github.com/apache/maven/pull/1098#discussion_r1184662324
##
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##
@@ -309,6 +320,47 @@ void initialize(CliRequest cliRequest) throws
ExitException {
}
}
+// We need to locate the top level project which may be pointed at
using
+// the -f/--file option. However, the command line isn't parsed yet,
so
+// we need to iterate through the args to find it and act upon it.
+Path topDirectory = Paths.get(cliRequest.workingDirectory);
+boolean isAltFile = false;
+for (String arg : cliRequest.args) {
+if (isAltFile) {
+// this is the argument following -f/--file
+Path path = topDirectory.resolve(arg);
+if (Files.isDirectory(path)) {
+topDirectory = path;
+} else if (Files.isRegularFile(path)) {
+topDirectory = path.getParent();
+if (!Files.isDirectory(topDirectory)) {
+System.err.println("Directory " + topDirectory
++ " extracted from the -f/--file command-line
argument " + arg + " does not exist");
+throw new ExitException(1);
+}
+} else {
+System.err.println(
+"POM file " + arg + " specified with the -f/--file
command line argument does not exist");
+throw new ExitException(1);
+}
+break;
+} else {
+// Check if this is the -f/--file option
+isAltFile =
arg.equals(String.valueOf(CLIManager.ALTERNATE_POM_FILE)) || arg.equals("file");
+}
+}
+try {
+topDirectory = topDirectory.toAbsolutePath().toRealPath();
+} catch (IOException e) {
+System.err.println("Error computing real path from " +
topDirectory);
Review Comment:
Agreed, included IOEx message as well
> Maven config and command line interpolation
> ---
>
> Key: MNG-7774
> URL: https://issues.apache.org/jira/browse/MNG-7774
> Project: Maven
> Issue Type: Task
> Components: Command Line
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.2
>
>
> Note: this issue "mildly follows" functionality done in Maven 4 as part of
> MNG-7038 and MNG-6303, with partial implementation only (is not full
> back-port), hence "mild introduction".
> Rationale: many new resolver features are akin to be able to store their
> configuration and input along SCM tracked Maven project sources. Sadly,
> currently this is not possible. The two issues targeting Maven4 (MNG-7038 and
> MNG-6303) with introduction of session and project "topDirectory" and
> "rootDirectory" properties solve this. Still, Maven 3.9.x does not need all
> of this.
> So, idea is following:
> * extend MavenCli to interpolate Maven arguments
> * introduce two special properties {{session.rootDirectory}} and
> {{session.topDirectory}} in interpolation. They are special, as they may not
> be defined, and IF they are not defined, their use in Maven argument
> interpolation causes error (Maven will not boot).
> * limit the use of the two new properties to Maven CLI interpolation only.
> This makes projects relying on Maven CLI interpolation "permeable" between
> Maven 3.9.x and Maven 4, while all the whistle and bells (exposing this via
> session or project) will be available in Maven 4 only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)
cstamas commented on code in PR #1098:
URL: https://github.com/apache/maven/pull/1098#discussion_r1184662324
##
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##
@@ -309,6 +320,47 @@ void initialize(CliRequest cliRequest) throws
ExitException {
}
}
+// We need to locate the top level project which may be pointed at
using
+// the -f/--file option. However, the command line isn't parsed yet,
so
+// we need to iterate through the args to find it and act upon it.
+Path topDirectory = Paths.get(cliRequest.workingDirectory);
+boolean isAltFile = false;
+for (String arg : cliRequest.args) {
+if (isAltFile) {
+// this is the argument following -f/--file
+Path path = topDirectory.resolve(arg);
+if (Files.isDirectory(path)) {
+topDirectory = path;
+} else if (Files.isRegularFile(path)) {
+topDirectory = path.getParent();
+if (!Files.isDirectory(topDirectory)) {
+System.err.println("Directory " + topDirectory
++ " extracted from the -f/--file command-line
argument " + arg + " does not exist");
+throw new ExitException(1);
+}
+} else {
+System.err.println(
+"POM file " + arg + " specified with the -f/--file
command line argument does not exist");
+throw new ExitException(1);
+}
+break;
+} else {
+// Check if this is the -f/--file option
+isAltFile =
arg.equals(String.valueOf(CLIManager.ALTERNATE_POM_FILE)) || arg.equals("file");
+}
+}
+try {
+topDirectory = topDirectory.toAbsolutePath().toRealPath();
+} catch (IOException e) {
+System.err.println("Error computing real path from " +
topDirectory);
Review Comment:
Agreed, included IOEx message as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2161:
-
Component/s: Maven Surefire Report Plugin
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SUREFIRE-2162) Document upcoming mojo and file names change
Michael Osipov created SUREFIRE-2162: Summary: Document upcoming mojo and file names change Key: SUREFIRE-2162 URL: https://issues.apache.org/jira/browse/SUREFIRE-2162 Project: Maven Surefire Issue Type: Sub-task Components: Maven Surefire Report Plugin Affects Versions: 3.0.0 Reporter: Michael Osipov Fix For: 3.1.0 Since we are going to break stuff, let's announce it on the front page first. https://maven.apache.org/surefire/maven-surefire-report-plugin/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2161:
-
Issue Type: Task (was: Improvement)
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2161:
-
Affects Version/s: 3.0.0
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2161:
-
Description:
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
{{failsafe}} |
| {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
| {{SurefireReportOnlyMojo}} || -{{surefire-report}}- \\ {{surefire}} |
was:
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} | -{{failsafe-report}}- \\
{{failsafe}} |
| {{SurefireReport}} | | -{{surefire-report}}- \\ {{surefire}} |
| {{SurefireReportOnlyMojo}} | | -{{surefire-report}}- \\ {{surefire}} |
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Michael Osipov
>Priority: Major
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireReportOnlyMojo}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned SUREFIRE-2161:
Assignee: Michael Osipov
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2161:
-
Description:
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
{{failsafe}} |
| {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
| {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
was:
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
{{failsafe}} |
| {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
| {{SurefireReportOnlyMojo}} || -{{surefire-report}}- \\ {{surefire}} |
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Michael Osipov
>Priority: Major
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SUREFIRE-2161) Align Mojo class names and output names
Michael Osipov created SUREFIRE-2161:
Summary: Align Mojo class names and output names
Key: SUREFIRE-2161
URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
Project: Maven Surefire
Issue Type: Improvement
Reporter: Michael Osipov
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} | -{{failsafe-report}}- \\
{{failsafe}} |
| {{SurefireReport}} | | -{{surefire-report}}- \\ {{surefire}} |
| {{SurefireReportOnlyMojo}} | | -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SUREFIRE-2130) Rewrite several test classes in report plugin for upcoming Doxia 2.0.0 stack
[
https://issues.apache.org/jira/browse/SUREFIRE-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SUREFIRE-2130.
Resolution: Fixed
Fixed by the linked issues.
> Rewrite several test classes in report plugin for upcoming Doxia 2.0.0 stack
>
>
> Key: SUREFIRE-2130
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2130
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0-M7
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Blocker
> Fix For: 3.1.0
>
>
> https://github.com/apache/maven-surefire/tree/master/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report:
> {{Surefire597Test}}, {{SurefireReportMojoTest}} use too much low level
> classes like concrete sinks, {{DecorationModel}}, {{SiteRenderingContext}}.
> Some of these will change or be removed in Doxia 2.0.0. Approaches like in
> MPIR, with a plugin specific abstract test class is required to do all the
> hefty, and high level lifting without using Doxia innards. If this isn't done
> already with Doxia 1.x these tests will not even compile with Doxia 2.0.0 and
> need to be commented out/removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SUREFIRE-2153) Replace SurefireReportGenerator with a new SurefireReportRenderer
[
https://issues.apache.org/jira/browse/SUREFIRE-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SUREFIRE-2153.
Resolution: Fixed
Fixed with
[33d30c6e018c92447006765c90cb43153ef5385c|https://gitbox.apache.org/repos/asf?p=maven-surefire.git=commit=33d30c6e018c92447006765c90cb43153ef5385c].
> Replace SurefireReportGenerator with a new SurefireReportRenderer
> -
>
> Key: SUREFIRE-2153
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2153
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0-M9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> The problem with {{SurefireReportGenerator}} is that is has been written 10+
> years ago. It does not use {{AbstractMavenReportRenderer}} which causes a lot
> of code duplication. It shall be superseded with {{SurefireReportRenderer}}
> which does extend from the abstract renderer.
> The new renderer will also modernize the way data is displayed:
> * {{SurefireReportParser}} is supposed to collect data, not to format it.
> This is a task of the view layer
> * Separate percent and number formatters
> * Hide full table row instead of leaving ugly condensed one because of hidden
> div
> * Remove redudant div around verbatim block
> * Simplify renderer due to the foundatation on abstact renderer
> * Simplify tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SUREFIRE-2160) Replace LocalizedProperties with (Custom)I18N approach from MPIR
[
https://issues.apache.org/jira/browse/SUREFIRE-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SUREFIRE-2160.
Resolution: Fixed
Fixed with
[6718f14fd1031def148834c6bef71b61759021af|https://gitbox.apache.org/repos/asf?p=maven-surefire.git=commit=6718f14fd1031def148834c6bef71b61759021af].
> Replace LocalizedProperties with (Custom)I18N approach from MPIR
>
>
> Key: SUREFIRE-2160
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2160
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Surefire uses its own approach for custom properties, but MPIR has developed
> a very nice one around {{I18N}} reuse that approach to load default and
> custom bundles.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2153) Replace SurefireReportGenerator with a new SurefireReportRenderer
[
https://issues.apache.org/jira/browse/SUREFIRE-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719180#comment-17719180
]
ASF GitHub Bot commented on SUREFIRE-2153:
--
asfgit closed pull request #625: SUREFIRE-2153 + SUREFIRE-2160
URL: https://github.com/apache/maven-surefire/pull/625
> Replace SurefireReportGenerator with a new SurefireReportRenderer
> -
>
> Key: SUREFIRE-2153
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2153
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0-M9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> The problem with {{SurefireReportGenerator}} is that is has been written 10+
> years ago. It does not use {{AbstractMavenReportRenderer}} which causes a lot
> of code duplication. It shall be superseded with {{SurefireReportRenderer}}
> which does extend from the abstract renderer.
> The new renderer will also modernize the way data is displayed:
> * {{SurefireReportParser}} is supposed to collect data, not to format it.
> This is a task of the view layer
> * Separate percent and number formatters
> * Hide full table row instead of leaving ugly condensed one because of hidden
> div
> * Remove redudant div around verbatim block
> * Simplify renderer due to the foundatation on abstact renderer
> * Simplify tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-surefire] asfgit closed pull request #625: SUREFIRE-2153 + SUREFIRE-2160
asfgit closed pull request #625: SUREFIRE-2153 + SUREFIRE-2160 URL: https://github.com/apache/maven-surefire/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
