[jira] [Commented] (ARCHETYPE-648) upgrade plexus-util 3 to plexus-utils 4 + plexus-xml 3
[ https://issues.apache.org/jira/browse/ARCHETYPE-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764017#comment-17764017 ] ASF GitHub Bot commented on ARCHETYPE-648: -- hboutemy opened a new pull request, #153: URL: https://github.com/apache/maven-archetype/pull/153 (no comment) > upgrade plexus-util 3 to plexus-utils 4 + plexus-xml 3 > -- > > Key: ARCHETYPE-648 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-648 > Project: Maven Archetype > Issue Type: Dependency upgrade >Affects Versions: 3.2.1 >Reporter: Herve Boutemy >Priority: Major > Fix For: 3.2.2 > > > - Modello generated code for archetype-descriptor and archetype-catalog > require Maven 3 XML APIs to read/write XML descriptors => plexus-xml 3 is a > key requirement > - plexus-xml 4 is Maven 4 specific, then upgrading plexus-xml from 3 to 4 has > to be avoided > - plexus-utils 4 remains useful as code generated by Modello still require a > few classes like StringUtils... > this upgrade is a proof of seamless upgrade from plexus-utils 3 to > plexus-utils 4 + plexus-xml 3 when XML API are required > MJARSIGNER-71 is the proof when plexus-xml is even not required in the upgrade -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARCHETYPE-648) upgrade plexus-util 3 to plexus-utils 4 + plexus-xml 3
Herve Boutemy created ARCHETYPE-648: --- Summary: upgrade plexus-util 3 to plexus-utils 4 + plexus-xml 3 Key: ARCHETYPE-648 URL: https://issues.apache.org/jira/browse/ARCHETYPE-648 Project: Maven Archetype Issue Type: Dependency upgrade Affects Versions: 3.2.1 Reporter: Herve Boutemy Fix For: 3.2.2 - Modello generated code for archetype-descriptor and archetype-catalog require Maven 3 XML APIs to read/write XML descriptors => plexus-xml 3 is a key requirement - plexus-xml 4 is Maven 4 specific, then upgrading plexus-xml from 3 to 4 has to be avoided - plexus-utils 4 remains useful as code generated by Modello still require a few classes like StringUtils... this upgrade is a proof of seamless upgrade from plexus-utils 3 to plexus-utils 4 + plexus-xml 3 when XML API are required MJARSIGNER-71 is the proof when plexus-xml is even not required in the upgrade -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJAVADOC-755) Clean up deprecated and unpreferred methods in JavadocUtil
[ https://issues.apache.org/jira/browse/MJAVADOC-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Schmiedehausen updated MJAVADOC-755: Fix Version/s: 3.6.0 > Clean up deprecated and unpreferred methods in JavadocUtil > -- > > Key: MJAVADOC-755 > URL: https://issues.apache.org/jira/browse/MJAVADOC-755 > Project: Maven Javadoc Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.6.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-755) Clean up deprecated and unpreferred methods in JavadocUtil
[ https://issues.apache.org/jira/browse/MJAVADOC-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764009#comment-17764009 ] Henning Schmiedehausen commented on MJAVADOC-755: - works for me. > Clean up deprecated and unpreferred methods in JavadocUtil > -- > > Key: MJAVADOC-755 > URL: https://issues.apache.org/jira/browse/MJAVADOC-755 > Project: Maven Javadoc Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-755) Clean up deprecated and unpreferred methods in JavadocUtil
[ https://issues.apache.org/jira/browse/MJAVADOC-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764010#comment-17764010 ] Henning Schmiedehausen commented on MJAVADOC-755: - we can add a 3.6.0 resolution version (so it shows up in the release notes) but keep the issue open (not resolve and close it). > Clean up deprecated and unpreferred methods in JavadocUtil > -- > > Key: MJAVADOC-755 > URL: https://issues.apache.org/jira/browse/MJAVADOC-755 > Project: Maven Javadoc Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.6.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764008#comment-17764008 ] ASF GitHub Bot commented on MJAVADOC-642: - hgschmie merged PR #238: URL: https://github.com/apache/maven-javadoc-plugin/pull/238 > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Assignee: Henning Schmiedehausen >Priority: Major > Fix For: 3.6.0 > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] hgschmie merged pull request #238: [MJAVADOC-642] Make offline mode configurable
hgschmie merged PR #238: URL: https://github.com/apache/maven-javadoc-plugin/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-707) Plugin won't work if Automatic-Module-Name is used
[
https://issues.apache.org/jira/browse/MJAVADOC-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764007#comment-17764007
]
Henning Schmiedehausen commented on MJAVADOC-707:
-
The next release of the javadoc plugin (3.6.0) will offer a new switch
(legacyMode) which should make this work for you. please try with
{{true}} either with the current snapshot or the next
release.
> Plugin won't work if Automatic-Module-Name is used
> --
>
> Key: MJAVADOC-707
> URL: https://issues.apache.org/jira/browse/MJAVADOC-707
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.3.1, 3.3.2, 3.4.0
>Reporter: Christopher Tubbs
>Priority: Critical
> Labels: jpms
>
> Using Automatic-Module-Name in a manifest (an intermediate step to help
> transition to using modules) prevents this plugin from adding the necessary
> dependencies to the class path, so it can build javadocs.
> maven-compiler-plugin seems to work fine, as does surefire and all the others
> when Automatic-Module-Name entries appear in a project's jar manifests.
> However, this plugin, as of 3.3.1, still does not work correctly with these.
> Instead of using the traditional class path, this plugin seems to force
> treating the project as a module, even though it does not have any
> module-info.java files, and most of its dependencies have not transitioned to
> using modules.
> Here's a pull request that demonstrates adding the Automatic-Module-Name to
> the manifest for a multi-module (Maven module) project, that fails on the
> javadoc plugin:
> https://github.com/apache/accumulo/pull/2498 ; both javadoc:aggregate and
> javadoc:jar are known to fail. I did not test with any other mojos.
> Not supporting this feature holds all projects back from being able to
> transition to modules over time.
> http://branchandbound.net/blog/java/2017/12/automatic-module-name/
> https://docs.oracle.com/javase/9/docs/api/java/lang/module/ModuleFinder.html#automatic-modules
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-build-cache-extension] dependabot[bot] merged pull request #101: Bump com.github.tomakehurst:wiremock-jre8 from 2.35.0 to 2.35.1
dependabot[bot] merged PR #101: URL: https://github.com/apache/maven-build-cache-extension/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] dependabot[bot] merged pull request #100: Bump slf4jVersion from 1.7.32 to 1.7.36
dependabot[bot] merged PR #100: URL: https://github.com/apache/maven-build-cache-extension/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-32) Do not print exception when probing builds in remote repo
[
https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763975#comment-17763975
]
ASF GitHub Bot commented on MBUILDCACHE-32:
---
olamy merged PR #33:
URL: https://github.com/apache/maven-build-cache-extension/pull/33
> Do not print exception when probing builds in remote repo
> -
>
> Key: MBUILDCACHE-32
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Major
> Labels: pull-request-available
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When cache engine tries to discover existing cache by checksum, it sends get
> request.
> This request is normally getting 404s, because cache is not guaranteed to
> exist.
> It's a normal situation and exception should not be printed in such case as
> it meaninglessly pollutes logs:
> {code:java}
> org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
> https://my-cache/.../buildinfo.xml, status: 404 Not Found
> at
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
> (AbstractHttpClientWagon.java:1191)
> at
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
> (AbstractHttpClientWagon.java:1140)
> at org.apache.maven.wagon.StreamWagon.getInputStream
> (StreamWagon.java:126)
> at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
> (StreamWagon.java:226)
> at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
> at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
> (WagonTransporter.java:533)
> at org.eclipse.aether.transport.wagon.WagonTransporter.execute
> (WagonTransporter.java:425)
> at org.eclipse.aether.transport.wagon.WagonTransporter.get
> (WagonTransporter.java:400)
> at
> org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
> (RemoteCacheRepositoryImpl.java:165)
> at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
> (RemoteCacheRepositoryImpl.java:114)
> at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
> (LocalCacheRepositoryImpl.java:183)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:212)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:179)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:114)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:179)
> {code}
> {{Need to create method similar to
> RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
> and use it when probing buildinfo.xml. the method should not log exceptions}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-build-cache-extension] olamy merged pull request #33: [MBUILDCACHE-32] Do not print exception when probing builds
olamy merged PR #33: URL: https://github.com/apache/maven-build-cache-extension/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRRESOURCES-139) Bump maven-archiver from 3.6.0 to 3.6.1
[ https://issues.apache.org/jira/browse/MRRESOURCES-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763963#comment-17763963 ] ASF GitHub Bot commented on MRRESOURCES-139: slawekjaranowski opened a new pull request, #43: URL: https://github.com/apache/maven-remote-resources-plugin/pull/43 Avoid using deprecated methods > Bump maven-archiver from 3.6.0 to 3.6.1 > --- > > Key: MRRESOURCES-139 > URL: https://issues.apache.org/jira/browse/MRRESOURCES-139 > Project: Maven Remote Resources Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763959#comment-17763959
]
ASF GitHub Bot commented on MNG-7864:
-
gnodet commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1322129967
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
What's the actual value for this parameter ? It should be computed, but I
don't really see any computation in this file. See the [computation for GitHub
actions](https://github.com/apache/maven/blob/master/.github/workflows/maven.yml#L76-L99).
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1239: [MNG-7864] Fix the S390x to use IT branches
gnodet commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1322129967
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
What's the actual value for this parameter ? It should be computed, but I
don't really see any computation in this file. See the [computation for GitHub
actions](https://github.com/apache/maven/blob/master/.github/workflows/maven.yml#L76-L99).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763958#comment-17763958
]
ASF GitHub Bot commented on MNG-7864:
-
gnodet commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1322129967
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
What's the actual value for this parameter ? It should be computed, but I
don't really see any computation in this file.
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1239: [MNG-7864] Fix the S390x to use IT branches
gnodet commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1322129967
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
What's the actual value for this parameter ? It should be computed, but I
don't really see any computation in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MGPG-90) Signing fails with 3.0.1: "no pinentry"
[ https://issues.apache.org/jira/browse/MGPG-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763941#comment-17763941 ] Łukasz Dywicki commented on MGPG-90: I believe that I've ran into this one with github actions executing maven-gpg-plugin 3.0.1 under maven release plugin 3.0.1. I've tried also maven-gpg-plugin 3.1.0, but it failed too. I've had to revert to release 3.0.0-M6 in order to conduct proper maven release, is there any workaround available to battle this incompatibility? > Signing fails with 3.0.1: "no pinentry" > --- > > Key: MGPG-90 > URL: https://issues.apache.org/jira/browse/MGPG-90 > Project: Maven GPG Plugin > Issue Type: Bug >Affects Versions: 3.0.1 >Reporter: Jens Reimann >Priority: Blocker > > Starting with 3.0.1 performing a maven release fails in the process of > signing artifacts with the message: "gpg: no pinentry". > I do believe this is due to the fact that in non-interactive mode with a > newer `gpg` version, the gpg plugin forces a "pinentry error" if no pin is > provided. And the release plugin runs the gpg plugin in non-interactive mode > However, not everyone wants to store the pin in a configuration file. > Assuming you have an interactive release process, you also might want an > interactive pin entry. > I would suggest to allow the user to force the pin entry to interactive (not > matter what the current maven context says). That way, you can keep the > current behavior, but still allow a manual/interactive release process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7873) Export missing Xpp3DomBuilder
[ https://issues.apache.org/jira/browse/MNG-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763925#comment-17763925 ] Herve Boutemy commented on MNG-7873: plexus-xml 3.0.0 released: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-xml/ and PR explaining it ready: https://github.com/codehaus-plexus/plexus-xml/pull/24 > Export missing Xpp3DomBuilder > - > > Key: MNG-7873 > URL: https://issues.apache.org/jira/browse/MNG-7873 > Project: Maven > Issue Type: Bug > Components: Core >Reporter: Guillaume Nodet >Priority: Major > Fix For: 3.9.5 > > > See https://lists.apache.org/thread/ltd1g1dbv0lqqdw5q941gmrkfyn6m87m -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763900#comment-17763900 ] ASF GitHub Bot commented on MNG-7864: - vivkong opened a new pull request, #1239: URL: https://github.com/apache/maven/pull/1239 JIRA issue: https://issues.apache.org/jira/browse/MNG-7864 This should allow integration testing on s390x to use the appropriate IT branches. @elharo @gnodet would you mind reviewing this? Thanks! I appreciate any help to get it set up in Jenkins so s390x builds can be run again. --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Fix the S390x to use IT branches > > > Key: MNG-7864 > URL: https://issues.apache.org/jira/browse/MNG-7864 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Priority: Major > > When testing a PR, the maven-integration-testing branch with the same name > should be used instead of master if it exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] vivkong opened a new pull request, #1239: [MNG-7864] Fix the S390x to use IT branches
vivkong opened a new pull request, #1239: URL: https://github.com/apache/maven/pull/1239 JIRA issue: https://issues.apache.org/jira/browse/MNG-7864 This should allow integration testing on s390x to use the appropriate IT branches. @elharo @gnodet would you mind reviewing this? Thanks! I appreciate any help to get it set up in Jenkins so s390x builds can be run again. --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[ https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763879#comment-17763879 ] ASF GitHub Bot commented on MJAVADOC-742: - cstamas commented on PR #186: URL: https://github.com/apache/maven-javadoc-plugin/pull/186#issuecomment-1714398990 Thank you all! > [REGRESSION] Transitive dependencies of docletArtifact missing > -- > > Key: MJAVADOC-742 > URL: https://issues.apache.org/jira/browse/MJAVADOC-742 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Patrick Ruckstuhl >Assignee: Tamas Cservenak >Priority: Blocker > Fix For: 3.6.0 > > > It looks like with 3.5.0 transitive dependencies of the docletArtifact are no > longer added to the classpath and generation fails with class not found. > Reverting back to 3.4.1 everything works fine. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763875#comment-17763875 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1714387479 @elharo I've rewritten the `dag` related classes with non public classes. The other copyrighted class originate from within the ASF and the last one was written by me. > Remove dependency on plexus-utils > - > > Key: MNG-7820 > URL: https://issues.apache.org/jira/browse/MNG-7820 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils
gnodet commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1714387479 @elharo I've rewritten the `dag` related classes with non public classes. The other copyrighted class originate from within the ASF and the last one was written by me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[ https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved MJAVADOC-742. -- Fix Version/s: 3.6.0 Assignee: Tamas Cservenak Resolution: Fixed Fixed in https://github.com/apache/maven-javadoc-plugin/commit/24362d288bc70c658cdcced4cc0b60b648180dc7. > [REGRESSION] Transitive dependencies of docletArtifact missing > -- > > Key: MJAVADOC-742 > URL: https://issues.apache.org/jira/browse/MJAVADOC-742 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Patrick Ruckstuhl >Assignee: Tamas Cservenak >Priority: Blocker > Fix For: 3.6.0 > > > It looks like with 3.5.0 transitive dependencies of the docletArtifact are no > longer added to the classpath and generation fails with class not found. > Reverting back to 3.4.1 everything works fine. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[ https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763869#comment-17763869 ] ASF GitHub Bot commented on MJAVADOC-742: - kwin merged PR #186: URL: https://github.com/apache/maven-javadoc-plugin/pull/186 > [REGRESSION] Transitive dependencies of docletArtifact missing > -- > > Key: MJAVADOC-742 > URL: https://issues.apache.org/jira/browse/MJAVADOC-742 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Patrick Ruckstuhl >Priority: Blocker > > It looks like with 3.5.0 transitive dependencies of the docletArtifact are no > longer added to the classpath and generation fails with class not found. > Reverting back to 3.4.1 everything works fine. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7541) Native support for PowerShell to start Maven
[ https://issues.apache.org/jira/browse/MNG-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763858#comment-17763858 ] ASF GitHub Bot commented on MNG-7541: - JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1714361609 @michael-o I understand your reserves, certainly if your see your PS knowledge as humble (I don't see myself as an expert either). At the same time @slachiewicz has given an approval. What's needed in order to get this PR merged? Please let me know what is needed, then I can specifically ask for input/help on the mailing list. > Native support for PowerShell to start Maven > > > Key: MNG-7541 > URL: https://issues.apache.org/jira/browse/MNG-7541 > Project: Maven > Issue Type: Improvement > Components: Command Line >Affects Versions: 3.8.3 > Environment: windows 10 / 11 >Reporter: Jurrian Fahner >Priority: Trivial > Labels: Script, Windows10, Windows11 > > Maven has two files in the bin dir: > ||command||its use|| > |mvn|POSIX shell| > |mvn.cmd|cmd.exe| > On windows there are two ways to write scripts, by using cmd.exe or using > powershell. > If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first. > If it doesn't find anything it will execute `mvn.cmd` as fall-back. > When running maven for starting a server for development purposes and you do > ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)? > As far as I know it is default behaviour of cmd.exe. > Well if I don't want to terminate, I wouldn't press ctrl-c. ;) > It is not the case (as far as I know that Microsoft is going to deprecate > cmd.exe in favor of powershell: > [https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/] > Allthough I think it would be a good move for maven to have also a powershell > script as well... It is possible to integrate elegant support for native help > in powershell, `get-help mvn`. > But it also increases the maintenance effort as well. I don't know whether > this cost outweigh the benefits, though... > By the way I would happy to contribute if it is appreciated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1714361609 @michael-o I understand your reserves, certainly if your see your PS knowledge as humble (I don't see myself as an expert either). At the same time @slachiewicz has given an approval. What's needed in order to get this PR merged? Please let me know what is needed, then I can specifically ask for input/help on the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MNG-7875:
---
Fix Version/s: 4.0.0-alpha-8
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.0-alpha-8, 3.9.5
>
> Attachments: MNG-7875_before_output.png,
> MNG-7875_colorized_output.png, MNG-7875_colorized_output_second.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MNG-7875.
--
Assignee: Herve Boutemy
Resolution: Fixed
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 4.0.0-alpha-8, 3.9.5
>
> Attachments: MNG-7875_before_output.png,
> MNG-7875_colorized_output.png, MNG-7875_colorized_output_second.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763824#comment-17763824
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy merged PR #1231:
URL: https://github.com/apache/maven/pull/1231
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png,
> MNG-7875_colorized_output.png, MNG-7875_colorized_output_second.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] hboutemy merged pull request #1231: MNG-7875 colorize transfer messages
hboutemy merged PR #1231: URL: https://github.com/apache/maven/pull/1231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MNG-7875:
---
Attachment: MNG-7875_colorized_output_second.png
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png,
> MNG-7875_colorized_output.png, MNG-7875_colorized_output_second.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763808#comment-17763808
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1714227158
here it is:
probably less surprising to end-users
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages
hboutemy commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1714227158 here it is:  probably less surprising to end-users -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7876) Add model version analysis and downgrade
[ https://issues.apache.org/jira/browse/MNG-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7876. Resolution: Fixed > Add model version analysis and downgrade > > > Key: MNG-7876 > URL: https://issues.apache.org/jira/browse/MNG-7876 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet merged pull request #1235: [MNG-7876] Model version analysis and downgrade
gnodet merged PR #1235: URL: https://github.com/apache/maven/pull/1235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7876) Add model version analysis and downgrade
[ https://issues.apache.org/jira/browse/MNG-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763801#comment-17763801 ] ASF GitHub Bot commented on MNG-7876: - gnodet merged PR #1235: URL: https://github.com/apache/maven/pull/1235 > Add model version analysis and downgrade > > > Key: MNG-7876 > URL: https://issues.apache.org/jira/browse/MNG-7876 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-integration-testing] gnodet merged pull request #291: [MNG-7876] Add model version analysis and downgrade
gnodet merged PR #291: URL: https://github.com/apache/maven-integration-testing/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763766#comment-17763766
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1714078071
dropped the layout-specific colorization as asked
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages
hboutemy commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1714078071 dropped the layout-specific colorization as asked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jar-plugin] VSVDEv opened a new pull request, #62: skip packaging
VSVDEv opened a new pull request, #62: URL: https://github.com/apache/maven-jar-plugin/pull/62 create parameter skipJar to skip packaging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763716#comment-17763716
]
ASF GitHub Bot commented on MNG-7820:
-
slawekjaranowski commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321550991
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_UNIX = "unix";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OPENVMS = "openvms";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_ZOS = "z/os";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS400 = "os/400";
+
+/**
+ * OpenJDK is reported to call MacOS X "Darwin"
+ *
+ * @see https://issues.apache.org/bugzilla/show_bug.cgi?id=44889;>bugzilla
issue
+ * @see https://issues.apache.org/jira/browse/HADOOP-3318;>HADOOP-3318
+ */
+private static final String DARWIN = "darwin";
+
+/**
+ * The path separator.
+ */
+private static final String PATH_SEP =
System.getProperty("path.separator");
+
+static {
+OS_FAMILY = getOsFamily();
+IS_WINDOWS = isWindowsFamily();
+}
+
+private Os() {}
+
+/**
+ * Determines if the OS on which Maven is executing matches the
+ * given OS family.
+ *
+ * @param family the family to check for
+ * @return true if the OS matches
+ *
+ */
+public static boolean isFamily(String family) {
Review Comment:
Enforcer rule `requireOS` use `plexus.Os` ... so we need check or improve
also enfrcer rule in such cases
> Remove dependency on plexus-utils
> -
>
> Key: MNG-7820
> URL: https://issues.apache.org/jira/browse/MNG-7820
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils
slawekjaranowski commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321550991
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_UNIX = "unix";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OPENVMS = "openvms";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_ZOS = "z/os";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS400 = "os/400";
+
+/**
+ * OpenJDK is reported to call MacOS X "Darwin"
+ *
+ * @see https://issues.apache.org/bugzilla/show_bug.cgi?id=44889;>bugzilla
issue
+ * @see https://issues.apache.org/jira/browse/HADOOP-3318;>HADOOP-3318
+ */
+private static final String DARWIN = "darwin";
+
+/**
+ * The path separator.
+ */
+private static final String PATH_SEP =
System.getProperty("path.separator");
+
+static {
+OS_FAMILY = getOsFamily();
+IS_WINDOWS = isWindowsFamily();
+}
+
+private Os() {}
+
+/**
+ * Determines if the OS on which Maven is executing matches the
+ * given OS family.
+ *
+ * @param family the family to check for
+ * @return true if the OS matches
+ *
+ */
+public static boolean isFamily(String family) {
Review Comment:
Enforcer rule `requireOS` use `plexus.Os` ... so we need check or improve
also enfrcer rule in such cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763680#comment-17763680
]
ASF GitHub Bot commented on MNG-7820:
-
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321446764
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
Review Comment:
same
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
+
+/**
+ * OS family that can be tested for. {@value}
+
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763679#comment-17763679
]
ASF GitHub Bot commented on MNG-7820:
-
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321446465
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
Review Comment:
I disagree, even if I have no idea what `tandem` is, I don't want this PR to
affect the behaviour.
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final
[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321446764
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
Review Comment:
same
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_UNIX = "unix";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OPENVMS = "openvms";
Review Comment:
same
--
This is
[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321446465
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
Review Comment:
I disagree, even if I have no idea what `tandem` is, I don't want this PR to
affect the behaviour.
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763677#comment-17763677
]
ASF GitHub Bot commented on MNG-7820:
-
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321445365
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
Review Comment:
They are documented, this PR is not about changing the current behaviour.
Trimming down the list of supported OS should be a separate JIRA issue / PR.
> Remove dependency on plexus-utils
> -
>
> Key: MNG-7820
> URL: https://issues.apache.org/jira/browse/MNG-7820
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321445365
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
Review Comment:
They are documented, this PR is not about changing the current behaviour.
Trimming down the list of supported OS should be a separate JIRA issue / PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763676#comment-17763676
]
ASF GitHub Bot commented on MNG-7820:
-
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321443872
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_UNIX = "unix";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OPENVMS = "openvms";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_ZOS = "z/os";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS400 = "os/400";
+
+/**
+ * OpenJDK is reported to call MacOS X "Darwin"
+ *
+ * @see https://issues.apache.org/bugzilla/show_bug.cgi?id=44889;>bugzilla
issue
+ * @see https://issues.apache.org/jira/browse/HADOOP-3318;>HADOOP-3318
+ */
+private static final String DARWIN = "darwin";
+
+/**
+ * The path separator.
+ */
+private static final String PATH_SEP =
System.getProperty("path.separator");
+
+static {
+OS_FAMILY = getOsFamily();
+IS_WINDOWS = isWindowsFamily();
+}
+
+private Os() {}
+
+/**
+ * Determines if the OS on which Maven is executing matches the
+ * given OS family.
+ *
+ * @param family the family to check for
+ * @return true if the OS matches
+ *
+ */
+public static boolean isFamily(String family) {
Review Comment:
Yes, I think you missed the fact that it's part of the public Maven 3.x API
because it's used by [OS profile
activation](https://github.com/apache/maven/blob/3ce0d951c199c9a0e9375f23587dcd7b1b657026/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/OperatingSystemProfileActivator.java#L140)
and the families are documented on the [Maven
site](https://maven.apache.org/enforcer/enforcer-rules/requireOS.html), so I
don't think it makes much sense making those constants private as they are
publicly documented, even if technically, they could be made private.
> Remove dependency on plexus-utils
>
[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321443872
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_UNIX = "unix";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OPENVMS = "openvms";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_ZOS = "z/os";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS400 = "os/400";
+
+/**
+ * OpenJDK is reported to call MacOS X "Darwin"
+ *
+ * @see https://issues.apache.org/bugzilla/show_bug.cgi?id=44889;>bugzilla
issue
+ * @see https://issues.apache.org/jira/browse/HADOOP-3318;>HADOOP-3318
+ */
+private static final String DARWIN = "darwin";
+
+/**
+ * The path separator.
+ */
+private static final String PATH_SEP =
System.getProperty("path.separator");
+
+static {
+OS_FAMILY = getOsFamily();
+IS_WINDOWS = isWindowsFamily();
+}
+
+private Os() {}
+
+/**
+ * Determines if the OS on which Maven is executing matches the
+ * given OS family.
+ *
+ * @param family the family to check for
+ * @return true if the OS matches
+ *
+ */
+public static boolean isFamily(String family) {
Review Comment:
Yes, I think you missed the fact that it's part of the public Maven 3.x API
because it's used by [OS profile
activation](https://github.com/apache/maven/blob/3ce0d951c199c9a0e9375f23587dcd7b1b657026/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/OperatingSystemProfileActivator.java#L140)
and the families are documented on the [Maven
site](https://maven.apache.org/enforcer/enforcer-rules/requireOS.html), so I
don't think it makes much sense making those constants private as they are
publicly documented, even if technically, they could be made private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact
[jira] [Commented] (MJAVADOC-755) Clean up deprecated and unpreferred methods in JavadocUtil
[ https://issues.apache.org/jira/browse/MJAVADOC-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763674#comment-17763674 ] Slawomir Jaranowski commented on MJAVADOC-755: -- For me every changes which change code should be included in release notes - even it looks for simple and safe ... everything can happen We can skip, Jira release notes for misspell fix in documentation, code refactor without change code. I have no problem to have one issue in more in one release notes. > Clean up deprecated and unpreferred methods in JavadocUtil > -- > > Key: MJAVADOC-755 > URL: https://issues.apache.org/jira/browse/MJAVADOC-755 > Project: Maven Javadoc Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #1228: resolve Circular dependencies for project org.apache.maven:maven-xml-impl and rename name
gnodet commented on PR #1228: URL: https://github.com/apache/maven/pull/1228#issuecomment-1713728163 > I agree that there is a problem > I don't think the current PR is the right approach > as found [on the ML while discussing on the topic](https://lists.apache.org/thread/8t5szmn8fhlrklhg5dgv496k26tz3w3p), I thin the approach is to create a Maven Shared Component that provides MetaAnnotations, XML API and XML Implementation separately from Maven core > I don't know how to name this release: "Maven fundamentals"? While I'm not opposed to moving things, I don't think this will solve the problem. The problem here is the cycle between maven-xml-impl / plexus-xml / maven-xml-impl. Moving maven-xml-impl in another location won't change that problem, so while this may not be a sufficient solution, I think this PR is still needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763672#comment-17763672
]
ASF GitHub Bot commented on MNG-7875:
-
michael-o commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713724463
> > Please note that we do have different listeners already which are
activated through other flags indirectly.
>
> Can you elaborate? I already asked you about it: [#1231
(comment)](https://github.com/apache/maven/pull/1231#discussion_r1320858589)
Look at impl if the interface. We have for nop, slf4j, no progress and this
one for the tty.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763671#comment-17763671
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713723818
Also, I am willing to accept following PR:
* for 3.9: emphasize (with color) the repoId and baseUrl, leave everything
else as is and make no assumptions about layout
* for 4: do something along the lines of @gnodet idea
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #1231: MNG-7875 colorize transfer messages
michael-o commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713724463 > > Please note that we do have different listeners already which are activated through other flags indirectly. > > Can you elaborate? I already asked you about it: [#1231 (comment)](https://github.com/apache/maven/pull/1231#discussion_r1320858589) Look at impl if the interface. We have for nop, slf4j, no progress and this one for the tty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1231: MNG-7875 colorize transfer messages
cstamas commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713723818 Also, I am willing to accept following PR: * for 3.9: emphasize (with color) the repoId and baseUrl, leave everything else as is and make no assumptions about layout * for 4: do something along the lines of @gnodet idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763670#comment-17763670
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713720193
> Please note that we do have different listeners already which are
activated through other flags indirectly.
Can you elaborate? I already asked you about it:
https://github.com/apache/maven/pull/1231#discussion_r1320858589
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #1231: MNG-7875 colorize transfer messages
cstamas commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713720193 > Please note that we do have different listeners already which are activated through other flags indirectly. Can you elaborate? I already asked you about it: https://github.com/apache/maven/pull/1231#discussion_r1320858589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] elharo merged pull request #444: Bump org.apache.ant:ant from 1.10.13 to 1.10.14
elharo merged PR #444: URL: https://github.com/apache/maven-site/pull/444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-755) Clean up deprecated and unpreferred methods in JavadocUtil
[ https://issues.apache.org/jira/browse/MJAVADOC-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763666#comment-17763666 ] Elliotte Rusty Harold commented on MJAVADOC-755: I think we need to consider that there is a many-to-many-many relationship between PRs, issues, and releases. Release notes sometimes need manual editing to account for this. In this case, I think these changes don't affect the end user experience and should not be included in the release notes. > Clean up deprecated and unpreferred methods in JavadocUtil > -- > > Key: MJAVADOC-755 > URL: https://issues.apache.org/jira/browse/MJAVADOC-755 > Project: Maven Javadoc Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763663#comment-17763663
]
ASF GitHub Bot commented on MNG-7875:
-
michael-o commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713691345
Please note that we do have different listeners already which are activated
through other flags indirectly.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #1231: MNG-7875 colorize transfer messages
michael-o commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713691345 Please note that we do have different listeners already which are activated through other flags indirectly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7873) Export missing Xpp3DomBuilder
[
https://issues.apache.org/jira/browse/MNG-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763659#comment-17763659
]
Guillaume Nodet commented on MNG-7873:
--
{quote}in fact, it's just a finding from cases where people report issues when
upgrading: they upgraded plexus-utils not because there was something they
wanted in the new releaase, but because Dependabot (or equivalent) said there
was a new release available
{quote}
Yes, I was asking for a pointer to such a PR. IIRC, Dependabot includes the
GitHub release notes in the PR, so a prominent warning in the release notes
could help the user decide if he needs to upgrade and to which version.
I think the plexus-xml-3.0 release is a good idea which would definitely make
the transition smoother...
> Export missing Xpp3DomBuilder
> -
>
> Key: MNG-7873
> URL: https://issues.apache.org/jira/browse/MNG-7873
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.5
>
>
> See https://lists.apache.org/thread/ltd1g1dbv0lqqdw5q941gmrkfyn6m87m
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763656#comment-17763656
]
ASF GitHub Bot commented on MNG-7820:
-
elharo commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321373092
##
maven-core/src/main/java/org/apache/maven/utils/dag/Dag.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils.dag;
+
+/*
+ * Copyright The Codehaus Foundation.
Review Comment:
ditto. Possibly start here:
https://incubator.apache.org/ip-clearance/ip-clearance-template.html
##
maven-core/src/main/java/org/apache/maven/utils/dag/CycleDetector.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils.dag;
+
+/*
+ * Copyright The Codehaus Foundation.
Review Comment:
as above
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+
[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils
elharo commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1321373092
##
maven-core/src/main/java/org/apache/maven/utils/dag/Dag.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils.dag;
+
+/*
+ * Copyright The Codehaus Foundation.
Review Comment:
ditto. Possibly start here:
https://incubator.apache.org/ip-clearance/ip-clearance-template.html
##
maven-core/src/main/java/org/apache/maven/utils/dag/CycleDetector.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils.dag;
+
+/*
+ * Copyright The Codehaus Foundation.
Review Comment:
as above
##
maven-model-builder/src/main/java/org/apache/maven/utils/Os.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.utils;
+
+import java.util.Locale;
+import java.util.stream.Stream;
+
+/**
+ * OS support
+ */
+public class Os {
+
+/**
+ * The OS Name.
+ */
+public static final String OS_NAME =
System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OA architecture.
+ */
+public static final String OS_ARCH =
System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
+
+/**
+ * The OS version.
+ */
+public static final String OS_VERSION =
System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+
+/**
+ * OS Family
+ */
+public static final String OS_FAMILY;
+
+public static final boolean IS_WINDOWS;
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WINDOWS = "windows";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_WIN9X = "win9x";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NT = "winnt";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_OS2 = "os/2";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_NETWARE = "netware";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_DOS = "dos";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_MAC = "mac";
+
+/**
+ * OS family that can be tested for. {@value}
+ */
+public static final String FAMILY_TANDEM = "tandem";
+
+/**
+ * OS family that can be
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763649#comment-17763649
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713661630
> As a user, I'm usually not interested in knowing which exacts artifacts
are downloaded, but mainly by the fact that the build is actually downloading
artifacts.
...completely agree, except with this last line (where am more at @hboutemy
side): baseUrl used in download is good to be visible, as a cautious developer
can catch from very first few lines of downloads if the env is not right (ie.
mirror not properly set up, etc). This is why I keep saying that am personally
uninterested in the "Downloading..." line, but am very interested in
"Downloaded..." line.
Thinking more, I kinda agree with @gnodet to keep build logs unspoiled with
downloading/downloaded lines (just to have some deleted line, so progress
should be visible), and maybe at the build end (a la validation) have some
summary table? Like by repoId/baseUrl/countOfDowmloaded artifacts?
Basically, _current Maven logging_ could be called "detailed" (as Maven
3.9.x behaves today), and introduce something like
`maven.download.logging=summary` where NO downloading/downloaded are emitted,
but only a summary at build end?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #1231: MNG-7875 colorize transfer messages
cstamas commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713661630 > As a user, I'm usually not interested in knowing which exacts artifacts are downloaded, but mainly by the fact that the build is actually downloading artifacts. ...completely agree, except with this last line (where am more at @hboutemy side): baseUrl used in download is good to be visible, as a cautious developer can catch from very first few lines of downloads if the env is not right (ie. mirror not properly set up, etc). This is why I keep saying that am personally uninterested in the "Downloading..." line, but am very interested in "Downloaded..." line. Thinking more, I kinda agree with @gnodet to keep build logs unspoiled with downloading/downloaded lines (just to have some deleted line, so progress should be visible), and maybe at the build end (a la validation) have some summary table? Like by repoId/baseUrl/countOfDowmloaded artifacts? Basically, _current Maven logging_ could be called "detailed" (as Maven 3.9.x behaves today), and introduce something like `maven.download.logging=summary` where NO downloading/downloaded are emitted, but only a summary at build end? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763644#comment-17763644
]
ASF GitHub Bot commented on MNG-7875:
-
gnodet commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713641040
Another possibility would be to implement something different when in
interactive mode:
* when some downloads starts, print a line saying saying Maven is
downloading
* eventually put some progression, but all on a single line (i.e. only the
last line is ever modified
* when downloads are done, completely erase the download line and continue
with normal build log
This can be easily achieved using JLine... (as has already been proven to
work inside Maven Daemon)
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763604#comment-17763604
]
ASF GitHub Bot commented on MNG-7875:
-
laeubi commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713448740
If the problem is "transfer message are currently hard to read for many
users" I must confess that I agree that adding color make them not easier to
read (for me as a user) and maybe one should better try to enhance the
message?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] laeubi commented on pull request #1231: MNG-7875 colorize transfer messages
laeubi commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713448740 If the problem is "transfer message are currently hard to read for many users" I must confess that I agree that adding color make them not easier to read (for me as a user) and maybe one should better try to enhance the message? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763601#comment-17763601
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713435810
if the goal is https://issues.apache.org/jira/browse/MNG-7875 (please take
time to read it), it reaches its goal
if there is another goal (and I understand there is), please open a Jira
issue describing the goal: I don't get fully this other goal
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages
hboutemy commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713435810 if the goal is https://issues.apache.org/jira/browse/MNG-7875 (please take time to read it), it reaches its goal if there is another goal (and I understand there is), please open a Jira issue describing the goal: I don't get fully this other goal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763592#comment-17763592 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1713389394 @elharo could you take another look ? > Remove dependency on plexus-utils > - > > Key: MNG-7820 > URL: https://issues.apache.org/jira/browse/MNG-7820 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-integration-testing] gnodet opened a new pull request, #291: [MNG-7876] Add model version analysis and downgrade
gnodet opened a new pull request, #291: URL: https://github.com/apache/maven-integration-testing/pull/291 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7876) Add model version analysis and downgrade
Guillaume Nodet created MNG-7876: Summary: Add model version analysis and downgrade Key: MNG-7876 URL: https://issues.apache.org/jira/browse/MNG-7876 Project: Maven Issue Type: New Feature Reporter: Guillaume Nodet Assignee: Guillaume Nodet Fix For: 4.0.0-alpha-8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[ https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763588#comment-17763588 ] ASF GitHub Bot commented on MJAVADOC-742: - kwin commented on PR #186: URL: https://github.com/apache/maven-javadoc-plugin/pull/186#issuecomment-1713368390 The NPE noted above can only be reproduced on JDK8 (the test works with JDK11 or above). > [REGRESSION] Transitive dependencies of docletArtifact missing > -- > > Key: MJAVADOC-742 > URL: https://issues.apache.org/jira/browse/MJAVADOC-742 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Patrick Ruckstuhl >Priority: Blocker > > It looks like with 3.5.0 transitive dependencies of the docletArtifact are no > longer added to the classpath and generation fails with class not found. > Reverting back to 3.4.1 everything works fine. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7866) Improvements to the logging API usage (technical debt)
[
https://issues.apache.org/jira/browse/MNG-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763586#comment-17763586
]
ASF GitHub Bot commented on MNG-7866:
-
gnodet commented on code in PR #1220:
URL: https://github.com/apache/maven/pull/1220#discussion_r1321137864
##
maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java:
##
@@ -152,16 +149,15 @@ private ClassRealm createRealm(
List parentImports,
Map foreignImports,
List artifacts) {
-Set artifactIds = new LinkedHashSet<>();
-
-List constituents = new ArrayList<>();
+List constituents = new ArrayList<>(artifacts
== null ? 0 : artifacts.size());
-if (artifacts != null) {
+if (artifacts != null && !artifacts.isEmpty()) {
for (Artifact artifact : artifacts) {
if (!isProvidedArtifact(artifact)) {
-artifactIds.add(getId(artifact));
if (artifact.getFile() != null) {
constituents.add(new
ArtifactClassRealmConstituent(artifact));
+} else if (logger.isDebugEnabled()) {
+logger.debug(" Excluded: {}", getId(artifact));
Review Comment:
Re-reading this PR before merging, I think this is slightly wrong.
I think artifacts should be considered excluded and logged if
`isProvidedArtifact` returns `true`, which I think is the main reason for the
exclusion, as they kinda are supposed to always point to a file.
> Improvements to the logging API usage (technical debt)
> --
>
> Key: MNG-7866
> URL: https://issues.apache.org/jira/browse/MNG-7866
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Minor
> Fix For: 4.0.0-alpha-8
>
>
> Since maven 4 is now using the Slf4J logger API, some logging code can be
> improved.
> Typical improvements are:
> * Use message formats with placeholders to avoid premature formatting and
> avoid the unnecessary garbage when then log level is disabled. Example :
>
> {code:java}
> logger.debug("Toolchains configuration was not found at " +
> userToolchainsFile);
> {code}
> can be replaced with :
> {code:java}
> logger.debug("Toolchains configuration was not found at {}",
> userToolchainsFile);{code}
> * Guarding some logging statements with conditionals on isEnabled() to
> avoid unnecessary garbage when then log level is disabled. Useful when some
> formatting must be done outside the logger call. Example :
>
> {code:java}
> } else {
> Lifecycle original = phaseToLifecycleMap.get(phase);
> logger.warn("Duplicated lifecycle phase " + phase + ".
> Defined in " + original.getId()
> + " but also in " + lifecycle.getId());
> }
> {code}
> can be replaced with the following code to avoid the cost of the map lookup :
>
> {code:java}
> } else if (logger.isWarnEnabled()) {
> Lifecycle original = phaseToLifecycleMap.get(phase);
> logger.warn(
> "Duplicated lifecycle phase {}. Defined in {} but
> also in {}",
> phase,
> original.getId(),
> lifecycle.getId());
> }
> {code}
> * Remove some unneeded conditional guarding to avoid testing twice if the
> log level is enabled, like for example :
>
> {code:java}
> if (logger.isDebugEnabled()) {
> logger.debug("Lifecycle " + lifecycle);
> }
> {code}
> can be replaced with :
> {code:java}
> logger.debug("Lifecycle {}", lifecycle);{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)
gnodet commented on code in PR #1220:
URL: https://github.com/apache/maven/pull/1220#discussion_r1321137864
##
maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java:
##
@@ -152,16 +149,15 @@ private ClassRealm createRealm(
List parentImports,
Map foreignImports,
List artifacts) {
-Set artifactIds = new LinkedHashSet<>();
-
-List constituents = new ArrayList<>();
+List constituents = new ArrayList<>(artifacts
== null ? 0 : artifacts.size());
-if (artifacts != null) {
+if (artifacts != null && !artifacts.isEmpty()) {
for (Artifact artifact : artifacts) {
if (!isProvidedArtifact(artifact)) {
-artifactIds.add(getId(artifact));
if (artifact.getFile() != null) {
constituents.add(new
ArtifactClassRealmConstituent(artifact));
+} else if (logger.isDebugEnabled()) {
+logger.debug(" Excluded: {}", getId(artifact));
Review Comment:
Re-reading this PR before merging, I think this is slightly wrong.
I think artifacts should be considered excluded and logged if
`isProvidedArtifact` returns `true`, which I think is the main reason for the
exclusion, as they kinda are supposed to always point to a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[
https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763582#comment-17763582
]
Konrad Windszus edited comment on MJAVADOC-742 at 9/11/23 7:55 AM:
---
The NPE observed with the reproducer provided above on JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}. According to
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Doclet.java#L86C27-L86C46
null must never be returned there but it does in
https://github.com/tarioch/MJAVADOC-742/blob/18ac22d5073dde43800c341f74fc7fd2b96b85f8/doclet/src/main/java/DummyDoclet.java#L28.
So this NPE is clearly an implementation bug with the reproducer.
Not sure yet, why with JDK 17 this doesn't run into the NPE.
was (Author: kwin):
The NPE observed with JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}. According to
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Doclet.java#L86C27-L86C46
null must never be returned there but it does in
https://github.com/tarioch/MJAVADOC-742/blob/18ac22d5073dde43800c341f74fc7fd2b96b85f8/doclet/src/main/java/DummyDoclet.java#L28.
So this NPE is clearly an implementation bug with the reproducer.
Not sure yet, why with JDK 17 this doesn't run into the NPE.
> [REGRESSION] Transitive dependencies of docletArtifact missing
> --
>
> Key: MJAVADOC-742
> URL: https://issues.apache.org/jira/browse/MJAVADOC-742
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.5.0
>Reporter: Patrick Ruckstuhl
>Priority: Blocker
>
> It looks like with 3.5.0 transitive dependencies of the docletArtifact are no
> longer added to the classpath and generation fails with class not found.
> Reverting back to 3.4.1 everything works fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7866) Improvements to the logging API usage (technical debt)
[
https://issues.apache.org/jira/browse/MNG-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7866:
-
Fix Version/s: 4.0.0-alpha-8
> Improvements to the logging API usage (technical debt)
> --
>
> Key: MNG-7866
> URL: https://issues.apache.org/jira/browse/MNG-7866
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Minor
> Fix For: 4.0.0-alpha-8
>
>
> Since maven 4 is now using the Slf4J logger API, some logging code can be
> improved.
> Typical improvements are:
> * Use message formats with placeholders to avoid premature formatting and
> avoid the unnecessary garbage when then log level is disabled. Example :
>
> {code:java}
> logger.debug("Toolchains configuration was not found at " +
> userToolchainsFile);
> {code}
> can be replaced with :
> {code:java}
> logger.debug("Toolchains configuration was not found at {}",
> userToolchainsFile);{code}
> * Guarding some logging statements with conditionals on isEnabled() to
> avoid unnecessary garbage when then log level is disabled. Useful when some
> formatting must be done outside the logger call. Example :
>
> {code:java}
> } else {
> Lifecycle original = phaseToLifecycleMap.get(phase);
> logger.warn("Duplicated lifecycle phase " + phase + ".
> Defined in " + original.getId()
> + " but also in " + lifecycle.getId());
> }
> {code}
> can be replaced with the following code to avoid the cost of the map lookup :
>
> {code:java}
> } else if (logger.isWarnEnabled()) {
> Lifecycle original = phaseToLifecycleMap.get(phase);
> logger.warn(
> "Duplicated lifecycle phase {}. Defined in {} but
> also in {}",
> phase,
> original.getId(),
> lifecycle.getId());
> }
> {code}
> * Remove some unneeded conditional guarding to avoid testing twice if the
> log level is enabled, like for example :
>
> {code:java}
> if (logger.isDebugEnabled()) {
> logger.debug("Lifecycle " + lifecycle);
> }
> {code}
> can be replaced with :
> {code:java}
> logger.debug("Lifecycle {}", lifecycle);{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[
https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763582#comment-17763582
]
Konrad Windszus edited comment on MJAVADOC-742 at 9/11/23 7:45 AM:
---
The NPE observed with JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}. According to
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Doclet.java#L86C27-L86C46
null must never be returned there but it does in
https://github.com/tarioch/MJAVADOC-742/blob/18ac22d5073dde43800c341f74fc7fd2b96b85f8/doclet/src/main/java/DummyDoclet.java#L28.
So this NPE is clearly an implementation bug with the reproducer.
was (Author: kwin):
The NPE observed with JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}. According to
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Doclet.java#L86C27-L86C46
null must never be returned there.
> [REGRESSION] Transitive dependencies of docletArtifact missing
> --
>
> Key: MJAVADOC-742
> URL: https://issues.apache.org/jira/browse/MJAVADOC-742
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.5.0
>Reporter: Patrick Ruckstuhl
>Priority: Blocker
>
> It looks like with 3.5.0 transitive dependencies of the docletArtifact are no
> longer added to the classpath and generation fails with class not found.
> Reverting back to 3.4.1 everything works fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[
https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763582#comment-17763582
]
Konrad Windszus edited comment on MJAVADOC-742 at 9/11/23 7:45 AM:
---
The NPE observed with JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}. According to
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Doclet.java#L86C27-L86C46
null must never be returned there but it does in
https://github.com/tarioch/MJAVADOC-742/blob/18ac22d5073dde43800c341f74fc7fd2b96b85f8/doclet/src/main/java/DummyDoclet.java#L28.
So this NPE is clearly an implementation bug with the reproducer.
Not sure yet, why with JDK 17 this doesn't run into the NPE.
was (Author: kwin):
The NPE observed with JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}. According to
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Doclet.java#L86C27-L86C46
null must never be returned there but it does in
https://github.com/tarioch/MJAVADOC-742/blob/18ac22d5073dde43800c341f74fc7fd2b96b85f8/doclet/src/main/java/DummyDoclet.java#L28.
So this NPE is clearly an implementation bug with the reproducer.
> [REGRESSION] Transitive dependencies of docletArtifact missing
> --
>
> Key: MJAVADOC-742
> URL: https://issues.apache.org/jira/browse/MJAVADOC-742
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.5.0
>Reporter: Patrick Ruckstuhl
>Priority: Blocker
>
> It looks like with 3.5.0 transitive dependencies of the docletArtifact are no
> longer added to the classpath and generation fails with class not found.
> Reverting back to 3.4.1 everything works fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[
https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763582#comment-17763582
]
Konrad Windszus edited comment on MJAVADOC-742 at 9/11/23 7:44 AM:
---
The NPE observed with JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}. According to
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Doclet.java#L86C27-L86C46
null must never be returned there.
was (Author: kwin):
The NPE observed with JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}.
> [REGRESSION] Transitive dependencies of docletArtifact missing
> --
>
> Key: MJAVADOC-742
> URL: https://issues.apache.org/jira/browse/MJAVADOC-742
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.5.0
>Reporter: Patrick Ruckstuhl
>Priority: Blocker
>
> It looks like with 3.5.0 transitive dependencies of the docletArtifact are no
> longer added to the classpath and generation fails with class not found.
> Reverting back to 3.4.1 everything works fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-742) [REGRESSION] Transitive dependencies of docletArtifact missing
[
https://issues.apache.org/jira/browse/MJAVADOC-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763582#comment-17763582
]
Konrad Windszus commented on MJAVADOC-742:
--
The NPE observed with JDK < 17 happens here:
https://github.com/openjdk/jdk11u-dev/blob/bcce7afba4503e3bc9f1d7dc2aa7de7eca86c764/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L634C34-L634C47.
So {{doclet.getSupportedOptions()}} obviously returns {{null}}.
> [REGRESSION] Transitive dependencies of docletArtifact missing
> --
>
> Key: MJAVADOC-742
> URL: https://issues.apache.org/jira/browse/MJAVADOC-742
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.5.0
>Reporter: Patrick Ruckstuhl
>Priority: Blocker
>
> It looks like with 3.5.0 transitive dependencies of the docletArtifact are no
> longer added to the classpath and generation fails with class not found.
> Reverting back to 3.4.1 everything works fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7870) Undeprecate wrongly deprecated repository metadata
[
https://issues.apache.org/jira/browse/MNG-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763573#comment-17763573
]
ASF GitHub Bot commented on MNG-7870:
-
hboutemy commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1321083887
##
maven-repository-metadata/src/site/apt/index.apt:
##
@@ -27,38 +27,8 @@ Maven Repository Metadata Model
This is strictly the model for Maven Repository Metadata, so really just
plain objects.
- The metadata file name is:
-
- * <<>> in a remote repository,
-
- * <<.xml>>> in a local repository, for metadata
from a repository with <<>> identifier.
-
- []
-
- Depending on what the directory represents ("groupId", "groupId/artifactId"
or "groupId/artifactId/version"),
- the Maven Repository Metadata file contains 3 different sets of metadata:
-
- [[1]] in a "groupId" directory: a "groupId" directory may contain Maven
plugins artifacts, which are described in metadata's <<>> element,
-
- [[2]] in a "groupId/artifactId" directory: metadata describes <<>>,
<<>> and <<>> element that
- gives data about available versions (<<>>, <<>>,
<<>> list and <<>>),
-
- [[3]] in a "groupId/artifactId/version" snapshot artifact directory: metadata
describes <<>>, <<>>, <<>> (base version, i.e.
ending in <<<-SNAPSHOT>>>) and
- <<>> element that gives data about snaphot (<<>>,
<<>> and <<>> list). Notice that a
- release artifact directory is not expected to provide metadata.
-
- []
-
Review Comment:
sorry, I finally overlooked the last update: I think we have the best of
every world now, thank you
> Undeprecate wrongly deprecated repository metadata
> --
>
> Key: MNG-7870
> URL: https://issues.apache.org/jira/browse/MNG-7870
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-alpha-8, 3.9.5
>
>
> In commit
> https://github.com/apache/maven/commit/1af8513fa7512cf25022b249cae0f84062c5085b
> related to MNG-7385 the modello G level metadata was deprecated (by mistake
> I assume).
> Undo this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] hboutemy commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
hboutemy commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1321083887
##
maven-repository-metadata/src/site/apt/index.apt:
##
@@ -27,38 +27,8 @@ Maven Repository Metadata Model
This is strictly the model for Maven Repository Metadata, so really just
plain objects.
- The metadata file name is:
-
- * <<>> in a remote repository,
-
- * <<.xml>>> in a local repository, for metadata
from a repository with <<>> identifier.
-
- []
-
- Depending on what the directory represents ("groupId", "groupId/artifactId"
or "groupId/artifactId/version"),
- the Maven Repository Metadata file contains 3 different sets of metadata:
-
- [[1]] in a "groupId" directory: a "groupId" directory may contain Maven
plugins artifacts, which are described in metadata's <<>> element,
-
- [[2]] in a "groupId/artifactId" directory: metadata describes <<>>,
<<>> and <<>> element that
- gives data about available versions (<<>>, <<>>,
<<>> list and <<>>),
-
- [[3]] in a "groupId/artifactId/version" snapshot artifact directory: metadata
describes <<>>, <<>>, <<>> (base version, i.e.
ending in <<<-SNAPSHOT>>>) and
- <<>> element that gives data about snaphot (<<>>,
<<>> and <<>> list). Notice that a
- release artifact directory is not expected to provide metadata.
-
- []
-
Review Comment:
sorry, I finally overlooked the last update: I think we have the best of
every world now, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (MNG-7873) Export missing Xpp3DomBuilder
[ https://issues.apache.org/jira/browse/MNG-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763567#comment-17763567 ] Herve Boutemy edited comment on MNG-7873 at 9/11/23 7:01 AM: - bq. Do you have a pointer ? in fact, it's just a finding from cases where people report issues when upgrading: they upgraded plexus-utils not because there was something they wanted in the new releaase, but because Dependabot (or equivalent) said there was a new release available then releasing plexus-xml 3 will solve one issue: when they use XML APIs from plexus-utils 3, people can upgrade from plexus-utils 3.x to plexus-utils 4 + plexus-xml 3 this step is necessary IMHO, we need a plexus-xml 3, or we don't have any Maven 3 compatible plexus-xml but I'm anticipating (perhaps I should not try...) that people will upgrade plexus-xml to latest, then introduce back non-Maven 3 compatible release but we need to go step by step... was (Author: hboutemy): bq. Do you have a pointer ? in fact, it's just a finding from cases where people report issues when upgrading: they upgraded plexus-utils not because there was something they wanted in the new releaase, but because Dependabot (or equivalent) said there was a new release available then releasing plexus-xml 3 will solve one issue: people can upgrade from plexus-utils 3.x to plexus-utils 4 + plexus-xml 3 this step is necessary IMHO, we need a plexus-xml 3, or we don't have any Maven 3 compatible plexus-xml but I'm anticipating (perhaps I should not try...) that people will upgrade plexus-xml to latest, then introduce back non-Maven 3 compatible release but we need to go step by step... > Export missing Xpp3DomBuilder > - > > Key: MNG-7873 > URL: https://issues.apache.org/jira/browse/MNG-7873 > Project: Maven > Issue Type: Bug > Components: Core >Reporter: Guillaume Nodet >Priority: Major > Fix For: 3.9.5 > > > See https://lists.apache.org/thread/ltd1g1dbv0lqqdw5q941gmrkfyn6m87m -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] hboutemy commented on pull request #1228: resolve Circular dependencies for project org.apache.maven:maven-xml-impl and rename name
hboutemy commented on PR #1228: URL: https://github.com/apache/maven/pull/1228#issuecomment-1713280315 I agree that there is a problem I don't think the current PR is the right approach as found [on the ML while discussing on the topic](https://lists.apache.org/thread/8t5szmn8fhlrklhg5dgv496k26tz3w3p), I thin the approach is to create a Maven Shared Component that provides MetaAnnotations, XML API and XML Implementation separately from Maven core I don't know how to name this release: "Maven fundamentals"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-482) JavadocSite.createLink() does not consider implicit module path prefix
[ https://issues.apache.org/jira/browse/MPLUGIN-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763568#comment-17763568 ] ASF GitHub Bot commented on MPLUGIN-482: kwin commented on code in PR #226: URL: https://github.com/apache/maven-plugin-tools/pull/226#discussion_r1321068846 ## maven-plugin-tools-api/pom.xml: ## @@ -125,4 +130,30 @@ + + + run-its + + + +org.apache.maven.plugins +maven-failsafe-plugin + + + + integration-test + verify + + + JavadocSite.createLink() does not consider implicit module path prefix > -- > > Key: MPLUGIN-482 > URL: https://issues.apache.org/jira/browse/MPLUGIN-482 > Project: Maven Plugin Tools > Issue Type: Bug > Components: API >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Although the module for a javadoc code reference is looked up (if not > explicitly given by the javadoc reference), it is afterwards not being > considered when the URL is calculated (last argument of > https://github.com/apache/maven-plugin-tools/blob/511d287352836a4dc52227b61208536af5feaded/maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/javadoc/JavadocSite.java#L309 > is just disregarded) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
kwin commented on code in PR #226: URL: https://github.com/apache/maven-plugin-tools/pull/226#discussion_r1321068846 ## maven-plugin-tools-api/pom.xml: ## @@ -125,4 +130,30 @@ + + + run-its + + + +org.apache.maven.plugins +maven-failsafe-plugin + + + + integration-test + verify + + + + nonLtsJavadocs Review Comment: always testing against all ever released JDKs just takes too much time. It is rather advisable to execute that IT manually in case something was fundamentally changed about link creation which might affect all versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-7873) Export missing Xpp3DomBuilder
[ https://issues.apache.org/jira/browse/MNG-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763567#comment-17763567 ] Herve Boutemy edited comment on MNG-7873 at 9/11/23 6:50 AM: - bq. Do you have a pointer ? in fact, it's just a finding from cases where people report issues when upgrading: they upgraded plexus-utils not because there was something they wanted in the new releaase, but because Dependabot (or equivalent) said there was a new release available then releasing plexus-xml 3 will solve one issue: people can upgrade from plexus-utils 3.x to plexus-utils 4 + plexus-xml 3 this step is necessary IMHO, we need a plexus-xml 3, or we don't have any Maven 3 compatible plexus-xml but I'm anticipating (perhaps I should not try...) that people will upgrade plexus-xml to latest, then introduce back non-Maven 3 compatible release but we need to go step by step... was (Author: hboutemy): bq. Do you have a pointer ? in fact, it's just a finding from cases where people report issues when upgrading: they upgraded plexus-utils not because there was something they wanted in the new releaase, but because Dependabot (or equivalent) said there was a new release available then I'm anticipating (perhaps I should not try...) that releasing plexus-xml 3 will solve one issue: people can upgrade from plexus-utils 3.x to plexus-utils 4 + plexus-xml 3 this step is necessary IMHO, we need a plexus-xml 3, or we don't have any Maven 3 compatible plexus-xml I'm anticipating that people will upgrade plexus-xml to latest, then introduce back non-Maven 3 compatible release but we need to go step by step... > Export missing Xpp3DomBuilder > - > > Key: MNG-7873 > URL: https://issues.apache.org/jira/browse/MNG-7873 > Project: Maven > Issue Type: Bug > Components: Core >Reporter: Guillaume Nodet >Priority: Major > Fix For: 3.9.5 > > > See https://lists.apache.org/thread/ltd1g1dbv0lqqdw5q941gmrkfyn6m87m -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MNG-7873) Export missing Xpp3DomBuilder
[ https://issues.apache.org/jira/browse/MNG-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763567#comment-17763567 ] Herve Boutemy edited comment on MNG-7873 at 9/11/23 6:49 AM: - bq. Do you have a pointer ? in fact, it's just a finding from cases where people report issues when upgrading: they upgraded plexus-utils not because there was something they wanted in the new releaase, but because Dependabot (or equivalent) said there was a new release available then I'm anticipating (perhaps I should not try...) that releasing plexus-xml 3 will solve one issue: people can upgrade from plexus-utils 3.x to plexus-utils 4 + plexus-xml 3 this step is necessary IMHO, we need a plexus-xml 3, or we don't have any Maven 3 compatible plexus-xml I'm anticipating that people will upgrade plexus-xml to latest, then introduce back non-Maven 3 compatible release but we need to go step by step... was (Author: hboutemy): bq. Do you have a pointer ? in fact, it's just a finding from cases where people report issues when upgrading: they upgraded plexus-utils not because there was something they wanted in the new releaase, but because Dependabot (or equivalent) said there was a new release available then I'm anticipating that releasing plexus-xml 3 will solve one issue: people can upgrade from plexus-utils 3.x to plexus-utils 4 + plexus-xml 3 this step is necessary IMHO, we need a plexus-xml 3, or we don't have any Maven 3 compatible plexus-xml I'm anticipating that people will upgrade plexus-xml to latest, then introduce back non-Maven 3 compatible release but we need to go step by step... > Export missing Xpp3DomBuilder > - > > Key: MNG-7873 > URL: https://issues.apache.org/jira/browse/MNG-7873 > Project: Maven > Issue Type: Bug > Components: Core >Reporter: Guillaume Nodet >Priority: Major > Fix For: 3.9.5 > > > See https://lists.apache.org/thread/ltd1g1dbv0lqqdw5q941gmrkfyn6m87m -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7873) Export missing Xpp3DomBuilder
[ https://issues.apache.org/jira/browse/MNG-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763567#comment-17763567 ] Herve Boutemy commented on MNG-7873: bq. Do you have a pointer ? in fact, it's just a finding from cases where people report issues when upgrading: they upgraded plexus-utils not because there was something they wanted in the new releaase, but because Dependabot (or equivalent) said there was a new release available then I'm anticipating that releasing plexus-xml 3 will solve one issue: people can upgrade from plexus-utils 3.x to plexus-utils 4 + plexus-xml 3 this step is necessary IMHO, we need a plexus-xml 3, or we don't have any Maven 3 compatible plexus-xml I'm anticipating that people will upgrade plexus-xml to latest, then introduce back non-Maven 3 compatible release but we need to go step by step... > Export missing Xpp3DomBuilder > - > > Key: MNG-7873 > URL: https://issues.apache.org/jira/browse/MNG-7873 > Project: Maven > Issue Type: Bug > Components: Core >Reporter: Guillaume Nodet >Priority: Major > Fix For: 3.9.5 > > > See https://lists.apache.org/thread/ltd1g1dbv0lqqdw5q941gmrkfyn6m87m -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763566#comment-17763566
]
ASF GitHub Bot commented on MNG-7875:
-
rmannibucau commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713265044
@hboutemy not imposing anything, was just sharing my feedback that I think
this PR is a noop regarding the goal which is something I share. Due to the
regular feedback we have on this part I don't think this step is that useful
and I think we can skip it but no issue for me if you want to merge it - code
is more than ok. It is just it does not reach its real goal and just push back
the actual issue IMHO so thought it would be worth thinking to a global
solution instead of a quick workaround.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] rmannibucau commented on pull request #1231: MNG-7875 colorize transfer messages
rmannibucau commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713265044 @hboutemy not imposing anything, was just sharing my feedback that I think this PR is a noop regarding the goal which is something I share. Due to the regular feedback we have on this part I don't think this step is that useful and I think we can skip it but no issue for me if you want to merge it - code is more than ok. It is just it does not reach its real goal and just push back the actual issue IMHO so thought it would be worth thinking to a global solution instead of a quick workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763564#comment-17763564
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713261184
disagree on everything: the PR does what the Jira title and description say
= color to ease understanding
which solve my improvement expectation
your expectations are different, probably complementary, then to be done
separately if you need it: going to slf4j will have other independent impact
I'm not saying that your expectations are wrong: just saying that they are
independent and should not be conflated (or even imposed on something
independent)
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages
hboutemy commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1713261184 disagree on everything: the PR does what the Jira title and description say = color to ease understanding which solve my improvement expectation your expectations are different, probably complementary, then to be done separately if you need it: going to slf4j will have other independent impact I'm not saying that your expectations are wrong: just saying that they are independent and should not be conflated (or even imposed on something independent) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-755) Clean up deprecated and unpreferred methods in JavadocUtil
[ https://issues.apache.org/jira/browse/MJAVADOC-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763563#comment-17763563 ] Slawomir Jaranowski commented on MJAVADOC-755: -- [~henning] but other PR was merged ... so we should report it in release notes ... Maybe we can create separate issue for "plexus --> maven-shared-utils" and this new can be postpone to next release? [~elharo] - what do you think? > Clean up deprecated and unpreferred methods in JavadocUtil > -- > > Key: MJAVADOC-755 > URL: https://issues.apache.org/jira/browse/MJAVADOC-755 > Project: Maven Javadoc Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
