[PR] PMC += henning [maven-parent]
hgschmie opened a new pull request, #143: URL: https://github.com/apache/maven-parent/pull/143 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MCLEAN-111) Fast clean does not work for filesets - files are deleted in foreground
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MCLEAN-111. -- Assignee: Slawomir Jaranowski Resolution: Fixed > Fast clean does not work for filesets - files are deleted in foreground > --- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Assignee: Slawomir Jaranowski >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work for filesets - files are deleted in foreground
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776934#comment-17776934 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769522737 @wilx - thanks for fix > Fast clean does not work for filesets - files are deleted in foreground > --- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature for filesets [maven-clean-plugin]
slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769522737 @wilx - thanks for fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work for filesets - files are deleted in foreground
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776933#comment-17776933 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski merged PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32 > Fast clean does not work for filesets - files are deleted in foreground > --- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature for filesets [maven-clean-plugin]
slawekjaranowski merged PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MCLEAN-111) Fast clean does not work for filesets - files are deleted in foreground
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MCLEAN-111: --- Summary: Fast clean does not work for filesets - files are deleted in foreground (was: Fast clean does not work delete files in the background but in foreground.) > Fast clean does not work for filesets - files are deleted in foreground > --- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-110) Utils.createSymlink should be replace by Java 7 code
[ https://issues.apache.org/jira/browse/MCLEAN-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776927#comment-17776927 ] Slawomir Jaranowski commented on MCLEAN-110: Why not use groovy script? > Utils.createSymlink should be replace by Java 7 code > > > Key: MCLEAN-110 > URL: https://issues.apache.org/jira/browse/MCLEAN-110 > Project: Maven Clean Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Major > > instead of shelling out to command line -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MCLEAN-112) Bump parent to 40
[ https://issues.apache.org/jira/browse/MCLEAN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MCLEAN-112. -- > Bump parent to 40 > - > > Key: MCLEAN-112 > URL: https://issues.apache.org/jira/browse/MCLEAN-112 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPOM-436) Remove quality-checks profile with maven-docck-plugin
[
https://issues.apache.org/jira/browse/MPOM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MPOM-436.
Resolution: Fixed
> Remove quality-checks profile with maven-docck-plugin
> -
>
> Key: MPOM-436
> URL: https://issues.apache.org/jira/browse/MPOM-436
> Project: Maven POMs
> Issue Type: Task
> Components: maven-extensions, maven-plugins
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-41
>
>
> maven-docck-plugin looks not maintained by long time ...
> Example use in m-install-p give an output:
> {noformat}
> [INFO] --- docck:1.1:check (docck-check) @ maven-install-plugin ---
> [INFO] Checking project: Apache Maven Install Plugin
> [INFO] Applying mojo extractor for language: java
> [INFO] Mojo extractor for language: java found 0 mojo descriptors.
> [INFO] Applying mojo extractor for language: bsh
> [INFO] Mojo extractor for language: bsh found 0 mojo descriptors.
> [ERROR] The following documentation problems were found:
> o Apache Maven Install Plugin (3 errors, 0 warnings)
> [ERROR] Failed to parse mojo descriptors.
> Error: No mojo definitions were found for plugin: null:null.
> [ERROR] pom.xml is missing the report plugin: maven-javadoc-plugin.
> [ERROR] pom.xml is missing the report plugin: maven-jxr-plugin.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPOM-436] Remove quality-checks profile with maven-docck-plugin [maven-parent]
slawekjaranowski merged PR #141: URL: https://github.com/apache/maven-parent/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Grammar mistake fixed [maven-clean-plugin]
slawekjaranowski merged PR #31: URL: https://github.com/apache/maven-clean-plugin/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [PR-105] Regression : direct input files located in target (usually s… [maven-build-cache-extension]
kbuntrock opened a new pull request, #105: URL: https://github.com/apache/maven-build-cache-extension/pull/105 Regression : direct input files located in target (usually scanned via scanning plugins configurations) are not correctly excluded. This PR includes the fix + the IT enhancement to test the case. Sincerely yours, Kevin Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [MBUILDCACHE JIRA issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add bmarwell as PMC Member [maven-parent]
bmarwell commented on PR #142: URL: https://github.com/apache/maven-parent/pull/142#issuecomment-1769370258 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add bmarwell as PMC Member [maven-parent]
bmarwell merged PR #142: URL: https://github.com/apache/maven-parent/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
kbuntrock opened a new pull request, #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104 This PR covers some bugfix / enhancements with the restoration of outputs on disk. It is in draft since I expect some discussions. And the IT test has still do be coded. "Au menu" : - Bugfix / "todo" : files in a base directory containing an underscore were wrongly restored to disk (not at the same location). -> To do so, the path is not guessed anymore from the classifier. I introduced a "filePath" property in the "attachedArtifact" section of the buildinfo.xml file. -> Because the buildInfo structure change, I changed the cache implementation version from "v1" to "v1.1". I assume it was one of the purpose of this value : we don't have to deal with structure migration. Any previous cache entry is defacto invalidated. - Forbid the possibility to extract/restore data in a directory outside the project (like extracting ../../../.ssh for example) -> I guess the extraction part is not a vulnerability since someone with commit permissions can guess other ways to extract data. But the possibility of restoring at any place on the disk looks pretty dangerous to me if a remote cache server is compromised. - Gives the possibility to restore artefacts on disk, with a dedicated property : maven.build.cache.restoreOnDiskArtefacts (default to true, open for discussion) - Introduce "globs" to filter extra attached outputs by filenames. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7909) Upgrade to Resolver 2.0.0
[ https://issues.apache.org/jira/browse/MNG-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776908#comment-17776908 ] ASF GitHub Bot commented on MNG-7909: - cstamas commented on PR #1282: URL: https://github.com/apache/maven/pull/1282#issuecomment-1769321300 Seems some more ITs failed, looking... The read poms one is recorded (and is not resolver related) https://issues.apache.org/jira/browse/MRESOLVER-412 Rest needs to be looked at. > Upgrade to Resolver 2.0.0 > - > > Key: MNG-7909 > URL: https://issues.apache.org/jira/browse/MNG-7909 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Post alpha-8 a release of Resolver 2.0.0 (depending on other work, like > transport) becomes possible, so upgrade as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7909] Upgrade to Resolver 2.0.0 [maven]
cstamas commented on PR #1282: URL: https://github.com/apache/maven/pull/1282#issuecomment-1769321300 Seems some more ITs failed, looking... The read poms one is recorded (and is not resolver related) https://issues.apache.org/jira/browse/MRESOLVER-412 Rest needs to be looked at. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-416) New transport: Jetty, HTTP/2 capable
[ https://issues.apache.org/jira/browse/MRESOLVER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776889#comment-17776889 ] ASF GitHub Bot commented on MRESOLVER-416: -- cstamas merged PR #344: URL: https://github.com/apache/maven-resolver/pull/344 > New transport: Jetty, HTTP/2 capable > > > Key: MRESOLVER-416 > URL: https://issues.apache.org/jira/browse/MRESOLVER-416 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Create new transport "jetty" that uses Jetty 10.x (and is HTTP/2 capable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-416] New transport "jetty" [maven-resolver]
cstamas merged PR #344: URL: https://github.com/apache/maven-resolver/pull/344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add bmarwell as PMC Member [maven-parent]
slawekjaranowski commented on PR #142: URL: https://github.com/apache/maven-parent/pull/142#issuecomment-1769166960 > I think I'd rather keep a single source for the team at https://people.apache.org/committers-by-project.html#maven-pmc, but go ahead and merge that one until that's decided (or not). We have here more details, like organization, timezones. And maybe there are a persons not like to be listed ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-416) New transport: Jetty, HTTP/2 capable
[ https://issues.apache.org/jira/browse/MRESOLVER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776859#comment-17776859 ] ASF GitHub Bot commented on MRESOLVER-416: -- cstamas opened a new pull request, #344: URL: https://github.com/apache/maven-resolver/pull/344 (no comment) > New transport: Jetty, HTTP/2 capable > > > Key: MRESOLVER-416 > URL: https://issues.apache.org/jira/browse/MRESOLVER-416 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Create new transport "jetty" that uses Jetty 10.x (and is HTTP/2 capable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]
rmannibucau commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1769109005 @gnodet I'm mixed about it since it assumes everything is wired in plugins conf and plugins/extensions don't read any other property so not sure it is really better today, maybe let's wait to see what mockito picks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]
gnodet commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1769106593 > Well any later phase is wrong cause then it depends if the interpolation will be reprocessed or not so think it is the least bad compromise to work immediately but agree on your point, the limitation is to explicit define the dependency in the project (potentially using a property but without anything implicit). I'm fine dropping this PR if it does not help while we don't add dependency plugin in any default lifecycle. @rmannibucau Wouldn't it be better to enhance the [`PluginParameterExpressionEvaluatorV4`](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluatorV4.java#L209) class instead ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-415) New transport: JDK11 HTTP/2 capable
[ https://issues.apache.org/jira/browse/MRESOLVER-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776840#comment-17776840 ] ASF GitHub Bot commented on MRESOLVER-415: -- cstamas merged PR #343: URL: https://github.com/apache/maven-resolver/pull/343 > New transport: JDK11 HTTP/2 capable > --- > > Key: MRESOLVER-415 > URL: https://issues.apache.org/jira/browse/MRESOLVER-415 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Create new transport "jdk" that uses Java11 java.net.http.HttpClient (and is > HTTP/2 capable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-415] The "jdk" transport [maven-resolver]
cstamas commented on PR #343: URL: https://github.com/apache/maven-resolver/pull/343#issuecomment-1769075799 This is just the (functional) implementation of Resolver "jdk" HTTP/2 transport, tests are coming as part of MRESOLVER-417. --- https://issues.apache.org/jira/browse/MRESOLVER-415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MRESOLVER-415] The "jdk" transport [maven-resolver]
cstamas merged PR #343: URL: https://github.com/apache/maven-resolver/pull/343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-415) New transport: JDK11 HTTP/2 capable
[ https://issues.apache.org/jira/browse/MRESOLVER-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776839#comment-17776839 ] ASF GitHub Bot commented on MRESOLVER-415: -- cstamas commented on PR #343: URL: https://github.com/apache/maven-resolver/pull/343#issuecomment-1769075799 This is just the (functional) implementation of Resolver "jdk" HTTP/2 transport, tests are coming as part of MRESOLVER-417. --- https://issues.apache.org/jira/browse/MRESOLVER-415 > New transport: JDK11 HTTP/2 capable > --- > > Key: MRESOLVER-415 > URL: https://issues.apache.org/jira/browse/MRESOLVER-415 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Create new transport "jdk" that uses Java11 java.net.http.HttpClient (and is > HTTP/2 capable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7772) Allow to register maven core extension in .m2 directory instead of MAVEN_HOME
[
https://issues.apache.org/jira/browse/MNG-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776837#comment-17776837
]
ASF GitHub Bot commented on MNG-7772:
-
gnodet merged PR #1280:
URL: https://github.com/apache/maven/pull/1280
> Allow to register maven core extension in .m2 directory instead of MAVEN_HOME
> --
>
> Key: MNG-7772
> URL: https://issues.apache.org/jira/browse/MNG-7772
> Project: Maven
> Issue Type: Improvement
>Reporter: Roy Teeuwen
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
> Currently the way to register a maven core extension is described here:
> [https://maven.apache.org/guides/mini/guide-using-extensions.html]
> Namely the following ways are supported:
> * Registered via extension jar in {{${maven.home}/lib/ext}}
> * Registered via CLI argument {{mvn -Dmaven.ext.class.path=extension.jar}}
> * Registered via [{{.mvn/extensions.xml}}
> file|https://maven.apache.org/configure.html#mvn-extensions-xml-file]
> The downside of this is that the ${maven.home} directory is not something
> that you should touch, seeing as with every update of maven (through for
> example homebrew), it will replace the directory with the new version, making
> it required to manually re-register the core extension by dragging the jar in
> /lib/ext.
> My proposal is to also make it possible to register the extension through the
> ${user.home}/.m2 directory. This could for example be by also allowing the
> extensions.xml in the .m2 directory or by creating an ext directory in the
> .m2 directory.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7772) Allow to register maven core extension in .m2 directory instead of MAVEN_HOME
[
https://issues.apache.org/jira/browse/MNG-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-7772.
Assignee: Guillaume Nodet
Resolution: Fixed
> Allow to register maven core extension in .m2 directory instead of MAVEN_HOME
> --
>
> Key: MNG-7772
> URL: https://issues.apache.org/jira/browse/MNG-7772
> Project: Maven
> Issue Type: Improvement
>Reporter: Roy Teeuwen
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
> Currently the way to register a maven core extension is described here:
> [https://maven.apache.org/guides/mini/guide-using-extensions.html]
> Namely the following ways are supported:
> * Registered via extension jar in {{${maven.home}/lib/ext}}
> * Registered via CLI argument {{mvn -Dmaven.ext.class.path=extension.jar}}
> * Registered via [{{.mvn/extensions.xml}}
> file|https://maven.apache.org/configure.html#mvn-extensions-xml-file]
> The downside of this is that the ${maven.home} directory is not something
> that you should touch, seeing as with every update of maven (through for
> example homebrew), it will replace the directory with the new version, making
> it required to manually re-register the core extension by dragging the jar in
> /lib/ext.
> My proposal is to also make it possible to register the extension through the
> ${user.home}/.m2 directory. This could for example be by also allowing the
> extensions.xml in the .m2 directory or by creating an ext directory in the
> .m2 directory.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7772] Allow to register maven core extension in .m2 directory instead of MAVEN_HOME [maven]
gnodet merged PR #1280: URL: https://github.com/apache/maven/pull/1280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7772] Test for extensions.xml defined in an ext directory in the… [maven-integration-testing]
gnodet merged PR #311: URL: https://github.com/apache/maven-integration-testing/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776836#comment-17776836 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769070764 > > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > > > > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. > > Yes make sense. > > Can you update documentation? https://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html (source in project src/site/apt/examples/delete_additional_files.apt.vm) > > We should explain such behaviors. I have added a note to the `delete_additional_files.apt.vm`. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769070764 > > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > > > > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. > > Yes make sense. > > Can you update documentation? https://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html (source in project src/site/apt/examples/delete_additional_files.apt.vm) > > We should explain such behaviors. I have added a note to the `delete_additional_files.apt.vm`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]
rmannibucau commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1769070264 Well any later phase is wrong cause then it depends if the interpolation will be reprocessed or not so think it is the least bad compromise to work immediately but agree on your point, the limitation is to explicit define the dependency in the project (potentially using a property but without anything implicit). I'm fine dropping this PR if it does not help while we don't add dependency plugin in any default lifecycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776834#comment-17776834 ] ASF GitHub Bot commented on MCLEAN-111: --- chabala commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769067418 > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. I agree. Looks like fast delete has always required `GlobSelector` to be null, since it was added in #6. So, it has never worked for this `Fileset` parsing path, only the directory parsing path above it at: https://github.com/apache/maven-clean-plugin/blob/f9da326e1b1ad4648d24e646b51cc7bc0a1baad7/src/main/java/org/apache/maven/plugins/clean/CleanMojo.java#L250-L254 > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
chabala commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769067418 > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. I agree. Looks like fast delete has always required `GlobSelector` to be null, since it was added in #6. So, it has never worked for this `Fileset` parsing path, only the directory parsing path above it at: https://github.com/apache/maven-clean-plugin/blob/f9da326e1b1ad4648d24e646b51cc7bc0a1baad7/src/main/java/org/apache/maven/plugins/clean/CleanMojo.java#L250-L254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRESOLVER-417) Create HTTP test suite a la "TCK"
[ https://issues.apache.org/jira/browse/MRESOLVER-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-417: -- Description: Now that we have 3 (4 w/ Wagon) HTTP capable resolver transports, we need some common reusable across HTTP Transports test suite, probably w/ "tunable" features. Requirements aside of "most basic functionality": * MRESOLVER-396 Back off * MRESOLVER-393 Retain last modified (on files) * MRESOLVER-382 Setting outgoing interface * MRESOLVER-361 Unreliable TCP and retries * MRESOLVER-347 and MRESOLVER-348 Pool controls, reuse connection, max TTL * MRESOLVER-339 and MRESOLVER-315 Preemptive auth * MRESOLVER-341 Preemptive PUT auth * MRESOLVER-328 SSL insecure mode * MRESOLVER-326 Retries on certain errors The test should use _standard Resolver configuration with different transports_ as described on page https://maven.apache.org/resolver/configuration.html Hence, testing of Wagon is out of scope, as it uses totally different, ancient Plexus-XML based configuration, does not obey standard resolver configuration properties. was: Now that we have 3 (4 w/ Wagon) HTTP capable resolver transports, we need some common reusable across HTTP Transports test suite, probably w/ "tunable" features. Requirements aside of "most basic functionality": * MRESOLVER-396 Back off * MRESOLVER-393 Retain last modified (on files) * MRESOLVER-382 Setting outgoing interface * MRESOLVER-361 Unreliable TCP and retries * MRESOLVER-347 and MRESOLVER-348 Pool controls, reuse connection, max TTL * MRESOLVER-339 and MRESOLVER-315 Preemptive auth * MRESOLVER-341 Preemptive PUT auth * MRESOLVER-328 SSL insecure mode * MRESOLVER-326 Retries on certain errors The should use _standard Resolver configuration with different transports_ as described on page https://maven.apache.org/resolver/configuration.html Hence, testing of Wagon is out of scope, as it uses totally different, ancient Plexus-XML based configuration, does not obey standard resolver configuration properties. > Create HTTP test suite a la "TCK" > - > > Key: MRESOLVER-417 > URL: https://issues.apache.org/jira/browse/MRESOLVER-417 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Now that we have 3 (4 w/ Wagon) HTTP capable resolver transports, we need > some common reusable across HTTP Transports test suite, probably w/ "tunable" > features. > Requirements aside of "most basic functionality": > * MRESOLVER-396 Back off > * MRESOLVER-393 Retain last modified (on files) > * MRESOLVER-382 Setting outgoing interface > * MRESOLVER-361 Unreliable TCP and retries > * MRESOLVER-347 and MRESOLVER-348 Pool controls, reuse connection, max TTL > * MRESOLVER-339 and MRESOLVER-315 Preemptive auth > * MRESOLVER-341 Preemptive PUT auth > * MRESOLVER-328 SSL insecure mode > * MRESOLVER-326 Retries on certain errors > The test should use _standard Resolver configuration with different > transports_ as described on page > https://maven.apache.org/resolver/configuration.html > Hence, testing of Wagon is out of scope, as it uses totally different, > ancient Plexus-XML based configuration, does not obey standard resolver > configuration properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-417) Create HTTP test suite a la "TCK"
[ https://issues.apache.org/jira/browse/MRESOLVER-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-417: -- Description: Now that we have 3 (4 w/ Wagon) HTTP capable resolver transports, we need some common reusable across HTTP Transports test suite, probably w/ "tunable" features. Requirements aside of "most basic functionality": * MRESOLVER-396 Back off * MRESOLVER-393 Retain last modified (on files) * MRESOLVER-382 Setting outgoing interface * MRESOLVER-361 Unreliable TCP and retries * MRESOLVER-347 and MRESOLVER-348 Pool controls, reuse connection, max TTL * MRESOLVER-339 and MRESOLVER-315 Preemptive auth * MRESOLVER-341 Preemptive PUT auth * MRESOLVER-328 SSL insecure mode * MRESOLVER-326 Retries on certain errors The should use _standard Resolver configuration with different transports_ as described on page https://maven.apache.org/resolver/configuration.html Hence, testing of Wagon is out of scope, as it uses totally different, ancient Plexus-XML based configuration, does not obey standard resolver configuration properties. was: Now that we have 3 (4 w/ Wagon) HTTP capable resolver transports, we need some common reusable across HTTP Transports test suite, probably w/ "tunable" features. Requirements aside of "most basic functionality": * MRESOLVER-396 Back off * MRESOLVER-393 Retain last modified (on files) * MRESOLVER-382 Setting outgoing interface * MRESOLVER-361 Unreliable TCP and retries * MRESOLVER-347 and MRESOLVER-348 Pool controls, reuse connection, max TTL * MRESOLVER-339 and MRESOLVER-315 Preemptive auth * MRESOLVER-341 Preemptive PUT auth * SSL insecure mode * MRESOLVER-326 Retries on certain errors > Create HTTP test suite a la "TCK" > - > > Key: MRESOLVER-417 > URL: https://issues.apache.org/jira/browse/MRESOLVER-417 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Now that we have 3 (4 w/ Wagon) HTTP capable resolver transports, we need > some common reusable across HTTP Transports test suite, probably w/ "tunable" > features. > Requirements aside of "most basic functionality": > * MRESOLVER-396 Back off > * MRESOLVER-393 Retain last modified (on files) > * MRESOLVER-382 Setting outgoing interface > * MRESOLVER-361 Unreliable TCP and retries > * MRESOLVER-347 and MRESOLVER-348 Pool controls, reuse connection, max TTL > * MRESOLVER-339 and MRESOLVER-315 Preemptive auth > * MRESOLVER-341 Preemptive PUT auth > * MRESOLVER-328 SSL insecure mode > * MRESOLVER-326 Retries on certain errors > The should use _standard Resolver configuration with different transports_ as > described on page https://maven.apache.org/resolver/configuration.html > Hence, testing of Wagon is out of scope, as it uses totally different, > ancient Plexus-XML based configuration, does not obey standard resolver > configuration properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-417) Create HTTP test suite a la "TCK"
Tamas Cservenak created MRESOLVER-417: - Summary: Create HTTP test suite a la "TCK" Key: MRESOLVER-417 URL: https://issues.apache.org/jira/browse/MRESOLVER-417 Project: Maven Resolver Issue Type: Task Components: Resolver Reporter: Tamas Cservenak Fix For: 2.0.0 Now that we have 3 (4 w/ Wagon) HTTP capable resolver transports, we need some common reusable across HTTP Transports test suite, probably w/ "tunable" features. Requirements aside of "most basic functionality": * MRESOLVER-396 Back off * MRESOLVER-393 Retain last modified (on files) * MRESOLVER-382 Setting outgoing interface * MRESOLVER-361 Unreliable TCP and retries * MRESOLVER-347 and MRESOLVER-348 Pool controls, reuse connection, max TTL * MRESOLVER-339 and MRESOLVER-315 Preemptive auth * MRESOLVER-341 Preemptive PUT auth * SSL insecure mode * MRESOLVER-326 Retries on certain errors -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Add bmarwell as PMC Member [maven-parent]
bmarwell opened a new pull request, #142: URL: https://github.com/apache/maven-parent/pull/142 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776830#comment-17776830 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769046065 > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. Yes make sense. Can you update documentation? https://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html (source in project src/site/apt/examples/delete_additional_files.apt.vm) We should explain such behaviors. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769046065 > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. Yes make sense. Can you update documentation? https://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html (source in project src/site/apt/examples/delete_additional_files.apt.vm) We should explain such behaviors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776829#comment-17776829 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364294236 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: Fixed. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
wilx commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364294236 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776818#comment-17776818 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769003627 > So it looks like when we use includes/excludes fastDelete will not works - correct? Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769003627 > So it looks like when we use includes/excludes fastDelete will not works - correct? Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776816#comment-17776816 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364259343 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: should be `@project.version@` ... in other tests we need fix also - but in separate PR ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: should be `@project.version@` ... in other tests we need fix also - but in separate PR > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364259343 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: should be `@project.version@` ... in other tests we need fix also - but in separate PR ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: should be `@project.version@` ... in other tests we need fix also - but in separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776815#comment-17776815 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768998145 So it looks like when we use includes/excludes fastDelete will not works - correct? > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768998145 So it looks like when we use includes/excludes fastDelete will not works - correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]
gnodet commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1768992902 This really looks like a temporary hack for agents to being supported by Surefire... It only saves the following declaration: ``` maven-dependency-plugin properties ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MCLEAN-113) Downgrade plexus-xml to 3.0.0
[ https://issues.apache.org/jira/browse/MCLEAN-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MCLEAN-113. -- Resolution: Fixed > Downgrade plexus-xml to 3.0.0 > - > > Key: MCLEAN-113 > URL: https://issues.apache.org/jira/browse/MCLEAN-113 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768991916 > Is this a symptom of `GlobSelector` not working on Windows at all? The issue is not with `GlobSelector`. The issue is that the `GlobSelector` instance passed into `cleaner.delete()` stops the fast method from taking effect: https://github.com/apache/maven-clean-plugin/blob/06876c18de04040448d7fb7e5287b96307de/src/main/java/org/apache/maven/plugins/clean/Cleaner.java#L122-L127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-113) Downgrade plexus-xml to 3.0.0
[ https://issues.apache.org/jira/browse/MCLEAN-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776811#comment-17776811 ] ASF GitHub Bot commented on MCLEAN-113: --- slawekjaranowski merged PR #34: URL: https://github.com/apache/maven-clean-plugin/pull/34 > Downgrade plexus-xml to 3.0.0 > - > > Key: MCLEAN-113 > URL: https://issues.apache.org/jira/browse/MCLEAN-113 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-113] Downgrade plexus-xml to 3.0.0 [maven-clean-plugin]
slawekjaranowski merged PR #34: URL: https://github.com/apache/maven-clean-plugin/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-112) Bump parent to 40
[ https://issues.apache.org/jira/browse/MCLEAN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776803#comment-17776803 ] ASF GitHub Bot commented on MCLEAN-112: --- slawekjaranowski merged PR #33: URL: https://github.com/apache/maven-clean-plugin/pull/33 > Bump parent to 40 > - > > Key: MCLEAN-112 > URL: https://issues.apache.org/jira/browse/MCLEAN-112 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MCLEAN-112) Bump parent to 40
[ https://issues.apache.org/jira/browse/MCLEAN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski resolved MCLEAN-112. Resolution: Fixed > Bump parent to 40 > - > > Key: MCLEAN-112 > URL: https://issues.apache.org/jira/browse/MCLEAN-112 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-112] Bump parent to 40 [maven-clean-plugin]
slawekjaranowski merged PR #33: URL: https://github.com/apache/maven-clean-plugin/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-113) Downgrade plexus-xml to 3.0.0
[ https://issues.apache.org/jira/browse/MCLEAN-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776787#comment-17776787 ] ASF GitHub Bot commented on MCLEAN-113: --- slawekjaranowski opened a new pull request, #34: URL: https://github.com/apache/maven-clean-plugin/pull/34 It is only needed for testing so move to test scope --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCLEAN) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MCLEAN-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCLEAN-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Downgrade plexus-xml to 3.0.0 > - > > Key: MCLEAN-113 > URL: https://issues.apache.org/jira/browse/MCLEAN-113 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MCLEAN-113] Downgrade plexus-xml to 3.0.0 [maven-clean-plugin]
slawekjaranowski opened a new pull request, #34: URL: https://github.com/apache/maven-clean-plugin/pull/34 It is only needed for testing so move to test scope --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCLEAN) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MCLEAN-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCLEAN-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MCLEAN-113) Downgrade plexus-xml to 3.0.0
Slawomir Jaranowski created MCLEAN-113: -- Summary: Downgrade plexus-xml to 3.0.0 Key: MCLEAN-113 URL: https://issues.apache.org/jira/browse/MCLEAN-113 Project: Maven Clean Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MCLEAN-112) Bump parent to 40
[ https://issues.apache.org/jira/browse/MCLEAN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MCLEAN-112: --- Summary: Bump parent to 40 (was: Bump paren to 40) > Bump parent to 40 > - > > Key: MCLEAN-112 > URL: https://issues.apache.org/jira/browse/MCLEAN-112 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MCLEAN-112] Bump paren to 40 [maven-clean-plugin]
slawekjaranowski opened a new pull request, #33: URL: https://github.com/apache/maven-clean-plugin/pull/33 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCLEAN) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MCLEAN-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCLEAN-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-112) Bump paren to 40
[ https://issues.apache.org/jira/browse/MCLEAN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776785#comment-17776785 ] ASF GitHub Bot commented on MCLEAN-112: --- slawekjaranowski opened a new pull request, #33: URL: https://github.com/apache/maven-clean-plugin/pull/33 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCLEAN) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MCLEAN-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCLEAN-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Bump paren to 40 > > > Key: MCLEAN-112 > URL: https://issues.apache.org/jira/browse/MCLEAN-112 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MCLEAN-112) Bump paren to 40
[ https://issues.apache.org/jira/browse/MCLEAN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MCLEAN-112: -- Assignee: Slawomir Jaranowski > Bump paren to 40 > > > Key: MCLEAN-112 > URL: https://issues.apache.org/jira/browse/MCLEAN-112 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump plexus-xml from 4.0.0 to 4.0.2 [maven-clean-plugin]
dependabot[bot] commented on PR #30: URL: https://github.com/apache/maven-clean-plugin/pull/30#issuecomment-1768917835 OK, I won't notify you about version 4.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump plexus-xml from 4.0.0 to 4.0.2 [maven-clean-plugin]
dependabot[bot] closed pull request #30: Bump plexus-xml from 4.0.0 to 4.0.2 URL: https://github.com/apache/maven-clean-plugin/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump plexus-xml from 4.0.0 to 4.0.2 [maven-clean-plugin]
slawekjaranowski commented on PR #30: URL: https://github.com/apache/maven-clean-plugin/pull/30#issuecomment-1768917712 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MCLEAN-112) Bump paren to 40
[ https://issues.apache.org/jira/browse/MCLEAN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MCLEAN-112: --- Summary: Bump paren to 40 (was: Bump paren) > Bump paren to 40 > > > Key: MCLEAN-112 > URL: https://issues.apache.org/jira/browse/MCLEAN-112 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MCLEAN-112) Bump paren to 40
[ https://issues.apache.org/jira/browse/MCLEAN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MCLEAN-112: --- Fix Version/s: next-release > Bump paren to 40 > > > Key: MCLEAN-112 > URL: https://issues.apache.org/jira/browse/MCLEAN-112 > Project: Maven Clean Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCLEAN-112) Bump paren
Slawomir Jaranowski created MCLEAN-112: -- Summary: Bump paren Key: MCLEAN-112 URL: https://issues.apache.org/jira/browse/MCLEAN-112 Project: Maven Clean Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768876305 > Is this a symptom of `GlobSelector` not working on Windows at all? Good point - it should be also checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776773#comment-17776773 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768876305 > Is this a symptom of `GlobSelector` not working on Windows at all? Good point - it should be also checked. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
chabala commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768742507 Is this a symptom of `GlobSelector` not working on Windows at all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776742#comment-17776742 ] ASF GitHub Bot commented on MCLEAN-111: --- chabala commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768742507 Is this a symptom of `GlobSelector` not working on Windows at all? > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPLUGINTESTING-84) Support JUnit 5 on Maven 3
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MPLUGINTESTING-84. - Assignee: Guillaume Nodet Resolution: Fixed > Support JUnit 5 on Maven 3 > -- > > Key: MPLUGINTESTING-84 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-84 > Project: Maven Plugin Testing > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGINTESTING-84) Support JUnit 5 on Maven 3
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776717#comment-17776717 ] ASF GitHub Bot commented on MPLUGINTESTING-84: -- gnodet merged PR #31: URL: https://github.com/apache/maven-plugin-testing/pull/31 > Support JUnit 5 on Maven 3 > -- > > Key: MPLUGINTESTING-84 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-84 > Project: Maven Plugin Testing > Issue Type: New Feature >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGINTESTING-84] Support Junit 5 + Maven 3 [maven-plugin-testing]
gnodet merged PR #31: URL: https://github.com/apache/maven-plugin-testing/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGINTESTING-84) Support JUnit 5 on Maven 3
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776709#comment-17776709 ] ASF GitHub Bot commented on MPLUGINTESTING-84: -- slawekjaranowski commented on PR #31: URL: https://github.com/apache/maven-plugin-testing/pull/31#issuecomment-1768555976 Great > Support JUnit 5 on Maven 3 > -- > > Key: MPLUGINTESTING-84 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-84 > Project: Maven Plugin Testing > Issue Type: New Feature >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776707#comment-17776707 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1363961577 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: Fixed. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
wilx commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1363961577 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGINTESTING-84] Support Junit 5 + Maven 3 [maven-plugin-testing]
slawekjaranowski commented on PR #31: URL: https://github.com/apache/maven-plugin-testing/pull/31#issuecomment-1768555976 Great -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776706#comment-17776706 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1363956331 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: missed license header ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: missed license header > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1363956331 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: missed license header ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: missed license header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] (MCLEAN-102) Fast is slower on windows with many cores
[ https://issues.apache.org/jira/browse/MCLEAN-102 ] Slawomir Jaranowski deleted comment on MCLEAN-102: was (Author: githubbot): wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768328143 JIRA: https://issues.apache.org/jira/projects/MCLEAN/issues/MCLEAN-102 > Fast is slower on windows with many cores > - > > Key: MCLEAN-102 > URL: https://issues.apache.org/jira/browse/MCLEAN-102 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Delany >Priority: Major > > I run a 500+ module project with 4 core Linux and experience a 20sec > improvement in reactor build time when enabling the fast. > My one colleagues runs the same build with 4 cores on Windows and also sees > an improvement. > But two other colleagues run the same build with 12 cores on Windows (one > uses cygwin, the other powershell) and they consistently see a slowdown from > 2:14 to 3:23, for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (MCLEAN-102) Fast is slower on windows with many cores
[ https://issues.apache.org/jira/browse/MCLEAN-102 ] Slawomir Jaranowski deleted comment on MCLEAN-102: was (Author: githubbot): wilx opened a new pull request, #32: URL: https://github.com/apache/maven-clean-plugin/pull/32 Pass `GlobSelector` instance into `cleaner.delete()` only if it matters. Passing `GlobSelector` always breaks the fast delete feature. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCLEAN) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MCLEAN-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCLEAN-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Fast is slower on windows with many cores > - > > Key: MCLEAN-102 > URL: https://issues.apache.org/jira/browse/MCLEAN-102 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Delany >Priority: Major > > I run a 500+ module project with 4 core Linux and experience a 20sec > improvement in reactor build time when enabling the fast. > My one colleagues runs the same build with 4 cores on Windows and also sees > an improvement. > But two other colleagues run the same build with 12 cores on Windows (one > uses cygwin, the other powershell) and they consistently see a slowdown from > 2:14 to 3:23, for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776699#comment-17776699
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1768511456
@gnodet the last commit fixes the unit test that was broken.
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7899] Various memory usage improvements 4 [maven]
sebastien-doyon commented on PR #1269: URL: https://github.com/apache/maven/pull/1269#issuecomment-1768511456 @gnodet the last commit fixes the unit test that was broken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776687#comment-17776687 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768492359 @slawekjaranowski I have added the test. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768492359 @slawekjaranowski I have added the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7893) Allow versioning the superpom according to the model version
[ https://issues.apache.org/jira/browse/MNG-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776676#comment-17776676 ] ASF GitHub Bot commented on MNG-7893: - gnodet merged PR #1290: URL: https://github.com/apache/maven/pull/1290 > Allow versioning the superpom according to the model version > > > Key: MNG-7893 > URL: https://issues.apache.org/jira/browse/MNG-7893 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7893] Fix exception loading superpom with invalid modelVersion [maven]
gnodet merged PR #1290: URL: https://github.com/apache/maven/pull/1290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MCLEAN-111: --- Fix Version/s: next-release > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1777#comment-1777 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768441320 @wilx thanks Is it possible to make an IT to be sure for regressions with next changes? > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]
slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768441320 @wilx thanks Is it possible to make an IT to be sure for regressions with next changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MNG-7893] Fix exception loading superpom with invalid modelVersion [maven]
gnodet opened a new pull request, #1290: URL: https://github.com/apache/maven/pull/1290 Even though this should not be supported, Maven 3.x is always using the 4.0.0 superpom. So if the version is not a supported model version, simply use 4.0.0. Any invalid value will be later verified by the model validator and eventually throw a meaninfual exception. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7893) Allow versioning the superpom according to the model version
[ https://issues.apache.org/jira/browse/MNG-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776647#comment-17776647 ] ASF GitHub Bot commented on MNG-7893: - gnodet opened a new pull request, #1290: URL: https://github.com/apache/maven/pull/1290 Even though this should not be supported, Maven 3.x is always using the 4.0.0 superpom. So if the version is not a supported model version, simply use 4.0.0. Any invalid value will be later verified by the model validator and eventually throw a meaninfual exception. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Allow versioning the superpom according to the model version > > > Key: MNG-7893 > URL: https://issues.apache.org/jira/browse/MNG-7893 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Václav Haisman updated MCLEAN-111: -- Labels: pull-request-available (was: ) > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776638#comment-17776638 ] Václav Haisman commented on MCLEAN-111: --- The linked pull request fixes the issue for me. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
