Re: [PR] Enables debug logs in MavenITmng6127 [maven-integration-testing]
slawekjaranowski merged PR #330: URL: https://github.com/apache/maven-integration-testing/pull/330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enables debug logs in MavenITmng6127 [maven-integration-testing]
slawekjaranowski commented on PR #330: URL: https://github.com/apache/maven-integration-testing/pull/330#issuecomment-1873695435 ok, we have different logs in project and plugin directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Build for Linux on aarch64 [maven-mvnd]
gzm55 commented on issue #888: URL: https://github.com/apache/maven-mvnd/issues/888#issuecomment-1873664250 > I'm sorry that I do not specialize in native programming. So, I'm unsure if my build only requires glibc@2.12. > > But I built the project followed by the official workflow (https://github.com/apache/maven-mvnd/blob/1.0-m7/.github/workflows/release.yaml#L67) which contains #825 that solves #823. > > I just replaced all `amd64` or `x86_64` with `aarch64` after this patch. > > Then everything was fine, even the `Verify native binary for only requiring glibc 2.12` script passed. (https://github.com/apache/maven-mvnd/blob/1.0-m7/.github/workflows/release.yaml#L91). > > When I copy the target to another aarch64 machine that runs Kylin-OS (a Linux distribution that seems like CentOS 8), it still works fine. > > It is worth mentioning that my `PAGE_SIZE` is 64k rather than 4k (maybe 4k is more common). So I have to set `-H:PageSize=65536`. We can get more information from [oracle/graal#5605](https://github.com/oracle/graal/pull/5605) For aarch64 arch, the oldest public released glibc is glibc-2.17 for CentOS7. It is reasonable that we limit the running glibc >= 2.17 on aarch64 cpu. But the resource should be upload for each hardware (x64/arm64). Also the UT in CI could be improved to check dependencies strictly for each arch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enables debug logs in MavenITmng6127 [maven-integration-testing]
CrazyHZM commented on PR #330: URL: https://github.com/apache/maven-integration-testing/pull/330#issuecomment-1873660376 > We have two execution on Maven here, both use the same log file. We can also set different logs for those. > > `verifier.setLogFileName ` I have found the log from https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/509/artifact/core-it-suite-logs-linux-jdk11.zip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MDEP-317] - add mojo to analyze invalid exclusions [maven-dependency-plugin]
vbreivik opened a new pull request, #362: URL: https://github.com/apache/maven-dependency-plugin/pull/362 This mojo reports if exclusions are defined on a dependency, but that dependency does not pull in said artifacts. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Before doing any more work I would like some feedback if I am on the correct path in implementing this feature. The unit tests uses snake case, that was frowned upon in another pull request, I can rename those. I am uncertain if the wildcard logic is good enough. Currently it matches only entire groupId or artifactId. It does not match for instance "javax.annotation:javax.an*". I am missing usage documentation, will do that if this is valid. The failOnWarning property is the same property as for analyze, keep it that way or make its own property? I placed the logic in its own package and made it its own execution, it can be moved to be a part of analyze if wanted. Having it as its own will make upgrading not change current behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2161:
-
Fix Version/s: Backlog
(was: 3.x-candidate)
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINVOKER-354) Upgrade to Doxia 2.0.0 Milestone Stack
[ https://issues.apache.org/jira/browse/MINVOKER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MINVOKER-354: Description: * Ugprade to Doxia 2.0.0-M8 * Upgrade to Maven Reporting API 4.0.0-M9 * Upgrade to Maven Reporting Impl 4.0.0-M13 * Upgrade to Maven Site Plugin 4.0.0-M13 was: * Ugprade to Doxia 2.0.0-M8 * Upgrade to Maven Reporting API 4.0.0-M9 * * Upgrade to Maven Reporting Impl 4.0.0-M13 * Upgrade to Maven Site Plugin 4.0.0-M13 > Upgrade to Doxia 2.0.0 Milestone Stack > -- > > Key: MINVOKER-354 > URL: https://issues.apache.org/jira/browse/MINVOKER-354 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: Backlog > > > * Ugprade to Doxia 2.0.0-M8 > * Upgrade to Maven Reporting API 4.0.0-M9 > * Upgrade to Maven Reporting Impl 4.0.0-M13 > * Upgrade to Maven Site Plugin 4.0.0-M13 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 [maven-site-plugin]
slachiewicz commented on PR #170: URL: https://github.com/apache/maven-site-plugin/pull/170#issuecomment-1873485519 The plugin org.codehaus.mojo:mrm-maven-plugin:1.6.0 requires Maven version 3.6.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINVOKER-354) Upgrade to Doxia 2.0.0 Milestone Stack
Michael Osipov created MINVOKER-354: --- Summary: Upgrade to Doxia 2.0.0 Milestone Stack Key: MINVOKER-354 URL: https://issues.apache.org/jira/browse/MINVOKER-354 Project: Maven Invoker Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: Backlog * Ugprade to Doxia 2.0.0-M8 * Upgrade to Maven Reporting API 4.0.0-M9 * * Upgrade to Maven Reporting Impl 4.0.0-M13 * Upgrade to Maven Site Plugin 4.0.0-M13 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Run CI tests also with Java 21 [maven-surefire]
slachiewicz opened a new pull request, #707: URL: https://github.com/apache/maven-surefire/pull/707 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINVOKER-346) Align report output name
[
https://issues.apache.org/jira/browse/MINVOKER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MINVOKER-346:
Fix Version/s: Backlog
(was: 3.x)
> Align report output name
>
>
> Key: MINVOKER-346
> URL: https://issues.apache.org/jira/browse/MINVOKER-346
> Project: Maven Invoker Plugin
> Issue Type: Task
>Affects Versions: 3.5.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | {{InvokerReport}} || -{{invoker-report}}- \\ {{invoker}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.htmlunit:htmlunit from 3.8.0 to 3.9.0 in /maven-failsafe-plugin/src/it/jetty-war-test-passing [maven-surefire]
slachiewicz commented on PR #693: URL: https://github.com/apache/maven-surefire/pull/693#issuecomment-1873482436 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Batch update to plugin [maven-invoker-plugin]
michael-o commented on code in PR #207:
URL:
https://github.com/apache/maven-invoker-plugin/pull/207#discussion_r1439085173
##
pom.xml:
##
@@ -62,12 +62,13 @@ under the License.
8
-3.2.5
+3.2.5
+3.9.6
Review Comment:
I wouldn't do this either in this release.
##
pom.xml:
##
@@ -169,6 +183,12 @@ under the License.
org.apache.maven.doxia
doxia-sink-api
1.12.0
+
+
+ org.codehaus.plexus
+ plexus-container-default
+
+
Review Comment:
Fair enough, will be solved with Doxia 2.0.0.
##
pom.xml:
##
@@ -145,6 +146,19 @@ under the License.
${mavenVersion}
provided
+
+ org.apache.maven.resolver
+ maven-resolver-api
+ 1.9.18
+ provided
Review Comment:
This does not correspond to the approach we have taken in other plugins: Use
the same Resolver API version as with the base Maven Core version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [MPOM-449] Remove the leading "1." from source/target properties [maven-parent]
slachiewicz opened a new pull request, #155: URL: https://github.com/apache/maven-parent/pull/155 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-903) Upgrade to Doxia 2.0.0 Milestone Stack
Michael Osipov created MDEP-903: --- Summary: Upgrade to Doxia 2.0.0 Milestone Stack Key: MDEP-903 URL: https://issues.apache.org/jira/browse/MDEP-903 Project: Maven Dependency Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: Backlog * Ugprade to Doxia 2.0.0-M8 * Upgrade to Maven Reporting API 4.0.0-M9 * Upgrade to Maven Reporting Impl 4.0.0-M13 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPOM-455) Add dependencyManagement for JUnit 5
Sylwester Lachiewicz created MPOM-455: - Summary: Add dependencyManagement for JUnit 5 Key: MPOM-455 URL: https://issues.apache.org/jira/browse/MPOM-455 Project: Maven POMs Issue Type: Dependency upgrade Components: maven Reporter: Sylwester Lachiewicz -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPH-212) Upgrade to Doxia 2.0.0 Milestone Stack
Michael Osipov created MPH-212: -- Summary: Upgrade to Doxia 2.0.0 Milestone Stack Key: MPH-212 URL: https://issues.apache.org/jira/browse/MPH-212 Project: Maven Help Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: Backlog * Upgrade to Maven Reporting API 4.0.0-M9 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCHECKSTYLE-446) Dynamically calculate xrefLocation/xrefTestLocation
Michael Osipov created MCHECKSTYLE-446: -- Summary: Dynamically calculate xrefLocation/xrefTestLocation Key: MCHECKSTYLE-446 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-446 Project: Maven Checkstyle Plugin Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 4.0.0-M1 After MSHARED-1327 we need to dynamically calculate where (Test) XRef report resides. Unless an explicit value has been provided. The calculation considers both standalone mode *and* site mode. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MPMD-368:
Fix Version/s: 4.0.0-M1
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M1
>
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MPMD-368) Parameter 'localRepository' is deprecated
[
https://issues.apache.org/jira/browse/MPMD-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MPMD-368:
---
Assignee: Michael Osipov
> Parameter 'localRepository' is deprecated
> -
>
> Key: MPMD-368
> URL: https://issues.apache.org/jira/browse/MPMD-368
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.20.0, 3.21.0
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
>
> Probably since Maven 3.9.1 this warning is seen in builds:
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> This broke the CI and has been worked around (MPMD-367) but the root cause
> should be addressed. This same issue might appear in other plugins as well
> and break their CIs that check to see there are no warnings in a build.
> I'm not sure whether this can be fixed without breaking compatibility with
> older Maven versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MCHECKSTYLE-445) Upgrade to Doxia 2.0.0 Milestone Stack
Michael Osipov created MCHECKSTYLE-445: -- Summary: Upgrade to Doxia 2.0.0 Milestone Stack Key: MCHECKSTYLE-445 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-445 Project: Maven Checkstyle Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 4.0.0-M1 * Ugprade to Doxia 2.0.0-M8 * Ugprade to Doxia Sitetools 2.0.0-M16 * Upgrade to Maven Reporting API 4.0.0-M9 * Upgrade to Maven Site Plugin 4.0.0-M13 * Upgrade to Maven JXR Plugin 4.0.0-M1 * Upgrade to Maven Reporting Impl 4.0.0-M13 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1136) Upgrade parent POM to version 41
[ https://issues.apache.org/jira/browse/MRELEASE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801603#comment-17801603 ] ASF GitHub Bot commented on MRELEASE-1136: -- slachiewicz opened a new pull request, #208: URL: https://github.com/apache/maven-release/pull/208 (no comment) > Upgrade parent POM to version 41 > > > Key: MRELEASE-1136 > URL: https://issues.apache.org/jira/browse/MRELEASE-1136 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRELEASE-1136) Upgrade parent POM to version 41
Sylwester Lachiewicz created MRELEASE-1136: -- Summary: Upgrade parent POM to version 41 Key: MRELEASE-1136 URL: https://issues.apache.org/jira/browse/MRELEASE-1136 Project: Maven Release Plugin Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-560) Clarify outputDirectory, reportOutputDirectory in javadoc:javadoc documentation
[
https://issues.apache.org/jira/browse/MJAVADOC-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801589#comment-17801589
]
Michael Osipov commented on MJAVADOC-560:
-
MJAVADOC-785 will clean this up completely and bring this plugin in line with
other reporting plugins behavior.
> Clarify outputDirectory, reportOutputDirectory in javadoc:javadoc
> documentation
> ---
>
> Key: MJAVADOC-560
> URL: https://issues.apache.org/jira/browse/MJAVADOC-560
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.1.0
>Reporter: Gili
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M1
>
>
> Looking at the documentation for javadoc:javadoc at
> [https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html] I
> see three problems:
> # The documentation lists both *outputDirectory* and *reportOutputDirectory*
> parameters, having the same description. It's not clear what each one is used
> for or what happens if one property is changed without the other.
> # The default value of *outputDirectory* is listed as
> *${project.build.directory}/apidocs* but the value that is actually used is
> *${project.reporting.outputDirectory}/apidocs* (the value of
> *reportOutputDirectory*).
> # It was extremely difficult to find any documentation on
> *${project.reporting.outputDirectory}***, such as what its default value is.
> I eventually found [https://maven.apache.org/pom.html#Reporting] but Google
> does not link directly to this page/section because it doesn't contain an
> explicit reference to *${project.reporting}*.
> Suggested fix(es):
> # Drop one of the two parameters, ideally *reportOutputDirectory*, to avoid
> confusion.
> # Update the documentation so it lists the correct default value for
> *outputDirectory*.
> # Link directly from mention of *${project.reporting.outputDirectory}* to
> [https://maven.apache.org/pom.html#Reporting]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump com.google.inject:guice from 6.0.0 to 7.0.0 [maven-doxia]
dependabot[bot] closed pull request #192: Bump com.google.inject:guice from 6.0.0 to 7.0.0 URL: https://github.com/apache/maven-doxia/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.inject:guice from 6.0.0 to 7.0.0 [maven-doxia]
dependabot[bot] commented on PR #192: URL: https://github.com/apache/maven-doxia/pull/192#issuecomment-1873465390 OK, I won't notify you about version 7.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.inject:guice from 6.0.0 to 7.0.0 [maven-doxia]
slachiewicz commented on PR #192: URL: https://github.com/apache/maven-doxia/pull/192#issuecomment-1873465373 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JXR-188) Upgrade to Doxia 2.0.0 Milestone Stack
[
https://issues.apache.org/jira/browse/JXR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated JXR-188:
---
Description:
* Upgrade to Maven Reporting API 4.0.0-M9
* Upgrade to Maven Reporting Impl 4.0.0-M13
* Upgrade to Maven Site Plugin 4.0.0-M13
* Upgrade to Velocity Engine 2.3
This change the following parameters:
* {{destDir}} is gone and folded into {{outputDirectory}}
was:
* Upgrade to Maven Reporting API 4.0.0-M9
* Upgrade to Maven Reporting Impl 4.0.0-M13
* Upgrade to Maven Site Plugin 4.0.0-M13
* Upgrade to Velocity Engine 2.3
> Upgrade to Doxia 2.0.0 Milestone Stack
> --
>
> Key: JXR-188
> URL: https://issues.apache.org/jira/browse/JXR-188
> Project: Maven JXR
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M1
>
>
> * Upgrade to Maven Reporting API 4.0.0-M9
> * Upgrade to Maven Reporting Impl 4.0.0-M13
> * Upgrade to Maven Site Plugin 4.0.0-M13
> * Upgrade to Velocity Engine 2.3
> This change the following parameters:
> * {{destDir}} is gone and folded into {{outputDirectory}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-785) Align plugin implementation with AbstractMavenReport (maven-reporting-impl)
[
https://issues.apache.org/jira/browse/MJAVADOC-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MJAVADOC-785:
Description:
Due to its complex nature this plugin has never used {{AbstractMavenReport}},
thus not its behavior as well. This causes inconsistencies compared with our
other plugins in configuration and runtime behavior. After MSHARED-1327 this
plugin will be logically aligned with maven-reporting-impl to mimic the
behavior to the extent necessary from {{AbstractMavenReport}}.
This change the following parameters:
* {{outputDirectory}} uses the semantics from {{AbstractMavenReport}} and is
not exlusive anymore
* {{destDir}} is gone and folded into {{outputDirectory}}
* {{reportOutputDirectory}}/{{reportTestOutputDirectory}} is gone and is
private according to {{AbstractMavenReport}}, it will be calculated at runtime
*
was:Due to its complex nature this plugin has never used
{{AbstractMavenReport}}, thus not its behavior as well. This causes
inconsistencies compared with our other plugins in configuration and runtime
behavior. After MSHARED-1327 this plugin will be logically aligned with
maven-reporting-impl to mimic the behavior to the extent necessary from
{{AbstractMavenReport}}.
> Align plugin implementation with AbstractMavenReport (maven-reporting-impl)
> ---
>
> Key: MJAVADOC-785
> URL: https://issues.apache.org/jira/browse/MJAVADOC-785
> Project: Maven Javadoc Plugin
> Issue Type: Task
> Components: javadoc
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M1
>
>
> Due to its complex nature this plugin has never used {{AbstractMavenReport}},
> thus not its behavior as well. This causes inconsistencies compared with our
> other plugins in configuration and runtime behavior. After MSHARED-1327 this
> plugin will be logically aligned with maven-reporting-impl to mimic the
> behavior to the extent necessary from {{AbstractMavenReport}}.
> This change the following parameters:
> * {{outputDirectory}} uses the semantics from {{AbstractMavenReport}} and is
> not exlusive anymore
> * {{destDir}} is gone and folded into {{outputDirectory}}
> * {{reportOutputDirectory}}/{{reportTestOutputDirectory}} is gone and is
> private according to {{AbstractMavenReport}}, it will be calculated at runtime
> *
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-785) Align plugin implementation with AbstractMavenReport (maven-reporting-impl)
[
https://issues.apache.org/jira/browse/MJAVADOC-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MJAVADOC-785:
Description:
Due to its complex nature this plugin has never used {{AbstractMavenReport}},
thus not its behavior as well. This causes inconsistencies compared with our
other plugins in configuration and runtime behavior. After MSHARED-1327 this
plugin will be logically aligned with maven-reporting-impl to mimic the
behavior to the extent necessary from {{AbstractMavenReport}}.
This change the following parameters:
* {{outputDirectory}} uses the semantics from {{AbstractMavenReport}} and is
not exlusive anymore
* {{destDir}} is gone and folded into {{outputDirectory}}
* {{reportOutputDirectory}}/{{reportTestOutputDirectory}} is gone and is
private according to {{AbstractMavenReport}}, it will be calculated at runtime
was:
Due to its complex nature this plugin has never used {{AbstractMavenReport}},
thus not its behavior as well. This causes inconsistencies compared with our
other plugins in configuration and runtime behavior. After MSHARED-1327 this
plugin will be logically aligned with maven-reporting-impl to mimic the
behavior to the extent necessary from {{AbstractMavenReport}}.
This change the following parameters:
* {{outputDirectory}} uses the semantics from {{AbstractMavenReport}} and is
not exlusive anymore
* {{destDir}} is gone and folded into {{outputDirectory}}
* {{reportOutputDirectory}}/{{reportTestOutputDirectory}} is gone and is
private according to {{AbstractMavenReport}}, it will be calculated at runtime
*
> Align plugin implementation with AbstractMavenReport (maven-reporting-impl)
> ---
>
> Key: MJAVADOC-785
> URL: https://issues.apache.org/jira/browse/MJAVADOC-785
> Project: Maven Javadoc Plugin
> Issue Type: Task
> Components: javadoc
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M1
>
>
> Due to its complex nature this plugin has never used {{AbstractMavenReport}},
> thus not its behavior as well. This causes inconsistencies compared with our
> other plugins in configuration and runtime behavior. After MSHARED-1327 this
> plugin will be logically aligned with maven-reporting-impl to mimic the
> behavior to the extent necessary from {{AbstractMavenReport}}.
> This change the following parameters:
> * {{outputDirectory}} uses the semantics from {{AbstractMavenReport}} and is
> not exlusive anymore
> * {{destDir}} is gone and folded into {{outputDirectory}}
> * {{reportOutputDirectory}}/{{reportTestOutputDirectory}} is gone and is
> private according to {{AbstractMavenReport}}, it will be calculated at runtime
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MJAVADOC-785) Align plugin implementation with AbstractMavenReport (maven-reporting-impl)
Michael Osipov created MJAVADOC-785:
---
Summary: Align plugin implementation with AbstractMavenReport
(maven-reporting-impl)
Key: MJAVADOC-785
URL: https://issues.apache.org/jira/browse/MJAVADOC-785
Project: Maven Javadoc Plugin
Issue Type: Task
Components: javadoc
Affects Versions: 3.6.3
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 4.0.0-M1
Due to its complex nature this plugin has never used {{AbstractMavenReport}},
thus not its behavior as well. This causes inconsistencies compared with our
other plugins in configuration and runtime behavior. After MSHARED-1327 this
plugin will be logically aligned with maven-reporting-impl to mimic the
behavior to the extent necessary from {{AbstractMavenReport}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MJAVADOC-784) Upgrade to Doxia 2.0.0 Milestone Stack
Michael Osipov created MJAVADOC-784: --- Summary: Upgrade to Doxia 2.0.0 Milestone Stack Key: MJAVADOC-784 URL: https://issues.apache.org/jira/browse/MJAVADOC-784 Project: Maven Javadoc Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 4.0.0-M1 * Ugprade to Doxia 2.0.0-M8 * Ugprade to Doxia Sitetools 2.0.0-M16 * Upgrade to Maven Reporting API 4.0.0-M9 * Upgrade to Maven Site Plugin 4.0.0-M13 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-archiver]
dependabot[bot] opened a new pull request, #49: URL: https://github.com/apache/maven-archiver/pull/49 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.0. Release notes Sourced from https://github.com/assertj/assertj/releases;>org.assertj:assertj-core's releases. v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility;>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138;>#3138 :sparkles: New Features Core Add Descriptable#describedAs(SupplierString) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933;>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947;>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968;>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969;>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580;>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995;>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007;>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616;>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043;>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080;>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132;>#3132 Change the way the properties are collected using the Class.getMethods() API instead of iterating the class hierarchy using Class.declaredMethods() https://redirect.github.com/assertj/assertj/issues/3135;>#3135 Add default constructor for RecursiveComparator https://redirect.github.com/assertj/assertj/issues/3206;>#3206 Add isPrimitive and isNotPrimitive to Class assertions https://redirect.github.com/assertj/assertj/issues/2722;>#2722 Add anyOf(ThrowingConsumer...) and allOf(ThrowingConsumer...) https://redirect.github.com/assertj/assertj/issues/3219;>#3219 What was written as: assertThat(elements) .extracting(Element::getProperty) .allSatisfy(p - assertThat(p).satisfiesAnyOf( p1 - assertThat(p1).isNull(), ... (truncated) Commits https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246;>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b;>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85;>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311;>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b;>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312;>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251;>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 https://github.com/assertj/assertj/commit/1ea43798bdd19c02f0d5223df1188a8029740ef2;>1ea4379 chore(deps-dev): bump com.fasterxml.jackson.core:jackson-databind from 2.16.0... https://github.com/assertj/assertj/commit/e841b327cd668856625cb18dc6807723ab966742;>e841b32 chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 ... https://github.com/assertj/assertj/commit/5ea37606edf781f25d9661a09dcc02b8a9f3c7dc;>5ea3760 ci: update workflows to Java 21 (https://redirect.github.com/assertj/assertj/issues/3191;>#3191) https://github.com/assertj/assertj/commit/e91cb7bfafd612961350e6846220a62a8188567f;>e91cb7b ci: upload only report for latest release binary compatibility
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 1.1 to 3.0.24 in /src/it/script-class-loading [maven-invoker-plugin]
dependabot[bot] commented on PR #197: URL: https://github.com/apache/maven-invoker-plugin/pull/197#issuecomment-1873453741 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 1.1 to 3.0.24 in /src/it/script-class-loading [maven-invoker-plugin]
slachiewicz closed pull request #197: Bump org.codehaus.plexus:plexus-utils from 1.1 to 3.0.24 in /src/it/script-class-loading URL: https://github.com/apache/maven-invoker-plugin/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 39 to 41 [maven-invoker-plugin]
dependabot[bot] closed pull request #202: Bump org.apache.maven.plugins:maven-plugins from 39 to 41 URL: https://github.com/apache/maven-invoker-plugin/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 39 to 41 [maven-invoker-plugin]
dependabot[bot] commented on PR #202: URL: https://github.com/apache/maven-invoker-plugin/pull/202#issuecomment-1873452355 Looks like org.apache.maven.plugins:maven-plugins is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 39 to 41 [maven-invoker-plugin]
slachiewicz commented on PR #202: URL: https://github.com/apache/maven-invoker-plugin/pull/202#issuecomment-1873452257 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Deleted] (MINVOKER-353) Upgrade parent POM to version 41
[ https://issues.apache.org/jira/browse/MINVOKER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz deleted MINVOKER-353: -- > Upgrade parent POM to version 41 > > > Key: MINVOKER-353 > URL: https://issues.apache.org/jira/browse/MINVOKER-353 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINVOKER-353) Upgrade parent POM to version 41
Sylwester Lachiewicz created MINVOKER-353: - Summary: Upgrade parent POM to version 41 Key: MINVOKER-353 URL: https://issues.apache.org/jira/browse/MINVOKER-353 Project: Maven Invoker Plugin Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz Fix For: 3.x -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Switch to defaults for GHA maven verify [maven-invoker-plugin]
slachiewicz merged PR #210: URL: https://github.com/apache/maven-invoker-plugin/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Switch to defaults for GHA maven verify [maven-invoker-plugin]
slawekjaranowski commented on PR #210: URL: https://github.com/apache/maven-invoker-plugin/pull/210#issuecomment-1873450057 > Does Spotless work with JDK 21 in the meantime? > > Yes rechecked it works with JDK 21 (2.40.0)... Parent 4 has a workaround for Spotless and it is ready for JDK 21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Switch to defaults for GHA maven verify [maven-invoker-plugin]
khmarbaise commented on PR #210: URL: https://github.com/apache/maven-invoker-plugin/pull/210#issuecomment-1873436601 Does Spotless work with JDK 21 in the meantime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Switch to defaults for GHA maven verify [maven-invoker-plugin]
slawekjaranowski commented on PR #210: URL: https://github.com/apache/maven-invoker-plugin/pull/210#issuecomment-1873436275 > I've been expecting to have here Java 21 I think we can try 21 in shared actions as default today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Switch to defaults for GHA maven verify [maven-invoker-plugin]
slachiewicz commented on PR #210: URL: https://github.com/apache/maven-invoker-plugin/pull/210#issuecomment-1873435328 I've been expecting to have here Java 21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Switch to defaults for GHA maven verify [maven-invoker-plugin]
slachiewicz opened a new pull request, #210: URL: https://github.com/apache/maven-invoker-plugin/pull/210 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-invoker-plugin]
khmarbaise merged PR #208: URL: https://github.com/apache/maven-invoker-plugin/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINVOKER-352) Remove usage commons-lang3
[ https://issues.apache.org/jira/browse/MINVOKER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MINVOKER-352. Resolution: Fixed Done with https://github.com/apache/maven-invoker-plugin/commit/f61e240ed7eed015aac82fc9e121922febb43b16 > Remove usage commons-lang3 > -- > > Key: MINVOKER-352 > URL: https://issues.apache.org/jira/browse/MINVOKER-352 > Project: Maven Invoker Plugin > Issue Type: Improvement >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.x > > > Currently methods / classes of commons-lang3 are used only very few. We can > get rid of the usage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 [maven-invoker-plugin]
dependabot[bot] closed pull request #204: Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 URL: https://github.com/apache/maven-invoker-plugin/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 [maven-invoker-plugin]
dependabot[bot] commented on PR #204: URL: https://github.com/apache/maven-invoker-plugin/pull/204#issuecomment-1873394913 Looks like org.apache.commons:commons-lang3 is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-352) Remove usage commons-lang3
[ https://issues.apache.org/jira/browse/MINVOKER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801562#comment-17801562 ] ASF GitHub Bot commented on MINVOKER-352: - khmarbaise merged PR #209: URL: https://github.com/apache/maven-invoker-plugin/pull/209 > Remove usage commons-lang3 > -- > > Key: MINVOKER-352 > URL: https://issues.apache.org/jira/browse/MINVOKER-352 > Project: Maven Invoker Plugin > Issue Type: Improvement >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.x > > > Currently methods / classes of commons-lang3 are used only very few. We can > get rid of the usage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MINVOKER-352] - Remove usage commons-lang3 [maven-invoker-plugin]
khmarbaise merged PR #209: URL: https://github.com/apache/maven-invoker-plugin/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-enforcer]
dependabot[bot] opened a new pull request, #300: URL: https://github.com/apache/maven-enforcer/pull/300 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.0. Release notes Sourced from https://github.com/assertj/assertj/releases;>org.assertj:assertj-core's releases. v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility;>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138;>#3138 :sparkles: New Features Core Add Descriptable#describedAs(SupplierString) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933;>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947;>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968;>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969;>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580;>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995;>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007;>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616;>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043;>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080;>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132;>#3132 Change the way the properties are collected using the Class.getMethods() API instead of iterating the class hierarchy using Class.declaredMethods() https://redirect.github.com/assertj/assertj/issues/3135;>#3135 Add default constructor for RecursiveComparator https://redirect.github.com/assertj/assertj/issues/3206;>#3206 Add isPrimitive and isNotPrimitive to Class assertions https://redirect.github.com/assertj/assertj/issues/2722;>#2722 Add anyOf(ThrowingConsumer...) and allOf(ThrowingConsumer...) https://redirect.github.com/assertj/assertj/issues/3219;>#3219 What was written as: assertThat(elements) .extracting(Element::getProperty) .allSatisfy(p - assertThat(p).satisfiesAnyOf( p1 - assertThat(p1).isNull(), ... (truncated) Commits https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246;>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b;>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85;>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311;>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b;>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312;>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251;>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 https://github.com/assertj/assertj/commit/1ea43798bdd19c02f0d5223df1188a8029740ef2;>1ea4379 chore(deps-dev): bump com.fasterxml.jackson.core:jackson-databind from 2.16.0... https://github.com/assertj/assertj/commit/e841b327cd668856625cb18dc6807723ab966742;>e841b32 chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 ... https://github.com/assertj/assertj/commit/5ea37606edf781f25d9661a09dcc02b8a9f3c7dc;>5ea3760 ci: update workflows to Java 21 (https://redirect.github.com/assertj/assertj/issues/3191;>#3191) https://github.com/assertj/assertj/commit/e91cb7bfafd612961350e6846220a62a8188567f;>e91cb7b ci: upload only report for latest release binary compatibility
[jira] [Commented] (MPOM-454) Warning about usage of deprecated API by compiler
[ https://issues.apache.org/jira/browse/MPOM-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801558#comment-17801558 ] Slawomir Jaranowski commented on MPOM-454: -- This issue should be fixed https://github.com/codehaus-plexus/modello/issues/369 to avoid warning in generated classes > Warning about usage of deprecated API by compiler > - > > Key: MPOM-454 > URL: https://issues.apache.org/jira/browse/MPOM-454 > Project: Maven POMs > Issue Type: Improvement > Components: maven >Reporter: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.1 to 1.2 [maven-help-plugin]
dependabot[bot] opened a new pull request, #106: URL: https://github.com/apache/maven-help-plugin/pull/106 Bumps [org.codehaus.plexus:plexus-interactivity-api](https://github.com/codehaus-plexus/plexus-interactivity) from 1.1 to 1.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-interactivity/releases;>org.codehaus.plexus:plexus-interactivity-api's releases. plexus-interactivity-1.2 New features and improvements ensure prompter does not double colon (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/10;>#10) https://github.com/rmannibucau;>@rmannibucau java 8 as mininum (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/6;>#6) https://github.com/olamy;>@olamy Move off plexus (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/49;>#49) https://github.com/cstamas;>@cstamas Dependency updates Update parent pom to plexus 16 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/48;>#48) https://github.com/slachiewicz;>@slachiewicz Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/44;>#44) https://github.com/dependabot;>@dependabot Bump javax.annotation-api from 1.2 to 1.3.2 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/40;>#40) https://github.com/dependabot;>@dependabot JSR330 Replace plexus-container-default with javax.annotation (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/39;>#39) https://github.com/slachiewicz;>@slachiewicz Upgrade to JUnit 5 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/38;>#38) https://github.com/slachiewicz;>@slachiewicz Maintenance Update parent pom to plexus 16 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/48;>#48) https://github.com/slachiewicz;>@slachiewicz Reuse plexus-pom action for CI (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/46;>#46) https://github.com/slachiewicz;>@slachiewicz JSR330 Replace plexus-container-default with javax.annotation (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/39;>#39) https://github.com/slachiewicz;>@slachiewicz Upgrade to JUnit 5 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/38;>#38) https://github.com/slachiewicz;>@slachiewicz Add JDK 20 to CI (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/36;>#36) https://github.com/slachiewicz;>@slachiewicz add some ghaction, dependabot and release drafter (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/4;>#4) https://github.com/olamy;>@olamy Commits https://github.com/codehaus-plexus/plexus-interactivity/commit/558b3bbcac0564cab42b5af0e943b1563f4f3994;>558b3bb [maven-release-plugin] prepare release plexus-interactivity-1.2 https://github.com/codehaus-plexus/plexus-interactivity/commit/79eff99176129fa88c40c5929c4fc74d09493010;>79eff99 Move off plexus https://github.com/codehaus-plexus/plexus-interactivity/commit/2da2de8427db0191a2ef36bf8c340b507c16e257;>2da2de8 Update to plexus parent pom 16 https://github.com/codehaus-plexus/plexus-interactivity/commit/5cde88e4f1c89624671d782c6f03cc297f0f3dbe;>5cde88e Reformat code https://github.com/codehaus-plexus/plexus-interactivity/commit/5827324f69705692776aa4f210d5447f20fcde0e;>5827324 Bump org.codehaus.plexus:plexus-components from 10.0 to 14.2 https://github.com/codehaus-plexus/plexus-interactivity/commit/45c2e881c5ff9ecfc5b9c41b916101bd17f41b4c;>45c2e88 Reuse plexus-pom action for CI https://github.com/codehaus-plexus/plexus-interactivity/commit/5b38c7783bc0097530e2376cf702185b362f3271;>5b38c77 Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 https://github.com/codehaus-plexus/plexus-interactivity/commit/03433395d82177024f1ab75d2614bf1bff75cbeb;>0343339 Bump actions/checkout from 3 to 4 https://github.com/codehaus-plexus/plexus-interactivity/commit/e4a0551e7097bdfd361fe48b027fdf7f5b9c8dcd;>e4a0551 Bump org.junit.jupiter:junit-jupiter from 5.9.3 to 5.10.0 https://github.com/codehaus-plexus/plexus-interactivity/commit/fdd1ff98809559404d4d4188dab2f9dc840e359d;>fdd1ff9 Bump javax.annotation-api from 1.2 to 1.3.2 Additional commits viewable in https://github.com/codehaus-plexus/plexus-interactivity/compare/plexus-interactivity-1.1...plexus-interactivity-1.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you
[jira] [Commented] (MINVOKER-352) Remove usage commons-lang3
[ https://issues.apache.org/jira/browse/MINVOKER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801550#comment-17801550 ] ASF GitHub Bot commented on MINVOKER-352: - khmarbaise opened a new pull request, #209: URL: https://github.com/apache/maven-invoker-plugin/pull/209 Following this checklist to help us incorporate your contribution quickly and easily: - [x ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MINVOKER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MINVOKER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MINVOKER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Remove usage commons-lang3 > -- > > Key: MINVOKER-352 > URL: https://issues.apache.org/jira/browse/MINVOKER-352 > Project: Maven Invoker Plugin > Issue Type: Improvement >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.x > > > Currently methods / classes of commons-lang3 are used only very few. We can > get rid of the usage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MINVOKER-352] - Remove usage commons-lang3 [maven-invoker-plugin]
khmarbaise opened a new pull request, #209: URL: https://github.com/apache/maven-invoker-plugin/pull/209 Following this checklist to help us incorporate your contribution quickly and easily: - [x ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MINVOKER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MINVOKER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MINVOKER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #255: URL: https://github.com/apache/maven-plugin-tools/pull/255 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.0. Release notes Sourced from https://github.com/assertj/assertj/releases;>org.assertj:assertj-core's releases. v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility;>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138;>#3138 :sparkles: New Features Core Add Descriptable#describedAs(SupplierString) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933;>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947;>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968;>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969;>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580;>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995;>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007;>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616;>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043;>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080;>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132;>#3132 Change the way the properties are collected using the Class.getMethods() API instead of iterating the class hierarchy using Class.declaredMethods() https://redirect.github.com/assertj/assertj/issues/3135;>#3135 Add default constructor for RecursiveComparator https://redirect.github.com/assertj/assertj/issues/3206;>#3206 Add isPrimitive and isNotPrimitive to Class assertions https://redirect.github.com/assertj/assertj/issues/2722;>#2722 Add anyOf(ThrowingConsumer...) and allOf(ThrowingConsumer...) https://redirect.github.com/assertj/assertj/issues/3219;>#3219 What was written as: assertThat(elements) .extracting(Element::getProperty) .allSatisfy(p - assertThat(p).satisfiesAnyOf( p1 - assertThat(p1).isNull(), ... (truncated) Commits https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246;>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b;>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85;>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311;>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b;>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312;>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251;>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 https://github.com/assertj/assertj/commit/1ea43798bdd19c02f0d5223df1188a8029740ef2;>1ea4379 chore(deps-dev): bump com.fasterxml.jackson.core:jackson-databind from 2.16.0... https://github.com/assertj/assertj/commit/e841b327cd668856625cb18dc6807723ab966742;>e841b32 chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 ... https://github.com/assertj/assertj/commit/5ea37606edf781f25d9661a09dcc02b8a9f3c7dc;>5ea3760 ci: update workflows to Java 21 (https://redirect.github.com/assertj/assertj/issues/3191;>#3191) https://github.com/assertj/assertj/commit/e91cb7bfafd612961350e6846220a62a8188567f;>e91cb7b ci: upload only report for latest release binary compatibility
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801546#comment-17801546
]
ASF GitHub Bot commented on MRELEASE-1109:
--
kwin commented on code in PR #201:
URL: https://github.com/apache/maven-release/pull/201#discussion_r1439031745
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
* Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
* The first group selects the property name the expression refers to.
*/
-private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
Review Comment:
No it isn’t:
https://docs.oracle.com/javase/tutorial/essential/regex/quant.html. The latter
is greedy while the former is reluctant.
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801545#comment-17801545
]
ASF GitHub Bot commented on MRELEASE-1109:
--
kwin commented on code in PR #201:
URL: https://github.com/apache/maven-release/pull/201#discussion_r1439031745
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
* Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
* The first group selects the property name the expression refers to.
*/
-private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
Review Comment:
No it isn’t:
https://docs.oracle.com/javase/tutorial/essential/regex/quant.html. The former
is greedy while the latter is reluctant.
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRELEASE-1109] patch JDomModel [maven-release]
kwin commented on code in PR #201:
URL: https://github.com/apache/maven-release/pull/201#discussion_r1439031745
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
* Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
* The first group selects the property name the expression refers to.
*/
-private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
Review Comment:
No it isn’t:
https://docs.oracle.com/javase/tutorial/essential/regex/quant.html. The latter
is greedy while the former is reluctant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MRELEASE-1109] patch JDomModel [maven-release]
kwin commented on code in PR #201:
URL: https://github.com/apache/maven-release/pull/201#discussion_r1439031745
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
* Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
* The first group selects the property name the expression refers to.
*/
-private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
Review Comment:
No it isn’t:
https://docs.oracle.com/javase/tutorial/essential/regex/quant.html. The former
is greedy while the latter is reluctant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINVOKER-352) Remove usage commons-lang3
Karl Heinz Marbaise created MINVOKER-352: Summary: Remove usage commons-lang3 Key: MINVOKER-352 URL: https://issues.apache.org/jira/browse/MINVOKER-352 Project: Maven Invoker Plugin Issue Type: Improvement Affects Versions: 3.6.0 Reporter: Karl Heinz Marbaise Assignee: Karl Heinz Marbaise Fix For: 3.x Currently methods / classes of commons-lang3 are used only very few. We can get rid of the usage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801537#comment-17801537
]
ASF GitHub Bot commented on MRELEASE-1109:
--
elharo commented on code in PR #201:
URL: https://github.com/apache/maven-release/pull/201#discussion_r1439016711
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
* Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
* The first group selects the property name the expression refers to.
*/
-private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
Review Comment:
Is .+? the same as .*
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRELEASE-1109] patch JDomModel [maven-release]
elharo commented on code in PR #201:
URL: https://github.com/apache/maven-release/pull/201#discussion_r1439016711
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
* Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
* The first group selects the property name the expression refers to.
*/
-private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
Review Comment:
Is .+? the same as .*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump com.google.inject:guice from 6.0.0 to 7.0.0 [maven-doxia]
dependabot[bot] opened a new pull request, #192:
URL: https://github.com/apache/maven-doxia/pull/192
Bumps [com.google.inject:guice](https://github.com/google/guice) from 6.0.0
to 7.0.0.
Release notes
Sourced from https://github.com/google/guice/releases;>com.google.inject:guice's
releases.
Guice 7.0.0
See https://github.com/google/guice/wiki/Guice700;>https://github.com/google/guice/wiki/Guice700
for release notes.
Guice 7.0.0-rc1
See https://github.com/google/guice/wiki/Guice700;>https://github.com/google/guice/wiki/Guice700
for release notes.
Commits
https://github.com/google/guice/commit/b0e1d0fab0167cd555ab8d262333c1a32db7d492;>b0e1d0f
set 7.0.0 release #s.
https://github.com/google/guice/commit/f4a66b797ecc05d80406d6c8fb11e6cc0e5c6d21;>f4a66b7
Make error_prone_annotations dependency optional
https://github.com/google/guice/commit/654032a954d55a00fc5ee90da815da98cb6676a1;>654032a
Internal change.
https://github.com/google/guice/commit/bee813b7cc15e46695ca1baf5041a00e0a612f91;>bee813b
Improve MissingImplementationError to lazily calculate suggestions and
standa...
https://github.com/google/guice/commit/2d64067e99401e50404c6e05a819bce891b725de;>2d64067
Use linked bindings for MapBinder/Multibinder/OptionalBinder aliases,
instead...
https://github.com/google/guice/commit/be0141cc0d01763a13ec0b2fcd32ddbe0748ad6d;>be0141c
Internal change
https://github.com/google/guice/commit/40a5bcfab5cfe45c3b6c5ffc9309b310df82775b;>40a5bcf
Avoid re-initializing factories that are already initialized. This is
necessa...
https://github.com/google/guice/commit/9ac476784e88f4481f8211dcb19ac536f5f2b32d;>9ac4767
Change the way we reference what 6.0 supports in the README, so it doesn't
ge...
https://github.com/google/guice/commit/24324ca6c61f64872376ed7f4ed22a3f1f0724f1;>24324ca
Prepare for the Guice 6.0 7.0 releases. This change does the
following:
https://github.com/google/guice/commit/49b1a33c594fd92ad0d1d013fa91d689e8814a6c;>49b1a33
Remove redundant references to javax.{inject,persistence,servlet} and
replace...
See full diff in https://github.com/google/guice/compare/6.0.0...7.0.0;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI
passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and
block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it.
You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of
the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the PR or
upgrade to it yourself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.1 to 1.2 [maven-release]
elharo merged PR #207: URL: https://github.com/apache/maven-release/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange
[
https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801521#comment-17801521
]
ASF GitHub Bot commented on MRELEASE-1054:
--
wuwen5 commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1438995411
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -39,6 +43,7 @@
import org.apache.maven.shared.release.versions.VersionParseException;
import org.codehaus.plexus.components.interactivity.Prompter;
import org.codehaus.plexus.components.interactivity.PrompterException;
+import org.codehaus.plexus.util.SelectorUtils;
Review Comment:
Removed use of `SelectorUtils`
> [Git submodule] Wrong Change on scm submodule after release:prepare and
> failed on pushChange
>
>
> Key: MRELEASE-1054
> URL: https://issues.apache.org/jira/browse/MRELEASE-1054
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: Git, prepare, scm
>Affects Versions: 3.0.0-M1
>Reporter: Cau Ta
>Priority: Major
> Attachments: Screen Shot 2020-07-29 at 13.54.41.png
>
>
> *My project structure:*
> {{parent (git scm repo parent.git)}}
> {{-- git submodule A (git scm repo a.git)}}
> {{-- git submodule B (git scm repo b.git)}}
> {{-- git submodule C (git scm repo c.git)}}
> my maven release plugin config on parent pom.xml:
> __
> _org.apache.maven.plugins_
> _maven-release-plugin_
> _3.0.0-M1_
> __
> __
> _v@\{project.version}_
> _true_
> _true_
> _true_
> _false_
> __
> __
>
> The release was successful but after release:prepare the scm config of all
> submodule has been change.
> [Please take a look at the attachment]
> *--*
> *Another bug i have been faced is:*
> when enable push change (_true_)
> the release:prepare got stuck after push change at the first git submodule
> _[INFO] Executing: /bin/sh -c cd repository/beowulf/beowulf-libs/constant &&
> git push g...@github.com:beowulfchain-libs/beowulf-libs.git
> refs/heads/master:refs/heads/master_
> _[INFO] Working directory: repository/beowulf/beowulf-libs/constant_
> _[INFO]
> _
> _[INFO] Reactor Summary for beowulf 1.0-SNAPSHOT:_
> _[INFO]_
> _[INFO] beowulf FAILURE [
> 42.033 s]_
> _[INFO] constant ... SKIPPED_
> _[INFO] core ... SKIPPED_
> _[INFO] utils .. SKIPPED_
> _[INFO] domain . SKIPPED_
> _[INFO] config . SKIPPED_
> _[INFO] logging SKIPPED_
> _[INFO]
> _
> _[INFO] BUILD FAILURE_
> _[INFO]
> _
> _[INFO] Total time: 42.709 s_
> _[INFO] Finished at: 2020-07-28T17:51:04+07:00_
> _[INFO]
> _
> _[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M1:prepare (default-cli)
> on project beowulf: Unable to commit files_
> _[ERROR] Provider message:_
> _[ERROR] The git-push command failed._
> _[ERROR] Command output:_
> _[ERROR] Warning: Permanently added the RSA host key for IP address
> 'xxx.xxx.xxx.3' to the list of known hosts._
> _[ERROR] To github.com:beowulfchain-libs/beowulf-libs.git_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRELEASE-1054] Support for excluding submodules changes. [maven-release]
wuwen5 commented on code in PR #196: URL: https://github.com/apache/maven-release/pull/196#discussion_r1438995411 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -39,6 +43,7 @@ import org.apache.maven.shared.release.versions.VersionParseException; import org.codehaus.plexus.components.interactivity.Prompter; import org.codehaus.plexus.components.interactivity.PrompterException; +import org.codehaus.plexus.util.SelectorUtils; Review Comment: Removed use of `SelectorUtils` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7991) refactor aggregator goal
[ https://issues.apache.org/jira/browse/MNG-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-7991: --- Description: aggregation was added in early Maven 2 stages with MNG-250, not really documented AFAIK there are multiple shortcomings found over time: * discrepancy between CLI and lifecycle use: CLI skips execution in sub-modules, but not lifecycle * forked lifecycle execution vs second execution in modules * sometimes, instead of executing aggregate goal *before* building modules, it would be useful to execute aggregate *after* building modules (to aggregate some results built in each module) notice that this looks also like the need for "execute at end" as found in install/deploy we probably need to better document what aggregate currently does and define what should be the target: perhaps refactoring will require new mechanisms that we won't call aggregator, like MNG-5665... edge case: aggregating reports for maven-site-plugin (launched by maven-reporting-exec, hence quite independent from associated reporting goals even if we expect some consistency between site reports and reporting goals) was: aggregation was added in early Maven 2 stages with MNG-250, not really documented AFAIK there are multiple shortcomings found over time: * discrepancy between CLI and lifecycle use: CLI skips execution in sub-modules, but not lifecycle * forked lifecycle execution vs second execution in modules * sometimes, instead of executing aggregate goal *before* building modules, it would be useful to execute aggregate *after* building modules (to aggregate some results built in each module) notice that this looks also like the need for "execute at end" as found in install/deploy we probably need to better document what aggregate currently does and define what should be the target: perhaps refactoring will require new mechanisms that we won't call aggregator, like MNG-5665... edge case: aggregating reports for maven-site-plugin (launched by maven-reporting-exec, hence quite independent from associated reporting goals even if we expect some consistency) > refactor aggregator goal > > > Key: MNG-7991 > URL: https://issues.apache.org/jira/browse/MNG-7991 > Project: Maven > Issue Type: Wish > Components: Plugin API, Plugins and Lifecycle, Reactor and Workspace >Affects Versions: 4.x / Backlog >Reporter: Herve Boutemy >Priority: Major > > aggregation was added in early Maven 2 stages with MNG-250, not really > documented AFAIK > there are multiple shortcomings found over time: > * discrepancy between CLI and lifecycle use: CLI skips execution in > sub-modules, but not lifecycle > * forked lifecycle execution vs second execution in modules > * sometimes, instead of executing aggregate goal *before* building modules, > it would be useful to execute aggregate *after* building modules (to > aggregate some results built in each module) > notice that this looks also like the need for "execute at end" as found in > install/deploy > we probably need to better document what aggregate currently does and define > what should be the target: perhaps refactoring will require new mechanisms > that we won't call aggregator, like MNG-5665... > edge case: aggregating reports for maven-site-plugin (launched by > maven-reporting-exec, hence quite independent from associated reporting goals > even if we expect some consistency between site reports and reporting goals) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7991) refactor aggregator goal
[ https://issues.apache.org/jira/browse/MNG-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-7991: --- Description: aggregation was added in early Maven 2 stages with MNG-250, not really documented AFAIK there are multiple shortcomings found over time: * discrepancy between CLI and lifecycle use: CLI skips execution in sub-modules, but not lifecycle * forked lifecycle execution vs second execution in modules * sometimes, instead of executing aggregate goal *before* building modules, it would be useful to execute aggregate *after* building modules (to aggregate some results built in each module) notice that this looks also like the need for "execute at end" as found in install/deploy we probably need to better document what aggregate currently does and define what should be the target: perhaps refactoring will require new mechanisms that we won't call aggregator, like MNG-5665... edge case: aggregating reports for maven-site-plugin (launched by maven-reporting-exec, hence quite independent from associated reporting goals even if we expect some consistency) was: aggregation was added in early Maven 2 stages with MNG-250, not really documented AFAIK there are multiple shortcomings found over time: * discrepancy between CLI and lifecycle use: CLI skips execution in sub-modules, but not lifecycle * forked lifecycle execution vs second execution in modules * sometimes, instead of executing aggregate goal before building modules, it would be useful to execute aggregate after building modules (to aggregate some results built in each module) notice that this looks also like the need for "execute at end" as found in install/deploy we probably need to better document what aggregate currently does and define what should be the target: perhaps refactoring will require new mechanisms that we won't call aggregator... edge case: aggregating reports for maven-site-plugin (launched by maven-reporting-exec, hence quite independent from associated reporting goals even if we expect some consistency) > refactor aggregator goal > > > Key: MNG-7991 > URL: https://issues.apache.org/jira/browse/MNG-7991 > Project: Maven > Issue Type: Wish > Components: Plugin API, Plugins and Lifecycle, Reactor and Workspace >Affects Versions: 4.x / Backlog >Reporter: Herve Boutemy >Priority: Major > > aggregation was added in early Maven 2 stages with MNG-250, not really > documented AFAIK > there are multiple shortcomings found over time: > * discrepancy between CLI and lifecycle use: CLI skips execution in > sub-modules, but not lifecycle > * forked lifecycle execution vs second execution in modules > * sometimes, instead of executing aggregate goal *before* building modules, > it would be useful to execute aggregate *after* building modules (to > aggregate some results built in each module) > notice that this looks also like the need for "execute at end" as found in > install/deploy > we probably need to better document what aggregate currently does and define > what should be the target: perhaps refactoring will require new mechanisms > that we won't call aggregator, like MNG-5665... > edge case: aggregating reports for maven-site-plugin (launched by > maven-reporting-exec, hence quite independent from associated reporting goals > even if we expect some consistency) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7976) Investigate MNG-6127 IT instability
[ https://issues.apache.org/jira/browse/MNG-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801516#comment-17801516 ] Zhongming Hua commented on MNG-7976: [~cstamas] I can't reproduce the unstable 6127 IT in the local environment. With the debug log enabled, I will try to troubleshoot the problem through the debug log. https://github.com/apache/maven-integration-testing/pull/330 > Investigate MNG-6127 IT instability > --- > > Key: MNG-7976 > URL: https://issues.apache.org/jira/browse/MNG-7976 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > The MNG-6127 IT quite often fails, and passes when CI job rebuilt, seems > unstable. > Look into it why (lurking concurrency bug somewhere? or just the IT is > flakey?) and fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Enables debug logs in MavenITmng6127 [maven-integration-testing]
CrazyHZM opened a new pull request, #330: URL: https://github.com/apache/maven-integration-testing/pull/330 I can't reproduce the unstable 6127 IT in the local environment. With the debug log enabled, I will try to troubleshoot the problem through the debug log. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
