[jira] [Created] (MSHADE-471) still timestamp issues
Herve Boutemy created MSHADE-471:
Summary: still timestamp issues
Key: MSHADE-471
URL: https://issues.apache.org/jira/browse/MSHADE-471
Project: Maven Shade Plugin
Issue Type: Bug
Affects Versions: 3.5.2
Reporter: Herve Boutemy
MSHADE-420 is incomplete, problems still appear like
{noformat}1 / 1
target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
toolbox/target/toolbox-0.1.5-cli.jar
--- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
+++ toolbox/target/toolbox-0.1.5-cli.jar
├── zipinfo {}
│ @@ -735,96 +735,96 @@
│ -rw 2.0 fat 50 bl defN 24-Jan-23 12:20
META-INF/maven/org.jline/jline/pom.properties
│ --rw 2.0 fat0 bl defN 23-Oct-12 07:38
META-INF/native-image/jansi/
│ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38
META-INF/native-image/jansi/jni-config.json
...
│ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38
META-INF/maven/org.fusesource.jansi/jansi/pom.xml
│ --rw 2.0 fat 60 bl defN 23-Oct-12 07:38
META-INF/maven/org.fusesource.jansi/jansi/pom.properties
│ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38
META-INF/native-image/jansi/
│ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38
META-INF/native-image/jansi/jni-config.json
...
│ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38
META-INF/maven/org.fusesource.jansi/jansi/pom.xml
│ +-rw 2.0 fat 60 bl defN 23-Oct-12 06:38
META-INF/maven/org.fusesource.jansi/jansi/pom.properties
│ -rw 2.0 fat0 bl defN 24-Apr-11 20:18
eu/maveniverse/maven/toolbox/shared/
{noformat}
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-parent]
CrazyHZM merged PR #172: URL: https://github.com/apache/maven-parent/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-parent]
dependabot[bot] opened a new pull request, #172: URL: https://github.com/apache/maven-parent/pull/172 Bumps [apache/maven-gh-actions-shared](https://github.com/apache/maven-gh-actions-shared) from 3 to 4. Commits https://github.com/apache/maven-gh-actions-shared/commit/26f55bffc699e7bc46a512ae86187bce7d5340be";>26f55bf Apply ASF Infra GitHub Actions Policy https://github.com/apache/maven-gh-actions-shared/commit/45f4617ba01c4be9dca576ff755f548127e76086";>45f4617 Add GPG install step See full diff in https://github.com/apache/maven-gh-actions-shared/compare/v3...v4";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-apache-parent]
dependabot[bot] opened a new pull request, #211: URL: https://github.com/apache/maven-apache-parent/pull/211 Bumps [apache/maven-gh-actions-shared](https://github.com/apache/maven-gh-actions-shared) from 3 to 4. Commits https://github.com/apache/maven-gh-actions-shared/commit/26f55bffc699e7bc46a512ae86187bce7d5340be";>26f55bf Apply ASF Infra GitHub Actions Policy https://github.com/apache/maven-gh-actions-shared/commit/45f4617ba01c4be9dca576ff755f548127e76086";>45f4617 Add GPG install step See full diff in https://github.com/apache/maven-gh-actions-shared/compare/v3...v4";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MPOM-483] Make a separate module for documentation [maven-parent]
slawekjaranowski opened a new pull request, #171: URL: https://github.com/apache/maven-parent/pull/171 current: https://maven.apache.org/pom/maven/index.html new: https://maven.apache.org/pom-archives/maven-LATEST/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
slawekjaranowski commented on code in PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210#discussion_r1563159511 ## docs/pom.xml: ## @@ -82,11 +77,26 @@ under the License. + + +org.apache.maven.plugins +maven-install-plugin + + true + + + +org.apache.maven.plugins +maven-deploy-plugin + + true Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
slawekjaranowski commented on PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210#issuecomment-2052473907 In ASF parent pom there is more trick about publishing documentation and publishing parent pom. For documentation perspective we need add some information to pom ... but we don't want to propagate it to child project. So current we have a special site-pom.xml which must by manually edited during release process. I trying to avoid such manual taks. https://maven.apache.org/developers/release/parent-pom-release.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
slawekjaranowski commented on code in PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210#discussion_r1563147779 ## docs/pom.xml: ## @@ -82,11 +77,26 @@ under the License. + + +org.apache.maven.plugins +maven-install-plugin + + true + + + +org.apache.maven.plugins +maven-deploy-plugin + + true Review Comment: ok, good idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make TerminalOutput.pathToMaven() more robust to avoid #929 [maven-mvnd]
ppalaga commented on PR #930: URL: https://github.com/apache/maven-mvnd/pull/930#issuecomment-2052397518 > It would be nice to log (debug?) when the URL is malformed Well, the issue we are mitigating happens only in the text UI, where the place is sparse and where there is no concept of log level. I am not sure the information that we were not able to parse some URL is that interesting to end users. If we cannot parse it, we just print it as is. If the transfer failure matters, the daemon will inform them through a separate message. If it is ignorable, I do not think they need to know. My 2c. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] TerminalOutput.pathToMaven throws StringIndexOutOfBoundsException [maven-mvnd]
ppalaga commented on issue #929: URL: https://github.com/apache/maven-mvnd/issues/929#issuecomment-2052375052 > Would logging just bare file name not be enough? The full URL is much longer. The g:a:v makes the text UI much better readable. > It looks like it's missing the packaging in the URL, which should default to jar if not specified in the model. Fixing the rendering in the console would be easy. Omitting the packaging is wrong at its source (wherever it comes from) because there are download failures logged for each of these incomplete URLs. I wonder whether it is the sundr-maven-plugin that is called from quarkus-langchain4j-parent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
ctubbsii commented on code in PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210#discussion_r1563034471 ## docs/pom.xml: ## @@ -82,11 +77,26 @@ under the License. + + +org.apache.maven.plugins +maven-install-plugin + + true + + + +org.apache.maven.plugins +maven-deploy-plugin + + true Review Comment: Can these skips be done with a property instead? Seems like it would be less config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
slawekjaranowski opened a new pull request, #210: URL: https://github.com/apache/maven-apache-parent/pull/210 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-478) Remove manually maintained history from site
[ https://issues.apache.org/jira/browse/MPOM-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-478. Resolution: Fixed > Remove manually maintained history from site > > > Key: MPOM-478 > URL: https://issues.apache.org/jira/browse/MPOM-478 > Project: Maven POMs > Issue Type: Improvement > Components: asf, maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-32, MAVEN-42 > > > We have history of releases eg: > [https://maven.apache.org/pom/asf/#history] > [https://maven.apache.org/pom/maven/#history] > [https://maven.apache.org/pom/maven/maven-plugins/#history] > We can replace it by link to GitHub tags/releases and everybody can find what > is interesting for them. > > All of them are manually edited during release preparing. > We should avoid manual steps during release. > Site [https://maven.apache.org/developers/release/parent-pom-release.html] - > should be updated after it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPOM-478) Remove manually maintained history from site
[ https://issues.apache.org/jira/browse/MPOM-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836726#comment-17836726 ] ASF GitHub Bot commented on MPOM-478: - slawekjaranowski merged PR #508: URL: https://github.com/apache/maven-site/pull/508 > Remove manually maintained history from site > > > Key: MPOM-478 > URL: https://issues.apache.org/jira/browse/MPOM-478 > Project: Maven POMs > Issue Type: Improvement > Components: asf, maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-32, MAVEN-42 > > > We have history of releases eg: > [https://maven.apache.org/pom/asf/#history] > [https://maven.apache.org/pom/maven/#history] > [https://maven.apache.org/pom/maven/maven-plugins/#history] > We can replace it by link to GitHub tags/releases and everybody can find what > is interesting for them. > > All of them are manually edited during release preparing. > We should avoid manual steps during release. > Site [https://maven.apache.org/developers/release/parent-pom-release.html] - > should be updated after it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-478] Simplify release of parent POMs [maven-site]
slawekjaranowski merged PR #508: URL: https://github.com/apache/maven-site/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-482) Publish site descriptor with new parent
[ https://issues.apache.org/jira/browse/MPOM-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-482. Resolution: Fixed > Publish site descriptor with new parent > --- > > Key: MPOM-482 > URL: https://issues.apache.org/jira/browse/MPOM-482 > Project: Maven POMs > Issue Type: Task > Components: maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-42 > > > In MPOM-480 maven-site-plugin:attach-descriptor was removed from parent. > We need add it where is needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-482] Publish site descriptor with new parent [maven-parent]
slawekjaranowski merged PR #170: URL: https://github.com/apache/maven-parent/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make TerminalOutput.pathToMaven() more robust to avoid #929 [maven-mvnd]
gastaldi commented on PR #930: URL: https://github.com/apache/maven-mvnd/pull/930#issuecomment-2052263766 It would be nice to log (debug?) when the URL is malformed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] TerminalOutput.pathToMaven throws StringIndexOutOfBoundsException [maven-mvnd]
gastaldi commented on issue #929: URL: https://github.com/apache/maven-mvnd/issues/929#issuecomment-2052259867 It looks like it's missing the `packaging` in the URL, which should default to `jar` if not specified in the model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPOM-483) Make a separate module for documentation
Slawomir Jaranowski created MPOM-483:
Summary: Make a separate module for documentation
Key: MPOM-483
URL: https://issues.apache.org/jira/browse/MPOM-483
Project: Maven POMs
Issue Type: Improvement
Components: asf, maven
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
Fix For: ASF-32, MAVEN-42
Instead of having separate poms like {{site-pom.xml}} we can create separate
module for documentation.
Thanks to this, we will get rid of the last manual step during release.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
slawekjaranowski commented on PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#issuecomment-2052186688 It can be a time needed for downloading new plugins version into tarted/local-repo Too small difference to more investigating build with `mvn clean ...` ``` gpg [INFO] sign-release-best-practices/pom.xml .. SUCCESS (8.135 s) bc [INFO] sign-release-best-practices/pom.xml .. SUCCESS (2.189 s) ``` next without `clean` ``` gpg [INFO] sign-release-best-practices/pom.xml .. SUCCESS (2.653 s) bc [INFO] sign-release-best-practices/pom.xml .. SUCCESS (2.237 s) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-120) attach site descriptor only for pom packaging
[ https://issues.apache.org/jira/browse/MPOM-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836705#comment-17836705 ] Slawomir Jaranowski commented on MPOM-120: -- I missed this issue and did one more MPOM-480, so this can be closed now. > attach site descriptor only for pom packaging > - > > Key: MPOM-120 > URL: https://issues.apache.org/jira/browse/MPOM-120 > Project: Maven POMs > Issue Type: Improvement > Components: asf >Affects Versions: ASF-17 >Reporter: Herve Boutemy >Priority: Minor > > publishing site.xml is only useful for parent poms, not for jar or any other > packaging: running attach-descriptor that will then skip attach is not useful > would be better to avoid running the goal -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNGSITE-536) Link to Reference "Maven Plugin Tools and annotations" wrong
[
https://issues.apache.org/jira/browse/MNGSITE-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MNGSITE-536.
---
Resolution: Fixed
> Link to Reference "Maven Plugin Tools and annotations" wrong
>
>
> Key: MNGSITE-536
> URL: https://issues.apache.org/jira/browse/MNGSITE-536
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> The link on the page https://maven.apache.org/plugin-developers/index.html to
> the annotation {{Maven Plugin Tools and annotations}} is wrong.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNGSITE-536) Link to Reference "Maven Plugin Tools and annotations" wrong
[
https://issues.apache.org/jira/browse/MNGSITE-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836698#comment-17836698
]
ASF GitHub Bot commented on MNGSITE-536:
asfgit merged PR #512:
URL: https://github.com/apache/maven-site/pull/512
> Link to Reference "Maven Plugin Tools and annotations" wrong
>
>
> Key: MNGSITE-536
> URL: https://issues.apache.org/jira/browse/MNGSITE-536
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> The link on the page https://maven.apache.org/plugin-developers/index.html to
> the annotation {{Maven Plugin Tools and annotations}} is wrong.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNGSITE-536] - Link to Reference "Maven Plugin Tools and annotations… [maven-site]
asfgit merged PR #512: URL: https://github.com/apache/maven-site/pull/512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-536) Link to Reference "Maven Plugin Tools and annotations" wrong
[
https://issues.apache.org/jira/browse/MNGSITE-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836694#comment-17836694
]
ASF GitHub Bot commented on MNGSITE-536:
khmarbaise opened a new pull request, #512:
URL: https://github.com/apache/maven-site/pull/512
…" wrong
> Link to Reference "Maven Plugin Tools and annotations" wrong
>
>
> Key: MNGSITE-536
> URL: https://issues.apache.org/jira/browse/MNGSITE-536
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> The link on the page https://maven.apache.org/plugin-developers/index.html to
> the annotation {{Maven Plugin Tools and annotations}} is wrong.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MNGSITE-536] - Link to Reference "Maven Plugin Tools and annotations… [maven-site]
khmarbaise opened a new pull request, #512: URL: https://github.com/apache/maven-site/pull/512 …" wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail
[ https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836693#comment-17836693 ] ASF GitHub Bot commented on MGPG-125: - cstamas commented on PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#issuecomment-2052127538 For last build this PR: ``` [INFO] Building: sign-release-best-practices/pom.xml [INFO] run post-build script verify.groovy [INFO] sign-release-best-practices/pom.xml .. SUCCESS (4.002 s) ``` 2nd build/commit: ``` [INFO] Building: sign-release-best-practices/pom.xml [INFO] run post-build script verify.groovy [INFO] sign-release-best-practices/pom.xml .. SUCCESS (3.877 s) ``` Hm, minimal... unsure what I "feel" locally. Maybe that these two ITs use _new_ plugins (hence downoads them) while all the rest use old/ancient plugins but some version? > Due to default value of gpg.passphraseServerId, bestPractices=true will > always fail > --- > > Key: MGPG-125 > URL: https://issues.apache.org/jira/browse/MGPG-125 > Project: Maven GPG Plugin > Issue Type: Bug >Affects Versions: 3.2.3 >Reporter: Benjamin Marwell >Assignee: Tamas Cservenak >Priority: Critical > Fix For: 3.2.4 > > > Running gpg-plugin with best practices from the CLI, it will always fail > since gpg.passphraseServerId does have a default value set. > See: > https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140 > CC [~cstamas] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
cstamas commented on PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#issuecomment-2052127538 For last build this PR: ``` [INFO] Building: sign-release-best-practices/pom.xml [INFO] run post-build script verify.groovy [INFO] sign-release-best-practices/pom.xml .. SUCCESS (4.002 s) ``` 2nd build/commit: ``` [INFO] Building: sign-release-best-practices/pom.xml [INFO] run post-build script verify.groovy [INFO] sign-release-best-practices/pom.xml .. SUCCESS (3.877 s) ``` Hm, minimal... unsure what I "feel" locally. Maybe that these two ITs use _new_ plugins (hence downoads them) while all the rest use old/ancient plugins but some version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNGSITE-536) Link to Reference "Maven Plugin Tools and annotations" wrong
Karl Heinz Marbaise created MNGSITE-536:
---
Summary: Link to Reference "Maven Plugin Tools and annotations"
wrong
Key: MNGSITE-536
URL: https://issues.apache.org/jira/browse/MNGSITE-536
Project: Maven Project Web Site
Issue Type: Bug
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
The link on the page https://maven.apache.org/plugin-developers/index.html to
the annotation {{Maven Plugin Tools and annotations}} is wrong.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPOM-482) Publish site descriptor with new parent
Slawomir Jaranowski created MPOM-482: Summary: Publish site descriptor with new parent Key: MPOM-482 URL: https://issues.apache.org/jira/browse/MPOM-482 Project: Maven POMs Issue Type: Task Components: maven Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: MAVEN-42 In MPOM-480 maven-site-plugin:attach-descriptor was removed from parent. We need add it where is needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
slawekjaranowski commented on PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#issuecomment-2052107116 > but now the new IT is considerably slower ... do you have any number to compare? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-532) Move plugin-report to Reporting Plugin table
[
https://issues.apache.org/jira/browse/MNGSITE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836683#comment-17836683
]
ASF GitHub Bot commented on MNGSITE-532:
asfgit merged PR #511:
URL: https://github.com/apache/maven-site/pull/511
> Move plugin-report to Reporting Plugin table
>
>
> Key: MNGSITE-532
> URL: https://issues.apache.org/jira/browse/MNGSITE-532
> Project: Maven Project Web Site
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Karl Heinz Marbaise
>Priority: Major
>
> In https://maven.apache.org/plugins/index.html {{plugin-report}} is a pure
> reporting plugin, like {{surefire-report}}, it should be in reporting...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNGSITE-532) Move plugin-report to Reporting Plugin table
[
https://issues.apache.org/jira/browse/MNGSITE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MNGSITE-532.
---
Resolution: Fixed
> Move plugin-report to Reporting Plugin table
>
>
> Key: MNGSITE-532
> URL: https://issues.apache.org/jira/browse/MNGSITE-532
> Project: Maven Project Web Site
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Karl Heinz Marbaise
>Priority: Major
>
> In https://maven.apache.org/plugins/index.html {{plugin-report}} is a pure
> reporting plugin, like {{surefire-report}}, it should be in reporting...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNGSITE-532] - Move plugin-report to Reporting Plugin table [maven-site]
asfgit merged PR #511: URL: https://github.com/apache/maven-site/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties
[
https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836674#comment-17836674
]
ASF GitHub Bot commented on MNG-8081:
-
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2052059016
@gnodet do you have any thoughts on the best way to backport this feature to
Maven 3? https://github.com/apache/maven/pull/1447 is my original PR, but a
wildly divergent implementation may cause headaches in future. I wonder if it
would make sense [from a future merge perspective] to stabilize the v3 impl and
include the same commit in this branch prior to being replaced by the actual v4
implementation. 🤔
> default profile activation should consider available system and user
> properties
> ---
>
> Key: MNG-8081
> URL: https://issues.apache.org/jira/browse/MNG-8081
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.9.6, 4.0.0
>Reporter: Matthew Jason Benson
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-alpha-14
>
>
> As discussed in my open PR, my use case is to compare between environment
> variables e.g.:
> {code:java}
>
>
> env.FOO
> ${env.BAR}
>
> {code}
> Limiting the interpolation to user/system properties means that there is no
> mindf*ck resulting from profile activation order, etc., and keeps this
> request nonthreatening.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNGSITE-532) Move plugin-report to Reporting Plugin table
[
https://issues.apache.org/jira/browse/MNGSITE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836672#comment-17836672
]
ASF GitHub Bot commented on MNGSITE-532:
khmarbaise opened a new pull request, #511:
URL: https://github.com/apache/maven-site/pull/511
(no comment)
> Move plugin-report to Reporting Plugin table
>
>
> Key: MNGSITE-532
> URL: https://issues.apache.org/jira/browse/MNGSITE-532
> Project: Maven Project Web Site
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Karl Heinz Marbaise
>Priority: Major
>
> In https://maven.apache.org/plugins/index.html {{plugin-report}} is a pure
> reporting plugin, like {{surefire-report}}, it should be in reporting...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2052059016 @gnodet do you have any thoughts on the best way to backport this feature to Maven 3? https://github.com/apache/maven/pull/1447 is my original PR, but a wildly divergent implementation may cause headaches in future. I wonder if it would make sense [from a future merge perspective] to stabilize the v3 impl and include the same commit in this branch prior to being replaced by the actual v4 implementation. 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNGSITE-532) Move plugin-report to Reporting Plugin table
[
https://issues.apache.org/jira/browse/MNGSITE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MNGSITE-532:
---
Assignee: Karl Heinz Marbaise
> Move plugin-report to Reporting Plugin table
>
>
> Key: MNGSITE-532
> URL: https://issues.apache.org/jira/browse/MNGSITE-532
> Project: Maven Project Web Site
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Karl Heinz Marbaise
>Priority: Major
>
> In https://maven.apache.org/plugins/index.html {{plugin-report}} is a pure
> reporting plugin, like {{surefire-report}}, it should be in reporting...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNGSITE-535] - Improve the Release Notes about 3.9.2 - related to to… [maven-site]
asfgit merged PR #510: URL: https://github.com/apache/maven-site/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-535) Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
[
https://issues.apache.org/jira/browse/MNGSITE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836661#comment-17836661
]
Karl Heinz Marbaise commented on MNGSITE-535:
-
Done in [7d8d3c187215da8137e6ff7a174a741d59c8a3e7|.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
http://localhost:8081/nexus/content/groups
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
(/Users/khm/ws-git-maven/maven-site
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
http://localhost:8081/nexus/content/groups
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.?p=1.0:
The
following
artifacts
could
not
be
resolved:
org.apache.maven:maven-parent:pom:42-SNAPSHOT
(absent):
org.apache.maven:maven-parent:pom:42-SNAPSHOT
was
not
found
in
public
during
a
previous
attempt.
This
failure
was
cached
in
the
local
repository
and
resolution
is
not
reattempted
until
the
update
interval
of
nexus
has
elapsed
or
updates
are
forced
and
'parent.relativePath'
points
at
no
local
POM
@
line
23,
column
11
@
[ERROR]
The
build
could
not
read
1
project
->
[Help
1]
[ERROR]
1.0
pom.xml)
has
1
error
1.0:
The
following
artifacts
could
not
be
resolved:
org.apache.maven:maven-parent:pom:42-SNAPSHOT
(absent):
org.apache.maven:maven-parent:pom:42-SNAPSHOT
was
not
found
in
public
during
a
previous
attempt.
This
failure
was
cached
in
the
local
repository
and
resolution
is
not
reattempted
until
the
update
interval
of
nexus
has
elapsed
or
updates
are
forced
and
'parent.relativePath'
points
at
no
local
POM
@
line
23,
column
11
->
[Help
2]
[ERROR]
[ERROR]
To
see
the
full
stack
trace
of
the
errors,
re-run
Maven
with
the
-e
switch.
[ERROR]
Re-run
Maven
using
the
-X
switch
to
enable
full
debug
logging.
[ERROR];a=commitdiff;h=7d8d3c187215da8137e6ff7a174a741d59c8a3e7]
> Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
> -
>
> Key: MNGSITE-535
> URL: https://issues.apache.org/jira/browse/MNGSITE-535
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> Related to this: MNG-8095 there should more clear wording when the following
> properties can be used and when not:
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNGSITE-535) Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
[
https://issues.apache.org/jira/browse/MNGSITE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MNGSITE-535.
---
Resolution: Done
> Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
> -
>
> Key: MNGSITE-535
> URL: https://issues.apache.org/jira/browse/MNGSITE-535
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> Related to this: MNG-8095 there should more clear wording when the following
> properties can be used and when not:
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNGSITE-535) Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
[
https://issues.apache.org/jira/browse/MNGSITE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836661#comment-17836661
]
Karl Heinz Marbaise edited comment on MNGSITE-535 at 4/12/24 3:48 PM:
--
Done in [7d8d3c187215da8137e6ff7a174a741d59c8a3e7|
was (Author: khmarbaise):
Done in [7d8d3c187215da8137e6ff7a174a741d59c8a3e7|.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
http://localhost:8081/nexus/content/groups
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
(/Users/khm/ws-git-maven/maven-site
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
http://localhost:8081/nexus/content/groups
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.?p=1.0:
The
following
artifacts
could
not
be
resolved:
org.apache.maven:maven-parent:pom:42-SNAPSHOT
(absent):
org.apache.maven:maven-parent:pom:42-SNAPSHOT
was
not
found
in
public
during
a
previous
attempt.
This
failure
was
cached
in
the
local
repository
and
resolution
is
not
reattempted
until
the
update
interval
of
nexus
has
elapsed
or
updates
are
forced
and
'parent.relativePath'
points
at
no
local
POM
@
line
23,
column
11
@
[ERROR]
The
build
could
not
read
1
project
->
[Help
1]
[ERROR]
1.0
pom.xml)
has
1
error
1.0:
The
following
artifacts
could
not
be
resolved:
org.apache.maven:maven-parent:pom:42-SNAPSHOT
(absent):
org.apache.maven:maven-parent:pom:42-SNAPSHOT
was
not
found
in
public
during
a
previous
attempt.
This
failure
was
cached
in
the
local
repository
and
resolution
is
not
reattempted
until
the
update
interval
of
nexus
has
elapsed
or
updates
are
forced
and
'parent.relativePath'
points
at
no
local
POM
@
line
23,
column
11
->
[Help
2]
[ERROR]
[ERROR]
To
see
the
full
stack
trace
of
the
errors,
re-run
Maven
with
the
-e
switch.
[ERROR]
Re-run
Maven
using
the
-X
switch
to
enable
full
debug
logging.
[ERROR];a=commitdiff;h=7d8d3c187215da8137e6ff7a174a741d59c8a3e7]
> Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
> -
>
> Key: MNGSITE-535
> URL: https://issues.apache.org/jira/browse/MNGSITE-535
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> Related to this: MNG-8095 there should more clear wording when the following
> properties can be used and when not:
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNGSITE-535) Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
[
https://issues.apache.org/jira/browse/MNGSITE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836660#comment-17836660
]
ASF GitHub Bot commented on MNGSITE-535:
asfgit merged PR #510:
URL: https://github.com/apache/maven-site/pull/510
> Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
> -
>
> Key: MNGSITE-535
> URL: https://issues.apache.org/jira/browse/MNGSITE-535
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> Related to this: MNG-8095 there should more clear wording when the following
> properties can be used and when not:
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNGSITE-535) Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
[
https://issues.apache.org/jira/browse/MNGSITE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836659#comment-17836659
]
ASF GitHub Bot commented on MNGSITE-535:
khmarbaise opened a new pull request, #510:
URL: https://github.com/apache/maven-site/pull/510
…pDirectory/rootDirectory
> Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
> -
>
> Key: MNGSITE-535
> URL: https://issues.apache.org/jira/browse/MNGSITE-535
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> Related to this: MNG-8095 there should more clear wording when the following
> properties can be used and when not:
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNGSITE-535) Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
[
https://issues.apache.org/jira/browse/MNGSITE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836658#comment-17836658
]
Tamas Cservenak commented on MNGSITE-535:
-
In Maven 3.9.2+ (since introduction): only on command line (user properties)
and {{{}.mvn/maven.config{}}}.
In Maven 4 everywhere.
> Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
> -
>
> Key: MNGSITE-535
> URL: https://issues.apache.org/jira/browse/MNGSITE-535
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> Related to this: MNG-8095 there should more clear wording when the following
> properties can be used and when not:
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNGSITE-535) Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
[
https://issues.apache.org/jira/browse/MNGSITE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MNGSITE-535:
Description:
Related to this: MNG-8095 there should more clear wording when the following
properties can be used and when not:
* {{${session.topDirectory}}}
* {{${session.rootDirectory}}}
was:
Related to this: MNG-8095 there should be hint where the following:
* {{${session.topDirectory}}}
* {{${session.rootDirectory}}}
can be used an can not being used.
> Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
> -
>
> Key: MNGSITE-535
> URL: https://issues.apache.org/jira/browse/MNGSITE-535
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> Related to this: MNG-8095 there should more clear wording when the following
> properties can be used and when not:
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
cstamas commented on PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#issuecomment-2052003394 Updated PR with comments, but now the new IT is considerably slower (?) and also locally did not, but on CI fails (I guess the force sources creation is needed as there are actually no sources...) @slawekjaranowski ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MNG-8095.
Assignee: Karl Heinz Marbaise
Resolution: Not A Problem
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNGSITE-535) Improve the Release Notes about 3.9.2 - related to topDirectory/rootDirectory
Karl Heinz Marbaise created MNGSITE-535:
---
Summary: Improve the Release Notes about 3.9.2 - related to
topDirectory/rootDirectory
Key: MNGSITE-535
URL: https://issues.apache.org/jira/browse/MNGSITE-535
Project: Maven Project Web Site
Issue Type: Improvement
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
Related to this: MNG-8095 there should be hint where the following:
* {{${session.topDirectory}}}
* {{${session.rootDirectory}}}
can be used an can not being used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-45) Compiled classes are not copied/restored to target, causing higher phase builds to fail
[
https://issues.apache.org/jira/browse/MBUILDCACHE-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836656#comment-17836656
]
Réda Housni Alaoui commented on MBUILDCACHE-45:
---
I have the same issue with the sonar-maven-plugin. The latter expects .class
files in target folders.
> Compiled classes are not copied/restored to target, causing higher phase
> builds to fail
> ---
>
> Key: MBUILDCACHE-45
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-45
> Project: Maven Build Cache Extension
> Issue Type: Bug
> Environment: windows
>Reporter: Miguel Ortega
>Priority: Major
> Attachments: maven-cache.zip
>
>
> +*Step to reproduce*+
> 1. Execute a first command on a pristine projet( NO CACHE has ever been
> stored)
> {code:java}
> mvn test{code}
> Results are cached (contrary to documentation that states that "cache will
> kick-in automatically on every lifecycle build of phase {{package}} or
> higher.") This could also be a feature since tests can be skipped if nothing
> changes.
> 2 . But if I run next:
> {code:java}
> mvn clean verify
> #OR
> mvn clean install{code}
> Then the build fails
> {code:java}
> [ERROR] Failed to execute goal
> org.springframework.boot:spring-boot-maven-plugin:3.0.2:repackage (repackage)
> on project demo: Execution repackage of goal
> org.springframework.boot:spring-boot-maven-plugin:3.0.2:repackage failed:
> Unable to find main class -> [Help 1]
> [ERROR]
> {code}
> The root cause seems to be that after "clean", the maven target directory is
> cleaned and even if the cache is detected, classes are not restored to the
> target folder anymore
> {code:java}
> [INFO] Attempting to restore project com.example:demo from build cache
> [INFO] Remote cache is incomplete or missing, trying local build for
> com.example:demo
> [INFO] Local build found by checksum 596f60b3f5056d7d
> [INFO] Found cached build, restoring com.example:demo from cache by checksum
> 596f60b3f5056d7d
> [INFO] Project com.example:demo restored partially. Highest cached goal:
> test, requested: install
> [INFO] Skipping plugin execution (cached): resources:resources
> [INFO] Skipping plugin execution (cached): compiler:compile
> [INFO] Skipping plugin execution (cached): resources:testResources
> [INFO] Skipping plugin execution (cached): compiler:testCompile
> [INFO] Skipping plugin execution (cached): surefire:test {code}
> *+Workaround+*
> Manually remove cache data or disable cache via command line argument
> *+Environment+*
> {code:java}
> Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
> Maven home:
> Java version: 17.0.1, vendor: Eclipse Adoptium, runtime:
> Default locale: fr_FR, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836649#comment-17836649
]
Tamas Cservenak commented on MNG-8095:
--
Agreed, most probably release notes needs some better (or clearer) wording,
that we mean 'maven configuration' and not ANY 'configuration' like plugin
configuration is...
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836648#comment-17836648
]
Karl Heinz Marbaise commented on MNG-8095:
--
Ok I have feared such a thing. That means we have to make the release notes
more clear on that part... If I read "properties" and "configuration" which
could be mistaken with the configuration of the plugins... Ok...
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [I] TerminalOutput.pathToMaven throws StringIndexOutOfBoundsException [maven-mvnd]
cstamas commented on issue #929:
URL: https://github.com/apache/maven-mvnd/issues/929#issuecomment-2051952768
Stunts like these ("reverse engineering URL into artifact" IIUC) should be
avoided. Please do not do this :smile: Would logging just bare file name not be
enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836645#comment-17836645
]
Tamas Cservenak edited comment on MNG-8095 at 4/12/24 3:07 PM:
---
Rel notes says specifically "implemented interpolation for configuration and
command line".
So, in 3.9.x this is NOT a property, hence cannot be refd from POM/plugin
config etc, they are interpolated ONLY from command line and
{{{}.mvn/maven.config{}}}.
In 4.0 this IS fully fledged property, and can be referenced from POM as well.
So Maven 3.9.x and 4.x are _fully aligned_ only for (or "up to") configuration
and command line, while 4.0 supports these in POM as well.
was (Author: cstamas):
Rel notes says specifically "implemented interpolation for configuration and
command line".
So, in 3.9.x this is NOT a property, hence cannot be refd from POM/plugin
config etc, they are interpolated ONLY from command line and
{{{}.mvn/maven.config{}}}.
In 4.0 this IS fully fledged property, and can be referenced from POM as well.
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836645#comment-17836645
]
Tamas Cservenak edited comment on MNG-8095 at 4/12/24 3:06 PM:
---
Rel notes says specifically "implemented interpolation for configuration and
command line".
So, in 3.9.x this is NOT a property, hence cannot be refd from POM/plugin
config etc, they are interpolated ONLY from command line and
{{{}.mvn/maven.config{}}}.
In 4.0 this IS fully fledged property, and can be referenced from POM as well.
was (Author: cstamas):
Rel notes says specifically "implemented interpolation for configuration and
command line".
So, in 3.9.x this is NOT a property (so cannot be refd from POM etc), ONLY from
command line and .mvn/maven.config.
In 4.0 this IS fully fledged property, and can be referenced from POM as well.
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836645#comment-17836645
]
Tamas Cservenak commented on MNG-8095:
--
Rel notes says specifically "implemented interpolation for configuration and
command line".
So, in 3.9.x this is NOT a property (so cannot be refd from POM etc), ONLY from
command line and .mvn/maven.config.
In 4.0 this IS fully fledged property, and can be referenced from POM as well.
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836633#comment-17836633
]
Karl Heinz Marbaise commented on MNG-8095:
--
Yes the implementation between Maven 4 and Maven 3.X is different...
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836629#comment-17836629
]
Michael Osipov commented on MNG-8095:
-
I see now. I am certain that it is implemented differently than in Maven 4 and
this is the result now.
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836628#comment-17836628
]
Karl Heinz Marbaise commented on MNG-8095:
--
Apart from that the branch on 3.9.X contains refererences like this:
{code:java}
@Test
public void testPropertiesInterpolation() throws Exception {
// Arrange
CliRequest request = new CliRequest(
new String[] {
"-Dfoo=bar",
"-DvalFound=s${foo}i",
"-DvalNotFound=s${foz}i",
"-DvalRootDirectory=${session.rootDirectory}/.mvn/foo",
"-DvalTopDirectory=${session.topDirectory}/pom.xml",
"-f",
"${session.rootDirectory}/my-child",
"prefix:3.0.0:${foo}",
"validate"
},
null);
request.rootDirectory = Paths.get("myRootDirectory");
request.topDirectory = Paths.get("myTopDirectory");
{code}
and also the code in {{MavenCli.java}} contains
((https://github.com/apache/maven/blob/maven-3.9.x/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L1563):
{code:java}
protected static StringSearchInterpolator createInterpolator(CliRequest
cliRequest, Properties... properties) {
StringSearchInterpolator interpolator = new StringSearchInterpolator();
interpolator.addValueSource(new AbstractValueSource(false) {
@Override
public Object getValue(String expression) {
if ("session.topDirectory".equals(expression)) {
Path topDirectory = cliRequest.topDirectory;
if (topDirectory != null) {
return topDirectory.toString();
} else {
throw new IllegalUseOfUndefinedProperty(expression);
}
} else if ("session.rootDirectory".equals(expression)) {
Path rootDirectory = cliRequest.rootDirectory;
if (rootDirectory != null) {
return rootDirectory.toString();
} else {
throw new IllegalUseOfUndefinedProperty(expression);
}
}
return null;
}
});
...
{code}
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub
[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836624#comment-17836624
]
Karl Heinz Marbaise commented on MNG-8095:
--
The release notes of Maven 3.9.2 on
https://maven.apache.org/docs/3.9.2/release-notes.html saying something
different..
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836624#comment-17836624
]
Karl Heinz Marbaise edited comment on MNG-8095 at 4/12/24 2:16 PM:
---
The release notes of Maven 3.9.2 on
https://maven.apache.org/docs/3.9.2/release-notes.html#notable-new-features
saying something different..
was (Author: khmarbaise):
The release notes of Maven 3.9.2 on
https://maven.apache.org/docs/3.9.2/release-notes.html saying something
different..
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MNG-8095:
-
Affects Version/s: (was: 3.9.0)
(was: 3.9.1)
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [I] TerminalOutput.pathToMaven throws StringIndexOutOfBoundsException [maven-mvnd]
ppalaga commented on issue #929: URL: https://github.com/apache/maven-mvnd/issues/929#issuecomment-2051843233 [daemon-167cc94d.log](https://github.com/apache/maven-mvnd/files/14959771/daemon-167cc94d.log) Attaching the whole log after applying the linked patch in case somebody would like to investigate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836622#comment-17836622
]
Michael Osipov commented on MNG-8095:
-
??? I am genuinly confused. Those exist with Maven 4 only. How are they
supposed to work with 3?
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.0, 3.9.1, 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{${session.topDirectory}}}
> * {{${session.rootDirectory}}}
> * {{${project.rootDirectory}}}
> but unfortately they are not being replaced during the run of the project...
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
>
>
> initialize
>
> echo
>
>
>
>
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory:
> '${project.build.directory}'
>
>
>
>
>
>
> {code}
> My expectation is that during the build the values should be replaced with
> the appropriate values which works with Maven 4 (Tested with Maven
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
[
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MNG-8095:
-
Description:
I have setup a project which uses the following parts
(https://maven.apache.org/docs/3.9.2/release-notes.html)
* {{${session.topDirectory}}}
* {{${session.rootDirectory}}}
* {{${project.rootDirectory}}}
but unfortately they are not being replaced during the run of the project... A
small excerpt from the project... using the following simple configuration:
{code:xml}
com.soebes.maven.plugins
echo-maven-plugin
0.5.0
initialize
echo
project.rootDirectory: '${project.rootDirectory}'
session.rootDirectory: '${session.rootDirectory}'
session.topDirectory: '${session.topDirectory}'
project.basedir: '${project.basedir}'
project.build.directory:
'${project.build.directory}'
{code}
My expectation is that during the build the values should be replaced with the
appropriate values which works with Maven 4 (Tested with Maven 4-alpha-13) like
this:
{code}
[INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
[INFO] =
[INFO] project.rootDirectory: '/projects/props'
[INFO] session.rootDirectory: '/projects/props'
[INFO] session.topDirectory: '/projects/props'
[INFO] project.basedir: '/projects/props/sub-mod-2'
[INFO] project.build.directory: '/projects/props/sub-mod-2/target'
[INFO] =
{code}
But the run with Maven 3.9.X it looks like this:
{code}
[INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
[INFO] =
[INFO] project.rootDirectory: '${project.rootDirectory}'
[INFO] session.rootDirectory: '${session.rootDirectory}'
[INFO] session.topDirectory: '${session.topDirectory}'
[INFO] project.basedir: '/projects/props/sub-mod-2'
[INFO] project.build.directory: '/projects/props/sub-mod-2/target'
[INFO] =
{code}
I have setup a full working example here:
https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095
was:
I have setup a project which uses the following parts
(https://maven.apache.org/docs/3.9.2/release-notes.html)
* {{${session.topDirectory}}}
* {{${session.rootDirectory}}}
* {{${project.rootDirectory}}}
but unfortately they are not being replaced during the run of the project... A
small excerpt from the project... using the following simple configuration:
{code:xml}
com.soebes.maven.plugins
echo-maven-plugin
0.5.0
initialize
echo
project.rootDirectory: '${project.rootDirectory}'
session.rootDirectory: '${session.rootDirectory}'
session.topDirectory: '${session.topDirectory}'
project.basedir: '${project.basedir}'
project.build.directory:
'${project.build.directory}'
{code}
My expectation is that during the build the values should be replaced with the
appropriate values which works with Maven 4 (Tested with Maven 4-alpha-13) like
this:
{code}
[INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
[INFO] =
[INFO] project.rootDirectory: '/projects/props'
[INFO] session.rootDirectory: '/projects/props'
[INFO] session.topDirectory: '/projects/props'
[INFO] project.basedir: '/projects/props/sub-mod-2'
[INFO] project.build.directory: '/projects/props/sub-mod-2/target'
[INFO] =
{code}
But the run with Maven 3.9.X it looks like this:
{code}
[INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
[INFO] =
[INFO] project.rootDirectory: '${project.rootDirectory}'
[INFO] session.rootDirectory: '${session.rootDirectory}'
[INFO] session.topDirectory: '${session.topDirectory}'
[INFO] project.basedir: '/projects/props/sub-mod-2'
[INFO] project.build.directory: '/projects/props/sub-mod-2/target'
[INFO] =
{code}
> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.0, 3.9.1, 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl He
[jira] [Created] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work
Karl Heinz Marbaise created MNG-8095:
Summary: Usage of session.rootDirectory / session.topDirectory
does not work
Key: MNG-8095
URL: https://issues.apache.org/jira/browse/MNG-8095
Project: Maven
Issue Type: Bug
Components: Core
Affects Versions: 3.9.6, 3.9.5, 3.9.4, 3.9.3, 3.9.2, 3.9.1, 3.9.0
Reporter: Karl Heinz Marbaise
I have setup a project which uses the following parts
(https://maven.apache.org/docs/3.9.2/release-notes.html)
* {{${session.topDirectory}}}
* {{${session.rootDirectory}}}
* {{${project.rootDirectory}}}
but unfortately they are not being replaced during the run of the project... A
small excerpt from the project... using the following simple configuration:
{code:xml}
com.soebes.maven.plugins
echo-maven-plugin
0.5.0
initialize
echo
project.rootDirectory: '${project.rootDirectory}'
session.rootDirectory: '${session.rootDirectory}'
session.topDirectory: '${session.topDirectory}'
project.basedir: '${project.basedir}'
project.build.directory:
'${project.build.directory}'
{code}
My expectation is that during the build the values should be replaced with the
appropriate values which works with Maven 4 (Tested with Maven 4-alpha-13) like
this:
{code}
[INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
[INFO] =
[INFO] project.rootDirectory: '/projects/props'
[INFO] session.rootDirectory: '/projects/props'
[INFO] session.topDirectory: '/projects/props'
[INFO] project.basedir: '/projects/props/sub-mod-2'
[INFO] project.build.directory: '/projects/props/sub-mod-2/target'
[INFO] =
{code}
But the run with Maven 3.9.X it looks like this:
{code}
[INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
[INFO] =
[INFO] project.rootDirectory: '${project.rootDirectory}'
[INFO] session.rootDirectory: '${session.rootDirectory}'
[INFO] session.topDirectory: '${session.topDirectory}'
[INFO] project.basedir: '/projects/props/sub-mod-2'
[INFO] project.build.directory: '/projects/props/sub-mod-2/target'
[INFO] =
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [I] TerminalOutput.pathToMaven throws StringIndexOutOfBoundsException [maven-mvnd]
ppalaga commented on issue #929:
URL: https://github.com/apache/maven-mvnd/issues/929#issuecomment-2051825980
When I make `TerminalOutput.pathToMaven()` more robust, I see many such
extension-less URLs
```
$ grep "\-3.8.2'" daemon-167cc94d.log
15:43:45.779 I Dispatch message:
TransferInitiated{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-junit5-internal/3.8.2/quarkus-junit5-internal-3.8.2',
contentLength=-1, transferredBytes=0, exception='null'}
15:43:45.780 I Dispatch message:
ProjectLogMessage{projectId='quarkus-langchain4j-parent', message='[INFO]
Downloading from central:
https://repo.maven.apache.org/maven2/io/quarkus/quarkus-junit5-internal/3.8.2/quarkus-junit5-internal-3.8.2'}
15:43:45.878 I Dispatch message:
TransferFailed{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-junit5-internal/3.8.2/quarkus-junit5-internal-3.8.2',
contentLength=-1, transferredBytes=0,
exception='org.eclipse.aether.transfer.ArtifactNotFoundException: Could not
find artifact io.quarkus:quarkus-junit5-internal::3.8.2 in central
(https://repo.maven.apache.org/maven2)'}
15:43:51.300 I Dispatch message:
TransferInitiated{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-vertx-http-dev-ui-tests/3.8.2/quarkus-vertx-http-dev-ui-tests-3.8.2',
contentLength=-1, transferredBytes=0, exception='null'}
15:43:51.300 I Dispatch message:
ProjectLogMessage{projectId='quarkus-langchain4j-parent', message='[INFO]
Downloading from central:
https://repo.maven.apache.org/maven2/io/quarkus/quarkus-vertx-http-dev-ui-tests/3.8.2/quarkus-vertx-http-dev-ui-tests-3.8.2'}
15:43:51.392 I Dispatch message:
TransferFailed{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-vertx-http-dev-ui-tests/3.8.2/quarkus-vertx-http-dev-ui-tests-3.8.2',
contentLength=-1, transferredBytes=0,
exception='org.eclipse.aether.transfer.ArtifactNotFoundException: Could not
find artifact io.quarkus:quarkus-vertx-http-dev-ui-tests::3.8.2 in central
(https://repo.maven.apache.org/maven2)'}
15:43:53.943 I Dispatch message:
TransferInitiated{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-smallrye-fault-tolerance/3.8.2/quarkus-smallrye-fault-tolerance-3.8.2',
contentLength=-1, transferredBytes=0, exception='null'}
15:43:53.943 I Dispatch message:
ProjectLogMessage{projectId='quarkus-langchain4j-parent', message='[INFO]
Downloading from central:
https://repo.maven.apache.org/maven2/io/quarkus/quarkus-smallrye-fault-tolerance/3.8.2/quarkus-smallrye-fault-tolerance-3.8.2'}
15:43:54.035 I Dispatch message:
TransferFailed{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-smallrye-fault-tolerance/3.8.2/quarkus-smallrye-fault-tolerance-3.8.2',
contentLength=-1, transferredBytes=0,
exception='org.eclipse.aether.transfer.ArtifactNotFoundException: Could not
find artifact io.quarkus:quarkus-smallrye-fault-tolerance::3.8.2 in central
(https://repo.maven.apache.org/maven2)'}
15:43:54.425 I Dispatch message:
TransferInitiated{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-junit5/3.8.2/quarkus-junit5-3.8.2',
contentLength=-1, transferredBytes=0, exception='null'}
15:43:54.425 I Dispatch message:
ProjectLogMessage{projectId='quarkus-langchain4j-parent', message='[INFO]
Downloading from central:
https://repo.maven.apache.org/maven2/io/quarkus/quarkus-junit5/3.8.2/quarkus-junit5-3.8.2'}
15:43:54.518 I Dispatch message:
TransferFailed{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-junit5/3.8.2/quarkus-junit5-3.8.2',
contentLength=-1, transferredBytes=0,
exception='org.eclipse.aether.transfer.ArtifactNotFoundException: Could not
find artifact io.quarkus:quarkus-junit5::3.8.2 in central
(https://repo.maven.apache.org/maven2)'}
15:44:06.374 I Dispatch message:
TransferInitiated{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-devtools-testing/3.8.2/quarkus-devtools-testing-3.8.2',
contentLength=-1, transferredBytes=0, exception='null'}
15:44:06.374 I Disp
[jira] [Commented] (MNG-8025) API incompatibility with m-remote-resources-p
[
https://issues.apache.org/jira/browse/MNG-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836614#comment-17836614
]
Guillaume Nodet commented on MNG-8025:
--
I think it is. The current code still uses {{unsetInheritanceApplied}} and
it's not present in the current {{master}}.
> API incompatibility with m-remote-resources-p
> -
>
> Key: MNG-8025
> URL: https://issues.apache.org/jira/browse/MNG-8025
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process
> (default) on project sshd: Execution default of goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process failed:
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process:
> java.lang.NoSuchMethodError: 'void
> org.apache.maven.model.Plugin.unsetInheritanceApplied()'
> [ERROR] -
> [ERROR] realm =
> plugin>org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8025) API incompatibility with m-remote-resources-p
[
https://issues.apache.org/jira/browse/MNG-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836611#comment-17836611
]
Karl Heinz Marbaise commented on MNG-8025:
--
Is this still relevant? Or can it simply being "solved" by using a more recent
version of maven-resources-plugin (3.3.1)?
> API incompatibility with m-remote-resources-p
> -
>
> Key: MNG-8025
> URL: https://issues.apache.org/jira/browse/MNG-8025
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process
> (default) on project sshd: Execution default of goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process failed:
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process:
> java.lang.NoSuchMethodError: 'void
> org.apache.maven.model.Plugin.unsetInheritanceApplied()'
> [ERROR] -
> [ERROR] realm =
> plugin>org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MPOM-481) Improve description of maven-gpg-plugin settings
[ https://issues.apache.org/jira/browse/MPOM-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-481. Resolution: Fixed > Improve description of maven-gpg-plugin settings > > > Key: MPOM-481 > URL: https://issues.apache.org/jira/browse/MPOM-481 > Project: Maven POMs > Issue Type: Improvement > Components: asf >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-32 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[I] TerminalOutput.pathToMaven throws StringIndexOutOfBoundsException [maven-mvnd]
ppalaga opened a new issue, #929:
URL: https://github.com/apache/maven-mvnd/issues/929
Steps to reproduce:
```
git clone g...@github.com:quarkiverse/quarkus-langchain4j.git
cd quarkus-langchain4j
git reset --hard 177efc97b49823ad747a87766ea1e1d0c2b71ef6
mvnd --stop
mvnd -v
Apache Maven Daemon (mvnd) 1.0-m8 linux-amd64 native client
(0f4bdb6df5e74453d8d558d292789da4e66a7933)Terminal:
org.jline.terminal.impl.PosixSysTerminal with pty
org.jline.terminal.impl.jansi.linux.LinuxNativePty
Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: /home/ppalaga/.sdkman/candidates/mvnd/1.0-m8-m39/mvn
Java version: 17.0.9, vendor: Eclipse Adoptium, runtime:
/home/ppalaga/.sdkman/candidates/java/17.0.9-tem
Default locale: en_IE, platform encoding: UTF-8
OS name: "linux", version: "6.4.11-200.fc38.x86_64", arch: "amd64", family:
"unix"
rm -Rf /tmp/empty-local-maven-repo
mvnd clean install -DskipTests -Dquarkus.build.skip
-Dmaven.repo.local=/tmp/empty-local-maven-repo
...
Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String
index out of range: 17
at
java.base@17.0.6/java.lang.StringLatin1.charAt(StringLatin1.java:48)
at java.base@17.0.6/java.lang.String.charAt(String.java:1513)
at
org.mvndaemon.mvnd.common.logging.TerminalOutput.pathToMaven(TerminalOutput.java:724)
at
org.mvndaemon.mvnd.common.logging.TerminalOutput.formatTransfers(TerminalOutput.java:697)
at
org.mvndaemon.mvnd.common.logging.TerminalOutput.addProjectLine(TerminalOutput.java:810)
at
org.mvndaemon.mvnd.common.logging.TerminalOutput.update(TerminalOutput.java:615)
at
org.mvndaemon.mvnd.common.logging.TerminalOutput.accept(TerminalOutput.java:217)
at
org.mvndaemon.mvnd.client.DefaultClient.execute(DefaultClient.java:366)
at
org.mvndaemon.mvnd.client.DefaultClient.main(DefaultClient.java:161)
```
The daemon log contains the following lines that cause the issue in the
client:
```
15:23:09.559 I Dispatch message:
TransferInitiated{projectId=quarkus-langchain4j-parent, requestType=0,
repositoryId='central', repositoryUrl='https://repo.maven.apache.org/maven2/',
resourceName='io/quarkus/quarkus-jackson/3.8.2/quarkus-jackson-3.8.2',
contentLength=-1, transferredBytes=0, exception='null'}
15:23:09.559 I Dispatch message:
ProjectLogMessage{projectId='quarkus-langchain4j-parent',
message='[[1;34mINFO[m] Downloading from central:
https://repo.maven.apache.org/maven2/io/quarkus/quarkus-jackson/3.8.2/quarkus-jackson-3.8.2'}
```
Normally the artifact URL has an extension, such as `.pom` or `.jar`. There
is no such in
`https://repo.maven.apache.org/maven2/io/quarkus/quarkus-jackson/3.8.2/quarkus-jackson-3.8.2`
above.
I have no idea where it is coming from.
In any case, we should make the `TerminalOutput.pathToMaven()` method more
robust so that it does not fail on this kind of input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPOM-481] Improve description of maven-gpg-plugin settings [maven-apache-parent]
slawekjaranowski merged PR #209: URL: https://github.com/apache/maven-apache-parent/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836575#comment-17836575 ] ASF GitHub Bot commented on MNG-8084: - gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051624139 >  > > It's not readable unfortunately, but it started from generated graph, so it's correct with current master. Note that the ultimate goal would be, imho, to have a maven-compat3 with all the things from maven 3, and have `maven-core` not depend on the v3 artifacts / api anymore. > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051624139 >  > > It's not readable unfortunately, but it started from generated graph, so it's correct with current master. Note that the ultimate goal would be, imho, to have a maven-compat3 with all the things from maven 3, and have `maven-core` not depend on the v3 artifacts / api anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836571#comment-17836571 ] ASF GitHub Bot commented on MNG-8084: - gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051604730  It's really readable unfortunately, but it started from generated graph, so it's correct with current master. > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051604730  It's really readable unfortunately, but it started from generated graph, so it's correct with current master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836567#comment-17836567 ] ASF GitHub Bot commented on MNG-8084: - gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051576594 > Fwiw, this will be outdated with #1465 and later #1457 Also maven-compat is not used anymore (but only included in the distribution for compatibility). > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051576594 > Fwiw, this will be outdated with #1465 and later #1457 Also maven-compat is not used anymore (but only included in the distribution for compatibility). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8084: - Fix Version/s: 4.0.0-alpha-14 > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836554#comment-17836554 ] ASF GitHub Bot commented on MNG-8084: - gnodet merged PR #1457: URL: https://github.com/apache/maven/pull/1457 > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8084. Resolution: Fixed > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8084: Assignee: Guillaume Nodet > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]
gnodet merged PR #1457: URL: https://github.com/apache/maven/pull/1457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-480) Remove maven-site-plugin:attach-descriptor from ASF parent
[
https://issues.apache.org/jira/browse/MPOM-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MPOM-480.
Resolution: Fixed
> Remove maven-site-plugin:attach-descriptor from ASF parent
> --
>
> Key: MPOM-480
> URL: https://issues.apache.org/jira/browse/MPOM-480
> Project: Maven POMs
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-32
>
>
> We have defined {{maven-site-plugin:attach-descriptor}} in {{build/plugins}}
> It cause to *every* ASF projects have execute this goals - but it is only
> needed for parents pom and only in case when parent want to publish site
> descriptor.
> In child projects such task is not needed.
> Each ASF project should manage it and add this only in place where is needed,
> with *inherited* set to {*}false{*}, as example:
> {code:xml}
>
> org.apache.maven.plugins
> maven-site-plugin
> false
>
>
> attach-descriptor
>
> attach-descriptor
>
>
>
>
> {code}
> After removing from ASF parent we can simplify next step of releasing ASF
> parent - special manually maintained documentation layout.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPOM-481) Improve description of maven-gpg-plugin settings
Slawomir Jaranowski created MPOM-481: Summary: Improve description of maven-gpg-plugin settings Key: MPOM-481 URL: https://issues.apache.org/jira/browse/MPOM-481 Project: Maven POMs Issue Type: Improvement Components: asf Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: ASF-32 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-480] Remove maven-site-plugin:attach-descriptor [maven-apache-parent]
slawekjaranowski merged PR #207: URL: https://github.com/apache/maven-apache-parent/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRESOLVER-535) DependencyGraphDumper should be configurable
[ https://issues.apache.org/jira/browse/MRESOLVER-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-535: -- Summary: DependencyGraphDumper should be configurable (was: DependenctGraphDumper should be configurable) > DependencyGraphDumper should be configurable > > > Key: MRESOLVER-535 > URL: https://issues.apache.org/jira/browse/MRESOLVER-535 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > In a sense, we just accumulate what all it prints out (see class history), > but this should be in fact somehow configurable. > Maybe refactor all the output into "decorator" (appender)? And the let ctor > just accept a collection of them (with some predefined collections for some > defaults)? As then, user/caller is fully in charge what the dumper is writing > out, plus, is extensible with original "decorator" idea. > Original decorator idea was that I had a lookup table of some "extra info", > and decorator was basically appending info from that lookup table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7344) Effective pom should contain more finegrained details regarding its content origin: track dependencyManagement import
[
https://issues.apache.org/jira/browse/MNG-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836470#comment-17836470
]
ASF GitHub Bot commented on MNG-7344:
-
juulhobert commented on code in PR #603:
URL: https://github.com/apache/maven/pull/603#discussion_r1562205753
##
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java:
##
@@ -1683,13 +1684,20 @@ private void importDependencyManagement(
it.remove();
+// Model v3
DependencyManagement importMgmt = loadDependencyManagement(model,
request, problems, dependency, importIds);
+if (importMgmt == null) {
+continue;
+}
-if (importMgmt != null) {
-if (importMgmts == null) {
-importMgmts = new ArrayList<>();
-}
-
+if (request.isLocationTracking()) {
+// Keep track of why this DependencyManagement was imported.
+// And map model v3 to model v4 ->
importMgmt(v3).getDelegate() returns a v4 object
+importMgmts.add(
+
org.apache.maven.api.model.DependencyManagement.newBuilder(importMgmt.getDelegate(),
true)
+
.importedFrom(dependency.getDelegate().getLocation(""))
Review Comment:
@hboutemy you're right. It should only map it from model v3 to model v4.
We're going to remove the line
`.importedFrom(dependency.getDelegate().getLocation(""))`
> Effective pom should contain more finegrained details regarding its content
> origin: track dependencyManagement import
> -
>
> Key: MNG-7344
> URL: https://issues.apache.org/jira/browse/MNG-7344
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation, POM
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: MicrosoftTeams-image.png
>
>
> To support MPH-183 some changes needs to be done in Maven Core.
> For every element that is not part of the raw model, it must be possible to
> get the "resolution path" to that element.
> Until now, only the usual pure inheritance is tracked though InputLocation,
> as done in MNG-1803, later displayed by verbose help effective-pom with
> MPH-160
> The following are known to add elements to the effective pom:
> - BOMs dependencyManagement import
> - [Tiles Maven Plugin|https://github.com/repaint-io/maven-tiles] by [~talios]
> Without this feature, it is very hard to detect where these extra elements
> are coming from.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7344] track dependencyManagement import location in effective Model for MPH-183 [maven]
juulhobert commented on code in PR #603:
URL: https://github.com/apache/maven/pull/603#discussion_r1562205753
##
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java:
##
@@ -1683,13 +1684,20 @@ private void importDependencyManagement(
it.remove();
+// Model v3
DependencyManagement importMgmt = loadDependencyManagement(model,
request, problems, dependency, importIds);
+if (importMgmt == null) {
+continue;
+}
-if (importMgmt != null) {
-if (importMgmts == null) {
-importMgmts = new ArrayList<>();
-}
-
+if (request.isLocationTracking()) {
+// Keep track of why this DependencyManagement was imported.
+// And map model v3 to model v4 ->
importMgmt(v3).getDelegate() returns a v4 object
+importMgmts.add(
+
org.apache.maven.api.model.DependencyManagement.newBuilder(importMgmt.getDelegate(),
true)
+
.importedFrom(dependency.getDelegate().getLocation(""))
Review Comment:
@hboutemy you're right. It should only map it from model v3 to model v4.
We're going to remove the line
`.importedFrom(dependency.getDelegate().getLocation(""))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562205236
##
src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java:
##
@@ -131,13 +131,14 @@ public abstract class AbstractGpgMojo extends
AbstractMojo {
* Server id to lookup the passphrase under Maven settings. Do not use
this parameter, it leaks
* sensitive data. Passphrase should be provided only via gpg-agent or via
env variable.
* If parameter {@link #bestPractices} set to {@code true}, plugin fails
when this parameter is configured.
+ * Is programatically defaulted to {@link #GPG_PASSPHRASE}.
*
* @since 1.6
* @deprecated Do not use this configuration, it may leak sensitive
information. Rely on gpg-agent or env
* variables instead.
**/
@Deprecated
-@Parameter(property = "gpg.passphraseServerId", defaultValue =
GPG_PASSPHRASE)
+@Parameter(property = "gpg.passphraseServerId")
Review Comment:
I would like to not remove default values can be assumed as present by
many configurations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562205236
##
src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java:
##
@@ -131,13 +131,14 @@ public abstract class AbstractGpgMojo extends
AbstractMojo {
* Server id to lookup the passphrase under Maven settings. Do not use
this parameter, it leaks
* sensitive data. Passphrase should be provided only via gpg-agent or via
env variable.
* If parameter {@link #bestPractices} set to {@code true}, plugin fails
when this parameter is configured.
+ * Is programatically defaulted to {@link #GPG_PASSPHRASE}.
*
* @since 1.6
* @deprecated Do not use this configuration, it may leak sensitive
information. Rely on gpg-agent or env
* variables instead.
**/
@Deprecated
-@Parameter(property = "gpg.passphraseServerId", defaultValue =
GPG_PASSPHRASE)
+@Parameter(property = "gpg.passphraseServerId")
Review Comment:
I would like to not remove default values can be assumed as present by
many configurations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail
[
https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836468#comment-17836468
]
ASF GitHub Bot commented on MGPG-125:
-
slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562201582
##
src/it/sign-release-best-practices/verify.groovy:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+var artifactDir = new File(localRepositoryPath,
"org/apache/maven/its/gpg/sr/test/1.0")
+
+var expectedFiles = [
+"test-1.0.pom",
+"test-1.0.pom.asc",
+"test-1.0.jar",
+"test-1.0.jar.asc",
+"test-1.0-sources.jar",
+"test-1.0-sources.jar.asc"
+]
+
+for (String expectedFile : expectedFiles) {
+var file = new File(artifactDir, expectedFile)
+
+println "Checking for existence of $file"
+
+if (!file.isFile()) {
Review Comment:
`assert file.isFile()`
> Due to default value of gpg.passphraseServerId, bestPractices=true will
> always fail
> ---
>
> Key: MGPG-125
> URL: https://issues.apache.org/jira/browse/MGPG-125
> Project: Maven GPG Plugin
> Issue Type: Bug
>Affects Versions: 3.2.3
>Reporter: Benjamin Marwell
>Assignee: Tamas Cservenak
>Priority: Critical
> Fix For: 3.2.4
>
>
> Running gpg-plugin with best practices from the CLI, it will always fail
> since gpg.passphraseServerId does have a default value set.
> See:
> https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140
> CC [~cstamas]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562201582
##
src/it/sign-release-best-practices/verify.groovy:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+var artifactDir = new File(localRepositoryPath,
"org/apache/maven/its/gpg/sr/test/1.0")
+
+var expectedFiles = [
+"test-1.0.pom",
+"test-1.0.pom.asc",
+"test-1.0.jar",
+"test-1.0.jar.asc",
+"test-1.0-sources.jar",
+"test-1.0-sources.jar.asc"
+]
+
+for (String expectedFile : expectedFiles) {
+var file = new File(artifactDir, expectedFile)
+
+println "Checking for existence of $file"
+
+if (!file.isFile()) {
Review Comment:
`assert file.isFile()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail
[ https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836465#comment-17836465 ] ASF GitHub Bot commented on MGPG-125: - slawekjaranowski commented on code in PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562198479 ## src/it/sign-release-best-practices-fail/pom.xml: ## @@ -0,0 +1,103 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.its.gpg.sr + test + 1.0 + jar + + +Tests the installation of a simple release JAR with an attached artifact and its signatures. + + + +true + + + + + +org.apache.maven.plugins +maven-compiler-plugin +2.0.2 Review Comment: ? we can use `@version.maven-compiler-plugin@` properties for plugins versions are defined in parent > Due to default value of gpg.passphraseServerId, bestPractices=true will > always fail > --- > > Key: MGPG-125 > URL: https://issues.apache.org/jira/browse/MGPG-125 > Project: Maven GPG Plugin > Issue Type: Bug >Affects Versions: 3.2.3 >Reporter: Benjamin Marwell >Assignee: Tamas Cservenak >Priority: Critical > Fix For: 3.2.4 > > > Running gpg-plugin with best practices from the CLI, it will always fail > since gpg.passphraseServerId does have a default value set. > See: > https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140 > CC [~cstamas] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail
[ https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836466#comment-17836466 ] ASF GitHub Bot commented on MGPG-125: - slawekjaranowski commented on code in PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562199284 ## src/it/sign-release-best-practices-fail/pom.xml: ## @@ -0,0 +1,103 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.its.gpg.sr + test + 1.0 + jar + + +Tests the installation of a simple release JAR with an attached artifact and its signatures. + + + +true + + + + + +org.apache.maven.plugins +maven-compiler-plugin +2.0.2 + + +org.apache.maven.plugins +maven-gpg-plugin +@project.version@ + + +sign-artifacts + + sign + + + + + true + Due to default value of gpg.passphraseServerId, bestPractices=true will > always fail > --- > > Key: MGPG-125 > URL: https://issues.apache.org/jira/browse/MGPG-125 > Project: Maven GPG Plugin > Issue Type: Bug >Affects Versions: 3.2.3 >Reporter: Benjamin Marwell >Assignee: Tamas Cservenak >Priority: Critical > Fix For: 3.2.4 > > > Running gpg-plugin with best practices from the CLI, it will always fail > since gpg.passphraseServerId does have a default value set. > See: > https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140 > CC [~cstamas] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
slawekjaranowski commented on code in PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562199284 ## src/it/sign-release-best-practices-fail/pom.xml: ## @@ -0,0 +1,103 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.its.gpg.sr + test + 1.0 + jar + + +Tests the installation of a simple release JAR with an attached artifact and its signatures. + + + +true + + + + + +org.apache.maven.plugins +maven-compiler-plugin +2.0.2 + + +org.apache.maven.plugins +maven-gpg-plugin +@project.version@ + + +sign-artifacts + + sign + + + + + true + + + gpg.passphrase-sign-with-passphase-from-maven-settings + + + +org.apache.maven.plugins +maven-install-plugin +2.2 Review Comment: 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]
slawekjaranowski commented on code in PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562198479 ## src/it/sign-release-best-practices-fail/pom.xml: ## @@ -0,0 +1,103 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.its.gpg.sr + test + 1.0 + jar + + +Tests the installation of a simple release JAR with an attached artifact and its signatures. + + + +true + + + + + +org.apache.maven.plugins +maven-compiler-plugin +2.0.2 Review Comment: ? we can use `@version.maven-compiler-plugin@` properties for plugins versions are defined in parent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-535) DependenctGraphDumper should be configurable
[ https://issues.apache.org/jira/browse/MRESOLVER-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836463#comment-17836463 ] ASF GitHub Bot commented on MRESOLVER-535: -- cstamas commented on PR #464: URL: https://github.com/apache/maven-resolver/pull/464#issuecomment-2051242596 This PR as is is not gonna cut it, it need more. Updated https://issues.apache.org/jira/browse/MRESOLVER-535 with some context. > DependenctGraphDumper should be configurable > > > Key: MRESOLVER-535 > URL: https://issues.apache.org/jira/browse/MRESOLVER-535 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > In a sense, we just accumulate what all it prints out (see class history), > but this should be in fact somehow configurable. > Maybe refactor all the output into "decorator" (appender)? And the let ctor > just accept a collection of them (with some predefined collections for some > defaults)? As then, user/caller is fully in charge what the dumper is writing > out, plus, is extensible with original "decorator" idea. > Original decorator idea was that I had a lookup table of some "extra info", > and decorator was basically appending info from that lookup table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-535) DependenctGraphDumper should be configurable
[ https://issues.apache.org/jira/browse/MRESOLVER-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-535: -- Description: In a sense, we just accumulate what all it prints out (see class history), but this should be in fact somehow configurable. Maybe refactor all the output into "decorator" (appender)? And the let ctor just accept a collection of them (with some predefined collections for some defaults)? As then, user/caller is fully in charge what the dumper is writing out, plus, is extensible with original "decorator" idea. Original decorator idea was that I had a lookup table of some "extra info", and decorator was basically appending info from that lookup table. was:Allow passing in custom decorator to pull decoration from. > DependenctGraphDumper should be configurable > > > Key: MRESOLVER-535 > URL: https://issues.apache.org/jira/browse/MRESOLVER-535 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > In a sense, we just accumulate what all it prints out (see class history), > but this should be in fact somehow configurable. > Maybe refactor all the output into "decorator" (appender)? And the let ctor > just accept a collection of them (with some predefined collections for some > defaults)? As then, user/caller is fully in charge what the dumper is writing > out, plus, is extensible with original "decorator" idea. > Original decorator idea was that I had a lookup table of some "extra info", > and decorator was basically appending info from that lookup table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
