Re: [PR] [MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… [maven-site-plugin]
michael-o commented on PR #183: URL: https://github.com/apache/maven-site-plugin/pull/183#issuecomment-2092418124 If I don't get any objections will merge this until end of week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Create LICENSE [maven-archiver]
sammitachak opened a new pull request, #59: URL: https://github.com/apache/maven-archiver/pull/59 Added a LICENSE file at the root level directory. The license are as per the pom.xml file (https://github.com/apache/maven-archiver/blob/master/pom.xml#L3C1-L17C21). The license is version 2.0 of the Apache License. This is required for Github API for license fetch works for this repository. (Please note that the Copyright year and owner fields have been intentionally left empty since Google LLC doesn't own this repository) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-521) Nested types not properly extracted cause exception while generating Javadoc URLs
[
https://issues.apache.org/jira/browse/MPLUGIN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843137#comment-17843137
]
ASF GitHub Bot commented on MPLUGIN-521:
asfgit closed pull request #281: [MPLUGIN-521] Nested types not properly
extracted cause exception whi…
URL: https://github.com/apache/maven-plugin-tools/pull/281
> Nested types not properly extracted cause exception while generating Javadoc
> URLs
> -
>
> Key: MPLUGIN-521
> URL: https://issues.apache.org/jira/browse/MPLUGIN-521
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.12.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.0
>
>
> Details:
> https://github.com/apache/maven-site-plugin/pull/177#pullrequestreview-2033188399
> If you have a type like {{Map>}} the generator will extract
> {{List}} instead of just {{Foo}}. We should recursively go down to the
> type.
> This is likely an edge case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-521) Nested types not properly extracted cause exception while generating Javadoc URLs
[
https://issues.apache.org/jira/browse/MPLUGIN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843136#comment-17843136
]
ASF GitHub Bot commented on MPLUGIN-521:
asfgit merged PR #281:
URL: https://github.com/apache/maven-plugin-tools/pull/281
> Nested types not properly extracted cause exception while generating Javadoc
> URLs
> -
>
> Key: MPLUGIN-521
> URL: https://issues.apache.org/jira/browse/MPLUGIN-521
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.12.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.0
>
>
> Details:
> https://github.com/apache/maven-site-plugin/pull/177#pullrequestreview-2033188399
> If you have a type like {{Map>}} the generator will extract
> {{List}} instead of just {{Foo}}. We should recursively go down to the
> type.
> This is likely an edge case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-521] Nested types not properly extracted cause exception whi… [maven-plugin-tools]
asfgit closed pull request #281: [MPLUGIN-521] Nested types not properly extracted cause exception whi… URL: https://github.com/apache/maven-plugin-tools/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-521] Nested types not properly extracted cause exception whi… [maven-plugin-tools]
asfgit merged PR #281: URL: https://github.com/apache/maven-plugin-tools/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPLUGIN-521) Nested types not properly extracted cause exception while generating Javadoc URLs
[
https://issues.apache.org/jira/browse/MPLUGIN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MPLUGIN-521.
--
Resolution: Fixed
Fixed with
[789315b6958250c0e2e9291bb407a25fdd5112e3|https://gitbox.apache.org/repos/asf?p=maven-plugin-tools.git;a=commit;h=789315b6958250c0e2e9291bb407a25fdd5112e3].
> Nested types not properly extracted cause exception while generating Javadoc
> URLs
> -
>
> Key: MPLUGIN-521
> URL: https://issues.apache.org/jira/browse/MPLUGIN-521
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.12.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.12.1
>
>
> Details:
> https://github.com/apache/maven-site-plugin/pull/177#pullrequestreview-2033188399
> If you have a type like {{Map>}} the generator will extract
> {{List}} instead of just {{Foo}}. We should recursively go down to the
> type.
> This is likely an edge case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] (doc) Update checkstyle rule link format [maven-checkstyle-plugin]
rshindo opened a new pull request, #134:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/134
Fix rule link
format(https://checkstyle.org/checks/{category}/{ruleName}.html) since older
links (https://checkstyle.org/config_{category}.html#{ruleName}) cause a 404
error.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump com.google.guava:guava from 33.1.0-jre to 33.2.0-jre [maven-indexer]
dependabot[bot] opened a new pull request, #363: URL: https://github.com/apache/maven-indexer/pull/363 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.1.0-jre to 33.2.0-jre. Release notes Sourced from https://github.com/google/guava/releases";>com.google.guava:guava's releases. 33.2.0 Android users: Please test recent Guava versions If you know of Guava Android users who have not yet upgraded to at least release https://github.com/google/guava/releases/tag/v33.0.0";>33.0.0, please encourage them to upgrade, preferably to today's release, 33.2.0. These releases have begun adding Java 8+ APIs to guava-android. While we don't anticipate problems, we do anticipate that any unexpected problems could force a disruptive rollback. To minimize any disruption, we'd like to catch any such problems early. Please https://github.com/google/guava/issues/new?assignees=&labels=type%3Ddefect&projects=&template=bug_report.yaml";>let us know of any problems you encounter. MavenJar files https://repo1.maven.org/maven2/com/google/guava/guava/33.2.0-jre/guava-33.2.0-jre.jar";>33.2.0-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/33.2.0-android/guava-33.2.0-android.jar";>33.2.0-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies";>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar";>failureaccess-1.0.1.jar Javadoc https://guava.dev/releases/33.2.0-jre/api/docs/";>33.2.0-jre https://guava.dev/releases/33.2.0-android/api/docs/";>33.2.0-android JDiff https://guava.dev/releases/33.2.0-jre/api/diffs/";>33.2.0-jre vs. 33.1.0-jre https://guava.dev/releases/33.2.0-android/api/diffs/";>33.2.0-android vs. 33.1.0-android https://guava.dev/releases/33.2.0-android/api/androiddiffs/";>33.2.0-android vs. 33.2.0-jre Changelog Dropped testing for Android versions before Lollipop (API Level 21). Guava may stop working under older versions in the future, or it may have done so already. Fixed https://redirect.github.com/google/guava/issues/7134";>a GWT compilation breakage under Gradle. (858caf425c) collect: Made our Collector APIs (e.g., ImmutableList.toImmutableList()) available in guava-android. More https://redirect.github.com/google/guava/issues/6567";>Java 8 APIs will follow in future releases. (96fca0b747) As always, streams are available to Android code only when that code https://developer.android.com/studio/write/java8-support#library-desugaring";>enables library desugaring or targets a new enough API Level (https://developer.android.com/reference/java/util/stream/Stream";>24 (Nougat) for many stream APIs). (But note that we test only with library desugaring, so we don't currently know if API Level 24 is high enough to use our Collector APIs unless you have also enabled library desugaring.) Guava users who avoid the Collector APIs do not need to meet this requirement. collect: Fixed a potential NullPointerException in ImmutableMap.Builder on a rare code path. (70a98115d8) net: Added HttpHeaders constants Ad-Auction-Allowed, Permissions-Policy-Report-Only, and Sec-GPC. (7dc01ed27b, 41d0d9a833, 38c8017bd44b7919b112f1c99f3d8ce4b058ae5d) Commits See full diff in https://github.com/google/guava/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` com.google.guava guava 33.2.0-jre 33.2.0-android
[jira] [Closed] (MBUILDCACHE-88) Tests in failure when ran on jdk21
[
https://issues.apache.org/jira/browse/MBUILDCACHE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MBUILDCACHE-88.
---
Resolution: Fixed
> Tests in failure when ran on jdk21
> --
>
> Key: MBUILDCACHE-88
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-88
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Kevin Buntrock
>Assignee: Olivier Lamy
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.2.0
>
>
> The project tests cannot be run on jdk21. Result is :
> {code:java}
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR] CacheConfigImplTest.testInitializationDisabledInXML:234 expected:
> but was:
> [ERROR]
> CacheConfigImplTest.testRemoteDisableByUserPropertyOverride:330->assertDefaults:137->assertDefaults:201->lambda$testRemoteDisableByUserPropertyOverride$39:330
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoteEnableByUserPropertyOverrideWithURL:313->assertDefaults:137->assertDefaults:201->lambda$testRemoteEnableByUserPropertyOverrideWithURL$38:315
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoteEnableInXMLWithURL:288->assertDefaults:137->assertDefaults:201->lambda$testRemoteEnableInXMLWithURL$36:290
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoteSaveIgnoredWhenRemoteDisabledByUserPropertyOverride:420->assertDefaults:137->assertDefaults:201->lambda$testRemoteSaveIgnoredWhenRemoteDisabledByUserPropertyOverride$48:420
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveDisabledByUserProperty:381->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveDisabledByUserProperty$47:383
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveEnabledByUserProperty:362->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveEnabledByUserProperty$45:365
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveEnabledInXML:344->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveEnabledInXML$42:347
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveFinalEnabledByUserProperty:436->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveFinalEnabledByUserProperty$51:439
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveFinalIgnoredWhenRemoteSaveDisabled:455->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveFinalIgnoredWhenRemoteSaveDisabled$54:457
> expected: but was:
> [INFO]
> [ERROR] Tests run: 71, Failures: 10, Errors: 0, Skipped: 4
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
> {code}
> In class "CacheConfigImplTest", a method "deepMockConfigFile" mocks the
> result of the call to java.nio.file.Files.exists (via
> "FileSystemProvider.checkAccess").
> In jdk21 version, "Files.exists" does not rely on the same underlying
> "FileSystemProvider" method, therefore breaking the mocking purpose.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.apache.maven.extensions:maven-extensions from 41 to 42 [maven-build-cache-extension]
olamy commented on PR #144: URL: https://github.com/apache/maven-build-cache-extension/pull/144#issuecomment-2092014106 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.resolver:maven-resolver-transport-http from 1.9.19 to 1.9.20 [maven-build-cache-extension]
dependabot[bot] merged PR #149: URL: https://github.com/apache/maven-build-cache-extension/pull/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.resolver:maven-resolver-transport-http from 1.9.19 to 1.9.20 [maven-build-cache-extension]
olamy commented on PR #149: URL: https://github.com/apache/maven-build-cache-extension/pull/149#issuecomment-2092013766 @dependabot merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attriute
[
https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy reassigned MNG-8116:
-
Assignee: Olivier Lamy
> Plugin configuration can randomly fail in case of method overloading as it
> doesn't take into account implementation attriute
>
>
> Key: MNG-8116
> URL: https://issues.apache.org/jira/browse/MNG-8116
> Project: Maven
> Issue Type: Task
> Components: Plugin Requests
>Affects Versions: 3.9.6
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.9.7
>
>
> Originally discovered via a Jetty bug report see
> https://github.com/jetty/jetty.project/issues/11732
> The bean to configured have the following overloading method naming:
> * public void setExtraClasspath(String extraClasspath)
> * public void setExtraClasspath(List extraClasspath)
> The plugin configuration:
>
> ${basedir}/config
>
> even forcing the implementation attribute doesn't help
>
>implementation="java.lang.String">${basedir}/config
>
> The fix is implemented via the PR
> https://github.com/eclipse/sisu.plexus/pull/52
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attriute
[
https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy updated MNG-8116:
--
Description:
Originally discovered via a Jetty bug report see
https://github.com/jetty/jetty.project/issues/11732
The bean to configured have the following overloading method naming:
* public void setExtraClasspath(String extraClasspath)
* public void setExtraClasspath(List extraClasspath)
The plugin configuration:
${basedir}/config
even forcing the implementation attribute doesn't help
${basedir}/config
The fix is implemented via the PR https://github.com/eclipse/sisu.plexus/pull/52
was:
Originally discovered via a Jetty bug report see
https://github.com/jetty/jetty.project/issues/11732
The bean to configured have the following overloading method naming:
* public void setExtraClasspath(String extraClasspath)
* public void setExtraClasspath(List extraClasspath)
The plugin configuration:
> Plugin configuration can randomly fail in case of method overloading as it
> doesn't take into account implementation attriute
>
>
> Key: MNG-8116
> URL: https://issues.apache.org/jira/browse/MNG-8116
> Project: Maven
> Issue Type: Task
> Components: Plugin Requests
>Affects Versions: 3.9.6
>Reporter: Olivier Lamy
>Priority: Major
> Fix For: 3.9.7
>
>
> Originally discovered via a Jetty bug report see
> https://github.com/jetty/jetty.project/issues/11732
> The bean to configured have the following overloading method naming:
> * public void setExtraClasspath(String extraClasspath)
> * public void setExtraClasspath(List extraClasspath)
> The plugin configuration:
>
> ${basedir}/config
>
> even forcing the implementation attribute doesn't help
>
>implementation="java.lang.String">${basedir}/config
>
> The fix is implemented via the PR
> https://github.com/eclipse/sisu.plexus/pull/52
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attriute
[ https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MNG-8116: -- Description: Originally discovered via a Jetty bug report see https://github.com/jetty/jetty.project/issues/11732 The bean to configured have the following overloading method naming: * public void setExtraClasspath(String extraClasspath) * public void setExtraClasspath(List extraClasspath) The plugin configuration: > Plugin configuration can randomly fail in case of method overloading as it > doesn't take into account implementation attriute > > > Key: MNG-8116 > URL: https://issues.apache.org/jira/browse/MNG-8116 > Project: Maven > Issue Type: Task > Components: Plugin Requests >Affects Versions: 3.9.6 >Reporter: Olivier Lamy >Priority: Major > Fix For: 3.9.7 > > > Originally discovered via a Jetty bug report see > https://github.com/jetty/jetty.project/issues/11732 > The bean to configured have the following overloading method naming: > * public void setExtraClasspath(String extraClasspath) > * public void setExtraClasspath(List extraClasspath) > The plugin configuration: -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attriute
Olivier Lamy created MNG-8116: - Summary: Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attriute Key: MNG-8116 URL: https://issues.apache.org/jira/browse/MNG-8116 Project: Maven Issue Type: Task Components: Plugin Requests Affects Versions: 3.9.6 Reporter: Olivier Lamy Fix For: 3.9.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Exclude JDK 8 - temurin, adopt-openj9 on macos, use defaults values [maven-compiler-plugin]
elharo commented on code in PR #238:
URL:
https://github.com/apache/maven-compiler-plugin/pull/238#discussion_r1588538855
##
.github/workflows/maven-verify.yml:
##
@@ -28,7 +28,9 @@ jobs:
with:
# maven-args: "-Dinvoker.parallelThreads=2" cannot do this as this
generate some concurrent download issues
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft",
"adopt-openj9" ]'
- ff-jdk: "20"
- jdk-matrix: '[ "8", "11", "17", "20" ]'
- matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"},{ "jdk":
"20", "distribution": "microsoft"},{ "jdk": "20", "distribution":
"adopt-openj9"},]'
- maven-matrix: '[ "3.6.3", "3.8.8", "3.9.5" ]' # Maven versions matrix
for verify builds
+ matrix-exclude: '[
+ { "jdk": "8", "distribution": "microsoft" },
Review Comment:
Why is this one excluded? It's not a Mac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Exclude JDK 8 - temurin, adopt-openj9 on macos, use defaults values [maven-compiler-plugin]
olamy commented on code in PR #238:
URL:
https://github.com/apache/maven-compiler-plugin/pull/238#discussion_r1588461150
##
.github/workflows/maven-verify.yml:
##
@@ -28,7 +28,9 @@ jobs:
with:
# maven-args: "-Dinvoker.parallelThreads=2" cannot do this as this
generate some concurrent download issues
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft",
"adopt-openj9" ]'
- ff-jdk: "20"
- jdk-matrix: '[ "8", "11", "17", "20" ]'
- matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"},{ "jdk":
"20", "distribution": "microsoft"},{ "jdk": "20", "distribution":
"adopt-openj9"},]'
- maven-matrix: '[ "3.6.3", "3.8.8", "3.9.5" ]' # Maven versions matrix
for verify builds
+ matrix-exclude: '[
Review Comment:
the goal was to have a maximum of jdk to be tested as compiling can be
highly dependant of the used jdk.
so with this we are really reducing the coverage.
could we keep testing on 11 maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
kbuntrock commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2091521362 > Thank you, @kbuntrock! You're welcome :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843078#comment-17843078 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- kbuntrock commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2091521362 > Thank you, @kbuntrock! You're welcome :) > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[ https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MPLUGIN-519. --- Resolution: Fixed > Update to Parent POM 42, prerequisite 3.6.3 > --- > > Key: MPLUGIN-519 > URL: https://issues.apache.org/jira/browse/MPLUGIN-519 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.12.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPLUGIN-520) Get rid of maven-compat classes use
[ https://issues.apache.org/jira/browse/MPLUGIN-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MPLUGIN-520. --- Resolution: Fixed > Get rid of maven-compat classes use > --- > > Key: MPLUGIN-520 > URL: https://issues.apache.org/jira/browse/MPLUGIN-520 > Project: Maven Plugin Tools > Issue Type: Improvement > Components: Plugin Plugin >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.12.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
cstamas merged PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[ https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843076#comment-17843076 ] ASF GitHub Bot commented on MPLUGIN-519: cstamas merged PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280 > Update to Parent POM 42, prerequisite 3.6.3 > --- > > Key: MPLUGIN-519 > URL: https://issues.apache.org/jira/browse/MPLUGIN-519 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.12.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8115) Upgrade dependencies
[ https://issues.apache.org/jira/browse/MNG-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-8115: -- Fix Version/s: 3.9.x-candidate > Upgrade dependencies > > > Key: MNG-8115 > URL: https://issues.apache.org/jira/browse/MNG-8115 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.9.7, 3.9.x-candidate > > > Plexus Utils 4 > Guice 6 > Apache commons -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8115) Upgrade dependencies
[ https://issues.apache.org/jira/browse/MNG-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-8115: - Assignee: Sylwester Lachiewicz > Upgrade dependencies > > > Key: MNG-8115 > URL: https://issues.apache.org/jira/browse/MNG-8115 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.9.7, 3.9.x-candidate > > > Plexus Utils 4 > Guice 6 > Apache commons -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8115) Upgrade dependencies
[ https://issues.apache.org/jira/browse/MNG-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-8115: -- Description: Plexus Utils 4 Guice 6 Apache commons > Upgrade dependencies > > > Key: MNG-8115 > URL: https://issues.apache.org/jira/browse/MNG-8115 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.9.7 > > > Plexus Utils 4 > Guice 6 > Apache commons -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8115) Upgrade dependencies
[ https://issues.apache.org/jira/browse/MNG-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843073#comment-17843073 ] ASF GitHub Bot commented on MNG-8115: - slachiewicz opened a new pull request, #1496: URL: https://github.com/apache/maven/pull/1496 Plexus Utils 4 Guice 6 Commons > Upgrade dependencies > > > Key: MNG-8115 > URL: https://issues.apache.org/jira/browse/MNG-8115 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.9.7 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [maven-plugin-tools]
dependabot[bot] commented on PR #278: URL: https://github.com/apache/maven-plugin-tools/pull/278#issuecomment-2091435722 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [maven-plugin-tools]
slachiewicz closed pull request #278: Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 URL: https://github.com/apache/maven-plugin-tools/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 41 to 42 [maven-plugin-tools]
dependabot[bot] commented on PR #279: URL: https://github.com/apache/maven-plugin-tools/pull/279#issuecomment-2091435068 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 41 to 42 [maven-plugin-tools]
slachiewicz closed pull request #279: Bump org.apache.maven:maven-parent from 41 to 42 URL: https://github.com/apache/maven-plugin-tools/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.htmlunit:htmlunit from 4.0.0 to 4.1.0 [maven-doxia-sitetools]
slachiewicz merged PR #152: URL: https://github.com/apache/maven-doxia-sitetools/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-336) .mvn/extensions.xml from main project is used in it projects run
[ https://issues.apache.org/jira/browse/MINVOKER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843060#comment-17843060 ] ASF GitHub Bot commented on MINVOKER-336: - slawekjaranowski opened a new pull request, #232: URL: https://github.com/apache/maven-invoker-plugin/pull/232 https://issues.apache.org/jira/browse/MINVOKER-336 > .mvn/extensions.xml from main project is used in it projects run > > > Key: MINVOKER-336 > URL: https://issues.apache.org/jira/browse/MINVOKER-336 > Project: Maven Invoker Plugin > Issue Type: Bug >Affects Versions: 3.5.1 >Reporter: Olivier Lamy >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: 3.6.2 > > > if the main project contains some extensions in the top directory > .mvn/extensions.xml this directory will be used in IT projects run. > sounds more a issue with core (e.g MNG) due to the script mvn/mvn.bat > algorithm to find .mvn directory -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Remove info about old versions [maven-compiler-plugin]
slawekjaranowski commented on PR #237: URL: https://github.com/apache/maven-compiler-plugin/pull/237#issuecomment-2091288568 @elharo please look #238 Some of JDK are not supported on new macos 14 with M processors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINVOKER-253) Sub Modules do not respect localRepositoryPath
[ https://issues.apache.org/jira/browse/MINVOKER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-253. Fix Version/s: (was: waiting-for-feedback) Resolution: Cannot Reproduce Now I close it ... when we have a reproduce instruction we can reopen > Sub Modules do not respect localRepositoryPath > -- > > Key: MINVOKER-253 > URL: https://issues.apache.org/jira/browse/MINVOKER-253 > Project: Maven Invoker Plugin > Issue Type: Bug >Affects Versions: 3.2.1 > Environment: Maven 3.6.3, Java 1.8, Mac OSX 10.14.6 >Reporter: Andreas Schaefer >Priority: Major > > I use the invoker to run IT tests of our maven plugin and in these tests I > use sub modules like core and ui.apps. When settings localRepositoryPath to > avoid adding IT tests artifacts to my local Maven repo the pom/artifact of > pom called by the invoker will not be installed but the sub modules still are. > An example can be found at > [https://github.com/apache/sling-feature-converter-maven-plugin] . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8115) Upgrade dependencies
Sylwester Lachiewicz created MNG-8115: - Summary: Upgrade dependencies Key: MNG-8115 URL: https://issues.apache.org/jira/browse/MNG-8115 Project: Maven Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz Fix For: 3.9.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Remove info about old versions [maven-compiler-plugin]
elharo commented on PR #237: URL: https://github.com/apache/maven-compiler-plugin/pull/237#issuecomment-2091110755 Looks like the CI is a little borked. JDK 8 is not available: Installed distributions Trying to resolve the latest version from remote Error: Could not find satisfied version for SemVer '8'. Available versions: 22.0.1+8, 22.0.0+36, 21.0.3+9.0.LTS, 21.0.2+13.0.LTS, 21.0.1+12.0.LTS, 21.0.0+35.0.LTS, 20.0.2+9, 20.0.1+9, 20.0.0+36, 19.0.2+7, 19.0.1+10, 19.0.0+36, 18.0.2+101, 18.0.2+9, 18.0.1+10, 18.0.0+36, 17.0.11+9, 17.0.10+7, 17.0.9+9, 17.0.8+101, 17.0.8+7, 17.0.7+7, 17.0.6+10, 17.0.5+8, 17.0.4+101, 17.0.4+8, 17.0.3+7, 17.0.2+8, 17.0.1+12, 17.0.0+35, 11.0.23+9, 11.0.22+7.1, 11.0.22+7, 11.0.21+9, 11.0.20+101, 11.0.20+8, 11.0.19+7, 11.0.18+10, 11.0.17+8, 11.0.16+101, 11.0.16+8, 11.0.15+10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINVOKER-336) .mvn/extensions.xml from main project is used in it projects run
[ https://issues.apache.org/jira/browse/MINVOKER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MINVOKER-336: Assignee: Slawomir Jaranowski > .mvn/extensions.xml from main project is used in it projects run > > > Key: MINVOKER-336 > URL: https://issues.apache.org/jira/browse/MINVOKER-336 > Project: Maven Invoker Plugin > Issue Type: Bug >Affects Versions: 3.5.1 >Reporter: Olivier Lamy >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: 3.6.2 > > > if the main project contains some extensions in the top directory > .mvn/extensions.xml this directory will be used in IT projects run. > sounds more a issue with core (e.g MNG) due to the script mvn/mvn.bat > algorithm to find .mvn directory -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843019#comment-17843019
]
ASF GitHub Bot commented on MINVOKER-335:
-
slawekjaranowski merged PR #231:
URL: https://github.com/apache/maven-invoker-plugin/pull/231
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.2
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MINVOKER-335.
Resolution: Fixed
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.2
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MINVOKER-335] Preserve symlinks for copied files [maven-invoker-plugin]
slawekjaranowski merged PR #231: URL: https://github.com/apache/maven-invoker-plugin/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Resolver updates [maven]
gnodet merged PR #1495: URL: https://github.com/apache/maven/pull/1495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8114) install plugin failed with NPE for profiles activated by files existing
Jim Sellers created MNG-8114:
Summary: install plugin failed with NPE for profiles activated by
files existing
Key: MNG-8114
URL: https://issues.apache.org/jira/browse/MNG-8114
Project: Maven
Issue Type: Bug
Environment: Apache Maven 4.0.0-alpha-14-SNAPSHOT
(9fc4f499172637c403f27808d5c0ccd0c770f93c)
Maven home:
C:\Users\sellersj\Downloads\apache-maven-4.0.0-alpha-14-20240425.054714-33-bin
Java version: 21.0.3, vendor: Eclipse Adoptium, runtime: C:\devtools\java\jdk21
Default locale: en_CA, platform encoding: UTF-8
OS name: "windows 10", version: "10.0", arch: "amd64", family: "winnt"
Reporter: Jim Sellers
This is a change between apache-maven-4.0.0-alpha-13 and
4.0.0-alpha-14-SNAPSHOT which I understand is not released yet.
This happens both on windows and linux. If an app has a profile that's
activated by a file existing or not, it will generate a NPE
{code:XML|title=pom.xml}
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
4.0.0
com.example
Zminimal
0.0.1-SNAPSHOT
jar
8
8
UTF-8
UTF-8
is-webapp
${basedir}/src/main/webapp/
{code}
{code:title=log snipit}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install)
on project Zminimal: Execution default-install of goal
org.apache.maven.plugins:maven-install-plugin:3.1.1:install failed: Cannot
invoke
"org.apache.maven.internal.impl.model.ProfileActivationFilePathInterpolator.interpolate(String,
org.apache.maven.api.services.model.ProfileActivationContext)" because
"this.profileActivationFilePathInterpolator" is null -> [Help 1]
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Resolver updates [maven]
gnodet commented on code in PR #1495:
URL: https://github.com/apache/maven/pull/1495#discussion_r1587821649
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java:
##
@@ -116,17 +116,6 @@ public Artifact setVersion(String version) {
return new RelocatedArtifact(artifact, groupId, artifactId,
classifier, extension, version, message);
}
-@Deprecated
-@Override
-public Artifact setFile(File file) {
Review Comment:
I've reverted the removal of the two `setFile()` methods to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Resolver updates [maven]
gnodet commented on code in PR #1495:
URL: https://github.com/apache/maven/pull/1495#discussion_r1587821649
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java:
##
@@ -116,17 +116,6 @@ public Artifact setVersion(String version) {
return new RelocatedArtifact(artifact, groupId, artifactId,
classifier, extension, version, message);
}
-@Deprecated
-@Override
-public Artifact setFile(File file) {
Review Comment:
I've revert the removal of the two `setFile()` methods to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix consumer pom builder [maven]
gnodet merged PR #1491: URL: https://github.com/apache/maven/pull/1491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Resolver updates [maven]
gnodet commented on code in PR #1495:
URL: https://github.com/apache/maven/pull/1495#discussion_r1587812340
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java:
##
@@ -116,17 +116,6 @@ public Artifact setVersion(String version) {
return new RelocatedArtifact(artifact, groupId, artifactId,
classifier, extension, version, message);
}
-@Deprecated
-@Override
-public Artifact setFile(File file) {
Review Comment:
Mmh, not sure, as a default implementation is provided by
`AbstractArtifact`... ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Resolver updates [maven]
cstamas commented on code in PR #1495:
URL: https://github.com/apache/maven/pull/1495#discussion_r1587758281
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java:
##
@@ -116,17 +116,6 @@ public Artifact setVersion(String version) {
return new RelocatedArtifact(artifact, groupId, artifactId,
classifier, extension, version, message);
}
-@Deprecated
-@Override
-public Artifact setFile(File file) {
Review Comment:
maven-resolver-provider RelocatedArtifact is present in mvn3 as well, I mean
"binary compat"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Resolver updates [maven]
cstamas commented on code in PR #1495:
URL: https://github.com/apache/maven/pull/1495#discussion_r1587756658
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java:
##
@@ -116,17 +116,6 @@ public Artifact setVersion(String version) {
return new RelocatedArtifact(artifact, groupId, artifactId,
classifier, extension, version, message);
}
-@Deprecated
-@Override
-public Artifact setFile(File file) {
Review Comment:
This will break compat, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties
[
https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842988#comment-17842988
]
Matthew Jason Benson commented on MNG-8081:
---
Should we also update
[https://github.com/apache/maven-site/blob/master/content/apt/guides/introduction/introduction-to-profiles.apt]
(both streams)?
> default profile activation should consider available system and user
> properties
> ---
>
> Key: MNG-8081
> URL: https://issues.apache.org/jira/browse/MNG-8081
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.9.6, 4.0.0
>Reporter: Matthew Jason Benson
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-1
>
>
> As discussed in my open PR, my use case is to compare between environment
> variables e.g.:
> {code:java}
>
>
> env.FOO
> ${env.BAR}
>
> {code}
> Limiting the interpolation to user/system properties means that there is no
> mindf*ck resulting from profile activation order, etc., and keeps this
> request nonthreatening.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties
[
https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842985#comment-17842985
]
ASF GitHub Bot commented on MNG-8081:
-
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2090633311
@gnodet again, thanks!
> default profile activation should consider available system and user
> properties
> ---
>
> Key: MNG-8081
> URL: https://issues.apache.org/jira/browse/MNG-8081
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.9.6, 4.0.0
>Reporter: Matthew Jason Benson
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-1
>
>
> As discussed in my open PR, my use case is to compare between environment
> variables e.g.:
> {code:java}
>
>
> env.FOO
> ${env.BAR}
>
> {code}
> Limiting the interpolation to user/system properties means that there is no
> mindf*ck resulting from profile activation order, etc., and keeps this
> request nonthreatening.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties
[
https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842984#comment-17842984
]
ASF GitHub Bot commented on MNG-8081:
-
mbenson commented on PR #1447:
URL: https://github.com/apache/maven/pull/1447#issuecomment-2090632621
Thanks @gnodet !
> default profile activation should consider available system and user
> properties
> ---
>
> Key: MNG-8081
> URL: https://issues.apache.org/jira/browse/MNG-8081
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.9.6, 4.0.0
>Reporter: Matthew Jason Benson
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-1
>
>
> As discussed in my open PR, my use case is to compare between environment
> variables e.g.:
> {code:java}
>
>
> env.FOO
> ${env.BAR}
>
> {code}
> Limiting the interpolation to user/system properties means that there is no
> mindf*ck resulting from profile activation order, etc., and keeps this
> request nonthreatening.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2090633311 @gnodet again, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8081] Interpolate available properties during default profile selection (Maven 3.9.x) [maven]
mbenson commented on PR #1447: URL: https://github.com/apache/maven/pull/1447#issuecomment-2090632621 Thanks @gnodet ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties
[
https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842965#comment-17842965
]
ASF GitHub Bot commented on MNG-8081:
-
gnodet merged PR #1447:
URL: https://github.com/apache/maven/pull/1447
> default profile activation should consider available system and user
> properties
> ---
>
> Key: MNG-8081
> URL: https://issues.apache.org/jira/browse/MNG-8081
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.9.6, 4.0.0
>Reporter: Matthew Jason Benson
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-1
>
>
> As discussed in my open PR, my use case is to compare between environment
> variables e.g.:
> {code:java}
>
>
> env.FOO
> ${env.BAR}
>
> {code}
> Limiting the interpolation to user/system properties means that there is no
> mindf*ck resulting from profile activation order, etc., and keeps this
> request nonthreatening.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-8081) default profile activation should consider available system and user properties
[
https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8081.
Resolution: Fixed
> default profile activation should consider available system and user
> properties
> ---
>
> Key: MNG-8081
> URL: https://issues.apache.org/jira/browse/MNG-8081
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.9.6, 4.0.0
>Reporter: Matthew Jason Benson
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-1
>
>
> As discussed in my open PR, my use case is to compare between environment
> variables e.g.:
> {code:java}
>
>
> env.FOO
> ${env.BAR}
>
> {code}
> Limiting the interpolation to user/system properties means that there is no
> mindf*ck resulting from profile activation order, etc., and keeps this
> request nonthreatening.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties
[
https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842964#comment-17842964
]
ASF GitHub Bot commented on MNG-8081:
-
gnodet merged PR #1446:
URL: https://github.com/apache/maven/pull/1446
> default profile activation should consider available system and user
> properties
> ---
>
> Key: MNG-8081
> URL: https://issues.apache.org/jira/browse/MNG-8081
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.9.6, 4.0.0
>Reporter: Matthew Jason Benson
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-1
>
>
> As discussed in my open PR, my use case is to compare between environment
> variables e.g.:
> {code:java}
>
>
> env.FOO
> ${env.BAR}
>
> {code}
> Limiting the interpolation to user/system properties means that there is no
> mindf*ck resulting from profile activation order, etc., and keeps this
> request nonthreatening.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8081] Interpolate available properties during default profile selection (Maven 3.9.x) [maven]
gnodet merged PR #1447: URL: https://github.com/apache/maven/pull/1447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]
gnodet merged PR #1446: URL: https://github.com/apache/maven/pull/1446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-521) Nested types not properly extracted cause exception while generating Javadoc URLs
[
https://issues.apache.org/jira/browse/MPLUGIN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842963#comment-17842963
]
ASF GitHub Bot commented on MPLUGIN-521:
michael-o commented on code in PR #281:
URL:
https://github.com/apache/maven-plugin-tools/pull/281#discussion_r1587606761
##
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##
@@ -637,10 +637,10 @@ static URI getJavadocUrlForType(JavadocLinkGenerator
javadocLinkGenerator, Strin
.split(",\\s*");
switch (parameterTypes.length) {
case 1: // if only one parameter type, assume collection,
first parameter type is most interesting
-binaryName = parameterTypes[0];
+binaryName =
extractbinaryNameForJavadoc(parameterTypes[0]);
break;
case 2: // if two parameter types assume map, second parameter
type is most interesting
-binaryName = parameterTypes[1];
+binaryName =
extractbinaryNameForJavadoc(parameterTypes[1]);
Review Comment:
```suggestion
binaryName =
extractBinaryNameForJavadoc(parameterTypes[1]);
```
##
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##
@@ -637,10 +637,10 @@ static URI getJavadocUrlForType(JavadocLinkGenerator
javadocLinkGenerator, Strin
.split(",\\s*");
switch (parameterTypes.length) {
case 1: // if only one parameter type, assume collection,
first parameter type is most interesting
-binaryName = parameterTypes[0];
+binaryName =
extractbinaryNameForJavadoc(parameterTypes[0]);
Review Comment:
```suggestion
binaryName =
extractBinaryNameForJavadoc(parameterTypes[0]);
```
##
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##
@@ -649,7 +649,11 @@ static URI getJavadocUrlForType(JavadocLinkGenerator
javadocLinkGenerator, Strin
} else {
binaryName = type;
}
-return javadocLinkGenerator.createLink(binaryName);
+return binaryName;
+}
+
+static URI getJavadocUrlForType(JavadocLinkGenerator javadocLinkGenerator,
String type) {
+return
javadocLinkGenerator.createLink(extractbinaryNameForJavadoc(type));
Review Comment:
```suggestion
return
javadocLinkGenerator.createLink(extractBinaryNameForJavadoc(type));
```
> Nested types not properly extracted cause exception while generating Javadoc
> URLs
> -
>
> Key: MPLUGIN-521
> URL: https://issues.apache.org/jira/browse/MPLUGIN-521
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.12.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.12.1
>
>
> Details:
> https://github.com/apache/maven-site-plugin/pull/177#pullrequestreview-2033188399
> If you have a type like {{Map>}} the generator will extract
> {{List}} instead of just {{Foo}}. We should recursively go down to the
> type.
> This is likely an edge case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-521] Nested types not properly extracted cause exception whi… [maven-plugin-tools]
michael-o commented on code in PR #281:
URL:
https://github.com/apache/maven-plugin-tools/pull/281#discussion_r1587606761
##
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##
@@ -637,10 +637,10 @@ static URI getJavadocUrlForType(JavadocLinkGenerator
javadocLinkGenerator, Strin
.split(",\\s*");
switch (parameterTypes.length) {
case 1: // if only one parameter type, assume collection,
first parameter type is most interesting
-binaryName = parameterTypes[0];
+binaryName =
extractbinaryNameForJavadoc(parameterTypes[0]);
break;
case 2: // if two parameter types assume map, second parameter
type is most interesting
-binaryName = parameterTypes[1];
+binaryName =
extractbinaryNameForJavadoc(parameterTypes[1]);
Review Comment:
```suggestion
binaryName =
extractBinaryNameForJavadoc(parameterTypes[1]);
```
##
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##
@@ -637,10 +637,10 @@ static URI getJavadocUrlForType(JavadocLinkGenerator
javadocLinkGenerator, Strin
.split(",\\s*");
switch (parameterTypes.length) {
case 1: // if only one parameter type, assume collection,
first parameter type is most interesting
-binaryName = parameterTypes[0];
+binaryName =
extractbinaryNameForJavadoc(parameterTypes[0]);
Review Comment:
```suggestion
binaryName =
extractBinaryNameForJavadoc(parameterTypes[0]);
```
##
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##
@@ -649,7 +649,11 @@ static URI getJavadocUrlForType(JavadocLinkGenerator
javadocLinkGenerator, Strin
} else {
binaryName = type;
}
-return javadocLinkGenerator.createLink(binaryName);
+return binaryName;
+}
+
+static URI getJavadocUrlForType(JavadocLinkGenerator javadocLinkGenerator,
String type) {
+return
javadocLinkGenerator.createLink(extractbinaryNameForJavadoc(type));
Review Comment:
```suggestion
return
javadocLinkGenerator.createLink(extractBinaryNameForJavadoc(type));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-521) Nested types not properly extracted cause exception while generating Javadoc URLs
[
https://issues.apache.org/jira/browse/MPLUGIN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842960#comment-17842960
]
ASF GitHub Bot commented on MPLUGIN-521:
kwin commented on code in PR #281:
URL:
https://github.com/apache/maven-plugin-tools/pull/281#discussion_r1587258849
##
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##
@@ -625,7 +625,7 @@ protected void writeParameterType(
}
}
-static URI getJavadocUrlForType(JavadocLinkGenerator javadocLinkGenerator,
String type) {
+private static String extractbinaryNameForJavadoc(String type) {
Review Comment:
```suggestion
private static String extractBinaryNameForJavadoc(String type) {
```
> Nested types not properly extracted cause exception while generating Javadoc
> URLs
> -
>
> Key: MPLUGIN-521
> URL: https://issues.apache.org/jira/browse/MPLUGIN-521
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.12.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.12.1
>
>
> Details:
> https://github.com/apache/maven-site-plugin/pull/177#pullrequestreview-2033188399
> If you have a type like {{Map>}} the generator will extract
> {{List}} instead of just {{Foo}}. We should recursively go down to the
> type.
> This is likely an edge case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MWRAPPER-136) maven-wrapper.properties created with Windows line breaks which mvnw can't handle
Patrick Schmidt created MWRAPPER-136:
Summary: maven-wrapper.properties created with Windows line breaks
which mvnw can't handle
Key: MWRAPPER-136
URL: https://issues.apache.org/jira/browse/MWRAPPER-136
Project: Maven Wrapper
Issue Type: Bug
Components: Maven Wrapper Scripts
Affects Versions: 3.3.1, 3.3.0, 3.2.0
Environment: Windows, Git BASH
Reporter: Patrick Schmidt
Since around version 3.2.0 the maven-wrapper.properties is created with Windows
line breaks for me. Unfortunately mvnw can't handle that. The error I receive
is:
{noformat}
'istributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but
found
'https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.6/apache-maven-3.9.6-bin.zip{noformat}
When I manually change it to Unix line breaks it works again. Version 3.1.0 of
the plug-in still creates it with Unix line breaks. Later versions seem to use
the platform default instead. I.e. whenever I rerun wrapper:wrapper its broken
again.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-521] Nested types not properly extracted cause exception whi… [maven-plugin-tools]
kwin commented on code in PR #281:
URL:
https://github.com/apache/maven-plugin-tools/pull/281#discussion_r1587258849
##
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##
@@ -625,7 +625,7 @@ protected void writeParameterType(
}
}
-static URI getJavadocUrlForType(JavadocLinkGenerator javadocLinkGenerator,
String type) {
+private static String extractbinaryNameForJavadoc(String type) {
Review Comment:
```suggestion
private static String extractBinaryNameForJavadoc(String type) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Simplified redundant judgment [maven]
gnodet merged PR #1489: URL: https://github.com/apache/maven/pull/1489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Resolver updates [maven]
gnodet opened a new pull request, #1495: URL: https://github.com/apache/maven/pull/1495 - **Resolver updates** - **Remove a few other references** Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mockito.version from 4.11.0 to 5.11.0 [maven-dependency-plugin]
dependabot[bot] commented on PR #387: URL: https://github.com/apache/maven-dependency-plugin/pull/387#issuecomment-2090276226 OK, I won't notify you about version 5.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mockito.version from 4.11.0 to 5.11.0 [maven-dependency-plugin]
dependabot[bot] closed pull request #387: Bump mockito.version from 4.11.0 to 5.11.0 URL: https://github.com/apache/maven-dependency-plugin/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mockito.version from 4.11.0 to 5.11.0 [maven-dependency-plugin]
slawekjaranowski commented on PR #387: URL: https://github.com/apache/maven-dependency-plugin/pull/387#issuecomment-2090276079 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.jetty:jetty-bom from 10.0.20 to 11.0.20 [maven-resolver]
dependabot[bot] commented on PR #487: URL: https://github.com/apache/maven-resolver/pull/487#issuecomment-2090264497 OK, I won't notify you about version 11.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.jetty:jetty-bom from 10.0.20 to 11.0.20 [maven-resolver]
dependabot[bot] closed pull request #487: Bump org.eclipse.jetty:jetty-bom from 10.0.20 to 11.0.20 URL: https://github.com/apache/maven-resolver/pull/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.jetty:jetty-bom from 10.0.20 to 11.0.20 [maven-resolver]
slachiewicz commented on PR #487: URL: https://github.com/apache/maven-resolver/pull/487#issuecomment-2090264398 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[
https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842924#comment-17842924
]
ASF GitHub Bot commented on MRESOLVER-554:
--
laeubi commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1587390849
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
> with boolean there is no need for null-check and can really be this or
that.
Just a remark, a `Boolean` can be `null` ... beside that `ConcurrentHashMap`
does not allows `null` keys...
> Support configuration of upload/download threads individually
> -
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Matt Nelson
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool
> configuration is shared for uploads and downloads. It has been observed in
> our environment that uploads frequently error out when attempting to upload
> with the default thread pool size(5), but conversely we don't see the same
> errors for downloads.
> The proposal is to support configuration of upload/download thread pools
> individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-554] Split thread counts for up and downstream ops [maven-resolver]
laeubi commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1587390849
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
> with boolean there is no need for null-check and can really be this or
that.
Just a remark, a `Boolean` can be `null` ... beside that `ConcurrentHashMap`
does not allows `null` keys...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[ https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842919#comment-17842919 ] ASF GitHub Bot commented on MRESOLVER-554: -- cstamas merged PR #489: URL: https://github.com/apache/maven-resolver/pull/489 > Support configuration of upload/download threads individually > - > > Key: MRESOLVER-554 > URL: https://issues.apache.org/jira/browse/MRESOLVER-554 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Matt Nelson >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > > Parallel deploys were introduced in MRESOLVER-32. The thread pool > configuration is shared for uploads and downloads. It has been observed in > our environment that uploads frequently error out when attempting to upload > with the default thread pool size(5), but conversely we don't see the same > errors for downloads. > The proposal is to support configuration of upload/download thread pools > individually. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOLVER-554) Support configuration of upload/download threads individually
[ https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-554. - Resolution: Fixed > Support configuration of upload/download threads individually > - > > Key: MRESOLVER-554 > URL: https://issues.apache.org/jira/browse/MRESOLVER-554 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Matt Nelson >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > > Parallel deploys were introduced in MRESOLVER-32. The thread pool > configuration is shared for uploads and downloads. It has been observed in > our environment that uploads frequently error out when attempting to upload > with the default thread pool size(5), but conversely we don't see the same > errors for downloads. > The proposal is to support configuration of upload/download thread pools > individually. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-554] Split thread counts for up and downstream ops [maven-resolver]
cstamas merged PR #489: URL: https://github.com/apache/maven-resolver/pull/489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[
https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842869#comment-17842869
]
ASF GitHub Bot commented on MRESOLVER-554:
--
cstamas commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1587210763
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
I disagree here, here is why: if I add enum, it will complicate method a
lot, will need to null-check it, will need to throw IAEx if not expected
(default branch of switch), etc... with `boolean` there is no need for
null-check and can really be this or that. IF we have need to keep more than 2
executors for any reason, this can be easily extended to enum, but right now I
see no point of doing it.
> Support configuration of upload/download threads individually
> -
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Matt Nelson
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool
> configuration is shared for uploads and downloads. It has been observed in
> our environment that uploads frequently error out when attempting to upload
> with the default thread pool size(5), but conversely we don't see the same
> errors for downloads.
> The proposal is to support configuration of upload/download thread pools
> individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[
https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842868#comment-17842868
]
ASF GitHub Bot commented on MRESOLVER-554:
--
cstamas commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1587210763
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
I disagree here, here is why: if I add enum, it will complicate method a
lot, will need to null-check it, will need to throw IAEx if not expected
(default branch), etc... with `boolean` there is no need for null-check and can
really be this or that. IF we have need to keep more than 2 executors for any
reason, this can be easily extended to enum, but right now I see no point of
doing it.
> Support configuration of upload/download threads individually
> -
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Matt Nelson
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool
> configuration is shared for uploads and downloads. It has been observed in
> our environment that uploads frequently error out when attempting to upload
> with the default thread pool size(5), but conversely we don't see the same
> errors for downloads.
> The proposal is to support configuration of upload/download thread pools
> individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-554] Split thread counts for up and downstream ops [maven-resolver]
cstamas commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1587210763
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
I disagree here, here is why: if I add enum, it will complicate method a
lot, will need to null-check it, will need to throw IAEx if not expected
(default branch of switch), etc... with `boolean` there is no need for
null-check and can really be this or that. IF we have need to keep more than 2
executors for any reason, this can be easily extended to enum, but right now I
see no point of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MRESOLVER-554] Split thread counts for up and downstream ops [maven-resolver]
cstamas commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1587210763
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
I disagree here, here is why: if I add enum, it will complicate method a
lot, will need to null-check it, will need to throw IAEx if not expected
(default branch), etc... with `boolean` there is no need for null-check and can
really be this or that. IF we have need to keep more than 2 executors for any
reason, this can be easily extended to enum, but right now I see no point of
doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
