[jira] [Created] (MWRAPPER-81) mvnw does not remove return chars from jvm.config

2022-10-31 Thread Arlo Louis O'Keeffe (Jira)
Arlo Louis O'Keeffe created MWRAPPER-81:
---

 Summary: mvnw does not remove return chars from jvm.config
 Key: MWRAPPER-81
 URL: https://issues.apache.org/jira/browse/MWRAPPER-81
 Project: Maven Wrapper
  Issue Type: Bug
  Components: Maven Wrapper Scripts
Affects Versions: 3.1.1
Reporter: Arlo Louis O'Keeffe


When the jvm.config contains return characters (\r) in addition to newlines 
(\n) e.g. on Windows the mvnw script does not remove those.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-437) maven-dependency-tree removes optional flag from managed dependencies

2017-04-19 Thread Arlo Louis O'Keeffe (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHARED-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974769#comment-15974769
 ] 

Arlo Louis O'Keeffe commented on MSHARED-437:
-

Thanks for the reply, Michael. Sadly updating to 3.0 only makes it worse. Now 
no dependencies are marked as optional. All four integration tests are failing:

https://travis-ci.org/evosec/export-dependencies-maven-plugin/jobs/223574750

{code}
[ERROR] The following builds failed:
[ERROR] *  buck-bom-managed-optional-transitive-dependencies\pom.xml
[ERROR] *  buck-managed-optional-transitive-dependencies\pom.xml
[ERROR] *  buck-optional-single-dependency\pom.xml
[ERROR] *  buck-optional-transitive-dependencies\pom.xml
{code}

I believe the problem lies in 
MavenXDependencyGraphBuilder.getDependencyArtifact(Dependency). The method 
should not only set the scope but also optional. If possible one can actually 
completely replace 
MavenXDependencyGraphBuilder.getDependencyArtifact(Dependency) with 
RepositoryUtils.toArtifact(Dependency).

> maven-dependency-tree removes optional flag from managed dependencies
> -
>
> Key: MSHARED-437
> URL: https://issues.apache.org/jira/browse/MSHARED-437
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-tree
>Affects Versions: maven-dependency-tree-2.2
>Reporter: Arlo Louis O'Keeffe
>Priority: Minor
>
> Given the following 
> [pom|https://github.com/evosec/export-dependencies-maven-plugin/blob/21d80e29bd2e3507e97556e65f2f962fb7b0/src/it/buck-bom-managed-optional-transitive-dependencies/pom.xml]
>  the dependency tree looks like this
> - com.mysema.querydsl:querydsl-core:jar:3.4.3:compile
> -- com.google.guava:guava:jar:17.0:compile
> -- com.google.code.findbugs:jsr305:jar:2.0.3:compile
> -- com.mysema.commons:mysema-commons-lang:jar:0.2.4:compile
> -- com.infradna.tool:bridge-method-annotation:jar:1.13:compile
> You expect the entire tree to have the optional flag set to true. But sadly 
> that's not the case. com.google.guava:guava and 
> com.google.code.findbugs:jsr305 are optional = false.
> I found that this is because they are managed dependencies (no difference 
> whether imported or declared directly). When I use this 
> [pom|https://github.com/evosec/export-dependencies-maven-plugin/blob/a931ee09c0880097b73e2010d71b000ede3acbfe/src/it/buck-optional-transitive-dependencies/pom.xml]
>  it works.
> There are some integration tests in this 
> [repository|https://github.com/evosec/export-dependencies-maven-plugin] that 
> demonstrate the issue. Checkout demonstrate-tree-bug branch and run "mvn 
> verify". Now compare these files in target/it
> - buck-bom-managed-optional-transitive-dependencies/target/BUCK
> - buck-managed-optional-transitive-dependencies/target/BUCK
> - buck-optional-transitive-dependencies/target/BUCK
> [The CI builds demonstrating the 
> failure|https://travis-ci.org/evosec/export-dependencies-maven-plugin/builds/81137480].
> Let me know if I can help you reproduce the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (MSHARED-437) maven-dependency-tree removes optional flag from managed dependencies

2015-09-19 Thread Arlo Louis O'Keeffe (JIRA)
Arlo Louis O'Keeffe created MSHARED-437:
---

 Summary: maven-dependency-tree removes optional flag from managed 
dependencies
 Key: MSHARED-437
 URL: https://issues.apache.org/jira/browse/MSHARED-437
 Project: Maven Shared Components
  Issue Type: Bug
  Components: maven-dependency-tree
Affects Versions: maven-dependency-tree-2.2
Reporter: Arlo Louis O'Keeffe
Priority: Minor


Given the following 
[pom|https://github.com/evosec/export-dependencies-maven-plugin/blob/21d80e29bd2e3507e97556e65f2f962fb7b0/src/it/buck-bom-managed-optional-transitive-dependencies/pom.xml]
 the dependency tree looks like this

- com.mysema.querydsl:querydsl-core:jar:3.4.3:compile
-- com.google.guava:guava:jar:17.0:compile
-- com.google.code.findbugs:jsr305:jar:2.0.3:compile
-- com.mysema.commons:mysema-commons-lang:jar:0.2.4:compile
-- com.infradna.tool:bridge-method-annotation:jar:1.13:compile

You expect the entire tree to have the optional flag set to true. But sadly 
that's not the case. com.google.guava:guava and com.google.code.findbugs:jsr305 
are optional = false.

I found that this is because they are managed dependencies (no difference 
whether imported or declared directly). When I use this 
[pom|https://github.com/evosec/export-dependencies-maven-plugin/blob/a931ee09c0880097b73e2010d71b000ede3acbfe/src/it/buck-optional-transitive-dependencies/pom.xml]
 it works.

There are some integration tests in this 
[repository|https://github.com/evosec/export-dependencies-maven-plugin] that 
demonstrate the issue. Checkout demonstrate-tree-bug branch and run "mvn 
verify". Now compare these files in target/it
- buck-bom-managed-optional-transitive-dependencies/target/BUCK
- buck-managed-optional-transitive-dependencies/target/BUCK
- buck-optional-transitive-dependencies/target/BUCK

[The CI builds demonstrating the 
failure|https://travis-ci.org/evosec/export-dependencies-maven-plugin/builds/81137480].

Let me know if I can help you reproduce the problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] (MCHECKSTYLE-70) Support for multiple source folders

2014-09-22 Thread Arlo Louis O'Keeffe (JIRA)

[ 
https://jira.codehaus.org/browse/MCHECKSTYLE-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=353039#comment-353039
 ] 

Arlo Louis O'Keeffe commented on MCHECKSTYLE-70:


How does this deal with generated sources?

> Support for multiple source folders
> ---
>
> Key: MCHECKSTYLE-70
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-70
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>Affects Versions: 2.1
>Reporter: Jan Palmquist
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 2.13
>
>
> It would be great if this plugin would support multiple source folders added 
> by http://mojo.codehaus.org/build-helper-maven-plugin/ (or similar), and by 
> default inspect sources from these folders instead of just 
> ${project.build.sourceDirectory}. Correspondingly with respect to test 
> sources if those are configured to be included.
> There are other plugins available solving this problem (somehow), eg:
> * http://mojo.codehaus.org/jdepend-maven-plugin/
> * http://mojo.codehaus.org/findbugs-maven-plugin/
> Maybe they can give some inspiration for how to make this possible?



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MCHECKSTYLE-61) Upgrade Locator URL logic to use maven-wagon.

2014-09-22 Thread Arlo Louis O'Keeffe (JIRA)

[ 
https://jira.codehaus.org/browse/MCHECKSTYLE-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=353038#comment-353038
 ] 

Arlo Louis O'Keeffe commented on MCHECKSTYLE-61:


Is there any timeline for this and MCHECKSTYLE-42? It sucks to see new releases 
and bugs like these are hanging around since 2006.

> Upgrade Locator URL logic to use maven-wagon.
> -
>
> Key: MCHECKSTYLE-61
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-61
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>Reporter: Joakim Erdfelt
>  Labels: plexus-resources
>
> Upgrade the URL location logic in the Locator to utilize the maven-wagon api.
> Current logic utilizes the java URL object.
> Using maven-wagon, will allow for many more potential sources, as well as 
> greater authorization and proxy abilities already built into maven.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MDEP-187) dependency:copy fails when invoked from m2e with workspace resolution enabled, or more generally when copying within reactor for phases earlier than package

2014-04-01 Thread Arlo Louis O'Keeffe (JIRA)

[ 
https://jira.codehaus.org/browse/MDEP-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=343912#comment-343912
 ] 

Arlo Louis O'Keeffe commented on MDEP-187:
--

I have added a copy to the pre-integration-phase which AFAIK should work since 
it's after packaging. I nonetheless get the warning. Is this expected?

> dependency:copy fails when invoked from m2e with workspace resolution 
> enabled, or more generally when copying within reactor for phases earlier 
> than package
> 
>
> Key: MDEP-187
> URL: https://jira.codehaus.org/browse/MDEP-187
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: copy, copy-dependencies
>Affects Versions: 2.1
>Reporter: Igor Fedorenko
> Attachments: MDEP-187b.diff, MDEP-187c.diff, MDEP-187.diff
>
>
> m2e resolves workspace artifacts to their output folders but dependency:copy 
> expects all artifacts to be files. I will provide trivial patch shortly.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong

2014-03-13 Thread Arlo Louis O'Keeffe (JIRA)

[ 
https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342870#comment-342870
 ] 

Arlo Louis O'Keeffe edited comment on MCHECKSTYLE-221 at 3/13/14 7:11 PM:
--

You are absolutely right. It is the correct value. Maven file patterns are 
influenced by [ant FileSets|http://ant.apache.org/manual/Types/fileset.html] 
and the first example explains it perfectly.

I just followed the trail of the includes property and believe that the \ can 
be safely removed.

[DefaultCheckstyleExcecutor|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?view=markup#l557]
  passes {{\*\*\/\*.java}} to 
[org.codehaus.plexus.util.FileUtils.getFiles()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/FileUtils.java#FileUtils.getFiles%28java.io.File%2Cjava.lang.String%2Cjava.lang.String%29]
 which uses  
[AbstractScanner.setIncludes|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/AbstractScanner.java#AbstractScanner.setIncludes%28java.lang.String%5B%5D%29].
 There the pattern is converted to {{\*\*//\*.java}} (in the case of a unix 
system). This pattern is passed to 
[MatchPatterns.from()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/MatchPatterns.java#MatchPatterns.from%28java.lang.String%5B%5D%29]
 and ends up in a Tokenizer that uses {{/}} as a separator. The Tokenizer will 
ignore the duplicate {{/}} and therefore the \ can be removed.


was (Author: arlol):
You are absolutely right. It is the correct value. Maven file patterns are 
influenced by [ant FileSets|http://ant.apache.org/manual/Types/fileset.html] 
and the first example explains it perfectly.

I just followed the trail of the includes property and believe that the \ can 
be safely removed.

[DefaultCheckstyleExcecutor|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?view=markup#l557]
  passes {{\*\*\/\*.java}} to 
[org.codehaus.plexus.util.FileUtils.getFiles()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/FileUtils.java#FileUtils.getFiles%28java.io.File%2Cjava.lang.String%2Cjava.lang.String%29]
 which uses  
[AbstractScanner.setIncludes|http://plexus.codehaus.org/plexus-utils/apidocs/index.html].
 There the pattern is converted to {{\*\*//\*.java}} (in the case of a unix 
system). This pattern is passed to 
[MatchPatterns.from()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/MatchPatterns.java#MatchPatterns.from%28java.lang.String%5B%5D%29]
 and ends up in a Tokenizer that uses {{/}} as a separator. The Tokenizer will 
ignore the duplicate {{/}} and therefore the \ can be removed.

> ResourceIncludes default value is wrong
> ---
>
> Key: MCHECKSTYLE-221
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.11
>Reporter: Arlo Louis O'Keeffe
>Assignee: Dennis Lundberg
>Priority: Minor
> Fix For: 2.12
>
>
> The default value for resourceIncludes is supposed to be \*\*\/\*.properties 
> but in fact it is \*\*/\*.properties.
> You can verify in the generated maven site: 
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes
> An easy workaround is to simply define resourceIncludes yourself.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong

2014-03-13 Thread Arlo Louis O'Keeffe (JIRA)

[ 
https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342870#comment-342870
 ] 

Arlo Louis O'Keeffe commented on MCHECKSTYLE-221:
-

You are absolutely right. It is the correct value. Maven file patterns are 
influenced by [ant FileSets|http://ant.apache.org/manual/Types/fileset.html] 
and the first example explains it perfectly.

I just followed the trail of the includes property and believe that the \ can 
be safely removed.

[DefaultCheckstyleExcecutor|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?view=markup#l557]
  passes {{\*\*\/\*.java}} to 
[org.codehaus.plexus.util.FileUtils.getFiles()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/FileUtils.java#FileUtils.getFiles%28java.io.File%2Cjava.lang.String%2Cjava.lang.String%29]
 which uses  
[AbstractScanner.setIncludes|http://plexus.codehaus.org/plexus-utils/apidocs/index.html].
 There the pattern is converted to {{\*\*//\*.java}} (in the case of a unix 
system). This pattern is passed to 
[MatchPatterns.from()|http://grepcode.com/file/repo1.maven.org/maven2/org.codehaus.plexus/plexus-utils/3.0.15/org/codehaus/plexus/util/MatchPatterns.java#MatchPatterns.from%28java.lang.String%5B%5D%29]
 and ends up in a Tokenizer that uses {{/}} as a separator. The Tokenizer will 
ignore the duplicate {{/}} and therefore the \ can be removed.

> ResourceIncludes default value is wrong
> ---
>
> Key: MCHECKSTYLE-221
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.11
>Reporter: Arlo Louis O'Keeffe
>Assignee: Dennis Lundberg
>Priority: Minor
> Fix For: 2.12
>
>
> The default value for resourceIncludes is supposed to be \*\*\/\*.properties 
> but in fact it is \*\*/\*.properties.
> You can verify in the generated maven site: 
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes
> An easy workaround is to simply define resourceIncludes yourself.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong

2014-03-13 Thread Arlo Louis O'Keeffe (JIRA)

[ 
https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342860#comment-342860
 ] 

Arlo Louis O'Keeffe commented on MCHECKSTYLE-221:
-

Thanks for acknowledging my issue. Sadly I am still a little confused.

Do you mean that the value is supposed to be \*\*/\*.properties? If yes, could 
you explain why the includes for Java is different? Because If I look at the 
default value for 
[includes|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?view=markup#l68]
 and 
[resourceIncludes|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.12/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?view=markup#l336]
 they have a different structure.

> ResourceIncludes default value is wrong
> ---
>
> Key: MCHECKSTYLE-221
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.11
>Reporter: Arlo Louis O'Keeffe
>Assignee: Dennis Lundberg
>Priority: Minor
> Fix For: 2.12
>
>
> The default value for resourceIncludes is supposed to be \*\*\/\*.properties 
> but in fact it is \*\*/\*.properties.
> You can verify in the generated maven site: 
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes
> An easy workaround is to simply define resourceIncludes yourself.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong

2014-03-04 Thread Arlo Louis O'Keeffe (JIRA)

 [ 
https://jira.codehaus.org/browse/MCHECKSTYLE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arlo Louis O'Keeffe updated MCHECKSTYLE-221:


Description: 
The default value for resourceIncludes is supposed to be \*\*\/\*.properties 
but in fact it is \*\*/\*.properties.

You can verify in the generated maven site: 
https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes

An easy workaround is to simply define resourceIncludes yourself.

  was:
The default value for resourceIncludes is supposed to be **\/*.properties but 
in fact it is **/*.properties.

You can verify in the generated maven site: 
https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes

An easy workaround is to simply define resourceIncludes yourself.


> ResourceIncludes default value is wrong
> ---
>
> Key: MCHECKSTYLE-221
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.11
>Reporter: Arlo Louis O'Keeffe
>Priority: Minor
>
> The default value for resourceIncludes is supposed to be \*\*\/\*.properties 
> but in fact it is \*\*/\*.properties.
> You can verify in the generated maven site: 
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes
> An easy workaround is to simply define resourceIncludes yourself.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MCHECKSTYLE-221) ResourceIncludes default value is wrong

2014-03-04 Thread Arlo Louis O'Keeffe (JIRA)
Arlo Louis O'Keeffe created MCHECKSTYLE-221:
---

 Summary: ResourceIncludes default value is wrong
 Key: MCHECKSTYLE-221
 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-221
 Project: Maven Checkstyle Plugin
  Issue Type: Bug
Affects Versions: 2.11
Reporter: Arlo Louis O'Keeffe
Priority: Minor


The default value for resourceIncludes is supposed to be **\/*.properties but 
in fact it is **/*.properties.

You can verify in the generated maven site: 
https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#resourceIncludes

An easy workaround is to simply define resourceIncludes yourself.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MCHECKSTYLE-195) Property to fail on warnings

2013-06-27 Thread Arlo Louis O'Keeffe (JIRA)

 [ 
https://jira.codehaus.org/browse/MCHECKSTYLE-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arlo Louis O'Keeffe closed MCHECKSTYLE-195.
---

Resolution: Duplicate

Duplicate of MCHECKSTYLE-45

> Property to fail on warnings
> 
>
> Key: MCHECKSTYLE-195
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-195
> Project: Maven 2.x Checkstyle Plugin
>  Issue Type: Improvement
>Affects Versions: 2.10
>Reporter: Arlo Louis O'Keeffe
>Priority: Minor
>
> For my deployment builds I would like to fail the build for checkstyle 
> warnings not only for errors. It would be great if this functionality were 
> added to the check goal.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MCHECKSTYLE-195) Property to fail on warnings

2013-06-27 Thread Arlo Louis O'Keeffe (JIRA)
Arlo Louis O'Keeffe created MCHECKSTYLE-195:
---

 Summary: Property to fail on warnings
 Key: MCHECKSTYLE-195
 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-195
 Project: Maven 2.x Checkstyle Plugin
  Issue Type: Improvement
Affects Versions: 2.10
Reporter: Arlo Louis O'Keeffe
Priority: Minor


For my deployment builds I would like to fail the build for checkstyle warnings 
not only for errors. It would be great if this functionality were added to the 
check goal.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MCHECKSTYLE-42) checkstyle does not take into account proxy settings from settings.xml

2013-05-24 Thread Arlo Louis O'Keeffe (JIRA)

 [ 
https://jira.codehaus.org/browse/MCHECKSTYLE-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arlo Louis O'Keeffe updated MCHECKSTYLE-42:
---

Attachment: fix-proxy-usage.patch

I created a simple patch that uses cargo's approach for applying the proxy 
settings. It's not beautiful but it works.

> checkstyle does not take into account proxy settings from settings.xml
> --
>
> Key: MCHECKSTYLE-42
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-42
> Project: Maven 2.x Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.0
>Reporter: Frederic
> Attachments: fix-proxy-usage.patch
>
>
> I've been hesitating wether to report it as bug or as improvement, but at the 
> moment I'd rate it as a bug.
> It took me quite some time to figure out why this was going wrong.
> In my settings.xml I've defined our company proxysettings. These settings are 
> used by Maven when connecting to the remote repository.
> However when using the checkstyle plugin as part of the site generation I can 
>  not obtain our checkstyle.xml which is available via http.
> I found a solution by adding the following parameters on the command line 
> when continuum launches maven:
> -Dhttp.proxyHost=myproxy -Dhttp.proxyPort=80
> Wouldn't it be possible for the maven checkstyle plugin to use the settings 
> defined in settings.xml, so I've only to define those once?
> FYI the error generated:
> [INFO] Generate "Dependencies" report.
> [INFO] Generate "Issue Tracking" report.
> [INFO] Generate "Project License" report.
> [INFO] Generate "Mailing Lists" report.
> [INFO] Generate "Source Repository" report.
> [INFO] Generate "Project Team" report.
> [INFO] Generate "Maven Surefire Report" report.
> [INFO] Generate "Checkstyle" report.
> [INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Error during report generation
> Embedded error: Unable to find configuration file location.
> http://spirou.mycompany.be/javadev/install/checkstyle/mycompany-checkstyle-1.5.xml
> [INFO] 
> 
> [INFO] Trace
> org.apache.maven.lifecycle.LifecycleExecutionException: Error during report 
> generation
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:559)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:475)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:454)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:306)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:273)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:140)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:256)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:324)
> at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at 
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error during 
> report generation
> at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:389)
> at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:412)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:534)
> ... 16 more
> Caused by: org.apache.maven.reporting.MavenReportException: Unable to find 
> configuration file location.
> at 
> org.apache.maven.plugin.checkstyle.CheckstyleReport.getConfigFile(CheckstyleReport.java:879)
> at 
> org.apache.maven.plugin.checkstyle.CheckstyleReport.executeReport(CheckstyleReport.java:466)
> at 
> org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:98)
> at 
> org.apache.maven