[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549356949 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,14 +244,43 @@ under the License. --> + + maven:core:central-repo + + + central + Central Repository + https://repo.maven.apache.org/maven2 + +false + + + + + + + central + Central Repository + https://repo.maven.apache.org/maven2 + +false + + +never + + + + -alwaysActiveProfile -anotherAlwaysActiveProfile +maven:core:central-repo Review comment: I can't offer anything better until settings don't change. Take your time and let me know. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549152683 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +true Review comment: Added a profile. Have a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549150845 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comment: https://issues.apache.org/jira/browse/MNG-7059 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549123187 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comment: So do you want to move this after settings 1.2.0 or can we start with a profile and then move to a separate repo? Implementing 1.2.0 will take some time... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549123105 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +true Review comment: The `DefaultModelValidator` retains a negative list of characters, not a positive one. Are you referring to another validation? I am confused. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549110998 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comment: Correct, makes sense. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549110606 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +true Review comment: We also do not have an official documentation what is valid or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108923 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comment: So you want to bump settings model to 2.0.0 and introduce repos there? What will happen when pre-4.0.0 will try to read this settings file? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108923 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comment: So you want to bump settings model to 2.0.0 and introduce repos there? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108816 ## File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java ## @@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) && Artifact.SCOPE_COMPILE.equal // Code taken from LegacyRepositorySystem // -public ArtifactRepository createDefaultRemoteRepository( MavenExecutionRequest request ) Review comment: So leave as-is? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108800 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +true Review comment: No, it is not. Colon is invalid for group/artifact ids. For element ids nothing is enforced. See: https://issues.apache.org/jira/browse/MNG-7052. I intionally did not want to use a period because people might have used `maven.repo...`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549106505 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +true Review comment: I was never a fan of implicit deactivation because it seems to much magic to me. My initial idea was to name the profile. Same approach I have used with Maven Resolver Redisson Sync Context. I want to reserve a URN-style id namespace to use. In Resolver I have used: `maven:resolver:` prefix. Here I would like to use `maven:core:central-repo`, at least the `maven:core:` prefix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549106196 ## File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java ## @@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) && Artifact.SCOPE_COMPILE.equal // Code taken from LegacyRepositorySystem // -public ArtifactRepository createDefaultRemoteRepository( MavenExecutionRequest request ) Review comment: True, I chose to use a highly invasive approach. One could use the same approach like in the original commits. Retain public method, but return either `null` or `InvalidRepositoryException`. The contract does not describe any behavior. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549105819 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comment: That's correct, but we don't have a better way. Settings with Maven 5 could natively support repositories. Do you see a better way? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
