Re: [PR] Apache Lucene 9.9.0 and other minor dependency bumps [maven-indexer]
cstamas commented on code in PR #337:
URL: https://github.com/apache/maven-indexer/pull/337#discussion_r1425952599
##
pom.xml:
##
@@ -94,8 +94,7 @@ under the License.
11
-${javaVersion}
-${javaVersion}
+${javaVersion}
Review Comment:
Fixed with cbf1b5bcd406c57c24796c3561e3036fe651f27e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Apache Lucene 9.9.0 and other minor dependency bumps [maven-indexer]
mbien commented on code in PR #337:
URL: https://github.com/apache/maven-indexer/pull/337#discussion_r1425950222
##
pom.xml:
##
@@ -94,8 +94,7 @@ under the License.
11
-${javaVersion}
-${javaVersion}
+${javaVersion}
Review Comment:
oh no!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Apache Lucene 9.9.0 and other minor dependency bumps [maven-indexer]
cstamas commented on code in PR #337:
URL: https://github.com/apache/maven-indexer/pull/337#discussion_r1425947320
##
pom.xml:
##
@@ -94,8 +94,7 @@ under the License.
11
-${javaVersion}
-${javaVersion}
+${javaVersion}
Review Comment:
Bah, forgot that this should not be removed :smile:
Due this in parent:
https://github.com/apache/maven-parent/blob/maven-parent-41/pom.xml#L956-L957
Hence 11 becomes "1.11", which is kinda fine so far (as javac will ignore
those two when release set), but reporting craps out, so release becomes
impossible. Will undo this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Apache Lucene 9.9.0 and other minor dependency bumps [maven-indexer]
cstamas merged PR #337: URL: https://github.com/apache/maven-indexer/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Apache Lucene 9.9.0 and other minor dependency bumps [maven-indexer]
mbien commented on code in PR #337: URL: https://github.com/apache/maven-indexer/pull/337#discussion_r1421508426 ## pom.xml: ## @@ -106,9 +105,9 @@ under the License. 0.9.0.M2 6.0.0 -9.8.0 +9.9.0 3.9.5 Review Comment: roger, will update and force push in a sec ## pom.xml: ## @@ -268,7 +267,7 @@ under the License. org.eclipse.jetty jetty-webapp -9.4.51.v20230217 +9.4.53.v20231009 Review Comment: yep. the only reason I didn't change is because I know from running my old blog on a rapsi, that Jetty 10.x changed quite a few tings internally (module system etc and even some property names of the plugin) which can break logging for example. So I didn't want to blindly bump the major version without knowing the usages very well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Apache Lucene 9.9.0 and other minor dependency bumps [maven-indexer]
cstamas commented on code in PR #337: URL: https://github.com/apache/maven-indexer/pull/337#discussion_r1421392520 ## pom.xml: ## @@ -106,9 +105,9 @@ under the License. 0.9.0.M2 6.0.0 -9.8.0 +9.9.0 3.9.5 Review Comment: @mbien could you up this to 3.9.6 please as well? so have it all at once? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Apache Lucene 9.9.0 and other minor dependency bumps [maven-indexer]
cstamas commented on code in PR #337: URL: https://github.com/apache/maven-indexer/pull/337#discussion_r1421392650 ## pom.xml: ## @@ -268,7 +267,7 @@ under the License. org.eclipse.jetty jetty-webapp -9.4.51.v20230217 +9.4.53.v20231009 Review Comment: TODO for myself: we should move off EOLd Jetty, probably can lift some code from resolver tests that also did a smooth migration in test used "server" from 9.x to 10.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Apache Lucene 9.9.0 and other minor dependency bumps [maven-indexer]
mbien opened a new pull request, #337: URL: https://github.com/apache/maven-indexer/pull/337 - lucene 9.8.0 to 9.9.0 changes: https://lucene.apache.org/core/9_9_0/changes/Changes.html - this also switches javac source/target to release - didn't touch guice since it 7.0 changes namespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
