[jira] [Commented] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815117#comment-15815117
 ] 

Hudson commented on DOXIASITETOOLS-172:
---

SUCCESS: Integrated in Jenkins build doxia-all #317 (See 
[https://builds.apache.org/job/doxia-all/317/])
[DOXIASITETOOLS-172] Width, height and border values not used for banner display

Submitted-by: Michael Benz  (michaelo: 
[http://svn.apache.org/viewvc/?view=rev=1778133])
* (edit) 
./doxia-sitetools/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site-macros.vm


> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 1.7.5
>
> Attachments: enable-width-height-border-doxia-sitetools-alt.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> Created new issue DOXIASITETOOLS-173 for the CSS issue described below:
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

[Michael Benz (JIRA)]

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814486#comment-15814486
 ] 

Michael Benz commented on DOXIASITETOOLS-172:
-

Created DOXIASITETOOLS-173 for that and will provide a patch as well.

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

[Michael Benz (JIRA)]

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814484#comment-15814484
 ] 

Michael Benz commented on DOXIASITETOOLS-172:
-

border="0" can be removed. I was overzealous in making sure no borders are 
displayed around the banner. That should be the users's choice.
If I use the same alt definition as in the fluido skin, unit test 
DefaultSiteRenderer fails:
{quote}
Message: Attribute "alt" is required and must be specified for element type 
"img".
{quote}
Therefore I need to leave the empty {code}alt=""{code} tag in case neither name 
nor alt are defined for the banner image.

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812796#comment-15812796
 ] 

Michael Osipov commented on DOXIASITETOOLS-172:
---

Just checked the patch, two issues:

1. Set {{alt}} just like Fluido's {{site.vm}} does
2. Don't set {{border="0"}} as default, this isn't documented anywhere. Just 
leave it empty.

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DOXIASITETOOLS-172) Width, height and border values not used for banner display

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812777#comment-15812777
 ] 

Michael Osipov commented on DOXIASITETOOLS-172:
---

You just found a bug in the default skin CSS, please go ahead, file a ticket 
with a patch which removes the {{border: none}}. This style is pretty useless 
because we kill our own decoration model setting with that. It should be up to 
the user to decide about a border style.

> Width, height and border values not used for banner display
> ---
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.7.4
>Reporter: Michael Benz
>Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default 
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> 
>   Name
>   Logo.svg
>   30
>   10
>   Logo Title
>   2
> 
> {code}
> Created HTML:
> {code}
> 
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any 
> image - one would need to create a new skin for borders or remove the 
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
>   border:none;
> }
> /* (...) */
> #banner img {
>   border: none;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)