[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840193#comment-17840193 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- asfgit closed pull request #150: [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… URL: https://github.com/apache/maven-doxia-sitetools/pull/150 > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840194#comment-17840194 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- asfgit merged PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150 > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840135#comment-17840135 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2072684521 @kwin Just ran: ``` osipovmi@deblndw011x:~/var/Projekte/maven-project-info-reports-plugin (doxia-2.0.0 *=) $ git diff -U0 diff --git a/pom.xml b/pom.xml index 9395b30..69c5416 100644 - > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840110#comment-17840110 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2072373572 I will run our plugins and see how it goes. > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839956#comment-17839956 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2071492676 > According to https://mvnrepository.com/artifact/org.apache.maven.doxia/doxia-site-renderer/usages there is 180 downstream dependencies… This is deceiving data because the only thing they use is https://github.com/apache/maven-reporting-impl/blob/master/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java#L283. They will not interact with site directories or retrieve them. The `SiteRenderingContext` does not contain any site directories. > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839953#comment-17839953 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- kwin commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2071479172 According to https://mvnrepository.com/artifact/org.apache.maven.doxia/doxia-site-renderer/usages there is 180 downstream dependencies… > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839939#comment-17839939 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- hboutemy commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1575656039 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -271,7 +290,7 @@ public void addSiteDirectory(File siteDirectory) { * * @return List of site directories files. */ -public List getSiteDirectories() { +public List getSiteDirectories() { Review Comment: yes, Doxia Sitetools is only used by Maven Site plugin: binary compatibility is not really a topic, particularly when we are working on 2.0 milestones of Doxia Sitetools > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839272#comment-17839272 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2067752090 Rename to `SiteSourceDirectory`? > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839271#comment-17839271 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573364171 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -260,9 +279,9 @@ public void setTemplateName(String templateName) { * Add a site directory, expected to have a Doxia Site layout, ie one directory per Doxia parser module containing * files with parser extension. Typical values are src/site or target/generated-site. * - * @param siteDirectory a {@link java.io.File} object. + * @param siteDirectory a {@link SiteDirectory} object. */ -public void addSiteDirectory(File siteDirectory) { +public void addSiteDirectory(SiteDirectory siteDirectory) { Review Comment: Done > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839269#comment-17839269 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2067747899 @hboutemy Any comments on the binary compat? I am OK to break it since it this is a major version and the sole public user is Maven Site Plugin... > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839268#comment-17839268 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573361548 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -271,7 +290,7 @@ public void addSiteDirectory(File siteDirectory) { * * @return List of site directories files. */ -public List getSiteDirectories() { +public List getSiteDirectories() { Review Comment: I cannot come up with a better one either, but am willing to take the BC break on my shoulders given that the scope of usage is quite limited. > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839266#comment-17839266 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358753 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -260,9 +279,9 @@ public void setTemplateName(String templateName) { * Add a site directory, expected to have a Doxia Site layout, ie one directory per Doxia parser module containing * files with parser extension. Typical values are src/site or target/generated-site. * - * @param siteDirectory a {@link java.io.File} object. + * @param siteDirectory a {@link SiteDirectory} object. */ -public void addSiteDirectory(File siteDirectory) { +public void addSiteDirectory(SiteDirectory siteDirectory) { Review Comment: The general question: What is the affected audience? The only known consumer/caller is Maven Site Plugin. You expect this to break in a combination you can already forsee? > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839267#comment-17839267 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358826 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -260,9 +279,9 @@ public void setTemplateName(String templateName) { * Add a site directory, expected to have a Doxia Site layout, ie one directory per Doxia parser module containing * files with parser extension. Typical values are src/site or target/generated-site. * - * @param siteDirectory a {@link java.io.File} object. + * @param siteDirectory a {@link SiteDirectory} object. */ -public void addSiteDirectory(File siteDirectory) { +public void addSiteDirectory(SiteDirectory siteDirectory) { Review Comment: Will do. > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839264#comment-17839264 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- kwin commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573354321 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -271,7 +290,7 @@ public void addSiteDirectory(File siteDirectory) { * * @return List of site directories files. */ -public List getSiteDirectories() { +public List getSiteDirectories() { Review Comment: Please leave the old method in place, deprecate it and rename the new one (cannot come up with a good naming proposal right now). But please don't just break backwards compatibility. ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -260,9 +279,9 @@ public void setTemplateName(String templateName) { * Add a site directory, expected to have a Doxia Site layout, ie one directory per Doxia parser module containing * files with parser extension. Typical values are src/site or target/generated-site. * - * @param siteDirectory a {@link java.io.File} object. + * @param siteDirectory a {@link SiteDirectory} object. */ -public void addSiteDirectory(File siteDirectory) { +public void addSiteDirectory(SiteDirectory siteDirectory) { Review Comment: Why breaking backwards compatibility? Just leave the old method taking `File` in place, deprecate it and just delegate to the new `addSiteDirectory` For the new method please add `@since`. > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839051#comment-17839051 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o opened a new pull request, #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150 …le aware > Make SiteRenderingContext#siteDirectories editable aware > > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 2.0.0-M16 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)