[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail

2024-04-12 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836693#comment-17836693
 ] 

ASF GitHub Bot commented on MGPG-125:
-

cstamas commented on PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#issuecomment-2052127538

   For last build this PR:
   ```
   [INFO] Building: sign-release-best-practices/pom.xml
   [INFO] run post-build script verify.groovy
   [INFO]   sign-release-best-practices/pom.xml .. SUCCESS 
(4.002 s)
   ```
   2nd build/commit:
   ```
   [INFO] Building: sign-release-best-practices/pom.xml
   [INFO] run post-build script verify.groovy
   [INFO]   sign-release-best-practices/pom.xml .. SUCCESS 
(3.877 s)
   ```
   
   Hm, minimal... unsure what I "feel" locally. Maybe that these two ITs use 
_new_ plugins (hence downoads them) while all the rest use old/ancient plugins 
but some version?




> Due to default value of gpg.passphraseServerId, bestPractices=true will 
> always fail
> ---
>
> Key: MGPG-125
> URL: https://issues.apache.org/jira/browse/MGPG-125
> Project: Maven GPG Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
>Reporter: Benjamin Marwell
>Assignee: Tamas Cservenak
>Priority: Critical
> Fix For: 3.2.4
>
>
> Running gpg-plugin with best practices from the CLI, it will always fail 
> since gpg.passphraseServerId does have a default value set.
> See:
> https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140
> CC [~cstamas]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail

2024-04-12 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836468#comment-17836468
 ] 

ASF GitHub Bot commented on MGPG-125:
-

slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562201582


##
src/it/sign-release-best-practices/verify.groovy:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+var artifactDir = new File(localRepositoryPath, 
"org/apache/maven/its/gpg/sr/test/1.0")
+
+var expectedFiles = [
+"test-1.0.pom",
+"test-1.0.pom.asc",
+"test-1.0.jar",
+"test-1.0.jar.asc",
+"test-1.0-sources.jar",
+"test-1.0-sources.jar.asc"
+]
+
+for (String expectedFile : expectedFiles) {
+var file = new File(artifactDir, expectedFile)
+
+println "Checking for existence of $file"
+
+if (!file.isFile()) {

Review Comment:
   `assert file.isFile()`





> Due to default value of gpg.passphraseServerId, bestPractices=true will 
> always fail
> ---
>
> Key: MGPG-125
> URL: https://issues.apache.org/jira/browse/MGPG-125
> Project: Maven GPG Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
>Reporter: Benjamin Marwell
>Assignee: Tamas Cservenak
>Priority: Critical
> Fix For: 3.2.4
>
>
> Running gpg-plugin with best practices from the CLI, it will always fail 
> since gpg.passphraseServerId does have a default value set.
> See:
> https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140
> CC [~cstamas]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail

2024-04-12 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836465#comment-17836465
 ] 

ASF GitHub Bot commented on MGPG-125:
-

slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562198479


##
src/it/sign-release-best-practices-fail/pom.xml:
##
@@ -0,0 +1,103 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.its.gpg.sr
+  test
+  1.0
+  jar
+
+  
+Tests the installation of a simple release JAR with an attached artifact 
and its signatures.
+  
+
+  
+true
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-compiler-plugin
+2.0.2

Review Comment:
   ?
   we can use `@version.maven-compiler-plugin@` properties for plugins versions 
are defined in parent





> Due to default value of gpg.passphraseServerId, bestPractices=true will 
> always fail
> ---
>
> Key: MGPG-125
> URL: https://issues.apache.org/jira/browse/MGPG-125
> Project: Maven GPG Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
>Reporter: Benjamin Marwell
>Assignee: Tamas Cservenak
>Priority: Critical
> Fix For: 3.2.4
>
>
> Running gpg-plugin with best practices from the CLI, it will always fail 
> since gpg.passphraseServerId does have a default value set.
> See:
> https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140
> CC [~cstamas]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail

2024-04-12 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836466#comment-17836466
 ] 

ASF GitHub Bot commented on MGPG-125:
-

slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562199284


##
src/it/sign-release-best-practices-fail/pom.xml:
##
@@ -0,0 +1,103 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.its.gpg.sr
+  test
+  1.0
+  jar
+
+  
+Tests the installation of a simple release JAR with an attached artifact 
and its signatures.
+  
+
+  
+true
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-compiler-plugin
+2.0.2
+  
+  
+org.apache.maven.plugins
+maven-gpg-plugin
+@project.version@
+
+  
+sign-artifacts
+
+  sign
+
+  
+
+
+  true
+   Due to default value of gpg.passphraseServerId, bestPractices=true will 
> always fail
> ---
>
> Key: MGPG-125
> URL: https://issues.apache.org/jira/browse/MGPG-125
> Project: Maven GPG Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
>Reporter: Benjamin Marwell
>Assignee: Tamas Cservenak
>Priority: Critical
> Fix For: 3.2.4
>
>
> Running gpg-plugin with best practices from the CLI, it will always fail 
> since gpg.passphraseServerId does have a default value set.
> See:
> https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140
> CC [~cstamas]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)