[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764008#comment-17764008 ] ASF GitHub Bot commented on MJAVADOC-642: - hgschmie merged PR #238: URL: https://github.com/apache/maven-javadoc-plugin/pull/238 > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Assignee: Henning Schmiedehausen >Priority: Major > Fix For: 3.6.0 > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763464#comment-17763464 ] ASF GitHub Bot commented on MJAVADOC-642: - hgschmie opened a new pull request, #238: URL: https://github.com/apache/maven-javadoc-plugin/pull/238 Turns out that `mvn deploy` and `mvn clean deploy` do different things with settings. Explicitly add settings to the test-javadoc-test-plugin config, otherwise it throws a NPE when running `mvn deploy`. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Assignee: Henning Schmiedehausen >Priority: Major > Fix For: 3.6.0 > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763358#comment-17763358 ] ASF GitHub Bot commented on MJAVADOC-642: - hgschmie merged PR #232: URL: https://github.com/apache/maven-javadoc-plugin/pull/232 > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Priority: Major > Fix For: wontfix-candidate, waiting-for-feedback > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763284#comment-17763284
]
ASF GitHub Bot commented on MJAVADOC-642:
-
hgschmie commented on code in PR #232:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/232#discussion_r1320419121
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -334,9 +334,11 @@ public abstract class AbstractJavadocMojo extends
AbstractMojo {
/**
* Specify if the Javadoc should operate in offline mode.
+ *
+ * @since 3.6.0
*/
-@Parameter(defaultValue = "${settings.offline}", required = true, readonly
= true)
-private boolean isOffline;
+@Parameter(property = "maven.javadoc.offline", defaultValue = "false")
+private boolean offline;
Review Comment:
My personal assumption for all maven plugins is that every plugin implicitly
respects it (and I am allowed to get upset if they don't) because it is a tool
wide facility).
I added some comments to this option and the one that it affects (``).
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: wontfix-candidate, waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763269#comment-17763269
]
ASF GitHub Bot commented on MJAVADOC-642:
-
slawekjaranowski commented on code in PR #232:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/232#discussion_r1320360974
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -334,9 +334,11 @@ public abstract class AbstractJavadocMojo extends
AbstractMojo {
/**
* Specify if the Javadoc should operate in offline mode.
+ *
+ * @since 3.6.0
*/
-@Parameter(defaultValue = "${settings.offline}", required = true, readonly
= true)
-private boolean isOffline;
+@Parameter(property = "maven.javadoc.offline", defaultValue = "false")
+private boolean offline;
Review Comment:
We can add information that Maven offline mode `-or, --offline` is also
respected and has a higher priority
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: wontfix-candidate, waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763268#comment-17763268
]
Henning Schmiedehausen commented on MJAVADOC-642:
-
as a side note, while {{}} works, it was never documented (it was
intended for internal use). The next release (3.6.0) will expose a
{{}} configuration setting that serves the same purpose. You may need
to fix your build.
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: wontfix-candidate, waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763263#comment-17763263
]
ASF GitHub Bot commented on MJAVADOC-642:
-
hgschmie commented on code in PR #232:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/232#discussion_r1320341278
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -334,9 +334,11 @@ public abstract class AbstractJavadocMojo extends
AbstractMojo {
/**
* Specify if the Javadoc should operate in offline mode.
+ *
+ * @since 3.5.1
*/
-@Parameter(defaultValue = "${settings.offline}", required = true, readonly
= true)
-private boolean isOffline;
+@Parameter(alias = "isOffline", property = "maven.javadoc.offline",
defaultValue = "false")
+private boolean offline;
Review Comment:
ok.
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: wontfix-candidate, waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763262#comment-17763262 ] ASF GitHub Bot commented on MJAVADOC-642: - hgschmie commented on code in PR #232: URL: https://github.com/apache/maven-javadoc-plugin/pull/232#discussion_r1320340258 ## src/it/projects/MJAVADOC-642/invoker.properties: ## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +invoker.goals= package +invoker.java.version = 9+ Review Comment: oh, c'n'p error. :-) > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Priority: Major > Fix For: wontfix-candidate, waiting-for-feedback > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763261#comment-17763261
]
ASF GitHub Bot commented on MJAVADOC-642:
-
slawekjaranowski commented on code in PR #232:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/232#discussion_r1320331922
##
src/it/projects/MJAVADOC-642/pom.xml:
##
@@ -0,0 +1,54 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.apache.maven.plugins.javadoc.it
+mjavadoc642
+1.0-SNAPSHOT
+jar
+
+https://issues.apache.org/jira/browse/MJAVADOC-642
+
+
+UTF-8
+
+
+
+
+
+maven-javadoc-plugin
+@project.version@
+
+
+javadoc
+
+jar
+
+package
+
+true
+${project.build.targetJdk}
Review Comment:
`project.build.targetJdk` is not defined
we can skip configuration of this parameter - and test can be executed on
JDK 8
##
src/it/projects/MJAVADOC-642/invoker.properties:
##
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals= package
+invoker.java.version = 9+
Review Comment:
I hope we can also execute test on JDK 8
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -334,9 +334,11 @@ public abstract class AbstractJavadocMojo extends
AbstractMojo {
/**
* Specify if the Javadoc should operate in offline mode.
+ *
+ * @since 3.5.1
*/
-@Parameter(defaultValue = "${settings.offline}", required = true, readonly
= true)
-private boolean isOffline;
+@Parameter(alias = "isOffline", property = "maven.javadoc.offline",
defaultValue = "false")
+private boolean offline;
Review Comment:
as old version was readonly, internal so was not documented - we need not
try to preserve old filed name
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: wontfix-candidate, waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763247#comment-17763247 ] ASF GitHub Bot commented on MJAVADOC-642: - hgschmie opened a new pull request, #232: URL: https://github.com/apache/maven-javadoc-plugin/pull/232 expose the offline flag as a property (and a setting). Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Priority: Major > Fix For: wontfix-candidate, waiting-for-feedback > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763229#comment-17763229
]
Henning Schmiedehausen commented on MJAVADOC-642:
-
The explanation above is wrong.
The "isOffline" setting is controlled by "${settings.offline}", which is part
of the maven internal settings. It can not be controlled by
{{-Dsettings.offline=true}} but by passing the {{-o}} parameter to maven.
Neither setting maven.javadoc.isOffline nor setting settings.offline on the
command line has any effect.
Currently, the only way to run the javadoc plugin in offline mode is to pass
the {{-o}} flag to maven itself. I will add a property setting in a PR and
then close this issue as fixed.
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: wontfix-candidate, waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340121#comment-17340121
]
Benjamin Marwell commented on MJAVADOC-642:
---
Here is a sampel configuration:
{code:xml}
http://docs.oracle.com/javase/7/docs/api
http://static.netty.io/3.5/api
http://google-guice.googlecode.com/git/javadoc
http://fasterxml.github.com/jackson-databind/javadoc/2.0.4
https://developers.google.com/protocol-buffers/docs/reference/java
true
true
true
true
true
{code}
Output behind proxy:
{code}
[WARN] Error fetching link:
https://github.com/javaee/jaxb-spec/jaxb-api/apidocs. Ignored it.
[WARN] Error fetching link: http://www.slf4j.org/apidocs. Ignored it.
[WARN] Error fetching link: http://findbugs.sourceforge.net/apidocs. Ignored it.
[WARN] Error fetching link: http://cdi-spec.org/apidocs. Ignored it.
[WARN] Error fetching link: http://www.jqno.nl/equalsverifier/apidocs. Ignored
it.
[WARN] Error fetching link: https://checkerframework.org/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: http://hamcrest.org/JavaHamcrest/apidocs. Ignored
it.
[WARN] Error fetching link: https://github.com/mockito/mockito/apidocs. Ignored
it.
{code}
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058207#comment-17058207
]
Michael Osipov commented on MJAVADOC-642:
-
Can you please provide the debug output for your plugin invocation as well as
the {{@}} files generated?
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057960#comment-17057960 ] Michael Osipov commented on MJAVADOC-642: - OK, I need to look at this. > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057892#comment-17057892 ] Thomas Cunningham commented on MJAVADOC-642: I'm not seeing -Dsettings.offline work. I'm trying to set that to true, and it doesn't seem like it's being respected. If I hard code true into my configuration, that works, but setting -Dsettings.offLine=true doesn't seem to work. Here's a pom.xml example that I'm working with : [https://github.com/apache/camel/blob/master/core/camel-util/pom.xml] > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056099#comment-17056099
]
Michael Osipov commented on MJAVADOC-642:
-
There is your problem. The documentation is bad/incomplete and you did pass
{{-Dmaven.javadoc.isOffline}}. The property is {{-Dsettings.offline}}. Please
retry.
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056025#comment-17056025 ] Thomas Cunningham commented on MJAVADOC-642: It's here, but I'm not sure how to set it [https://github.com/apache/maven-javadoc-plugin/blob/master/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L342-L343] > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Priority: Major > Fix For: waiting-for-feedback > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055957#comment-17055957
]
Michael Osipov commented on MJAVADOC-642:
-
It is only mentioned in {{}}, but there is no reference. That seems odd.
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055908#comment-17055908 ] Thomas Cunningham commented on MJAVADOC-642: [~michael-o] I found it mentioned here : [https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html] > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Priority: Major > Fix For: waiting-for-feedback > > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[ https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055362#comment-17055362 ] Michael Osipov commented on MJAVADOC-642: - I can't find this property. Can you show me? > Setting maven.javadoc.isoffline seems to have no effect > --- > > Key: MJAVADOC-642 > URL: https://issues.apache.org/jira/browse/MJAVADOC-642 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: jar >Affects Versions: 3.1.1 >Reporter: Thomas Cunningham >Priority: Major > > I'm trying to work around MJAVADOC-641 and the proxy issues that we are > having, and I'd like to set isOffline to true. I tried to do this my > setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't > seem to take effect. Setting isOffline to true within the > allows my build to succeed. > Am I using the wrong command line property for isOffline? -- This message was sent by Atlassian Jira (v8.3.4#803005)
