[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772196#comment-17772196 ] ASF GitHub Bot commented on MNG-7864: - vivkong commented on PR #1239: URL: https://github.com/apache/maven/pull/1239#issuecomment-1748795247 Closing this as https://github.com/apache/maven/pull/1266 has been merged. Thanks. > Fix the S390x to use IT branches > > > Key: MNG-7864 > URL: https://issues.apache.org/jira/browse/MNG-7864 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Priority: Major > > When testing a PR, the maven-integration-testing branch with the same name > should be used instead of master if it exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772197#comment-17772197 ] ASF GitHub Bot commented on MNG-7864: - vivkong closed pull request #1239: [MNG-7864] Fix the S390x to use IT branches URL: https://github.com/apache/maven/pull/1239 > Fix the S390x to use IT branches > > > Key: MNG-7864 > URL: https://issues.apache.org/jira/browse/MNG-7864 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Priority: Major > > When testing a PR, the maven-integration-testing branch with the same name > should be used instead of master if it exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769148#comment-17769148
]
ASF GitHub Bot commented on MNG-7864:
-
vivkong commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1337113488
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
+ }
+ stages {
+stage("Build Maven Core") {
+ steps {
+withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }",
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {
Review Comment:
Thanks @olamy. Does this mean I can close this PR for
`Jenkinsfile.s390x.its` as PR checks won't run on s390x?
I will create another PR to bring back `Jenkinsfile.s390x`.
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768956#comment-17768956
]
ASF GitHub Bot commented on MNG-7864:
-
olamy commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1336530217
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
+ }
+ stages {
+stage("Build Maven Core") {
+ steps {
+withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }",
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {
Review Comment:
the job here has been configured to run only on `master`
https://ci-maven.apache.org/job/Maven/job/Maven%20Core%20s390x/
by the way gh checks were disable.
so this job was not doing any spam except the person registered to received
emails. And he asked to do so.
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768929#comment-17768929 ] ASF GitHub Bot commented on MNG-7864: - slawekjaranowski commented on PR #1239: URL: https://github.com/apache/maven/pull/1239#issuecomment-1734541890 Please look https://github.com/apache/maven/pull/1263 I select branch name for ITs based on branch. used for build or PR. There is possible that branch will be not exist in ITs so you need a fallback to checkout master branch. > Fix the S390x to use IT branches > > > Key: MNG-7864 > URL: https://issues.apache.org/jira/browse/MNG-7864 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Priority: Major > > When testing a PR, the maven-integration-testing branch with the same name > should be used instead of master if it exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768752#comment-17768752
]
ASF GitHub Bot commented on MNG-7864:
-
elharo commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1336075881
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
+ }
+ stages {
+stage("Build Maven Core") {
+ steps {
+withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }",
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {
Review Comment:
I don't have any particular opinion about that. As long as tests are
passing, I'm OK with whatever setup works best. I just want to avoid the
situation we got into earlier where the S390x build was broken and blocking
work, and no one was addressing it. I don't think anyone here not from IBM has
the resources to debug an S390 specific problem. We have enough trouble
figuring out what's going on when a test fails only on Windows. I'm also leery
of IT failures that happen because test setup or verification isn't configured
properly for some particular platform, rather than an actual bug in the maven
product. I think we've all burned a lot of hours debugging those kinds of
"failures".
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768736#comment-17768736
]
ASF GitHub Bot commented on MNG-7864:
-
vivkong commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1336012487
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
+ }
+ stages {
+stage("Build Maven Core") {
+ steps {
+withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }",
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {
Review Comment:
@elharo, your thoughts on adding `Jenkinsfile.s390x` back and disable PR
checks on s390x? (Please see
https://github.com/apache/maven/pull/1239#issuecomment-1719681339).
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765945#comment-17765945
]
ASF GitHub Bot commented on MNG-7864:
-
elharo commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1327945304
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
+ }
+ stages {
+stage("Build Maven Core") {
+ steps {
+withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }",
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {
Review Comment:
Is 3.6.3 what we're really using? Looks like other ITs are somewhere in 3.8
right now
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765751#comment-17765751 ] ASF GitHub Bot commented on MNG-7864: - vivkong commented on PR #1239: URL: https://github.com/apache/maven/pull/1239#issuecomment-1721642457 > The problem is really with PRs that use a custom IT branch, so nightly builds for the master branch would be fine with me. Thanks @gnodet. In that case, I will close this PR and create a new one to reinstate the previous Jenkinsfile.s390x file and ask for help with changing the Jenkins setup (disable PR checks). > Fix the S390x to use IT branches > > > Key: MNG-7864 > URL: https://issues.apache.org/jira/browse/MNG-7864 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Priority: Major > > When testing a PR, the maven-integration-testing branch with the same name > should be used instead of master if it exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765255#comment-17765255 ] ASF GitHub Bot commented on MNG-7864: - gnodet commented on PR #1239: URL: https://github.com/apache/maven/pull/1239#issuecomment-1719769083 > Thanks @ elharo. It looks like for PR checks on Jenkins, the current Jenkins build setup would always run integration test with [master](https://github.com/apache/maven/blob/master/Jenkinsfile#L88) branch of [maven-integration-testing](https://github.com/apache/maven-integration-testing.git) on amd64 (for example, see https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/view/change-requests/job/PR-1241/1/). This same setup was done for s390x before the Jenkinsfile.s390x file got removed. > > May I suggest that we only run nightly builds for s390x against maven and maven-integration-testing repos once all the changes have been committed/settled. Probably simplest will be to reinstate the Jenkinsfile.s390x file and disable PR checks in https://ci-maven.apache.org/job/Maven/job/Maven%20Core%20s390x/? Let me know your thoughts. The problem is really with PRs that use a custom IT branch, so nightly builds for the master branch would be fine with me. > Fix the S390x to use IT branches > > > Key: MNG-7864 > URL: https://issues.apache.org/jira/browse/MNG-7864 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Priority: Major > > When testing a PR, the maven-integration-testing branch with the same name > should be used instead of master if it exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765232#comment-17765232 ] ASF GitHub Bot commented on MNG-7864: - vivkong commented on PR #1239: URL: https://github.com/apache/maven/pull/1239#issuecomment-1719681339 Thanks @ elharo. It looks like for PR checks on Jenkins, the current Jenkins build setup would always run integration test with [master](https://github.com/apache/maven/blob/master/Jenkinsfile#L88) branch of [maven-integration-testing](https://github.com/apache/maven-integration-testing.git) on amd64 (for example, see https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/view/change-requests/job/PR-1241/1/). This same setup was done for s390x before the Jenkinsfile.s390x file got removed. May I suggest that we only run nightly builds for s390x against maven and maven-integration-testing repos once all the changes have been committed/settled. Probably simplest will be to reinstate the Jenkinsfile.s390x file and disable PR checks in https://ci-maven.apache.org/job/Maven/job/Maven%20Core%20s390x/? Let me know your thoughts. > Fix the S390x to use IT branches > > > Key: MNG-7864 > URL: https://issues.apache.org/jira/browse/MNG-7864 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Priority: Major > > When testing a PR, the maven-integration-testing branch with the same name > should be used instead of master if it exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765150#comment-17765150
]
ASF GitHub Bot commented on MNG-7864:
-
vivkong commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1325867907
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
I'm referring to this commit
(https://github.com/apache/maven/commit/b3e3972988df7b3dde26ccd4e48b3e6b97d89ad6,
PR: https://github.com/apache/maven/pull/355 ) that added the original
[Jenkinsfile.its](https://github.com/apache/maven/blob/master/Jenkinsfile.its).
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764894#comment-17764894
]
ASF GitHub Bot commented on MNG-7864:
-
olamy commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1325129692
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
As far as I can see with this commit
https://github.com/apache/maven/commit/bcfea094c00c7064bb654717599bc1c7fc842ecd
the file has been by @kun-lu20
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764646#comment-17764646
]
ASF GitHub Bot commented on MNG-7864:
-
vivkong commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1324457757
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
I see the existing Jenkinsfile.its was added by @olamy. @olamy can you
please help answer this - how does the ITS_BRANCH variable get computed? And
how is integration test triggered for Jenkins builds? Thanks.
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764314#comment-17764314
]
ASF GitHub Bot commented on MNG-7864:
-
gnodet commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1323371796
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
I did not imply to go through GitHub actions, but maybe the shell script
from the GitHub action could be reused somehow in the Jenkins pipeline in order
to find the correct remote repository + branch to use.
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764156#comment-17764156
]
ASF GitHub Bot commented on MNG-7864:
-
vivkong commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1322968946
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
Thank you for your review. I used the existing
[Jenkinsfile.its](https://github.com/apache/maven/blob/master/Jenkinsfile.its#L28)
file as a reference and assumed the parameter is set when the Jenkins build is
kicked off (as I cannot access the Jenkins configuration). I don't expect
s390x builds to be run with Github actions as there's no s390x support for
Github actions at this moment. How does the Jenkins build get triggered with
each PR? I cannot find information on this and would appreciate any pointers.
Thanks.
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763959#comment-17763959
]
ASF GitHub Bot commented on MNG-7864:
-
gnodet commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1322129967
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
What's the actual value for this parameter ? It should be computed, but I
don't really see any computation in this file. See the [computation for GitHub
actions](https://github.com/apache/maven/blob/master/.github/workflows/maven.yml#L76-L99).
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763958#comment-17763958
]
ASF GitHub Bot commented on MNG-7864:
-
gnodet commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1322129967
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
Review Comment:
What's the actual value for this parameter ? It should be computed, but I
don't really see any computation in this file.
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763900#comment-17763900 ] ASF GitHub Bot commented on MNG-7864: - vivkong opened a new pull request, #1239: URL: https://github.com/apache/maven/pull/1239 JIRA issue: https://issues.apache.org/jira/browse/MNG-7864 This should allow integration testing on s390x to use the appropriate IT branches. @elharo @gnodet would you mind reviewing this? Thanks! I appreciate any help to get it set up in Jenkins so s390x builds can be run again. --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Fix the S390x to use IT branches > > > Key: MNG-7864 > URL: https://issues.apache.org/jira/browse/MNG-7864 > Project: Maven > Issue Type: Bug >Reporter: Guillaume Nodet >Priority: Major > > When testing a PR, the maven-integration-testing branch with the same name > should be used instead of master if it exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
