[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778378#comment-17778378 ] ASF GitHub Bot commented on MPIR-431: - elharo closed pull request #53: Bump commons-io from 1.0 to 2.7 in /src/it/MPIR-431 URL: https://github.com/apache/maven-project-info-reports-plugin/pull/53 > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778379#comment-17778379 ] ASF GitHub Bot commented on MPIR-431: - dependabot[bot] commented on PR #53: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/53#issuecomment-1774096012 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728966#comment-17728966 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #53: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/53#issuecomment-1574922233 @dependabot rebase > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728046#comment-17728046 ] ASF GitHub Bot commented on MPIR-431: - pzygielo commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1570519734 Thanks to all checking this case. I a38c46bd149aa0cae39a5abdb5d34106275cb3db prevents breaking the build/NPEx - I like it :grin: > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728030#comment-17728030 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1570453498 @belingueres This is my proposal: https://github.com/apache/maven-project-info-reports-plugin/commit/a38c46bd149aa0cae39a5abdb5d34106275cb3db No fuzz, straight forward. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728016#comment-17728016 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1570407832 > I'll try to work on a PR if not too complex. > > > > We could fix the error by taking the same scope than its parent dependency AND logging a warning. It is warranted to eventually succeed since direct dependencies must have a correct scope (otherwise the project's pom.xml won't pass the validation phase) > > >  > > > > > > Sounds good. Do you want to work on a PR? > > I'll give it a try Don't waste your time, if it takes more than one hour. Before the faulty method is called we can test the scope for validity and log a warning that this artifact is ignored from the global calculation. Done. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728004#comment-17728004 ] ASF GitHub Bot commented on MPIR-431: - belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1570379127 I'll try to work on a PR if not too complex. > > We could fix the error by taking the same scope than its parent dependency AND logging a warning. It is warranted to eventually succeed since direct dependencies must have a correct scope (otherwise the project's pom.xml won't pass the validation phase) > >  > > Sounds good. Do you want to work on a PR? I'll give it a try > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727852#comment-17727852 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569717013 Patch works:  > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727846#comment-17727846 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569671450 Idiotlike approach: ``` diff --git a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java index d4c6b84..7f2694b 100644 - > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727829#comment-17727829 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569619457 > We could fix the error by taking the same scope than its parent dependency AND logging a warning. It is warranted to eventually succeed since direct dependencies must have a correct scope (otherwise the project's pom.xml won't pass the validation phase) > >  Sounds good. Do you want to work on a PR? > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1772#comment-1772 ] ASF GitHub Bot commented on MPIR-431: - belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569452467 We could fix the error by taking the same scope than its parent dependency AND logging a warning. It is warranted to eventually succeed since direct dependencies must have a correct scope (otherwise the project's pom.xml won't pass the validation phase)  > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727700#comment-17727700 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569075681 OK, there is no bug, but this POM is just broken: https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-remote-driver/4.9.1/selenium-remote-driver-4.9.1.pom They messed up scope with classifier. There is nothing to fix from our end. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727698#comment-17727698 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569065172 So it was before from my PoV:  we simply did not know. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727693#comment-17727693 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569045492 Trying 3.4.5-SNAPSHOT which uses maven-dependency-tree 3.2.1 which does not have this problem, but gives me: ``` Caused by: java.lang.NullPointerException at org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer$TotalCell.addTotal (DependenciesRenderer.java:1391) at org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer$TotalCell.incrementTotal (DependenciesRenderer.java:1365) at org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderSectionDependencyFileDetails (DependenciesRenderer.java:539) at org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderBody (DependenciesRenderer.java:229) ``` well...  > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727687#comment-17727687 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569006400 Ran with the old version. Something is wrong because the classifer is shown as scope. Non-sense. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727683#comment-17727683 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1568995421 This seems to be the problem: ``` [INFO] | +- io.netty:netty-transport-native-epoll:jar:4.1.91.Final:linux-x86_64 [INFO] | +- io.netty:netty-transport-native-kqueue:jar:4.1.91.Final:osx-x86_64 ``` > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727678#comment-17727678 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1568983400 @pzygielo Thanks for the heads up. Can you please file a JIRA and maybe a test case? I wonder what we have missed. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727671#comment-17727671 ] ASF GitHub Bot commented on MPIR-431: - pzygielo commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1568972249 Just FYI: With this change I'm getting: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project jasmine-maven-plugin: Error generating maven-project-info-reports-plugin:3.4.4-SNAPSHOT:dependencies report: Cannot invoke "org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer$TotalCell$SummaryTableRowOrder.addTotal(org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer$TotalCell, long)" because "currentRow" is null ``` ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project jasmine-maven-plugin: Error generating maven-project-info-reports-plugin:3.4.4-SNAPSHOT:dependencies report: Cannot invoke "org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer$TotalCell$SummaryTableRowOrder.addTotal(org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer$TotalCell, long)" because "currentRow" is null -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project jasmine-maven-plugin: Error generating maven-project-info-reports-plugin:3.4.4-SNAPSHOT:dependencies report at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:375) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293) at org.apache.maven.cli.MavenCli.main (MavenCli.java:196) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:568) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:568) at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:53) at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:152) at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:76) Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating maven-project-info-reports-plugin:3.4.4-SNAPSHOT:dependencies report at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:153) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoEx
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726623#comment-17726623 ] ASF GitHub Bot commented on MPIR-431: - dependabot[bot] opened a new pull request, #53: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/53 Bumps commons-io from 1.0 to 2.7. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-project-info-reports-plugin/network/alerts). > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.4.4 > > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726621#comment-17726621 ] ASF GitHub Bot commented on MPIR-431: - asfgit closed pull request #47: [MPIR-431] Dependency file details section: segregate Java version URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47 > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724729#comment-17724729
]
ASF GitHub Bot commented on MPIR-431:
-
belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199875668
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -588,14 +596,7 @@ private void renderSectionDependencyFileDetails() {
}
} else {
tableRow(hasSealed, new String[] {
-artifactFile.getName(),
-fileLengthDecimalFormat.format(artifactFile.length()),
-"",
-"",
-"",
-"",
-"",
-""
+artifactFile.getName(),
fileLengthDecimalFormat.format(artifactFile.length()), "", "", "", "", ""
Review Comment:
I'll fix it
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -674,7 +750,7 @@ private void tableRow(boolean fullRow, String[] content) {
private void createExceptionInfoTableRow(Artifact artifact, File
artifactFile, Exception e, boolean hasSealed) {
tableRow(
hasSealed,
-new String[] {artifact.getId(),
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", "", ""});
+new String[] {artifact.getId(),
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", ""});
Review Comment:
I'll fix it
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724712#comment-17724712
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199821656
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -607,25 +608,76 @@ private void renderSectionDependencyFileDetails() {
justification[0] = Sink.JUSTIFY_RIGHT;
justification[6] = Sink.JUSTIFY_RIGHT;
-for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
-if (totaldeps.getTotal(i) > 0) {
-tableRow(hasSealed, new String[] {
-totaldeps.getTotalString(i),
-totaldepsize.getTotalString(i),
-totalentries.getTotalString(i),
-totalclasses.getTotalString(i),
-totalpackages.getTotalString(i),
-(i < 0) ? javaVersionFormat.format(new Object[]
{highestJavaVersion}) : "",
-totalDebugInformation.getTotalString(i),
-totalsealed.getTotalString(i)
-});
+// calculate rowspan attr
+int rowspan = computeRowspan(totaldeps);
+
+if (rowspan > 1) {
+boolean insertRowspanAttr = false;
+int column = 5; // Java Version's column
+for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
+if (totaldeps.getTotal(i) > 0) {
+boolean alreadyInsertedRowspanAttr = insertRowspanAttr &&
(0 < i && i < 4);
+insertRowspanAttr = (0 <= i && i < 4);
+justification[column] = (insertRowspanAttr &&
alreadyInsertedRowspanAttr)
+? justification[column + 1]
+: Sink.JUSTIFY_CENTER;
+tableRowWithRowspan(
+hasSealed, insertRowspanAttr,
alreadyInsertedRowspanAttr, column, rowspan, new String[] {
+totaldeps.getTotalString(i),
+totaldepsize.getTotalString(i),
+totalentries.getTotalString(i),
+totalclasses.getTotalString(i),
+totalpackages.getTotalString(i),
+formatMaxVersionForScope(i,
highestTestJavaVersion, highestNonTestJavaVersion),
+totalDebugInformation.getTotalString(i),
+totalsealed.getTotalString(i)
+});
+}
+}
+} else {
+for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
+if (totaldeps.getTotal(i) > 0) {
+tableRow(hasSealed, new String[] {
+totaldeps.getTotalString(i),
+totaldepsize.getTotalString(i),
+totalentries.getTotalString(i),
+totalclasses.getTotalString(i),
+totalpackages.getTotalString(i),
+formatMaxVersionForScope(i, highestTestJavaVersion,
highestNonTestJavaVersion),
+totalDebugInformation.getTotalString(i),
+totalsealed.getTotalString(i)
+});
+}
}
}
endTable();
endSection();
}
+private int computeRowspan(TotalCell totaldeps) {
+int rowspan = 0;
+for (int i = 0; i < TotalCell.SCOPES_COUNT - 1; i++) {
+if (totaldeps.getTotal(i) > 0) {
+rowspan++;
+}
+}
+return rowspan;
+}
+
+private String formatMaxVersionForScope(
Review Comment:
Let's make this `formatMaxJavaVersionForScope`
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724710#comment-17724710
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199820872
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -674,7 +750,7 @@ private void tableRow(boolean fullRow, String[] content) {
private void createExceptionInfoTableRow(Artifact artifact, File
artifactFile, Exception e, boolean hasSealed) {
tableRow(
hasSealed,
-new String[] {artifact.getId(),
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", "", ""});
+new String[] {artifact.getId(),
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", ""});
Review Comment:
Here as well
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724709#comment-17724709
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199820627
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -588,14 +596,7 @@ private void renderSectionDependencyFileDetails() {
}
} else {
tableRow(hasSealed, new String[] {
-artifactFile.getName(),
-fileLengthDecimalFormat.format(artifactFile.length()),
-"",
-"",
-"",
-"",
-"",
-""
+artifactFile.getName(),
fileLengthDecimalFormat.format(artifactFile.length()), "", "", "", "", ""
Review Comment:
Why is one column gone here?
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721978#comment-17721978 ] ASF GitHub Bot commented on MPIR-431: - belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1545008672 Yes this is the kind of conclusions I'd like to derive about the jdk versions by looking at the report, and just separating test scoped deps into its own column I agree it is too simplistic, but I think it offers more value than having only one column for all scopes. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721965#comment-17721965
]
ASF GitHub Bot commented on MPIR-431:
-
belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191817536
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I'll create a separate issue for this. However the jdk detection seems to be
more complex. Currently org.codehaus.plexus:plexus-utils:3.5.0 dependency does
not detect any jdk details.
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721883#comment-17721883
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191606276
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
Look at
https://github.com/apache/maven-shared-jar/blob/3cd1e4d7060bba0b378c2f3bcb5bd00037b299dc/src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java#L92-L156.
If classes are corrupt or JAR contains only resources that value would be
`null`. Though this we can test with an minimal non-class JAR.
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721881#comment-17721881
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191590748
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
Ha, you are right! Can we move to a separate issue? I think the wiser step
would be a change from `double` to `Double` and use `null` truly.
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721877#comment-17721877
]
ASF GitHub Bot commented on MPIR-431:
-
belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191582040
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I think that was a bug. If all dependencies have jarDetails.getJdkRevision()
== null, then the summary column would print "0.0" instead of "-". The same
goes for test scope dependencies (it might be the case that there are no test
scoped dependencies at all). Perhaps this is clearer: "if (version > 0.0d) "
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721875#comment-17721875 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1544525489 I think I do understand the objective behind this change, though I am not really happy with the output. I have changed the `full-pom` IT to contain a runtime and provided dependency, now lets look at the output:  It doesn't look right, it says that 19 dependencies requrie Java 1.8 to run, which is not correct and the same again with 1.5, but when tests are run they do not require 1.5, they do require 1.8 because the max version is necessary. I understand the opposite case where your code and deps need 1.8, but test deps are on 11. I don't think that the information is properly visualized here avoid misunderstandings. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721866#comment-17721866
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191545277
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I don't understand this. Why wasn't this required before?
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721030#comment-17721030 ] Michael Osipov commented on MPIR-431: - OK, let me crunch on that to understand your idea. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721018#comment-17721018 ] Gabriel Belingueres commented on MPIR-431: -- I don't know if I understand the question, but the value is computed as before: it returns the max jdk version value found in all dependencies), except that now the test scoped dependencies won't be considered for the "Java version" summary column, instead it will be calculated as before (max jdk version value) but summarized in a new column "Test java version". I think it makes the report clearer and provide more useful information since the test scoped dependencies provide less value for a user of a module. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720326#comment-17720326 ] Michael Osipov commented on MPIR-431: - OK, this I understand, but which value does this have for runtime? MPIR generates information after the deployment of a module. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720323#comment-17720323 ] Gabriel Belingueres commented on MPIR-431: -- Sometimes you want to target a specific runtime java version (let's say 1.7), but use a test dependency that requires a higher java version (let's say 1.8). The actual unique column with the max version is misleading because it seems that the whole project targets 1.8, when in reality it's 1.7 the required version to execute it. That's why I propose to add this one column for test only dependencies. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720300#comment-17720300 ] Michael Osipov commented on MPIR-431: - I don't understand the explanation. Building does not necessarily require testing, you can disable it. >From a dep perspective the build version does not matter, no? The Target >runtime version is important. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720249#comment-17720249 ] ASF GitHub Bot commented on MPIR-431: - belingueres opened a new pull request, #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47 column into execution and test versions Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPIR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPIR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MPIR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
