[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates"
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852133#comment-17852133 ] ASF GitHub Bot commented on MPIR-451: - asfgit closed pull request #67: [MPIR-451] Rename "Dependency Information" to "Maven Coordinates" URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67 > Rename "Dependency Information" to "Maven Coordinates" > -- > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates"
[
https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851410#comment-17851410
]
ASF GitHub Bot commented on MPIR-451:
-
michael-o commented on code in PR #67:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/67#discussion_r1623401367
##
src/site/apt/index.apt.vm:
##
@@ -44,8 +44,8 @@ ${project.name}
*
{{{./dependency-convergence-mojo.html}project-info-reports:dependency-convergence}}
is used to generate the
Project Dependency Convergence report for (reactor) builds.
- * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is
used to generate code snippets to
- be added to build tools.
+ * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is
used to generate code snippets
Review Comment:
This goes throughout all bulletpoints. I'd leave as is and do this in
another PR.
> Rename "Dependency Information" to "Maven Coordinates"
> --
>
> Key: MPIR-451
> URL: https://issues.apache.org/jira/browse/MPIR-451
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
>
> From a thread on commons-math where I noticed I was unable to find the Maven
> coordinates for the project on the project's website:
> The only way to get to that page is scroll about two thirds of the way down a
> sidebar and click one of the four links that mention "dependencies" that
> seems as likely to bring you to a list of commons-math's own dependencies
> rather than how to add this project as a dependency. I'm a Maven comitter
> who's spent way more time in the depths of Maven Project website generation
> than 99.9% of Java programmers and I still couldn't find this the first time
> I looked for it. That's de facto evidence that this information is not easy
> to find.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates"
[
https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851408#comment-17851408
]
ASF GitHub Bot commented on MPIR-451:
-
elharo commented on code in PR #67:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/67#discussion_r1623397208
##
src/main/resources/project-info-reports_fr.properties:
##
@@ -117,8 +117,8 @@ report.dependency-convergence.stats.readyrelease.success
= Succ\u00e8s
report.dependency-convergence.stats.snapshots = Nombre
d'artefacts SNAPSHOT (NOS)\u202f:
report.dependency-convergence.stats.modules= Nombre de
sous-projets\u202f:
report.dependency-convergence.title=
R\u00e9action de la convergence des d\u00e9pendances
-report.dependency-info.name=
Informations de d\u00e9pendance
-report.dependency-info.title =
Informations de d\u00e9pendance
+report.dependency-info.name=
Coordonnu00e9es de Maven
Review Comment:
I think you're missing a backslash before \u00e9 here and in the next line
##
src/site/apt/index.apt.vm:
##
@@ -79,6 +79,17 @@ ${project.name}
* {{{./summary-mojo.html}project-info-reports:summary}} is used to generate
the Project Summary report.
+* Upcoming Incompatibility Notice
+
+ With the next major version (4.0) mojos and output filenames will change for
consistency alignment
Review Comment:
period at end
##
src/site/apt/index.apt.vm:
##
@@ -44,8 +44,8 @@ ${project.name}
*
{{{./dependency-convergence-mojo.html}project-info-reports:dependency-convergence}}
is used to generate the
Project Dependency Convergence report for (reactor) builds.
- * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is
used to generate code snippets to
- be added to build tools.
+ * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is
used to generate code snippets
Review Comment:
is used to generate --> generates
##
src/site/apt/index.apt.vm:
##
@@ -79,6 +79,17 @@ ${project.name}
* {{{./summary-mojo.html}project-info-reports:summary}} is used to generate
the Project Summary report.
+* Upcoming Incompatibility Notice
+
+ With the next major version (4.0) mojos and output filenames will change for
consistency alignment
+ To make you aware of that, see the following table for the upcoming changes:
Review Comment:
Might drop "To make you aware of that,"
> Rename "Dependency Information" to "Maven Coordinates"
> --
>
> Key: MPIR-451
> URL: https://issues.apache.org/jira/browse/MPIR-451
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
>
> From a thread on commons-math where I noticed I was unable to find the Maven
> coordinates for the project on the project's website:
> The only way to get to that page is scroll about two thirds of the way down a
> sidebar and click one of the four links that mention "dependencies" that
> seems as likely to bring you to a list of commons-math's own dependencies
> rather than how to add this project as a dependency. I'm a Maven comitter
> who's spent way more time in the depths of Maven Project website generation
> than 99.9% of Java programmers and I still couldn't find this the first time
> I looked for it. That's de facto evidence that this information is not easy
> to find.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates"
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851393#comment-17851393 ] ASF GitHub Bot commented on MPIR-451: - michael-o commented on PR #67: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67#issuecomment-2143765024 Note from me: I agree with @elharo's sentiments that this goal is incorrently named. I lines up with the other dependency goals which are about the project's deps and not about this project being a dep somewhere. > Rename "Dependency Information" to "Maven Coordinates" > -- > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates"
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851334#comment-17851334 ] ASF GitHub Bot commented on MPIR-451: - michael-o opened a new pull request, #67: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67 This closes #67 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPIR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MPIR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MPIR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Rename "Dependency Information" to "Maven Coordinates" > -- > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800483#comment-17800483 ] Elliotte Rusty Harold commented on MPIR-451: When I read "Maven Dependency Coordinates" I think coordinates of the dependencies of this project. "Maven Coordinates" suggests to me the coordinates of this project, which is what I want. I have occasionally used Maven coordinates to locate an artifact in a context where it is not a dependency. > Rename "Dependency Information" to "Maven Coordinates". > > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Major > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800333#comment-17800333 ] Michael Osipov commented on MPIR-451: - Maybe "Maven Depenency Coordinates" would be better. > Rename "Dependency Information" to "Maven Coordinates". > > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Major > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".
[
https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787424#comment-17787424
]
Michael Osipov commented on MPIR-451:
-
I don't consider {{dependency-info.html}} to be cool or helpful ;-)
> Rename "Dependency Information" to "Maven Coordinates".
>
>
> Key: MPIR-451
> URL: https://issues.apache.org/jira/browse/MPIR-451
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> From a thread on commons-math where I noticed I was unable to find the Maven
> coordinates for the project on the project's website:
> The only way to get to that page is scroll about two thirds of the way down a
> sidebar and click one of the four links that mention "dependencies" that
> seems as likely to bring you to a list of commons-math's own dependencies
> rather than how to add this project as a dependency. I'm a Maven comitter
> who's spent way more time in the depths of Maven Project website generation
> than 99.9% of Java programmers and I still couldn't find this the first time
> I looked for it. That's de facto evidence that this information is not easy
> to find.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787419#comment-17787419 ] Elliotte Rusty Harold commented on MPIR-451: The file name doesn't matter as much though it might help a little with SEO to change it. However the link in the sidebar that says Dependency Information should instead be Maven Coordinates Possibly the main header on that page could also change from "Dependency Information" to "Maven Coordinates" I'm a little hesitant to change the file name only because that would break existing links, and "Cool URIs don't change" https://www.w3.org/Provider/Style/URI > Rename "Dependency Information" to "Maven Coordinates". > > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Major > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787401#comment-17787401 ] Michael Osipov commented on MPIR-451: - Do you expect to see: * Change in content? * Change in output name (file name)? > Rename "Dependency Information" to "Maven Coordinates". > > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Major > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775305#comment-17775305 ] Michael Osipov commented on MPIR-451: - We can do this in the next major version (4) easily. > Rename "Dependency Information" to "Maven Coordinates". > > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Major > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
