[jira] [Commented] (MRESOLVER-393) Transport HTTP does not retain last modified as sent by remote end
[ https://issues.apache.org/jira/browse/MRESOLVER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749637#comment-17749637 ] ASF GitHub Bot commented on MRESOLVER-393: -- cstamas merged PR #323: URL: https://github.com/apache/maven-resolver/pull/323 > Transport HTTP does not retain last modified as sent by remote end > -- > > Key: MRESOLVER-393 > URL: https://issues.apache.org/jira/browse/MRESOLVER-393 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 1.9.15 > > > All files it downloads are created with "now" as timestamp. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-393) Transport HTTP does not retain last modified as sent by remote end
[
https://issues.apache.org/jira/browse/MRESOLVER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749317#comment-17749317
]
ASF GitHub Bot commented on MRESOLVER-393:
--
cstamas commented on code in PR #323:
URL: https://github.com/apache/maven-resolver/pull/323#discussion_r1279749516
##
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##
@@ -641,6 +642,17 @@ public void handle(CloseableHttpResponse response) throws
IOException, TransferC
task.setDataFile(dataFile);
}
}
+if (task.getDataFile() != null) {
+Header lastModifiedHeader =
+response.getFirstHeader(HttpHeaders.LAST_MODIFIED); //
note: Wagon also does first not last
Review Comment:
```suggestion
response.getFirstHeader(HttpHeaders.LAST_MODIFIED);
// note: do same as Wagon
```
##
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##
@@ -641,6 +642,17 @@ public void handle(CloseableHttpResponse response) throws
IOException, TransferC
task.setDataFile(dataFile);
}
}
+if (task.getDataFile() != null) {
+Header lastModifiedHeader =
+response.getFirstHeader(HttpHeaders.LAST_MODIFIED); //
note: Wagon also does first not last
Review Comment:
?
> Transport HTTP does not retain last modified as sent by remote end
> --
>
> Key: MRESOLVER-393
> URL: https://issues.apache.org/jira/browse/MRESOLVER-393
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.15
>
>
> All files it downloads are created with "now" as timestamp.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOLVER-393) Transport HTTP does not retain last modified as sent by remote end
[
https://issues.apache.org/jira/browse/MRESOLVER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749313#comment-17749313
]
ASF GitHub Bot commented on MRESOLVER-393:
--
michael-o commented on code in PR #323:
URL: https://github.com/apache/maven-resolver/pull/323#discussion_r1279731434
##
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##
@@ -641,6 +642,17 @@ public void handle(CloseableHttpResponse response) throws
IOException, TransferC
task.setDataFile(dataFile);
}
}
+if (task.getDataFile() != null) {
+Header lastModifiedHeader =
+response.getFirstHeader(HttpHeaders.LAST_MODIFIED); //
note: Wagon also does first not last
Review Comment:
According to https://www.rfc-editor.org/rfc/rfc9110#name-collected-abnf it
can only appear only once anyway. Everything else is protocol violation.
> Transport HTTP does not retain last modified as sent by remote end
> --
>
> Key: MRESOLVER-393
> URL: https://issues.apache.org/jira/browse/MRESOLVER-393
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.15
>
>
> All files it downloads are created with "now" as timestamp.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOLVER-393) Transport HTTP does not retain last modified as sent by remote end
[ https://issues.apache.org/jira/browse/MRESOLVER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749193#comment-17749193 ] ASF GitHub Bot commented on MRESOLVER-393: -- cstamas opened a new pull request, #323: URL: https://github.com/apache/maven-resolver/pull/323 If sent by remote end. --- https://issues.apache.org/jira/browse/MRESOLVER-393 > Transport HTTP does not retain last modified as sent by remote end > -- > > Key: MRESOLVER-393 > URL: https://issues.apache.org/jira/browse/MRESOLVER-393 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 1.9.15 > > > All files it downloads are created with "now" as timestamp. -- This message was sent by Atlassian Jira (v8.20.10#820010)
