[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[
https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739332#comment-17739332
]
Michael Osipov commented on MSHARED-193:
You are right. Since the one with {{#canGenerateReport()}} works as well, I can
make it happen here too. I will evaluate and provide a PR.
> No checked exceptions for rendering
> ---
>
> Key: MSHARED-193
> URL: https://issues.apache.org/jira/browse/MSHARED-193
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-api, maven-reporting-impl
>Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0
>Reporter: Benson Margulies
>Priority: Major
> Labels: doxia-2.0.0-stack
> Fix For: waiting-for-feedback
>
>
> It seems unfortunate that
> [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html]
> does not throw MavenReportingException. Thus, even though the execute method
> for a report throws that exception, rendering problems cannot.
> Obviously, a change to this would ramify. Would there be any chance of
> acceptance for a patch that added this 'throws'? Alternatively, how about an
> unchecked cousin of MavenReportingException?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739331#comment-17739331 ] Herve Boutemy commented on MSHARED-193: --- adding a checked exception does not cost anything, lets flexibility for users refusing just force them to tweak when they need it: I don't see why > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > Fix For: waiting-for-feedback > > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739326#comment-17739326 ] Michael Osipov commented on MSHARED-193: [~hboutemy], I'd like to settle this. WDYT? Still required? > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735262#comment-17735262 ] Michael Osipov commented on MSHARED-193: How likely is this? I mean if you need to stream the data to process it, then how to visualize so much data in a report? Does this then make sense? > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735155#comment-17735155 ] Herve Boutemy commented on MSHARED-193: --- yes, reading in memory is exactly what I'm talking about avoiding > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734068#comment-17734068 ] Michael Osipov commented on MSHARED-193: While this looks valid at first sight, it still does not qualify. We exactly have this case: Surefire, Failsafe. Complex tests are being run, results are stored in XML files, but not read by the renderer. The report class which invokes the render reads the file into a memory representation and passes onto the renderer. > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733886#comment-17733886 ] Herve Boutemy commented on MSHARED-193: --- if prepare stores result to file (after huge computation), renderer has to read it back perhaps looking at concrete examples where renderers were forced to work around the miss would be useful, to avoid endless theoretical discussions > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733875#comment-17733875 ] Michael Osipov commented on MSHARED-193: The IO you mention I would expect to happen in the report, don't you think? At least in all of our reporting plugins we prepare everything **outside** of the renderer. > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733873#comment-17733873 ] Herve Boutemy commented on MSHARED-193: --- bq. A renderer (view in MVC) is the last layer, there is no logic, no data retrieval. Data (model) must be fetched and prepared by the controller, here the report and passed to the view (renderer) and the view's sole purpose is to print it out. yes, I agree but "it should" does not mean that there is never a small IO call, like reading a file that was prepared previously then yes, in general IO should not happen, but it happens sometimes and is a pain when it arrives that's why adding a MavenReportingException is IMHO a good thing (while adding the same to canGenerate() in MSHARED-1032), to make maven-reporting-api easier to use when something unexpected happens (and avoid stupid unchecked exceptions) > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-193) No checked exceptions for rendering
[ https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733733#comment-17733733 ] Michael Osipov commented on MSHARED-193: [~hboutemy], after touching all of our renders and looking again at this, I think this should be closed as wontfix and I will explain why: A renderer (view in MVC) is the last layer, there is no logic, no data retrieval. Data (model) must be fetched and prepared by the controller, here the report and passed to the view (renderer) and the view's sole purpose is to print it out. Done. See [here|https://github.com/apache/maven-invoker-plugin/commit/a154e5b13dd7d900829d1d951efff50c41f25738] for a good example. Let me know what you think! > No checked exceptions for rendering > --- > > Key: MSHARED-193 > URL: https://issues.apache.org/jira/browse/MSHARED-193 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-api, maven-reporting-impl >Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0 >Reporter: Benson Margulies >Priority: Major > Labels: doxia-2.0.0-stack > > It seems unfortunate that > [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html] > does not throw MavenReportingException. Thus, even though the execute method > for a report throws that exception, rendering problems cannot. > Obviously, a change to this would ramify. Would there be any chance of > acceptance for a patch that added this 'throws'? Alternatively, how about an > unchecked cousin of MavenReportingException? -- This message was sent by Atlassian Jira (v8.20.10#820010)
