[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738269#comment-16738269
]
Andre Tadeu de Carvalho commented on MWAR-371:
--
Hi,
The PR [https://github.com/apache/maven-war-plugin/pull/3] was already merged
to the master. Could anyone set the status of this issue accordingly?
Thanks,
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730294#comment-16730294
]
Hudson commented on MWAR-371:
-
Build failed in Jenkins: Maven TLP » maven-war-plugin » master #51
See https://builds.apache.org/job/maven-box/job/maven-war-plugin/job/master/51/
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662733#comment-16662733
]
Robert Scholte commented on MWAR-371:
-
[~Alf.H] I've had a look at your patch. The provided tests don't cover the
change. When cherry-picking only the changes of {{PathSetTest}}, all tests
still succeed.
Also respect the maven code style which you can find at
https://maven.apache.org/developers/conventions/code.html
If you run {{mvn verify -Prun-its}} the project must still succeed after your
changes.
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640815#comment-16640815
]
ASF GitHub Bot commented on MWAR-371:
-
khmarbaise commented on a change in pull request #1: [MWAR-371] - Overlays
break first-win rule for web resource with target path ending with '/'
URL: https://github.com/apache/maven-war-plugin/pull/1#discussion_r223189348
##
File path: src/it/MWAR-371/pom.xml
##
@@ -0,0 +1,25 @@
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+ mwar371
+ mwar371
+ 0.0.1-SNAPSHOT
+ pom
+
+ generic
+ custom
+
+
+
+
+
+
maven-war-plugin
+ 2.6
+
Review comment:
Why defining an different version than you are build with this build?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640814#comment-16640814
]
ASF GitHub Bot commented on MWAR-371:
-
khmarbaise commented on a change in pull request #1: [MWAR-371] - Overlays
break first-win rule for web resource with target path ending with '/'
URL: https://github.com/apache/maven-war-plugin/pull/1#discussion_r223189332
##
File path: src/it/MWAR-371/custom/pom.xml
##
@@ -0,0 +1,47 @@
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+ mwar371
+ mwar371
+ 0.0.1-SNAPSHOT
+
+ custom
+ war
+
+
+ mwar371
+ generic
+ 0.0.1-SNAPSHOT
+ war
+
+
+
+
+
+
+ maven-war-plugin
+ 3.2.3-SNAPSHOT
+
Review comment:
The hard coded version is not a good idea...you should look at the other
IT's as an example how to do this correctly. `@project.version@`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633497#comment-16633497
]
Robert Scholte commented on MWAR-371:
-
That's a unittest, integration tests are located under src/it and represent a
small Maven project.
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633483#comment-16633483
]
W.Alphonse Harouny commented on MWAR-371:
-
Hello,
The fix is working properly, I attached the expected result to my comment.
An integration test was made as well, have a look at
[PathSetTest.java|https://github.com/W-Alphonse/maven-war-plugin/commit/77cbf15e049cf8707a3146470fe407588ff2860b#diff-2cc51c8bb8365c9aa5554e0c9bbfafb5],
#testTrimAjdacentSlashes().
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633465#comment-16633465
]
Robert Scholte commented on MWAR-371:
-
Have you tested this fix? My impression is that this won't fix the original
issue. This issue probably deserves an integration-test as well based on the
usecase in the description.
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624600#comment-16624600
]
W.Alphonse Harouny commented on MWAR-371:
-
Hello, it is possible to convert to Java 7 Paths.
However the main role of PathSet java class in *the current implementation* is
to "clean" targetPath value that had been filled in the maven-war-plugin
configuration.
So even if Java 7 Paths is used, the cleaning step still be needed if we would
like to keep the existing tolerance at the maven-war-plugin configuration level.
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624581#comment-16624581
]
ASF GitHub Bot commented on MWAR-371:
-
W-Alphonse opened a new pull request #1: [MWAR-371] - Overlays break first-win
rule for web resource with target path ending with '/'
URL: https://github.com/apache/maven-war-plugin/pull/1
[MWAR-371] - Overlays break first-win rule for web resource with target path
ending with '/'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606956#comment-16606956
]
Robert Scholte commented on MWAR-371:
-
[~Alf.H] thanks for the patch. Could you make a GitHub PullRequest for it?
Regarding the implementation, let's only normalize trailing slashes. And just
wondering, this code was originally written for Java 5. How easy is it to
convert it to Java 7 Paths?
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605306#comment-16605306
]
W.Alphonse Harouny commented on MWAR-371:
-
Hello, please find attached a patch correcting the bug.
Regards.
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
> Attachments: mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578756#comment-16578756
]
Robert Scholte commented on MWAR-371:
-
Great! if you get stuck, just let us know. FYI, [~diakogiannis] was also
interested in this issue.
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577692#comment-16577692
]
Dejan Stojadinović commented on MWAR-371:
-
[~rfscholte] I will take this one.
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
> Labels: up-for-grabs
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MWAR-371) Overlays break first-win rule for web resource with target path ending with '/'
[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239088#comment-15239088
]
Michal Domagala commented on MWAR-371:
--
Example: https://github.com/michaldo/mwar371
Call mvn package and inspect WAR 'custom'
> Overlays break first-win rule for web resource with target path ending with
> '/'
> ---
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
>Affects Versions: 2.6
>Reporter: Michal Domagala
>Priority: Minor
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a1.txt and settings:
> {code:xml}
> maven-war-plugin
>
>
>
> src/main/custom
> a1.txt
> x/
>
>
> src/main/custom
> a2.txt
> x
>
>
>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
