[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760870#comment-16760870
]
Baptiste MATHUS commented on SCM-777:
-
Sorry to answer late, TBH given you've had a look at the code already, I think
you're now better positioned to have an opinion given I did this apparently in
2014 and I only a very small memory I had done that :).
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751963#comment-16751963
]
Andreas Schaller commented on SCM-777:
--
Still works for me, thanks again for your work!
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751612#comment-16751612
]
Michael Osipov commented on SCM-777:
[~hboutemy], force pushed final changes to the branch. Have a look.
Who wants to validate this branch?
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745224#comment-16745224
]
Hervé Boutemy commented on SCM-777:
---
done, you can review when you want
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744951#comment-16744951
]
Michael Osipov commented on SCM-777:
OK, I will wait for your changes.
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744900#comment-16744900
]
Hervé Boutemy commented on SCM-777:
---
I had a look: [~mathu...@mipih.fr] provided SCM-741 (merged by me) and SCM-781
(merged by olamy), then I suppose he'll be the best advise
but when I look, it seems the addition of the
"scmCheckWorkingDirectoryUrl.currentWorkingDirectory" system property as a
result of validate goal scmCheckWorkingDirectoryUrl parameter in SCM-781 should
have replaced the scmCheckWorkingDirectoryUrl system property: seems ok to me
I just propose a few changes as an additionnal commit: you can squash it when
merging to master...
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741597#comment-16741597
]
Michael Osipov commented on SCM-777:
[~hboutemy], did you get a chance to have a look at?
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732760#comment-16732760
]
Michael Osipov commented on SCM-777:
[~hboutemy], as far as I understand the overall design there is no way to pass
around this piece of information easily. Sys property or thread local storage
are the only viable options. I do feel confident on the patch because it is
straight forward, but I'd be happy if you could spare an hour or so to think
about your previous approach and tell whether the change is legit.
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732733#comment-16732733
]
Hervé Boutemy commented on SCM-777:
---
[~michael-o] I don't remember anything on that easily: do you need me to dig
more in details this WE? or are you confident enough?
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732075#comment-16732075
]
Michael Osipov commented on SCM-777:
[~schaller], that's great. If I don't hear any objections from the other folks,
I will merge this next week.
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-777) scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732021#comment-16732021
]
Andreas Schaller commented on SCM-777:
--
[~michael-o] your fix works for me, thanks!
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> --
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
