[jira] [Commented] (SUREFIRE-2182) Log starter implementation on DEBUG level
[ https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736051#comment-17736051 ] ASF GitHub Bot commented on SUREFIRE-2182: -- kwin merged PR #665: URL: https://github.com/apache/maven-surefire/pull/665 > Log starter implementation on DEBUG level > - > > Key: SUREFIRE-2182 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2182 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > In order to ease debugging classpath issues the fork configuration determined > by > [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216] > should be logged with debug level for when using the fork starter. Similarly > a DEBUG log entry should be emitted when the in-process starter is being used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2182) Log starter implementation on DEBUG level
[
https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735997#comment-17735997
]
ASF GitHub Bot commented on SUREFIRE-2182:
--
kwin commented on code in PR #665:
URL: https://github.com/apache/maven-surefire/pull/665#discussion_r1238087796
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -1181,6 +1181,9 @@ private RunResult executeProvider(
} else {
ForkConfiguration forkConfiguration =
createForkConfiguration(platform, resolvedJavaModularityResult);
if (getConsoleLogger().isDebugEnabled()) {
+getConsoleLogger()
+.debug("Using fork starter with configuration "
Review Comment:
Maybe "Using fork starter with configuration implementation " to be in line
with
https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#LL2228C32-L2228C32?
> Log starter implementation on DEBUG level
> -
>
> Key: SUREFIRE-2182
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2182
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In order to ease debugging classpath issues the fork configuration determined
> by
> [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216]
> should be logged with debug level for when using the fork starter. Similarly
> a DEBUG log entry should be emitted when the in-process starter is being used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2182) Log starter implementation on DEBUG level
[
https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735955#comment-17735955
]
ASF GitHub Bot commented on SUREFIRE-2182:
--
kwin commented on code in PR #665:
URL: https://github.com/apache/maven-surefire/pull/665#discussion_r1237936661
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -1181,6 +1181,9 @@ private RunResult executeProvider(
} else {
ForkConfiguration forkConfiguration =
createForkConfiguration(platform, resolvedJavaModularityResult);
if (getConsoleLogger().isDebugEnabled()) {
+getConsoleLogger()
+.debug("Using fork starter with configuration "
Review Comment:
Any suggestions?
> Log starter implementation on DEBUG level
> -
>
> Key: SUREFIRE-2182
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2182
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In order to ease debugging classpath issues the fork configuration determined
> by
> [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216]
> should be logged with debug level for when using the fork starter. Similarly
> a DEBUG log entry should be emitted when the in-process starter is being used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2182) Log starter implementation on DEBUG level
[
https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735909#comment-17735909
]
ASF GitHub Bot commented on SUREFIRE-2182:
--
michael-o commented on code in PR #665:
URL: https://github.com/apache/maven-surefire/pull/665#discussion_r1237743912
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -1181,6 +1181,9 @@ private RunResult executeProvider(
} else {
ForkConfiguration forkConfiguration =
createForkConfiguration(platform, resolvedJavaModularityResult);
if (getConsoleLogger().isDebugEnabled()) {
+getConsoleLogger()
+.debug("Using fork starter with configuration "
Review Comment:
The statement is a bit misleading. It does not print the configuration, but
only the configuration class (name), no?
> Log starter implementation on DEBUG level
> -
>
> Key: SUREFIRE-2182
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2182
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In order to ease debugging classpath issues the fork configuration determined
> by
> [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216]
> should be logged with debug level for when using the fork starter. Similarly
> a DEBUG log entry should be emitted when the in-process starter is being used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2182) Log starter implementation on DEBUG level
[
https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735889#comment-17735889
]
ASF GitHub Bot commented on SUREFIRE-2182:
--
kwin commented on code in PR #665:
URL: https://github.com/apache/maven-surefire/pull/665#discussion_r1237540052
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -1181,6 +1181,9 @@ private RunResult executeProvider(
} else {
ForkConfiguration forkConfiguration =
createForkConfiguration(platform, resolvedJavaModularityResult);
if (getConsoleLogger().isDebugEnabled()) {
+getConsoleLogger()
Review Comment:
First https://issues.apache.org/jira/browse/SUREFIRE-2183 needs
clarification, because for me the newly added line is not logged when using
{{mvn -X}}. But it is logged if placed outside the guard in line 1183 (both
with the same level debug).
> Log starter implementation on DEBUG level
> -
>
> Key: SUREFIRE-2182
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2182
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In order to ease debugging classpath issues the fork configuration determined
> by
> [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216]
> should be logged with debug level for when using the fork starter. Similarly
> a DEBUG log entry should be emitted when the in-process starter is being used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2182) Log starter implementation on DEBUG level
[
https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735869#comment-17735869
]
ASF GitHub Bot commented on SUREFIRE-2182:
--
kwin commented on code in PR #665:
URL: https://github.com/apache/maven-surefire/pull/665#discussion_r1237540052
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -1181,6 +1181,9 @@ private RunResult executeProvider(
} else {
ForkConfiguration forkConfiguration =
createForkConfiguration(platform, resolvedJavaModularityResult);
if (getConsoleLogger().isDebugEnabled()) {
+getConsoleLogger()
Review Comment:
First https://issues.apache.org/jira/browse/SUREFIRE-2183 needs
clarification, because for me the latter is not logged when using {{mvn -X}}.
But it is logged if placed outside the guard in line 1183...
> Log starter implementation on DEBUG level
> -
>
> Key: SUREFIRE-2182
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2182
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In order to ease debugging classpath issues the fork configuration determined
> by
> [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216]
> should be logged with debug level for when using the fork starter. Similarly
> a DEBUG log entry should be emitted when the in-process starter is being used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2182) Log starter implementation on DEBUG level
[
https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735870#comment-17735870
]
ASF GitHub Bot commented on SUREFIRE-2182:
--
kwin commented on code in PR #665:
URL: https://github.com/apache/maven-surefire/pull/665#discussion_r1237540052
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -1181,6 +1181,9 @@ private RunResult executeProvider(
} else {
ForkConfiguration forkConfiguration =
createForkConfiguration(platform, resolvedJavaModularityResult);
if (getConsoleLogger().isDebugEnabled()) {
+getConsoleLogger()
Review Comment:
First https://issues.apache.org/jira/browse/SUREFIRE-2183 needs
clarification, because for me the newly added line is not logged when using
{{mvn -X}}. But it is logged if placed outside the guard in line 1183 (both
with the same level debug).
> Log starter implementation on DEBUG level
> -
>
> Key: SUREFIRE-2182
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2182
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In order to ease debugging classpath issues the fork configuration determined
> by
> [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216]
> should be logged with debug level for when using the fork starter. Similarly
> a DEBUG log entry should be emitted when the in-process starter is being used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2182) Log starter implementation on DEBUG level
[ https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735860#comment-17735860 ] ASF GitHub Bot commented on SUREFIRE-2182: -- kwin opened a new pull request, #665: URL: https://github.com/apache/maven-surefire/pull/665 For fork starter log the underlying configuration class name as well Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Log starter implementation on DEBUG level > - > > Key: SUREFIRE-2182 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2182 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > In order to ease debugging classpath issues the fork configuration determined > by > [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216] > should be logged with debug level for when using the fork starter. Similarly > a DEBUG log entry should be emitted when the in-process starter is being used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
