[jira] [Commented] (MESOS-7342) Port Docker tests
[ https://issues.apache.org/jira/browse/MESOS-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388702#comment-16388702 ] Andrew Schwartzmeyer commented on MESOS-7342: - commit ca357e95f Author: Akash Gupta Date: Tue Mar 6 13:11:19 2018 -0800 Windows: Fixed `WIFEXITED` and `WIFSIGNALED` stubs. The `WIFEXITED` and `WIFSIGNALED` macros were incorrectly checking if the exit code was not -1 to determine if the process exited or was signaled. However, -1 is a valid return code on Windows, so when logic like `CHECK(WIFEXITED(status)|| WIFSIGNALED(status))` was used, it would end up aborting the process accidentally. For `WIFEXITED`, we simply return `true` because all error codes on Windows indicate the process exited (if the process instead failed to spawn, then `os::spawn()` would return `None()` instead of an exit code). For `WIFIGNALED`, we simply return `false` for similar reasons. We assume the process did not exit due to a signal, as that is not an expected scenario on Windows. Review: https://reviews.apache.org/r/65840/ > Port Docker tests > - > > Key: MESOS-7342 > URL: https://issues.apache.org/jira/browse/MESOS-7342 > Project: Mesos > Issue Type: Bug >Reporter: Andrew Schwartzmeyer >Assignee: Akash Gupta >Priority: Major > Labels: docker, windows > > While one of Daniel Pravat's last acts was introducing the the Docker > containerizer for Windows, we don't have tests. We need to port > `docker_tests.cpp` and `docker_containerizer_tests.cpp` to Windows. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MESOS-7342) Port Docker tests
[
https://issues.apache.org/jira/browse/MESOS-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329733#comment-16329733
]
Andrew Schwartzmeyer commented on MESOS-7342:
-
{noformat}
commit 8964137f6 (HEAD -> master, apache/master, apache/HEAD)
Author: Akash Gupta
Date: Wed Jan 17 13:51:59 2018 -0800
Windows: Updated networking documentation.
The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.
Review: https://reviews.apache.org/r/63861/
commit 6b35c93ba
Author: Akash Gupta
Date: Wed Jan 17 13:51:44 2018 -0800
Windows: Mapped the Docker network info types.
The Network enum in DockerInfo is specific to Linux containers. `HOST`
doesn't exist on Windows and `BRIDGE` is `NAT` on Windows. The current
default docker network setting was always `HOST`, which broke the
Windows docker executor. Now, if a specific network isn't given, the
network mode will default to `HOST` on Linux agents and `NAT` on Windows
agents. Also, `BRIDGE` mode will be translated to `NAT` on Windows.
Review: https://reviews.apache.org/r/63860/
commit eccd0a9f9
Author: Akash Gupta
Date: Wed Jan 17 13:51:32 2018 -0800
Windows: Fixed mock signal values in stout.
Removed `SIGSTOP` and `SIGCONT` on Windows, since they are meaningless,
and never unused. Also, fixed the WEXITSTATUS macro to cast the exit
code instead of bit-masking it, since Windows exit codes are 32 bit
unsigned ints.
Review: https://reviews.apache.org/r/63859/
{noformat}
> Port Docker tests
> -
>
> Key: MESOS-7342
> URL: https://issues.apache.org/jira/browse/MESOS-7342
> Project: Mesos
> Issue Type: Bug
> Components: docker
> Environment: Windows 10
>Reporter: Andrew Schwartzmeyer
>Assignee: Akash Gupta
>Priority: Major
> Labels: microsoft, windows
>
> While one of Daniel Pravat's last acts was introducing the the Docker
> containerizer for Windows, we don't have tests. We need to port
> `docker_tests.cpp` and `docker_containerizer_tests.cpp` to Windows.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-7342) Port Docker tests
[
https://issues.apache.org/jira/browse/MESOS-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044673#comment-16044673
]
Andrew Schwartzmeyer commented on MESOS-7342:
-
This is odd. I have two separate builds of Mesos on Windows right now, and in
one of them, these tests try to run:
{{.\src\mesos-tests.exe --gtest_filter="ROOT_DOCKER*"}}
{noformat}
[==] Running 8 tests from 1 test case.
[--] Global test environment set-up.
[--] 8 tests from
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest
[ RUN ]
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskRunning/0
C:\Users\andschwa\src\mesos\3rdparty\libprocess\include\process/gmock.hpp(209):
ERROR: this mock object (used in test RO
OT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskRunning/0)
should be deleted but never is. Its address is
@02024AEB5888.
C:\Users\andschwa\src\mesos\src\tests\default_executor_tests.cpp(131): ERROR:
this mock object (used in test ROOT_DOCKER
_DockerAndMesosContainerizers/DefaultExecutorTest.TaskRunning/0) should be
deleted but never is. Its address is @020
24CBAF220.
C:\Users\andschwa\src\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock
object (used in test ROOT_DOCKER_DockerAn
dMesosContainerizers/DefaultExecutorTest.TaskRunning/0) should be deleted but
never is. Its address is @02024D6B4E70
.
ERROR: 3 leaked mock objects found at program exit.
{noformat}
And in the other:
{noformat}
[==] Running 0 tests from 0 test cases.
[==] 0 tests from 0 test cases ran. (16 ms total)
[ PASSED ] 0 tests.
{noformat}
I'm trying to identify the difference between the two builds that is causing
this.
> Port Docker tests
> -
>
> Key: MESOS-7342
> URL: https://issues.apache.org/jira/browse/MESOS-7342
> Project: Mesos
> Issue Type: Bug
> Components: docker
> Environment: Windows 10
>Reporter: Andrew Schwartzmeyer
>Assignee: John Kordich
> Labels: microsoft, windows
>
> While one of Daniel Pravat's last acts was introducing the the Docker
> containerizer for Windows, we don't have tests. We need to port
> `docker_tests.cpp` and `docker_containerizer_tests.cpp` to Windows.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7342) Port Docker tests
[
https://issues.apache.org/jira/browse/MESOS-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025642#comment-16025642
]
Joseph Wu commented on MESOS-7342:
--
{code}
commit c4df8f7b0e48e190111ef427080bf3ca5019a25a
Author: John Kordich
Date: Thu May 25 17:24:10 2017 -0700
Windows: Enabled DOCKER and ROOT test filters.
This flips two test filters on Windows, so that all Docker and Root
tests are now enabled by default on Windows (rather than disabled).
On Windows, everything must be run as Administrator (like root, but
also somewhat different), so all ROOT tests are enabled by default.
The DOCKER filter now has the same behavior on Windows and Linux.
However, since many of the tests affected by these filters are
still not working on Windows, some individual tests have been
disabled.
The main test enabled by this commit is:
`DockerTest.ROOT_DOCKER_Version`.
Review: https://reviews.apache.org/r/59353/
{code}
> Port Docker tests
> -
>
> Key: MESOS-7342
> URL: https://issues.apache.org/jira/browse/MESOS-7342
> Project: Mesos
> Issue Type: Bug
> Components: docker
> Environment: Windows 10
>Reporter: Andrew Schwartzmeyer
>Assignee: John Kordich
> Labels: microsoft, windows
>
> While one of Daniel Pravat's last acts was introducing the the Docker
> containerizer for Windows, we don't have tests. We need to port
> `docker_tests.cpp` and `docker_containerizer_tests.cpp` to Windows.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
