[jira] [Commented] (METRON-1643) Create a REGEX_ROUTING field transformation
[
https://issues.apache.org/jira/browse/METRON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534132#comment-16534132
]
ASF GitHub Bot commented on METRON-1643:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1083
Sure, so the difference in the parser chaining example would be between the
following
# Stellar
```
"fieldTransformations" : [
{
"transformation" : "STELLAR"
,"input" : "pix_type"
,"output" : "logical_source_type"
,"config" : {
"logical_source_type" : "match{REGEXP_MATCH(pix_type, '^6-302.*') =>
'cisco-6-302', REGEXP_MATCH(pix_type, '^5-304.*') => 'cisco-5-304', default =>
NULL}",
}
}
]
```
# `REGEX_SELECT`
```
"fieldTransformations" : [
{
"transformation" : "REGEX_SELECT"
,"input" : "pix_type"
,"output" : "logical_source_type"
,"config" : {
"cisco-6-302" : "^6-302.*",
"cisco-5-304" : "^5-304.*"
}
}
]
```
It bears mentioning that things get worse in stellar when:
1. You want to match on one of a set of regexs (e.g. `match {
REGEXP_MATCH(pix_type, 'regex1') or REGEXP_MATCH(pix_type, 'regex2') => 'foo',
...`)
2. The set of target kafka topics grows. In this example there are 2, but
if there were 5, they'd all have to fit in a long line of stellar.
I think it's not that stellar isn't equipped to handle it theoretically,
it's just that for these kinds of use-cases, it's more readable to create
something a bit more specific until we get multi-line Stellar available.
Ultimately, I consider this a stop-gap.
> Create a REGEX_ROUTING field transformation
> ---
>
> Key: METRON-1643
> URL: https://issues.apache.org/jira/browse/METRON-1643
> Project: Metron
> Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> A relatively common pattern is to choose the value of a field based on if
> another field matches a set of regexes. This can be done via stellar with
> match, but if the list of possible regexes are large, that can be unwieldy.
> To ease that burden, we should have a REGEX_ROUTING field transformation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] metron issue #1083: METRON-1643: Create a REGEX_ROUTING field transformation
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1083
Sure, so the difference in the parser chaining example would be between the
following
# Stellar
```
"fieldTransformations" : [
{
"transformation" : "STELLAR"
,"input" : "pix_type"
,"output" : "logical_source_type"
,"config" : {
"logical_source_type" : "match{REGEXP_MATCH(pix_type, '^6-302.*') =>
'cisco-6-302', REGEXP_MATCH(pix_type, '^5-304.*') => 'cisco-5-304', default =>
NULL}",
}
}
]
```
# `REGEX_SELECT`
```
"fieldTransformations" : [
{
"transformation" : "REGEX_SELECT"
,"input" : "pix_type"
,"output" : "logical_source_type"
,"config" : {
"cisco-6-302" : "^6-302.*",
"cisco-5-304" : "^5-304.*"
}
}
]
```
It bears mentioning that things get worse in stellar when:
1. You want to match on one of a set of regexs (e.g. `match {
REGEXP_MATCH(pix_type, 'regex1') or REGEXP_MATCH(pix_type, 'regex2') => 'foo',
...`)
2. The set of target kafka topics grows. In this example there are 2, but
if there were 5, they'd all have to fit in a long line of stellar.
I think it's not that stellar isn't equipped to handle it theoretically,
it's just that for these kinds of use-cases, it's more readable to create
something a bit more specific until we get multi-line Stellar available.
Ultimately, I consider this a stop-gap.
---
[jira] [Commented] (METRON-1476) Update angular
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533843#comment-16533843 ] ASF GitHub Bot commented on METRON-1476: GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1096 METRON-1476: Update Angular in Alerts UI ## Contributor Comments This PR updates the Alerts UI to use the latest stable release of Angular (6.0.6). The original ticket in the ASF JIRA was originally intended to update both the Alerts and Config UI. However, I did not update Config UI due to there being a lack of e2e and unit tests. Without those, it's very hard to be confident that the update didn't break any functionality. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sardell/metron METRON-1476 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1096.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1096 commit b5788fb1f892012d4cd105fc8c23667fd7c8df6f Author: Shane Ardell Date: 2018-06-27T13:08:01Z update angular to current stable version commit 4f1ee4fea99cc154ee0a328a349abab58c0d67a2 Author: Shane Ardell Date: 2018-07-05T10:45:58Z remove module file extension commit cd5942a11c25e8ccb1be98919e3c4883823f2f59 Author: Shane Ardell Date: 2018-07-05T11:09:53Z add http interceptor for default headers commit fa40b49f9a6d2aa4b36a9266e4b72b28a5c26ecb Author: Shane Ardell Date: 2018-07-05T12:01:16Z update configurations commit 86bfaa30c89b24474fbfaed118c3b35c483c19e3 Author: Shane Ardell Date: 2018-07-05T12:02:21Z update dependencies commit 1abd618b5f2b53381feb23ba12ccb1fa282da297 Author: Shane Ardell Date: 2018-07-05T12:03:06Z update services to use HttpClient and rxjs changes commit c7e7c95fd84618218b786d8f8ecad3d660434318 Author: Shane Ardell Date: 2018-07-05T15:50:24Z merge master and resolve conflicts in view and login specs > Update angular > -- > >
[GitHub] metron pull request #1096: METRON-1476: Update Angular in Alerts UI
GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1096 METRON-1476: Update Angular in Alerts UI ## Contributor Comments This PR updates the Alerts UI to use the latest stable release of Angular (6.0.6). The original ticket in the ASF JIRA was originally intended to update both the Alerts and Config UI. However, I did not update Config UI due to there being a lack of e2e and unit tests. Without those, it's very hard to be confident that the update didn't break any functionality. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sardell/metron METRON-1476 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1096.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1096 commit b5788fb1f892012d4cd105fc8c23667fd7c8df6f Author: Shane Ardell Date: 2018-06-27T13:08:01Z update angular to current stable version commit 4f1ee4fea99cc154ee0a328a349abab58c0d67a2 Author: Shane Ardell Date: 2018-07-05T10:45:58Z remove module file extension commit cd5942a11c25e8ccb1be98919e3c4883823f2f59 Author: Shane Ardell Date: 2018-07-05T11:09:53Z add http interceptor for default headers commit fa40b49f9a6d2aa4b36a9266e4b72b28a5c26ecb Author: Shane Ardell Date: 2018-07-05T12:01:16Z update configurations commit 86bfaa30c89b24474fbfaed118c3b35c483c19e3 Author: Shane Ardell Date: 2018-07-05T12:02:21Z update dependencies commit 1abd618b5f2b53381feb23ba12ccb1fa282da297 Author: Shane Ardell Date: 2018-07-05T12:03:06Z update services to use HttpClient and rxjs changes commit c7e7c95fd84618218b786d8f8ecad3d660434318 Author: Shane Ardell Date: 2018-07-05T15:50:24Z merge master and resolve conflicts in view and login specs ---
[jira] [Updated] (METRON-1651) Fixing failing protractor e2e test
[ https://issues.apache.org/jira/browse/METRON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1651: - Summary: Fixing failing protractor e2e test (was: Fixing faIling protractor e2e tests) > Fixing failing protractor e2e test > -- > > Key: METRON-1651 > URL: https://issues.apache.org/jira/browse/METRON-1651 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Major > Attachments: e2e-assertion-errors.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1651) Fixing failing protractor e2e test
[ https://issues.apache.org/jira/browse/METRON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533815#comment-16533815 ] ASF GitHub Bot commented on METRON-1651: GitHub user tiborm opened a pull request: https://github.com/apache/metron/pull/1095 METRON-1651: Fixing faIling protractor e2e tests ## Contributor Comments The PR contains fixes for METRON-1651 and some small improvements stabilize protractor tests. - alert-details-status test had to be ignored till wi fix the bug behind the test failure (related ticket linked) - two assertation has to be commented out because of the same bug (related ticket linked) - one assertation added back, the issue behind it fixed - browser.sleep added in two places to reduce test flakiness ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tiborm/metron METRON-1651 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1095.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1095 commit c0b6a994c8011f9dcfaf1fff5cb5c205d808049e Author: tiborm Date: 2018-07-04T11:24:03Z METRON-1651: ignoring tests fails by a know issue commit dafd0fd2aa90c24986869aeb297519e92203f30a Author: tiborm Date: 2018-07-05T09:44:47Z METRON-1651: linking faling assertations to the related bug ticket commit d40310da038ab0aad2e2dbd7486bcbf69911ebff Author: tiborm Date: 2018-07-05T14:40:17Z METRON-1651: adding custom matchers in beforeAll commit e1160b040ad386d2535ecf3a9cf16297222aa4fb Author: tiborm Date: 2018-07-05T14:43:59Z METRON-1651: jira ticket #1631 fixed - assertation passing; adding sleep to reduce test flakiness commit 35036146d0f5be025a3db53ee2ba46d098c1bdc8 Author: tiborm Date: 2018-07-05T14:45:35Z METRON-1651: fixing changed alert order caused by test data modifications commit 02d679767cc3ca44bf50fda0c79bce7e29897a17 Author: tiborm Date: 2018-07-05T14:46:34Z METRON-1631: adding sleep to
[jira] [Updated] (METRON-1651) Fixing faIling protractor e2e tests
[ https://issues.apache.org/jira/browse/METRON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1651: - Summary: Fixing faIling protractor e2e tests (was: Fixing faling protractor e2e tests) > Fixing faIling protractor e2e tests > --- > > Key: METRON-1651 > URL: https://issues.apache.org/jira/browse/METRON-1651 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Major > Attachments: e2e-assertion-errors.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1095: METRON-1651: Fixing faIling protractor e2e tests
GitHub user tiborm opened a pull request: https://github.com/apache/metron/pull/1095 METRON-1651: Fixing faIling protractor e2e tests ## Contributor Comments The PR contains fixes for METRON-1651 and some small improvements stabilize protractor tests. - alert-details-status test had to be ignored till wi fix the bug behind the test failure (related ticket linked) - two assertation has to be commented out because of the same bug (related ticket linked) - one assertation added back, the issue behind it fixed - browser.sleep added in two places to reduce test flakiness ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tiborm/metron METRON-1651 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1095.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1095 commit c0b6a994c8011f9dcfaf1fff5cb5c205d808049e Author: tiborm Date: 2018-07-04T11:24:03Z METRON-1651: ignoring tests fails by a know issue commit dafd0fd2aa90c24986869aeb297519e92203f30a Author: tiborm Date: 2018-07-05T09:44:47Z METRON-1651: linking faling assertations to the related bug ticket commit d40310da038ab0aad2e2dbd7486bcbf69911ebff Author: tiborm Date: 2018-07-05T14:40:17Z METRON-1651: adding custom matchers in beforeAll commit e1160b040ad386d2535ecf3a9cf16297222aa4fb Author: tiborm Date: 2018-07-05T14:43:59Z METRON-1651: jira ticket #1631 fixed - assertation passing; adding sleep to reduce test flakiness commit 35036146d0f5be025a3db53ee2ba46d098c1bdc8 Author: tiborm Date: 2018-07-05T14:45:35Z METRON-1651: fixing changed alert order caused by test data modifications commit 02d679767cc3ca44bf50fda0c79bce7e29897a17 Author: tiborm Date: 2018-07-05T14:46:34Z METRON-1631: adding sleep to reduce test flakiness ---
[jira] [Commented] (METRON-1652) Document X-Pack Common Problem
[ https://issues.apache.org/jira/browse/METRON-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533787#comment-16533787 ] ASF GitHub Bot commented on METRON-1652: Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1092 > Document X-Pack Common Problem > -- > > Key: METRON-1652 > URL: https://issues.apache.org/jira/browse/METRON-1652 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Minor > > Improvements to the Elasticsearch X-Pack documentation to document a common > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1092: METRON-1652 Document X-Pack Common Problem
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1092 ---
[jira] [Commented] (METRON-1643) Create a REGEX_ROUTING field transformation
[ https://issues.apache.org/jira/browse/METRON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533751#comment-16533751 ] ASF GitHub Bot commented on METRON-1643: Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1083 Can you provide a "routing in Stellar" versus "routing with REGEX_ROUTING" example that highlights the benefits of this approach? This go against our current trajectory of "do everything in Stellar" and I want to make sure I understand the benefits. > Create a REGEX_ROUTING field transformation > --- > > Key: METRON-1643 > URL: https://issues.apache.org/jira/browse/METRON-1643 > Project: Metron > Issue Type: Improvement >Reporter: Casey Stella >Priority: Major > > A relatively common pattern is to choose the value of a field based on if > another field matches a set of regexes. This can be done via stellar with > match, but if the list of possible regexes are large, that can be unwieldy. > To ease that burden, we should have a REGEX_ROUTING field transformation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1083: METRON-1643: Create a REGEX_ROUTING field transformation
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1083 Can you provide a "routing in Stellar" versus "routing with REGEX_ROUTING" example that highlights the benefits of this approach? This go against our current trajectory of "do everything in Stellar" and I want to make sure I understand the benefits. ---
[jira] [Commented] (METRON-1652) Document X-Pack Common Problem
[ https://issues.apache.org/jira/browse/METRON-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533746#comment-16533746 ] ASF GitHub Bot commented on METRON-1652: Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1092 @mmiklavc I'd be happy to write-up your feedback as another PR. Its definitely really good info (especially (6) ES client is intimidated by ElasticsearchUtils :) ), but I don't want to steal your thunder. If you don't have time to get to it, just let me know and I'll write it up in a separate PR. > Document X-Pack Common Problem > -- > > Key: METRON-1652 > URL: https://issues.apache.org/jira/browse/METRON-1652 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Minor > > Improvements to the Elasticsearch X-Pack documentation to document a common > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1092: METRON-1652 Document X-Pack Common Problem
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1092 @mmiklavc I'd be happy to write-up your feedback as another PR. Its definitely really good info (especially (6) ES client is intimidated by ElasticsearchUtils :) ), but I don't want to steal your thunder. If you don't have time to get to it, just let me know and I'll write it up in a separate PR. ---
[jira] [Commented] (METRON-1650) Packaging docker containers are too large
[ https://issues.apache.org/jira/browse/METRON-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533691#comment-16533691 ] ASF GitHub Bot commented on METRON-1650: Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1091 @jameslamb, The vagrant stuff is the general information on how to run it. For the docker containers that you have worked on, it would be fine I think to say that you tested that the containers work for their purpose. It would be enough for you to say in the description: ``` Testing: run ansible docker like this %THIS, see that it works without error run deb docker like this %THIS, see that it works without error run rpm docker like this %THIS, see that it works without error ``` Our vagrant build for centos and ubuntu targets actually use the rpm and deb dockers so that is one way they get tests, but doesn't have to be the only way. the ansible docker must be tested explicitly > Packaging docker containers are too large > - > > Key: METRON-1650 > URL: https://issues.apache.org/jira/browse/METRON-1650 > Project: Metron > Issue Type: Improvement >Reporter: James Lamb >Priority: Minor > > I have been looking through the project source code, and found that the > packaging docker containers are bigger than they need to be. > The containers' size could be cut substantially by: > * Grouping as many commands as possible into as few RUN stages as possible > * Taking advantage of `yum clean` and `apt-get clean` > * Removing artifacts pulled with `wget` > * Removing unused libraries or libraries only needed at build time (like > `tar` and `wget`) > I am creating this issue but will soon submit a PR to address it. > Thank you for considering my proposal! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1091: METRON-1650: Cut size of packaging docker containers
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1091 @jameslamb, The vagrant stuff is the general information on how to run it. For the docker containers that you have worked on, it would be fine I think to say that you tested that the containers work for their purpose. It would be enough for you to say in the description: ``` Testing: run ansible docker like this %THIS, see that it works without error run deb docker like this %THIS, see that it works without error run rpm docker like this %THIS, see that it works without error ``` Our vagrant build for centos and ubuntu targets actually use the rpm and deb dockers so that is one way they get tests, but doesn't have to be the only way. the ansible docker must be tested explicitly ---
[jira] [Commented] (METRON-1588) Migrate storm-kafka-client to 1.2.1
[ https://issues.apache.org/jira/browse/METRON-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533669#comment-16533669 ] Casey Stella commented on METRON-1588: -- Yep, so marked. > Migrate storm-kafka-client to 1.2.1 > --- > > Key: METRON-1588 > URL: https://issues.apache.org/jira/browse/METRON-1588 > Project: Metron > Issue Type: Improvement >Reporter: Jungtaek Lim >Priority: Critical > > Storm community defines storm-kafka-client 1.1.0 to be "unstable" and says > 1.2.0 to be stabled one, because Storm community resolved 40 issues including > critical and blocker from 1.2.0. > There're still couple of issues after 1.2.0 so better to sync up the version > to the latest, so I suggest Metron to upgrade the version to the latest, > 1.2.1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1652) Document X-Pack Common Problem
[ https://issues.apache.org/jira/browse/METRON-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533663#comment-16533663 ] ASF GitHub Bot commented on METRON-1652: Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1092 Sounds good @nickwallen, +1 by inspection. > Document X-Pack Common Problem > -- > > Key: METRON-1652 > URL: https://issues.apache.org/jira/browse/METRON-1652 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Minor > > Improvements to the Elasticsearch X-Pack documentation to document a common > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1092: METRON-1652 Document X-Pack Common Problem
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1092 Sounds good @nickwallen, +1 by inspection. ---
[GitHub] metron issue #1092: METRON-1652 Document X-Pack Common Problem
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1092 +1 by inspection ---
[jira] [Commented] (METRON-1652) Document X-Pack Common Problem
[ https://issues.apache.org/jira/browse/METRON-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533656#comment-16533656 ] ASF GitHub Bot commented on METRON-1652: Github user cestella commented on the issue: https://github.com/apache/metron/pull/1092 +1 by inspection > Document X-Pack Common Problem > -- > > Key: METRON-1652 > URL: https://issues.apache.org/jira/browse/METRON-1652 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Minor > > Improvements to the Elasticsearch X-Pack documentation to document a common > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1092: METRON-1652 Document X-Pack Common Problem
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1092 Ok, maybe we can hit any other common problems with a subsequent PR. No need to delay this one getting in. ---
[jira] [Commented] (METRON-1653) Stellar exceptions can be extremely nested and we should make efforts to separate the nested exception better
[ https://issues.apache.org/jira/browse/METRON-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533641#comment-16533641 ] ASF GitHub Bot commented on METRON-1653: Github user cestella commented on the issue: https://github.com/apache/metron/pull/1093 Ah crap, I misread a stacktrace. It didn't fail to log the full one, I just failed to have reading comprehension. The main issue here was I saw a stack trace in the wild, which i'm not sure I can share, that appeared to cut off the trace AT the point of a NPE but without the full stack trace of the NPE, which made diagnosing it impossible. I see now that I just didn't get the full cut and paste. I'm closing this. > Stellar exceptions can be extremely nested and we should make efforts to > separate the nested exception better > - > > Key: METRON-1653 > URL: https://issues.apache.org/jira/browse/METRON-1653 > Project: Metron > Issue Type: Improvement >Reporter: Casey Stella >Priority: Major > > Stellar exceptions can be extremely nested and we should make efforts to > separate the nested exception better. What happens now is sometimes the > exception gets cut off. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1653) Stellar exceptions can be extremely nested and we should make efforts to separate the nested exception better
[ https://issues.apache.org/jira/browse/METRON-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533642#comment-16533642 ] ASF GitHub Bot commented on METRON-1653: Github user cestella closed the pull request at: https://github.com/apache/metron/pull/1093 > Stellar exceptions can be extremely nested and we should make efforts to > separate the nested exception better > - > > Key: METRON-1653 > URL: https://issues.apache.org/jira/browse/METRON-1653 > Project: Metron > Issue Type: Improvement >Reporter: Casey Stella >Priority: Major > > Stellar exceptions can be extremely nested and we should make efforts to > separate the nested exception better. What happens now is sometimes the > exception gets cut off. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1093: METRON-1653: Stellar exceptions can be extremely ...
Github user cestella closed the pull request at: https://github.com/apache/metron/pull/1093 ---
[GitHub] metron issue #1093: METRON-1653: Stellar exceptions can be extremely nested ...
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1093 Ah crap, I misread a stacktrace. It didn't fail to log the full one, I just failed to have reading comprehension. The main issue here was I saw a stack trace in the wild, which i'm not sure I can share, that appeared to cut off the trace AT the point of a NPE but without the full stack trace of the NPE, which made diagnosing it impossible. I see now that I just didn't get the full cut and paste. I'm closing this. ---
[jira] [Updated] (METRON-1654) findOne request after an alert patch returns with the original state of the alert item
[ https://issues.apache.org/jira/browse/METRON-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1654: - Priority: Major (was: Minor) > findOne request after an alert patch returns with the original state of the > alert item > -- > > Key: METRON-1654 > URL: https://issues.apache.org/jira/browse/METRON-1654 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Major > > /findOne request after an alert patch returns with the original state of the > alert item. > The UI stays inconsistent until the next search request. > This leads to the following bugs: > - Alert status change on details panel haven't reflected on the list view. > - Adding an element to a meta-alert doesn't change the items counter beside > the name of the meta-alert > - Removing an element from a meta-alert doesn't change the items counter > beside the name of the meta-alert > - Clicking on remove/unlink button in a meta-alert group doesn't remove item > immediately > This behavior only validated on the full dev single node VM and might not > exist in production. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-1654) findOne request after an alert patch returns with the original state of the alert item
[ https://issues.apache.org/jira/browse/METRON-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1654: - Description: The UI stays inconsistent until the next search request. This leads to the following bugs: - Alert status change on details panel haven't reflected on the list view. - Adding an element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing an element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking on remove/unlink button in a meta-alert group doesn't remove item immediately This behavior only validated on the full dev single node VM and might not exist in production. was: The UI stays inconsistent until the next search request. Bugs - Alert status change on details panel haven't reflected on the list view. - Adding an element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing an element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking remove/unlink alert from a meta-alert doesn't remove immediately This behavior only validated on the full dev single node VM and might not exist in production. > findOne request after an alert patch returns with the original state of the > alert item > -- > > Key: METRON-1654 > URL: https://issues.apache.org/jira/browse/METRON-1654 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Minor > > The UI stays inconsistent until the next search request. > This leads to the following bugs: > - Alert status change on details panel haven't reflected on the list view. > - Adding an element to a meta-alert doesn't change the items counter beside > the name of the meta-alert > - Removing an element from a meta-alert doesn't change the items counter > beside the name of the meta-alert > - Clicking on remove/unlink button in a meta-alert group doesn't remove item > immediately > This behavior only validated on the full dev single node VM and might not > exist in production. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-1654) findOne request after an alert patch returns with the original state of the alert item
[ https://issues.apache.org/jira/browse/METRON-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1654: - Description: /findOne request after an alert patch returns with the original state of the alert item. The UI stays inconsistent until the next search request. This leads to the following bugs: - Alert status change on details panel haven't reflected on the list view. - Adding an element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing an element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking on remove/unlink button in a meta-alert group doesn't remove item immediately This behavior only validated on the full dev single node VM and might not exist in production. was: The UI stays inconsistent until the next search request. This leads to the following bugs: - Alert status change on details panel haven't reflected on the list view. - Adding an element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing an element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking on remove/unlink button in a meta-alert group doesn't remove item immediately This behavior only validated on the full dev single node VM and might not exist in production. > findOne request after an alert patch returns with the original state of the > alert item > -- > > Key: METRON-1654 > URL: https://issues.apache.org/jira/browse/METRON-1654 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Minor > > /findOne request after an alert patch returns with the original state of the > alert item. > The UI stays inconsistent until the next search request. > This leads to the following bugs: > - Alert status change on details panel haven't reflected on the list view. > - Adding an element to a meta-alert doesn't change the items counter beside > the name of the meta-alert > - Removing an element from a meta-alert doesn't change the items counter > beside the name of the meta-alert > - Clicking on remove/unlink button in a meta-alert group doesn't remove item > immediately > This behavior only validated on the full dev single node VM and might not > exist in production. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-1654) findOne request after an alert patch returns with the original state of the alert item
[ https://issues.apache.org/jira/browse/METRON-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1654: - Summary: findOne request after an alert patch returns with the original state of the alert item (was: findOne request after an alert patch returns with the original state of the alrert item) > findOne request after an alert patch returns with the original state of the > alert item > -- > > Key: METRON-1654 > URL: https://issues.apache.org/jira/browse/METRON-1654 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Minor > > The UI stays inconsistent until the next search request. > Bugs > - Alert status change on details panel haven't reflected on the list view. > - Adding an element to a meta-alert doesn't change the items counter beside > the name of the meta-alert > - Removing an element from a meta-alert doesn't change the items counter > beside the name of the meta-alert > - Clicking remove/unlink alert from a meta-alert doesn't remove immediately > This behavior only validated on the full dev single node VM and might not > exist in production. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-1654) findOne request after an alert patch returns with the original state of the alrert item
[ https://issues.apache.org/jira/browse/METRON-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1654: - Summary: findOne request after an alert patch returns with the original state of the alrert item (was: Status change on details panel haven't reflected on the list view) > findOne request after an alert patch returns with the original state of the > alrert item > --- > > Key: METRON-1654 > URL: https://issues.apache.org/jira/browse/METRON-1654 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Minor > > The UI stays inconsistent until the next search request. > Bugs > - Alert status change on details panel haven't reflected on the list view. > - Adding an element to a meta-alert doesn't change the items counter beside > the name of the meta-alert > - Removing an element from a meta-alert doesn't change the items counter > beside the name of the meta-alert > - Clicking remove/unlink alert from a meta-alert doesn't remove immediately > This behavior only validated on the full dev single node VM and might not > exist in production. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-1654) Status change on details panel haven't reflected on the list view
[ https://issues.apache.org/jira/browse/METRON-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1654: - Description: The UI stays inconsistent until the next search request. Bugs - Alert status change on details panel haven't reflected on the list view. - Adding an element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing an element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking remove/unlink alert from a meta-alert doesn't remove immediately This behavior only validated on the full dev single node VM and might not exist in production. was: The ui stays inconsistent untill the next search request. Bugs - Alert status change on details panel haven't reflected on the list view. - Adding element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking remove/unlink alert from a meta-alert doesn't removes imediatelly This behavior only validated on the full dev single node vm and might not exist in production. > Status change on details panel haven't reflected on the list view > - > > Key: METRON-1654 > URL: https://issues.apache.org/jira/browse/METRON-1654 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Minor > > The UI stays inconsistent until the next search request. > Bugs > - Alert status change on details panel haven't reflected on the list view. > - Adding an element to a meta-alert doesn't change the items counter beside > the name of the meta-alert > - Removing an element from a meta-alert doesn't change the items counter > beside the name of the meta-alert > - Clicking remove/unlink alert from a meta-alert doesn't remove immediately > This behavior only validated on the full dev single node VM and might not > exist in production. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-1654) Status change on details panel haven't reflected on the list view
[ https://issues.apache.org/jira/browse/METRON-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1654: - Description: The ui stays inconsistent till the next search request. Bugs - Alert status change on details panel haven't reflected on the list view. - Adding element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking remove/unlink alert from a meta-alert doesn't removes imediatelly This behavior only validated on the full dev single node vm and might not exist in production. was: Alert status change on details panel haven't reflected on the list view. The status change triggers a request to update the list but the response contains the previous state. This behavior only validated on the full dev single node vm and might not exist in production. > Status change on details panel haven't reflected on the list view > - > > Key: METRON-1654 > URL: https://issues.apache.org/jira/browse/METRON-1654 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Minor > > The ui stays inconsistent till the next search request. > Bugs > - Alert status change on details panel haven't reflected on the list view. > - Adding element to a meta-alert doesn't change the items counter beside the > name of the meta-alert > - Removing element from a meta-alert doesn't change the items counter beside > the name of the meta-alert > - Clicking remove/unlink alert from a meta-alert doesn't removes imediatelly > This behavior only validated on the full dev single node vm and might not > exist in production. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-1654) Status change on details panel haven't reflected on the list view
[ https://issues.apache.org/jira/browse/METRON-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1654: - Description: The ui stays inconsistent untill the next search request. Bugs - Alert status change on details panel haven't reflected on the list view. - Adding element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking remove/unlink alert from a meta-alert doesn't removes imediatelly This behavior only validated on the full dev single node vm and might not exist in production. was: The ui stays inconsistent till the next search request. Bugs - Alert status change on details panel haven't reflected on the list view. - Adding element to a meta-alert doesn't change the items counter beside the name of the meta-alert - Removing element from a meta-alert doesn't change the items counter beside the name of the meta-alert - Clicking remove/unlink alert from a meta-alert doesn't removes imediatelly This behavior only validated on the full dev single node vm and might not exist in production. > Status change on details panel haven't reflected on the list view > - > > Key: METRON-1654 > URL: https://issues.apache.org/jira/browse/METRON-1654 > Project: Metron > Issue Type: Bug >Reporter: Tibor Meller >Priority: Minor > > The ui stays inconsistent untill the next search request. > Bugs > - Alert status change on details panel haven't reflected on the list view. > - Adding element to a meta-alert doesn't change the items counter beside the > name of the meta-alert > - Removing element from a meta-alert doesn't change the items counter beside > the name of the meta-alert > - Clicking remove/unlink alert from a meta-alert doesn't removes imediatelly > This behavior only validated on the full dev single node vm and might not > exist in production. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
