[GitHub] [metron] sardell commented on issue #1380: METRON-1253: Manual pasting of timestamps into the timestamp picker
sardell commented on issue #1380: METRON-1253: Manual pasting of timestamps into the timestamp picker URL: https://github.com/apache/metron/pull/1380#issuecomment-496797322 I do think my suggestion is creating more work that is clearly out of scope of this specific fix for the datepicker. I respectfully disagree that these changes aren't necessary or worth the effort. Maybe I'm oversimplifying this, but you could add a HostListener to listen for clicks outside of the datepicker. For example: https://stackoverflow.com/questions/40107008/detect-click-outside-angular-component. The Cypress tests are probably broken with the suggested changes because they are targeting the input vs. the icon to open the calendar. All that said, I'm going to give this a +1, as this work clearly addresses the problem you set out to fix (copy and pasting dates in the datepicker). I've created a separate ticket to address the UX issues with the datepicker: https://issues.apache.org/jira/browse/METRON-2146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (METRON-2146) [UI] Datepicker open/close functionality should be more user friendly
Shane Ardell created METRON-2146: Summary: [UI] Datepicker open/close functionality should be more user friendly Key: METRON-2146 URL: https://issues.apache.org/jira/browse/METRON-2146 Project: Metron Issue Type: Bug Reporter: Shane Ardell Attachments: image-2019-05-29-07-54-53-043.png, image-2019-05-29-07-55-04-489.png There are a couple of user-unfriendly behaviors related to the datepicker in the Alerts UI that should be addressed: * If a user double-clicks the datepicker input, pastes a date and then clicks outside the datepicker, the calendar quickly opens and closes. Besides it being unnecessary for the calendar to open if a user is manually adding a timestamp, a user could accidentally click on the calendar and unintentionally select a date. * The calendar only opens if a user clicks on the input. This differs from most datepickers in libraries like Angular Material, which toggle the calendar view by clicking on the calendar icon. I've included a gif of the behavior I'm talking about in the first issue, as well as a gif of how Angular Material's datepicker behaves for reference. !image-2019-05-29-07-54-53-043.png! !image-2019-05-29-07-55-04-489.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [metron] mmiklavc opened a new pull request #1434: METRON-2145 Clarify RPM build documentation
mmiklavc opened a new pull request #1434: METRON-2145 Clarify RPM build documentation URL: https://github.com/apache/metron/pull/1434 ## Contributor Comments https://issues.apache.org/jira/browse/METRON-2145 The context for building **only** the RPMs comes after the Quick Start, so when looking for a quick reference to building only the RPMs you'll unwittingly end up building all of Metron first as well. Added a brief note before the command to make that more apparent. Also fixed a typo for the rpm profile name in the build packages section. ## Pull Request Checklist ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - n/a Have you written or updated unit tests and or integration tests to verify your changes? - n/a If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - n/a Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` - n/a Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (METRON-2145) Clarify RPM build documentation
[ https://issues.apache.org/jira/browse/METRON-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic updated METRON-2145: -- Summary: Clarify RPM build documentation (was: Clarify rpm build documentation) > Clarify RPM build documentation > --- > > Key: METRON-2145 > URL: https://issues.apache.org/jira/browse/METRON-2145 > Project: Metron > Issue Type: Task >Reporter: Michael Miklavcic >Assignee: Michael Miklavcic >Priority: Major > > The RPM doc quick start currently tells users to run the command from the > project root. This works, however it also runs a full packaging for the > entire project. This may not be what users want. The full dev build, for > example, runs from /metron-deployment and will only build the > rpm artifacts. This effectively cuts down 20 minutes from the rpm build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (METRON-2145) Clarify rpm build documentation
Michael Miklavcic created METRON-2145: - Summary: Clarify rpm build documentation Key: METRON-2145 URL: https://issues.apache.org/jira/browse/METRON-2145 Project: Metron Issue Type: Task Reporter: Michael Miklavcic Assignee: Michael Miklavcic The RPM doc quick start currently tells users to run the command from the project root. This works, however it also runs a full packaging for the entire project. This may not be what users want. The full dev build, for example, runs from /metron-deployment and will only build the rpm artifacts. This effectively cuts down 20 minutes from the rpm build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2128) LEEF config file is missing in RPM spec file
[ https://issues.apache.org/jira/browse/METRON-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic updated METRON-2128: -- Fix Version/s: Next + 1 > LEEF config file is missing in RPM spec file > > > Key: METRON-2128 > URL: https://issues.apache.org/jira/browse/METRON-2128 > Project: Metron > Issue Type: Bug >Reporter: Ryan Merriman >Assignee: Simon Elliston Ball >Priority: Major > Fix For: Next + 1 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > The Metron RPM build step is failing due to a missing LEEF config file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [metron] asfgit closed pull request #1419: METRON-2128: LEEF config file is missing in RPM spec file
asfgit closed pull request #1419: METRON-2128: LEEF config file is missing in RPM spec file URL: https://github.com/apache/metron/pull/1419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (METRON-2144) Fix missing entries in metron.spec changelog
Michael Miklavcic created METRON-2144: - Summary: Fix missing entries in metron.spec changelog Key: METRON-2144 URL: https://issues.apache.org/jira/browse/METRON-2144 Project: Metron Issue Type: Task Reporter: Michael Miklavcic We're missing a number of entries in the spec file changelog. Add and date them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [metron] mmiklavc commented on issue #1419: METRON-2128: LEEF config file is missing in RPM spec file
mmiklavc commented on issue #1419: METRON-2128: LEEF config file is missing in RPM spec file URL: https://github.com/apache/metron/pull/1419#issuecomment-496589891 https://issues.apache.org/jira/browse/METRON-2144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1419: METRON-2128: LEEF config file is missing in RPM spec file
mmiklavc commented on issue #1419: METRON-2128: LEEF config file is missing in RPM spec file URL: https://github.com/apache/metron/pull/1419#issuecomment-496589149 @justinleet Everything looks good, except we're missing an update to the changelog file here - https://github.com/apache/metron/blob/02bd729bf349095e4fc7054d647dd6b903ac8bb7/metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec#L688. It looks like we also missed the update from a PR I submitted as well. I'm going to open a separate PR to fix this so we can get master working again. +1 by inspection This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] sardell commented on issue #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table
sardell commented on issue #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table URL: https://github.com/apache/metron/pull/1431#issuecomment-496577578 +1 pending a small typo fix. Tested with full dev and the instructions left on the ASF Jira ticket. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] sardell commented on a change in pull request #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table
sardell commented on a change in pull request #1431: METRON-2102: [UI] Adding
click-through navigation to Alerts table
URL: https://github.com/apache/metron/pull/1431#discussion_r288176956
##
File path:
metron-interface/metron-alerts/cypress/integration/alert-list/context-menu.spec.js
##
@@ -0,0 +1,89 @@
+///
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import * as appConfigJSON from '../../../src/assets/app-config.json';
+
+context('Context Menu on Alerts', () => {
+
+ beforeEach(() => {
+cy.server();
+cy.route({
+ method: 'GET',
+ url: '/api/v1/user',
+ response: 'user'
+});
+cy.route({
+method: 'POST',
+url: '/api/v1/logout',
+response: []
+});
+
+cy.route('GET', '/api/v1/global/config', 'fixture:config.json');
+cy.route('POST', 'search', 'fixture:search.json');
+
+cy.route('GET', appConfigJSON.contextMenuConfigURL,
'fixture:context-menu.conf.json');
+
+cy.visit('login');
+cy.get('[name="user"]').type('user');
+cy.get('[name="password"]').type('password');
+cy.contains('LOG IN').click();
+
+cy.get('[data-qe-id="alert-search-btn"]').click();
+ });
+
+ it('clicking on a table cell should show context menu', () => {
+cy.get('[data-qe-id="row-5"] > :nth-child(6) > a').click();
+cy.get('[data-qe-id="cm-dropdown"]').should('be.visible');
+ });
+
+ it('clicking on "Add to search bar" should apply value to filter bar', () =>
{
+cy.get('[data-qe-id="row-5"] > :nth-child(6) > a').click();
+cy.get('[data-qe-id="cm-dropdown"]').should('be.visible');
+cy.contains('Add to search bar').click();
+cy.get('.ace_keyword').should('contain', 'ip_src_addr:');
+cy.get('.ace_value').should('contain', '192.168.66.121');
+ });
+
+ it('clicking on "Add to search bar" should colose the dropdown of context
menu', () => {
Review comment:
Typo. 'close' instead of 'colose'.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] justinleet commented on issue #1419: METRON-2128: LEEF config file is missing in RPM spec file
justinleet commented on issue #1419: METRON-2128: LEEF config file is missing in RPM spec file URL: https://github.com/apache/metron/pull/1419#issuecomment-496574026 @mmiklavc Are you good with this? I'm going to abstain since I mostly saw a Travis issue that I probably commented on the wrong PR for, based on the response from @simonellistonball This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] merrimanr commented on a change in pull request #1389: METRON-2087: Remove Storm dependency from metron-indexing
merrimanr commented on a change in pull request #1389: METRON-2087: Remove
Storm dependency from metron-indexing
URL: https://github.com/apache/metron/pull/1389#discussion_r288142010
##
File path:
metron-platform/metron-elasticsearch/metron-elasticsearch-common/pom.xml
##
@@ -0,0 +1,242 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
+
+org.apache.metron
+metron-elasticsearch
+0.7.1
+
+metron-elasticsearch-common
+metron-elasticsearch-common
+https://metron.apache.org/
+
+UTF-8
+
UTF-8
+${global_hbase_guava_version}
+
+
+
+org.apache.metron
+elasticsearch-shaded
+${project.parent.version}
+
+
+org.apache.metron
+metron-common
+${project.parent.version}
+
+
+org.apache.metron
+metron-writer-common
+${project.parent.version}
+
+
+org.apache.metron
+metron-hbase
Review comment:
Looks like we do need metron-hbase as a test dependency.
`ElasticsearchUpdateIntegrationTest` depends on our mock hbase classes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] tiborm commented on a change in pull request #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table
tiborm commented on a change in pull request #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table URL: https://github.com/apache/metron/pull/1431#discussion_r288133126 ## File path: .gitignore ## @@ -32,3 +32,4 @@ repodata/ !.vscode/tasks.json !.vscode/launch.json !.vscode/extensions.json +metron-interface/metron-alerts/TODO Review comment: No. I going to remove it. It was just for my todo file while I was developed this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] sardell commented on a change in pull request #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table
sardell commented on a change in pull request #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table URL: https://github.com/apache/metron/pull/1431#discussion_r288127236 ## File path: .gitignore ## @@ -32,3 +32,4 @@ repodata/ !.vscode/tasks.json !.vscode/launch.json !.vscode/extensions.json +metron-interface/metron-alerts/TODO Review comment: Should this be here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] merrimanr commented on a change in pull request #1389: METRON-2087: Remove Storm dependency from metron-indexing
merrimanr commented on a change in pull request #1389: METRON-2087: Remove
Storm dependency from metron-indexing
URL: https://github.com/apache/metron/pull/1389#discussion_r288112815
##
File path:
metron-platform/metron-elasticsearch/metron-elasticsearch-storm/pom.xml
##
@@ -0,0 +1,210 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
+
+org.apache.metron
+metron-elasticsearch
+0.7.1
+
+metron-elasticsearch-storm
+metron-elasticsearch-storm
+Components common to Storm
+https://metron.apache.org/
+
+UTF-8
+
UTF-8
+1.10
+${global_hbase_guava_version}
+
+
+
+org.apache.metron
+elasticsearch-shaded
+${project.parent.version}
+
+
+org.apache.metron
+metron-storm-kafka
+${project.parent.version}
+
+
+org.apache.storm
+flux-core
+${global_flux_version}
+
+
+org.apache.storm
+storm-core
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] merrimanr commented on a change in pull request #1389: METRON-2087: Remove Storm dependency from metron-indexing
merrimanr commented on a change in pull request #1389: METRON-2087: Remove
Storm dependency from metron-indexing
URL: https://github.com/apache/metron/pull/1389#discussion_r288112781
##
File path: metron-platform/metron-solr/metron-solr-storm/pom.xml
##
@@ -0,0 +1,192 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
+
+org.apache.metron
+metron-solr
+0.7.1
+
+metron-solr-storm
+metron-solr-storm
+Components common to Storm
+https://metron.apache.org/
+
+UTF-8
+
UTF-8
+1.10
+
+
+
+org.apache.metron
+metron-solr-common
+${project.parent.version}
+
+
+org.apache.metron
+metron-solr-common
+${project.parent.version}
+test
+test-jar
+
+
+org.apache.metron
+metron-indexing-storm
+${project.parent.version}
+
+
+org.apache.metron
+metron-indexing-storm
+${project.parent.version}
+test
+test-jar
+
+
+org.apache.solr
+solr-test-framework
+${global_solr_version}
+test
+
+
+fastutil
+it.unimi.dsi
+
+
+com.fasterxml.jackson.core
+jackson-core
+
+
+com.fasterxml.jackson.core
+jackson-annotations
+
+
+com.fasterxml.jackson.core
+jackson-databind
+
+
+caffeine
+com.github.ben-manes.caffeine
+
+
+
+
+org.apache.storm
+flux-core
+${global_flux_version}
+
+
+org.apache.storm
+storm-core
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
