[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #12: METRON-1817: Remove bro package dependency on bro source
ottobackwards commented on pull request #12: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/12#issuecomment-624390051 +1, ship it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (METRON-2352) [BRO-KAFKA-PLUGIN] e2e testing should leverage multiple brokers
Jon Zeolla created METRON-2352: -- Summary: [BRO-KAFKA-PLUGIN] e2e testing should leverage multiple brokers Key: METRON-2352 URL: https://issues.apache.org/jira/browse/METRON-2352 Project: Metron Issue Type: Bug Reporter: Jon Zeolla Assignee: Jon Zeolla Currently we only create a single kafka broker for e2e testing. We should leverage multiple brokers for a more production-equivalent testing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.
JonZeolla commented on pull request #40: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-624383143 Also please align the title of the PR exactly with your [JIRA](https://issues.apache.org/jira/browse/METRON-2309) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla edited a comment on pull request #8: METRON-1768: Adjust versioning of metron-bro-plugin-kafka to be x.y.z
JonZeolla edited a comment on pull request #8: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/8#issuecomment-425690228 This is on hold, pending https://github.com/zeek/zeek/issues/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.
JonZeolla commented on pull request #40: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-624373988 @mauropalumbo75 the issue you were seeing was fixed as of 587e9da and I just confirmed that everything is now passing on this branch. I would love to get this in - can you please add some tests for the new logic? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron] ottobackwards commented on a change in pull request #1580: METRON-2348 fix prepare-commit
ottobackwards commented on a change in pull request #1580:
URL: https://github.com/apache/metron/pull/1580#discussion_r420479572
##
File path: dev-utilities/committer-utils/metron-committer-common
##
@@ -135,8 +135,8 @@ function read_pull_request {
exit 1
fi
-if [[ "$PR_MERGEABLE" != "\"clean\"" ]]; then
- echo "Error: pull request #$PR is not mergable"
+if [[ "$PR_MERGEABLE" == "\"clean\"" ]] || [[ "$PR_MERGEABLE" ==
"unstable" ]]; then
Review comment:
drat
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit
JonZeolla commented on a change in pull request #1580:
URL: https://github.com/apache/metron/pull/1580#discussion_r420477673
##
File path: dev-utilities/committer-utils/metron-committer-common
##
@@ -135,8 +135,8 @@ function read_pull_request {
exit 1
fi
-if [[ "$PR_MERGEABLE" != "\"clean\"" ]]; then
- echo "Error: pull request #$PR is not mergable"
+if [[ "$PR_MERGEABLE" == "\"clean\"" ]] || [[ "$PR_MERGEABLE" ==
"unstable" ]]; then
Review comment:
Not sure what you were getting at with this change. Did you mean to
change `!=` to `==`? Also, if it's `!= "\"clean\""` then it doesn't matter if
it's `== "unstable"`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit
JonZeolla commented on a change in pull request #1580:
URL: https://github.com/apache/metron/pull/1580#discussion_r420477673
##
File path: dev-utilities/committer-utils/metron-committer-common
##
@@ -135,8 +135,8 @@ function read_pull_request {
exit 1
fi
-if [[ "$PR_MERGEABLE" != "\"clean\"" ]]; then
- echo "Error: pull request #$PR is not mergable"
+if [[ "$PR_MERGEABLE" == "\"clean\"" ]] || [[ "$PR_MERGEABLE" ==
"unstable" ]]; then
Review comment:
Not sure what you were getting at with this change. Did you mean to
change `!=` to `==`? Also, if it's `!= "\"clean\""` then it doesn't matter if
it's `== "unstable"` or `== "literallyanything"`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit
JonZeolla commented on a change in pull request #1580:
URL: https://github.com/apache/metron/pull/1580#discussion_r420477673
##
File path: dev-utilities/committer-utils/metron-committer-common
##
@@ -135,8 +135,8 @@ function read_pull_request {
exit 1
fi
-if [[ "$PR_MERGEABLE" != "\"clean\"" ]]; then
- echo "Error: pull request #$PR is not mergable"
+if [[ "$PR_MERGEABLE" == "\"clean\"" ]] || [[ "$PR_MERGEABLE" ==
"unstable" ]]; then
Review comment:
I think you meant `if [[ "$PR_MERGEABLE" != "\"clean\"" ]] || [[
"$PR_MERGEABLE" == "unstable" ]]; then`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (METRON-2351) Zeek Plugin should have it's own version of prepare commit
Otto Fowler created METRON-2351: --- Summary: Zeek Plugin should have it's own version of prepare commit Key: METRON-2351 URL: https://issues.apache.org/jira/browse/METRON-2351 Project: Metron Issue Type: Improvement Reporter: Otto Fowler Assignee: Otto Fowler The plugin project shouldn't depend on the main project -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624366596 for the love of puppies, merge this already This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420364150 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: Updated documentation to point to RC3 regarding what was tested and `zkg.meta` points to `~1.4.2-RC1` as the required external_depends This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420359510 ## File path: README.md ## @@ -63,11 +63,11 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ### Manual Installation -Manually installing the plugin should only occur in situations where installing and configuring `zkg` is not reasonable, such as in a docker container. If you are running zeek in an environment where you do not have Internet connectivity, investigate [bundles](https://docs.zeek.org/projects/package-manager/en/stable/zkg.html#bundle) or creating an internal [package source](https://docs.zeek.org/projects/package-manager/en/stable/source.html). +Manually installing the plugin should *only* occur in situations where installing and configuring `zkg` is not reasonable. If you are running zeek in an environment where you do not have Internet connectivity, investigate [bundles](https://docs.zeek.org/projects/package-manager/en/stable/zkg.html#bundle) or creating an internal [package source](https://docs.zeek.org/projects/package-manager/en/stable/source.html). These instructions could also be helpful if you were interested in distributing this as a package (such as a deb or rpm). -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: Update made throughout This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420304901 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: Yes, if we don't have a timeframe. This is an in between release build in our terms, and it passes our tests. I don't see why we wait. But maybe I don't understand the arguments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420299628 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: Right, we are on the same page. I'm saying I'm open to waiting to merge this until 1.4.2 is released and any remnants for RC3 are removed. If we don't do that, I agree the docs should be accurate as of the commit and refer to RC3. I assume your preference is update the README to reflect the RC and get this merged sooner rather than later, given we don't know what the 1.4.2 timeframe is? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420274006 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: Ok, I wasn't thinking of this as a question of the release or release process, I'm just thinking that with 'stable master', this needs to be correct (as of this commit ) The question of cutting a release off of master or not is separate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420178988 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: This is up for debate, I'm good with waiting for the release or running with the RC. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420173786 ## File path: README.md ## @@ -63,11 +63,11 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ### Manual Installation -Manually installing the plugin should only occur in situations where installing and configuring `zkg` is not reasonable, such as in a docker container. If you are running zeek in an environment where you do not have Internet connectivity, investigate [bundles](https://docs.zeek.org/projects/package-manager/en/stable/zkg.html#bundle) or creating an internal [package source](https://docs.zeek.org/projects/package-manager/en/stable/source.html). +Manually installing the plugin should *only* occur in situations where installing and configuring `zkg` is not reasonable. If you are running zeek in an environment where you do not have Internet connectivity, investigate [bundles](https://docs.zeek.org/projects/package-manager/en/stable/zkg.html#bundle) or creating an internal [package source](https://docs.zeek.org/projects/package-manager/en/stable/source.html). These instructions could also be helpful if you were interested in distributing this as a package (such as a deb or rpm). -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: same as above, put in the RC version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420173561 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: If we are going to commit with the -RC version, this should say the RC version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624043661 @ottobackwards Unit tests and e2e are both passing now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420092815 ## File path: README.md ## @@ -12,68 +12,68 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ## Installation Review comment: README should be accurate as of 761462a, ready for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
