[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420304901 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: Yes, if we don't have a timeframe. This is an in between release build in our terms, and it passes our tests. I don't see why we wait. But maybe I don't understand the arguments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420274006 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: Ok, I wasn't thinking of this as a question of the release or release process, I'm just thinking that with 'stable master', this needs to be correct (as of this commit ) The question of cutting a release off of master or not is separate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420173786 ## File path: README.md ## @@ -63,11 +63,11 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ### Manual Installation -Manually installing the plugin should only occur in situations where installing and configuring `zkg` is not reasonable, such as in a docker container. If you are running zeek in an environment where you do not have Internet connectivity, investigate [bundles](https://docs.zeek.org/projects/package-manager/en/stable/zkg.html#bundle) or creating an internal [package source](https://docs.zeek.org/projects/package-manager/en/stable/source.html). +Manually installing the plugin should *only* occur in situations where installing and configuring `zkg` is not reasonable. If you are running zeek in an environment where you do not have Internet connectivity, investigate [bundles](https://docs.zeek.org/projects/package-manager/en/stable/zkg.html#bundle) or creating an internal [package source](https://docs.zeek.org/projects/package-manager/en/stable/source.html). These instructions could also be helpful if you were interested in distributing this as a package (such as a deb or rpm). -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: same as above, put in the RC version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420173561 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: If we are going to commit with the -RC version, this should say the RC version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org