[jira] [Commented] (NIFI-3688) Create extended groovy scripting processor

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017062#comment-16017062
 ] 

ASF GitHub Bot commented on NIFI-3688:
--

Github user dlukyanov commented on the issue:

https://github.com/apache/nifi/pull/1662
  
In this case i believe it's ready for review.
I've reverted last commits and rebased all commits into one
Tried to build locally - and it's fine. 


> Create extended groovy scripting processor
> --
>
> Key: NIFI-3688
> URL: https://issues.apache.org/jira/browse/NIFI-3688
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Dmitry Lukyanov
>Priority: Minor
>
> The idea is to simplify groovy scripting.
> Main targets:
> - to be compatible with existing groovy scripting
> - simplify read/write attributes
> - simplify read/write content
> - avoid closure casting to nifi types like `StreamCallback`
> - simplify and provide visibility when accessing to controller services from 
> script



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi issue #1662: NIFI-3688 Extended Groovy Nifi Processor

2017-05-19 Thread dlukyanov
Github user dlukyanov commented on the issue:

https://github.com/apache/nifi/pull/1662
  
In this case i believe it's ready for review.
I've reverted last commits and rebased all commits into one
Tried to build locally - and it's fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (NIFI-3936) Follow the instructions step, maven build fails

2017-05-19 Thread shuguo zheng (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

shuguo zheng resolved NIFI-3936.

   Resolution: Not A Bug
Fix Version/s: 1.2.0

> Follow the instructions step, maven build fails
> ---
>
> Key: NIFI-3936
> URL: https://issues.apache.org/jira/browse/NIFI-3936
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.2.0
> Environment: windows7,centos6
>Reporter: shuguo zheng
> Fix For: 1.2.0
>
>
> When i execute “mvn -T 2.0C clean install ” or "mvn clean install" to compile 
> nifi source, The following error occurred. How can i fix it?
> [ERROR] Failed to execute goal 
> com.github.eirslett:frontend-maven-plugin:1.0:ins
> tall-node-and-npm (install-node-and-npm) on project nifi-web-ui: Could not 
> extra
> ct the npm archive: Could not extract archive: 
> 'F:\maven\com\github\eirslett\npm
> \1.3.8\npm-1.3.8.tar.gz': EOFException -> [Help 1]
> The detail error:
> [ERROR] No goals have been specified for this build. You must specify a valid 
> li
> fecycle phase or a goal in the format : or 
>  >:[:]:. Available lifecycle phases 
> >are
> : validate, initialize, generate-sources, process-sources, 
> generate-resources, p
> rocess-resources, compile, process-classes, generate-test-sources, 
> process-test-
> sources, generate-test-resources, process-test-resources, test-compile, 
> process-
> test-classes, test, prepare-package, package, pre-integration-test, 
> integration-
> test, post-integration-test, verify, install, deploy, pre-clean, clean, 
> post-cle
> an, pre-site, site, post-site, site-deploy. -> [Help 1]
> org.apache.maven.lifecycle.NoGoalSpecifiedException: No goals have been 
> specifie
> d for this build. You must specify a valid lifecycle phase or a goal in the 
> form
> at : or 
> :[: sion>]:. Available lifecycle phases are: validate, initialize, 
> generate-so
> urces, process-sources, generate-resources, process-resources, compile, 
> process-
> classes, generate-test-sources, process-test-sources, 
> generate-test-resources, p
> rocess-test-resources, test-compile, process-test-classes, test, 
> prepare-package
> , package, pre-integration-test, integration-test, post-integration-test, 
> verify
> , install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, 
> site
> -deploy.
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(Lifecycl
> eStarter.java:90)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
> java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Laun
> cher.java:289)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.jav
> a:229)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(La
> uncher.java:415)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:
> 356)
> [ERROR]
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> rea
> d the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/NoGoalSpecifie
> dException



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi-minifi-cpp issue #95: MINIFI-290 Refactor Tests

2017-05-19 Thread kevdoran
Github user kevdoran commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/95
  
@apiri @phrocker - update on this: 

The approach of setting a hardcoded working directory when adding tests to 
ctest in the CMakeLists.txt file proved to be too brittle. If you invoke the 
test executable directly, it fails. After some exploration, I could not find a 
way to pass the resource location to the Catch unit tests in a manner that I 
was satisfied with. Two alternatives I explored included passing the location 
as an environment variable and passing it as a command line argument. The 
environment variable approach was a no-go as it it would require us to setup 
the "test" target in CMake using something other than enable_testing() and 
instead creating our own target, which seemed undesirable at this time. The 
argument approach would require us to define our own main for Catch unit tests, 
rather than using the `#define CATCH_CONFIG_MAIN`, and because `#define 
CATCH_CONFIG_MAIN` does more than just inline a main function, I didn't want to 
do that either in case assumptions made today break with other versions of
  Catch.hpp in the future.

The benefits here seemed minor, and could not justify the extra complexity 
introduced by the workarounds I explored (IMO), so I reverted the yaml config 
to being hardcoded inline strings. For now, I recommend closing MINIFI-290 as 
"won't do" and merge this PR which has a few other changes that I cam across 
while investigating this. Alternatively, we could move MINIFI-290 back to 
"open" if we want to revisit this in the future... but I'm sure if the need 
arises we would reopen it or make a new ticket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Assigned] (NIFI-3942) IPLookupService should auto reload geo dictionary file

2017-05-19 Thread Bryan Bende (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende reassigned NIFI-3942:
-

Assignee: Bryan Bende

> IPLookupService should auto reload geo dictionary file
> --
>
> Key: NIFI-3942
> URL: https://issues.apache.org/jira/browse/NIFI-3942
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Joseph Witt
>Assignee: Bryan Bende
>
> Right now the IPLookupService introduced in NIFI-3863 loads the database 
> onEnabled for the controller service.  It needs to periodically check for a 
> new database file and reload it automatically during calls to lookup.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (NIFI-3943) Help/hover text is misaligned in the Scope drop-down in the Enable Controller Service dialog

2017-05-19 Thread Andrew Lim (JIRA)
Andrew Lim created NIFI-3943:


 Summary: Help/hover text is misaligned in the Scope drop-down in 
the Enable Controller Service dialog
 Key: NIFI-3943
 URL: https://issues.apache.org/jira/browse/NIFI-3943
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core UI
Affects Versions: 1.2.0
 Environment: Chrome Version 58.0.3029.110 (64-bit)
Reporter: Andrew Lim
Priority: Trivial


When hovering over the "?" icons in the Scope drop-down, the help text that 
appears higher than it should.  It is especially confusing for the help for 
"Service and referencing components", as the text appears closer to the 
"Service Only" option.

Screenshot attached.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (NIFI-3943) Help/hover text is misaligned in the Scope drop-down in the Enable Controller Service dialog

2017-05-19 Thread Andrew Lim (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim updated NIFI-3943:
-
Attachment: NIFI-3943.png

> Help/hover text is misaligned in the Scope drop-down in the Enable Controller 
> Service dialog
> 
>
> Key: NIFI-3943
> URL: https://issues.apache.org/jira/browse/NIFI-3943
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.2.0
> Environment: Chrome Version 58.0.3029.110 (64-bit)
>Reporter: Andrew Lim
>Priority: Trivial
> Attachments: NIFI-3943.png
>
>
> When hovering over the "?" icons in the Scope drop-down, the help text that 
> appears higher than it should.  It is especially confusing for the help for 
> "Service and referencing components", as the text appears closer to the 
> "Service Only" option.
> Screenshot attached.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (NIFI-3943) Help/hover text is misaligned in the Scope drop-down in the Enable Controller Service dialog

2017-05-19 Thread Andrew Lim (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim updated NIFI-3943:
-
Description: 
When hovering over the "?" icons in the Scope drop-down, the help text appears 
higher than it should.  It is especially confusing for the help text for 
"Service and referencing components", as the text appears closer to the 
"Service Only" option.

Screenshot attached.

  was:
When hovering over the "?" icons in the Scope drop-down, the help text that 
appears higher than it should.  It is especially confusing for the help for 
"Service and referencing components", as the text appears closer to the 
"Service Only" option.

Screenshot attached.


> Help/hover text is misaligned in the Scope drop-down in the Enable Controller 
> Service dialog
> 
>
> Key: NIFI-3943
> URL: https://issues.apache.org/jira/browse/NIFI-3943
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.2.0
> Environment: Chrome Version 58.0.3029.110 (64-bit)
>Reporter: Andrew Lim
>Priority: Trivial
> Attachments: NIFI-3943.png
>
>
> When hovering over the "?" icons in the Scope drop-down, the help text 
> appears higher than it should.  It is especially confusing for the help text 
> for "Service and referencing components", as the text appears closer to the 
> "Service Only" option.
> Screenshot attached.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi-minifi-cpp issue #95: MINIFI-290 Refactor Tests

2017-05-19 Thread apiri
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/95
  
@kevdoran thanks for all the thought process and rationale.  totally seems 
fair. will review the updates.  thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp pull request #95: MINIFI-290 Refactor Tests

2017-05-19 Thread apiri
Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/95#discussion_r117497192
  
--- Diff: libminifi/test/TestBase.h ---
@@ -29,6 +29,13 @@
 #include "core/Core.h"
 #include "properties/Configure.h"
 
+/* Defining the root location of test resource files here in case it 
moves.   *
--- End diff --

Is this a relic of the original approach?  Don't believe it's currently 
being used any more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp pull request #95: MINIFI-290 Refactor Tests

2017-05-19 Thread kevdoran
Github user kevdoran commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/95#discussion_r117498245
  
--- Diff: libminifi/test/TestBase.h ---
@@ -29,6 +29,13 @@
 #include "core/Core.h"
 #include "properties/Configure.h"
 
+/* Defining the root location of test resource files here in case it 
moves.   *
--- End diff --

Good catch! Will push a commit removing that to my branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1828: NIFI-3938: Added ScriptedLookupService, some refact...

2017-05-19 Thread mattyb149
GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/1828

NIFI-3938: Added ScriptedLookupService, some refactor for reusable 
scripting classes

Moved some code common to scripted ControllerServices out into 
AbstractScriptedControllerService. Also the Scripting helper classes were in 
the processor package but are useful elsewhere, so I moved that and changed the 
visibility of some protected methods.

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-3938

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1828


commit e3eb44fa1d6be545528e1985359b0cc57f5c6e0a
Author: Matt Burgess 
Date:   2017-05-19T14:46:26Z

NIFI-3938: Added ScriptedLookupService, some refactor for reusable 
scripting classes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3938) Add a ScriptedLookupService

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017487#comment-16017487
 ] 

ASF GitHub Bot commented on NIFI-3938:
--

GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/1828

NIFI-3938: Added ScriptedLookupService, some refactor for reusable 
scripting classes

Moved some code common to scripted ControllerServices out into 
AbstractScriptedControllerService. Also the Scripting helper classes were in 
the processor package but are useful elsewhere, so I moved that and changed the 
visibility of some protected methods.

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-3938

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1828


commit e3eb44fa1d6be545528e1985359b0cc57f5c6e0a
Author: Matt Burgess 
Date:   2017-05-19T14:46:26Z

NIFI-3938: Added ScriptedLookupService, some refactor for reusable 
scripting classes




> Add a ScriptedLookupService
> ---
>
> Key: NIFI-3938
> URL: https://issues.apache.org/jira/browse/NIFI-3938
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>
> NIFI-3863 aims to implement a LookupRecord processor along with two 
> implementations of LookupServices, one for enriching records with Geo 
> information from IP addresses, and a static one from a list of provided 
> key/value pairs.
> A very flexible and powerful improvement would be to offer a 
> ScriptedLookupService, where the same scripting capabilities that are 
> available to InvokeScriptedProcessor, ScriptedReader and 
> ScriptedRecordSetWriter are available to prototype/implement a LookupService 
> for use by the LookupRecord processor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (NIFI-3938) Add a ScriptedLookupService

2017-05-19 Thread Matt Burgess (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-3938:
---
Status: Patch Available  (was: In Progress)

> Add a ScriptedLookupService
> ---
>
> Key: NIFI-3938
> URL: https://issues.apache.org/jira/browse/NIFI-3938
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>
> NIFI-3863 aims to implement a LookupRecord processor along with two 
> implementations of LookupServices, one for enriching records with Geo 
> information from IP addresses, and a static one from a list of provided 
> key/value pairs.
> A very flexible and powerful improvement would be to offer a 
> ScriptedLookupService, where the same scripting capabilities that are 
> available to InvokeScriptedProcessor, ScriptedReader and 
> ScriptedRecordSetWriter are available to prototype/implement a LookupService 
> for use by the LookupRecord processor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi-minifi-cpp issue #95: MINIFI-290 Refactor Tests

2017-05-19 Thread kevdoran
Github user kevdoran commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/95
  
Updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #95: MINIFI-290 Refactor Tests

2017-05-19 Thread apiri
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/95
  
@kevdoran cool, thanks will get merged!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Assigned] (NIFI-3944) Update documentation for functionality related to Component Versions

2017-05-19 Thread Andrew Lim (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim reassigned NIFI-3944:


Assignee: Andrew Lim

> Update documentation for functionality related to Component Versions
> 
>
> Key: NIFI-3944
> URL: https://issues.apache.org/jira/browse/NIFI-3944
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Affects Versions: 1.2.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Minor
>
> Component Versions was added in 1.2.0 and a new section in the User Guide was 
> created to describe this functionality (NIFI-3773).  There are other areas of 
> the documentation that are affected that should be updated.  Some examples:
> -Add Processor dialog
> -Add Processor settings tab
> -Processors on the canvas
> (Note: Related updates to Controller Services and Reporting Task 
> documentation were made via NIFI-3911)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (NIFI-3944) Update documentation for functionality related to Component Versions

2017-05-19 Thread Andrew Lim (JIRA)
Andrew Lim created NIFI-3944:


 Summary: Update documentation for functionality related to 
Component Versions
 Key: NIFI-3944
 URL: https://issues.apache.org/jira/browse/NIFI-3944
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Documentation & Website
Affects Versions: 1.2.0
Reporter: Andrew Lim
Priority: Minor


Component Versions was added in 1.2.0 and a new section in the User Guide was 
created to describe this functionality (NIFI-3773).  There are other areas of 
the documentation that are affected that should be updated.  Some examples:

-Add Processor dialog
-Add Processor settings tab
-Processors on the canvas

(Note: Related updates to Controller Services and Reporting Task documentation 
were made via NIFI-3911)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (NIFI-3945) Improve documentation around security for 0.10 Kafka processors

2017-05-19 Thread Bryan Bende (JIRA)
Bryan Bende created NIFI-3945:
-

 Summary: Improve documentation around security for 0.10 Kafka 
processors
 Key: NIFI-3945
 URL: https://issues.apache.org/jira/browse/NIFI-3945
 Project: Apache NiFi
  Issue Type: Improvement
Affects Versions: 1.2.0
Reporter: Bryan Bende
Assignee: Bryan Bende
Priority: Minor
 Fix For: 1.3.0


Based on a mailing list thread around using Kafka processors with Kerberos 
while also using HDFS processors with Kerberos, we should improve the 
documentation for the various security protocol options in the Kafka 
processors, and document any known limitations/issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi-minifi-cpp pull request #95: MINIFI-290 Refactor Tests

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1829: NIFI-3945 Adding documentaion about security protoc...

2017-05-19 Thread bbende
GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/1829

NIFI-3945 Adding documentaion about security protocols to Kafka 0.10 …

…processors

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi kafka-security-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1829


commit 0cd6dae049873d4a3bdd058aef0758653912c885
Author: Bryan Bende 
Date:   2017-05-19T13:37:34Z

NIFI-3945 Adding documentaion about security protocols to Kafka 0.10 
processors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3945) Improve documentation around security for 0.10 Kafka processors

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017542#comment-16017542
 ] 

ASF GitHub Bot commented on NIFI-3945:
--

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/1829

NIFI-3945 Adding documentaion about security protocols to Kafka 0.10 …

…processors

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi kafka-security-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1829


commit 0cd6dae049873d4a3bdd058aef0758653912c885
Author: Bryan Bende 
Date:   2017-05-19T13:37:34Z

NIFI-3945 Adding documentaion about security protocols to Kafka 0.10 
processors




> Improve documentation around security for 0.10 Kafka processors
> ---
>
> Key: NIFI-3945
> URL: https://issues.apache.org/jira/browse/NIFI-3945
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
> Fix For: 1.3.0
>
>
> Based on a mailing list thread around using Kafka processors with Kerberos 
> while also using HDFS processors with Kerberos, we should improve the 
> documentation for the various security protocol options in the Kafka 
> processors, and document any known limitations/issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi issue #1828: NIFI-3938: Added ScriptedLookupService, some refactor for ...

2017-05-19 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1828
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3938) Add a ScriptedLookupService

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017620#comment-16017620
 ] 

ASF GitHub Bot commented on NIFI-3938:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1828
  
Reviewing...


> Add a ScriptedLookupService
> ---
>
> Key: NIFI-3938
> URL: https://issues.apache.org/jira/browse/NIFI-3938
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>
> NIFI-3863 aims to implement a LookupRecord processor along with two 
> implementations of LookupServices, one for enriching records with Geo 
> information from IP addresses, and a static one from a list of provided 
> key/value pairs.
> A very flexible and powerful improvement would be to offer a 
> ScriptedLookupService, where the same scripting capabilities that are 
> available to InvokeScriptedProcessor, ScriptedReader and 
> ScriptedRecordSetWriter are available to prototype/implement a LookupService 
> for use by the LookupRecord processor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi-minifi-cpp issue #97: MINIFI-289: Update test folder to apply linter an...

2017-05-19 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/97
  
@apiri rebase complete. Waiting on travis to prove me right/wrong...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #97: MINIFI-289: Update test folder to apply linter an...

2017-05-19 Thread apiri
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/97
  
@phrocker good deal, thanks!  Looks like Travis is happy.  Will scope out 
from my side to see if that apiri guy is happy too and get this wrapped up


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #97: MINIFI-289: Update test folder to apply linter an...

2017-05-19 Thread apiri
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/97
  
looks good, merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp pull request #97: MINIFI-289: Update test folder to apply li...

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #100: MINIFI-320: Move instantiation of OpenSSL to a s...

2017-05-19 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/100
  
@apiri this PR is ready for review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1829: NIFI-3945 Adding documentaion about security protoc...

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1829


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3945) Improve documentation around security for 0.10 Kafka processors

2017-05-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017761#comment-16017761
 ] 

ASF subversion and git services commented on NIFI-3945:
---

Commit d4f0c1d048f0539a226b4b5ce33b9d172402f50e in nifi's branch 
refs/heads/master from [~bbende]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d4f0c1d ]

NIFI-3945 This closes #1829. Adding documentaion about security protocols to 
Kafka 0.10 processors

Signed-off-by: joewitt 


> Improve documentation around security for 0.10 Kafka processors
> ---
>
> Key: NIFI-3945
> URL: https://issues.apache.org/jira/browse/NIFI-3945
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
> Fix For: 1.3.0
>
>
> Based on a mailing list thread around using Kafka processors with Kerberos 
> while also using HDFS processors with Kerberos, we should improve the 
> documentation for the various security protocol options in the Kafka 
> processors, and document any known limitations/issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3945) Improve documentation around security for 0.10 Kafka processors

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017762#comment-16017762
 ] 

ASF GitHub Bot commented on NIFI-3945:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1829


> Improve documentation around security for 0.10 Kafka processors
> ---
>
> Key: NIFI-3945
> URL: https://issues.apache.org/jira/browse/NIFI-3945
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
> Fix For: 1.3.0
>
>
> Based on a mailing list thread around using Kafka processors with Kerberos 
> while also using HDFS processors with Kerberos, we should improve the 
> documentation for the various security protocol options in the Kafka 
> processors, and document any known limitations/issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (NIFI-3945) Improve documentation around security for 0.10 Kafka processors

2017-05-19 Thread Joseph Witt (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Witt resolved NIFI-3945.
---
Resolution: Fixed

+1 merged to master.  Thanks!

> Improve documentation around security for 0.10 Kafka processors
> ---
>
> Key: NIFI-3945
> URL: https://issues.apache.org/jira/browse/NIFI-3945
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
> Fix For: 1.3.0
>
>
> Based on a mailing list thread around using Kafka processors with Kerberos 
> while also using HDFS processors with Kerberos, we should improve the 
> documentation for the various security protocol options in the Kafka 
> processors, and document any known limitations/issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi issue #1828: NIFI-3938: Added ScriptedLookupService, some refactor for ...

2017-05-19 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1828
  
Built with `contrib-check` and all tests pass. With Matt's help, I created 
a schema registry with a defined schema, generated flowfiles with CSV formatted 
data (a hockey roster), and used `SplitRecord` with the `CSVReader` and 
`CSVRecordSetWriter` controller services to split the data into individual 
flowfiles, then used `LookupRecord` with `ScriptedLookupService` and wrote a 
custom Groovy implementation which performed position lookups. Finally, I 
output the enriched flowfiles to a `ConvertRecord` processor which wrote them 
out in JSON. 

Looks very useful and I think this will make a lot of people's flows more 
powerful. Thanks Matt. 

+1, merging. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3938) Add a ScriptedLookupService

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017785#comment-16017785
 ] 

ASF GitHub Bot commented on NIFI-3938:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1828
  
Built with `contrib-check` and all tests pass. With Matt's help, I created 
a schema registry with a defined schema, generated flowfiles with CSV formatted 
data (a hockey roster), and used `SplitRecord` with the `CSVReader` and 
`CSVRecordSetWriter` controller services to split the data into individual 
flowfiles, then used `LookupRecord` with `ScriptedLookupService` and wrote a 
custom Groovy implementation which performed position lookups. Finally, I 
output the enriched flowfiles to a `ConvertRecord` processor which wrote them 
out in JSON. 

Looks very useful and I think this will make a lot of people's flows more 
powerful. Thanks Matt. 

+1, merging. 


> Add a ScriptedLookupService
> ---
>
> Key: NIFI-3938
> URL: https://issues.apache.org/jira/browse/NIFI-3938
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>
> NIFI-3863 aims to implement a LookupRecord processor along with two 
> implementations of LookupServices, one for enriching records with Geo 
> information from IP addresses, and a static one from a list of provided 
> key/value pairs.
> A very flexible and powerful improvement would be to offer a 
> ScriptedLookupService, where the same scripting capabilities that are 
> available to InvokeScriptedProcessor, ScriptedReader and 
> ScriptedRecordSetWriter are available to prototype/implement a LookupService 
> for use by the LookupRecord processor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3938) Add a ScriptedLookupService

2017-05-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017786#comment-16017786
 ] 

ASF subversion and git services commented on NIFI-3938:
---

Commit 9294a2613913f28789a1989744c5c79108768eeb in nifi's branch 
refs/heads/master from [~mattyb149]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9294a26 ]

NIFI-3938: Added ScriptedLookupService, some refactor for reusable scripting 
classes

This closes #1828.

Signed-off-by: Andy LoPresto 


> Add a ScriptedLookupService
> ---
>
> Key: NIFI-3938
> URL: https://issues.apache.org/jira/browse/NIFI-3938
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>
> NIFI-3863 aims to implement a LookupRecord processor along with two 
> implementations of LookupServices, one for enriching records with Geo 
> information from IP addresses, and a static one from a list of provided 
> key/value pairs.
> A very flexible and powerful improvement would be to offer a 
> ScriptedLookupService, where the same scripting capabilities that are 
> available to InvokeScriptedProcessor, ScriptedReader and 
> ScriptedRecordSetWriter are available to prototype/implement a LookupService 
> for use by the LookupRecord processor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi pull request #1828: NIFI-3938: Added ScriptedLookupService, some refact...

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1828


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3938) Add a ScriptedLookupService

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017788#comment-16017788
 ] 

ASF GitHub Bot commented on NIFI-3938:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1828


> Add a ScriptedLookupService
> ---
>
> Key: NIFI-3938
> URL: https://issues.apache.org/jira/browse/NIFI-3938
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>
> NIFI-3863 aims to implement a LookupRecord processor along with two 
> implementations of LookupServices, one for enriching records with Geo 
> information from IP addresses, and a static one from a list of provided 
> key/value pairs.
> A very flexible and powerful improvement would be to offer a 
> ScriptedLookupService, where the same scripting capabilities that are 
> available to InvokeScriptedProcessor, ScriptedReader and 
> ScriptedRecordSetWriter are available to prototype/implement a LookupService 
> for use by the LookupRecord processor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (NIFI-3938) Add a ScriptedLookupService

2017-05-19 Thread Andy LoPresto (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy LoPresto updated NIFI-3938:

   Resolution: Fixed
Fix Version/s: 1.3.0
   Status: Resolved  (was: Patch Available)

> Add a ScriptedLookupService
> ---
>
> Key: NIFI-3938
> URL: https://issues.apache.org/jira/browse/NIFI-3938
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
> Fix For: 1.3.0
>
>
> NIFI-3863 aims to implement a LookupRecord processor along with two 
> implementations of LookupServices, one for enriching records with Geo 
> information from IP addresses, and a static one from a list of provided 
> key/value pairs.
> A very flexible and powerful improvement would be to offer a 
> ScriptedLookupService, where the same scripting capabilities that are 
> available to InvokeScriptedProcessor, ScriptedReader and 
> ScriptedRecordSetWriter are available to prototype/implement a LookupService 
> for use by the LookupRecord processor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread Joseph Witt (JIRA)
Joseph Witt created NIFI-3946:
-

 Summary: Should update LookupRecord to allow multi criteria lookups
 Key: NIFI-3946
 URL: https://issues.apache.org/jira/browse/NIFI-3946
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Joseph Witt


At present the LookupRecord processor allows a single criteria lookup.

We need to provide a lookup API which takes a map of string key/values that a 
given lookup can use when searching for the result. The LookupRecord processor 
should change such that all dynamic properties are the loookup key names with 
values that are the RecordPath to find the value for that given key. The 
resulting map would be passed to the lookup service. Also the lookup service 
API should allow returning the set of required key names so that the processor 
can validate once all required keys have RecordPaths to search for values.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (NIFI-3947) MergeContent when merging avro and not receiving avro handles the failure improperly

2017-05-19 Thread Joseph Witt (JIRA)
Joseph Witt created NIFI-3947:
-

 Summary: MergeContent when merging avro and not receiving avro 
handles the failure improperly
 Key: NIFI-3947
 URL: https://issues.apache.org/jira/browse/NIFI-3947
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Joseph Witt


2017-05-19 11:09:31,601 ERROR [Timer-Driven Process Thread-3] 
o.a.n.processors.standard.MergeContent 
MergeContent[id=21afec4c-015c-1000--48ddee06] Failed to process bundle 
of 206 files due to org.
apache.nifi.processor.exception.ProcessException: IOException thrown from 
MergeContent[id=21afec4c-015c-1000--48ddee06]: java.io.IOException: Not 
a data file.: org.apache.nifi.processor.exception.
ProcessException: IOException thrown from 
MergeContent[id=21afec4c-015c-1000--48ddee06]: java.io.IOException: Not 
a data file.
2017-05-19 11:09:31,602 ERROR [Timer-Driven Process Thread-3] 
o.a.n.processors.standard.MergeContent
org.apache.nifi.processor.exception.ProcessException: IOException thrown from 
MergeContent[id=21afec4c-015c-1000--48ddee06]: java.io.IOException: Not 
a data file.
at 
org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2105)
 ~[na:na]
at 
org.apache.nifi.processors.standard.MergeContent$AvroMerge$1.process(MergeContent.java:885)
 ~[nifi-standard-processors-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2329)
 ~[na:na]
at 
org.apache.nifi.processors.standard.MergeContent$AvroMerge.merge(MergeContent.java:880)
 ~[nifi-standard-processors-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.processors.standard.MergeContent.processBin(MergeContent.java:459)
 ~[nifi-standard-processors-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.processor.util.bin.BinFiles.processBins(BinFiles.java:231) 
[nifi-processor-utils-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.processor.util.bin.BinFiles.onTrigger(BinFiles.java:191) 
[nifi-processor-utils-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1099)
 [nifi-framework-core-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:136)
 [nifi-framework-core-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
 [nifi-framework-core-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:132)
 [nifi-framework-core-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[na:1.8.0_91]
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) 
[na:1.8.0_91]
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
 [na:1.8.0_91]
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
 [na:1.8.0_91]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[na:1.8.0_91]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[na:1.8.0_91]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_91]
Caused by: java.io.IOException: Not a data file.
at 
org.apache.avro.file.DataFileStream.initialize(DataFileStream.java:105) 
~[avro-1.7.7.jar:1.7.7]
at org.apache.avro.file.DataFileStream.(DataFileStream.java:84) 
~[avro-1.7.7.jar:1.7.7]
at 
org.apache.nifi.processors.standard.MergeContent$AvroMerge$1$1.process(MergeContent.java:889)
 ~[nifi-standard-processors-1.1.0.2.1.0.0-165.jar:1.1.0.2.1.0.0-165]
at 
org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2082)
 ~[na:na]
... 17 common frames omitted
2017-05-19 11:09:31,603 ERROR [Timer-Driven Process Thread-3] 
o.a.n.processors.standard.MergeContent 
MergeContent[id=21afec4c-015c-1000--48ddee06] 
MergeContent[id=21afec4c-015c-1000--48dde
e06] failed to process session due to 
org.apache.nifi.processor.exception.FlowFileHandlingException: 
StandardFlowFileRecord[uuid=cc1b1ad8-d556-43b0-bb48-31fb7f62e308,claim=,offset=0,name=846915345633862,s
ize=0] transfer relationship not specified: 
org.apache.nifi.processor.exception.FlowFileHandlingException: 
StandardFlowFileRecord[uuid=cc1b1ad8-d556-43b0-bb48-31fb7f62e308,claim=,offset=0,name=846915345633862,size=0]
 transfer relationship not specified
2017-05-19 11:09:31,603 ERROR [T

[jira] [Assigned] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread Mark Payne (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Payne reassigned NIFI-3946:


Assignee: Mark Payne

> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (NIFI-3854) Expand expression language support for Kafka processors

2017-05-19 Thread Joseph Witt (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Witt updated NIFI-3854:
--
Fix Version/s: 1.3.0

> Expand expression language support for Kafka processors
> ---
>
> Key: NIFI-3854
> URL: https://issues.apache.org/jira/browse/NIFI-3854
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Tim Reardon
>Priority: Minor
> Fix For: 1.3.0
>
>
> Expand expression language support for Kafka processors:
> - brokers / zookeepers
> - topic



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3854) Expand expression language support for Kafka processors

2017-05-19 Thread Joseph Witt (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017853#comment-16017853
 ] 

Joseph Witt commented on NIFI-3854:
---

reviewing.  But looks good to go

> Expand expression language support for Kafka processors
> ---
>
> Key: NIFI-3854
> URL: https://issues.apache.org/jira/browse/NIFI-3854
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Tim Reardon
>Priority: Minor
> Fix For: 1.3.0
>
>
> Expand expression language support for Kafka processors:
> - brokers / zookeepers
> - topic



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread Joey Frazee (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017878#comment-16017878
 ] 

Joey Frazee commented on NIFI-3946:
---

[~joewitt] Is the suggestion to allow multiple lookups simultaneously or to do 
lookups with multiple constraints such that the map is basically like the 
conjunction of conditions in a WHERE clause? If it's the latter then won't you 
box out the case where you're using individual dynamic properties to do several 
lookups? Both seem like valid approaches so it might make sense to just have a 
flag that says which mode it's in rather than only do multi criteria lookups 
(if I've understood it correctly even).

> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread Joseph Witt (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017885#comment-16017885
 ] 

Joseph Witt commented on NIFI-3946:
---

Joey in this case I'm suggesting it is a multi condition WHERE clause case.  
The nature of the processor is that the result of the lookup goes into a single 
RecordPath specified location.  I think if we want to offer multiple lookups 
and once with different destinations we'll need to have an additional processor 
for that use case. Not sure what we'd want to do there for UX such that someone 
could have multiple RecordPath pairs for lookup value, replacement target.

But under the nature of the current processor being able to do multi criteria 
lookups for a single result will be really powerful.  Good case is if I have a 
geo of lat and lon I can grab both values and do a lookup that gives me a 
reverse geo code.  This goes very nicely with the scripted lookup service.

> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi-minifi-cpp issue #100: MINIFI-320: Move instantiation of OpenSSL to a s...

2017-05-19 Thread apiri
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/100
  
reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1830: NIFI-3404 Add lookup processor for enrichments/join...

2017-05-19 Thread jfrazee
GitHub user jfrazee opened a pull request:

https://github.com/apache/nifi/pull/1830

NIFI-3404 Add lookup processor for enrichments/joins to reference data

Note: This is overlaid on 
[NIFI-3339](https://issues.apache.org/jira/browse/NIFI-3339)/#1450.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jfrazee/nifi NIFI-3404

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1830


commit 449f33ca5379b22f8dc4b7ba0042481c46129045
Author: Joey Frazee 
Date:   2017-05-19T16:45:14Z

NIFI-3404 Added properties and csv file lookup services

commit f2cda5c47c19b1d95a8813c2c79329f49537da1a
Author: Joey Frazee 
Date:   2017-05-19T17:49:24Z

NIFI-3404 Added LookupAttribute processor, L&N fixes

commit 64e03e344432665b7b4184405335f62221c3e93a
Author: Toivo Adams 
Date:   2017-01-29T11:40:37Z

NIFI-3339 Add getDataSource() to DBCPService

This closes #1450

Signed-off-by: Joey Frazee 

commit c3b7e2e76eb38500c02e42676cfe1bcaa0b2291d
Author: Joey Frazee 
Date:   2017-05-19T18:32:41Z

NIFI-3404 Added database lookup service




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3404) Add lookup processor for enrichments/joins to reference data

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017895#comment-16017895
 ] 

ASF GitHub Bot commented on NIFI-3404:
--

GitHub user jfrazee opened a pull request:

https://github.com/apache/nifi/pull/1830

NIFI-3404 Add lookup processor for enrichments/joins to reference data

Note: This is overlaid on 
[NIFI-3339](https://issues.apache.org/jira/browse/NIFI-3339)/#1450.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jfrazee/nifi NIFI-3404

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1830


commit 449f33ca5379b22f8dc4b7ba0042481c46129045
Author: Joey Frazee 
Date:   2017-05-19T16:45:14Z

NIFI-3404 Added properties and csv file lookup services

commit f2cda5c47c19b1d95a8813c2c79329f49537da1a
Author: Joey Frazee 
Date:   2017-05-19T17:49:24Z

NIFI-3404 Added LookupAttribute processor, L&N fixes

commit 64e03e344432665b7b4184405335f62221c3e93a
Author: Toivo Adams 
Date:   2017-01-29T11:40:37Z

NIFI-3339 Add getDataSource() to DBCPService

This closes #1450

Signed-off-by: Joey Frazee 

commit c3b7e2e76eb38500c02e42676cfe1bcaa0b2291d
Author: Joey Frazee 
Date:   2017-05-19T18:32:41Z

NIFI-3404 Added database lookup service




> Add lookup processor for enrichments/joins to reference data
> 
>
> Key: NIFI-3404
> URL: https://issues.apache.org/jira/browse/NIFI-3404
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>
> NiFi doesn't currently have an easy, concise way of doing enrichment, joining 
> against reference data sets or performing attribute lookups against external 
> data sources.
> Since enrichments and joins are basic streaming use cases, and since 
> attributes and EL are often used to parameterize processor properties, there 
> is a need for an easy way to do enrichments, joins and lookups without having 
> to write code or create a lengthy data flow.
> There's been some discussion of this on the mailing list [1] and I've started 
> work on a LookupAttribute [2] processor that delegates the work to controller 
> services.
> 1. 
> https://lists.apache.org/thread.html/74321ff0e9e0b7339e43ad53b36119315dc5094991605edfb12b34d0@%3Cdev.nifi.apache.org%3E
> 2. https://github.com/jfrazee/nifi-lookup-service



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi pull request #1831: NIFI-3942 Making IPLookupService reload the databas...

2017-05-19 Thread bbende
GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/1831

NIFI-3942 Making IPLookupService reload the database file on the fly …

…when detecting the file has changed

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-3942

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1831


commit 560d1000a9079a38ed0d0ad5e60aa023eaaa41a9
Author: Bryan Bende 
Date:   2017-05-19T19:06:48Z

NIFI-3942 Making IPLookupService reload the database file on the fly when 
detecting the file has changed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (NIFI-3942) IPLookupService should auto reload geo dictionary file

2017-05-19 Thread Bryan Bende (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-3942:
--
Status: Patch Available  (was: Open)

> IPLookupService should auto reload geo dictionary file
> --
>
> Key: NIFI-3942
> URL: https://issues.apache.org/jira/browse/NIFI-3942
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Joseph Witt
>Assignee: Bryan Bende
>
> Right now the IPLookupService introduced in NIFI-3863 loads the database 
> onEnabled for the controller service.  It needs to periodically check for a 
> new database file and reload it automatically during calls to lookup.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3942) IPLookupService should auto reload geo dictionary file

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017910#comment-16017910
 ] 

ASF GitHub Bot commented on NIFI-3942:
--

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/1831

NIFI-3942 Making IPLookupService reload the database file on the fly …

…when detecting the file has changed

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-3942

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1831


commit 560d1000a9079a38ed0d0ad5e60aa023eaaa41a9
Author: Bryan Bende 
Date:   2017-05-19T19:06:48Z

NIFI-3942 Making IPLookupService reload the database file on the fly when 
detecting the file has changed




> IPLookupService should auto reload geo dictionary file
> --
>
> Key: NIFI-3942
> URL: https://issues.apache.org/jira/browse/NIFI-3942
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Joseph Witt
>Assignee: Bryan Bende
>
> Right now the IPLookupService introduced in NIFI-3863 loads the database 
> onEnabled for the controller service.  It needs to periodically check for a 
> new database file and reload it automatically during calls to lookup.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread Joey Frazee (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017927#comment-16017927
 ] 

Joey Frazee commented on NIFI-3946:
---

What you describe makes a lot of sense if you're trying to do a single 
enrichment on a wide dataset (relational DBs, CSV files), but the simple CS's 
at least are also really useful for doing a bunch of independent attribute 
enrichments (on flat, narrow key-value stores; e.g., caches, properties files) 
in one go [1]. In the LookupAttribute processor here, the name of the dynamic 
property is the destination attribute name and the value is the key for the 
lookup (potentially an attribute expression).

So in [1] I took something really dumb like properties files as the base case 
and then for the DBs and CSV files you specify a key column and value column 
and it operates like a KV store.

Either way, if multi-criteria is the base case, then we need to at least have a 
sub-class to allow for a more KV-like lookup.

1. https://issues.apache.org/jira/browse/NIFI-3404

> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi pull request #1773: NIFI-3854 Expand expression language support for Ka...

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1773


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3854) Expand expression language support for Kafka processors

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017929#comment-16017929
 ] 

ASF GitHub Bot commented on NIFI-3854:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1773


> Expand expression language support for Kafka processors
> ---
>
> Key: NIFI-3854
> URL: https://issues.apache.org/jira/browse/NIFI-3854
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Tim Reardon
>Priority: Minor
> Fix For: 1.3.0
>
>
> Expand expression language support for Kafka processors:
> - brokers / zookeepers
> - topic



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3854) Expand expression language support for Kafka processors

2017-05-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017928#comment-16017928
 ] 

ASF subversion and git services commented on NIFI-3854:
---

Commit 58ce52d5d64d0599110c5b66addb1b093246f157 in nifi's branch 
refs/heads/master from [~treardon]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=58ce52d ]

NIFI-3854 This closes #1773. Expand expression language support for Kafka 
processors

Signed-off-by: joewitt 


> Expand expression language support for Kafka processors
> ---
>
> Key: NIFI-3854
> URL: https://issues.apache.org/jira/browse/NIFI-3854
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Tim Reardon
>Priority: Minor
> Fix For: 1.3.0
>
>
> Expand expression language support for Kafka processors:
> - brokers / zookeepers
> - topic



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-1452) Yield Duration can short circuit long Timer Driven Run Schedule

2017-05-19 Thread Michael Moser (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017931#comment-16017931
 ] 

Michael Moser commented on NIFI-1452:
-

This also affects GetHTTP, which yields when HTTP server responds with 304 
NOT_MODIFIED.  So a GetHTTP with Run Schedule of 10 minutes and Yield Duration 
of 1 second, actually hits the HTTP server every 1 second when the server 
replies with 304.

An example server that exhibits this behavior is 
http://archive.apache.org/icons/blank.gif

> Yield Duration can short circuit long Timer Driven Run Schedule
> ---
>
> Key: NIFI-1452
> URL: https://issues.apache.org/jira/browse/NIFI-1452
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.4.1
>Reporter: Michael Moser
>Assignee: Michael Moser
>Priority: Trivial
>
> This may be a rare use case, but I configured a GetFile processor to be Timer 
> Driven with a Run Schedule of 30 secs.  Its Yield Duration was default 1 sec. 
>  I expected GetFile onTrigger() to be called every 30 secs, but it was being 
> called every 1 sec most of the time.
> GetFile will call context.yield() when it polls a directory and gets an empty 
> list in return.  It appears that a yield will ignore the Run Schedule.  Many 
> standard processors call context.yield() when they have no work to do.
> I changed my scheduling strategy to CRON Driven with its run schedule every 
> 30 seconds, and the onTrigger() was called every 30 seconds, even after a 
> yield.  So CRON Driven scheduling is working as expected after a yield.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi pull request #1832: NIFI-1452 on timer-driven yield, use the greater of...

2017-05-19 Thread mosermw
GitHub user mosermw opened a pull request:

https://github.com/apache/nifi/pull/1832

NIFI-1452 on timer-driven yield, use the greater of yield duration or run 
schedule

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mosermw/nifi NIFI-1452

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1832


commit 7d376af5020226da8e036c602fb90cfeb0530714
Author: Mike Moser 
Date:   2017-05-19T19:48:10Z

NIFI-1452 on timer-driven yield, use the greater of yield duration or run 
schedule




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1452) Yield Duration can short circuit long Timer Driven Run Schedule

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017934#comment-16017934
 ] 

ASF GitHub Bot commented on NIFI-1452:
--

GitHub user mosermw opened a pull request:

https://github.com/apache/nifi/pull/1832

NIFI-1452 on timer-driven yield, use the greater of yield duration or run 
schedule

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mosermw/nifi NIFI-1452

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1832


commit 7d376af5020226da8e036c602fb90cfeb0530714
Author: Mike Moser 
Date:   2017-05-19T19:48:10Z

NIFI-1452 on timer-driven yield, use the greater of yield duration or run 
schedule




> Yield Duration can short circuit long Timer Driven Run Schedule
> ---
>
> Key: NIFI-1452
> URL: https://issues.apache.org/jira/browse/NIFI-1452
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.4.1
>Reporter: Michael Moser
>Assignee: Michael Moser
>Priority: Trivial
>
> This may be a rare use case, but I configured a GetFile processor to be Timer 
> Driven with a Run Schedule of 30 secs.  Its Yield Duration was default 1 sec. 
>  I expected GetFile onTrigger() to be called every 30 secs, but it was being 
> called every 1 sec most of the time.
> GetFile will call context.yield() when it polls a directory and gets an empty 
> list in return.  It appears that a yield will ignore the Run Schedule.  Many 
> standard processors call context.yield() when they have no work to do.
> I changed my scheduling strategy to CRON Driven with its run schedule every 
> 30 seconds, and the onTrigger() was called every 30 seconds, even after a 
> yield.  So CRON Driven scheduling is working as expected after a yield.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (NIFI-1452) Yield Duration can short circuit long Timer Driven Run Schedule

2017-05-19 Thread Michael Moser (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Moser updated NIFI-1452:

Status: Patch Available  (was: Open)

> Yield Duration can short circuit long Timer Driven Run Schedule
> ---
>
> Key: NIFI-1452
> URL: https://issues.apache.org/jira/browse/NIFI-1452
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.4.1
>Reporter: Michael Moser
>Assignee: Michael Moser
>Priority: Trivial
>
> This may be a rare use case, but I configured a GetFile processor to be Timer 
> Driven with a Run Schedule of 30 secs.  Its Yield Duration was default 1 sec. 
>  I expected GetFile onTrigger() to be called every 30 secs, but it was being 
> called every 1 sec most of the time.
> GetFile will call context.yield() when it polls a directory and gets an empty 
> list in return.  It appears that a yield will ignore the Run Schedule.  Many 
> standard processors call context.yield() when they have no work to do.
> I changed my scheduling strategy to CRON Driven with its run schedule every 
> 30 seconds, and the onTrigger() was called every 30 seconds, even after a 
> yield.  So CRON Driven scheduling is working as expected after a yield.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (NIFI-3948) PublishKafkaRecord_0_10 appears to no longer write messages on correct boundaries

2017-05-19 Thread Mark Payne (JIRA)
Mark Payne created NIFI-3948:


 Summary: PublishKafkaRecord_0_10 appears to no longer write 
messages on correct boundaries
 Key: NIFI-3948
 URL: https://issues.apache.org/jira/browse/NIFI-3948
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Affects Versions: 1.3.0
Reporter: Mark Payne
Assignee: Mark Payne
Priority: Critical
 Fix For: 1.3.0


This issue appears only to be a problem on master and does not affect 
previously released version of Apache NiFi. I am trying to send messages to 
Kafka using PublishKafkaRecord_0_10 with the JSON Writer. The messages appear 
not to be demarcated properly and have data missing.

It appears to be due to the JSON Writer needing to flush its output before 
creating the byte[] that we push to Kafka.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi-minifi-cpp issue #100: MINIFI-320: Move instantiation of OpenSSL to a s...

2017-05-19 Thread apiri
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/100
  
Code, build, and tests all look good.  Will get this merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp pull request #100: MINIFI-320: Move instantiation of OpenSSL...

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (NIFI-3949) NullPointerException from GrokReader

2017-05-19 Thread Bryan Bende (JIRA)
Bryan Bende created NIFI-3949:
-

 Summary: NullPointerException from GrokReader
 Key: NIFI-3949
 URL: https://issues.apache.org/jira/browse/NIFI-3949
 Project: Apache NiFi
  Issue Type: Bug
Affects Versions: 1.2.0
Reporter: Bryan Bende
Priority: Minor


When creating a GrokReader, I specified an expression of:

%\{SYSLOGBASE\}%\{GREEDYDATA:message\}

And I left the default schema strategy of "use fields from grok expression".

This resulted in an NPE:
{code}
java.lang.NullPointerException: null
at java.util.Objects.requireNonNull(Objects.java:203)
at 
org.apache.nifi.serialization.record.RecordField.(RecordField.java:50)
at 
org.apache.nifi.serialization.record.RecordField.(RecordField.java:33)
at 
org.apache.nifi.grok.GrokReader.createRecordSchema(GrokReader.java:150)
at org.apache.nifi.grok.GrokReader.preCompile(GrokReader.java:136)
{code}

This appears to be because I didn't specify a name for SYSLOGBASE, since I was 
expecting it to see what SYSLOGBASE expands to and then use and named fields 
under that. If we don't want to support that expansion, then we should at least 
validate that all parts of the Grok expression have a name.

Next I changed to using a schema defined in an AvroSchemaRegistry and 
referencing it by name, but I still got the above exception because the 
preCompile method always attempts to create a RecordSchema from the 
GrokExpression, even if you selected a different strategy.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi issue #1831: NIFI-3942 Making IPLookupService reload the database file ...

2017-05-19 Thread markap14
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/1831
  
@bbende I very much like the idea of this PR. I tried to test it out, 
though, and it didn't behave as I was hoping. 

I downloaded the GeoLite2 database for ASN and for City. I set the service 
to lookup all fields. I then copied the City database to "db.mmdb" and 
configured the lookup to load db.mmdb file. While running, I tried overwriting 
db.mmdb with the ASN database so that we can see if it reloads properly. 
Unfortunately, though, as soon as I overwrote the file, I got the following 
stack trace:

```
2017-05-19 17:02:19,287 ERROR [Timer-Driven Process Thread-4] 
o.a.n.processors.standard.LookupRecord 
LookupRecord[id=17a48af1-015c-1000-29d3-2b7ebd7d4241] Failed to process 
StandardFlowFileRecord[uuid=c25e503e-5f28-4b59-a05f-7462df2424b8,claim=StandardContentClaim
 [resourceClaim=StandardResourceClaim[id=1495227698674-1, container=default, 
section=1], offset=36678, length=91],offset=0,name=1599597234048490,size=91]: 
org.apache.nifi.processor.exception.ProcessException: Failed to lookup value 
'216.58.195.228' in Lookup Service
org.apache.nifi.processor.exception.ProcessException: Failed to lookup 
value '216.58.195.228' in Lookup Service
at 
org.apache.nifi.processors.standard.LookupRecord.route(LookupRecord.java:218)
at 
org.apache.nifi.processors.standard.LookupRecord.route(LookupRecord.java:58)
at 
org.apache.nifi.processors.standard.AbstractRouteRecord$1.process(AbstractRouteRecord.java:136)
at 
org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2136)
at 
org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2106)
at 
org.apache.nifi.processors.standard.AbstractRouteRecord.onTrigger(AbstractRouteRecord.java:129)
at 
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at 
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1120)
at 
org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:144)
at 
org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
at 
org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:132)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.nifi.lookup.LookupFailureException: Failed to lookup 
City information for IP Address /216.58.195.228
at 
org.apache.nifi.lookup.maxmind.IPLookupService.lookup(IPLookupService.java:211)
at sun.reflect.GeneratedMethodAccessor349.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:89)
at com.sun.proxy.$Proxy77.lookup(Unknown Source)
at 
org.apache.nifi.processors.standard.LookupRecord.route(LookupRecord.java:216)
... 17 common frames omitted
Caused by: com.maxmind.db.InvalidDatabaseException: The MaxMind DB file's 
search tree is corrupt: contains pointer larger than the database.
at com.maxmind.db.Reader.resolveDataPointer(Reader.java:196)
at com.maxmind.db.Reader.get(Reader.java:103)
at 
org.apache.nifi.lookup.maxmind.DatabaseReader.get(DatabaseReader.java:150)
at 
org.apache.nifi.lookup.maxmind.DatabaseReader.city(DatabaseReader.java:194)
at 
org.apache.nifi.lookup.maxmind.IPLookupService.lookup(IPLookupService.java:209)
... 23 common frames omitted
```

If we are going to support reloading, then we need to support having the 
file overwritten. I think we should wrap the entire lookup method in a 
try/catch and catch InvalidDatabaseException. If this is caught, we should 
reload the database and try again. If it fails a second time, then we should 
just throw a LookupFailedException. Thoughts?


---
If your project is set up for it, you can r

[jira] [Commented] (NIFI-3942) IPLookupService should auto reload geo dictionary file

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018025#comment-16018025
 ] 

ASF GitHub Bot commented on NIFI-3942:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/1831
  
@bbende I very much like the idea of this PR. I tried to test it out, 
though, and it didn't behave as I was hoping. 

I downloaded the GeoLite2 database for ASN and for City. I set the service 
to lookup all fields. I then copied the City database to "db.mmdb" and 
configured the lookup to load db.mmdb file. While running, I tried overwriting 
db.mmdb with the ASN database so that we can see if it reloads properly. 
Unfortunately, though, as soon as I overwrote the file, I got the following 
stack trace:

```
2017-05-19 17:02:19,287 ERROR [Timer-Driven Process Thread-4] 
o.a.n.processors.standard.LookupRecord 
LookupRecord[id=17a48af1-015c-1000-29d3-2b7ebd7d4241] Failed to process 
StandardFlowFileRecord[uuid=c25e503e-5f28-4b59-a05f-7462df2424b8,claim=StandardContentClaim
 [resourceClaim=StandardResourceClaim[id=1495227698674-1, container=default, 
section=1], offset=36678, length=91],offset=0,name=1599597234048490,size=91]: 
org.apache.nifi.processor.exception.ProcessException: Failed to lookup value 
'216.58.195.228' in Lookup Service
org.apache.nifi.processor.exception.ProcessException: Failed to lookup 
value '216.58.195.228' in Lookup Service
at 
org.apache.nifi.processors.standard.LookupRecord.route(LookupRecord.java:218)
at 
org.apache.nifi.processors.standard.LookupRecord.route(LookupRecord.java:58)
at 
org.apache.nifi.processors.standard.AbstractRouteRecord$1.process(AbstractRouteRecord.java:136)
at 
org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2136)
at 
org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2106)
at 
org.apache.nifi.processors.standard.AbstractRouteRecord.onTrigger(AbstractRouteRecord.java:129)
at 
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at 
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1120)
at 
org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:144)
at 
org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
at 
org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:132)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.nifi.lookup.LookupFailureException: Failed to lookup 
City information for IP Address /216.58.195.228
at 
org.apache.nifi.lookup.maxmind.IPLookupService.lookup(IPLookupService.java:211)
at sun.reflect.GeneratedMethodAccessor349.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:89)
at com.sun.proxy.$Proxy77.lookup(Unknown Source)
at 
org.apache.nifi.processors.standard.LookupRecord.route(LookupRecord.java:216)
... 17 common frames omitted
Caused by: com.maxmind.db.InvalidDatabaseException: The MaxMind DB file's 
search tree is corrupt: contains pointer larger than the database.
at com.maxmind.db.Reader.resolveDataPointer(Reader.java:196)
at com.maxmind.db.Reader.get(Reader.java:103)
at 
org.apache.nifi.lookup.maxmind.DatabaseReader.get(DatabaseReader.java:150)
at 
org.apache.nifi.lookup.maxmind.DatabaseReader.city(DatabaseReader.java:194)
at 
org.apache.nifi.lookup.maxmind.IPLookupService.lookup(IPLookupService.java:209)
... 23 common frames omitted
```

If we are going to support reloading, then we need to support having the 
file overwritten. I think we should wrap the entire lookup method in

[GitHub] nifi pull request #1833: NIFI-3946: Update LookupService to take a Map inste...

2017-05-19 Thread markap14
GitHub user markap14 opened a pull request:

https://github.com/apache/nifi/pull/1833

NIFI-3946: Update LookupService to take a Map instead of a String for…

… the input

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markap14/nifi NIFI-3946

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1833


commit d981ac0ea6f45290459122a696457555a1cc3c8a
Author: Mark Payne 
Date:   2017-05-19T20:42:51Z

NIFI-3946: Update LookupService to take a Map instead of a String for the 
input




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018028#comment-16018028
 ] 

ASF GitHub Bot commented on NIFI-3946:
--

GitHub user markap14 opened a pull request:

https://github.com/apache/nifi/pull/1833

NIFI-3946: Update LookupService to take a Map instead of a String for…

… the input

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markap14/nifi NIFI-3946

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1833


commit d981ac0ea6f45290459122a696457555a1cc3c8a
Author: Mark Payne 
Date:   2017-05-19T20:42:51Z

NIFI-3946: Update LookupService to take a Map instead of a String for the 
input




> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread Mark Payne (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018031#comment-16018031
 ] 

Mark Payne commented on NIFI-3946:
--

[~jfrazee][~joewitt] - I attached a PR that I think can illustrate how I think 
we should handle this. It still allows easily for a key/value type of approach, 
I think... Take a look and see what you think?

> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3759) Enable Avro append for Put HDFS

2017-05-19 Thread Mika Borner (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018041#comment-16018041
 ] 

Mika Borner commented on NIFI-3759:
---

I second that, essential for time-series data with lots of small files 
otherwise.

> Enable Avro append for Put HDFS
> ---
>
> Key: NIFI-3759
> URL: https://issues.apache.org/jira/browse/NIFI-3759
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.1.0, 1.1.1
>Reporter: Jonas Hartwig
>Priority: Minor
>
> It would be nice where Nifi already supports working with AVRO to enable hdfs 
> append working correctly with avro files coming from MergeContent processor.
> I suggest making a similar choice in as in MergeContent to be able to choose 
> a file format which applies file format specific logic when required.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi issue #1831: NIFI-3942 Making IPLookupService reload the database file ...

2017-05-19 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1831
  
@markap14 Thanks for reviewing, I agree about the handling of the 
InvalidDatabaseException. I added another commit that catches the 
InvalidDatabaseException, then forces a reload and attempts the look up one 
more time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3942) IPLookupService should auto reload geo dictionary file

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018092#comment-16018092
 ] 

ASF GitHub Bot commented on NIFI-3942:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1831
  
@markap14 Thanks for reviewing, I agree about the handling of the 
InvalidDatabaseException. I added another commit that catches the 
InvalidDatabaseException, then forces a reload and attempts the look up one 
more time.


> IPLookupService should auto reload geo dictionary file
> --
>
> Key: NIFI-3942
> URL: https://issues.apache.org/jira/browse/NIFI-3942
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Joseph Witt
>Assignee: Bryan Bende
>
> Right now the IPLookupService introduced in NIFI-3863 loads the database 
> onEnabled for the controller service.  It needs to periodically check for a 
> new database file and reload it automatically during calls to lookup.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi pull request #1834: NIFI-3948: Added flush() method to RecordWriter and...

2017-05-19 Thread markap14
GitHub user markap14 opened a pull request:

https://github.com/apache/nifi/pull/1834

NIFI-3948: Added flush() method to RecordWriter and call it when writ…

…ing a single record to OutputStream for PublishKafkaRecord. Also removed 
no-longer-used class WriteAvroResult

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markap14/nifi NIFI-3948

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1834


commit 3cf91443e4be321b0f48def47ab4c63ed0145c73
Author: Mark Payne 
Date:   2017-05-20T00:52:26Z

NIFI-3948: Added flush() method to RecordWriter and call it when writing a 
single record to OutputStream for PublishKafkaRecord. Also removed 
no-longer-used class WriteAvroResult




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (NIFI-3948) PublishKafkaRecord_0_10 appears to no longer write messages on correct boundaries

2017-05-19 Thread Mark Payne (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Payne updated NIFI-3948:
-
Status: Patch Available  (was: Open)

> PublishKafkaRecord_0_10 appears to no longer write messages on correct 
> boundaries
> -
>
> Key: NIFI-3948
> URL: https://issues.apache.org/jira/browse/NIFI-3948
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.3.0
>
>
> This issue appears only to be a problem on master and does not affect 
> previously released version of Apache NiFi. I am trying to send messages to 
> Kafka using PublishKafkaRecord_0_10 with the JSON Writer. The messages appear 
> not to be demarcated properly and have data missing.
> It appears to be due to the JSON Writer needing to flush its output before 
> creating the byte[] that we push to Kafka.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3948) PublishKafkaRecord_0_10 appears to no longer write messages on correct boundaries

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018215#comment-16018215
 ] 

ASF GitHub Bot commented on NIFI-3948:
--

GitHub user markap14 opened a pull request:

https://github.com/apache/nifi/pull/1834

NIFI-3948: Added flush() method to RecordWriter and call it when writ…

…ing a single record to OutputStream for PublishKafkaRecord. Also removed 
no-longer-used class WriteAvroResult

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markap14/nifi NIFI-3948

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1834


commit 3cf91443e4be321b0f48def47ab4c63ed0145c73
Author: Mark Payne 
Date:   2017-05-20T00:52:26Z

NIFI-3948: Added flush() method to RecordWriter and call it when writing a 
single record to OutputStream for PublishKafkaRecord. Also removed 
no-longer-used class WriteAvroResult




> PublishKafkaRecord_0_10 appears to no longer write messages on correct 
> boundaries
> -
>
> Key: NIFI-3948
> URL: https://issues.apache.org/jira/browse/NIFI-3948
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.3.0
>
>
> This issue appears only to be a problem on master and does not affect 
> previously released version of Apache NiFi. I am trying to send messages to 
> Kafka using PublishKafkaRecord_0_10 with the JSON Writer. The messages appear 
> not to be demarcated properly and have data missing.
> It appears to be due to the JSON Writer needing to flush its output before 
> creating the byte[] that we push to Kafka.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3854) Expand expression language support for Kafka processors

2017-05-19 Thread Joseph Witt (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018265#comment-16018265
 ] 

Joseph Witt commented on NIFI-3854:
---

+1 merged to master.  thanks

> Expand expression language support for Kafka processors
> ---
>
> Key: NIFI-3854
> URL: https://issues.apache.org/jira/browse/NIFI-3854
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Tim Reardon
>Priority: Minor
> Fix For: 1.3.0
>
>
> Expand expression language support for Kafka processors:
> - brokers / zookeepers
> - topic



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (NIFI-3854) Expand expression language support for Kafka processors

2017-05-19 Thread Joseph Witt (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Witt updated NIFI-3854:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Expand expression language support for Kafka processors
> ---
>
> Key: NIFI-3854
> URL: https://issues.apache.org/jira/browse/NIFI-3854
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Tim Reardon
>Priority: Minor
> Fix For: 1.3.0
>
>
> Expand expression language support for Kafka processors:
> - brokers / zookeepers
> - topic



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi pull request #1834: NIFI-3948: Added flush() method to RecordWriter and...

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3948) PublishKafkaRecord_0_10 appears to no longer write messages on correct boundaries

2017-05-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018279#comment-16018279
 ] 

ASF subversion and git services commented on NIFI-3948:
---

Commit c49933f03df295760e1b6764e38dddbc9b2d31e6 in nifi's branch 
refs/heads/master from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c49933f ]

NIFI-3948: This closes #1834. Added flush() method to RecordWriter and call it 
when writing a single record to OutputStream for PublishKafkaRecord. Also 
removed no-longer-used class WriteAvroResult

Signed-off-by: joewitt 


> PublishKafkaRecord_0_10 appears to no longer write messages on correct 
> boundaries
> -
>
> Key: NIFI-3948
> URL: https://issues.apache.org/jira/browse/NIFI-3948
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.3.0
>
>
> This issue appears only to be a problem on master and does not affect 
> previously released version of Apache NiFi. I am trying to send messages to 
> Kafka using PublishKafkaRecord_0_10 with the JSON Writer. The messages appear 
> not to be demarcated properly and have data missing.
> It appears to be due to the JSON Writer needing to flush its output before 
> creating the byte[] that we push to Kafka.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3948) PublishKafkaRecord_0_10 appears to no longer write messages on correct boundaries

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018281#comment-16018281
 ] 

ASF GitHub Bot commented on NIFI-3948:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1834


> PublishKafkaRecord_0_10 appears to no longer write messages on correct 
> boundaries
> -
>
> Key: NIFI-3948
> URL: https://issues.apache.org/jira/browse/NIFI-3948
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.3.0
>
>
> This issue appears only to be a problem on master and does not affect 
> previously released version of Apache NiFi. I am trying to send messages to 
> Kafka using PublishKafkaRecord_0_10 with the JSON Writer. The messages appear 
> not to be demarcated properly and have data missing.
> It appears to be due to the JSON Writer needing to flush its output before 
> creating the byte[] that we push to Kafka.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (NIFI-3948) PublishKafkaRecord_0_10 appears to no longer write messages on correct boundaries

2017-05-19 Thread Joseph Witt (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Witt updated NIFI-3948:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

+1 merged to master.

full clean build/contrib all good.  Flow that had the behavior previously is 
now rock solid.  Thanks

> PublishKafkaRecord_0_10 appears to no longer write messages on correct 
> boundaries
> -
>
> Key: NIFI-3948
> URL: https://issues.apache.org/jira/browse/NIFI-3948
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.3.0
>
>
> This issue appears only to be a problem on master and does not affect 
> previously released version of Apache NiFi. I am trying to send messages to 
> Kafka using PublishKafkaRecord_0_10 with the JSON Writer. The messages appear 
> not to be demarcated properly and have data missing.
> It appears to be due to the JSON Writer needing to flush its output before 
> creating the byte[] that we push to Kafka.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread Joseph Witt (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018286#comment-16018286
 ] 

Joseph Witt commented on NIFI-3946:
---

[~jfrazee] i was definitely good with keeping the simple interface options too. 
 I did a quick look at mark's pr and it seems to make sense to me.  You agree?

> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018307#comment-16018307
 ] 

ASF GitHub Bot commented on NIFI-3946:
--

Github user jfrazee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1833#discussion_r117601695
  
--- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/SimpleKeyValueLookupService.java
 ---
@@ -52,7 +57,21 @@ public void cacheConfiguredValues(final 
ConfigurationContext context) {
 }
 
 @Override
-public Optional lookup(final String key) {
+public Optional lookup(final Map coordinates) {
+if (coordinates == null) {
+return null;
--- End diff --

Should these nulls be Optional.empty()? 


> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] nifi pull request #1833: NIFI-3946: Update LookupService to take a Map inste...

2017-05-19 Thread jfrazee
Github user jfrazee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1833#discussion_r117601695
  
--- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/SimpleKeyValueLookupService.java
 ---
@@ -52,7 +57,21 @@ public void cacheConfiguredValues(final 
ConfigurationContext context) {
 }
 
 @Override
-public Optional lookup(final String key) {
+public Optional lookup(final Map coordinates) {
+if (coordinates == null) {
+return null;
--- End diff --

Should these nulls be Optional.empty()? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1833: NIFI-3946: Update LookupService to take a Map inste...

2017-05-19 Thread jfrazee
Github user jfrazee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1833#discussion_r117601703
  
--- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/maxmind/IPLookupService.java
 ---
@@ -146,17 +153,27 @@ public void closeReader() throws IOException {
 }
 
 @Override
-public Optional lookup(final String key) throws 
LookupFailureException {
-if (key == null) {
+public Set getRequiredKeys() {
+return REQUIRED_KEYS;
+}
+
+@Override
+public Optional lookup(final Map coordinates) 
throws LookupFailureException {
+if (coordinates == null) {
 return Optional.empty();
 }
 
+final String ipAddress = coordinates.get(IP_KEY);
+if (ipAddress == null) {
+return null;
--- End diff --

Optional.empty() here too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-3946) Should update LookupRecord to allow multi criteria lookups

2017-05-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018308#comment-16018308
 ] 

ASF GitHub Bot commented on NIFI-3946:
--

Github user jfrazee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1833#discussion_r117601703
  
--- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/maxmind/IPLookupService.java
 ---
@@ -146,17 +153,27 @@ public void closeReader() throws IOException {
 }
 
 @Override
-public Optional lookup(final String key) throws 
LookupFailureException {
-if (key == null) {
+public Set getRequiredKeys() {
+return REQUIRED_KEYS;
+}
+
+@Override
+public Optional lookup(final Map coordinates) 
throws LookupFailureException {
+if (coordinates == null) {
 return Optional.empty();
 }
 
+final String ipAddress = coordinates.get(IP_KEY);
+if (ipAddress == null) {
+return null;
--- End diff --

Optional.empty() here too?


> Should update LookupRecord to allow multi criteria lookups
> --
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a 
> given lookup can use when searching for the result. The LookupRecord 
> processor should change such that all dynamic properties are the loookup key 
> names with values that are the RecordPath to find the value for that given 
> key. The resulting map would be passed to the lookup service. Also the lookup 
> service API should allow returning the set of required key names so that the 
> processor can validate once all required keys have RecordPaths to search for 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)