[jira] [Commented] (NIFI-2030) Refactor how HTTP-based Site-to-Site ports are communicated

2018-06-27 Thread Koji Kawamura (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525858#comment-16525858
 ] 

Koji Kawamura commented on NIFI-2030:
-

[~markap14] After NIFI-5146, NiFi stops supporting using both HTTP and HTTPS 
port at the same time. Is it fine to close this now?

> Refactor how HTTP-based Site-to-Site ports are communicated
> ---
>
> Key: NIFI-2030
> URL: https://issues.apache.org/jira/browse/NIFI-2030
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.0.0
>Reporter: Mark Payne
>Priority: Major
>
> Currently, when clustered, the NodeIdentifier contains a field 
> siteToSiteHttpApiPort but site-to-site should be enabled on both HTTP and 
> HTTPS interfaces if both are made available. We should refactor 
> NodeIdentifier so that it contains an apiPort and a secureApiPort and then 
> when asked for the list of Peers for site-to-site, it should use the scheme 
> of the given HTTP request to determine which port to return. I.e., if the 
> request was made to https://myhost:443/site-to-site/peers then we should 
> return the secure api port. If made to http://myhost:80/site-to-site/peers 
> then we should return the non-secure api port.
> The fix version for this is marked as 1.0.0, but this should be backward 
> compatible, so if it needs to slide from 1.0.0 it's not critical that it make 
> it into this version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (MINIFICPP-540) add link to issue tracker from README.md

2018-06-27 Thread Dustin Rodrigues (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dustin Rodrigues resolved MINIFICPP-540.

Resolution: Fixed

https://github.com/apache/nifi-minifi-cpp/pull/362

> add link to issue tracker from README.md
> 
>
> Key: MINIFICPP-540
> URL: https://issues.apache.org/jira/browse/MINIFICPP-540
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Dustin Rodrigues
>Assignee: Dustin Rodrigues
>Priority: Minor
>
> Linking to the apache minifi-cpp issue tracker from the README would allow 
> users to view/submit issues since the Github issues tab is disabled 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (MINIFICPP-541) fix minor cmake warning

2018-06-27 Thread Dustin Rodrigues (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dustin Rodrigues resolved MINIFICPP-541.

Resolution: Fixed

https://github.com/apache/nifi-minifi-cpp/pull/363

> fix minor cmake warning
> ---
>
> Key: MINIFICPP-541
> URL: https://issues.apache.org/jira/browse/MINIFICPP-541
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Dustin Rodrigues
>Assignee: Dustin Rodrigues
>Priority: Minor
>
> CMake Warning (dev) in CMakeLists.txt:
>  A logical block opening on the line
> /home/nifi/nifi-minifi-cpp/CMakeLists.txt:79 (if)
> closes on the line
> /home/nifi/nifi-minifi-cpp/CMakeLists.txt:117 (endif)
> with mis-matching arguments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-546) minifi.sh status should return 0 when process isn't running

2018-06-27 Thread Dustin Rodrigues (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525784#comment-16525784
 ] 

Dustin Rodrigues commented on MINIFICPP-546:


My mistake, I somehow missed (both of) the references to the init script spec.

I agree that it makes sense to return 3 when calling status when it's run as an 
init script per the spec, so I'll change that back. It seems like people are in 
agreement that the return value when calling "minifi.sh status" directly should 
be 0 if the process is not running and there isn't a stale pidfile. I'll leave 
it at 0 for this case and remove the comments pointing to the LSB spec in that 
section of the script since it no longer is relevant. I'll also leave it 
returning 1 when status is called on a stopped process with a stale process 
since that is indicative of an error.

 

> minifi.sh status should return 0 when process isn't running
> ---
>
> Key: MINIFICPP-546
> URL: https://issues.apache.org/jira/browse/MINIFICPP-546
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Dustin Rodrigues
>Assignee: Dustin Rodrigues
>Priority: Minor
>
> Currently, calling "minifi.sh status" when the process isn't running returns 
> exit code 3. It should return 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (NIFI-5346) Allow EncryptContent processor to specify PGP key as processor property

2018-06-27 Thread Andy LoPresto (JIRA)
Andy LoPresto created NIFI-5346:
---

 Summary: Allow EncryptContent processor to specify PGP key as 
processor property
 Key: NIFI-5346
 URL: https://issues.apache.org/jira/browse/NIFI-5346
 Project: Apache NiFi
  Issue Type: New Feature
  Components: Extensions
Affects Versions: 1.7.0
Reporter: Andy LoPresto
Assignee: Andy LoPresto


Users have requested the capability to paste the ASCII-armored key contents 
into an {{EncryptContent}} processor property in order to decouple from from an 
external keyring (for both encryption and decryption). 

The private key would be protected as a sensitive property (encrypted in the 
flow.xml.gz the same as a password field). The public key can either be 
protected in the same way, or treated as a plaintext value (it is not 
sensitive). There should be an additional field to record the unique identifier 
of the respective key (i.e. key ID or fingerprint + description). 

Specifying all of this information may be confusing on the default processor 
property dialog, and so an "Advanced"/"PGP" custom UI should be provided which 
organizes this information in a helpful way. 

Obviously, encrypting with a literal public key or decrypting with a literal 
private key should be easily interoperable with another encryption/decryption 
operation (either with another instance of {{EncryptContent}} within NiFi 
referencing an external keyring or using an external tool like GnuPG). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5341) Groovy tests in nifi-runtime aren't running with the build

2018-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525751#comment-16525751
 ] 

ASF GitHub Bot commented on NIFI-5341:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2821#discussion_r198676656
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-runtime/src/test/groovy/org/apache/nifi/NiFiGroovyTest.groovy
 ---
@@ -105,14 +97,13 @@ class NiFiGroovyTest extends GroovyTestCase {
 NiFi.main(args)
 
 // Assert
-assert TestAppender.events.last().getMessage() == "Failure to 
launch NiFi due to java.lang.IllegalArgumentException: The bootstrap process 
did not provide a valid key and there are protected properties present in the 
properties file"
+assert TestAppender.events.last().getMessage() == "Failure to 
launch NiFi due to java.lang.IllegalArgumentException: There was an issue 
decrypting protected properties"
--- End diff --

This error message seems less helpful than the previous message. Is there a 
reason it is changed?


> Groovy tests in nifi-runtime aren't running with the build
> --
>
> Key: NIFI-5341
> URL: https://issues.apache.org/jira/browse/NIFI-5341
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> At some point, NiFiGroovyTest in nifi-runtime stopped running with the build. 
> During the work for NIFI-5176, it was discovered that 
> build-helper-maven-plugin is not being invoked for nifi-runtime to explicitly 
> add src/test/groovy to bind it to the test compile phase, and since there are 
> no java tests, src/test/groovy is ignored, and the tests are not run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #2821: NIFI-5341 Enabled groovy tests in nifi-runtime

2018-06-27 Thread alopresto
Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2821#discussion_r198676656
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-runtime/src/test/groovy/org/apache/nifi/NiFiGroovyTest.groovy
 ---
@@ -105,14 +97,13 @@ class NiFiGroovyTest extends GroovyTestCase {
 NiFi.main(args)
 
 // Assert
-assert TestAppender.events.last().getMessage() == "Failure to 
launch NiFi due to java.lang.IllegalArgumentException: The bootstrap process 
did not provide a valid key and there are protected properties present in the 
properties file"
+assert TestAppender.events.last().getMessage() == "Failure to 
launch NiFi due to java.lang.IllegalArgumentException: There was an issue 
decrypting protected properties"
--- End diff --

This error message seems less helpful than the previous message. Is there a 
reason it is changed?


---


[jira] [Commented] (MINIFICPP-546) minifi.sh status should return 0 when process isn't running

2018-06-27 Thread Aldrin Piri (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525592#comment-16525592
 ] 

Aldrin Piri commented on MINIFICPP-546:
---

Hey [~drodrigues] & [~phrocker],
yeah, the intent was that if this script was used for init purposes, we had 
functionality that met the spec called out in the comments 
(https://github.com/apache/nifi-minifi-cpp/blob/master/bin/minifi.sh#L218) - 
http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html.

With the benefit of hindsight, this could be a bit misguided for the generic 
minifi.sh case but I believe it to be correct for the service case that is 
embedded in the script. But don't have any strong issues with main case 
changing to 0. 

In terms of breaking, I believe we could note this as a migration point for 
that release.

> minifi.sh status should return 0 when process isn't running
> ---
>
> Key: MINIFICPP-546
> URL: https://issues.apache.org/jira/browse/MINIFICPP-546
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Dustin Rodrigues
>Assignee: Dustin Rodrigues
>Priority: Minor
>
> Currently, calling "minifi.sh status" when the process isn't running returns 
> exit code 3. It should return 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-534) Add EL support to ExecuteProcess

2018-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525503#comment-16525503
 ] 

ASF GitHub Bot commented on MINIFICPP-534:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/357


> Add EL support to ExecuteProcess
> 
>
> Key: MINIFICPP-534
> URL: https://issues.apache.org/jira/browse/MINIFICPP-534
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
> Fix For: 0.6.0
>
>
> ExecuteProcess needs EL support for the following properties:
>  * Command
>  * Command Arguments
>  * Working Directory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi-minifi-cpp pull request #357: MINIFICPP-534 Added EL support to Execute...

2018-06-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/357


---


[jira] [Updated] (MINIFICPP-534) Add EL support to ExecuteProcess

2018-06-27 Thread marco polo (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

marco polo updated MINIFICPP-534:
-
Fix Version/s: 0.6.0

> Add EL support to ExecuteProcess
> 
>
> Key: MINIFICPP-534
> URL: https://issues.apache.org/jira/browse/MINIFICPP-534
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
> Fix For: 0.6.0
>
>
> ExecuteProcess needs EL support for the following properties:
>  * Command
>  * Command Arguments
>  * Working Directory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-5176) NiFi needs to be buildable on Java 9+

2018-06-27 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5176:
--
Description: 
While retaining a source/target comptability of 1.8, NiFi needs to be buildable 
on Java 9.

The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||
|groovy-eclipse-compiler not working with Java 10|-Switched to gmaven-plus- 
Updated to maven-compiler-plugin:3.7.0, groovy-eclipse-compiler:2.9.3-01, and 
groovy-eclipse-batch:2.4.15-01 |
|Antler3 issue with ambiguous method calls|Explicit cast to ValidationContext 
needed in TestHL7Query.java|
|jaxb2-maven-plugin not compatible with Java 9|Switched to maven-jaxb-plugin|
|hbase-client:1.1.2 depends on jdk.tools:jdk.tools:1.7|Excluded this dependency 
{color:#f79232}*(needs testing)*{color}|
|-nifi-enrich-processors uses package com.sun.jndi.dns, which does not 
exist-|-Required addition of- -add-modules=jdk.naming.dns 
--add-exports=jdk.naming.dns/com.sun.jndi.dns=ALL-UNNAMED, which prevents the 
usage of compiling with the --release option (to compile only against public 
APIs in the JDK) from being used.  Not an optimal solution.-|
|groovy-eclipse-batch:2.4.13-01 could not find JDK base classes|Updated to 
groovy-eclipse-batch:2.4.15-01 and grooy-all:2.4.15|
|maven-surefire-plugin:2.20.1 throws null pointer exceptions|Updated to 
maven-surefire-plugin:2.22.0|
|okhttp client builder requires X509TrustManager on Java 9+|Added methods to 
return TrustManager instances with the SSLContext created by SSLContextFactory 
and updated HttpNotificationService to use the paired TrustManager|
|nifi-runtime groovy tests aren't running|Added usage of 
build-helper-maven-plugin to explicitly add src/test/groovy to force groovy 
compilation of test sources.  groovy-eclipse-compiler skips src/test/groovy if 
src/test/java doesn't exist, which is the case for nifi-runtime. (See NIFI-5341 
for reference)|
|HBase client 1.1.2 does not allow running on Java 9+|*{color:#f79232}Will 
update to HBase client 1.1.11 and retest{color}*|

  was:
While retaining a source/target comptability of 1.8, NiFi needs to be buildable 
on Java 9.

The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||
|Groovy compiler not parsing groovy code correctly on Java 9|Updated 
maven-compiler-plugin to 3.7.0, and included dependencies for 
groovy-eclipse-compiler:2.9.3-01 and groovy-eclipse-batch:2.4.15-01|
|Antler3 issue with ambiguous method calls|Explicit cast to ValidationContext 
needed in TestHL7Query.java|
|jaxb2-maven-plugin not compatible with Java 9|Switched to maven-jaxb-plugin|
|hbase-client:1.1.2 depends on jdk.tools:jdk.tools:1.7|Excluded this dependency 
*(needs testing)*|
|-nifi-enrich-processors uses package com.sun.jndi.dns, which does not 
exist-|-Required addition of- -add-modules=jdk.naming.dns 
--add-exports=jdk.naming.dns/com.sun.jndi.dns=ALL-UNNAMED, which prevents the 
usage of compiling with the --release option (to compile only against public 
APIs in the JDK) from being used.  Not an optimal solution.-|
|groovy-eclipse-compiler not working with Java 10|-Switched to gmaven-plus- 
Updated to groovy-eclipse-compiler:2.9.3-01 and groovy-eclipse-batch:2.4.15-01|
|groovy-eclipse-batch:2.4.13-01 could not find JDK base classes|Updated to 
groovy-eclipse-batch:2.4.15-01 and grooy-all:2.4.15|
|maven-surefire-plugin:2.20.1 throws null pointer exceptions|Switched to 
version 2.22.0|
|okhttp client builder requires X509TrustManager on Java 9+|Added methods to 
return TrustManager instances with the SSLContext created by SSLContextFactory 
and updated HttpNotificationService to use the paired TrustManager|
|nifi-runtime groovy tests aren't running|Added usage of 
build-helper-maven-plugin to explicitly add src/test/groovy to force groovy 
compilation of test sources.  groovy-eclipse-compiler skips src/test/groovy if 
src/test/java doesn't exist, which is the case for nifi-runtime. (See 
[NIFI-5341|https://issues.apache.org/jira/browse/NIFI-5341] for reference)|


> NiFi needs to be buildable on Java 9+
> -
>
> Key: NIFI-5176
> URL: https://issues.apache.org/jira/browse/NIFI-5176
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> While retaining a source/target comptability of 1.8, NiFi needs to be 
> buildable on Java 9.
> The following issues have been encountered while attempting to run a Java 
> 1.8-built NiFi on Java 9:
> ||Issue||Solution||
> |groovy-eclipse-compiler not working with Java 10|-Switched to gmaven-plus- 
> Updated to maven-compiler-plugin:3.7.0, groovy-eclipse-compiler:2.9.3-01, and 
> groovy-eclipse-batch:2.4.15-01 |
> |Antler3 issue with ambiguous 

[jira] [Updated] (NIFI-5175) NiFi built with Java 1.8 needs to run on Java 9+

2018-06-27 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5175:
--
Summary: NiFi built with Java 1.8 needs to run on Java 9+  (was: NiFi built 
with Java 1.8 needs to run on Java 9)

> NiFi built with Java 1.8 needs to run on Java 9+
> 
>
> Key: NIFI-5175
> URL: https://issues.apache.org/jira/browse/NIFI-5175
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
> Fix For: 1.7.0
>
>
> The following issues have been encountered while attempting to run a Java 
> 1.8-built NiFi on Java 9:
> ||Issue||Solution||Status||
> |JAXB classes cannot be found on the classpath|Add 
> "--add-modules=java.xml.bind" to the commant that starts NiFi|Done|
> |NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
> stop|Detect if NiFi is running on Java 9, and reflectively invoke 
> Process.pid(), which was newly added to the Process API in Java 9|Done|
>  
> 
>  
> ||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
> 9+||Description||Solution||
> |WARNING: An illegal reflective access operation has occurred
>  ..._specific class usage snipped_...
>  WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
>  WARNING: All illegal access operations will be denied in a future 
> release|Reflective invocations are common in the code used in NiFi and its 
> dependencies in Java 1.8|Full compliant migration to Java 9 and use 
> dependencies that are Java 9 compliant|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-5176) NiFi needs to be buildable on Java 9+

2018-06-27 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5176:
--
Summary: NiFi needs to be buildable on Java 9+  (was: NiFi needs to be 
buildable on Java 9)

> NiFi needs to be buildable on Java 9+
> -
>
> Key: NIFI-5176
> URL: https://issues.apache.org/jira/browse/NIFI-5176
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> While retaining a source/target comptability of 1.8, NiFi needs to be 
> buildable on Java 9.
> The following issues have been encountered while attempting to run a Java 
> 1.8-built NiFi on Java 9:
> ||Issue||Solution||
> |Groovy compiler not parsing groovy code correctly on Java 9|Updated 
> maven-compiler-plugin to 3.7.0, and included dependencies for 
> groovy-eclipse-compiler:2.9.3-01 and groovy-eclipse-batch:2.4.15-01|
> |Antler3 issue with ambiguous method calls|Explicit cast to ValidationContext 
> needed in TestHL7Query.java|
> |jaxb2-maven-plugin not compatible with Java 9|Switched to maven-jaxb-plugin|
> |hbase-client:1.1.2 depends on jdk.tools:jdk.tools:1.7|Excluded this 
> dependency *(needs testing)*|
> |-nifi-enrich-processors uses package com.sun.jndi.dns, which does not 
> exist-|-Required addition of- -add-modules=jdk.naming.dns 
> --add-exports=jdk.naming.dns/com.sun.jndi.dns=ALL-UNNAMED, which prevents the 
> usage of compiling with the --release option (to compile only against public 
> APIs in the JDK) from being used.  Not an optimal solution.-|
> |groovy-eclipse-compiler not working with Java 10|-Switched to gmaven-plus- 
> Updated to groovy-eclipse-compiler:2.9.3-01 and 
> groovy-eclipse-batch:2.4.15-01|
> |groovy-eclipse-batch:2.4.13-01 could not find JDK base classes|Updated to 
> groovy-eclipse-batch:2.4.15-01 and grooy-all:2.4.15|
> |maven-surefire-plugin:2.20.1 throws null pointer exceptions|Switched to 
> version 2.22.0|
> |okhttp client builder requires X509TrustManager on Java 9+|Added methods to 
> return TrustManager instances with the SSLContext created by 
> SSLContextFactory and updated HttpNotificationService to use the paired 
> TrustManager|
> |nifi-runtime groovy tests aren't running|Added usage of 
> build-helper-maven-plugin to explicitly add src/test/groovy to force groovy 
> compilation of test sources.  groovy-eclipse-compiler skips src/test/groovy 
> if src/test/java doesn't exist, which is the case for nifi-runtime. (See 
> [NIFI-5341|https://issues.apache.org/jira/browse/NIFI-5341] for reference)|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-5176) NiFi needs to be buildable on Java 9

2018-06-27 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5176:
--
Description: 
While retaining a source/target comptability of 1.8, NiFi needs to be buildable 
on Java 9.

The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||
|Groovy compiler not parsing groovy code correctly on Java 9|Updated 
maven-compiler-plugin to 3.7.0, and included dependencies for 
groovy-eclipse-compiler:2.9.3-01 and groovy-eclipse-batch:2.4.15-01|
|Antler3 issue with ambiguous method calls|Explicit cast to ValidationContext 
needed in TestHL7Query.java|
|jaxb2-maven-plugin not compatible with Java 9|Switched to maven-jaxb-plugin|
|hbase-client:1.1.2 depends on jdk.tools:jdk.tools:1.7|Excluded this dependency 
*(needs testing)*|
|-nifi-enrich-processors uses package com.sun.jndi.dns, which does not 
exist-|-Required addition of- -add-modules=jdk.naming.dns 
--add-exports=jdk.naming.dns/com.sun.jndi.dns=ALL-UNNAMED, which prevents the 
usage of compiling with the --release option (to compile only against public 
APIs in the JDK) from being used.  Not an optimal solution.-|
|groovy-eclipse-compiler not working with Java 10|-Switched to gmaven-plus- 
Updated to groovy-eclipse-compiler:2.9.3-01 and groovy-eclipse-batch:2.4.15-01|
|groovy-eclipse-batch:2.4.13-01 could not find JDK base classes|Updated to 
groovy-eclipse-batch:2.4.15-01 and grooy-all:2.4.15|
|maven-surefire-plugin:2.20.1 throws null pointer exceptions|Switched to 
version 2.22.0|
|okhttp client builder requires X509TrustManager on Java 9+|Added methods to 
return TrustManager instances with the SSLContext created by SSLContextFactory 
and updated HttpNotificationService to use the paired TrustManager|
|nifi-runtime groovy tests aren't running|Added usage of 
build-helper-maven-plugin to explicitly add src/test/groovy to force groovy 
compilation of test sources.  groovy-eclipse-compiler skips src/test/groovy if 
src/test/java doesn't exist, which is the case for nifi-runtime. (See 
[NIFI-5341|https://issues.apache.org/jira/browse/NIFI-5341] for reference)|

  was:
While retaining a source/target comptability of 1.8, NiFi needs to be buildable 
on Java 9.

The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||
|Groovy compiler not parsing groovy code correctly on Java 9|Updated 
maven-compiler-plugin to 3.7.0, and included dependencies for 
groovy-eclipse-compiler:2.9.3-01 and groovy-eclipse-batch:2.4.15-01|
|Antler3 issue with ambiguous method calls|Explicit cast to ValidationContext 
needed in TestHL7Query.java|
|jaxb2-maven-plugin not compatible with Java 9|Switched to maven-jaxb-plugin|
|hbase-client:1.1.2 depends on jdk.tools:jdk.tools:1.7|Excluded this dependency 
*(needs testing)*|
|-nifi-enrich-processors uses package com.sun.jndi.dns, which does not 
exist-|-Required addition of- -add-modules=jdk.naming.dns 
--add-exports=jdk.naming.dns/com.sun.jndi.dns=ALL-UNNAMED, which prevents the 
usage of compiling with the --release option (to compile only against public 
APIs in the JDK) from being used.  Not an optimal solution.-|
|groovy-eclipse-compiler not working with Java 10|-Switched to gmaven-plus- 
Updated to groovy-eclipse-compiler:2.9.3-01 and groovy-eclipse-batch:2.4.15-01|
|groovy-eclipse-batch:2.4.13-01 could not find JDK base classes|Updated to 
groovy-eclipse-batch:2.4.15-01 and grooy-all:2.4.15|
|maven-surefire-plugin:2.20.1 throws null pointer exceptions|Switched to 
version 2.22.0|
|okhttp client builder requires X509TrustManager on Java 9+|Added methods to 
return TrustManager instances with the SSLContext created by SSLContextFactory 
and updated HttpNotificationService to use the paired TrustManager|
|nifi-runtime groovy tests aren't running|Added usage of 
build-helper-maven-plugin to explicitly add src/test/groovy to force groovy 
compilation of test sources.  groovy-eclipse-compiler skips src/test/groovy if 
src/test/java doesn't exist, which is the case for nifi-runtime.|


> NiFi needs to be buildable on Java 9
> 
>
> Key: NIFI-5176
> URL: https://issues.apache.org/jira/browse/NIFI-5176
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> While retaining a source/target comptability of 1.8, NiFi needs to be 
> buildable on Java 9.
> The following issues have been encountered while attempting to run a Java 
> 1.8-built NiFi on Java 9:
> ||Issue||Solution||
> |Groovy compiler not parsing groovy code correctly on Java 9|Updated 
> maven-compiler-plugin to 3.7.0, and included dependencies for 
> groovy-eclipse-compiler:2.9.3-01 and groovy-eclipse-batch:2.4.15-01|
> |Antler3 issue with ambiguous method 

[jira] [Updated] (NIFI-5174) NiFi Compatibility with Java 9+

2018-06-27 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5174:
--
Summary: NiFi Compatibility with Java 9+  (was: NiFi Compatibility with 
Java 9)

> NiFi Compatibility with Java 9+
> ---
>
> Key: NIFI-5174
> URL: https://issues.apache.org/jira/browse/NIFI-5174
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-5345) ProtectedNiFiProperties should warn if it detects protected properties not listed in nifi.sensitive.props.additional.keys

2018-06-27 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5345:
--
Description: ProtectedNiFiProperties should log a warning if it detects a 
property ending with .protected matching a known protection scheme, and that 
property is not listed in nifi.sensitive.props.additional.keys *and* is not a 
default sensitive property (as clarified by Andy).  (was: 
ProtectedNiFiProperties should log a warning if it detects a property ending 
with .protected matching a known protection scheme, and that property is not 
listed in nifi.sensitive.props.additional.keys.)

> ProtectedNiFiProperties should warn if it detects protected properties not 
> listed in nifi.sensitive.props.additional.keys
> -
>
> Key: NIFI-5345
> URL: https://issues.apache.org/jira/browse/NIFI-5345
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Jeff Storck
>Priority: Minor
>
> ProtectedNiFiProperties should log a warning if it detects a property ending 
> with .protected matching a known protection scheme, and that property is not 
> listed in nifi.sensitive.props.additional.keys *and* is not a default 
> sensitive property (as clarified by Andy).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5345) ProtectedNiFiProperties should warn if it detects protected properties not listed in nifi.sensitive.props.additional.keys

2018-06-27 Thread Andy LoPresto (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525368#comment-16525368
 ] 

Andy LoPresto commented on NIFI-5345:
-

Just to clarify the description, it should only warn if a property is detected 
with the known protection scheme and it is not listed in 
{{nifi.sensitive.props.additional.keys}} *if* it is not a default sensitive 
property. 

> ProtectedNiFiProperties should warn if it detects protected properties not 
> listed in nifi.sensitive.props.additional.keys
> -
>
> Key: NIFI-5345
> URL: https://issues.apache.org/jira/browse/NIFI-5345
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Jeff Storck
>Priority: Minor
>
> ProtectedNiFiProperties should log a warning if it detects a property ending 
> with .protected matching a known protection scheme, and that property is not 
> listed in nifi.sensitive.props.additional.keys.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (NIFI-5345) ProtectedNiFiProperties should warn if it detects protected properties not listed in nifi.sensitive.props.additional.keys

2018-06-27 Thread Andy LoPresto (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525368#comment-16525368
 ] 

Andy LoPresto edited comment on NIFI-5345 at 6/27/18 6:15 PM:
--

Just to clarify the description, it should only warn if a property is detected 
with the known protection scheme and it is not listed in 
{{nifi.sensitive.props.additional.keys}} *and* it is not a default sensitive 
property. 


was (Author: alopresto):
Just to clarify the description, it should only warn if a property is detected 
with the known protection scheme and it is not listed in 
{{nifi.sensitive.props.additional.keys}} *if* it is not a default sensitive 
property. 

> ProtectedNiFiProperties should warn if it detects protected properties not 
> listed in nifi.sensitive.props.additional.keys
> -
>
> Key: NIFI-5345
> URL: https://issues.apache.org/jira/browse/NIFI-5345
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Jeff Storck
>Priority: Minor
>
> ProtectedNiFiProperties should log a warning if it detects a property ending 
> with .protected matching a known protection scheme, and that property is not 
> listed in nifi.sensitive.props.additional.keys.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-5341) Groovy tests in nifi-runtime aren't running with the build

2018-06-27 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5341:
--
Status: Patch Available  (was: In Progress)

> Groovy tests in nifi-runtime aren't running with the build
> --
>
> Key: NIFI-5341
> URL: https://issues.apache.org/jira/browse/NIFI-5341
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> At some point, NiFiGroovyTest in nifi-runtime stopped running with the build. 
> During the work for NIFI-5176, it was discovered that 
> build-helper-maven-plugin is not being invoked for nifi-runtime to explicitly 
> add src/test/groovy to bind it to the test compile phase, and since there are 
> no java tests, src/test/groovy is ignored, and the tests are not run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5341) Groovy tests in nifi-runtime aren't running with the build

2018-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525338#comment-16525338
 ] 

ASF GitHub Bot commented on NIFI-5341:
--

Github user jtstorck commented on the issue:

https://github.com/apache/nifi/pull/2821
  
@joewitt @alopresto This PR modifies code that was worked on by the two of 
you.  I think there will be some discussion of the fixes, but I wanted to get a 
PR up ASAP to start the review process.  Of interest, there's some exception 
handling changes in NiFi.java.  NiFiGroovyTest needs to be able to invoke the 
main method, and since it's a unit test, lib/bootstrap isn't available.  
Creating a temp directory for the test didn't work out very well, based on 
varying PWDs between surefire and the IDE, so I thought this would be an 
acceptable approach.


> Groovy tests in nifi-runtime aren't running with the build
> --
>
> Key: NIFI-5341
> URL: https://issues.apache.org/jira/browse/NIFI-5341
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> At some point, NiFiGroovyTest in nifi-runtime stopped running with the build. 
> During the work for NIFI-5176, it was discovered that 
> build-helper-maven-plugin is not being invoked for nifi-runtime to explicitly 
> add src/test/groovy to bind it to the test compile phase, and since there are 
> no java tests, src/test/groovy is ignored, and the tests are not run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi issue #2821: NIFI-5341 Enabled groovy tests in nifi-runtime

2018-06-27 Thread jtstorck
Github user jtstorck commented on the issue:

https://github.com/apache/nifi/pull/2821
  
@joewitt @alopresto This PR modifies code that was worked on by the two of 
you.  I think there will be some discussion of the fixes, but I wanted to get a 
PR up ASAP to start the review process.  Of interest, there's some exception 
handling changes in NiFi.java.  NiFiGroovyTest needs to be able to invoke the 
main method, and since it's a unit test, lib/bootstrap isn't available.  
Creating a temp directory for the test didn't work out very well, based on 
varying PWDs between surefire and the IDE, so I thought this would be an 
acceptable approach.


---


[jira] [Commented] (NIFI-5341) Groovy tests in nifi-runtime aren't running with the build

2018-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525335#comment-16525335
 ] 

ASF GitHub Bot commented on NIFI-5341:
--

GitHub user jtstorck opened a pull request:

https://github.com/apache/nifi/pull/2821

NIFI-5341 Enabled groovy tests in nifi-runtime

Fixed tests in NiFiGroovyTest in the nifi-runtime module
Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap 
does not exist rather than throwing a FileNotFoundException, since it already 
catches MalformedUrlException if there's an issue adding one of the bootstrap 
JARs to the bootstrap classpath
Explicitly handling InvocationTargetException in NiFi.initializeProperties 
to unwrap the cause and rewrap as an IllegalArgumentException to propogate the 
real cause of the underlying exception thrown by NiFiPropertiesLoader

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jtstorck/nifi NIFI-5341

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2821.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2821


commit 174e213dc83cdbfa9e449c0b3b57f05673bc2167
Author: Jeff Storck 
Date:   2018-06-27T02:33:19Z

NIFI-5341 Enabled groovy tests in nifi-runtime
Fixed tests in NiFiGroovyTest in the nifi-runtime module
Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap 
does not exist rather than throwing a FileNotFoundException, since it already 
catches MalformedUrlException if there's an issue adding one of the bootstrap 
JARs to the bootstrap classpath
Explicitly handling InvocationTargetException in NiFi.initializeProperties 
to unwrap the cause and rewrap as an IllegalArgumentException to propogate the 
real cause of the underlying exception thrown by NiFiPropertiesLoader




> Groovy tests in nifi-runtime aren't running with the build
> --
>
> Key: NIFI-5341
> URL: https://issues.apache.org/jira/browse/NIFI-5341
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> At some point, NiFiGroovyTest in nifi-runtime stopped running with the build. 
> During the work for NIFI-5176, it was discovered that 
> build-helper-maven-plugin is not being invoked for nifi-runtime to explicitly 
> add src/test/groovy to bind it to the test compile phase, and since there are 
> no java tests, src/test/groovy is ignored, and the tests are not run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #2821: NIFI-5341 Enabled groovy tests in nifi-runtime

2018-06-27 Thread jtstorck
GitHub user jtstorck opened a pull request:

https://github.com/apache/nifi/pull/2821

NIFI-5341 Enabled groovy tests in nifi-runtime

Fixed tests in NiFiGroovyTest in the nifi-runtime module
Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap 
does not exist rather than throwing a FileNotFoundException, since it already 
catches MalformedUrlException if there's an issue adding one of the bootstrap 
JARs to the bootstrap classpath
Explicitly handling InvocationTargetException in NiFi.initializeProperties 
to unwrap the cause and rewrap as an IllegalArgumentException to propogate the 
real cause of the underlying exception thrown by NiFiPropertiesLoader

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jtstorck/nifi NIFI-5341

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2821.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2821


commit 174e213dc83cdbfa9e449c0b3b57f05673bc2167
Author: Jeff Storck 
Date:   2018-06-27T02:33:19Z

NIFI-5341 Enabled groovy tests in nifi-runtime
Fixed tests in NiFiGroovyTest in the nifi-runtime module
Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap 
does not exist rather than throwing a FileNotFoundException, since it already 
catches MalformedUrlException if there's an issue adding one of the bootstrap 
JARs to the bootstrap classpath
Explicitly handling InvocationTargetException in NiFi.initializeProperties 
to unwrap the cause and rewrap as an IllegalArgumentException to propogate the 
real cause of the underlying exception thrown by NiFiPropertiesLoader




---


[jira] [Created] (NIFI-5345) ProtectedNiFiProperties should warn if it detects protected properties not listed in nifi.sensitive.props.additional.keys

2018-06-27 Thread Jeff Storck (JIRA)
Jeff Storck created NIFI-5345:
-

 Summary: ProtectedNiFiProperties should warn if it detects 
protected properties not listed in nifi.sensitive.props.additional.keys
 Key: NIFI-5345
 URL: https://issues.apache.org/jira/browse/NIFI-5345
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework
Affects Versions: 1.7.0
Reporter: Jeff Storck


ProtectedNiFiProperties should log a warning if it detects a property ending 
with .protected matching a known protection scheme, and that property is not 
listed in nifi.sensitive.props.additional.keys.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-5327) NetFlow Processors

2018-06-27 Thread Aldrin Piri (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldrin Piri updated NIFI-5327:
--
Status: Patch Available  (was: Open)

> NetFlow Processors
> --
>
> Key: NIFI-5327
> URL: https://issues.apache.org/jira/browse/NIFI-5327
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Affects Versions: 1.6.0
>Reporter: Prashanth Venkatesan
>Assignee: Prashanth Venkatesan
>Priority: Major
>
> As network traffic data scopes for the big data use case, would like NiFi to 
> have processors to support parsing of those protocols.
> Netflow is a protocol introduced by Cisco that provides the ability to 
> collect IP network traffic as it enters or exits an interface and is 
> described in detail in here:
> [https://www.cisco.com/c/en/us/td/docs/net_mgmt/netflow_collection_engine/3-6/user/guide/format.html]
>  
> Currently, I have created the following processor:
> *ParseNetflowv5*:  Parses the ingress netflowv5 bytes and ingest as either 
> NiFi flowfile attributes or as a JSON content. This also sends 
> one-time-template.
>  
> Further ahead, we can add many processor specific to network protocols in 
> this nar bundle.
> I will create a pull request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5327) NetFlow Processors

2018-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525226#comment-16525226
 ] 

ASF GitHub Bot commented on NIFI-5327:
--

GitHub user PrashanthVenkatesan opened a pull request:

https://github.com/apache/nifi/pull/2820

NIFI-5327 Adding Netflowv5 protocol parser

NIFI-5327 Netflowv5 protocol parser processor.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PrashanthVenkatesan/nifi NIFI-5327

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2820


commit 825f388c29b3d0905d4640b7df51ee42531b773c
Author: “PrashanthVenkatesan” 
Date:   2018-06-27T12:42:00Z

NIFI-5327 Adding Netflowv5 protocol parser




> NetFlow Processors
> --
>
> Key: NIFI-5327
> URL: https://issues.apache.org/jira/browse/NIFI-5327
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Affects Versions: 1.6.0
>Reporter: Prashanth Venkatesan
>Assignee: Prashanth Venkatesan
>Priority: Major
>
> As network traffic data scopes for the big data use case, would like NiFi to 
> have processors to support parsing of those protocols.
> Netflow is a protocol introduced by Cisco that provides the ability to 
> collect IP network traffic as it enters or exits an interface and is 
> described in detail in here:
> [https://www.cisco.com/c/en/us/td/docs/net_mgmt/netflow_collection_engine/3-6/user/guide/format.html]
>  
> Currently, I have created the following processor:
> *ParseNetflowv5*:  Parses the ingress netflowv5 bytes and ingest as either 
> NiFi flowfile attributes or as a JSON content. This also sends 
> one-time-template.
>  
> Further ahead, we can add many processor specific to network protocols in 
> this nar bundle.
> I will create a pull request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-06-27 Thread PrashanthVenkatesan
GitHub user PrashanthVenkatesan opened a pull request:

https://github.com/apache/nifi/pull/2820

NIFI-5327 Adding Netflowv5 protocol parser

NIFI-5327 Netflowv5 protocol parser processor.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PrashanthVenkatesan/nifi NIFI-5327

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2820


commit 825f388c29b3d0905d4640b7df51ee42531b773c
Author: “PrashanthVenkatesan” 
Date:   2018-06-27T12:42:00Z

NIFI-5327 Adding Netflowv5 protocol parser




---


[jira] [Comment Edited] (MINIFICPP-546) minifi.sh status should return 0 when process isn't running

2018-06-27 Thread marco polo (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525212#comment-16525212
 ] 

marco polo edited comment on MINIFICPP-546 at 6/27/18 3:50 PM:
---

[~drodrigues] Why should it return 0? This case, I believe, is where we want to 
notify the caller that we have an unsuccessful exit, so a return code of zero 
would not indicate this. What purpose does changing this to successful serve? 

I'm guessing the original author wanted to serve this as being a notification 
mechanism when the status is intended to be running. [~aldrin], do you have any 
info on this?

Dustin is correct, it looks like it should be zero, but I'm worried this may 
break users and we should perhaps delay this for a separate release or at least 
make some notification. 


was (Author: phrocker):
[~drodrigues] Why should it return 0? This case, I believe, is where we want to 
notify the caller that we have an unsuccessful exit, so a return code of zero 
would not indicate this. What purpose does changing this to successful serve? 


I'm guessing the original author wanted to serve this as being a notification 
mechanism when the status is intended to be running. [~aldrin], do you have any 
info on this?

 

 

Dustin is correct, it looks like it should be zero, but I'm worried this may 
break users and we should perhaps delay this for a separate release or at least 
make some notification. 

> minifi.sh status should return 0 when process isn't running
> ---
>
> Key: MINIFICPP-546
> URL: https://issues.apache.org/jira/browse/MINIFICPP-546
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Dustin Rodrigues
>Assignee: Dustin Rodrigues
>Priority: Minor
>
> Currently, calling "minifi.sh status" when the process isn't running returns 
> exit code 3. It should return 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (MINIFICPP-546) minifi.sh status should return 0 when process isn't running

2018-06-27 Thread marco polo (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525212#comment-16525212
 ] 

marco polo edited comment on MINIFICPP-546 at 6/27/18 3:49 PM:
---

[~drodrigues] Why should it return 0? This case, I believe, is where we want to 
notify the caller that we have an unsuccessful exit, so a return code of zero 
would not indicate this. What purpose does changing this to successful serve? 


I'm guessing the original author wanted to serve this as being a notification 
mechanism when the status is intended to be running. [~aldrin], do you have any 
info on this?

 

 

Dustin is correct, it looks like it should be zero, but I'm worried this may 
break users and we should perhaps delay this for a separate release or at least 
make some notification. 


was (Author: phrocker):
[~drodrigues] Why should it return 0? This case, I believe, is where we want to 
notify the caller that we have an unsuccessful exit, so a return code of zero 
would not indicate this. What purpose does changing this to successful serve? 
Thanks

> minifi.sh status should return 0 when process isn't running
> ---
>
> Key: MINIFICPP-546
> URL: https://issues.apache.org/jira/browse/MINIFICPP-546
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Dustin Rodrigues
>Assignee: Dustin Rodrigues
>Priority: Minor
>
> Currently, calling "minifi.sh status" when the process isn't running returns 
> exit code 3. It should return 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-546) minifi.sh status should return 0 when process isn't running

2018-06-27 Thread marco polo (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525212#comment-16525212
 ] 

marco polo commented on MINIFICPP-546:
--

[~drodrigues] Why should it return 0? This case, I believe, is where we want to 
notify the caller that we have an unsuccessful exit, so a return code of zero 
would not indicate this. What purpose does changing this to successful serve? 
Thanks

> minifi.sh status should return 0 when process isn't running
> ---
>
> Key: MINIFICPP-546
> URL: https://issues.apache.org/jira/browse/MINIFICPP-546
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Dustin Rodrigues
>Assignee: Dustin Rodrigues
>Priority: Minor
>
> Currently, calling "minifi.sh status" when the process isn't running returns 
> exit code 3. It should return 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (NIFI-5327) NetFlow Processors

2018-06-27 Thread Aldrin Piri (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldrin Piri reassigned NIFI-5327:
-

Assignee: Prashanth Venkatesan

> NetFlow Processors
> --
>
> Key: NIFI-5327
> URL: https://issues.apache.org/jira/browse/NIFI-5327
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Affects Versions: 1.6.0
>Reporter: Prashanth Venkatesan
>Assignee: Prashanth Venkatesan
>Priority: Major
>
> As network traffic data scopes for the big data use case, would like NiFi to 
> have processors to support parsing of those protocols.
> Netflow is a protocol introduced by Cisco that provides the ability to 
> collect IP network traffic as it enters or exits an interface and is 
> described in detail in here:
> [https://www.cisco.com/c/en/us/td/docs/net_mgmt/netflow_collection_engine/3-6/user/guide/format.html]
>  
> Currently, I have created the following processor:
> *ParseNetflowv5*:  Parses the ingress netflowv5 bytes and ingest as either 
> NiFi flowfile attributes or as a JSON content. This also sends 
> one-time-template.
>  
> Further ahead, we can add many processor specific to network protocols in 
> this nar bundle.
> I will create a pull request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5344) Fix Write Ahead Log Unit Test on Windows

2018-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525165#comment-16525165
 ] 

ASF GitHub Bot commented on NIFI-5344:
--

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2819
  
Can you update the title of this pr to have more title?


> Fix Write Ahead Log Unit Test on Windows
> 
>
> Key: NIFI-5344
> URL: https://issues.apache.org/jira/browse/NIFI-5344
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
>
> On Windows, testRecoverFileThatHasTrailingNULBytesAndTruncation unit test 
> fails because it uses the same directory as 
> testRecoverFileThatHasTrailingNULBytesNoTruncation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi issue #2819: NIFI-5344

2018-06-27 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2819
  
Can you update the title of this pr to have more title?


---


[jira] [Commented] (NIFI-5344) Fix Write Ahead Log Unit Test on Windows

2018-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525083#comment-16525083
 ] 

ASF GitHub Bot commented on NIFI-5344:
--

GitHub user patricker opened a pull request:

https://github.com/apache/nifi/pull/2819

NIFI-5344

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/patricker/nifi NIFI-5344

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2819.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2819


commit 2aa9500e6688c97bb9ac59bf11f646239ad3989f
Author: patricker 
Date:   2018-06-27T13:20:10Z

NIFI-5344




> Fix Write Ahead Log Unit Test on Windows
> 
>
> Key: NIFI-5344
> URL: https://issues.apache.org/jira/browse/NIFI-5344
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
>
> On Windows, testRecoverFileThatHasTrailingNULBytesAndTruncation unit test 
> fails because it uses the same directory as 
> testRecoverFileThatHasTrailingNULBytesNoTruncation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #2819: NIFI-5344

2018-06-27 Thread patricker
GitHub user patricker opened a pull request:

https://github.com/apache/nifi/pull/2819

NIFI-5344

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/patricker/nifi NIFI-5344

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2819.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2819


commit 2aa9500e6688c97bb9ac59bf11f646239ad3989f
Author: patricker 
Date:   2018-06-27T13:20:10Z

NIFI-5344




---


[jira] [Created] (NIFI-5344) Fix Write Ahead Log Unit Test on Windows

2018-06-27 Thread Peter Wicks (JIRA)
Peter Wicks created NIFI-5344:
-

 Summary: Fix Write Ahead Log Unit Test on Windows
 Key: NIFI-5344
 URL: https://issues.apache.org/jira/browse/NIFI-5344
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Peter Wicks
Assignee: Peter Wicks


On Windows, testRecoverFileThatHasTrailingNULBytesAndTruncation unit test fails 
because it uses the same directory as 
testRecoverFileThatHasTrailingNULBytesNoTruncation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-5343) GetMongo fails when 'Character Set' has expression language

2018-06-27 Thread Sivaprasanna Sethuraman (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sivaprasanna Sethuraman updated NIFI-5343:
--
Attachment: NIFI-5343-Fix-GetMongo-to-properly-reads-charset.patch
Status: Patch Available  (was: In Progress)

> GetMongo fails when 'Character Set' has expression language
> ---
>
> Key: NIFI-5343
> URL: https://issues.apache.org/jira/browse/NIFI-5343
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.7.0, 1.6.0, 1.5.0
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Minor
> Attachments: NIFI-5343-Fix-GetMongo-to-properly-reads-charset.patch
>
>
> When GetMongo processors' have 'Character Set' set to an expression language 
> query such as '${charset}' and the incoming FlowFile carries the attribute 
> 'charset' with a valid Charset as its value, the processor should ideally 
> read the value and work but it fails with an "UnsupportedEncodingException"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5343) GetMongo fails when 'Character Set' has expression language

2018-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524857#comment-16524857
 ] 

ASF GitHub Bot commented on NIFI-5343:
--

GitHub user zenfenan opened a pull request:

https://github.com/apache/nifi/pull/2818

NIFI-5343: Fix GetMongo to properly read charset from FlowFile attri…

…butes

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zenfenan/nifi NIFI-5343

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2818


commit 776e7df9fb971ffeb29c3539df3695cb4ca19d41
Author: zenfenan 
Date:   2018-06-27T10:00:11Z

NIFI-5343: Fix GetMongo to properly reads charset from FlowFile attributes




> GetMongo fails when 'Character Set' has expression language
> ---
>
> Key: NIFI-5343
> URL: https://issues.apache.org/jira/browse/NIFI-5343
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.5.0, 1.6.0, 1.7.0
>Reporter: Sivaprasanna Sethuraman
>Assignee: Sivaprasanna Sethuraman
>Priority: Minor
>
> When GetMongo processors' have 'Character Set' set to an expression language 
> query such as '${charset}' and the incoming FlowFile carries the attribute 
> 'charset' with a valid Charset as its value, the processor should ideally 
> read the value and work but it fails with an "UnsupportedEncodingException"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] nifi pull request #2818: NIFI-5343: Fix GetMongo to properly read charset fr...

2018-06-27 Thread zenfenan
GitHub user zenfenan opened a pull request:

https://github.com/apache/nifi/pull/2818

NIFI-5343: Fix GetMongo to properly read charset from FlowFile attri…

…butes

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zenfenan/nifi NIFI-5343

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2818


commit 776e7df9fb971ffeb29c3539df3695cb4ca19d41
Author: zenfenan 
Date:   2018-06-27T10:00:11Z

NIFI-5343: Fix GetMongo to properly reads charset from FlowFile attributes




---


[jira] [Created] (NIFI-5343) GetMongo fails when 'Character Set' has expression language

2018-06-27 Thread Sivaprasanna Sethuraman (JIRA)
Sivaprasanna Sethuraman created NIFI-5343:
-

 Summary: GetMongo fails when 'Character Set' has expression 
language
 Key: NIFI-5343
 URL: https://issues.apache.org/jira/browse/NIFI-5343
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Affects Versions: 1.7.0, 1.6.0, 1.5.0
Reporter: Sivaprasanna Sethuraman
Assignee: Sivaprasanna Sethuraman


When GetMongo processors' have 'Character Set' set to an expression language 
query such as '${charset}' and the incoming FlowFile carries the attribute 
'charset' with a valid Charset as its value, the processor should ideally read 
the value and work but it fails with an "UnsupportedEncodingException"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-5342) CaptureChangeMySQL didn't escape database name

2018-06-27 Thread Tanapol Nearunchorn (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tanapol Nearunchorn updated NIFI-5342:
--
Description: 
CaptureChangeMySQL didn't escape database name as you can see:

[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L1003]

 

And also with the line 1004, which query from a table.

It can cause problems when there is database or table name that contains a 
reserved keyword.

  was:
CaptureChangeMySQL didn't escape database name as you can see:

[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L1003]

 

It cause problem when there using with database that contains reserved keyword.


> CaptureChangeMySQL didn't escape database name
> --
>
> Key: NIFI-5342
> URL: https://issues.apache.org/jira/browse/NIFI-5342
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
>Reporter: Tanapol Nearunchorn
>Priority: Major
>
> CaptureChangeMySQL didn't escape database name as you can see:
> [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L1003]
>  
> And also with the line 1004, which query from a table.
> It can cause problems when there is database or table name that contains a 
> reserved keyword.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (NIFI-5342) CaptureChangeMySQL didn't escape database name

2018-06-27 Thread Tanapol Nearunchorn (JIRA)
Tanapol Nearunchorn created NIFI-5342:
-

 Summary: CaptureChangeMySQL didn't escape database name
 Key: NIFI-5342
 URL: https://issues.apache.org/jira/browse/NIFI-5342
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 1.6.0
Reporter: Tanapol Nearunchorn


CaptureChangeMySQL didn't escape database name as you can see:

[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L1003]

 

It cause problem when there using with database that contains reserved keyword.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-5340) Not able to update the flow using NiFi registry when NiFi server is set as cluster mode

2018-06-27 Thread Pierre Villard (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524705#comment-16524705
 ] 

Pierre Villard commented on NIFI-5340:
--

Working with a cluster does not require additional settings to work with the 
NiFi Registry. I assume there is a component to be stopped while changing from 
version A to B and this component cannot be successfully stopped causing the 
error you're seeing. Can you share more details about what components are used 
in the workflow you want to update? In particular does it reference controller 
services? any particular processors that could require a long time to be 
stopped gracefully?

> Not able to update the flow using NiFi registry when NiFi server is set as 
> cluster mode
> ---
>
> Key: NIFI-5340
> URL: https://issues.apache.org/jira/browse/NIFI-5340
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: yahor tsaryk
>Priority: Major
>  Labels: Bug, Question
> Attachments: NiFi Flow Version Update via Registry (failure).png
>
>
> Hello, we recently updated our NiFi version to 1.6.0 and got ability to 
> synchronize flows in our environments via versioning i.e NiFi Registry. It 
> works pretty well when we try to fetch the latest flow version from the 
> Registry into a standalone NiFi server (without clustering mode). 
> However, when we try to update the flow in our environments where we run NiFi 
> in cluster mode composed of 3 nodes we got a failure:
> ```Failed to update flow to new version due to 
> org.apache.nifi.web.util.LifecycleManagementException: Failed while waiting 
> for components to transition to state of STOPPED```
> I attached a screenshot with this alert. Could you shed some light on this ? 
> Does cluster mode require any additional settings in order to work with NiFi 
> registry ? Let me know if you need more info



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)