[jira] [Created] (NIFI-5356) PutElasticsearchHttpRecord should write record.count attribute
Matt Burgess created NIFI-5356: -- Summary: PutElasticsearchHttpRecord should write record.count attribute Key: NIFI-5356 URL: https://issues.apache.org/jira/browse/NIFI-5356 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Matt Burgess Best practice for record-based processors is to write the "record.count" attribute to outgoing flow files, indicating how many records are in the flow file. PutElasticsearchHttpRecord does not write this attribute, this Jira proposes to add this functionality (and the associated documentation). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
[ https://issues.apache.org/jira/browse/NIFI-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yolanda M. Davis updated NIFI-5354: --- Resolution: Fixed Fix Version/s: 1.8.0 Status: Resolved (was: Patch Available) > Use ranger-client 1.0.0 in Ranger Authorizer > > > Key: NIFI-5354 > URL: https://issues.apache.org/jira/browse/NIFI-5354 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 1.8.0 > > > We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We > should bump the version, and since we also include hadoop-client in the > ranger-authorizer NAR, we should make it so you can override that version > independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
[ https://issues.apache.org/jira/browse/NIFI-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528529#comment-16528529 ] ASF GitHub Bot commented on NIFI-5354: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2827 > Use ranger-client 1.0.0 in Ranger Authorizer > > > Key: NIFI-5354 > URL: https://issues.apache.org/jira/browse/NIFI-5354 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We > should bump the version, and since we also include hadoop-client in the > ranger-authorizer NAR, we should make it so you can override that version > independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2827: NIFI-5354 Changing ranger.version to 1.0.0 and rang...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2827 ---
[jira] [Commented] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
[ https://issues.apache.org/jira/browse/NIFI-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528528#comment-16528528 ] ASF subversion and git services commented on NIFI-5354: --- Commit 3fd45ac4c4155311966f675c6a504d683796b172 in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=3fd45ac ] NIFI-5354 Changing ranger.version to 1.0.0 and ranger.hadoop.version to 3.0.0 Signed-off-by: Yolanda Davis This closes #2827 > Use ranger-client 1.0.0 in Ranger Authorizer > > > Key: NIFI-5354 > URL: https://issues.apache.org/jira/browse/NIFI-5354 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We > should bump the version, and since we also include hadoop-client in the > ranger-authorizer NAR, we should make it so you can override that version > independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5195) Make clustering enabled Docker image
[ https://issues.apache.org/jira/browse/NIFI-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528458#comment-16528458 ] ASF GitHub Bot commented on NIFI-5195: -- Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2828 @apiri can you review? > Make clustering enabled Docker image > > > Key: NIFI-5195 > URL: https://issues.apache.org/jira/browse/NIFI-5195 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Dongkyu Hwangbo >Assignee: Mike Thomsen >Priority: Major > > Currently, Docker image only support stand-alone but sometimes, for > experimental testing or any reason, Making cluster with multiple Docker > instance is needed. To make it enable, put related property in > nifi.properties is needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2828: NIFI-5195 Added clustering to the docker image
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2828 @apiri can you review? ---
[jira] [Commented] (NIFI-5195) Make clustering enabled Docker image
[ https://issues.apache.org/jira/browse/NIFI-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528449#comment-16528449 ] ASF GitHub Bot commented on NIFI-5195: -- GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2828 NIFI-5195 Added clustering to the docker image Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MikeThomsen/nifi NIFI-5195 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2828.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2828 commit ab5a7ea050ad603714616f56501bc6d12d14a6df Author: Mike Thomsen Date: 2018-06-30T00:48:08Z NIFI-5195 Added clustering to the docker image > Make clustering enabled Docker image > > > Key: NIFI-5195 > URL: https://issues.apache.org/jira/browse/NIFI-5195 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Dongkyu Hwangbo >Assignee: Mike Thomsen >Priority: Major > > Currently, Docker image only support stand-alone but sometimes, for > experimental testing or any reason, Making cluster with multiple Docker > instance is needed. To make it enable, put related property in > nifi.properties is needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2828: NIFI-5195 Added clustering to the docker image
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2828 NIFI-5195 Added clustering to the docker image Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MikeThomsen/nifi NIFI-5195 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2828.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2828 commit ab5a7ea050ad603714616f56501bc6d12d14a6df Author: Mike Thomsen Date: 2018-06-30T00:48:08Z NIFI-5195 Added clustering to the docker image ---
[jira] [Updated] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
[ https://issues.apache.org/jira/browse/NIFI-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yolanda M. Davis updated NIFI-5354: --- Affects Version/s: 1.7.0 > Use ranger-client 1.0.0 in Ranger Authorizer > > > Key: NIFI-5354 > URL: https://issues.apache.org/jira/browse/NIFI-5354 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We > should bump the version, and since we also include hadoop-client in the > ranger-authorizer NAR, we should make it so you can override that version > independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
[ https://issues.apache.org/jira/browse/NIFI-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yolanda M. Davis updated NIFI-5354: --- Comment: was deleted (was: PR posted here https://github.com/apache/nifi/pull/2827) > Use ranger-client 1.0.0 in Ranger Authorizer > > > Key: NIFI-5354 > URL: https://issues.apache.org/jira/browse/NIFI-5354 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We > should bump the version, and since we also include hadoop-client in the > ranger-authorizer NAR, we should make it so you can override that version > independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
[ https://issues.apache.org/jira/browse/NIFI-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yolanda M. Davis updated NIFI-5354: --- Status: Patch Available (was: Open) PR posted here https://github.com/apache/nifi/pull/2827 > Use ranger-client 1.0.0 in Ranger Authorizer > > > Key: NIFI-5354 > URL: https://issues.apache.org/jira/browse/NIFI-5354 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We > should bump the version, and since we also include hadoop-client in the > ranger-authorizer NAR, we should make it so you can override that version > independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1251) Allow ExecuteSQL to send out large result sets in chunks
[ https://issues.apache.org/jira/browse/NIFI-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528175#comment-16528175 ] Peter Wicks commented on NIFI-1251: --- I have a version just about ready. Unit tests are passing, but still need to do real testing (because Unit Tests don't test for commit's happening mid-run... :)). Will hopefully have a PR next week. Branch: [https://github.com/patricker/nifi/tree/NIFI-1251] > Allow ExecuteSQL to send out large result sets in chunks > > > Key: NIFI-1251 > URL: https://issues.apache.org/jira/browse/NIFI-1251 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Peter Wicks >Priority: Major > > Currently, when using ExecuteSQL, if a result set is very large, it can take > quite a long time to pull back all of the results. It would be nice to have > the ability to specify the maximum number of records to put into a FlowFile, > so that if we pull back say 1 million records we can configure it to create > 1000 FlowFiles, each with 1000 records. This way, we can begin processing the > first 1,000 records while the next 1000 are being pulled from the remote > database. > This suggestion comes from Vinay via the dev@ mailing list: > Is there way to have streaming feature when large result set is fetched from > database basically to reads data from the database in chunks of records > instead of loading the full result set into memory. > As part of ExecuteSQL can a property be specified called "FetchSize" which > Indicates how many rows should be fetched from the resultSet. > Since jam bit new in using NIFI , can any guide me on above. > Thanks in advance -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (NIFI-1251) Allow ExecuteSQL to send out large result sets in chunks
[ https://issues.apache.org/jira/browse/NIFI-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Wicks reassigned NIFI-1251: - Assignee: Peter Wicks > Allow ExecuteSQL to send out large result sets in chunks > > > Key: NIFI-1251 > URL: https://issues.apache.org/jira/browse/NIFI-1251 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Peter Wicks >Priority: Major > > Currently, when using ExecuteSQL, if a result set is very large, it can take > quite a long time to pull back all of the results. It would be nice to have > the ability to specify the maximum number of records to put into a FlowFile, > so that if we pull back say 1 million records we can configure it to create > 1000 FlowFiles, each with 1000 records. This way, we can begin processing the > first 1,000 records while the next 1000 are being pulled from the remote > database. > This suggestion comes from Vinay via the dev@ mailing list: > Is there way to have streaming feature when large result set is fetched from > database basically to reads data from the database in chunks of records > instead of loading the full result set into memory. > As part of ExecuteSQL can a property be specified called "FetchSize" which > Indicates how many rows should be fetched from the resultSet. > Since jam bit new in using NIFI , can any guide me on above. > Thanks in advance -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5355) ResizeImage Fails to read PNG type on some OS's
Peter Wicks created NIFI-5355: - Summary: ResizeImage Fails to read PNG type on some OS's Key: NIFI-5355 URL: https://issues.apache.org/jira/browse/NIFI-5355 Project: Apache NiFi Issue Type: Bug Reporter: Peter Wicks On some operating systems ResizeImage will fail to properly read the PNG file type when calling getType. It will return '0' instead of '5'. [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java#L177] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-4517) Allow SQL results to be output as records in any supported format
[ https://issues.apache.org/jira/browse/NIFI-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-4517: --- Summary: Allow SQL results to be output as records in any supported format (was: Create a processor to allow SQL results to be output as records in any supported format (ExecuteSQLToRecord)) > Allow SQL results to be output as records in any supported format > - > > Key: NIFI-4517 > URL: https://issues.apache.org/jira/browse/NIFI-4517 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Priority: Major > > ExecuteSQL currently only outputs Avro, and the schema is only available as > embedded within the flow file, not as an attribute such as record-aware > processors can handle. > I propose an ExecuteSQLToRecord processor that can be configured with a > RecordSetWriter implementation, or to change the existing ExecuteSQL > processor (although that might be more invasive and disruptive to existing > flows). This will allow output using any writer format (Avro, JSON, CSV, > Free-form text, etc.), as well as all the other features therein (such as > writing the schema to an attribute, and will avoid the need for a > ConvertAvroToXYZ or ConvertRecord processor downstream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4517) Create a processor to allow SQL results to be output as records in any supported format (ExecuteSQLToRecord)
[ https://issues.apache.org/jira/browse/NIFI-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528168#comment-16528168 ] Matt Burgess commented on NIFI-4517: That's a good point, with precedence: The SiteToSiteMetricsReportingTask has a default (Ambari) output along with the option for a Record Writer. Will update the title to be less specific to implementation, good catch thanks! > Create a processor to allow SQL results to be output as records in any > supported format (ExecuteSQLToRecord) > > > Key: NIFI-4517 > URL: https://issues.apache.org/jira/browse/NIFI-4517 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Priority: Major > > ExecuteSQL currently only outputs Avro, and the schema is only available as > embedded within the flow file, not as an attribute such as record-aware > processors can handle. > I propose an ExecuteSQLToRecord processor that can be configured with a > RecordSetWriter implementation, or to change the existing ExecuteSQL > processor (although that might be more invasive and disruptive to existing > flows). This will allow output using any writer format (Avro, JSON, CSV, > Free-form text, etc.), as well as all the other features therein (such as > writing the schema to an attribute, and will avoid the need for a > ConvertAvroToXYZ or ConvertRecord processor downstream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MINIFICPP-550) Create RocksDB Controller Service
marco polo created MINIFICPP-550: Summary: Create RocksDB Controller Service Key: MINIFICPP-550 URL: https://issues.apache.org/jira/browse/MINIFICPP-550 Project: NiFi MiNiFi C++ Issue Type: Bug Reporter: marco polo Assignee: marco polo A RocksDB Controller service will give us the ability to store arbitrary information into controller services that can later be sent via SiteToSite. This will support many of my monitoring and test use cases. Using RocksDB as a key/value store we can serialize and send this information periodically -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
[ https://issues.apache.org/jira/browse/NIFI-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528113#comment-16528113 ] ASF GitHub Bot commented on NIFI-5354: -- Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/2827 @bbende thanks Bryan I will review shortly > Use ranger-client 1.0.0 in Ranger Authorizer > > > Key: NIFI-5354 > URL: https://issues.apache.org/jira/browse/NIFI-5354 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We > should bump the version, and since we also include hadoop-client in the > ranger-authorizer NAR, we should make it so you can override that version > independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2827: NIFI-5354 Changing ranger.version to 1.0.0 and ranger.hado...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/2827 @bbende thanks Bryan I will review shortly ---
[jira] [Commented] (NIFI-4517) Create a processor to allow SQL results to be output as records in any supported format (ExecuteSQLToRecord)
[ https://issues.apache.org/jira/browse/NIFI-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528098#comment-16528098 ] Peter Wicks commented on NIFI-4517: --- [~mattyb149], does this need to be a new processor? Could we just add an optional RecordWriter property to ExecuteSQL, that if not set defaults to using the existing Avro? > Create a processor to allow SQL results to be output as records in any > supported format (ExecuteSQLToRecord) > > > Key: NIFI-4517 > URL: https://issues.apache.org/jira/browse/NIFI-4517 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Priority: Major > > ExecuteSQL currently only outputs Avro, and the schema is only available as > embedded within the flow file, not as an attribute such as record-aware > processors can handle. > I propose an ExecuteSQLToRecord processor that can be configured with a > RecordSetWriter implementation, or to change the existing ExecuteSQL > processor (although that might be more invasive and disruptive to existing > flows). This will allow output using any writer format (Avro, JSON, CSV, > Free-form text, etc.), as well as all the other features therein (such as > writing the schema to an attribute, and will avoid the need for a > ConvertAvroToXYZ or ConvertRecord processor downstream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[ https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528081#comment-16528081 ] ASF GitHub Bot commented on MINIFICPP-543: -- Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/365 @apiri I made some updates to the wiki entry. > Add Policy enforcement to C2 Updates > > > Key: MINIFICPP-543 > URL: https://issues.apache.org/jira/browse/MINIFICPP-543 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: marco polo >Assignee: marco polo >Priority: Major > > Enable configuration based policy enforcement for C2 updates. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
[ https://issues.apache.org/jira/browse/NIFI-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528079#comment-16528079 ] ASF GitHub Bot commented on NIFI-5354: -- GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2827 NIFI-5354 Changing ranger.version to 1.0.0 and ranger.hadoop.version … …to 3.0.0 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi ranger-hadoop-version Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2827.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2827 commit d9d89721af1a10ae135c609c60b4eaf68438962d Author: Bryan Bende Date: 2018-06-29T14:33:10Z NIFI-5354 Changing ranger.version to 1.0.0 and ranger.hadoop.version to 3.0.0 > Use ranger-client 1.0.0 in Ranger Authorizer > > > Key: NIFI-5354 > URL: https://issues.apache.org/jira/browse/NIFI-5354 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > > We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We > should bump the version, and since we also include hadoop-client in the > ranger-authorizer NAR, we should make it so you can override that version > independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp issue #365: MINIFICPP-543: Implement C2 based update policy ...
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/365 @apiri I made some updates to the wiki entry. ---
[GitHub] nifi pull request #2827: NIFI-5354 Changing ranger.version to 1.0.0 and rang...
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2827 NIFI-5354 Changing ranger.version to 1.0.0 and ranger.hadoop.version ⦠â¦to 3.0.0 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi ranger-hadoop-version Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2827.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2827 commit d9d89721af1a10ae135c609c60b4eaf68438962d Author: Bryan Bende Date: 2018-06-29T14:33:10Z NIFI-5354 Changing ranger.version to 1.0.0 and ranger.hadoop.version to 3.0.0 ---
[jira] [Created] (NIFI-5354) Use ranger-client 1.0.0 in Ranger Authorizer
Bryan Bende created NIFI-5354: - Summary: Use ranger-client 1.0.0 in Ranger Authorizer Key: NIFI-5354 URL: https://issues.apache.org/jira/browse/NIFI-5354 Project: Apache NiFi Issue Type: Improvement Reporter: Bryan Bende Assignee: Bryan Bende We currently use ranger-client 0.7.1, but 1.0.0 has been out for a while. We should bump the version, and since we also include hadoop-client in the ranger-authorizer NAR, we should make it so you can override that version independent of other hadoop.version properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MINIFICPP-549) C2 heartbeats should have a periodic reduced state
marco polo created MINIFICPP-549: Summary: C2 heartbeats should have a periodic reduced state Key: MINIFICPP-549 URL: https://issues.apache.org/jira/browse/MINIFICPP-549 Project: NiFi MiNiFi C++ Issue Type: Bug Reporter: marco polo We can reduce the size of heartbeats by only sending certain information a different periodicity than a full heartbeat. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (NIFI-5353) Add a JoltTransformRecord processor
[ https://issues.apache.org/jira/browse/NIFI-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-5353: -- Assignee: Matt Burgess > Add a JoltTransformRecord processor > --- > > Key: NIFI-5353 > URL: https://issues.apache.org/jira/browse/NIFI-5353 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > JOLT is a great Domain-Specific Language (DSL) and engine for transforming > JSON documents, which our JoltTransformJSON processor leverages. However, the > JOLT engine simply translates the JSON text into a Java object, runs the > transformation based on the spec, and then transforms the object(s) back into > JSON. This is very similar to how our record-based processors work, and JOLT > itself is not bound to JSON per se. > We can leverage JOLT to provide a record-based processor to run JOLT > transformations on any incoming record sets, such as XML, CSV, Avro, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5353) Add a JoltTransformRecord processor
Matt Burgess created NIFI-5353: -- Summary: Add a JoltTransformRecord processor Key: NIFI-5353 URL: https://issues.apache.org/jira/browse/NIFI-5353 Project: Apache NiFi Issue Type: New Feature Components: Extensions Reporter: Matt Burgess JOLT is a great Domain-Specific Language (DSL) and engine for transforming JSON documents, which our JoltTransformJSON processor leverages. However, the JOLT engine simply translates the JSON text into a Java object, runs the transformation based on the spec, and then transforms the object(s) back into JSON. This is very similar to how our record-based processors work, and JOLT itself is not bound to JSON per se. We can leverage JOLT to provide a record-based processor to run JOLT transformations on any incoming record sets, such as XML, CSV, Avro, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527985#comment-16527985
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199227402
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
--- End diff --
I typed a long response that Allow All doesn't fit what I intended with
disallow, below; however, it was lost. I think the gist of that response was I
will think about a better name to convey its meaning.
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199227402
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
--- End diff --
I typed a long response that Allow All doesn't fit what I intended with
disallow, below; however, it was lost. I think the gist of that response was I
will think about a better name to convey its meaning.
---
[jira] [Commented] (NIFI-4535) Set the Page Title to the name of the Root Process Group
[ https://issues.apache.org/jira/browse/NIFI-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527957#comment-16527957 ] ASF GitHub Bot commented on NIFI-4535: -- Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2826 Three cheers.\ > Set the Page Title to the name of the Root Process Group > > > Key: NIFI-4535 > URL: https://issues.apache.org/jira/browse/NIFI-4535 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > NiFi's UI has a hard coded page title of NiFi. I have many servers and it's > hard to keep track of the tabs in Chrome. > Please change the Title of the page so it matches the name of the Root > processor group. This way I can name the root group by server/instance, and > easily identify the right tab/window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2826: NIFI-4535 Set the Page Title to the name of the Root Proce...
Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2826 Three cheers.\ ---
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527942#comment-16527942
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199220324
--- Diff: libminifi/test/unit/UpdatePolicyTests.cpp ---
@@ -0,0 +1,78 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include "../TestBase.h"
+#include "io/ClientSocket.h"
+#include "core/Processor.h"
+#include "../../controller/Controller.h"
+#include "core/controller/ControllerService.h"
+#include "c2/ControllerSocketProtocol.h"
+#include "controllers/UpdatePolicyControllerService.h"
+
+TEST_CASE("TestEmptyPolicy", "[test1]") {
+ auto controller =
std::make_shared("TestService");
+ std::shared_ptr configuration =
std::make_shared();
+ controller->initialize();
+ controller->onEnable();
+ REQUIRE(false == controller->canUpdate("anyproperty"));
+}
+
+TEST_CASE("TestEnableAll", "[test1]") {
+ auto controller =
std::make_shared("TestService");
+ std::shared_ptr configuration =
std::make_shared();
+ controller->initialize();
+
controller->setProperty(minifi::controllers::UpdatePolicyControllerService::EnableAllProperties,
"true");
+ controller->onEnable();
+ REQUIRE(true == controller->canUpdate("anyproperty"));
+}
+
+TEST_CASE("TestEnableAllFalls", "[test1]") {
--- End diff --
Oh wow. Thanks. This is what I get for using a 4k monitor.
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527937#comment-16527937
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199220156
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
+
+void UpdatePolicyControllerService::initialize() {
+ std::set supportedProperties;
+ supportedProperties.insert(EnableAllProperties);
+ supportedProperties.insert(AllowedProperties);
+ supportedProperties.insert(DisallowedProperties);
+ supportedProperties.insert(PersistUpdates);
+ setSupportedProperties(supportedProperties);
+}
+
+void UpdatePolicyControllerService::yield() {
+}
+
+bool UpdatePolicyControllerService::isRunning() {
+ return getState() == core::controller::ControllerServiceState::ENABLED;
+}
+
+bool UpdatePolicyControllerService::isWorkAvailable() {
+ return false;
+}
+
+void UpdatePolicyControllerService::onEnable() {
+ std::string enableStr, persistStr;
+
+ bool enable_all = false;
+ if (getProperty(EnableAllProperties.getName(), enableStr)) {
+enable_all = utils::StringUtils::StringToBool(enableStr, enable_all);
+ }
+
+ if (getProperty(PersistUpdates.getName(), persistStr)) {
--- End diff --
"I assume the policy service would get precedence but am uncertain of
conditions such as I request allowing permanent but the instance is not
configured to persist config changes."
I'm not sure I follow...but perhaps I should explain this a little better
before adding a comment for the code to ensure it makes sense. Updates can be
controlled via the flow via the controller service. There may be cases where
you do not want configuration updates to be persisted. An easy case would be
one in which there is no volatile storage. That's a bit trite as it over
exemplifies the argument; however, a less whimsical example may be one in which
you only want updates to persist through transferring the minifi.properties
file. This ONLY controls updates performed through mechanisms that use the
controller service. Does that make sense? If so I'd like to document that on
the wiki and in the code as your question points out that it's a point of
confusion.
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enabl
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199220324
--- Diff: libminifi/test/unit/UpdatePolicyTests.cpp ---
@@ -0,0 +1,78 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include "../TestBase.h"
+#include "io/ClientSocket.h"
+#include "core/Processor.h"
+#include "../../controller/Controller.h"
+#include "core/controller/ControllerService.h"
+#include "c2/ControllerSocketProtocol.h"
+#include "controllers/UpdatePolicyControllerService.h"
+
+TEST_CASE("TestEmptyPolicy", "[test1]") {
+ auto controller =
std::make_shared("TestService");
+ std::shared_ptr configuration =
std::make_shared();
+ controller->initialize();
+ controller->onEnable();
+ REQUIRE(false == controller->canUpdate("anyproperty"));
+}
+
+TEST_CASE("TestEnableAll", "[test1]") {
+ auto controller =
std::make_shared("TestService");
+ std::shared_ptr configuration =
std::make_shared();
+ controller->initialize();
+
controller->setProperty(minifi::controllers::UpdatePolicyControllerService::EnableAllProperties,
"true");
+ controller->onEnable();
+ REQUIRE(true == controller->canUpdate("anyproperty"));
+}
+
+TEST_CASE("TestEnableAllFalls", "[test1]") {
--- End diff --
Oh wow. Thanks. This is what I get for using a 4k monitor.
---
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527939#comment-16527939
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199220210
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
+
+void UpdatePolicyControllerService::initialize() {
+ std::set supportedProperties;
+ supportedProperties.insert(EnableAllProperties);
+ supportedProperties.insert(AllowedProperties);
+ supportedProperties.insert(DisallowedProperties);
+ supportedProperties.insert(PersistUpdates);
+ setSupportedProperties(supportedProperties);
+}
+
+void UpdatePolicyControllerService::yield() {
+}
+
+bool UpdatePolicyControllerService::isRunning() {
+ return getState() == core::controller::ControllerServiceState::ENABLED;
+}
+
+bool UpdatePolicyControllerService::isWorkAvailable() {
+ return false;
+}
+
+void UpdatePolicyControllerService::onEnable() {
+ std::string enableStr, persistStr;
+
+ bool enable_all = false;
+ if (getProperty(EnableAllProperties.getName(), enableStr)) {
+enable_all = utils::StringUtils::StringToBool(enableStr, enable_all);
+ }
+
+ if (getProperty(PersistUpdates.getName(), persistStr)) {
+persist_updates_ = utils::StringUtils::StringToBool(persistStr,
persist_updates_);
+ }
+
+ auto builder = state::UpdatePolicyBuilder::newBuilder(enable_all);
+
+ core::Property all_prop("Allowed Properties", "Properties for which we
will allow updates");
+ core::Property dall_prop("Disallowed Properties", "Properties for which
we will allow updates");
--- End diff --
COPY PASTA! Thanks!
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4535) Set the Page Title to the name of the Root Process Group
[ https://issues.apache.org/jira/browse/NIFI-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527940#comment-16527940 ] ASF GitHub Bot commented on NIFI-4535: -- GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2826 NIFI-4535 Set the Page Title to the name of the Root Process Group NiFi will automatically update the HTML page title to reflect the name of the root processor group. This code runs whenever a Processor Group is being loaded/reloaded, allowing for immediate updates to the title. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-4535 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2826.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2826 commit 6a1498e4ec58571fcc75a34db6879d1b71265f76 Author: patricker Date: 2018-06-29T16:49:44Z NIFI-4535 > Set the Page Title to the name of the Root Process Group > > > Key: NIFI-4535 > URL: https://issues.apache.org/jira/browse/NIFI-4535 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > NiFi's UI has a hard coded page title of NiFi. I have many servers and it's > hard to keep track of the tabs in Chrome. > Please change the Title of the page so it matches the name of the Root > processor group. This way I can name the root group by server/instance, and > easily identify the right tab/window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199220156
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
+
+void UpdatePolicyControllerService::initialize() {
+ std::set supportedProperties;
+ supportedProperties.insert(EnableAllProperties);
+ supportedProperties.insert(AllowedProperties);
+ supportedProperties.insert(DisallowedProperties);
+ supportedProperties.insert(PersistUpdates);
+ setSupportedProperties(supportedProperties);
+}
+
+void UpdatePolicyControllerService::yield() {
+}
+
+bool UpdatePolicyControllerService::isRunning() {
+ return getState() == core::controller::ControllerServiceState::ENABLED;
+}
+
+bool UpdatePolicyControllerService::isWorkAvailable() {
+ return false;
+}
+
+void UpdatePolicyControllerService::onEnable() {
+ std::string enableStr, persistStr;
+
+ bool enable_all = false;
+ if (getProperty(EnableAllProperties.getName(), enableStr)) {
+enable_all = utils::StringUtils::StringToBool(enableStr, enable_all);
+ }
+
+ if (getProperty(PersistUpdates.getName(), persistStr)) {
--- End diff --
"I assume the policy service would get precedence but am uncertain of
conditions such as I request allowing permanent but the instance is not
configured to persist config changes."
I'm not sure I follow...but perhaps I should explain this a little better
before adding a comment for the code to ensure it makes sense. Updates can be
controlled via the flow via the controller service. There may be cases where
you do not want configuration updates to be persisted. An easy case would be
one in which there is no volatile storage. That's a bit trite as it over
exemplifies the argument; however, a less whimsical example may be one in which
you only want updates to persist through transferring the minifi.properties
file. This ONLY controls updates performed through mechanisms that use the
controller service. Does that make sense? If so I'd like to document that on
the wiki and in the code as your question points out that it's a point of
confusion.
---
[GitHub] nifi pull request #2826: NIFI-4535 Set the Page Title to the name of the Roo...
GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2826 NIFI-4535 Set the Page Title to the name of the Root Process Group NiFi will automatically update the HTML page title to reflect the name of the root processor group. This code runs whenever a Processor Group is being loaded/reloaded, allowing for immediate updates to the title. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-4535 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2826.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2826 commit 6a1498e4ec58571fcc75a34db6879d1b71265f76 Author: patricker Date: 2018-06-29T16:49:44Z NIFI-4535 ---
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199220210
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
+
+void UpdatePolicyControllerService::initialize() {
+ std::set supportedProperties;
+ supportedProperties.insert(EnableAllProperties);
+ supportedProperties.insert(AllowedProperties);
+ supportedProperties.insert(DisallowedProperties);
+ supportedProperties.insert(PersistUpdates);
+ setSupportedProperties(supportedProperties);
+}
+
+void UpdatePolicyControllerService::yield() {
+}
+
+bool UpdatePolicyControllerService::isRunning() {
+ return getState() == core::controller::ControllerServiceState::ENABLED;
+}
+
+bool UpdatePolicyControllerService::isWorkAvailable() {
+ return false;
+}
+
+void UpdatePolicyControllerService::onEnable() {
+ std::string enableStr, persistStr;
+
+ bool enable_all = false;
+ if (getProperty(EnableAllProperties.getName(), enableStr)) {
+enable_all = utils::StringUtils::StringToBool(enableStr, enable_all);
+ }
+
+ if (getProperty(PersistUpdates.getName(), persistStr)) {
+persist_updates_ = utils::StringUtils::StringToBool(persistStr,
persist_updates_);
+ }
+
+ auto builder = state::UpdatePolicyBuilder::newBuilder(enable_all);
+
+ core::Property all_prop("Allowed Properties", "Properties for which we
will allow updates");
+ core::Property dall_prop("Disallowed Properties", "Properties for which
we will allow updates");
--- End diff --
COPY PASTA! Thanks!
---
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527931#comment-16527931
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199218485
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
--- End diff --
This is the intransitive verb.
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199218485
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
--- End diff --
This is the intransitive verb.
---
[jira] [Resolved] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved NIFIREG-180. - Resolution: Fixed > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > Fix For: 0.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri updated NIFIREG-180: Fix Version/s: 0.3.0 > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > Fix For: 0.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527920#comment-16527920 ] ASF GitHub Bot commented on NIFIREG-180: Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/128 > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > Fix For: 0.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-registry pull request #128: NIFIREG-180 Added db configuration properti...
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/128 ---
[jira] [Commented] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527917#comment-16527917 ] ASF GitHub Bot commented on NIFIREG-180: Github user apiri commented on the issue: https://github.com/apache/nifi-registry/pull/128 @MikeThomsen looks good. thank you for the updates. definitely helpful to not have to dig through source to see what is possible. > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...
Github user apiri commented on the issue: https://github.com/apache/nifi-registry/pull/128 @MikeThomsen looks good. thank you for the updates. definitely helpful to not have to dig through source to see what is possible. ---
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527913#comment-16527913
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199214051
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
+
+void UpdatePolicyControllerService::initialize() {
+ std::set supportedProperties;
+ supportedProperties.insert(EnableAllProperties);
+ supportedProperties.insert(AllowedProperties);
+ supportedProperties.insert(DisallowedProperties);
+ supportedProperties.insert(PersistUpdates);
+ setSupportedProperties(supportedProperties);
+}
+
+void UpdatePolicyControllerService::yield() {
+}
+
+bool UpdatePolicyControllerService::isRunning() {
+ return getState() == core::controller::ControllerServiceState::ENABLED;
+}
+
+bool UpdatePolicyControllerService::isWorkAvailable() {
+ return false;
+}
+
+void UpdatePolicyControllerService::onEnable() {
+ std::string enableStr, persistStr;
+
+ bool enable_all = false;
+ if (getProperty(EnableAllProperties.getName(), enableStr)) {
+enable_all = utils::StringUtils::StringToBool(enableStr, enable_all);
+ }
+
+ if (getProperty(PersistUpdates.getName(), persistStr)) {
+persist_updates_ = utils::StringUtils::StringToBool(persistStr,
persist_updates_);
+ }
+
+ auto builder = state::UpdatePolicyBuilder::newBuilder(enable_all);
+
+ core::Property all_prop("Allowed Properties", "Properties for which we
will allow updates");
+ core::Property dall_prop("Disallowed Properties", "Properties for which
we will allow updates");
--- End diff --
allow -> disallow
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199214051
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
+
+void UpdatePolicyControllerService::initialize() {
+ std::set supportedProperties;
+ supportedProperties.insert(EnableAllProperties);
+ supportedProperties.insert(AllowedProperties);
+ supportedProperties.insert(DisallowedProperties);
+ supportedProperties.insert(PersistUpdates);
+ setSupportedProperties(supportedProperties);
+}
+
+void UpdatePolicyControllerService::yield() {
+}
+
+bool UpdatePolicyControllerService::isRunning() {
+ return getState() == core::controller::ControllerServiceState::ENABLED;
+}
+
+bool UpdatePolicyControllerService::isWorkAvailable() {
+ return false;
+}
+
+void UpdatePolicyControllerService::onEnable() {
+ std::string enableStr, persistStr;
+
+ bool enable_all = false;
+ if (getProperty(EnableAllProperties.getName(), enableStr)) {
+enable_all = utils::StringUtils::StringToBool(enableStr, enable_all);
+ }
+
+ if (getProperty(PersistUpdates.getName(), persistStr)) {
+persist_updates_ = utils::StringUtils::StringToBool(persistStr,
persist_updates_);
+ }
+
+ auto builder = state::UpdatePolicyBuilder::newBuilder(enable_all);
+
+ core::Property all_prop("Allowed Properties", "Properties for which we
will allow updates");
+ core::Property dall_prop("Disallowed Properties", "Properties for which
we will allow updates");
--- End diff --
allow -> disallow
---
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527915#comment-16527915
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199212457
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
+
+void UpdatePolicyControllerService::initialize() {
+ std::set supportedProperties;
+ supportedProperties.insert(EnableAllProperties);
+ supportedProperties.insert(AllowedProperties);
+ supportedProperties.insert(DisallowedProperties);
+ supportedProperties.insert(PersistUpdates);
+ setSupportedProperties(supportedProperties);
+}
+
+void UpdatePolicyControllerService::yield() {
+}
+
+bool UpdatePolicyControllerService::isRunning() {
+ return getState() == core::controller::ControllerServiceState::ENABLED;
+}
+
+bool UpdatePolicyControllerService::isWorkAvailable() {
+ return false;
+}
+
+void UpdatePolicyControllerService::onEnable() {
+ std::string enableStr, persistStr;
+
+ bool enable_all = false;
+ if (getProperty(EnableAllProperties.getName(), enableStr)) {
+enable_all = utils::StringUtils::StringToBool(enableStr, enable_all);
+ }
+
+ if (getProperty(PersistUpdates.getName(), persistStr)) {
--- End diff --
I saw this is being handled via MINIFICPP-544. It seems like this should
be used in conjunction with the temp/permanent considerations. Scanned through
the C2 wiki page but am a little hazy about how this interacts with
temp/permanent. I assume the policy service would get precedence but am
uncertain of conditions such as I request allowing permanent but the instance
is not configured to persist config changes.
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199214256
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
--- End diff --
Not sure I am tracking the delineation between "enable" and "allow". It
seems that enable all might be better suited as AllowAll?
---
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199213790
--- Diff: libminifi/test/unit/UpdatePolicyTests.cpp ---
@@ -0,0 +1,78 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include "../TestBase.h"
+#include "io/ClientSocket.h"
+#include "core/Processor.h"
+#include "../../controller/Controller.h"
+#include "core/controller/ControllerService.h"
+#include "c2/ControllerSocketProtocol.h"
+#include "controllers/UpdatePolicyControllerService.h"
+
+TEST_CASE("TestEmptyPolicy", "[test1]") {
+ auto controller =
std::make_shared("TestService");
+ std::shared_ptr configuration =
std::make_shared();
+ controller->initialize();
+ controller->onEnable();
+ REQUIRE(false == controller->canUpdate("anyproperty"));
+}
+
+TEST_CASE("TestEnableAll", "[test1]") {
+ auto controller =
std::make_shared("TestService");
+ std::shared_ptr configuration =
std::make_shared();
+ controller->initialize();
+
controller->setProperty(minifi::controllers::UpdatePolicyControllerService::EnableAllProperties,
"true");
+ controller->onEnable();
+ REQUIRE(true == controller->canUpdate("anyproperty"));
+}
+
+TEST_CASE("TestEnableAllFalls", "[test1]") {
--- End diff --
Falls -> Fails
---
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527916#comment-16527916
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199213790
--- Diff: libminifi/test/unit/UpdatePolicyTests.cpp ---
@@ -0,0 +1,78 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include "../TestBase.h"
+#include "io/ClientSocket.h"
+#include "core/Processor.h"
+#include "../../controller/Controller.h"
+#include "core/controller/ControllerService.h"
+#include "c2/ControllerSocketProtocol.h"
+#include "controllers/UpdatePolicyControllerService.h"
+
+TEST_CASE("TestEmptyPolicy", "[test1]") {
+ auto controller =
std::make_shared("TestService");
+ std::shared_ptr configuration =
std::make_shared();
+ controller->initialize();
+ controller->onEnable();
+ REQUIRE(false == controller->canUpdate("anyproperty"));
+}
+
+TEST_CASE("TestEnableAll", "[test1]") {
+ auto controller =
std::make_shared("TestService");
+ std::shared_ptr configuration =
std::make_shared();
+ controller->initialize();
+
controller->setProperty(minifi::controllers::UpdatePolicyControllerService::EnableAllProperties,
"true");
+ controller->onEnable();
+ REQUIRE(true == controller->canUpdate("anyproperty"));
+}
+
+TEST_CASE("TestEnableAllFalls", "[test1]") {
--- End diff --
Falls -> Fails
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527912#comment-16527912
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199214256
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
--- End diff --
Not sure I am tracking the delineation between "enable" and "allow". It
seems that enable all might be better suited as AllowAll?
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[
https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527914#comment-16527914
]
ASF GitHub Bot commented on MINIFICPP-543:
--
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199210517
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
--- End diff --
a -> after
> Add Policy enforcement to C2 Updates
>
>
> Key: MINIFICPP-543
> URL: https://issues.apache.org/jira/browse/MINIFICPP-543
> Project: NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> Enable configuration based policy enforcement for C2 updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199212457
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
+
+void UpdatePolicyControllerService::initialize() {
+ std::set supportedProperties;
+ supportedProperties.insert(EnableAllProperties);
+ supportedProperties.insert(AllowedProperties);
+ supportedProperties.insert(DisallowedProperties);
+ supportedProperties.insert(PersistUpdates);
+ setSupportedProperties(supportedProperties);
+}
+
+void UpdatePolicyControllerService::yield() {
+}
+
+bool UpdatePolicyControllerService::isRunning() {
+ return getState() == core::controller::ControllerServiceState::ENABLED;
+}
+
+bool UpdatePolicyControllerService::isWorkAvailable() {
+ return false;
+}
+
+void UpdatePolicyControllerService::onEnable() {
+ std::string enableStr, persistStr;
+
+ bool enable_all = false;
+ if (getProperty(EnableAllProperties.getName(), enableStr)) {
+enable_all = utils::StringUtils::StringToBool(enableStr, enable_all);
+ }
+
+ if (getProperty(PersistUpdates.getName(), persistStr)) {
--- End diff --
I saw this is being handled via MINIFICPP-544. It seems like this should
be used in conjunction with the temp/permanent considerations. Scanned through
the C2 wiki page but am a little hazy about how this interacts with
temp/permanent. I assume the policy service would get precedence but am
uncertain of conditions such as I request allowing permanent but the instance
is not configured to persist config changes.
---
[GitHub] nifi-minifi-cpp pull request #365: MINIFICPP-543: Implement C2 based update ...
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199210517
--- Diff: libminifi/src/controllers/UpdatePolicyControllerService.cpp ---
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "controllers/UpdatePolicyControllerService.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "utils/StringUtils.h"
+#if ( defined(__APPLE__) || defined(__MACH__) || defined(BSD))
+#include
+#include
+#endif
+#include "core/state/UpdatePolicy.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace controllers {
+
+core::Property UpdatePolicyControllerService::EnableAllProperties("Enable
All Properties", "Enables all properties", "false");
+core::Property UpdatePolicyControllerService::AllowedProperties("Allowed
Properties", "Properties for which we will allow updates");
+core::Property
UpdatePolicyControllerService::DisallowedProperties("Disallowed Properties",
"Properties for which we will not allow updates");
+core::Property UpdatePolicyControllerService::PersistUpdates("Persist
Updates", "Property that dictates whether updates should persist a restart");
--- End diff --
a -> after
---
[jira] [Commented] (NIFI-5352) Change distribution to have the JARs and NARs in lib readable by "other"
[
https://issues.apache.org/jira/browse/NIFI-5352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527893#comment-16527893
]
ASF GitHub Bot commented on NIFI-5352:
--
GitHub user lfrancke opened a pull request:
https://github.com/apache/nifi/pull/2825
NIFI-5352 Change distribution to have the JARs and NARs in lib readable by
"other"
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ x] Does your PR title start with NIFI- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lfrancke/nifi NIFI-5352
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2825.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2825
commit d3b1694c4e77165a5ff87b0dc0be98a1ed86cd0d
Author: Lars Francke
Date: 2018-06-29T16:09:36Z
NIFI-5352 Change distribution to have the JARs and NARs in lib readable by
"other"
> Change distribution to have the JARs and NARs in lib readable by "other"
>
>
> Key: NIFI-5352
> URL: https://issues.apache.org/jira/browse/NIFI-5352
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Affects Versions: 1.7.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
>
> Currently all the nar and jar files under {{lib}} and {{lib/boostrap}} have
> the 640 permissions. That means it can't even be read by "other".
> When I extract it as "root" but want to run as "nifi" this causes it to fail
> because the "nifi" user cannot read the jar files.
> I don't think there's a particular harm in having others being able to read
> those files. So I'd like to change the assembly to include those as 644 if
> there are no objections.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2825: NIFI-5352 Change distribution to have the JARs and ...
GitHub user lfrancke opened a pull request: https://github.com/apache/nifi/pull/2825 NIFI-5352 Change distribution to have the JARs and NARs in lib readable by "other" Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lfrancke/nifi NIFI-5352 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2825.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2825 commit d3b1694c4e77165a5ff87b0dc0be98a1ed86cd0d Author: Lars Francke Date: 2018-06-29T16:09:36Z NIFI-5352 Change distribution to have the JARs and NARs in lib readable by "other" ---
[jira] [Created] (NIFI-5352) Change distribution to have the JARs and NARs in lib readable by "other"
Lars Francke created NIFI-5352:
--
Summary: Change distribution to have the JARs and NARs in lib
readable by "other"
Key: NIFI-5352
URL: https://issues.apache.org/jira/browse/NIFI-5352
Project: Apache NiFi
Issue Type: Improvement
Components: Tools and Build
Affects Versions: 1.7.0
Reporter: Lars Francke
Assignee: Lars Francke
Currently all the nar and jar files under {{lib}} and {{lib/boostrap}} have the
640 permissions. That means it can't even be read by "other".
When I extract it as "root" but want to run as "nifi" this causes it to fail
because the "nifi" user cannot read the jar files.
I don't think there's a particular harm in having others being able to read
those files. So I'd like to change the assembly to include those as 644 if
there are no objections.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFIREG-182) Add a way to move on from reverted versions
[
https://issues.apache.org/jira/browse/NIFIREG-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fredrik Sko updated NIFIREG-182:
Description:
Quote from {{nifi-users thread "Registry - deleting versions of flow}}".
{quote}I'm not sure if my workflow needs to change using NiFi + NiFi Registry,
or if this is a bug or corner-case.
I do the following:
1) Create a new process group, make the initial flow and start version control
(ver 1)
2) Modify the workflow and commit (ver 2)
3) Realize the most recent change was defective, and reverts (back to ver 1)
4) Make some new changes
I'm now stuck with NiFi telling me "Local changes have been made and a newer
version of the flow is available".
There are two options as I see it:
1) The need for the ability to delete version 2, enabling me to commit my
local changes.
2) The ability to commit a new version 3, which is a child of version 1.
As of now (running NiFI 1.7 and Registry 0.2), my only options are to either
revert my local changes or stop version control. My current workaround is
unfortunately to stop version control, delete the entire flow using the
Registry UI and start over again.
Thoughts?
{quote}
Creating Jira ticket as suggested by [~bende] to track
development/ideas/thoughts.
was:
Quote from {{nifi-users }}thread {{Registry - deleting versions of flow}}.
{quote}I'm not sure if my workflow needs to change using NiFi + NiFi Registry,
or if this is a bug or corner-case.
I do the following:
1) Create a new process group, make the initial flow and start version control
(ver 1)
2) Modify the workflow and commit (ver 2)
3) Realize the most recent change was defective, and reverts (back to ver 1)
4) Make some new changes
I'm now stuck with NiFi telling me "Local changes have been made and a newer
version of the flow is available".
There are two options as I see it:
1) The need for the ability to delete version 2, enabling me to commit my local
changes.
2) The ability to commit a new version 3, which is a child of version 1.
As of now (running NiFI 1.7 and Registry 0.2), my only options are to either
revert my local changes or stop version control. My current workaround is
unfortunately to stop version control, delete the entire flow using the
Registry UI and start over again.
Thoughts?{quote}
Creating Jira ticket as suggested by [~bende] to track
development/ideas/thoughts.
> Add a way to move on from reverted versions
> ---
>
> Key: NIFIREG-182
> URL: https://issues.apache.org/jira/browse/NIFIREG-182
> Project: NiFi Registry
> Issue Type: New Feature
>Affects Versions: 0.2.0
> Environment: NiFi 1.7.0, NiFi Registry 0.2.0
>Reporter: Fredrik Sko
>Priority: Minor
>
> Quote from {{nifi-users thread "Registry - deleting versions of flow}}".
> {quote}I'm not sure if my workflow needs to change using NiFi + NiFi
> Registry, or if this is a bug or corner-case.
>
> I do the following:
> 1) Create a new process group, make the initial flow and start version
> control (ver 1)
> 2) Modify the workflow and commit (ver 2)
> 3) Realize the most recent change was defective, and reverts (back to ver 1)
> 4) Make some new changes
>
> I'm now stuck with NiFi telling me "Local changes have been made and a newer
> version of the flow is available".
>
> There are two options as I see it:
>
> 1) The need for the ability to delete version 2, enabling me to commit my
> local changes.
> 2) The ability to commit a new version 3, which is a child of version 1.
>
> As of now (running NiFI 1.7 and Registry 0.2), my only options are to either
> revert my local changes or stop version control. My current workaround is
> unfortunately to stop version control, delete the entire flow using the
> Registry UI and start over again.
> Thoughts?
> {quote}
>
> Creating Jira ticket as suggested by [~bende] to track
> development/ideas/thoughts.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (NIFIREG-182) Add a way to move on from reverted versions
Fredrik Sko created NIFIREG-182:
---
Summary: Add a way to move on from reverted versions
Key: NIFIREG-182
URL: https://issues.apache.org/jira/browse/NIFIREG-182
Project: NiFi Registry
Issue Type: New Feature
Affects Versions: 0.2.0
Environment: NiFi 1.7.0, NiFi Registry 0.2.0
Reporter: Fredrik Sko
Quote from {{nifi-users }}thread {{Registry - deleting versions of flow}}.
{quote}I'm not sure if my workflow needs to change using NiFi + NiFi Registry,
or if this is a bug or corner-case.
I do the following:
1) Create a new process group, make the initial flow and start version control
(ver 1)
2) Modify the workflow and commit (ver 2)
3) Realize the most recent change was defective, and reverts (back to ver 1)
4) Make some new changes
I'm now stuck with NiFi telling me "Local changes have been made and a newer
version of the flow is available".
There are two options as I see it:
1) The need for the ability to delete version 2, enabling me to commit my local
changes.
2) The ability to commit a new version 3, which is a child of version 1.
As of now (running NiFI 1.7 and Registry 0.2), my only options are to either
revert my local changes or stop version control. My current workaround is
unfortunately to stop version control, delete the entire flow using the
Registry UI and start over again.
Thoughts?{quote}
Creating Jira ticket as suggested by [~bende] to track
development/ideas/thoughts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (NIFI-4535) Set the Page Title to the name of the Root Process Group
[ https://issues.apache.org/jira/browse/NIFI-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Wicks reassigned NIFI-4535: - Assignee: Peter Wicks > Set the Page Title to the name of the Root Process Group > > > Key: NIFI-4535 > URL: https://issues.apache.org/jira/browse/NIFI-4535 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > NiFi's UI has a hard coded page title of NiFi. I have many servers and it's > hard to keep track of the tabs in Chrome. > Please change the Title of the page so it matches the name of the Root > processor group. This way I can name the root group by server/instance, and > easily identify the right tab/window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-181) Make flow provider configurable in Docker
[ https://issues.apache.org/jira/browse/NIFIREG-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527790#comment-16527790 ] ASF GitHub Bot commented on NIFIREG-181: Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/129 @apiri This too. > Make flow provider configurable in Docker > - > > Key: NIFIREG-181 > URL: https://issues.apache.org/jira/browse/NIFIREG-181 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-181) Make flow provider configurable in Docker
[ https://issues.apache.org/jira/browse/NIFIREG-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527789#comment-16527789 ] ASF GitHub Bot commented on NIFIREG-181: GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi-registry/pull/129 NIFIREG-181 Updated registry docker build to make flow provider confi… …gurable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MikeThomsen/nifi-registry NIFIREG-181 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit b3b632f9547049ee4b7094077e4a19d079a6b852 Author: Mike Date: 2018-06-29T15:04:54Z NIFIREG-181 Updated registry docker build to make flow provider configurable. > Make flow provider configurable in Docker > - > > Key: NIFIREG-181 > URL: https://issues.apache.org/jira/browse/NIFIREG-181 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-registry issue #129: NIFIREG-181 Updated registry docker build to make ...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/129 @apiri This too. ---
[GitHub] nifi-registry pull request #129: NIFIREG-181 Updated registry docker build t...
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi-registry/pull/129 NIFIREG-181 Updated registry docker build to make flow provider confi⦠â¦gurable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MikeThomsen/nifi-registry NIFIREG-181 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit b3b632f9547049ee4b7094077e4a19d079a6b852 Author: Mike Date: 2018-06-29T15:04:54Z NIFIREG-181 Updated registry docker build to make flow provider configurable. ---
[jira] [Commented] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527775#comment-16527775 ] ASF GitHub Bot commented on NIFIREG-180: Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/128 @apiri updated. Let me know what you think. > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/128 @apiri updated. Let me know what you think. ---
[jira] [Created] (NIFIREG-181) Make flow provider configurable in Docker
Mike Thomsen created NIFIREG-181: Summary: Make flow provider configurable in Docker Key: NIFIREG-181 URL: https://issues.apache.org/jira/browse/NIFIREG-181 Project: NiFi Registry Issue Type: New Feature Reporter: Mike Thomsen Assignee: Mike Thomsen -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen reassigned NIFIREG-180: Assignee: Mike Thomsen > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[ https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527749#comment-16527749 ] ASF GitHub Bot commented on NIFI-5339: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2824 Merged, thanks @patricker > Better Time Tracking for ExecuteSQL Durations > - > > Key: NIFI-5339 > URL: https://issues.apache.org/jira/browse/NIFI-5339 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long > query execution and fetch took. > For multiple result set queries this is a cumulative/running total, and is > not specific to each query. > Also, there is no separation between query execution and fetch times. > Updates: > * Add a dedicated property `executesql.query.executiontime` to track the > base query execution time. > * Add a dedicated property 'executesql.query.fetchtime` to track the per > resultset fetch time. > * Update the existing `executesql.query.duration` to be the sum of the other > two times. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[ https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527748#comment-16527748 ] ASF subversion and git services commented on NIFI-5339: --- Commit a14dbc7dbe20d31e919d52e349efbabc73caf19f in nifi's branch refs/heads/master from patricker [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=a14dbc7 ] NIFI-5339 - Better Time Tracking for ExecuteSQL Durations Signed-off-by: Pierre Villard This closes #2824. > Better Time Tracking for ExecuteSQL Durations > - > > Key: NIFI-5339 > URL: https://issues.apache.org/jira/browse/NIFI-5339 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long > query execution and fetch took. > For multiple result set queries this is a cumulative/running total, and is > not specific to each query. > Also, there is no separation between query execution and fetch times. > Updates: > * Add a dedicated property `executesql.query.executiontime` to track the > base query execution time. > * Add a dedicated property 'executesql.query.fetchtime` to track the per > resultset fetch time. > * Update the existing `executesql.query.duration` to be the sum of the other > two times. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2824 ---
[jira] [Commented] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[ https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527751#comment-16527751 ] ASF GitHub Bot commented on NIFI-5339: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2824 > Better Time Tracking for ExecuteSQL Durations > - > > Key: NIFI-5339 > URL: https://issues.apache.org/jira/browse/NIFI-5339 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long > query execution and fetch took. > For multiple result set queries this is a cumulative/running total, and is > not specific to each query. > Also, there is no separation between query execution and fetch times. > Updates: > * Add a dedicated property `executesql.query.executiontime` to track the > base query execution time. > * Add a dedicated property 'executesql.query.fetchtime` to track the per > resultset fetch time. > * Update the existing `executesql.query.duration` to be the sum of the other > two times. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Durations
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2824 Merged, thanks @patricker ---
[jira] [Commented] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527742#comment-16527742 ] ASF GitHub Bot commented on NIFIREG-180: Github user apiri commented on the issue: https://github.com/apache/nifi-registry/pull/128 hey @MikeThomsen, This looks fine. I see now that the README.md is deficient in enumerating such configuration but would you mind surfacing these added properties similar to https://github.com/apache/nifi/blob/master/nifi-docker/dockerhub/README.md#configuration-information? I typically use https://www.tablesgenerator.com/markdown_tables to help gen up the formatting. > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...
Github user apiri commented on the issue: https://github.com/apache/nifi-registry/pull/128 hey @MikeThomsen, This looks fine. I see now that the README.md is deficient in enumerating such configuration but would you mind surfacing these added properties similar to https://github.com/apache/nifi/blob/master/nifi-docker/dockerhub/README.md#configuration-information? I typically use https://www.tablesgenerator.com/markdown_tables to help gen up the formatting. ---
[jira] [Commented] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[
https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527739#comment-16527739
]
ASF GitHub Bot commented on NIFI-5339:
--
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2824#discussion_r199182375
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -93,6 +93,8 @@
@WritesAttributes({
@WritesAttribute(attribute="executesql.row.count", description =
"Contains the number of rows returned in the select query"),
@WritesAttribute(attribute="executesql.query.duration", description =
"Duration of the query in milliseconds"),
--- End diff --
Updated.
> Better Time Tracking for ExecuteSQL Durations
> -
>
> Key: NIFI-5339
> URL: https://issues.apache.org/jira/browse/NIFI-5339
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.8.0
>
>
> ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long
> query execution and fetch took.
> For multiple result set queries this is a cumulative/running total, and is
> not specific to each query.
> Also, there is no separation between query execution and fetch times.
> Updates:
> * Add a dedicated property `executesql.query.executiontime` to track the
> base query execution time.
> * Add a dedicated property 'executesql.query.fetchtime` to track the per
> resultset fetch time.
> * Update the existing `executesql.query.duration` to be the sum of the other
> two times.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2824#discussion_r199182375
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -93,6 +93,8 @@
@WritesAttributes({
@WritesAttribute(attribute="executesql.row.count", description =
"Contains the number of rows returned in the select query"),
@WritesAttribute(attribute="executesql.query.duration", description =
"Duration of the query in milliseconds"),
--- End diff --
Updated.
---
[jira] [Commented] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[
https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527737#comment-16527737
]
ASF GitHub Bot commented on NIFI-5339:
--
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2824#discussion_r199181403
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -93,6 +93,8 @@
@WritesAttributes({
@WritesAttribute(attribute="executesql.row.count", description =
"Contains the number of rows returned in the select query"),
@WritesAttribute(attribute="executesql.query.duration", description =
"Duration of the query in milliseconds"),
--- End diff --
Update this description to say it's the addition of query execution and
fetch time?
> Better Time Tracking for ExecuteSQL Durations
> -
>
> Key: NIFI-5339
> URL: https://issues.apache.org/jira/browse/NIFI-5339
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.8.0
>
>
> ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long
> query execution and fetch took.
> For multiple result set queries this is a cumulative/running total, and is
> not specific to each query.
> Also, there is no separation between query execution and fetch times.
> Updates:
> * Add a dedicated property `executesql.query.executiontime` to track the
> base query execution time.
> * Add a dedicated property 'executesql.query.fetchtime` to track the per
> resultset fetch time.
> * Update the existing `executesql.query.duration` to be the sum of the other
> two times.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2824#discussion_r199181403
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -93,6 +93,8 @@
@WritesAttributes({
@WritesAttribute(attribute="executesql.row.count", description =
"Contains the number of rows returned in the select query"),
@WritesAttribute(attribute="executesql.query.duration", description =
"Duration of the query in milliseconds"),
--- End diff --
Update this description to say it's the addition of query execution and
fetch time?
---
[jira] [Commented] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[ https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527730#comment-16527730 ] ASF GitHub Bot commented on NIFI-5339: -- GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2824 NIFI-5339 - Better Time Tracking for ExecuteSQL Durations @pvillard31 I forgot to add in the `WritesAttribute` annotations for the new attributes on NIFI-5339. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5339 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2824.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2824 commit 8c3775e09ea0cacab2cc16f7a1b2baa92095d8a3 Author: patricker Date: 2018-06-26T19:27:11Z NIFI-5339 commit 1e41e1521c881fd12752734686d86820bf7defca Author: patricker Date: 2018-06-29T14:33:51Z NIFI-5339 > Better Time Tracking for ExecuteSQL Durations > - > > Key: NIFI-5339 > URL: https://issues.apache.org/jira/browse/NIFI-5339 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long > query execution and fetch took. > For multiple result set queries this is a cumulative/running total, and is > not specific to each query. > Also, there is no separation between query execution and fetch times. > Updates: > * Add a dedicated property `executesql.query.executiontime` to track the > base query execution time. > * Add a dedicated property 'executesql.query.fetchtime` to track the per > resultset fetch time. > * Update the existing `executesql.query.duration` to be the sum of the other > two times. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2824 NIFI-5339 - Better Time Tracking for ExecuteSQL Durations @pvillard31 I forgot to add in the `WritesAttribute` annotations for the new attributes on NIFI-5339. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5339 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2824.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2824 commit 8c3775e09ea0cacab2cc16f7a1b2baa92095d8a3 Author: patricker Date: 2018-06-26T19:27:11Z NIFI-5339 commit 1e41e1521c881fd12752734686d86820bf7defca Author: patricker Date: 2018-06-29T14:33:51Z NIFI-5339 ---
[jira] [Commented] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527654#comment-16527654 ] ASF GitHub Bot commented on NIFIREG-180: Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/128 @apiri Can you review? Once this is done, I'd like to move onto adding support for the GitFlow adapter. > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/128 @apiri Can you review? Once this is done, I'd like to move onto adding support for the GitFlow adapter. ---
[jira] [Commented] (NIFIREG-180) Expose DB configuration properties through docker image
[ https://issues.apache.org/jira/browse/NIFIREG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527652#comment-16527652 ] ASF GitHub Bot commented on NIFIREG-180: GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi-registry/pull/128 NIFIREG-180 Added db configuration properties to the docker image. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MikeThomsen/nifi-registry NIFIREG-180 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 commit 2e8c20809614b4e80fb4222471e0853a149e9140 Author: Mike Date: 2018-06-29T13:51:10Z NIFIREG-180 Added db configuration properties to the docker image. > Expose DB configuration properties through docker image > --- > > Key: NIFIREG-180 > URL: https://issues.apache.org/jira/browse/NIFIREG-180 > Project: NiFi Registry > Issue Type: New Feature >Reporter: Mike Thomsen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-registry pull request #128: NIFIREG-180 Added db configuration properti...
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi-registry/pull/128 NIFIREG-180 Added db configuration properties to the docker image. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MikeThomsen/nifi-registry NIFIREG-180 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 commit 2e8c20809614b4e80fb4222471e0853a149e9140 Author: Mike Date: 2018-06-29T13:51:10Z NIFIREG-180 Added db configuration properties to the docker image. ---
[jira] [Created] (NIFIREG-180) Expose DB configuration properties through docker image
Mike Thomsen created NIFIREG-180: Summary: Expose DB configuration properties through docker image Key: NIFIREG-180 URL: https://issues.apache.org/jira/browse/NIFIREG-180 Project: NiFi Registry Issue Type: New Feature Reporter: Mike Thomsen -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-543) Add Policy enforcement to C2 Updates
[ https://issues.apache.org/jira/browse/MINIFICPP-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527644#comment-16527644 ] ASF GitHub Bot commented on MINIFICPP-543: -- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/365 reviewing > Add Policy enforcement to C2 Updates > > > Key: MINIFICPP-543 > URL: https://issues.apache.org/jira/browse/MINIFICPP-543 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: marco polo >Assignee: marco polo >Priority: Major > > Enable configuration based policy enforcement for C2 updates. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp issue #365: MINIFICPP-543: Implement C2 based update policy ...
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/365 reviewing ---
[jira] [Commented] (NIFI-5334) GetMongo should pass along NiFi FlowFile Attributes
[ https://issues.apache.org/jira/browse/NIFI-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527602#comment-16527602 ] ASF GitHub Bot commented on NIFI-5334: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2815 Code LGTM. @zenfenan, could you rebase against master? > GetMongo should pass along NiFi FlowFile Attributes > --- > > Key: NIFI-5334 > URL: https://issues.apache.org/jira/browse/NIFI-5334 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.6.0 >Reporter: Ryan Hendrickson >Assignee: Sivaprasanna Sethuraman >Priority: Major > > When passing a FlowFile into the GetMongo processor to kickoff a query, the > resulting FlowFile does not contain the FlowFile attributes of the incoming > FlowFile. > This is a desirable outcome in some situations. > Adding an optional flag to pass along NiFi attributes would be useful. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2815: NIFI-5334: GetMongo keeps original attributes when it has ...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2815 Code LGTM. @zenfenan, could you rebase against master? ---
[jira] [Resolved] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[ https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-5339. -- Resolution: Fixed > Better Time Tracking for ExecuteSQL Durations > - > > Key: NIFI-5339 > URL: https://issues.apache.org/jira/browse/NIFI-5339 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long > query execution and fetch took. > For multiple result set queries this is a cumulative/running total, and is > not specific to each query. > Also, there is no separation between query execution and fetch times. > Updates: > * Add a dedicated property `executesql.query.executiontime` to track the > base query execution time. > * Add a dedicated property 'executesql.query.fetchtime` to track the per > resultset fetch time. > * Update the existing `executesql.query.duration` to be the sum of the other > two times. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[ https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527598#comment-16527598 ] ASF GitHub Bot commented on NIFI-5339: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2817 > Better Time Tracking for ExecuteSQL Durations > - > > Key: NIFI-5339 > URL: https://issues.apache.org/jira/browse/NIFI-5339 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long > query execution and fetch took. > For multiple result set queries this is a cumulative/running total, and is > not specific to each query. > Also, there is no separation between query execution and fetch times. > Updates: > * Add a dedicated property `executesql.query.executiontime` to track the > base query execution time. > * Add a dedicated property 'executesql.query.fetchtime` to track the per > resultset fetch time. > * Update the existing `executesql.query.duration` to be the sum of the other > two times. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[ https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-5339: - Fix Version/s: 1.8.0 > Better Time Tracking for ExecuteSQL Durations > - > > Key: NIFI-5339 > URL: https://issues.apache.org/jira/browse/NIFI-5339 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Fix For: 1.8.0 > > > ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long > query execution and fetch took. > For multiple result set queries this is a cumulative/running total, and is > not specific to each query. > Also, there is no separation between query execution and fetch times. > Updates: > * Add a dedicated property `executesql.query.executiontime` to track the > base query execution time. > * Add a dedicated property 'executesql.query.fetchtime` to track the per > resultset fetch time. > * Update the existing `executesql.query.duration` to be the sum of the other > two times. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2817: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2817 ---
[jira] [Updated] (NIFI-5339) Better Time Tracking for ExecuteSQL Durations
[ https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-5339: - Component/s: (was: Core Framework) Extensions > Better Time Tracking for ExecuteSQL Durations > - > > Key: NIFI-5339 > URL: https://issues.apache.org/jira/browse/NIFI-5339 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long > query execution and fetch took. > For multiple result set queries this is a cumulative/running total, and is > not specific to each query. > Also, there is no separation between query execution and fetch times. > Updates: > * Add a dedicated property `executesql.query.executiontime` to track the > base query execution time. > * Add a dedicated property 'executesql.query.fetchtime` to track the per > resultset fetch time. > * Update the existing `executesql.query.duration` to be the sum of the other > two times. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
