[jira] [Commented] (NIFI-5083) Support for Expression Language in Group ID field of Kafka Consumer Processors
[ https://issues.apache.org/jira/browse/NIFI-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535609#comment-16535609 ] Corey Fritz commented on NIFI-5083: --- I would also like to be able to use EL to set consumer group ids. I'm going to take a crack at this. > Support for Expression Language in Group ID field of Kafka Consumer Processors > -- > > Key: NIFI-5083 > URL: https://issues.apache.org/jira/browse/NIFI-5083 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0 >Reporter: Robert Bruno >Priority: Minor > Labels: kafka > > I have the use case where I have two separate NiFi clusters reading data from > the same topics but need to have unique group ids so they each get separate > copies of the data. It would be useful if the group id field supported > expression language so I could use a processor group variable to define the > group id to use. I have a large enough number of kafka consumers to make > this tedious to manually change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5388) Enable EL support for dynamic properties of Kafka processors
Corey Fritz created NIFI-5388: - Summary: Enable EL support for dynamic properties of Kafka processors Key: NIFI-5388 URL: https://issues.apache.org/jira/browse/NIFI-5388 Project: Apache NiFi Issue Type: Improvement Components: Extensions Affects Versions: 1.7.0 Reporter: Corey Fritz Fix For: 1.8.0 We have a flow committed to a NiFi Registry that includes a Kafka consumer, and ideally the processor configuration would include some dynamic consumer properties where the values would differ depending on which environment the flow is deployed to. Unfortunately, dynamic properties in the Kafka processors do not currently support EL, which would allow us to use environment variables to pass in those environment-specific values. So I'm proposing EL support be added to the dynamic properties of all Kafka processors. I am planning on tackling this ticket myself, unless someone thinks this is a bad idea for some reason. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (NIFI-4811) Use a newer version of spring-data-redis
[ https://issues.apache.org/jira/browse/NIFI-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt reopened NIFI-4811: --- Assignee: Mike Thomsen re-opened to validate whether L&N considerations have been addressed. I did a quick scan of the L&N and it looks like at least we have things to remove if not some things to add. Did you check this [~mikerthomsen] and determined no changes needed? > Use a newer version of spring-data-redis > > > Key: NIFI-4811 > URL: https://issues.apache.org/jira/browse/NIFI-4811 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Johan Oceanstorm >Assignee: Mike Thomsen >Priority: Major > Fix For: 1.8.0 > > > NiFi uses version 1.8.3 of spring-data-redis (as you can see > [here|[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-redis-bundle/pom.xml#L31].] > This version is an old version. The newer stable version is 2.0.2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2853: NIFI-5382 ConvertRecord Add Option To Drop 0 Record Files
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2853 makes sense to be consistent with https://github.com/patricker/nifi/blob/f234f0b2e654027dcaa7e72acfd0f3d035377bae/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryRecord.java#L131 ---
[jira] [Commented] (NIFI-5382) ConvertRecord 1.7.0 - Creates emtpy Flow File
[ https://issues.apache.org/jira/browse/NIFI-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535580#comment-16535580 ] ASF GitHub Bot commented on NIFI-5382: -- Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2853 makes sense to be consistent with https://github.com/patricker/nifi/blob/f234f0b2e654027dcaa7e72acfd0f3d035377bae/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryRecord.java#L131 > ConvertRecord 1.7.0 - Creates emtpy Flow File > - > > Key: NIFI-5382 > URL: https://issues.apache.org/jira/browse/NIFI-5382 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.7.0 >Reporter: Stefan Goldener >Assignee: Peter Wicks >Priority: Minor > Attachments: ConvertRecordBUG.xml > > > The Nifi ConvertRecord Processor does create an empty flow file in case the > input is a CSV with Header but no content. If no content is available the > flow file should be ignored or at least there should be an option to ignore > empty files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5355) ResizeImage Fails to read PNG type on some OS's
[ https://issues.apache.org/jira/browse/NIFI-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535576#comment-16535576 ] ASF GitHub Bot commented on NIFI-5355: -- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2854#discussion_r200800108 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java --- @@ -196,4 +187,53 @@ public void process(final InputStream rawIn, final OutputStream out) throws IOEx } } +// https://stackoverflow.com/questions/7951290/re-sizing-an-image-without-losing-quality --- End diff -- it is polite to cite the source. however, stackoverflow posts cannot be copied as their origin/licensing is not established or clear. The code to perform the function you desire needs to be original/authentic or sourced to ALv2 or category-A compliant code https://www.apache.org/legal/resolved.html#category-a We cannot accept this code as-is. > ResizeImage Fails to read PNG type on some OS's > --- > > Key: NIFI-5355 > URL: https://issues.apache.org/jira/browse/NIFI-5355 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > On some operating systems ResizeImage will fail to properly read the PNG file > type when calling getType. It will return '0' instead of '5'. > > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java#L177] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5355) ResizeImage Fails to read PNG type on some OS's
[ https://issues.apache.org/jira/browse/NIFI-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535575#comment-16535575 ] ASF GitHub Bot commented on NIFI-5355: -- Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2854 Thanks Joe, I got a new computer and some of my rules aren't setup correctly in the IDE yet. > ResizeImage Fails to read PNG type on some OS's > --- > > Key: NIFI-5355 > URL: https://issues.apache.org/jira/browse/NIFI-5355 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > On some operating systems ResizeImage will fail to properly read the PNG file > type when calling getType. It will return '0' instead of '5'. > > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java#L177] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2854: NIFI-5355 ResizeImage Fails to read PNG type on som...
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2854#discussion_r200800108 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java --- @@ -196,4 +187,53 @@ public void process(final InputStream rawIn, final OutputStream out) throws IOEx } } +// https://stackoverflow.com/questions/7951290/re-sizing-an-image-without-losing-quality --- End diff -- it is polite to cite the source. however, stackoverflow posts cannot be copied as their origin/licensing is not established or clear. The code to perform the function you desire needs to be original/authentic or sourced to ALv2 or category-A compliant code https://www.apache.org/legal/resolved.html#category-a We cannot accept this code as-is. ---
[GitHub] nifi issue #2854: NIFI-5355 ResizeImage Fails to read PNG type on some OS's
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2854 Thanks Joe, I got a new computer and some of my rules aren't setup correctly in the IDE yet. ---
[jira] [Commented] (NIFI-5355) ResizeImage Fails to read PNG type on some OS's
[ https://issues.apache.org/jira/browse/NIFI-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535574#comment-16535574 ] ASF GitHub Bot commented on NIFI-5355: -- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2854#discussion_r200800076 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java --- @@ -17,8 +17,7 @@ package org.apache.nifi.processors.image; -import java.awt.Graphics2D; -import java.awt.Image; +import java.awt.*; --- End diff -- we need to explicitly reference the items we wish to import > ResizeImage Fails to read PNG type on some OS's > --- > > Key: NIFI-5355 > URL: https://issues.apache.org/jira/browse/NIFI-5355 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > On some operating systems ResizeImage will fail to properly read the PNG file > type when calling getType. It will return '0' instead of '5'. > > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java#L177] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2854: NIFI-5355 ResizeImage Fails to read PNG type on som...
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2854#discussion_r200800076 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java --- @@ -17,8 +17,7 @@ package org.apache.nifi.processors.image; -import java.awt.Graphics2D; -import java.awt.Image; +import java.awt.*; --- End diff -- we need to explicitly reference the items we wish to import ---
[jira] [Updated] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joseph Witt updated NIFI-5383:
--
Fix Version/s: (was: 1.8.0)
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Mike Thomsen
>Priority: Trivial
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535573#comment-16535573
]
ASF GitHub Bot commented on NIFI-5383:
--
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2848
I see a couple errant uses in nifi-hbase pom(s) but otherwise it is all ok
usage.
In your evaluation of things looking ok it would have been a typical build
I suspect. But we need consistency for maintainability purposes of course and
further we have it this way because this way works not just during typical
build processes developers do but also it worked well in maven during the
apache release process. We can change it but doing so requires a far more
thorough analysis of not just the typical build process but being able to do a
full release cycle.
It is not necessary, however, to use '${project.version}' since the maven
release plugin takes care of it so nicely. This JIRA and PR should be closed
in my opinion.
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Mike Thomsen
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2848: NIFI-5383 Replaced hard-coded version with Maven property ...
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2848
I see a couple errant uses in nifi-hbase pom(s) but otherwise it is all ok
usage.
In your evaluation of things looking ok it would have been a typical build
I suspect. But we need consistency for maintainability purposes of course and
further we have it this way because this way works not just during typical
build processes developers do but also it worked well in maven during the
apache release process. We can change it but doing so requires a far more
thorough analysis of not just the typical build process but being able to do a
full release cycle.
It is not necessary, however, to use '${project.version}' since the maven
release plugin takes care of it so nicely. This JIRA and PR should be closed
in my opinion.
---
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[ https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535569#comment-16535569 ] ASF GitHub Bot commented on NIFI-5318: -- Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2843 I dont fully understand what this aims to achieve so please understand that in my comments. However, changes to the nifi-toolkit-tls module dont seem to apply to wanting a test harness style capability for flows. Adding a series of 'test' packages to main/source code seems like an anti-pattern.We really need to reset on this effort and make sure it is clear what we're looking to achieve before this goes further as-is. > Implement NiFi test harness > --- > > Key: NIFI-5318 > URL: https://issues.apache.org/jira/browse/NIFI-5318 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Peter Horvath >Priority: Major > > Currently, it is not really possible to automatically test the behaviour of a > specific NiFi flow and make unit test type asserts if it works as expected. > For example, if the expected behaviour of a NiFi flow is that a file placed > to a specific directory will trigger some operation after which some output > file will appear at another directory, once currently can only do one thing: > test the NiFi flow manually. > Manual testing is especially hard to manage if a NiFi flow is being actively > developed: any change to a complex, existing NiFi flow might require a lot of > manual testing just to ensure there are no regressions introduced. > Some kind of Java API that allows managing a NiFi instance and manipulating > flow deployments like for example, [Codehaus > Cargo|]https://codehaus-cargo.github.io/] would be of great help. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2843: NIFI-5318 Implement NiFi test harness: initial commit of n...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2843 I dont fully understand what this aims to achieve so please understand that in my comments. However, changes to the nifi-toolkit-tls module dont seem to apply to wanting a test harness style capability for flows. Adding a series of 'test' packages to main/source code seems like an anti-pattern.We really need to reset on this effort and make sure it is clear what we're looking to achieve before this goes further as-is. ---
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535568#comment-16535568
]
ASF GitHub Bot commented on NIFI-5318:
--
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200799818
--- Diff:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/test/util/FileUtils.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+
+package org.apache.nifi.test.util;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.*;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.Arrays;
+
+public final class FileUtils {
+
+
+private static final String MAC_DS_STORE_NAME = ".DS_Store";
--- End diff --
the osx specific nature of this is concerning
> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL: https://issues.apache.org/jira/browse/NIFI-5318
> Project: Apache NiFi
> Issue Type: New Feature
>Reporter: Peter Horvath
>Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a
> specific NiFi flow and make unit test type asserts if it works as expected.
> For example, if the expected behaviour of a NiFi flow is that a file placed
> to a specific directory will trigger some operation after which some output
> file will appear at another directory, once currently can only do one thing:
> test the NiFi flow manually.
> Manual testing is especially hard to manage if a NiFi flow is being actively
> developed: any change to a complex, existing NiFi flow might require a lot of
> manual testing just to ensure there are no regressions introduced.
> Some kind of Java API that allows managing a NiFi instance and manipulating
> flow deployments like for example, [Codehaus
> Cargo|]https://codehaus-cargo.github.io/] would be of great help.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200799818
--- Diff:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/test/util/FileUtils.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+
+package org.apache.nifi.test.util;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.*;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.Arrays;
+
+public final class FileUtils {
+
+
+private static final String MAC_DS_STORE_NAME = ".DS_Store";
--- End diff --
the osx specific nature of this is concerning
---
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535567#comment-16535567
]
ASF GitHub Bot commented on NIFI-5318:
--
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200799793
--- Diff:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/test/SimpleNiFiFlowDefinitionEditor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+
+package org.apache.nifi.test;
+
+import org.apache.nifi.test.api.FlowFileEditorCallback;
+import org.w3c.dom.Document;
+import org.w3c.dom.Node;
+
+import javax.xml.xpath.XPath;
+import javax.xml.xpath.XPathConstants;
+import javax.xml.xpath.XPathFactory;
+import java.util.LinkedList;
+
+
+/**
+ *
+ * A facility to describe simple, common changes to a NiFi flow before it
is installed to the test
+ * NiFi instance. Intended to be used by
+ * {@link
TestNiFiInstance.Builder#modifyFlowXmlBeforeInstalling(FlowFileEditorCallback)}
+ *
+ *
+ *
+ * The desired edits can be configured via the {@link Builder} object
returned by the {@link #builder()}
+ * method. Once fully configured, the {@link Builder#build()} emits a
{@code FlowFileEditorCallback}
+ * object that can be passed to
+ * {@link
TestNiFiInstance.Builder#modifyFlowXmlBeforeInstalling(FlowFileEditorCallback)}.
+ *
+ *
+ *
+ * CAUTION: THIS IS AN EXPERIMENTAL API: EXPECT CHANGES!
+ * Efforts will be made to retain backwards API compatibility, but
+ * no guarantee is given.
+ *
+ *
+ * @see
TestNiFiInstance.Builder#modifyFlowXmlBeforeInstalling(FlowFileEditorCallback)
+ *
+ * @author Peter G. Horvath
--- End diff --
please remove all author tags from all javadocs
> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL: https://issues.apache.org/jira/browse/NIFI-5318
> Project: Apache NiFi
> Issue Type: New Feature
>Reporter: Peter Horvath
>Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a
> specific NiFi flow and make unit test type asserts if it works as expected.
> For example, if the expected behaviour of a NiFi flow is that a file placed
> to a specific directory will trigger some operation after which some output
> file will appear at another directory, once currently can only do one thing:
> test the NiFi flow manually.
> Manual testing is especially hard to manage if a NiFi flow is being actively
> developed: any change to a complex, existing NiFi flow might require a lot of
> manual testing just to ensure there are no regressions introduced.
> Some kind of Java API that allows managing a NiFi instance and manipulating
> flow deployments like for example, [Codehaus
> Cargo|]https://codehaus-cargo.github.io/] would be of great help.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200799793
--- Diff:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/test/SimpleNiFiFlowDefinitionEditor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+
+package org.apache.nifi.test;
+
+import org.apache.nifi.test.api.FlowFileEditorCallback;
+import org.w3c.dom.Document;
+import org.w3c.dom.Node;
+
+import javax.xml.xpath.XPath;
+import javax.xml.xpath.XPathConstants;
+import javax.xml.xpath.XPathFactory;
+import java.util.LinkedList;
+
+
+/**
+ *
+ * A facility to describe simple, common changes to a NiFi flow before it
is installed to the test
+ * NiFi instance. Intended to be used by
+ * {@link
TestNiFiInstance.Builder#modifyFlowXmlBeforeInstalling(FlowFileEditorCallback)}
+ *
+ *
+ *
+ * The desired edits can be configured via the {@link Builder} object
returned by the {@link #builder()}
+ * method. Once fully configured, the {@link Builder#build()} emits a
{@code FlowFileEditorCallback}
+ * object that can be passed to
+ * {@link
TestNiFiInstance.Builder#modifyFlowXmlBeforeInstalling(FlowFileEditorCallback)}.
+ *
+ *
+ *
+ * CAUTION: THIS IS AN EXPERIMENTAL API: EXPECT CHANGES!
+ * Efforts will be made to retain backwards API compatibility, but
+ * no guarantee is given.
+ *
+ *
+ * @see
TestNiFiInstance.Builder#modifyFlowXmlBeforeInstalling(FlowFileEditorCallback)
+ *
+ * @author Peter G. Horvath
--- End diff --
please remove all author tags from all javadocs
---
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535565#comment-16535565
]
ASF GitHub Bot commented on NIFI-5383:
--
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
@joewitt IntelliJ reported 4 hits on `${projection.version}`. Is
that worth a new Jira ticket to harmonize?
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Mike Thomsen
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535564#comment-16535564
]
ASF GitHub Bot commented on NIFI-5318:
--
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200799698
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/DocGenerator.java
---
@@ -57,6 +57,9 @@
* @param extensionMapping extension mapping
*/
public static void generate(final NiFiProperties properties, final
ExtensionMapping extensionMapping) {
+
--- End diff --
these extra lines should be removed
> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL: https://issues.apache.org/jira/browse/NIFI-5318
> Project: Apache NiFi
> Issue Type: New Feature
>Reporter: Peter Horvath
>Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a
> specific NiFi flow and make unit test type asserts if it works as expected.
> For example, if the expected behaviour of a NiFi flow is that a file placed
> to a specific directory will trigger some operation after which some output
> file will appear at another directory, once currently can only do one thing:
> test the NiFi flow manually.
> Manual testing is especially hard to manage if a NiFi flow is being actively
> developed: any change to a complex, existing NiFi flow might require a lot of
> manual testing just to ensure there are no regressions introduced.
> Some kind of Java API that allows managing a NiFi instance and manipulating
> flow deployments like for example, [Codehaus
> Cargo|]https://codehaus-cargo.github.io/] would be of great help.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2848: NIFI-5383 Replaced hard-coded version with Maven property ...
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
@joewitt IntelliJ reported 4 hits on `${projection.version}`. Is
that worth a new Jira ticket to harmonize?
---
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535563#comment-16535563
]
ASF GitHub Bot commented on NIFI-5318:
--
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200799695
--- Diff: nifi-docs/src/main/asciidoc/developer-guide.adoc ---
@@ -2296,6 +2296,32 @@ threads that should be used to run the Processor can
be set via the `setThreadCount(int)` method.
+=== Experimental NiFi Flow test harness
+
+NiFi now has an experimental feature for full end-to-end testing of flows.
This allows us
+to take a NiFi flow, install it to a test NiFi instance, run it and make
Java unit test
+like asserts regarding its behaviour.
+
+The class `org.apache.nifi.test.TestNiFiInstance` is a thin wrapper that
allows us
+to manipulate a NiFi installation and deploy a flow with some adjustments
+to its configuration, including changing processor properties and
replacing processor
+classes with mocks.
+
+In order to add the necessary classes to your project,
+you can use the Maven dependency:
+
+[source]
+
+
+ org.apache.nifi
+ nifi-test
+ ${nifi version}
+
+
+
+For further documentation, please consult the JavaDoc of
+`org.apache.nifi.test.TestNiFiInstance`. For samples, please take a look at
+link:https://github.com/apache/nifi/tree/master/nifi-test/src/test/java/org/apache/test/samples[samples
on GitHub^].
--- End diff --
what is this link really meant to be?
> Implement NiFi test harness
> ---
>
> Key: NIFI-5318
> URL: https://issues.apache.org/jira/browse/NIFI-5318
> Project: Apache NiFi
> Issue Type: New Feature
>Reporter: Peter Horvath
>Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a
> specific NiFi flow and make unit test type asserts if it works as expected.
> For example, if the expected behaviour of a NiFi flow is that a file placed
> to a specific directory will trigger some operation after which some output
> file will appear at another directory, once currently can only do one thing:
> test the NiFi flow manually.
> Manual testing is especially hard to manage if a NiFi flow is being actively
> developed: any change to a complex, existing NiFi flow might require a lot of
> manual testing just to ensure there are no regressions introduced.
> Some kind of Java API that allows managing a NiFi instance and manipulating
> flow deployments like for example, [Codehaus
> Cargo|]https://codehaus-cargo.github.io/] would be of great help.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535560#comment-16535560
]
ASF subversion and git services commented on NIFI-5383:
---
Commit 40c4b2c771aaf61292294f59a7bdb9f6d262cb7a in nifi's branch
refs/heads/master from [~mike.thomsen]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=40c4b2c ]
Revert "NIFI-5383 Replaced hard-coded version with Maven property in
nifi-redis-bundle"
This reverts commit a8a0b0d075ccf1d6a71f88a973e6878cec4889e4.
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Mike Thomsen
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200799695
--- Diff: nifi-docs/src/main/asciidoc/developer-guide.adoc ---
@@ -2296,6 +2296,32 @@ threads that should be used to run the Processor can
be set via the `setThreadCount(int)` method.
+=== Experimental NiFi Flow test harness
+
+NiFi now has an experimental feature for full end-to-end testing of flows.
This allows us
+to take a NiFi flow, install it to a test NiFi instance, run it and make
Java unit test
+like asserts regarding its behaviour.
+
+The class `org.apache.nifi.test.TestNiFiInstance` is a thin wrapper that
allows us
+to manipulate a NiFi installation and deploy a flow with some adjustments
+to its configuration, including changing processor properties and
replacing processor
+classes with mocks.
+
+In order to add the necessary classes to your project,
+you can use the Maven dependency:
+
+[source]
+
+
+ org.apache.nifi
+ nifi-test
+ ${nifi version}
+
+
+
+For further documentation, please consult the JavaDoc of
+`org.apache.nifi.test.TestNiFiInstance`. For samples, please take a look at
+link:https://github.com/apache/nifi/tree/master/nifi-test/src/test/java/org/apache/test/samples[samples
on GitHub^].
--- End diff --
what is this link really meant to be?
---
[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200799698
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/DocGenerator.java
---
@@ -57,6 +57,9 @@
* @param extensionMapping extension mapping
*/
public static void generate(final NiFiProperties properties, final
ExtensionMapping extensionMapping) {
+
--- End diff --
these extra lines should be removed
---
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535561#comment-16535561
]
ASF GitHub Bot commented on NIFI-5383:
--
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
Done.
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Mike Thomsen
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2848: NIFI-5383 Replaced hard-coded version with Maven property ...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2848 Done. ---
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535559#comment-16535559
]
ASF GitHub Bot commented on NIFI-5383:
--
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
Do we have anything you can think of that isn't set to the current version?
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Mike Thomsen
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2848: NIFI-5383 Replaced hard-coded version with Maven property ...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2848 Do we have anything you can think of that isn't set to the current version? ---
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535558#comment-16535558
]
ASF GitHub Bot commented on NIFI-5383:
--
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
Ok. Everything checked out as far as I saw when I tried it, but I'll revert
it.
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Mike Thomsen
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2848: NIFI-5383 Replaced hard-coded version with Maven property ...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2848 Ok. Everything checked out as far as I saw when I tried it, but I'll revert it. ---
[jira] [Reopened] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joseph Witt reopened NIFI-5383:
---
Assignee: Mike Thomsen
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Mike Thomsen
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1653#comment-1653
]
Joseph Witt commented on NIFI-5383:
---
[~mikerthomsen] please revert this as requested above.
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2848: NIFI-5383 Replaced hard-coded version with Maven property ...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2848 this is not consistent with the rest of all modules in the project. the versions get changed correctly and automatically during the build release process. please revert this. if we want to change the approach then lets do it for everything and by validating the actual release process works. ---
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535554#comment-16535554
]
ASF GitHub Bot commented on NIFI-5383:
--
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2848
this is not consistent with the rest of all modules in the project. the
versions get changed correctly and automatically during the build release
process. please revert this. if we want to change the approach then lets do
it for everything and by validating the actual release process works.
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[ https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535540#comment-16535540 ] ASF GitHub Bot commented on NIFI-5318: -- Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2843#discussion_r200798916 --- Diff: nifi-test/pom.xml --- @@ -0,0 +1,145 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + +nifi +org.apache.nifi +1.8.0-SNAPSHOT + + +4.0.0 + +com.thinkbiganalytics +nifi-test --- End diff -- +1 > Implement NiFi test harness > --- > > Key: NIFI-5318 > URL: https://issues.apache.org/jira/browse/NIFI-5318 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Peter Horvath >Priority: Major > > Currently, it is not really possible to automatically test the behaviour of a > specific NiFi flow and make unit test type asserts if it works as expected. > For example, if the expected behaviour of a NiFi flow is that a file placed > to a specific directory will trigger some operation after which some output > file will appear at another directory, once currently can only do one thing: > test the NiFi flow manually. > Manual testing is especially hard to manage if a NiFi flow is being actively > developed: any change to a complex, existing NiFi flow might require a lot of > manual testing just to ensure there are no regressions introduced. > Some kind of Java API that allows managing a NiFi instance and manipulating > flow deployments like for example, [Codehaus > Cargo|]https://codehaus-cargo.github.io/] would be of great help. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2843#discussion_r200798916 --- Diff: nifi-test/pom.xml --- @@ -0,0 +1,145 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + +nifi +org.apache.nifi +1.8.0-SNAPSHOT + + +4.0.0 + +com.thinkbiganalytics +nifi-test --- End diff -- +1 ---
[jira] [Commented] (NIFI-5318) Implement NiFi test harness
[ https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535539#comment-16535539 ] ASF GitHub Bot commented on NIFI-5318: -- Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2843#discussion_r200798895 --- Diff: nifi-test/pom.xml --- @@ -0,0 +1,145 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + +nifi +org.apache.nifi +1.8.0-SNAPSHOT + + +4.0.0 + --- End diff -- Agreed. AFAIK, things like this need to be refactored, where possible, to `org.apache.nifi.*` > Implement NiFi test harness > --- > > Key: NIFI-5318 > URL: https://issues.apache.org/jira/browse/NIFI-5318 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Peter Horvath >Priority: Major > > Currently, it is not really possible to automatically test the behaviour of a > specific NiFi flow and make unit test type asserts if it works as expected. > For example, if the expected behaviour of a NiFi flow is that a file placed > to a specific directory will trigger some operation after which some output > file will appear at another directory, once currently can only do one thing: > test the NiFi flow manually. > Manual testing is especially hard to manage if a NiFi flow is being actively > developed: any change to a complex, existing NiFi flow might require a lot of > manual testing just to ensure there are no regressions introduced. > Some kind of Java API that allows managing a NiFi instance and manipulating > flow deployments like for example, [Codehaus > Cargo|]https://codehaus-cargo.github.io/] would be of great help. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2843#discussion_r200798895 --- Diff: nifi-test/pom.xml --- @@ -0,0 +1,145 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + +nifi +org.apache.nifi +1.8.0-SNAPSHOT + + +4.0.0 + --- End diff -- Agreed. AFAIK, things like this need to be refactored, where possible, to `org.apache.nifi.*` ---
[GitHub] nifi pull request #2848: NIFI-5383 Replaced hard-coded version with Maven pr...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2848 ---
[jira] [Resolved] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen resolved NIFI-5383.
Resolution: Fixed
Fix Version/s: 1.8.0
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535530#comment-16535530
]
ASF subversion and git services commented on NIFI-5383:
---
Commit a8a0b0d075ccf1d6a71f88a973e6878cec4889e4 in nifi's branch
refs/heads/master from [~Jan Hentschel]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=a8a0b0d ]
NIFI-5383 Replaced hard-coded version with Maven property in nifi-redis-bundle
This closes #2848
Signed-off-by: Mike Thomsen
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535531#comment-16535531
]
ASF GitHub Bot commented on NIFI-5383:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2848
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5387) Remove redundant groupId in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535527#comment-16535527
]
ASF GitHub Bot commented on NIFI-5387:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2852
> Remove redundant groupId in nifi-redis-bundle
> -
>
> Key: NIFI-5387
> URL: https://issues.apache.org/jira/browse/NIFI-5387
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> The POM of the {{nifi-redis-bundle}} bundle declares the {{groupId}} from the
> parent module again. The {{groupId}} can be safely removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5387) Remove redundant groupId in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535526#comment-16535526
]
ASF subversion and git services commented on NIFI-5387:
---
Commit 87f3a99adfd202965643fd524ec0729d38e52f37 in nifi's branch
refs/heads/master from [~Jan Hentschel]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=87f3a99 ]
NIFI-5387 Removed redundant groupId from nifi-redis-bundle
This closes #2852
Signed-off-by: Mike Thomsen
> Remove redundant groupId in nifi-redis-bundle
> -
>
> Key: NIFI-5387
> URL: https://issues.apache.org/jira/browse/NIFI-5387
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> The POM of the {{nifi-redis-bundle}} bundle declares the {{groupId}} from the
> parent module again. The {{groupId}} can be safely removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2852: NIFI-5387 Removed redundant groupId from nifi-redis...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2852 ---
[jira] [Resolved] (NIFI-5387) Remove redundant groupId in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen resolved NIFI-5387.
Resolution: Fixed
Fix Version/s: 1.8.0
> Remove redundant groupId in nifi-redis-bundle
> -
>
> Key: NIFI-5387
> URL: https://issues.apache.org/jira/browse/NIFI-5387
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> The POM of the {{nifi-redis-bundle}} bundle declares the {{groupId}} from the
> parent module again. The {{groupId}} can be safely removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5386) Remove redundant dependencies from nifi-redis-extensions
[
https://issues.apache.org/jira/browse/NIFI-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535524#comment-16535524
]
ASF subversion and git services commented on NIFI-5386:
---
Commit 8fd8a247d9d504f28f710676b13d795763073bed in nifi's branch
refs/heads/master from [~Jan Hentschel]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8fd8a24 ]
NIFI-5386 Removed redundant dependencies from nifi-redis-extensions
This closes #2851
Signed-off-by: Mike Thomsen
> Remove redundant dependencies from nifi-redis-extensions
>
>
> Key: NIFI-5386
> URL: https://issues.apache.org/jira/browse/NIFI-5386
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> The module {{nifi-redis-extensions}} defines the dependencies
> {{slf4j-simple}} and {{junit}}, which are already defined in the root POM and
> can be removed safely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2851: NIFI-5386 Removed redundant dependencies from nifi-...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2851 ---
[jira] [Commented] (NIFI-5386) Remove redundant dependencies from nifi-redis-extensions
[
https://issues.apache.org/jira/browse/NIFI-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535525#comment-16535525
]
ASF GitHub Bot commented on NIFI-5386:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2851
> Remove redundant dependencies from nifi-redis-extensions
>
>
> Key: NIFI-5386
> URL: https://issues.apache.org/jira/browse/NIFI-5386
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> The module {{nifi-redis-extensions}} defines the dependencies
> {{slf4j-simple}} and {{junit}}, which are already defined in the root POM and
> can be removed safely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (NIFI-5386) Remove redundant dependencies from nifi-redis-extensions
[
https://issues.apache.org/jira/browse/NIFI-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen resolved NIFI-5386.
Resolution: Fixed
Fix Version/s: 1.8.0
> Remove redundant dependencies from nifi-redis-extensions
>
>
> Key: NIFI-5386
> URL: https://issues.apache.org/jira/browse/NIFI-5386
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
> Fix For: 1.8.0
>
>
> The module {{nifi-redis-extensions}} defines the dependencies
> {{slf4j-simple}} and {{junit}}, which are already defined in the root POM and
> can be removed safely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4811) Use a newer version of spring-data-redis
[ https://issues.apache.org/jira/browse/NIFI-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535523#comment-16535523 ] ASF GitHub Bot commented on NIFI-4811: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2845 > Use a newer version of spring-data-redis > > > Key: NIFI-4811 > URL: https://issues.apache.org/jira/browse/NIFI-4811 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Johan Oceanstorm >Priority: Major > > NiFi uses version 1.8.3 of spring-data-redis (as you can see > [here|[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-redis-bundle/pom.xml#L31].] > This version is an old version. The newer stable version is 2.0.2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (NIFI-4811) Use a newer version of spring-data-redis
[ https://issues.apache.org/jira/browse/NIFI-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen resolved NIFI-4811. Resolution: Fixed Fix Version/s: 1.8.0 > Use a newer version of spring-data-redis > > > Key: NIFI-4811 > URL: https://issues.apache.org/jira/browse/NIFI-4811 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Johan Oceanstorm >Priority: Major > Fix For: 1.8.0 > > > NiFi uses version 1.8.3 of spring-data-redis (as you can see > [here|[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-redis-bundle/pom.xml#L31].] > This version is an old version. The newer stable version is 2.0.2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4811) Use a newer version of spring-data-redis
[ https://issues.apache.org/jira/browse/NIFI-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535521#comment-16535521 ] ASF subversion and git services commented on NIFI-4811: --- Commit d31a919553c533a7385a5274d15c72a2a82a9c21 in nifi's branch refs/heads/master from [~Jan Hentschel] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d31a919 ] NIFI-4811 Updated spring-data-redis to the latest version This closes #2845 Signed-off-by: Mike Thomsen > Use a newer version of spring-data-redis > > > Key: NIFI-4811 > URL: https://issues.apache.org/jira/browse/NIFI-4811 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Johan Oceanstorm >Priority: Major > > NiFi uses version 1.8.3 of spring-data-redis (as you can see > [here|[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-redis-bundle/pom.xml#L31].] > This version is an old version. The newer stable version is 2.0.2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2845: NIFI-4811 Updated spring-data-redis to the latest v...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2845 ---
[jira] [Commented] (NIFI-5292) Rename existing ElasticSearch client service impl to specify it is for 5.X
[ https://issues.apache.org/jira/browse/NIFI-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535520#comment-16535520 ] ASF GitHub Bot commented on NIFI-5292: -- Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @zenfenan can you review? It's mostly copy pasta from the ES v5 client. > Rename existing ElasticSearch client service impl to specify it is for 5.X > -- > > Key: NIFI-5292 > URL: https://issues.apache.org/jira/browse/NIFI-5292 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.0 >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > Labels: Migration > > The current version of the impl is 5.X, but has a generic name that will be > confusing down the road. > Add an ES 6.X client service as well. > > Migration note: Anyone using the existing client service component will have > to create a new one that corresponds to the version of ElasticSearch they are > using. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @zenfenan can you review? It's mostly copy pasta from the ES v5 client. ---
[jira] [Commented] (NIFI-5355) ResizeImage Fails to read PNG type on some OS's
[ https://issues.apache.org/jira/browse/NIFI-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535362#comment-16535362 ] ASF GitHub Bot commented on NIFI-5355: -- Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2854 @JPercivall (in case you want to take a look) > ResizeImage Fails to read PNG type on some OS's > --- > > Key: NIFI-5355 > URL: https://issues.apache.org/jira/browse/NIFI-5355 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > On some operating systems ResizeImage will fail to properly read the PNG file > type when calling getType. It will return '0' instead of '5'. > > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java#L177] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2854: NIFI-5355 ResizeImage Fails to read PNG type on some OS's
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2854 @JPercivall (in case you want to take a look) ---
[jira] [Commented] (NIFI-5355) ResizeImage Fails to read PNG type on some OS's
[ https://issues.apache.org/jira/browse/NIFI-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535359#comment-16535359 ] ASF GitHub Bot commented on NIFI-5355: -- GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2854 NIFI-5355 ResizeImage Fails to read PNG type on some OS's Updated ResizeImage to better support PNG file format on all platforms. Updated resize logic to provide a higher performance/faster experience. Unfortunately `Hint` values are not exactly the same. I mapped them as best as possible to avoid any breaking changes. Added in Unit tests for these changes, and also for if the requested resize size is larger than the original image. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5355 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2854.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2854 commit 7ce35f4b3e85811b2ea883b7cdfbe11c058518a8 Author: patricker Date: 2018-07-06T21:09:04Z NIFI-5355 ResizeImage Fails to read PNG type on some OS's > ResizeImage Fails to read PNG type on some OS's > --- > > Key: NIFI-5355 > URL: https://issues.apache.org/jira/browse/NIFI-5355 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > On some operating systems ResizeImage will fail to properly read the PNG file > type when calling getType. It will return '0' instead of '5'. > > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java#L177] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2854: NIFI-5355 ResizeImage Fails to read PNG type on som...
GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2854 NIFI-5355 ResizeImage Fails to read PNG type on some OS's Updated ResizeImage to better support PNG file format on all platforms. Updated resize logic to provide a higher performance/faster experience. Unfortunately `Hint` values are not exactly the same. I mapped them as best as possible to avoid any breaking changes. Added in Unit tests for these changes, and also for if the requested resize size is larger than the original image. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5355 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2854.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2854 commit 7ce35f4b3e85811b2ea883b7cdfbe11c058518a8 Author: patricker Date: 2018-07-06T21:09:04Z NIFI-5355 ResizeImage Fails to read PNG type on some OS's ---
[jira] [Assigned] (NIFI-5355) ResizeImage Fails to read PNG type on some OS's
[ https://issues.apache.org/jira/browse/NIFI-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Wicks reassigned NIFI-5355: - Assignee: Peter Wicks > ResizeImage Fails to read PNG type on some OS's > --- > > Key: NIFI-5355 > URL: https://issues.apache.org/jira/browse/NIFI-5355 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > On some operating systems ResizeImage will fail to properly read the PNG file > type when calling getType. It will return '0' instead of '5'. > > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java#L177] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5382) ConvertRecord 1.7.0 - Creates emtpy Flow File
[ https://issues.apache.org/jira/browse/NIFI-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535307#comment-16535307 ] ASF GitHub Bot commented on NIFI-5382: -- GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2853 NIFI-5382 ConvertRecord Add Option To Drop 0 Record Files ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5382 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2853 commit f234f0b2e654027dcaa7e72acfd0f3d035377bae Author: patricker Date: 2018-07-06T20:16:11Z NIFI-5382 ConvertRecord Add Option To Drop 0 Record Files > ConvertRecord 1.7.0 - Creates emtpy Flow File > - > > Key: NIFI-5382 > URL: https://issues.apache.org/jira/browse/NIFI-5382 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.7.0 >Reporter: Stefan Goldener >Assignee: Peter Wicks >Priority: Minor > Attachments: ConvertRecordBUG.xml > > > The Nifi ConvertRecord Processor does create an empty flow file in case the > input is a CSV with Header but no content. If no content is available the > flow file should be ignored or at least there should be an option to ignore > empty files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2853: NIFI-5382 ConvertRecord Add Option To Drop 0 Record...
GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2853 NIFI-5382 ConvertRecord Add Option To Drop 0 Record Files ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5382 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2853 commit f234f0b2e654027dcaa7e72acfd0f3d035377bae Author: patricker Date: 2018-07-06T20:16:11Z NIFI-5382 ConvertRecord Add Option To Drop 0 Record Files ---
[jira] [Assigned] (NIFI-5382) ConvertRecord 1.7.0 - Creates emtpy Flow File
[ https://issues.apache.org/jira/browse/NIFI-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Wicks reassigned NIFI-5382: - Assignee: Peter Wicks > ConvertRecord 1.7.0 - Creates emtpy Flow File > - > > Key: NIFI-5382 > URL: https://issues.apache.org/jira/browse/NIFI-5382 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.7.0 >Reporter: Stefan Goldener >Assignee: Peter Wicks >Priority: Minor > Attachments: ConvertRecordBUG.xml > > > The Nifi ConvertRecord Processor does create an empty flow file in case the > input is a CSV with Header but no content. If no content is available the > flow file should be ignored or at least there should be an option to ignore > empty files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5382) ConvertRecord 1.7.0 - Creates emtpy Flow File
[ https://issues.apache.org/jira/browse/NIFI-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Wicks updated NIFI-5382: -- Priority: Minor (was: Major) > ConvertRecord 1.7.0 - Creates emtpy Flow File > - > > Key: NIFI-5382 > URL: https://issues.apache.org/jira/browse/NIFI-5382 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.7.0 >Reporter: Stefan Goldener >Priority: Minor > Attachments: ConvertRecordBUG.xml > > > The Nifi ConvertRecord Processor does create an empty flow file in case the > input is a CSV with Header but no content. If no content is available the > flow file should be ignored or at least there should be an option to ignore > empty files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5382) ConvertRecord 1.7.0 - Creates emtpy Flow File
[ https://issues.apache.org/jira/browse/NIFI-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Wicks updated NIFI-5382: -- Issue Type: New Feature (was: Bug) > ConvertRecord 1.7.0 - Creates emtpy Flow File > - > > Key: NIFI-5382 > URL: https://issues.apache.org/jira/browse/NIFI-5382 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.7.0 >Reporter: Stefan Goldener >Priority: Minor > Attachments: ConvertRecordBUG.xml > > > The Nifi ConvertRecord Processor does create an empty flow file in case the > input is a CSV with Header but no content. If no content is available the > flow file should be ignored or at least there should be an option to ignore > empty files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5387) Remove redundant groupId in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535239#comment-16535239
]
ASF GitHub Bot commented on NIFI-5387:
--
GitHub user HorizonNet opened a pull request:
https://github.com/apache/nifi/pull/2852
NIFI-5387 Removed redundant groupId from nifi-redis-bundle
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder? Fails at
`nifi-standard-processors`.
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ultratendency/nifi NIFI-5387
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2852
commit f015db8038869799522b6613debfda546adae1b6
Author: Jan Hentschel
Date: 2018-07-06T19:06:19Z
NIFI-5387 Removed redundant groupId from nifi-redis-bundle
> Remove redundant groupId in nifi-redis-bundle
> -
>
> Key: NIFI-5387
> URL: https://issues.apache.org/jira/browse/NIFI-5387
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
>
> The POM of the {{nifi-redis-bundle}} bundle declares the {{groupId}} from the
> parent module again. The {{groupId}} can be safely removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2852: NIFI-5387 Removed redundant groupId from nifi-redis...
GitHub user HorizonNet opened a pull request: https://github.com/apache/nifi/pull/2852 NIFI-5387 Removed redundant groupId from nifi-redis-bundle Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? Fails at `nifi-standard-processors`. - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ultratendency/nifi NIFI-5387 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2852.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2852 commit f015db8038869799522b6613debfda546adae1b6 Author: Jan Hentschel Date: 2018-07-06T19:06:19Z NIFI-5387 Removed redundant groupId from nifi-redis-bundle ---
[jira] [Created] (NIFI-5387) Remove redundant groupId in nifi-redis-bundle
Jan Hentschel created NIFI-5387:
---
Summary: Remove redundant groupId in nifi-redis-bundle
Key: NIFI-5387
URL: https://issues.apache.org/jira/browse/NIFI-5387
Project: Apache NiFi
Issue Type: Improvement
Reporter: Jan Hentschel
The POM of the {{nifi-redis-bundle}} bundle declares the {{groupId}} from the
parent module again. The {{groupId}} can be safely removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5386) Remove redundant dependencies from nifi-redis-extensions
[
https://issues.apache.org/jira/browse/NIFI-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535212#comment-16535212
]
ASF GitHub Bot commented on NIFI-5386:
--
GitHub user HorizonNet opened a pull request:
https://github.com/apache/nifi/pull/2851
NIFI-5386 Removed redundant dependencies from nifi-redis-extensions
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder? Fails at
`nifi-standard-processors`.
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ultratendency/nifi NIFI-5386
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2851.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2851
commit 4097f45e4132d7d43705375b464c366f806933f1
Author: Jan Hentschel
Date: 2018-07-06T18:35:11Z
NIFI-5386 Removed redundant dependencies from nifi-redis-extensions
> Remove redundant dependencies from nifi-redis-extensions
>
>
> Key: NIFI-5386
> URL: https://issues.apache.org/jira/browse/NIFI-5386
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
>
> The module {{nifi-redis-extensions}} defines the dependencies
> {{slf4j-simple}} and {{junit}}, which are already defined in the root POM and
> can be removed safely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2851: NIFI-5386 Removed redundant dependencies from nifi-...
GitHub user HorizonNet opened a pull request: https://github.com/apache/nifi/pull/2851 NIFI-5386 Removed redundant dependencies from nifi-redis-extensions Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? Fails at `nifi-standard-processors`. - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ultratendency/nifi NIFI-5386 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2851.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2851 commit 4097f45e4132d7d43705375b464c366f806933f1 Author: Jan Hentschel Date: 2018-07-06T18:35:11Z NIFI-5386 Removed redundant dependencies from nifi-redis-extensions ---
[jira] [Commented] (NIFI-5327) NetFlow Processors
[ https://issues.apache.org/jira/browse/NIFI-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535202#comment-16535202 ] ASF GitHub Bot commented on NIFI-5327: -- Github user PrashanthVenkatesan commented on the issue: https://github.com/apache/nifi/pull/2820 Currently I can find only Windows applications. I'll check for any generator available that's runs in Linux. If not I will create a generator code and share it asap.. > NetFlow Processors > -- > > Key: NIFI-5327 > URL: https://issues.apache.org/jira/browse/NIFI-5327 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework >Affects Versions: 1.6.0 >Reporter: Prashanth Venkatesan >Assignee: Prashanth Venkatesan >Priority: Major > > As network traffic data scopes for the big data use case, would like NiFi to > have processors to support parsing of those protocols. > Netflow is a protocol introduced by Cisco that provides the ability to > collect IP network traffic as it enters or exits an interface and is > described in detail in here: > [https://www.cisco.com/c/en/us/td/docs/net_mgmt/netflow_collection_engine/3-6/user/guide/format.html] > > Currently, I have created the following processor: > *ParseNetflowv5*: Parses the ingress netflowv5 bytes and ingest as either > NiFi flowfile attributes or as a JSON content. This also sends > one-time-template. > > Further ahead, we can add many processor specific to network protocols in > this nar bundle. > I will create a pull request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2820: NIFI-5327 Adding Netflowv5 protocol parser
Github user PrashanthVenkatesan commented on the issue: https://github.com/apache/nifi/pull/2820 Currently I can find only Windows applications. I'll check for any generator available that's runs in Linux. If not I will create a generator code and share it asap.. ---
[jira] [Created] (NIFI-5386) Remove redundant dependencies from nifi-redis-extensions
Jan Hentschel created NIFI-5386:
---
Summary: Remove redundant dependencies from nifi-redis-extensions
Key: NIFI-5386
URL: https://issues.apache.org/jira/browse/NIFI-5386
Project: Apache NiFi
Issue Type: Improvement
Reporter: Jan Hentschel
The module {{nifi-redis-extensions}} defines the dependencies {{slf4j-simple}}
and {{junit}}, which are already defined in the root POM and can be removed
safely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5385) assertAttributeNotExists Is hard to understand
[ https://issues.apache.org/jira/browse/NIFI-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535112#comment-16535112 ] ASF GitHub Bot commented on NIFI-5385: -- GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2850 NIFI-5385 assertAttributeNotExists Is hard to understand assertAttributeNotExists has a hard to understand error message, clarified language. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5385 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2850.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2850 commit 45dbfcd95d63ac439e3356068058bc2162551391 Author: patricker Date: 2018-07-06T16:44:38Z NIFI-5385 assertAttributeNotExists Is hard to understand > assertAttributeNotExists Is hard to understand > -- > > Key: NIFI-5385 > URL: https://issues.apache.org/jira/browse/NIFI-5385 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > In the mocking/testing framework, `assertAttributeNotExists` has an unclear > error message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2850: NIFI-5385 assertAttributeNotExists Is hard to under...
GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2850 NIFI-5385 assertAttributeNotExists Is hard to understand assertAttributeNotExists has a hard to understand error message, clarified language. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5385 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2850.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2850 commit 45dbfcd95d63ac439e3356068058bc2162551391 Author: patricker Date: 2018-07-06T16:44:38Z NIFI-5385 assertAttributeNotExists Is hard to understand ---
[jira] [Created] (NIFI-5385) assertAttributeNotExists Is hard to understand
Peter Wicks created NIFI-5385: - Summary: assertAttributeNotExists Is hard to understand Key: NIFI-5385 URL: https://issues.apache.org/jira/browse/NIFI-5385 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Reporter: Peter Wicks Assignee: Peter Wicks In the mocking/testing framework, `assertAttributeNotExists` has an unclear error message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project
[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535098#comment-16535098
]
ASF GitHub Bot commented on NIFI-5376:
--
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2841#discussion_r200708592
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java
---
@@ -264,7 +263,7 @@ private static void unpack(final File nar, final File
workingDirectory, final by
String name = jarEntry.getName();
File f = new File(workingDirectory, name);
if (jarEntry.isDirectory()) {
-FileUtils.ensureDirectoryExistAndCanAccess(f);
+FileUtils.ensureDirectoryExistAndCanReadAndWrite(f);
--- End diff --
The deprecated method was one line simply calling the method with which I
replaced it. There is no behavioral change. I imagine the original fix changed
behavior but did not update all calling references.
> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references
> to deprecated custom versions of
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced
> with
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}.
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Us
[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2841#discussion_r200708592
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java
---
@@ -264,7 +263,7 @@ private static void unpack(final File nar, final File
workingDirectory, final by
String name = jarEntry.getName();
File f = new File(workingDirectory, name);
if (jarEntry.isDirectory()) {
-FileUtils.ensureDirectoryExistAndCanAccess(f);
+FileUtils.ensureDirectoryExistAndCanReadAndWrite(f);
--- End diff --
The deprecated method was one line simply calling the method with which I
replaced it. There is no behavioral change. I imagine the original fix changed
behavior but did not update all calling references.
---
[GitHub] nifi pull request #2849: NIFI-5384 FlowFile's queued in batches should all h...
GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2849 NIFI-5384 FlowFile's queued in batches should all have the same Queue⦠⦠time While building some batching unit tests I started making the assumption that FlowFile's sent to session.Transfer in batches should all have the same Queued time. Only to find out that wasn't true. Updating batch queuing of FlowFile's so that FlowFile's transferred together all have the same queue time. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5384 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2849.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2849 commit 5bd487d08049d9c74ef46607200268819042e2bf Author: patricker Date: 2018-07-06T16:38:04Z NIFI-5384 FlowFile's queued in batches should all have the same Queue time ---
[jira] [Commented] (NIFI-5384) FlowFile's queued in batches should all have the same Queue time
[ https://issues.apache.org/jira/browse/NIFI-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535095#comment-16535095 ] ASF GitHub Bot commented on NIFI-5384: -- GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/2849 NIFI-5384 FlowFile's queued in batches should all have the same Queue… … time While building some batching unit tests I started making the assumption that FlowFile's sent to session.Transfer in batches should all have the same Queued time. Only to find out that wasn't true. Updating batch queuing of FlowFile's so that FlowFile's transferred together all have the same queue time. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-5384 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2849.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2849 commit 5bd487d08049d9c74ef46607200268819042e2bf Author: patricker Date: 2018-07-06T16:38:04Z NIFI-5384 FlowFile's queued in batches should all have the same Queue time > FlowFile's queued in batches should all have the same Queue time > > > Key: NIFI-5384 > URL: https://issues.apache.org/jira/browse/NIFI-5384 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > When performing a Session.Transfer on a list of FlowFile's, all FlowFIle's > should have the same queue time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5376) Remove deprecated ByteArrayInput|OutputStream references throughout project
[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535074#comment-16535074
]
ASF GitHub Bot commented on NIFI-5376:
--
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2841#discussion_r200703862
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java
---
@@ -264,7 +263,7 @@ private static void unpack(final File nar, final File
workingDirectory, final by
String name = jarEntry.getName();
File f = new File(workingDirectory, name);
if (jarEntry.isDirectory()) {
-FileUtils.ensureDirectoryExistAndCanAccess(f);
+FileUtils.ensureDirectoryExistAndCanReadAndWrite(f);
--- End diff --
this looks like a change fixing a bug whereby we checked for simple access
instead of ability to write files. Can we link this to an existing JIRA or
expand the scope of NIFI-5376 so we dont lose track of this.
> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.7.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references
> to deprecated custom versions of
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced
> with
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}.
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
>
[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2841#discussion_r200703862
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java
---
@@ -264,7 +263,7 @@ private static void unpack(final File nar, final File
workingDirectory, final by
String name = jarEntry.getName();
File f = new File(workingDirectory, name);
if (jarEntry.isDirectory()) {
-FileUtils.ensureDirectoryExistAndCanAccess(f);
+FileUtils.ensureDirectoryExistAndCanReadAndWrite(f);
--- End diff --
this looks like a change fixing a bug whereby we checked for simple access
instead of ability to write files. Can we link this to an existing JIRA or
expand the scope of NIFI-5376 so we dont lose track of this.
---
[jira] [Commented] (NIFI-5377) StandardNiFiServiceFacade: Recursive method call allows for infinite loop when a circular reference exists
[ https://issues.apache.org/jira/browse/NIFI-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535065#comment-16535065 ] ASF GitHub Bot commented on NIFI-5377: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2847 @JonathanKessler I experienced it on the graph. If you add another service (like I described) you should be able to enable the service with no dependencies. As part of that action, you can indicate whether you want referencing services to also be enabled. > StandardNiFiServiceFacade: Recursive method call allows for infinite loop > when a circular reference exists > -- > > Key: NIFI-5377 > URL: https://issues.apache.org/jira/browse/NIFI-5377 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Jon Kessler >Assignee: Mark Bean >Priority: Minor > > At a minimum, when you attempt to view a list of controller services in the > gui this specific method is called to obtain a set of referenced controller > service identifiers. If there is a circular dependency in that set, you end > up with an infinite loop that ultimately results the user being redirected to > an error page in the gui. > The method in question is > findControllerServiceReferencingComponentIdentifiers. It checks to see if > each node has been visited already but does not add them to the set until > after recursively calling itself again. If the line "visited.add(node);" is > moved above the method call, this will be resolved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2847: NIFI-5377 prevent infinite loop if a controller service ci...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2847 @JonathanKessler I experienced it on the graph. If you add another service (like I described) you should be able to enable the service with no dependencies. As part of that action, you can indicate whether you want referencing services to also be enabled. ---
[jira] [Created] (NIFI-5384) FlowFile's queued in batches should all have the same Queue time
Peter Wicks created NIFI-5384: - Summary: FlowFile's queued in batches should all have the same Queue time Key: NIFI-5384 URL: https://issues.apache.org/jira/browse/NIFI-5384 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Reporter: Peter Wicks Assignee: Peter Wicks When performing a Session.Transfer on a list of FlowFile's, all FlowFIle's should have the same queue time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1251) Allow ExecuteSQL to send out large result sets in chunks
[ https://issues.apache.org/jira/browse/NIFI-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535048#comment-16535048 ] ASF GitHub Bot commented on NIFI-1251: -- Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2834 @mattyb149 Updated > Allow ExecuteSQL to send out large result sets in chunks > > > Key: NIFI-1251 > URL: https://issues.apache.org/jira/browse/NIFI-1251 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Peter Wicks >Priority: Major > > Currently, when using ExecuteSQL, if a result set is very large, it can take > quite a long time to pull back all of the results. It would be nice to have > the ability to specify the maximum number of records to put into a FlowFile, > so that if we pull back say 1 million records we can configure it to create > 1000 FlowFiles, each with 1000 records. This way, we can begin processing the > first 1,000 records while the next 1000 are being pulled from the remote > database. > This suggestion comes from Vinay via the dev@ mailing list: > Is there way to have streaming feature when large result set is fetched from > database basically to reads data from the database in chunks of records > instead of loading the full result set into memory. > As part of ExecuteSQL can a property be specified called "FetchSize" which > Indicates how many rows should be fetched from the resultSet. > Since jam bit new in using NIFI , can any guide me on above. > Thanks in advance -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2834: NIFI-1251 - Allow ExecuteSQL to send out large result sets...
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2834 @mattyb149 Updated ---
[GitHub] nifi pull request #2848: NIFI-5383 Replaced hard-coded version with Maven pr...
GitHub user HorizonNet opened a pull request: https://github.com/apache/nifi/pull/2848 NIFI-5383 Replaced hard-coded version with Maven property in nifi-redis-bundle Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? Fails at `nifi-standard-processors`. - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ultratendency/nifi NIFI-5383 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2848.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2848 commit cc62cab40d1dc94581395199b610b9a9dac3df40 Author: Jan Hentschel Date: 2018-07-06T15:58:59Z NIFI-5383 Replaced hard-coded version with Maven property in nifi-redis-bundle ---
[jira] [Commented] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
[
https://issues.apache.org/jira/browse/NIFI-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535045#comment-16535045
]
ASF GitHub Bot commented on NIFI-5383:
--
GitHub user HorizonNet opened a pull request:
https://github.com/apache/nifi/pull/2848
NIFI-5383 Replaced hard-coded version with Maven property in
nifi-redis-bundle
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder? Fails at
`nifi-standard-processors`.
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ultratendency/nifi NIFI-5383
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2848.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2848
commit cc62cab40d1dc94581395199b610b9a9dac3df40
Author: Jan Hentschel
Date: 2018-07-06T15:58:59Z
NIFI-5383 Replaced hard-coded version with Maven property in
nifi-redis-bundle
> Use ${project.version} instead of hard-coded version in nifi-redis-bundle
> -
>
> Key: NIFI-5383
> URL: https://issues.apache.org/jira/browse/NIFI-5383
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Priority: Trivial
>
> Currently the {{nifi-redis-bundle}} module and its sub-modules use a
> hard-coded NiFi version. To make version updates easier this should be
> replaced by {{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (NIFI-5383) Use ${project.version} instead of hard-coded version in nifi-redis-bundle
Jan Hentschel created NIFI-5383:
---
Summary: Use ${project.version} instead of hard-coded version in
nifi-redis-bundle
Key: NIFI-5383
URL: https://issues.apache.org/jira/browse/NIFI-5383
Project: Apache NiFi
Issue Type: Improvement
Reporter: Jan Hentschel
Currently the {{nifi-redis-bundle}} module and its sub-modules use a hard-coded
NiFi version. To make version updates easier this should be replaced by
{{${project.version}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5327) NetFlow Processors
[ https://issues.apache.org/jira/browse/NIFI-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535023#comment-16535023 ] ASF GitHub Bot commented on NIFI-5327: -- Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2820 Anything not windows specific? > NetFlow Processors > -- > > Key: NIFI-5327 > URL: https://issues.apache.org/jira/browse/NIFI-5327 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework >Affects Versions: 1.6.0 >Reporter: Prashanth Venkatesan >Assignee: Prashanth Venkatesan >Priority: Major > > As network traffic data scopes for the big data use case, would like NiFi to > have processors to support parsing of those protocols. > Netflow is a protocol introduced by Cisco that provides the ability to > collect IP network traffic as it enters or exits an interface and is > described in detail in here: > [https://www.cisco.com/c/en/us/td/docs/net_mgmt/netflow_collection_engine/3-6/user/guide/format.html] > > Currently, I have created the following processor: > *ParseNetflowv5*: Parses the ingress netflowv5 bytes and ingest as either > NiFi flowfile attributes or as a JSON content. This also sends > one-time-template. > > Further ahead, we can add many processor specific to network protocols in > this nar bundle. > I will create a pull request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2820: NIFI-5327 Adding Netflowv5 protocol parser
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2820 Anything not windows specific? ---
[jira] [Commented] (MINIFICPP-555) Pass through CMake args from build environment to external projects
[
https://issues.apache.org/jira/browse/MINIFICPP-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535022#comment-16535022
]
Andrew Christianson commented on MINIFICPP-555:
---
Compare with -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE} to make sure it's
kept simple & non-redundant.
> Pass through CMake args from build environment to external projects
> ---
>
> Key: MINIFICPP-555
> URL: https://issues.apache.org/jira/browse/MINIFICPP-555
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
>
> When the build environment is customized, and especially in cross-compilation
> build environments, many CMake env vars are set which need to be, but are not
> by default, passed to external project builds. Vars include:
>
> {code:java}
> set(PASSTHROUGH_CMAKE_ARGS -DANDROID_ABI=${ANDROID_ABI}
> -DANDROID_PLATFORM=${ANDROID_PLATFORM}
> -DANDROID_STL=${ANDROID_STL}
> -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
> -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
> -DANDROID_NDK=${ANDROID_NDK}
> -DCMAKE_CXX_FLAGS=${CMAKE_CXX_FLAGS}
> -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
> -DCMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM}
> -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
> -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
> -DCMAKE_FIND_ROOT_PATH=${CMAKE_FIND_ROOT_PATH}
> -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=${CMAKE_FIND_ROOT_PATH_MODE_PROGRAM}
> -DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=${CMAKE_FIND_ROOT_PATH_MODE_LIBRARY}
> -DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=${CMAKE_FIND_ROOT_PATH_MODE_INCLUDE}
> -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
> -G${CMAKE_GENERATOR})
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-3698) Create SSH Processor
[ https://issues.apache.org/jira/browse/NIFI-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535021#comment-16535021 ] Otto Fowler commented on NIFI-3698: --- Thank you [~patricker] that is what I had missed. Sorry > Create SSH Processor > > > Key: NIFI-3698 > URL: https://issues.apache.org/jira/browse/NIFI-3698 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Joseph Petro >Assignee: Peter Wicks >Priority: Minor > > We need an ssh processor built in for running external commands on remote > servers. Currently, groovy offers a way to do this. It should be implemented > into NiFi. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5377) StandardNiFiServiceFacade: Recursive method call allows for infinite loop when a circular reference exists
[ https://issues.apache.org/jira/browse/NIFI-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535018#comment-16535018 ] Mark Bean commented on NIFI-5377: - FYI- NIFI-5368 is related (but not covered under this ticket). I'm modifying StandardProcessorTestRunner to validate a controller service before enabling it. The Mock framework is not handing this correctly currently. Unfortunately, this broke unit tests which were taking advantage of this loophole (knowingly or otherwise) > StandardNiFiServiceFacade: Recursive method call allows for infinite loop > when a circular reference exists > -- > > Key: NIFI-5377 > URL: https://issues.apache.org/jira/browse/NIFI-5377 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Jon Kessler >Assignee: Mark Bean >Priority: Minor > > At a minimum, when you attempt to view a list of controller services in the > gui this specific method is called to obtain a set of referenced controller > service identifiers. If there is a circular dependency in that set, you end > up with an infinite loop that ultimately results the user being redirected to > an error page in the gui. > The method in question is > findControllerServiceReferencingComponentIdentifiers. It checks to see if > each node has been visited already but does not add them to the set until > after recursively calling itself again. If the line "visited.add(node);" is > moved above the method call, this will be resolved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-3698) Create SSH Processor
[ https://issues.apache.org/jira/browse/NIFI-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535015#comment-16535015 ] Peter Wicks commented on NIFI-3698: --- [~ottobackwards], As with the SFTP processors, this is buried a few layers deep in helper classes. REf SSHTransfer, `getSession`. I copied this right out of the SFTP Transfer class. > Create SSH Processor > > > Key: NIFI-3698 > URL: https://issues.apache.org/jira/browse/NIFI-3698 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Joseph Petro >Assignee: Peter Wicks >Priority: Minor > > We need an ssh processor built in for running external commands on remote > servers. Currently, groovy offers a way to do this. It should be implemented > into NiFi. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
