[GitHub] [nifi] SamHjelmfelt opened a new pull request #3762: NIFI-6703: Add Stateless NiFi to CLI
SamHjelmfelt opened a new pull request #3762: NIFI-6703: Add Stateless NiFi to
CLI
URL: https://github.com/apache/nifi/pull/3762
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
https://issues.apache.org/jira/browse/NIFI-6703
Users should be able to easily run Stateless NiFi flows from the CLI without
docker.
Added stateless bootstrap and nar to nifi-assembly and removed
nifi-stateless/nifi-stateless-assembly. nifi-docker/dockermaven-stateless was
updated to accommodate this change.
Added a new top level action (stateless) to nifi.sh which runs the
"org.apache.nifi.stateless.NiFiStateless" bootstrap class with the provided
arguments after extracting nars. Note that this is intentionally synchronous to
allow for many stateless flows on the same machine.
Updated stateless-nifi/README.md
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ X ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ X ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ X ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and
JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ X ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6703) Add Stateless NiFi to CLI
[ https://issues.apache.org/jira/browse/NIFI-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Hjelmfelt updated NIFI-6703: Summary: Add Stateless NiFi to CLI (was: Add Stateless NiFi to nifi.sh CLI) > Add Stateless NiFi to CLI > - > > Key: NIFI-6703 > URL: https://issues.apache.org/jira/browse/NIFI-6703 > Project: Apache NiFi > Issue Type: Bug >Reporter: Sam Hjelmfelt >Priority: Major > > Users should be able to easily run Stateless NiFi flows from the CLI without > docker. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-6703) Add Stateless NiFi to nifi.sh CLI
Sam Hjelmfelt created NIFI-6703: --- Summary: Add Stateless NiFi to nifi.sh CLI Key: NIFI-6703 URL: https://issues.apache.org/jira/browse/NIFI-6703 Project: Apache NiFi Issue Type: Bug Reporter: Sam Hjelmfelt Users should be able to easily run Stateless NiFi flows from the CLI without docker. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mans2singh commented on issue #3741: NIFI-6675 - Added support for JsonPath put operation
mans2singh commented on issue #3741: NIFI-6675 - Added support for JsonPath put operation URL: https://github.com/apache/nifi/pull/3741#issuecomment-534253012 Thanks @joewitt This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6702) ConsumeAzureEventHub requires Manage palicy to list all partitions
Antoh created NIFI-6702: --- Summary: ConsumeAzureEventHub requires Manage palicy to list all partitions Key: NIFI-6702 URL: https://issues.apache.org/jira/browse/NIFI-6702 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 1.9.2 Environment: windows Reporter: Antoh if I have Listen policy for my eventhub key, this ConsumeAzureEventHub proccessor fails with h1. Failure getting partition ids for event hub It can be fixed by changing to key to Manage policy Similar to [https://stackoverflow.com/questions/38505786/in-azure-eventhub-reciever-giving-encountered-error-while-fetching-the-list-of] By default Listen policy have to work. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #650: MINIFICPP-1034 - MQTT processors doesnt work
arpadboda closed pull request #650: MINIFICPP-1034 - MQTT processors doesnt work URL: https://github.com/apache/nifi-minifi-cpp/pull/650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Reopened] (NIFI-6679) MoveHDFS removes original file when destination exists
[ https://issues.apache.org/jira/browse/NIFI-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Mota Fontes reopened NIFI-6679: --- The PR wasn't merged yet. > MoveHDFS removes original file when destination exists > -- > > Key: NIFI-6679 > URL: https://issues.apache.org/jira/browse/NIFI-6679 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.9.2 > Environment: N/A >Reporter: Eduardo Mota Fontes >Priority: Major > Labels: patch > Fix For: 1.10.0 > > Attachments: Capturar.PNG > > Time Spent: 50m > Remaining Estimate: 0h > > In MoveHDFS processor when destination file exists it removes the "original > file" in place of "destination file" when the case of conflict resolution is > REPLACE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6671) UI:Parameters listed in "Reference parameter..." drop-down not listed alphabetically
[ https://issues.apache.org/jira/browse/NIFI-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936116#comment-16936116 ] Andrew Lim commented on NIFI-6671: -- Verified fix. > UI:Parameters listed in "Reference parameter..." drop-down not listed > alphabetically > > > Key: NIFI-6671 > URL: https://issues.apache.org/jira/browse/NIFI-6671 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Andrew Lim >Assignee: Robert Fellows >Priority: Major > Fix For: 1.10.0 > > Attachments: alphabetical_order.png, wrong-order.png > > Time Spent: 40m > Remaining Estimate: 0h > > I created a Parameter Context and then added three parameters in this order: > level1 > level2 > level3 > But these parameters are listed in the following order when I try to select > them for a property value: > level1 > level3 > level2 > > See attached screenshots. If not easily reproducible, I can attach a video of > my exact steps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] belugabehr commented on issue #3643: NIFI-6542: Upgrade nifi-hadoop-bundles Hadoop version dependency to 3…
belugabehr commented on issue #3643: NIFI-6542: Upgrade nifi-hadoop-bundles Hadoop version dependency to 3… URL: https://github.com/apache/nifi/pull/3643#issuecomment-534230306 ```[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project nifi-hive-processors: Compilation failure [ERROR] error: error reading /home/travis/.m2/repository/org/apache/hive/hive-exec/1.2.1/hive-exec-1.2.1.jar; error in opening zip file``` Failure doesn't really seem related. How do I kick off the CI tests suite again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFIREG-321) Integrate nifi-registry-revsion into REST API and service layers
Bryan Bende created NIFIREG-321: --- Summary: Integrate nifi-registry-revsion into REST API and service layers Key: NIFIREG-321 URL: https://issues.apache.org/jira/browse/NIFIREG-321 Project: NiFi Registry Issue Type: Improvement Reporter: Bryan Bende Assignee: Bryan Bende Fix For: 1.0.0 In NIFIREG-300 we setup the revision modules which represent a library for implementing optimistic locking using the same approach NiFi currently implements. This ticket is the follow on work to now integrate the revision concept into NiFi Registry's REST API and service layer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi] bbende merged pull request #168: MINIFI-512 Change bootstrap port command handling
bbende merged pull request #168: MINIFI-512 Change bootstrap port command handling URL: https://github.com/apache/nifi-minifi/pull/168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFIREG-318) Only allow bootstrap port to be set during initial startup
[ https://issues.apache.org/jira/browse/NIFIREG-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-318. - Resolution: Fixed > Only allow bootstrap port to be set during initial startup > -- > > Key: NIFIREG-318 > URL: https://issues.apache.org/jira/browse/NIFIREG-318 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Minor > Fix For: 1.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-registry] bbende merged pull request #228: NIFIREG-318 Change bootstrap port command handling
bbende merged pull request #228: NIFIREG-318 Change bootstrap port command handling URL: https://github.com/apache/nifi-registry/pull/228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-standard-libraries] kevdoran merged pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE
kevdoran merged pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE URL: https://github.com/apache/nifi-standard-libraries/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6701) PublishGCPPubSub does not send all messages
Jake Dalli created NIFI-6701:
Summary: PublishGCPPubSub does not send all messages
Key: NIFI-6701
URL: https://issues.apache.org/jira/browse/NIFI-6701
Project: Apache NiFi
Issue Type: Bug
Components: Extensions
Affects Versions: 1.9.2
Reporter: Jake Dalli
I have found an issue with the PublishGCPPubSub processor. After implementing
a number of flows, I have realised that approximately 30% of messages are
sporadically not sent to Pubsub in spite of a 'Send Successful' response from
the processor.
Upon investigating the code on github
([https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java|https://slack-redir.net/link?url=https%3A%2F%2Fgithub.com%2Fapache%2Fnifi%2Fblob%2Fmaster%2Fnifi-nar-bundles%2Fnifi-gcp-bundle%2Fnifi-gcp-processors%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fnifi%2Fprocessors%2Fgcp%2Fpubsub%2FPublishGCPubSub.java]),
I found the following issue:
# On line 163 we get the Future for the 'Publish message' action.
# On line 165 we have the following loop:
{code:java}
while (messageIdFuture.isDone()) {
Thread.sleep(500L);
}
{code}
This means that if the future isDone method returns, the thread sleeps. It is
unclear to me why this is the case and I believe this is a bag, in my opinion
the processor should sleep if the future is not done, thus the loop should read:
{code:java}
while(!messageIdFuture.isDone()){ ... }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6684) Add more property to Hive3ConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936042#comment-16936042 ] Peter Wicks commented on NIFI-6684: --- [~AxelSync] I was planning to review this, and don't have any concerns. It probably should have been done quite a while ago. > Add more property to Hive3ConnectionPool > > > Key: NIFI-6684 > URL: https://issues.apache.org/jira/browse/NIFI-6684 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: jamescheng >Assignee: Peter Wicks >Priority: Minor > Attachments: PutHive3 enhance.png > > Time Spent: 10m > Remaining Estimate: 0h > > The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them > are using DBCP BasicDataSource. However, Hive3ConnectionPool doesn't provide > some properties of what DBCPConnectionPool has. Such as "Minimum Idle > Connections", "Max Idle Connections", "Max Connection Lifetime", "Time > Between Eviction Runs", "Minimum Evictable Idle Time" and "Soft Minimum > Evictable Idle Time". > This improvement is try to provide more properties for developer to set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-6700) Link to contributor guide in online documentation broken
Otto Fowler created NIFI-6700: - Summary: Link to contributor guide in online documentation broken Key: NIFI-6700 URL: https://issues.apache.org/jira/browse/NIFI-6700 Project: Apache NiFi Issue Type: Task Reporter: Otto Fowler The link to the contributing guide in the developer's guide off of https://nifi.apache.org/docs/nifi-docs/ doesn't work -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] phrocker commented on issue #652: MINIFICPP-1041: Update JSON header for the connection queues
phrocker commented on issue #652: MINIFICPP-1041: Update JSON header for the connection queues URL: https://github.com/apache/nifi-minifi-cpp/pull/652#issuecomment-534190015 @apiri or @kevdoran if you have a chance can you validate this? thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker opened a new pull request #652: MINIFICPP-1041: Update JSON header for the connection queues
phrocker opened a new pull request #652: MINIFICPP-1041: Update JSON header for the connection queues URL: https://github.com/apache/nifi-minifi-cpp/pull/652 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MINIFICPP-1041) Re-order connection queues in RESTFuil c2 response
[ https://issues.apache.org/jira/browse/MINIFICPP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-1041: -- Description: Currently the JSON response has the queue name as the top level node ( in jSON this is the object key ). We don't want to change the AST and impact upstream changes. Therefore we will simply change the JSON response in line. > Re-order connection queues in RESTFuil c2 response > --- > > Key: MINIFICPP-1041 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1041 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.7.0 > > > Currently the JSON response has the queue name as the top level node ( in > jSON this is the object key ). We don't want to change the AST and impact > upstream changes. Therefore we will simply change the JSON response in line. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MINIFICPP-1041) Re-order connection queues in RESTFuil c2 response
Mr TheSegfault created MINIFICPP-1041: - Summary: Re-order connection queues in RESTFuil c2 response Key: MINIFICPP-1041 URL: https://issues.apache.org/jira/browse/MINIFICPP-1041 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Mr TheSegfault Assignee: Mr TheSegfault Fix For: 0.7.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6684) Add more property to Hive3ConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935984#comment-16935984 ] Alessandro D'Armiento commented on NIFI-6684: - I agree with you on updating the dependency, however, I am not sure if this should be done in a separated issue, for better tracking. > Add more property to Hive3ConnectionPool > > > Key: NIFI-6684 > URL: https://issues.apache.org/jira/browse/NIFI-6684 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: jamescheng >Assignee: Peter Wicks >Priority: Minor > Attachments: PutHive3 enhance.png > > Time Spent: 10m > Remaining Estimate: 0h > > The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them > are using DBCP BasicDataSource. However, Hive3ConnectionPool doesn't provide > some properties of what DBCPConnectionPool has. Such as "Minimum Idle > Connections", "Max Idle Connections", "Max Connection Lifetime", "Time > Between Eviction Runs", "Minimum Evictable Idle Time" and "Soft Minimum > Evictable Idle Time". > This improvement is try to provide more properties for developer to set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] bbende commented on a change in pull request #3677: NIFI-6598 Storing peers into managed-state
bbende commented on a change in pull request #3677: NIFI-6598 Storing peers
into managed-state
URL: https://github.com/apache/nifi/pull/3677#discussion_r327189220
##
File path:
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
##
@@ -921,6 +931,23 @@ public File getPeerPersistenceFile() {
return peerPersistenceFile;
}
+@Override
+public StateManager getStateManager() {
+return stateManager;
+}
+
+@Override
+public PeerPersistence getPeerPersistence() {
+if (stateManager != null) {
+return new StatePeerPersistence(stateManager);
+
+} else if (peerPersistenceFile != null) {
+return new FilePeerPersistence(peerPersistenceFile);
+}
+
+return null;
+}
+
Review comment:
Anything that is part of the SiteToSiteClientConfig needs to also implement
Serializable because when the SiteToSite client is used in the streaming
integrations like SparkReceiver or Strom, it will serialize the config.
I think this means we need to make StateManager, and any of it's member
classes, implement Serializable, and also the new PeerPersistence
implementations.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #649: MINIFICPP-1024 - Fix third party dependencies
arpadboda closed pull request #649: MINIFICPP-1024 - Fix third party dependencies URL: https://github.com/apache/nifi-minifi-cpp/pull/649 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] arpadboda commented on issue #649: MINIFICPP-1024 - Fix third party dependencies
arpadboda commented on issue #649: MINIFICPP-1024 - Fix third party dependencies URL: https://github.com/apache/nifi-minifi-cpp/pull/649#issuecomment-534140495 Win verification is in progress on my VM. Merging this, will create a follow-up if I spot anything suspicious. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6696) Deadlock can occur when node disconnects from cluster if using load-balanced connections
[
https://issues.apache.org/jira/browse/NIFI-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Bende updated NIFI-6696:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Deadlock can occur when node disconnects from cluster if using load-balanced
> connections
>
>
> Key: NIFI-6696
> URL: https://issues.apache.org/jira/browse/NIFI-6696
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Blocker
> Fix For: 1.10.0
>
>
> I have encountered a deadlock when a node disconnected from the cluster. The
> relevant stack traces are as below:
>
> - Holds SocketLoadBalanceFlowFileQueue.partitionWriteLock
> - Needs NioAsyncLoadBalanceClient synchronized
> {code:java}
> Thread 61318: (state = BLOCKED)
> -
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.register(java.lang.String,
> java.util.function.BooleanSupplier, java.util.function.Supplier,
> org.apache.nifi.controller.queue.clustered.client.async.TransactionFailureCallback,
>
> org.apache.nifi.controller.queue.clustered.client.async.TransactionCompleteCallback,
> java.util.function.Supplier, java.util.function.BooleanSupplier) @bci=0,
> line=109 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientRegistry.lambda$register$0(java.lang.String,
> java.util.function.BooleanSupplier, java.util.function.Supplier,
> org.apache.nifi.controller.queue.clustered.client.async.TransactionFailureCallback,
>
> org.apache.nifi.controller.queue.clustered.client.async.TransactionCompleteCallback,
> java.util.function.Supplier, java.util.function.BooleanSupplier,
> org.apache.nifi.controller.queue.clustered.client.async.AsyncLoadBalanceClient)
> @bci=12, line=63 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientRegistry$$Lambda$1143.accept(java.lang.Object)
> @bci=32 (Compiled frame)
> - java.lang.Iterable.forEach(java.util.function.Consumer) @bci=30, line=75
> (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientRegistry.register(java.lang.String,
> org.apache.nifi.cluster.protocol.NodeIdentifier,
> java.util.function.BooleanSupplier, java.util.function.Supplier,
> org.apache.nifi.controller.queue.clustered.client.async.TransactionFailureCallback,
>
> org.apache.nifi.controller.queue.clustered.client.async.TransactionCompleteCallback,
> java.util.function.Supplier, java.util.function.BooleanSupplier) @bci=46,
> line=63 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.partition.RemoteQueuePartition.start(org.apache.nifi.controller.queue.clustered.partition.FlowFilePartitioner)
> @bci=94, line=217 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.SocketLoadBalancedFlowFileQueue.setNodeIdentifiers(java.util.Set,
> boolean) @bci=794, line=728 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.SocketLoadBalancedFlowFileQueue$ClusterEventListener.onNodeRemoved(org.apache.nifi.cluster.protocol.NodeIdentifier)
> @bci=90, line=1082 (Compiled frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator.lambda$onNodeRemoved$3(org.apache.nifi.cluster.protocol.NodeIdentifier,
> org.apache.nifi.cluster.coordination.ClusterTopologyEventListener) @bci=2,
> line=583 (Compiled frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator$$Lambda$1178.accept(java.lang.Object)
> @bci=8 (Compiled frame)
> -
> java.util.concurrent.CopyOnWriteArrayList.forEach(java.util.function.Consumer)
> @bci=38, line=891 (Compiled frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator.onNodeRemoved(org.apache.nifi.cluster.protocol.NodeIdentifier)
> @bci=10, line=583 (Interpreted frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator.removeNodeConditionally(org.apache.nifi.cluster.protocol.NodeIdentifier,
> org.apache.nifi.cluster.coordination.node.NodeConnectionStatus) @bci=29,
> line=331 (Interpreted frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator.replaceNodeStatus(org.apache.nifi.cluster.protocol.NodeIdentifier,
> org.apache.nifi.cluster.coordination.node.NodeConnectionStatus,
> org.apache.nifi.cluster.coordination.node.NodeConnectionStatus) @bci=89,
> line=415 (Interpreted frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator.resetNodeStatus(org.apache.nifi.cluster.coordination.node.NodeConnectionStatus,
> long) @bci=44, line=380 (Interpreted frame)
> -
>
[jira] [Commented] (NIFI-6696) Deadlock can occur when node disconnects from cluster if using load-balanced connections
[
https://issues.apache.org/jira/browse/NIFI-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935888#comment-16935888
]
ASF subversion and git services commented on NIFI-6696:
---
Commit c721a9ee5fddfefa6b4dc87afa1b6c45cb09d101 in nifi's branch
refs/heads/master from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c721a9e ]
NIFI-6696: Ensured that callback to RemoteQueuePartition do not attempt to
obtain the Partition Read Lock. The Read Lock is not necessary as long as the
'partitioner' is volatile, because it doesn't matter whether or not the actual
partitions themselves change, since the only partition that would be touched is
the Rebalancing Partition,on, which is fixed. Obtaining the partition read lock
can lead to a deadlock as outlined in the Jira description.
This closes #3760.
Signed-off-by: Bryan Bende
> Deadlock can occur when node disconnects from cluster if using load-balanced
> connections
>
>
> Key: NIFI-6696
> URL: https://issues.apache.org/jira/browse/NIFI-6696
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Blocker
> Fix For: 1.10.0
>
>
> I have encountered a deadlock when a node disconnected from the cluster. The
> relevant stack traces are as below:
>
> - Holds SocketLoadBalanceFlowFileQueue.partitionWriteLock
> - Needs NioAsyncLoadBalanceClient synchronized
> {code:java}
> Thread 61318: (state = BLOCKED)
> -
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.register(java.lang.String,
> java.util.function.BooleanSupplier, java.util.function.Supplier,
> org.apache.nifi.controller.queue.clustered.client.async.TransactionFailureCallback,
>
> org.apache.nifi.controller.queue.clustered.client.async.TransactionCompleteCallback,
> java.util.function.Supplier, java.util.function.BooleanSupplier) @bci=0,
> line=109 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientRegistry.lambda$register$0(java.lang.String,
> java.util.function.BooleanSupplier, java.util.function.Supplier,
> org.apache.nifi.controller.queue.clustered.client.async.TransactionFailureCallback,
>
> org.apache.nifi.controller.queue.clustered.client.async.TransactionCompleteCallback,
> java.util.function.Supplier, java.util.function.BooleanSupplier,
> org.apache.nifi.controller.queue.clustered.client.async.AsyncLoadBalanceClient)
> @bci=12, line=63 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientRegistry$$Lambda$1143.accept(java.lang.Object)
> @bci=32 (Compiled frame)
> - java.lang.Iterable.forEach(java.util.function.Consumer) @bci=30, line=75
> (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientRegistry.register(java.lang.String,
> org.apache.nifi.cluster.protocol.NodeIdentifier,
> java.util.function.BooleanSupplier, java.util.function.Supplier,
> org.apache.nifi.controller.queue.clustered.client.async.TransactionFailureCallback,
>
> org.apache.nifi.controller.queue.clustered.client.async.TransactionCompleteCallback,
> java.util.function.Supplier, java.util.function.BooleanSupplier) @bci=46,
> line=63 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.partition.RemoteQueuePartition.start(org.apache.nifi.controller.queue.clustered.partition.FlowFilePartitioner)
> @bci=94, line=217 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.SocketLoadBalancedFlowFileQueue.setNodeIdentifiers(java.util.Set,
> boolean) @bci=794, line=728 (Compiled frame)
> -
> org.apache.nifi.controller.queue.clustered.SocketLoadBalancedFlowFileQueue$ClusterEventListener.onNodeRemoved(org.apache.nifi.cluster.protocol.NodeIdentifier)
> @bci=90, line=1082 (Compiled frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator.lambda$onNodeRemoved$3(org.apache.nifi.cluster.protocol.NodeIdentifier,
> org.apache.nifi.cluster.coordination.ClusterTopologyEventListener) @bci=2,
> line=583 (Compiled frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator$$Lambda$1178.accept(java.lang.Object)
> @bci=8 (Compiled frame)
> -
> java.util.concurrent.CopyOnWriteArrayList.forEach(java.util.function.Consumer)
> @bci=38, line=891 (Compiled frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator.onNodeRemoved(org.apache.nifi.cluster.protocol.NodeIdentifier)
> @bci=10, line=583 (Interpreted frame)
> -
> org.apache.nifi.cluster.coordination.node.NodeClusterCoordinator.removeNodeConditionally(org.apache.nifi.cluster.protocol.NodeIdentifier,
>
[GitHub] [nifi] asfgit closed pull request #3760: NIFI-9969: Ensured that callback to RemoteQueuePartition do not attem…
asfgit closed pull request #3760: NIFI-9969: Ensured that callback to RemoteQueuePartition do not attem… URL: https://github.com/apache/nifi/pull/3760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6684) Add more property to Hive3ConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935876#comment-16935876 ] jamescheng commented on NIFI-6684: -- Hi [~AxelSync], I used DBCP2 to replace DBCP library in Hive3ConnectionPool so it can support MAX_CONN_LIFETIME and SOFT_MIN_EVICTABLE_IDLE_TIME properties. I'm still testing it and will provide the PR later. > Add more property to Hive3ConnectionPool > > > Key: NIFI-6684 > URL: https://issues.apache.org/jira/browse/NIFI-6684 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: jamescheng >Assignee: Peter Wicks >Priority: Minor > Attachments: PutHive3 enhance.png > > Time Spent: 10m > Remaining Estimate: 0h > > The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them > are using DBCP BasicDataSource. However, Hive3ConnectionPool doesn't provide > some properties of what DBCPConnectionPool has. Such as "Minimum Idle > Connections", "Max Idle Connections", "Max Connection Lifetime", "Time > Between Eviction Runs", "Minimum Evictable Idle Time" and "Soft Minimum > Evictable Idle Time". > This improvement is try to provide more properties for developer to set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (NIFI-6684) Add more property to Hive3ConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935863#comment-16935863 ] Alessandro D'Armiento edited comment on NIFI-6684 at 9/23/19 1:39 PM: -- Hello Peter, feel free to take inspiration from the PR I've attached to this Jira. It's still a work in progress (I found some potential issues with the Unit testing). I didn't know this was already taken was (Author: axelsync): Hello Peter, feel free to take some from the PR I've attached to this Jira. It's still a work in progress (I found some potential issues with the Unit testing). I didn't know this was already taken > Add more property to Hive3ConnectionPool > > > Key: NIFI-6684 > URL: https://issues.apache.org/jira/browse/NIFI-6684 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: jamescheng >Assignee: Peter Wicks >Priority: Minor > Attachments: PutHive3 enhance.png > > Time Spent: 10m > Remaining Estimate: 0h > > The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them > are using DBCP BasicDataSource. However, Hive3ConnectionPool doesn't provide > some properties of what DBCPConnectionPool has. Such as "Minimum Idle > Connections", "Max Idle Connections", "Max Connection Lifetime", "Time > Between Eviction Runs", "Minimum Evictable Idle Time" and "Soft Minimum > Evictable Idle Time". > This improvement is try to provide more properties for developer to set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6684) Add more property to Hive3ConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935863#comment-16935863 ] Alessandro D'Armiento commented on NIFI-6684: - Hello Peter, feel free to take some from the PR I've attached to this Jira. It's still a work in progress (I found some potential issues with the Unit testing). I didn't know this was already taken > Add more property to Hive3ConnectionPool > > > Key: NIFI-6684 > URL: https://issues.apache.org/jira/browse/NIFI-6684 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: jamescheng >Assignee: Peter Wicks >Priority: Minor > Attachments: PutHive3 enhance.png > > Time Spent: 10m > Remaining Estimate: 0h > > The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them > are using DBCP BasicDataSource. However, Hive3ConnectionPool doesn't provide > some properties of what DBCPConnectionPool has. Such as "Minimum Idle > Connections", "Max Idle Connections", "Max Connection Lifetime", "Time > Between Eviction Runs", "Minimum Evictable Idle Time" and "Soft Minimum > Evictable Idle Time". > This improvement is try to provide more properties for developer to set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6684) Add more property to Hive3ConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935856#comment-16935856 ] Peter Wicks commented on NIFI-6684: --- hi [~AxelSync], I have been discussing this issue outside of Jira with [~jamescheng]. We've had some issues getting the proper permissions in place to get it assigned. I've assigned it to myself in the short term until we figure out the permissions issue. I'll see if he can post an update, but I believe has completed the work. > Add more property to Hive3ConnectionPool > > > Key: NIFI-6684 > URL: https://issues.apache.org/jira/browse/NIFI-6684 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: jamescheng >Assignee: Peter Wicks >Priority: Minor > Attachments: PutHive3 enhance.png > > Time Spent: 10m > Remaining Estimate: 0h > > The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them > are using DBCP BasicDataSource. However, Hive3ConnectionPool doesn't provide > some properties of what DBCPConnectionPool has. Such as "Minimum Idle > Connections", "Max Idle Connections", "Max Connection Lifetime", "Time > Between Eviction Runs", "Minimum Evictable Idle Time" and "Soft Minimum > Evictable Idle Time". > This improvement is try to provide more properties for developer to set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NIFI-6684) Add more property to Hive3ConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Wicks reassigned NIFI-6684: - Assignee: Peter Wicks > Add more property to Hive3ConnectionPool > > > Key: NIFI-6684 > URL: https://issues.apache.org/jira/browse/NIFI-6684 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: jamescheng >Assignee: Peter Wicks >Priority: Minor > Attachments: PutHive3 enhance.png > > Time Spent: 10m > Remaining Estimate: 0h > > The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them > are using DBCP BasicDataSource. However, Hive3ConnectionPool doesn't provide > some properties of what DBCPConnectionPool has. Such as "Minimum Idle > Connections", "Max Idle Connections", "Max Connection Lifetime", "Time > Between Eviction Runs", "Minimum Evictable Idle Time" and "Soft Minimum > Evictable Idle Time". > This improvement is try to provide more properties for developer to set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-standard-libraries] ottobackwards commented on issue #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE
ottobackwards commented on issue #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE URL: https://github.com/apache/nifi-standard-libraries/pull/1#issuecomment-534099629 +1, thanks @bbende! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-standard-libraries] bbende commented on issue #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE
bbende commented on issue #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE URL: https://github.com/apache/nifi-standard-libraries/pull/1#issuecomment-534097718 @kevdoran @ottobackwards thanks for taking a look, pushed another commit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-standard-libraries] bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE
bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom,
README, LICENSE, & NOTICE
URL:
https://github.com/apache/nifi-standard-libraries/pull/1#discussion_r327108535
##
File path: pom.xml
##
@@ -0,0 +1,521 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache
+apache
+19
+
+
+
+org.apache.nifi.stdlibs
+nifi-standard-libraries
+0.1.0-SNAPSHOT
+pom
+
+NiFi Standard Libraries
+A collection of standard implementations used across the NiFi
ecosystem.
+
+
+
+
+
+https://nifi.apache.org
+
+
+Apache NiFi Project
+https://nifi.apache.org/
+
+
+
+
+Apache License, Version 2.0
+https://www.apache.org/licenses/LICENSE-2.0
+
+
+
+
+
+Dev
+dev-subscr...@nifi.apache.org
+dev-unsubscr...@nifi.apache.org
+d...@nifi.apache.org
+
https://mail-archives.apache.org/mod_mbox/nifi-dev
+
+
+Users
+users-subscr...@nifi.apache.org
+users-unsubscr...@nifi.apache.org
+us...@nifi.apache.org
+
https://mail-archives.apache.org/mod_mbox/nifi-users
+
+
+Commits
+commits-subscr...@nifi.apache.org
+commits-unsubscr...@nifi.apache.org
+comm...@nifi.apache.org
+
https://mail-archives.apache.org/mod_mbox/nifi-commits
+
+
+
+
+
scm:git:git://git.apache.org/nifi-standard-libraries.git
+
scm:git:https://git-wip-us.apache.org/repos/asf/nifi-standard-libraries.git
+
https://git-wip-us.apache.org/repos/asf?p=nifi-standard-libraries.git
+HEAD
+
+
+
+JIRA
+https://issues.apache.org/jira/browse/NIFILIBS
+
+
+
+1.8
+1.8
+3.1.1
+
+UTF-8
+
UTF-8
+2019
+
+
+
+
+central
+
+Maven Repository
+https://repo1.maven.org/maven2
+
+true
+
+
+false
+
+
+
+apache-repo
+Apache Repository
+
https://repository.apache.org/content/repositories/releases
+
+true
+
+
+false
+
+
+
+jcenter
+https://jcenter.bintray.com
+
+false
+
+
+true
+
+
+
+
+
+
+jcenter-releases
+jcenter
+https://jcenter.bintray.com
+
+false
+
+
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.2
+
+true
+true
+true
+true
+
+
+
+ org.apache.maven.plugins
+maven-surefire-plugin
+2.18
+
+
+true
+
+
+**/*Test.class
+**/Test*.class
+**/*Spec.class
+
+
true
+-Xmx1G
-Djava.net.preferIPv4Stack=true
+${maven.surefire.arguments}
+
+
+
+
+
+org.apache.maven.surefire
+surefire-junit4
+2.18
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+2.18
+
+
+org.apache.maven.plugins
+maven-source-plugin
+2.4
+
+
+org.apache.maven.plugins
+maven-site-plugin
+3.4
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.5
+
+
+org.apache.maven.plugins
+maven-javadoc-plugin
+3.1.1
[GitHub] [nifi-standard-libraries] bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE
bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE URL: https://github.com/apache/nifi-standard-libraries/pull/1#discussion_r327108652 ## File path: pom.xml ## @@ -0,0 +1,521 @@ + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> +4.0.0 + + +org.apache +apache +19 Review comment: No reason, just took 19 b/c that is what NiFi had, will update This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-standard-libraries] bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE
bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE URL: https://github.com/apache/nifi-standard-libraries/pull/1#discussion_r327108447 ## File path: pom.xml ## @@ -0,0 +1,521 @@ + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> +4.0.0 + + +org.apache +apache +19 + + + +org.apache.nifi.stdlibs +nifi-standard-libraries +0.1.0-SNAPSHOT +pom + +NiFi Standard Libraries +A collection of standard implementations used across the NiFi ecosystem. + + + + + +https://nifi.apache.org + + +Apache NiFi Project +https://nifi.apache.org/ + + + + +Apache License, Version 2.0 +https://www.apache.org/licenses/LICENSE-2.0 + + + + + +Dev +dev-subscr...@nifi.apache.org +dev-unsubscr...@nifi.apache.org +d...@nifi.apache.org + https://mail-archives.apache.org/mod_mbox/nifi-dev + + +Users +users-subscr...@nifi.apache.org +users-unsubscr...@nifi.apache.org +us...@nifi.apache.org + https://mail-archives.apache.org/mod_mbox/nifi-users + + +Commits +commits-subscr...@nifi.apache.org +commits-unsubscr...@nifi.apache.org +comm...@nifi.apache.org + https://mail-archives.apache.org/mod_mbox/nifi-commits + + + Review comment: I think they are all valid now, but I'll switch to gitbox This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-standard-libraries] bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE
bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE URL: https://github.com/apache/nifi-standard-libraries/pull/1#discussion_r327108203 ## File path: README.md ## @@ -1 +1,59 @@ + # Apache NiFi Standard Libraries + +A collection of standard implementations used across the NiFi ecosystem. + +## Table of Contents + +- [Getting Started](#getting-started) +- [License](#license) + +## Getting Started + +### Requirements + Review comment: Will update This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-standard-libraries] bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE
bbende commented on a change in pull request #1: NIFILIBS-1 Setup root pom, README, LICENSE, & NOTICE URL: https://github.com/apache/nifi-standard-libraries/pull/1#discussion_r327108275 ## File path: README.md ## @@ -1 +1,59 @@ + # Apache NiFi Standard Libraries + +A collection of standard implementations used across the NiFi ecosystem. + +## Table of Contents + +- [Getting Started](#getting-started) +- [License](#license) + +## Getting Started + +### Requirements + +* Java 1.8 +* Maven 3.1.0, or newer +* Recent git client + +### Building + +1) Clone the repo + Review comment: Will update This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3716: Adding infinispan processor
MikeThomsen commented on a change in pull request #3716: Adding infinispan
processor
URL: https://github.com/apache/nifi/pull/3716#discussion_r327097502
##
File path:
nifi-nar-bundles/nifi-infinispan-bundle/nifi-putInInfinispanCache-processors/src/main/java/com/nifi/infinispancache/processors/getFromInfinispanCache/GetFromInfinispanCache.java
##
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.nifi.infinispancache.processors.getFromInfinispanCache;
+
+import org.apache.nifi.annotation.behavior.*;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.AttributeExpression;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.*;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.io.OutputStreamCallback;
+import org.apache.nifi.processor.util.FlowFileFilters;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.infinispan.client.hotrod.RemoteCache;
+import org.infinispan.client.hotrod.RemoteCacheManager;
+import org.infinispan.client.hotrod.configuration.ConfigurationBuilder;
+import org.infinispan.client.hotrod.configuration.ServerConfigurationBuilder;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@SupportsBatching
+@Tags({"Infinispan", "Cache", "Get"})
+@CapabilityDescription("Get value from Infinispan cache")
+@ReadsAttributes({@ReadsAttribute(attribute = "", description = "")})
+@WritesAttributes({@WritesAttribute(attribute = "", description = "")})
+@DynamicProperty(name = "Infinispan host property.", value = "Infinispan Port
configuration property.",
+description = "These properties will be added on the Infinispan
configuration after loading any provided configuration properties."
++ " In the event a dynamic property represents a property that
was already set, its value will be ignored and WARN message logged.",
+expressionLanguageScope = ExpressionLanguageScope.VARIABLE_REGISTRY)
+public class GetFromInfinispanCache extends AbstractProcessor {
+
+public static final PropertyDescriptor INFINISPAN_HOST = new
PropertyDescriptor.Builder()
+.name("Infinispan Host")
+.description("Infinispan Host")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor INFINISPAN_PORT = new
PropertyDescriptor.Builder()
+.name("Infinispan Port")
+.description("Infinispan Port")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor CACHE_NAME = new
PropertyDescriptor.Builder()
+.name("Cache Name")
+.description("Cache Name")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor CACHE_KEY = new
PropertyDescriptor.Builder()
+.name("Cache Key")
+.description("Cache Key")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+.build();
+
+public static final PropertyDescriptor PROP_PUT_CACHE_VALUE_IN_ATTRIBUTE =
new PropertyDescriptor.Builder()
+.name("Put Cache Value In
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3716: Adding infinispan processor
MikeThomsen commented on a change in pull request #3716: Adding infinispan
processor
URL: https://github.com/apache/nifi/pull/3716#discussion_r327097903
##
File path:
nifi-nar-bundles/nifi-infinispan-bundle/nifi-putInInfinispanCache-processors/src/main/java/com/nifi/infinispancache/processors/getFromInfinispanCache/GetFromInfinispanCache.java
##
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.nifi.infinispancache.processors.getFromInfinispanCache;
+
+import org.apache.nifi.annotation.behavior.*;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.AttributeExpression;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.*;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.io.OutputStreamCallback;
+import org.apache.nifi.processor.util.FlowFileFilters;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.infinispan.client.hotrod.RemoteCache;
+import org.infinispan.client.hotrod.RemoteCacheManager;
+import org.infinispan.client.hotrod.configuration.ConfigurationBuilder;
+import org.infinispan.client.hotrod.configuration.ServerConfigurationBuilder;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@SupportsBatching
+@Tags({"Infinispan", "Cache", "Get"})
+@CapabilityDescription("Get value from Infinispan cache")
+@ReadsAttributes({@ReadsAttribute(attribute = "", description = "")})
+@WritesAttributes({@WritesAttribute(attribute = "", description = "")})
+@DynamicProperty(name = "Infinispan host property.", value = "Infinispan Port
configuration property.",
+description = "These properties will be added on the Infinispan
configuration after loading any provided configuration properties."
++ " In the event a dynamic property represents a property that
was already set, its value will be ignored and WARN message logged.",
+expressionLanguageScope = ExpressionLanguageScope.VARIABLE_REGISTRY)
+public class GetFromInfinispanCache extends AbstractProcessor {
+
+public static final PropertyDescriptor INFINISPAN_HOST = new
PropertyDescriptor.Builder()
+.name("Infinispan Host")
+.description("Infinispan Host")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor INFINISPAN_PORT = new
PropertyDescriptor.Builder()
+.name("Infinispan Port")
+.description("Infinispan Port")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor CACHE_NAME = new
PropertyDescriptor.Builder()
+.name("Cache Name")
+.description("Cache Name")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor CACHE_KEY = new
PropertyDescriptor.Builder()
+.name("Cache Key")
+.description("Cache Key")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+.build();
+
+public static final PropertyDescriptor PROP_PUT_CACHE_VALUE_IN_ATTRIBUTE =
new PropertyDescriptor.Builder()
+.name("Put Cache Value In
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3716: Adding infinispan processor
MikeThomsen commented on a change in pull request #3716: Adding infinispan processor URL: https://github.com/apache/nifi/pull/3716#discussion_r32707 ## File path: nifi-nar-bundles/nifi-infinispan-bundle/pom.xml ## @@ -0,0 +1,35 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-nar-bundles +1.9.2 + + +com.nifi.infinispancache +put-in-infinispan +1.0 Review comment: Also, your dependencies should be 1.10.0-SNAPSHOT. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3716: Adding infinispan processor
MikeThomsen commented on a change in pull request #3716: Adding infinispan processor URL: https://github.com/apache/nifi/pull/3716#discussion_r327099670 ## File path: nifi-nar-bundles/nifi-infinispan-bundle/pom.xml ## @@ -0,0 +1,35 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-nar-bundles +1.9.2 Review comment: Should be `1.10.0-SNAPSHOT` throughout the contribution since that's the latest version in master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3716: Adding infinispan processor
MikeThomsen commented on a change in pull request #3716: Adding infinispan
processor
URL: https://github.com/apache/nifi/pull/3716#discussion_r327100183
##
File path:
nifi-nar-bundles/nifi-infinispan-bundle/nifi-putInInfinispanCache-processors/src/test/java/com/nifi/infinispancache/processors/putInInfinispanCache/PutInInfinispanCacheTest.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.nifi.infinispancache.processors.putInInfinispanCache;
+
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.Before;
+import org.junit.Test;
+
+
+public class PutInInfinispanCacheTest {
+
+private TestRunner testRunner;
+
+@Before
+public void init() {
+testRunner = TestRunners.newTestRunner(PutInInfinispanCache.class);
+}
+
+@Test
+public void testProcessor() {
Review comment:
Definitely going to need to flesh this out.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3716: Adding infinispan processor
MikeThomsen commented on a change in pull request #3716: Adding infinispan
processor
URL: https://github.com/apache/nifi/pull/3716#discussion_r327097007
##
File path:
nifi-nar-bundles/nifi-infinispan-bundle/nifi-putInInfinispanCache-processors/src/main/java/com/nifi/infinispancache/processors/getFromInfinispanCache/GetFromInfinispanCache.java
##
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.nifi.infinispancache.processors.getFromInfinispanCache;
+
+import org.apache.nifi.annotation.behavior.*;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.AttributeExpression;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.*;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.io.OutputStreamCallback;
+import org.apache.nifi.processor.util.FlowFileFilters;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.infinispan.client.hotrod.RemoteCache;
+import org.infinispan.client.hotrod.RemoteCacheManager;
+import org.infinispan.client.hotrod.configuration.ConfigurationBuilder;
+import org.infinispan.client.hotrod.configuration.ServerConfigurationBuilder;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@SupportsBatching
+@Tags({"Infinispan", "Cache", "Get"})
+@CapabilityDescription("Get value from Infinispan cache")
+@ReadsAttributes({@ReadsAttribute(attribute = "", description = "")})
+@WritesAttributes({@WritesAttribute(attribute = "", description = "")})
+@DynamicProperty(name = "Infinispan host property.", value = "Infinispan Port
configuration property.",
+description = "These properties will be added on the Infinispan
configuration after loading any provided configuration properties."
++ " In the event a dynamic property represents a property that
was already set, its value will be ignored and WARN message logged.",
+expressionLanguageScope = ExpressionLanguageScope.VARIABLE_REGISTRY)
+public class GetFromInfinispanCache extends AbstractProcessor {
+
+public static final PropertyDescriptor INFINISPAN_HOST = new
PropertyDescriptor.Builder()
+.name("Infinispan Host")
+.description("Infinispan Host")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor INFINISPAN_PORT = new
PropertyDescriptor.Builder()
+.name("Infinispan Port")
+.description("Infinispan Port")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor CACHE_NAME = new
PropertyDescriptor.Builder()
+.name("Cache Name")
+.description("Cache Name")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor CACHE_KEY = new
PropertyDescriptor.Builder()
+.name("Cache Key")
+.description("Cache Key")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+.build();
+
+public static final PropertyDescriptor PROP_PUT_CACHE_VALUE_IN_ATTRIBUTE =
new PropertyDescriptor.Builder()
+.name("Put Cache Value In
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3716: Adding infinispan processor
MikeThomsen commented on a change in pull request #3716: Adding infinispan
processor
URL: https://github.com/apache/nifi/pull/3716#discussion_r327099321
##
File path:
nifi-nar-bundles/nifi-infinispan-bundle/nifi-putInInfinispanCache-processors/src/main/java/com/nifi/infinispancache/processors/putInInfinispanCache/PutInInfinispanCache.java
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.nifi.infinispancache.processors.putInInfinispanCache;
+
+import org.apache.nifi.annotation.behavior.*;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.AttributeExpression;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.*;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.FlowFileFilters;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.infinispan.client.hotrod.RemoteCache;
+import org.infinispan.client.hotrod.RemoteCacheManager;
+import org.infinispan.client.hotrod.configuration.ConfigurationBuilder;
+import org.infinispan.client.hotrod.configuration.ServerConfigurationBuilder;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@SupportsBatching
+@Tags({"Infinispan", "Cache", "Put"})
+@CapabilityDescription("Puts key-value in Infinispan cache")
+@ReadsAttributes({@ReadsAttribute(attribute = "", description = "")})
+@WritesAttributes({@WritesAttribute(attribute = "", description = "")})
+@DynamicProperty(name = "Infinispan host property.", value = "Infinispan Port
configuration property.",
+description = "These properties will be added on the Infinispan
configuration after loading any provided configuration properties."
++ " In the event a dynamic property represents a property that
was already set, its value will be ignored and WARN message logged.",
+expressionLanguageScope = ExpressionLanguageScope.VARIABLE_REGISTRY)
+public class PutInInfinispanCache extends AbstractProcessor {
+
+public static final PropertyDescriptor INFINISPAN_HOST = new
PropertyDescriptor.Builder()
+.name("Infinispan Host")
+.description("Infinispan Host")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor INFINISPAN_PORT = new
PropertyDescriptor.Builder()
+.name("Infinispan Port")
+.description("Infinispan Port")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor CACHE_NAME = new
PropertyDescriptor.Builder()
+.name("Cache Name")
+.description("Cache Name")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor CACHE_KEY = new
PropertyDescriptor.Builder()
+.name("Cache Key")
+.description("Cache Key")
+.required(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+.build();
+
+public static final PropertyDescriptor CACHE_VALUE = new
PropertyDescriptor.Builder()
+.name("Cache Value")
+.description("Cache Value")
+.required(true)
+
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3716: Adding infinispan processor
MikeThomsen commented on a change in pull request #3716: Adding infinispan processor URL: https://github.com/apache/nifi/pull/3716#discussion_r327095986 ## File path: nifi-nar-bundles/nifi-infinispan-bundle/nifi-putInInfinispanCache-processors/src/main/java/com/nifi/infinispancache/processors/getFromInfinispanCache/GetFromInfinispanCache.java ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.nifi.infinispancache.processors.getFromInfinispanCache; Review comment: This should be `org.apache.nifi.processor.infinispancache`. We use `org.apache.nifi`, not `com.nifi` and we need to avoid mixing namespaces like that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6698) HandleHttpRequest does not handle multiple URL parameters
[ https://issues.apache.org/jira/browse/NIFI-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935819#comment-16935819 ] Patrick Laneville commented on NIFI-6698: - Hi Alessandro, My apologies. I retested and found that it works exactly as you described. It was a problem with the way that I was testing. I was using curl from the command line and the shell was truncating the command when it reached the "&" character. I put double quotes around the URL in my shell command and found that multiple parameters are handled properly when separated by "&". However, I agree that the parameters are not handled properly when using URL encoding. Thanks, Patrick > HandleHttpRequest does not handle multiple URL parameters > - > > Key: NIFI-6698 > URL: https://issues.apache.org/jira/browse/NIFI-6698 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework >Affects Versions: 1.9.2 > Environment: CentOS >Reporter: Patrick Laneville >Priority: Minor > Attachments: image-2019-09-22-15-19-18-523.png, > image-2019-09-22-15-22-44-053.png > > > The http.query.string parameter is updated. However, it is only updated > properly when the URL contains a single parameter. Additional parameters are > truncated when separated by an "&" in the URL. > > Example > Attempt a GET on the following resource: > [http://myserver.com/resource?name=ferret=purple:] > Result is the http.query.string attribute in the outgoing flow file is set to > "name=ferret". The problem is the http.query.string should be set to > "name=ferret=purple" > However, if you use URL encoding (encode & as %26) and specify > [http://myserver.com/resource?name=ferret%26color=purple|http://myserver.com/resource?name=ferret=purple:] > then then http.query.string attribute in the outgoing flow file is set > properly to "name=ferret=purple" > However, with the URL encoding work-around the attribute > http.query.param.name is incorrectly set to "ferret=purple" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] phrocker edited a comment on issue #649: MINIFICPP-1024 - Fix third party dependencies
phrocker edited a comment on issue #649: MINIFICPP-1024 - Fix third party dependencies URL: https://github.com/apache/nifi-minifi-cpp/pull/649#issuecomment-534082048 > @arpadboda @phrocker I have created a fresh build on Windows and tested PublishKafka with a simple GenerateFlowFile -> PublishKafka flow with a Kafka instance running on the same Windows machine, and it works fine for me. @arpadboda second party validation doesn't hurt. I'll probably be able to get to this later this afternoon ( my time ). if you have a chance to validate sooner let me know. Though also good with a merge and fix any issue that could possibly arise, later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on issue #649: MINIFICPP-1024 - Fix third party dependencies
phrocker commented on issue #649: MINIFICPP-1024 - Fix third party dependencies URL: https://github.com/apache/nifi-minifi-cpp/pull/649#issuecomment-534082048 > @arpadboda @phrocker I have created a fresh build on Windows and tested PublishKafka with a simple GenerateFlowFile -> PublishKafka flow with a Kafka instance running on the same Windows machine, and it works fine for me. @arpadboda second party validation doesn't hurt. I'll probably be able to get to this later this afternoon ( my time ). if you have a chance to validate sooner let me know. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid commented on issue #649: MINIFICPP-1024 - Fix third party dependencies
bakaid commented on issue #649: MINIFICPP-1024 - Fix third party dependencies URL: https://github.com/apache/nifi-minifi-cpp/pull/649#issuecomment-534081560 @arpadboda @phrocker I have created a fresh build on Windows and tested PublishKafka with a simple GenerateFlowFile -> PublishKafka flow with a Kafka instance running on the same Windows machine, and it works fine for me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6520) Upgrade to latest Apache Tika 1.22
[ https://issues.apache.org/jira/browse/NIFI-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935794#comment-16935794 ] ASF subversion and git services commented on NIFI-6520: --- Commit 6d8968cc87668c30e46a9d3a0a49a790ad32a936 in nifi's branch refs/heads/master from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6d8968c ] NIFI-6520 update to tika 1.22 This closes #3756 Signed-off-by: Mike Thomsen > Upgrade to latest Apache Tika 1.22 > -- > > Key: NIFI-6520 > URL: https://issues.apache.org/jira/browse/NIFI-6520 > Project: Apache NiFi > Issue Type: Task >Reporter: Joseph Witt >Assignee: Joseph Witt >Priority: Major > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > > [CVE-2019-10088] OOM from a crafted Zip File in Apache Tika's > RecursiveParserWrapper > [CVE-2019-10093] Denial of Service in Apache Tika's 2003ml and 2006ml Parsers > [CVE-2019-10094] StackOverflow from Crafted Package/Compressed Files in > Apache Tika's RecursiveParserWrapper > Not really a blocker but upgrading is generally extremely easy and we should > knock it out. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3756: NIFI-6520 update to tika 1.22
asfgit closed pull request #3756: NIFI-6520 update to tika 1.22 URL: https://github.com/apache/nifi/pull/3756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] arenger edited a comment on issue #3455: NIFI-5900 Add SelectJson processor
arenger edited a comment on issue #3455: NIFI-5900 Add SelectJson processor URL: https://github.com/apache/nifi/pull/3455#issuecomment-534040805 @ottobackwards Yeah I agree that this PR would probably have less maintenance burden. That's why I closed PR #3414 a few months ago. I would be happy to merge or to close this PR. I'd prefer the former but just want to go one way or another. In my opinion, both this PR and PR #3222 should be merged. This would allow for streaming json processing from either a record-based processing model or the "traditional"/original processing model. I think #3222 and this PR complement one another, but they're not dependent on each other. I did not submit PR #3222 and it is apparently closed. I submitted PR #3414 but I closed that one in favor of this one. Therefore, I think this PR should be merged and @MikeThomsen can decide separately whether he would like to resubmit his work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid commented on issue #649: MINIFICPP-1024 - Fix third party dependencies
bakaid commented on issue #649: MINIFICPP-1024 - Fix third party dependencies URL: https://github.com/apache/nifi-minifi-cpp/pull/649#issuecomment-534063768 > > > Looks good. I'll run some tests across platforms with various builds enabling and disabling features before merging. thanks! > > > > > > Thanks, let me know if anything fails. This is a less complete fix than MINIFICPP-1022 will be, but it should make the builds running properly again. > > That's a good point. I had a failure on Windows but cleaned out my workspace and am working on another task. I'm good to merge this with a +1 since I haven't had time to re-validate the failure wasn't something in a polluted workspace. If you and @arpadboda already attempted to build and deploy flows w/ PublishKafka on Windows and other platforms I'm good to merge. @phrocker I haven't tested PublishKadka under Windows, I'll do it now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on issue #649: MINIFICPP-1024 - Fix third party dependencies
phrocker commented on issue #649: MINIFICPP-1024 - Fix third party dependencies URL: https://github.com/apache/nifi-minifi-cpp/pull/649#issuecomment-534062835 > > Looks good. I'll run some tests across platforms with various builds enabling and disabling features before merging. thanks! > > Thanks, let me know if anything fails. This is a less complete fix than MINIFICPP-1022 will be, but it should make the builds running properly again. That's a good point. I had a failure on Windows but cleaned out my workspace and am working on another task. I'm good to merge this with a +1 since I haven't had time to re-validate the failure wasn't something in a polluted workspace. If you and @arpadboda already attempted to build and deploy flows w/ PublishKafka on Windows and other platforms I'm good to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-3096) Issues with NTLM authentication in GetHttp and InvokeHttp processors
[ https://issues.apache.org/jira/browse/NIFI-3096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935768#comment-16935768 ] Ryan Womer commented on NIFI-3096: -- NTLM implemented in a custom processor located at: https://github.com/simonellistonball/nifi-webdav-bundle > Issues with NTLM authentication in GetHttp and InvokeHttp processors > > > Key: NIFI-3096 > URL: https://issues.apache.org/jira/browse/NIFI-3096 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Michael Kalika >Assignee: Karthik Narayanan >Priority: Major > > GetHttp and InvokeHttp do not support HTTP endpoints protected with NTLM > authentication. This functionality is needed for working with services and > APIs hosted in Windows systems. > Here's a log with error: > 2016-11-23 17:45:22,272 WARN [Timer-Driven Process Thread-7] > o.a.http.impl.auth.HttpAuthenticator NEGOTIATE authentication error: No valid > credentials provided (Mechanism level: No valid credentials provided > (Mechanism > level: Failed to find any Kerberos tgt)) > 2016-11-23 17:45:22,272 WARN [Timer-Driven Process Thread-7] > o.a.http.impl.auth.HttpAuthenticator NTLM authentication error: Credentials > cannot be used for NTLM authentication: > org.apache.http.auth.UsernamePasswordCredentials > 2016-11-23 17:45:22,274 ERROR [Timer-Driven Process > Thread-7] o.a.nifi.processors.standard.GetHTTP > GetHTTP[id=91ce7dfd-0158-1000-1c53-cf24cf132983] received status code > 401:Unauthorized from http://internal.api.ep/dosomething > and a discussion about this issue > https://community.hortonworks.com/questions/68097/issues-with-gethttp-and-ntlm-authentication-in-nif.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] ottobackwards commented on issue #3455: NIFI-5900 Add SelectJson processor
ottobackwards commented on issue #3455: NIFI-5900 Add SelectJson processor URL: https://github.com/apache/nifi/pull/3455#issuecomment-534050870 +1 from me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] arenger edited a comment on issue #3455: NIFI-5900 Add SelectJson processor
arenger edited a comment on issue #3455: NIFI-5900 Add SelectJson processor URL: https://github.com/apache/nifi/pull/3455#issuecomment-534040805 @ottobackwards Yeah I agree that this PR would probably have less maintenance burden. That's why I closed PR #3414 a few months ago. I would be happy to merge or to close this PR. I'd prefer the former but just want to go one way or another. In my opinion, both this PR and PR #3222 should be merged. This would allow for streaming json processing from either a record-based processing model or the "traditional"/original processing model. I think #3222 and this PR complement one another, but they're not dependent on each other. I did not submit PR #3222 and it is apparently closed. I submitted PR #3414 but I close that one in favor of this one. Therefore, I think this PR should be merged and @MikeThomsen can decide separately whether he would like to resubmit his work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] arenger commented on issue #3455: NIFI-5900 Add SelectJson processor
arenger commented on issue #3455: NIFI-5900 Add SelectJson processor URL: https://github.com/apache/nifi/pull/3455#issuecomment-534040805 @ottobackwards Yeah I agree that this PR would probably have less maintenance burden. That's why I closed PR #3414 a few months ago. I would be happy to merge or to close this PR. I'd prefer the former but just want to go one way or another. In my opinion, both this PR and PR #3222 should be merged. This would allow for streaming json processing from either a record-based processing model or the "traditional"/original processing model. I think #3222 and this PR complement one another, but they're not dependent on each other. I did not submit PR #3222 and it is apparently closed. I submitted PR #3414 but I closed that one in favor of this one. Therefore, I think this PR should be merged and @MikeThomsen can decide separately whether he would like to resubmit his work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
