[GitHub] [nifi] gresockj opened a new pull request #5703: NIFI-9620: Adding isStateful to StatelessDataflow
gresockj opened a new pull request #5703:
URL: https://github.com/apache/nifi/pull/5703
Description of PR
Adds a new method to `StatelessDataflow` called `isStateful`. This allows
the calling code to detect whether the dataflow contains any processors that
maintain state.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-9618) Upgrade Checkstyle to 9.2.1
[
https://issues.apache.org/jira/browse/NIFI-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-9618:
---
Fix Version/s: 1.16.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Upgrade Checkstyle to 9.2.1
> ---
>
> Key: NIFI-9618
> URL: https://issues.apache.org/jira/browse/NIFI-9618
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Affects Versions: 1.16.0
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.16.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Following recent updates to the maven-checkstyle-plugin version, the plugin
> now reports the following warnings:
> {noformat}
> Warning: Old version of checkstyle detected. Consider updating to >= v8.30
> Warning: For more information see:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
> {noformat}
> Upgrading to the latest version of the checkstyle library will eliminate this
> warning.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (NIFI-9618) Upgrade Checkstyle to 9.2.1
[
https://issues.apache.org/jira/browse/NIFI-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480324#comment-17480324
]
ASF subversion and git services commented on NIFI-9618:
---
Commit e2243500d3c878fbb33b8f642462a7b29c441fa3 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e224350 ]
NIFI-9618 Upgraded Checkstyle to 9.2.1
- Corrected several missing return statements
- Increased Maven heap size to 3 GB for ci-workflow
This closes #5700
Signed-off-by: David Handermann
> Upgrade Checkstyle to 9.2.1
> ---
>
> Key: NIFI-9618
> URL: https://issues.apache.org/jira/browse/NIFI-9618
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Affects Versions: 1.16.0
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Following recent updates to the maven-checkstyle-plugin version, the plugin
> now reports the following warnings:
> {noformat}
> Warning: Old version of checkstyle detected. Consider updating to >= v8.30
> Warning: For more information see:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
> {noformat}
> Upgrading to the latest version of the checkstyle library will eliminate this
> warning.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi] asfgit closed pull request #5700: NIFI-9618 Upgrade Checkstyle to 9.2.1
asfgit closed pull request #5700: URL: https://github.com/apache/nifi/pull/5700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-9620) Add isStateful() method to Stateless DataFlow API
Joe Gresock created NIFI-9620: - Summary: Add isStateful() method to Stateless DataFlow API Key: NIFI-9620 URL: https://issues.apache.org/jira/browse/NIFI-9620 Project: Apache NiFi Issue Type: Improvement Components: NiFi Stateless Reporter: Joe Gresock Stateless NiFi's DataFlow interface could have a isStateful() method, which returns true if any processors in the flow maintain state (by checking for the presence of the @Stateful annotation). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (NIFI-9619) Remove GPG key from Security Disclosure details
[ https://issues.apache.org/jira/browse/NIFI-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9619: --- Fix Version/s: 1.16.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Remove GPG key from Security Disclosure details > --- > > Key: NIFI-9619 > URL: https://issues.apache.org/jira/browse/NIFI-9619 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Trivial > Fix For: 1.16.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The Security Vulnerability Disclosure instructions reference a GPG key > fingerprint for secur...@nifi.apache.org as an option for reporting sensitive > information. The public key associated with the fingerprint expired on > 2021-03-23. The difficulty of sharing a GPG private key with all members of > the PMC outweighs the potential benefit of supporting this method of > vulnerability reporting. For these reasons, the GPG key fingerprint should be > removed from the Security Vulnerability Disclosure instructions. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi-site] exceptionfactory merged pull request #55: NIFI-9619 Remove GPG key from Security Mailing List reporting
exceptionfactory merged pull request #55: URL: https://github.com/apache/nifi-site/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9619) Remove GPG key from Security Disclosure details
[ https://issues.apache.org/jira/browse/NIFI-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480274#comment-17480274 ] ASF subversion and git services commented on NIFI-9619: --- Commit 3d05844b713142851584d4990da2828c81cc1cfa in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3d05844 ] NIFI-9619 Removed GPG key from Security Mailing List reporting This closes #5702 Signed-off-by: David Handermann > Remove GPG key from Security Disclosure details > --- > > Key: NIFI-9619 > URL: https://issues.apache.org/jira/browse/NIFI-9619 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Trivial > Time Spent: 50m > Remaining Estimate: 0h > > The Security Vulnerability Disclosure instructions reference a GPG key > fingerprint for secur...@nifi.apache.org as an option for reporting sensitive > information. The public key associated with the fingerprint expired on > 2021-03-23. The difficulty of sharing a GPG private key with all members of > the PMC outweighs the potential benefit of supporting this method of > vulnerability reporting. For these reasons, the GPG key fingerprint should be > removed from the Security Vulnerability Disclosure instructions. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] exceptionfactory closed pull request #5702: NIFI-9619 Remove GPG key from Security Mailing List reporting
exceptionfactory closed pull request #5702: URL: https://github.com/apache/nifi/pull/5702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-site] joewitt commented on pull request #55: NIFI-9619 Remove GPG key from Security Mailing List reporting
joewitt commented on pull request #55: URL: https://github.com/apache/nifi-site/pull/55#issuecomment-1018902469 +1 from me. Feel free to merge. Generally speaking we dont tend to do RTC on nifi-site changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #5702: NIFI-9619 Remove GPG key from Security Mailing List reporting
exceptionfactory commented on pull request #5702: URL: https://github.com/apache/nifi/pull/5702#issuecomment-1018902348 Thanks @joewitt! Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-site] exceptionfactory opened a new pull request #55: NIFI-9619 Remove GPG key from Security Mailing List reporting
exceptionfactory opened a new pull request #55: URL: https://github.com/apache/nifi-site/pull/55 NIFI-9619 Updates the NiFi and NiFi Registry Security pages to remove references to the expired GPG key fingerprint for vulnerability disclosures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9619) Remove GPG key from Security Disclosure details
[ https://issues.apache.org/jira/browse/NIFI-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9619: --- Status: Patch Available (was: In Progress) > Remove GPG key from Security Disclosure details > --- > > Key: NIFI-9619 > URL: https://issues.apache.org/jira/browse/NIFI-9619 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Trivial > Time Spent: 10m > Remaining Estimate: 0h > > The Security Vulnerability Disclosure instructions reference a GPG key > fingerprint for secur...@nifi.apache.org as an option for reporting sensitive > information. The public key associated with the fingerprint expired on > 2021-03-23. The difficulty of sharing a GPG private key with all members of > the PMC outweighs the potential benefit of supporting this method of > vulnerability reporting. For these reasons, the GPG key fingerprint should be > removed from the Security Vulnerability Disclosure instructions. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] joewitt commented on pull request #5702: NIFI-9619 Remove GPG key from Security Mailing List reporting
joewitt commented on pull request #5702: URL: https://github.com/apache/nifi/pull/5702#issuecomment-1018898870 +1 please self merge thanks for updating this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory opened a new pull request #5702: NIFI-9619 Remove GPG key from Security Mailing List reporting
exceptionfactory opened a new pull request #5702:
URL: https://github.com/apache/nifi/pull/5702
Description of PR
NIFI-9619 Removes the expired GPG key fingerprint from the Security
Vulnerability Disclosure documentation. The difficulty of securely sharing a
GPG private key among members of the Project Management Committee outweighs the
benefit of supporting encrypted disclosure messages, so the most
straightforward change is to remove the expired GPG key fingerprint and
simplify the reporting instructions.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-9607) PutDatabaseRecord doesn't honor Update Keys when Quote Identifiers is true
[ https://issues.apache.org/jira/browse/NIFI-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-9607: --- Status: Patch Available (was: In Progress) > PutDatabaseRecord doesn't honor Update Keys when Quote Identifiers is true > -- > > Key: NIFI-9607 > URL: https://issues.apache.org/jira/browse/NIFI-9607 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When using the Update Keys property of PutDatabaseTable, if Quote Identifiers > is set then invalid SQL (i.e empty WHERE clause) is generated so a failure > occurs. This combination should work as expected. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] mattyb149 opened a new pull request #5701: NIFI-9607: Honor Update Keys when Quoting Identifiers in PutDatabaseRecord
mattyb149 opened a new pull request #5701:
URL: https://github.com/apache/nifi/pull/5701
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Update Keys weren't being used when Quoted Identifiers were set. Refactored
and added unit test.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-9619) Remove GPG key from Security Disclosure details
David Handermann created NIFI-9619: -- Summary: Remove GPG key from Security Disclosure details Key: NIFI-9619 URL: https://issues.apache.org/jira/browse/NIFI-9619 Project: Apache NiFi Issue Type: Improvement Components: Documentation Website Reporter: David Handermann Assignee: David Handermann The Security Vulnerability Disclosure instructions reference a GPG key fingerprint for secur...@nifi.apache.org as an option for reporting sensitive information. The public key associated with the fingerprint expired on 2021-03-23. The difficulty of sharing a GPG private key with all members of the PMC outweighs the potential benefit of supporting this method of vulnerability reporting. For these reasons, the GPG key fingerprint should be removed from the Security Vulnerability Disclosure instructions. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (NIFI-9607) PutDatabaseRecord doesn't honor Update Keys when Quote Identifiers is true
[ https://issues.apache.org/jira/browse/NIFI-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-9607: -- Assignee: Matt Burgess > PutDatabaseRecord doesn't honor Update Keys when Quote Identifiers is true > -- > > Key: NIFI-9607 > URL: https://issues.apache.org/jira/browse/NIFI-9607 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > When using the Update Keys property of PutDatabaseTable, if Quote Identifiers > is set then invalid SQL (i.e empty WHERE clause) is generated so a failure > occurs. This combination should work as expected. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] exceptionfactory commented on pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
exceptionfactory commented on pull request #5668: URL: https://github.com/apache/nifi/pull/5668#issuecomment-1018886341 Thanks @bbende, if there is an opportunity to cut down the number of test cases and corresponding properties files, that would be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
bbende commented on pull request #5668: URL: https://github.com/apache/nifi/pull/5668#issuecomment-1018885544 @exceptionfactory thanks for taking a look... as part of splitting apart the properties and properties loader, there was also a test class for properties loader that used several of these files. At the time I was mostly trying to get the tests passing and just duplicated the resources, so we can probably narrow it down a little bit, a bunch of them are used though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-9501) Add REST end-point to retrieve RuntimeManifest
[ https://issues.apache.org/jira/browse/NIFI-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-9501. Fix Version/s: 1.16.0 Resolution: Fixed > Add REST end-point to retrieve RuntimeManifest > -- > > Key: NIFI-9501 > URL: https://issues.apache.org/jira/browse/NIFI-9501 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.16.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > In NIFI-9452, the build will produce an artifact containing a C2 > RuntimeManifest for the overall NiFi build. > We should also support retrieving this manifest from a running NiFi instance, > and should ensure that any NARs that are hot-loaded will also be included > (i.e. don't create a static manifest during start up). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (NIFI-9501) Add REST end-point to retrieve RuntimeManifest
[ https://issues.apache.org/jira/browse/NIFI-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480273#comment-17480273 ] ASF subversion and git services commented on NIFI-9501: --- Commit 6ef6e71d05d6f63a362b6195ce9bb9c652174293 in nifi's branch refs/heads/main from Bryan Bende [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6ef6e71 ] NIFI-9501 Added REST end-point to retrieve a RuntimeManifest - Switch ExtensionManifestParser implementation to use JAXB instead of Jackson XML - Fix handling of older NARs that don't have newer fields in ExtensionManifest - Add response merging for runtime-manifest REST end-point, remove commons-lang3 from c2 dependencies This closes #5630 Signed-off-by: David Handermann > Add REST end-point to retrieve RuntimeManifest > -- > > Key: NIFI-9501 > URL: https://issues.apache.org/jira/browse/NIFI-9501 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > In NIFI-9452, the build will produce an artifact containing a C2 > RuntimeManifest for the overall NiFi build. > We should also support retrieving this manifest from a running NiFi instance, > and should ensure that any NARs that are hot-loaded will also be included > (i.e. don't create a static manifest during start up). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] exceptionfactory closed pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
exceptionfactory closed pull request #5630: URL: https://github.com/apache/nifi/pull/5630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9527) nifi-hive-nar fails to load because of the old snappy-java jar
[
https://issues.apache.org/jira/browse/NIFI-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480272#comment-17480272
]
Saurabh B commented on NIFI-9527:
-
This issue is not observed on upgrade 1.14.0 -> 1.15.3. I did not try upgrade
to 1.15.2, let me know if you want me to try.
> nifi-hive-nar fails to load because of the old snappy-java jar
> --
>
> Key: NIFI-9527
> URL: https://issues.apache.org/jira/browse/NIFI-9527
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.15.0, 1.15.2
> Environment: Linux 3.10.0-1160.49.1.el7.x86_64 #1 SMP Tue Nov 9
> 16:09:48 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Saurabh B
>Priority: Minor
>
> nifi-hive-nar has old version of snappy-java jar (snappy-java-1.0.5.jar)
> which fails to load. New version of snappy-java-1.1.8.4.jar works.
>
> {{2022-01-03 12:11:19,126 ERROR [main] org.apache.nifi.NiFi Failure to launch
> NiFi}}
> {{org.xerial.snappy.SnappyError: [FAILED_TO_LOAD_NATIVE_LIBRARY] null}}
> {{ at org.xerial.snappy.SnappyLoader.load(SnappyLoader.java:239)}}
> {{ at org.xerial.snappy.Snappy.(Snappy.java:48)}}
> {{ at
> org.apache.nifi.processors.hive.PutHiveStreaming.(PutHiveStreaming.java:158)}}
> {{ at java.base/java.lang.Class.forName0(Native Method)}}
> {{ at java.base/java.lang.Class.forName(Class.java:398)}}
> {{ at
> org.apache.nifi.nar.StandardExtensionDiscoveringManager.getClass(StandardExtensionDiscoveringManager.java:330)}}
> {{ at
> org.apache.nifi.documentation.DocGenerator.documentConfigurableComponent(DocGenerator.java:100)}}
> {{ at
> org.apache.nifi.documentation.DocGenerator.generate(DocGenerator.java:65)}}
> {{ at
> org.apache.nifi.web.server.JettyServer.start(JettyServer.java:1139)}}
> {{ at org.apache.nifi.NiFi.(NiFi.java:170)}}
> {{ at org.apache.nifi.NiFi.(NiFi.java:82)}}
> {{ at org.apache.nifi.NiFi.main(NiFi.java:330)}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi] exceptionfactory commented on pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
exceptionfactory commented on pull request #5668: URL: https://github.com/apache/nifi/pull/5668#issuecomment-1018860318 Thanks for the improvement @bbende! The pull request appears to include a number of test properties files, are all of those necessary as part of this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] guimou commented on pull request #5684: NIFI-9605: Docker Images for OpenShift
guimou commented on pull request #5684: URL: https://github.com/apache/nifi/pull/5684#issuecomment-1018849385 Hi @dmnewber! The idea of creating the openshift folders alongside the docker/dockerhub ones (btw naming and structure is not really consistent for those) was to minimize coupling, in the sense that I did not want to "get in the way" (I was not even sure the project would be interested by this). In my idea, people would be able to build the images themselves, or we could have an external automated build process generating these specific/custom images without putting too much burden on the project. Having their definitions integrated into the NiFi code would make it easier to find them though, even if people had to build themselves. Now, if the project thinks it's a good idea and is keen to integrate those images, I could change the approach and extend the maven builds with openshift profiles that would source their files from the already existing docker/dockerhub folders, as well as from the openshift one, but that would then only contain its specific files. The thing I'm struggling with though is that the way the different images are built (nifi, registry, toolkit) is not really consistent (for registry for example it does not seem to be a maven build at all, whereas in nifi you find two different things, dockerhub and dockermaven...), so I'm not sure how I should do this... Another less intrusive option would be to simply add instructions/script in the parent folder and build directly from there. Like this, the build context would authorize to pick files from diffent subfolders and minimize duplication. This would also allow to provide only "recipes" for OpenShift, but not integrate the full build and have to determine where to put and how to name those images. I'm open to any suggestion, whatever is the simple for the project and the users! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-9557) Changing C2 OperandType to Enum with validation
[ https://issues.apache.org/jira/browse/NIFI-9557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess resolved NIFI-9557. Fix Version/s: 1.16.0 Resolution: Fixed > Changing C2 OperandType to Enum with validation > --- > > Key: NIFI-9557 > URL: https://issues.apache.org/jira/browse/NIFI-9557 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Csaba Bejan >Assignee: Csaba Bejan >Priority: Major > Fix For: 1.16.0 > > Time Spent: 1h > Remaining Estimate: 0h > > As OperationType and Operand is well defined and central in the [C2 > specification|https://cwiki.apache.org/confluence/display/MINIFI/C2+Design] > their values and valid mappings could be reflected in the API so we could > avoid invalid operation configurations on the protocol level. Similarly to > OperationType OperandType could be introduced and known mappings should be > defined. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (NIFI-7840) ExecuteScript - Groovy 3.0
[ https://issues.apache.org/jira/browse/NIFI-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7840: --- Issue Type: Improvement (was: Wish) > ExecuteScript - Groovy 3.0 > -- > > Key: NIFI-7840 > URL: https://issues.apache.org/jira/browse/NIFI-7840 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mermillod >Assignee: Matt Burgess >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Groovy 4.0 is in alpha, and Groovy 3.0 is out for long time, with features > like lambdas. > (ExecuteScript is using Groov 2.5.4) > New features : [https://groovy-lang.org/releasenotes/groovy-3.0.html] > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] mattyb149 closed pull request #5649: NIFI-9557: Change C2 OperandType to Enum
mattyb149 closed pull request #5649: URL: https://github.com/apache/nifi/pull/5649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5649: NIFI-9557: Change C2 OperandType to Enum
mattyb149 commented on pull request #5649: URL: https://github.com/apache/nifi/pull/5649#issuecomment-1018834071 +1 LGTM, thanks for the improvement! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #5699: NIFI-7840: Upgrade to Groovy 3.0.8 and Spock 2.1
exceptionfactory commented on pull request #5699: URL: https://github.com/apache/nifi/pull/5699#issuecomment-1018798954 Thanks for the upgrade @mattyb149! Unfortunately it looks like a couple Spock-based tests failed on the Windows build. Also recommend removing the test methods currently marked as ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9586) Investigate issues with Github Actions Build
[ https://issues.apache.org/jira/browse/NIFI-9586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480249#comment-17480249 ] ASF subversion and git services commented on NIFI-9586: --- Commit 73de3a0fe7eb0bdc449b6170aaf426213816f53f in nifi's branch refs/heads/main from Paul Grey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=73de3a0 ] NIFI-9586 Excluded additional assembly modules from ci-workflow This closes #5690 Signed-off-by: David Handermann > Investigate issues with Github Actions Build > -- > > Key: NIFI-9586 > URL: https://issues.apache.org/jira/browse/NIFI-9586 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Minor > Fix For: 1.16.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Recent builds in github actions for the NiFi repository have intermittently > failed. Investigate ways of diagnosing and correcting any issues. > https://github.com/apache/nifi/actions/runs/1713674982 > Ubuntu Zulu JDK 11 EN > Process completed with exit code 1. > Windows Zulu JDK 8 FR > You are running out of disk space. The runner will stop working when the > machine runs out of disk space. Free space left: 32 MB -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] exceptionfactory closed pull request #5690: NIFI-9586 - exclude assemblies from CI
exceptionfactory closed pull request #5690: URL: https://github.com/apache/nifi/pull/5690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dmnewber commented on pull request #5684: NIFI-9605: Docker Images for OpenShift
dmnewber commented on pull request #5684: URL: https://github.com/apache/nifi/pull/5684#issuecomment-1018783753 Hi @guimou, thanks for the PR! It looks like there's a lot of duplication here, particularly with the `sh` directories. It would be better from a maintenance perspective to not have the scripts duplicated and instead enhance the build scripts to be able to select different Dockerfiles. Did you have a goal in mind with duplicating the entire build directory? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #5700: NIFI-9618 Upgrade Checkstyle to 9.2.1
joewitt commented on pull request #5700: URL: https://github.com/apache/nifi/pull/5700#issuecomment-1018779815 love it. if build checks out +1 and please self merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9618) Upgrade Checkstyle to 9.2.1
[
https://issues.apache.org/jira/browse/NIFI-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-9618:
---
Status: Patch Available (was: Open)
> Upgrade Checkstyle to 9.2.1
> ---
>
> Key: NIFI-9618
> URL: https://issues.apache.org/jira/browse/NIFI-9618
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Affects Versions: 1.16.0
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Following recent updates to the maven-checkstyle-plugin version, the plugin
> now reports the following warnings:
> {noformat}
> Warning: Old version of checkstyle detected. Consider updating to >= v8.30
> Warning: For more information see:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
> {noformat}
> Upgrading to the latest version of the checkstyle library will eliminate this
> warning.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi] exceptionfactory opened a new pull request #5700: NIFI-9618 Upgrade Checkstyle to 9.2.1
exceptionfactory opened a new pull request #5700:
URL: https://github.com/apache/nifi/pull/5700
Description of PR
NIFI-9618 Upgrades Checkstyle from 8.29 to 9.2.1 and corrects several
missing Java documentation return statements. Changes also include removing the
duplicative maven-checkstyle-plugin in the NiFi Registry Maven configuration.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-fds] rfellows commented on a change in pull request #60: [NIFI-9554] update node/npm versions and frontend deps
rfellows commented on a change in pull request #60:
URL: https://github.com/apache/nifi-fds/pull/60#discussion_r789904029
##
File path: .eslintrc.js
##
@@ -15,77 +15,110 @@
* limitations under the License.
*/
+const OFF = 0; // turn the rule off
+const WARNING = 1; // turn the rule on as a warning (doesn’t affect exit code)
+const ERROR = 2; // turn the rule on as an error (exit code is 1 when
triggered)
+
module.exports = {
-"root": true,
-"extends": "eslint-config-airbnb",
-"env": {
-"browser": true,
-"es6": true,
-"jasmine": true,
-"jquery": true
+'extends': 'eslint-config-airbnb',
+'env': {
+'browser': true,
+'es6': true,
+'jasmine': true
},
-"parserOptions": {
-"ecmaVersion": 2017,
-"sourceType": "module"
+'parserOptions': {
+'ecmaVersion': 2017,
+'sourceType': 'module'
},
-"parser": "@typescript-eslint/parser",
-"plugins": ["@typescript-eslint"],
+'parser': '@typescript-eslint/parser',
+'plugins': [
+'jasmine',
+'@typescript-eslint'
+],
overrides: [
{
// Legacy Javascript files
files: ['*.js'],
rules: {
-"dot-notation": 0,
-"prefer-arrow-callback": 0,
-"no-var": 0,
-"no-redeclare": 0,
-"no-shadow": 0,
-"quote-props": 0,
-"object-shorthand": 0,
-"vars-on-top": 0,
-"no-param-reassign": 0,
-"block-scoped-var": 0,
-"prefer-destructuring": 0,
-"prefer-template": 0,
-"consistent-return": 0,
-"no-restricted-properties": 0,
-"no-use-before-define": 0,
-"object-curly-spacing": 0,
-"newline-per-chained-call": 0,
-"no-bitwise": 0,
-"no-nested-ternary": 0,
-"no-useless-escape": 0,
-"no-prototype-builtins": 0,
+'dot-notation': OFF,
+'prefer-arrow-callback': OFF,
+'no-var': OFF,
+'no-redeclare': OFF,
+'no-shadow': OFF,
+'quote-props': OFF,
+'object-shorthand': OFF,
+'vars-on-top': OFF,
+'no-param-reassign': OFF,
+'block-scoped-var': OFF,
+'prefer-destructuring': OFF,
+'prefer-template': OFF,
+'consistent-return': OFF,
+'no-restricted-properties': OFF,
+'no-use-before-define': OFF,
+'object-curly-spacing': OFF,
+'newline-per-chained-call': OFF,
+'no-bitwise': OFF,
+'no-nested-ternary': OFF,
+'no-useless-escape': OFF,
+'no-prototype-builtins': OFF,
+'arrow-body-style': OFF,
+'no-else-return': OFF,
}
},
{
// Typescript files
files: ['*.ts'],
rules: {
-'@typescript-eslint/no-unused-vars': [2, { args: "none" }]
+'dot-notation': OFF,
+'no-shadow': OFF,
+'no-use-before-define': OFF,
+'@typescript-eslint/no-unused-vars': [ERROR, { args: 'none' }]
+}
+},
+{
+// Test files
+files: ['*.spec.ts'],
+rules: {
+'max-classes-per-file': OFF
}
}
],
-"rules": {
+'rules': {
// Customize for all files
-"no-unused-vars": ["error", { "args": "none" }],
-"lines-between-class-members": ["error", "always", {
"exceptAfterSingleLine": true }],
-"indent": ["error", 4],
+'no-unused-vars': [ERROR, { 'vars': 'all' }],
+'lines-between-class-members': [ERROR, 'always', {
'exceptAfterSingleLine': true }],
+'indent': [ERROR, 4, { 'SwitchCase': 1 }],
+'jasmine/no-focused-tests': ERROR,
+'class-methods-use-this': OFF,
+'prefer-destructuring': [ERROR, {
+'VariableDeclarator': {
+'array': false,
+'object': true
+},
+'AssignmentExpression': {
+'array': false,
+'object': false
+}
+}],
// Disable for all files
-"max-len": 0,
-"func-names": 0,
-"spaced-comment": 0,
-"comma-dangle": 0,
-"import/extensions": 0,
-"import/no-unresolved": 0,
-"import/no-extraneous-dependencies": 0,
-"no-plusplus": 0,
-"react/no-this-in-sfc": 0,
-"prefer-promise-reject-errors": 0,
-"object-curly-newline": 0,
-"no-restricted-globals": 0,
-"import/prefer-default-export": 0,
-
[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #60: [NIFI-9554] update node/npm versions and frontend deps
scottyaslan commented on a change in pull request #60:
URL: https://github.com/apache/nifi-fds/pull/60#discussion_r789896813
##
File path: platform/core/snackbars/fds-snackbars.module.js
##
@@ -38,6 +32,10 @@ import {
} from './services/snackbar.service';
import { FdsCoasterComponent } from './coaster/coaster.component';
+import {MatSnackBarModule} from "@angular/material/snack-bar";
Review comment:
ok I updated the linter and addressed the lint errors it found. plz
confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-9618) Upgrade Checkstyle to 9.2.1
[
https://issues.apache.org/jira/browse/NIFI-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480220#comment-17480220
]
David Handermann commented on NIFI-9618:
No problem [~joewitt]! It looks like Checkstyle 9 includes a few minor rule
adjustments, so running a few more checks and will be submitting a PR soon.
> Upgrade Checkstyle to 9.2.1
> ---
>
> Key: NIFI-9618
> URL: https://issues.apache.org/jira/browse/NIFI-9618
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Affects Versions: 1.16.0
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> Following recent updates to the maven-checkstyle-plugin version, the plugin
> now reports the following warnings:
> {noformat}
> Warning: Old version of checkstyle detected. Consider updating to >= v8.30
> Warning: For more information see:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
> {noformat}
> Upgrading to the latest version of the checkstyle library will eliminate this
> warning.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (NIFI-9618) Upgrade Checkstyle to 9.2.1
[
https://issues.apache.org/jira/browse/NIFI-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480215#comment-17480215
]
Joe Witt commented on NIFI-9618:
doh! sorry [~exceptionfactory]thought I had checked these bits but I forgot
the checkstyle itself difffers from the plugin
> Upgrade Checkstyle to 9.2.1
> ---
>
> Key: NIFI-9618
> URL: https://issues.apache.org/jira/browse/NIFI-9618
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Affects Versions: 1.16.0
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> Following recent updates to the maven-checkstyle-plugin version, the plugin
> now reports the following warnings:
> {noformat}
> Warning: Old version of checkstyle detected. Consider updating to >= v8.30
> Warning: For more information see:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
> {noformat}
> Upgrading to the latest version of the checkstyle library will eliminate this
> warning.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (NIFI-9618) Upgrade Checkstyle to 9.2.1
David Handermann created NIFI-9618:
--
Summary: Upgrade Checkstyle to 9.2.1
Key: NIFI-9618
URL: https://issues.apache.org/jira/browse/NIFI-9618
Project: Apache NiFi
Issue Type: Improvement
Components: Tools and Build
Affects Versions: 1.16.0
Reporter: David Handermann
Assignee: David Handermann
Following recent updates to the maven-checkstyle-plugin version, the plugin now
reports the following warnings:
{noformat}
Warning: Old version of checkstyle detected. Consider updating to >= v8.30
Warning: For more information see:
https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
{noformat}
Upgrading to the latest version of the checkstyle library will eliminate this
warning.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (NIFI-7840) ExecuteScript - Groovy 3.0
[ https://issues.apache.org/jira/browse/NIFI-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7840: --- Status: Patch Available (was: In Progress) > ExecuteScript - Groovy 3.0 > -- > > Key: NIFI-7840 > URL: https://issues.apache.org/jira/browse/NIFI-7840 > Project: Apache NiFi > Issue Type: Wish > Components: Extensions >Reporter: Mermillod >Assignee: Matt Burgess >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Groovy 4.0 is in alpha, and Groovy 3.0 is out for long time, with features > like lambdas. > (ExecuteScript is using Groov 2.5.4) > New features : [https://groovy-lang.org/releasenotes/groovy-3.0.html] > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] mattyb149 opened a new pull request #5699: NIFI-7840: Upgrade to Groovy 3.0.8 and Spock 2.1
mattyb149 opened a new pull request #5699:
URL: https://github.com/apache/nifi/pull/5699
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Upgrades Spock version to 2.1 and Groovy version to 3.0.8 (to match Spock's
Groovy version, even though 3.0.9 has been released). Since one of the
motivations for this upgrade is to reduce the number of illegal reflective
access errors, I noticed the version of Mockito in MiNiFi Java is ancient so I
upgraded that too.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-7840) ExecuteScript - Groovy 3.0
[ https://issues.apache.org/jira/browse/NIFI-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480206#comment-17480206 ] Mermillod commented on NIFI-7840: - I don't know about the backward compatibility between groovy 2 and 3. Maybe it can worth adding a "Groovy3" language in ExecuteScript (and the new REcord one). > ExecuteScript - Groovy 3.0 > -- > > Key: NIFI-7840 > URL: https://issues.apache.org/jira/browse/NIFI-7840 > Project: Apache NiFi > Issue Type: Wish > Components: Extensions >Reporter: Mermillod >Assignee: Matt Burgess >Priority: Minor > > Groovy 4.0 is in alpha, and Groovy 3.0 is out for long time, with features > like lambdas. > (ExecuteScript is using Groov 2.5.4) > New features : [https://groovy-lang.org/releasenotes/groovy-3.0.html] > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (NIFI-9617) Remove unused screenshots from documentation
[ https://issues.apache.org/jira/browse/NIFI-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9617: --- Status: Patch Available (was: Open) > Remove unused screenshots from documentation > > > Key: NIFI-9617 > URL: https://issues.apache.org/jira/browse/NIFI-9617 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Recent changes to update the implementation and documentation for encrypted > repositories removed references to several screenshots. These screenshots > account for several MB in the documentation directory and should be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] exceptionfactory opened a new pull request #5698: NIFI-9617 Remove unused screenshots from documentation
exceptionfactory opened a new pull request #5698:
URL: https://github.com/apache/nifi/pull/5698
Description of PR
NIFI-9617 Removes several large unused screenshots from the documentation
directory. Previous documentation on the encrypted repository implementations
referenced these screenshots, but recent updates to the implementation and
documentation removed references to these files.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-9617) Remove unused screenshots from documentation
David Handermann created NIFI-9617: -- Summary: Remove unused screenshots from documentation Key: NIFI-9617 URL: https://issues.apache.org/jira/browse/NIFI-9617 Project: Apache NiFi Issue Type: Improvement Components: Documentation Website Reporter: David Handermann Assignee: David Handermann Recent changes to update the implementation and documentation for encrypted repositories removed references to several screenshots. These screenshots account for several MB in the documentation directory and should be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] markobean closed pull request #5664: NIFI-9562: add 'archive' conflict resolution strategy to PutFile
markobean closed pull request #5664: URL: https://github.com/apache/nifi/pull/5664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-9233) Improve reliability of system integration tests
[
https://issues.apache.org/jira/browse/NIFI-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Grey reassigned NIFI-9233:
---
Assignee: Paul Grey
> Improve reliability of system integration tests
> ---
>
> Key: NIFI-9233
> URL: https://issues.apache.org/jira/browse/NIFI-9233
> Project: Apache NiFi
> Issue Type: Task
> Components: Tools and Build
>Reporter: David Handermann
>Assignee: Paul Grey
>Priority: Major
>
> The {{nifi-system-tests}} module contains multiple integration tests for
> verifying behavior using minimal instances of NiFi. The GitHub
> [system-tests|https://github.com/apache/nifi/actions/workflows/system-tests.yml]
> workflow fails on some occasions due to apparent timing issues when making
> requests or evaluating expected results. The polling approach and instance
> configuration properties should be evaluated for potential improvements to
> make the tests more reliable in environments with limited resources.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi] markobean commented on pull request #5664: NIFI-9562: add 'archive' conflict resolution strategy to PutFile
markobean commented on pull request #5664: URL: https://github.com/apache/nifi/pull/5664#issuecomment-1018666170 Your recommendation is exactly what we are currently performing. Specifically, writing the "new" file to a semi-permanent location prior to overwriting the existing file. So, the historical information is preserved, albeit prior to being "in use" by the controller service. Yet, this is perfectly adequate. The idea of incorporating the functionality into the PutFile processor itself is that it seemed a logical extension of the processor's capability. It seemed convenient to add the option to the processor especially since doing so is fully backward compatible with existing behavior. Also, it has the advantage of not duplicating data and archiving a copy if there was ever only a single file by that name, i.e. if there was no need for an archived copy. I'm still not clear on the words of caution you've brought up based on past experience. However, you are correct that a NiFi flow can be configured to accomplish nearly the same functionality. Also, it just occurred to me that performing this in a flow can result in archiving a file only once per cluster, but putting it in the processor itself means each node in the cluster would redundantly archive the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] simonbence commented on pull request #5696: NIFI-9615 Extending capabilities of NAR provider with restraing, conflict resolution strategy and refactors to make it more flexible
simonbence commented on pull request #5696: URL: https://github.com/apache/nifi/pull/5696#issuecomment-1018665522 Hi @bbende ! Could you please take a look if you are okay with how I converted the NiFi Registry Bundle based provider? Many thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-1240) Check last modified timestamp of the inode before re-reading the script file of ExecutePythonScript
[ https://issues.apache.org/jira/browse/MINIFICPP-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi resolved MINIFICPP-1240. -- Fix Version/s: 0.12.0 Assignee: Gábor Gyimesi (was: Adam Hunyadi) Resolution: Fixed > Check last modified timestamp of the inode before re-reading the script file > of ExecutePythonScript > --- > > Key: MINIFICPP-1240 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1240 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.7.0 >Reporter: Adam Hunyadi >Assignee: Gábor Gyimesi >Priority: Minor > Fix For: 1.0.0, 0.12.0 > > > *Acceptance criteria:* > *GIVEN* A Getfile -> ExecutePythonScript -> Putfile workflow > *WHEN* The ExecutePythonScript is run twice *without* any update on the > script file inbetween > *THEN* There should be no log line stating that the script was reloaded > *GIVEN* A Getfile -> ExecutePythonScript -> Putfile workflow > *WHEN* The ExecutePythonScript is run twice *with* an update on the script > file inbetween > *THEN* On the second execution, the new script file should be executed and a > re-read should be logged > *Background:* > The ExecutePythonScriptProcessor currently rereads the script file every time > it is on schedule. This is suboptimal. > *Proposal:* > As an optimization we may want to check the last modified timestamp of the > inode before reading the file. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #1249: MINIFICPP-1669 Use std::byte for buffers
szaszm opened a new pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249 The initial goal was streams only, but it's impossible to change only one part of the code to use std::byte for byte representation. There is still a bug lurking somewhere, causing SecureSocketGetTCP* tests to fail, but other than that, the PR should be close to final. --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #5664: NIFI-9562: add 'archive' conflict resolution strategy to PutFile
joewitt commented on pull request #5664: URL: https://github.com/apache/nifi/pull/5664#issuecomment-1018624053 The JIRA and code just describe what you want to do not the why. In your last comment it sounds like the why (a specific use case) is more clear. If I follow correctly you have a case whereby you have a service which looks at a specific file and you periodically want to update that file. And whenever you do update the file you'd like to have the previous file saved somewhere in case an operator might want to rollback. Makes perfect sense. Without this change how that would be well accomplished is a flow that simply writes a copy of the new dataset to the archive location using PutFile. Then using another PutFile writes a copy of it to the actual target location. You can modify names, replace, etc.. all as you wish. The full power/flexibility of the existing mechanisms are available to the user. They're not limited by what renaming options you exposed in PutFile, etc.. Additionally we didn't have to make substantial changes to a high use Processor and add a new set of properties to it. Do the existing capabilities not address the use case you've laid out or another use case you've not yet mentioned? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
bbende commented on pull request #5630: URL: https://github.com/apache/nifi/pull/5630#issuecomment-1018602692 @exceptionfactory any chance you can take another pass at this? I think I have addressed the previous comments with the latest commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9616) Include SLF4J bridge libraries in NiFi Stateless Kafka Connect assembly
[
https://issues.apache.org/jira/browse/NIFI-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-9616:
--
Status: Patch Available (was: Open)
> Include SLF4J bridge libraries in NiFi Stateless Kafka Connect assembly
> ---
>
> Key: NIFI-9616
> URL: https://issues.apache.org/jira/browse/NIFI-9616
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Stateless
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add SLF4J bridge libraries in NiFi Stateless Kafka Connect assembly. The
> {{lib}} directory should contain these jars (similar to the traditional and
> stateless NiFi assemblies) because some NARs depend on 3rd party libraries
> that use those logging frameworks.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi] thenatog commented on a change in pull request #5669: NIFI-9453 - Refactored ListenBeats to use netty.
thenatog commented on a change in pull request #5669:
URL: https://github.com/apache/nifi/pull/5669#discussion_r789739370
##
File path:
nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/netty/BeatsFrameDecoder.java
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.beats.netty;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.ByteToMessageDecoder;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.listen.event.EventFactoryUtil;
+import org.apache.nifi.processors.beats.frame.BeatsMetadata;
+import org.apache.nifi.processors.beats.frame.BeatsDecoder;
+import org.apache.nifi.processors.beats.frame.BeatsEncoder;
+import org.apache.nifi.processors.beats.frame.BeatsFrame;
+
+import java.nio.charset.Charset;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Decode a Beats message's bytes into a BeatsMessage object
+ */
+public class BeatsFrameDecoder extends ByteToMessageDecoder {
+
+private Charset charset;
+private BeatsDecoder decoder;
+private final ComponentLog logger;
+private final BeatsEncoder encoder;
+private final BeatsMessageFactory messageFactory;
+
+public static final byte FRAME_WINDOWSIZE = 0x57, FRAME_DATA = 0x44,
FRAME_COMPRESSED = 0x43, FRAME_ACK = 0x41, FRAME_JSON = 0x4a;
Review comment:
I added a new class to hold these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-7840) ExecuteScript - Groovy 3.0
[ https://issues.apache.org/jira/browse/NIFI-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-7840: -- Assignee: Matt Burgess > ExecuteScript - Groovy 3.0 > -- > > Key: NIFI-7840 > URL: https://issues.apache.org/jira/browse/NIFI-7840 > Project: Apache NiFi > Issue Type: Wish > Components: Extensions >Reporter: Mermillod >Assignee: Matt Burgess >Priority: Minor > > Groovy 4.0 is in alpha, and Groovy 3.0 is out for long time, with features > like lambdas. > (ExecuteScript is using Groov 2.5.4) > New features : [https://groovy-lang.org/releasenotes/groovy-3.0.html] > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] turcsanyip opened a new pull request #5697: NIFI-9616: Included SLF4J bridge libraries in NiFi Stateless Kafka Co…
turcsanyip opened a new pull request #5697: URL: https://github.com/apache/nifi/pull/5697 …nnect assembly https://issues.apache.org/jira/browse/NIFI-9616 In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-** where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you verified that the full build is successful on JDK 8? - [ ] Have you verified that the full build is successful on JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-9616) Include SLF4J bridge libraries in NiFi Stateless Kafka Connect assembly
Peter Turcsanyi created NIFI-9616:
-
Summary: Include SLF4J bridge libraries in NiFi Stateless Kafka
Connect assembly
Key: NIFI-9616
URL: https://issues.apache.org/jira/browse/NIFI-9616
Project: Apache NiFi
Issue Type: Bug
Components: NiFi Stateless
Reporter: Peter Turcsanyi
Assignee: Peter Turcsanyi
Add SLF4J bridge libraries in NiFi Stateless Kafka Connect assembly. The
{{lib}} directory should contain these jars (similar to the traditional and
stateless NiFi assemblies) because some NARs depend on 3rd party libraries that
use those logging frameworks.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi] guimou commented on pull request #5684: NIFI-9605: Docker Images for OpenShift
guimou commented on pull request #5684: URL: https://github.com/apache/nifi/pull/5684#issuecomment-1018590854 @kevdoran Perfect, thanks a lot. In this case everything has already been tested with 1.15.2 as part of [this project](https://github.com/guimou/odh-manifests/tree/nifi/nifi), both as a simple Kustomize configuration and with the [Open Data Hub](https://opendatahub.io/) operator. Built images are available here: [Nifi](https://quay.io/repository/rh-data-services/nifi-openshift), [Registry](https://quay.io/repository/rh-data-services/nifi-registry-openshift) and [Toolkit](https://quay.io/repository/rh-data-services/nifi-toolkit-openshift). As 1.15.3 was only a bug fix over 1.15.2 I would say it's pretty much ok, although I will surely find some time to rebuild images with 1.15.3 in the next few days. However it won't change anything for the PR as everything is already set to 1.16.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] simonbence opened a new pull request #5696: NIFI-9615 Extending capabilities of NAR provider with restraing, conflict resolution strategy and refactors to make it more flexible
simonbence opened a new pull request #5696:
URL: https://github.com/apache/nifi/pull/5696
[NIFI-9615](https://issues.apache.org/jira/browse/NIFI-9615)
This is a follow up on NIFI-8519: the NAR Provider has been refactored for
being more flexible (both in usage and with furher extensions). With this some
feature has been added:
- Allowing providers to replace already existing files if certain conditions
apply, using "conflict resolution strategies"
- Restraining NiFi from startup until the first fetch has been succeeded
(optional)
- Adding a property to refine poll interval
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] simonbence closed pull request #5393: NIFI-9208 Adding Flow Resource Provider Service
simonbence closed pull request #5393: URL: https://github.com/apache/nifi/pull/5393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-9615) Extending the capabilities of the NAR provider functionality
Simon Bence created NIFI-9615: - Summary: Extending the capabilities of the NAR provider functionality Key: NIFI-9615 URL: https://issues.apache.org/jira/browse/NIFI-9615 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Reporter: Simon Bence Assignee: Simon Bence NAR provider functionality would benefit from some additional funcitons which would make it more user friendly and flexible: - Restrain NiFi from startup before the first fetch attempt - Adding the capability to decide what should be the "conflict resolution strartegy" in case of a NAR with the same name already exists in the target folder - Allowing a property to refine poll intervals In order to achieve this, relevant refactors and changes from [NIFI-9208|https://issues.apache.org/jira/browse/NIFI-9208] will be applied and refined. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] kevdoran commented on pull request #5684: NIFI-9605: Docker Images for OpenShift
kevdoran commented on pull request #5684: URL: https://github.com/apache/nifi/pull/5684#issuecomment-1018549016 @guimou There are no nightlies, so you can test with a release version such as 1.15.3. I know that complicates things with the hardcoded version in files such as DockerImage.txt. I'm actually thinking about a new approach so that we don't need those files / hardcoded versions in the code base. To @joewitt's point though, the idea here is that we are always preparing the source code to be ready for the next release, so if someone downloads the source tarball for 1.16.0 (when it is ready) and builds the Docker images, it will default to fetching those artifacts. During development / testing on main, that does make it trickier. For this PR, if it is working with 1.15.3, I would say that is good for verifying everything is in good order -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #5664: NIFI-9562: add 'archive' conflict resolution strategy to PutFile
markobean commented on pull request #5664: URL: https://github.com/apache/nifi/pull/5664#issuecomment-1018543213 The option of changing the filename is not applicable to the use case in mind. Suppose a PutFile is writing an updated file used by a Controller Service. The Controller Service will reload the file when a change is detected, but it requires the filename to remain the same. Therefore, changing the filename upon PutFile failure and trying again is not possible in this scenario. Also, in the above use case, it is desirable to save (archive) the current file before replacing it. The archived file can be used as a fallback if the new file is corrupt or otherwise unusable. The archive also can provide a historical record of when a certain configuration changed. I'm not sure I follow the "error prone and too limiting". The rules as laid out seem pretty straight-forward. Can you further explain the concern or historical errors that occurred? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9603) When a processor group is stopped or started in the UI, the thread pool cannot execute any tasks
[ https://issues.apache.org/jira/browse/NIFI-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480073#comment-17480073 ] liuke commented on NIFI-9603: - At present, the company's production environment cannot be upgraded immediately. Can you help us look at this problem first? If it can't be solved, we'll consider upgrading to the latest version. Thank you. > When a processor group is stopped or started in the UI, the thread pool > cannot execute any tasks > > > Key: NIFI-9603 > URL: https://issues.apache.org/jira/browse/NIFI-9603 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.9.0 > Environment: nifi version:1.9.0 > Server：CentOS Linux release 7.9.2009 > Deployment mode: 5-node cluster > The maximum timer driven thread count is set to 350 > JDK version is "1.8.0_181" >Reporter: liuke >Priority: Major > Attachments: description.pdf, dump.log, nifi-app_2022-01-21_09.34.log > > Original Estimate: 192h > Remaining Estimate: 192h > > See the attachment for the picture > > Problem phenomenon > # This problem is probably triggered when a processor group (including > multiple processors) is stopped in the interface > # Nifi cluster UI “Active Thread Count”becomes 0 > # The task cannot be executed. The UI shows that the thread is stuck > # Analysis using jstack，The stack information is intercepted many times at a > long time interval, and the information is the following results: total > 350 thread, one of which is timed_ Waiting, The remaining 349 are waiting -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1196: MINIFICPP-1659 Create DeleteAzureBlobStorage processor
lordgamez commented on a change in pull request #1196:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1196#discussion_r789616097
##
File path: extensions/azure/processors/DeleteAzureBlobStorage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * @file DeleteAzureBlobStorage.cpp
+ * DeleteAzureBlobStorage class implementation
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "DeleteAzureBlobStorage.h"
+
+#include "core/Resource.h"
+#include "utils/ProcessorConfigUtils.h"
+
+namespace org::apache::nifi::minifi::azure::processors {
+
+const core::Property DeleteAzureBlobStorage::DeleteSnapshotsOption(
+ core::PropertyBuilder::createProperty("Delete Snapshots Option")
+->withDescription("Specifies the snapshot deletion options to be used when
deleting a blob. None: Deletes the blob only. Include Snapshots: Delete the
blob and its snapshots. "
+ "Delete Snapshots Only: Delete only the blob's
snapshots.")
+->isRequired(true)
+->withDefaultValue(toString(storage::OptionalDeletion::NONE))
+->withAllowableValues(storage::OptionalDeletion::values())
+->build());
+
+const core::Relationship DeleteAzureBlobStorage::Success("success", "All
successfully processed FlowFiles are routed to this relationship");
+const core::Relationship DeleteAzureBlobStorage::Failure("failure",
"Unsuccessful operations will be transferred to the failure relationship");
+
+void DeleteAzureBlobStorage::initialize() {
+ // Set the supported properties
+ setSupportedProperties({
+AzureStorageCredentialsService,
+ContainerName,
+StorageAccountName,
+StorageAccountKey,
+SASToken,
+CommonStorageAccountEndpointSuffix,
+ConnectionString,
+Blob,
+DeleteSnapshotsOption,
+UseManagedIdentityCredentials
+ });
+ // Set the supported relationships
+ setSupportedRelationships({
+Success,
+Failure
+ });
+}
+
+void DeleteAzureBlobStorage::onSchedule(const
std::shared_ptr& context, const
std::shared_ptr& session_factory) {
+ gsl_Expects(context && session_factory);
+ AzureBlobStorageProcessorBase::onSchedule(context, session_factory);
+ optional_deletion_ = storage::OptionalDeletion::parse(
Review comment:
Good idea, updated in 752968bd6175b59ca1474a3ca344b6d3c444b742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request #1248: MINIFICPP-1702: DefragmentText multiinput improvement
martinzink opened a new pull request #1248: URL: https://github.com/apache/nifi-minifi-cpp/pull/1248 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1196: MINIFICPP-1659 Create DeleteAzureBlobStorage processor
adamdebreceni commented on a change in pull request #1196:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1196#discussion_r789588581
##
File path: extensions/azure/processors/DeleteAzureBlobStorage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * @file DeleteAzureBlobStorage.cpp
+ * DeleteAzureBlobStorage class implementation
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "DeleteAzureBlobStorage.h"
+
+#include "core/Resource.h"
+#include "utils/ProcessorConfigUtils.h"
+
+namespace org::apache::nifi::minifi::azure::processors {
+
+const core::Property DeleteAzureBlobStorage::DeleteSnapshotsOption(
+ core::PropertyBuilder::createProperty("Delete Snapshots Option")
+->withDescription("Specifies the snapshot deletion options to be used when
deleting a blob. None: Deletes the blob only. Include Snapshots: Delete the
blob and its snapshots. "
+ "Delete Snapshots Only: Delete only the blob's
snapshots.")
+->isRequired(true)
+->withDefaultValue(toString(storage::OptionalDeletion::NONE))
+->withAllowableValues(storage::OptionalDeletion::values())
+->build());
+
+const core::Relationship DeleteAzureBlobStorage::Success("success", "All
successfully processed FlowFiles are routed to this relationship");
+const core::Relationship DeleteAzureBlobStorage::Failure("failure",
"Unsuccessful operations will be transferred to the failure relationship");
+
+void DeleteAzureBlobStorage::initialize() {
+ // Set the supported properties
+ setSupportedProperties({
+AzureStorageCredentialsService,
+ContainerName,
+StorageAccountName,
+StorageAccountKey,
+SASToken,
+CommonStorageAccountEndpointSuffix,
+ConnectionString,
+Blob,
+DeleteSnapshotsOption,
+UseManagedIdentityCredentials
+ });
+ // Set the supported relationships
+ setSupportedRelationships({
+Success,
+Failure
+ });
+}
+
+void DeleteAzureBlobStorage::onSchedule(const
std::shared_ptr& context, const
std::shared_ptr& session_factory) {
+ gsl_Expects(context && session_factory);
+ AzureBlobStorageProcessorBase::onSchedule(context, session_factory);
+ optional_deletion_ = storage::OptionalDeletion::parse(
Review comment:
we could replace this with
`parseEnumProperty(*context, DeleteSnapshotsOption)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution
lordgamez commented on a change in pull request #1237: URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789586909 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -211,7 +211,7 @@ void ConsumeKafka::onSchedule(core::ProcessContext* context, core::ProcessSessio context->getProperty(DuplicateHeaderHandling.getName(), duplicate_header_handling_); headers_to_add_as_attributes_ = utils::listFromCommaSeparatedProperty(*context, HeadersToAddAsAttributes.getName()); - max_poll_records_ = gsl::narrow(utils::getOptionalUintProperty(*context, MaxPollRecords.getName()).value_or(DEFAULT_MAX_POLL_RECORDS)); + max_poll_records_ = gsl::narrow(utils::getOptionalProperty(*context, MaxPollRecords.getName()).value_or(DEFAULT_MAX_POLL_RECORDS)); Review comment: I wasn't aware of this, in that case this is not needed at all, removed it in ddfa1b976649599300457af5d5b4100f948d6a43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution
adamdebreceni commented on a change in pull request #1237: URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789584630 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -211,7 +211,7 @@ void ConsumeKafka::onSchedule(core::ProcessContext* context, core::ProcessSessio context->getProperty(DuplicateHeaderHandling.getName(), duplicate_header_handling_); headers_to_add_as_attributes_ = utils::listFromCommaSeparatedProperty(*context, HeadersToAddAsAttributes.getName()); - max_poll_records_ = gsl::narrow(utils::getOptionalUintProperty(*context, MaxPollRecords.getName()).value_or(DEFAULT_MAX_POLL_RECORDS)); + max_poll_records_ = gsl::narrow(utils::getOptionalProperty(*context, MaxPollRecords.getName()).value_or(DEFAULT_MAX_POLL_RECORDS)); Review comment: `ProcessContext::getProperty(const Property&)` already returns an `std::optional`, does `getOptionalProperty` behave differently? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9578) The Nifi User List in the UI will not populate if they are syncing a username and a group name that are the same
[ https://issues.apache.org/jira/browse/NIFI-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Kocsis updated NIFI-9578: -- Status: Patch Available (was: In Progress) > The Nifi User List in the UI will not populate if they are syncing a username > and a group name that are the same > > > Key: NIFI-9578 > URL: https://issues.apache.org/jira/browse/NIFI-9578 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.13.2 >Reporter: Timea Barna >Assignee: Adam Kocsis >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The Nifi User List in the UI will not populate if they are syncing a username > and a group name that are the same > Recreation Steps: > I have a user name 'kevin' > I created a group named 'kevin' > When I open Nifi, the user list is blank and when I check the browser > console, I see the error: > slick.dataview.js:191 Uncaught Error: [SlickGrid DataView] Each data element > must implement a unique 'id' property > Nifi uses a combined user list even though they come from different endpoints > /tenant > The UI only support searching for users so the 'id' (identity fields within > the response json) will match which will throw the error because the code > expects the id fields to be unique > Reproduced in 1.13.2 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] koccs opened a new pull request #5695: NIFI-9578 NiFi user list no longer breaks if a user and group have the same id
koccs opened a new pull request #5695:
URL: https://github.com/apache/nifi/pull/5695
Description of PR
- ids of the entities are prefixed by their types to avoid id conflict in
3rd party table library
For some authorizers the UUID calculation for users and groups based only
on the name of the entity and a global seed.
This results the same UUID for a group and a user with the same name. The
same ids are no longer causing any issue on the UI.
- group icon alignment is fixed for edit user dialog
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution
lordgamez commented on a change in pull request #1237:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789553463
##
File path: extensions/script/ExecuteScript.cpp
##
@@ -123,6 +128,10 @@ void ExecuteScript::onTrigger(const
std::shared_ptr
throw std::runtime_error("No script engine available");
}
+ if (module_directory_.size()) {
Review comment:
Updated module directory to be optional in
f6be6d51339473f54b18c103fdef812b47c759ee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1247: MINIFICPP-1731 - Linter targets should not be built by default on Win…
adam-markovics commented on a change in pull request #1247:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1247#discussion_r789543109
##
File path: CMakeLists.txt
##
@@ -872,25 +872,27 @@ include(BuildDocs)
# Create a custom build target that will run the linter.
# Directories have their separate linter targets to be able to use better
parallelization
-get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
-set(root_linted_dirs libminifi/include libminifi/src libminifi/test
encrypt-config)
-list(TRANSFORM root_linted_dirs PREPEND ${CMAKE_SOURCE_DIR}/)
-
-set(linted_dir_counter 1)
-set(root_linter_target_names "")
-
-foreach(linted_dir ${root_linted_dirs})
- set(linter_target_name "root-linter-${linted_dir_counter}")
- list(APPEND root_linter_target_names ${linter_target_name})
- add_custom_target("${linter_target_name}"
- COMMAND python3
${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -q -i
- ${linted_dir}
- )
- math(EXPR linted_dir_counter "${linted_dir_counter}+1")
-endforeach()
-
-# Main linter target that depends on every other
-add_custom_target(linter DEPENDS ${root_linter_target_names} ${extensions})
+if (ENABLE_LINTER)
+get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
Review comment:
Anyways, I made an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1247: MINIFICPP-1731 - Linter targets should not be built by default on Win…
lordgamez commented on a change in pull request #1247:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1247#discussion_r789540945
##
File path: CMakeLists.txt
##
@@ -872,25 +872,27 @@ include(BuildDocs)
# Create a custom build target that will run the linter.
# Directories have their separate linter targets to be able to use better
parallelization
-get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
-set(root_linted_dirs libminifi/include libminifi/src libminifi/test
encrypt-config)
-list(TRANSFORM root_linted_dirs PREPEND ${CMAKE_SOURCE_DIR}/)
-
-set(linted_dir_counter 1)
-set(root_linter_target_names "")
-
-foreach(linted_dir ${root_linted_dirs})
- set(linter_target_name "root-linter-${linted_dir_counter}")
- list(APPEND root_linter_target_names ${linter_target_name})
- add_custom_target("${linter_target_name}"
- COMMAND python3
${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -q -i
- ${linted_dir}
- )
- math(EXPR linted_dir_counter "${linted_dir_counter}+1")
-endforeach()
-
-# Main linter target that depends on every other
-add_custom_target(linter DEPENDS ${root_linter_target_names} ${extensions})
+if (ENABLE_LINTER)
+get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
Review comment:
Actually as I checked although as the file already has 15 other lines
where spaces are used for indentation it is not that important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1247: MINIFICPP-1731 - Linter targets should not be built by default on Win…
lordgamez commented on a change in pull request #1247:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1247#discussion_r789532760
##
File path: CMakeLists.txt
##
@@ -872,25 +872,27 @@ include(BuildDocs)
# Create a custom build target that will run the linter.
# Directories have their separate linter targets to be able to use better
parallelization
-get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
-set(root_linted_dirs libminifi/include libminifi/src libminifi/test
encrypt-config)
-list(TRANSFORM root_linted_dirs PREPEND ${CMAKE_SOURCE_DIR}/)
-
-set(linted_dir_counter 1)
-set(root_linter_target_names "")
-
-foreach(linted_dir ${root_linted_dirs})
- set(linter_target_name "root-linter-${linted_dir_counter}")
- list(APPEND root_linter_target_names ${linter_target_name})
- add_custom_target("${linter_target_name}"
- COMMAND python3
${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -q -i
- ${linted_dir}
- )
- math(EXPR linted_dir_counter "${linted_dir_counter}+1")
-endforeach()
-
-# Main linter target that depends on every other
-add_custom_target(linter DEPENDS ${root_linter_target_names} ${extensions})
+if (ENABLE_LINTER)
Review comment:
Oh now I see, so it's more about the creation of the target than about
building the target. It's clear now, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-9614) GUI redirect to /nifi/ should not be delayed
Wiktor Kubicki created NIFI-9614:
Summary: GUI redirect to /nifi/ should not be delayed
Key: NIFI-9614
URL: https://issues.apache.org/jira/browse/NIFI-9614
Project: Apache NiFi
Issue Type: Improvement
Components: Core UI
Affects Versions: 1.15.3
Reporter: Wiktor Kubicki
When someone open nifi in browser withount putting path, sees:
{code:java}
Did you mean: /nifi
You may have mistyped... but we'll try to redirect you in 5 seconds.
{code}
This is helpfull, but are we supposed to wait 5 secunds? If we enter via
browser i think info is not as neccecery to read it each time, and redirect
should be instant.
But if someone opens nifi via curl or something (for example trying to access
to API) the info will be there anyway: they not run redirect.
I cannot find any valuable case when we should wait 5secund each time when we
are too lazy to put /nifi at the end of url.
I think, redirect should be instantly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1247: MINIFICPP-1731 - Linter targets should not be built by default on Win…
szaszm commented on a change in pull request #1247:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1247#discussion_r789521434
##
File path: CMakeLists.txt
##
@@ -872,25 +872,27 @@ include(BuildDocs)
# Create a custom build target that will run the linter.
# Directories have their separate linter targets to be able to use better
parallelization
-get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
-set(root_linted_dirs libminifi/include libminifi/src libminifi/test
encrypt-config)
-list(TRANSFORM root_linted_dirs PREPEND ${CMAKE_SOURCE_DIR}/)
-
-set(linted_dir_counter 1)
-set(root_linter_target_names "")
-
-foreach(linted_dir ${root_linted_dirs})
- set(linter_target_name "root-linter-${linted_dir_counter}")
- list(APPEND root_linter_target_names ${linter_target_name})
- add_custom_target("${linter_target_name}"
- COMMAND python3
${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -q -i
- ${linted_dir}
- )
- math(EXPR linted_dir_counter "${linted_dir_counter}+1")
-endforeach()
-
-# Main linter target that depends on every other
-add_custom_target(linter DEPENDS ${root_linter_target_names} ${extensions})
+if (ENABLE_LINTER)
Review comment:
The root-linter-* targets used to run on Windows even if ENABLE_LINTER
was OFF. Now we don't even create the targets if ENABLE_LINTER=OFF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-9613) QueryRecord fails with java.util.NoSuchElementException
[
https://issues.apache.org/jira/browse/NIFI-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479963#comment-17479963
]
Anders Synstad commented on NIFI-9613:
--
I believe you are correct :)
> QueryRecord fails with java.util.NoSuchElementException
> ---
>
> Key: NIFI-9613
> URL: https://issues.apache.org/jira/browse/NIFI-9613
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.15.2
> Environment: Ubuntu 18.04 with openjdk-11-jre-headless
> 11.0.13+8-0ubuntu1~18.04
>Reporter: Anders Synstad
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.16.0
>
> Attachments: JSON-test.xml
>
>
> I am getting java.util.NoSuchElementException in QueryRecord under certain
> conditions using JsonTreeReader + JsonRecordSetWriter + a simple json event.
> Generating a simple flowfile with the following json using GenerateFlowFile:
> {{
> {"epoch":1642669279,"thing":[1234],"foo":"bar"}
> }}
> Using QueryRecord with the following dynamic properties work:
> {{SELECT * FROM FLOWFILE WHERE foo = 'bar'}}
> {{SELECT * FROM FLOWFILE WHERE foo LIKE 'ba%'}}
> However, using the following generates an error:
> {{SELECT * FROM FLOWFILE WHERE foo LIKE 'fo%'}}
> It appears it will fail if the WHERE clause does not find any matches in the
> flowfile.Removing {{"thing":[12345]}} from the json in the flowfile causes
> all 3 dynamic
> properties in QueryRecord to work.The error generated is:
> {code}
> 2022-01-20 10:19:25,403 ERROR [Timer-Driven Process Thread-24]
> o.a.nifi.processors.standard.QueryRecord
> QueryRecord[id=9a2539a7-14df-159f-b3f4-83787721a05f] Unable to query
> StandardFlowFileRecord[uuid=db24c0b5-e874-4a55-82a7-cbdf69b0cf5a,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1642670361821-5989894,
> container=default, section=518], offset=517544,
> length=47],offset=0,name=db24c0b5-e874-4a55-82a7-cbdf69b0cf5a,size=47] due to
> org.apache.nifi.processor.exception.ProcessException: java.sql.SQLException:
> java.util.NoSuchElementException: Expecting cursor position to be
> Position.OK, actual is Position.AFTER_END: java.util.NoSuchElementException:
> Expecting cursor position to be Position.OK, actual is Position.AFTER_END
> ↳ causes: java.sql.SQLException: java.util.NoSuchElementException: Expecting
> cursor position to be Position.OK, actual is Position.AFTER_END
> ↳ causes: org.apache.nifi.processor.exception.ProcessException:
> java.sql.SQLException: java.util.NoSuchElementException: Expecting cursor
> position to be Position.OK, actual is Position.AFTER_END
> org.apache.nifi.processor.exception.ProcessException: java.sql.SQLException:
> java.util.NoSuchElementException: Expecting cursor position to be
> Position.OK, actual is Position.AFTER_END
> at
> org.apache.nifi.processors.standard.QueryRecord$1.process(QueryRecord.java:343)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2909)
> at
> org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:332)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1273)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:63)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: java.sql.SQLException: java.util.NoSuchElementException: Expecting
> cursor position to be Position.OK, actual is Position.AFTER_END
> at
> org.apache.calcite.avatica.util.PositionedCursor$ArrayGetter.getObject(PositionedCursor.java:65)
> at
> org.apache.calcite.avatica.util.AbstractCursor$AccessorImpl.getObject(AbstractCursor.java:355)
> at
> org.apache.calcite.avatica.util.AbstractCursor$ArrayAccessor.getObject(AbstractCursor.java:1286)
> at
> org.apache.calcite.avatica.util.AbstractCursor$ArrayAccessor.getArray(AbstractCursor.java:1354)
> at
> org.apache.calcite.avatica.AvaticaResultSet.getArray(AvaticaResultSet.java:729)
>
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1247: MINIFICPP-1731 - Linter targets should not be built by default on Win…
lordgamez commented on a change in pull request #1247:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1247#discussion_r789512942
##
File path: CMakeLists.txt
##
@@ -872,25 +872,27 @@ include(BuildDocs)
# Create a custom build target that will run the linter.
# Directories have their separate linter targets to be able to use better
parallelization
-get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
-set(root_linted_dirs libminifi/include libminifi/src libminifi/test
encrypt-config)
-list(TRANSFORM root_linted_dirs PREPEND ${CMAKE_SOURCE_DIR}/)
-
-set(linted_dir_counter 1)
-set(root_linter_target_names "")
-
-foreach(linted_dir ${root_linted_dirs})
- set(linter_target_name "root-linter-${linted_dir_counter}")
- list(APPEND root_linter_target_names ${linter_target_name})
- add_custom_target("${linter_target_name}"
- COMMAND python3
${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -q -i
- ${linted_dir}
- )
- math(EXPR linted_dir_counter "${linted_dir_counter}+1")
-endforeach()
-
-# Main linter target that depends on every other
-add_custom_target(linter DEPENDS ${root_linter_target_names} ${extensions})
+if (ENABLE_LINTER)
+get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
Review comment:
This cmake file is indented with tabs so the new content should also use
tabs instead of spaces
##
File path: CMakeLists.txt
##
@@ -872,25 +872,27 @@ include(BuildDocs)
# Create a custom build target that will run the linter.
# Directories have their separate linter targets to be able to use better
parallelization
-get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
-set(root_linted_dirs libminifi/include libminifi/src libminifi/test
encrypt-config)
-list(TRANSFORM root_linted_dirs PREPEND ${CMAKE_SOURCE_DIR}/)
-
-set(linted_dir_counter 1)
-set(root_linter_target_names "")
-
-foreach(linted_dir ${root_linted_dirs})
- set(linter_target_name "root-linter-${linted_dir_counter}")
- list(APPEND root_linter_target_names ${linter_target_name})
- add_custom_target("${linter_target_name}"
- COMMAND python3
${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -q -i
- ${linted_dir}
- )
- math(EXPR linted_dir_counter "${linted_dir_counter}+1")
-endforeach()
-
-# Main linter target that depends on every other
-add_custom_target(linter DEPENDS ${root_linter_target_names} ${extensions})
+if (ENABLE_LINTER)
Review comment:
Could you please explain how does this change the behavior on Windows?
It looks like the ENABLE_LINTER is still ON by default and we did not change
anything that is specific to Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1731) Linter targets should not be built by default on Windows
[ https://issues.apache.org/jira/browse/MINIFICPP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ádám Markovics updated MINIFICPP-1731: -- Description: Even if ENABLE_LINTER is set to OFF, root-linter-* targets are run on Windows. (was: A run from Jenkins is attached.) > Linter targets should not be built by default on Windows > > > Key: MINIFICPP-1731 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1731 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Ádám Markovics >Assignee: Ádám Markovics >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Even if ENABLE_LINTER is set to OFF, root-linter-* targets are run on Windows. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MINIFICPP-1731) Linter targets should not be built by default on Windows
[ https://issues.apache.org/jira/browse/MINIFICPP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ádám Markovics updated MINIFICPP-1731: -- Attachment: (was: consoleText) > Linter targets should not be built by default on Windows > > > Key: MINIFICPP-1731 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1731 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Ádám Markovics >Assignee: Ádám Markovics >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > A run from Jenkins is attached. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi-minifi-cpp] adam-markovics opened a new pull request #1247: MINIFICPP-1731 - Linter targets should not be built by default on Win…
adam-markovics opened a new pull request #1247: URL: https://github.com/apache/nifi-minifi-cpp/pull/1247 …dows Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-1736) Add MiNiFi agent C2 operation capabilities to agent manifest
[
https://issues.apache.org/jira/browse/MINIFICPP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi reassigned MINIFICPP-1736:
Assignee: Gábor Gyimesi
> Add MiNiFi agent C2 operation capabilities to agent manifest
>
>
> Key: MINIFICPP-1736
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1736
> Project: Apache NiFi MiNiFi C++
> Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
>
>
> Agent manifest should be extended in the following format with the agent's
> capabilities:
> {code:java}
> {
> ...
> "supportedOperations": [
> {
> "type": OperationType,
> "properties": [
> "operand": OperandType,
> "metaData": [
> {
> "key": String,
> "value": Object
> }
> ]
> ]
> }
> ]
> ...
> } {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MINIFICPP-1736) Add MiNiFi agent C2 operation capabilities to agent manifest
Gábor Gyimesi created MINIFICPP-1736:
Summary: Add MiNiFi agent C2 operation capabilities to agent
manifest
Key: MINIFICPP-1736
URL: https://issues.apache.org/jira/browse/MINIFICPP-1736
Project: Apache NiFi MiNiFi C++
Issue Type: New Feature
Reporter: Gábor Gyimesi
Agent manifest should be extended in the following format with the agent's
capabilities:
{code:java}
{
...
"supportedOperations": [
{
"type": OperationType,
"properties": [
"operand": OperandType,
"metaData": [
{
"key": String,
"value": Object
}
]
]
}
]
...
} {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution
adamdebreceni commented on a change in pull request #1237:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789487612
##
File path: extensions/script/ExecuteScript.cpp
##
@@ -123,6 +128,10 @@ void ExecuteScript::onTrigger(const
std::shared_ptr
throw std::runtime_error("No script engine available");
}
+ if (module_directory_.size()) {
Review comment:
should we use `!module_directory_.empty()`?
(or better yet `std::optional`, although I see that this member
is not a new addition)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINIFICPP-1735) Add Google Cloud Storage related processors
Martin Zink created MINIFICPP-1735: -- Summary: Add Google Cloud Storage related processors Key: MINIFICPP-1735 URL: https://issues.apache.org/jira/browse/MINIFICPP-1735 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Martin Zink Assignee: Martin Zink Minifi already support AWS and Azure, but we currently lack the support for Google Cloud Storage. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (NIFI-9613) QueryRecord fails with java.util.NoSuchElementException
[
https://issues.apache.org/jira/browse/NIFI-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-9613.
--
Fix Version/s: 1.16.0
Assignee: Pierre Villard
Resolution: Duplicate
I believe this is a duplicate of NIFI-9476. Feel free to reopen if you think
it's not the case.
> QueryRecord fails with java.util.NoSuchElementException
> ---
>
> Key: NIFI-9613
> URL: https://issues.apache.org/jira/browse/NIFI-9613
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.15.2
> Environment: Ubuntu 18.04 with openjdk-11-jre-headless
> 11.0.13+8-0ubuntu1~18.04
>Reporter: Anders Synstad
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.16.0
>
> Attachments: JSON-test.xml
>
>
> I am getting java.util.NoSuchElementException in QueryRecord under certain
> conditions using JsonTreeReader + JsonRecordSetWriter + a simple json event.
> Generating a simple flowfile with the following json using GenerateFlowFile:
> {{
> {"epoch":1642669279,"thing":[1234],"foo":"bar"}
> }}
> Using QueryRecord with the following dynamic properties work:
> {{SELECT * FROM FLOWFILE WHERE foo = 'bar'}}
> {{SELECT * FROM FLOWFILE WHERE foo LIKE 'ba%'}}
> However, using the following generates an error:
> {{SELECT * FROM FLOWFILE WHERE foo LIKE 'fo%'}}
> It appears it will fail if the WHERE clause does not find any matches in the
> flowfile.Removing {{"thing":[12345]}} from the json in the flowfile causes
> all 3 dynamic
> properties in QueryRecord to work.The error generated is:
> {code}
> 2022-01-20 10:19:25,403 ERROR [Timer-Driven Process Thread-24]
> o.a.nifi.processors.standard.QueryRecord
> QueryRecord[id=9a2539a7-14df-159f-b3f4-83787721a05f] Unable to query
> StandardFlowFileRecord[uuid=db24c0b5-e874-4a55-82a7-cbdf69b0cf5a,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1642670361821-5989894,
> container=default, section=518], offset=517544,
> length=47],offset=0,name=db24c0b5-e874-4a55-82a7-cbdf69b0cf5a,size=47] due to
> org.apache.nifi.processor.exception.ProcessException: java.sql.SQLException:
> java.util.NoSuchElementException: Expecting cursor position to be
> Position.OK, actual is Position.AFTER_END: java.util.NoSuchElementException:
> Expecting cursor position to be Position.OK, actual is Position.AFTER_END
> ↳ causes: java.sql.SQLException: java.util.NoSuchElementException: Expecting
> cursor position to be Position.OK, actual is Position.AFTER_END
> ↳ causes: org.apache.nifi.processor.exception.ProcessException:
> java.sql.SQLException: java.util.NoSuchElementException: Expecting cursor
> position to be Position.OK, actual is Position.AFTER_END
> org.apache.nifi.processor.exception.ProcessException: java.sql.SQLException:
> java.util.NoSuchElementException: Expecting cursor position to be
> Position.OK, actual is Position.AFTER_END
> at
> org.apache.nifi.processors.standard.QueryRecord$1.process(QueryRecord.java:343)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2909)
> at
> org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:332)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1273)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:63)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: java.sql.SQLException: java.util.NoSuchElementException: Expecting
> cursor position to be Position.OK, actual is Position.AFTER_END
> at
> org.apache.calcite.avatica.util.PositionedCursor$ArrayGetter.getObject(PositionedCursor.java:65)
> at
> org.apache.calcite.avatica.util.AbstractCursor$AccessorImpl.getObject(AbstractCursor.java:355)
> at
> org.apache.calcite.avatica.util.AbstractCursor$ArrayAccessor.getObject(AbstractCursor.java:1286)
> at
>
[jira] [Updated] (NIFI-9613) QueryRecord fails with java.util.NoSuchElementException
[
https://issues.apache.org/jira/browse/NIFI-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Synstad updated NIFI-9613:
-
Description:
I am getting java.util.NoSuchElementException in QueryRecord under certain
conditions using JsonTreeReader + JsonRecordSetWriter + a simple json event.
Generating a simple flowfile with the following json using GenerateFlowFile:
{{
{"epoch":1642669279,"thing":[1234],"foo":"bar"}
}}
Using QueryRecord with the following dynamic properties work:
{{SELECT * FROM FLOWFILE WHERE foo = 'bar'}}
{{SELECT * FROM FLOWFILE WHERE foo LIKE 'ba%'}}
However, using the following generates an error:
{{SELECT * FROM FLOWFILE WHERE foo LIKE 'fo%'}}
It appears it will fail if the WHERE clause does not find any matches in the
flowfile.Removing {{"thing":[12345]}} from the json in the flowfile causes all
3 dynamic
properties in QueryRecord to work.The error generated is:
{code}
2022-01-20 10:19:25,403 ERROR [Timer-Driven Process Thread-24]
o.a.nifi.processors.standard.QueryRecord
QueryRecord[id=9a2539a7-14df-159f-b3f4-83787721a05f] Unable to query
StandardFlowFileRecord[uuid=db24c0b5-e874-4a55-82a7-cbdf69b0cf5a,claim=StandardContentClaim
[resourceClaim=StandardResourceClaim[id=1642670361821-5989894,
container=default, section=518], offset=517544,
length=47],offset=0,name=db24c0b5-e874-4a55-82a7-cbdf69b0cf5a,size=47] due to
org.apache.nifi.processor.exception.ProcessException: java.sql.SQLException:
java.util.NoSuchElementException: Expecting cursor position to be Position.OK,
actual is Position.AFTER_END: java.util.NoSuchElementException: Expecting
cursor position to be Position.OK, actual is Position.AFTER_END
↳ causes: java.sql.SQLException: java.util.NoSuchElementException: Expecting
cursor position to be Position.OK, actual is Position.AFTER_END
↳ causes: org.apache.nifi.processor.exception.ProcessException:
java.sql.SQLException: java.util.NoSuchElementException: Expecting cursor
position to be Position.OK, actual is Position.AFTER_END
org.apache.nifi.processor.exception.ProcessException: java.sql.SQLException:
java.util.NoSuchElementException: Expecting cursor position to be Position.OK,
actual is Position.AFTER_END
at
org.apache.nifi.processors.standard.QueryRecord$1.process(QueryRecord.java:343)
at
org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2909)
at
org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:332)
at
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1273)
at
org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)
at
org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:63)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.sql.SQLException: java.util.NoSuchElementException: Expecting
cursor position to be Position.OK, actual is Position.AFTER_END
at
org.apache.calcite.avatica.util.PositionedCursor$ArrayGetter.getObject(PositionedCursor.java:65)
at
org.apache.calcite.avatica.util.AbstractCursor$AccessorImpl.getObject(AbstractCursor.java:355)
at
org.apache.calcite.avatica.util.AbstractCursor$ArrayAccessor.getObject(AbstractCursor.java:1286)
at
org.apache.calcite.avatica.util.AbstractCursor$ArrayAccessor.getArray(AbstractCursor.java:1354)
at
org.apache.calcite.avatica.AvaticaResultSet.getArray(AvaticaResultSet.java:729)
at
org.apache.nifi.serialization.record.ResultSetRecordSet.getArrayDataType(ResultSetRecordSet.java:295)
at
org.apache.nifi.serialization.record.ResultSetRecordSet.getDataType(ResultSetRecordSet.java:207)
at
org.apache.nifi.serialization.record.ResultSetRecordSet.createSchema(ResultSetRecordSet.java:184)
at
org.apache.nifi.serialization.record.ResultSetRecordSet.(ResultSetRecordSet.java:86)
at
org.apache.nifi.serialization.record.ResultSetRecordSet.(ResultSetRecordSet.java:71)
at
org.apache.nifi.processors.standard.QueryRecord$1.process(QueryRecord.java:339)
... 13 common frames omitted
Caused by: java.util.NoSuchElementException: Expecting cursor position to be
Position.OK, actual is Position.AFTER_END
at
org.apache.calcite.avatica.util.IteratorCursor.current(IteratorCursor.java:71)
at
[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request #1246: MINIFICPP-1732 - Protect the sink with a mutex
adamdebreceni opened a new pull request #1246: URL: https://github.com/apache/nifi-minifi-cpp/pull/1246 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-9613) QueryRecord fails with java.util.NoSuchElementException
Anders Synstad created NIFI-9613:
Summary: QueryRecord fails with java.util.NoSuchElementException
Key: NIFI-9613
URL: https://issues.apache.org/jira/browse/NIFI-9613
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Affects Versions: 1.15.2
Environment: Ubuntu 18.04 with openjdk-11-jre-headless
11.0.13+8-0ubuntu1~18.04
Reporter: Anders Synstad
Attachments: JSON-test.xml
I am getting java.util.NoSuchElementException in QueryRecord under certain
conditions using JsonTreeReader + JsonRecordSetWriter + a simple json event.
Generating a simple flowfile with the following json using GenerateFlowFile:
{{{"epoch":1642669279,"thing":[1234],"foo":"bar"}}}
Using QueryRecord with the following dynamic properties work:
{{SELECT * FROM FLOWFILE WHERE foo = 'bar'}}
{{SELECT * FROM FLOWFILE WHERE foo LIKE 'ba%'}}
However, using the following generates an error:
{{SELECT * FROM FLOWFILE WHERE foo LIKE 'fo%'}}
It appears it will fail if the WHERE clause does not find any matches in the
flowfile.Removing {{"thing":[12345]}} from the json in the flowfile causes all
3 dynamic
properties in QueryRecord to work.The error generated is:
2022-01-20 10:19:25,403 ERROR [Timer-Driven Process Thread-24]
o.a.nifi.processors.standard.QueryRecord
QueryRecord[id=9a2539a7-14df-159f-b3f4-83787721a05f] Unable to query
StandardFlowFileRecord[uuid=db24c0b5-e874-4a55-82a7-cbdf69b0cf5a,claim=StandardContentClaim
[resourceClaim=StandardResourceClaim[id=1642670361821-5989894,
container=default, section=518], offset=517544,
length=47],offset=0,name=db24c0b5-e874-4a55-82a7-cbdf69b0cf5a,size=47] due to
org.apache.nifi.processor.exception.ProcessException: java.sql.SQLException:
java.util.NoSuchElementException: Expecting cursor position to be Position.OK,
actual is Position.AFTER_END: java.util.NoSuchElementException: Expecting
cursor position to be Position.OK, actual is Position.AFTER_END
↳ causes: java.sql.SQLException: java.util.NoSuchElementException: Expecting
cursor position to be Position.OK, actual is Position.AFTER_END
↳ causes: org.apache.nifi.processor.exception.ProcessException:
java.sql.SQLException: java.util.NoSuchElementException: Expecting cursor
position to be Position.OK, actual is Position.AFTER_END
org.apache.nifi.processor.exception.ProcessException: java.sql.SQLException:
java.util.NoSuchElementException: Expecting cursor position to be Position.OK,
actual is Position.AFTER_END
at
org.apache.nifi.processors.standard.QueryRecord$1.process(QueryRecord.java:343)
at
org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2909)
at
org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:332)
at
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1273)
at
org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)
at
org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:63)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.sql.SQLException: java.util.NoSuchElementException: Expecting
cursor position to be Position.OK, actual is Position.AFTER_END
at
org.apache.calcite.avatica.util.PositionedCursor$ArrayGetter.getObject(PositionedCursor.java:65)
at
org.apache.calcite.avatica.util.AbstractCursor$AccessorImpl.getObject(AbstractCursor.java:355)
at
org.apache.calcite.avatica.util.AbstractCursor$ArrayAccessor.getObject(AbstractCursor.java:1286)
at
org.apache.calcite.avatica.util.AbstractCursor$ArrayAccessor.getArray(AbstractCursor.java:1354)
at
org.apache.calcite.avatica.AvaticaResultSet.getArray(AvaticaResultSet.java:729)
at
org.apache.nifi.serialization.record.ResultSetRecordSet.getArrayDataType(ResultSetRecordSet.java:295)
at
org.apache.nifi.serialization.record.ResultSetRecordSet.getDataType(ResultSetRecordSet.java:207)
at
org.apache.nifi.serialization.record.ResultSetRecordSet.createSchema(ResultSetRecordSet.java:184)
at
