Re: [PR] Bump org.apache.santuario:xmlsec from 2.3.3 to 2.3.4 in /nifi-nar-bundles/nifi-framework-bundle [nifi]
exceptionfactory commented on PR #7917: URL: https://github.com/apache/nifi/pull/7917#issuecomment-1773603953 Closing in favor of #7916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.santuario:xmlsec from 2.3.3 to 2.3.4 in /nifi-nar-bundles/nifi-framework-bundle [nifi]
dependabot[bot] commented on PR #7917: URL: https://github.com/apache/nifi/pull/7917#issuecomment-1773603978 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.santuario:xmlsec from 2.3.3 to 2.3.4 in /nifi-nar-bundles/nifi-framework-bundle [nifi]
exceptionfactory closed pull request #7917: Bump org.apache.santuario:xmlsec from 2.3.3 to 2.3.4 in /nifi-nar-bundles/nifi-framework-bundle URL: https://github.com/apache/nifi/pull/7917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.santuario:xmlsec from 2.3.3 to 2.3.4 in /nifi-nar-bundles/nifi-framework-bundle [nifi]
dependabot[bot] opened a new pull request, #7917: URL: https://github.com/apache/nifi/pull/7917 Bumps org.apache.santuario:xmlsec from 2.3.3 to 2.3.4. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/nifi/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2248 Refactor string::join_pack [nifi-minifi-cpp]
szaszm commented on code in PR #1680: URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1367522637 ## CPPLINT.cfg: ## @@ -1,2 +1,2 @@ set noparent -filter=-runtime/reference,-runtime/string,-build/c++11,-build/include_subdir,-whitespace/forcolon,-build/namespaces_literals,-readability/check,-build/include_what_you_use,-readability/nolint +filter=-runtime/reference,-runtime/string,-build/c++11,-build/include_subdir,-whitespace/forcolon,-build/namespaces_literals,-readability/check,-build/include_what_you_use,-readability/nolint,-readability/braces Review Comment: To be honest, I have the feeling that we would be better off by dropping cpplint, and rely more on clang-tidy, especially as you recent changes in #1671 get ready and do the google-specific checks. Too many false positives, and it looks outdated barely maintained. On the other hand, it runs much faster than clang-tidy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2248 Refactor string::join_pack [nifi-minifi-cpp]
szaszm commented on code in PR #1680: URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1367522637 ## CPPLINT.cfg: ## @@ -1,2 +1,2 @@ set noparent -filter=-runtime/reference,-runtime/string,-build/c++11,-build/include_subdir,-whitespace/forcolon,-build/namespaces_literals,-readability/check,-build/include_what_you_use,-readability/nolint +filter=-runtime/reference,-runtime/string,-build/c++11,-build/include_subdir,-whitespace/forcolon,-build/namespaces_literals,-readability/check,-build/include_what_you_use,-readability/nolint,-readability/braces Review Comment: To be honest, I have the feeling that we would be better off by dropping cpplint, and rely more on clang-tidy, especially as you recent changes in #1671 get ready and do the google-specific checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1825#comment-1825
]
Daniel Stieglitz edited comment on NIFI-11627 at 10/20/23 7:09 PM:
---
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this? Studying the code it seems AmazonGlueSchemaRegistry and
ConfluentSchemaRegistry can be reused as they are not specific to any schema
type but AvroSchemaRegistry cannot as it is specific to Avro. I assume in lieu
of the AvroSchemaRegistry I would need to develop a JsonSchemaRegistry. If this
is so where do I place this new ControllerService?
Please confirm. Thanks!
was (Author: JIRAUSER294662):
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this? Studying the code it seems AmazonGlueSchemaRegistry and
ConfluentSchemaRegistry can be reused as they are not specific to any schema
type but AvroSchemaRegistry cannot as it is specific to Avro. I assume in lieu
of the AvroSchemaRegistry I would need to develop a JsonSchemaRegistry.
Please confirm. Thanks!
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1825#comment-1825
]
Daniel Stieglitz edited comment on NIFI-11627 at 10/20/23 7:08 PM:
---
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this? Studying the code it seems AmazonGlueSchemaRegistry and
ConfluentSchemaRegistry can be reused as they are not specific to any schema
type but AvroSchemaRegistry cannot as it is specific to Avro. I assume in lieu
of the AvroSchemaRegistry I would need to develop a JsonSchemaRegistry.
Please confirm. Thanks!
was (Author: JIRAUSER294662):
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this?
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1825#comment-1825
]
Daniel Stieglitz edited comment on NIFI-11627 at 10/20/23 7:01 PM:
---
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this?
was (Author: JIRAUSER294662):
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this?
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11874) Reorganize UI presentation of Process Group configuration
[ https://issues.apache.org/jira/browse/NIFI-11874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1911#comment-1911 ] ASF subversion and git services commented on NIFI-11874: Commit 0e806a19a18024c495516cd0f0f276a959fc328f in nifi's branch refs/heads/support/nifi-1.x from markobean [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0e806a19a1 ] NIFI-11874: update process group configuration dialog UI, specific to nifi-1.x line (#7844) This closes #7844 > Reorganize UI presentation of Process Group configuration > - > > Key: NIFI-11874 > URL: https://issues.apache.org/jira/browse/NIFI-11874 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.23.0 >Reporter: Mark Bean >Assignee: Mark Bean >Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > > When configuring a Process Group, the configuration options scroll off the > screen. Of course, this depends on the user's display resolution. However, on > many common display configurations, this results in the options scrolling off > a single screen view. > Recommend creating two columns of configuration settings so they are more > likely to fit on a single dialog window without needing to scroll - in > particular the "Apply" button. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11874: update process group configuration dialog UI, specific to nifi-1.x line [nifi]
mcgilman merged PR #7844: URL: https://github.com/apache/nifi/pull/7844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12260) UI - Remove leftover templates code from frontend
[ https://issues.apache.org/jira/browse/NIFI-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated NIFI-12260: Description: NIFI-12006 ([https://github.com/apache/nifi/pull/7658]) removed templates from NiFi, but there is still some leftover code related to templates in the frontend code. (was: NIFI-12006 (https://github.com/apache/nifi/pull/7658) removed templates from NiFi, but there is still some leftover code related to templates in the frontend code.) > UI - Remove leftover templates code from frontend > - > > Key: NIFI-12260 > URL: https://issues.apache.org/jira/browse/NIFI-12260 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > Fix For: 2.0.0 > > > NIFI-12006 ([https://github.com/apache/nifi/pull/7658]) removed templates > from NiFi, but there is still some leftover code related to templates in the > frontend code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12260) UI - Remove leftover templates code from frontend
Shane Ardell created NIFI-12260: --- Summary: UI - Remove leftover templates code from frontend Key: NIFI-12260 URL: https://issues.apache.org/jira/browse/NIFI-12260 Project: Apache NiFi Issue Type: Improvement Components: Core UI Reporter: Shane Ardell Assignee: Shane Ardell Fix For: 2.0.0 NIFI-12006 (https://github.com/apache/nifi/pull/7658) removed templates from NiFi, but there is still some leftover code related to templates in the frontend code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12246) Bump @babel/traverse version
[ https://issues.apache.org/jira/browse/NIFI-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman resolved NIFI-12246. Resolution: Fixed > Bump @babel/traverse version > > > Key: NIFI-12246 > URL: https://issues.apache.org/jira/browse/NIFI-12246 > Project: Apache NiFi > Issue Type: Task >Reporter: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/nifi/pull/7897 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12246 - Bump @babel/traverse from 7.21.2 to 7.23.2 in /nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main [nifi]
mcgilman merged PR #7897: URL: https://github.com/apache/nifi/pull/7897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11463 Allow IdentifyMimeType to use custom MIME types in addition to defaults [nifi]
NissimShiman commented on PR #7781:
URL: https://github.com/apache/nifi/pull/7781#issuecomment-1773201080
Thank you @exceptionfactory for all the cycles spent to improve this PR and
for pointing out the new `migrateProperties()` feature This is really neat
addition.
Unfortunately I am running into some undesired behaviour when trying to
implement.
The code is:
```
@Override
public void migrateProperties(PropertyConfiguration config) {
if (!config.hasProperty(CONFIG_STRATEGY)) {
if (config.isPropertySet(MIME_CONFIG_FILE) ||
config.isPropertySet(MIME_CONFIG_BODY)) {
config.setProperty(CONFIG_STRATEGY, REPLACE.getValue());
}
}
}
```
For some reason, the first `if` is always evaluating as false, even when
migrating from a 1.x flow.
Still looking into this.
(The first `if` needs to be there as `PRESET` can have `CONFIG_BODY` /
`CONFIG_FILE`, set but they will be ignored. Without the first `if`, these
will become `REPLACE` on a nifi bounce.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1825#comment-1825
]
Daniel Stieglitz edited comment on NIFI-11627 at 10/20/23 6:06 PM:
---
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this?
was (Author: JIRAUSER294662):
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, would an in memory map similar to the AvroSchemaRegistry
be okay?
Can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this?
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-11874: update process group configuration dialog UI, specific to nifi-1.x line [nifi]
mcgilman commented on PR #7844: URL: https://github.com/apache/nifi/pull/7844#issuecomment-1773151007 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11874 update Process Group configuration layout in the UI [nifi]
markobean commented on code in PR #7591:
URL: https://github.com/apache/nifi/pull/7591#discussion_r1367330143
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/process-group-configuration.css:
##
@@ -87,7 +95,6 @@
}
#parameter-contexts-recursive-container {
-float: left;
Review Comment:
Thanks @mcgilman !
Would you mind taking a look/merging the PR for nifi-1.x as well so this can
get into the 1.24.0 release?
#7844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11874 update Process Group configuration layout in the UI [nifi]
mcgilman commented on PR #7591: URL: https://github.com/apache/nifi/pull/7591#issuecomment-1773149872 @exceptionfactory CI was apparently not run because you had requested changes. I just manually triggered it. I plan to merge this one once CI completes unless you had any other concerns. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11874 update Process Group configuration layout in the UI [nifi]
mcgilman commented on code in PR #7591:
URL: https://github.com/apache/nifi/pull/7591#discussion_r1367328075
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/process-group-configuration.css:
##
@@ -87,7 +95,6 @@
}
#parameter-contexts-recursive-container {
-float: left;
Review Comment:
I see. It is because the elements inside
`parameter-contexts-recursive-container` are floated left. It would probably be
clearer if the `div.clear` were the last element in that element but it's ok.
I'll merge this one. Thanks again for the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11874 update Process Group configuration layout in the UI [nifi]
mcgilman commented on code in PR #7591:
URL: https://github.com/apache/nifi/pull/7591#discussion_r1367323039
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/process-group-configuration.css:
##
@@ -87,7 +95,6 @@
}
#parameter-contexts-recursive-container {
-float: left;
Review Comment:
I'll take a look. But if nothing is floating (which should be the case now)
then there should be no need to clear. But maybe I missed something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12239) Print basic OS/Java details in bootstrap log file
[
https://issues.apache.org/jira/browse/NIFI-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12239:
Fix Version/s: 2.0.0
1.24.0
(was: 1.latest)
(was: 2.latest)
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Print basic OS/Java details in bootstrap log file
> -
>
> Key: NIFI-12239
> URL: https://issues.apache.org/jira/browse/NIFI-12239
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 2.0.0, 1.24.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The goal here is to add a log line in the bootstrap.log file when NiFi starts
> that is printing some basic OS/Java details. On busy clusters, nifi-app.log
> may be rolling over quickly and/or contain huge amount of data. Adding this
> data in the bootstrap log file makes it easy to retrieve.
> The associated PR will add a log line as below:
> {code:java}
> 2023-10-17 17:26:33,501 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> {"javaVersion":"21","cores":16,"totalPhysicalMemoryMB":16384,"maxOpenFileDescriptors":10240,"xms":"1g","xmx":"1g"}
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12239) Print basic OS/Java details in bootstrap log file
[
https://issues.apache.org/jira/browse/NIFI-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1888#comment-1888
]
ASF subversion and git services commented on NIFI-12239:
Commit 17738df3b06c4fb7933dfc59281857016fbccfe6 in nifi's branch
refs/heads/support/nifi-1.x from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=17738df3b0 ]
NIFI-12239 Add OS and Java details at startup in bootstrap log
This closes #7891
Signed-off-by: David Handermann
(cherry picked from commit e4e2336ebe022ee8f42cd29b52d6e210c9ceb24c)
> Print basic OS/Java details in bootstrap log file
> -
>
> Key: NIFI-12239
> URL: https://issues.apache.org/jira/browse/NIFI-12239
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The goal here is to add a log line in the bootstrap.log file when NiFi starts
> that is printing some basic OS/Java details. On busy clusters, nifi-app.log
> may be rolling over quickly and/or contain huge amount of data. Adding this
> data in the bootstrap log file makes it easy to retrieve.
> The associated PR will add a log line as below:
> {code:java}
> 2023-10-17 17:26:33,501 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> {"javaVersion":"21","cores":16,"totalPhysicalMemoryMB":16384,"maxOpenFileDescriptors":10240,"xms":"1g","xmx":"1g"}
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]
exceptionfactory closed pull request #7891: NIFI-12239 - Add OS/Java details at startup in bootstrap log URL: https://github.com/apache/nifi/pull/7891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12239) Print basic OS/Java details in bootstrap log file
[
https://issues.apache.org/jira/browse/NIFI-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1885#comment-1885
]
ASF subversion and git services commented on NIFI-12239:
Commit e4e2336ebe022ee8f42cd29b52d6e210c9ceb24c in nifi's branch
refs/heads/main from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e4e2336ebe ]
NIFI-12239 Add OS and Java details at startup in bootstrap log
This closes #7891
Signed-off-by: David Handermann
> Print basic OS/Java details in bootstrap log file
> -
>
> Key: NIFI-12239
> URL: https://issues.apache.org/jira/browse/NIFI-12239
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The goal here is to add a log line in the bootstrap.log file when NiFi starts
> that is printing some basic OS/Java details. On busy clusters, nifi-app.log
> may be rolling over quickly and/or contain huge amount of data. Adding this
> data in the bootstrap log file makes it easy to retrieve.
> The associated PR will add a log line as below:
> {code:java}
> 2023-10-17 17:26:33,501 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> {"javaVersion":"21","cores":16,"totalPhysicalMemoryMB":16384,"maxOpenFileDescriptors":10240,"xms":"1g","xmx":"1g"}
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12259) Upgrade Santuario XML to 2.3.4
[ https://issues.apache.org/jira/browse/NIFI-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12259: Status: Patch Available (was: Open) > Upgrade Santuario XML to 2.3.4 > -- > > Key: NIFI-12259 > URL: https://issues.apache.org/jira/browse/NIFI-12259 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: dependency-upgrade > Fix For: 2.0.0, 1.24.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Santuario 2.3.4 includes a resolution for CVE-2023-44483, which > relates to logging sensitive private key information at the debug level. > Spring Security SAML2 has a dependency on Apache Santuario, which should be > upgraded. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12259 Upgrade Apache Santuario from 2.3.3 to 2.3.4 [nifi]
exceptionfactory opened a new pull request, #7916: URL: https://github.com/apache/nifi/pull/7916 # Summary [NIFI-12259](https://issues.apache.org/jira/browse/NIFI-12259) Upgrades Apache Santuario XML Security from 2.3.3 to 2.3.4 to resolve CVE-2023-44483, related to sensitive information disclosure in debug log messages. This upgrade applies to both main and support branches. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12259) Upgrade Santuario XML to 2.3.4
David Handermann created NIFI-12259: --- Summary: Upgrade Santuario XML to 2.3.4 Key: NIFI-12259 URL: https://issues.apache.org/jira/browse/NIFI-12259 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Reporter: David Handermann Assignee: David Handermann Fix For: 2.0.0, 1.24.0 Apache Santuario 2.3.4 includes a resolution for CVE-2023-44483, which relates to logging sensitive private key information at the debug level. Spring Security SAML2 has a dependency on Apache Santuario, which should be upgraded. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-8606 Added Stop & Configure button to the Controller Services De… [nifi]
mosermw commented on PR #7562: URL: https://github.com/apache/nifi/pull/7562#issuecomment-1773061142 I tested this on the support/nifi-1.x branch and this code works as expected there, too. I would still like another javascript dev to review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11197 Initial check in for Yaml record reader [nifi]
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367234754
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonParserFactory.java:
##
@@ -23,27 +23,20 @@
import java.io.IOException;
import java.io.InputStream;
+import java.util.Objects;
-public class JsonParserFactory implements TokenParserFactory{
-private static final JsonFactory JSON_FACTORY = new JsonFactory();
-private static final ObjectMapper JSON_MAPPER = new ObjectMapper();
-
+public class JsonParserFactory implements TokenParserFactory {
@Override
-public JsonParser getJsonParser(InputStream in) throws IOException {
-JsonParser jsonParser = JSON_FACTORY.createParser(in);
-jsonParser.setCodec(JSON_MAPPER);
-
-return jsonParser;
-}
+public JsonParser getJsonParser(final InputStream in, final
StreamReadConstraints streamReadConstraints, final boolean allowComments)
throws IOException {
+Objects.requireNonNull(in, "Input Stream required");
+Objects.requireNonNull(streamReadConstraints, "Stream Read Constraints
required");
-@Override
-public ObjectMapper createCodec(boolean allowComments,
StreamReadConstraints streamReadConstraints) {
-ObjectMapper codec = new ObjectMapper();
-if(allowComments) {
-codec.enable(JsonParser.Feature.ALLOW_COMMENTS);
+final ObjectMapper objectMapper = new ObjectMapper();
+
objectMapper.getFactory().setStreamReadConstraints(streamReadConstraints);
+if (allowComments) {
+objectMapper.enable(JsonParser.Feature.ALLOW_COMMENTS);
}
-codec.getFactory().setStreamReadConstraints(streamReadConstraints);
-
-return codec;
+final JsonFactory jsonFactory = objectMapper.getFactory();
+return jsonFactory.createParser(in);
Review Comment:
Thanks for noting the previous approach. The line calling `setCodec()` was
unchanged in the most recent updates for NIFI-12153, but it actually should
have been removed as part of the changes to incorporate the constraint
settings. So in this case, it is an opportunity to correct the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12258) Upgrade SSHD to 2.11.0
[ https://issues.apache.org/jira/browse/NIFI-12258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1857#comment-1857 ] ASF subversion and git services commented on NIFI-12258: Commit f9615414bd750621977de7386eaa3a64019fa6a8 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f9615414bd ] NIFI-12258 Upgraded MINA SSHD from 2.10.0 to 2.11.0 Signed-off-by: Pierre Villard This closes #7915. > Upgrade SSHD to 2.11.0 > -- > > Key: NIFI-12258 > URL: https://issues.apache.org/jira/browse/NIFI-12258 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: dependency-upgrade > Fix For: 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache MINA SSHD dependencies should be upgraded to 2.11.0 on the main branch > to mitgate CVE-2023-35887. The vulnerability applies to SFTP server > implementations and is not directly applicable to transitive usage in NiFi > Registry, but upgrading mitigates version-based vulnerability findings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12258) Upgrade SSHD to 2.11.0
[ https://issues.apache.org/jira/browse/NIFI-12258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12258: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade SSHD to 2.11.0 > -- > > Key: NIFI-12258 > URL: https://issues.apache.org/jira/browse/NIFI-12258 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: dependency-upgrade > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache MINA SSHD dependencies should be upgraded to 2.11.0 on the main branch > to mitgate CVE-2023-35887. The vulnerability applies to SFTP server > implementations and is not directly applicable to transitive usage in NiFi > Registry, but upgrading mitigates version-based vulnerability findings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12258 Upgrade MINA SSHD from 2.10.0 to 2.11.0 for Main Branch [nifi]
asfgit closed pull request #7915: NIFI-12258 Upgrade MINA SSHD from 2.10.0 to 2.11.0 for Main Branch URL: https://github.com/apache/nifi/pull/7915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-1891 Integrate google clang-tidy checks in CI [nifi-minifi-cpp]
fgerlits commented on code in PR #1671:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1367165495
##
libminifi/src/core/ProcessSession.cpp:
##
@@ -175,7 +175,7 @@ std::shared_ptr
ProcessSession::cloneDuringTransfer(const std::s
}
std::shared_ptr ProcessSession::clone(const
std::shared_ptr , int64_t offset, int64_t size) {
- if ((uint64_t) (offset + size) > parent->getSize()) {
+ if (static_cast(offset + size) > parent->getSize()) {
Review Comment:
I would use `gsl::narrow` here, too
##
extensions/sftp/tests/PutSFTPTests.cpp:
##
@@ -201,7 +201,7 @@ class PutSFTPTestsFixture {
namespace {
std::size_t directoryContentCount(const std::filesystem::path& dir) {
- return (std::size_t)std::distance(std::filesystem::directory_iterator{dir},
std::filesystem::directory_iterator{});
+ return
static_cast(std::distance(std::filesystem::directory_iterator{dir},
std::filesystem::directory_iterator{}));
Review Comment:
`gsl::narrow` may be more appropriate here: if the distance is negative for
some strange reason, it's better to crash than to return a huge number
##
libminifi/src/core/flow/StructuredConfiguration.cpp:
##
@@ -266,10 +266,10 @@ void StructuredConfiguration::parseProcessorNode(const
Node& processors_node, co
logger_->log_debug("setting scheduling strategy as {}",
procCfg.schedulingStrategy);
}
-int32_t maxConcurrentTasks;
+int32_t maxConcurrentTasks = 0;
if (core::Property::StringToInt(procCfg.maxConcurrentTasks,
maxConcurrentTasks)) {
logger_->log_debug("parseProcessorNode: maxConcurrentTasks => [{}]",
maxConcurrentTasks);
- processor->setMaxConcurrentTasks((uint8_t) maxConcurrentTasks);
+
processor->setMaxConcurrentTasks(static_cast(maxConcurrentTasks));
}
Review Comment:
would
```c++
uint8_t maxConcurrentTasks;
if (core::Property::StringToInt(procCfg.maxConcurrentTasks,
maxConcurrentTasks)) {
logger_->log_debug("parseProcessorNode: maxConcurrentTasks => [{}]",
maxConcurrentTasks);
processor->setMaxConcurrentTasks(maxConcurrentTasks);
}
```
work? I think that would be better, if it works.
##
libminifi/src/provenance/Provenance.cpp:
##
@@ -249,17 +249,17 @@ bool ProvenanceEventRecord::deserialize(io::InputStream
_stream) {
}
}
- uint32_t eventType;
+ uint32_t eventType = 0;
{
const auto ret = input_stream.read(eventType);
if (ret != 4) {
return false;
}
}
- this->_eventType = (ProvenanceEventRecord::ProvenanceEventType) eventType;
+ _eventType =
static_cast(eventType);
Review Comment:
we could check this:
```suggestion
if (auto event_type_opt =
magic_enum::enum_cast(eventType)) {
_eventType = *event_type_opt;
} else {
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11197 Initial check in for Yaml record reader [nifi]
dan-s1 commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367185418
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonParserFactory.java:
##
@@ -23,27 +23,20 @@
import java.io.IOException;
import java.io.InputStream;
+import java.util.Objects;
-public class JsonParserFactory implements TokenParserFactory{
-private static final JsonFactory JSON_FACTORY = new JsonFactory();
-private static final ObjectMapper JSON_MAPPER = new ObjectMapper();
-
+public class JsonParserFactory implements TokenParserFactory {
@Override
-public JsonParser getJsonParser(InputStream in) throws IOException {
-JsonParser jsonParser = JSON_FACTORY.createParser(in);
-jsonParser.setCodec(JSON_MAPPER);
-
-return jsonParser;
-}
+public JsonParser getJsonParser(final InputStream in, final
StreamReadConstraints streamReadConstraints, final boolean allowComments)
throws IOException {
+Objects.requireNonNull(in, "Input Stream required");
+Objects.requireNonNull(streamReadConstraints, "Stream Read Constraints
required");
-@Override
-public ObjectMapper createCodec(boolean allowComments,
StreamReadConstraints streamReadConstraints) {
-ObjectMapper codec = new ObjectMapper();
-if(allowComments) {
-codec.enable(JsonParser.Feature.ALLOW_COMMENTS);
+final ObjectMapper objectMapper = new ObjectMapper();
+
objectMapper.getFactory().setStreamReadConstraints(streamReadConstraints);
+if (allowComments) {
+objectMapper.enable(JsonParser.Feature.ALLOW_COMMENTS);
}
-codec.getFactory().setStreamReadConstraints(streamReadConstraints);
-
-return codec;
+final JsonFactory jsonFactory = objectMapper.getFactory();
+return jsonFactory.createParser(in);
Review Comment:
In the previous code also the `JsonFactory` was coming from the
`ObjectMapper`and yet `setCodec` was still called. See the previous line 145:
`jsonParser = codec.getFactory().createParser(in);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11197 Initial check in for Yaml record reader [nifi]
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367180160
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonRecordSource.java:
##
@@ -29,6 +30,11 @@
public class JsonRecordSource implements RecordSource {
private static final Logger logger =
LoggerFactory.getLogger(JsonRecordSource.class);
Review Comment:
There have been discussions in the past around casing for the `Logger` in
particular. The general trend is having the `logger` lowercase, even when
static, but of course actual constants should be uppercase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11197 Initial check in for Yaml record reader [nifi]
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367179198
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonParserFactory.java:
##
@@ -23,27 +23,20 @@
import java.io.IOException;
import java.io.InputStream;
+import java.util.Objects;
-public class JsonParserFactory implements TokenParserFactory{
-private static final JsonFactory JSON_FACTORY = new JsonFactory();
-private static final ObjectMapper JSON_MAPPER = new ObjectMapper();
-
+public class JsonParserFactory implements TokenParserFactory {
@Override
-public JsonParser getJsonParser(InputStream in) throws IOException {
-JsonParser jsonParser = JSON_FACTORY.createParser(in);
-jsonParser.setCodec(JSON_MAPPER);
-
-return jsonParser;
-}
+public JsonParser getJsonParser(final InputStream in, final
StreamReadConstraints streamReadConstraints, final boolean allowComments)
throws IOException {
+Objects.requireNonNull(in, "Input Stream required");
+Objects.requireNonNull(streamReadConstraints, "Stream Read Constraints
required");
-@Override
-public ObjectMapper createCodec(boolean allowComments,
StreamReadConstraints streamReadConstraints) {
-ObjectMapper codec = new ObjectMapper();
-if(allowComments) {
-codec.enable(JsonParser.Feature.ALLOW_COMMENTS);
+final ObjectMapper objectMapper = new ObjectMapper();
+
objectMapper.getFactory().setStreamReadConstraints(streamReadConstraints);
+if (allowComments) {
+objectMapper.enable(JsonParser.Feature.ALLOW_COMMENTS);
}
-codec.getFactory().setStreamReadConstraints(streamReadConstraints);
-
-return codec;
+final JsonFactory jsonFactory = objectMapper.getFactory();
+return jsonFactory.createParser(in);
Review Comment:
Setting the codec is not necessary because the `JsonFactory` is coming from
the `ObjectMapper`, as opposed to the other way around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11197 Initial check in for Yaml record reader [nifi]
dan-s1 commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367170067
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonRecordSource.java:
##
@@ -29,6 +30,11 @@
public class JsonRecordSource implements RecordSource {
private static final Logger logger =
LoggerFactory.getLogger(JsonRecordSource.class);
Review Comment:
If the added static final private variables below are uppercase, this should
also be for consistency.
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonParserFactory.java:
##
@@ -23,27 +23,20 @@
import java.io.IOException;
import java.io.InputStream;
+import java.util.Objects;
-public class JsonParserFactory implements TokenParserFactory{
-private static final JsonFactory JSON_FACTORY = new JsonFactory();
-private static final ObjectMapper JSON_MAPPER = new ObjectMapper();
-
+public class JsonParserFactory implements TokenParserFactory {
@Override
-public JsonParser getJsonParser(InputStream in) throws IOException {
-JsonParser jsonParser = JSON_FACTORY.createParser(in);
-jsonParser.setCodec(JSON_MAPPER);
-
-return jsonParser;
-}
+public JsonParser getJsonParser(final InputStream in, final
StreamReadConstraints streamReadConstraints, final boolean allowComments)
throws IOException {
+Objects.requireNonNull(in, "Input Stream required");
+Objects.requireNonNull(streamReadConstraints, "Stream Read Constraints
required");
-@Override
-public ObjectMapper createCodec(boolean allowComments,
StreamReadConstraints streamReadConstraints) {
-ObjectMapper codec = new ObjectMapper();
-if(allowComments) {
-codec.enable(JsonParser.Feature.ALLOW_COMMENTS);
+final ObjectMapper objectMapper = new ObjectMapper();
+
objectMapper.getFactory().setStreamReadConstraints(streamReadConstraints);
+if (allowComments) {
+objectMapper.enable(JsonParser.Feature.ALLOW_COMMENTS);
}
-codec.getFactory().setStreamReadConstraints(streamReadConstraints);
-
-return codec;
+final JsonFactory jsonFactory = objectMapper.getFactory();
+return jsonFactory.createParser(in);
Review Comment:
The previous code in `AbstractJsonRowRecordReader.java` formally on line 146
when creating the jsonParser also called `setCodec`. Shouldn't you have
something similar here?
Instead of
` return jsonFactory.createParser(in);`
change to
```
final JsonParser jsonParser = jsonFactory.createParser(in);
jsonParser.setCodec(objectMapper);
return jsonParser;
```
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/TokenParserFactory.java:
##
@@ -18,13 +18,19 @@
import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.core.StreamReadConstraints;
-import com.fasterxml.jackson.databind.ObjectMapper;
import java.io.IOException;
import java.io.InputStream;
public interface TokenParserFactory {
-JsonParser getJsonParser(InputStream in) throws IOException;
-
-ObjectMapper createCodec(boolean allowComments, StreamReadConstraints
streamReadConstraints);
+/**
+ * Get JSON Parser implementation for provided Input Stream with
configured settings
+ *
+ * @param in Input Stream to be parsed
+ * @param streamReadConstraints Stream Read Constraints applied
+ * @param allowComments Whether to allow comments when parsing
+ * @return JSON Parser
+ * @throws IOException Thrown on failures ot read the Input Stream
Review Comment:
Instead of
`@throws IOException Thrown on failures ot read the Input Stream`
this should be
`@throws IOException Thrown on failures to read the Input Stream`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12257) Upgrade SSHD to 2.9.3
[ https://issues.apache.org/jira/browse/NIFI-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12257: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade SSHD to 2.9.3 > - > > Key: NIFI-12257 > URL: https://issues.apache.org/jira/browse/NIFI-12257 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.24.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Apache MINA SSHD dependencies should be upgraded to 2.9.3 on the support > branch to mitgate CVE-2023-35887. The vulnerability applies to SFTP server > implementations and is not directly applicable to transitive usage in NiFi > Registry, but upgrading mitigates version-based vulnerability findings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12257) Upgrade SSHD to 2.9.3
[ https://issues.apache.org/jira/browse/NIFI-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1843#comment-1843 ] ASF subversion and git services commented on NIFI-12257: Commit f4722f4d300c3f000aa172f7ac224274238b716b in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f4722f4d30 ] NIFI-12257 Upgraded MINA SSHD from 2.9.2 to 2.9.3 - SSHD 2.9.3 applies to JGit 5 for Java 8 - Upgraded SSHD from 2.10.0 to 2.11.0 for test components Signed-off-by: Pierre Villard This closes #7914. > Upgrade SSHD to 2.9.3 > - > > Key: NIFI-12257 > URL: https://issues.apache.org/jira/browse/NIFI-12257 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.24.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache MINA SSHD dependencies should be upgraded to 2.9.3 on the support > branch to mitgate CVE-2023-35887. The vulnerability applies to SFTP server > implementations and is not directly applicable to transitive usage in NiFi > Registry, but upgrading mitigates version-based vulnerability findings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12257 Upgrade MINA SSHD from 2.9.2 to 2.9.3 for Support Branch [nifi]
pvillard31 commented on PR #7914: URL: https://github.com/apache/nifi/pull/7914#issuecomment-1772966777 Merged to support branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12257 Upgrade MINA SSHD from 2.9.2 to 2.9.3 for Support Branch [nifi]
pvillard31 closed pull request #7914: NIFI-12257 Upgrade MINA SSHD from 2.9.2 to 2.9.3 for Support Branch URL: https://github.com/apache/nifi/pull/7914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12087) Remove all deprecated items in the nifi-api
[ https://issues.apache.org/jira/browse/NIFI-12087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1841#comment-1841 ] Mark Payne commented on NIFI-12087: --- The last of these should be addressed by NIFI-12245, which has a PR up now. > Remove all deprecated items in the nifi-api > --- > > Key: NIFI-12087 > URL: https://issues.apache.org/jira/browse/NIFI-12087 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-8981) Review TODO Comments and Deprecations
[ https://issues.apache.org/jira/browse/NIFI-8981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8981: - Fix Version/s: 2.latest (was: 2.0.0) > Review TODO Comments and Deprecations > - > > Key: NIFI-8981 > URL: https://issues.apache.org/jira/browse/NIFI-8981 > Project: Apache NiFi > Issue Type: Task >Reporter: Andrew Atwood >Priority: Minor > Fix For: 2.latest > > > Once NiFi 2.0 plans are stable, all of the TODOs in the project should be > evaluated (Hopefully assignee's IDE can show all TODOs). > For example, currently Java 11 requirement is being planned for NiFi 2.0 > release, and I find lots of TODO comments saying to remove something when > minimum Java version is 11. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11170) Support Migration for Upgrading Flows to 2.0.0
[ https://issues.apache.org/jira/browse/NIFI-11170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11170: Priority: Major (was: Critical) > Support Migration for Upgrading Flows to 2.0.0 > -- > > Key: NIFI-11170 > URL: https://issues.apache.org/jira/browse/NIFI-11170 > Project: Apache NiFi > Issue Type: Epic >Reporter: David Handermann >Priority: Major > Fix For: 2.latest > > > Migration tools and documentation should be created to streamline the process > of upgrading to 2.0.0. > Supporting migration includes the following priorities outlined in the [NiFi > 2.0 Release > Goals|https://cwiki.apache.org/confluence/display/NIFI/NiFi+2.0+Release+Goals]: > * Implement automated migration where possible to remap properties and > features > * Implement migration tools for manual conversion of XML Templates to JSON > Flow Definitions > * Create documentation for manual steps necessary where programmatic > migration cannot be implemented > * NiFi 2.0 should be capable of starting with ghosted components for removed > Processors or Controller Services -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11170) Support Migration for Upgrading Flows to 2.0.0
[ https://issues.apache.org/jira/browse/NIFI-11170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11170: Fix Version/s: 2.latest (was: 2.0.0) > Support Migration for Upgrading Flows to 2.0.0 > -- > > Key: NIFI-11170 > URL: https://issues.apache.org/jira/browse/NIFI-11170 > Project: Apache NiFi > Issue Type: Epic >Reporter: David Handermann >Priority: Critical > Fix For: 2.latest > > > Migration tools and documentation should be created to streamline the process > of upgrading to 2.0.0. > Supporting migration includes the following priorities outlined in the [NiFi > 2.0 Release > Goals|https://cwiki.apache.org/confluence/display/NIFI/NiFi+2.0+Release+Goals]: > * Implement automated migration where possible to remap properties and > features > * Implement migration tools for manual conversion of XML Templates to JSON > Flow Definitions > * Create documentation for manual steps necessary where programmatic > migration cannot be implemented > * NiFi 2.0 should be capable of starting with ghosted components for removed > Processors or Controller Services -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12242) Allow ControlRate to optionally route to a new 'rate exceeded' relationship instead of just slowing things down
[ https://issues.apache.org/jira/browse/NIFI-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser updated NIFI-12242: --- Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Allow ControlRate to optionally route to a new 'rate exceeded' relationship > instead of just slowing things down > --- > > Key: NIFI-12242 > URL: https://issues.apache.org/jira/browse/NIFI-12242 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > ControlRate provides the ability to slow down the rate of data through the > system. This is important in cases where we want to avoid overwhelming a > downstream system. However, there are times when we don't want to just slow > down the flow of data but instead reject it if the rate is too high. > Take, for example, the typical case with an HTTP Server that responds with a > 429: Too Many Requests status code. ControlRate should give us the option of > rejecting FlowFiles when they exceed the limit, not just slow everything down. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11170) Support Migration for Upgrading Flows to 2.0.0
[ https://issues.apache.org/jira/browse/NIFI-11170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1838#comment-1838 ] Mark Payne commented on NIFI-11170: --- The documentation for manual steps necessary can be found at: [https://cwiki.apache.org/confluence/display/NIFI/Migrating+Deprecated+Components+and+Features+for+2.0.0] > Support Migration for Upgrading Flows to 2.0.0 > -- > > Key: NIFI-11170 > URL: https://issues.apache.org/jira/browse/NIFI-11170 > Project: Apache NiFi > Issue Type: Epic >Reporter: David Handermann >Priority: Critical > Fix For: 2.0.0 > > > Migration tools and documentation should be created to streamline the process > of upgrading to 2.0.0. > Supporting migration includes the following priorities outlined in the [NiFi > 2.0 Release > Goals|https://cwiki.apache.org/confluence/display/NIFI/NiFi+2.0+Release+Goals]: > * Implement automated migration where possible to remap properties and > features > * Implement migration tools for manual conversion of XML Templates to JSON > Flow Definitions > * Create documentation for manual steps necessary where programmatic > migration cannot be implemented > * NiFi 2.0 should be capable of starting with ghosted components for removed > Processors or Controller Services -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12242) Allow ControlRate to optionally route to a new 'rate exceeded' relationship instead of just slowing things down
[ https://issues.apache.org/jira/browse/NIFI-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1839#comment-1839 ] ASF subversion and git services commented on NIFI-12242: Commit 40ac38dfe3b12376050fd09f8017cea52bcb7943 in nifi's branch refs/heads/main from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=40ac38dfe3 ] NIFI-12242: Added ability to route data that exceeds the configured threshold in ControlRate to be routed to 'rate exceeded' instead of just staying in the queue. Added Use Case documentation to ControlRate. This closes #7895 Signed-off-by: Mike Moser > Allow ControlRate to optionally route to a new 'rate exceeded' relationship > instead of just slowing things down > --- > > Key: NIFI-12242 > URL: https://issues.apache.org/jira/browse/NIFI-12242 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > ControlRate provides the ability to slow down the rate of data through the > system. This is important in cases where we want to avoid overwhelming a > downstream system. However, there are times when we don't want to just slow > down the flow of data but instead reject it if the rate is too high. > Take, for example, the typical case with an HTTP Server that responds with a > 429: Too Many Requests status code. ControlRate should give us the option of > rejecting FlowFiles when they exceed the limit, not just slow everything down. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12242: Added ability to route data that exceeds the configured t… [nifi]
asfgit closed pull request #7895: NIFI-12242: Added ability to route data that exceeds the configured t… URL: https://github.com/apache/nifi/pull/7895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12242: Added ability to route data that exceeds the configured t… [nifi]
mosermw commented on PR #7895: URL: https://github.com/apache/nifi/pull/7895#issuecomment-1772932139 +1 merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1825#comment-1825
]
Daniel Stieglitz edited comment on NIFI-11627 at 10/20/23 3:07 PM:
---
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, would an in memory map similar to the AvroSchemaRegistry
be okay?
Can
{code:java}
org.apache.nifi.schemaregistry.services.SchemaRegistry{code}
be reused for this?
was (Author: JIRAUSER294662):
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, would an in memory map similar to the AvroSchemaRegistry
be okay?
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1825#comment-1825
]
Daniel Stieglitz edited comment on NIFI-11627 at 10/20/23 3:02 PM:
---
@[~markap14] [~exceptionfactory] For the initial implementation for this
Controller Interface, would an in memory map similar to the AvroSchemaRegistry
be okay?
was (Author: JIRAUSER294662):
@[~markap14] [~exceptionfactory] As for the initial implementation for this
Controller Interface would an in memory map similar to the AvroSchemaRegistry
be okay?
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1825#comment-1825
]
Daniel Stieglitz commented on NIFI-11627:
-
@[~markap14] [~exceptionfactory] As for the initial implementation for this
Controller Interface would an in memory map similar to the AvroSchemaRegistry
be okay?
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12198) Add API to import a VersionedReportingTaskSnapshot
[ https://issues.apache.org/jira/browse/NIFI-12198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-12198: -- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Add API to import a VersionedReportingTaskSnapshot > -- > > Key: NIFI-12198 > URL: https://issues.apache.org/jira/browse/NIFI-12198 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > This is the corresponding import API to go along with the export API that was > added in NIFI-12186 . We should be able to POST a previously exported > VersionedReportingTaskSnapshot to a given NiFi instance to create any > reporting tasks and controller services provided in the snapshot. We should > also support uploading a file. The import process should be additive, we are > not trying to sync existing components, just create whatever is in the > snapshot. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12198 Add API and CLI commands to import reporting task snapshots [nifi]
markap14 merged PR #7875: URL: https://github.com/apache/nifi/pull/7875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12198 Add API and CLI commands to import reporting task snapshots [nifi]
markap14 commented on PR #7875: URL: https://github.com/apache/nifi/pull/7875#issuecomment-1772876906 Great, thanks @bbende, merged to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12198) Add API to import a VersionedReportingTaskSnapshot
[ https://issues.apache.org/jira/browse/NIFI-12198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1820#comment-1820 ] ASF subversion and git services commented on NIFI-12198: Commit fd2de5a1515458ccc73df3e9a85fed9d6c4c3ce1 in nifi's branch refs/heads/main from Bryan Bende [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=fd2de5a151 ] NIFI-12198 Add API and CLI commands to import reporting task snapshots (#7875) * NIFI-12198 Add API and CLI commands to import reporting task snapshots > Add API to import a VersionedReportingTaskSnapshot > -- > > Key: NIFI-12198 > URL: https://issues.apache.org/jira/browse/NIFI-12198 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > This is the corresponding import API to go along with the export API that was > added in NIFI-12186 . We should be able to POST a previously exported > VersionedReportingTaskSnapshot to a given NiFi instance to create any > reporting tasks and controller services provided in the snapshot. We should > also support uploading a file. The import process should be additive, we are > not trying to sync existing components, just create whatever is in the > snapshot. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12198 Add API and CLI commands to import reporting task snapshots [nifi]
markap14 commented on code in PR #7875:
URL: https://github.com/apache/nifi/pull/7875#discussion_r1367075338
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerResource.java:
##
@@ -449,6 +455,72 @@ public Response createReportingTask(
);
}
+/**
+ * Imports a reporting task snapshot.
+ */
+@POST
+@Consumes(MediaType.APPLICATION_JSON)
+@Produces(MediaType.APPLICATION_JSON)
+@Path("reporting-tasks/import")
+@ApiOperation(
+value = "Imports a reporting task snapshot",
+response = VersionedReportingTaskImportResponseEntity.class,
+authorizations = {
+@Authorization(value = "Write - /controller")
+}
+)
+@ApiResponses(
+value = {
+@ApiResponse(code = 400, message = "NiFi was unable to
complete the request because it was invalid. The request should not be retried
without modification."),
+@ApiResponse(code = 401, message = "Client could not be
authenticated."),
+@ApiResponse(code = 403, message = "Client is not
authorized to make this request."),
+@ApiResponse(code = 409, message = "The request was valid
but NiFi was not in the appropriate state to process it. Retrying the same
request later may be successful.")
+}
+)
+public Response importReportingTaskSnapshot(
+@Context final HttpServletRequest httpServletRequest,
+@ApiParam(
+value = "The import request containing the reporting task
snapshot to import.",
+required = true
+) final VersionedReportingTaskImportRequestEntity
importRequestEntity) {
+
+if (importRequestEntity == null ||
importRequestEntity.getReportingTaskSnapshot() == null) {
+throw new IllegalArgumentException("Reporting task snapshot is
required");
+}
+
+final VersionedReportingTaskSnapshot requestSnapshot =
importRequestEntity.getReportingTaskSnapshot();
+serviceFacade.discoverCompatibleBundles(requestSnapshot);
+serviceFacade.generateIdentifiersForImport(requestSnapshot, () ->
generateUuid());
+
+if (isReplicateRequest()) {
+return replicate(HttpMethod.POST, importRequestEntity);
+} else if (isDisconnectedFromCluster()) {
+
verifyDisconnectedNodeModification(importRequestEntity.getDisconnectedNodeAcknowledged());
+}
+
+return withWriteLock(
+serviceFacade,
+importRequestEntity,
+lookup -> {
+authorizeController(RequestAction.WRITE);
+
+final Set restrictedComponents =
FlowRegistryUtils.getRestrictedComponents(requestSnapshot, serviceFacade);
+restrictedComponents.forEach(restrictedComponent -> {
+final ComponentAuthorizable
restrictedComponentAuthorizable =
lookup.getConfigurableComponent(restrictedComponent);
+authorizeRestrictions(authorizer,
restrictedComponentAuthorizable);
+});
+},
+() -> {
+// Nothing to verify
+},
+(importRequest) -> {
+final VersionedReportingTaskSnapshot snapshot =
importRequestEntity.getReportingTaskSnapshot();
Review Comment:
```suggestion
final VersionedReportingTaskSnapshot snapshot =
importRequest.getReportingTaskSnapshot();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12198 Add API and CLI commands to import reporting task snapshots [nifi]
bbende commented on PR #7875: URL: https://github.com/apache/nifi/pull/7875#issuecomment-1772874845 @markap14 yes that would be great! Really appreciate the review and testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12198 Add API and CLI commands to import reporting task snapshots [nifi]
markap14 commented on PR #7875: URL: https://github.com/apache/nifi/pull/7875#issuecomment-1772871187 Was able to test and all looks good. Given that the only I had was a trivial change, I can make that change and merge if you're good with that @bbende -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12245: Removed deprecations around flow registry clients [nifi]
markap14 commented on code in PR #7899:
URL: https://github.com/apache/nifi/pull/7899#discussion_r1367056503
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##
@@ -502,7 +502,7 @@ private String determineRegistryId(final
VersionedFlowCoordinates coordinates) {
}
}
-final String location = coordinates.getStorageLocation() == null ?
coordinates.getRegistryUrl() : coordinates.getStorageLocation();
+final String location = coordinates.getStorageLocation();
if (location == null) {
Review Comment:
Yeah, good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12245: Removed deprecations around flow registry clients [nifi]
simonbence commented on code in PR #7899:
URL: https://github.com/apache/nifi/pull/7899#discussion_r1367032604
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##
@@ -502,7 +502,7 @@ private String determineRegistryId(final
VersionedFlowCoordinates coordinates) {
}
}
-final String location = coordinates.getStorageLocation() == null ?
coordinates.getRegistryUrl() : coordinates.getStorageLocation();
+final String location = coordinates.getStorageLocation();
if (location == null) {
Review Comment:
I think the empty storage location is not valid (at least not with url
removed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12220: Added ability to create Controller Services from migrateProperties. [nifi]
markap14 commented on code in PR #7874:
URL: https://github.com/apache/nifi/pull/7874#discussion_r1367042333
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/migration/ControllerServiceFactory.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.migration;
+
+import org.apache.nifi.controller.service.ControllerServiceNode;
+
+import java.util.Map;
+
+public interface ControllerServiceFactory {
+ControllerServiceCreationDetails creationDetails(String
implementationClassName, Map propertyValues);
Review Comment:
Nope - `getCreationDetails` is probably a better name. Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12220: Added ability to create Controller Services from migrateProperties. [nifi]
markap14 commented on code in PR #7874:
URL: https://github.com/apache/nifi/pull/7874#discussion_r1367038991
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/kinesis/stream/ITPutKinesisStreamWithEndpointOverride.java:
##
@@ -29,24 +31,24 @@
// This integration test can be run against a mock Kenesis such as
// https://github.com/mhart/kinesalite or
https://github.com/localstack/localstack
+@Disabled("Required external service be running. Needs to be updated to make
use of Localstack TestContainer")
Review Comment:
Yeah, fair enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12220: Added ability to create Controller Services from migrateProperties. [nifi]
markap14 commented on code in PR #7874: URL: https://github.com/apache/nifi/pull/7874#discussion_r1367035011 ## nifi-mock/src/main/java/org/apache/nifi/util/TestRunner.java: ## @@ -1064,4 +1064,6 @@ void assertAttributes( * @param eventType Provenance event type */ void assertProvenanceEvent(ProvenanceEventType eventType); + Review Comment: Good catch. Will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12220: Added ability to create Controller Services from migrateProperties. [nifi]
markap14 commented on code in PR #7874:
URL: https://github.com/apache/nifi/pull/7874#discussion_r1367034467
##
nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyConfiguration.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.util;
+
+import org.apache.nifi.migration.PropertyConfiguration;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.UUID;
+
+public class MockPropertyConfiguration implements PropertyConfiguration {
+private final Map propertyRenames = new HashMap<>();
+private final Set propertiesRemoved = new HashSet<>();
+private final Set propertiesUpdated = new HashSet<>();
+private final Map rawProperties;
+private final Set createdControllerServices =
new HashSet<>();
+
+
+public MockPropertyConfiguration(final Map propertyValues)
{
+this.rawProperties = new HashMap<>(propertyValues);
Review Comment:
There is, in general, no expectation of ordering of elements in the map. If
there were, we would want to require a `SequencedMap` rather than a `Map`. In
general, the List of Property Descriptors is ordered, so that we can provide a
better user experience via the UI. However, the order in which elements are
iterated over need not be maintained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12165 Changed the properties "Custom Transformation Class Name" and "Custom Module Directory" to depend on the "Jolt Transformation DSL" property when its value is "Custom" [nifi]
dan-s1 commented on PR #7890: URL: https://github.com/apache/nifi/pull/7890#issuecomment-1772819385 @ChrisSamo632 @exceptionfactory I understand the history from #7782 that there had to be two processors `JoltTransformJSON` and `JoltTransformRecord`. But my question is why is there duplicate code between the two processors? This MR and NIFI-11959 are consequences of duplicate code. Is there something we can do here to refactor and extract the duplicate code to be shared with these two classes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12220: Added ability to create Controller Services from migrateProperties. [nifi]
markap14 commented on code in PR #7874:
URL: https://github.com/apache/nifi/pull/7874#discussion_r1367031263
##
nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyConfiguration.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.util;
+
+import org.apache.nifi.migration.PropertyConfiguration;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.UUID;
+
+public class MockPropertyConfiguration implements PropertyConfiguration {
+private final Map propertyRenames = new HashMap<>();
+private final Set propertiesRemoved = new HashSet<>();
+private final Set propertiesUpdated = new HashSet<>();
+private final Map rawProperties;
+private final Set createdControllerServices =
new HashSet<>();
Review Comment:
I think I would disagree on this one. I believe that the order in which
properties are removed, renamed, updated, etc. is not something that should be
relied upon in a test. Tests should verify that "given this input, the expected
output is produced." They should not attempt to assert the order in which the
operations were performed in order to obtain that output - doing so would make
the test very brittle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12220: Added ability to create Controller Services from migrateProperties. [nifi]
markap14 commented on code in PR #7874:
URL: https://github.com/apache/nifi/pull/7874#discussion_r1367027814
##
nifi-api/src/main/java/org/apache/nifi/migration/PropertyConfiguration.java:
##
@@ -128,10 +128,83 @@ default Optional
getPropertyValue(PropertyDescriptor descriptor) {
return getPropertyValue(descriptor.getName());
}
+/**
+ * Returns an optional value representing the "raw" value of the property
with the given name. The "raw" value is
+ * the value before any parameters are substituted.
+ *
+ * @param propertyName the name of the property
+ * @return an empty optional if the value is null or unset, else an
Optional representing the configured value
+ */
+Optional getRawPropertyValue(String propertyName);
+
+/**
+ * Returns an optional value representing the "raw" value of the property
identified by the given descriptor. The "raw" value is
+ * the value before any parameters are substituted.
+ *
+ * @param descriptor the descriptor that identifies the property
+ * @return an empty optional if the value is null or unset, else an
Optional representing the configured value
+ */
+default Optional getRawPropertyValue(PropertyDescriptor
descriptor) {
+return getRawPropertyValue(descriptor.getName());
+}
+
/**
* Returns a map containing all of the configured properties
* @return a Map containing the names and values of all configured
properties
*/
Map getProperties();
+/**
+ * Returns a map containing all of the raw property values
+ *
+ * @return a Map containing the names and values of all configured
properties
+ */
+Map getRawProperties();
+
+/**
+ *
+ * Creates a new Controller Service of the given type and configures it
with the given property values. Note that if a Controller Service
+ * already exists within the same scope and with the same implementation
and configuration, a new service may not be created and instead
+ * the existing service may be used.
+ *
+ *
+ *
+ * This allows for properties that were previously defined in the
extension to be moved to a Controller Service. For example,
+ * consider a Processor that has "Username" and "Password" properties. In
the next version of the Processor, we want to support
+ * multiple types of authentication, and we delegate the authentication to
a Controller Service. Consider that the Controller Service
+ * implementation we wish to use has a classname of {@code
org.apache.nifi.services.authentication.UsernamePassword}. We might then
+ * use this method as such:
+ *
+ *
+ *
+ * // Create a new Controller Service ofo type
org.apache.nifi.services.authentication.UsernamePassword whose Username and
Password
+ * // properties match those currently configured for this Processor.
+ * final MapString, String serviceProperties =
Map.of("Username", propertyConfiguration.getRawPropertyValue("Username"),
+ * "Password",
propertyConfiguration.getRawPropertyValue("Password"));
+ * final String serviceId =
propertyConfiguration.createControllerService("org.apache.nifi.services.authentication.UsernamePassword",
serviceProperties);
+ *
+ * // Set our Authentication Service property to point to this new
service.
+ * propertyConfiguration.setProperty(AUTHENTICATION_SERVICE,
serviceId);
+ *
+ * // Remove the Username and Password properties from this Processor,
since we are now going to use then Authentication Service.
+ * propertyConfiguration.removeProperty("Username");
+ * propertyConfiguration.removeProperty("Password");
+ *
+ *
+ *
+ * Note the use of {@link #getRawPropertyValue(String)} here instead of
{@link #getPropertyValue(String)}. Because we want to set
+ * the new Controller Service's value to the same value as is currently
configured for the Processor's "Username" and "Password" properties,
+ * we use {@link #getRawPropertyValue(String)}. This ensures that if the
Processor is configured using Parameters, those Parameter
+ * references are still held by the Controller Service.
+ *
+ *
+ *
+ * Also note that this method expects the classname of the implementation,
not the classname of the interface.
+ *
+ *
+ * @param implementationClassName the fully qualified classname of the
Controller Service implementation
+ * @param serviceProperties the property values to configure the
newly created Controller Service with
+ * @return an identifier for the Controller Service
+ */
+String createControllerService(String implementationClassName, Map serviceProperties);
Review Comment:
Yeah, agreed. I don't love that it is needing to provide an explicit
implementation of the service, but at the same time - the whole point is to
Re: [PR] NIFI-12242: Added ability to route data that exceeds the configured t… [nifi]
markap14 commented on PR #7895: URL: https://github.com/apache/nifi/pull/7895#issuecomment-1772804079 Thanks @mosermw pushed a commit that addresses the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12242: Added ability to route data that exceeds the configured t… [nifi]
markap14 commented on code in PR #7895:
URL: https://github.com/apache/nifi/pull/7895#discussion_r1367022418
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ControlRate.java:
##
@@ -66,6 +66,52 @@
@CapabilityDescription("Controls the rate at which data is transferred to
follow-on processors."
+ " If you configure a very small Time Duration, then the accuracy of
the throttle gets worse."
+ " You can improve this accuracy by decreasing the Yield Duration, at
the expense of more Tasks given to the processor.")
+@UseCase(description = "Limit the rate at which data is sent to a downstream
system with little to no bursts",
+keywords = {"throttle", "limit", "slow down", "data rate"},
+configuration = """
+Set the "Rate Control Criteria" to `data rate`.
+Set the "Time Duration" property to `1 sec`.
+Configure the "Maximum Rate" property to specify how much data should
be allowed through each second.
+
+For example, to allow through 8 MB per second, "Maximum Rate" to `8
MB`.
Review Comment:
Good catch @mosermw thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12230) Add Configurable Log Level to GeoEnrichIP
[ https://issues.apache.org/jira/browse/NIFI-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12230: Summary: Add Configurable Log Level to GeoEnrichIP (was: GeoEnrichIP shouldn't produce a message when an IP is not found) > Add Configurable Log Level to GeoEnrichIP > - > > Key: NIFI-12230 > URL: https://issues.apache.org/jira/browse/NIFI-12230 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Didier B. >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0, 1.24.0 > > > GeoEnrichIP is a processor that convert an IP (found in the flowfile > attribute) to a geolocation information that it put in attributes. To do so > it requires a database file. > In many environments, it's normal to have IP not found in the database > (internal IP, unknown IP, and so on). This is an information that concern the > rest of the workflow if needed. > The problem here is that for every IP not found, GeoEnrichIP make a log warn > call which imply that a bulletin is emitted. This bulletin will trigger the > red box (upper right corner of the processor) up to the root flowgraph, > warning everyone working on the flowgraph that there is a problem, which is > not and will also emit a log that will flood the log system. > *When an IP is not found, routing to failure is enough. No bulletin should be > emitted. Not finding an IP is normal and can happen several times per second.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12253) GeoEnrichIPRecord does not route FF to not found
[ https://issues.apache.org/jira/browse/NIFI-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12253: Fix Version/s: 2.0.0 1.24.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > GeoEnrichIPRecord does not route FF to not found > > > Key: NIFI-12253 > URL: https://issues.apache.org/jira/browse/NIFI-12253 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0, 1.24.0 > > Attachments: Screenshot 2023-10-19 at 13.23.40.png > > Time Spent: 40m > Remaining Estimate: 0h > > If the IP is not found, the flow file is rolled back instead of being routed > to the not found relationship. > !Screenshot 2023-10-19 at 13.23.40.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12230) GeoEnrichIP shouldn't produce a message when an IP is not found
[ https://issues.apache.org/jira/browse/NIFI-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12230: Fix Version/s: 2.0.0 1.24.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > GeoEnrichIP shouldn't produce a message when an IP is not found > --- > > Key: NIFI-12230 > URL: https://issues.apache.org/jira/browse/NIFI-12230 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Didier B. >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0, 1.24.0 > > > GeoEnrichIP is a processor that convert an IP (found in the flowfile > attribute) to a geolocation information that it put in attributes. To do so > it requires a database file. > In many environments, it's normal to have IP not found in the database > (internal IP, unknown IP, and so on). This is an information that concern the > rest of the workflow if needed. > The problem here is that for every IP not found, GeoEnrichIP make a log warn > call which imply that a bulletin is emitted. This bulletin will trigger the > red box (upper right corner of the processor) up to the root flowgraph, > warning everyone working on the flowgraph that there is a problem, which is > not and will also emit a log that will flood the log system. > *When an IP is not found, routing to failure is enough. No bulletin should be > emitted. Not finding an IP is normal and can happen several times per second.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12253) GeoEnrichIPRecord does not route FF to not found
[ https://issues.apache.org/jira/browse/NIFI-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1793#comment-1793 ] ASF subversion and git services commented on NIFI-12253: Commit 3d607a7b6f37f1d24427e499df87362e45a3dfbb in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3d607a7b6f ] NIFI-12230 Add configurable Log Level for IP not found in GeoEnrichIP NIFI-12253 Route to not found relationship instead of rolling back in GeoEnrichIPRecord This closes #7909 Signed-off-by: David Handermann (cherry picked from commit 184757fede3e253ba47552ab8e6fe8bd75f8f49f) > GeoEnrichIPRecord does not route FF to not found > > > Key: NIFI-12253 > URL: https://issues.apache.org/jira/browse/NIFI-12253 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Attachments: Screenshot 2023-10-19 at 13.23.40.png > > Time Spent: 40m > Remaining Estimate: 0h > > If the IP is not found, the flow file is rolled back instead of being routed > to the not found relationship. > !Screenshot 2023-10-19 at 13.23.40.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12230) GeoEnrichIP shouldn't produce a message when an IP is not found
[ https://issues.apache.org/jira/browse/NIFI-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1790#comment-1790 ] ASF subversion and git services commented on NIFI-12230: Commit 184757fede3e253ba47552ab8e6fe8bd75f8f49f in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=184757fede ] NIFI-12230 Add configurable Log Level for IP not found in GeoEnrichIP NIFI-12253 Route to not found relationship instead of rolling back in GeoEnrichIPRecord This closes #7909 Signed-off-by: David Handermann > GeoEnrichIP shouldn't produce a message when an IP is not found > --- > > Key: NIFI-12230 > URL: https://issues.apache.org/jira/browse/NIFI-12230 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Didier B. >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > > GeoEnrichIP is a processor that convert an IP (found in the flowfile > attribute) to a geolocation information that it put in attributes. To do so > it requires a database file. > In many environments, it's normal to have IP not found in the database > (internal IP, unknown IP, and so on). This is an information that concern the > rest of the workflow if needed. > The problem here is that for every IP not found, GeoEnrichIP make a log warn > call which imply that a bulletin is emitted. This bulletin will trigger the > red box (upper right corner of the processor) up to the root flowgraph, > warning everyone working on the flowgraph that there is a problem, which is > not and will also emit a log that will flood the log system. > *When an IP is not found, routing to failure is enough. No bulletin should be > emitted. Not finding an IP is normal and can happen several times per second.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12230) GeoEnrichIP shouldn't produce a message when an IP is not found
[ https://issues.apache.org/jira/browse/NIFI-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1792#comment-1792 ] ASF subversion and git services commented on NIFI-12230: Commit 3d607a7b6f37f1d24427e499df87362e45a3dfbb in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3d607a7b6f ] NIFI-12230 Add configurable Log Level for IP not found in GeoEnrichIP NIFI-12253 Route to not found relationship instead of rolling back in GeoEnrichIPRecord This closes #7909 Signed-off-by: David Handermann (cherry picked from commit 184757fede3e253ba47552ab8e6fe8bd75f8f49f) > GeoEnrichIP shouldn't produce a message when an IP is not found > --- > > Key: NIFI-12230 > URL: https://issues.apache.org/jira/browse/NIFI-12230 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Didier B. >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > > GeoEnrichIP is a processor that convert an IP (found in the flowfile > attribute) to a geolocation information that it put in attributes. To do so > it requires a database file. > In many environments, it's normal to have IP not found in the database > (internal IP, unknown IP, and so on). This is an information that concern the > rest of the workflow if needed. > The problem here is that for every IP not found, GeoEnrichIP make a log warn > call which imply that a bulletin is emitted. This bulletin will trigger the > red box (upper right corner of the processor) up to the root flowgraph, > warning everyone working on the flowgraph that there is a problem, which is > not and will also emit a log that will flood the log system. > *When an IP is not found, routing to failure is enough. No bulletin should be > emitted. Not finding an IP is normal and can happen several times per second.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12253) GeoEnrichIPRecord does not route FF to not found
[ https://issues.apache.org/jira/browse/NIFI-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1791#comment-1791 ] ASF subversion and git services commented on NIFI-12253: Commit 184757fede3e253ba47552ab8e6fe8bd75f8f49f in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=184757fede ] NIFI-12230 Add configurable Log Level for IP not found in GeoEnrichIP NIFI-12253 Route to not found relationship instead of rolling back in GeoEnrichIPRecord This closes #7909 Signed-off-by: David Handermann > GeoEnrichIPRecord does not route FF to not found > > > Key: NIFI-12253 > URL: https://issues.apache.org/jira/browse/NIFI-12253 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Attachments: Screenshot 2023-10-19 at 13.23.40.png > > Time Spent: 40m > Remaining Estimate: 0h > > If the IP is not found, the flow file is rolled back instead of being routed > to the not found relationship. > !Screenshot 2023-10-19 at 13.23.40.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12253 NIFI-12230 - Add configurable log level for IP not found and fix GeoEnrichIPRecord [nifi]
exceptionfactory closed pull request #7909: NIFI-12253 NIFI-12230 - Add configurable log level for IP not found and fix GeoEnrichIPRecord URL: https://github.com/apache/nifi/pull/7909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11197 Initial check in for Yaml record reader [nifi]
dan-s1 commented on PR #7665: URL: https://github.com/apache/nifi/pull/7665#issuecomment-1772781514 @exceptionfactory Any chance this can make 1.24? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12257) Upgrade SSHD to 2.9.3
[ https://issues.apache.org/jira/browse/NIFI-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12257: Status: Patch Available (was: Open) > Upgrade SSHD to 2.9.3 > - > > Key: NIFI-12257 > URL: https://issues.apache.org/jira/browse/NIFI-12257 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.24.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache MINA SSHD dependencies should be upgraded to 2.9.3 on the support > branch to mitgate CVE-2023-35887. The vulnerability applies to SFTP server > implementations and is not directly applicable to transitive usage in NiFi > Registry, but upgrading mitigates version-based vulnerability findings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12258) Upgrade SSHD to 2.11.0
[ https://issues.apache.org/jira/browse/NIFI-12258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12258: Status: Patch Available (was: Open) > Upgrade SSHD to 2.11.0 > -- > > Key: NIFI-12258 > URL: https://issues.apache.org/jira/browse/NIFI-12258 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: dependency-upgrade > Fix For: 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache MINA SSHD dependencies should be upgraded to 2.11.0 on the main branch > to mitgate CVE-2023-35887. The vulnerability applies to SFTP server > implementations and is not directly applicable to transitive usage in NiFi > Registry, but upgrading mitigates version-based vulnerability findings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12258 Upgrade MINA SSHD from 2.10.0 to 2.11.0 for Main Branch [nifi]
exceptionfactory opened a new pull request, #7915: URL: https://github.com/apache/nifi/pull/7915 # Summary [NIFI-12258](https://issues.apache.org/jira/browse/NIFI-12258) Upgrades Apache MINA SSHD dependencies from 2.10.0 to 2.11.0 for the main branch. This upgrade mitigates CVE-2023-35887, which applies to SFTP server implementations and is not directly applicable to transitive usage in NiFi Registry. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12257 Upgrade MINA SSHD from 2.9.2 to 2.9.3 for Support Branch [nifi]
exceptionfactory opened a new pull request, #7914: URL: https://github.com/apache/nifi/pull/7914 # Summary [NIFI-12257](https://issues.apache.org/jira/browse/NIFI-12257) Upgrades runtime Apache MINA SSHD dependencies in NiFi Registry from 2.9.2 to 2.9.3, maintaining compatibility with JGit 5. Additional changes include upgrading MINA SSHD test dependencies for standard processors from 2.10.0 to 2.11.0. This upgrade mitigates CVE-2023-35887, which applies to SFTP server implementations and is not directly applicable to transitive usage in NiFi Registry. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11874 update Process Group configuration layout in the UI [nifi]
markobean commented on PR #7591: URL: https://github.com/apache/nifi/pull/7591#issuecomment-1772766720 @mcgilman @mtien-apache @exceptionfactory Hey all.. thank you for the time you've put into this PR so far. I'd like to get it over the line - and more importantly merge the corresponding nifi-1.x PR - before we get to the 1.24.0 release. https://github.com/apache/nifi/pull/7844 Appreciate your time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12257) Upgrade SSHD to 2.9.3
David Handermann created NIFI-12257: --- Summary: Upgrade SSHD to 2.9.3 Key: NIFI-12257 URL: https://issues.apache.org/jira/browse/NIFI-12257 Project: Apache NiFi Issue Type: Improvement Components: NiFi Registry Reporter: David Handermann Assignee: David Handermann Fix For: 1.24.0 Apache MINA SSHD dependencies should be upgraded to 2.9.3 on the support branch to mitgate CVE-2023-35887. The vulnerability applies to SFTP server implementations and is not directly applicable to transitive usage in NiFi Registry, but upgrading mitigates version-based vulnerability findings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12258) Upgrade SSHD to 2.11.0
David Handermann created NIFI-12258: --- Summary: Upgrade SSHD to 2.11.0 Key: NIFI-12258 URL: https://issues.apache.org/jira/browse/NIFI-12258 Project: Apache NiFi Issue Type: Improvement Components: NiFi Registry Reporter: David Handermann Assignee: David Handermann Fix For: 2.0.0 Apache MINA SSHD dependencies should be upgraded to 2.11.0 on the main branch to mitgate CVE-2023-35887. The vulnerability applies to SFTP server implementations and is not directly applicable to transitive usage in NiFi Registry, but upgrading mitigates version-based vulnerability findings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2256) Un-singletonize LoggerConfiguration
Ferenc Gerlits created MINIFICPP-2256:
-
Summary: Un-singletonize LoggerConfiguration
Key: MINIFICPP-2256
URL: https://issues.apache.org/jira/browse/MINIFICPP-2256
Project: Apache NiFi MiNiFi C++
Issue Type: Improvement
Reporter: Ferenc Gerlits
1. {{LoggerConfiguration}} has a private constructor and a public
{{newInstance}} method, which returns a pointer. This means we can create new
instances, but only on the heap, which makes no sense. Remove
{{newInstance()}}, make the constructor public, and update tests to create
{{LoggerConfiguration}} objects on the stack.
2. If possible, we should also make the ownership of {{LoggerConfiguration}}
clearer in the production use cases. Currently, we use it as a singleton, via
the {{getInstance}} method. It would be better to have a clear (non-static)
owner for it, and users got a reference or pointer to {{LoggerConfiguration}}
from the owner. Then we could remove {{getInstance}}, as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2256) Un-singletonize LoggerConfiguration
[
https://issues.apache.org/jira/browse/MINIFICPP-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-2256:
--
Description:
1. {{LoggerConfiguration}} has a private constructor and a public
{{newInstance}} method, which returns a pointer. This means we can create new
instances, but only on the heap, which makes no sense. Remove {{newInstance}},
make the constructor public, and update tests to create {{LoggerConfiguration}}
objects on the stack.
2. If possible, we should also make the ownership of {{LoggerConfiguration}}
clearer in the production use cases. Currently, we use it as a singleton, via
the {{getInstance}} method. It would be better to have a clear (non-static)
owner for it, and users got a reference or pointer to {{LoggerConfiguration}}
from the owner. Then we could remove {{getInstance}}, as well.
was:
1. {{LoggerConfiguration}} has a private constructor and a public
{{newInstance}} method, which returns a pointer. This means we can create new
instances, but only on the heap, which makes no sense. Remove
{{newInstance()}}, make the constructor public, and update tests to create
{{LoggerConfiguration}} objects on the stack.
2. If possible, we should also make the ownership of {{LoggerConfiguration}}
clearer in the production use cases. Currently, we use it as a singleton, via
the {{getInstance}} method. It would be better to have a clear (non-static)
owner for it, and users got a reference or pointer to {{LoggerConfiguration}}
from the owner. Then we could remove {{getInstance}}, as well.
> Un-singletonize LoggerConfiguration
> ---
>
> Key: MINIFICPP-2256
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2256
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Priority: Minor
>
> 1. {{LoggerConfiguration}} has a private constructor and a public
> {{newInstance}} method, which returns a pointer. This means we can create
> new instances, but only on the heap, which makes no sense. Remove
> {{newInstance}}, make the constructor public, and update tests to create
> {{LoggerConfiguration}} objects on the stack.
> 2. If possible, we should also make the ownership of {{LoggerConfiguration}}
> clearer in the production use cases. Currently, we use it as a singleton,
> via the {{getInstance}} method. It would be better to have a clear
> (non-static) owner for it, and users got a reference or pointer to
> {{LoggerConfiguration}} from the owner. Then we could remove
> {{getInstance}}, as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]
exceptionfactory commented on code in PR #7891:
URL: https://github.com/apache/nifi/pull/7891#discussion_r1366910027
##
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java:
##
@@ -1165,13 +1168,22 @@ public void start(final boolean monitor) throws
IOException {
nifiPropsFilename = nifiPropsFilename.trim();
+String xmx = null;
+String xms = null;
+
final List javaAdditionalArgs = new ArrayList<>();
for (final Map.Entry entry : props.entrySet()) {
final String key = entry.getKey();
final String value = entry.getValue();
if (key.startsWith("java.arg")) {
javaAdditionalArgs.add(value);
+if(value.toLowerCase().startsWith("-xms")) {
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11958 Azure Data Explorer as sink [nifi]
exceptionfactory commented on code in PR #7624:
URL: https://github.com/apache/nifi/pull/7624#discussion_r1366908724
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-services-api/src/main/java/org/apache/nifi/services/azure/data/explorer/KustoIngestService.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.services.azure.data.explorer;
+
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+
+import java.net.URISyntaxException;
+
+@Tags({"azure", "adx", "explorer", "kusto", "ingest"})
+@CapabilityDescription("Connection-Service for Azure ADX (Kusto) ingestion
cluster to ingest data.")
+public interface KustoIngestService extends KustoQueryService {
Review Comment:
Thanks for clarifying, that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2248 Refactor string::join_pack [nifi-minifi-cpp]
lordgamez commented on code in PR #1680: URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1366849293 ## CPPLINT.cfg: ## @@ -1,2 +1,2 @@ set noparent -filter=-runtime/reference,-runtime/string,-build/c++11,-build/include_subdir,-whitespace/forcolon,-build/namespaces_literals,-readability/check,-build/include_what_you_use,-readability/nolint +filter=-runtime/reference,-runtime/string,-build/c++11,-build/include_subdir,-whitespace/forcolon,-build/namespaces_literals,-readability/check,-build/include_what_you_use,-readability/nolint,-readability/braces Review Comment: @martinzink has an open issue for this for a while now https://github.com/google/styleguide/issues/752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12254) PutElasticsearchRecord documentation for Dynamic Properties isn't clear
[
https://issues.apache.org/jira/browse/NIFI-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-12254:
--
Fix Version/s: 2.0.0
1.24.0
(was: 1.latest)
(was: 2.latest)
Resolution: Fixed
Status: Resolved (was: Patch Available)
> PutElasticsearchRecord documentation for Dynamic Properties isn't clear
> ---
>
> Key: NIFI-12254
> URL: https://issues.apache.org/jira/browse/NIFI-12254
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.2
>Reporter: Chris Sampson
>Assignee: Chris Sampson
>Priority: Minor
> Fix For: 2.0.0, 1.24.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Dynamic Property documentation for {{PutElasticsearchRecord}} doesn't
> indicate that the values of the properties are expected to be Record Path
> expressions in order to obtain values from within the Records processed for
> sending to Elasticsearch.
> This is very confusing for users.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12254) PutElasticsearchRecord documentation for Dynamic Properties isn't clear
[
https://issues.apache.org/jira/browse/NIFI-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1686#comment-1686
]
ASF subversion and git services commented on NIFI-12254:
Commit 54030bfe11fecee83fc402b04274fe5a478d2c4d in nifi's branch
refs/heads/support/nifi-1.x from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=54030bfe11 ]
NIFI-12254 clarify Bulk operation header documentation for
PutElasticsearchRecord and PutElasticsearchJson processors
Signed-off-by: Pierre Villard
This closes #7912.
> PutElasticsearchRecord documentation for Dynamic Properties isn't clear
> ---
>
> Key: NIFI-12254
> URL: https://issues.apache.org/jira/browse/NIFI-12254
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.2
>Reporter: Chris Sampson
>Assignee: Chris Sampson
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Dynamic Property documentation for {{PutElasticsearchRecord}} doesn't
> indicate that the values of the properties are expected to be Record Path
> expressions in order to obtain values from within the Records processed for
> sending to Elasticsearch.
> This is very confusing for users.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12254) PutElasticsearchRecord documentation for Dynamic Properties isn't clear
[
https://issues.apache.org/jira/browse/NIFI-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1682#comment-1682
]
ASF subversion and git services commented on NIFI-12254:
Commit 6c7d02e22e95ea84cf8895231d01c9b60144c24d in nifi's branch
refs/heads/main from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6c7d02e22e ]
NIFI-12254 clarify Bulk operation header documentation for
PutElasticsearchRecord and PutElasticsearchJson processors
Signed-off-by: Pierre Villard
This closes #7912.
> PutElasticsearchRecord documentation for Dynamic Properties isn't clear
> ---
>
> Key: NIFI-12254
> URL: https://issues.apache.org/jira/browse/NIFI-12254
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.2
>Reporter: Chris Sampson
>Assignee: Chris Sampson
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Dynamic Property documentation for {{PutElasticsearchRecord}} doesn't
> indicate that the values of the properties are expected to be Record Path
> expressions in order to obtain values from within the Records processed for
> sending to Elasticsearch.
> This is very confusing for users.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12254 clarify Bulk operation header documentation for PutElasticsearchRecord and PutElasticsearchJson processors [nifi]
asfgit closed pull request #7912: NIFI-12254 clarify Bulk operation header documentation for PutElasticsearchRecord and PutElasticsearchJson processors URL: https://github.com/apache/nifi/pull/7912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11958 Azure Data Explorer as sink [nifi]
tanmaya-panda1 commented on PR #7624: URL: https://github.com/apache/nifi/pull/7624#issuecomment-1772420811 @exceptionfactory : Thanks for the detailed review. I have addressed most of your comments, please feel free to review and comment if anything is missing. Thanks once again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12256) Update documentation and screenshots
[ https://issues.apache.org/jira/browse/NIFI-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12256: -- Component/s: Documentation & Website > Update documentation and screenshots > > > Key: NIFI-12256 > URL: https://issues.apache.org/jira/browse/NIFI-12256 > Project: Apache NiFi > Issue Type: Sub-task > Components: Documentation Website >Reporter: Pierre Villard >Priority: Major > Fix For: 2.latest > > > Following changes such as NIFI-12167 (and others), documentation should be > updated as well as the screenshots to take into account UI-related changes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
