[jira] [Updated] (NIFI-12608) Processor Bundle Maven Archetype broken build
[
https://issues.apache.org/jira/browse/NIFI-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shane O'Neill updated NIFI-12608:
-
Description:
I am seeing...
{noformat}
mvn archetype:generate -DarchetypeGroupId=org.apache.nifi
-DarchetypeArtifactId=nifi-processor-bundle-archetype{noformat}
fail to produce a buildable project for the
{{{}nifi-processor-bundle-archetype{}}}. The error is:
{code:java}
java.lang.ClassNotFoundException:
org.apache.nifi.processor.util.StandardValidators
at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
(MethodHandleAccessorFactory.java:300)
at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
(MethodHandleAccessorFactory.java:103)
at jdk.internal.reflect.ReflectionFactory.newConstructorAccessor
(ReflectionFactory.java:200)
at java.lang.reflect.Constructor.acquireConstructorAccessor
(Constructor.java:549)
at java.lang.reflect.Constructor.newInstanceWithCaller (Constructor.java:499)
at java.lang.reflect.Constructor.newInstance (Constructor.java:486) {code}
Adding {{nifi-standard-services-api-nar}} to the NAR packaging module fixes it.
To recreate the issue, generate a project and run mvn package.
{code:java}
mvn archetype:generate \
-DarchetypeGroupId=org.apache.nifi \
-DarchetypeArtifactId=nifi-processor-bundle-archetype \
-DnifiVersion=2.0.0-M1 \
-DartifactBaseName=example \
-DgroupId=org.example \
-DartifactId=myproject \
-Dversion=0.0.1 \
-Dpackage=org.example.processors.example {code}
{code:java}
cd myproject
mvn package {code}
was:
I am seeing the {{mvn archetype:generate}} CLI fail to produce a buildable
project for the {{{}nifi-processor-bundle-archetype{}}}. The error is:
{code:java}
java.lang.ClassNotFoundException:
org.apache.nifi.processor.util.StandardValidators
at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
(MethodHandleAccessorFactory.java:300)
at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
(MethodHandleAccessorFactory.java:103)
at jdk.internal.reflect.ReflectionFactory.newConstructorAccessor
(ReflectionFactory.java:200)
at java.lang.reflect.Constructor.acquireConstructorAccessor
(Constructor.java:549)
at java.lang.reflect.Constructor.newInstanceWithCaller (Constructor.java:499)
at java.lang.reflect.Constructor.newInstance (Constructor.java:486) {code}
Adding {{nifi-standard-services-api-nar}} to the NAR packaging module fixes it.
To recreate the issue, generate a project and run mvn package.
{code:java}
mvn archetype:generate \
-DarchetypeGroupId=org.apache.nifi \
-DarchetypeArtifactId=nifi-processor-bundle-archetype \
-DnifiVersion=2.0.0-M1 \
-DartifactBaseName=example \
-DgroupId=org.example \
-DartifactId=myproject \
-Dversion=0.0.1 \
-Dpackage=org.example.processors.example {code}
{code:java}
cd myproject
mvn package {code}
> Processor Bundle Maven Archetype broken build
> -
>
> Key: NIFI-12608
> URL: https://issues.apache.org/jira/browse/NIFI-12608
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Affects Versions: 2.0.0-M1
>Reporter: Shane O'Neill
>Priority: Major
>
> I am seeing...
> {noformat}
> mvn archetype:generate -DarchetypeGroupId=org.apache.nifi
> -DarchetypeArtifactId=nifi-processor-bundle-archetype{noformat}
> fail to produce a buildable project for the
> {{{}nifi-processor-bundle-archetype{}}}. The error is:
> {code:java}
> java.lang.ClassNotFoundException:
> org.apache.nifi.processor.util.StandardValidators
> at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
> at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
> at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
> at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
> at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
> at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
> at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
> (MethodHandleAccessorFactory.java:300)
> at jdk.internal.reflect.Me
[jira] [Updated] (NIFI-12608) Processor Bundle Maven Archetype broken build
[
https://issues.apache.org/jira/browse/NIFI-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shane O'Neill updated NIFI-12608:
-
Description:
I am seeing the {{mvn archetype:generate}} CLI fail to produce a buildable
project for the {{{}nifi-processor-bundle-archetype{}}}. The error is:
{code:java}
java.lang.ClassNotFoundException:
org.apache.nifi.processor.util.StandardValidators
at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
(MethodHandleAccessorFactory.java:300)
at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
(MethodHandleAccessorFactory.java:103)
at jdk.internal.reflect.ReflectionFactory.newConstructorAccessor
(ReflectionFactory.java:200)
at java.lang.reflect.Constructor.acquireConstructorAccessor
(Constructor.java:549)
at java.lang.reflect.Constructor.newInstanceWithCaller (Constructor.java:499)
at java.lang.reflect.Constructor.newInstance (Constructor.java:486) {code}
Adding {{nifi-standard-services-api-nar}} to the NAR packaging module fixes it.
To recreate the issue, generate a project and run mvn package.
{code:java}
mvn archetype:generate \
-DarchetypeGroupId=org.apache.nifi \
-DarchetypeArtifactId=nifi-processor-bundle-archetype \
-DnifiVersion=2.0.0-M1 \
-DartifactBaseName=example \
-DgroupId=org.example \
-DartifactId=myproject \
-Dversion=0.0.1 \
-Dpackage=org.example.processors.example {code}
{code:java}
cd myproject
mvn package {code}
was:
I am seeing the {{mvn archetype:generate}} CLI fail to produce a buildable
project for the {{{}nifi-processor-bundle-archetype{}}}. The error is:
Caused by: java.lang.ClassNotFoundException:
org.apache.nifi.processor.util.StandardValidators
at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
(MethodHandleAccessorFactory.java:300)
at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
(MethodHandleAccessorFactory.java:103)
at jdk.internal.reflect.ReflectionFactory.newConstructorAccessor
(ReflectionFactory.java:200)
at java.lang.reflect.Constructor.acquireConstructorAccessor
(Constructor.java:549)
at java.lang.reflect.Constructor.newInstanceWithCaller
(Constructor.java:499)
at java.lang.reflect.Constructor.newInstance (Constructor.java:486){{}}
Adding {{nifi-standard-services-api-nar}} to the NAR packaging module fixes it.
To recreate the issue, generate a project and run mvn package.
{{}}
mvn archetype:generate \
-DarchetypeGroupId=org.apache.nifi \
-DarchetypeArtifactId=nifi-processor-bundle-archetype \
-DnifiVersion=2.0.0-M1 \
-DartifactBaseName=example \
-DgroupId=org.example \
-DartifactId=myproject \
-Dversion=0.0.1 \
-Dpackage=org.example.processors.example
cd myproject
mvn package
> Processor Bundle Maven Archetype broken build
> -
>
> Key: NIFI-12608
> URL: https://issues.apache.org/jira/browse/NIFI-12608
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Affects Versions: 2.0.0-M1
>Reporter: Shane O'Neill
>Priority: Major
>
> I am seeing the {{mvn archetype:generate}} CLI fail to produce a buildable
> project for the {{{}nifi-processor-bundle-archetype{}}}. The error is:
>
> {code:java}
> java.lang.ClassNotFoundException:
> org.apache.nifi.processor.util.StandardValidators
> at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
> at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
> at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
> at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
> at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
> at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
> at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
> (MethodHandleAccessorFactory.java:300)
> at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
> (MethodHandleAccessorFactory.java:103)
> at jdk.internal.reflect.ReflectionFactory.newConstructorAccess
[jira] [Updated] (NIFI-12608) Processor Bundle Maven Archetype broken build
[
https://issues.apache.org/jira/browse/NIFI-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shane O'Neill updated NIFI-12608:
-
Description:
I am seeing the {{mvn archetype:generate}} CLI fail to produce a buildable
project for the {{{}nifi-processor-bundle-archetype{}}}. The error is:
{code:java}
java.lang.ClassNotFoundException:
org.apache.nifi.processor.util.StandardValidators
at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
(MethodHandleAccessorFactory.java:300)
at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
(MethodHandleAccessorFactory.java:103)
at jdk.internal.reflect.ReflectionFactory.newConstructorAccessor
(ReflectionFactory.java:200)
at java.lang.reflect.Constructor.acquireConstructorAccessor
(Constructor.java:549)
at java.lang.reflect.Constructor.newInstanceWithCaller (Constructor.java:499)
at java.lang.reflect.Constructor.newInstance (Constructor.java:486) {code}
Adding {{nifi-standard-services-api-nar}} to the NAR packaging module fixes it.
To recreate the issue, generate a project and run mvn package.
{code:java}
mvn archetype:generate \
-DarchetypeGroupId=org.apache.nifi \
-DarchetypeArtifactId=nifi-processor-bundle-archetype \
-DnifiVersion=2.0.0-M1 \
-DartifactBaseName=example \
-DgroupId=org.example \
-DartifactId=myproject \
-Dversion=0.0.1 \
-Dpackage=org.example.processors.example {code}
{code:java}
cd myproject
mvn package {code}
was:
I am seeing the {{mvn archetype:generate}} CLI fail to produce a buildable
project for the {{{}nifi-processor-bundle-archetype{}}}. The error is:
{code:java}
java.lang.ClassNotFoundException:
org.apache.nifi.processor.util.StandardValidators
at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
(MethodHandleAccessorFactory.java:300)
at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
(MethodHandleAccessorFactory.java:103)
at jdk.internal.reflect.ReflectionFactory.newConstructorAccessor
(ReflectionFactory.java:200)
at java.lang.reflect.Constructor.acquireConstructorAccessor
(Constructor.java:549)
at java.lang.reflect.Constructor.newInstanceWithCaller (Constructor.java:499)
at java.lang.reflect.Constructor.newInstance (Constructor.java:486) {code}
Adding {{nifi-standard-services-api-nar}} to the NAR packaging module fixes it.
To recreate the issue, generate a project and run mvn package.
{code:java}
mvn archetype:generate \
-DarchetypeGroupId=org.apache.nifi \
-DarchetypeArtifactId=nifi-processor-bundle-archetype \
-DnifiVersion=2.0.0-M1 \
-DartifactBaseName=example \
-DgroupId=org.example \
-DartifactId=myproject \
-Dversion=0.0.1 \
-Dpackage=org.example.processors.example {code}
{code:java}
cd myproject
mvn package {code}
> Processor Bundle Maven Archetype broken build
> -
>
> Key: NIFI-12608
> URL: https://issues.apache.org/jira/browse/NIFI-12608
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Affects Versions: 2.0.0-M1
>Reporter: Shane O'Neill
>Priority: Major
>
> I am seeing the {{mvn archetype:generate}} CLI fail to produce a buildable
> project for the {{{}nifi-processor-bundle-archetype{}}}. The error is:
> {code:java}
> java.lang.ClassNotFoundException:
> org.apache.nifi.processor.util.StandardValidators
> at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
> at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
> at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
> at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
> at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
> at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
> at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
> (MethodHandleAccessorFactory.java:300)
> at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
> (MethodHandleAccessorFactory.java:103)
> at jdk.internal.reflect.ReflectionFactory.newConstructorAccessor
> (ReflectionFactory.java:200)
> at java.lang.refl
[jira] [Created] (NIFI-12608) Processor Bundle Maven Archetype broken build
Shane O'Neill created NIFI-12608:
Summary: Processor Bundle Maven Archetype broken build
Key: NIFI-12608
URL: https://issues.apache.org/jira/browse/NIFI-12608
Project: Apache NiFi
Issue Type: Bug
Components: Tools and Build
Affects Versions: 2.0.0-M1
Reporter: Shane O'Neill
I am seeing the {{mvn archetype:generate}} CLI fail to produce a buildable
project for the {{{}nifi-processor-bundle-archetype{}}}. The error is:
Caused by: java.lang.ClassNotFoundException:
org.apache.nifi.processor.util.StandardValidators
at java.net.URLClassLoader.findClass (URLClassLoader.java:445)
at java.lang.ClassLoader.loadClass (ClassLoader.java:593)
at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
at org.example.processors.example.MyProcessor. (MyProcessor.java:53)
at jdk.internal.misc.Unsafe.ensureClassInitialized0 (Native Method)
at jdk.internal.misc.Unsafe.ensureClassInitialized (Unsafe.java:1160)
at jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized
(MethodHandleAccessorFactory.java:300)
at jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor
(MethodHandleAccessorFactory.java:103)
at jdk.internal.reflect.ReflectionFactory.newConstructorAccessor
(ReflectionFactory.java:200)
at java.lang.reflect.Constructor.acquireConstructorAccessor
(Constructor.java:549)
at java.lang.reflect.Constructor.newInstanceWithCaller
(Constructor.java:499)
at java.lang.reflect.Constructor.newInstance (Constructor.java:486){{}}
Adding {{nifi-standard-services-api-nar}} to the NAR packaging module fixes it.
To recreate the issue, generate a project and run mvn package.
{{}}
mvn archetype:generate \
-DarchetypeGroupId=org.apache.nifi \
-DarchetypeArtifactId=nifi-processor-bundle-archetype \
-DnifiVersion=2.0.0-M1 \
-DartifactBaseName=example \
-DgroupId=org.example \
-DartifactId=myproject \
-Dversion=0.0.1 \
-Dpackage=org.example.processors.example
cd myproject
mvn package
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12594: ListS3 - observe min/max object age when entity state tracking is used [nifi]
p-kimberley commented on code in PR #8231:
URL: https://github.com/apache/nifi/pull/8231#discussion_r1451091233
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##
@@ -499,23 +500,19 @@ private void listByTrackingTimestamps(ProcessContext
context, ProcessSession ses
writer.beginListing();
do {
-VersionListing versionListing = bucketLister.listVersions();
+final VersionListing versionListing =
bucketLister.listVersions();
for (S3VersionSummary versionSummary :
versionListing.getVersionSummaries()) {
-long lastModified =
versionSummary.getLastModified().getTime();
-if (lastModified < currentTimestamp
-|| lastModified == currentTimestamp &&
currentKeys.contains(versionSummary.getKey())
-|| (maxAgeMilliseconds != null && (lastModified <
(listingTimestamp - maxAgeMilliseconds)))
-|| lastModified > (listingTimestamp -
minAgeMilliseconds)) {
+final long lastModified =
versionSummary.getLastModified().getTime();
+if (lastModified == currentTimestamp &&
currentKeys.contains(versionSummary.getKey())
+|| !includeObjectInListing(versionSummary,
listingTimestamp)) {
Review Comment:
Good pickup, thanks. I found the variable names to be confusing, so
`currentTimestamp` is now `listingTimestamp` and vice versa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12349: Create Put processor for Apache Hudi [nifi]
exceptionfactory commented on PR #8012: URL: https://github.com/apache/nifi/pull/8012#issuecomment-1890170771 @mark-bathori Since it has been several months, and there have been significant framework dependency upgrades, I'm closing this pull request for now. Feel free to open it again after revisiting the dependencies, and as mentioned, it may be better to wait until Hudi is out of incubation, or release these Processor through an alternate mechanism is the interim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12349: Create Put processor for Apache Hudi [nifi]
exceptionfactory closed pull request #8012: NIFI-12349: Create Put processor for Apache Hudi URL: https://github.com/apache/nifi/pull/8012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12394 when synching to a VersionedFlow, make sure processor references to new controller services are valid [nifi]
exceptionfactory commented on code in PR #8184:
URL: https://github.com/apache/nifi/pull/8184#discussion_r1451043360
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##
@@ -1433,6 +1434,14 @@ private Map populatePropertiesMap(final
ComponentNode componentN
final String serviceVersionedComponentId =
proposedProperties.get(propertyName);
String instanceId =
getServiceInstanceId(serviceVersionedComponentId, group);
value = (instanceId == null) ?
serviceVersionedComponentId : instanceId;
+
+// Find the same property descriptor in the
component's CreatedExtension and replace it with the
+// instance ID of the service
+createdExtensions.stream().filter(ce ->
ce.extension.equals(componentNode)).forEach(createdExtension -> {
+LOG.debug("Replacing CreatedExtension property {}
old value {} with new value {}",
+propertyName,
createdExtension.propertyValues.get(propertyName) , value);
Review Comment:
This debug log should be removed because property values may contain
sensitive information that should not be logged.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11294 ConsumeAzureEventHub supports storing checkpoints in compo… [nifi]
exceptionfactory commented on PR #8013: URL: https://github.com/apache/nifi/pull/8013#issuecomment-1890155711 > @exceptionfactory Pushed the state clean-up. > > While I was testing it, I found a more generic issue unfortunately: If you run ConsumeAzureEventHub in a cluster, the processor instances use the shared cluster state provider (e.g. Zookeeper) and maintain the state together, handle the partition balancing, etc. It works properly until all nodes use the shared cluster state. But if you disconnect a node from the cluster (on the UI or I guess the same happens when there is a network issue between the nodes), the disconnected node becomes a standalone node and it does not use the shared state anymore but starts to maintain its own state in the local state provider from scratch. As the disconnected node does not know about the other consumer instances, it believes it is the only consumer in the group and can own all the partitions. Both the remaining part of the cluster and the disconnected node try to own the same partitions. The checkpoints will be maintained in two places (cluster vs local state) and it will lead to message dupl ication. It would be better if the processor on the disconnected node was stopped and did not create its local state at all. Do you think it is possible? I'm afraid it is how the framework works though. Thanks for making the changes and highlighting the concern @turcsanyip. Changing a node from a cluster member to a standalone instance effectively changes the state source as you noted. However, if a node is part of a cluster and temporarily has cluster communication problems, this is different than manually disconnecting and removing the node from the cluster. With that background, I don't think that scenario should be a concern because switching cluster membership should be a manual process. Are you observing different behavior? With that background, it seems like this should be close to completion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11294 ConsumeAzureEventHub supports storing checkpoints in compo… [nifi]
turcsanyip commented on PR #8013: URL: https://github.com/apache/nifi/pull/8013#issuecomment-1890147926 @exceptionfactory Pushed the state clean-up. While I was testing it, I found a more generic issue unfortunately: If you run ConsumeAzureEventHub in a cluster, the processor instances use the shared cluster state provider (e.g. Zookeeper) and maintain the state together, handle the partition balancing, etc. It works properly until all nodes use the shared cluster state. But if you disconnect a node from the cluster (on the UI or I guess the same happens when there is a network issue between the nodes), the disconnected node becomes a standalone node and it does not use the shared state anymore but starts to maintain its own state in the local state provider from scratch. As the disconnected node does not know about the other consumer instances, it believes it is the only consumer in the group and can own all the partitions. Both the remaining part of the cluster and the disconnected node try to own the same partitions. The checkpoints will be maintained in two places (cluster vs local state) and it will lead to message duplication. It would be better if the processor on the disconnected node was stopped and did not create its local state at all. Do you think it is possible? I'm afraid it is how the framework works though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12588) Flow Analysis Rules
[ https://issues.apache.org/jira/browse/NIFI-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman resolved NIFI-12588. Fix Version/s: 2.0.0 Resolution: Fixed > Flow Analysis Rules > --- > > Key: NIFI-12588 > URL: https://issues.apache.org/jira/browse/NIFI-12588 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12588) Flow Analysis Rules
[ https://issues.apache.org/jira/browse/NIFI-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806221#comment-17806221 ] ASF subversion and git services commented on NIFI-12588: Commit f1cac06f2aa40a3b4f5f3e9415500cc007df37ee in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f1cac06f2a ] NIFI-12588: Flow Analysis Rules (#8241) * [NIFI-12588] Flow Analysis Rules listing review feedback update goto dialog title remove transitional states of enable fix CS goto remove access policy UX check canModifyController update currentTime move interfaces update sorting, inline CS creation, CS goto use Edit in dialog titles * review feedback * input current user This closes #8241 > Flow Analysis Rules > --- > > Key: NIFI-12588 > URL: https://issues.apache.org/jira/browse/NIFI-12588 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12588: Flow Analysis Rules [nifi]
mcgilman merged PR #8241: URL: https://github.com/apache/nifi/pull/8241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12606) Update Apache parent POM to version 31
[ https://issues.apache.org/jira/browse/NIFI-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12606: Resolution: Fixed Status: Resolved (was: Patch Available) > Update Apache parent POM to version 31 > -- > > Key: NIFI-12606 > URL: https://issues.apache.org/jira/browse/NIFI-12606 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Apache parent POM (used at the root pom.xml in NiFi) has a new release, > version 31: > https://github.com/apache/maven-apache-parent/releases/tag/apache-31 > This includes a number of dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12606) Update Apache parent POM to version 31
[ https://issues.apache.org/jira/browse/NIFI-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806206#comment-17806206 ] ASF subversion and git services commented on NIFI-12606: Commit 037ab2886fbf017e67074773b618c3ce8c96abeb in nifi's branch refs/heads/support/nifi-1.x from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=037ab2886f ] NIFI-12606: Upgrade parent Apache POM to version 31 > Update Apache parent POM to version 31 > -- > > Key: NIFI-12606 > URL: https://issues.apache.org/jira/browse/NIFI-12606 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Apache parent POM (used at the root pom.xml in NiFi) has a new release, > version 31: > https://github.com/apache/maven-apache-parent/releases/tag/apache-31 > This includes a number of dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12606) Update Apache parent POM to version 31
[ https://issues.apache.org/jira/browse/NIFI-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806205#comment-17806205 ] ASF subversion and git services commented on NIFI-12606: Commit be16a423ed8a1082e1692bfe75e7afe3660e4e35 in nifi's branch refs/heads/main from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=be16a423ed ] NIFI-12606: Upgrade parent Apache POM to version 31 This closes #8242. Signed-off-by: Joseph Witt > Update Apache parent POM to version 31 > -- > > Key: NIFI-12606 > URL: https://issues.apache.org/jira/browse/NIFI-12606 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.25.0, 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The Apache parent POM (used at the root pom.xml in NiFi) has a new release, > version 31: > https://github.com/apache/maven-apache-parent/releases/tag/apache-31 > This includes a number of dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12606: Upgrade parent Apache POM to version 31 [nifi]
asfgit closed pull request #8242: NIFI-12606: Upgrade parent Apache POM to version 31 URL: https://github.com/apache/nifi/pull/8242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12607) Remove TIMED_WAIT doc for kernel 2.6
[ https://issues.apache.org/jira/browse/NIFI-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12607: Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) Thanks Andrew! > Remove TIMED_WAIT doc for kernel 2.6 > > > Key: NIFI-12607 > URL: https://issues.apache.org/jira/browse/NIFI-12607 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation & Website >Affects Versions: 2.0.0-M1 >Reporter: Andrew Atwood >Assignee: Andrew Atwood >Priority: Trivial > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Admin guide includes how to configure TIMED_WAIT for linux kernel 2.6, but no > up-to-date linux distro should still be using 2.6, as its support ended in > 2016 per > https://en.wikipedia.org/wiki/Linux_kernel_version_history#Releases_2.6.x.y -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12607) Remove TIMED_WAIT doc for kernel 2.6
[ https://issues.apache.org/jira/browse/NIFI-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806203#comment-17806203 ] ASF subversion and git services commented on NIFI-12607: Commit 2179d16bdc3b79b34fce111ce6272561faec08c5 in nifi's branch refs/heads/main from theBestAndrew [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2179d16bdc ] NIFI-12607 This closes #8243. remove kernel 2.6 TIMED_WAIT documentation Signed-off-by: Joseph Witt > Remove TIMED_WAIT doc for kernel 2.6 > > > Key: NIFI-12607 > URL: https://issues.apache.org/jira/browse/NIFI-12607 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation & Website >Affects Versions: 2.0.0-M1 >Reporter: Andrew Atwood >Assignee: Andrew Atwood >Priority: Trivial > Time Spent: 10m > Remaining Estimate: 0h > > Admin guide includes how to configure TIMED_WAIT for linux kernel 2.6, but no > up-to-date linux distro should still be using 2.6, as its support ended in > 2016 per > https://en.wikipedia.org/wiki/Linux_kernel_version_history#Releases_2.6.x.y -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12607 remove kernel 2.6 TIMED_WAIT documentation [nifi]
asfgit closed pull request #8243: NIFI-12607 remove kernel 2.6 TIMED_WAIT documentation URL: https://github.com/apache/nifi/pull/8243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12607) Remove TIMED_WAIT doc for kernel 2.6
[ https://issues.apache.org/jira/browse/NIFI-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Atwood updated NIFI-12607: - Status: Patch Available (was: In Progress) > Remove TIMED_WAIT doc for kernel 2.6 > > > Key: NIFI-12607 > URL: https://issues.apache.org/jira/browse/NIFI-12607 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation & Website >Affects Versions: 2.0.0-M1 >Reporter: Andrew Atwood >Assignee: Andrew Atwood >Priority: Trivial > Time Spent: 10m > Remaining Estimate: 0h > > Admin guide includes how to configure TIMED_WAIT for linux kernel 2.6, but no > up-to-date linux distro should still be using 2.6, as its support ended in > 2016 per > https://en.wikipedia.org/wiki/Linux_kernel_version_history#Releases_2.6.x.y -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12607 remove kernel 2.6 TIMED_WAIT documentation [nifi]
theBestAndrew opened a new pull request, #8243: URL: https://github.com/apache/nifi/pull/8243 # Summary [NIFI-12607](https://issues.apache.org/jira/browse/NIFI-12607) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12589) List Queue
[ https://issues.apache.org/jira/browse/NIFI-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12589: --- Resolution: Fixed Status: Resolved (was: Patch Available) > List Queue > -- > > Key: NIFI-12589 > URL: https://issues.apache.org/jira/browse/NIFI-12589 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Add support for listing a queue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12589) List Queue
[ https://issues.apache.org/jira/browse/NIFI-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806191#comment-17806191 ] ASF subversion and git services commented on NIFI-12589: Commit a7546a7095670fc871f0a45750183677fb72538a in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a7546a7095 ] NIFI-12589: Queue Listing (#8235) * NIFI-12589: - Introducing queue listing. - View flowfile content. - Download flowfile content. - View flowfile dialog. * NIFI-12589: - Addressing review feedback. * NIFI-12589: - Fixing merge conflict and removing additional @ts-ignore. This closes #8235 > List Queue > -- > > Key: NIFI-12589 > URL: https://issues.apache.org/jira/browse/NIFI-12589 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Add support for listing a queue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12561) MergeContent processor retains text delimiter settings when switched to 'Do Not Use Delimiters' strategy
[
https://issues.apache.org/jira/browse/NIFI-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12561.
-
Fix Version/s: 1.25.0
2.0.0
Resolution: Fixed
> MergeContent processor retains text delimiter settings when switched to 'Do
> Not Use Delimiters' strategy
>
>
> Key: NIFI-12561
> URL: https://issues.apache.org/jira/browse/NIFI-12561
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.24.0
> Environment: NiFi Docker
>Reporter: Mohammed Salim
>Assignee: endzeit
>Priority: Minor
> Fix For: 1.25.0, 2.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In the MergeContent processor version 1.24.0, when configuring the processor
> to use Text Delimiters (by setting values for Header, Footer, and
> Demarcator), and then changing the Delimiter Strategy to "Do Not Use
> Delimiters", the previously set values for the Text Delimiters Strategy are
> still being applied during processing.
> {_}Steps to Reproduce{_}:
> # Configure the MergeContent processor with the Delimiter Strategy set to
> "Text".
> # Set values for Header, Footer, and Demarcator.
> # Apply the configuration changes.
> # Change the Delimiter Strategy to "Do Not Use Delimiters" and apply the
> configuration.
> # Observe that the processor still uses the old values for Header, Footer,
> and Demarcator during processing, despite the Delimiter Strategy being set to
> "Do Not Use Delimiters".
> {_}Expected Behavior{_}: When changing the Delimiter Strategy to "Do Not Use
> Delimiters", any previously set values for Text Delimiters should not be
> applied.
> {_}Actual Behavior{_}: The processor retains and applies the old values for
> Text Delimiters even after changing the Delimiter Strategy to "Do Not Use
> Delimiters".
> {_}Environment{_}:
> * NiFi Version: 1.24.0
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12589: Queue Listing [nifi]
scottyaslan merged PR #8235: URL: https://github.com/apache/nifi/pull/8235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12561) MergeContent processor retains text delimiter settings when switched to 'Do Not Use Delimiters' strategy
[
https://issues.apache.org/jira/browse/NIFI-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806190#comment-17806190
]
ASF subversion and git services commented on NIFI-12561:
Commit 3c3ce0d51a08c70a0d80670c595dcfb8fbac1ea5 in nifi's branch
refs/heads/support/nifi-1.x from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3c3ce0d51a ]
NIFI-12561 Fixed MergeContent DELIMITER_STRATEGY_NONE Handling
This closes #8222
Signed-off-by: David Handermann
(cherry picked from commit 4efabdcf51e89c93738b0dbab3eafefd12faec6a)
> MergeContent processor retains text delimiter settings when switched to 'Do
> Not Use Delimiters' strategy
>
>
> Key: NIFI-12561
> URL: https://issues.apache.org/jira/browse/NIFI-12561
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.24.0
> Environment: NiFi Docker
>Reporter: Mohammed Salim
>Assignee: endzeit
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In the MergeContent processor version 1.24.0, when configuring the processor
> to use Text Delimiters (by setting values for Header, Footer, and
> Demarcator), and then changing the Delimiter Strategy to "Do Not Use
> Delimiters", the previously set values for the Text Delimiters Strategy are
> still being applied during processing.
> {_}Steps to Reproduce{_}:
> # Configure the MergeContent processor with the Delimiter Strategy set to
> "Text".
> # Set values for Header, Footer, and Demarcator.
> # Apply the configuration changes.
> # Change the Delimiter Strategy to "Do Not Use Delimiters" and apply the
> configuration.
> # Observe that the processor still uses the old values for Header, Footer,
> and Demarcator during processing, despite the Delimiter Strategy being set to
> "Do Not Use Delimiters".
> {_}Expected Behavior{_}: When changing the Delimiter Strategy to "Do Not Use
> Delimiters", any previously set values for Text Delimiters should not be
> applied.
> {_}Actual Behavior{_}: The processor retains and applies the old values for
> Text Delimiters even after changing the Delimiter Strategy to "Do Not Use
> Delimiters".
> {_}Environment{_}:
> * NiFi Version: 1.24.0
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12561) MergeContent processor retains text delimiter settings when switched to 'Do Not Use Delimiters' strategy
[
https://issues.apache.org/jira/browse/NIFI-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806187#comment-17806187
]
ASF subversion and git services commented on NIFI-12561:
Commit 4efabdcf51e89c93738b0dbab3eafefd12faec6a in nifi's branch
refs/heads/main from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4efabdcf51 ]
NIFI-12561 Fixed MergeContent DELIMITER_STRATEGY_NONE Handling
This closes #8222
Signed-off-by: David Handermann
> MergeContent processor retains text delimiter settings when switched to 'Do
> Not Use Delimiters' strategy
>
>
> Key: NIFI-12561
> URL: https://issues.apache.org/jira/browse/NIFI-12561
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.24.0
> Environment: NiFi Docker
>Reporter: Mohammed Salim
>Assignee: endzeit
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In the MergeContent processor version 1.24.0, when configuring the processor
> to use Text Delimiters (by setting values for Header, Footer, and
> Demarcator), and then changing the Delimiter Strategy to "Do Not Use
> Delimiters", the previously set values for the Text Delimiters Strategy are
> still being applied during processing.
> {_}Steps to Reproduce{_}:
> # Configure the MergeContent processor with the Delimiter Strategy set to
> "Text".
> # Set values for Header, Footer, and Demarcator.
> # Apply the configuration changes.
> # Change the Delimiter Strategy to "Do Not Use Delimiters" and apply the
> configuration.
> # Observe that the processor still uses the old values for Header, Footer,
> and Demarcator during processing, despite the Delimiter Strategy being set to
> "Do Not Use Delimiters".
> {_}Expected Behavior{_}: When changing the Delimiter Strategy to "Do Not Use
> Delimiters", any previously set values for Text Delimiters should not be
> applied.
> {_}Actual Behavior{_}: The processor retains and applies the old values for
> Text Delimiters even after changing the Delimiter Strategy to "Do Not Use
> Delimiters".
> {_}Environment{_}:
> * NiFi Version: 1.24.0
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12561 MergeContent honours DELIMITER_STRATEGY_NONE [nifi]
exceptionfactory closed pull request #8222: NIFI-12561 MergeContent honours DELIMITER_STRATEGY_NONE URL: https://github.com/apache/nifi/pull/8222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12599) Add READ_FILESYSTEM Permissions to File Lookup Services
[ https://issues.apache.org/jira/browse/NIFI-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12599. - Resolution: Fixed > Add READ_FILESYSTEM Permissions to File Lookup Services > --- > > Key: NIFI-12599 > URL: https://issues.apache.org/jira/browse/NIFI-12599 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Some lookup controller services requires to have the proper restrictions as > they access the local file system for reading some files: > * XMLFileLookupService > * SimpleCsvFileLookupService > * PropertiesFileLookupService > * CSVRecordLookupService -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12599) Add READ_FILESYSTEM Permissions to File Lookup Services
[ https://issues.apache.org/jira/browse/NIFI-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12599: Summary: Add READ_FILESYSTEM Permissions to File Lookup Services (was: Add proper restrictions on some lookup controller services) > Add READ_FILESYSTEM Permissions to File Lookup Services > --- > > Key: NIFI-12599 > URL: https://issues.apache.org/jira/browse/NIFI-12599 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Some lookup controller services requires to have the proper restrictions as > they access the local file system for reading some files: > * XMLFileLookupService > * SimpleCsvFileLookupService > * PropertiesFileLookupService > * CSVRecordLookupService -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12599) Add proper restrictions on some lookup controller services
[ https://issues.apache.org/jira/browse/NIFI-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806183#comment-17806183 ] ASF subversion and git services commented on NIFI-12599: Commit f95dde16309b9a521bbadb4db639519410bc80e2 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f95dde1630 ] NIFI-12599 Added READ_FILESYSTEM Permissions to Lookup Services This closes #8236 Signed-off-by: David Handermann > Add proper restrictions on some lookup controller services > -- > > Key: NIFI-12599 > URL: https://issues.apache.org/jira/browse/NIFI-12599 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Some lookup controller services requires to have the proper restrictions as > they access the local file system for reading some files: > * XMLFileLookupService > * SimpleCsvFileLookupService > * PropertiesFileLookupService > * CSVRecordLookupService -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12599) Add proper restrictions on some lookup controller services
[ https://issues.apache.org/jira/browse/NIFI-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806184#comment-17806184 ] ASF subversion and git services commented on NIFI-12599: Commit c39bdda02f817c5efed94671f56fe21d14be6993 in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c39bdda02f ] NIFI-12599 Added READ_FILESYSTEM Permissions to Lookup Services This closes #8236 Signed-off-by: David Handermann (cherry picked from commit f95dde16309b9a521bbadb4db639519410bc80e2) > Add proper restrictions on some lookup controller services > -- > > Key: NIFI-12599 > URL: https://issues.apache.org/jira/browse/NIFI-12599 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Some lookup controller services requires to have the proper restrictions as > they access the local file system for reading some files: > * XMLFileLookupService > * SimpleCsvFileLookupService > * PropertiesFileLookupService > * CSVRecordLookupService -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12599 - Add proper restrictions on some lookup controller services [nifi]
exceptionfactory closed pull request #8236: NIFI-12599 - Add proper restrictions on some lookup controller services URL: https://github.com/apache/nifi/pull/8236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12607) Remove TIMED_WAIT doc for kernel 2.6
Andrew Atwood created NIFI-12607: Summary: Remove TIMED_WAIT doc for kernel 2.6 Key: NIFI-12607 URL: https://issues.apache.org/jira/browse/NIFI-12607 Project: Apache NiFi Issue Type: Improvement Components: Documentation & Website Affects Versions: 2.0.0-M1 Reporter: Andrew Atwood Assignee: Andrew Atwood Admin guide includes how to configure TIMED_WAIT for linux kernel 2.6, but no up-to-date linux distro should still be using 2.6, as its support ended in 2016 per https://en.wikipedia.org/wiki/Linux_kernel_version_history#Releases_2.6.x.y -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12606) Update Apache parent POM to version 31
[ https://issues.apache.org/jira/browse/NIFI-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12606: Fix Version/s: 1.25.0 2.0.0 Status: Patch Available (was: In Progress) > Update Apache parent POM to version 31 > -- > > Key: NIFI-12606 > URL: https://issues.apache.org/jira/browse/NIFI-12606 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.25.0, 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The Apache parent POM (used at the root pom.xml in NiFi) has a new release, > version 31: > https://github.com/apache/maven-apache-parent/releases/tag/apache-31 > This includes a number of dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12606: Upgrade parent Apache POM to version 31 [nifi]
mattyb149 opened a new pull request, #8242: URL: https://github.com/apache/nifi/pull/8242 # Summary [NIFI-12606](https://issues.apache.org/jira/browse/NIFI-12606) This PR upgrades the root pom.xml to use the latest Apache parent POM (version 31) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12606) Update Apache parent POM to version 31
[ https://issues.apache.org/jira/browse/NIFI-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-12606: --- Assignee: Matt Burgess > Update Apache parent POM to version 31 > -- > > Key: NIFI-12606 > URL: https://issues.apache.org/jira/browse/NIFI-12606 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > > The Apache parent POM (used at the root pom.xml in NiFi) has a new release, > version 31: > https://github.com/apache/maven-apache-parent/releases/tag/apache-31 > This includes a number of dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12606) Update Apache parent POM to version 31
Matt Burgess created NIFI-12606: --- Summary: Update Apache parent POM to version 31 Key: NIFI-12606 URL: https://issues.apache.org/jira/browse/NIFI-12606 Project: Apache NiFi Issue Type: Improvement Components: Tools and Build Reporter: Matt Burgess The Apache parent POM (used at the root pom.xml in NiFi) has a new release, version 31: https://github.com/apache/maven-apache-parent/releases/tag/apache-31 This includes a number of dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12588: Flow Analysis Rules [nifi]
scottyaslan commented on PR #8241: URL: https://github.com/apache/nifi/pull/8241#issuecomment-1889850234 Thanks for the review @mcgilman! I have addressed your comments and I think this PR is ready to merge once CI completes successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12548) Introduce pages for managing Access Policies
[ https://issues.apache.org/jira/browse/NIFI-12548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12548: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Introduce pages for managing Access Policies > > > Key: NIFI-12548 > URL: https://issues.apache.org/jira/browse/NIFI-12548 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > New pages should be introduced for managing both global access policies and > component-specific access policies. Further, we should include necessary > actions to configure access policies for components that support them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12548) Introduce pages for managing Access Policies
[ https://issues.apache.org/jira/browse/NIFI-12548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806169#comment-17806169 ] ASF subversion and git services commented on NIFI-12548: Commit 0a3393b091db849f47f08531644d5e089ffa2fa3 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0a3393b091 ] NIFI-12548: Policy Management (#8225) * NIFI-12548: - Global Access Policies. * NIFI-12548: - Component Access Policies. * NIFI-12548: - Addressing review feedback. * NIFI-12548: - Addressing review feedback. This closes #8225 > Introduce pages for managing Access Policies > > > Key: NIFI-12548 > URL: https://issues.apache.org/jira/browse/NIFI-12548 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > New pages should be introduced for managing both global access policies and > component-specific access policies. Further, we should include necessary > actions to configure access policies for components that support them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12548: Policy Management [nifi]
rfellows merged PR #8225: URL: https://github.com/apache/nifi/pull/8225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12605) Stateless Nifi Artifactory Extension Client
Dye357 created NIFI-12605: - Summary: Stateless Nifi Artifactory Extension Client Key: NIFI-12605 URL: https://issues.apache.org/jira/browse/NIFI-12605 Project: Apache NiFi Issue Type: New Feature Components: NiFi Stateless Reporter: Dye357 Currently Stateless Nifi supports pulling extensions via the Nexus Extension Client - this ticket would add another implementation of the Extension Client interface to support pulling artifacts from Artifactory. Yes, Technically the nexus client will work against an Artifactory as long as the repository type is Maven2 however the nexus client as-is does not support additional features offered by Artifactory such as Authentication with an Auth Token. Proposed implementation would be an Artifactory Extension Client, the client would support authenticating using an auth token (via configuration) for pulling bundles. Additionally the interface would be modified to add an enabled flag to the Extension Client interface such that we can disable extension clients that we do-not want to run. The Artifactory extension client to be disabled by default so the current out of the box behavior's remains unchanged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12588: Flow Analysis Rules [nifi]
mcgilman commented on code in PR #8241:
URL: https://github.com/apache/nifi/pull/8241#discussion_r1450786595
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/flow-analysis-rules/flow-analysis-rule-table/flow-analysis-rule-table.component.ts:
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, EventEmitter, Input, Output, ViewChild } from
'@angular/core';
+import { MatButtonModule } from '@angular/material/button';
+import { MatDialogModule } from '@angular/material/dialog';
+import { RouterLink } from '@angular/router';
+import { NgClass, NgIf } from '@angular/common';
+import { MatTableDataSource, MatTableModule } from '@angular/material/table';
+import { MatSortModule, Sort } from '@angular/material/sort';
+import { FlowAnalysisRuleEntity } from '../../../state/flow-analysis-rules';
+import { TextTip } from
'../../../../../ui/common/tooltips/text-tip/text-tip.component';
+import { BulletinsTip } from
'../../../../../ui/common/tooltips/bulletins-tip/bulletins-tip.component';
+import { ValidationErrorsTip } from
'../../../../../ui/common/tooltips/validation-errors-tip/validation-errors-tip.component';
+import { NiFiCommon } from '../../../../../service/nifi-common.service';
+import { BulletinsTipInput, TextTipInput, ValidationErrorsTipInput } from
'../../../../../state/shared';
+import { NifiTooltipDirective } from
'../../../../../ui/common/tooltips/nifi-tooltip.directive';
+import { ReportingTaskEntity } from '../../../state/reporting-tasks';
+
+@Component({
+selector: 'flow-analysis-rule-table',
+standalone: true,
+templateUrl: './flow-analysis-rule-table.component.html',
+imports: [
+MatButtonModule,
+MatDialogModule,
+MatTableModule,
+MatSortModule,
+NgIf,
+NgClass,
+NifiTooltipDirective,
+RouterLink
+],
+styleUrls: ['./flow-analysis-rule-table.component.scss',
'../../../../../../assets/styles/listing-table.scss']
+})
+export class FlowAnalysisRuleTable {
+@Input() set flowAnalysisRules(flowAnalysisRuleEntities:
FlowAnalysisRuleEntity[]) {
+this.dataSource = new
MatTableDataSource(flowAnalysisRuleEntities);
+this.dataSource.data =
this.sortFlowAnalysisRules(flowAnalysisRuleEntities, this.sort);
+}
+@Input() selectedFlowAnalysisRuleId!: string;
+@Input() definedByCurrentGroup!: (entity: FlowAnalysisRuleEntity) =>
boolean;
+@Input() canModifyParent!: (entity: FlowAnalysisRuleEntity) => boolean;
+
+@Output() selectFlowAnalysisRule: EventEmitter =
new EventEmitter();
+@Output() deleteFlowAnalysisRule: EventEmitter =
new EventEmitter();
+@Output() configureFlowAnalysisRule: EventEmitter =
+new EventEmitter();
+@Output() enableFlowAnalysisRule: EventEmitter =
new EventEmitter();
+@Output() disableFlowAnalysisRule: EventEmitter =
+new EventEmitter();
+
+sort: Sort = {
+active: 'name',
+direction: 'asc'
+};
+
+protected readonly TextTip = TextTip;
+protected readonly BulletinsTip = BulletinsTip;
+protected readonly ValidationErrorsTip = ValidationErrorsTip;
+
+displayedColumns: string[] = ['moreDetails', 'name', 'type', 'bundle',
'state', 'actions'];
+dataSource: MatTableDataSource = new
MatTableDataSource();
+
+constructor(private nifiCommon: NiFiCommon) {}
+
+updateSort(sort: Sort): void {
+this.sort = sort;
+this.dataSource.data =
this.sortFlowAnalysisRules(this.dataSource.data, sort);
+}
+
+sortFlowAnalysisRules(items: FlowAnalysisRuleEntity[], sort: Sort):
FlowAnalysisRuleEntity[] {
+const data: FlowAnalysisRuleEntity[] = items.slice();
+return data.sort((a, b) => {
+const isAsc = sort.direction === 'asc';
+
+let retVal: number = 0;
+switch (sort.active) {
+case 'name':
+retVal = this.nifiCommon.compareString(this.formatType(a),
this.formatType(b));
+break;
+case 'type':
+retVal = this.nifiCommon.compareString(this.formatType(
[jira] [Created] (NIFI-12604) Add support to empty queues
Matt Gilman created NIFI-12604: -- Summary: Add support to empty queues Key: NIFI-12604 URL: https://issues.apache.org/jira/browse/NIFI-12604 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Introduce actions for emptying a queue or all queues within a Process Group. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]
juldrixx commented on PR #8240: URL: https://github.com/apache/nifi/pull/8240#issuecomment-1889716522 > Thanks for proposing this addition @juldrixx. I provided some recommendations on naming and implementation details. Thanks for the review, I should have made the requested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]
juldrixx commented on code in PR #8240:
URL: https://github.com/apache/nifi/pull/8240#discussion_r1450752341
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-kubernetes-bundle/nifi-framework-kubernetes-state-provider/src/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java:
##
@@ -99,6 +116,11 @@ public void initialize(final
StateProviderInitializationContext context) {
this.logger = context.getLogger();
this.kubernetesClient = getKubernetesClient();
this.namespace = new ServiceAccountNamespaceProvider().getNamespace();
+
+String resourcePrefix = context.getProperty(RESOURCE_PREFIX).isSet() ?
context.getProperty(RESOURCE_PREFIX).getValue() : null;
+CONFIG_MAP_NAME_FORMAT = resourcePrefix != null ?
String.format("%s-nifi-component-%%s", resourcePrefix) : "nifi-component-%s";
+CONFIG_MAP_NAME_PATTERN = Pattern.compile(resourcePrefix != null ?
+String.format("^%s-nifi-component-(.+)$", resourcePrefix) :
"^nifi-component-(.+)$");
Review Comment:
Created the variable `CONFIG_MAP_CORE_NAME`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enab
[jira] [Created] (NIFI-12603) Dialog vertical fesizing on smaller screens do not allow users to access all fields
Scott Aslan created NIFI-12603: -- Summary: Dialog vertical fesizing on smaller screens do not allow users to access all fields Key: NIFI-12603 URL: https://issues.apache.org/jira/browse/NIFI-12603 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: Kapture 2024-01-12 at 11.33.57.gif -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12603) Dialog vertical resizing on smaller screens do not allow users to access all fields
[ https://issues.apache.org/jira/browse/NIFI-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12603: --- Summary: Dialog vertical resizing on smaller screens do not allow users to access all fields (was: Dialog vertical fesizing on smaller screens do not allow users to access all fields) > Dialog vertical resizing on smaller screens do not allow users to access all > fields > --- > > Key: NIFI-12603 > URL: https://issues.apache.org/jira/browse/NIFI-12603 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > Attachments: Kapture 2024-01-12 at 11.33.57.gif > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Nifi 12588 [nifi]
scottyaslan opened a new pull request, #8241: URL: https://github.com/apache/nifi/pull/8241 NIFI-12588 Flow Analysis Rules UX -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12400] Flow Analysis Rules listing [nifi]
scottyaslan closed pull request #8233: [NIFI-12400] Flow Analysis Rules listing URL: https://github.com/apache/nifi/pull/8233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12400] Flow Analysis Rules listing [nifi]
scottyaslan commented on code in PR #8233: URL: https://github.com/apache/nifi/pull/8233#discussion_r1450692035 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/reporting-tasks/edit-reporting-task/edit-reporting-task.component.html: ## @@ -15,7 +15,7 @@ ~ limitations under the License. --> -Edit Reporting Task +Configure Reporting Task Review Comment: Ok we will go with Edit in dialog titles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12400] Flow Analysis Rules listing [nifi]
scottyaslan commented on code in PR #8233: URL: https://github.com/apache/nifi/pull/8233#discussion_r1450690250 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/flow-analysis-rules/flow-analysis-rule-table/flow-analysis-rule-table.component.html: ## @@ -0,0 +1,145 @@ + + + + + + + + + + + + + + + + + + + + Review Comment: We discussed this and will keep the bulletins for now as it is not clear if this feature supports it or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12548: Policy Management [nifi]
rfellows commented on code in PR #8225:
URL: https://github.com/apache/nifi/pull/8225#discussion_r1450555490
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.html:
##
@@ -0,0 +1,152 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+No policy for the specified resource.
+
+Create a
new policy.
+
+
+
+
+
+
+
+
+Not authorized to access the policy for the
specified resource.
+
+
+
+
+
+
+
+
+
+
+
+{{
policyComponentState.label }}
+{{
getContextType() }}
+
+
+
+
+Policy
+
+{{ option.text }}
+
Review Comment:
should we just not show the options that are not selectable? I realize NiFi
does it the same way as implemented here, but if the user can't select them why
show them? Especially since the dropdown is padded more and there are cases
where you have to scroll past disabled items to get to the next available
option.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/global-access-policies/global-access-policies-routing.module.ts:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { NgModule } from '@angular/core';
+import { RouterModule, Routes } from '@angular/router';
+import { GlobalAccessPolicies } from './global-access-policies.component';
+import { authorizationGuard } from
'../../../../service/guard/authorization.guard';
+import { CurrentUser } from '../../../../state/current-user';
+
+const routes: Routes = [
+{
+path: ':action/:resource',
+canMatch: [
+authorizationGuard(
+(user: CurrentUser) =>
+user.tenantsPermissions.canRead &&
+user.policiesPermissions.canRead &&
+user.policiesPermissions.canWrite
+)
Review Comment:
Do we also need to inject the FlowConfiguration here to verify
`supportsManagedAuthorizer`?
If the user has the url,
http://localhost:4200/#/access-policies/global/read/parameter-contexts for
example, they can get to the page even though the menu options are not
available.
Same is true for the users page as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12599) Add proper restrictions on some lookup controller services
[ https://issues.apache.org/jira/browse/NIFI-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806118#comment-17806118 ] Pierre Villard commented on NIFI-12599: --- A processor or controller service that requires to read a specific configuration file on the filesystem for its proper usage is totally fine. The problem here is really that the configured file could end up as the content of a flow file. If you do see a component for which a malicious user could use its configuration with a file to load the content of that file in the content of a flow file, please let us know. > Add proper restrictions on some lookup controller services > -- > > Key: NIFI-12599 > URL: https://issues.apache.org/jira/browse/NIFI-12599 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Some lookup controller services requires to have the proper restrictions as > they access the local file system for reading some files: > * XMLFileLookupService > * SimpleCsvFileLookupService > * PropertiesFileLookupService > * CSVRecordLookupService -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]
exceptionfactory commented on code in PR #8240:
URL: https://github.com/apache/nifi/pull/8240#discussion_r1450663163
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-kubernetes-bundle/nifi-framework-kubernetes-state-provider/src/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java:
##
@@ -40,26 +41,35 @@
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import org.apache.nifi.components.AbstractConfigurableComponent;
+import org.apache.nifi.components.PropertyDescriptor;
import org.apache.nifi.components.state.Scope;
import org.apache.nifi.components.state.StateMap;
import org.apache.nifi.components.state.StateProvider;
import org.apache.nifi.components.state.StateProviderInitializationContext;
import org.apache.nifi.kubernetes.client.ServiceAccountNamespaceProvider;
import org.apache.nifi.kubernetes.client.StandardKubernetesClientProvider;
import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
/**
* State Provider implementation based on Kubernetes ConfigMaps with Base64
encoded keys to meet Kubernetes constraints
*/
public class KubernetesConfigMapStateProvider extends
AbstractConfigurableComponent implements StateProvider {
+static final PropertyDescriptor RESOURCE_PREFIX = new
PropertyDescriptor.Builder()
+.name("Resource Prefix")
+.description("The resource prefix to add to the beginning of the
kubernetes resource names, followed by a hyphen")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(false)
+.build();
+
private static final int MAX_UPDATE_ATTEMPTS = 5;
private static final Scope[] SUPPORTED_SCOPES = { Scope.CLUSTER };
private static final Charset KEY_CHARACTER_SET = StandardCharsets.UTF_8;
-private static final String CONFIG_MAP_NAME_FORMAT = "nifi-component-%s";
+private static String CONFIG_MAP_NAME_FORMAT;
-private static final Pattern CONFIG_MAP_NAME_PATTERN =
Pattern.compile("^nifi-component-(.+)$");
+private static Pattern CONFIG_MAP_NAME_PATTERN;
Review Comment:
These variables should not be `static` and should instead be changed to
instance variables since they are different per instance of the Provider.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-kubernetes-bundle/nifi-framework-kubernetes-state-provider/src/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java:
##
@@ -40,26 +41,35 @@
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import org.apache.nifi.components.AbstractConfigurableComponent;
+import org.apache.nifi.components.PropertyDescriptor;
import org.apache.nifi.components.state.Scope;
import org.apache.nifi.components.state.StateMap;
import org.apache.nifi.components.state.StateProvider;
import org.apache.nifi.components.state.StateProviderInitializationContext;
import org.apache.nifi.kubernetes.client.ServiceAccountNamespaceProvider;
import org.apache.nifi.kubernetes.client.StandardKubernetesClientProvider;
import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
/**
* State Provider implementation based on Kubernetes ConfigMaps with Base64
encoded keys to meet Kubernetes constraints
*/
public class KubernetesConfigMapStateProvider extends
AbstractConfigurableComponent implements StateProvider {
+static final PropertyDescriptor RESOURCE_PREFIX = new
PropertyDescriptor.Builder()
Review Comment:
Recommend naming this more specifically:
```suggestion
static final PropertyDescriptor CONFIG_MAP_NAME_PREFIX = new
PropertyDescriptor.Builder()
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-kubernetes-bundle/nifi-framework-kubernetes-state-provider/src/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java:
##
@@ -40,26 +41,35 @@
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import org.apache.nifi.components.AbstractConfigurableComponent;
+import org.apache.nifi.components.PropertyDescriptor;
import org.apache.nifi.components.state.Scope;
import org.apache.nifi.components.state.StateMap;
import org.apache.nifi.components.state.StateProvider;
import org.apache.nifi.components.state.StateProviderInitializationContext;
import org.apache.nifi.kubernetes.client.ServiceAccountNamespaceProvider;
import org.apache.nifi.kubernetes.client.StandardKubernetesClientProvider;
import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
/**
* State Provider implementation based on Kubernetes ConfigMaps with Base64
encoded keys to meet Kubernetes constraints
*/
public class KubernetesConfigMapStateProvider extends
AbstractConfigurableComponent implements StateProvider {
+
[PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]
juldrixx opened a new pull request, #8240: URL: https://github.com/apache/nifi/pull/8240 …uster Leader Election and State Management # Summary [NIFI-12590](https://issues.apache.org/jira/browse/NIFI-12590) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12590) Add an option to add a prefix on Kubernetes resources
[
https://issues.apache.org/jira/browse/NIFI-12590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julien G. reassigned NIFI-12590:
Assignee: Julien G.
> Add an option to add a prefix on Kubernetes resources
> -
>
> Key: NIFI-12590
> URL: https://issues.apache.org/jira/browse/NIFI-12590
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 2.0.0
>Reporter: Julien G.
>Assignee: Julien G.
>Priority: Major
>
> In case of using Kubernetes as a *Cluster Leader Election* and *State
> Mangement*, NiFi will create two types of resources: *ConfigMaps* and
> *Leases*.
> 2 *Leases* for the _Cluster Leader Election_ and multiple *ConfigMaps*
> depending the number of components which their state to be stored.
> Their names are normalized:
> - *Leases*: {{cluster-coordinator}} and {{primary-node}}.
> - *ConfigMap*: {{nifi-component-%s}} with {{%s}} the component identifier.
> But currently, if someone wants to deploy more than one cluster in one
> namespace, conflicts will arise. Because the resources will share their
> names. It has been done this way to prevent security concerns where a cluster
> will manipulate resources of another cluster.
> But as discussed on Slack, these concerns can't prevented with 100% certainty.
> So users should be able to configure a prefix to add to these resources to
> prevent conflict and assume the security concerns.
> It can be done by replicating the logic done with ZooKeeper by adding a
> property in {{nifi.properties}} and a new field in the
> {{state_management.xml}} file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12599) Add proper restrictions on some lookup controller services
[ https://issues.apache.org/jira/browse/NIFI-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806061#comment-17806061 ] Daniel Stieglitz edited comment on NIFI-12599 at 1/12/24 3:53 PM: -- What about processors and/or controller services that use ResourceType.FILE in properties? Shouldn't they also need the restrictions? was (Author: JIRAUSER294662): What about processors and/or controller services that use ResourceType.FILE in properties? Shouldn't they also need the restrictions also? > Add proper restrictions on some lookup controller services > -- > > Key: NIFI-12599 > URL: https://issues.apache.org/jira/browse/NIFI-12599 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Some lookup controller services requires to have the proper restrictions as > they access the local file system for reading some files: > * XMLFileLookupService > * SimpleCsvFileLookupService > * PropertiesFileLookupService > * CSVRecordLookupService -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12593 - ValidateCSV - get all constraint violations for an invalid line [nifi]
dan-s1 commented on code in PR #8229:
URL: https://github.com/apache/nifi/pull/8229#discussion_r1450508701
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -619,18 +632,83 @@ public NifiCsvListReader(Reader reader, CsvPreference
preferences) {
super(reader, preferences);
}
-@Override
-public List read(CellProcessor... processors) throws
IOException {
+public List read(boolean getAllViolations, CellProcessor...
processors) throws IOException {
if( processors == null ) {
throw new NullPointerException("Processors should not be
null");
}
if( readRow() ) {
-super.executeProcessors(new
ArrayList(getColumns().size()), processors);
+executeProcessors(new ArrayList(getColumns().size()),
processors, getAllViolations);
return new ArrayList(getColumns());
Review Comment:
```suggestion
executeProcessors(new ArrayList<>(getColumns().size()),
processors, getAllViolations);
return new ArrayList<>(getColumns());
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -619,18 +632,83 @@ public NifiCsvListReader(Reader reader, CsvPreference
preferences) {
super(reader, preferences);
}
-@Override
-public List read(CellProcessor... processors) throws
IOException {
+public List read(boolean getAllViolations, CellProcessor...
processors) throws IOException {
if( processors == null ) {
throw new NullPointerException("Processors should not be
null");
}
if( readRow() ) {
-super.executeProcessors(new
ArrayList(getColumns().size()), processors);
+executeProcessors(new ArrayList(getColumns().size()),
processors, getAllViolations);
Review Comment:
See earlier comment
```suggestion
executeProcessors(new
ArrayList(getColumns().size()), processors, allViolations);
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -619,18 +632,83 @@ public NifiCsvListReader(Reader reader, CsvPreference
preferences) {
super(reader, preferences);
}
-@Override
-public List read(CellProcessor... processors) throws
IOException {
+public List read(boolean getAllViolations, CellProcessor...
processors) throws IOException {
if( processors == null ) {
throw new NullPointerException("Processors should not be
null");
}
if( readRow() ) {
-super.executeProcessors(new
ArrayList(getColumns().size()), processors);
+executeProcessors(new ArrayList(getColumns().size()),
processors, getAllViolations);
return new ArrayList(getColumns());
}
return null; // EOF
}
+protected List executeProcessors(List
processedColumns, CellProcessor[] processors, boolean getAllViolations) {
+this.executeCellProcessors(processedColumns, getColumns(),
processors, getLineNumber(), getRowNumber(), getAllViolations);
+return processedColumns;
Review Comment:
See earlier comment
```suggestion
protected List executeProcessors(List
processedColumns, CellProcessor[] processors, boolean allViolations) {
this.executeCellProcessors(processedColumns, getColumns(),
processors, getLineNumber(), getRowNumber(), allViolations);
return processedColumns;
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -619,18 +632,83 @@ public NifiCsvListReader(Reader reader, CsvPreference
preferences) {
super(reader, preferences);
}
-@Override
-public List read(CellProcessor... processors) throws
IOException {
+public List read(boolean getAllViolations, CellProcessor...
processors) throws IOException {
if( processors == null ) {
throw new NullPointerException("Processors should not be
null");
}
if( readRow() ) {
-super.executeProcessors(new
ArrayList(getColumns().size()), processors);
+executeProcessors(new ArrayList(getColumns().size()),
processors, getAllViolations);
return new ArrayList(getColumns());
}
return null; // EOF
}
+protected List executeProcessors(List
processedColumns, CellProcessor[] processors, boolean getAllViolations) {
+
Re: [PR] Add nifi-standard-services-api-nar to mvn archetype [nifi]
zeevo commented on PR #8239: URL: https://github.com/apache/nifi/pull/8239#issuecomment-1889493801 Thanks @exceptionfactory I'll do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12602) Upgrade follow-redirects to 1.15.4 for Registry
[ https://issues.apache.org/jira/browse/NIFI-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12602. - Resolution: Fixed > Upgrade follow-redirects to 1.15.4 for Registry > --- > > Key: NIFI-12602 > URL: https://issues.apache.org/jira/browse/NIFI-12602 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The [follow-redirects|https://github.com/follow-redirects/follow-redirects] > library is a development dependency of NiFi Registry and should be upgraded > from 1.15.2 to 1.15.4 to incorporate URL handling improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12602) Upgrade follow-redirects to 1.15.4 for Registry
[ https://issues.apache.org/jira/browse/NIFI-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806082#comment-17806082 ] ASF subversion and git services commented on NIFI-12602: Commit 095b394259c4369b78c3fa949dcda6c74ae07904 in nifi's branch refs/heads/support/nifi-1.x from dependabot[bot] [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=095b394259 ] NIFI-12602 Upgraded follow-redirects from 1.15.2 to 1.15.4 This closes #8230 Signed-off-by: David Handermann (cherry picked from commit 9dd832e150886fa03afea3ef05ab0e770fa146fd) > Upgrade follow-redirects to 1.15.4 for Registry > --- > > Key: NIFI-12602 > URL: https://issues.apache.org/jira/browse/NIFI-12602 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The [follow-redirects|https://github.com/follow-redirects/follow-redirects] > library is a development dependency of NiFi Registry and should be upgraded > from 1.15.2 to 1.15.4 to incorporate URL handling improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12602) Upgrade follow-redirects to 1.15.4 for Registry
[ https://issues.apache.org/jira/browse/NIFI-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12602: Component/s: NiFi Registry > Upgrade follow-redirects to 1.15.4 for Registry > --- > > Key: NIFI-12602 > URL: https://issues.apache.org/jira/browse/NIFI-12602 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The [follow-redirects|https://github.com/follow-redirects/follow-redirects] > library is a development dependency of NiFi Registry and should be upgraded > from 1.15.2 to 1.15.4 to incorporate URL handling improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12602) Upgrade follow-redirects to 1.15.4 for Registry
[ https://issues.apache.org/jira/browse/NIFI-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806081#comment-17806081 ] ASF subversion and git services commented on NIFI-12602: Commit 9dd832e150886fa03afea3ef05ab0e770fa146fd in nifi's branch refs/heads/main from dependabot[bot] [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9dd832e150 ] NIFI-12602 Upgraded follow-redirects from 1.15.2 to 1.15.4 This closes #8230 Signed-off-by: David Handermann > Upgrade follow-redirects to 1.15.4 for Registry > --- > > Key: NIFI-12602 > URL: https://issues.apache.org/jira/browse/NIFI-12602 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The [follow-redirects|https://github.com/follow-redirects/follow-redirects] > library is a development dependency of NiFi Registry and should be upgraded > from 1.15.2 to 1.15.4 to incorporate URL handling improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12602 Bump follow-redirects from 1.15.2 to 1.15.4 in /nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main [nifi]
dependabot[bot] commented on PR #8230: URL: https://github.com/apache/nifi/pull/8230#issuecomment-1889438766 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12602) Upgrade follow-redirects to 1.15.4 for Registry
David Handermann created NIFI-12602: --- Summary: Upgrade follow-redirects to 1.15.4 for Registry Key: NIFI-12602 URL: https://issues.apache.org/jira/browse/NIFI-12602 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann Fix For: 1.25.0, 2.0.0 The [follow-redirects|https://github.com/follow-redirects/follow-redirects] library is a development dependency of NiFi Registry and should be upgraded from 1.15.2 to 1.15.4 to incorporate URL handling improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12602 Bump follow-redirects from 1.15.2 to 1.15.4 in /nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main [nifi]
exceptionfactory closed pull request #8230: NIFI-12602 Bump follow-redirects from 1.15.2 to 1.15.4 in /nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main URL: https://github.com/apache/nifi/pull/8230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12592) Update curator-client to 5.6.0
[ https://issues.apache.org/jira/browse/NIFI-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12592: Affects Version/s: (was: 2.0.0-M1) > Update curator-client to 5.6.0 > -- > > Key: NIFI-12592 > URL: https://issues.apache.org/jira/browse/NIFI-12592 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Update curator-client to 5.6.0. Removes > [CVE-2023-44981|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-44981] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12592) Update curator-client to 5.6.0
[ https://issues.apache.org/jira/browse/NIFI-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12592. - Fix Version/s: 1.25.0 2.0.0 Resolution: Fixed > Update curator-client to 5.6.0 > -- > > Key: NIFI-12592 > URL: https://issues.apache.org/jira/browse/NIFI-12592 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Update curator-client to 5.6.0. Removes > [CVE-2023-44981|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-44981] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12592) Update curator-client to 5.6.0
[ https://issues.apache.org/jira/browse/NIFI-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806075#comment-17806075 ] ASF subversion and git services commented on NIFI-12592: Commit e520bbcb699a9bc7b99a2bb02f886b8953236c50 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e520bbcb69 ] NIFI-12592 Upgraded Apache Curator from 5.5.0 to 5.6.0 Signed-off-by: David Handermann (cherry picked from commit 56be04cc73ef3dbdfaeaf7a498c7f7eecbeec9af) > Update curator-client to 5.6.0 > -- > > Key: NIFI-12592 > URL: https://issues.apache.org/jira/browse/NIFI-12592 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M1 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Update curator-client to 5.6.0. Removes > [CVE-2023-44981|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-44981] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12600) Upgrade Apache Maven to 3.9.6
[ https://issues.apache.org/jira/browse/NIFI-12600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12600. - Fix Version/s: 1.25.0 2.0.0 Assignee: Mike R Resolution: Fixed > Upgrade Apache Maven to 3.9.6 > - > > Key: NIFI-12600 > URL: https://issues.apache.org/jira/browse/NIFI-12600 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Upgrade Apache Maven to 3.9.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12600) Upgrade Apache Maven to 3.9.6
[ https://issues.apache.org/jira/browse/NIFI-12600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12600: Affects Version/s: (was: 2.0.0-M1) > Upgrade Apache Maven to 3.9.6 > - > > Key: NIFI-12600 > URL: https://issues.apache.org/jira/browse/NIFI-12600 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Upgrade Apache Maven to 3.9.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12600) Upgrade Apache Maven to 3.9.6
[ https://issues.apache.org/jira/browse/NIFI-12600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806076#comment-17806076 ] ASF subversion and git services commented on NIFI-12600: Commit da3cb28efb16d7fd05e3a802e91469e55c876779 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=da3cb28efb ] NIFI-12600 Upgraded Apache Maven from 3.9.5 to 3.9.6 This closes #8238 Signed-off-by: David Handermann (cherry picked from commit 0cc3f447f2e0a400bd38712a816fd66cd94b6e1b) > Upgrade Apache Maven to 3.9.6 > - > > Key: NIFI-12600 > URL: https://issues.apache.org/jira/browse/NIFI-12600 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M1 >Reporter: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Upgrade Apache Maven to 3.9.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12592) Update curator-client to 5.6.0
[ https://issues.apache.org/jira/browse/NIFI-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806073#comment-17806073 ] ASF subversion and git services commented on NIFI-12592: Commit 56be04cc73ef3dbdfaeaf7a498c7f7eecbeec9af in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=56be04cc73 ] NIFI-12592 Upgraded Apache Curator from 5.5.0 to 5.6.0 This closes #8226 Signed-off-by: David Handermann > Update curator-client to 5.6.0 > -- > > Key: NIFI-12592 > URL: https://issues.apache.org/jira/browse/NIFI-12592 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M1 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Update curator-client to 5.6.0. Removes > [CVE-2023-44981|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-44981] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12600) Upgrade Apache Maven to 3.9.6
[ https://issues.apache.org/jira/browse/NIFI-12600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806074#comment-17806074 ] ASF subversion and git services commented on NIFI-12600: Commit 0cc3f447f2e0a400bd38712a816fd66cd94b6e1b in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0cc3f447f2 ] NIFI-12600 Upgraded Apache Maven from 3.9.5 to 3.9.6 This closes #8238 Signed-off-by: David Handermann > Upgrade Apache Maven to 3.9.6 > - > > Key: NIFI-12600 > URL: https://issues.apache.org/jira/browse/NIFI-12600 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M1 >Reporter: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Upgrade Apache Maven to 3.9.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12592 Update curator-client to 5.6.0 [nifi]
exceptionfactory closed pull request #8226: NIFI-12592 Update curator-client to 5.6.0 URL: https://github.com/apache/nifi/pull/8226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12600 Upgrade Apache Maven to 3.9.6 [nifi]
exceptionfactory closed pull request #8238: NIFI-12600 Upgrade Apache Maven to 3.9.6 URL: https://github.com/apache/nifi/pull/8238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12589: Queue Listing [nifi]
scottyaslan commented on code in PR #8235:
URL: https://github.com/apache/nifi/pull/8235#discussion_r1450545185
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/queue/state/queue-listing/queue-listing.effects.ts:
##
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable } from '@angular/core';
+import { Actions, createEffect, ofType } from '@ngrx/effects';
+import * as QueueListingActions from './queue-listing.actions';
+import { Store } from '@ngrx/store';
+import { CanvasState } from '../../../flow-designer/state';
+import {
+asyncScheduler,
+catchError,
+filter,
+from,
+interval,
+map,
+of,
+switchMap,
+take,
+takeUntil,
+tap,
+withLatestFrom
+} from 'rxjs';
+import { selectConnectionIdFromRoute, selectListingRequestEntity } from
'./queue-listing.selectors';
+import { QueueService } from '../../service/queue.service';
+import { ListingRequest } from './index';
+import { CancelDialog } from
'../../../../ui/common/cancel-dialog/cancel-dialog.component';
+import { MatDialog } from '@angular/material/dialog';
+import { selectAbout } from '../../../../state/about/about.selectors';
+import { FlowFileDialog } from
'../../ui/queue-listing/flowfile-dialog/flowfile-dialog.component';
+import { NiFiCommon } from '../../../../service/nifi-common.service';
+
+@Injectable()
+export class QueueListingEffects {
+constructor(
+private actions$: Actions,
+private store: Store,
+private queueService: QueueService,
+private dialog: MatDialog,
+private nifiCommon: NiFiCommon
+) {}
+
+loadConnectionLabel$ = createEffect(() =>
+this.actions$.pipe(
+ofType(QueueListingActions.loadConnectionLabel),
+map((action) => action.request),
+switchMap((request) =>
+
from(this.queueService.getConnection(request.connectionId)).pipe(
+map((response) => {
+const connection: any = response.component;
+
+let connectionLabel: string = 'Connection';
+if (!this.nifiCommon.isBlank(connection.name)) {
+connectionLabel = connection.name;
+} else if (connection.selectedRelationships) {
+connectionLabel =
connection.selectedRelationships.join(', ');
+}
+
+return QueueListingActions.loadConnectionLabelSuccess({
+response: {
+connectionLabel
+}
+});
+}),
+catchError((error) =>
+of(
+QueueListingActions.loadConnectionLabelSuccess({
+response: {
+connectionLabel: 'Connection'
+}
+})
+)
+)
+)
+)
+)
+);
+
+submitQueueListingRequest$ = createEffect(() =>
+this.actions$.pipe(
+ofType(QueueListingActions.submitQueueListingRequest),
+map((action) => action.request),
+switchMap((request) => {
+const dialogReference = this.dialog.open(CancelDialog, {
+data: {
+title: 'Queue Listing',
+message: 'Waiting for queue listing to complete...'
+},
+disableClose: true,
+panelClass: 'small-dialog'
+});
+
+
dialogReference.componentInstance.cancel.pipe(take(1)).subscribe(() => {
+
this.store.dispatch(QueueListingActions.stopPollingQueueListingRequest());
+});
+
+return
from(this.queueService.submitQueueListingRequest(request)).pipe(
+map((response) =>
+QueueListingActions.submitQueueListingRequestSuccess
Re: [PR] [NIFI-12400] Flow Analysis Rules listing [nifi]
scottyaslan commented on code in PR #8233: URL: https://github.com/apache/nifi/pull/8233#discussion_r1450544727 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/entity/FlowAnalysisRulesEntity.java: ## @@ -16,7 +16,12 @@ */ package org.apache.nifi.web.api.entity; +import io.swagger.annotations.ApiModelProperty; Review Comment: Hmm, I am getting build errors after this change... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12548: Policy Management [nifi]
mcgilman commented on code in PR #8225: URL: https://github.com/apache/nifi/pull/8225#discussion_r1450476215 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/header.component.html: ## @@ -131,7 +131,15 @@ Users - + Review Comment: Good catch. This was an oversight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12599) Add proper restrictions on some lookup controller services
[ https://issues.apache.org/jira/browse/NIFI-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806061#comment-17806061 ] Daniel Stieglitz commented on NIFI-12599: - What about processors and/or controller services that use ResourceType.FILE in properties? Shouldn't they also need the restrictions also? > Add proper restrictions on some lookup controller services > -- > > Key: NIFI-12599 > URL: https://issues.apache.org/jira/browse/NIFI-12599 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Some lookup controller services requires to have the proper restrictions as > they access the local file system for reading some files: > * XMLFileLookupService > * SimpleCsvFileLookupService > * PropertiesFileLookupService > * CSVRecordLookupService -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12548: Policy Management [nifi]
mcgilman commented on code in PR #8225:
URL: https://github.com/apache/nifi/pull/8225#discussion_r1450469195
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/feature/access-policies.component.ts:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, OnDestroy, OnInit } from '@angular/core';
+import { Store } from '@ngrx/store';
+import { NiFiState } from '../../../state';
+import { startCurrentUserPolling, stopCurrentUserPolling } from
'../../../state/current-user/current-user.actions';
+
+@Component({
+selector: 'access-policies',
+templateUrl: './access-policies.component.html',
+styleUrls: ['./access-policies.component.scss']
+})
+export class AccessPolicies implements OnInit, OnDestroy {
+constructor(private store: Store) {}
+
+ngOnInit(): void {
+this.store.dispatch(startCurrentUserPolling());
+}
+
+ngOnDestroy(): void {
+this.store.dispatch(stopCurrentUserPolling());
Review Comment:
Good call. I'm going to add this to the global policy component as
component-based policies aren't a part of the `currentUser` model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12548: Policy Management [nifi]
mcgilman commented on code in PR #8225:
URL: https://github.com/apache/nifi/pull/8225#discussion_r1450463616
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.ts:
##
@@ -0,0 +1,427 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, OnDestroy, OnInit, TemplateRef, ViewChild } from
'@angular/core';
+import { Store } from '@ngrx/store';
+import { selectCurrentUser } from
'../../../../state/current-user/current-user.selectors';
+import {
+createAccessPolicy,
+openAddTenantToPolicyDialog,
+promptDeleteAccessPolicy,
+promptRemoveTenantFromPolicy,
+reloadAccessPolicy,
+resetAccessPolicyState,
+selectComponentAccessPolicy,
+setAccessPolicy
+} from '../../state/access-policy/access-policy.actions';
+import { AccessPolicyState, RemoveTenantFromPolicyRequest } from
'../../state/access-policy';
+import { initialState } from '../../state/access-policy/access-policy.reducer';
+import {
+selectAccessPolicyState,
+selectComponentResourceActionFromRoute
+} from '../../state/access-policy/access-policy.selectors';
+import { filter } from 'rxjs';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
+import { FormBuilder, FormControl, FormGroup, Validators } from
'@angular/forms';
+import { NiFiCommon } from '../../../../service/nifi-common.service';
+import { ComponentType, SelectOption, TextTipInput } from
'../../../../state/shared';
+import { TextTip } from
'../../../../ui/common/tooltips/text-tip/text-tip.component';
+import { AccessPolicyEntity, Action, PolicyStatus, ResourceAction } from
'../../state/shared';
+import { loadFlowConfiguration } from
'../../../../state/flow-configuration/flow-configuration.actions';
+import { selectFlowConfiguration } from
'../../../../state/flow-configuration/flow-configuration.selectors';
+import { loadTenants, resetTenantsState } from
'../../state/tenants/tenants.actions';
+import { loadPolicyComponent, resetPolicyComponentState } from
'../../state/policy-component/policy-component.actions';
+import { selectPolicyComponentState } from
'../../state/policy-component/policy-component.selectors';
+import { PolicyComponentState } from '../../state/policy-component';
+
+@Component({
+selector: 'global-access-policies',
+templateUrl: './component-access-policies.component.html',
+styleUrls: ['./component-access-policies.component.scss']
+})
+export class ComponentAccessPolicies implements OnInit, OnDestroy {
+flowConfiguration$ = this.store.select(selectFlowConfiguration);
+accessPolicyState$ = this.store.select(selectAccessPolicyState);
+policyComponentState$ = this.store.select(selectPolicyComponentState);
+currentUser$ = this.store.select(selectCurrentUser);
+
+protected readonly TextTip = TextTip;
+protected readonly Action = Action;
+protected readonly PolicyStatus = PolicyStatus;
+protected readonly ComponentType = ComponentType;
+
+policyForm: FormGroup;
+policyActionOptions: SelectOption[] = [
+{
+text: 'view the component',
+value: 'read-component',
+description: 'Allows users to view component configuration details'
+},
+{
+text: 'modify the component',
+value: 'write-component',
+description: 'Allows users to modify component configuration
details'
+},
+{
+text: 'operate the component',
+value: 'write-operation',
+description:
+'Allows users to operate components by changing component run
status (start/stop/enable/disable), remote port transmission status, or
terminating processor threads'
+},
+{
+text: 'view provenance',
+value: 'read-provenance-data',
+description: 'Allows users to view provenance events generated by
this component'
+},
+{
+text: 'view the data',
+value: 'read-data',
+description:
+'Allows users to view metadata and co
Re: [PR] NIFI-12594: ListS3 - observe min/max object age when entity state tracking is used [nifi]
turcsanyip commented on code in PR #8231:
URL: https://github.com/apache/nifi/pull/8231#discussion_r1450405484
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##
@@ -499,23 +500,19 @@ private void listByTrackingTimestamps(ProcessContext
context, ProcessSession ses
writer.beginListing();
do {
-VersionListing versionListing = bucketLister.listVersions();
+final VersionListing versionListing =
bucketLister.listVersions();
for (S3VersionSummary versionSummary :
versionListing.getVersionSummaries()) {
-long lastModified =
versionSummary.getLastModified().getTime();
-if (lastModified < currentTimestamp
-|| lastModified == currentTimestamp &&
currentKeys.contains(versionSummary.getKey())
-|| (maxAgeMilliseconds != null && (lastModified <
(listingTimestamp - maxAgeMilliseconds)))
-|| lastModified > (listingTimestamp -
minAgeMilliseconds)) {
+final long lastModified =
versionSummary.getLastModified().getTime();
+if (lastModified == currentTimestamp &&
currentKeys.contains(versionSummary.getKey())
+|| !includeObjectInListing(versionSummary,
listingTimestamp)) {
Review Comment:
`lastModified < currentTimestamp` check is still needed and cannot be
removed. _currentTimestamp_ here means the "latest listed timestamp in the
previous round" and it is used to filter out the already listed items.
```suggestion
if (lastModified < currentTimestamp
|| lastModified == currentTimestamp &&
currentKeys.contains(versionSummary.getKey())
|| !includeObjectInListing(versionSummary,
listingTimestamp)) {
```
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##
@@ -321,6 +322,8 @@ public class ListS3 extends AbstractS3Processor implements
VerifiableProcessor {
private volatile boolean justElectedPrimaryNode = false;
private volatile boolean resetEntityTrackingState = false;
private volatile
ListedEntityTracker>
listedEntityTracker;
+private Long minObjectAgeMilliseconds;
+private Long maxObjectAgeMilliseconds;
Review Comment:
Please add `volatile` for the fields (like the others above). It is used
because the variable is written and then read by different threads (written in
`onScheduled`, read in `onTrigger`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12594: ListS3 - observe min/max object age when entity state tracking is used [nifi]
p-kimberley commented on PR #8231: URL: https://github.com/apache/nifi/pull/8231#issuecomment-1888702309 > @p-kimberley Thanks for reporting and fixing this bug! The implementation works properly but I found some improvement points. Could you please check them? Thanks for the suggestions. Let me know if you want me to squash these commits into the previous. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
