[jira] [Updated] (NIFI-13022) Disabled button state indistinguishable from enabled state
[ https://issues.apache.org/jira/browse/NIFI-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13022: --- Status: Patch Available (was: In Progress) > Disabled button state indistinguishable from enabled state > -- > > Key: NIFI-13022 > URL: https://issues.apache.org/jira/browse/NIFI-13022 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > It seems that due to some unfortunate "!important" styles, the mat-primary > style is winning over the disabled style for buttons. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13022] rename semantic color classes to avoid conflict with angular material class names [nifi]
scottyaslan opened a new pull request, #8628: URL: https://github.com/apache/nifi/pull/8628 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13021) Status History dialog changes size when switching selected metric
[ https://issues.apache.org/jira/browse/NIFI-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13021: --- Status: Patch Available (was: In Progress) > Status History dialog changes size when switching selected metric > - > > Key: NIFI-13021 > URL: https://issues.apache.org/jira/browse/NIFI-13021 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Kapture 2024-04-10 at 10.46.54.gif > > > This appears to be due to the content of the left column getting wider. > Probably needs a max-width set on it or something analogous. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13024) Support "Enter" to create selected extension type
[ https://issues.apache.org/jira/browse/NIFI-13024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13024: --- Status: Patch Available (was: In Progress) > Support "Enter" to create selected extension type > - > > Key: NIFI-13024 > URL: https://issues.apache.org/jira/browse/NIFI-13024 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > > When typing in to the filter input, the first element in the list should be > selected. If you hit enter it should create that component type. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13000) Prevent text selection
[ https://issues.apache.org/jira/browse/NIFI-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-13000: -- Assignee: Rob Fellows > Prevent text selection > -- > > Key: NIFI-13000 > URL: https://issues.apache.org/jira/browse/NIFI-13000 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Rob Fellows >Priority: Major > > The UI should prevent text selection where appropriate. One notable place is > on the entire canvas and the extension creation component but we should > consider other areas of the UI as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] General improvements [nifi]
rfellows opened a new pull request, #8627: URL: https://github.com/apache/nifi/pull/8627 * [NIFI-13000](https://issues.apache.org/jira/browse/NIFI-13000) - Improvement - Prevent text selection in header, flow status, canvas, extension creation dialog table. * [NIFI-13024](https://issues.apache.org/jira/browse/NIFI-13024) - Improvement - Support Enter to create selected extension type * [NIFI-13023](https://issues.apache.org/jira/browse/NIFI-13023) - Fix - Right click on canvas while search results open shows browser right-click menu * [NIFI-13018](https://issues.apache.org/jira/browse/NIFI-13018) - Fix - Refreshing Node Status History when open for the cluster, makes the incorrect backend call * [NIFI-13021](https://issues.apache.org/jira/browse/NIFI-13021) - Fix - Status History dialog changes size when switching selected metric -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13018) BUG - Refreshing Node Status History when open for the cluster, makes the incorrect backend call
[
https://issues.apache.org/jira/browse/NIFI-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rob Fellows updated NIFI-13018:
---
Status: Patch Available (was: In Progress)
> BUG - Refreshing Node Status History when open for the cluster, makes the
> incorrect backend call
>
>
> Key: NIFI-13018
> URL: https://issues.apache.org/jira/browse/NIFI-13018
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>
> If you open the Node Status History dialog from the global menu and then hit
> the refresh icon in the corner, the API call fails as it is trying to load:
> {code:java}
> http://localhost:4200/nifi-api/flow/processors/undefined/status/history
> {code}
> and gets a 404. It should be calling:
> {code:java}
> http://localhost:4200/nifi-api/controller/status/history
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13000) Prevent text selection
[ https://issues.apache.org/jira/browse/NIFI-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13000: --- Status: Patch Available (was: In Progress) > Prevent text selection > -- > > Key: NIFI-13000 > URL: https://issues.apache.org/jira/browse/NIFI-13000 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Rob Fellows >Priority: Major > > The UI should prevent text selection where appropriate. One notable place is > on the entire canvas and the extension creation component but we should > consider other areas of the UI as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13023) Right click on canvas while search results open shows browser right-click menu
[ https://issues.apache.org/jira/browse/NIFI-13023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13023: --- Status: Patch Available (was: In Progress) > Right click on canvas while search results open shows browser right-click menu > -- > > Key: NIFI-13023 > URL: https://issues.apache.org/jira/browse/NIFI-13023 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > > * If you have the search results panel open and then you go to interact with > components on the flow such as right clicking and so on - you get a generic > response instead of actually talking to the component. If you close the > search panel by clicking out behavior returns as normal -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12986 Tidy up JavaDoc of ProcessSession [nifi]
EndzeitBegins commented on PR #8620: URL: https://github.com/apache/nifi/pull/8620#issuecomment-2048209586 Thank you for taking a look @exceptionfactory. I know this is a large change in terms of lines changes, so I really appreciate that. While going through the interface declaration, I noticed that those functions are just a shorthand overload of their respective functions with more parameters. The behaviour of calling `commitAsync()` is defined equal to calling `commitAsync(Runnable onSuccess, Consumer onFailure)` with both parameters set to `null`, as both parameters are optional. In fact, the same applies to the "sibling" method `commitAsync(Runnable onSuccess)` which has an existing default implementation of `commitAsync(onSuccess, null);`. I figured adding a default for `commitAsync()` would further align both function overloads. A similar reasoning can be applied to `merge(Collection sources, FlowFile destination)` who's behavior is defined akin to that of `merge(Collection sources, FlowFile destination, byte[] header, byte[] footer, byte[] demarcator)` when passing `null` for all of `header`, `footer`, and `demarcator`. However, this time there is no other sibling overload with a default. As adding a default implementation is not a breaking change nor alters the behavior for any existing implementation I figured that's a sensible addition. However, you're right that it's out of scope of the original issue description. With this background, what are your thoughts on this? Should I revert the addition of those default implementations or do you follow the reasoning above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13020) Flow update fails when legacy flow is received via C2
[ https://issues.apache.org/jira/browse/NIFI-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835847#comment-17835847 ] ASF subversion and git services commented on NIFI-13020: Commit bc589e273d4e29dad8837a64895f60fb4a56173b in nifi's branch refs/heads/main from Ferenc Kis [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=bc589e273d ] NIFI-13020 Fix legacy flow C2 update issue Signed-off-by: Csaba Bejan This closes #8624 > Flow update fails when legacy flow is received via C2 > - > > Key: NIFI-13020 > URL: https://issues.apache.org/jira/browse/NIFI-13020 > Project: Apache NiFi > Issue Type: Bug > Components: MiNiFi >Affects Versions: 2.0.0-M2 >Reporter: Ferenc Kis >Assignee: Ferenc Kis >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > > When legacy flow is received via C2, flow update will fail. > Legacy flows do not have instanceId, so those will need to be generated and > mapped. > Additionally there are some processor properties which are missing those need > to be populated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13020 Fix legacy flow C2 update issue [nifi]
bejancsaba closed pull request #8624: NIFI-13020 Fix legacy flow C2 update issue URL: https://github.com/apache/nifi/pull/8624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12614) Create record reader service for Protobuf messages
[ https://issues.apache.org/jira/browse/NIFI-12614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy resolved NIFI-12614. Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed > Create record reader service for Protobuf messages > --- > > Key: NIFI-12614 > URL: https://issues.apache.org/jira/browse/NIFI-12614 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Create a record reader implementation for Protobuf which is capable to read > encoded data and create NiFi records from it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12614: Create record reader service for Protobuf messages (1.x version) [nifi]
tpalfy closed pull request #8626: NIFI-12614: Create record reader service for Protobuf messages (1.x version) URL: https://github.com/apache/nifi/pull/8626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12614: Create record reader service for Protobuf messages (1.x version) [nifi]
tpalfy commented on PR #8626: URL: https://github.com/apache/nifi/pull/8626#issuecomment-2048139272 LGTM Thank you for your work @mark-bathori ! Merged into support/nifi-1.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12614) Create record reader service for Protobuf messages
[ https://issues.apache.org/jira/browse/NIFI-12614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835838#comment-17835838 ] ASF subversion and git services commented on NIFI-12614: Commit ddcdac674bd70e2f9fc9d604de3aefe0465a4219 in nifi's branch refs/heads/support/nifi-1.x from Mark Bathori [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ddcdac674b ] NIFI-12614: Create record reader service for Protobuf messages (1.x version) This closes #8626. Signed-off-by: Tamas Palfy > Create record reader service for Protobuf messages > --- > > Key: NIFI-12614 > URL: https://issues.apache.org/jira/browse/NIFI-12614 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > Create a record reader implementation for Protobuf which is capable to read > encoded data and create NiFi records from it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13024) Support "Enter" to create selected extension type
Rob Fellows created NIFI-13024: -- Summary: Support "Enter" to create selected extension type Key: NIFI-13024 URL: https://issues.apache.org/jira/browse/NIFI-13024 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows When typing in to the filter input, the first element in the list should be selected. If you hit enter it should create that component type. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12614: Create record reader service for Protobuf messages [nifi]
tpalfy commented on PR #8250: URL: https://github.com/apache/nifi/pull/8250#issuecomment-2048073797 LGTM Thank your for work @mark-bathori and for the review @dan-s1 ! Merged into main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12614) Create record reader service for Protobuf messages
[ https://issues.apache.org/jira/browse/NIFI-12614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835826#comment-17835826 ] ASF subversion and git services commented on NIFI-12614: Commit 8b39a65d5d645cb1a66e0ac42442f9e28d14b74e in nifi's branch refs/heads/main from Mark Bathori [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8b39a65d5d ] NIFI-12614: Create record reader service for Protobuf messages This closes #8250. Signed-off-by: Tamas Palfy > Create record reader service for Protobuf messages > --- > > Key: NIFI-12614 > URL: https://issues.apache.org/jira/browse/NIFI-12614 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > Create a record reader implementation for Protobuf which is capable to read > encoded data and create NiFi records from it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12614: Create record reader service for Protobuf messages [nifi]
asfgit closed pull request #8250: NIFI-12614: Create record reader service for Protobuf messages URL: https://github.com/apache/nifi/pull/8250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool [nifi]
turcsanyip commented on code in PR #8619:
URL: https://github.com/apache/nifi/pull/8619#discussion_r1559748008
##
nifi-nar-bundles/nifi-standard-services/nifi-hadoop-dbcp-service-bundle/nifi-hadoop-dbcp-service/src/main/java/org/apache/nifi/dbcp/HadoopDBCPConnectionPool.java:
##
@@ -64,15 +48,44 @@
import org.apache.nifi.security.krb.KerberosKeytabUser;
import org.apache.nifi.security.krb.KerberosLoginException;
import org.apache.nifi.security.krb.KerberosPasswordUser;
-import org.apache.nifi.security.krb.KerberosUser;
+
+import javax.security.auth.login.LoginException;
+import java.io.File;
+import java.io.IOException;
+import java.lang.reflect.UndeclaredThrowableException;
+import java.security.PrivilegedExceptionAction;
+import java.sql.Connection;
+import java.sql.Driver;
+import java.sql.DriverManager;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+import static org.apache.nifi.dbcp.utils.DBCPProperties.DATABASE_URL;
Review Comment:
`DBCPProperties.KERBEROS_USER_SERVICE` should be used too instead of
defining the property in the class.
##
nifi-nar-bundles/nifi-standard-services/nifi-hadoop-dbcp-service-bundle/nifi-hadoop-dbcp-service/src/main/java/org/apache/nifi/dbcp/HadoopDBCPConnectionPool.java:
##
@@ -86,37 +99,13 @@
)
}
)
-public class HadoopDBCPConnectionPool extends AbstractControllerService
implements DBCPService {
+public class HadoopDBCPConnectionPool extends AbstractDBCPConnectionPool {
private static final String ALLOW_EXPLICIT_KEYTAB =
"NIFI_ALLOW_EXPLICIT_KEYTAB";
private static final String HADOOP_CONFIGURATION_CLASS =
"org.apache.hadoop.conf.Configuration";
private static final String HADOOP_UGI_CLASS =
"org.apache.hadoop.security.UserGroupInformation";
-private static final String DEFAULT_MIN_IDLE = "0";
-private static final String DEFAULT_MAX_IDLE = "8";
-private static final String DEFAULT_MAX_CONN_LIFETIME = "-1";
-private static final String DEFAULT_EVICTION_RUN_PERIOD =
String.valueOf(-1L);
-private static final String DEFAULT_MIN_EVICTABLE_IDLE_TIME = "30 mins";
-private static final String DEFAULT_SOFT_MIN_EVICTABLE_IDLE_TIME =
String.valueOf(-1L);
-
-public static final PropertyDescriptor DATABASE_URL = new
PropertyDescriptor.Builder()
-.name("Database Connection URL")
-.description("A database connection URL used to connect to a
database. May contain database system name, host, port, database name and some
parameters."
-+ " The exact syntax of a database connection URL is
specified by your DBMS.")
-.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
-.required(true)
-.expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
-.build();
-
-public static final PropertyDescriptor DB_DRIVERNAME = new
PropertyDescriptor.Builder()
-.name("Database Driver Class Name")
-.description("Database driver class name")
-.required(true)
-.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
-.expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
-.build();
-
public static final PropertyDescriptor DB_DRIVER_LOCATION = new
PropertyDescriptor.Builder()
Review Comment:
It could be simplified via reusing and customizing the property descriptor
from `DBCPProperties`:
```
public static final PropertyDescriptor DB_DRIVER_LOCATION = new
PropertyDescriptor.Builder()
.fromPropertyDescriptor(DBCPProperties.DB_DRIVER_LOCATION)
.description("Comma-separated list of files/folders and/or URLs
containing the driver JAR and its dependencies (if any). " +
"For example '/var/tmp/phoenix-client.jar'. NOTE: It is
required that the resources specified by this property provide " +
"the classes from hadoop-common, such as Configuration
and UserGroupInformation.")
.required(true)
.build();
```
Also, the description says that some jars are required and the property is
also `required(true)`. So removing "_(if any)_" would make sense.
##
nifi-nar-bundles/nifi-standard-services/nifi-hadoop-dbcp-service-bundle/nifi-hadoop-dbcp-service/src/main/java/org/apache/nifi/dbcp/HadoopDBCPConnectionPool.java:
##
@@ -498,10 +365,10 @@ public void onEnabled(final ConfigurationContext context)
throws IOException {
if (resolvedKeytab != null) {
kerberosUser = new KerberosKeytabUser(resolvedPrincipal,
resolvedKeytab);
-getLogger().info("Security Enabled, logging in as principal {}
with keytab {}", new Object[] {resolvedPrincipal,
Re: [PR] MINIFICPP-2326 Link lua statically [nifi-minifi-cpp]
lordgamez commented on PR #1756: URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#issuecomment-2047939844 I think some other files need to be updated as well: - Remove Lua from build time dependencies in README.md - Remove lua package installation from bootstrap shell files if lua extension is enabled (aptitude.sh, arch.sh, centos.sh, darwin.sh, debian.sh, fedora.sh, rheldistro.sh, suse.sh) - Remove lua package installation from python bootstrap if lua extension is enabled (package_manager.py) - Remove lua development packages from dockerfiles -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13023) Right click on canvas while search results open shows browser right-click menu
Rob Fellows created NIFI-13023: -- Summary: Right click on canvas while search results open shows browser right-click menu Key: NIFI-13023 URL: https://issues.apache.org/jira/browse/NIFI-13023 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows * If you have the search results panel open and then you go to interact with components on the flow such as right clicking and so on - you get a generic response instead of actually talking to the component. If you close the search panel by clicking out behavior returns as normal -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2309 Add JSON flow config examples [nifi-minifi-cpp]
lordgamez commented on code in PR #1740:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1740#discussion_r1559688807
##
examples/getfile_putfile_config.json:
##
@@ -0,0 +1,50 @@
+{
+"rootGroup": {
+"name": "MiNiFi Flow",
+"processors": [
+{
+"name": "GetFile",
+"identifier": "b01793b6-5275-4ee3-9fc0-d9e39ce3162f",
+"type": "org.apache.nifi.processors.standard.GetFile",
+"schedulingStrategy": "TIMER_DRIVEN",
+"schedulingPeriod": "2 sec",
+"properties": {
+"Input Directory": "/tmp/input"
Review Comment:
Good catch, fixed in 20feddbeb43868d968be1a932939a2539c653eb8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
fgerlits commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1559650942
##
extensions/standard-processors/processors/ListenTCP.cpp:
##
@@ -28,7 +28,13 @@ void ListenTCP::initialize() {
}
void ListenTCP::onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory&) {
- startTcpServer(context, SSLContextService, ClientAuth);
+ auto delimiter_str = context.getProperty(MessageDelimiter).value_or("\n");
+ if (delimiter_str.empty()) {
+logger_->log_warn("{} cannot be an empty string", MessageDelimiter.name);
+delimiter_str = "\n";
+ }
Review Comment:
This is OK, but it means that the only way to specify `\n` as the delimiter
is to not set the property, or set it to empty. Setting `Message Delimiter` to
`\n` explicitly (either in the lua config or in the C2 server) will not work,
because minifi will receive two separate characters, `\` and `n`.
If we want to support explicit `\n` (or `\t` etc) as the value of the
Message Delimiter property, we need to use the
`utils::string::parseCharacter()` function, as it is done in GetTCP and
TailFile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-2327 Fix Loki protobuf code generation on Windows using msbuild [nifi-minifi-cpp]
lordgamez opened a new pull request, #1757: URL: https://github.com/apache/nifi-minifi-cpp/pull/1757 https://issues.apache.org/jira/browse/MINIFICPP-2327 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2327) Loki build fails with msbuild on Windows
Gábor Gyimesi created MINIFICPP-2327:
Summary: Loki build fails with msbuild on Windows
Key: MINIFICPP-2327
URL: https://issues.apache.org/jira/browse/MINIFICPP-2327
Project: Apache NiFi MiNiFi C++
Issue Type: Bug
Reporter: Gábor Gyimesi
Assignee: Gábor Gyimesi
Loki build fails with the following message on Windows when using msbuild
generator:
{code:java}
2024-04-09T16:43:23.1251957Z Generating
../../grafana-loki-protobuf-generated/grafana-loki-push.grpc.pb.cc,
../../grafana-loki-protobuf-generated/grafana-loki-push.grpc.pb.h,
../../grafana-loki-protobuf-generated/grafana-loki-push.pb.h,
../../grafana-loki-protobuf-generated/grafana-loki-push.pb.cc
2024-04-09T16:43:23.1255534Z
'..\..\_deps\grpc-build\third_party\protobuf\protoc.exe' is not recognized as
an internal or external command,
2024-04-09T16:43:23.1256990Z operable program or batch file. {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-13018) BUG - Refreshing Node Status History when open for the cluster, makes the incorrect backend call
[
https://issues.apache.org/jira/browse/NIFI-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rob Fellows reassigned NIFI-13018:
--
Assignee: Rob Fellows
> BUG - Refreshing Node Status History when open for the cluster, makes the
> incorrect backend call
>
>
> Key: NIFI-13018
> URL: https://issues.apache.org/jira/browse/NIFI-13018
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>
> If you open the Node Status History dialog from the global menu and then hit
> the refresh icon in the corner, the API call fails as it is trying to load:
> {code:java}
> http://localhost:4200/nifi-api/flow/processors/undefined/status/history
> {code}
> and gets a 404. It should be calling:
> {code:java}
> http://localhost:4200/nifi-api/controller/status/history
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool [nifi]
turcsanyip commented on code in PR #8619:
URL: https://github.com/apache/nifi/pull/8619#discussion_r1559652391
##
nifi-nar-bundles/nifi-standard-services/nifi-hadoop-dbcp-service-bundle/nifi-hadoop-dbcp-service/src/main/java/org/apache/nifi/dbcp/HadoopDBCPConnectionPool.java:
##
@@ -582,6 +409,41 @@ public void shutdown() throws SQLException {
}
}
+@Override
+protected Driver getDriver(String driverName, String url) {
+return null;
+}
+
+@Override
+protected DataSourceConfiguration
getDataSourceConfiguration(ConfigurationContext context) {
+final String url =
context.getProperty(DATABASE_URL).evaluateAttributeExpressions().getValue();
+final String driverName =
context.getProperty(DB_DRIVERNAME).evaluateAttributeExpressions().getValue();
+final String user =
context.getProperty(DB_USER).evaluateAttributeExpressions().getValue();
+final String password =
context.getProperty(DB_PASSWORD).evaluateAttributeExpressions().getValue();
+final Integer maxTotal =
context.getProperty(MAX_TOTAL_CONNECTIONS).evaluateAttributeExpressions().asInteger();
+final String validationQuery =
context.getProperty(VALIDATION_QUERY).evaluateAttributeExpressions().getValue();
+final Long maxWaitMillis =
extractMillisWithInfinite(context.getProperty(MAX_WAIT_TIME).evaluateAttributeExpressions());
+final Integer minIdle =
context.getProperty(MIN_IDLE).evaluateAttributeExpressions().asInteger();
+final Integer maxIdle =
context.getProperty(MAX_IDLE).evaluateAttributeExpressions().asInteger();
+final Long maxConnLifetimeMillis =
extractMillisWithInfinite(context.getProperty(MAX_CONN_LIFETIME).evaluateAttributeExpressions());
+final Long timeBetweenEvictionRunsMillis =
extractMillisWithInfinite(context.getProperty(EVICTION_RUN_PERIOD).evaluateAttributeExpressions());
+final Long minEvictableIdleTimeMillis =
extractMillisWithInfinite(context.getProperty(MIN_EVICTABLE_IDLE_TIME).evaluateAttributeExpressions());
+final Long softMinEvictableIdleTimeMillis =
extractMillisWithInfinite(context.getProperty(SOFT_MIN_EVICTABLE_IDLE_TIME).evaluateAttributeExpressions());
+
+return new DataSourceConfiguration.Builder(url, driverName, user,
password)
+.validationQuery(validationQuery)
+.driverClassLoader(this.getClass().getClassLoader())
Review Comment:
I see it comes from the old implementation but instead of setting the
`ClassLoader`, the `Driver` could be initialized in this class (similar to
[DBCPConnectionPool.getDriver()](https://github.com/apache/nifi/blob/90d0f6317a94d1730f779b719398c6a384fb9033/nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java#L288-L312)).
In this case, `AbstractDBCPConnectionPool` and `DataSourceConfiguration` do
not need to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-13021) Status History dialog changes size when switching selected metric
[ https://issues.apache.org/jira/browse/NIFI-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-13021: -- Assignee: Rob Fellows > Status History dialog changes size when switching selected metric > - > > Key: NIFI-13021 > URL: https://issues.apache.org/jira/browse/NIFI-13021 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Kapture 2024-04-10 at 10.46.54.gif > > > This appears to be due to the content of the left column getting wider. > Probably needs a max-width set on it or something analogous. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13022) Disabled button state indistinguishable from enabled state
[ https://issues.apache.org/jira/browse/NIFI-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-13022: -- Assignee: Scott Aslan > Disabled button state indistinguishable from enabled state > -- > > Key: NIFI-13022 > URL: https://issues.apache.org/jira/browse/NIFI-13022 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > > It seems that due to some unfortunate "!important" styles, the mat-primary > style is winning over the disabled style for buttons. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2309 Add JSON flow config examples [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1740:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1740#discussion_r1559636533
##
examples/getfile_putfile_config.json:
##
@@ -0,0 +1,50 @@
+{
+"rootGroup": {
+"name": "MiNiFi Flow",
+"processors": [
+{
+"name": "GetFile",
+"identifier": "b01793b6-5275-4ee3-9fc0-d9e39ce3162f",
+"type": "org.apache.nifi.processors.standard.GetFile",
+"schedulingStrategy": "TIMER_DRIVEN",
+"schedulingPeriod": "2 sec",
+"properties": {
+"Input Directory": "/tmp/input"
Review Comment:
this seems to be different from its yaml counterpart, multiple properties
seem to be missing for both processors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
lordgamez commented on PR #1753: URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#issuecomment-2047818986 I think the Jira ticket for this issue is duplicate of this: https://issues.apache.org/jira/browse/MINIFICPP-2310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12995) Remaining PG Versioning Actions
[ https://issues.apache.org/jira/browse/NIFI-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835782#comment-17835782 ] ASF subversion and git services commented on NIFI-12995: Commit 90d0f6317a94d1730f779b719398c6a384fb9033 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=90d0f6317a ] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes (#8607) * [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes * review feedback > Remaining PG Versioning Actions > --- > > Key: NIFI-12995 > URL: https://issues.apache.org/jira/browse/NIFI-12995 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Change Flow Version > Show local changes > Revert local changes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12995) Remaining PG Versioning Actions
[ https://issues.apache.org/jira/browse/NIFI-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12995: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Remaining PG Versioning Actions > --- > > Key: NIFI-12995 > URL: https://issues.apache.org/jira/browse/NIFI-12995 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Change Flow Version > Show local changes > Revert local changes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2326 Link lua statically [nifi-minifi-cpp]
fgerlits opened a new pull request, #1756: URL: https://github.com/apache/nifi-minifi-cpp/pull/1756 Link liblua statically into the lua script extension instead of using the lua library installed on the system. https://issues.apache.org/jira/browse/MINIFICPP-2326 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
scottyaslan merged PR #8607: URL: https://github.com/apache/nifi/pull/8607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13022) Disabled button state indistinguishable from enabled state
Rob Fellows created NIFI-13022: -- Summary: Disabled button state indistinguishable from enabled state Key: NIFI-13022 URL: https://issues.apache.org/jira/browse/NIFI-13022 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows It seems that due to some unfortunate "!important" styles, the mat-primary style is winning over the disabled style for buttons. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13021) Status History dialog changes size when switching selected metric
Rob Fellows created NIFI-13021: -- Summary: Status History dialog changes size when switching selected metric Key: NIFI-13021 URL: https://issues.apache.org/jira/browse/NIFI-13021 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Attachments: Kapture 2024-04-10 at 10.46.54.gif This appears to be due to the content of the left column getting wider. Probably needs a max-width set on it or something analogous. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2326) Link lualib statically
Ferenc Gerlits created MINIFICPP-2326: - Summary: Link lualib statically Key: MINIFICPP-2326 URL: https://issues.apache.org/jira/browse/MINIFICPP-2326 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Ferenc Gerlits Assignee: Ferenc Gerlits Installing the liblua library on Windows and using it during the build is a pain. Instead of this, we should bundle liblua and link it statically into the lua script extension DLL. This will make thing simpler on Linux, as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559539605
##
extensions/python/PythonDependencyInstaller.cpp:
##
@@ -0,0 +1,166 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "PythonDependencyInstaller.h"
+
+#include "PythonScriptException.h"
+#include "PythonInterpreter.h"
+#include "PyException.h"
+#include "types/Types.h"
+
+namespace org::apache::nifi::minifi::extensions::python {
+
+namespace {
+
+std::string getPythonBinary(const std::shared_ptr ) {
+#if WIN32
+ std::string python_binary_ = "python";
+#else
+ std::string python_binary_ = "python3";
+#endif
+ if (auto binary =
configuration->get(minifi::Configuration::nifi_python_env_setup_binary)) {
+python_binary_ = *binary;
+ }
+ return python_binary_;
+}
+
+// On Windows when calling a system command using std::system, the whole
command needs to be encapsulated in additional quotes,
+// due to the std::system passing the command to 'cmd.exe /C' which needs the
additional quotes to handle the command as a single argument
+std::string encapsulateCommandInQuotesIfNeeded(const std::string& command) {
+#if WIN32
+return "\"" + command + "\"";
+#else
+return command;
+#endif
+}
+
+} // namespace
+
+PythonDependencyInstaller::PythonDependencyInstaller(const
std::shared_ptr ) {
+ python_binary_ = getPythonBinary(configuration);
+ std::string automatic_install_str;
+ install_python_packages_automatically_ =
+
configuration->get(Configuration::nifi_python_install_packages_automatically,
automatic_install_str) &&
utils::string::toBool(automatic_install_str).value_or(false);
+ if (auto path =
configuration->get(minifi::Configuration::nifi_python_virtualenv_directory)) {
+virtualenv_path_ = *path;
+logger_->log_debug("Python virtualenv path was specified at: {}",
virtualenv_path_.string());
+ } else {
+logger_->log_debug("No valid python virtualenv path was specified");
+ }
+ if (auto python_processor_dir =
configuration->get(minifi::Configuration::nifi_python_processor_dir)) {
+python_processor_dir_ = *python_processor_dir;
+logger_->log_debug("Python processor dir was specified at: {}",
python_processor_dir_.string());
+ } else {
+logger_->log_debug("No valid python processor dir was not specified in
properties");
+ }
+ createVirtualEnvIfSpecified();
+ addVirtualenvToPath();
+}
+
+std::vector
PythonDependencyInstaller::getRequirementsFilePaths() const {
+ if (!std::filesystem::exists(python_processor_dir_)) {
+return {};
+ }
+ std::vector paths;
+ for (const auto& entry :
std::filesystem::recursive_directory_iterator(std::filesystem::path{python_processor_dir_}))
{
+if (std::filesystem::is_regular_file(entry.path()) &&
entry.path().filename() == "requirements.txt") {
+ paths.push_back(entry.path());
+}
+ }
+ return paths;
+}
+
+void PythonDependencyInstaller::createVirtualEnvIfSpecified() const {
+ if (virtualenv_path_.empty()) {
Review Comment:
Sounds good, added warning in 33e8770038e823678763c9bef60cc656c07ba16b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559538680
##
extensions/python/PythonDependencyInstaller.cpp:
##
@@ -0,0 +1,166 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "PythonDependencyInstaller.h"
+
+#include "PythonScriptException.h"
+#include "PythonInterpreter.h"
+#include "PyException.h"
+#include "types/Types.h"
+
+namespace org::apache::nifi::minifi::extensions::python {
+
+namespace {
+
+std::string getPythonBinary(const std::shared_ptr ) {
+#if WIN32
+ std::string python_binary_ = "python";
+#else
+ std::string python_binary_ = "python3";
+#endif
+ if (auto binary =
configuration->get(minifi::Configuration::nifi_python_env_setup_binary)) {
+python_binary_ = *binary;
+ }
+ return python_binary_;
Review Comment:
Good catch, updated in 33e8770038e823678763c9bef60cc656c07ba16b
##
extensions/python/PythonDependencyInstaller.cpp:
##
@@ -0,0 +1,166 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "PythonDependencyInstaller.h"
+
+#include "PythonScriptException.h"
+#include "PythonInterpreter.h"
+#include "PyException.h"
+#include "types/Types.h"
+
+namespace org::apache::nifi::minifi::extensions::python {
+
+namespace {
+
+std::string getPythonBinary(const std::shared_ptr ) {
+#if WIN32
+ std::string python_binary_ = "python";
+#else
+ std::string python_binary_ = "python3";
+#endif
+ if (auto binary =
configuration->get(minifi::Configuration::nifi_python_env_setup_binary)) {
+python_binary_ = *binary;
+ }
+ return python_binary_;
+}
+
+// On Windows when calling a system command using std::system, the whole
command needs to be encapsulated in additional quotes,
+// due to the std::system passing the command to 'cmd.exe /C' which needs the
additional quotes to handle the command as a single argument
+std::string encapsulateCommandInQuotesIfNeeded(const std::string& command) {
+#if WIN32
+return "\"" + command + "\"";
+#else
+return command;
+#endif
+}
+
+} // namespace
+
+PythonDependencyInstaller::PythonDependencyInstaller(const
std::shared_ptr ) {
+ python_binary_ = getPythonBinary(configuration);
+ std::string automatic_install_str;
+ install_python_packages_automatically_ =
+
configuration->get(Configuration::nifi_python_install_packages_automatically,
automatic_install_str) &&
utils::string::toBool(automatic_install_str).value_or(false);
Review Comment:
Good idea, updated in 33e8770038e823678763c9bef60cc656c07ba16b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13020 Fix legacy flow C2 update issue [nifi]
ferencerdei commented on PR #8624: URL: https://github.com/apache/nifi/pull/8624#issuecomment-2047656933 Thanks for the improvement, it helps backward compatibility with the previous implementation where these fields were not mandatory. +1 from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13019) ClassNotFoundException when using HandleHttpRequest in MiNiFi-2.0.0-M2
[
https://issues.apache.org/jira/browse/NIFI-13019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Erdei updated NIFI-13019:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> ClassNotFoundException when using HandleHttpRequest in MiNiFi-2.0.0-M2
> --
>
> Key: NIFI-13019
> URL: https://issues.apache.org/jira/browse/NIFI-13019
> Project: Apache NiFi
> Issue Type: Bug
> Components: MiNiFi
>Affects Versions: 2.0.0-M2
>Reporter: Ferenc Kis
>Assignee: Ferenc Kis
>Priority: Critical
> Fix For: 2.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When using HandleHttpRequest in a MiNiFi flow in version 2.0.0-M2 it results
> in an error:
> {code}
> 2024-04-10 08:47:15,984 ERROR [Timer-Driven Process Thread-6]
> o.a.n.p.standard.HandleHttpRequest
> HandleHttpRequest[id=c6babdfa-018e-1000-78f6-d8fd88397126] Processing halted:
> yielding [1 sec]
> java.lang.NoClassDefFoundError:
> org/eclipse/jetty/server/handler/ContextHandler
> at
> org.apache.nifi.processors.standard.HandleHttpRequest.initializeServer(HandleHttpRequest.java:487)
> at
> org.apache.nifi.processors.standard.HandleHttpRequest.onTrigger(HandleHttpRequest.java:572)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1274)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:244)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
> at
> java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:358)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> at java.base/java.lang.Thread.run(Thread.java:1583)
> Caused by: java.lang.ClassNotFoundException:
> org.eclipse.jetty.server.handler.ContextHandler
> ... 13 common frames omitted
> {code}
> Most probably this happens due to the Jetty 12 upgrade.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-13019) ClassNotFoundException when using HandleHttpRequest in MiNiFi-2.0.0-M2
[
https://issues.apache.org/jira/browse/NIFI-13019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835743#comment-17835743
]
ASF subversion and git services commented on NIFI-13019:
Commit 4e8528d0287075b91749cb6461a5469f83d89899 in nifi's branch
refs/heads/main from Ferenc Kis
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4e8528d028 ]
NIFI-13019 Exclude Jetty EE10 jars from MiNiFi lib directory
Signed-off-by: Ferenc Erdei
This closes #8625.
> ClassNotFoundException when using HandleHttpRequest in MiNiFi-2.0.0-M2
> --
>
> Key: NIFI-13019
> URL: https://issues.apache.org/jira/browse/NIFI-13019
> Project: Apache NiFi
> Issue Type: Bug
> Components: MiNiFi
>Affects Versions: 2.0.0-M2
>Reporter: Ferenc Kis
>Assignee: Ferenc Kis
>Priority: Critical
> Fix For: 2.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When using HandleHttpRequest in a MiNiFi flow in version 2.0.0-M2 it results
> in an error:
> {code}
> 2024-04-10 08:47:15,984 ERROR [Timer-Driven Process Thread-6]
> o.a.n.p.standard.HandleHttpRequest
> HandleHttpRequest[id=c6babdfa-018e-1000-78f6-d8fd88397126] Processing halted:
> yielding [1 sec]
> java.lang.NoClassDefFoundError:
> org/eclipse/jetty/server/handler/ContextHandler
> at
> org.apache.nifi.processors.standard.HandleHttpRequest.initializeServer(HandleHttpRequest.java:487)
> at
> org.apache.nifi.processors.standard.HandleHttpRequest.onTrigger(HandleHttpRequest.java:572)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1274)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:244)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
> at
> java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:358)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> at java.base/java.lang.Thread.run(Thread.java:1583)
> Caused by: java.lang.ClassNotFoundException:
> org.eclipse.jetty.server.handler.ContextHandler
> ... 13 common frames omitted
> {code}
> Most probably this happens due to the Jetty 12 upgrade.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-13019 Exclude Jetty EE10 jars from MiNiFi lib directory [nifi]
ferencerdei closed pull request #8625: NIFI-13019 Exclude Jetty EE10 jars from MiNiFi lib directory URL: https://github.com/apache/nifi/pull/8625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559466021
##
extensions/python/PythonDependencyInstaller.cpp:
##
@@ -0,0 +1,166 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "PythonDependencyInstaller.h"
+
+#include "PythonScriptException.h"
+#include "PythonInterpreter.h"
+#include "PyException.h"
+#include "types/Types.h"
+
+namespace org::apache::nifi::minifi::extensions::python {
+
+namespace {
+
+std::string getPythonBinary(const std::shared_ptr ) {
+#if WIN32
+ std::string python_binary_ = "python";
+#else
+ std::string python_binary_ = "python3";
+#endif
+ if (auto binary =
configuration->get(minifi::Configuration::nifi_python_env_setup_binary)) {
+python_binary_ = *binary;
+ }
+ return python_binary_;
+}
+
+// On Windows when calling a system command using std::system, the whole
command needs to be encapsulated in additional quotes,
+// due to the std::system passing the command to 'cmd.exe /C' which needs the
additional quotes to handle the command as a single argument
+std::string encapsulateCommandInQuotesIfNeeded(const std::string& command) {
+#if WIN32
+return "\"" + command + "\"";
+#else
+return command;
+#endif
+}
+
+} // namespace
+
+PythonDependencyInstaller::PythonDependencyInstaller(const
std::shared_ptr ) {
+ python_binary_ = getPythonBinary(configuration);
+ std::string automatic_install_str;
+ install_python_packages_automatically_ =
+
configuration->get(Configuration::nifi_python_install_packages_automatically,
automatic_install_str) &&
utils::string::toBool(automatic_install_str).value_or(false);
+ if (auto path =
configuration->get(minifi::Configuration::nifi_python_virtualenv_directory)) {
+virtualenv_path_ = *path;
+logger_->log_debug("Python virtualenv path was specified at: {}",
virtualenv_path_.string());
+ } else {
+logger_->log_debug("No valid python virtualenv path was specified");
+ }
+ if (auto python_processor_dir =
configuration->get(minifi::Configuration::nifi_python_processor_dir)) {
+python_processor_dir_ = *python_processor_dir;
+logger_->log_debug("Python processor dir was specified at: {}",
python_processor_dir_.string());
+ } else {
+logger_->log_debug("No valid python processor dir was not specified in
properties");
+ }
+ createVirtualEnvIfSpecified();
+ addVirtualenvToPath();
+}
+
+std::vector
PythonDependencyInstaller::getRequirementsFilePaths() const {
+ if (!std::filesystem::exists(python_processor_dir_)) {
+return {};
+ }
+ std::vector paths;
+ for (const auto& entry :
std::filesystem::recursive_directory_iterator(std::filesystem::path{python_processor_dir_}))
{
+if (std::filesystem::is_regular_file(entry.path()) &&
entry.path().filename() == "requirements.txt") {
+ paths.push_back(entry.path());
+}
+ }
+ return paths;
+}
+
+void PythonDependencyInstaller::createVirtualEnvIfSpecified() const {
+ if (virtualenv_path_.empty()) {
Review Comment:
should we log a warning if the virtualenv_path is empty but the automatic
install is requested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559462716
##
extensions/python/PythonDependencyInstaller.cpp:
##
@@ -0,0 +1,166 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "PythonDependencyInstaller.h"
+
+#include "PythonScriptException.h"
+#include "PythonInterpreter.h"
+#include "PyException.h"
+#include "types/Types.h"
+
+namespace org::apache::nifi::minifi::extensions::python {
+
+namespace {
+
+std::string getPythonBinary(const std::shared_ptr ) {
+#if WIN32
+ std::string python_binary_ = "python";
+#else
+ std::string python_binary_ = "python3";
+#endif
+ if (auto binary =
configuration->get(minifi::Configuration::nifi_python_env_setup_binary)) {
+python_binary_ = *binary;
+ }
+ return python_binary_;
+}
+
+// On Windows when calling a system command using std::system, the whole
command needs to be encapsulated in additional quotes,
+// due to the std::system passing the command to 'cmd.exe /C' which needs the
additional quotes to handle the command as a single argument
+std::string encapsulateCommandInQuotesIfNeeded(const std::string& command) {
+#if WIN32
+return "\"" + command + "\"";
+#else
+return command;
+#endif
+}
+
+} // namespace
+
+PythonDependencyInstaller::PythonDependencyInstaller(const
std::shared_ptr ) {
+ python_binary_ = getPythonBinary(configuration);
+ std::string automatic_install_str;
+ install_python_packages_automatically_ =
+
configuration->get(Configuration::nifi_python_install_packages_automatically,
automatic_install_str) &&
utils::string::toBool(automatic_install_str).value_or(false);
Review Comment:
we could use the monadic functions here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12956) Add semantic styles for the basic theme colors
[
https://issues.apache.org/jira/browse/NIFI-12956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835734#comment-17835734
]
ASF subversion and git services commented on NIFI-12956:
Commit 1a2a23d1b643ef59551826440f7eda2fcc82668c in nifi's branch
refs/heads/main from Scott Aslan
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1a2a23d1b6 ]
[NIFI-12956] update to mat-button on general settings and login forms (#8621)
* [NIFI-12956] update to mat-button on general settings and login forms
* update mixin name
* fix typo
This closes #8621
> Add semantic styles for the basic theme colors
> --
>
> Key: NIFI-12956
> URL: https://issues.apache.org/jira/browse/NIFI-12956
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Reporter: Rob Fellows
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 2.0.0-M3
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> We should add themed styles for the commonly used colors from the palettes.
> I'm thinking like the 3 (light, default, dark) main colors from each palette.
> Something like this:
> {code:java}
> .warn-light {
> color: $warn-palette-light
> }
> .warn-default {
> color: $warn-palette-default
> }
> .warn-dark {
> color: $warn-palette-dark
> }
> .primary-light {
> color: $primary-palette-light
> }
> .primary-default {
> color: $primary-palette-default
> }
> .primary-dark {
> color: $primary-palette-dark
> }
> .accent-light {
> color: $accent-palette-light
> }
> .accent-default {
> color: $accent-palette-default
> }
> .accent-dark {
> color: $accent-palette-dark
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [NIFI-12956] update to mat-button on general settings and login forms [nifi]
rfellows merged PR #8621: URL: https://github.com/apache/nifi/pull/8621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559445576
##
extensions/python/PythonDependencyInstaller.cpp:
##
@@ -0,0 +1,166 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "PythonDependencyInstaller.h"
+
+#include "PythonScriptException.h"
+#include "PythonInterpreter.h"
+#include "PyException.h"
+#include "types/Types.h"
+
+namespace org::apache::nifi::minifi::extensions::python {
+
+namespace {
+
+std::string getPythonBinary(const std::shared_ptr ) {
+#if WIN32
+ std::string python_binary_ = "python";
+#else
+ std::string python_binary_ = "python3";
+#endif
+ if (auto binary =
configuration->get(minifi::Configuration::nifi_python_env_setup_binary)) {
+python_binary_ = *binary;
+ }
+ return python_binary_;
Review Comment:
accidental trailing underscore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
scottyaslan commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1559434165
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.html:
##
@@ -0,0 +1,51 @@
+
+
+Change Flow Version
+
+
+
+@if (flowUpdateRequest$ | async; as versionChangeRequest) {
+
+@if (versionChangeRequest.request.complete) {
+This Process Group version has changed.
+} @else {
+{{ versionChangeRequest.request.state }}
+}
+
+
+
Review Comment:
actually this was a mistake. I thought it was applying the value class.
Disregard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
rfellows commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1559396797
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html:
##
@@ -0,0 +1,89 @@
+
+
+Change Version
+
+
+
+
+Registry
+{{ versionControlInformation.registryName
}}
Review Comment:
Good call, how's this?
https://github.com/apache/nifi/assets/713866/6eb46d1a-c7f5-427e-a9ac-0c8db2872b1a;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
rfellows commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1559374929
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.html:
##
@@ -0,0 +1,51 @@
+
+
+Change Flow Version
+
+
+
+@if (flowUpdateRequest$ | async; as versionChangeRequest) {
+
+@if (versionChangeRequest.request.complete) {
+This Process Group version has changed.
+} @else {
+{{ versionChangeRequest.request.state }}
+}
+
+
+
Review Comment:
I'll assume you meant this to be on the line below where we display the
actual percentage value as text below the progress bar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
rfellows commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1559370570
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.html:
##
@@ -0,0 +1,51 @@
+
+
+Change Flow Version
+
+
+
+@if (flowUpdateRequest$ | async; as versionChangeRequest) {
+
+@if (versionChangeRequest.request.complete) {
+This Process Group version has changed.
+} @else {
+{{ versionChangeRequest.request.state }}
+}
+
+
+
Review Comment:
I don't understand this suggestion. the `[value]` here is an input into the
component to it knows the percent complete to display. It isn't a class/style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
szaszm commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1559357442
##
PROCESSORS.md:
##
@@ -1548,7 +1548,7 @@ In the list below, the names of required properties
appear in bold. Any other pr
### Description
-Listens for incoming TCP connections and reads data from each connection using
a line separator as the message demarcator. For each message the processor
produces a single FlowFile.
+Listens for incoming TCP connections and reads data from each connection using
a configurable message demarcator. For each message the processor produces a
single FlowFile.
Review Comment:
We should call it either delimiter or demarcator consistently.
```suggestion
Listens for incoming TCP connections and reads data from each connection
using a configurable message delimiter. For each message the processor produces
a single FlowFile.
```
##
extensions/standard-processors/processors/ListenTCP.h:
##
@@ -69,15 +69,29 @@ class ListenTCP : public NetworkListenerProcessor {
.withDefaultValue(magic_enum::enum_name(utils::net::ClientAuthOption::NONE))
.withAllowedValues(magic_enum::enum_names())
.build();
- EXTENSIONAPI static constexpr auto Properties =
std::array{
+ EXTENSIONAPI static constexpr auto MessageDelimiter =
core::PropertyDefinitionBuilder<>::createProperty("Message Delimiter")
+ .withDescription("The delimiter is used to divide the stream into
flowfiles.")
+ .isRequired(true)
+ .withDefaultValue("\n")
+ .supportsExpressionLanguage(false)
+ .build();
+ EXTENSIONAPI static constexpr auto ConsumeDelimiter =
core::PropertyDefinitionBuilder<>::createProperty("Consume delimiter")
Review Comment:
```suggestion
EXTENSIONAPI static constexpr auto ConsumeDelimiter =
core::PropertyDefinitionBuilder<>::createProperty("Consume Delimiter")
```
##
PROCESSORS.md:
##
@@ -1561,6 +1561,8 @@ In the list below, the names of required properties
appear in bold. Any other pr
| **Max Size of Message Queue** | 1 ||
Maximum number of messages allowed to be buffered before processing them when
the processor is triggered. If the buffer is full, the message is ignored. If
set to zero the buffer is unlimited. |
| SSL Context Service | ||
The Controller Service to use in order to obtain an SSL Context. If this
property is set, messages will be received over a secure connection.
|
| Client Auth | NONE | NONEWANTREQUIRED |
The client authentication policy to use for the SSL Context. Only used if an
SSL Context Service is provided.
|
+| **Message Delimiter** | \n||
The delimiter is used to divide the stream into flowfiles.
|
+| **Consume delimiter** | true | truefalse |
If set to true then the delimiter won't be included at the end of the resulting
flowfiles.
|
Review Comment:
Most properties have capital first letters in each word.
```suggestion
| **Consume Delimiter** | true | truefalse
| If set to true then the delimiter won't be included at the end of the
resulting flowfiles.
|
```
##
extensions/standard-processors/processors/ListenTCP.h:
##
@@ -36,10 +36,10 @@ namespace org::apache::nifi::minifi::processors {
class ListenTCP : public NetworkListenerProcessor {
public:
explicit ListenTCP(std::string_view name, const utils::Identifier& uuid = {})
-: NetworkListenerProcessor(name, uuid,
core::logging::LoggerFactory::getLogger(uuid)) {
+ : NetworkListenerProcessor(name, uuid,
core::logging::LoggerFactory::getLogger(uuid)) {
}
- EXTENSIONAPI static constexpr const char* Description = "Listens for
incoming TCP connections and reads data from each connection using a line
separator as the message demarcator. "
+ EXTENSIONAPI static constexpr const char* Description = "Listens for
incoming TCP connections and reads data from each connection using a
configurable message demarcator. "
Review Comment:
```suggestion
EXTENSIONAPI static constexpr const char* Description = "Listens for
incoming TCP connections and reads data from each connection using a
configurable message delimiter. "
```
--
This is an automated message from the Apache Git Service.
To respond to the message,
Re: [PR] [NIFI-12995]- Change Flow Version, Show Local Changes, Revert local changes [nifi]
rfellows commented on code in PR #8607:
URL: https://github.com/apache/nifi/pull/8607#discussion_r1559348402
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/local-changes-dialog/local-changes-table/local-changes-table.html:
##
@@ -0,0 +1,80 @@
+
+
+
+
+Displaying {{ filteredCount }} of {{ totalCount
}}
+
+
+
+
+Filter
+
Review Comment:
Yeah, it is on the left everywhere else. I'd say we leave it alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2251 Make OPENSSL and CURL mandatory [nifi-minifi-cpp]
lordgamez commented on code in PR #1749:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#discussion_r1559333949
##
libminifi/test/unit/SchedulingAgentTests.cpp:
##
@@ -63,8 +64,8 @@ class SchedulingAgentTestFixture {
count_proc_->setScheduledState(core::RUNNING);
#ifdef WIN32
-utils::dateSetInstall(TZ_DATA_DIR);
date::set_install(TZ_DATA_DIR);
+minifi::utils::timeutils::dateSetInstall(TZ_DATA_DIR);
Review Comment:
It was removed, and readded so that's probably why the order changed,
updated in 6c350a979f1fbdd0e2e020feeb0ad7087b64771c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2251 Make OPENSSL and CURL mandatory [nifi-minifi-cpp]
lordgamez commented on code in PR #1749: URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#discussion_r1559332779 ## README.md: ## @@ -185,7 +184,7 @@ On all distributions please use -DUSE_SHARED_LIBS=OFF to statically link zlib, l Libraries * libuuid * librocksdb (built and statically linked) -* libcurl-openssl (If not available or desired, NSS will be used) +* libcurl-openssl Review Comment: Updated in 6c350a979f1fbdd0e2e020feeb0ad7087b64771c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2251 Make OPENSSL and CURL mandatory [nifi-minifi-cpp]
lordgamez commented on code in PR #1749:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#discussion_r1559331235
##
arch.sh:
##
@@ -31,10 +31,9 @@ bootstrap_compiler(){
sudo pacman -S --noconfirm gcc
}
build_deps(){
-COMMAND="sudo pacman -S --noconfirm --needed cmake zlib openssl util-linux
make patch which pkgconf"
+COMMAND="sudo pacman -S --noconfirm --needed cmake zlib openssl util-linux
make patch which pkgconf perl bzip2 curl"
Review Comment:
Yes, but only on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-12614: Create record reader service for Protobuf messages (1.x v… [nifi]
mark-bathori opened a new pull request, #8626: URL: https://github.com/apache/nifi/pull/8626 …ersion) # Summary [NIFI-12614](https://issues.apache.org/jira/browse/NIFI-12614) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2251 Make OPENSSL and CURL mandatory [nifi-minifi-cpp]
lordgamez commented on code in PR #1749:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#discussion_r1559282097
##
libminifi/CMakeLists.txt:
##
@@ -78,17 +76,17 @@ endif()
include(RangeV3)
include(Asio)
include(MagicEnum)
-list(APPEND LIBMINIFI_LIBRARIES yaml-cpp ZLIB::ZLIB concurrentqueue RapidJSON
spdlog Threads::Threads gsl-lite libsodium range-v3 expected-lite date::date
date::tz asio magic_enum)
+list(APPEND LIBMINIFI_LIBRARIES yaml-cpp ZLIB::ZLIB concurrentqueue RapidJSON
spdlog Threads::Threads gsl-lite libsodium range-v3 expected-lite date::date
date::tz asio magic_enum OpenSSL::Crypto OpenSSL::SSL CURL::libcurl RapidJSON)
if(NOT WIN32)
list(APPEND LIBMINIFI_LIBRARIES OSSP::libuuid++)
endif()
-if (MINIFI_OPENSSL)
-list(APPEND LIBMINIFI_LIBRARIES OpenSSL::Crypto OpenSSL::SSL)
-endif()
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION
VERSION_LESS 9)
list(APPEND LIBMINIFI_LIBRARIES stdc++fs)
endif()
target_link_libraries(core-minifi ${CMAKE_DL_LIBS} ${LIBMINIFI_LIBRARIES})
+if (APPLE)
+target_link_libraries(core-minifi "-framework CoreFoundation -framework
SystemConfiguration")
+endif()
Review Comment:
It was needed in `minifi-http-curl` which is now part of `core-minifi` so it
was moved here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1559273234
##
extensions/python/PythonCreator.h:
##
@@ -78,6 +80,11 @@ class PythonCreator : public minifi::core::CoreComponent {
class_name = full_name;
}
if (path.string().find("nifi_python_processors") != std::string::npos) {
+auto utils_path = std::string("nifi_python_processors").append(1,
utils::file::getSeparator()).append("utils");
Review Comment:
Good point, updated in 8a56c5920d11b683b800a73cf603bfca6de925f4
##
msi/WixWin.wsi.in:
##
@@ -437,6 +438,11 @@ ${WIX_EXTRA_COMPONENTS}
+
+
+
Review Comment:
Updated in 8a56c5920d11b683b800a73cf603bfca6de925f4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]
balazsgerner commented on PR #8544: URL: https://github.com/apache/nifi/pull/8544#issuecomment-2047264513 I had to rebase to `main` in order resolve merge conflicts. Sorry for the force push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13019) ClassNotFoundException when using HandleHttpRequest in MiNiFi-2.0.0-M2
[
https://issues.apache.org/jira/browse/NIFI-13019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Kis updated NIFI-13019:
--
Fix Version/s: 2.0.0-M3
Status: Patch Available (was: In Progress)
> ClassNotFoundException when using HandleHttpRequest in MiNiFi-2.0.0-M2
> --
>
> Key: NIFI-13019
> URL: https://issues.apache.org/jira/browse/NIFI-13019
> Project: Apache NiFi
> Issue Type: Bug
> Components: MiNiFi
>Affects Versions: 2.0.0-M2
>Reporter: Ferenc Kis
>Assignee: Ferenc Kis
>Priority: Critical
> Fix For: 2.0.0-M3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When using HandleHttpRequest in a MiNiFi flow in version 2.0.0-M2 it results
> in an error:
> {code}
> 2024-04-10 08:47:15,984 ERROR [Timer-Driven Process Thread-6]
> o.a.n.p.standard.HandleHttpRequest
> HandleHttpRequest[id=c6babdfa-018e-1000-78f6-d8fd88397126] Processing halted:
> yielding [1 sec]
> java.lang.NoClassDefFoundError:
> org/eclipse/jetty/server/handler/ContextHandler
> at
> org.apache.nifi.processors.standard.HandleHttpRequest.initializeServer(HandleHttpRequest.java:487)
> at
> org.apache.nifi.processors.standard.HandleHttpRequest.onTrigger(HandleHttpRequest.java:572)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1274)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:244)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
> at
> java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:358)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> at java.base/java.lang.Thread.run(Thread.java:1583)
> Caused by: java.lang.ClassNotFoundException:
> org.eclipse.jetty.server.handler.ContextHandler
> ... 13 common frames omitted
> {code}
> Most probably this happens due to the Jetty 12 upgrade.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-13019 Exclude Jetty EE10 jars from MiNiFi lib directory [nifi]
briansolo1985 opened a new pull request, #8625: URL: https://github.com/apache/nifi/pull/8625 # Summary [NIFI-13019](https://issues.apache.org/jira/browse/NIFI-13019) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13020) Flow update fails when legacy flow is received via C2
[ https://issues.apache.org/jira/browse/NIFI-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Kis updated NIFI-13020: -- Fix Version/s: 2.0.0-M3 Status: Patch Available (was: In Progress) > Flow update fails when legacy flow is received via C2 > - > > Key: NIFI-13020 > URL: https://issues.apache.org/jira/browse/NIFI-13020 > Project: Apache NiFi > Issue Type: Bug > Components: MiNiFi >Affects Versions: 2.0.0-M2 >Reporter: Ferenc Kis >Assignee: Ferenc Kis >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 10m > Remaining Estimate: 0h > > When legacy flow is received via C2, flow update will fail. > Legacy flows do not have instanceId, so those will need to be generated and > mapped. > Additionally there are some processor properties which are missing those need > to be populated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13020 Fix legacy flow C2 update issue [nifi]
briansolo1985 opened a new pull request, #8624: URL: https://github.com/apache/nifi/pull/8624 # Summary [NIFI-13020](https://issues.apache.org/jira/browse/NIFI-13020) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2309 Add JSON flow config examples [nifi-minifi-cpp]
lordgamez commented on code in PR #1740:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1740#discussion_r1559138925
##
examples/splittext_puttcp_config.json:
##
@@ -0,0 +1,86 @@
+{
+"rootGroup": {
+"name": "MiNiFi Flow",
+"processors": [
+{
+"name": "Get files from /tmp/input",
+"identifier": "a8fd96f8-6f3e-4ab8-9cc7-7dcb3304d60b",
+"type": "org.apache.nifi.processors.standard.GetFile",
+"schedulingStrategy": "TIMER_DRIVEN",
+"schedulingPeriod": "2 sec",
+"penaltyDuration": "30 sec",
+"yieldDuration": "1 sec",
+"properties": {
+"Input Directory": "/tmp/input"
+},
+"autoTerminatedRelationships": []
+},
+{
+"name": "Split text by lines skipping the first 3 header
lines",
+"identifier": "40b45f52-ae1d-443c-9465-7e070ce3bea0",
+"type": "org.apache.nifi.processors.standard.SplitText",
+"schedulingStrategy": "EVENT_DRIVEN",
+"schedulingPeriod": "1 sec",
Review Comment:
Updated in dcab8ffd0883e3fc881e85f6a30fcbdf0cb7e9f2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
fgerlits commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1549915952
##
extensions/python/PythonCreator.h:
##
@@ -78,6 +80,11 @@ class PythonCreator : public minifi::core::CoreComponent {
class_name = full_name;
}
if (path.string().find("nifi_python_processors") != std::string::npos) {
+auto utils_path = std::string("nifi_python_processors").append(1,
utils::file::getSeparator()).append("utils");
Review Comment:
why not
```suggestion
auto utils_path = (std::filesystem::path("nifi_python_processors") /
"utils").string();
```
? then we wouldn't need the `getSeparator()` function
##
msi/WixWin.wsi.in:
##
@@ -437,6 +438,11 @@ ${WIX_EXTRA_COMPONENTS}
+
+
+
Review Comment:
nitpicking:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1559125910
##
extensions/python/pythonprocessors/nifi_python_processors/utils/inline_dependency_installer.py:
##
@@ -0,0 +1,43 @@
+import ast
+import sys
+import subprocess
+import os
+
+
+class Visitor(ast.NodeVisitor):
+def __init__(self, class_name):
+self.dependencies = []
+self.class_name = class_name
+
+def visit_ClassDef(self, node):
+if node.name != self.class_name:
+return
+for child in node.body:
+if isinstance(child, ast.ClassDef) and child.name ==
'ProcessorDetails':
+for detail in child.body:
+if isinstance(detail, ast.Assign) and detail.targets[0].id
== 'dependencies':
+for elt in detail.value.elts:
+if isinstance(elt, ast.Constant):
+self.dependencies.append(elt.s)
+break
+break
+
+
+def extract_dependencies(file_path):
+class_name = file_path.split(os.sep)[-1].split('.')[0]
+with open(file_path, 'r') as file:
+code = file.read()
+
+tree = ast.parse(code)
+visitor = Visitor(class_name)
+visitor.visit(tree)
+return visitor.dependencies
+
+
+if __name__ == '__main__':
+if len(sys.argv) < 2:
+sys.exit(1)
+
+dependencies = extract_dependencies(sys.argv[1])
+if dependencies:
+subprocess.check_call([sys.executable, "-m", "pip", "install",
"--no-cache-dir"] + dependencies)
Review Comment:
Updated in 092b9141f6362a32269cad06a20b24731fd17d19
##
extensions/python/pythonprocessors/nifi_python_processors/utils/inline_dependency_installer.py:
##
@@ -0,0 +1,49 @@
+import ast
+import sys
+import subprocess
+import os
+
+
+class Visitor(ast.NodeVisitor):
Review Comment:
Updated in 092b9141f6362a32269cad06a20b24731fd17d19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors (1.x version) [nifi]
pvillard31 commented on PR #8618: URL: https://github.com/apache/nifi/pull/8618#issuecomment-2046996949 Merged, thanks @mattyb149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors (1.x version) [nifi]
pvillard31 closed pull request #8618: NIFI-12889: Retry Kerberos login on auth failure in HDFS processors (1.x version) URL: https://github.com/apache/nifi/pull/8618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
lordgamez commented on code in PR #1727: URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1559125185 ## docker/test/integration/cluster/ImageStore.py: ## @@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self): return self.__build_image(dockerfile) -def __build_minifi_cpp_image_with_nifi_python_processors(self, additional_cmd=""): +def __build_minifi_cpp_image_with_nifi_python_processors(self, python_option): parse_document_url = "https://raw.githubusercontent.com/apache/nifi/rel/nifi-; + NifiContainer.NIFI_VERSION + "/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py" chunk_document_url = "https://raw.githubusercontent.com/apache/nifi/rel/nifi-; + NifiContainer.NIFI_VERSION + "/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py" pip3_install_command = "" +requirements_install_command = "" +additional_cmd = "" +parse_document_sed_cmd = 'sed -i "54d;55d" /opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py && \\' +chunk_document_sed_cmd = 'sed -i "112d" /opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py && \\' Review Comment: Good point I also tried doing that first, but the reason changed it is because the dependencies can be listed in multiple lines as it is done in the `ParseDocument.py` at the moment and sed only works in a line-by-line manner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12889) Retry Kerberos Login on auth failures in HDFS processors
[ https://issues.apache.org/jira/browse/NIFI-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12889: -- Fix Version/s: 1.26.0 > Retry Kerberos Login on auth failures in HDFS processors > > > Key: NIFI-12889 > URL: https://issues.apache.org/jira/browse/NIFI-12889 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Currently if a Kerberos authentication failure happens (during ticket > relogin, e.g.) in the HDFS processors, the controller service must be > restarted manually in order for the processors to execute correctly. From the > processors we should reset the HDFS resources on auth failure to simulate a > "restart" of the controller service so relogin can occur correctly. > At a minimum this includes the following processors: > FetchHDFS > GetHDFS > GetHDFSFileInfo > PutHDFS > ListHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12889) Retry Kerberos Login on auth failures in HDFS processors
[ https://issues.apache.org/jira/browse/NIFI-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835663#comment-17835663 ] ASF subversion and git services commented on NIFI-12889: Commit b04b9b2213f902d8fd912ab3ba950875deb7e9e4 in nifi's branch refs/heads/support/nifi-1.x from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b04b9b2213 ] NIFI-12889 - Retry Kerberos login on auth failure in HDFS processors Signed-off-by: Pierre Villard This closes #8618. > Retry Kerberos Login on auth failures in HDFS processors > > > Key: NIFI-12889 > URL: https://issues.apache.org/jira/browse/NIFI-12889 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 4h > Remaining Estimate: 0h > > Currently if a Kerberos authentication failure happens (during ticket > relogin, e.g.) in the HDFS processors, the controller service must be > restarted manually in order for the processors to execute correctly. From the > processors we should reset the HDFS resources on auth failure to simulate a > "restart" of the controller service so relogin can occur correctly. > At a minimum this includes the following processors: > FetchHDFS > GetHDFS > GetHDFSFileInfo > PutHDFS > ListHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2314 - Send asset state hash in heartbeat, implement c2 asset sync [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1751:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1751#discussion_r1559110636
##
conf/minifi.properties:
##
@@ -90,7 +90,7 @@ nifi.content.repository.class.name=DatabaseContentRepository
#nifi.c2.rest.url=
#nifi.c2.rest.url.ack=
#nifi.c2.rest.ssl.context.service=
-nifi.c2.root.classes=DeviceInfoNode,AgentInformation,FlowInformation
+nifi.c2.root.classes=DeviceInfoNode,AgentInformation,FlowInformation,AssetInformation
Review Comment:
expanded on the Asset directory entry in CONFIGURE.md
##
libminifi/src/utils/file/AssetManager.cpp:
##
@@ -0,0 +1,153 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "utils/file/AssetManager.h"
+#include "utils/file/FileUtils.h"
+#include "rapidjson/document.h"
+#include "rapidjson/writer.h"
+#include "core/logging/LoggerFactory.h"
+#include "utils/Hash.h"
+
+#undef GetObject
+
+namespace org::apache::nifi::minifi::utils::file {
+
+AssetManager::AssetManager(std::shared_ptr configuration)
Review Comment:
done
##
libminifi/include/core/state/nodes/AssetInformation.h:
##
@@ -0,0 +1,42 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "core/state/nodes/MetricsBase.h"
+#include "utils/file/AssetManager.h"
+#include "core/logging/Logger.h"
+
+namespace org::apache::nifi::minifi::state::response {
+
+class AssetInformation : public ResponseNode {
+ public:
+ AssetInformation();
+ explicit AssetInformation(std::string name, const utils::Identifier& uuid =
{}) : ResponseNode(std::move(name), uuid) {}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559104966 ## libminifi/src/Configuration.cpp: ## @@ -152,7 +152,11 @@ const std::unordered_map
[PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool (1.x version) [nifi]
Lehel44 opened a new pull request, #8623: URL: https://github.com/apache/nifi/pull/8623 [NIFI-12890](https://issues.apache.org/jira/browse/NIFI-12890) This PR is the 1.x version of https://github.com/apache/nifi/pull/8619 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool (1.x version) [nifi]
Lehel44 closed pull request #8622: NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool (1.x version) URL: https://github.com/apache/nifi/pull/8622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool (1.x version) [nifi]
Lehel44 opened a new pull request, #8622: URL: https://github.com/apache/nifi/pull/8622 # Summary [NIFI-12890](https://issues.apache.org/jira/browse/NIFI-12890) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13020) Flow update fails when legacy flow is received via C2
[ https://issues.apache.org/jira/browse/NIFI-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Kis updated NIFI-13020: -- Fix Version/s: (was: 2.0.0-M3) > Flow update fails when legacy flow is received via C2 > - > > Key: NIFI-13020 > URL: https://issues.apache.org/jira/browse/NIFI-13020 > Project: Apache NiFi > Issue Type: Bug > Components: MiNiFi >Affects Versions: 2.0.0-M2 >Reporter: Ferenc Kis >Assignee: Ferenc Kis >Priority: Major > > When legacy flow is received via C2, flow update will fail. > Legacy flows do not have instanceId, so those will need to be generated and > mapped. > Additionally there are some processor properties which are missing those need > to be populated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13020) Flow update fails when legacy flow is received via C2
Ferenc Kis created NIFI-13020: - Summary: Flow update fails when legacy flow is received via C2 Key: NIFI-13020 URL: https://issues.apache.org/jira/browse/NIFI-13020 Project: Apache NiFi Issue Type: Bug Components: MiNiFi Affects Versions: 2.0.0-M2 Reporter: Ferenc Kis Assignee: Ferenc Kis Fix For: 2.0.0-M3 When legacy flow is received via C2, flow update will fail. Legacy flows do not have instanceId, so those will need to be generated and mapped. Additionally there are some processor properties which are missing those need to be populated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13019) ClassNotFoundException when using HandleHttpRequest in MiNiFi-2.0.0-M2
Ferenc Kis created NIFI-13019:
-
Summary: ClassNotFoundException when using HandleHttpRequest in
MiNiFi-2.0.0-M2
Key: NIFI-13019
URL: https://issues.apache.org/jira/browse/NIFI-13019
Project: Apache NiFi
Issue Type: Bug
Components: MiNiFi
Affects Versions: 2.0.0-M2
Reporter: Ferenc Kis
Assignee: Ferenc Kis
When using HandleHttpRequest in a MiNiFi flow in version 2.0.0-M2 it results in
an error:
{code}
2024-04-10 08:47:15,984 ERROR [Timer-Driven Process Thread-6]
o.a.n.p.standard.HandleHttpRequest
HandleHttpRequest[id=c6babdfa-018e-1000-78f6-d8fd88397126] Processing halted:
yielding [1 sec]
java.lang.NoClassDefFoundError: org/eclipse/jetty/server/handler/ContextHandler
at
org.apache.nifi.processors.standard.HandleHttpRequest.initializeServer(HandleHttpRequest.java:487)
at
org.apache.nifi.processors.standard.HandleHttpRequest.onTrigger(HandleHttpRequest.java:572)
at
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1274)
at
org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:244)
at
org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
at
java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:358)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.ClassNotFoundException:
org.eclipse.jetty.server.handler.ContextHandler
... 13 common frames omitted
{code}
Most probably this happens due to the Jetty 12 upgrade.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
