Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
github-advanced-security[bot] commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1576961234
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitPcap.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.ProcessorInitializationContext;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.processors.standard.util.Pcap;
+import org.apache.nifi.processors.standard.util.Pcap.ByteBufferInterface;
+import org.apache.nifi.processors.standard.util.Pcap.Packet;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttribute(attribute = "ERROR_REASON", description = "The reason the
flowfile was sent to the failure relationship.")
+
+public class SplitPcap extends AbstractProcessor {
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP_MAX_SIZE")
+.displayName("PCAP max size (bytes)")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_SUCCESS = new Relationship.Builder()
+.name("success")
+.description("output flowfiles")
+.build();
+
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("Flowfiles not parseable as pcap.")
+.build();
+
+private List descriptors;
+
+private Set relationships;
+
+@Override
+protected void init(final ProcessorInitializationContext context) {
+descriptors = new ArrayList<>();
+descriptors.add(PCAP_MAX_SIZE);
+descriptors = Collections.unmodifiableList(descriptors);
+
+relationships = new HashSet<>();
+relationships.add(REL_SUCCESS);
+relationships.add(REL_FAILURE);
+relationships = Collections.unmodifiableSet(relationships);
+}
+
+@Override
+public Set getRelationships() {
+return this.relationships;
+}
+
+@Override
+public final List getSupportedPropertyDescriptors() {
+return descriptors;
+}
+
+@OnScheduled
+public void onScheduled(final ProcessContext context) {
+
+}
+
+private static final char[] HEX_ARRAY = "0123456789ABCDEF".toCharArray();
+public static String bytesToHex(byte[] bytes) {
+char[] hexChars = new char[bytes.length * 2];
+for (int j = 0; j < bytes.length; j++) {
+int v = bytes[j] & 0xFF;
+hexChars[j * 2] = HEX_ARRAY[v >>> 4];
+hexChars[j * 2 + 1] = HEX_ARRAY[v & 0x0F];
+}
+return new String(hexChars);
+}
+
+/**
+ * This method is called when a trigger event occurs in the processor.
+ * It processes the incoming flow file, splits it into smaller pcap files
based on the maximum size,
+ * and transfers the split pcap files to the success relationship.
+ * If the flow file is empty or not parseable, it is transferred to the
failure relationship.
+ *
+ * @param context the process context
+ *
[jira] [Commented] (NIFI-13078) Support Enable/Disable Component
[ https://issues.apache.org/jira/browse/NIFI-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840225#comment-17840225 ] ASF subversion and git services commented on NIFI-13078: Commit 562eece6e3c1eec8d3eec15fd15d9fb986cbc433 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=562eece6e3 ] NIFI-13078: Adding support to Enable and Disable through the context menu and operation control (#8680) * NIFI-13078: - Adding support to Enable and Disable through the context menu and operation control. * NIFI-13078: - Addressing review feedback. This closes #8680 > Support Enable/Disable Component > > > Key: NIFI-13078 > URL: https://issues.apache.org/jira/browse/NIFI-13078 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Add support to enable and disable components through the context menu and the > operation control. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13078) Support Enable/Disable Component
[ https://issues.apache.org/jira/browse/NIFI-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13078: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Support Enable/Disable Component > > > Key: NIFI-13078 > URL: https://issues.apache.org/jira/browse/NIFI-13078 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 40m > Remaining Estimate: 0h > > Add support to enable and disable components through the context menu and the > operation control. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13078: Adding support to Enable and Disable through the context menu and operation control [nifi]
rfellows merged PR #8680: URL: https://github.com/apache/nifi/pull/8680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13055) [BUG] Missing Users or Policies menu options
[ https://issues.apache.org/jira/browse/NIFI-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-13055: -- Assignee: Matt Gilman > [BUG] Missing Users or Policies menu options > > > Key: NIFI-13055 > URL: https://issues.apache.org/jira/browse/NIFI-13055 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Matt Gilman >Priority: Major > > When the user visits one of the counters, bulletins, summary, or the > controller services pages and refreshes the page the global hamburger menu no > longer contains the Users or Policies menu options? If they go to the canvas > and then go to one of those pages those menu options are present. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13089) UI - Update README and PR template
[ https://issues.apache.org/jira/browse/NIFI-13089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman resolved NIFI-13089. Fix Version/s: 2.0.0-M3 Resolution: Fixed > UI - Update README and PR template > -- > > Key: NIFI-13089 > URL: https://issues.apache.org/jira/browse/NIFI-13089 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 50m > Remaining Estimate: 0h > > Update the README to provide guidance for contributing to the new UI. Also > update the PR template to assert that any new UI contribution is implemented > in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2332 Fix data size conversion in NiFi python processors [nifi-minifi-cpp]
martinzink closed pull request #1760: MINIFICPP-2332 Fix data size conversion in NiFi python processors URL: https://github.com/apache/nifi-minifi-cpp/pull/1760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2334 win: smb and loki extensions on by default [nifi-minifi-cpp]
martinzink closed pull request #1764: MINIFICPP-2334 win: smb and loki extensions on by default URL: https://github.com/apache/nifi-minifi-cpp/pull/1764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2333 Don't register example python processors [nifi-minifi-cpp]
martinzink closed pull request #1765: MINIFICPP-2333 Don't register example python processors URL: https://github.com/apache/nifi-minifi-cpp/pull/1765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2339 Fix sccache path in CI workflow [nifi-minifi-cpp]
martinzink closed pull request #1767: MINIFICPP-2339 Fix sccache path in CI workflow URL: https://github.com/apache/nifi-minifi-cpp/pull/1767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13091) Only show selected Relationships in Edit Connection
Matt Gilman created NIFI-13091: -- Summary: Only show selected Relationships in Edit Connection Key: NIFI-13091 URL: https://issues.apache.org/jira/browse/NIFI-13091 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman The Edit Connection dialog was updated in NIFI-12972 to only show the selected Relationships. This Jira is tracking the same change in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13089) UI - Update README and PR template
[ https://issues.apache.org/jira/browse/NIFI-13089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840209#comment-17840209 ] ASF subversion and git services commented on NIFI-13089: Commit cde820673cbd448880e75ff1ff2eef2a2e01f5f9 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cde820673c ] NIFI-13089: Updating PR Template and README for new UI (#8693) * NIFI-13089: - Updating PR Template and README for new UI. * Update nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/README.md Reformatting the code structure layout. Co-authored-by: Rob Fellows - Co-authored-by: Rob Fellows This closes #8693 > UI - Update README and PR template > -- > > Key: NIFI-13089 > URL: https://issues.apache.org/jira/browse/NIFI-13089 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Update the README to provide guidance for contributing to the new UI. Also > update the PR template to assert that any new UI contribution is implemented > in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13089: Updating PR Template and README for new UI [nifi]
rfellows merged PR #8693: URL: https://github.com/apache/nifi/pull/8693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13090 Backport Improve handling of embedded JSON records (NIFI-1… [nifi]
krisztina-zsihovszki opened a new pull request, #8694: URL: https://github.com/apache/nifi/pull/8694 …2480) # Summary [NIFI-13090](https://issues.apache.org/jira/browse/NIFI-13090) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13053] Cluster page [nifi]
mcgilman commented on code in PR #8685:
URL: https://github.com/apache/nifi/pull/8685#discussion_r1576500672
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/cluster/state/cluster-listing/cluster-listing.effects.ts:
##
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable } from '@angular/core';
+import { Actions, concatLatestFrom, createEffect, ofType } from
'@ngrx/effects';
+import { ActionCreator, Creator, Store } from '@ngrx/store';
+import { NiFiState } from '../../../../state';
+import { ErrorHelper } from '../../../../service/error-helper.service';
+import { Router } from '@angular/router';
+import * as ClusterListingActions from './cluster-listing.actions';
+import { catchError, from, map, of, switchMap, take, tap } from 'rxjs';
+import { SystemDiagnosticsService } from
'../../../../service/system-diagnostics.service';
+import { HttpErrorResponse } from '@angular/common/http';
+import { selectClusterListingStatus } from './cluster-listing.selectors';
+import { reloadSystemDiagnostics } from
'../../../../state/system-diagnostics/system-diagnostics.actions';
+import { ClusterService } from '../../service/cluster.service';
+import { MatDialog } from '@angular/material/dialog';
+import { YesNoDialog } from
'../../../../ui/common/yes-no-dialog/yes-no-dialog.component';
+import { LARGE_DIALOG, MEDIUM_DIALOG, SMALL_DIALOG } from '../../../../index';
+import { ClusterNodeDetailDialog } from
'../../ui/cluster-node-listing/cluster-node-detail-dialog/cluster-node-detail-dialog.component';
+import * as ErrorActions from '../../../../state/error/error.actions';
+import { SelectClusterNodeRequest } from './index';
+
+@Injectable()
+export class ClusterListingEffects {
+constructor(
+private actions$: Actions,
+private store: Store,
+private errorHelper: ErrorHelper,
+private router: Router,
+private systemDiagnosticsService: SystemDiagnosticsService,
+private clusterService: ClusterService,
+private dialog: MatDialog
+) {}
+
+loadClusterListing$ = createEffect(() =>
+this.actions$.pipe(
+ofType(ClusterListingActions.loadClusterListing),
+tap(() => {
+this.store.dispatch(reloadSystemDiagnostics({ request: {
nodewise: true } }));
+}),
+concatLatestFrom(() =>
[this.store.select(selectClusterListingStatus)]),
+switchMap(([, listingStatus]) =>
+from(this.clusterService.getClusterListing()).pipe(
+map((response) =>
ClusterListingActions.loadClusterListingSuccess({ response: response.cluster
})),
+catchError((errorResponse: HttpErrorResponse) =>
+of(this.errorHelper.handleLoadingError(listingStatus,
errorResponse))
+)
+)
+)
+)
+);
+
+confirmAndDisconnectNode$ = createEffect(
+() =>
+this.actions$.pipe(
+ofType(ClusterListingActions.confirmAndDisconnectNode),
+map((action) => action.request),
+tap((request) => {
+const nodeAddress =
`${request.address}:${request.apiPort}`;
+const dialogRef = this.dialog.open(YesNoDialog, {
+...SMALL_DIALOG,
+data: {
+title: 'Disconnect Node',
+message: `Disconnect '${nodeAddress}' from the
cluster?`
+}
+});
+dialogRef.componentInstance.yes.pipe(take(1)).subscribe(()
=> {
+
this.store.dispatch(ClusterListingActions.disconnectNode({ request }));
+});
+})
+),
+{ dispatch: false }
+);
+
+disconnectNode$ = createEffect(() =>
+this.actions$.pipe(
+ofType(ClusterListingActions.disconnectNode),
+map((action) => action.request),
+switchMap((request) =>
+
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) *** Support Processor Details dialog *** Support Connection Details dialog * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * Replay last event (NIFI-12445) * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version (NIFI-13034) * Consider PG permissions in Toolbox (NIFI-12683) * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Configure Label (NIFI-13081) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Status Bar ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History (NIFI-13047) ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * Terminate Threads (context menu) (NIFI-13068) * Enable/Disable (context menu/operate panel) (NIFI-13078) * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062) * Download Flow (NIFI-13029) * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color (context menu/operate panel) * Move to Front (NIFI-13044) * Copy/Paste (context menu/operate panel) (NIFI-13059) * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Parameter ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) **
Re: [PR] NIFI-13089: Updating PR Template and README for new UI [nifi]
exceptionfactory commented on PR #8693: URL: https://github.com/apache/nifi/pull/8693#issuecomment-2073099660 > > @mcgilman For awareness, PR #8677 includes moving the `nifi-framework` module, which would impact the location of the source links listed in the new `UI Contributions` section of the template. Perhaps simply highlighting `nifi-web-ui` and `nifi-web-frontend` without linking would be sufficient? > > Thanks for the comment. I am aware of #8677. I will update once everything is in. I think the link is helpful as the `new UI` link takes the user directly to the location of the README. This should help folks that have opened PRs updating the existing UI get an introduction to the structure and layout in the new UI. Sounds good, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13084 Backport Allow disabling scientific notation when writing … [nifi]
krisztina-zsihovszki commented on code in PR #8686:
URL: https://github.com/apache/nifi/pull/8686#discussion_r1576584416
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/WriteJsonResult.java:
##
@@ -165,19 +177,44 @@ public WriteResult writeRawRecord(final Record record)
throws IOException {
return WriteResult.of(incrementRecordCount(), attributes);
}
+private boolean isUseSerializeForm(final Record record, final RecordSchema
writeSchema) {
+final Optional serializedForm =
record.getSerializedForm();
+if (!serializedForm.isPresent()) {
+return false;
+}
+
+final SerializedForm form = serializedForm.get();
+if (!form.getMimeType().equals(getMimeType()) ||
!record.getSchema().equals(writeSchema)) {
+return false;
+}
+
+final Object serialized = form.getSerialized();
+String serializedString;
+
+if (!(serialized instanceof String)) {
+return false;
+} else {
+serializedString = (String) serialized;
+}
+
Review Comment:
@tpalfy Thank you for the comment, I agree, we need to avoid possible merge
issues.
I think it would be the best if I backported
[NIFI-12480](https://issues.apache.org/jira/browse/NIFI-12480) first and when
it is merged to support/nifi-1.x, we can continue with the actual ticket.
I created another ticket for backporting NIFI-12480, will create the PR for
it soon: https://issues.apache.org/jira/browse/NIFI-13090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13090) Backport Improve handling of embedded JSON records
Zsihovszki Krisztina created NIFI-13090: --- Summary: Backport Improve handling of embedded JSON records Key: NIFI-13090 URL: https://issues.apache.org/jira/browse/NIFI-13090 Project: Apache NiFi Issue Type: Improvement Reporter: Zsihovszki Krisztina Assignee: Zsihovszki Krisztina The changes made for NIFI-12480 were only committed on the 2.x branch and not backported to the support/nifi-1.x branch. The purpose of this ticket is to backport the code. Another backport ticket, https://issues.apache.org/jira/browse/NIFI-13084 is based on this change. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13089: Updating PR Template and README for new UI [nifi]
mcgilman commented on PR #8693: URL: https://github.com/apache/nifi/pull/8693#issuecomment-2072886055 > @mcgilman For awareness, PR #8677 includes moving the `nifi-framework` module, which would impact the location of the source links listed in the new `UI Contributions` section of the template. Perhaps simply highlighting `nifi-web-ui` and `nifi-web-frontend` without linking would be sufficient? Thanks for the comment. I am aware of #8677. I will update once everything is in. I think the link is helpful as the `new UI` link takes the user directly to the location of the README. This should help folks that have opened PRs updating the existing UI get an introduction to the structure and layout in the new UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13051) UI - update dialog action buttons to be 'Add' for create and 'Apply' for update
[ https://issues.apache.org/jira/browse/NIFI-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13051: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > UI - update dialog action buttons to be 'Add' for create and 'Apply' for > update > --- > > Key: NIFI-13051 > URL: https://issues.apache.org/jira/browse/NIFI-13051 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13051) UI - update dialog action buttons to be 'Add' for create and 'Apply' for update
[ https://issues.apache.org/jira/browse/NIFI-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840142#comment-17840142 ] ASF subversion and git services commented on NIFI-13051: Commit 3e0dcf7342ef0690e3c8c58b82048f256ec5b187 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3e0dcf7342 ] [NIFI-13051] update dialog action buttons (#8688) This closes #8688 > UI - update dialog action buttons to be 'Add' for create and 'Apply' for > update > --- > > Key: NIFI-13051 > URL: https://issues.apache.org/jira/browse/NIFI-13051 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13051] update dialog action buttons [nifi]
rfellows merged PR #8688: URL: https://github.com/apache/nifi/pull/8688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13089: Updating PR Template and README for new UI [nifi]
rfellows commented on code in PR #8693: URL: https://github.com/apache/nifi/pull/8693#discussion_r1576421090 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/README.md: ## @@ -1,41 +1,73 @@ # NiFi -https://nx.dev; target="_blank" rel="noreferrer">https://raw.githubusercontent.com/nrwl/nx/master/images/nx-logo.png; width="45"> - ## General Info -### Nx - -If you are unfamiliar Nx, you can learn more at https://nx.dev/getting-started/intro. They provide many solid resources to get you up to speed. - -_From Nx:_ - -> We created Nx because developers struggle to configure, maintain and especially integrate various tools and frameworks. -> Setting up a system that works well for a handful of developers and at the same time, easily scales up to an entire organization is hard. -> This includes setting up low-level build tooling, configuring fast CI, and keeping your codebase healthy, up-to-date, and maintainable. +This module is the primary UI for NiFi. It contains the canvas and all UI's for managing the NiFi instance. There are other modules within the codebase +that support other UIs that intergate with this. These include documentation, data viewers, advanced configuration UIs, error handling, and Registry UIs. +Overtime, these will all be modernized and possibly brought into this Nx repo to co-locate all the front end code. + +In its current state it is not quite ready to replace the existing UI as there are a few features that are not implemented yet. The new UI will not +be available with the default build. However, if the build activates the `include-new-ui` profile the new UI will be built and included. On startup, +NiFi has been updated to locate the new UI and if present deploy it to a new context path (`/nf`). If the new UI is not found, nothing is deployed to +the new context path and the application functions as it does today. + +One thing to note, when using the new UI running in NiFi at `/nf`, the user can log in and use the application. When logging out however, there is +a hardcoded redirect that happens from the back end which sends the user to the old UI (`/nifi`). + +Once the remaining features have been implemented, the look and feel has be polished, and it is ready for release the old UI will be removed, update +the context path for the new UI to use `/nifi`, and remove the `include-new-ui` Maven profile. At that point, the logout redirection issue called out above won’t +be a problem anymore. + +## Source Structure + +The structure of the application is laid out in the following manner. + +- app +- pages +- flow-designer +- feature +- service +- state +- ui +- settings +- feature +- service +- state +- ui +- ... +- service +- state +- ui Review Comment: ```suggestion app ├── pages │ ├── flow-designer │ │ ├── feature │ │ ├── service │ │ ├── state │ │ └── ui │ ├── settings │ │ ├── feature │ │ ├── service │ │ ├── state │ │ └── ui ├── service ├── state └── ui ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13078: Adding support to Enable and Disable through the context menu and operation control [nifi]
rfellows commented on code in PR #8680:
URL: https://github.com/apache/nifi/pull/8680#discussion_r1576346036
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.reducer.ts:
##
@@ -400,20 +415,26 @@ export const flowReducer = createReducer(
...state,
operationCollapsed
})),
-on(startComponentSuccess, stopComponentSuccess, (state, { response }) => {
-return produce(state, (draftState) => {
-const collection: any[] | null =
getComponentCollection(draftState, response.type);
+on(
+startComponentSuccess,
+stopComponentSuccess,
+enableComponentSuccess,
+disableComponentSuccess,
Review Comment:
We are missing a reducer for `enableProcessGroupSuccess` and
`disableProcessGroupSuccess` that sets the flowState saving back to false.
If you enable/disable the current process group (right click on the canvas)
then try to edit one of the components in that PG, the apply button is a
spinner as it thinks it is still "saving"
https://github.com/apache/nifi/assets/713866/8866a3e9-d911-47d9-a825-9b9c4564711c;>
However, if you were to enable/disable a child pg this isn't an issue as the
child pg is reloaded and causes `loadChildProcessGroupSuccess` to fire which
ultimately sets the saving state back to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13084 Backport Allow disabling scientific notation when writing … [nifi]
tpalfy commented on code in PR #8686:
URL: https://github.com/apache/nifi/pull/8686#discussion_r1576346414
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/WriteJsonResult.java:
##
@@ -165,19 +177,44 @@ public WriteResult writeRawRecord(final Record record)
throws IOException {
return WriteResult.of(incrementRecordCount(), attributes);
}
+private boolean isUseSerializeForm(final Record record, final RecordSchema
writeSchema) {
+final Optional serializedForm =
record.getSerializedForm();
+if (!serializedForm.isPresent()) {
+return false;
+}
+
+final SerializedForm form = serializedForm.get();
+if (!form.getMimeType().equals(getMimeType()) ||
!record.getSchema().equals(writeSchema)) {
+return false;
+}
+
+final Object serialized = form.getSerialized();
+String serializedString;
+
+if (!(serialized instanceof String)) {
+return false;
+} else {
+serializedString = (String) serialized;
+}
+
Review Comment:
I feel it's risky to remove the check for pretty formatting form the
backport. A later backport of https://issues.apache.org/jira/browse/NIFI-12480
is not straightforward, it's very possible this wouldn't be added back. I see
no drawback in leaving it here.
```suggestion
final boolean serializedPretty = serializedString.contains("\n");
if (serializedPretty != this.prettyPrint) {
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]
scottyaslan commented on PR #8663: URL: https://github.com/apache/nifi/pull/8663#issuecomment-2072393868 > There are some discrepancies between light and dark mode in terms of bulletin/warn styling. In light mode the bulletin icon for the canvas and for processors (and most likely other components) looks good. They use the `warn-color-darker` background with a white color for the icon. However, in dark mode it seems this is not respected and `red` is used as the background and the icon color is white for the canvas but black for the processor. https://private-user-images.githubusercontent.com/713866/324832248-e07d9da9-8a73-4cbe-ac46-2b668a72e6eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4ODA3ODMsIm5iZiI6MTcxMzg4MDQ4MywicGF0aCI6Ii83MTM4NjYvMzI0ODMyMjQ4LWUwN2Q5ZGE5LThhNzMtNGNiZS1hYzQ2LTJiNjY4YTcyZTZlYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDIzJT JGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyM1QxMzU0NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NTVkYmIzNjc3ZDFjODc0ZDM4YjMyZGM1NWVjMmZkNTQzMWU3MzMzYzZhZWQxZWFhMTE1ZTc5MjVjZDU1ZjhmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.zmjgnsRKg0HF2Pv29dp70i9RTJ5PDuMu_MQ-FGSKNz4"> https://private-user-images.githubusercontent.com/713866/324832281-ebc42446-cc7f-46d8-96c1-caaf53722a9d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4ODA3ODMsIm5iZiI6MTcxMzg4MDQ4MywicGF0aCI6Ii83MTM4NjYvMzI0ODMyMjgxLWViYzQyNDQ2LWNjN2YtNDZkOC05NmMxLWNhYWY1MzcyMmE5ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyM1QxMzU0NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNp Z25hdHVyZT03Mjc5YzUwODFmNTg4NzA1OGE5NDMyNDQ5Yjk3Nzk1ZGM0MWRlZjBhMmRlNTVhNmY3MmFlYzQzYTFhYmRmYzk1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.K86DCONJq_KrIj-eWosVGbRuvHVFkEC4Yai_bqVowvw"> > Good catch! The red background colors are correct AFAIK. I will update the bulletin icon color. > Also of note, the cluster nodes icon in the top left is no longer indicating a problem when a node is not available. This used to display in the darker warning color, now it doesn't seem to have a color at all (black). This is how it looks in original NiFi: https://private-user-images.githubusercontent.com/713866/324833245-8a1373f0-444a-4274-be7e-d61908a78eee.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4ODA3ODMsIm5iZiI6MTcxMzg4MDQ4MywicGF0aCI6Ii83MTM4NjYvMzI0ODMzMjQ1LThhMTM3M2YwLTQ0NGEtNDI3NC1iZTdlLWQ2MTkwOGE3OGVlZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyM1QxMzU0NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MmFlOGZkZGYyZTBhMTg2ZDlkNDAxY2FiN2RkY2YzMzc2M2JkMDgwNDc2NjBh NzVhNWVhZjQ5M2I3OTBlZGU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.kiXGJAOGDlAHbEXkBp_BbaqXwxe3Gbk--jmNb9icpoo"> vs how it looks now: https://private-user-images.githubusercontent.com/713866/324833443-635e998a-4380-44c9-9239-3aa38be03c7e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4ODA3ODMsIm5iZiI6MTcxMzg4MDQ4MywicGF0aCI6Ii83MTM4NjYvMzI0ODMzNDQzLTYzNWU5OThhLTQzODAtNDRjOS05MjM5LTNhYTM4YmUwM2M3ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyM1QxMzU0NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NGY0ZTQ2NWI3NzdiYWNhZWQyYWM1YTA1YTk4Y2NiZjgyNTIwNmZmMzczOGMxYTE2ZjMxOGQ1OWVhM2Q1YzlkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faW Q9MCJ9.ntlhEYbC4AfxA55reupZvuhlbzmfjdjvOxFjDnF1HyE"> Another great catch! I have updated the warning color of the clustered icon in the flow status menu to be the nifi (theme) warn (palette) darker color. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13053) Node table (Disconnect/Connect/Load Balance/Etc)
[ https://issues.apache.org/jira/browse/NIFI-13053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13053: --- Status: Patch Available (was: In Progress) > Node table (Disconnect/Connect/Load Balance/Etc) > - > > Key: NIFI-13053 > URL: https://issues.apache.org/jira/browse/NIFI-13053 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13078: Adding support to Enable and Disable through the context menu and operation control [nifi]
rfellows commented on PR #8680: URL: https://github.com/apache/nifi/pull/8680#issuecomment-2072374960 reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13086) Set maxWorkers for jest tests
[ https://issues.apache.org/jira/browse/NIFI-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13086: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Set maxWorkers for jest tests > - > > Key: NIFI-13086 > URL: https://issues.apache.org/jira/browse/NIFI-13086 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13086 - set jest maxWorkers to 50% for maven builds to alleviate some resource contention [nifi]
mcgilman merged PR #8689: URL: https://github.com/apache/nifi/pull/8689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13086) Set maxWorkers for jest tests
[ https://issues.apache.org/jira/browse/NIFI-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840109#comment-17840109 ] ASF subversion and git services commented on NIFI-13086: Commit 04c6c51aed117873e142af76edbc7aec35658467 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=04c6c51aed ] NIFI-13086 - set jest maxWorkers to 50% for maven builds to alleviate some resource contention (#8689) * NIFI-13086 - set jest maxWorkers to 50% for maven builds to alleviate some resource contention * quoting the maxWorkers value * set maxWorkers in jest.config.ts * set maxWorkers to 2 for maven builds This closes #8689 > Set maxWorkers for jest tests > - > > Key: NIFI-13086 > URL: https://issues.apache.org/jira/browse/NIFI-13086 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13088) MiNiFi flow fails to load with flow exported from NiFI and transformed using transform-nifi command
[ https://issues.apache.org/jira/browse/NIFI-13088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Kis resolved NIFI-13088. --- Resolution: Fixed > MiNiFi flow fails to load with flow exported from NiFI and transformed using > transform-nifi command > --- > > Key: NIFI-13088 > URL: https://issues.apache.org/jira/browse/NIFI-13088 > Project: Apache NiFi > Issue Type: Bug > Components: MiNiFi >Affects Versions: 2.0.0-M2 >Reporter: Ferenc Kis >Assignee: Ferenc Kis >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Context: > https://apachenifi.slack.com/archives/CDF1VC1UZ/p1713804974154929 > Given > * flow containing parameter context > * exported from NiFi > * converted with minifi-toolkit transform-nifi command > When: > * minifi is started with that given flow > Then: > * flow fails to start as parameter contexts does not have id and instance id > filled in > Solution: > * implement a logic in StandardFLowEnrichService to fill in the id-s if those > are missing -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13088) MiNiFi flow fails to load with flow exported from NiFI and transformed using transform-nifi command
[ https://issues.apache.org/jira/browse/NIFI-13088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840098#comment-17840098 ] ASF subversion and git services commented on NIFI-13088: Commit 4b5b7ac2bb98168bfcafdc87c342c611d48dd820 in nifi's branch refs/heads/main from Ferenc Kis [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4b5b7ac2bb ] NIFI-13088 Populate missing parameter context ids in MiNiFi flows.json.raw Signed-off-by: Ferenc Erdei This closes #8692. > MiNiFi flow fails to load with flow exported from NiFI and transformed using > transform-nifi command > --- > > Key: NIFI-13088 > URL: https://issues.apache.org/jira/browse/NIFI-13088 > Project: Apache NiFi > Issue Type: Bug > Components: MiNiFi >Affects Versions: 2.0.0-M2 >Reporter: Ferenc Kis >Assignee: Ferenc Kis >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Context: > https://apachenifi.slack.com/archives/CDF1VC1UZ/p1713804974154929 > Given > * flow containing parameter context > * exported from NiFi > * converted with minifi-toolkit transform-nifi command > When: > * minifi is started with that given flow > Then: > * flow fails to start as parameter contexts does not have id and instance id > filled in > Solution: > * implement a logic in StandardFLowEnrichService to fill in the id-s if those > are missing -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13088 Populate missing parameter context ids in MiNiFi flows.json.raw [nifi]
ferencerdei closed pull request #8692: NIFI-13088 Populate missing parameter context ids in MiNiFi flows.json.raw URL: https://github.com/apache/nifi/pull/8692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13088 Populate missing parameter context ids in MiNiFi flows.json.raw [nifi]
ferencerdei commented on PR #8692: URL: https://github.com/apache/nifi/pull/8692#issuecomment-2072284794 Thanks for the fix. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2330 Copy the python examples from the source into the MSI [nifi-minifi-cpp]
fgerlits commented on code in PR #1759:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1759#discussion_r1576219037
##
extensions/python/CMakeLists.txt:
##
@@ -45,7 +45,15 @@ target_include_directories(minifi-python-script-extension
PUBLIC ${Python_INCLUD
get_target_property(TARGET_EXT minifi-python-script-extension SUFFIX)
-if (NOT WIN32)
+if (WIN32)
+add_custom_command(
+TARGET minifi-python-script-extension
+POST_BUILD
+COMMAND ${CMAKE_COMMAND} -E copy_directory
+"${CMAKE_SOURCE_DIR}/extensions/python/pythonprocessors"
"${CMAKE_BINARY_DIR}/pythonprocessors"
+COMMENT "Copy example python processors to the build directory"
+)
Review Comment:
fixed by a8102c59822f621eafa5009e18de5e9b303c9ff1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-1886 - Enable msi upgrade [nifi-minifi-cpp]
adamdebreceni opened a new pull request, #1768: URL: https://github.com/apache/nifi-minifi-cpp/pull/1768 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13089) UI - Update README and PR template
Matt Gilman created NIFI-13089: -- Summary: UI - Update README and PR template Key: NIFI-13089 URL: https://issues.apache.org/jira/browse/NIFI-13089 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Update the README to provide guidance for contributing to the new UI. Also update the PR template to assert that any new UI contribution is implemented in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2340) Upgrade WiX tool support
Adam Debreceni created MINIFICPP-2340: - Summary: Upgrade WiX tool support Key: MINIFICPP-2340 URL: https://issues.apache.org/jira/browse/MINIFICPP-2340 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Adam Debreceni Assignee: Adam Debreceni -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13072: Fix MonitorActivity problems with cluster scope flow monitoring [nifi]
turcsanyip commented on PR #8669: URL: https://github.com/apache/nifi/pull/8669#issuecomment-2072023632 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13088 Populate missing parameter context ids in MiNiFi flows.json.raw [nifi]
briansolo1985 opened a new pull request, #8692: URL: https://github.com/apache/nifi/pull/8692 # Summary [NIFI-13088](https://issues.apache.org/jira/browse/NIFI-13088) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13088) MiNiFi flow fails to load with flow exported from NiFI and transformed using transform-nifi command
[ https://issues.apache.org/jira/browse/NIFI-13088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Kis updated NIFI-13088: -- Description: Context: https://apachenifi.slack.com/archives/CDF1VC1UZ/p1713804974154929 Given * flow containing parameter context * exported from NiFi * converted with minifi-toolkit transform-nifi command When: * minifi is started with that given flow Then: * flow fails to start as parameter contexts does not have id and instance id filled in Solution: * implement a logic in StandardFLowEnrichService to fill in the id-s if those are missing was: Given * flow containing parameter context * exported from NiFi * converted with minifi-toolkit transform-nifi command When: * minifi is started with that given flow Then: * flow fails to start as parameter contexts does not have id and instance id filled in Solution: * implement a logic in StandardFLowEnrichService to fill in the id-s if those are missing > MiNiFi flow fails to load with flow exported from NiFI and transformed using > transform-nifi command > --- > > Key: NIFI-13088 > URL: https://issues.apache.org/jira/browse/NIFI-13088 > Project: Apache NiFi > Issue Type: Bug > Components: MiNiFi >Affects Versions: 2.0.0-M2 >Reporter: Ferenc Kis >Assignee: Ferenc Kis >Priority: Major > Fix For: 2.0.0-M3 > > > Context: > https://apachenifi.slack.com/archives/CDF1VC1UZ/p1713804974154929 > Given > * flow containing parameter context > * exported from NiFi > * converted with minifi-toolkit transform-nifi command > When: > * minifi is started with that given flow > Then: > * flow fails to start as parameter contexts does not have id and instance id > filled in > Solution: > * implement a logic in StandardFLowEnrichService to fill in the id-s if those > are missing -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13088) MiNiFi flow fails to load with flow exported from NiFI and transformed using transform-nifi command
Ferenc Kis created NIFI-13088: - Summary: MiNiFi flow fails to load with flow exported from NiFI and transformed using transform-nifi command Key: NIFI-13088 URL: https://issues.apache.org/jira/browse/NIFI-13088 Project: Apache NiFi Issue Type: Bug Components: MiNiFi Affects Versions: 2.0.0-M2 Reporter: Ferenc Kis Assignee: Ferenc Kis Fix For: 2.0.0-M3 Given * flow containing parameter context * exported from NiFi * converted with minifi-toolkit transform-nifi command When: * minifi is started with that given flow Then: * flow fails to start as parameter contexts does not have id and instance id filled in Solution: * implement a logic in StandardFLowEnrichService to fill in the id-s if those are missing -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT opened a new pull request, #8691: URL: https://github.com/apache/nifi/pull/8691 Created SplitPcap processor, Pcap supporting class, and attendant unit tests. This processor is used to split a flowfile containing a large PCAP file (in binary format) into smaller files, depending on the max size set by the user. Each of the resultant flowfiles contains a valid PCAP that may be used as normal. If the incoming PCAP is malformed, in the wrong format, or the incoming PCAP contains a packet that is larger than the maximum desired size, the incoming flowfile will be transferred to the 'failure' relationship and an 'error' attribute will be added to that flowfile stating the reason for failure. # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-2335) Add documentation for python bootstrap
[ https://issues.apache.org/jira/browse/MINIFICPP-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi resolved MINIFICPP-2335. -- Fix Version/s: 0.16.0 Resolution: Won't Fix There is already enough documentation on the python bootstrap and it is the recommended way for bootstrapping in both README.md and Windows.md documentation > Add documentation for python bootstrap > -- > > Key: MINIFICPP-2335 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2335 > Project: Apache NiFi MiNiFi C++ > Issue Type: Documentation >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.16.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13072) MonitorActivity processor generates a false positive on a node restart
[ https://issues.apache.org/jira/browse/NIFI-13072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajmund Takacs updated NIFI-13072: -- Attachment: MonitorActivity_Flow_Example_NiFi_1.18_OSS.json > MonitorActivity processor generates a false positive on a node restart > -- > > Key: NIFI-13072 > URL: https://issues.apache.org/jira/browse/NIFI-13072 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M1, 1.18.0, 1.19.0, 1.20.0, 1.19.1, 1.21.0, > 1.22.0, 1.23.0, 1.24.0, 1.23.1, 1.23.2, 1.25.0, 2.0.0-M2 >Reporter: Rajmund Takacs >Assignee: Rajmund Takacs >Priority: Major > Attachments: MonitorActivity_Flow_Example_NiFi_1.18_OSS.json > > Time Spent: 10m > Remaining Estimate: 0h > > If the monitoring scope is configured to "cluster", then there are multiple > restart cases when markers are incorrectly generated: > h4. CASE 1 > * The flow is already inactive, and there is no traffic. The processor is > still running and scheduled on all nodes. > * We restart any of the NiFi nodes in the cluster. > * *All nodes, except the restarted one, generates activation marker.* (Reason > for this is, that the common timestamp is updated by the restarted node > during initialization.) > h4. CASE 2: > * The flow is already inactive, and there is no traffic. The processor is > still running and scheduled on all nodes. Reporting is done by all nodes. > * We temporarily stop any of the nodes. > * We start traffic on any other node, so that an activation marker is > generated. > * We start the previously stopped node again. > * *This node does not send activation marker.* (Reason for this is that the > initial state is always active.) > Expected behavior for stop/start cases would be: > * Single node restart alone should not affect the flow activity state. > * If a marker has already been sent before stopping the processor, it should > not be repeated on next start, unless asked for, or there is a change in > activity state. > * If the flow was active during a weekend shutdown, it should not begin with > an inactivity marker right after startup on monday. Although it should send > inactivity marker after the threshold has expired since startup. > * If the flow was inactive during a weekend shutdown, it should send > activation marker after started up again with traffic. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13084 Backport Allow disabling scientific notation when writing … [nifi]
krisztina-zsihovszki commented on code in PR #8686:
URL: https://github.com/apache/nifi/pull/8686#discussion_r1575882905
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/WriteJsonResult.java:
##
@@ -48,9 +49,14 @@
import java.util.Map;
import java.util.Optional;
import java.util.Set;
+
+import java.util.regex.Pattern;
import java.util.function.Supplier;
public class WriteJsonResult extends AbstractRecordSetWriter implements
RecordSetWriter, RawRecordWriter {
+//private static final FieldConverter
STRING_FIELD_CONVERTER =
StandardFieldConverterRegistry.getRegistry().getFieldConverter(String.class);
Review Comment:
It's not needed, thank you for pointing out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2333 Don't register example python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1765#discussion_r1575801013
##
docker/test/integration/cluster/containers/MinifiContainer.py:
##
@@ -177,6 +178,8 @@ def deploy(self):
if self.options.enable_sql:
image = self.image_store.get_image('minifi-cpp-sql')
+elif self.options.enable_example_minifi_python_processors:
+image =
self.image_store.get_image('minifi-cpp-with-example-python-processors')
elif
self.options.use_nifi_python_processors_with_system_python_packages_installed:
image =
self.image_store.get_image('minifi-cpp-nifi-python-system-python-packages')
Review Comment:
I think we just didn't have the need for it yet. These added features to the
base minifi image are usually used in separate tests or even separate features,
so we didn't need to combine them. I think it can be refactored in the future
to have a list of required add-ons instead of a single parameter, but that
should be done when one of the tests require it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-2335) Add documentation for python bootstrap
[ https://issues.apache.org/jira/browse/MINIFICPP-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2335: Assignee: Gábor Gyimesi > Add documentation for python bootstrap > -- > > Key: MINIFICPP-2335 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2335 > Project: Apache NiFi MiNiFi C++ > Issue Type: Documentation >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2295 Add controller service support for NiFi python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1762:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1762#discussion_r1575788821
##
extensions/python/PYTHON.md:
##
@@ -102,10 +102,12 @@ NON_BLANK = 5
PORT = 6
```
+The last parameter of addProperty is the controller service type. If the
property is a controller service, the controller service type should be
provided. It should be the non-qualified type name of the controller service.
Currently SSLContextService is the only controller service type supported.
+
```python
def onInitialize(processor):
processor.setSupportsDynamicProperties()
- processor.addProperty("property name","description","default value", True
/*required*/, False /*expression language supported*/, False /*sensitive*/, 1
/*property type code*/)
+ processor.addProperty("property name", "description", "default value", True
/*required*/, False /*expression language supported*/, False /*sensitive*/, 1
/*property type code*/, None /*controller service type name*/)
Review Comment:
Good point, I added comment for the arguments in
0b35f1cf419e8b57955f65f9192cf39b8d8a5fde. Due to the implementation of
`PyProcessor::addProperty(PyProcessor* self, PyObject* args)` these are
handled as positional arguments, so using keyword arguments would be misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2333 Don't register example python processors [nifi-minifi-cpp]
fgerlits commented on code in PR #1765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1765#discussion_r1575778051
##
docker/test/integration/cluster/containers/MinifiContainer.py:
##
@@ -177,6 +178,8 @@ def deploy(self):
if self.options.enable_sql:
image = self.image_store.get_image('minifi-cpp-sql')
+elif self.options.enable_example_minifi_python_processors:
+image =
self.image_store.get_image('minifi-cpp-with-example-python-processors')
elif
self.options.use_nifi_python_processors_with_system_python_packages_installed:
image =
self.image_store.get_image('minifi-cpp-nifi-python-system-python-packages')
Review Comment:
Why do we only allow one of these at a time? I would expect (both
`enable_sql` and) `enable_example_minifi_python_processors` to be add-ons to
the other images rather than stand-alone images themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-13079) Is there a roadmap for bundle persistence provider?
[ https://issues.apache.org/jira/browse/NIFI-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839983#comment-17839983 ] Igor Milavec commented on NIFI-13079: - Hi Pierre! Sorry, I did not want to abuse the issue system, I just did not know where else to discuss this. I'll switch to Slack. Thank you! > Is there a roadmap for bundle persistence provider? > --- > > Key: NIFI-13079 > URL: https://issues.apache.org/jira/browse/NIFI-13079 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Igor Milavec >Priority: Minor > > Hi! > Based on the admin and user guides, it feels to me that the current status of > bundle persistence providers is in limbo? > The functionality is there, but it is not clear how to use it. I have found > documentation about how to configure NiFi Registry and how to upload a bundle > (using curl). I'm left wondering how this affects deployment, what are the > triggers for deployment, does it support SemVer, ... > Also, I could find no future plans for this feature. Is this being used at > all and are there plans to develop/support it in the future? > > Thank you! Igor -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13079) Is there a roadmap for bundle persistence provider?
[ https://issues.apache.org/jira/browse/NIFI-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Milavec resolved NIFI-13079. - Resolution: Information Provided > Is there a roadmap for bundle persistence provider? > --- > > Key: NIFI-13079 > URL: https://issues.apache.org/jira/browse/NIFI-13079 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Igor Milavec >Priority: Minor > > Hi! > Based on the admin and user guides, it feels to me that the current status of > bundle persistence providers is in limbo? > The functionality is there, but it is not clear how to use it. I have found > documentation about how to configure NiFi Registry and how to upload a bundle > (using curl). I'm left wondering how this affects deployment, what are the > triggers for deployment, does it support SemVer, ... > Also, I could find no future plans for this feature. Is this being used at > all and are there plans to develop/support it in the future? > > Thank you! Igor -- This message was sent by Atlassian Jira (v8.20.10#820010)
