[jira] [Updated] (NIFI-13253) Correct NOTICE discrepancies
[ https://issues.apache.org/jira/browse/NIFI-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13253: Description: With the latest changes to NIFI.2.0.0-M3 I noticed the following discrepancies which should be addressed. # Lines 7-8 should detail where it is located as other entries in this file do:nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SoftLimitBoundedByteArrayOutputStream.java # Lines 10-13 should detail where it is located as other entries in this file do: nifi-commons/nifi-property-utils/src/main/java/org/apache/nifi/util/StringUtils.java # Lines 21-26,31-34 are Hive related items which should be removed as Hive is no longer supported in NIFI # Line 46 needs to be changed from org.apache.nifi.processors.standard.util.jolt.TransformFactory to org.apache.nifi.jolt.util.TransformFactory # Line 53 should to be changed from nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestExtractGrok/patterns to nifi/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestExtractGrok/pattern # Line 58 should to be changed from Are used in unit tests found in nifi/nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich processors/src/test/java/org/apache/nifi/processors/TestGeoEnrichIP.java to Are used in unit tests found in nifi/nifi-extension-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestGeoEnrichIP.java # Lines 60-66 should be removed as there is no class FlowFileTableScan anymore # Lines 68-71 should be removed as I believe Solr items were removed # Line 75 does not exist I believe instead of The code can be found nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/krb/KeytabUser.java it should be The code can be found nifi-commons/nifi-security-kerberos/src/main/java/org/apache/nifi/security/krb/KerberosKeytabUser.java # Also 73-75 is missing a copyright year which I am not sure is an issue or not. # Line 88 should be changed from nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/../wag/client/ to nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/../wag/client/ # Lines 95-97 should be removed as these classes do not exist # Lines 99-108 do not mention where the derivative software is used. # Lines 110-114 should have Copyright 2010-2012 Coda Hale and Yammer, Inc. # Line 130 should change from nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6 processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/CustomKerberosLogin.java to nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-2-6 processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/CustomKerberosLogin.java # Line 133 should change from Copyright 2002-2023 the original author or authors. to Copyright 2002-2024 the original author or authors. was: With the latest changes to NIFI.2.0.0-M3 I noticed the following discrepancies which should be addressed. Lines 7-8 should detail where it is located as other entries in this file do: nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SoftLimitBoundedByteArrayOutputStream.java Lines 10-13 should detail where it is located as other entries in this file do: nifi-commons/nifi-property-utils/src/main/java/org/apache/nifi/util/StringUtils.java Lines 21-26,31-34 are Hive related items which should be removed as Hive is no longer supported in NIFI Line 46 needs to be changed from org.apache.nifi.processors.standard.util.jolt.TransformFactory to org.apache.nifi.jolt.util.TransformFactory Line 53 should to be changed from nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestExtractGrok/patterns to nifi/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestExtractGrok/patterns Line 58 should to be changed from Are used in unit tests found in nifi/nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestGeoEnrichIP.java to Are used in unit tests found in nifi/nifi-extension-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestGeoEnrichIP.java Lines 60-66 should be removed as there is no class FlowFileTableScan anymore Lines 68-71 should be removed as I believe Solr items were removed Line 75 does not exist I believe instead of The code can be found nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/krb/KeytabUser.java it should be The code can be found nifi-commons/nifi-security-kerberos/src/main/java/org/apache/nifi/security/krb/KerberosKeytabUser.java Also 73-75 is missing a copyright year which I am not sure is an issue or not. Line 88 should be
[jira] [Created] (NIFI-13253) Correct NOTICE discrepancies
Daniel Stieglitz created NIFI-13253: --- Summary: Correct NOTICE discrepancies Key: NIFI-13253 URL: https://issues.apache.org/jira/browse/NIFI-13253 Project: Apache NiFi Issue Type: Improvement Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz With the latest changes to NIFI.2.0.0-M3 I noticed the following discrepancies which should be addressed. Lines 7-8 should detail where it is located as other entries in this file do: nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SoftLimitBoundedByteArrayOutputStream.java Lines 10-13 should detail where it is located as other entries in this file do: nifi-commons/nifi-property-utils/src/main/java/org/apache/nifi/util/StringUtils.java Lines 21-26,31-34 are Hive related items which should be removed as Hive is no longer supported in NIFI Line 46 needs to be changed from org.apache.nifi.processors.standard.util.jolt.TransformFactory to org.apache.nifi.jolt.util.TransformFactory Line 53 should to be changed from nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestExtractGrok/patterns to nifi/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestExtractGrok/patterns Line 58 should to be changed from Are used in unit tests found in nifi/nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestGeoEnrichIP.java to Are used in unit tests found in nifi/nifi-extension-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestGeoEnrichIP.java Lines 60-66 should be removed as there is no class FlowFileTableScan anymore Lines 68-71 should be removed as I believe Solr items were removed Line 75 does not exist I believe instead of The code can be found nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/krb/KeytabUser.java it should be The code can be found nifi-commons/nifi-security-kerberos/src/main/java/org/apache/nifi/security/krb/KerberosKeytabUser.java Also 73-75 is missing a copyright year which I am not sure is an issue or not. Line 88 should be changed from nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/../wag/client/ to nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/../wag/client/ Lines 95-97 should be removed as these classes do not exist Lines 99-108 do not mention where the derivative software is used. Lines 110-114 should have Copyright 2010-2012 Coda Hale and Yammer, Inc. Line 130 should change from nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/CustomKerberosLogin.java to nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/CustomKerberosLogin.java Line 133 should change from Copyright 2002-2023 the original author or authors. to Copyright 2002-2024 the original author or authors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13252) Replace deprecated software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest.Builder argument for attributeNames with API suggestion
Daniel Stieglitz created NIFI-13252: --- Summary: Replace deprecated software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest.Builder argument for attributeNames with API suggestion Key: NIFI-13252 URL: https://issues.apache.org/jira/browse/NIFI-13252 Project: Apache NiFi Issue Type: Improvement Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz Change must be made in file {code:java} nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/a ws/sqs/GetSQS.java {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13251) Replace deprecated method fromName of com.amazonaws.regions.Regions with API suggestion
Daniel Stieglitz created NIFI-13251: --- Summary: Replace deprecated method fromName of com.amazonaws.regions.Regions with API suggestion Key: NIFI-13251 URL: https://issues.apache.org/jira/browse/NIFI-13251 Project: Apache NiFi Issue Type: Improvement Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz Changes need to be made in files # nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/util/RegionUtilV1.java # nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSCredentialsProviderProcessor.java # nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/encryption/ClientSideKMSEncryptionStrategy.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13250) Replace deprecated method withRelyingPartyRegistration of org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration with API suggestion
Daniel Stieglitz created NIFI-13250: --- Summary: Replace deprecated method withRelyingPartyRegistration of org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration with API suggestion Key: NIFI-13250 URL: https://issues.apache.org/jira/browse/NIFI-13250 Project: Apache NiFi Issue Type: Improvement Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz This needs to be changed in {code:java} nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/sec urity/saml2/service/web/StandardRelyingPartyRegistrationResolver.java {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13249) Cluster Offload Failure; node stuck in OFFLOADING state
[ https://issues.apache.org/jira/browse/NIFI-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846766#comment-17846766 ] Paul Grey commented on NIFI-13249: -- Restart of node cleared condition; node was able to rejoin cluster. > Cluster Offload Failure; node stuck in OFFLOADING state > --- > > Key: NIFI-13249 > URL: https://issues.apache.org/jira/browse/NIFI-13249 > Project: Apache NiFi > Issue Type: Bug >Reporter: Paul Grey >Priority: Minor > Attachments: node3.excerpt.nifi-app_2024-05-15_17.0.log > > > While testing 2.0.0-M3, performed DISCONNECT / OFFLOAD operations on nodes in > a three node dev cluster. During one iteration, after DISCONNECT completed, > performed offload operation. Offload never completed. In app log, found > this log entry: > 2024-05-15 17:33:45,248 WARN [Offload Flow Files from Node] > o.a.n.c.c.node.NodeClusterCoordinator Attempted to finish node offload for > localhost:9443 but node is not in the offloading state, it is currently > DISCONNECTED. > Node remained in state OFFLOADING; no UI operation available for nodes in > this state. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13249) Cluster Offload Failure; node stuck in OFFLOADING state
Paul Grey created NIFI-13249: Summary: Cluster Offload Failure; node stuck in OFFLOADING state Key: NIFI-13249 URL: https://issues.apache.org/jira/browse/NIFI-13249 Project: Apache NiFi Issue Type: Bug Reporter: Paul Grey Attachments: node3.excerpt.nifi-app_2024-05-15_17.0.log While testing 2.0.0-M3, performed DISCONNECT / OFFLOAD operations on nodes in a three node dev cluster. During one iteration, after DISCONNECT completed, performed offload operation. Offload never completed. In app log, found this log entry: 2024-05-15 17:33:45,248 WARN [Offload Flow Files from Node] o.a.n.c.c.node.NodeClusterCoordinator Attempted to finish node offload for localhost:9443 but node is not in the offloading state, it is currently DISCONNECTED. Node remained in state OFFLOADING; no UI operation available for nodes in this state. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13249) Cluster Offload Failure; node stuck in OFFLOADING state
[ https://issues.apache.org/jira/browse/NIFI-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Grey updated NIFI-13249: - Attachment: node3.excerpt.nifi-app_2024-05-15_17.0.log > Cluster Offload Failure; node stuck in OFFLOADING state > --- > > Key: NIFI-13249 > URL: https://issues.apache.org/jira/browse/NIFI-13249 > Project: Apache NiFi > Issue Type: Bug >Reporter: Paul Grey >Priority: Minor > Attachments: node3.excerpt.nifi-app_2024-05-15_17.0.log > > > While testing 2.0.0-M3, performed DISCONNECT / OFFLOAD operations on nodes in > a three node dev cluster. During one iteration, after DISCONNECT completed, > performed offload operation. Offload never completed. In app log, found > this log entry: > 2024-05-15 17:33:45,248 WARN [Offload Flow Files from Node] > o.a.n.c.c.node.NodeClusterCoordinator Attempted to finish node offload for > localhost:9443 but node is not in the offloading state, it is currently > DISCONNECTED. > Node remained in state OFFLOADING; no UI operation available for nodes in > this state. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13138 - Add extensions name and description in NiFi Registry [nifi]
pvillard31 commented on PR #8740: URL: https://github.com/apache/nifi/pull/8740#issuecomment-2113517903 Thanks @exceptionfactory - added the number of components per type ![Screenshot 2024-05-15 at 23 51 56](https://github.com/apache/nifi/assets/11541012/bc8b96b8-56e0-434f-9b8f-ce6d313ba91a) ![Screenshot 2024-05-15 at 23 51 51](https://github.com/apache/nifi/assets/11541012/bd92a082-9c6b-46df-968f-51b0dcf29d7a) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13126: Add Impala DB Adapter [nifi]
mattyb149 commented on PR #8728: URL: https://github.com/apache/nifi/pull/8728#issuecomment-2113419404 Without Impala dependencies I don't see why it can't go into the standard NAR, especially since `PhoenixDatabaseAdapter` is a precedent. I think there are a number of people in the community (including myself) that can maintain this. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13248) Add Flow Analysis report menu
Shane Ardell created NIFI-13248: --- Summary: Add Flow Analysis report menu Key: NIFI-13248 URL: https://issues.apache.org/jira/browse/NIFI-13248 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Shane Ardell Assignee: Shane Ardell In keeping feature parity with the new ui, we should recreate the work done here: https://github.com/apache/nifi/pull/8273 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
scottyaslan commented on code in PR #8804: URL: https://github.com/apache/nifi/pull/8804#discussion_r1602192448 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.html: ## @@ -23,37 +23,43 @@ } @else { @if (policyComponentState$ | async; as policyComponentState) { @if (flowConfiguration$ | async; as flowConfiguration) { - + - - -@switch (accessPolicyState.policyStatus) { -@case (PolicyStatus.NotFound) { -No policy for the specified resource. -@if (flowConfiguration.supportsConfigurableAuthorizer) { -Create a new policy. +@if ( +accessPolicyState.policyStatus === PolicyStatus.NotFound || +accessPolicyState.policyStatus === PolicyStatus.Inherited || +accessPolicyState.policyStatus === PolicyStatus.Forbidden +) { + + +@switch (accessPolicyState.policyStatus) { +@case (PolicyStatus.NotFound) { +No policy for the specified resource. Review Comment: Good idea! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13236) Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2
[ https://issues.apache.org/jira/browse/NIFI-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13236: --- Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2 > - > > Key: NIFI-13236 > URL: https://issues.apache.org/jira/browse/NIFI-13236 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 2.0.0-M2 >Reporter: Matt Gilman >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M4 > > Time Spent: 0.5h > Remaining Estimate: 0h > > When attempting to view or download content the flowfile's filename (from the > filename attribute) is used as the proposed downloaded filename. These > endpoints support gzip encoding. If the filename contains characters are > invalid VCHAR based on RFC9110, the endpoint fails with a connection error. > The log contains the following exception. > > {noformat} > 2024-05-14 14:52:40,290 ERROR [NiFi Web Server-138] > o.g.j.server.ServerRuntime$Responder An I/O error has occurred while writing > a response message entity to the container output stream. > org.glassfish.jersey.server.internal.process.MappableException: > java.io.IOException: > org.eclipse.jetty.http2.hpack.HpackException$SessionException: Could not > hpack encode HTTP/2.0{s=200,h=11,cl=-1} > at > org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:67) > at > org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139) > at > org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116) > at > org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:678) > at > org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:387) > at > org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:377) > at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:266) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244) > at org.glassfish.jersey.internal.Errors.process(Errors.java:292) > at org.glassfish.jersey.internal.Errors.process(Errors.java:274) > at org.glassfish.jersey.internal.Errors.process(Errors.java:244) > at > org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266) > at > org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:242) > at > org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:697) > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394) > at > org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205) > at > org.eclipse.jetty.ee10.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1379) > at > org.eclipse.jetty.ee10.servlet.ServletHolder.handle(ServletHolder.java:736) > at > org.eclipse.jetty.ee10.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1614) > at > org.springframework.security.web.FilterChainProxy.lambda$doFilterInternal$3(FilterChainProxy.java:231) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:365) > at > org.springframework.security.web.access.intercept.AuthorizationFilter.doFilter(AuthorizationFilter.java:100) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:126) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:120) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.apache.nifi.web.security.log.AuthenticationUserFilter.doFilterInternal(AuthenticationUserFilter.java:57) > at > org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at >
[jira] [Commented] (NIFI-13236) Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2
[ https://issues.apache.org/jira/browse/NIFI-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846741#comment-17846741 ] ASF subversion and git services commented on NIFI-13236: Commit 2a0858645069314c836afe37769fa6ce3be38118 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2a08586450 ] NIFI-13236 Corrected Content-Disposition Filename for Downloads (#8840) - Added encoding method for handling filenames with non-ASCII characters This closes #8840 > Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2 > - > > Key: NIFI-13236 > URL: https://issues.apache.org/jira/browse/NIFI-13236 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 2.0.0-M2 >Reporter: Matt Gilman >Assignee: David Handermann >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > When attempting to view or download content the flowfile's filename (from the > filename attribute) is used as the proposed downloaded filename. These > endpoints support gzip encoding. If the filename contains characters are > invalid VCHAR based on RFC9110, the endpoint fails with a connection error. > The log contains the following exception. > > {noformat} > 2024-05-14 14:52:40,290 ERROR [NiFi Web Server-138] > o.g.j.server.ServerRuntime$Responder An I/O error has occurred while writing > a response message entity to the container output stream. > org.glassfish.jersey.server.internal.process.MappableException: > java.io.IOException: > org.eclipse.jetty.http2.hpack.HpackException$SessionException: Could not > hpack encode HTTP/2.0{s=200,h=11,cl=-1} > at > org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:67) > at > org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139) > at > org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116) > at > org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:678) > at > org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:387) > at > org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:377) > at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:266) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244) > at org.glassfish.jersey.internal.Errors.process(Errors.java:292) > at org.glassfish.jersey.internal.Errors.process(Errors.java:274) > at org.glassfish.jersey.internal.Errors.process(Errors.java:244) > at > org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266) > at > org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:242) > at > org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:697) > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394) > at > org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205) > at > org.eclipse.jetty.ee10.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1379) > at > org.eclipse.jetty.ee10.servlet.ServletHolder.handle(ServletHolder.java:736) > at > org.eclipse.jetty.ee10.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1614) > at > org.springframework.security.web.FilterChainProxy.lambda$doFilterInternal$3(FilterChainProxy.java:231) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:365) > at > org.springframework.security.web.access.intercept.AuthorizationFilter.doFilter(AuthorizationFilter.java:100) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:126) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:120) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at >
Re: [PR] NIFI-13236 Correct Content-Disposition Filename for Downloads [nifi]
mcgilman merged PR #8840: URL: https://github.com/apache/nifi/pull/8840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) *** Support Processor Details dialog *** Support Connection Details dialog * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About (NIFI-13094) * Show Upstream/Downstream * Align (NIFI-13162) * Replay last event (NIFI-12445) * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version (NIFI-13034) * Consider PG permissions in Toolbox (NIFI-12683) * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Configure Label (NIFI-13081) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Status Bar ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History (NIFI-13047) ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification (NIFI-13247) * Terminate Threads (context menu) (NIFI-13068) * Enable/Disable (context menu/operate panel) (NIFI-13078) * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062) * Download Flow (NIFI-13029) * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color (context menu/operate panel) (NIFI-13226) * Move to Front (NIFI-13044) * Copy/Paste (context menu/operate panel) (NIFI-13059) * Add/Update Info Icons in dialogs throughout the application (NIFI-13092) * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling (NIFI-13104) * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer (NIFI-13100) ** Parameter Contexts
[jira] [Created] (NIFI-13247) Property Verification
Rob Fellows created NIFI-13247: -- Summary: Property Verification Key: NIFI-13247 URL: https://issues.apache.org/jira/browse/NIFI-13247 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13236 Correct Content-Disposition Filename for Downloads [nifi]
mcgilman commented on PR #8840: URL: https://github.com/apache/nifi/pull/8840#issuecomment-2113241551 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13241) [BUG] Escape button does not close extension creation dialogs
[ https://issues.apache.org/jira/browse/NIFI-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13241: --- Resolution: Fixed Status: Resolved (was: Patch Available) > [BUG] Escape button does not close extension creation dialogs > - > > Key: NIFI-13241 > URL: https://issues.apache.org/jira/browse/NIFI-13241 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > This issue affects all creation dialogs that set focus to an input. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13241) [BUG] Escape button does not close extension creation dialogs
[ https://issues.apache.org/jira/browse/NIFI-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846734#comment-17846734 ] ASF subversion and git services commented on NIFI-13241: Commit 0ef121493ace4acabcd4f05346f1c2dd2e1cc129 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0ef121493a ] [NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it (#8833) * [NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it * extend CloseOnEscapeDialog in a few more instances This closes #8833 > [BUG] Escape button does not close extension creation dialogs > - > > Key: NIFI-13241 > URL: https://issues.apache.org/jira/browse/NIFI-13241 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > This issue affects all creation dialogs that set focus to an input. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it [nifi]
scottyaslan merged PR #8833: URL: https://github.com/apache/nifi/pull/8833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13243) Cancel Move connection does not return connection to previous location
[ https://issues.apache.org/jira/browse/NIFI-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13243: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Cancel Move connection does not return connection to previous location > -- > > Key: NIFI-13243 > URL: https://issues.apache.org/jira/browse/NIFI-13243 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Attachments: image-2024-05-15-10-12-48-847.png > > Time Spent: 20m > Remaining Estimate: 0h > > When closing the move connection dialog with the 'Esc' key the connection is > not returned to it's original location > > !image-2024-05-15-10-12-48-847.png|width=624,height=277! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13243) Cancel Move connection does not return connection to previous location
[ https://issues.apache.org/jira/browse/NIFI-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846733#comment-17846733 ] ASF subversion and git services commented on NIFI-13243: Commit c794943c5bfff5213ce72635a91c9b7f32afa378 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c794943c5b ] [NIFI-13243] - support cancel response in CloseOnEscapeDialog (#8838) This closes #8838 > Cancel Move connection does not return connection to previous location > -- > > Key: NIFI-13243 > URL: https://issues.apache.org/jira/browse/NIFI-13243 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Attachments: image-2024-05-15-10-12-48-847.png > > Time Spent: 20m > Remaining Estimate: 0h > > When closing the move connection dialog with the 'Esc' key the connection is > not returned to it's original location > > !image-2024-05-15-10-12-48-847.png|width=624,height=277! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13243] - support cancel response in CloseOnEscapeDialog [nifi]
scottyaslan merged PR #8838: URL: https://github.com/apache/nifi/pull/8838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13233] - Fix for overflow issues on change version dialog [nifi]
scottyaslan commented on code in PR #8837: URL: https://github.com/apache/nifi/pull/8837#discussion_r1602080460 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html: ## @@ -22,32 +22,48 @@ - + Registry -{{ versionControlInformation.registryName }} + +{{ versionControlInformation.registryName }} + Bucket -{{ versionControlInformation.bucketName }} + +{{ versionControlInformation.bucketName }} + - + Review Comment: and then ```suggestion ``` here. ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html: ## @@ -22,32 +22,48 @@ - + Review Comment: We had this issue in the create/edit connection templates. There is no padding in between the 'columns': https://github.com/apache/nifi/assets/6797571/0b68fab5-0b56-41c4-8f5d-f519efef4d08;> The fix was to use `w-1/2 pr-2` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12670) JoltTransform processors incorrectly encode/decode text in the Jolt Specification
[ https://issues.apache.org/jira/browse/NIFI-12670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey updated NIFI-12670: -- Affects Version/s: 1.26.0 2.0.0-M3 > JoltTransform processors incorrectly encode/decode text in the Jolt > Specification > - > > Key: NIFI-12670 > URL: https://issues.apache.org/jira/browse/NIFI-12670 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration, Extensions >Affects Versions: 2.0.0-M1, 1.24.0, 1.25.0, 2.0.0-M2, 1.26.0, 2.0.0-M3 > Environment: JVM with non-UTF-8 default encoding (e.g. default > Windows installation) >Reporter: René Zeidler >Assignee: Jim Steinebrey >Priority: Minor > Labels: encoding, jolt, json, utf8, windows > Attachments: Jolt_Transform_Encoding_Bug.json, > Jolt_Transform_Encoding_Bug_M2.json, image-2024-01-25-11-01-15-405.png, > image-2024-01-25-11-59-56-662.png, image-2024-01-25-12-00-09-544.png > > > h2. Environment > This issue affects environments where the JVM default encoding is not > {{{}UTF-8{}}}. Standard Java installations on Windows are affected, as they > usually use the default encoding {{{}windows-1252{}}}. To reproduce the issue > on Linux, change the default encoding to {{windows-1252}} by adding the > following line to your {{{}bootstrap.conf{}}}: > {quote}{{java.arg.21=-Dfile.encoding=windows-1252}} > {quote} > h2. Summary > The Jolt Specification of both the JoltTransformJSON and JoltTransformRecord > processors is read interally using the system default encoding, even though > it is always stored in UTF-8. This causes non-ASCII characters to be garbled > in the Jolt Specification, resulting in incorrect transformations (missing > data or garbled keys). > h2. Steps to reproduce > # Make sure NiFi runs with a non-UTF-8 default encoding, see "Environment" > # Create a GenerateFlowFile processor with the following content: > {quote}{ > "regularString": "string with only ASCII characters", > "umlautString": "string with non-ASCII characters: ÄÖÜäöüßéèóò", > "keyWithÜmlaut": "any string" > } > {quote} > # Connect the processor to a JoltTransformJSON and/or JoltTransformRecord > processor. > (If using the record based processor, use a default JsonTreeReader and > JsonRecordSetWriter. The record reader/writer don't affect this bug.) > Set the Jolt Specification to: > {quote}[ > { > "operation": "shift", > "spec": { > "regularString": "Remapped to Umlaut ÄÖÜ", > "umlautString": "Umlaut String", > "keyWithÜmlaut": "Key with Umlaut" > } > } > ] > {quote} > # Connect the outputs of the Jolt processor(s) to funnels to be able to > observe the result in the queue. > # Start the Jolt processor(s) and run the GenerateFlowFile processor once. > The flow should look similar to this: > !image-2024-01-25-11-01-15-405.png! > I also attached a JSON export of the example flow. > # Observe the content of the resulting FlowFile(s) in the queue. > h3. Expected Result > !image-2024-01-25-12-00-09-544.png! > h3. Actual Result > !image-2024-01-25-11-59-56-662.png! > * Remapped key containing non-ASCII characters is garbled, since the key > value originated from the Jolt Specification. > * The key "{{{}keyWithÜmlaut{}}}" could not be matched at all, since it > contains non-ASCII characters, resulting in missing data in the output. > h2. Root Cause Analysis > Both processors use the > {{[readTransform|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-jolt-bundle/nifi-jolt-processors/src/main/java/org/apache/nifi/processors/jolt/AbstractJoltTransform.java#L242-L249]}} > method of {{AbstractJoltTransform}} to read the Jolt Specification property. > This method uses an > [{{InputStreamReader}}|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/InputStreamReader.html] > without specifying an encoding, which then defaults to the default charset > of the environment. Text properties are [always encoded in > UTF-8|https://github.com/apache/nifi/blob/89836f32d017d77972a4de09c4e864b0e11899a8/nifi-api/src/main/java/org/apache/nifi/components/resource/StandardResourceReferenceFactory.java#L111]. > When the default charset is not UTF-8, this results in UTF-8 bytes to be > interpreted in a different encoding when converting to a string, resulting in > a garbled Jolt Specification being used. > h2. Workaround > This issue is not present when any attribute expression language is present > in the Jolt Specification. Simply adding {{${literal('')}}} anywhere in the > Jolt Specification works around this issue. > This happens because [a different code path is >
[jira] [Assigned] (NIFI-12670) JoltTransform processors incorrectly encode/decode text in the Jolt Specification
[ https://issues.apache.org/jira/browse/NIFI-12670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey reassigned NIFI-12670: - Assignee: Jim Steinebrey > JoltTransform processors incorrectly encode/decode text in the Jolt > Specification > - > > Key: NIFI-12670 > URL: https://issues.apache.org/jira/browse/NIFI-12670 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration, Extensions >Affects Versions: 2.0.0-M1, 1.24.0, 1.25.0, 2.0.0-M2 > Environment: JVM with non-UTF-8 default encoding (e.g. default > Windows installation) >Reporter: René Zeidler >Assignee: Jim Steinebrey >Priority: Minor > Labels: encoding, jolt, json, utf8, windows > Attachments: Jolt_Transform_Encoding_Bug.json, > Jolt_Transform_Encoding_Bug_M2.json, image-2024-01-25-11-01-15-405.png, > image-2024-01-25-11-59-56-662.png, image-2024-01-25-12-00-09-544.png > > > h2. Environment > This issue affects environments where the JVM default encoding is not > {{{}UTF-8{}}}. Standard Java installations on Windows are affected, as they > usually use the default encoding {{{}windows-1252{}}}. To reproduce the issue > on Linux, change the default encoding to {{windows-1252}} by adding the > following line to your {{{}bootstrap.conf{}}}: > {quote}{{java.arg.21=-Dfile.encoding=windows-1252}} > {quote} > h2. Summary > The Jolt Specification of both the JoltTransformJSON and JoltTransformRecord > processors is read interally using the system default encoding, even though > it is always stored in UTF-8. This causes non-ASCII characters to be garbled > in the Jolt Specification, resulting in incorrect transformations (missing > data or garbled keys). > h2. Steps to reproduce > # Make sure NiFi runs with a non-UTF-8 default encoding, see "Environment" > # Create a GenerateFlowFile processor with the following content: > {quote}{ > "regularString": "string with only ASCII characters", > "umlautString": "string with non-ASCII characters: ÄÖÜäöüßéèóò", > "keyWithÜmlaut": "any string" > } > {quote} > # Connect the processor to a JoltTransformJSON and/or JoltTransformRecord > processor. > (If using the record based processor, use a default JsonTreeReader and > JsonRecordSetWriter. The record reader/writer don't affect this bug.) > Set the Jolt Specification to: > {quote}[ > { > "operation": "shift", > "spec": { > "regularString": "Remapped to Umlaut ÄÖÜ", > "umlautString": "Umlaut String", > "keyWithÜmlaut": "Key with Umlaut" > } > } > ] > {quote} > # Connect the outputs of the Jolt processor(s) to funnels to be able to > observe the result in the queue. > # Start the Jolt processor(s) and run the GenerateFlowFile processor once. > The flow should look similar to this: > !image-2024-01-25-11-01-15-405.png! > I also attached a JSON export of the example flow. > # Observe the content of the resulting FlowFile(s) in the queue. > h3. Expected Result > !image-2024-01-25-12-00-09-544.png! > h3. Actual Result > !image-2024-01-25-11-59-56-662.png! > * Remapped key containing non-ASCII characters is garbled, since the key > value originated from the Jolt Specification. > * The key "{{{}keyWithÜmlaut{}}}" could not be matched at all, since it > contains non-ASCII characters, resulting in missing data in the output. > h2. Root Cause Analysis > Both processors use the > {{[readTransform|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-jolt-bundle/nifi-jolt-processors/src/main/java/org/apache/nifi/processors/jolt/AbstractJoltTransform.java#L242-L249]}} > method of {{AbstractJoltTransform}} to read the Jolt Specification property. > This method uses an > [{{InputStreamReader}}|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/InputStreamReader.html] > without specifying an encoding, which then defaults to the default charset > of the environment. Text properties are [always encoded in > UTF-8|https://github.com/apache/nifi/blob/89836f32d017d77972a4de09c4e864b0e11899a8/nifi-api/src/main/java/org/apache/nifi/components/resource/StandardResourceReferenceFactory.java#L111]. > When the default charset is not UTF-8, this results in UTF-8 bytes to be > interpreted in a different encoding when converting to a string, resulting in > a garbled Jolt Specification being used. > h2. Workaround > This issue is not present when any attribute expression language is present > in the Jolt Specification. Simply adding {{${literal('')}}} anywhere in the > Jolt Specification works around this issue. > This happens because [a different code path is >
[jira] [Updated] (NIFI-13236) Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2
[ https://issues.apache.org/jira/browse/NIFI-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13236: Affects Version/s: 2.0.0-M2 Status: Patch Available (was: Open) > Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2 > - > > Key: NIFI-13236 > URL: https://issues.apache.org/jira/browse/NIFI-13236 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 2.0.0-M2 >Reporter: Matt Gilman >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When attempting to view or download content the flowfile's filename (from the > filename attribute) is used as the proposed downloaded filename. These > endpoints support gzip encoding. If the filename contains characters are > invalid VCHAR based on RFC9110, the endpoint fails with a connection error. > The log contains the following exception. > > {noformat} > 2024-05-14 14:52:40,290 ERROR [NiFi Web Server-138] > o.g.j.server.ServerRuntime$Responder An I/O error has occurred while writing > a response message entity to the container output stream. > org.glassfish.jersey.server.internal.process.MappableException: > java.io.IOException: > org.eclipse.jetty.http2.hpack.HpackException$SessionException: Could not > hpack encode HTTP/2.0{s=200,h=11,cl=-1} > at > org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:67) > at > org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139) > at > org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116) > at > org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:678) > at > org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:387) > at > org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:377) > at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:266) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244) > at org.glassfish.jersey.internal.Errors.process(Errors.java:292) > at org.glassfish.jersey.internal.Errors.process(Errors.java:274) > at org.glassfish.jersey.internal.Errors.process(Errors.java:244) > at > org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266) > at > org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:242) > at > org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:697) > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394) > at > org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205) > at > org.eclipse.jetty.ee10.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1379) > at > org.eclipse.jetty.ee10.servlet.ServletHolder.handle(ServletHolder.java:736) > at > org.eclipse.jetty.ee10.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1614) > at > org.springframework.security.web.FilterChainProxy.lambda$doFilterInternal$3(FilterChainProxy.java:231) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:365) > at > org.springframework.security.web.access.intercept.AuthorizationFilter.doFilter(AuthorizationFilter.java:100) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:126) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:120) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.apache.nifi.web.security.log.AuthenticationUserFilter.doFilterInternal(AuthenticationUserFilter.java:57) > at > org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at >
[PR] NIFI-13236 Correct Content-Disposition Filename for Downloads [nifi]
exceptionfactory opened a new pull request, #8840: URL: https://github.com/apache/nifi/pull/8840 # Summary [NIFI-13236](https://issues.apache.org/jira/browse/NIFI-13236) Corrects filename encoding for the HTTP `Content-Disposition` header when downloading files from FlowFile Queues or Provenance event references over HTTP/2. The HTTP/2 protocol implementation in Jetty 12 includes character encoding validation for HTTP response headers, resulting in an `IllegalArgumentException` when attempting to write invalid characters. [RFC 9110](https://www.rfc-editor.org/rfc/rfc9110.html) requires that HTTP header values consist of specific characters in the ASCII character set, so characters outside of the set must be encoded. The Spring Framework [ContentDisposition](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/ContentDisposition.html) supports parsing and encoding filename values according to RFC standards. Replacing existing `Content-Disposition` header formatting with encoded formatting based on the Spring Framework class enables support for extended character sets, such as UTF-8. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13236) Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2
[ https://issues.apache.org/jira/browse/NIFI-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13236: Summary: Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2 (was: Issue when viewing and downloading content) > Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2 > - > > Key: NIFI-13236 > URL: https://issues.apache.org/jira/browse/NIFI-13236 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: David Handermann >Priority: Major > > When attempting to view or download content the flowfile's filename (from the > filename attribute) is used as the proposed downloaded filename. These > endpoints support gzip encoding. If the filename contains characters are > invalid VCHAR based on RFC9110, the endpoint fails with a connection error. > The log contains the following exception. > > {noformat} > 2024-05-14 14:52:40,290 ERROR [NiFi Web Server-138] > o.g.j.server.ServerRuntime$Responder An I/O error has occurred while writing > a response message entity to the container output stream. > org.glassfish.jersey.server.internal.process.MappableException: > java.io.IOException: > org.eclipse.jetty.http2.hpack.HpackException$SessionException: Could not > hpack encode HTTP/2.0{s=200,h=11,cl=-1} > at > org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:67) > at > org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139) > at > org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116) > at > org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:678) > at > org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:387) > at > org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:377) > at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:266) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244) > at org.glassfish.jersey.internal.Errors.process(Errors.java:292) > at org.glassfish.jersey.internal.Errors.process(Errors.java:274) > at org.glassfish.jersey.internal.Errors.process(Errors.java:244) > at > org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266) > at > org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:242) > at > org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:697) > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394) > at > org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205) > at > org.eclipse.jetty.ee10.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1379) > at > org.eclipse.jetty.ee10.servlet.ServletHolder.handle(ServletHolder.java:736) > at > org.eclipse.jetty.ee10.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1614) > at > org.springframework.security.web.FilterChainProxy.lambda$doFilterInternal$3(FilterChainProxy.java:231) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:365) > at > org.springframework.security.web.access.intercept.AuthorizationFilter.doFilter(AuthorizationFilter.java:100) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:126) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:120) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.apache.nifi.web.security.log.AuthenticationUserFilter.doFilterInternal(AuthenticationUserFilter.java:57) > at > org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at >
[jira] [Updated] (NIFI-10752) Update Couchbase client to 3.x
[ https://issues.apache.org/jira/browse/NIFI-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-10752: Attachment: Couchbase_Testing.json > Update Couchbase client to 3.x > -- > > Key: NIFI-10752 > URL: https://issues.apache.org/jira/browse/NIFI-10752 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Matt Burgess >Priority: Major > Attachments: Couchbase_Testing.json > > Time Spent: 50m > Remaining Estimate: 0h > > Update com.couchbase.client.java-client to latest 3.x to remediate CVEs in > the program > Here are the release notes: [SDK Release Notes | Couchbase > Docs|https://docs.couchbase.com/java-sdk/current/project-docs/sdk-release-notes.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10752) Update Couchbase client to 3.x
[ https://issues.apache.org/jira/browse/NIFI-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-10752: Affects Version/s: (was: 1.18.0) Status: Patch Available (was: In Progress) > Update Couchbase client to 3.x > -- > > Key: NIFI-10752 > URL: https://issues.apache.org/jira/browse/NIFI-10752 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Matt Burgess >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Update com.couchbase.client.java-client to latest 3.x to remediate CVEs in > the program > Here are the release notes: [SDK Release Notes | Couchbase > Docs|https://docs.couchbase.com/java-sdk/current/project-docs/sdk-release-notes.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-10752: Add Couchbase 3.x components [nifi]
mattyb149 opened a new pull request, #8839: URL: https://github.com/apache/nifi/pull/8839 # Summary [NIFI-10752](https://issues.apache.org/jira/browse/NIFI-10752) This PR adds the Couchbase components back into NiFi, but using the Couchbase 3.x SDK and added to the assembly via a profile `include-couchbase`. The Jira has a sample flow definition attached. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13243) Cancel Move connection does not return connection to previous location
[ https://issues.apache.org/jira/browse/NIFI-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13243: --- Status: Patch Available (was: In Progress) > Cancel Move connection does not return connection to previous location > -- > > Key: NIFI-13243 > URL: https://issues.apache.org/jira/browse/NIFI-13243 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Attachments: image-2024-05-15-10-12-48-847.png > > Time Spent: 10m > Remaining Estimate: 0h > > When closing the move connection dialog with the 'Esc' key the connection is > not returned to it's original location > > !image-2024-05-15-10-12-48-847.png|width=624,height=277! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13243] - support cancel response in CloseOnEscapeDialog [nifi]
rfellows opened a new pull request, #8838: URL: https://github.com/apache/nifi/pull/8838 [NIFI-13243](https://issues.apache.org/jira/browse/NIFI-13243) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13243) Cancel Move connection does not return connection to previous location
[ https://issues.apache.org/jira/browse/NIFI-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-13243: -- Assignee: Rob Fellows > Cancel Move connection does not return connection to previous location > -- > > Key: NIFI-13243 > URL: https://issues.apache.org/jira/browse/NIFI-13243 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Attachments: image-2024-05-15-10-12-48-847.png > > > When closing the move connection dialog with the 'Esc' key the connection is > not returned to it's original location > > !image-2024-05-15-10-12-48-847.png|width=624,height=277! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13233) Change version dialog issues
[ https://issues.apache.org/jira/browse/NIFI-13233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13233: --- Status: Patch Available (was: In Progress) > Change version dialog issues > > > Key: NIFI-13233 > URL: https://issues.apache.org/jira/browse/NIFI-13233 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-14 at 1.21.56 PM.png > > Time Spent: 10m > Remaining Estimate: 0h > > There are some text overflow issues and the version column does not have > enough width for the new git backed version name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13233] - Fix for overflow issues on change version dialog [nifi]
rfellows opened a new pull request, #8837: URL: https://github.com/apache/nifi/pull/8837 [NIFI-13233](https://issues.apache.org/jira/browse/NIFI-13233) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691: URL: https://github.com/apache/nifi/pull/8691#discussion_r1601826244 ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.network; + +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.annotation.behavior.WritesAttribute; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.processor.AbstractProcessor; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.processors.network.util.PCAP; +import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface; +import org.apache.nifi.processors.network.util.PCAP.Packet; + +import java.io.ByteArrayOutputStream; +import java.util.ArrayList; +import java.util.List; +import java.util.Set; + +@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark", "TShark"}) +@CapabilityDescription("Splits a pcap file into multiple pcap files based on a maximum size.") +@WritesAttribute(attribute = SplitPCAP.ERROR_REASON, description = "The reason the flowfile was sent to the failure relationship.") + +public class SplitPCAP extends AbstractProcessor { + +protected static final String ERROR_REASON = "ERROR_REASON"; + +public static final PropertyDescriptor PCAP_MAX_SIZE = new PropertyDescriptor +.Builder().name("PCAP_MAX_SIZE") +.displayName("PCAP max size (bytes)") +.description("Maximum size of the output pcap file in bytes.") +.required(true) +.addValidator(StandardValidators.INTEGER_VALIDATOR) +.build(); + +public static final Relationship REL_SUCCESS = new Relationship.Builder() +.name("success") +.description("output flowfiles") +.build(); + +public static final Relationship REL_FAILURE = new Relationship.Builder() +.name("failure") +.description("Flowfiles not parseable as pcap.") +.build(); + +private static final List DESCRIPTORS = List.of(PCAP_MAX_SIZE); + +private static final Set RELATIONSHIPS = Set.of(REL_SUCCESS, REL_FAILURE); + +@Override +public Set getRelationships() { +return RELATIONSHIPS; +} + +@Override +public final List getSupportedPropertyDescriptors() { +return DESCRIPTORS; +} + +/** + * This method is called when a trigger event occurs in the processor. + * It processes the incoming flow file, splits it into smaller pcap files based on the maximum size, + * and transfers the split pcap files to the success relationship. + * If the flow file is empty or not parseable, it is transferred to the failure relationship. + * + * @param context the process context + * @param session the process session + */ +@Override +public void onTrigger(final ProcessContext context, final ProcessSession session) { +FlowFile flowFile = session.get(); +if (flowFile == null) { +return; +} + +int pcapMaxSize = context.getProperty(PCAP_MAX_SIZE.getName()).asInteger(); + +final ByteArrayOutputStream contentBytes = new ByteArrayOutputStream(); +session.exportTo(flowFile, contentBytes); +final byte[] contentByteArray = contentBytes.toByteArray(); + +if(contentByteArray.length == 0){ +session.putAttribute(flowFile,ERROR_REASON, "PCAP file empty."); +session.transfer(flowFile, REL_FAILURE); +return; +} + +PCAP parsedPcap; +PCAP templatePcap; + +// Parse the pcap file and create a template pcap object to borrow the header from. +try{ +parsedPcap = new PCAP(new ByteBufferInterface(contentByteArray)); + +//
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691: URL: https://github.com/apache/nifi/pull/8691#discussion_r1601806706 ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.network; + +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.annotation.behavior.WritesAttribute; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.processor.AbstractProcessor; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.processors.network.util.PCAP; +import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface; +import org.apache.nifi.processors.network.util.PCAP.Packet; + +import java.io.ByteArrayOutputStream; +import java.util.ArrayList; +import java.util.List; +import java.util.Set; + +@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark", "TShark"}) +@CapabilityDescription("Splits a pcap file into multiple pcap files based on a maximum size.") +@WritesAttribute(attribute = SplitPCAP.ERROR_REASON, description = "The reason the flowfile was sent to the failure relationship.") + +public class SplitPCAP extends AbstractProcessor { + +protected static final String ERROR_REASON = "ERROR_REASON"; + +public static final PropertyDescriptor PCAP_MAX_SIZE = new PropertyDescriptor +.Builder().name("PCAP_MAX_SIZE") +.displayName("PCAP max size (bytes)") +.description("Maximum size of the output pcap file in bytes.") +.required(true) +.addValidator(StandardValidators.INTEGER_VALIDATOR) Review Comment: It is not enough to only have an integer as a user can specify 0 or a negative number which in this case would be pointless. In order to prevent that, use a validator that will ensure the number is greater than 0. ```suggestion .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691: URL: https://github.com/apache/nifi/pull/8691#discussion_r1601629943 ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/util/PCAP.java: ## @@ -0,0 +1,457 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project + +// Permission is hereby granted, free of charge, to any person obtaining a copy +// of this software and associated documentation files (the "Software"), to deal +// in the Software without restriction, including without limitation the rights +// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the Software is +// furnished to do so, subject to the following conditions: + +// The above copyright notice and this permission notice shall be included in all +// copies or substantial portions of the Software. + +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +// SOFTWARE. + +package org.apache.nifi.processors.network.util; + +import java.nio.ByteBuffer; +import java.nio.ByteOrder; + +import org.apache.commons.lang3.EnumUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ListIterator; +import java.util.ArrayList; +import java.util.List; + +/** + * PCAP (named after libpcap / winpcap) is a popular format for saving + * network traffic grabbed by network sniffers. It is typically + * produced by tools like [tcpdump](https://www.tcpdump.org/) or + * [Wireshark](https://www.wireshark.org/). + * + * @see https://wiki.wireshark.org/Development/LibpcapFileFormat;>Source + */ +public class PCAP { +public ByteBufferInterface io; Review Comment: ```suggestion private ByteBufferInterface io; ``` ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/util/PCAP.java: ## @@ -0,0 +1,457 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project + +// Permission is hereby granted, free of charge, to any person obtaining a copy +// of this software and associated documentation files (the "Software"), to deal +// in the Software without restriction, including without limitation the rights +// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the Software is +// furnished to do so, subject to the following conditions: + +// The above copyright notice and this permission notice shall be included in all +// copies or substantial portions of the Software. + +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +// SOFTWARE. + +package org.apache.nifi.processors.network.util; + +import java.nio.ByteBuffer; +import java.nio.ByteOrder; + +import org.apache.commons.lang3.EnumUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ListIterator; +import java.util.ArrayList; +import java.util.List; + +/** + * PCAP (named after libpcap / winpcap) is a popular format for saving + * network traffic grabbed by network sniffers. It is typically + * produced by tools like [tcpdump](https://www.tcpdump.org/) or + * [Wireshark](https://www.wireshark.org/). + * + * @see https://wiki.wireshark.org/Development/LibpcapFileFormat;>Source + */ +public class PCAP { +public ByteBufferInterface io; + +public PCAP(ByteBufferInterface io){ +this(io, null, null); +} + +public PCAP(ByteBufferInterface io, Object parent, PCAP root) { + +this.parent = parent; +this.root = root == null ? this : root; +this.io = io; +read(); +} + +public PCAP(Header hdr, List packets) { +this.hdr = hdr; +this.packets = packets; +} + +public byte[] readBytesFull() { + +int headerBufferSize = 20 + this.hdr().magicNumber().length; +ByteBuffer headerBuffer = ByteBuffer.allocate(headerBufferSize); +headerBuffer.order(ByteOrder.LITTLE_ENDIAN); + +headerBuffer.put(this.hdr().magicNumber()); +
[jira] [Updated] (NIFI-13243) Cancel Move connection does not return connection to previous location
[ https://issues.apache.org/jira/browse/NIFI-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13243: --- Description: When closing the move connection dialog with the 'Esc' key the connection is not returned to it's original location !image-2024-05-15-10-12-48-847.png|width=624,height=277! was:!image-2024-05-15-10-12-48-847.png|width=2014,height=894! > Cancel Move connection does not return connection to previous location > -- > > Key: NIFI-13243 > URL: https://issues.apache.org/jira/browse/NIFI-13243 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > Attachments: image-2024-05-15-10-12-48-847.png > > > When closing the move connection dialog with the 'Esc' key the connection is > not returned to it's original location > > !image-2024-05-15-10-12-48-847.png|width=624,height=277! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13243) Cancel Move connection does not return connection to previous location
[ https://issues.apache.org/jira/browse/NIFI-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13243: --- Description: !image-2024-05-15-10-12-48-847.png|width=2014,height=894! (was: !image-2024-05-15-10-12-48-847.png!) > Cancel Move connection does not return connection to previous location > -- > > Key: NIFI-13243 > URL: https://issues.apache.org/jira/browse/NIFI-13243 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > Attachments: image-2024-05-15-10-12-48-847.png > > > !image-2024-05-15-10-12-48-847.png|width=2014,height=894! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13233) Change version dialog issues
[ https://issues.apache.org/jira/browse/NIFI-13233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-13233: -- Assignee: Rob Fellows > Change version dialog issues > > > Key: NIFI-13233 > URL: https://issues.apache.org/jira/browse/NIFI-13233 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-14 at 1.21.56 PM.png > > > There are some text overflow issues and the version column does not have > enough width for the new git backed version name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12896) Add Endpoint Override Property to PutSNS
[ https://issues.apache.org/jira/browse/NIFI-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12896: Fix Version/s: 1.27.0 > Add Endpoint Override Property to PutSNS > > > Key: NIFI-12896 > URL: https://issues.apache.org/jira/browse/NIFI-12896 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Sue Kim >Assignee: Sue Kim >Priority: Minor > Fix For: 1.27.0, 2.0.0-M4 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Request for PutSNS processor to have an endpoint override property similar to > Get/PutSQS processors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12896) Add Endpoint Override Property to PutSNS
[ https://issues.apache.org/jira/browse/NIFI-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846698#comment-17846698 ] ASF subversion and git services commented on NIFI-12896: Commit be62d80a896a607f2289bc6c5c61da22ffeed0a3 in nifi's branch refs/heads/support/nifi-1.x from sujkm [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=be62d80a89 ] NIFI-12896 Added Endpoint Override URL property for PutSNS Processor This closes #8835 Signed-off-by: David Handermann > Add Endpoint Override Property to PutSNS > > > Key: NIFI-12896 > URL: https://issues.apache.org/jira/browse/NIFI-12896 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Sue Kim >Assignee: Sue Kim >Priority: Minor > Fix For: 2.0.0-M4 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Request for PutSNS processor to have an endpoint override property similar to > Get/PutSQS processors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12896: Add Endpoint Override URL property for PutSNS processor [nifi]
exceptionfactory closed pull request #8835: NIFI-12896: Add Endpoint Override URL property for PutSNS processor URL: https://github.com/apache/nifi/pull/8835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12896: Add Endpoint Override URL property for PutSNS processor [nifi]
exceptionfactory commented on PR #8835: URL: https://github.com/apache/nifi/pull/8835#issuecomment-2112950077 Merged in https://github.com/apache/nifi/commit/be62d80a896a607f2289bc6c5c61da22ffeed0a3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
mcgilman commented on code in PR #8804: URL: https://github.com/apache/nifi/pull/8804#discussion_r1601646400 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/component-state/component-state.component.html: ## @@ -48,6 +47,9 @@ Component State } } + +Displaying {{ filteredEntries }} of {{ totalEntries }} + Review Comment: This doesn't look quite right. ![Screenshot 2024-05-15 at 9 24 15 AM](https://github.com/apache/nifi/assets/123395/afbdb938-b394-41cb-90dd-eb2cf718bbe2) ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.html: ## @@ -23,37 +23,43 @@ } @else { @if (policyComponentState$ | async; as policyComponentState) { @if (flowConfiguration$ | async; as flowConfiguration) { - + - - -@switch (accessPolicyState.policyStatus) { -@case (PolicyStatus.NotFound) { -No policy for the specified resource. -@if (flowConfiguration.supportsConfigurableAuthorizer) { -Create a new policy. +@if ( +accessPolicyState.policyStatus === PolicyStatus.NotFound || +accessPolicyState.policyStatus === PolicyStatus.Inherited || +accessPolicyState.policyStatus === PolicyStatus.Forbidden +) { + + +@switch (accessPolicyState.policyStatus) { +@case (PolicyStatus.NotFound) { +No policy for the specified resource. Review Comment: Should the access policy status be shown as a `hint` too? ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/error-banner/error-banner.component.html: ## @@ -16,18 +16,20 @@ --> @if ((messages$ | async)!; as messages) { - -@if (messages.length === 1) { -{{ messages[0] }} -} @else { - -@for (message of messages; track message) { -{{ message }} -} - -} - -Dismiss + Review Comment: ```suggestion ``` ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/cluster/ui/common/cluster-table-filter/cluster-table-filter.component.ts: ## @@ -42,7 +42,7 @@ export interface ClusterTableFilterContext extends ClusterTableFilterArgs { @Component({ selector: 'cluster-table-filter', standalone: true, -imports: [MatCheckbox, MatFormField, MatInput, MatLabel, MatOption, MatSelect, ReactiveFormsModule], +imports: [MatCheckbox, MatFormField, MatInput, MatLabel, MatOption, MatSelect, ReactiveFormsModule, MatHint], Review Comment: `MatHint` is being imported but I'm not sure it's being used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13226) Color (context menu/operate panel)
[ https://issues.apache.org/jira/browse/NIFI-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13226: --- Status: Patch Available (was: In Progress) > Color (context menu/operate panel) > -- > > Key: NIFI-13226 > URL: https://issues.apache.org/jira/browse/NIFI-13226 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12669) EvaluateXQuery processor incorrectly encodes result attributes
[ https://issues.apache.org/jira/browse/NIFI-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846695#comment-17846695 ] David Handermann commented on NIFI-12669: - [~mattyb149] I pushed an update to the support branch, correct to the ByteArrayOutputStream.toString() method. The signature that takes a Charset was added in Java 10, so the change requires using the String name of the character set instead. > EvaluateXQuery processor incorrectly encodes result attributes > -- > > Key: NIFI-12669 > URL: https://issues.apache.org/jira/browse/NIFI-12669 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration, Extensions > Environment: JVM with non-UTF-8 default encoding (e.g. default > Windows installation) >Reporter: René Zeidler >Assignee: Jim Steinebrey >Priority: Major > Labels: encoding, utf8, windows, xml > Fix For: 1.27.0, 2.0.0-M4 > > Attachments: EvaluateXQuery_Encoding_Bug.json, > image-2024-01-25-10-24-17-005.png, image-2024-01-25-10-31-35-200.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > h2. Environment > This issue affects environments where the JVM default encoding is not > {{{}UTF-8{}}}. Standard Java installations on Windows are affected, as they > usually use the default encoding {{{}windows-1252{}}}. To reproduce the issue > on Linux, change the default encoding to {{windows-1252}} by adding the > following line to your {{{}bootstrap.conf{}}}: > {quote}{{java.arg.21=-Dfile.encoding=windows-1252}} > {quote} > h2. Summary > The EvaluateXQuery incorrectly encodes result values when storing them in > attributes. This causes non-ASCII characters to be garbled. > Example: > !image-2024-01-25-10-24-17-005.png! > h2. Steps to reproduce > # Make sure NiFi runs with a non-UTF-8 default encoding, see "Environment" > # Create a GenerateFlowFile processor with the following content: > {quote}{{}} > {{}} > {{ This text contains non-ASCII characters: ÄÖÜäöüßéèóò}} > {{}} > {quote} > # Connect the processor to an EvaluateXQuery processor. > Set the {{Destination}} to {{{}flowfile-attribute{}}}. > Create a custom property {{myData}} with value {{{}string(/myRoot/myData){}}}. > # Connect the outputs of the EvaluateXQuery processor to funnels to be able > to observe the result in the queue. > # Start the EvaluateXQuery processor and run the GenerateFlowFile processor > once. > The flow should look similar to this: > !image-2024-01-25-10-31-35-200.png! > I also attached a JSON export of the example flow. > # Observe the attributes of the resulting FlowFile in the queue. > h3. Expected Result > The FlowFile should contain an attribute {{myData}} with the value {{{}"This > text contains non-ASCII characters: ÄÖÜäöüßéèóò"{}}}. > h3. Actual Result > The attribute has the value "This text contains non-ASCII characters: > ÄÖÜäöüßéèóò". > h2. Root Cause Analysis > EvaluateXQuery uses the method > [{{formatItem}}|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java#L368-L372] > to write the query result to an attribute. This method calls > {{{}ByteArrayOutputStream{}}}'s > [toString|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/ByteArrayOutputStream.html#toString()] > method without an encoding argument, which then defaults to the default > charset of the environment. Bytes are always written to this output stream > using UTF-8 > ([.getBytes(StandardCharsets.UTF8)|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java#L397]). > When the default charset is not UTF-8, this results in UTF-8 bytes to be > interpreted in a different encoding when converting to a string, resulting in > garbled text (see above). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12669) EvaluateXQuery processor incorrectly encodes result attributes
[ https://issues.apache.org/jira/browse/NIFI-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846695#comment-17846695 ] David Handermann edited comment on NIFI-12669 at 5/15/24 3:59 PM: -- [~mattyb149] I pushed an update to the support branch, correcting the ByteArrayOutputStream.toString() method. The signature that takes a Charset was added in Java 10, so the change requires using the String name of the character set instead. was (Author: exceptionfactory): [~mattyb149] I pushed an update to the support branch, correct to the ByteArrayOutputStream.toString() method. The signature that takes a Charset was added in Java 10, so the change requires using the String name of the character set instead. > EvaluateXQuery processor incorrectly encodes result attributes > -- > > Key: NIFI-12669 > URL: https://issues.apache.org/jira/browse/NIFI-12669 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration, Extensions > Environment: JVM with non-UTF-8 default encoding (e.g. default > Windows installation) >Reporter: René Zeidler >Assignee: Jim Steinebrey >Priority: Major > Labels: encoding, utf8, windows, xml > Fix For: 1.27.0, 2.0.0-M4 > > Attachments: EvaluateXQuery_Encoding_Bug.json, > image-2024-01-25-10-24-17-005.png, image-2024-01-25-10-31-35-200.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > h2. Environment > This issue affects environments where the JVM default encoding is not > {{{}UTF-8{}}}. Standard Java installations on Windows are affected, as they > usually use the default encoding {{{}windows-1252{}}}. To reproduce the issue > on Linux, change the default encoding to {{windows-1252}} by adding the > following line to your {{{}bootstrap.conf{}}}: > {quote}{{java.arg.21=-Dfile.encoding=windows-1252}} > {quote} > h2. Summary > The EvaluateXQuery incorrectly encodes result values when storing them in > attributes. This causes non-ASCII characters to be garbled. > Example: > !image-2024-01-25-10-24-17-005.png! > h2. Steps to reproduce > # Make sure NiFi runs with a non-UTF-8 default encoding, see "Environment" > # Create a GenerateFlowFile processor with the following content: > {quote}{{}} > {{}} > {{ This text contains non-ASCII characters: ÄÖÜäöüßéèóò}} > {{}} > {quote} > # Connect the processor to an EvaluateXQuery processor. > Set the {{Destination}} to {{{}flowfile-attribute{}}}. > Create a custom property {{myData}} with value {{{}string(/myRoot/myData){}}}. > # Connect the outputs of the EvaluateXQuery processor to funnels to be able > to observe the result in the queue. > # Start the EvaluateXQuery processor and run the GenerateFlowFile processor > once. > The flow should look similar to this: > !image-2024-01-25-10-31-35-200.png! > I also attached a JSON export of the example flow. > # Observe the attributes of the resulting FlowFile in the queue. > h3. Expected Result > The FlowFile should contain an attribute {{myData}} with the value {{{}"This > text contains non-ASCII characters: ÄÖÜäöüßéèóò"{}}}. > h3. Actual Result > The attribute has the value "This text contains non-ASCII characters: > ÄÖÜäöüßéèóò". > h2. Root Cause Analysis > EvaluateXQuery uses the method > [{{formatItem}}|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java#L368-L372] > to write the query result to an attribute. This method calls > {{{}ByteArrayOutputStream{}}}'s > [toString|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/ByteArrayOutputStream.html#toString()] > method without an encoding argument, which then defaults to the default > charset of the environment. Bytes are always written to this output stream > using UTF-8 > ([.getBytes(StandardCharsets.UTF8)|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java#L397]). > When the default charset is not UTF-8, this results in UTF-8 bytes to be > interpreted in a different encoding when converting to a string, resulting in > garbled text (see above). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12669) EvaluateXQuery processor incorrectly encodes result attributes
[ https://issues.apache.org/jira/browse/NIFI-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846693#comment-17846693 ] ASF subversion and git services commented on NIFI-12669: Commit 801a14e7cf1217a7a6bab2234a6dd18867ce57bf in nifi's branch refs/heads/support/nifi-1.x from sujkim [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=801a14e7cf ] NIFI-12669 Fixed ByteArrayOutputStream.toString() for Java 8 in EvaluateXQuery > EvaluateXQuery processor incorrectly encodes result attributes > -- > > Key: NIFI-12669 > URL: https://issues.apache.org/jira/browse/NIFI-12669 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration, Extensions > Environment: JVM with non-UTF-8 default encoding (e.g. default > Windows installation) >Reporter: René Zeidler >Assignee: Jim Steinebrey >Priority: Major > Labels: encoding, utf8, windows, xml > Fix For: 1.27.0, 2.0.0-M4 > > Attachments: EvaluateXQuery_Encoding_Bug.json, > image-2024-01-25-10-24-17-005.png, image-2024-01-25-10-31-35-200.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > h2. Environment > This issue affects environments where the JVM default encoding is not > {{{}UTF-8{}}}. Standard Java installations on Windows are affected, as they > usually use the default encoding {{{}windows-1252{}}}. To reproduce the issue > on Linux, change the default encoding to {{windows-1252}} by adding the > following line to your {{{}bootstrap.conf{}}}: > {quote}{{java.arg.21=-Dfile.encoding=windows-1252}} > {quote} > h2. Summary > The EvaluateXQuery incorrectly encodes result values when storing them in > attributes. This causes non-ASCII characters to be garbled. > Example: > !image-2024-01-25-10-24-17-005.png! > h2. Steps to reproduce > # Make sure NiFi runs with a non-UTF-8 default encoding, see "Environment" > # Create a GenerateFlowFile processor with the following content: > {quote}{{}} > {{}} > {{ This text contains non-ASCII characters: ÄÖÜäöüßéèóò}} > {{}} > {quote} > # Connect the processor to an EvaluateXQuery processor. > Set the {{Destination}} to {{{}flowfile-attribute{}}}. > Create a custom property {{myData}} with value {{{}string(/myRoot/myData){}}}. > # Connect the outputs of the EvaluateXQuery processor to funnels to be able > to observe the result in the queue. > # Start the EvaluateXQuery processor and run the GenerateFlowFile processor > once. > The flow should look similar to this: > !image-2024-01-25-10-31-35-200.png! > I also attached a JSON export of the example flow. > # Observe the attributes of the resulting FlowFile in the queue. > h3. Expected Result > The FlowFile should contain an attribute {{myData}} with the value {{{}"This > text contains non-ASCII characters: ÄÖÜäöüßéèóò"{}}}. > h3. Actual Result > The attribute has the value "This text contains non-ASCII characters: > ÄÖÜäöüßéèóò". > h2. Root Cause Analysis > EvaluateXQuery uses the method > [{{formatItem}}|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java#L368-L372] > to write the query result to an attribute. This method calls > {{{}ByteArrayOutputStream{}}}'s > [toString|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/ByteArrayOutputStream.html#toString()] > method without an encoding argument, which then defaults to the default > charset of the environment. Bytes are always written to this output stream > using UTF-8 > ([.getBytes(StandardCharsets.UTF8)|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java#L397]). > When the default charset is not UTF-8, this results in UTF-8 bytes to be > interpreted in a different encoding when converting to a string, resulting in > garbled text (see above). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2346: Build MiNiFi Core, MainExe, Standard-Processors with Conan2 [nifi-minifi-cpp]
james94 commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2112912172 Thanks for your suggestion @szaszm I was considering to break this PR into multiple parts because like you said there is a lot to review. Actually, with each major update and commit hash, my goal was to make it easier to track each section of the new update that I made. For example with just updating **OpenSSL** to have USE_CONAN_PACKAGER support and backward compatibility for USE_CMAKE_FETCH_CONTENT, which impacts **libminifi**, we could reference my current commit hash from **UPDATE (May 4, 2024) - [2d1b884](https://github.com/apache/nifi-minifi-cpp/pull/1775/commits/2d1b8842c6809380f981f9857543805efbfd00cc)** and extract out just the part for OpenSSL, so its a smaller PR following your suggestions. Once its approved, we're on the same page for what you guys are looking for, we could look toward bringing up USE_CONAN_PACKAGER support for building the whole **libminifi** like I do in commit **2d1b884**. I will follow up with a smaller PR for **OpenSSL** impacting part of **libminifi**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13228) Jolt Transform UI uses incorrect property names
[ https://issues.apache.org/jira/browse/NIFI-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13228: Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Jolt Transform UI uses incorrect property names > --- > > Key: NIFI-13228 > URL: https://issues.apache.org/jira/browse/NIFI-13228 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M2 >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M4 > > Time Spent: 20m > Remaining Estimate: 0h > > NIFI-12554 introducing a breaking change with the property names used by > JoltTransformJSON. The existing custom UI saves the transform and > specification into properties under the previous name. As a result, the > values are stored in dynamic properties. This custom UI needs to be updated > to leverage the new/updated Property names. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13228) Jolt Transform UI uses incorrect property names
[ https://issues.apache.org/jira/browse/NIFI-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846692#comment-17846692 ] ASF subversion and git services commented on NIFI-13228: Commit eaf3f23100ce388a9bfb56428f62316c3a55cd47 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=eaf3f23100 ] NIFI-13228 Fixed Jolt Transform Custom UI with updated property names This closes #8829 Signed-off-by: David Handermann > Jolt Transform UI uses incorrect property names > --- > > Key: NIFI-13228 > URL: https://issues.apache.org/jira/browse/NIFI-13228 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M2 >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > NIFI-12554 introducing a breaking change with the property names used by > JoltTransformJSON. The existing custom UI saves the transform and > specification into properties under the previous name. As a result, the > values are stored in dynamic properties. This custom UI needs to be updated > to leverage the new/updated Property names. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13228: Fixing jolt transform json custom UI to reflect the updated property names [nifi]
exceptionfactory closed pull request #8829: NIFI-13228: Fixing jolt transform json custom UI to reflect the updated property names URL: https://github.com/apache/nifi/pull/8829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12896: Add Endpoint Override URL property for PutSNS processor [nifi]
sujkm commented on PR #8529: URL: https://github.com/apache/nifi/pull/8529#issuecomment-2112881657 @exceptionfactory Thanks so much! I have submitted a PR to the support branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12896: Add Endpoint Override URL property for PutSNS processor [nifi]
sujkm opened a new pull request, #8835: URL: https://github.com/apache/nifi/pull/8835 # Summary [NIFI-12896](https://issues.apache.org/jira/browse/NIFI-12896) Added Endpoint Override Property to PutSNS processor. This PR is for support/1.x branch. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2375) ExecuteScript with lua throws
Ferenc Gerlits created MINIFICPP-2375: - Summary: ExecuteScript with lua throws Key: MINIFICPP-2375 URL: https://issues.apache.org/jira/browse/MINIFICPP-2375 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Ferenc Gerlits When running ExecuteScript with {noformat} Properties: Script Engine: python Script Body: print("hello world!") {noformat} onTrigger throws an exception, and the flow file gets penalized, although the script gets called: "hello world!" is printed to the console. The log file has {noformat} [2024-05-15 15:11:29.108] [org::apache::nifi::minifi::core::Processor] [warning] Caught "attempt to call a nil value stack traceback:" (N3org6apache4nifi6minifi10extensions3lua18LuaScriptExceptionE) during Processor::onTrigger of processor: 2cc9c0d6-6ea2-473e-a30d-5debb0b3b2c5 (Execute script) (2cc9c0d6-6ea2-473e-a30d-5debb0b3b2c5) [2024-05-15 15:11:29.108] [org::apache::nifi::minifi::core::ProcessSession] [warning] ProcessSession rollback for Execute script executed [2024-05-15 15:11:29.108] [org::apache::nifi::minifi::SchedulingAgent] [warning] Caught Exception during SchedulingAgent::onTrigger of processor Execute script (uuid: 2cc9c0d6-6ea2-473e-a30d-5debb0b3b2c5), type: N3org6apache4nifi6minifi10extensions3lua18LuaScriptExceptionE, what: attempt to call a nil value stack traceback: {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13246) Move actions into kebab menu
Scott Aslan created NIFI-13246: -- Summary: Move actions into kebab menu Key: NIFI-13246 URL: https://issues.apache.org/jira/browse/NIFI-13246 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan View Provenance event View FlowFile View Documentation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13232) Add REST API Resource for Authentication Configuration
[ https://issues.apache.org/jira/browse/NIFI-13232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13232: Status: Patch Available (was: In Progress) > Add REST API Resource for Authentication Configuration > -- > > Key: NIFI-13232 > URL: https://issues.apache.org/jira/browse/NIFI-13232 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The NiFi user interface applications include Servlet Filters to handle Login > and Logout redirection based on the configured authentication strategy. > Rather than continuing to maintain these filters, a new REST API resource > should be created to provide login and logout URLs based on application > configuration. The response should also indicate whether the system supports > login and logout operations so that the user interface can present the > appropriate forms and links according to the current system configuration. > Implementing this new REST API should support the removal of the Login and > Logout filters from the new user interface, simplifying the build and > deployment process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13232 Add Authentication Configuration REST API method [nifi]
exceptionfactory opened a new pull request, #8834: URL: https://github.com/apache/nifi/pull/8834 # Summary [NIFI-13232](https://issues.apache.org/jira/browse/NIFI-13232) Adds a new REST API method for returning authentication configuration details. The purpose of the new method is to provide sufficient details for the user interface to determine when to show the login screen and when to show the logout link. The REST API method is designed to support current authentication strategies, including username and password authentication with a Login Identity Provider, as well as single sign-on with either OIDC or SAML. The method should also return correct status when the client makes a request using mutual TLS with a client certificate. The mutual TLS scenario may require an additional field because when NiFi is running behind a reverse proxy, the proxy itself will provide a client certificate, but the client web browser should be presented with a login screen or be redirected for single sign-on. Changes include adding a `credentials` property to the authentication token class, providing access to the JSON Web Token or Client Certificates passed during the initial authentication process. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2363 Verify linux package on other distros using the docker… [nifi-minifi-cpp]
martinzink commented on PR #1787: URL: https://github.com/apache/nifi-minifi-cpp/pull/1787#issuecomment-2112809616 I've requested to update the allowed actions so we can use the non-deprecated version of phoenix-actions/test-reporting https://issues.apache.org/jira/browse/INFRA-25789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13236) Issue when viewing and downloading content
[ https://issues.apache.org/jira/browse/NIFI-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-13236: --- Assignee: David Handermann > Issue when viewing and downloading content > -- > > Key: NIFI-13236 > URL: https://issues.apache.org/jira/browse/NIFI-13236 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: David Handermann >Priority: Major > > When attempting to view or download content the flowfile's filename (from the > filename attribute) is used as the proposed downloaded filename. These > endpoints support gzip encoding. If the filename contains characters are > invalid VCHAR based on RFC9110, the endpoint fails with a connection error. > The log contains the following exception. > > {noformat} > 2024-05-14 14:52:40,290 ERROR [NiFi Web Server-138] > o.g.j.server.ServerRuntime$Responder An I/O error has occurred while writing > a response message entity to the container output stream. > org.glassfish.jersey.server.internal.process.MappableException: > java.io.IOException: > org.eclipse.jetty.http2.hpack.HpackException$SessionException: Could not > hpack encode HTTP/2.0{s=200,h=11,cl=-1} > at > org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:67) > at > org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139) > at > org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116) > at > org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:678) > at > org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:387) > at > org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:377) > at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:266) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248) > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244) > at org.glassfish.jersey.internal.Errors.process(Errors.java:292) > at org.glassfish.jersey.internal.Errors.process(Errors.java:274) > at org.glassfish.jersey.internal.Errors.process(Errors.java:244) > at > org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266) > at > org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:242) > at > org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:697) > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394) > at > org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312) > at > org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205) > at > org.eclipse.jetty.ee10.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1379) > at > org.eclipse.jetty.ee10.servlet.ServletHolder.handle(ServletHolder.java:736) > at > org.eclipse.jetty.ee10.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1614) > at > org.springframework.security.web.FilterChainProxy.lambda$doFilterInternal$3(FilterChainProxy.java:231) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:365) > at > org.springframework.security.web.access.intercept.AuthorizationFilter.doFilter(AuthorizationFilter.java:100) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:126) > at > org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:120) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.apache.nifi.web.security.log.AuthenticationUserFilter.doFilterInternal(AuthenticationUserFilter.java:57) > at > org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at > org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:100) > at > org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) > at >
Re: [PR] MINIFICPP-2346: Build MiNiFi Core, MainExe, Standard-Processors with Conan2 [nifi-minifi-cpp]
szaszm commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2112726707 @james94 I'm busy with other commitments to keep up with this, but I'd like to prevent wasting too much of your time on something we can't use. We can't review a 17k diff, so it will never be merged as is stands now. If you want to pursue this, please create a separate pull request, where you only convert a single dependency to build with conan, so we can provide feedback there, and only change what's absolutely necessary. A good first target could be OpenSSL, because it takes forever to build on Windows. Please make an effort to keep the diff as small as possible, in the 100s if possible, but keep it under 1000. We can review many small pull requests, but not giants like this. Example: #603 didn't get any reviews, despite being a very valuable feature As the conversion of the first dependency is reviewed, we both learn from it, and subsequent dependency source conversions will be easier. Please only pursue 1 or max 2 features at a time, so we can keep up and provide the necessary feedback. This will inevitably take a few months. I'll also give some early feedback on things I noticed so far: - Please use a proper multi-choice option for selecting the source of a dependency instead of USE_CONAN_PACKAGER and USE_CMAKE_FETCH_CONTENT binary options. For example: MINIFI_OPENSSL_SOURCE: [conan|find_package|bundled]. The second option could keep just find_package, and rely on sources from the system. If it doesn't work, just having [conan|bundled] is fine. - Please don't include patches that are not strictly necessary to make conan builds work - Please prefix minifi-related options with MINIFI_ in cmake. Not all options follow this now, but future new CMake options should. - Please don't add new dependencies in the context of converting to Conan. For example, minifi doesn't depend on ffmpeg or libtiff at the moment. If they're needed for a new feature, the new feature needs to be a separate pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13245) Provenance Event dialog overflow issues
Scott Aslan created NIFI-13245: -- Summary: Provenance Event dialog overflow issues Key: NIFI-13245 URL: https://issues.apache.org/jira/browse/NIFI-13245 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: Screenshot 2024-05-15 at 10.18.51 AM.png -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13244) Paste location seems to be inconsistent
Scott Aslan created NIFI-13244: -- Summary: Paste location seems to be inconsistent Key: NIFI-13244 URL: https://issues.apache.org/jira/browse/NIFI-13244 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: image-2024-05-15-10-14-52-757.png !image-2024-05-15-10-14-52-757.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13243) Cancel Move connection does not return connection to previous location
Scott Aslan created NIFI-13243: -- Summary: Cancel Move connection does not return connection to previous location Key: NIFI-13243 URL: https://issues.apache.org/jira/browse/NIFI-13243 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: image-2024-05-15-10-12-48-847.png !image-2024-05-15-10-12-48-847.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it [nifi]
scottyaslan commented on PR #8833: URL: https://github.com/apache/nifi/pull/8833#issuecomment-2112653800 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
scottyaslan commented on PR #8804: URL: https://github.com/apache/nifi/pull/8804#issuecomment-2112648720 @mcgilman a good way to quickly see these changes is to use the browser back/forward navigation between the pages. The changes at the top of the page are particularly noticeable in that they are more consistent with the spacing: ![Kapture 2024-05-15 at 09 58 28](https://github.com/apache/nifi/assets/6797571/97d496d8-f542-4fb0-8bee-c9a5c5b60fb5) A more tedious check would be to go through each page and verify all the padding/spacing and see that there is no longer overlapping elements nor any need for negative margins etc. Feel free to use both approaches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
scottyaslan commented on code in PR #8804: URL: https://github.com/apache/nifi/pull/8804#discussion_r1601701285 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html: ## @@ -17,7 +17,7 @@ - + Review Comment: FYI I didn't actually use `` but rather I simply moved the `` to the appropriate place such that there are no overflow issues. This approach does not really correlate the 'hint' to a particular field which is why I didn't opt to use ``. It actually doesn't make any visual difference whether we use `` or `` so if you like I can update to use ``. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
scottyaslan commented on code in PR #8804: URL: https://github.com/apache/nifi/pull/8804#discussion_r1601696361 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/feature/access-policies.component.html: ## @@ -15,14 +15,14 @@ ~ limitations under the License. --> - - + + -Access Policies +Access Policies - + Review Comment: Sorry, I must have not been looking at main. I do agree that these changes do not impact the refreshed timestamp and button. I have reverted this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12896: Add Endpoint Override URL property for PutSNS processor [nifi]
exceptionfactory commented on PR #8529: URL: https://github.com/apache/nifi/pull/8529#issuecomment-2112597361 @dan-s1 You're welcome! The main branch includes a number of changes to the AWS tests, so it isn't a clean cherry-pick from the main branch. If you would like to submit a PR to the support branch, I can review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12896: Add Endpoint Override URL property for PutSNS processor [nifi]
dan-s1 commented on PR #8529: URL: https://github.com/apache/nifi/pull/8529#issuecomment-2112479956 @exceptionfactory Thank you so much for merging this. If possible can this change be also cherry picked to the 1.x branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
mcgilman commented on code in PR #8804: URL: https://github.com/apache/nifi/pull/8804#discussion_r1601599674 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html: ## @@ -17,7 +17,7 @@ - + Review Comment: My comment was regarding this change (not other parts of the application) specifically which makes these elements even closer. Usage of `hint` is a great idea. Let me review these changes in your latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
mcgilman commented on code in PR #8804: URL: https://github.com/apache/nifi/pull/8804#discussion_r1601596277 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/feature/access-policies.component.html: ## @@ -15,14 +15,14 @@ ~ limitations under the License. --> - - + + -Access Policies +Access Policies - + Review Comment: I don't believe these changes make any difference in the padding/spacing. And the changes are different from the other pages. They do not impact the refreshed timestamp and button. Is there something subtle that I missed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13241) [BUG] Escape button does not close extension creation dialogs
[ https://issues.apache.org/jira/browse/NIFI-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13241: --- Status: Patch Available (was: In Progress) > [BUG] Escape button does not close extension creation dialogs > - > > Key: NIFI-13241 > URL: https://issues.apache.org/jira/browse/NIFI-13241 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This issue affects all creation dialogs that set focus to an input. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it [nifi]
rfellows opened a new pull request, #8833: URL: https://github.com/apache/nifi/pull/8833 [NIFI-13241](https://issues.apache.org/jira/browse/NIFI-13241) There were a number of dialogs missed in the original pass at supporting escape to close them. This PR adds it to those dialogs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12896) PutSNS Endpoint Override
[ https://issues.apache.org/jira/browse/NIFI-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846604#comment-17846604 ] ASF subversion and git services commented on NIFI-12896: Commit ea48d22fba666cc5ec70db70ccd4a13da07acff8 in nifi's branch refs/heads/main from sujkim [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ea48d22fba ] NIFI-12896 Add Endpoint Override URL property for PutSNS Processor This closes #8529 Signed-off-by: David Handermann > PutSNS Endpoint Override > > > Key: NIFI-12896 > URL: https://issues.apache.org/jira/browse/NIFI-12896 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Sue Kim >Assignee: Sue Kim >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > Request for PutSNS processor to have an endpoint override property similar to > Get/PutSQS processors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12896) Add Endpoint Override Property to PutSNS
[ https://issues.apache.org/jira/browse/NIFI-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12896. - Fix Version/s: 2.0.0-M4 Resolution: Fixed > Add Endpoint Override Property to PutSNS > > > Key: NIFI-12896 > URL: https://issues.apache.org/jira/browse/NIFI-12896 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Sue Kim >Assignee: Sue Kim >Priority: Minor > Fix For: 2.0.0-M4 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Request for PutSNS processor to have an endpoint override property similar to > Get/PutSQS processors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12896) Add Endpoint Override Property to PutSNS
[ https://issues.apache.org/jira/browse/NIFI-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12896: Summary: Add Endpoint Override Property to PutSNS (was: PutSNS Endpoint Override) > Add Endpoint Override Property to PutSNS > > > Key: NIFI-12896 > URL: https://issues.apache.org/jira/browse/NIFI-12896 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Sue Kim >Assignee: Sue Kim >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > Request for PutSNS processor to have an endpoint override property similar to > Get/PutSQS processors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12896) Add Endpoint Override Property to PutSNS
[ https://issues.apache.org/jira/browse/NIFI-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12896: Issue Type: Improvement (was: New Feature) > Add Endpoint Override Property to PutSNS > > > Key: NIFI-12896 > URL: https://issues.apache.org/jira/browse/NIFI-12896 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Sue Kim >Assignee: Sue Kim >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > Request for PutSNS processor to have an endpoint override property similar to > Get/PutSQS processors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13241) [BUG] Escape button does not close extension creation dialogs
[ https://issues.apache.org/jira/browse/NIFI-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-13241: -- Assignee: Rob Fellows > [BUG] Escape button does not close extension creation dialogs > - > > Key: NIFI-13241 > URL: https://issues.apache.org/jira/browse/NIFI-13241 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > > This issue affects all creation dialogs that set focus to an input. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12896: Add Endpoint Override URL property for PutSNS processor [nifi]
exceptionfactory closed pull request #8529: NIFI-12896: Add Endpoint Override URL property for PutSNS processor URL: https://github.com/apache/nifi/pull/8529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13225) Replace the deprecated methods/classes/enums in JwtService with API suggestions
[ https://issues.apache.org/jira/browse/NIFI-13225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13225: Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Replace the deprecated methods/classes/enums in JwtService with API > suggestions > --- > > Key: NIFI-13225 > URL: https://issues.apache.org/jira/browse/NIFI-13225 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Fix For: 2.0.0-M4 > > Time Spent: 20m > Remaining Estimate: 0h > > These are the warnings seen from a build > {code:java} > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,25] > [deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,66] > [deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[68,39] > [deprecation] getBody() in Jwt has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[73,39] > [deprecation] getBody() in Jwt has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[76,22] > [deprecation] getBody() in Jwt has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,59] > [deprecation] SigningKeyResolverAdapter in io.jsonwebtoken has been > deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,32] > [deprecation] setSigningKeyResolver(SigningKeyResolver) in JwtParserBuilder > has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[103,22] > [deprecation] parseClaimsJws(CharSequence) in JwtParser has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[104,73] > [deprecation] SignatureException in io.jsonwebtoken has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[155,33] > [deprecation] setSubject(String) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[156,20] > [deprecation] setIssuer(String) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[157,20] > [deprecation] setAudience(String) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[160,20] > [deprecation] setIssuedAt(Date) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[161,20] > [deprecation] setExpiration(Date) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[162,20] > [deprecation] signWith(SignatureAlgorithm,byte[]) in JwtBuilder has been > deprecated > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13225) Replace the deprecated methods/classes/enums in JwtService with API suggestions
[ https://issues.apache.org/jira/browse/NIFI-13225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846602#comment-17846602 ] ASF subversion and git services commented on NIFI-13225: Commit 4ccf3a288c5bea758f0e1d59b0385cdeb47aeef3 in nifi's branch refs/heads/main from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4ccf3a288c ] NIFI-13225 Replaced most of the deprecated elements in Registry JwtService This closes #8827 Signed-off-by: David Handermann > Replace the deprecated methods/classes/enums in JwtService with API > suggestions > --- > > Key: NIFI-13225 > URL: https://issues.apache.org/jira/browse/NIFI-13225 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > These are the warnings seen from a build > {code:java} > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,25] > [deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,66] > [deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[68,39] > [deprecation] getBody() in Jwt has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[73,39] > [deprecation] getBody() in Jwt has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[76,22] > [deprecation] getBody() in Jwt has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,59] > [deprecation] SigningKeyResolverAdapter in io.jsonwebtoken has been > deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,32] > [deprecation] setSigningKeyResolver(SigningKeyResolver) in JwtParserBuilder > has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[103,22] > [deprecation] parseClaimsJws(CharSequence) in JwtParser has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[104,73] > [deprecation] SignatureException in io.jsonwebtoken has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[155,33] > [deprecation] setSubject(String) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[156,20] > [deprecation] setIssuer(String) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[157,20] > [deprecation] setAudience(String) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[160,20] > [deprecation] setIssuedAt(Date) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[161,20] > [deprecation] setExpiration(Date) in ClaimsMutator has been deprecated > [WARNING] > nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[162,20] > [deprecation] signWith(SignatureAlgorithm,byte[]) in JwtBuilder has been > deprecated > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13225 Replaced most of the deprecated methods/classes/enums in JwtService with the API suggestions [nifi]
exceptionfactory closed pull request #8827: NIFI-13225 Replaced most of the deprecated methods/classes/enums in JwtService with the API suggestions URL: https://github.com/apache/nifi/pull/8827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13242) [MiNiFi] Sync Resource command
Ferenc Kis created NIFI-13242: - Summary: [MiNiFi] Sync Resource command Key: NIFI-13242 URL: https://issues.apache.org/jira/browse/NIFI-13242 Project: Apache NiFi Issue Type: Improvement Components: MiNiFi Reporter: Ferenc Kis Assignee: Ferenc Kis Fix For: 2.0.0-M4 Handle Sync resource command. (Download files, and store version id/hash) * check if agent has enough disk space * extension types should be downloaded to extension folder * other types are relative to the asset folder (that must be different than the old asset push command folder) * the agent maintains a local repo, so it can be kept in sync with the C2 server Heartbeat operation: operation type: SYNC operand type: RESOURCE args: {code} "args": { "globalHash": { "digest": "xzy123", "hashType": "SHA1" }, "resourceList": [ { "resourceId": "abc123", "resourceName": "a.txt", "resourceType": "ASSET", "resourcePath": "valami/barmi", "digest": "hij987", "hashType": "SHA1", "url": "/c2/resource/abc123" }, { "resourceId": "def123", "resourceName": "b.nar", "resourceType": "EXTENSION", "resourcePath": null, "digest": "mno666", "hashType": "SHA1", "url": "/c2/resource/def123" } ] } {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13235) Import from registry to a PG without read permissions causes NPE
[ https://issues.apache.org/jira/browse/NIFI-13235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846599#comment-17846599 ] ASF subversion and git services commented on NIFI-13235: Commit 35a7e8743279a444913c7307fbd1c85588dddee8 in nifi's branch refs/heads/main from Bryan Bende [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=35a7e87432 ] NIFI-13235 Corrected REST API Import Process Group ID Reference Use the PG id from the entity because component may be null if current user does not have READ permissions This closes #8831 Signed-off-by: David Handermann > Import from registry to a PG without read permissions causes NPE > > > Key: NIFI-13235 > URL: https://issues.apache.org/jira/browse/NIFI-13235 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M2 >Reporter: Bryan Bende >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > If you are inside a PG where you have WRITE permissions, but not READ > permissions, and you import a new PG from a registry client, it results in an > unexpected error page and an NPE in the logs: > {code:java} > 2024-05-14 13:41:46,946 ERROR [NiFi Web Server-139] > o.a.nifi.web.api.config.ThrowableMapper An unexpected error has occurred: > java.lang.NullPointerException: Cannot invoke > "org.apache.nifi.web.api.dto.ProcessGroupDTO.getId()" because the return > value of "org.apache.nifi.web.api.entity.ProcessGroupEntity.getComponent()" > is null. Returning Internal Server Error response. > java.lang.NullPointerException: Cannot invoke > "org.apache.nifi.web.api.dto.ProcessGroupDTO.getId()" because the return > value of "org.apache.nifi.web.api.entity.ProcessGroupEntity.getComponent()" > is null > at > org.apache.nifi.web.api.ProcessGroupResource.lambda$createProcessGroup$18(ProcessGroupResource.java:1016) > at > org.apache.nifi.web.api.ApplicationResource.withWriteLock(ApplicationResource.java:691) > at > org.apache.nifi.web.api.ProcessGroupResource.createProcessGroup(ProcessGroupResource.java:988) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13235) Import from registry to a PG without read permissions causes NPE
[ https://issues.apache.org/jira/browse/NIFI-13235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-13235. - Fix Version/s: 2.0.0-M4 Assignee: Bryan Bende Resolution: Fixed > Import from registry to a PG without read permissions causes NPE > > > Key: NIFI-13235 > URL: https://issues.apache.org/jira/browse/NIFI-13235 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M2 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 2.0.0-M4 > > Time Spent: 20m > Remaining Estimate: 0h > > If you are inside a PG where you have WRITE permissions, but not READ > permissions, and you import a new PG from a registry client, it results in an > unexpected error page and an NPE in the logs: > {code:java} > 2024-05-14 13:41:46,946 ERROR [NiFi Web Server-139] > o.a.nifi.web.api.config.ThrowableMapper An unexpected error has occurred: > java.lang.NullPointerException: Cannot invoke > "org.apache.nifi.web.api.dto.ProcessGroupDTO.getId()" because the return > value of "org.apache.nifi.web.api.entity.ProcessGroupEntity.getComponent()" > is null. Returning Internal Server Error response. > java.lang.NullPointerException: Cannot invoke > "org.apache.nifi.web.api.dto.ProcessGroupDTO.getId()" because the return > value of "org.apache.nifi.web.api.entity.ProcessGroupEntity.getComponent()" > is null > at > org.apache.nifi.web.api.ProcessGroupResource.lambda$createProcessGroup$18(ProcessGroupResource.java:1016) > at > org.apache.nifi.web.api.ApplicationResource.withWriteLock(ApplicationResource.java:691) > at > org.apache.nifi.web.api.ProcessGroupResource.createProcessGroup(ProcessGroupResource.java:988) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13235 Use the PG id from the entity because component may be nul… [nifi]
exceptionfactory closed pull request #8831: NIFI-13235 Use the PG id from the entity because component may be nul… URL: https://github.com/apache/nifi/pull/8831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13238) Checkstyle - rules for whitespace
[ https://issues.apache.org/jira/browse/NIFI-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13238: Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Checkstyle - rules for whitespace > - > > Key: NIFI-13238 > URL: https://issues.apache.org/jira/browse/NIFI-13238 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0-M4 > > Time Spent: 20m > Remaining Estimate: 0h > > Adding the following rules: > * WhitespaceAfter > * NoWhitespaceAfter > * NoWhitespaceBefore > * WhitespaceAround -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13238) Checkstyle - rules for whitespace
[ https://issues.apache.org/jira/browse/NIFI-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846593#comment-17846593 ] ASF subversion and git services commented on NIFI-13238: Commit ee179f4acfbc57cfccc86bd2ea9a5dc4cb3b8221 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ee179f4acf ] NIFI-13238 Added Checkstyle rules for whitespace This closes #8832 Signed-off-by: David Handermann > Checkstyle - rules for whitespace > - > > Key: NIFI-13238 > URL: https://issues.apache.org/jira/browse/NIFI-13238 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Adding the following rules: > * WhitespaceAfter > * NoWhitespaceAfter > * NoWhitespaceBefore > * WhitespaceAround -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13238 - Adding checkstyle rules for whitespaces [nifi]
exceptionfactory closed pull request #8832: NIFI-13238 - Adding checkstyle rules for whitespaces URL: https://github.com/apache/nifi/pull/8832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINIFICPP-2374) Support more distros in the python bootstrapper
[ https://issues.apache.org/jira/browse/MINIFICPP-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846583#comment-17846583 ] Marton Szasz commented on MINIFICPP-2374: - We detect Fedora Asahi Remix with the "fedora-asahi-remix" distro id. The same command works as on Rocky Linux, except the epel-release package and the --enablerepo=crb flags are not needed. I tested the release candidate there. > Support more distros in the python bootstrapper > --- > > Key: MINIFICPP-2374 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2374 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Ferenc Gerlits >Priority: Minor > > The python bootstrapper supports these Linux distros: ubuntu, arch, manjaro > and rocky (see > [package_manager.py|https://github.com/apache/nifi-minifi-cpp/blob/main/bootstrap/package_manager.py#L303]). > I think it should support a few more, eg. fedora and debian. The old > boostrap.sh script supports these distros. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2374) Support more distros in the python bootstrapper
Ferenc Gerlits created MINIFICPP-2374: - Summary: Support more distros in the python bootstrapper Key: MINIFICPP-2374 URL: https://issues.apache.org/jira/browse/MINIFICPP-2374 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Ferenc Gerlits The python bootstrapper supports these Linux distros: ubuntu, arch, manjaro and rocky (see [package_manager.py|https://github.com/apache/nifi-minifi-cpp/blob/main/bootstrap/package_manager.py#L303]). I think it should support a few more, eg. fedora and debian. The old boostrap.sh script supports these distros. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2341 Include custom relationships in C2 manifest for NiFi python processors [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1770: URL: https://github.com/apache/nifi-minifi-cpp/pull/1770#discussion_r1601416310 ## extensions/python/pythonprocessors/nifiapi/properties.py: ## @@ -281,3 +284,21 @@ def getProperty(self, descriptor) -> PythonPropertyValue: expression_language_support = descriptor.expressionLanguageScope != ExpressionLanguageScope.NONE property_value = self.cpp_context.getProperty(property_name) return PythonPropertyValue(self.cpp_context, property_name, property_value, expression_language_support) + +def getStateManager(self) -> StateManager: +return self.cpp_context.getStateManager() + +def getName(self) -> str: +return self.cpp_context.getName() + +def getProperties(self) -> Dict[PropertyDescriptor, str]: +properties = dict() +cpp_properties = self.cpp_context.getProperties() + +for property_name in cpp_properties: +for property_descriptor in self.processor.getPropertyDescriptors(): +if property_descriptor.name == property_name: +properties[property_descriptor] = cpp_properties[property_name] +break Review Comment: can't we just flip it? `cpp_properties` seems to be a wrapped python dictionary, forwarding the `contains` call (which I think the following code would do) ```suggestion for property_descriptor in self.processor.getPropertyDescriptors(): if property_descriptor.name in cpp_properties: properties[property_descriptor] = cpp_properties[property_name] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2341 Include custom relationships in C2 manifest for NiFi python processors [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1770: URL: https://github.com/apache/nifi-minifi-cpp/pull/1770#discussion_r1601416310 ## extensions/python/pythonprocessors/nifiapi/properties.py: ## @@ -281,3 +284,21 @@ def getProperty(self, descriptor) -> PythonPropertyValue: expression_language_support = descriptor.expressionLanguageScope != ExpressionLanguageScope.NONE property_value = self.cpp_context.getProperty(property_name) return PythonPropertyValue(self.cpp_context, property_name, property_value, expression_language_support) + +def getStateManager(self) -> StateManager: +return self.cpp_context.getStateManager() + +def getName(self) -> str: +return self.cpp_context.getName() + +def getProperties(self) -> Dict[PropertyDescriptor, str]: +properties = dict() +cpp_properties = self.cpp_context.getProperties() + +for property_name in cpp_properties: +for property_descriptor in self.processor.getPropertyDescriptors(): +if property_descriptor.name == property_name: +properties[property_descriptor] = cpp_properties[property_name] +break Review Comment: can't we just flip it and do, `cpp_properties` seems to be a wrapped python dictionary, forwarding the `contains` call (which I think the following code would do) ```suggestion for property_descriptor in self.processor.getPropertyDescriptors(): if property_descriptor.name in cpp_properties: properties[property_descriptor] = cpp_properties[property_name] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2341 Include custom relationships in C2 manifest for NiFi python processors [nifi-minifi-cpp]
adamdebreceni commented on code in PR #1770: URL: https://github.com/apache/nifi-minifi-cpp/pull/1770#discussion_r1601405963 ## extensions/python/PYTHON.md: ## @@ -166,6 +166,10 @@ Due to some differences between the NiFi and MiNiFi C++ processors and implement - MiNiFi C++ only supports expression language with flow file attributes, so only FLOWFILE_ATTRIBUTES expression language scope is supported, otherwise the expression language will not be evaluated. - MiNiFi C++ does not support property dependencies, so the property dependencies will be ignored. If a property depends on another property, the property will not be required. - MiNiFi C++ does not support the use of self.jvm member in Python processors that provides JVM bindings in NiFi, it is set to None in MiNiFi C++. +- Dynamic properties are supported in all Python processors and the dynamic properties defined in the flow configuration are automatically added. There is no need to define getDynamicPropertyDescriptor method in the Python processor. The only caveat is that the description of the dynamic property cannot be custom defined. +- In MiNiFi C++ when the processor is stopped the stop event handling is done in the `notifystop()` processor which does not have the context available. Due to this the `def onStopped(self, context)` cannot be called in NiFi Python processors, so the `onStopped` method is not supported in MiNiFi C++. Review Comment: do you mean the following? ```suggestion - In MiNiFi C++ when the processor is stopped the stop event handling is done in the `notifyStop()` method which does not have the context available. Due to this the `def onStopped(self, context)` cannot be called in NiFi Python processors, so the `onStopped` method is not supported in MiNiFi C++. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org