Re: [PR] NIFI-13231 Added Private key authentication for GitHubFlowRegistryClient [nifi]
maybevanshh commented on code in PR #8890:
URL: https://github.com/apache/nifi/pull/8890#discussion_r1619921824
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubRepositoryClient.java:
##
@@ -379,6 +392,41 @@ public GHContent deleteContent(final String filePath,
final String commitMessage
});
}
+/**
+ * Creates the JwtToken for Authentication with Private Key
+ *
+ * @param pemString is the PKCS#1 String
+ * @return the JwtToken
+ *
+ * @throws Exception if an error occurs parsing key
+ */
+private static String loadPrivateKeyFromPEM(String pemString) throws
Exception {
+long nowMillis = System.currentTimeMillis();
+long expMillis = nowMillis + 60; // Token validity 10 minutes
+Date now = new Date(nowMillis);
+Date exp = new Date(expMillis);
+PEMParser pemParser = new PEMParser(new StringReader(pemString));
+Object object = pemParser.readObject();
+pemParser.close();
+
+if (object instanceof PEMKeyPair) {
+PEMKeyPair keyPair = (PEMKeyPair) object;
+RSAPrivateKey rsaPrivateKey =
RSAPrivateKey.getInstance(keyPair.getPrivateKeyInfo().parsePrivateKey());
+PKCS8EncodedKeySpec keySpec = new
PKCS8EncodedKeySpec(rsaPrivateKey.getEncoded());
Review Comment:
I'll commit the changes you requested and will use the utility function for
authentication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12595 Introduce 'Track Last Listing Time' mode to ListedEntityTracker [nifi]
github-actions[bot] closed pull request #8244: NIFI-12595 Introduce 'Track Last Listing Time' mode to ListedEntityTracker URL: https://github.com/apache/nifi/pull/8244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13289) Add tooltip to NewCanvas item
[ https://issues.apache.org/jira/browse/NIFI-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850523#comment-17850523 ] ASF subversion and git services commented on NIFI-13289: Commit e3cf0a67bc9781ecd14dc49ed0c019ab328fce5c in nifi's branch refs/heads/main from Shane [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e3cf0a67bc ] NIFI-13289 add tooltips to NewCanvasItem (#8870) This closes #8870 > Add tooltip to NewCanvas item > - > > Key: NIFI-13289 > URL: https://issues.apache.org/jira/browse/NIFI-13289 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Shane O'Neill >Priority: Major > Attachments: Screenshot 2024-05-23 at 2.36.55 PM.png > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Old NiFi UI had tooltips for the new canvas items in the top bar. These are > currently missing in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13289) Add tooltip to NewCanvas item
[ https://issues.apache.org/jira/browse/NIFI-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13289: --- Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Add tooltip to NewCanvas item > - > > Key: NIFI-13289 > URL: https://issues.apache.org/jira/browse/NIFI-13289 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Shane O'Neill >Priority: Major > Fix For: 2.0.0-M4 > > Attachments: Screenshot 2024-05-23 at 2.36.55 PM.png > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Old NiFi UI had tooltips for the new canvas items in the top bar. These are > currently missing in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
rfellows merged PR #8870: URL: https://github.com/apache/nifi/pull/8870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13312] - Restructure as an Nx monorepo [nifi]
mcgilman commented on code in PR #8893:
URL: https://github.com/apache/nifi/pull/8893#discussion_r1619554202
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/package.json:
##
@@ -56,7 +56,7 @@
"@angular/compiler-cli": "^17.1.3",
"@happy-dom/jest-environment": "^14.10.1",
"@nx/angular": "18.1.3",
-"@nx/jest": "^18.1.3",
+"@nx/jest": "18.3.4",
Review Comment:
With an update to package.json we should also include the updated
package-lock.json.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/apps/nifi/project.json:
##
@@ -70,15 +70,16 @@
}
},
"test": {
-"executor": "@angular-builders/jest:run",
+"executor": "@nx/jest:jest",
+"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
-"configPath": "./jest.config.ts"
+"jestConfig": "apps/nifi/jest.config.ts"
}
},
"lint": {
"executor": "@angular-eslint/builder:lint",
"options": {
-"lintFilePatterns": ["src/**/*.ts"]
+"lintFilePatterns": ["apps/nifi/src/**/*.ts"]
Review Comment:
This is the closest I could comment on this but I am unable to run
`lint:fix`. I receive the following error:
```
> nifi-web-frontend@0.0.0 lint:fix
> nx lint --eslint-config .eslintrc.json --fix
> nx run nifi:lint --eslint-config .eslintrc.json --fix
Linting "nifi"...
NX Failed to load plugin '@nx' declared in '--config#overrides[1]':
Cannot find module '@nx/eslint-plugin'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13289) Add tooltip to NewCanvas item
[ https://issues.apache.org/jira/browse/NIFI-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13289: --- Status: Patch Available (was: Open) > Add tooltip to NewCanvas item > - > > Key: NIFI-13289 > URL: https://issues.apache.org/jira/browse/NIFI-13289 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Shane O'Neill >Priority: Major > Attachments: Screenshot 2024-05-23 at 2.36.55 PM.png > > Time Spent: 1h > Remaining Estimate: 0h > > Old NiFi UI had tooltips for the new canvas items in the top bar. These are > currently missing in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]
dan-s1 commented on PR #8896: URL: https://github.com/apache/nifi/pull/8896#issuecomment-2138336598 @exceptionfactory Can you please advise on is there something I checked in that caused the following exceptions ``` Error:TestExecuteProcess.testNotRedirectErrorStream:241 If redirect error stream is false, the output should be logged as a warning so that user can notice on bulletin. ==> expected: <1> but was: <0> Error:TestExecuteProcess.testRedirectErrorStream:268 expected: <1> but was: <0> ``` Those tests on my computer are working and they are working on the MacOS. What more can I do for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
zeevo commented on code in PR #8870:
URL: https://github.com/apache/nifi/pull/8870#discussion_r1619511161
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/tooltips/nifi-tooltip.directive.ts:
##
@@ -58,11 +59,29 @@ export class NifiTooltipDirective implements OnDestroy {
}
}
+@HostListener('mousemove')
+mouseMove() {
+if (this.overlayRef?.hasAttached() && this.tooltipDisabled) {
+this.overlayRef?.detach();
+} else {
+this.attach();
Review Comment:
Removed `else` block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
zeevo commented on code in PR #8870:
URL: https://github.com/apache/nifi/pull/8870#discussion_r1619510853
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/tooltips/nifi-tooltip.directive.ts:
##
@@ -58,11 +59,29 @@ export class NifiTooltipDirective implements OnDestroy {
}
}
+@HostListener('mousemove')
+mouseMove() {
+if (this.overlayRef?.hasAttached() && this.tooltipDisabled) {
+this.overlayRef?.detach();
+} else {
+this.attach();
+}
+}
+
+@HostListener('mouseup')
+mouseup() {
+this.attach();
Review Comment:
Added guard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13265) Remove the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements
[ https://issues.apache.org/jira/browse/NIFI-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13265: Priority: Major (was: Minor) > Remove the instantiation of Object arrays for arguments in ComponentLog log > and org.slf4j.Logger statements > --- > > Key: NIFI-13265 > URL: https://issues.apache.org/jira/browse/NIFI-13265 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > There are still classes after the changes in NIFI-12075 and NIFI-12076 which > instantiate an Object array for ComponentLog log statements. This ticket aims > to remove those instantiations. In addition similar changes should be made to > org.slf4j.Logger statements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13265) Remove the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements
[ https://issues.apache.org/jira/browse/NIFI-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13265: Status: Patch Available (was: In Progress) > Remove the instantiation of Object arrays for arguments in ComponentLog log > and org.slf4j.Logger statements > --- > > Key: NIFI-13265 > URL: https://issues.apache.org/jira/browse/NIFI-13265 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > There are still classes after the changes in NIFI-12075 and NIFI-12076 which > instantiate an Object array for ComponentLog log statements. This ticket aims > to remove those instantiations. In addition similar changes should be made to > org.slf4j.Logger statements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]
dan-s1 opened a new pull request, #8896: URL: https://github.com/apache/nifi/pull/8896 # Summary [NIFI-13265](https://issues.apache.org/jira/browse/NIFI-13265) In addition to removing the unnecessary instantiation of Object arrays in logging statements this PR also aimed to remove parameters meant for exceptions which had for example `due to...` syntax as this was an artifact of legacy behavior that did not properly handle Throwable arguments. In addition this PR fixed some of the logging arguments as well e.g. not calling toString on an argument. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13231 Added Private key authentication for GitHubFlowRegistryClient [nifi]
exceptionfactory commented on code in PR #8890:
URL: https://github.com/apache/nifi/pull/8890#discussion_r1619437365
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubRepositoryClient.java:
##
@@ -379,6 +392,41 @@ public GHContent deleteContent(final String filePath,
final String commitMessage
});
}
+/**
+ * Creates the JwtToken for Authentication with Private Key
+ *
+ * @param pemString is the PKCS#1 String
+ * @return the JwtToken
+ *
+ * @throws Exception if an error occurs parsing key
+ */
+private static String loadPrivateKeyFromPEM(String pemString) throws
Exception {
+long nowMillis = System.currentTimeMillis();
+long expMillis = nowMillis + 60; // Token validity 10 minutes
+Date now = new Date(nowMillis);
+Date exp = new Date(expMillis);
+PEMParser pemParser = new PEMParser(new StringReader(pemString));
+Object object = pemParser.readObject();
+pemParser.close();
+
+if (object instanceof PEMKeyPair) {
+PEMKeyPair keyPair = (PEMKeyPair) object;
+RSAPrivateKey rsaPrivateKey =
RSAPrivateKey.getInstance(keyPair.getPrivateKeyInfo().parsePrivateKey());
+PKCS8EncodedKeySpec keySpec = new
PKCS8EncodedKeySpec(rsaPrivateKey.getEncoded());
Review Comment:
On further research, there are some options for reading PKCS 1 RSA private
keys with standard Java `KeyFactory` methods. If you can address some of the
other comments, I could add a commit to implement that element of key parsing,
which would still enable using the utility method from the github-api library,
using `PrivateKey` objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13299) Prevent negative numbers in concurrent tasks
[ https://issues.apache.org/jira/browse/NIFI-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13299: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Prevent negative numbers in concurrent tasks > > > Key: NIFI-13299 > URL: https://issues.apache.org/jira/browse/NIFI-13299 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > For inputs like concurrent tasks we know that negative values are not > allowed. We should prevent them before the user can submit the form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13299) Prevent negative numbers in concurrent tasks
[ https://issues.apache.org/jira/browse/NIFI-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850494#comment-17850494 ] ASF subversion and git services commented on NIFI-13299: Commit 2cd462482567e6be13cbee71b80d942933f0b68f in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2cd4624825 ] NIFI-13299: (#8894) - Adding min validators where appropriate. This closes #8894 > Prevent negative numbers in concurrent tasks > > > Key: NIFI-13299 > URL: https://issues.apache.org/jira/browse/NIFI-13299 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > For inputs like concurrent tasks we know that negative values are not > allowed. We should prevent them before the user can submit the form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13299: Adding min validators where appropriate [nifi]
rfellows merged PR #8894: URL: https://github.com/apache/nifi/pull/8894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-11171) Reorganize Standard Components for 2.0.0
[
https://issues.apache.org/jira/browse/NIFI-11171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-11171.
-
Fix Version/s: 2.0.0-M3
Resolution: Fixed
Marking as completed based on changes implemented up to 2.0.0-M3. Any further
changes could be considered under other issues.
> Reorganize Standard Components for 2.0.0
>
>
> Key: NIFI-11171
> URL: https://issues.apache.org/jira/browse/NIFI-11171
> Project: Apache NiFi
> Issue Type: Epic
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> The {{nifi-standard-processors}} and {{nifi-standard-services}} modules
> include a large number of Processors and Controller Services supporting an
> array of capabilities. Some of these capabilities require specialized
> libraries that apply to a limited number of components.
> Moving Processors and Controller Services changes class names and bundle
> coordinates which will break existing flow configurations. For this reason,
> the selection of components for reorganization should be limited and focused.
> Components with less frequent updates or usage and components with large
> dependencies trees should be considered.
> The following items should be considered as described in the [NiFi 2.0
> Release
> Goals|https://cwiki.apache.org/confluence/display/NIFI/NiFi+2.0+Release+Goals]:
> * SFTP Processors
> * Jolt Transform Processors
> * Jetty HTTP Processors
> * JSON Processors
> * Netty-based Processors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-13308) Upgrade Spring Framework to 6.1.8 along with Spring Boot 3.2.6, AWS 2.25.60, Netty 4.1.110 and others
[ https://issues.apache.org/jira/browse/NIFI-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-13308. - Fix Version/s: 2.0.0-M4 Resolution: Fixed > Upgrade Spring Framework to 6.1.8 along with Spring Boot 3.2.6, AWS 2.25.60, > Netty 4.1.110 and others > - > > Key: NIFI-13308 > URL: https://issues.apache.org/jira/browse/NIFI-13308 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M4 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13308) Upgrade Spring Framework to 6.1.8 along with Spring Boot 3.2.6, AWS 2.25.60, Netty 4.1.110 and others
[ https://issues.apache.org/jira/browse/NIFI-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13308: Summary: Upgrade Spring Framework to 6.1.8 along with Spring Boot 3.2.6, AWS 2.25.60, Netty 4.1.110 and others (was: Bump aws, spring, jersey, netty versions to latest) > Upgrade Spring Framework to 6.1.8 along with Spring Boot 3.2.6, AWS 2.25.60, > Netty 4.1.110 and others > - > > Key: NIFI-13308 > URL: https://issues.apache.org/jira/browse/NIFI-13308 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13308 bumped dependencies slack,maven,mariadb,spring boot, spring framework, jersey, netty, box, aws [nifi]
exceptionfactory closed pull request #8887: NIFI-13308 bumped dependencies slack,maven,mariadb,spring boot, spring framework, jersey, netty, box, aws URL: https://github.com/apache/nifi/pull/8887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13308) Bump aws, spring, jersey, netty versions to latest
[ https://issues.apache.org/jira/browse/NIFI-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850476#comment-17850476 ] ASF subversion and git services commented on NIFI-13308: Commit 89e8434bf03398ac06dbe4be84c72236a4bd902e in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=89e8434bf0 ] NIFI-13308 Upgraded Spring Framework from 6.1.7 to 6.1.8 - Upgraded Spring Boot from 3.2.5 to 3.2.6 - Upgraded Slack bolt-socket-mode from 1.39.2 to 1.39.3 - Upgraded maven-artifact from 3.9.6 to 3.9.7 - Upgraded mariadb-java-client from 3.3.3 to 3.4.0 - Upgraded software.amazon.awssdk from 2.25.55 to 2.25.60 - Upgraded com.amazonaws from 1.12.725 to 1.12.730 - Upgraded Jersey from 3.1.6 to 3.1.7 - Upgraded Netty from 4.1.109.Final to 4.1.110.Final - Upgraded box-java-sdk from 4.9.0 to 4.9.1 This closes #8887 Signed-off-by: David Handermann > Bump aws, spring, jersey, netty versions to latest > -- > > Key: NIFI-13308 > URL: https://issues.apache.org/jira/browse/NIFI-13308 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12343) PutElasticsearchJson exception with JSON strings over 20 MB
[
https://issues.apache.org/jira/browse/NIFI-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850474#comment-17850474
]
ASF subversion and git services commented on NIFI-12343:
Commit cbe5f7db9d678518b9846af1150c9b0e55afae1a in nifi's branch
refs/heads/main from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cbe5f7db9d ]
NIFI-12343 Added Max JSON Field String Length for Elasticsearch
This closes #8881
Signed-off-by: David Handermann
> PutElasticsearchJson exception with JSON strings over 20 MB
> ---
>
> Key: NIFI-12343
> URL: https://issues.apache.org/jira/browse/NIFI-12343
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.23.2, 2.0.0-M2
>Reporter: Gregory M. Foreman
>Assignee: Chris Sampson
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
>
> PutElasticsearchJson throws an exception when reading JSON documents that
> contain string fields over 20 MB:
> {code:java}
> PutElasticsearchJson[id=] No FlowFiles successfully parsed for sending to
> Elasticsearch
> PutElasticsearchJson[id=] Could not read FlowFile content valid JSON.:
> com.fasterxml.jackson.core.exc.StreamConstraintsException: String length
> (20050553) exceeds the maximum length (2000)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12343) PutElasticsearchJson exception with JSON strings over 20 MB
[
https://issues.apache.org/jira/browse/NIFI-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12343:
Fix Version/s: 2.0.0-M4
Resolution: Fixed
Status: Resolved (was: Patch Available)
> PutElasticsearchJson exception with JSON strings over 20 MB
> ---
>
> Key: NIFI-12343
> URL: https://issues.apache.org/jira/browse/NIFI-12343
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.23.2, 2.0.0-M2
>Reporter: Gregory M. Foreman
>Assignee: Chris Sampson
>Priority: Major
> Fix For: 2.0.0-M4
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
>
> PutElasticsearchJson throws an exception when reading JSON documents that
> contain string fields over 20 MB:
> {code:java}
> PutElasticsearchJson[id=] No FlowFiles successfully parsed for sending to
> Elasticsearch
> PutElasticsearchJson[id=] Could not read FlowFile content valid JSON.:
> com.fasterxml.jackson.core.exc.StreamConstraintsException: String length
> (20050553) exceeds the maximum length (2000)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12343 allow override of JSON field max string length for PutElasticsearchJson [nifi]
exceptionfactory closed pull request #8881: NIFI-12343 allow override of JSON field max string length for PutElasticsearchJson URL: https://github.com/apache/nifi/pull/8881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619329171 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar + + +org.apache.nifi +nifi-oracle-db-adapter-provider-nar Review Comment: I dont think I realized we had a 'database-adapter-api' and a 'database-adapter-provider-api'. The word 'adapter' is generic/broad as is 'provider' so it just looks odd having them both side by side. I dont know enough about why we need these two separate APIs so I guess I'll back out of this comment for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13284: Only saving canvas routes that are not edit or history [nifi]
rfellows merged PR #8891: URL: https://github.com/apache/nifi/pull/8891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13284) Consider filtering current-canvas-route
[ https://issues.apache.org/jira/browse/NIFI-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850460#comment-17850460 ] ASF subversion and git services commented on NIFI-13284: Commit 0660616864df27a238363036cc2a20414c39fb3b in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0660616864 ] NIFI-13284: (#8891) - Only saving canvas routes that are not edit or history. This closes #8891 > Consider filtering current-canvas-route > --- > > Key: NIFI-13284 > URL: https://issues.apache.org/jira/browse/NIFI-13284 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently, the canvas tracks the current route so the user can be returned to > where they were when returning to the canvas. We should consider filtering > out any `edit` routes so that the user is returned to the place in the canvas > rather then in an Edit dialog. > Since dialogs are only and must be closed prior to using most navigation > controls this won't happen regularly. However a user routes through a Go To > command it will. By filtering out `edit` routes, it may be less confusing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13284) Consider filtering current-canvas-route
[ https://issues.apache.org/jira/browse/NIFI-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13284: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Consider filtering current-canvas-route > --- > > Key: NIFI-13284 > URL: https://issues.apache.org/jira/browse/NIFI-13284 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently, the canvas tracks the current route so the user can be returned to > where they were when returning to the canvas. We should consider filtering > out any `edit` routes so that the user is returned to the place in the canvas > rather then in an Edit dialog. > Since dialogs are only and must be closed prior to using most navigation > controls this won't happen regularly. However a user routes through a Go To > command it will. By filtering out `edit` routes, it may be less confusing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13269) Parameter reference list is randomly ordered or not ordered
[ https://issues.apache.org/jira/browse/NIFI-13269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13269: --- Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Parameter reference list is randomly ordered or not ordered > --- > > Key: NIFI-13269 > URL: https://issues.apache.org/jira/browse/NIFI-13269 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Julien G. >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M4 > > Attachments: Screenshot 2024-05-22 at 3.49.48 PM.png, > image-2024-05-21-11-04-26-571.png, image-2024-05-22-22-12-46-877.png, > legacy.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > When referencing a parameter in a Controller Service, a list of the availabe > parameter is displayed. > In the new UI, the list is randomly ordered or not ordered at all. > !image-2024-05-21-11-04-26-571.png|thumbnail! > It makes it hard to find a parameter. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13269) Parameter reference list is randomly ordered or not ordered
[ https://issues.apache.org/jira/browse/NIFI-13269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850455#comment-17850455 ] ASF subversion and git services commented on NIFI-13269: Commit dbc786095ce229af8d75199c587c84863bbeeef6 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=dbc786095c ] [NIFI-13269] - Order parameter reference list alphabetically (#8885) * [NIFI-13269] - Order parameter reference list alphabetically * ran prettier:format to address minor code style issue * update nfpr and nfel to sort combo entries the same as the combo entries in the property table (case insensitive) This closes #8885 > Parameter reference list is randomly ordered or not ordered > --- > > Key: NIFI-13269 > URL: https://issues.apache.org/jira/browse/NIFI-13269 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Julien G. >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-22 at 3.49.48 PM.png, > image-2024-05-21-11-04-26-571.png, image-2024-05-22-22-12-46-877.png, > legacy.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > When referencing a parameter in a Controller Service, a list of the availabe > parameter is displayed. > In the new UI, the list is randomly ordered or not ordered at all. > !image-2024-05-21-11-04-26-571.png|thumbnail! > It makes it hard to find a parameter. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13269] - Order parameter reference list alphabetically [nifi]
mcgilman merged PR #8885: URL: https://github.com/apache/nifi/pull/8885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) *** Support Processor Details dialog *** Support Connection Details dialog * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About (NIFI-13094) * Show Upstream/Downstream * Align (NIFI-13162) * Replay last event (NIFI-12445) * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version (NIFI-13034) * Consider PG permissions in Toolbox (NIFI-12683) * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Configure Label (NIFI-13081) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Status Bar ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History (NIFI-13047) ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification (NIFI-13247) * Terminate Threads (context menu) (NIFI-13068) * Enable/Disable (context menu/operate panel) (NIFI-13078) * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062) * Download Flow (NIFI-13029) * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color (context menu/operate panel) (NIFI-13226) * Move to Front (NIFI-13044) * Copy/Paste (context menu/operate panel) (NIFI-13059) * Add/Update Info Icons in dialogs throughout the application (NIFI-13092) * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling (NIFI-13104) * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer (NIFI-13100) ** Parameter Contexts
[jira] [Created] (NIFI-13314) Update guides for new UI
Matt Gilman created NIFI-13314: -- Summary: Update guides for new UI Key: NIFI-13314 URL: https://issues.apache.org/jira/browse/NIFI-13314 Project: Apache NiFi Issue Type: Task Components: Documentation Website Reporter: Matt Gilman The new NiFi UI leverages the same general UX as the old UI. However, there are some differences that have evolved as the new UI was built. This Jira is tracking needed changes to the documentation and guides. While is a ton of details in these guides, we should prioritize updating areas where the UX has changed substantially from the old UI. * Managing Remote Ports * Process Group Configuration * Process Group Controller Services * Color Processor/Label * Flow Configuration History Sub-tasks can be added to this Jira for landing each of these updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) *** Support Processor Details dialog *** Support Connection Details dialog * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About (NIFI-13094) * Show Upstream/Downstream * Align (NIFI-13162) * Replay last event (NIFI-12445) * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version (NIFI-13034) * Consider PG permissions in Toolbox (NIFI-12683) * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Configure Label (NIFI-13081) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Status Bar ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History (NIFI-13047) ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification (NIFI-13247) * Terminate Threads (context menu) (NIFI-13068) * Enable/Disable (context menu/operate panel) (NIFI-13078) * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062) * Download Flow (NIFI-13029) * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color (context menu/operate panel) (NIFI-13226) * Move to Front (NIFI-13044) * Copy/Paste (context menu/operate panel) (NIFI-13059) * Add/Update Info Icons in dialogs throughout the application (NIFI-13092) * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling (NIFI-13104) * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer (NIFI-13100) ** Parameter Contexts
[jira] [Created] (NIFI-13313) Replace old UI
Matt Gilman created NIFI-13313: -- Summary: Replace old UI Key: NIFI-13313 URL: https://issues.apache.org/jira/browse/NIFI-13313 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman With the new UI functionally ready and other UIs (documentations, data viewers, etc) no longer depending on the old UI it can now be removed. This Jira is tracking removal of that maven module and any downstream changes. These include updating of LICENSE/NOTICEs that no longer bundle removed dependencies and updating the Jetty Server to only deploy the new UI. The new UI should use "/nifi" context. Existing functionality around authentication where the back end redirects the user to the UI should be verified. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13284: Only saving canvas routes that are not edit or history [nifi]
rfellows commented on PR #8891: URL: https://github.com/apache/nifi/pull/8891#issuecomment-2137990180 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13307) Refactor KeyStoreUtils References using nifi-security-ssl
[
https://issues.apache.org/jira/browse/NIFI-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-13307:
Summary: Refactor KeyStoreUtils References using nifi-security-ssl (was:
Refactor TLS Loading using nifi-security-ssl)
> Refactor KeyStoreUtils References using nifi-security-ssl
> -
>
> Key: NIFI-13307
> URL: https://issues.apache.org/jira/browse/NIFI-13307
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{KeyStoreUtils}} class in {{nifi-security-utils}} contains a large
> number of similar methods for loading keystores and other TLS components. The
> {{nifi-security-ssl}} module contains a streamlined set of builder classes,
> without external dependencies. References to {{KeyStoreUtils}} should be
> refactored to use the newer builder classes to remove unnecessary
> dependencies on {{nifi-security-utils}} and associated transitive
> dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13307) Refactor TLS Loading using nifi-security-ssl
[
https://issues.apache.org/jira/browse/NIFI-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-13307:
Status: Patch Available (was: Open)
> Refactor TLS Loading using nifi-security-ssl
>
>
> Key: NIFI-13307
> URL: https://issues.apache.org/jira/browse/NIFI-13307
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{KeyStoreUtils}} class in {{nifi-security-utils}} contains a large
> number of similar methods for loading keystores and other TLS components. The
> {{nifi-security-ssl}} module contains a streamlined set of builder classes,
> without external dependencies. References to {{KeyStoreUtils}} should be
> refactored to use the newer builder classes to remove unnecessary
> dependencies on {{nifi-security-utils}} and associated transitive
> dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-13301) Create NiFi Processor Marketplace App Powered by NiFi Registry
[
https://issues.apache.org/jira/browse/NIFI-13301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850446#comment-17850446
]
David Handermann commented on NIFI-13301:
-
One general point worth highlighting is that using NiFi Registry as the
supporting storage service for something like this is probably not ideal.
Although NiFi Registry has a number of configurable features, it does not
support clustered deployment for high availability, which would be a vital part
of such a marketplace. As noted in the approach 2, work on alternative Registry
Clients for Flow Definitions, such as GitHub, highlights options for hosting
that do not require running NiFi Registry. Options for hosting component
bundles could include services that provide Maven-style package services.
> Create NiFi Processor Marketplace App Powered by NiFi Registry
> --
>
> Key: NIFI-13301
> URL: https://issues.apache.org/jira/browse/NIFI-13301
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions, NiFi Registry
> Environment: Linux: Ubuntu 20.04 or 22.04
>Reporter: James Guzman (Medel)
>Assignee: James Guzman (Medel)
>Priority: Minor
>
> *Objective:* Improve/enable sharing/reuse of at least two features of Apache
> NiFi, so the community can have an easier time contributing their flows
> and/or custom processors into a NiFi Marketplace:
> * {*}Pre-Designed Flows{*}: (Approach 1) stored in a NiFi Registry or
> accessible location. (Approach 2) NiFi Registry can also substituted by
> NiFi's git registry client having the location of the NiFi Marketplace.
> Thus, we just have a git location and NiFi uses that to find/store flows.
> * *Components/Processors* built in *Java/Python* that anyone is free to use
> * *End to End Full Stack Applications Powered By NiFi or MiNiFi CPP?* The
> frontend could be various ones from PyQT, ReactJS, H2O.ai Wave, 3D Slicer,
> OHIF Viewer, etc: (Maybe this one can be subscription based where users get
> access if they invest in the monthly or yearly subscription?)
> {*}Project Ownership{*}: There will be a clear line that the NiFi Marketplace
> is not owned by the Apache NiFi PMC, rather it will be managed and owned by a
> vendor in close alignment with NiFi, which we will announce at a later time.
>
> {*}Motivation (NiFi){*}: Some people in the community have shown interest in
> having a NiFi Processor Marketplace where they can contribute their category
> of processors. In particular, I saw some people interested in contributing
> their NiFi python processors. This NiFi Processor marketplace could be also
> applied toward the community interested in contributing custom NiFi java
> processors.
> * {*}Extra MiNiFi C+{+}{+}{*}: We could even add a section for MiNiFi C+
> custom processors. There is a part of the MiNiFi build process that brings in
> NiFi through building the JNI extension. So, that is a way to integrate NiFi
> Registry there too.
> I have briefly talked with [~bbende] and [~joewitt] asking them questions on
> ways to bring custom python processors into production. One of the routes was
> through leveraging NiFi Registry in connection with Apache NiFi to streamline
> integration. For my use case, I would leverage the NiFi Processor Marketplace
> to start contributing my AI/DL "Medical Imaging" Pipeline of custom NiFi
> Python Processors where I focused on my master thesis AI/DL for stroke
> diagnosis.
> *High Level Details of NiFi Processor Marketplace App:* For a full stack NiFi
> Processor Marketplace App, there are frameworks we can leverage for the UI
> from ReactJS (this mainly is used for frontend), H2O.ai Wave (this can be
> used for full stack, but probably would mainly be used for the frontend
> portion) and other options. in the case that we want to make something more
> custom to display each category of processors. This full stack application
> could interact wth the NiFi Registry, which is the central location for
> storage and management of shared resources across one or more instances of
> NiFi and/or MiNiFi (C++). What are some hosting options for Apache projects?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-13307 Replace KeyStoreUtils with nifi-security-ssl Builders [nifi]
exceptionfactory opened a new pull request, #8895: URL: https://github.com/apache/nifi/pull/8895 # Summary [NIFI-13307](https://issues.apache.org/jira/browse/NIFI-13307) Replaces `KeyStoreUtils` in `nifi-security-utils` with Builder classes from the `nifi-security-ssl` module. The `nifi-security-ssl` module has no external dependencies and provides specific Builder interfaces and classes to instantiate various TLS components. These classes are already widely used throughout the system, leaving minimal references to `KeyStoreUtils`. In addition, adjusting the custom validation logic in `StandardSSLContextService` reduced unnecessary loading of KeyStore files. Additional changes include removing a number of unused test classes from `nifi-web-api`, some of which had references to `KeyStoreUtils` methods. Other adjustments include relocating the `HashService` and `HashAlgorithm` classes to the `nifi-standard-processors` module, since the `CryptographicHashContent` Processor was the only consumer of these specialized components. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619267802 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar Review Comment: @exceptionfactory Sounds reasonable. I'll try to apply this concept to my PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13301) Create NiFi Processor Marketplace App Powered by NiFi Registry
[
https://issues.apache.org/jira/browse/NIFI-13301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850436#comment-17850436
]
James Guzman (Medel) commented on NIFI-13301:
-
You're welcome. [~joewitt] .
I am happy to help out with this effort in the open source. We can observe some
projects that have done well with community engagement in the open source for
their marketplace apps.
> Create NiFi Processor Marketplace App Powered by NiFi Registry
> --
>
> Key: NIFI-13301
> URL: https://issues.apache.org/jira/browse/NIFI-13301
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions, NiFi Registry
> Environment: Linux: Ubuntu 20.04 or 22.04
>Reporter: James Guzman (Medel)
>Assignee: James Guzman (Medel)
>Priority: Minor
>
> *Objective:* Improve/enable sharing/reuse of at least two features of Apache
> NiFi, so the community can have an easier time contributing their flows
> and/or custom processors into a NiFi Marketplace:
> * {*}Pre-Designed Flows{*}: (Approach 1) stored in a NiFi Registry or
> accessible location. (Approach 2) NiFi Registry can also substituted by
> NiFi's git registry client having the location of the NiFi Marketplace.
> Thus, we just have a git location and NiFi uses that to find/store flows.
> * *Components/Processors* built in *Java/Python* that anyone is free to use
> * *End to End Full Stack Applications Powered By NiFi or MiNiFi CPP?* The
> frontend could be various ones from PyQT, ReactJS, H2O.ai Wave, 3D Slicer,
> OHIF Viewer, etc: (Maybe this one can be subscription based where users get
> access if they invest in the monthly or yearly subscription?)
> {*}Project Ownership{*}: There will be a clear line that the NiFi Marketplace
> is not owned by the Apache NiFi PMC, rather it will be managed and owned by a
> vendor in close alignment with NiFi, which we will announce at a later time.
>
> {*}Motivation (NiFi){*}: Some people in the community have shown interest in
> having a NiFi Processor Marketplace where they can contribute their category
> of processors. In particular, I saw some people interested in contributing
> their NiFi python processors. This NiFi Processor marketplace could be also
> applied toward the community interested in contributing custom NiFi java
> processors.
> * {*}Extra MiNiFi C+{+}{+}{*}: We could even add a section for MiNiFi C+
> custom processors. There is a part of the MiNiFi build process that brings in
> NiFi through building the JNI extension. So, that is a way to integrate NiFi
> Registry there too.
> I have briefly talked with [~bbende] and [~joewitt] asking them questions on
> ways to bring custom python processors into production. One of the routes was
> through leveraging NiFi Registry in connection with Apache NiFi to streamline
> integration. For my use case, I would leverage the NiFi Processor Marketplace
> to start contributing my AI/DL "Medical Imaging" Pipeline of custom NiFi
> Python Processors where I focused on my master thesis AI/DL for stroke
> diagnosis.
> *High Level Details of NiFi Processor Marketplace App:* For a full stack NiFi
> Processor Marketplace App, there are frameworks we can leverage for the UI
> from ReactJS (this mainly is used for frontend), H2O.ai Wave (this can be
> used for full stack, but probably would mainly be used for the frontend
> portion) and other options. in the case that we want to make something more
> custom to display each category of processors. This full stack application
> could interact wth the NiFi Registry, which is the central location for
> storage and management of shared resources across one or more instances of
> NiFi and/or MiNiFi (C++). What are some hosting options for Apache projects?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-13301) Create NiFi Processor Marketplace App Powered by NiFi Registry
[
https://issues.apache.org/jira/browse/NIFI-13301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850435#comment-17850435
]
Joe Witt commented on NIFI-13301:
-
i'd just say someone has to host/maintain/support this thing. Does not have to
be a vendor but I suspect that is the model we can leverage. Other projects
have figured this out we can learn from.. Thanks for capturing James!
> Create NiFi Processor Marketplace App Powered by NiFi Registry
> --
>
> Key: NIFI-13301
> URL: https://issues.apache.org/jira/browse/NIFI-13301
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions, NiFi Registry
> Environment: Linux: Ubuntu 20.04 or 22.04
>Reporter: James Guzman (Medel)
>Assignee: James Guzman (Medel)
>Priority: Minor
>
> *Objective:* Improve/enable sharing/reuse of at least two features of Apache
> NiFi, so the community can have an easier time contributing their flows
> and/or custom processors into a NiFi Marketplace:
> * {*}Pre-Designed Flows{*}: (Approach 1) stored in a NiFi Registry or
> accessible location. (Approach 2) NiFi Registry can also substituted by
> NiFi's git registry client having the location of the NiFi Marketplace.
> Thus, we just have a git location and NiFi uses that to find/store flows.
> * *Components/Processors* built in *Java/Python* that anyone is free to use
> * *End to End Full Stack Applications Powered By NiFi or MiNiFi CPP?* The
> frontend could be various ones from PyQT, ReactJS, H2O.ai Wave, 3D Slicer,
> OHIF Viewer, etc: (Maybe this one can be subscription based where users get
> access if they invest in the monthly or yearly subscription?)
> {*}Project Ownership{*}: There will be a clear line that the NiFi Marketplace
> is not owned by the Apache NiFi PMC, rather it will be managed and owned by a
> vendor in close alignment with NiFi, which we will announce at a later time.
>
> {*}Motivation (NiFi){*}: Some people in the community have shown interest in
> having a NiFi Processor Marketplace where they can contribute their category
> of processors. In particular, I saw some people interested in contributing
> their NiFi python processors. This NiFi Processor marketplace could be also
> applied toward the community interested in contributing custom NiFi java
> processors.
> * {*}Extra MiNiFi C+{+}{+}{*}: We could even add a section for MiNiFi C+
> custom processors. There is a part of the MiNiFi build process that brings in
> NiFi through building the JNI extension. So, that is a way to integrate NiFi
> Registry there too.
> I have briefly talked with [~bbende] and [~joewitt] asking them questions on
> ways to bring custom python processors into production. One of the routes was
> through leveraging NiFi Registry in connection with Apache NiFi to streamline
> integration. For my use case, I would leverage the NiFi Processor Marketplace
> to start contributing my AI/DL "Medical Imaging" Pipeline of custom NiFi
> Python Processors where I focused on my master thesis AI/DL for stroke
> diagnosis.
> *High Level Details of NiFi Processor Marketplace App:* For a full stack NiFi
> Processor Marketplace App, there are frameworks we can leverage for the UI
> from ReactJS (this mainly is used for frontend), H2O.ai Wave (this can be
> used for full stack, but probably would mainly be used for the frontend
> portion) and other options. in the case that we want to make something more
> custom to display each category of processors. This full stack application
> could interact wth the NiFi Registry, which is the central location for
> storage and management of shared resources across one or more instances of
> NiFi and/or MiNiFi (C++). What are some hosting options for Apache projects?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13301) Create NiFi Processor Marketplace App Powered by NiFi Registry
[
https://issues.apache.org/jira/browse/NIFI-13301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated NIFI-13301:
Description:
*Objective:* Improve/enable sharing/reuse of at least two features of Apache
NiFi, so the community can have an easier time contributing their flows and/or
custom processors into a NiFi Marketplace:
* {*}Pre-Designed Flows{*}: (Approach 1) stored in a NiFi Registry or
accessible location. (Approach 2) NiFi Registry can also substituted by NiFi's
git registry client having the location of the NiFi Marketplace. Thus, we just
have a git location and NiFi uses that to find/store flows.
* *Components/Processors* built in *Java/Python* that anyone is free to use
* *End to End Full Stack Applications Powered By NiFi or MiNiFi CPP?* The
frontend could be various ones from PyQT, ReactJS, H2O.ai Wave, 3D Slicer, OHIF
Viewer, etc: (Maybe this one can be subscription based where users get access
if they invest in the monthly or yearly subscription?)
{*}Project Ownership{*}: There will be a clear line that the NiFi Marketplace
is not owned by the Apache NiFi PMC, rather it will be managed and owned by a
vendor in close alignment with NiFi, which we will announce at a later time.
{*}Motivation (NiFi){*}: Some people in the community have shown interest in
having a NiFi Processor Marketplace where they can contribute their category of
processors. In particular, I saw some people interested in contributing their
NiFi python processors. This NiFi Processor marketplace could be also applied
toward the community interested in contributing custom NiFi java processors.
* {*}Extra MiNiFi C+{+}{+}{*}: We could even add a section for MiNiFi C+
custom processors. There is a part of the MiNiFi build process that brings in
NiFi through building the JNI extension. So, that is a way to integrate NiFi
Registry there too.
I have briefly talked with [~bbende] and [~joewitt] asking them questions on
ways to bring custom python processors into production. One of the routes was
through leveraging NiFi Registry in connection with Apache NiFi to streamline
integration. For my use case, I would leverage the NiFi Processor Marketplace
to start contributing my AI/DL "Medical Imaging" Pipeline of custom NiFi Python
Processors where I focused on my master thesis AI/DL for stroke diagnosis.
*High Level Details of NiFi Processor Marketplace App:* For a full stack NiFi
Processor Marketplace App, there are frameworks we can leverage for the UI from
ReactJS (this mainly is used for frontend), H2O.ai Wave (this can be used for
full stack, but probably would mainly be used for the frontend portion) and
other options. in the case that we want to make something more custom to
display each category of processors. This full stack application could interact
wth the NiFi Registry, which is the central location for storage and management
of shared resources across one or more instances of NiFi and/or MiNiFi (C++).
What are some hosting options for Apache projects?
was:
{*}Description (NiFi){*}: Some people in the community have shown interest in
having a NiFi Processor Marketplace where they can contribute their category of
processors. In particular, I saw some people interested in contributing their
NiFi python processors. This NiFi Processor marketplace could be also applied
toward the community interested in contributing custom NiFi java processors.
* {*}Extra MiNiFi C++{*}: We could even add a section for MiNiFi C++ custom
processors. There is a part of the MiNiFi build process that brings in NiFi
through building the JNI extension. So, that is a way to integrate NiFi
Registry there too.
I have briefly talked with [~bbende] and [~joewitt] asking them questions on
ways to bring custom python processors into production. One of the routes was
through leveraging NiFi Registry in connection with Apache NiFi to streamline
integration. For my use case, I would leverage the NiFi Processor Marketplace
to start contributing my AI/DL "Medical Imaging" Pipeline of custom NiFi Python
Processors where I focused on my master thesis AI/DL for stroke diagnosis.
*High Level Details of NiFi Processor Marketplace App:* For a full stack NiFi
Processor Marketplace App, there are frameworks we can leverage for the UI from
ReactJS (this mainly is used for frontend), H2O.ai Wave (this can be used for
full stack, but probably would mainly be used for the frontend portion) and
other options. in the case that we want to make something more custom to
display each category of processors. This full stack application could interact
wth the NiFi Registry, which is the central location for storage and management
of shared resources across one or more instances of NiFi and/or MiNiFi (C++).
What are some hosting options for Apache projects?
> Create NiFi Processor Marketplace App Powered by NiFi
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619227955 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar + + +org.apache.nifi +nifi-oracle-db-adapter-provider-nar Review Comment: I'm fine with removing the word 'provider' from the controller services, but I'm not sure if it's a good practice, since we have actual 'adapter' classes, that are instantiated by the 'provider' classes. If you feel like you have better wording for this concept, then I'm OK with renaming. Or did you mean this 'adapter' - 'provider' abstraction does not seem useful? IMHO it adds some flexibility to how we organize, or combine various adapters, because for example a single controller service for MSSQL can provide adapters for multiple versions of that dialect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13265) Remove the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements
[ https://issues.apache.org/jira/browse/NIFI-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850433#comment-17850433 ] David Handermann commented on NIFI-13265: - [~dstiegli1], for warning cases like that one from PutS3Object, the purpose appears to be including the message, but not the stack trace. In most cases, the full exception should be included in order to log the stack trace, but for certain selected instances, the stack trace is not necessary because the message itself contains enough information for troubleshooting. > Remove the instantiation of Object arrays for arguments in ComponentLog log > and org.slf4j.Logger statements > --- > > Key: NIFI-13265 > URL: https://issues.apache.org/jira/browse/NIFI-13265 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > > There are still classes after the changes in NIFI-12075 and NIFI-12076 which > instantiate an Object array for ComponentLog log statements. This ticket aims > to remove those instantiations. In addition similar changes should be made to > org.slf4j.Logger statements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
exceptionfactory commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619219742 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar Review Comment: For clarification, I think the Service interface should be for an individual dialect, but all the implementations should be packaged in a single NAR. This should allow Apache NiFi-maintained implementations to be distributed easily, but also allow for external development of other implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619203022 ## nifi-extension-bundles/nifi-extension-utils/nifi-database-adapters/nifi-database-adapter-api/pom.xml: ## @@ -0,0 +1,36 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> + +4.0.0 + +org.apache.nifi +nifi-database-adapters +2.0.0-SNAPSHOT + + +nifi-database-adapter-api +jar + + +org.apache.nifi +nifi-utils Review Comment: OK I'll check if I can remove this dependency. I used DBCP CS as a template, while creating these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619200158 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar Review Comment: I was not sure about what granularity would be accaptable. I'm fine with combining them all together in a single controller service. The user could then select the needed dialect from a dropdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13265) Remove the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements
[
https://issues.apache.org/jira/browse/NIFI-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850430#comment-17850430
]
Daniel Stieglitz commented on NIFI-13265:
-
[~exceptionfactory] Thanks for clarifying. How about for something like this in
PutS3Object lines 925-929
{code:java}
getLogger().warn("AccessDenied checking S3 Multipart Upload list for {}: {} " +
"** The configured user does not have the
s3:ListBucketMultipartUploads permission " +
"for this bucket, S3 ageoff cannot occur without
this permission. Next ageoff check " +
"time is being advanced by interval to prevent
checking on every upload **",
new Object[]{bucket, e.getMessage()});
{code}
should i completely remove the parameter for the exception as
{code:java}
getLogger().warn("AccessDenied checking S3 Multipart Upload list for {}: " +
"** The configured user does not have the
s3:ListBucketMultipartUploads permission " +
"for this bucket, S3 ageoff cannot occur without
this permission. Next ageoff check " +
"time is being advanced by interval to prevent
checking on every upload **", bucket, e);
{code}
> Remove the instantiation of Object arrays for arguments in ComponentLog log
> and org.slf4j.Logger statements
> ---
>
> Key: NIFI-13265
> URL: https://issues.apache.org/jira/browse/NIFI-13265
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
>
> There are still classes after the changes in NIFI-12075 and NIFI-12076 which
> instantiate an Object array for ComponentLog log statements. This ticket aims
> to remove those instantiations. In addition similar changes should be made to
> org.slf4j.Logger statements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13299) Prevent negative numbers in concurrent tasks
[ https://issues.apache.org/jira/browse/NIFI-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13299: --- Status: Patch Available (was: In Progress) > Prevent negative numbers in concurrent tasks > > > Key: NIFI-13299 > URL: https://issues.apache.org/jira/browse/NIFI-13299 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > For inputs like concurrent tasks we know that negative values are not > allowed. We should prevent them before the user can submit the form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13299: Adding min validators where appropriate [nifi]
mcgilman opened a new pull request, #8894: URL: https://github.com/apache/nifi/pull/8894 NIFI-13299: - Adding min validators where appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13312) Restructure as an nx monorepo
[ https://issues.apache.org/jira/browse/NIFI-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13312: --- Status: Patch Available (was: In Progress) > Restructure as an nx monorepo > - > > Key: NIFI-13312 > URL: https://issues.apache.org/jira/browse/NIFI-13312 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In preparation for maintaining various ui "apps" in this repo (nifi proper, > documentation, custom ui, ...) we should move to a nx monorepo structure > where nifi is the default project. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13312) Restructure as an nx monorepo
Rob Fellows created NIFI-13312: -- Summary: Restructure as an nx monorepo Key: NIFI-13312 URL: https://issues.apache.org/jira/browse/NIFI-13312 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows In preparation for maintaining various ui "apps" in this repo (nifi proper, documentation, custom ui, ...) we should move to a nx monorepo structure where nifi is the default project. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
bbende commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1619124970
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##
@@ -2104,6 +2203,24 @@ public Response getVersions(
return
generateOkResponse(versionedFlowSnapshotMetadataSetEntity).build();
}
+private static FlowComparisonEntity limitDifferences(final
FlowComparisonEntity original, final int offset, final int limit) {
+final List limited =
PaginationHelper.paginateByContainedItems(
+original.getComponentDifferences(), offset, limit,
ComponentDifferenceDTO::getDifferences, FlowResource::limitDifferences);
+final FlowComparisonEntity result = new FlowComparisonEntity();
+result.setComponentDifferences(new HashSet<>(limited));
+return result;
+}
+
+private static ComponentDifferenceDTO limitDifferences(final
ComponentDifferenceDTO original, final List partial) {
+final ComponentDifferenceDTO result = new ComponentDifferenceDTO();
+result.setComponentType(original.getComponentType());
+result.setComponentId(original.getComponentId());
+result.setComponentName(original.getComponentName());
+result.setProcessGroupId(original.getProcessGroupId());
+result.setDifferences(partial);
+return result;
+}
Review Comment:
Just want to ask whether we think we truly need paging here. Generally most
of NiFi's REST APIs don't page anything, and all of the paging is done on the
client side. The reason is because the slow part is not sending a large
response from server to client, it is the rendering of the whole response on
the client. So as long as the client is rendering pages, it usually works
totally fine.
If we do want paging, then shouldn't the entity being returned contain some
paging info? At a minimum I would think we need to return the total rows in the
result set, otherwise how can a client know when to page to?
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##
@@ -2057,6 +2062,100 @@ public Response getDetails(
return generateOkResponse(flowDetails).build();
}
+@GET
+@Consumes(MediaType.WILDCARD)
+@Produces(MediaType.APPLICATION_JSON)
+
@Path("registries/{registry-id}/branches/{branch-id-a}/buckets/{bucket-id-a}/flows/{flow-id-a}/{version-a}/diff/branches/{branch-id-b}/buckets/{bucket-id-b}/flows/{flow-id-b}/{version-b}")
Review Comment:
Is the intended use case for this to right-click on a process group under
version control and be able to choose something like `Compare With` and then
choose another version to compare with? is there any other scenario where we
want to compare two flow versions?
I'm asking because if it is limited to the first scenario I described, we
may want to consider a more specific API to the PG, similar to
`process-groups/{id}local-changes`, maybe `/process-groups/{id}/diff`. Then it
would only need the parameters for the other flow version to compare to, which
could be added to the path, or as query params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
bbende commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1619117358
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##
@@ -2057,6 +2062,100 @@ public Response getDetails(
return generateOkResponse(flowDetails).build();
}
+@GET
+@Consumes(MediaType.WILDCARD)
+@Produces(MediaType.APPLICATION_JSON)
+
@Path("registries/{registry-id}/branches/{branch-id-a}/buckets/{bucket-id-a}/flows/{flow-id-a}/{version-a}/diff/branches/{branch-id-b}/buckets/{bucket-id-b}/flows/{flow-id-b}/{version-b}")
Review Comment:
Is the intended use case for this to right-click on a process group under
version control and be able to choose something like `Compare With` and then
choose another version to compare with? is there any other scenario where we
want to compare two flow versions?
I'm asking because if it is limited to the first scenario I described, we
may want to consider a more specific API to the PG, similar to
`process-groups/{id}/local-changes`, maybe `/process-groups/{id}/diff`. Then it
would only need the parameters for the other flow version to compare to, which
could be added to the path, or as query params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-2388 Fix warnings on Windows build [nifi-minifi-cpp]
lordgamez opened a new pull request, #1805: URL: https://github.com/apache/nifi-minifi-cpp/pull/1805 https://issues.apache.org/jira/browse/MINIFICPP-2388 Depends on https://github.com/apache/nifi-minifi-cpp/pull/1802 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet
[ https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850403#comment-17850403 ] Daniel Stieglitz commented on NIFI-13304: - [~iiojj2] I believe I understand you now. I was thinking, would a new processor (e.g. SplitExcelSpreadsheet or SplitExcel) which will split up the original worksheet work for your use case? In other words for N sheets, this new processor would create N new worksheets where each worksheet has a single sheet. > ExcelReader - ability to split into flowfile per sheet > -- > > Key: NIFI-13304 > URL: https://issues.apache.org/jira/browse/NIFI-13304 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Philipp Korniets >Priority: Major > > Currently ConvertExcelToCSV processor, if processing excel with multiple > required sheets in it, produces flowfile per sheet. > New ExcelReader produces one flowfile with all data in it > > There should be a way to configure output to be sheet-per-flowfile > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619060507 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar + + +org.apache.nifi +nifi-oracle-db-adapter-provider-nar Review Comment: Is the word 'provider' helpful in these? It seems to me we have database adapter api and database adapters that implement the api. Ie we have nifi-database-adapter-api is the api module. nifi-oracle-db-adapter-nar implements the api specific to oracle column/types. Provider seems not needed. Can you share more if that is helpful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619054989 ## nifi-extension-bundles/nifi-extension-utils/nifi-database-adapters/nifi-database-adapter-api/pom.xml: ## @@ -0,0 +1,36 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> + +4.0.0 + +org.apache.nifi +nifi-database-adapters +2.0.0-SNAPSHOT + + +nifi-database-adapter-api +jar + + +org.apache.nifi +nifi-utils Review Comment: Can we dump this since commons-lang is there? it seems nifi-utils is being used for a simple string utils class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13231 Added Private key authentication for GitHubFlowRegistryClient [nifi]
exceptionfactory commented on code in PR #8890:
URL: https://github.com/apache/nifi/pull/8890#discussion_r1618922463
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -128,7 +128,22 @@ public class GitHubFlowRegistryClient extends
AbstractFlowRegistryClient {
.sensitive(true)
.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.APP_INSTALLATION_TOKEN.name())
.build();
-
+static final PropertyDescriptor PRIVATE_KEY = new
PropertyDescriptor.Builder()
+.name("Private Key")
+.description("Private RSA key generated foo Github App to use for
Authentication")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.sensitive(true)
+.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.PRIVATE_KEY.name())
+.build();
+static final PropertyDescriptor APP_ID = new PropertyDescriptor.Builder()
+.name("APP ID")
Review Comment:
```suggestion
.name("App ID")
```
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -128,7 +128,22 @@ public class GitHubFlowRegistryClient extends
AbstractFlowRegistryClient {
.sensitive(true)
.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.APP_INSTALLATION_TOKEN.name())
.build();
-
+static final PropertyDescriptor PRIVATE_KEY = new
PropertyDescriptor.Builder()
+.name("Private Key")
+.description("Private RSA key generated foo Github App to use for
Authentication")
Review Comment:
Recommend the following wording adjustments, also noting that PKCS 8 is
required.
```suggestion
.description("RSA private key associated with GitHub App to use
for authentication. The private key must be PEM-encoded using PKCS 8.")
```
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -128,7 +128,22 @@ public class GitHubFlowRegistryClient extends
AbstractFlowRegistryClient {
.sensitive(true)
.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.APP_INSTALLATION_TOKEN.name())
.build();
-
+static final PropertyDescriptor PRIVATE_KEY = new
PropertyDescriptor.Builder()
+.name("Private Key")
+.description("Private RSA key generated foo Github App to use for
Authentication")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.sensitive(true)
+.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.PRIVATE_KEY.name())
+.build();
+static final PropertyDescriptor APP_ID = new PropertyDescriptor.Builder()
+.name("APP ID")
+.description("App Id of Github App to use for Authentication")
Review Comment:
```suggestion
.description("Identifier of GitHub App to use for
authentication")
```
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubRepositoryClient.java:
##
@@ -35,10 +40,11 @@
import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.InputStream;
-import java.util.List;
-import java.util.Objects;
-import java.util.Optional;
-import java.util.Set;
+import java.io.StringReader;
+import java.security.KeyFactory;
+import java.security.PrivateKey;
+import java.security.spec.PKCS8EncodedKeySpec;
+import java.util.*;
Review Comment:
Asterisk imports are not permitted in the the Checkstyle configuration.
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubRepositoryClient.java:
##
@@ -379,6 +392,41 @@ public GHContent deleteContent(final String filePath,
final String commitMessage
});
}
+/**
+ * Creates the JwtToken for Authentication with Private Key
+ *
+ * @param pemString is the PKCS#1 String
+ * @return the JwtToken
+ *
+ * @throws Exception if an error occurs parsing key
+ */
+private static String loadPrivateKeyFromPEM(String pemString) throws
Exception {
+long nowMillis = System.currentTimeMillis();
+long expMillis = nowMillis + 60; // Token validity 10 minutes
+Date now = new Date(nowMillis);
+Date exp = new Date(expMillis);
+PEMParser pemParser = new PEMParser(new StringReader(pemString));
+Object object = pemParser.readObject();
+pemParser.close();
+
+if (object instanceof PEMKeyPair) {
+PEMKeyPair keyPair = (PEMKeyPair) object;
+RSAPrivateKey rsaPrivateKey =
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619049108 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar Review Comment: Can you share more about the benefit of each of these being their own nar? If i understand each nar correctly it does not contain provider specific things like mssql/etc.. So it seems like they can all be together. If something had bespoke requirements splitting them is good. Can you share more on what you had in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13126: Add Impala DB Adapter [nifi]
takraj commented on PR #8728: URL: https://github.com/apache/nifi/pull/8728#issuecomment-2137622470 @mattyb149 @joewitt I have created a PoC / PR implementing the concept of having controller services instead of fixed lists of supported SQL dialects. If we accept this solution, then Impala dialect is not necessarily needed to be included & maintained in the NiFi repository. Please have a look: https://github.com/apache/nifi/pull/8892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj opened a new pull request, #8892: URL: https://github.com/apache/nifi/pull/8892 # Summary [NIFI-13311](https://issues.apache.org/jira/browse/NIFI-13311) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### UI Contributions - [x] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13311) Turn DB adapters into controller services
Rajmund Takacs created NIFI-13311: - Summary: Turn DB adapters into controller services Key: NIFI-13311 URL: https://issues.apache.org/jira/browse/NIFI-13311 Project: Apache NiFi Issue Type: Improvement Components: Extensions Affects Versions: 2.0.0-M3, 2.0.0-M2, 2.0.0-M1 Reporter: Rajmund Takacs Assignee: Rajmund Takacs Most of the SQL processors have a property now, where the user is supposed to select a dialect their database understands. The list of supported dialects is currently hard-coded into the standard processors, and therefore there is no way to add a new one as an end-user, without forking NiFi. On the other hand, the user is allowed to supply their own DBCP controller service, by just dropping in the nar. So having a fixed list of supported SQL dialects is a serious limitation, since the user can have an unsupported database, and while they can create the necessary DBCP, they cannot add support for the dialect. We could resolve this problem by turning these fixed lists into controller services, so letting users fully interfacing NiFi with their own database. With NiFi 2.x, there is a property migration framework, that could be utilized in order to avoid breaking existing flows after upgrade. For 1.x line, we could probably introduce an option to pick the controller service too, by having an option in these fixed lists like 'Use Controller Service'. This could also be the default option, educating existing users. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13299) Prevent negative numbers in concurrent tasks
[ https://issues.apache.org/jira/browse/NIFI-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-13299: -- Assignee: Matt Gilman > Prevent negative numbers in concurrent tasks > > > Key: NIFI-13299 > URL: https://issues.apache.org/jira/browse/NIFI-13299 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > For inputs like concurrent tasks we know that negative values are not > allowed. We should prevent them before the user can submit the form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
briansolo1985 commented on PR #: URL: https://github.com/apache/nifi/pull/#issuecomment-2137473601 Thanks for submitting the change and incorporating the suggestions. +1 from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13284) Consider filtering current-canvas-route
[ https://issues.apache.org/jira/browse/NIFI-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13284: --- Status: Patch Available (was: In Progress) > Consider filtering current-canvas-route > --- > > Key: NIFI-13284 > URL: https://issues.apache.org/jira/browse/NIFI-13284 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently, the canvas tracks the current route so the user can be returned to > where they were when returning to the canvas. We should consider filtering > out any `edit` routes so that the user is returned to the place in the canvas > rather then in an Edit dialog. > Since dialogs are only and must be closed prior to using most navigation > controls this won't happen regularly. However a user routes through a Go To > command it will. By filtering out `edit` routes, it may be less confusing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13310) Fix duplicate rat plugin declaration in jolt transform module
Joe Witt created NIFI-13310: --- Summary: Fix duplicate rat plugin declaration in jolt transform module Key: NIFI-13310 URL: https://issues.apache.org/jira/browse/NIFI-13310 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.nifi:nifi-jolt-transform-json-ui:war:2.0.0-SNAPSHOT [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.rat:apache-rat-plugin @ line 209, column 21 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13303) Remove text indicating property verification is disabled
[ https://issues.apache.org/jira/browse/NIFI-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13303: --- Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Remove text indicating property verification is disabled > > > Key: NIFI-13303 > URL: https://issues.apache.org/jira/browse/NIFI-13303 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M4 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The text "Property verification is disabled" is extraneous. Don't display it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13269] - Order parameter reference list alphabetically [nifi]
mcgilman commented on PR #8885: URL: https://github.com/apache/nifi/pull/8885#issuecomment-2137363552 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13303) Remove text indicating property verification is disabled
[ https://issues.apache.org/jira/browse/NIFI-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850363#comment-17850363 ] ASF subversion and git services commented on NIFI-13303: Commit 82cd1e5ef0f98a4e21c1cfbf6cffd58e848fc7e9 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=82cd1e5ef0 ] [NIFI-13303] - Remove text indicating property verification is disabled. (#8884) This closes #8884 > Remove text indicating property verification is disabled > > > Key: NIFI-13303 > URL: https://issues.apache.org/jira/browse/NIFI-13303 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The text "Property verification is disabled" is extraneous. Don't display it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13303] - Remove text indicating property verification is disabled. [nifi]
mcgilman merged PR #8884: URL: https://github.com/apache/nifi/pull/8884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
rfellows commented on code in PR #8870:
URL: https://github.com/apache/nifi/pull/8870#discussion_r1618830563
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/tooltips/nifi-tooltip.directive.ts:
##
@@ -58,11 +59,29 @@ export class NifiTooltipDirective implements OnDestroy {
}
}
+@HostListener('mousemove')
+mouseMove() {
+if (this.overlayRef?.hasAttached() && this.tooltipDisabled) {
+this.overlayRef?.detach();
+} else {
+this.attach();
Review Comment:
I don't think this attach is needed. In fact it causes console errors...
https://github.com/apache/nifi/assets/713866/e9060af1-ddb5-44f5-9e24-9089513668e4;>
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/tooltips/nifi-tooltip.directive.ts:
##
@@ -58,11 +59,29 @@ export class NifiTooltipDirective implements OnDestroy {
}
}
+@HostListener('mousemove')
+mouseMove() {
+if (this.overlayRef?.hasAttached() && this.tooltipDisabled) {
+this.overlayRef?.detach();
+} else {
+this.attach();
+}
+}
+
+@HostListener('mouseup')
+mouseup() {
+this.attach();
Review Comment:
Nice touch but i think this should also be guarded. It currently can cause
an error (similar to the above) if you mousedown outside of the target object
and then mouseup over it. The tooltip will render based on the mouseenter and
then try to attach another on the mouseup.
```suggestion
if (!this.overlayRef?.hasAttached()) {
this.attach();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13303] - Remove text indicating property verification is disabled. [nifi]
mcgilman commented on PR #8884: URL: https://github.com/apache/nifi/pull/8884#issuecomment-2137298095 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
ferencerdei commented on code in PR #:
URL: https://github.com/apache/nifi/pull/#discussion_r1618793587
##
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##
@@ -257,6 +257,10 @@ private void mapCompatibleBundles(final DataFlow
proposedFlow, final ExtensionMa
final Set missingComponentIds =
proposedFlow.getMissingComponents();
final VersionedDataflow dataflow = proposedFlow.getVersionedDataflow();
+if (dataflow == null) {
Review Comment:
changed it to use the recommended method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
simonbence commented on code in PR #:
URL: https://github.com/apache/nifi/pull/#discussion_r1618732933
##
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##
@@ -257,6 +257,10 @@ private void mapCompatibleBundles(final DataFlow
proposedFlow, final ExtensionMa
final Set missingComponentIds =
proposedFlow.getMissingComponents();
final VersionedDataflow dataflow = proposedFlow.getVersionedDataflow();
+if (dataflow == null) {
Review Comment:
I propose the usage of the `isFlowEmpty`method here, which covers more
possible variations for an empty `dataFlow`. I tested it via standard NiFi and
it worked properly during initial startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (NIFI-13231) Update GitHubFlowRegistryClient to generate App Installation Token
[ https://issues.apache.org/jira/browse/NIFI-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850286#comment-17850286 ] Vansh Chaudhary edited comment on NIFI-13231 at 5/29/24 11:40 AM: -- Hi [~exceptionfactory] , I've added the authentication with Private key. can you check and review , I've added method to generate Token since JWTTokenProvider didn't process PKCS#1 keys. [https://github.com/apache/nifi/compare/main...maybevanshh:nifi:main] was (Author: JIRAUSER305277): Hi [~exceptionfactory] , I've added the authentication with Private key. can you check and review before i raise the pr request? https://github.com/apache/nifi/compare/main...maybevanshh:nifi:main > Update GitHubFlowRegistryClient to generate App Installation Token > -- > > Key: NIFI-13231 > URL: https://issues.apache.org/jira/browse/NIFI-13231 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Brian Ghigiarelli >Assignee: Vansh Chaudhary >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The new GitHubFlowRegistryClient accepts two types of authentication: > # Personal Access Token > # App Installation Token > The App Installation Token requires the user to input the token as a > property, then uses that to communicate with GitHub. However, this token is > short-lived and would require frequent updates (~hourly). > Instead of directly providing the token, the GitHubFlowRegistryClient should > accept as properties: > # App ID > # Private Key (PEM text format) > and use these values to generate a short-lived token, following the guide at > https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#generating-a-json-web-token-jwt -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
simonbence commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1618730811
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/Interval.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+public interface Interval {
+
+enum RelativePosition {
+/**
+ * The compared interval ends before the actual, there is no
intersection.
+ */
+BEFORE,
+
+/**
+ * The compared interval exceeds the actual both at the low and high
ends.
+ */
+EXCEEDS,
+
+/**
+ * The compared interval's tail (but not the whole interval)
intersects the actual interval (part of it or the whole actual interval).
+ */
+TAIL_INTERSECTS,
+
+/**
+ * The compared interval is within the actual interval. It can match
with the actual or contained by that.
+ */
+WITHIN,
+
+/**
+ *The compared interval's head (but not the whole interval) intersects
the actual interval (part of it or the whole actual interval).
+ */
+HEAD_INTERSECTS,
+
+/**
+ * The compared interval starts after the actual, there is no
intersection.
+ */
+AFTER,
+}
+
+/**
+ * Relative position of the "other" interval compared to this.
+ *
+ * @param otherIntervalLowerBoundary Lower boundary of the compared
interval.
+ * @param otherIntervalHigherBoundary Higher boundary of the compared
interval.
+ *
+ * @return Returns the relative position of the "other" interval compared
to this interval. For example: if the result
+ * is BEFORE, read it as: the other interval ends BEFORE the
actual (and there is no intersection between them).
+ */
+RelativePosition getRelativePositionOf(final int
otherIntervalLowerBoundary, final int otherIntervalHigherBoundary);
+
+/**
+ * @return Returns an interval instance with closed low and open high
boundary.
+ */
+static Interval getClosedOpenInterval(final int lowerBoundary, final int
higherBoundary) {
Review Comment:
I slightly disagree with this primarily because of the static method usage
but I have no strong feelings about it. Please expect a commit soonish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-2390 Save build type and build dir in python bootstrap state [nifi-minifi-cpp]
lordgamez opened a new pull request, #1804: URL: https://github.com/apache/nifi-minifi-cpp/pull/1804 https://issues.apache.org/jira/browse/MINIFICPP-2390 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2390) Save build type and build dir in python bootstrap state
Gábor Gyimesi created MINIFICPP-2390: Summary: Save build type and build dir in python bootstrap state Key: MINIFICPP-2390 URL: https://issues.apache.org/jira/browse/MINIFICPP-2390 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13231 Added Private key authentication for GitHubFlowRegistryClient [nifi]
maybevanshh opened a new pull request, #8890: URL: https://github.com/apache/nifi/pull/8890 # Summary [NIFI-13231](https://issues.apache.org/jira/browse/NIFI-13231) This PR adds function to Generate Jwt Token in GitHubFlowRegistryClient and PrivateKey Authentication support. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added Private key authentication for GitHubFlowRegistryClient [nifi]
maybevanshh closed pull request #8889: Added Private key authentication for GitHubFlowRegistryClient URL: https://github.com/apache/nifi/pull/8889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Added Private key authentication for GitHubFlowRegistryClient [nifi]
maybevanshh opened a new pull request, #8889: URL: https://github.com/apache/nifi/pull/8889 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
ferencerdei opened a new pull request, #: URL: https://github.com/apache/nifi/pull/ # Summary [NIFI-13309](https://issues.apache.org/jira/browse/NIFI-13309) This change modifies the VersionedFlowSyncronizer to call mapCompatibleBundles even if the original flow was empty. An additional null check was added to the proposed dataFlow instead to prevent exception during NiFi startup. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13309) MiNiFi flow update fails to lookup compatible bundles
Ferenc Erdei created NIFI-13309:
---
Summary: MiNiFi flow update fails to lookup compatible bundles
Key: NIFI-13309
URL: https://issues.apache.org/jira/browse/NIFI-13309
Project: Apache NiFi
Issue Type: Bug
Components: MiNiFi
Affects Versions: 2.0.0-M3, 2.0.0-M2, 2.0.0-M1
Reporter: Ferenc Erdei
Assignee: Ferenc Erdei
Fix For: 2.0.0-M4
h3. Issue
Publishing a MiNiFi flow that was designed with not the same manifest version
as the current MiNiFi runtime use causes flow update failure.
Steps to reproduce:
* Design a Flow with the previous NiFi version
* Publish that flow through C2 Server
h3. Expected behaviour
The flow should be loaded with the compatible bundles.
h3. Actual behaviour
Exceptions in logs:
{noformat}
2024-05-29 11:43:43,872 INFO [pool-15-thread-1]
o.a.n.f.s.StandardVersionedComponentSynchronizer Added
GhostProcessor[id=f4d7586c-d575-4255-bbe1-c0f7b129a7ea] to
StandardProcessGroup[identifier=7072239a-c047-4d5e-8e68-cd2cbc651343,name=root]
2024-05-29 11:43:43,872 ERROR [pool-15-thread-1]
o.a.nifi.controller.ExtensionBuilder Could not create Processor of type
org.apache.nifi.processors.standard.GenerateFlowFile for ID
d7c7463f-beaf-4122-b7af-581a41740512 due to:
org.apache.nifi.processors.standard.GenerateFlowFile; creating "Ghost"
implementation{noformat}
And Flow is reverted to the previous flow.
h3. Root cause
We have a condition in
[https://github.com/apache/nifi/blob/main/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java#L170]
for the existing flow, but we should have a null check for the proposed, and
map the compatible bundles even if the old flow was empty.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
pgyori commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1618578862
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/Interval.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+public interface Interval {
+
+enum RelativePosition {
+/**
+ * The compared interval ends before the actual, there is no
intersection.
+ */
+BEFORE,
+
+/**
+ * The compared interval exceeds the actual both at the low and high
ends.
+ */
+EXCEEDS,
+
+/**
+ * The compared interval's tail (but not the whole interval)
intersects the actual interval (part of it or the whole actual interval).
+ */
+TAIL_INTERSECTS,
+
+/**
+ * The compared interval is within the actual interval. It can match
with the actual or contained by that.
+ */
+WITHIN,
+
+/**
+ *The compared interval's head (but not the whole interval) intersects
the actual interval (part of it or the whole actual interval).
+ */
+HEAD_INTERSECTS,
+
+/**
+ * The compared interval starts after the actual, there is no
intersection.
+ */
+AFTER,
+}
+
+/**
+ * Relative position of the "other" interval compared to this.
+ *
+ * @param otherIntervalLowerBoundary Lower boundary of the compared
interval.
+ * @param otherIntervalHigherBoundary Higher boundary of the compared
interval.
+ *
+ * @return Returns the relative position of the "other" interval compared
to this interval. For example: if the result
+ * is BEFORE, read it as: the other interval ends BEFORE the
actual (and there is no intersection between them).
+ */
+RelativePosition getRelativePositionOf(final int
otherIntervalLowerBoundary, final int otherIntervalHigherBoundary);
+
+/**
+ * @return Returns an interval instance with closed low and open high
boundary.
+ */
+static Interval getClosedOpenInterval(final int lowerBoundary, final int
higherBoundary) {
Review Comment:
I understand your thought that since there is a finite number of
combinations of boundaries, the interface could have methods for instantiating
each combination and would not need to expose which implementing class is used.
However, this current implementation violates 3 of the SOLID principles, namely:
- Single Responsibility: the interface now not only defines the capabilities
of an Interval, but is also responsible for creating instances.
- Open-Closed Principle: Adding new implementations other than
ClosedOpenInterval requires modification of Interval (to add new factory
methods or modify exiting one(s)).
- Dependency Inversion: currently the interface depends on the implementing
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-13231) Update GitHubFlowRegistryClient to generate App Installation Token
[ https://issues.apache.org/jira/browse/NIFI-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850286#comment-17850286 ] Vansh Chaudhary commented on NIFI-13231: Hi [~exceptionfactory] , I've added the authentication with Private key. can you check and review before i raise the pr request? https://github.com/apache/nifi/compare/main...maybevanshh:nifi:main > Update GitHubFlowRegistryClient to generate App Installation Token > -- > > Key: NIFI-13231 > URL: https://issues.apache.org/jira/browse/NIFI-13231 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Brian Ghigiarelli >Assignee: Vansh Chaudhary >Priority: Major > > The new GitHubFlowRegistryClient accepts two types of authentication: > # Personal Access Token > # App Installation Token > The App Installation Token requires the user to input the token as a > property, then uses that to communicate with GitHub. However, this token is > short-lived and would require frequent updates (~hourly). > Instead of directly providing the token, the GitHubFlowRegistryClient should > accept as properties: > # App ID > # Private Key (PEM text format) > and use these values to generate a short-lived token, following the guide at > https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#generating-a-json-web-token-jwt -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] libminifi: Rename mutex_ to mtx_ member of ConcurrentQueue [nifi-minifi-cpp]
lordgamez commented on PR #1803: URL: https://github.com/apache/nifi-minifi-cpp/pull/1803#issuecomment-2136692854 Hi @kraj, thanks for the contribution! Please create an jira ticket in the Apache Jira system under the [MiNiFi C++ project](https://issues.apache.org/jira/projects/MINIFICPP/) and include the MINIFICPP- ticket number in the PR title. If you do not have Jira access yet you can request access here: https://selfserve.apache.org/jira-account.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
