Re: [PR] MINIFICPP-2346-P1: Integrated Conan2 for OpenSSL, CURL, ZLIB & Build MiNiFi [nifi-minifi-cpp]

2024-05-30 Thread via GitHub


james94 commented on PR #1793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#issuecomment-2141170468

   @szaszm @martinzink @lordgamez just checking in, anything I can do to help 
speed up testing toward this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13326) UI web token (JWT) decoding error

2024-05-30 Thread Night Gryphon (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Night Gryphon updated NIFI-13326:
-
Description: 
With some combinations of JWT contents UI can not decode received JWT because 
different base64 modifications are used by server and client.

At the server side JWT is generated using URL-SAFE base64 encoding which 
replace '+' and '/' characters with '-' and '_' respectively.

But at UI side JWT is decoded with JQuery standard base64 decode function as 
regular non URL-Safe data and '-' and '_' characters are dropped by incoming 
filter which corrupts encoded data.

The error is within getJwtPayload() function located at
 * 
nifi-framework-bundle\nifi-framework\nifi-web\nifi-web-frontend\src\main\nifi\src\app\service\auth.service.ts
 * 
nifi-registry\nifi-registry-core\nifi-registry-web-ui\src\main\webapp\services\nf-storage.service.js

Function getJwtPayload() calls JQuery base64 atob() function without appopriate 
JWT data preparation by replacing '-' and '_' characters back to '+' and '/'. 
This cause JWT data loss and javascript fails at parsing JWT json data

The example of affected UI script is nf-login-all.js which fails after 
successful user login and receiving token 

 

  was:
With some combinations of JWT contents UI can not decode received JWT because 
different base64 modifications are used by server and client.

At the server side JWT is generated using URL-SAFE base64 encoding which 
replace '+' and '/' characters with '-' and '_' respectively.

But at UI side JWT is decoded with JQuery standard base64 decode function as 
regular non URL-Safe data and '-' and '_' characters are dropped by incoming 
filter which corrupts encoded data.

The error is within getJwtPayload() function located at
 * 
nifi-framework-bundle\nifi-framework\nifi-web\nifi-web-frontend\src\main\nifi\src\app\service\auth.service.ts
 * 
nifi-registry\nifi-registry-core\nifi-registry-web-ui\src\main\webapp\services\nf-storage.service.js

Function getJwtPayload() calls JQuery base64 atob() function without appopriate 
JWT data preparation by replacing '-' and '_' characters back to '+' and '/'. 
This cause JWT data loss and javascript fails at decoding JWT json data

The example of affected UI script is nf-login-all.js which fails after 
successful user login and receiving token 

 


> UI web token (JWT) decoding error
> -
>
> Key: NIFI-13326
> URL: https://issues.apache.org/jira/browse/NIFI-13326
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 2.0.0-M2, 2.0.0-M3
> Environment: Linux Ubuntu 22.04
>Reporter: Night Gryphon
>Priority: Major
>
> With some combinations of JWT contents UI can not decode received JWT because 
> different base64 modifications are used by server and client.
> At the server side JWT is generated using URL-SAFE base64 encoding which 
> replace '+' and '/' characters with '-' and '_' respectively.
> But at UI side JWT is decoded with JQuery standard base64 decode function as 
> regular non URL-Safe data and '-' and '_' characters are dropped by incoming 
> filter which corrupts encoded data.
> The error is within getJwtPayload() function located at
>  * 
> nifi-framework-bundle\nifi-framework\nifi-web\nifi-web-frontend\src\main\nifi\src\app\service\auth.service.ts
>  * 
> nifi-registry\nifi-registry-core\nifi-registry-web-ui\src\main\webapp\services\nf-storage.service.js
> Function getJwtPayload() calls JQuery base64 atob() function without 
> appopriate JWT data preparation by replacing '-' and '_' characters back to 
> '+' and '/'. This cause JWT data loss and javascript fails at parsing JWT 
> json data
> The example of affected UI script is nf-login-all.js which fails after 
> successful user login and receiving token 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13326) UI web token (JWT) decoding error

2024-05-30 Thread Night Gryphon (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Night Gryphon updated NIFI-13326:
-
Description: 
With some combinations of JWT contents UI can not decode received JWT because 
different base64 modifications are used by server and client.

At the server side JWT is generated using URL-SAFE base64 encoding which 
replace '+' and '/' characters with '-' and '_' respectively.

But at UI side JWT is decoded with JQuery standard base64 decode function as 
regular non URL-Safe data and '-' and '_' characters are dropped by incoming 
filter which corrupts encoded data.

The error is within getJwtPayload() function located at
 * 
nifi-framework-bundle\nifi-framework\nifi-web\nifi-web-frontend\src\main\nifi\src\app\service\auth.service.ts
 * 
nifi-registry\nifi-registry-core\nifi-registry-web-ui\src\main\webapp\services\nf-storage.service.js

Function getJwtPayload() calls JQuery base64 atob() function without appopriate 
JWT data preparation by replacing '-' and '_' characters back to '+' and '/'. 
This cause JWT data loss and javascript fails at decoding JWT json data

The example of affected UI script is nf-login-all.js which fails after 
successful user login and receiving token 

 

  was:
With some combinations of JWT contents UI can not decode received JWT because 
different base64 modifications are used by server and client.

At the server side JWT is generated using URL-SAFE base64 encoding which 
replace '+' and '/' characters with '-' and '_' respectively.

But at UI side JWT is decoded with JQuery standard base64 decode function as 
regular non URL-Safe data and '-' and '_' characters are dropped by incoming 
filter which corrupts encoded data.

As an example the UI script nf-login-all.js (and some other) declare function 
getJwtPayload which call JQuery base 64 decode without appopriate JWT data 
preparation by replacing '-' and '_' characters back to '+' and '/'. This cause 
JWT data loss and javascript fails at decoding JWT json data

 


> UI web token (JWT) decoding error
> -
>
> Key: NIFI-13326
> URL: https://issues.apache.org/jira/browse/NIFI-13326
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 2.0.0-M2, 2.0.0-M3
> Environment: Linux Ubuntu 22.04
>Reporter: Night Gryphon
>Priority: Major
>
> With some combinations of JWT contents UI can not decode received JWT because 
> different base64 modifications are used by server and client.
> At the server side JWT is generated using URL-SAFE base64 encoding which 
> replace '+' and '/' characters with '-' and '_' respectively.
> But at UI side JWT is decoded with JQuery standard base64 decode function as 
> regular non URL-Safe data and '-' and '_' characters are dropped by incoming 
> filter which corrupts encoded data.
> The error is within getJwtPayload() function located at
>  * 
> nifi-framework-bundle\nifi-framework\nifi-web\nifi-web-frontend\src\main\nifi\src\app\service\auth.service.ts
>  * 
> nifi-registry\nifi-registry-core\nifi-registry-web-ui\src\main\webapp\services\nf-storage.service.js
> Function getJwtPayload() calls JQuery base64 atob() function without 
> appopriate JWT data preparation by replacing '-' and '_' characters back to 
> '+' and '/'. This cause JWT data loss and javascript fails at decoding JWT 
> json data
> The example of affected UI script is nf-login-all.js which fails after 
> successful user login and receiving token 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13326) UI web token (JWT) decoding error

2024-05-30 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850875#comment-17850875
 ] 

David Handermann commented on NIFI-13326:
-

Thanks for highlighting this issue [~nightgryphon]. It is worth noting that the 
new UI no longer decodes the JWT, and the current {{nifi-web-ui}} is slated for 
removal in the next milestone release of 2.0.0. For that reason, this should be 
effectively resolved soon with the transition to the new UI.

> UI web token (JWT) decoding error
> -
>
> Key: NIFI-13326
> URL: https://issues.apache.org/jira/browse/NIFI-13326
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 2.0.0-M2, 2.0.0-M3
> Environment: Linux Ubuntu 22.04
>Reporter: Night Gryphon
>Priority: Major
>
> With some combinations of JWT contents UI can not decode received JWT because 
> different base64 modifications are used by server and client.
> At the server side JWT is generated using URL-SAFE base64 encoding which 
> replace '+' and '/' characters with '-' and '_' respectively.
> But at UI side JWT is decoded with JQuery standard base64 decode function as 
> regular non URL-Safe data and '-' and '_' characters are dropped by incoming 
> filter which corrupts encoded data.
> As an example the UI script nf-login-all.js (and some other) declare function 
> getJwtPayload which call JQuery base 64 decode without appopriate JWT data 
> preparation by replacing '-' and '_' characters back to '+' and '/'. This 
> cause JWT data loss and javascript fails at decoding JWT json data
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-13326) UI web token (JWT) decoding error

2024-05-30 Thread Night Gryphon (Jira)
Night Gryphon created NIFI-13326:


 Summary: UI web token (JWT) decoding error
 Key: NIFI-13326
 URL: https://issues.apache.org/jira/browse/NIFI-13326
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core UI
Affects Versions: 2.0.0-M3, 2.0.0-M2
 Environment: Linux Ubuntu 22.04
Reporter: Night Gryphon


With some combinations of JWT contents UI can not decode received JWT because 
different base64 modifications are used by server and client.

At the server side JWT is generated using URL-SAFE base64 encoding which 
replace '+' and '/' characters with '-' and '_' respectively.

But at UI side JWT is decoded with JQuery standard base64 decode function as 
regular non URL-Safe data and '-' and '_' characters are dropped by incoming 
filter which corrupts encoded data.

As an example the UI script nf-login-all.js (and some other) declare function 
getJwtPayload which call JQuery base 64 decode without appopriate JWT data 
preparation by replacing '-' and '_' characters back to '+' and '/'. This cause 
JWT data loss and javascript fails at decoding JWT json data

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13325) Dark mode angular material density is inconsistent with light mode

2024-05-30 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-13325:
---
Status: Patch Available  (was: In Progress)

> Dark mode angular material density is inconsistent with light mode
> --
>
> Key: NIFI-13325
> URL: https://issues.apache.org/jira/browse/NIFI-13325
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [NIFI-13325] update dark mode theme density to match light mode [nifi]

2024-05-30 Thread via GitHub


scottyaslan opened a new pull request, #8904:
URL: https://github.com/apache/nifi/pull/8904

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-13325) Dark mode angular material density is inconsistent with light mode

2024-05-30 Thread Scott Aslan (Jira)
Scott Aslan created NIFI-13325:
--

 Summary: Dark mode angular material density is inconsistent with 
light mode
 Key: NIFI-13325
 URL: https://issues.apache.org/jira/browse/NIFI-13325
 Project: Apache NiFi
  Issue Type: Sub-task
Reporter: Scott Aslan
Assignee: Scott Aslan






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]

2024-05-30 Thread via GitHub


exceptionfactory commented on PR #8896:
URL: https://github.com/apache/nifi/pull/8896#issuecomment-2140949450

   > @exceptionfactory Can I just then modify NIFI-13323 to include other 
places besides the HashAttribute and PostHttp Processors?
   
   Sure, that sounds like a good plan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]

2024-05-30 Thread via GitHub


dan-s1 commented on PR #8896:
URL: https://github.com/apache/nifi/pull/8896#issuecomment-2140948368

   @exceptionfactory Can I just then modify NIFI-13323 to include other places 
besides the HashAttribute and PostHttp Processors? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13265) Remove the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements

2024-05-30 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13265:

Fix Version/s: 2.0.0-M4
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Remove the instantiation of Object arrays for arguments in ComponentLog log 
> and org.slf4j.Logger statements
> ---
>
> Key: NIFI-13265
> URL: https://issues.apache.org/jira/browse/NIFI-13265
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Major
> Fix For: 2.0.0-M4
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> There are still classes after the changes in NIFI-12075 and NIFI-12076 which 
> instantiate an Object array for ComponentLog log statements. This ticket aims 
> to remove those instantiations. In addition similar changes should be made to 
> org.slf4j.Logger statements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]

2024-05-30 Thread via GitHub


exceptionfactory commented on PR #8896:
URL: https://github.com/apache/nifi/pull/8896#issuecomment-2140945458

   @dan-s1 This commit does not apply cleanly to the support branch given the 
number of other changes, so if you are interested in having it applied, it 
would require a separate pull request. I also recommend handling it in a 
different Jira issue, since there are likely a number of other classes, now 
removed from main, where this would otherwise apply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]

2024-05-30 Thread via GitHub


dan-s1 commented on PR #8903:
URL: https://github.com/apache/nifi/pull/8903#issuecomment-2140944177

   @exceptionfactory I wanted to restart the MacOS build as the failure seems 
unrelated to the code I changed but there is no icon for me on the right hand 
side of that build  when I navigate to under checks that would allow me to 
restart it. Please advise. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-13265) Remove the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850872#comment-17850872
 ] 

ASF subversion and git services commented on NIFI-13265:


Commit 86d36d232700ff45080d8789da80e53d2dcd1684 in nifi's branch 
refs/heads/main from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=86d36d2327 ]

NIFI-13265 Removed instantiation of Object arrays for log arguments

This closes #8896

Signed-off-by: David Handermann 


> Remove the instantiation of Object arrays for arguments in ComponentLog log 
> and org.slf4j.Logger statements
> ---
>
> Key: NIFI-13265
> URL: https://issues.apache.org/jira/browse/NIFI-13265
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> There are still classes after the changes in NIFI-12075 and NIFI-12076 which 
> instantiate an Object array for ComponentLog log statements. This ticket aims 
> to remove those instantiations. In addition similar changes should be made to 
> org.slf4j.Logger statements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]

2024-05-30 Thread via GitHub


exceptionfactory closed pull request #8896: NIFI-13265 Removed the 
instantiation of Object arrays for arguments in ComponentLog log and 
org.slf4j.Logger statements.
URL: https://github.com/apache/nifi/pull/8896


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]

2024-05-30 Thread via GitHub


exceptionfactory commented on code in PR #8892:
URL: https://github.com/apache/nifi/pull/8892#discussion_r1621477589


##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/DatabaseParameterProvider.java:
##
@@ -38,37 +26,34 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.ServiceLoader;
 import java.util.stream.Collectors;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyDescriptor.Builder;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.db.DatabaseAdapter;
+import org.apache.nifi.dbcp.DBCPService;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.util.StringUtils;
 
 @Tags({"database", "dbcp", "sql"})
 @CapabilityDescription("Fetches parameters from database tables")
 
 public class DatabaseParameterProvider extends AbstractParameterProvider 
implements VerifiableParameterProvider {
 
-protected final static Map dbAdapters = new 
HashMap<>();
-
-public static final PropertyDescriptor DB_TYPE;
-
-static {
-// Load the DatabaseAdapters
-ArrayList dbAdapterValues = new ArrayList<>();
-ServiceLoader dbAdapterLoader = 
ServiceLoader.load(DatabaseAdapter.class);
-dbAdapterLoader.forEach(it -> {
-dbAdapters.put(it.getName(), it);
-dbAdapterValues.add(new AllowableValue(it.getName(), it.getName(), 
it.getDescription()));
-});
-
-DB_TYPE = new PropertyDescriptor.Builder()
-.name("db-type")
-.displayName("Database Type")
-.description("The type/flavor of database, used for generating 
database-specific code. In many cases the Generic type "
-+ "should suffice, but some databases (such as Oracle) 
require custom SQL clauses. ")
-.allowableValues(dbAdapterValues.toArray(new 
AllowableValue[dbAdapterValues.size()]))
-.defaultValue("Generic")
-.required(true)
-.build();
-}
+// TODO: There was no migration facility for Parameter Providers by the 
time of introducing this property,
+//  and removing the old 'db-type'.
+public static final PropertyDescriptor DATABASE_ADAPTER_PROVIDER = new 
Builder()
+.name("db-adapter-provider")
+.displayName("Database Adapter Provider")

Review Comment:
   Any new properties should use `name()` only and should use a human-readable 
label for the property. So in this case, it should be `name("Database Adapter 
Provider")` and the `displayName()` can be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13323) Remove the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors

2024-05-30 Thread Daniel Stieglitz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz updated NIFI-13323:

Status: Patch Available  (was: In Progress)

> Remove the instantiation of Object arrays for arguments in ComponentLog log 
> in the HashAttribute and PostHttp Processors
> 
>
> Key: NIFI-13323
> URL: https://issues.apache.org/jira/browse/NIFI-13323
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.27.0
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]

2024-05-30 Thread via GitHub


joewitt commented on code in PR #8892:
URL: https://github.com/apache/nifi/pull/8892#discussion_r1621459675


##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/DatabaseParameterProvider.java:
##
@@ -233,7 +218,7 @@ private void validateValueNotNull(final String value, final 
String columnName) {
 }
 
 String getQuery(final ConfigurationContext context, final String 
tableName, final List columns, final String whereClause) {
-final DatabaseAdapter dbAdapter = 
dbAdapters.get(context.getProperty(DB_TYPE).getValue());
+final DatabaseAdapter dbAdapter = 
context.getProperty(DATABASE_ADAPTER_PROVIDER).asControllerService(DatabaseAdapter.class);

Review Comment:
   perfect example where we do not need the word adapter anywhere.
   
   DatabaseAdapter.class is an interface.  There are concrete impls.



##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/DatabaseParameterProvider.java:
##
@@ -233,7 +218,7 @@ private void validateValueNotNull(final String value, final 
String columnName) {
 }
 
 String getQuery(final ConfigurationContext context, final String 
tableName, final List columns, final String whereClause) {
-final DatabaseAdapter dbAdapter = 
dbAdapters.get(context.getProperty(DB_TYPE).getValue());
+final DatabaseAdapter dbAdapter = 
context.getProperty(DATABASE_ADAPTER_PROVIDER).asControllerService(DatabaseAdapter.class);

Review Comment:
   perfect example where we do not need the word provider anywhere.
   
   DatabaseAdapter.class is an interface.  There are concrete impls.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]

2024-05-30 Thread via GitHub


joewitt commented on code in PR #8892:
URL: https://github.com/apache/nifi/pull/8892#discussion_r1621459232


##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/DatabaseParameterProvider.java:
##
@@ -38,37 +26,34 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.ServiceLoader;
 import java.util.stream.Collectors;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyDescriptor.Builder;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.db.DatabaseAdapter;
+import org.apache.nifi.dbcp.DBCPService;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.util.StringUtils;
 
 @Tags({"database", "dbcp", "sql"})
 @CapabilityDescription("Fetches parameters from database tables")
 
 public class DatabaseParameterProvider extends AbstractParameterProvider 
implements VerifiableParameterProvider {
 
-protected final static Map dbAdapters = new 
HashMap<>();
-
-public static final PropertyDescriptor DB_TYPE;
-
-static {
-// Load the DatabaseAdapters
-ArrayList dbAdapterValues = new ArrayList<>();
-ServiceLoader dbAdapterLoader = 
ServiceLoader.load(DatabaseAdapter.class);
-dbAdapterLoader.forEach(it -> {
-dbAdapters.put(it.getName(), it);
-dbAdapterValues.add(new AllowableValue(it.getName(), it.getName(), 
it.getDescription()));
-});
-
-DB_TYPE = new PropertyDescriptor.Builder()
-.name("db-type")
-.displayName("Database Type")
-.description("The type/flavor of database, used for generating 
database-specific code. In many cases the Generic type "
-+ "should suffice, but some databases (such as Oracle) 
require custom SQL clauses. ")
-.allowableValues(dbAdapterValues.toArray(new 
AllowableValue[dbAdapterValues.size()]))
-.defaultValue("Generic")
-.required(true)
-.build();
-}
+// TODO: There was no migration facility for Parameter Providers by the 
time of introducing this property,
+//  and removing the old 'db-type'.
+public static final PropertyDescriptor DATABASE_ADAPTER_PROVIDER = new 
Builder()
+.name("db-adapter-provider")
+.displayName("Database Adapter Provider")

Review Comment:
   we dont tend to want these both populated where one is a computer type name 
and the other is the human readable form.  @exceptionfactory what is the 
guidance now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]

2024-05-30 Thread via GitHub


joewitt commented on code in PR #8892:
URL: https://github.com/apache/nifi/pull/8892#discussion_r1621458711


##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/DatabaseParameterProvider.java:
##
@@ -38,37 +26,34 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.ServiceLoader;
 import java.util.stream.Collectors;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyDescriptor.Builder;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.db.DatabaseAdapter;
+import org.apache.nifi.dbcp.DBCPService;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.util.StringUtils;
 
 @Tags({"database", "dbcp", "sql"})
 @CapabilityDescription("Fetches parameters from database tables")
 
 public class DatabaseParameterProvider extends AbstractParameterProvider 
implements VerifiableParameterProvider {
 
-protected final static Map dbAdapters = new 
HashMap<>();
-
-public static final PropertyDescriptor DB_TYPE;
-
-static {
-// Load the DatabaseAdapters
-ArrayList dbAdapterValues = new ArrayList<>();
-ServiceLoader dbAdapterLoader = 
ServiceLoader.load(DatabaseAdapter.class);
-dbAdapterLoader.forEach(it -> {
-dbAdapters.put(it.getName(), it);
-dbAdapterValues.add(new AllowableValue(it.getName(), it.getName(), 
it.getDescription()));
-});
-
-DB_TYPE = new PropertyDescriptor.Builder()
-.name("db-type")
-.displayName("Database Type")
-.description("The type/flavor of database, used for generating 
database-specific code. In many cases the Generic type "
-+ "should suffice, but some databases (such as Oracle) 
require custom SQL clauses. ")
-.allowableValues(dbAdapterValues.toArray(new 
AllowableValue[dbAdapterValues.size()]))
-.defaultValue("Generic")
-.required(true)
-.build();
-}
+// TODO: There was no migration facility for Parameter Providers by the 
time of introducing this property,
+//  and removing the old 'db-type'.
+public static final PropertyDescriptor DATABASE_ADAPTER_PROVIDER = new 
Builder()

Review Comment:
   Yeah so i'm back to my provider vs not provider questions here then.  So 
here we have a processor property which references a controller service.  That 
will be a listing of controller services that implement the 'DatabaseAdapter' 
api.  Then we should just call this the 'database adapter' and the user selects 
a particular concrete impl.
   
   We need to have less terms.  It is also somewhat confusing given the todo 
references a parameter provider and here we're talking about a database adapter 
provider.  I really don't think we need so many words to describe these 
concepts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]

2024-05-30 Thread via GitHub


joewitt commented on code in PR #8892:
URL: https://github.com/apache/nifi/pull/8892#discussion_r1621457102


##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/DatabaseParameterProvider.java:
##
@@ -38,37 +26,34 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.ServiceLoader;
 import java.util.stream.Collectors;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyDescriptor.Builder;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.db.DatabaseAdapter;
+import org.apache.nifi.dbcp.DBCPService;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.util.StringUtils;
 
 @Tags({"database", "dbcp", "sql"})
 @CapabilityDescription("Fetches parameters from database tables")
 
 public class DatabaseParameterProvider extends AbstractParameterProvider 
implements VerifiableParameterProvider {
 
-protected final static Map dbAdapters = new 
HashMap<>();
-
-public static final PropertyDescriptor DB_TYPE;
-
-static {
-// Load the DatabaseAdapters
-ArrayList dbAdapterValues = new ArrayList<>();
-ServiceLoader dbAdapterLoader = 
ServiceLoader.load(DatabaseAdapter.class);
-dbAdapterLoader.forEach(it -> {
-dbAdapters.put(it.getName(), it);
-dbAdapterValues.add(new AllowableValue(it.getName(), it.getName(), 
it.getDescription()));
-});
-
-DB_TYPE = new PropertyDescriptor.Builder()
-.name("db-type")
-.displayName("Database Type")
-.description("The type/flavor of database, used for generating 
database-specific code. In many cases the Generic type "
-+ "should suffice, but some databases (such as Oracle) 
require custom SQL clauses. ")
-.allowableValues(dbAdapterValues.toArray(new 
AllowableValue[dbAdapterValues.size()]))
-.defaultValue("Generic")
-.required(true)
-.build();
-}
+// TODO: There was no migration facility for Parameter Providers by the 
time of introducing this property,

Review Comment:
   better to have todo not in the code and instead just file the JIRA for this 
topic if necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13321) Fix mocking of child components in unit tests

2024-05-30 Thread Rob Fellows (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Fellows updated NIFI-13321:
---
Fix Version/s: 2.0.0-M4
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Fix mocking of child components in unit tests
> -
>
> Key: NIFI-13321
> URL: https://issues.apache.org/jira/browse/NIFI-13321
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 2.0.0-M4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The existing mocking of child components in unit tests was incorrect and 
> would often require the test bed to provide dependencies of the child 
> component. This should be fixed so that unit tests can focus on just the 
> component in question and not anything functionality of a child component.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13321) Fix mocking of child components in unit tests

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850863#comment-17850863
 ] 

ASF subversion and git services commented on NIFI-13321:


Commit 983f209083983498d5a676e68cc53d24e8f005d3 in nifi's branch 
refs/heads/main from Matt Gilman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=983f209083 ]

NIFI-13321: (#8901)

- Fixing the mocking of child components in unit tests.
- Removing any provided dependency that is no longer needed.

This closes #8901 

> Fix mocking of child components in unit tests
> -
>
> Key: NIFI-13321
> URL: https://issues.apache.org/jira/browse/NIFI-13321
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The existing mocking of child components in unit tests was incorrect and 
> would often require the test bed to provide dependencies of the child 
> component. This should be fixed so that unit tests can focus on just the 
> component in question and not anything functionality of a child component.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13321: Fixing the mocking of child components in unit tests [nifi]

2024-05-30 Thread via GitHub


rfellows merged PR #8901:
URL: https://github.com/apache/nifi/pull/8901


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13321: Fixing the mocking of child components in unit tests [nifi]

2024-05-30 Thread via GitHub


rfellows commented on PR #8901:
URL: https://github.com/apache/nifi/pull/8901#issuecomment-2140851807

   Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13246) Move actions into kebab menu

2024-05-30 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-13246:
---
Fix Version/s: 2.0.0-M4
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Move actions into kebab menu
> 
>
> Key: NIFI-13246
> URL: https://issues.apache.org/jira/browse/NIFI-13246
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
> Fix For: 2.0.0-M4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> View Provenance event
> View FlowFile
> View Documentation
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13246) Move actions into kebab menu

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850858#comment-17850858
 ] 

ASF subversion and git services commented on NIFI-13246:


Commit e66c1643d192ed71f0923793392d9eb875ee75b5 in nifi's branch 
refs/heads/main from Scott Aslan
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e66c1643d1 ]

[NIFI-13246] move actions from details columns into menu (#8900)

* [NIFI-13246] move actions from details columns into menu

* move View Documentation menu option lower

This closes #8900 

> Move actions into kebab menu
> 
>
> Key: NIFI-13246
> URL: https://issues.apache.org/jira/browse/NIFI-13246
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> View Provenance event
> View FlowFile
> View Documentation
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [NIFI-13246] move actions from details columns into menu [nifi]

2024-05-30 Thread via GitHub


mcgilman merged PR #8900:
URL: https://github.com/apache/nifi/pull/8900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]

2024-05-30 Thread via GitHub


takraj commented on PR #8892:
URL: https://github.com/apache/nifi/pull/8892#issuecomment-2140843566

   Hey @joewitt & @exceptionfactory . I've tried to rework my PR based on your 
comments. Please revisit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]

2024-05-30 Thread via GitHub


dan-s1 opened a new pull request, #8903:
URL: https://github.com/apache/nifi/pull/8903

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-13323](https://issues.apache.org/jira/browse/NIFI-13323)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### UI Contributions
   
   - [ ] NiFi is modernizing its UI. Any contributions that update the [current 
UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui)
 also need to be implemented in the [new 
UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi).
  
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-13324) Attributes skipped for Failure relationship in Python Processors

2024-05-30 Thread Asif Arman Rahman (Jira)
Asif Arman Rahman created NIFI-13324:


 Summary: Attributes skipped for Failure relationship in Python 
Processors
 Key: NIFI-13324
 URL: https://issues.apache.org/jira/browse/NIFI-13324
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 2.0.0-M3, 2.0.0-M2, 2.0.0-M1
Reporter: Asif Arman Rahman
 Attachments: attributeFailureTest.py

Hello Team,

Thank you for bringing the power of Python Processor to NiFi!

It was discovered that attributes set to be written for `failure` relationship 
is skipped, and not written for some reason. But it works as expected for 
`success` and even custom defined relationships.

I'll attach a simple processor for test purpose.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (NIFI-13234) Unauthorized canvas components issues

2024-05-30 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-13234.

Fix Version/s: 2.0.0-M4
   Resolution: Fixed

> Unauthorized canvas components issues
> -
>
> Key: NIFI-13234
> URL: https://issues.apache.org/jira/browse/NIFI-13234
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: Screenshot 2024-05-14 at 1.01.15 PM.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are color and contrast ratio issues for unauthorized components on the 
> canvas:
>  
> !Screenshot 2024-05-14 at 1.01.15 PM.png|width=415,height=222!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13234) Unauthorized canvas components issues

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850840#comment-17850840
 ] 

ASF subversion and git services commented on NIFI-13234:


Commit 732b5875611631ea16f7156e1332ce632fb14014 in nifi's branch 
refs/heads/main from Scott Aslan
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=732b587561 ]

[NIFI-13234] update unauthorized canvas component colors (#8902)

* [NIFI-13234] update unautorized canvas component colors

* restore web font loader to ensure positions of canvas text is calculate 
correctly

This closes #8902 

> Unauthorized canvas components issues
> -
>
> Key: NIFI-13234
> URL: https://issues.apache.org/jira/browse/NIFI-13234
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
> Attachments: Screenshot 2024-05-14 at 1.01.15 PM.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are color and contrast ratio issues for unauthorized components on the 
> canvas:
>  
> !Screenshot 2024-05-14 at 1.01.15 PM.png|width=415,height=222!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [NIFI-13234] update unauthorized canvas component colors [nifi]

2024-05-30 Thread via GitHub


mcgilman merged PR #8902:
URL: https://github.com/apache/nifi/pull/8902


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported features

2024-05-30 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-12400:
---
Description: 
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups (NIFI-12504)
 *** connections (NIFI-12504)
 *** System Diagnostics (NIFI-12505)
 *** support for cluster-specific ui elements (NIFI-12537)
 *** Add pagination (NIFI-12552)
 *** Support Processor Details dialog (NIFI-13316)
 *** Support Connection Details dialog (NIFI-13317)
 * Counters (NIFI-12415)
 ** Counter table has extra unnecessary can modify check (NIFI-12948)
 * Bulletin Board (NIFI-12560)
 * Provenance (NIFI-12445)
 ** Event Listing (NIFI-12445)
 ** Search (NIFI-12445)
 ** Event Dialog (NIFI-12445)
 ** Lineage (NIFI-12485)
 ** Replay from context menu (NIFI-12445)
 ** Clustering (NIFI-12807)

 * Configure Reporting Task (NIFI-12563)
 * Flow Analysis Rules (NIFI-12588)
 * Registry Clients (NIFI-12486)
 * Import from Registry (NIFI-12734)
 * Parameter Providers (NIFI-12622)
 ** Fetch parameters from provider, map to parameter context (dialog) - 
(NIFI-12665)
 * Cluster
 ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053)
 ** Status History - node specific values (NIFI-12848)
 * Flow Configuration History (NIFI-12754)
 ** ActionEntity.action should be optional (NIFI-12948)
 * Node Status History (NIFI-12553)
 * Status history for components from canvas context menu (NIFI-12553)
 * Users (NIFI-12543)
 ** Don't show users or groups in create/edit dialog is there are none 
(NIFI-12948)
 * Policies (NIFI-12548)
 ** Overridden policy Empty or Copy (NIFI-12679)
 ** Select Empty by default (NIFI-12948)
 * Help (NIFI-12795)
 * About (NIFI-13094)
 * Show Upstream/Downstream
 * Align (NIFI-13162)
 * Replay last event (NIFI-12445)
 * List Queue (NIFI-12589)
 ** Clustering (NIFI-12807)
 * Empty [all] Queue (NIFI-12604)
 * View Content (NIFI-12589 and NIFI-12445)
 * View State (NIFI-12611)
 ** Clustering (NIFI-13005)
 * Change Component Version (NIFI-13034)
 * Consider PG permissions in Toolbox (NIFI-12683)
 * PG Version (NIFI-12963 & NIFI-12995)
 ** Start (NIFI-12963)
 ** Commit (NIFI-12963)
 ** Force Commit (NIFI-12963)
 ** Show changes (NIFI-12995)
 ** Revert changes (NIFI-12995)
 ** Change Flow version (NIFI-12995)
 ** Stop (NIFI-12963)

 * Configure PG (NIFI-12417)
 * Configure Label (NIFI-13081)
 * Process Group Services (NIFI-12425)
 ** Listing (NIFI-12425)
 ** Create (NIFI-12425)
 ** Configure (NIFI-12425)
 ** Delete (NIFI-12425)
 ** Enable (NIFI-12529)
 ** Disable (NIFI-12529)
 ** Improve layout and breadcrumbs
 ** Disable and Configure
 * Configure Processor
 ** Service Link (NIFI-12425)
 ** Create inline Service (NIFI-12425)
 ** Parameter Link (NIFI-12502)
 ** Convert to Parameter (NIFI-12502)
 ** Fix issue with Property Editor width (NIFI-12547)
 ** Status Bar
 ** Stop and Configure
 ** Open Custom UI (NIFI-12958)
 ** Property History (NIFI-13047)
 ** Unable to re-add any removed Property (NIFI-12743)
 ** Shift-Enter new line when editing Property (NIFI-12743)
 * Property Verification (NIFI-13247)
 * Terminate Threads (context menu) (NIFI-13068)
 * Enable/Disable (context menu/operate panel) (NIFI-13078)
 * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062)

 * Download Flow (NIFI-13029)
 * Create RPG (NIFI-12758)
 * Configure RPG (NIFI-12774)
 * RPG Remote Ports (NIFI-12778)
 * RPG Go To (NIFI-12759)
 * RPG Refresh (NIFI-12761)
 * Color (context menu/operate panel) (NIFI-13226)
 * Move to Front (NIFI-13044)
 * Copy/Paste (context menu/operate panel) (NIFI-13059)
 * Add/Update Info Icons in dialogs throughout the application (NIFI-13092)
 * Set viewport earlier when loading a Process Group (NIFI-12737)
 * Canvas global menu item should navigate user back to where they were on the 
canvas (NIFI-12737)
 * Better theme support (NIFI-12655)
 * Set up development/production environments files
 * Run unit tests are part of standard build (NIFI-12941)
 * Update all API calls to consider disconnect node confirmation (NIFI-13001)
 * Update API calls to use uiOnly flag (NIFI-12950)
 * Use polling interval from API
 * Load FlowConfiguration in guard (NIFI-12948)
 * Routing error handling (NIFI-13104)
 * General API response error handling
 ** Management CS (NIFI-12663)
 ** Canvas CS (NIFI-12684)
 ** Remainder of Settings (NIFI-12723)
 ** Counters (NIFI-12723)
 ** Bulletins (NIFI-12723)
 ** Flow Designer (NIFI-13100)
 

[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported features

2024-05-30 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-12400:
---
Description: 
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups (NIFI-12504)
 *** connections (NIFI-12504)
 *** System Diagnostics (NIFI-12505)
 *** support for cluster-specific ui elements (NIFI-12537)
 *** Add pagination (NIFI-12552)
 *** Support Processor Details dialog (NIFI-13316)
 *** Support Connection Details dialog (NIFI-13317)
 * Counters (NIFI-12415)
 ** Counter table has extra unnecessary can modify check (NIFI-12948)
 * Bulletin Board (NIFI-12560)
 * Provenance (NIFI-12445)
 ** Event Listing (NIFI-12445)
 ** Search (NIFI-12445)
 ** Event Dialog (NIFI-12445)
 ** Lineage (NIFI-12485)
 ** Replay from context menu (NIFI-12445)
 ** Clustering (NIFI-12807)

 * Configure Reporting Task (NIFI-12563)
 * Flow Analysis Rules (NIFI-12588)
 * Registry Clients (NIFI-12486)
 * Import from Registry (NIFI-12734)
 * Parameter Providers (NIFI-12622)
 ** Fetch parameters from provider, map to parameter context (dialog) - 
(NIFI-12665)
 * Cluster
 ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053)
 ** Status History - node specific values (NIFI-12848)
 * Flow Configuration History (NIFI-12754)
 ** ActionEntity.action should be optional (NIFI-12948)
 * Node Status History (NIFI-12553)
 * Status history for components from canvas context menu (NIFI-12553)
 * Users (NIFI-12543)
 ** Don't show users or groups in create/edit dialog is there are none 
(NIFI-12948)
 * Policies (NIFI-12548)
 ** Overridden policy Empty or Copy (NIFI-12679)
 ** Select Empty by default (NIFI-12948)
 * Help (NIFI-12795)
 * About (NIFI-13094)
 * Show Upstream/Downstream
 * Align (NIFI-13162)
 * Replay last event (NIFI-12445)
 * List Queue (NIFI-12589)
 ** Clustering (NIFI-12807)
 * Empty [all] Queue (NIFI-12604)
 * View Content (NIFI-12589 and NIFI-12445)
 * View State (NIFI-12611)
 ** Clustering (NIFI-13005)
 * Change Component Version (NIFI-13034)
 * Consider PG permissions in Toolbox (NIFI-12683)
 * PG Version (NIFI-12963 & NIFI-12995)
 ** Start (NIFI-12963)
 ** Commit (NIFI-12963)
 ** Force Commit (NIFI-12963)
 ** Show changes (NIFI-12995)
 ** Revert changes (NIFI-12995)
 ** Change Flow version (NIFI-12995)
 ** Stop (NIFI-12963)

 * Configure PG (NIFI-12417)
 * Configure Label (NIFI-13081)
 * Process Group Services (NIFI-12425)
 ** Listing (NIFI-12425)
 ** Create (NIFI-12425)
 ** Configure (NIFI-12425)
 ** Delete (NIFI-12425)
 ** Enable (NIFI-12529)
 ** Disable (NIFI-12529)
 ** Improve layout and breadcrumbs
 ** Disable and Configure (NIFI-13319)
 * Configure Processor
 ** Service Link (NIFI-12425)
 ** Create inline Service (NIFI-12425)
 ** Parameter Link (NIFI-12502)
 ** Convert to Parameter (NIFI-12502)
 ** Fix issue with Property Editor width (NIFI-12547)
 ** Status Bar
 ** Stop and Configure (NIFI-13318)
 ** Open Custom UI (NIFI-12958)
 ** Property History (NIFI-13047)
 ** Unable to re-add any removed Property (NIFI-12743)
 ** Shift-Enter new line when editing Property (NIFI-12743)
 * Property Verification (NIFI-13247)
 * Terminate Threads (context menu) (NIFI-13068)
 * Enable/Disable (context menu/operate panel) (NIFI-13078)
 * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062)

 * Download Flow (NIFI-13029)
 * Create RPG (NIFI-12758)
 * Configure RPG (NIFI-12774)
 * RPG Remote Ports (NIFI-12778)
 * RPG Go To (NIFI-12759)
 * RPG Refresh (NIFI-12761)
 * Color (context menu/operate panel) (NIFI-13226)
 * Move to Front (NIFI-13044)
 * Copy/Paste (context menu/operate panel) (NIFI-13059)
 * Add/Update Info Icons in dialogs throughout the application (NIFI-13092)
 * Set viewport earlier when loading a Process Group (NIFI-12737)
 * Canvas global menu item should navigate user back to where they were on the 
canvas (NIFI-12737)
 * Better theme support (NIFI-12655)
 * Set up development/production environments files
 * Run unit tests are part of standard build (NIFI-12941)
 * Update all API calls to consider disconnect node confirmation (NIFI-13001)
 * Update API calls to use uiOnly flag (NIFI-12950)
 * Use polling interval from API
 * Load FlowConfiguration in guard (NIFI-12948)
 * Routing error handling (NIFI-13104)
 * General API response error handling
 ** Management CS (NIFI-12663)
 ** Canvas CS (NIFI-12684)
 ** Remainder of Settings (NIFI-12723)
 ** Counters (NIFI-12723)
 ** Bulletins (NIFI-12723)
 ** 

[jira] [Updated] (NIFI-13314) Update guides for new UI

2024-05-30 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-13314:
---
Description: 
The new NiFi UI leverages the same general UX as the old UI. However, there are 
some differences that have evolved as the new UI was built. This Jira is 
tracking needed changes to the documentation and guides. While there are many 
details in these guides, we should prioritize updating areas where the UX has 
changed substantially from the old UI.
 * Managing Remote Ports
 * Process Group Configuration
 * Process Group Controller Services
 * Color Processor/Label
 * Flow Configuration History

Sub-tasks can be added to this Jira for landing each of these updates.

  was:
The new NiFi UI leverages the same general UX as the old UI. However, there are 
some differences that have evolved as the new UI was built. This Jira is 
tracking needed changes to the documentation and guides. While is a ton of 
details in these guides, we should prioritize updating areas where the UX has 
changed substantially from the old UI.
 * Managing Remote Ports
 * Process Group Configuration
 * Process Group Controller Services
 * Color Processor/Label
 * Flow Configuration History

Sub-tasks can be added to this Jira for landing each of these updates.


> Update guides for new UI
> 
>
> Key: NIFI-13314
> URL: https://issues.apache.org/jira/browse/NIFI-13314
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Documentation  Website
>Reporter: Matt Gilman
>Priority: Major
>
> The new NiFi UI leverages the same general UX as the old UI. However, there 
> are some differences that have evolved as the new UI was built. This Jira is 
> tracking needed changes to the documentation and guides. While there are many 
> details in these guides, we should prioritize updating areas where the UX has 
> changed substantially from the old UI.
>  * Managing Remote Ports
>  * Process Group Configuration
>  * Process Group Controller Services
>  * Color Processor/Label
>  * Flow Configuration History
> Sub-tasks can be added to this Jira for landing each of these updates.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]

2024-05-30 Thread via GitHub


exceptionfactory commented on code in PR #8896:
URL: https://github.com/apache/nifi/pull/8896#discussion_r1621169344


##
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/sqs/GetSQS.java:
##
@@ -223,8 +223,7 @@ private void deleteMessages(final SqsClient client, final 
String queueUrl, final
 try {
 client.deleteMessageBatch(deleteRequest);
 } catch (final Exception e) {
-getLogger().error("Received {} messages from Amazon SQS but failed 
to delete the messages; these messages"
-+ " may be duplicated. Reason for deletion failure: {}", new 
Object[]{messages.size(), e});
+getLogger().error("Received {} messages from Amazon SQS but failed 
to delete the messages; these messages may be duplicated. Reason for deletion 
failure: ", messages.size(), e);

Review Comment:
   ```suggestion
   getLogger().error("Received {} messages from Amazon SQS but 
failed to delete the messages; these messages may be duplicated", 
messages.size(), e);
   ```



##
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java:
##
@@ -925,12 +908,10 @@ protected MultipartUploadListing 
getS3AgeoffListAndAgeoffLocalState(final Proces
 getLogger().warn("AccessDenied checking S3 Multipart 
Upload list for {}: {} " +
 "** The configured user does not have the 
s3:ListBucketMultipartUploads permission " +
 "for this bucket, S3 ageoff cannot occur without 
this permission.  Next ageoff check " +
-"time is being advanced by interval to prevent 
checking on every upload **",
-new Object[]{bucket, e.getMessage()});
+"time is being advanced by interval to prevent 
checking on every upload **", bucket, e.getMessage());
 lastS3AgeOff.set(System.currentTimeMillis());
 } else {
-getLogger().error("Error checking S3 Multipart Upload list 
for {}: {}",
-new Object[]{bucket, e.getMessage()});
+getLogger().error("Error checking S3 Multipart Upload list 
for {}:", bucket, e);

Review Comment:
   ```suggestion
   getLogger().error("Error checking S3 Multipart Upload 
list for {}", bucket, e);
   ```



##
nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/FetchHDFS.java:
##
@@ -181,7 +181,7 @@ public void onTrigger(final ProcessContext context, final 
ProcessSession session
 session.getProvenanceReporter().fetch(outgoingFlowFile, 
qualifiedPath.toString(), stopWatch.getDuration(TimeUnit.MILLISECONDS));
 session.transfer(outgoingFlowFile, getSuccessRelationship());
 } catch (final FileNotFoundException | AccessControlException e) {
-getLogger().error("Failed to retrieve content from {} for {} 
due to {}; routing to failure", new Object[]{qualifiedPath, outgoingFlowFile, 
e});
+getLogger().error("Routing to failure since failed to retrieve 
content from {} for {}", qualifiedPath, outgoingFlowFile, e);

Review Comment:
   ```suggestion
   getLogger().error("Failed to retrieve content from {} for 
{}", qualifiedPath, outgoingFlowFile, e);
   ```



##
nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java:
##
@@ -223,15 +223,15 @@ public void process(OutputStream out) throws IOException {
 lastTxId = eventBatch.getTxid();
 }
 } catch (IOException | InterruptedException e) {
-getLogger().error("Unable to get notification information: {}", 
new Object[]{e});
+getLogger().error("Unable to get notification information:", e);

Review Comment:
   ```suggestion
   getLogger().error("Unable to get notification information", e);
   ```



##
nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/KeyValueReader.java:
##
@@ -68,7 +68,7 @@ public Set readSequenceFile(Path file, 
Configuration configuration, Fi
 final KeyValueWriterCallback callback = new 
KeyValueWriterCallback(reader);
 final String inputfileName = file.getName() + "." + System.nanoTime() 
+ ".";
 int counter = 0;
-LOG.debug("Read from SequenceFile: {} ", new Object[]{file});
+LOG.debug("Read from SequenceFile: {} ", file);

Review Comment:
   ```suggestion
   LOG.debug("Read from SequenceFile: {}", file);
   ```



##

[jira] [Updated] (NIFI-13301) Create ExtensionRegistryClient for External Extension Registry Interaction

2024-05-30 Thread James Guzman (Medel) (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Guzman (Medel) updated NIFI-13301:

Summary: Create ExtensionRegistryClient for External Extension Registry 
Interaction  (was: Create NiFi Processor Marketplace App Powered by NiFi 
Registry)

> Create ExtensionRegistryClient for External Extension Registry Interaction
> --
>
> Key: NIFI-13301
> URL: https://issues.apache.org/jira/browse/NIFI-13301
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions, NiFi Registry
> Environment: Linux: Ubuntu 20.04 or 22.04
>Reporter: James Guzman (Medel)
>Assignee: James Guzman (Medel)
>Priority: Minor
>
> *Objective:* Improve/enable sharing/reuse of at least two features of Apache 
> NiFi, so the community can have an easier time contributing their flows 
> and/or custom processors into a NiFi Marketplace:
>  * {*}Pre-Designed Flows{*}: (Approach 1) stored in a NiFi Registry or 
> accessible location. (Approach 2) NiFi Registry can also substituted by 
> NiFi's git registry client having the location of the NiFi Marketplace.  
> Thus, we just have a git location and NiFi uses that to find/store flows.
>  * *Components/Processors* built in *Java/Python* that anyone is free to use
>  * *End to End Full Stack Applications Powered By NiFi or MiNiFi CPP?* The 
> frontend could be various ones from PyQT, ReactJS, H2O.ai Wave, 3D Slicer, 
> OHIF Viewer, etc: (Maybe this one can be subscription based where users get 
> access if they invest in the monthly or yearly subscription?)
> *Potential Solution:* Apache NiFi builds an extension point for interacting 
> with Extension Registries, similar to how it currently has 
> *{{FlowRegistryClient}}* with implementations for NiFi Registry and now 
> GitHub, there would be *{{ExtensionRegistryClient}}* with implementations for 
> stuff like Nexus, NiFi Registry, and any other vendor ones, for example maybe 
> Datavolo provides one, but basically in apache we don't want to build another 
> application, we already have NiFi Registry. (Briefly Discussed with [~bbende] 
> )
>  * I will start by looking into *{{FlowRegistryClient}}* and then base 
> *{{ExtensionRegistryClient}}* toward that approach. If I am understanding 
> correctly, we would contribute an *{{ExtensionRegistryClient}}* feature into 
> Apache NiFi that enables NiFi to integrate with other vendors (Datavolo, 
> H2Oai, etc) group of processors, data flow templates and so on. I see where 
> you are coming from with for Apache the goal being not to build another 
> application. That application could be by the another and NiFi's 
> *{{ExtensionRegistryClient}}* hooks up to their {*}RegistryServer{*}. (Heres 
> the path I will take toward that goal).
>  
> {*}Project Ownership{*}: There will be a clear line that the NiFi Marketplace 
> is not owned by the Apache NiFi PMC, rather it will be managed and owned by a 
> vendor in close alignment with NiFi, which we will announce at a later time.
>  
> {*}Motivation (NiFi){*}: Some people in the community have shown interest in 
> having a NiFi Processor Marketplace where they can contribute their category 
> of processors. In particular, I saw some people interested in contributing 
> their NiFi python processors. This NiFi Processor marketplace could be also 
> applied toward the community interested in contributing custom NiFi java 
> processors.
>  * {*}Extra MiNiFi C+{+}{{+}}{*}: We could even add a section for MiNiFi C+ 
> custom processors. There is a part of the MiNiFi build process that brings in 
> NiFi through building the JNI extension. So, that is a way to integrate NiFi 
> Registry there too.
> I have briefly talked with [~bbende] and [~joewitt] asking them questions on 
> ways to bring custom python processors into production. One of the routes was 
> through leveraging NiFi Registry in connection with Apache NiFi to streamline 
> integration. For my use case, I would leverage the NiFi Processor Marketplace 
> to start contributing my AI/DL "Medical Imaging" Pipeline of custom NiFi 
> Python Processors where I focused on my master thesis AI/DL for stroke 
> diagnosis.
> *High Level Details of NiFi Processor Marketplace App:* For a full stack NiFi 
> Processor Marketplace App, there are frameworks we can leverage for the UI 
> from ReactJS (this mainly is used for frontend), H2O.ai Wave (this can be 
> used for full stack, but probably would mainly be used for the frontend 
> portion) and other options. in the case that we want to make something more 
> custom to display each category of processors. This full stack application 
> could interact wth the NiFi Registry, which is the central location for 
> storage and management of shared resources 

Re: [PR] [NIFI-13234] update unauthorized canvas component colors [nifi]

2024-05-30 Thread via GitHub


mcgilman commented on PR #8902:
URL: https://github.com/apache/nifi/pull/8902#issuecomment-2140396480

   Will review...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [NIFI-13246] move actions from details columns into menu [nifi]

2024-05-30 Thread via GitHub


mcgilman commented on PR #8900:
URL: https://github.com/apache/nifi/pull/8900#issuecomment-2140339895

   Will review...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13323) Remove the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors

2024-05-30 Thread Daniel Stieglitz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz updated NIFI-13323:

Summary: Remove the instantiation of Object arrays for arguments in 
ComponentLog log in the HashAttribute and PostHttp Processors  (was: Remove the 
instantiation of Object arrays for arguments in ComponentLog log in the 
HashAttribute Processor)

> Remove the instantiation of Object arrays for arguments in ComponentLog log 
> in the HashAttribute and PostHttp Processors
> 
>
> Key: NIFI-13323
> URL: https://issues.apache.org/jira/browse/NIFI-13323
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.27.0
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13301) Create NiFi Processor Marketplace App Powered by NiFi Registry

2024-05-30 Thread James Guzman (Medel) (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Guzman (Medel) updated NIFI-13301:

Description: 
*Objective:* Improve/enable sharing/reuse of at least two features of Apache 
NiFi, so the community can have an easier time contributing their flows and/or 
custom processors into a NiFi Marketplace:
 * {*}Pre-Designed Flows{*}: (Approach 1) stored in a NiFi Registry or 
accessible location. (Approach 2) NiFi Registry can also substituted by NiFi's 
git registry client having the location of the NiFi Marketplace.  Thus, we just 
have a git location and NiFi uses that to find/store flows.
 * *Components/Processors* built in *Java/Python* that anyone is free to use
 * *End to End Full Stack Applications Powered By NiFi or MiNiFi CPP?* The 
frontend could be various ones from PyQT, ReactJS, H2O.ai Wave, 3D Slicer, OHIF 
Viewer, etc: (Maybe this one can be subscription based where users get access 
if they invest in the monthly or yearly subscription?)

*Potential Solution:* Apache NiFi builds an extension point for interacting 
with Extension Registries, similar to how it currently has 
*{{FlowRegistryClient}}* with implementations for NiFi Registry and now GitHub, 
there would be *{{ExtensionRegistryClient}}* with implementations for stuff 
like Nexus, NiFi Registry, and any other vendor ones, for example maybe 
Datavolo provides one, but basically in apache we don't want to build another 
application, we already have NiFi Registry. (Briefly Discussed with [~bbende] )
 * I will start by looking into *{{FlowRegistryClient}}* and then base 
*{{ExtensionRegistryClient}}* toward that approach. If I am understanding 
correctly, we would contribute an *{{ExtensionRegistryClient}}* feature into 
Apache NiFi that enables NiFi to integrate with other vendors (Datavolo, H2Oai, 
etc) group of processors, data flow templates and so on. I see where you are 
coming from with for Apache the goal being not to build another application. 
That application could be by the another and NiFi's 
*{{ExtensionRegistryClient}}* hooks up to their {*}RegistryServer{*}. (Heres 
the path I will take toward that goal).

 

{*}Project Ownership{*}: There will be a clear line that the NiFi Marketplace 
is not owned by the Apache NiFi PMC, rather it will be managed and owned by a 
vendor in close alignment with NiFi, which we will announce at a later time.

 

{*}Motivation (NiFi){*}: Some people in the community have shown interest in 
having a NiFi Processor Marketplace where they can contribute their category of 
processors. In particular, I saw some people interested in contributing their 
NiFi python processors. This NiFi Processor marketplace could be also applied 
toward the community interested in contributing custom NiFi java processors.
 * {*}Extra MiNiFi C+{+}{{+}}{*}: We could even add a section for MiNiFi C+ 
custom processors. There is a part of the MiNiFi build process that brings in 
NiFi through building the JNI extension. So, that is a way to integrate NiFi 
Registry there too.

I have briefly talked with [~bbende] and [~joewitt] asking them questions on 
ways to bring custom python processors into production. One of the routes was 
through leveraging NiFi Registry in connection with Apache NiFi to streamline 
integration. For my use case, I would leverage the NiFi Processor Marketplace 
to start contributing my AI/DL "Medical Imaging" Pipeline of custom NiFi Python 
Processors where I focused on my master thesis AI/DL for stroke diagnosis.

*High Level Details of NiFi Processor Marketplace App:* For a full stack NiFi 
Processor Marketplace App, there are frameworks we can leverage for the UI from 
ReactJS (this mainly is used for frontend), H2O.ai Wave (this can be used for 
full stack, but probably would mainly be used for the frontend portion) and 
other options. in the case that we want to make something more custom to 
display each category of processors. This full stack application could interact 
wth the NiFi Registry, which is the central location for storage and management 
of shared resources across one or more instances of NiFi and/or MiNiFi (C++). 
What are some hosting options for Apache projects?

  was:
*Objective:* Improve/enable sharing/reuse of at least two features of Apache 
NiFi, so the community can have an easier time contributing their flows and/or 
custom processors into a NiFi Marketplace:
 * {*}Pre-Designed Flows{*}: (Approach 1) stored in a NiFi Registry or 
accessible location. (Approach 2) NiFi Registry can also substituted by NiFi's 
git registry client having the location of the NiFi Marketplace.  Thus, we just 
have a git location and NiFi uses that to find/store flows.
 * *Components/Processors* built in *Java/Python* that anyone is free to use
 * *End to End Full Stack Applications Powered By NiFi or MiNiFi CPP?* The 
frontend could be various ones from PyQT, 

[jira] [Updated] (NIFI-13323) Remove the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute Processor

2024-05-30 Thread Daniel Stieglitz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz updated NIFI-13323:

Summary: Remove the instantiation of Object arrays for arguments in 
ComponentLog log in the HashAttribute Processor  (was: Remove the instantiation 
of Object arrays for arguments in ComponentLog log in HashAttribute)

> Remove the instantiation of Object arrays for arguments in ComponentLog log 
> in the HashAttribute Processor
> --
>
> Key: NIFI-13323
> URL: https://issues.apache.org/jira/browse/NIFI-13323
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.27.0
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-13323) Remove the instantiation of Object arrays for arguments in ComponentLog log in HashAttribute

2024-05-30 Thread Daniel Stieglitz (Jira)
Daniel Stieglitz created NIFI-13323:
---

 Summary: Remove the instantiation of Object arrays for arguments 
in ComponentLog log in HashAttribute
 Key: NIFI-13323
 URL: https://issues.apache.org/jira/browse/NIFI-13323
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Daniel Stieglitz
Assignee: Daniel Stieglitz






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13323) Remove the instantiation of Object arrays for arguments in ComponentLog log in HashAttribute

2024-05-30 Thread Daniel Stieglitz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz updated NIFI-13323:

Affects Version/s: 1.27.0

> Remove the instantiation of Object arrays for arguments in ComponentLog log 
> in HashAttribute
> 
>
> Key: NIFI-13323
> URL: https://issues.apache.org/jira/browse/NIFI-13323
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.27.0
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet

2024-05-30 Thread Philipp Korniets (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850803#comment-17850803
 ] 

Philipp Korniets commented on NIFI-13304:
-

Ok. Thanks a lot

> ExcelReader - ability to split into flowfile per sheet
> --
>
> Key: NIFI-13304
> URL: https://issues.apache.org/jira/browse/NIFI-13304
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Philipp Korniets
>Assignee: Daniel Stieglitz
>Priority: Major
>
> Currently ConvertExcelToCSV processor, if processing excel with multiple 
> required sheets in it, produces flowfile per sheet.
> New ExcelReader produces one flowfile with all data in it
>  
> There should be a way to configure output to be sheet-per-flowfile
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13321) Fix mocking of child components in unit tests

2024-05-30 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-13321:
---
Status: Patch Available  (was: In Progress)

> Fix mocking of child components in unit tests
> -
>
> Key: NIFI-13321
> URL: https://issues.apache.org/jira/browse/NIFI-13321
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The existing mocking of child components in unit tests was incorrect and 
> would often require the test bed to provide dependencies of the child 
> component. This should be fixed so that unit tests can focus on just the 
> component in question and not anything functionality of a child component.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] NIFI-13321: Fixing the mocking of child components in unit tests [nifi]

2024-05-30 Thread via GitHub


mcgilman opened a new pull request, #8901:
URL: https://github.com/apache/nifi/pull/8901

   NIFI-13321:
   - Fixing the mocking of child components in unit tests.
   - Removing any provided dependency that is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-13321) Fix mocking of child components in unit tests

2024-05-30 Thread Matt Gilman (Jira)
Matt Gilman created NIFI-13321:
--

 Summary: Fix mocking of child components in unit tests
 Key: NIFI-13321
 URL: https://issues.apache.org/jira/browse/NIFI-13321
 Project: Apache NiFi
  Issue Type: Sub-task
  Components: Core UI
Reporter: Matt Gilman
Assignee: Matt Gilman


The existing mocking of child components in unit tests was incorrect and would 
often require the test bed to provide dependencies of the child component. This 
should be fixed so that unit tests can focus on just the component in question 
and not anything functionality of a child component.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-13322) Error banners in dialogs can cause the dialog actions buttons to be unreachable

2024-05-30 Thread Scott Aslan (Jira)
Scott Aslan created NIFI-13322:
--

 Summary: Error banners in dialogs can cause the dialog actions 
buttons to be unreachable
 Key: NIFI-13322
 URL: https://issues.apache.org/jira/browse/NIFI-13322
 Project: Apache NiFi
  Issue Type: Sub-task
Reporter: Scott Aslan
 Attachments: Screenshot 2024-05-30 at 12.25.41 PM.png





--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]

2024-05-30 Thread via GitHub


exceptionfactory commented on PR #8896:
URL: https://github.com/apache/nifi/pull/8896#issuecomment-213928

   > @exceptionfactory Thanks for the help on that! Looking at the javadoc on 
the method `isCommandFailed`
   > 
   > ```
   > /**
   >  * On some environment, the test command immediately fail with an 
IOException
   >  * because of the native UnixProcess.init method implementation 
difference.
   >  *
   >  * @return true, if the command fails
   >  */
   > ```
   > 
   > it would seems to indicate that the JUnit 5 `@EnabledOnOs` annotation 
should be used to run those unit tests this method is used in to only run on a 
Unix environment.
   
   Yes, that is just one of several issues with the test class as it stands. 
There are System.out.println() statements that should be removed, System 
properties that should be removed, and other issues. It would be worth 
rewriting from scratch, with the goal of modernizing the implementation and 
providing better coverage of some scenarios. Not something for this Jira issue, 
but something to consider separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (NIFI-13234) Unauthorized canvas components issues

2024-05-30 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan reassigned NIFI-13234:
--

Assignee: Scott Aslan

> Unauthorized canvas components issues
> -
>
> Key: NIFI-13234
> URL: https://issues.apache.org/jira/browse/NIFI-13234
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
> Attachments: Screenshot 2024-05-14 at 1.01.15 PM.png
>
>
> There are color and contrast ratio issues for unauthorized components on the 
> canvas:
>  
> !Screenshot 2024-05-14 at 1.01.15 PM.png|width=415,height=222!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]

2024-05-30 Thread via GitHub


dan-s1 commented on PR #8896:
URL: https://github.com/apache/nifi/pull/8896#issuecomment-2139843287

   @exceptionfactory Thanks for the help on that! Looking at the javadoc on the 
method `isCommandFailed` 
   ```
   /**
* On some environment, the test command immediately fail with an 
IOException
* because of the native UnixProcess.init method implementation 
difference.
*
* @return true, if the command fails
*/
   ```
   
   it would seems to indicate that the JUnit 5 `@EnabledOnOs` annotation should 
be used to run those unit tests this method is used in to only run on a Unix 
environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13246) Move actions into kebab menu

2024-05-30 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-13246:
---
Status: Patch Available  (was: In Progress)

> Move actions into kebab menu
> 
>
> Key: NIFI-13246
> URL: https://issues.apache.org/jira/browse/NIFI-13246
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> View Provenance event
> View FlowFile
> View Documentation
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet

2024-05-30 Thread Daniel Stieglitz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz reassigned NIFI-13304:
---

Assignee: Daniel Stieglitz

> ExcelReader - ability to split into flowfile per sheet
> --
>
> Key: NIFI-13304
> URL: https://issues.apache.org/jira/browse/NIFI-13304
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Philipp Korniets
>Assignee: Daniel Stieglitz
>Priority: Major
>
> Currently ConvertExcelToCSV processor, if processing excel with multiple 
> required sheets in it, produces flowfile per sheet.
> New ExcelReader produces one flowfile with all data in it
>  
> There should be a way to configure output to be sheet-per-flowfile
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13320) Upgrade Spring Boot to 3.3.0

2024-05-30 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13320:

Status: Patch Available  (was: Open)

> Upgrade Spring Boot to 3.3.0
> 
>
> Key: NIFI-13320
> URL: https://issues.apache.org/jira/browse/NIFI-13320
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Spring Boot dependencies for NiFi Registry should be upgraded to 
> [3.3.0|https://github.com/spring-projects/spring-boot/releases/tag/v3.3.0] to 
> incorporate the latest set of improvements and dependency upgrades. The 3.3.0 
> release provides the latest maintained version beyond the 3.2 series.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] NIFI-13320 Upgrade Spring Boot from 3.2.6 to 3.3.0 for Registry [nifi]

2024-05-30 Thread via GitHub


exceptionfactory opened a new pull request, #8899:
URL: https://github.com/apache/nifi/pull/8899

   # Summary
   
   [NIFI-13320](https://issues.apache.org/jira/browse/NIFI-13320) Upgrades 
Spring Boot dependencies from 3.2.6 to 
[3.3.0](https://github.com/spring-projects/spring-boot/releases/tag/v3.3.0) for 
NiFi Registry.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### UI Contributions
   
   - [ ] NiFi is modernizing its UI. Any contributions that update the [current 
UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui)
 also need to be implemented in the [new 
UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi).
  
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-13320) Upgrade Spring Boot to 3.3.0

2024-05-30 Thread David Handermann (Jira)
David Handermann created NIFI-13320:
---

 Summary: Upgrade Spring Boot to 3.3.0
 Key: NIFI-13320
 URL: https://issues.apache.org/jira/browse/NIFI-13320
 Project: Apache NiFi
  Issue Type: Improvement
  Components: NiFi Registry
Reporter: David Handermann
Assignee: David Handermann


Spring Boot dependencies for NiFi Registry should be upgraded to 
[3.3.0|https://github.com/spring-projects/spring-boot/releases/tag/v3.3.0] to 
incorporate the latest set of improvements and dependency upgrades. The 3.3.0 
release provides the latest maintained version beyond the 3.2 series.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet

2024-05-30 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850743#comment-17850743
 ] 

Daniel Stieglitz commented on NIFI-13304:
-

Probably not as it appears no new features are being added to 1.x

> ExcelReader - ability to split into flowfile per sheet
> --
>
> Key: NIFI-13304
> URL: https://issues.apache.org/jira/browse/NIFI-13304
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Philipp Korniets
>Priority: Major
>
> Currently ConvertExcelToCSV processor, if processing excel with multiple 
> required sheets in it, produces flowfile per sheet.
> New ExcelReader produces one flowfile with all data in it
>  
> There should be a way to configure output to be sheet-per-flowfile
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet

2024-05-30 Thread Philipp Korniets (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850738#comment-17850738
 ] 

Philipp Korniets commented on NIFI-13304:
-

No chance to get it into 1.x versions?

> ExcelReader - ability to split into flowfile per sheet
> --
>
> Key: NIFI-13304
> URL: https://issues.apache.org/jira/browse/NIFI-13304
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Philipp Korniets
>Priority: Major
>
> Currently ConvertExcelToCSV processor, if processing excel with multiple 
> required sheets in it, produces flowfile per sheet.
> New ExcelReader produces one flowfile with all data in it
>  
> There should be a way to configure output to be sheet-per-flowfile
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet

2024-05-30 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850736#comment-17850736
 ] 

Daniel Stieglitz edited comment on NIFI-13304 at 5/30/24 2:31 PM:
--

{quote}
Yes, something like that. Why not take a step further - split and convert to a 
target format? So we can get N csvs, or N jsons or else ..
{quote}
That issue is addressed in [Remove Deprecated 
Components|https://cwiki.apache.org/confluence/display/NIFI/NiFi+2.0+Release+Goals#NiFi2.0ReleaseGoals-RemoveDeprecatedComponents]


was (Author: JIRAUSER294662):
{quote}
Yes, something like that. Why not take a step further - split and convert to a 
target format? So we can get N csvs, or N jsons or else ..
{quote}
[Remove Deprecated 
Components|https://cwiki.apache.org/confluence/display/NIFI/NiFi+2.0+Release+Goals#NiFi2.0ReleaseGoals-RemoveDeprecatedComponents]

> ExcelReader - ability to split into flowfile per sheet
> --
>
> Key: NIFI-13304
> URL: https://issues.apache.org/jira/browse/NIFI-13304
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Philipp Korniets
>Priority: Major
>
> Currently ConvertExcelToCSV processor, if processing excel with multiple 
> required sheets in it, produces flowfile per sheet.
> New ExcelReader produces one flowfile with all data in it
>  
> There should be a way to configure output to be sheet-per-flowfile
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet

2024-05-30 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850736#comment-17850736
 ] 

Daniel Stieglitz commented on NIFI-13304:
-

{quote}
Yes, something like that. Why not take a step further - split and convert to a 
target format? So we can get N csvs, or N jsons or else ..
{quote}
[Remove Deprecated 
Components|https://cwiki.apache.org/confluence/display/NIFI/NiFi+2.0+Release+Goals#NiFi2.0ReleaseGoals-RemoveDeprecatedComponents]

> ExcelReader - ability to split into flowfile per sheet
> --
>
> Key: NIFI-13304
> URL: https://issues.apache.org/jira/browse/NIFI-13304
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Philipp Korniets
>Priority: Major
>
> Currently ConvertExcelToCSV processor, if processing excel with multiple 
> required sheets in it, produces flowfile per sheet.
> New ExcelReader produces one flowfile with all data in it
>  
> There should be a way to configure output to be sheet-per-flowfile
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (NIFI-13246) Move actions into kebab menu

2024-05-30 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan reassigned NIFI-13246:
--

Assignee: Scott Aslan

> Move actions into kebab menu
> 
>
> Key: NIFI-13246
> URL: https://issues.apache.org/jira/browse/NIFI-13246
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>
> View Provenance event
> View FlowFile
> View Documentation
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13312) Restructure as an nx monorepo

2024-05-30 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-13312:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Restructure as an nx monorepo
> -
>
> Key: NIFI-13312
> URL: https://issues.apache.org/jira/browse/NIFI-13312
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In preparation for maintaining various ui "apps" in this repo (nifi proper, 
> documentation, custom ui, ...) we should move to a nx monorepo structure 
> where nifi is the default project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread Mark Bathori (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Bathori updated NIFI-13315:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> ListAzureBlobStorage_v12 fails when Record Writer is used
> -
>
> Key: NIFI-13315
> URL: https://issues.apache.org/jira/browse/NIFI-13315
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 1.27.0, 2.0.0-M4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> BlobInfo declares Container Name as type of boolean in the record schema 
> which fails when the records are written.
> {code}
> 2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
> o.a.n.p.a.s.ListAzureBlobStorage_v12 
> ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
> write MapRecord[{container=container1, 
> blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
> filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
> primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
>  length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
> blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
> ["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
> "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
> "STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> as a JSON Object due to 
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.toBoolean(DataTypeUtils.java:1224)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:199)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:178)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:349)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:233)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:157)
>     at 
> org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59)
>     at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
>     at jdk.proxy55/jdk.proxy55.$Proxy220.write(Unknown Source)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.createRecordsForEntities(AbstractListProcessor.java:940)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByNoTracking(AbstractListProcessor.java:584)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread Mark Bathori (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Bathori updated NIFI-13315:

Fix Version/s: 1.27.0
   2.0.0-M4

> ListAzureBlobStorage_v12 fails when Record Writer is used
> -
>
> Key: NIFI-13315
> URL: https://issues.apache.org/jira/browse/NIFI-13315
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 1.27.0, 2.0.0-M4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> BlobInfo declares Container Name as type of boolean in the record schema 
> which fails when the records are written.
> {code}
> 2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
> o.a.n.p.a.s.ListAzureBlobStorage_v12 
> ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
> write MapRecord[{container=container1, 
> blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
> filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
> primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
>  length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
> blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
> ["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
> "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
> "STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> as a JSON Object due to 
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.toBoolean(DataTypeUtils.java:1224)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:199)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:178)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:349)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:233)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:157)
>     at 
> org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59)
>     at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
>     at jdk.proxy55/jdk.proxy55.$Proxy220.write(Unknown Source)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.createRecordsForEntities(AbstractListProcessor.java:940)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByNoTracking(AbstractListProcessor.java:584)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850725#comment-17850725
 ] 

ASF subversion and git services commented on NIFI-13315:


Commit 1a4de1f8381292592a661176dbc4cd2852990bc6 in nifi's branch 
refs/heads/support/nifi-1.x from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1a4de1f838 ]

NIFI-13315 Fixed ListAzureBlobStorage_v12 fails when Record Writer is used

This closes #8897

Signed-off-by: Mark Bathori 


> ListAzureBlobStorage_v12 fails when Record Writer is used
> -
>
> Key: NIFI-13315
> URL: https://issues.apache.org/jira/browse/NIFI-13315
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> BlobInfo declares Container Name as type of boolean in the record schema 
> which fails when the records are written.
> {code}
> 2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
> o.a.n.p.a.s.ListAzureBlobStorage_v12 
> ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
> write MapRecord[{container=container1, 
> blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
> filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
> primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
>  length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
> blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
> ["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
> "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
> "STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> as a JSON Object due to 
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.toBoolean(DataTypeUtils.java:1224)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:199)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:178)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:349)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:233)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:157)
>     at 
> org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59)
>     at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
>     at jdk.proxy55/jdk.proxy55.$Proxy220.write(Unknown Source)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.createRecordsForEntities(AbstractListProcessor.java:940)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByNoTracking(AbstractListProcessor.java:584)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13312) Restructure as an nx monorepo

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850723#comment-17850723
 ] 

ASF subversion and git services commented on NIFI-13312:


Commit a8ba9e99c437b0e89e5cd995d876c4cdb60f1836 in nifi's branch 
refs/heads/main from Rob Fellows
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a8ba9e99c4 ]

[NIFI-13312] - Restructure as an Nx monorepo (#8893)

* [NIFI-13312] - Restructure as an Nx monorepo

* restored lint:fix functionality, updated package-lock

This closes #8893 

> Restructure as an nx monorepo
> -
>
> Key: NIFI-13312
> URL: https://issues.apache.org/jira/browse/NIFI-13312
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In preparation for maintaining various ui "apps" in this repo (nifi proper, 
> documentation, custom ui, ...) we should move to a nx monorepo structure 
> where nifi is the default project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [NIFI-13312] - Restructure as an Nx monorepo [nifi]

2024-05-30 Thread via GitHub


mcgilman merged PR #8893:
URL: https://github.com/apache/nifi/pull/8893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-13265 Removed the instantiation of Object arrays for arguments in ComponentLog log and org.slf4j.Logger statements. [nifi]

2024-05-30 Thread via GitHub


exceptionfactory commented on PR #8896:
URL: https://github.com/apache/nifi/pull/8896#issuecomment-2139613747

   > @exceptionfactory Can you please advise on iif s there something I checked 
in that caused the following exceptions
   > 
   > ```
   > Error:TestExecuteProcess.testNotRedirectErrorStream:241 If redirect 
error stream is false, the output should be logged as a warning so that user 
can notice on bulletin. ==> expected: <1> but was: <0>
   > Error:TestExecuteProcess.testRedirectErrorStream:268 expected: <1> but 
was: <0>
   > ```
   > 
   > Those tests on my computer are working and they are working on the MacOS. 
What more can I do for this?
   
   @dan-s1 The `TestExecuteProcess` class has some design issues, but it 
appears that this particular issue could be related to the `isCommandFailed()` 
method in `TestExecuteProcess`. That method looks for an error message 
containing the words `due to` on line 308. Removing the `due to` portion of the 
string should align with the changes you have implemented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-13319) Add support to Stop and Disable from CS Configuration

2024-05-30 Thread Matt Gilman (Jira)
Matt Gilman created NIFI-13319:
--

 Summary: Add support to Stop and Disable from CS Configuration
 Key: NIFI-13319
 URL: https://issues.apache.org/jira/browse/NIFI-13319
 Project: Apache NiFi
  Issue Type: Sub-task
  Components: Core UI
Reporter: Matt Gilman


While a Service is enabled, the configuration dialog is shown in read only 
form. When the user wants to make configuration changes, they need to disable 
the component before they can open the Edit dialog.

This Jira is tracking the introduction of being able to disable the enabled 
Service and automatically have the Edit dialog being opened to reduce the 
interaction and number of clicks needed to disable the component manually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-13318) Add support to Stop and Configure from Processor Configuration

2024-05-30 Thread Matt Gilman (Jira)
Matt Gilman created NIFI-13318:
--

 Summary: Add support to Stop and Configure from Processor 
Configuration
 Key: NIFI-13318
 URL: https://issues.apache.org/jira/browse/NIFI-13318
 Project: Apache NiFi
  Issue Type: Sub-task
Reporter: Matt Gilman


While a Processor is running, the configuration dialog is shown in read only 
form. When the user wants to make configuration changes, they need to stop the 
component and wait for active threads to stop before they can open the Edit 
dialog.

This Jira is tracking the introduction of being able to stop the running 
Processor and automatically have the Edit dialog being opened to reduce the 
interaction and number of clicks needed to stop the component manually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13267 - Bump NiFi NAR Maven plugin version [nifi]

2024-05-30 Thread via GitHub


bbende commented on code in PR #8860:
URL: https://github.com/apache/nifi/pull/8860#discussion_r1620747959


##
nifi-manifest/nifi-runtime-manifest-core/src/main/java/org/apache/nifi/runtime/manifest/impl/StandardComponentManifestBuilder.java:
##
@@ -61,6 +65,24 @@ public ComponentManifestBuilder addReportingTask(final 
ReportingTaskDefinition r
 return this;
 }
 
+@Override
+public ComponentManifestBuilder 
addParameterProvider(ParameterProviderDefinition parameterProviderDefinition) {
+if (parameterProviderDefinition == null) {
+throw new IllegalArgumentException("Parameter Provider definition 
cannot be null");
+}
+parameterProviders.add(parameterProviderDefinition);
+return this;
+}
+
+@Override
+public ComponentManifestBuilder 
addFlowAnalysisRule(FlowAnalysisRuleDefinition flowAnalysisRuleDefinition) {
+if (flowAnalysisRuleDefinition == null) {
+throw new IllegalArgumentException("Flow Analysis Rule definition 
cannot be null");
+}
+flowAnalysisRules.add(flowAnalysisRuleDefinition);
+return this;
+}
+

Review Comment:
   There is still one change needed here in the final `build` method, it needs 
to set the parameter providers and flow analysis rules from the builder into 
the final `ComponentManifest`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-13317) Read only Connection Configuration from Summary

2024-05-30 Thread Matt Gilman (Jira)
Matt Gilman created NIFI-13317:
--

 Summary: Read only Connection Configuration from Summary
 Key: NIFI-13317
 URL: https://issues.apache.org/jira/browse/NIFI-13317
 Project: Apache NiFi
  Issue Type: Sub-task
Reporter: Matt Gilman


>From the Summary page NiFi should support showing the Connection configuration 
>dialog in read only form.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-13316) Read only Processor Configuration from Summary

2024-05-30 Thread Matt Gilman (Jira)
Matt Gilman created NIFI-13316:
--

 Summary: Read only Processor Configuration from Summary
 Key: NIFI-13316
 URL: https://issues.apache.org/jira/browse/NIFI-13316
 Project: Apache NiFi
  Issue Type: Sub-task
  Components: Core UI
Reporter: Matt Gilman


>From the Summary page NiFi should support showing the Processor configuration 
>dialog in read only form.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported features

2024-05-30 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-12400:
---
Summary: Remaining items to migrate UI to currently supported features  
(was: Remaining items to migrate UI to currently supported/active framework)

> Remaining items to migrate UI to currently supported features
> -
>
> Key: NIFI-12400
> URL: https://issues.apache.org/jira/browse/NIFI-12400
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> The purpose of this Jira is to track all remaining items following the 
> initial commit [1] for NIFI-11481. The description will be kept up to date 
> with remaining features, tasks, and improvements. As each items is worked, a 
> new sub task Jira will be created and referenced in this description.
>  * Support Parameters in Properties with Allowable Values (NIFI-12401)
>  * Summary (NIFI-12437)
>  ** Remaining work not addressed in initial Jira:
>  *** input ports (NIFI-12504)
>  *** output ports (NIFI-12504)
>  *** remote process groups (NIFI-12504)
>  *** process groups (NIFI-12504)
>  *** connections (NIFI-12504)
>  *** System Diagnostics (NIFI-12505)
>  *** support for cluster-specific ui elements (NIFI-12537)
>  *** Add pagination (NIFI-12552)
>  *** Support Processor Details dialog
>  *** Support Connection Details dialog
>  * Counters (NIFI-12415)
>  ** Counter table has extra unnecessary can modify check (NIFI-12948)
>  * Bulletin Board (NIFI-12560)
>  * Provenance (NIFI-12445)
>  ** Event Listing (NIFI-12445)
>  ** Search (NIFI-12445)
>  ** Event Dialog (NIFI-12445)
>  ** Lineage (NIFI-12485)
>  ** Replay from context menu (NIFI-12445)
>  ** Clustering (NIFI-12807)
>  * Configure Reporting Task (NIFI-12563)
>  * Flow Analysis Rules (NIFI-12588)
>  * Registry Clients (NIFI-12486)
>  * Import from Registry (NIFI-12734)
>  * Parameter Providers (NIFI-12622)
>  ** Fetch parameters from provider, map to parameter context (dialog) - 
> (NIFI-12665)
>  * Cluster
>  ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053)
>  ** Status History - node specific values (NIFI-12848)
>  * Flow Configuration History (NIFI-12754)
>  ** ActionEntity.action should be optional (NIFI-12948)
>  * Node Status History (NIFI-12553)
>  * Status history for components from canvas context menu (NIFI-12553)
>  * Users (NIFI-12543)
>  ** Don't show users or groups in create/edit dialog is there are none 
> (NIFI-12948)
>  * Policies (NIFI-12548)
>  ** Overridden policy Empty or Copy (NIFI-12679)
>  ** Select Empty by default (NIFI-12948)
>  * Help (NIFI-12795)
>  * About (NIFI-13094)
>  * Show Upstream/Downstream
>  * Align (NIFI-13162)
>  * Replay last event (NIFI-12445)
>  * List Queue (NIFI-12589)
>  ** Clustering (NIFI-12807)
>  * Empty [all] Queue (NIFI-12604)
>  * View Content (NIFI-12589 and NIFI-12445)
>  * View State (NIFI-12611)
>  ** Clustering (NIFI-13005)
>  * Change Component Version (NIFI-13034)
>  * Consider PG permissions in Toolbox (NIFI-12683)
>  * PG Version (NIFI-12963 & NIFI-12995)
>  ** Start (NIFI-12963)
>  ** Commit (NIFI-12963)
>  ** Force Commit (NIFI-12963)
>  ** Show changes (NIFI-12995)
>  ** Revert changes (NIFI-12995)
>  ** Change Flow version (NIFI-12995)
>  ** Stop (NIFI-12963)
>  * Configure PG (NIFI-12417)
>  * Configure Label (NIFI-13081)
>  * Process Group Services (NIFI-12425)
>  ** Listing (NIFI-12425)
>  ** Create (NIFI-12425)
>  ** Configure (NIFI-12425)
>  ** Delete (NIFI-12425)
>  ** Enable (NIFI-12529)
>  ** Disable (NIFI-12529)
>  ** Improve layout and breadcrumbs
>  ** Disable and Configure
>  * Configure Processor
>  ** Service Link (NIFI-12425)
>  ** Create inline Service (NIFI-12425)
>  ** Parameter Link (NIFI-12502)
>  ** Convert to Parameter (NIFI-12502)
>  ** Fix issue with Property Editor width (NIFI-12547)
>  ** Status Bar
>  ** Stop and Configure
>  ** Open Custom UI (NIFI-12958)
>  ** Property History (NIFI-13047)
>  ** Unable to re-add any removed Property (NIFI-12743)
>  ** Shift-Enter new line when editing Property (NIFI-12743)
>  * Property Verification (NIFI-13247)
>  * Terminate Threads (context menu) (NIFI-13068)
>  * Enable/Disable (context menu/operate panel) (NIFI-13078)
>  * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062)
>  * Download Flow (NIFI-13029)
>  * Create RPG (NIFI-12758)
>  * Configure RPG (NIFI-12774)
>  * RPG Remote Ports (NIFI-12778)
>  * RPG Go To (NIFI-12759)
>  * RPG Refresh (NIFI-12761)
>  * Color (context menu/operate panel) (NIFI-13226)
>  * Move to Front (NIFI-13044)
>  * Copy/Paste (context menu/operate panel) (NIFI-13059)
>  * Add/Update Info Icons in dialogs throughout 

[jira] [Resolved] (NIFI-12873) Time inputs don't match dark mode styling

2024-05-30 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-12873.

Resolution: Won't Fix

> Time inputs don't match dark mode styling
> -
>
> Key: NIFI-12873
> URL: https://issues.apache.org/jira/browse/NIFI-12873
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: James Elliott
>Priority: Major
> Attachments: Screenshot 2024-03-07 at 11.20.29 AM.png, Screenshot 
> 2024-03-19 at 10.40.32 AM.png, Screenshot 2024-03-19 at 10.40.42 AM.png
>
>
> Inputs with type="time" get an icon that launches a time selection popup. 
> Unfortunately the icon is always dark, even in dark mode. The popup doesn't 
> have styling applied either.
> !Screenshot 2024-03-07 at 11.20.29 AM.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] NIFI-13242 MiNiFi Sync Resource C2 command [nifi]

2024-05-30 Thread via GitHub


briansolo1985 opened a new pull request, #8898:
URL: https://github.com/apache/nifi/pull/8898

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-13242](https://issues.apache.org/jira/browse/NIFI-13242)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [x] Build completed using `mvn clean install -P contrib-check`
 - [x] JDK 21
   
   ### UI Contributions
   
   - [ ] NiFi is modernizing its UI. Any contributions that update the [current 
UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui)
 also need to be implemented in the [new 
UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi).
  
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850693#comment-17850693
 ] 

ASF subversion and git services commented on NIFI-13315:


Commit 7ea4c067fcbf8861b815a77dac918dcf2910a08a in nifi's branch 
refs/heads/main from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7ea4c067fc ]

NIFI-13315 Fixed ListAzureBlobStorage_v12 fails when Record Writer is used

This closes #8897

Signed-off-by: Mark Bathori 


> ListAzureBlobStorage_v12 fails when Record Writer is used
> -
>
> Key: NIFI-13315
> URL: https://issues.apache.org/jira/browse/NIFI-13315
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> BlobInfo declares Container Name as type of boolean in the record schema 
> which fails when the records are written.
> {code}
> 2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
> o.a.n.p.a.s.ListAzureBlobStorage_v12 
> ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
> write MapRecord[{container=container1, 
> blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
> filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
> primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
>  length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
> blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
> ["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
> "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
> "STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> as a JSON Object due to 
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.toBoolean(DataTypeUtils.java:1224)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:199)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:178)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:349)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:233)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:157)
>     at 
> org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59)
>     at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
>     at jdk.proxy55/jdk.proxy55.$Proxy220.write(Unknown Source)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.createRecordsForEntities(AbstractListProcessor.java:940)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByNoTracking(AbstractListProcessor.java:584)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13315 Fixed ListAzureBlobStorage_v12 fails when Record Writer is… [nifi]

2024-05-30 Thread via GitHub


asfgit closed pull request #8897: NIFI-13315 Fixed ListAzureBlobStorage_v12 
fails when Record Writer is…
URL: https://github.com/apache/nifi/pull/8897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread Peter Turcsanyi (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-13315:
---
Status: Patch Available  (was: Open)

> ListAzureBlobStorage_v12 fails when Record Writer is used
> -
>
> Key: NIFI-13315
> URL: https://issues.apache.org/jira/browse/NIFI-13315
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> BlobInfo declares Container Name as type of boolean in the record schema 
> which fails when the records are written.
> {code}
> 2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
> o.a.n.p.a.s.ListAzureBlobStorage_v12 
> ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
> write MapRecord[{container=container1, 
> blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
> filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
> primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
>  length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
> blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
> ["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
> "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
> "STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> as a JSON Object due to 
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [container1] of type class java.lang.String to Boolean 
> for field container
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.toBoolean(DataTypeUtils.java:1224)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:199)
>     at 
> org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:178)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:349)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:233)
>     at 
> org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:157)
>     at 
> org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59)
>     at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
>     at jdk.proxy55/jdk.proxy55.$Proxy220.write(Unknown Source)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.createRecordsForEntities(AbstractListProcessor.java:940)
>     at 
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByNoTracking(AbstractListProcessor.java:584)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] NIFI-13315 Fixed ListAzureBlobStorage_v12 fails when Record Writer is… [nifi]

2024-05-30 Thread via GitHub


turcsanyip opened a new pull request, #8897:
URL: https://github.com/apache/nifi/pull/8897

   … used
   
   # Summary
   
   [NIFI-13315](https://issues.apache.org/jira/browse/NIFI-13315)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### UI Contributions
   
   - [ ] NiFi is modernizing its UI. Any contributions that update the [current 
UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui)
 also need to be implemented in the [new 
UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi).
  
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread Peter Turcsanyi (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-13315:
---
Description: 
BlobInfo declares Container Name as type of boolean in the record schema which 
fails when the records are written.

{code}
2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
o.a.n.p.a.s.ListAzureBlobStorage_v12 
ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
write MapRecord[{container=container1, 
blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
 length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
"container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
"STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
as a JSON Object due to 
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of type class java.lang.String to Boolean for 
field container
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of type class java.lang.String to Boolean for 
field container
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.toBoolean(DataTypeUtils.java:1224)
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:199)
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:178)
    at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:349)
    at 
org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:233)
    at 
org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:157)
    at 
org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59)
    at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
    at java.base/java.lang.reflect.Method.invoke(Method.java:580)
    at 
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
    at 
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
    at jdk.proxy55/jdk.proxy55.$Proxy220.write(Unknown Source)
    at 
org.apache.nifi.processor.util.list.AbstractListProcessor.createRecordsForEntities(AbstractListProcessor.java:940)
    at 
org.apache.nifi.processor.util.list.AbstractListProcessor.listByNoTracking(AbstractListProcessor.java:584)
{code}

  was:
BlobInfo declares Container Name as type of boolean in the record schema which 
fails when the records are written.

{noformat}
2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
o.a.n.p.a.s.ListAzureBlobStorage_v12 
ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
write MapRecord[{container=container1, 
blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
 length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
"container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
"STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
as a JSON Object due to 
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of type class java.lang.String to Boolean for 
field container
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of 

[jira] [Updated] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread Peter Turcsanyi (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-13315:
---
Description: 
BlobInfo declares Container Name as type of boolean in the record schema which 
fails when the records are written.

{noformat}
2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
o.a.n.p.a.s.ListAzureBlobStorage_v12 
ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
write MapRecord[{container=container1, 
blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
 length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
"container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
"STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
as a JSON Object due to 
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of type class java.lang.String to Boolean for 
field container
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of type class java.lang.String to Boolean for 
field container
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.toBoolean(DataTypeUtils.java:1224)
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:199)
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:178)
    at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:349)
    at 
org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:233)
    at 
org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:157)
    at 
org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59)
    at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
    at java.base/java.lang.reflect.Method.invoke(Method.java:580)
    at 
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
    at 
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
    at jdk.proxy55/jdk.proxy55.$Proxy220.write(Unknown Source)
    at 
org.apache.nifi.processor.util.list.AbstractListProcessor.createRecordsForEntities(AbstractListProcessor.java:940)
    at 
org.apache.nifi.processor.util.list.AbstractListProcessor.listByNoTracking(AbstractListProcessor.java:584)
{noformat}

  was:
BlobInfo declares Container Name as type of boolean in the record schema which 
fails when the records are written.
{code:java}
2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
o.a.n.p.a.s.ListAzureBlobStorage_v12 
ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
write MapRecord[{container=container1, 
blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
 length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
"container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
"STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
as a JSON Object due to 
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of type class java.lang.String to Boolean for 
field container
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value 

[jira] [Updated] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread Peter Turcsanyi (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-13315:
---
Description: 
BlobInfo declares Container Name as type of boolean in the record schema which 
fails when the records are written.
{code:java}
2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
o.a.n.p.a.s.ListAzureBlobStorage_v12 
ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
write MapRecord[{container=container1, 
blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
 length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
"container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
and writer schema ["blobName" : "STRING", "blobType" : "STRING", "filename" : 
"STRING", "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
"TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
"contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
as a JSON Object due to 
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of type class java.lang.String to Boolean for 
field container
org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
Cannot convert value [container1] of type class java.lang.String to Boolean for 
field container
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.toBoolean(DataTypeUtils.java:1224)
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:199)
    at 
org.apache.nifi.serialization.record.util.DataTypeUtils.convertType(DataTypeUtils.java:178)
    at org.apache.nifi.json.WriteJsonResult.writeValue(WriteJsonResult.java:349)
    at 
org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:233)
    at 
org.apache.nifi.json.WriteJsonResult.writeRecord(WriteJsonResult.java:157)
    at 
org.apache.nifi.serialization.AbstractRecordSetWriter.write(AbstractRecordSetWriter.java:59)
    at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
    at java.base/java.lang.reflect.Method.invoke(Method.java:580)
    at 
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
    at 
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
    at jdk.proxy55/jdk.proxy55.$Proxy220.write(Unknown Source)
    at 
org.apache.nifi.processor.util.list.AbstractListProcessor.createRecordsForEntities(AbstractListProcessor.java:940)
    at 
org.apache.nifi.processor.util.list.AbstractListProcessor.listByNoTracking(AbstractListProcessor.java:584){code}

  was:BlobInfo declares Container Name as type of boolean in the record schema 
which fails when the records are written.


> ListAzureBlobStorage_v12 fails when Record Writer is used
> -
>
> Key: NIFI-13315
> URL: https://issues.apache.org/jira/browse/NIFI-13315
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>
> BlobInfo declares Container Name as type of boolean in the record schema 
> which fails when the records are written.
> {code:java}
> 2024-05-30 12:23:54,794 ERROR [Timer-Driven Process Thread-9] 
> o.a.n.p.a.s.ListAzureBlobStorage_v12 
> ListAzureBlobStorage_v12[id=dee130d2-d89c-3894-40ba-bc5dd5e52d2b] Failed to 
> write MapRecord[{container=container1, 
> blobName=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, 
> filename=fea8dfbd-a53c-40f7-ad11-faaefdc7a99c, secondaryUri=null, 
> primaryUri=https://turcsanyiblob.blob.core.windows.net/container1/fea8dfbd-a53c-40f7-ad11-faaefdc7a99c,
>  length=5, language=null, etag=0x8DC3A36EF89F172, lastModified=170932868, 
> blobType=BlockBlob, contentType=application/octet-stream}] with reader schema 
> ["blobName" : "STRING", "blobType" : "STRING", "filename" : "STRING", 
> "container" : "BOOLEAN", "length" : "LONG", "lastModified" : 
> "TIMESTAMP:-MM-dd HH:mm:ss", "etag" : "STRING", "language" : "STRING", 
> "contentType" : "STRING", "primaryUri" : "STRING", "secondaryUri" : "STRING"] 
> and writer schema ["blobName" : "STRING", "blobType" : "STRING", 

[jira] [Updated] (NIFI-13315) ListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread Peter Turcsanyi (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-13315:
---
Summary: ListAzureBlobStorage_v12 fails when Record Writer is used  (was: 
ListListAzureBlobStorage_v12 fails when Record Writer is used)

> ListAzureBlobStorage_v12 fails when Record Writer is used
> -
>
> Key: NIFI-13315
> URL: https://issues.apache.org/jira/browse/NIFI-13315
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>
> BlobInfo declares Container Name as type of boolean in the record schema 
> which fails when the records are written.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-13315) ListListAzureBlobStorage_v12 fails when Record Writer is used

2024-05-30 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-13315:
--

 Summary: ListListAzureBlobStorage_v12 fails when Record Writer is 
used
 Key: NIFI-13315
 URL: https://issues.apache.org/jira/browse/NIFI-13315
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Peter Turcsanyi
Assignee: Peter Turcsanyi


BlobInfo declares Container Name as type of boolean in the record schema which 
fails when the records are written.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet

2024-05-30 Thread Philipp Korniets (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850657#comment-17850657
 ] 

Philipp Korniets edited comment on NIFI-13304 at 5/30/24 9:42 AM:
--

Yes, something like that. Why not take a step further - split and convert to a 
target format? So we can get N csvs, or N jsons or else ..

 

If we link it with https://issues.apache.org/jira/browse/NIFI-12491 - could be 
a nice solution 


was (Author: iiojj2):
Yes, something like that. Why not take a step further - split and convert to a 
target format? So we can get N csvs, or N jsons or else ..

> ExcelReader - ability to split into flowfile per sheet
> --
>
> Key: NIFI-13304
> URL: https://issues.apache.org/jira/browse/NIFI-13304
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Philipp Korniets
>Priority: Major
>
> Currently ConvertExcelToCSV processor, if processing excel with multiple 
> required sheets in it, produces flowfile per sheet.
> New ExcelReader produces one flowfile with all data in it
>  
> There should be a way to configure output to be sheet-per-flowfile
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-13304) ExcelReader - ability to split into flowfile per sheet

2024-05-30 Thread Philipp Korniets (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-13304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850657#comment-17850657
 ] 

Philipp Korniets commented on NIFI-13304:
-

Yes, something like that. Why not take a step further - split and convert to a 
target format? So we can get N csvs, or N jsons or else ..

> ExcelReader - ability to split into flowfile per sheet
> --
>
> Key: NIFI-13304
> URL: https://issues.apache.org/jira/browse/NIFI-13304
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Philipp Korniets
>Priority: Major
>
> Currently ConvertExcelToCSV processor, if processing excel with multiple 
> required sheets in it, produces flowfile per sheet.
> New ExcelReader produces one flowfile with all data in it
>  
> There should be a way to configure output to be sheet-per-flowfile
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-13267 - Bump NiFi NAR Maven plugin version [nifi]

2024-05-30 Thread via GitHub


pvillard31 commented on PR #8860:
URL: https://github.com/apache/nifi/pull/8860#issuecomment-2139052820

   Thanks @bbende for switching the status of this PR. This is ready for review 
/ merge from my PoV.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org