[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-07 Thread via GitHub 


fgerlits commented on code in PR #1498:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093407989


##
minifi_main/MiNiFiMain.cpp:
##
@@ -258,7 +259,11 @@ int main(int argc, char **argv) {
 
 minifi::core::extension::ExtensionManager::get().initialize(configure);
 
-if (argc >= 3 && std::string("docs") == argv[1]) {
+if (argc >= 2 && std::string("docs") == argv[1]) {
+  if (argc == 2) {

Review Comment:
   yes, good idea, done in 205ed38ec5e8677a58ba7900ff2a20409cb50ee3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-07 Thread via GitHub 


fgerlits commented on code in PR #1498:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093407232


##
minifi_main/MiNiFiWindowsService.h:
##
@@ -20,10 +20,12 @@
 #ifdef WIN32
 
 #include 
+#include 
+
 #include "core/Core.h"
 
 void RunAsServiceIfNeeded();
-HANDLE GetTerminationEventHandle(bool* isStartedByService);
+std::tuple GetTerminationEventHandle();

Review Comment:
   OK, done in 503afa2109daece2a98fe2450c2162ff9dd632c2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub 


fgerlits commented on code in PR #1498:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093407989


##
minifi_main/MiNiFiMain.cpp:
##
@@ -258,7 +259,11 @@ int main(int argc, char **argv) {
 
 minifi::core::extension::ExtensionManager::get().initialize(configure);
 
-if (argc >= 3 && std::string("docs") == argv[1]) {
+if (argc >= 2 && std::string("docs") == argv[1]) {
+  if (argc == 2) {

Review Comment:
   yes, good idea, done in 4388f346770f907b725052893d8063d33ab9a6e3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub 


fgerlits commented on code in PR #1498:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093407232


##
minifi_main/MiNiFiWindowsService.h:
##
@@ -20,10 +20,12 @@
 #ifdef WIN32
 
 #include 
+#include 
+
 #include "core/Core.h"
 
 void RunAsServiceIfNeeded();
-HANDLE GetTerminationEventHandle(bool* isStartedByService);
+std::tuple GetTerminationEventHandle();

Review Comment:
   OK, done in c81662e94abefbea9ac993a2cdb551d16ee55ecd



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-01-27 Thread via GitHub 


fgerlits commented on code in PR #1498:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1088759960


##
minifi_main/MiNiFiWindowsService.h:
##
@@ -20,10 +20,12 @@
 #ifdef WIN32
 
 #include 
+#include 
+
 #include "core/Core.h"
 
 void RunAsServiceIfNeeded();
-HANDLE GetTerminationEventHandle(bool* isStartedByService);
+std::tuple GetTerminationEventHandle();

Review Comment:
   or I guess we could do just this: 
https://github.com/fgerlits/nifi-minifi-cpp/commit/c81662e94abefbea9ac993a2cdb551d16ee55ecd
 -- still not sure it's worth it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-01-27 Thread via GitHub 


fgerlits commented on code in PR #1498:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1088750787


##
minifi_main/MiNiFiWindowsService.h:
##
@@ -20,10 +20,12 @@
 #ifdef WIN32
 
 #include 
+#include 
+
 #include "core/Core.h"
 
 void RunAsServiceIfNeeded();
-HANDLE GetTerminationEventHandle(bool* isStartedByService);
+std::tuple GetTerminationEventHandle();

Review Comment:
   we only call this function from one place, and the parts are named where we 
call it, so I'm not sure it's worth it
   
   did you mean something like this? 
https://github.com/fgerlits/nifi-minifi-cpp/commit/02a2b692c4d924dfbb522ac0eb71a007c84dbd69



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org