[GitHub] nifi pull request #2679: NIFI-5141: Updated regex for doubles to allow for n...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2679


---

[GitHub] nifi pull request #2679: NIFI-5141: Updated regex for doubles to allow for n...

[bdesert]

Github user bdesert commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2679#discussion_r186609421
  
--- Diff: 
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
 ---
@@ -60,19 +60,19 @@
 private static final String Infinity = "(Infinity)";
 private static final String NotANumber = "(NaN)";
 
-private static final String Base10Digits  = "\\d+";
-private static final String Base10Decimal  = "\\." + Base10Digits;
-private static final String OptionalBase10Decimal  = Base10Decimal + 
"?";
+private static final String Base10Digits = "\\d+";
+private static final String Base10Decimal = "\\." + Base10Digits;
+private static final String OptionalBase10Decimal = "(" + 
Base10Decimal + ")?";
 
-private static final String Base10Exponent  = "[eE]" + 
OptionalSign + Base10Digits;
+private static final String Base10Exponent = "[eE]" + OptionalSign + 
Base10Digits;
 private static final String OptionalBase10Exponent = "(" + 
Base10Exponent + ")?";
 
 private static final String  doubleRegex =
 OptionalSign +
 "(" +
 Infinity + "|" +
 NotANumber + "|"+
-"(" + Base10Digits + Base10Decimal + ")" + "|" +
+"(" + Base10Digits + OptionalBase10Decimal + ")" + "|" +
 "(" + Base10Digits + OptionalBase10Decimal + Base10Exponent + 
")" + "|" +
--- End diff --

I think it'd be nice to have also:
"(" + Base10Digits + "\\." + ")" + "|" + 



---

[GitHub] nifi pull request #2679: NIFI-5141: Updated regex for doubles to allow for n...

[markap14]

GitHub user markap14 opened a pull request:

https://github.com/apache/nifi/pull/2679

NIFI-5141: Updated regex for doubles to allow for numbers that have n…

…o decimal

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markap14/nifi NIFI-5141

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2679


commit a46ab9a94eb2b9ae49cd3b8a4d26d7d694f23cf3
Author: Mark Payne 
Date:   2018-05-04T19:35:00Z

NIFI-5141: Updated regex for doubles to allow for numbers that have no 
decimal




---