[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023568#comment-16023568
 ] 

ASF GitHub Bot commented on NIFI-3963:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1853


> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
> Fix For: 1.3.0
>
> Attachments: Screen Shot 2017-05-23 at 5.07.45 PM.png, 
> unable-to-reproduce-nifi-3963.png
>
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023563#comment-16023563
 ] 

ASF GitHub Bot commented on NIFI-3963:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1853
  
+1 Looks good, repeated the steps outline by Joe P and can see that we are 
now yielding correctly, will merge to master


> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
> Fix For: 1.3.0
>
> Attachments: Screen Shot 2017-05-23 at 5.07.45 PM.png, 
> unable-to-reproduce-nifi-3963.png
>
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023483#comment-16023483
 ] 

ASF GitHub Bot commented on NIFI-3963:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1853
  
Reviewing...


> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
> Fix For: 1.3.0
>
> Attachments: Screen Shot 2017-05-23 at 5.07.45 PM.png, 
> unable-to-reproduce-nifi-3963.png
>
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023410#comment-16023410
 ] 

ASF GitHub Bot commented on NIFI-3963:
--

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/1853

NIFI-3963: RPG Yield Issue

NIFI-3963:
- Ensuring the RemoteGroupPort yields when the details cannot be refreshed 
from any of the configured remote instances.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-3963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1853.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1853


commit 12fd5f942df1531b28a25bd2eb369d58d7677934
Author: Matt Gilman 
Date:   2017-05-24T18:28:51Z

NIFI-3963:
- Ensuring the RemoteGroupPort yields when the details cannot be refreshed 
from any of the configured remote instances.




> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
> Fix For: 1.3.0
>
> Attachments: Screen Shot 2017-05-23 at 5.07.45 PM.png, 
> unable-to-reproduce-nifi-3963.png
>
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[Matt Gilman (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023113#comment-16023113
 ] 

Matt Gilman commented on NIFI-3963:
---

Thanks for the clarification [~JPercivall]. I have successfully replicated the 
issue.

> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
> Attachments: Screen Shot 2017-05-23 at 5.07.45 PM.png, 
> unable-to-reproduce-nifi-3963.png
>
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[Joseph Percivall (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021909#comment-16021909
 ] 

Joseph Percivall commented on NIFI-3963:


Also I verified in the flow.xml that the yield period is "10 sec"

> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
> Attachments: Screen Shot 2017-05-23 at 5.07.45 PM.png, 
> unable-to-reproduce-nifi-3963.png
>
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[Joseph Percivall (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021897#comment-16021897
 ] 

Joseph Percivall commented on NIFI-3963:


Hey [~mcgilman], I believe I've narrowed it down. I can reliably replicate when 
the RPG is pulling from an output port. So the steps are:

Initial state: 2 NiFi instances. One instance with an output port (seen with a 
1.1.1 or 1.2.0 instance here). The second being a 1.2.0 instance with an RPG 
set up to pull from that output port. 

1: Enable transmission on the RPG to start pulling from the output port
2: Stop the output port instance (ie. "nifi.sh stop")
3: Disable transmission on the RPG
4: Enable transmission on the RPG
5: Wait a couple seconds
6: See a flood of failed requests in the logs.

I will be attached an screenshot of the logs where I disable then reenable it.

I have not been able to reproduce when it is an input port instead of an output 
port.


> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
> Attachments: unable-to-reproduce-nifi-3963.png
>
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[Matt Gilman (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021795#comment-16021795
 ] 

Matt Gilman commented on NIFI-3963:
---

I've also tried terminating the target instance but the yield duration seems to 
be honored. I do see some logging about trying to refresh the peer list in the 
background. However, the RemoteGroupPort does not appear to trigger again until 
the yield duration completes.

> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
> Attachments: unable-to-reproduce-nifi-3963.png
>
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3963) Remote Process Group does not honor yield duration if transmission is disabled then reenabled

[Matt Gilman (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021756#comment-16021756
 ] 

Matt Gilman commented on NIFI-3963:
---

[~JPercivall] I have been unable to reproduce this issue with the supplied 
steps. I've attached a screenshot showing the yield duration being honored 
throughout multiple transmission cycles. 

Any other details that may help me reproduce? Can you check the flow.xml.gz to 
see the configuration value in there?

> Remote Process Group does not honor yield duration if transmission is 
> disabled then reenabled
> -
>
> Key: NIFI-3963
> URL: https://issues.apache.org/jira/browse/NIFI-3963
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Joseph Percivall
>
> To reproduce, create two NiFi instances properly set up for unsecure or 
> secure  S2S. One on side add an input/output port and the other an RPG. 
> Enable transmission on the RPG. Stop the instance with the port. On the 
> running instance see NiFi honoring the yield duration. Then stop and start 
> transmission, see NiFi repeatedly attempt to connect to the instance (I saw 
> multiple log messages per millisecond). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)