[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317701#comment-16317701
 ] 

ASF subversion and git services commented on NIFI-4697:
---

Commit 6e7544bd3786fa829fedf1e284488e6756664f2c in nifi's branch 
refs/heads/master from [~boardm26]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=6e7544b ]

NIFI-4697 This closes #2381. clarified some PostHTTP documentation

Signed-off-by: joewitt 


> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Assignee: Michael Moser
>Priority: Minor
> Fix For: 1.5.0
>
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317702#comment-16317702
 ] 

ASF GitHub Bot commented on NIFI-4697:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2381


> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Assignee: Michael Moser
>Priority: Minor
> Fix For: 1.5.0
>
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[Michael Hogue (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317643#comment-16317643
 ] 

Michael Hogue commented on NIFI-4697:
-

No problem, [~mosermw]! Thanks for picking it up.

> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Assignee: Michael Moser
>Priority: Minor
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[Michael Moser (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313962#comment-16313962
 ] 

Michael Moser commented on NIFI-4697:
-

Hi [~m-hogue] I noticed that you assigned this ticket to yourself, and I hope 
you don't mind that I went ahead and put up a PR for it, since it was simple.  
I added a few words about connection pooling, which I thought were useful and 
appropriate.

> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Assignee: Michael Hogue
>Priority: Minor
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313922#comment-16313922
 ] 

ASF GitHub Bot commented on NIFI-4697:
--

GitHub user mosermw opened a pull request:

https://github.com/apache/nifi/pull/2381

NIFI-4697 clarified some PostHTTP documentation

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?
- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [N/A] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [N/A] If applicable, have you updated the LICENSE file, including the 
main LICENSE file under nifi-assembly?
- [N/A] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [N/A] If adding new Properties, have you added .displayName in addition 
to .name (programmatic access) for each of the new properties?

### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mosermw/nifi nifi-4697

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2381


commit 3f503b890aa0278b42a9d3e43c75a37dab430e38
Author: Mike Moser 
Date:   2018-01-05T21:13:05Z

NIFI-4697 clarified some PostHTTP documentation




> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Assignee: Michael Hogue
>Priority: Minor
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[Brandon DeVries (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294003#comment-16294003
 ] 

Brandon DeVries commented on NIFI-4697:
---

I think that wording's good.  no harm in being explicit.

> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Assignee: Michael Hogue
>Priority: Minor
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[Michael Hogue (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293957#comment-16293957
 ] 

Michael Hogue commented on NIFI-4697:
-

How about "The URL to POST to. The URL may be defined using the Attribute 
Expression Language."

> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Assignee: Michael Hogue
>Priority: Minor
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[Brandon DeVries (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293225#comment-16293225
 ] 

Brandon DeVries commented on NIFI-4697:
---

I might have been unclear.  Expression language is supported... anywhere in the 
URL (i.e. not limited as indicated in the description).  There's no bug in the 
processor, the documentation just indicates a *restriction* that isn't there.

> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Priority: Minor
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293137#comment-16293137
 ] 

Joseph Witt commented on NIFI-4697:
---

i should have said that differently:

Can you provide a test which can replicate the issue you're seeing.  Ideally a 
unit test that fails for now but would work once the bug is fixed.

> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Priority: Minor
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4697) PostHTTP: correct documentation

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293102#comment-16293102
 ] 

Joseph Witt commented on NIFI-4697:
---

Given these two lines I'd assume it would be true/accurate.

https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java#L159

https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java#L481


Could you provide a unit test or something showing it is broken?


> PostHTTP: correct documentation
> ---
>
> Key: NIFI-4697
> URL: https://issues.apache.org/jira/browse/NIFI-4697
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Brandon DeVries
>Priority: Minor
>
> The description of the URL property of PostHTTP says 
> "The URL to POST to. The first part of the URL must be static. However, the 
> path of the URL may be defined using the Attribute Expression Language. "  
> This does not appear to be true.  We should modify to something like "The URL 
> to POST to."
> ...or, someone can point out to me why I'm wrong in saying it's wrong...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)